[jira] [Commented] (OFBIZ-6234) catalog main page show freemarker exception

2015-04-09 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14486915#comment-14486915
 ] 

Jacques Le Roux commented on OFBIZ-6234:


Weirdly I had that fixed in the custom project where I 1st implemented the 
tabindex but did not backport this fix :/ I will check further...

 catalog main page show freemarker exception
 ---

 Key: OFBIZ-6234
 URL: https://issues.apache.org/jira/browse/OFBIZ-6234
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Reporter: Wai
Assignee: Jacques Le Roux
 Fix For: Upcoming Branch


 go to ... https://localhost:8443/catalog/control/main
 console output...
 2015-04-08 14:31:32,760 |http-bio-8443-exec-3 |ServiceDispatcher 
 |T| Sync service [catalog/getVisualThemeResources] finished in [1] 
 milliseconds
 2015-04-08 14:31:32,887 |http-bio-8443-exec-3 |runtime   
 |E| Error executing FreeMarker template
 freemarker.core._MiscTemplateException: Can't compare values of these types. 
 Allowed comparisons are between two numbers, two strings, two dates, or two 
 booleans.
 Left hand operand is a boolean (wrapper: f.t.TrueTemplateBooleanModel).
 Right hand operand is a string (wrapper: f.t.SimpleScalar).
 The blamed expression:
 == presentation == window  [in template 
 component://widget/templates/htmlFormMacroLibrary.ftl at line 664, column 
 42]
 
 FTL stack trace (~ means nesting-related):
   - Failed at: #elseif presentation?has_content  p...  [in template 
 component://widget/templates/htmlFormMacroLibrary.ftl in macro 
 renderLookupField at line 664, column 5]
   - Reached through: @renderLookupField name, formName, fi...  [in 
 template component://common/webcommon/includes/htmlTemplate.ftl in macro 
 lookupField at line 40, column 5]
   - Reached through: @htmlTemplate.lookupField value=\${r...  [in 
 template component://product/webapp/catalog/find/keywordsearchbox.ftl at 
 line 43, column 7]
 
   at freemarker.core.EvalUtil.compare(EvalUtil.java:300) 
 ~[freemarker-2.3.22.jar:2.3.22]
   at freemarker.core.EvalUtil.compare(EvalUtil.java:112) 
 ~[freemarker-2.3.22.jar:2.3.22]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-5035) Special characters (latin, accent ...) are in error from an input (search, contact us ...)

2015-04-09 Thread Jacopo Cappellato (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-5035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato closed OFBIZ-5035.

Resolution: Fixed

This is now fixed with the following revisions:
* trunk: 1672430
* 14.12: 1672457
* 13.07: 1672465


 Special characters (latin, accent ...) are in error from an input (search, 
 contact us ...)
 --

 Key: OFBIZ-5035
 URL: https://issues.apache.org/jira/browse/OFBIZ-5035
 Project: OFBiz
  Issue Type: Bug
  Components: ALL COMPONENTS
Affects Versions: Trunk, 12.04.04, 12.04.05, 13.07.01
 Environment: trunk-r1384251
Reporter: Eric de Maulde
Assignee: Jacopo Cappellato
Priority: Critical
 Fix For: 14.12.01, 13.07.02, Upcoming Branch

 Attachments: OFBIZ-5035.patch, OFBIZ-5035.patch, OFBIZ-5035.patch


 When a user tapes a special character on a search field or a contact us 
 field, OFBiz sends back a wrong character.
 Try on : http://demo-trunk.ofbiz.apache.org/ecommerce
 This error doesn't appear on old stable version : 10.04  09.04
 http://demo-stable.ofbiz.apache.org/ecommerce
 http://demo-old.ofbiz.apache.org/ecommerce
 *Note that this is not an issue in the ecomseo webapp which has specifically 
 fixed this issue.*



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-6238) Give the order notification email attachment the orderId as filename

2015-04-09 Thread Martin Becker (JIRA)
Martin Becker created OFBIZ-6238:


 Summary: Give the order notification email attachment the orderId 
as filename
 Key: OFBIZ-6238
 URL: https://issues.apache.org/jira/browse/OFBIZ-6238
 Project: OFBiz
  Issue Type: Improvement
  Components: order
Affects Versions: Trunk
Reporter: Martin Becker
Priority: Trivial


According to customer needs I've made a change to 
OrderServices.sendOrderNotificationScreen to fill the attachmentName parameter 
of the sendMailFromScreen context with the orderId to override the default in 
sendMailFromScreen, so that the PDF attachments in standard order notifications 
have a name like WS10001.pdf instead of Details.pdf



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Reopened] (OFBIZ-6234) catalog main page show freemarker exception

2015-04-09 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reopened OFBIZ-6234:


Oops wrong, forgot to login :D

 catalog main page show freemarker exception
 ---

 Key: OFBIZ-6234
 URL: https://issues.apache.org/jira/browse/OFBIZ-6234
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Reporter: Wai
Assignee: Jacques Le Roux

 go to ... https://localhost:8443/catalog/control/main
 console output...
 2015-04-08 14:31:32,760 |http-bio-8443-exec-3 |ServiceDispatcher 
 |T| Sync service [catalog/getVisualThemeResources] finished in [1] 
 milliseconds
 2015-04-08 14:31:32,887 |http-bio-8443-exec-3 |runtime   
 |E| Error executing FreeMarker template
 freemarker.core._MiscTemplateException: Can't compare values of these types. 
 Allowed comparisons are between two numbers, two strings, two dates, or two 
 booleans.
 Left hand operand is a boolean (wrapper: f.t.TrueTemplateBooleanModel).
 Right hand operand is a string (wrapper: f.t.SimpleScalar).
 The blamed expression:
 == presentation == window  [in template 
 component://widget/templates/htmlFormMacroLibrary.ftl at line 664, column 
 42]
 
 FTL stack trace (~ means nesting-related):
   - Failed at: #elseif presentation?has_content  p...  [in template 
 component://widget/templates/htmlFormMacroLibrary.ftl in macro 
 renderLookupField at line 664, column 5]
   - Reached through: @renderLookupField name, formName, fi...  [in 
 template component://common/webcommon/includes/htmlTemplate.ftl in macro 
 lookupField at line 40, column 5]
   - Reached through: @htmlTemplate.lookupField value=\${r...  [in 
 template component://product/webapp/catalog/find/keywordsearchbox.ftl at 
 line 43, column 7]
 
   at freemarker.core.EvalUtil.compare(EvalUtil.java:300) 
 ~[freemarker-2.3.22.jar:2.3.22]
   at freemarker.core.EvalUtil.compare(EvalUtil.java:112) 
 ~[freemarker-2.3.22.jar:2.3.22]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


buildbot success in ASF Buildbot on ofbiz-branch14

2015-04-09 Thread buildbot
The Buildbot has detected a restored build on builder ofbiz-branch14 while 
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/ofbiz-branch14/builds/91

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: lares_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-ofbiz14-commit' 
triggered this build
Build Source Stamp: [branch ofbiz/branches/release14.12] 1672457
Blamelist: jacopoc

Build succeeded!

Sincerely,
 -The Buildbot





[jira] [Closed] (OFBIZ-6234) catalog main page show freemarker exception

2015-04-09 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-6234.
--
Resolution: Cannot Reproduce

I cannot reproduce, are you sure you are using trunk head?

 catalog main page show freemarker exception
 ---

 Key: OFBIZ-6234
 URL: https://issues.apache.org/jira/browse/OFBIZ-6234
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Reporter: Wai
Assignee: Jacques Le Roux

 go to ... https://localhost:8443/catalog/control/main
 console output...
 2015-04-08 14:31:32,760 |http-bio-8443-exec-3 |ServiceDispatcher 
 |T| Sync service [catalog/getVisualThemeResources] finished in [1] 
 milliseconds
 2015-04-08 14:31:32,887 |http-bio-8443-exec-3 |runtime   
 |E| Error executing FreeMarker template
 freemarker.core._MiscTemplateException: Can't compare values of these types. 
 Allowed comparisons are between two numbers, two strings, two dates, or two 
 booleans.
 Left hand operand is a boolean (wrapper: f.t.TrueTemplateBooleanModel).
 Right hand operand is a string (wrapper: f.t.SimpleScalar).
 The blamed expression:
 == presentation == window  [in template 
 component://widget/templates/htmlFormMacroLibrary.ftl at line 664, column 
 42]
 
 FTL stack trace (~ means nesting-related):
   - Failed at: #elseif presentation?has_content  p...  [in template 
 component://widget/templates/htmlFormMacroLibrary.ftl in macro 
 renderLookupField at line 664, column 5]
   - Reached through: @renderLookupField name, formName, fi...  [in 
 template component://common/webcommon/includes/htmlTemplate.ftl in macro 
 lookupField at line 40, column 5]
   - Reached through: @htmlTemplate.lookupField value=\${r...  [in 
 template component://product/webapp/catalog/find/keywordsearchbox.ftl at 
 line 43, column 7]
 
   at freemarker.core.EvalUtil.compare(EvalUtil.java:300) 
 ~[freemarker-2.3.22.jar:2.3.22]
   at freemarker.core.EvalUtil.compare(EvalUtil.java:112) 
 ~[freemarker-2.3.22.jar:2.3.22]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[VOTE] [RELEASE] Apache OFBiz 13.07.02

2015-04-09 Thread Jacopo Cappellato
Let's try to do a release just in time for ApacheCon US! It would be nice to do 
the announcement during the conference.

This is the vote thread to release a new bug fix release for the release13.07 
branch. This new release, Apache OFBiz 13.07.02 will supersede the previous 
release from the same branch.
The release files can be downloaded from here:

https://dist.apache.org/repos/dist/dev/ofbiz/

and are:

* apache-ofbiz-13.07.02.zip
* KEYS: text file with keys
* apache-ofbiz-13.07.02.zip.asc: the detached signature file
* apache-ofbiz-13.07.02.zip.md5, apache-ofbiz-13.07.02.zip.sha: hashes

Please download and test the zip file and its signatures (for instructions on 
testing the signatures see http://www.apache.org/info/verification.html).

Vote:

[ +1] release as Apache OFBiz 13.07.02
[ -1] do not release

This vote will be open for at least 3 days.
For more details about this process please read 
http://www.apache.org/foundation/voting.html

Kind Regards,

Jacopo

[jira] [Updated] (OFBIZ-6066) Tenant specific components are visible/accessible in any tenant instance

2015-04-09 Thread Jacopo Cappellato (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-6066:
-
Affects Version/s: (was: 14.12.01)

 Tenant specific components are visible/accessible in any tenant instance
 

 Key: OFBIZ-6066
 URL: https://issues.apache.org/jira/browse/OFBIZ-6066
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: Release Branch 14.12, Trunk
Reporter: Pierre Smits
Priority: Blocker
  Labels: component, tenant

 Tenant specific components should only be visible/accessible by users of the 
 specified tenant. 
 However, because data of the tenant specific component can be loaded into any 
 tenant (including the master rmdbs) through ./ant load-data or via the import 
 function of webtools, the tenant specific component is exposed to all



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-6237) function linkGeos deletes existing GeoAssocs for geoId

2015-04-09 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-6237:
--

Assignee: Jacques Le Roux

 function linkGeos deletes existing GeoAssocs for geoId
 --

 Key: OFBIZ-6237
 URL: https://issues.apache.org/jira/browse/OFBIZ-6237
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: Trunk
Reporter: Pierre Smits
Assignee: Jacques Le Roux
  Labels: Geolocation

 When creating a new GeoAssoc between a geoId and a geoIdTo all existing 
 GeoAssocs for the geoId are removed. It should however check for existence 
 and add if it doesn't exist.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6217) fix warnings in trunk on java source code

2015-04-09 Thread Taher Alkhateeb (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14488155#comment-14488155
 ] 

Taher Alkhateeb commented on OFBIZ-6217:


Hi Jacques,

It seems interesting that my patch is now eight days old and fixing over a 
hundred warnings in trunk and it is not yet applied. What is the strategy on 
applying patches? What is the normal expected number of days for a commit to 
enter the system? How should we setup our expectations and / or reminders 
accordingly?

I feel both confused and disappointed for not being able to work on the system 
easily or quickly. If commits are slow to incorporate to trunk which are 
trivial, I wonder if I can ever push anything significant.

 fix warnings in trunk on java source code
 -

 Key: OFBIZ-6217
 URL: https://issues.apache.org/jira/browse/OFBIZ-6217
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL COMPONENTS
Affects Versions: Trunk
Reporter: Taher Alkhateeb
Assignee: Adrian Crum
Priority: Minor
  Labels: java, warning
 Fix For: Upcoming Branch

 Attachments: remove_unused_imports.patch, warnings_patch_2.patch, 
 warnings_patch_2.patch


 Right now, we have 528 warnings on trunk out of which 238 are about raw types 
 and 118 never used imports. So we can already eliminate most of the warning 
 quite quickly.
 I will issue multiple patches to resolve most of these warnings. It might be 
 a bit of a challenge to eliminate the raw types because the generics are not 
 always deducable from the code especially when relying on external APIs



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6235) Have FlexibleStringExpander applied to scripts in screens

2015-04-09 Thread Adrian Crum (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adrian Crum updated OFBIZ-6235:
---
Priority: Minor  (was: Major)

 Have FlexibleStringExpander applied to scripts in screens
 -

 Key: OFBIZ-6235
 URL: https://issues.apache.org/jira/browse/OFBIZ-6235
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: Trunk
Reporter: Pierre Smits
Priority: Minor

 Currently the FlexibleStringExpander is applied when a ${value} is included 
 in various elements in screens and forms.
 However it isn't possible to use a ${value} in the name or location of a 
 script. Having this would make screens and forms more flexible.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6235) Have FlexibleStringExpander applied to scripts in screens

2015-04-09 Thread Adrian Crum (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adrian Crum updated OFBIZ-6235:
---
Issue Type: Improvement  (was: Bug)

 Have FlexibleStringExpander applied to scripts in screens
 -

 Key: OFBIZ-6235
 URL: https://issues.apache.org/jira/browse/OFBIZ-6235
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: Trunk
Reporter: Pierre Smits

 Currently the FlexibleStringExpander is applied when a ${value} is included 
 in various elements in screens and forms.
 However it isn't possible to use a ${value} in the name or location of a 
 script. Having this would make screens and forms more flexible.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


buildbot success in ASF Buildbot on ofbiz-branch13

2015-04-09 Thread buildbot
The Buildbot has detected a restored build on builder ofbiz-branch13 while 
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/ofbiz-branch13/builds/279

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: lares_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-ofbiz13-commit' 
triggered this build
Build Source Stamp: [branch ofbiz/branches/release13.07] 1672429
Blamelist: jacopoc

Build succeeded!

Sincerely,
 -The Buildbot





[jira] [Comment Edited] (OFBIZ-6232) Adds HTML tabindex into widget form fields

2015-04-09 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14481079#comment-14481079
 ] 

Jacques Le Roux edited comment on OFBIZ-6232 at 4/9/15 7:40 AM:


Implemented at revisions: 1671500  + 1671519 + 1671756  + 1671847 + 1672252.



was (Author: jacques.le.roux):
Implemented at revisions: 1671500  + 1671519 + 1671756  + 1671847


 Adds HTML tabindex into widget form fields
 --

 Key: OFBIZ-6232
 URL: https://issues.apache.org/jira/browse/OFBIZ-6232
 Project: OFBiz
  Issue Type: New Feature
  Components: framework
Affects Versions: Trunk
Reporter: Jacques Le Roux
Assignee: Jacques Le Roux
Priority: Minor
 Fix For: Upcoming Branch


 To allow to set the tab order of elements (when the tab button is used for 
 navigating). For instance by column, when columns are used with the position 
 attribute.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-6234) catalog main page show freemarker exception

2015-04-09 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-6234.
--
   Resolution: Fixed
Fix Version/s: Upcoming Branch

Thanks Wai, fixed at revision 1672252.

 catalog main page show freemarker exception
 ---

 Key: OFBIZ-6234
 URL: https://issues.apache.org/jira/browse/OFBIZ-6234
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Reporter: Wai
Assignee: Jacques Le Roux
 Fix For: Upcoming Branch


 go to ... https://localhost:8443/catalog/control/main
 console output...
 2015-04-08 14:31:32,760 |http-bio-8443-exec-3 |ServiceDispatcher 
 |T| Sync service [catalog/getVisualThemeResources] finished in [1] 
 milliseconds
 2015-04-08 14:31:32,887 |http-bio-8443-exec-3 |runtime   
 |E| Error executing FreeMarker template
 freemarker.core._MiscTemplateException: Can't compare values of these types. 
 Allowed comparisons are between two numbers, two strings, two dates, or two 
 booleans.
 Left hand operand is a boolean (wrapper: f.t.TrueTemplateBooleanModel).
 Right hand operand is a string (wrapper: f.t.SimpleScalar).
 The blamed expression:
 == presentation == window  [in template 
 component://widget/templates/htmlFormMacroLibrary.ftl at line 664, column 
 42]
 
 FTL stack trace (~ means nesting-related):
   - Failed at: #elseif presentation?has_content  p...  [in template 
 component://widget/templates/htmlFormMacroLibrary.ftl in macro 
 renderLookupField at line 664, column 5]
   - Reached through: @renderLookupField name, formName, fi...  [in 
 template component://common/webcommon/includes/htmlTemplate.ftl in macro 
 lookupField at line 40, column 5]
   - Reached through: @htmlTemplate.lookupField value=\${r...  [in 
 template component://product/webapp/catalog/find/keywordsearchbox.ftl at 
 line 43, column 7]
 
   at freemarker.core.EvalUtil.compare(EvalUtil.java:300) 
 ~[freemarker-2.3.22.jar:2.3.22]
   at freemarker.core.EvalUtil.compare(EvalUtil.java:112) 
 ~[freemarker-2.3.22.jar:2.3.22]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-6236) Integration of OFBiz and Magento ecommerce for providing Order Management support

2015-04-09 Thread Arun Patidar (JIRA)
Arun Patidar created OFBIZ-6236:
---

 Summary: Integration of OFBiz and Magento ecommerce for providing 
Order Management support
 Key: OFBIZ-6236
 URL: https://issues.apache.org/jira/browse/OFBIZ-6236
 Project: OFBiz
  Issue Type: New Feature
Affects Versions: Trunk
Reporter: Arun Patidar
Priority: Trivial


Integration of OFBiz and Magento Ecommerce for providing Order Management 
support.

We can use OFBiz ERP system for handling Magento orders work flow till 
fulfilment.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6235) Have FlexibleStringExpander applied to scripts in screens

2015-04-09 Thread Pierre Smits (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14486918#comment-14486918
 ] 

Pierre Smits commented on OFBIZ-6235:
-

True. But application of such a feature should be monitored in accordance with 
GRC procedures. As we do. And so should all.

 Have FlexibleStringExpander applied to scripts in screens
 -

 Key: OFBIZ-6235
 URL: https://issues.apache.org/jira/browse/OFBIZ-6235
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: Trunk
Reporter: Pierre Smits
Priority: Minor

 Currently the FlexibleStringExpander is applied when a ${value} is included 
 in various elements in screens and forms.
 However it isn't possible to use a ${value} in the name or location of a 
 script. Having this would make screens and forms more flexible.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6217) fix warnings in trunk on java source code

2015-04-09 Thread Adrian Crum (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14488322#comment-14488322
 ] 

Adrian Crum commented on OFBIZ-6217:


I will look at this after ApacheCon.

 fix warnings in trunk on java source code
 -

 Key: OFBIZ-6217
 URL: https://issues.apache.org/jira/browse/OFBIZ-6217
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL COMPONENTS
Affects Versions: Trunk
Reporter: Taher Alkhateeb
Assignee: Adrian Crum
Priority: Minor
  Labels: java, warning
 Fix For: Upcoming Branch

 Attachments: remove_unused_imports.patch, warnings_patch_2.patch, 
 warnings_patch_2.patch


 Right now, we have 528 warnings on trunk out of which 238 are about raw types 
 and 118 never used imports. So we can already eliminate most of the warning 
 quite quickly.
 I will issue multiple patches to resolve most of these warnings. It might be 
 a bit of a challenge to eliminate the raw types because the generics are not 
 always deducable from the code especially when relying on external APIs



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


buildbot exception in ASF Buildbot on ofbiz-branch14

2015-04-09 Thread buildbot
The Buildbot has detected a build exception on builder ofbiz-branch14 while 
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/ofbiz-branch14/builds/90

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: lares_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-ofbiz14-commit' 
triggered this build
Build Source Stamp: [branch ofbiz/branches/release14.12] 1672428
Blamelist: jacopoc

BUILD FAILED: exception upload_1

Sincerely,
 -The Buildbot





[jira] [Updated] (OFBIZ-5035) Special characters (latin, accent ...) are in error from an input (search, contact us ...)

2015-04-09 Thread Jacopo Cappellato (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-5035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-5035:
-
Attachment: OFBIZ-5035.patch

This patch should fix the issue.

 Special characters (latin, accent ...) are in error from an input (search, 
 contact us ...)
 --

 Key: OFBIZ-5035
 URL: https://issues.apache.org/jira/browse/OFBIZ-5035
 Project: OFBiz
  Issue Type: Bug
  Components: ALL COMPONENTS
Affects Versions: Trunk, 12.04.04, 12.04.05, 13.07.01
 Environment: trunk-r1384251
Reporter: Eric de Maulde
Assignee: Jacopo Cappellato
Priority: Critical
 Attachments: OFBIZ-5035.patch, OFBIZ-5035.patch, OFBIZ-5035.patch


 When a user tapes a special character on a search field or a contact us 
 field, OFBiz sends back a wrong character.
 Try on : http://demo-trunk.ofbiz.apache.org/ecommerce
 This error doesn't appear on old stable version : 10.04  09.04
 http://demo-stable.ofbiz.apache.org/ecommerce
 http://demo-old.ofbiz.apache.org/ecommerce
 *Note that this is not an issue in the ecomseo webapp which has specifically 
 fixed this issue.*



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-5035) Special characters (latin, accent ...) are in error from an input (search, contact us ...)

2015-04-09 Thread Jacopo Cappellato (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-5035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-5035:
-
Fix Version/s: Upcoming Branch
   13.07.02
   14.12.01

 Special characters (latin, accent ...) are in error from an input (search, 
 contact us ...)
 --

 Key: OFBIZ-5035
 URL: https://issues.apache.org/jira/browse/OFBIZ-5035
 Project: OFBiz
  Issue Type: Bug
  Components: ALL COMPONENTS
Affects Versions: Trunk, 12.04.04, 12.04.05, 13.07.01
 Environment: trunk-r1384251
Reporter: Eric de Maulde
Assignee: Jacopo Cappellato
Priority: Critical
 Fix For: 14.12.01, 13.07.02, Upcoming Branch

 Attachments: OFBIZ-5035.patch, OFBIZ-5035.patch, OFBIZ-5035.patch


 When a user tapes a special character on a search field or a contact us 
 field, OFBiz sends back a wrong character.
 Try on : http://demo-trunk.ofbiz.apache.org/ecommerce
 This error doesn't appear on old stable version : 10.04  09.04
 http://demo-stable.ofbiz.apache.org/ecommerce
 http://demo-old.ofbiz.apache.org/ecommerce
 *Note that this is not an issue in the ecomseo webapp which has specifically 
 fixed this issue.*



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6235) Have FlexibleStringExpander applied to scripts in screens

2015-04-09 Thread Adrian Crum (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14486848#comment-14486848
 ] 

Adrian Crum commented on OFBIZ-6235:


A feature like that could be used as an attack vector.

 Have FlexibleStringExpander applied to scripts in screens
 -

 Key: OFBIZ-6235
 URL: https://issues.apache.org/jira/browse/OFBIZ-6235
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: Trunk
Reporter: Pierre Smits
Priority: Minor

 Currently the FlexibleStringExpander is applied when a ${value} is included 
 in various elements in screens and forms.
 However it isn't possible to use a ${value} in the name or location of a 
 script. Having this would make screens and forms more flexible.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-6237) function linkGeos deletes existing GeoAssocs for geoId

2015-04-09 Thread Pierre Smits (JIRA)
Pierre Smits created OFBIZ-6237:
---

 Summary: function linkGeos deletes existing GeoAssocs for geoId
 Key: OFBIZ-6237
 URL: https://issues.apache.org/jira/browse/OFBIZ-6237
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: Trunk
Reporter: Pierre Smits


When creating a new GeoAssoc between a geoId and a geoIdTo all existing 
GeoAssocs for the geoId are removed. It should however check for existence and 
add if it doesn't exist.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6237) function linkGeos deletes existing GeoAssocs for geoId

2015-04-09 Thread Pierre Smits (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-6237:

Labels: Geolocation  (was: )

 function linkGeos deletes existing GeoAssocs for geoId
 --

 Key: OFBIZ-6237
 URL: https://issues.apache.org/jira/browse/OFBIZ-6237
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: Trunk
Reporter: Pierre Smits
  Labels: Geolocation

 When creating a new GeoAssoc between a geoId and a geoIdTo all existing 
 GeoAssocs for the geoId are removed. It should however check for existence 
 and add if it doesn't exist.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6238) Give the order notification email attachment the orderId as filename

2015-04-09 Thread Martin Becker (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Becker updated OFBIZ-6238:
-
Attachment: OrderServices.patch

Patch for OrderServices.java

 Give the order notification email attachment the orderId as filename
 

 Key: OFBIZ-6238
 URL: https://issues.apache.org/jira/browse/OFBIZ-6238
 Project: OFBiz
  Issue Type: Improvement
  Components: order
Affects Versions: Trunk
Reporter: Martin Becker
Priority: Trivial
 Attachments: OrderServices.patch


 According to customer needs I've made a change to 
 OrderServices.sendOrderNotificationScreen to fill the attachmentName 
 parameter of the sendMailFromScreen context with the orderId to override the 
 default in sendMailFromScreen, so that the PDF attachments in standard order 
 notifications have a name like WS10001.pdf instead of Details.pdf



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)