Re: svn commit: r1672752 [1/18] - in /ofbiz/trunk: applications/accounting/src/org/ofbiz/accounting/agreement/ applications/accounting/src/org/ofbiz/accounting/finaccount/ applications/accounting/src/

2015-04-11 Thread Adrian Crum
This should be fine, but there might be cases where a LinkedHashMap is 
needed.


Adrian Crum
Sandglass Software
www.sandglass-software.com

On 4/10/2015 9:22 PM, nma...@apache.org wrote:

Author: nmalin
Date: Fri Apr 10 20:22:54 2015
New Revision: 1672752

URL: http://svn.apache.org/r1672752
Log:
Convert javolution FastMap, FastSet and FastList by standard java.util.*
Related to OFBIZ-5781 Convert Javolution collections into Java collections
Thanks to Deepak Dixit and Adrian Crum for their help.

By defautl converted :
  * FastMap by HashMap
  * FastList by LinkedList
  * FastSet by HashSet

Modified:
 
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/agreement/AgreementServices.java
 
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/finaccount/FinAccountPaymentServices.java
 
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/finaccount/FinAccountProductServices.java
 
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/finaccount/FinAccountServices.java
 
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/invoice/InvoiceServices.java
 
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/invoice/InvoiceWorker.java
 
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/payment/BillingAccountWorker.java
 
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/payment/GiftCertificateServices.java
 
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/payment/PaymentGatewayServices.java
 
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/payment/PaymentMethodServices.java
 
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/payment/PaymentWorker.java
 
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/tax/TaxAuthorityServices.java
 
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/authorizedotnet/AIMPaymentServices.java
 
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/authorizedotnet/AIMRespPositions.java
 
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/authorizedotnet/CPRespPositions.java
 
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/cybersource/IcsPaymentServices.java
 
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/gosoftware/RitaApi.java
 
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/ideal/IdealEvents.java
 
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/orbital/OrbitalPaymentServices.java
 
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/PayPalServices.java
 
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/sagepay/SagePayPaymentServices.java
 
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/sagepay/SagePayUtil.java
 
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/valuelink/ValueLinkApi.java
 
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/valuelink/ValueLinkServices.java
 
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/verisign/PayflowPro.java
 
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/worldpay/WorldPayEvents.java
 
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/util/UtilAccounting.java
 
ofbiz/trunk/applications/accounting/webapp/accounting/WEB-INF/actions/chartofaccounts/TaxAuthorityGlAccounts.groovy
 
ofbiz/trunk/applications/accounting/webapp/accounting/WEB-INF/actions/invoice/EditInvoice.groovy
 
ofbiz/trunk/applications/accounting/webapp/accounting/WEB-INF/actions/invoice/GetAccountOrganizationAndClass.groovy
 
ofbiz/trunk/applications/accounting/webapp/accounting/WEB-INF/actions/invoice/InvoiceReport.groovy
 
ofbiz/trunk/applications/accounting/webapp/accounting/WEB-INF/actions/order/BillingAccountOrders.groovy
 
ofbiz/trunk/applications/accounting/webapp/accounting/WEB-INF/actions/reports/BalanceSheet.groovy
 
ofbiz/trunk/applications/accounting/webapp/accounting/WEB-INF/actions/reports/CashFlowStatement.groovy
 
ofbiz/trunk/applications/accounting/webapp/accounting/WEB-INF/actions/reports/CostCenters.groovy
 
ofbiz/trunk/applications/accounting/webapp/accounting/WEB-INF/actions/reports/IncomeStatement.groovy
 
ofbiz/trunk/applications/accounting/webapp/accounting/WEB-INF/actions/reports/SalesInvoiceByProductCategorySummary.groovy
 
ofbiz/trunk/applications/accounting/webapp/accounting/WEB-INF/actions/reports/TransactionTotals.groovy
 
ofbiz/trunk/applications/commonext/webapp/ofbizsetup/WEB-INF/actions/GetProdCatalog.groovy
 
ofbiz/trunk/applications/commonext/webapp/ofbizsetup/WEB-INF/actions/GetProductStoreAndWebSite.groovy
 
ofbiz/trunk/applications/content/script/org/ofbiz/content/content/ContentServices.xml
 ofbiz/trunk/applications/content/

[jira] [Assigned] (OFBIZ-6205) Use EntityUtilProperties to get the WebSiteProperties

2015-04-11 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit reassigned OFBIZ-6205:
---

Assignee: Deepak Dixit

> Use EntityUtilProperties to get the WebSiteProperties
> -
>
> Key: OFBIZ-6205
> URL: https://issues.apache.org/jira/browse/OFBIZ-6205
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Release 
> Branch 14.12, Trunk
>Reporter: Arun Patidar
>Assignee: Deepak Dixit
>Priority: Critical
> Attachments: OFBIZ-6205.patch
>
>
> Use EntityUtilProperties to get the WebSiteProperties, As per current 
> implementation its using UtilProperties and its affecting the multitenant 
> environment.
> Wrong https url creation for a tenant in multi-tenant environment. Its 
> redirecting to default instance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6205) Use EntityUtilProperties to get the WebSiteProperties

2015-04-11 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490883#comment-14490883
 ] 

Deepak Dixit commented on OFBIZ-6205:
-

Thanks Arun your changes has been committed at
Trunk at r#1672846
14.12 at r#1672848
13.07 at r#1672849

EntityUtilProperties implementation exists for 13.07 branches as well, so 
committing patch for trunk and related branches.
As Jacopo said will convert all EntityUtilProperties implementation at once 
into EntityClassLoader when we are sure about performance impact.

> Use EntityUtilProperties to get the WebSiteProperties
> -
>
> Key: OFBIZ-6205
> URL: https://issues.apache.org/jira/browse/OFBIZ-6205
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Release 
> Branch 14.12, Trunk
>Reporter: Arun Patidar
>Assignee: Deepak Dixit
>Priority: Critical
> Attachments: OFBIZ-6205.patch
>
>
> Use EntityUtilProperties to get the WebSiteProperties, As per current 
> implementation its using UtilProperties and its affecting the multitenant 
> environment.
> Wrong https url creation for a tenant in multi-tenant environment. Its 
> redirecting to default instance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-6205) Use EntityUtilProperties to get the WebSiteProperties

2015-04-11 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit closed OFBIZ-6205.
---
   Resolution: Fixed
Fix Version/s: Upcoming Branch
   13.07.02
   14.12.01

> Use EntityUtilProperties to get the WebSiteProperties
> -
>
> Key: OFBIZ-6205
> URL: https://issues.apache.org/jira/browse/OFBIZ-6205
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Release 
> Branch 14.12, Trunk
>Reporter: Arun Patidar
>Assignee: Deepak Dixit
>Priority: Critical
> Fix For: 14.12.01, 13.07.02, Upcoming Branch
>
> Attachments: OFBIZ-6205.patch
>
>
> Use EntityUtilProperties to get the WebSiteProperties, As per current 
> implementation its using UtilProperties and its affecting the multitenant 
> environment.
> Wrong https url creation for a tenant in multi-tenant environment. Its 
> redirecting to default instance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: [VOTE] [RELEASE] Apache OFBiz 13.07.02

2015-04-11 Thread Deepak Dixit
+1

Jacopo could you please include r#1672849 (OFBIZ-6205) into 13.07.02
release?



Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com

On Fri, Apr 10, 2015 at 12:11 PM, Nicolas Malin 
wrote:

> +1
>
> ./ant load-demo run-tests -> BUILD SUCCESSFUL
>
> Tested archive signature :
> * MD5
> andrealphus$ flowToParse="apache-ofbiz-13.07.02.zip.md5"; echo "$(cat
> $flowToParse | tr -d [:space:] | cut -f 2 -d ':') $(cat $flowToParse |  tr
> -d [:space:] | cut -f 1 -d ':' | tr -d [:space:])" > tmp.hash; md5sum -c
> tmp.hash ;
> apache-ofbiz-13.07.02.zip: Réussi
>
> * SHA
> andrealphus$ flowToParse="apache-ofbiz-13.07.02.zip.sha"; echo "$(cat
> $flowToParse | tr -d [:space:] | cut -f 2 -d ':') $(cat $flowToParse |  tr
> -d [:space:] | cut -f 1 -d ':' | tr -d [:space:])" > tmp.hash; sha512sum -c
> tmp.hash ;
> apache-ofbiz-13.07.02.zip: Réussi
>
> Nicolas
>
> Le 09/04/2015 22:48, Jacopo Cappellato a écrit :
>
>> Let's try to do a release just in time for ApacheCon US! It would be nice
>> to do the announcement during the conference.
>>
>> This is the vote thread to release a new bug fix release for the
>> release13.07 branch. This new release, "Apache OFBiz 13.07.02" will
>> supersede the previous release from the same branch.
>> The release files can be downloaded from here:
>>
>> https://dist.apache.org/repos/dist/dev/ofbiz/
>>
>> and are:
>>
>> * apache-ofbiz-13.07.02.zip
>> * KEYS: text file with keys
>> * apache-ofbiz-13.07.02.zip.asc: the detached signature file
>> * apache-ofbiz-13.07.02.zip.md5, apache-ofbiz-13.07.02.zip.sha: hashes
>>
>> Please download and test the zip file and its signatures (for
>> instructions on testing the signatures see http://www.apache.org/info/
>> verification.html).
>>
>> Vote:
>>
>> [ +1] release as Apache OFBiz 13.07.02
>> [ -1] do not release
>>
>> This vote will be open for at least 3 days.
>> For more details about this process please read http://www.apache.org/
>> foundation/voting.html
>>
>> Kind Regards,
>>
>> Jacopo
>>
>
>


[jira] [Commented] (OFBIZ-6226) Webpos F4-F11 label mismatch

2015-04-11 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490884#comment-14490884
 ] 

Deepak Dixit commented on OFBIZ-6226:
-

Hi  Christian Carlow,

Can use rearrange  the function key instead of changing the UiLabels or can 
update the UiLabel as well?
As its confusing to use uiLabelMap.WebPosShortcutF6 for shourtcust key f5 and 
similar for other keys.

> Webpos F4-F11 label mismatch
> 
>
> Key: OFBIZ-6226
> URL: https://issues.apache.org/jira/browse/OFBIZ-6226
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/webpos
>Affects Versions: Trunk
>Reporter: Christian Carlow
> Attachments: OFBIZ-6226.patch
>
>
> At webpos/control/Login the payGiftCard F4 button incorrectly uses label 
> WebPosShortcutF5 (Pay Pin) when it should be using WebPosShortcutF6.  The 
> same mismatch applies to all buttons higher than F4 and should be incremented 
> by 1 as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-6222) Change the field name 'tenantId' to 'userTenantId' from login page and ContextFilter

2015-04-11 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit reassigned OFBIZ-6222:
---

Assignee: Deepak Dixit

> Change the field name 'tenantId' to 'userTenantId' from login page and 
> ContextFilter
> 
>
> Key: OFBIZ-6222
> URL: https://issues.apache.org/jira/browse/OFBIZ-6222
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Reporter: Arun Patidar
>Assignee: Deepak Dixit
>Priority: Critical
> Fix For: Release Branch 14.12, Trunk
>
> Attachments: OFBIZ-6222.patch
>
>
> Change the field name 'tenantId' to 'userTenantId' from login page and 
> ContextFilter
> While using webtools for tenantGroup and searching with a tenantId then its 
> interpreting it as tenantId in request and switching delegator for it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6222) Change the field name 'tenantId' to 'userTenantId' from login page and ContextFilter

2015-04-11 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-6222:

Affects Version/s: Release Branch 14.12
   Trunk

> Change the field name 'tenantId' to 'userTenantId' from login page and 
> ContextFilter
> 
>
> Key: OFBIZ-6222
> URL: https://issues.apache.org/jira/browse/OFBIZ-6222
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Release Branch 14.12, Trunk
>Reporter: Arun Patidar
>Assignee: Deepak Dixit
>Priority: Critical
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6222.patch
>
>
> Change the field name 'tenantId' to 'userTenantId' from login page and 
> ContextFilter
> While using webtools for tenantGroup and searching with a tenantId then its 
> interpreting it as tenantId in request and switching delegator for it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6222) Change the field name 'tenantId' to 'userTenantId' from login page and ContextFilter

2015-04-11 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-6222:

Fix Version/s: (was: Release Branch 14.12)
   (was: Trunk)
   Upcoming Branch
   14.12.01

> Change the field name 'tenantId' to 'userTenantId' from login page and 
> ContextFilter
> 
>
> Key: OFBIZ-6222
> URL: https://issues.apache.org/jira/browse/OFBIZ-6222
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Release Branch 14.12, Trunk
>Reporter: Arun Patidar
>Assignee: Deepak Dixit
>Priority: Critical
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6222.patch
>
>
> Change the field name 'tenantId' to 'userTenantId' from login page and 
> ContextFilter
> While using webtools for tenantGroup and searching with a tenantId then its 
> interpreting it as tenantId in request and switching delegator for it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6222) Change the field name 'tenantId' to 'userTenantId' from login page and ContextFilter

2015-04-11 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490895#comment-14490895
 ] 

Deepak Dixit commented on OFBIZ-6222:
-

Thanks Arun Patidar for your contribution. 
Your patch has been committed in following revision:

Trunk  at r#1672853
14.12 at r#1672854

> Change the field name 'tenantId' to 'userTenantId' from login page and 
> ContextFilter
> 
>
> Key: OFBIZ-6222
> URL: https://issues.apache.org/jira/browse/OFBIZ-6222
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Release Branch 14.12, Trunk
>Reporter: Arun Patidar
>Assignee: Deepak Dixit
>Priority: Critical
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6222.patch
>
>
> Change the field name 'tenantId' to 'userTenantId' from login page and 
> ContextFilter
> While using webtools for tenantGroup and searching with a tenantId then its 
> interpreting it as tenantId in request and switching delegator for it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (OFBIZ-6222) Change the field name 'tenantId' to 'userTenantId' from login page and ContextFilter

2015-04-11 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit resolved OFBIZ-6222.
-
Resolution: Fixed

> Change the field name 'tenantId' to 'userTenantId' from login page and 
> ContextFilter
> 
>
> Key: OFBIZ-6222
> URL: https://issues.apache.org/jira/browse/OFBIZ-6222
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Release Branch 14.12, Trunk
>Reporter: Arun Patidar
>Assignee: Deepak Dixit
>Priority: Critical
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6222.patch
>
>
> Change the field name 'tenantId' to 'userTenantId' from login page and 
> ContextFilter
> While using webtools for tenantGroup and searching with a tenantId then its 
> interpreting it as tenantId in request and switching delegator for it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-6222) Change the field name 'tenantId' to 'userTenantId' from login page and ContextFilter

2015-04-11 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit closed OFBIZ-6222.
---

> Change the field name 'tenantId' to 'userTenantId' from login page and 
> ContextFilter
> 
>
> Key: OFBIZ-6222
> URL: https://issues.apache.org/jira/browse/OFBIZ-6222
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Release Branch 14.12, Trunk
>Reporter: Arun Patidar
>Assignee: Deepak Dixit
>Priority: Critical
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6222.patch
>
>
> Change the field name 'tenantId' to 'userTenantId' from login page and 
> ContextFilter
> While using webtools for tenantGroup and searching with a tenantId then its 
> interpreting it as tenantId in request and switching delegator for it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6207) Anyone can view any Request or Quote

2015-04-11 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490897#comment-14490897
 ] 

Deepak Dixit commented on OFBIZ-6207:
-

Hi Forrest Raae,

You can pass in parameters as context-map.
Here is exa



> Anyone can view any Request or Quote
> 
>
> Key: OFBIZ-6207
> URL: https://issues.apache.org/jira/browse/OFBIZ-6207
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/ecommerce
>Affects Versions: Trunk, 13.07.01
>Reporter: Forrest Rae
>Assignee: Deepak Dixit
>Priority: Critical
>  Labels: security
> Attachments: OFBIZ-6207-fourth-attempt.patch
>
>
> This is a security bug in the ecommerce application.  Anyone can view any 
> quote or request in the system regardless of the associated partyId.  They 
> can do this via URL parameter manipulation.
> Reproduction:
> 1) Login to the ecommerce application as DemoCustomer.
> 2) Navigate to 
> http://demo-stable-ofbiz.apache.org/ecommerce/control/ViewRequest?custRequestId=9000
>  to view your own request.
> 3) Navigate to 
> http://demo-stable-ofbiz.apache.org/ecommerce/control/ViewRequest?custRequestId=9001
>  to view DemoCustAgent's request.
> 4) Navigate to 
> http://demo-stable-ofbiz.apache.org/ecommerce/control/ViewRequest?custRequestId=9002
>  to view DemoCustomer2's request.
> Same goes for Quotes, although there are no quotes in the Demo data.  The 
> attach patch fixes this issue.
> Would like this issue back ported to release 13.07 please.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6207) Anyone can view any Request or Quote

2015-04-11 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490902#comment-14490902
 ] 

Jacques Le Roux commented on OFBIZ-6207:


Forrest Raae,  did you read 
https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Security+Permissions ?

> Anyone can view any Request or Quote
> 
>
> Key: OFBIZ-6207
> URL: https://issues.apache.org/jira/browse/OFBIZ-6207
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/ecommerce
>Affects Versions: Trunk, 13.07.01
>Reporter: Forrest Rae
>Assignee: Deepak Dixit
>Priority: Critical
>  Labels: security
> Attachments: OFBIZ-6207-fourth-attempt.patch
>
>
> This is a security bug in the ecommerce application.  Anyone can view any 
> quote or request in the system regardless of the associated partyId.  They 
> can do this via URL parameter manipulation.
> Reproduction:
> 1) Login to the ecommerce application as DemoCustomer.
> 2) Navigate to 
> http://demo-stable-ofbiz.apache.org/ecommerce/control/ViewRequest?custRequestId=9000
>  to view your own request.
> 3) Navigate to 
> http://demo-stable-ofbiz.apache.org/ecommerce/control/ViewRequest?custRequestId=9001
>  to view DemoCustAgent's request.
> 4) Navigate to 
> http://demo-stable-ofbiz.apache.org/ecommerce/control/ViewRequest?custRequestId=9002
>  to view DemoCustomer2's request.
> Same goes for Quotes, although there are no quotes in the Demo data.  The 
> attach patch fixes this issue.
> Would like this issue back ported to release 13.07 please.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6207) Anyone can view any Request or Quote

2015-04-11 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490903#comment-14490903
 ] 

Deepak Dixit commented on OFBIZ-6207:
-

Hi [~adri...@hlmksw.com],

I think this is different case, In this case if any request or quote does not 
belongs to logged in user then also he can view request/quote by changing the 
id from url. 
If we add VIEW permission check then also use can able to view others 
request/quote as well.

It can't be handle by if-service-permission. 
For order view (ecommerce) logged in party id comparison has been checked in 
orderstatus.groovy. If logged in party exist in any order role then only user 
can view the order.

We can create common service to perform check if order/request/quote belongs to 
logged in part then only user can view else error message will be displayed.


> Anyone can view any Request or Quote
> 
>
> Key: OFBIZ-6207
> URL: https://issues.apache.org/jira/browse/OFBIZ-6207
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/ecommerce
>Affects Versions: Trunk, 13.07.01
>Reporter: Forrest Rae
>Assignee: Deepak Dixit
>Priority: Critical
>  Labels: security
> Attachments: OFBIZ-6207-fourth-attempt.patch
>
>
> This is a security bug in the ecommerce application.  Anyone can view any 
> quote or request in the system regardless of the associated partyId.  They 
> can do this via URL parameter manipulation.
> Reproduction:
> 1) Login to the ecommerce application as DemoCustomer.
> 2) Navigate to 
> http://demo-stable-ofbiz.apache.org/ecommerce/control/ViewRequest?custRequestId=9000
>  to view your own request.
> 3) Navigate to 
> http://demo-stable-ofbiz.apache.org/ecommerce/control/ViewRequest?custRequestId=9001
>  to view DemoCustAgent's request.
> 4) Navigate to 
> http://demo-stable-ofbiz.apache.org/ecommerce/control/ViewRequest?custRequestId=9002
>  to view DemoCustomer2's request.
> Same goes for Quotes, although there are no quotes in the Demo data.  The 
> attach patch fixes this issue.
> Would like this issue back ported to release 13.07 please.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6226) Webpos F4-F11 label mismatch

2015-04-11 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490905#comment-14490905
 ] 

Jacques Le Roux commented on OFBIZ-6226:


Also please see my last comment at OFBIZ-5241

> Webpos F4-F11 label mismatch
> 
>
> Key: OFBIZ-6226
> URL: https://issues.apache.org/jira/browse/OFBIZ-6226
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/webpos
>Affects Versions: Trunk
>Reporter: Christian Carlow
> Attachments: OFBIZ-6226.patch
>
>
> At webpos/control/Login the payGiftCard F4 button incorrectly uses label 
> WebPosShortcutF5 (Pay Pin) when it should be using WebPosShortcutF6.  The 
> same mismatch applies to all buttons higher than F4 and should be incremented 
> by 1 as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


buildbot success in ASF Buildbot on ofbiz-trunk

2015-04-11 Thread buildbot
The Buildbot has detected a restored build on builder ofbiz-trunk while 
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/ofbiz-trunk/builds/820

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: lares_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-ofbiz-commit' 
triggered this build
Build Source Stamp: [branch ofbiz/trunk] 1672846
Blamelist: deepak

Build succeeded!

Sincerely,
 -The Buildbot





[jira] [Commented] (OFBIZ-5169) Removing Javolution from framework components

2015-04-11 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490907#comment-14490907
 ] 

Jacques Le Roux commented on OFBIZ-5169:


Yes maybe a profiler session would be a plus. But I have no ideas on how much 
OFBIZ-5781 changes performances. I note here Adrian comment on dev ML about 
OFBIZ-5781 and r1672752 
{quote}
This should be fine, but there might be cases where a LinkedHashMap is needed. 
{quote}

> Removing Javolution from framework components
> -
>
> Key: OFBIZ-5169
> URL: https://issues.apache.org/jira/browse/OFBIZ-5169
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Varun Bhansaly
>Priority: Minor
> Attachments: framework-FastList-removed.patch
>
>
> a. Remove static instances of Javolution objects.
> b. Remove other uses of Javolution objects.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-6077) Error when creating a quote report

2015-04-11 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit reassigned OFBIZ-6077:
---

Assignee: Deepak Dixit

> Error when creating a quote report
> --
>
> Key: OFBIZ-6077
> URL: https://issues.apache.org/jira/browse/OFBIZ-6077
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk, 13.07.01
>Reporter: Jacques Le Roux
>Assignee: Deepak Dixit
>  Labels: quote
>
> Create a quote (w/o items), click on Report menu entry 
> ordermgr/control/QuoteReport?quoteId=CQ1
> You get this error in log
> {code}
> 2015-02-16 07:58:10,762 |http-bio-8443-exec-3 |FOUserAgent   
> |W| "fo:table-body" is missing child elements. Required content model: 
> marker* (table-row+|table-cell+) (See position 202:32)
> 2015-02-16 07:58:10,763 |http-bio-8443-exec-3 |ScreenFopViewHandler  
> |E| Unable to transform FO file: org.apache.fop.apps.FOPException
> java.lang.NullPointerException; Screen XSL:FO text was:
> {code}
> I think when you try to send the report by email you get a related error (did 
> not check). These error has been reported at OFBIZ-6076
> {code}
> 015-02-16 08:00:32,405 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 139:40)
> 015-02-16 08:00:32,407 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 161:81)
> 015-02-16 08:00:32,410 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 190:39)
> 015-02-16 08:00:32,413 |http-bio-8443-exec-9 |FOUserAgent   
> |W| "fo:table-body" is missing child elements. Required content model: 
> marker* (table-row+|table-cell+) (See position 209:32)
> 015-02-16 08:00:32,414 |http-bio-8443-exec-9 |EmailServices 
> |E| Error rendering PDF attachment for email: 
> org.apache.fop.apps.FOPExceptionava.lang.NullPointerException
> org.apache.fop.apps.FOPException
>at 
> org.ofbiz.webapp.view.ApacheFopWorker.transform(ApacheFopWorker.java:160) 
> ~[ofbiz-webapp.jar:?]
>at 
> org.ofbiz.common.email.EmailServices.sendMailFromScreen(EmailServices.java:533)
>  [ofbiz-common.jar:?]
> {code}   
> Same error with stable demo, I did not test with R14.12, but I suppose it's 
> there also. Both works in the old demo (R12.04).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


buildbot exception in ASF Buildbot on ofbiz-branch14

2015-04-11 Thread buildbot
The Buildbot has detected a build exception on builder ofbiz-branch14 while 
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/ofbiz-branch14/builds/94

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: lares_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-ofbiz14-commit' 
triggered this build
Build Source Stamp: [branch ofbiz/branches/release14.12] 1672859
Blamelist: deepak

BUILD FAILED: exception upload_1

Sincerely,
 -The Buildbot





[jira] [Created] (OFBIZ-6241) Fix fop warning related to table-layout="auto"

2015-04-11 Thread Deepak Dixit (JIRA)
Deepak Dixit created OFBIZ-6241:
---

 Summary: Fix fop warning related to table-layout="auto"
 Key: OFBIZ-6241
 URL: https://issues.apache.org/jira/browse/OFBIZ-6241
 Project: OFBiz
  Issue Type: Improvement
Affects Versions: Trunk
Reporter: Deepak Dixit
Priority: Minor


{code}
 [java] 2015-04-11 16:37:18,388 |http-bio-8443-exec-6 |FOUserAgent  
 |W| The following feature isn't implemented by Apache FOP, yet: 
table-layout="auto" (on fo:table) (See position 139:40)
 [java] 2015-04-11 16:37:18,390 |http-bio-8443-exec-6 |FOUserAgent  
 |W| The following feature isn't implemented by Apache FOP, yet: 
table-layout="auto" (on fo:table) (See position 173:81)
 [java] 2015-04-11 16:37:18,395 |http-bio-8443-exec-6 |FOUserAgent  
 |W| The following feature isn't implemented by Apache FOP, yet: 
table-layout="auto" (on fo:table) (See position 202:39)
 [java] 2015-04-11 16:37:18,398 |http-bio-8443-exec-6 |FOUserAgent  
 |W| "fo:table-body" is missing child elements. Required content model: 
marker* (table-row+|table-cell+) (See position 221:32)
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6077) Error when creating a quote report

2015-04-11 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490917#comment-14490917
 ] 

Deepak Dixit commented on OFBIZ-6077:
-

FOP throwing NPE because there is no NPE check on Quote report ft ftl for 
quoteItems .
Added has_content check now report with out item generating properly. 

Create separate issue to fix the table-layout="auto" related warning.
Thanks Jacques for reporting the issue ;)

> Error when creating a quote report
> --
>
> Key: OFBIZ-6077
> URL: https://issues.apache.org/jira/browse/OFBIZ-6077
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk, 13.07.01
>Reporter: Jacques Le Roux
>Assignee: Deepak Dixit
>  Labels: quote
>
> Create a quote (w/o items), click on Report menu entry 
> ordermgr/control/QuoteReport?quoteId=CQ1
> You get this error in log
> {code}
> 2015-02-16 07:58:10,762 |http-bio-8443-exec-3 |FOUserAgent   
> |W| "fo:table-body" is missing child elements. Required content model: 
> marker* (table-row+|table-cell+) (See position 202:32)
> 2015-02-16 07:58:10,763 |http-bio-8443-exec-3 |ScreenFopViewHandler  
> |E| Unable to transform FO file: org.apache.fop.apps.FOPException
> java.lang.NullPointerException; Screen XSL:FO text was:
> {code}
> I think when you try to send the report by email you get a related error (did 
> not check). These error has been reported at OFBIZ-6076
> {code}
> 015-02-16 08:00:32,405 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 139:40)
> 015-02-16 08:00:32,407 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 161:81)
> 015-02-16 08:00:32,410 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 190:39)
> 015-02-16 08:00:32,413 |http-bio-8443-exec-9 |FOUserAgent   
> |W| "fo:table-body" is missing child elements. Required content model: 
> marker* (table-row+|table-cell+) (See position 209:32)
> 015-02-16 08:00:32,414 |http-bio-8443-exec-9 |EmailServices 
> |E| Error rendering PDF attachment for email: 
> org.apache.fop.apps.FOPExceptionava.lang.NullPointerException
> org.apache.fop.apps.FOPException
>at 
> org.ofbiz.webapp.view.ApacheFopWorker.transform(ApacheFopWorker.java:160) 
> ~[ofbiz-webapp.jar:?]
>at 
> org.ofbiz.common.email.EmailServices.sendMailFromScreen(EmailServices.java:533)
>  [ofbiz-common.jar:?]
> {code}   
> Same error with stable demo, I did not test with R14.12, but I suppose it's 
> there also. Both works in the old demo (R12.04).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-6077) Error when creating a quote report

2015-04-11 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit closed OFBIZ-6077.
---

> Error when creating a quote report
> --
>
> Key: OFBIZ-6077
> URL: https://issues.apache.org/jira/browse/OFBIZ-6077
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk, 13.07.01
>Reporter: Jacques Le Roux
>Assignee: Deepak Dixit
>  Labels: quote
> Fix For: 14.12.01, Upcoming Branch
>
>
> Create a quote (w/o items), click on Report menu entry 
> ordermgr/control/QuoteReport?quoteId=CQ1
> You get this error in log
> {code}
> 2015-02-16 07:58:10,762 |http-bio-8443-exec-3 |FOUserAgent   
> |W| "fo:table-body" is missing child elements. Required content model: 
> marker* (table-row+|table-cell+) (See position 202:32)
> 2015-02-16 07:58:10,763 |http-bio-8443-exec-3 |ScreenFopViewHandler  
> |E| Unable to transform FO file: org.apache.fop.apps.FOPException
> java.lang.NullPointerException; Screen XSL:FO text was:
> {code}
> I think when you try to send the report by email you get a related error (did 
> not check). These error has been reported at OFBIZ-6076
> {code}
> 015-02-16 08:00:32,405 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 139:40)
> 015-02-16 08:00:32,407 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 161:81)
> 015-02-16 08:00:32,410 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 190:39)
> 015-02-16 08:00:32,413 |http-bio-8443-exec-9 |FOUserAgent   
> |W| "fo:table-body" is missing child elements. Required content model: 
> marker* (table-row+|table-cell+) (See position 209:32)
> 015-02-16 08:00:32,414 |http-bio-8443-exec-9 |EmailServices 
> |E| Error rendering PDF attachment for email: 
> org.apache.fop.apps.FOPExceptionava.lang.NullPointerException
> org.apache.fop.apps.FOPException
>at 
> org.ofbiz.webapp.view.ApacheFopWorker.transform(ApacheFopWorker.java:160) 
> ~[ofbiz-webapp.jar:?]
>at 
> org.ofbiz.common.email.EmailServices.sendMailFromScreen(EmailServices.java:533)
>  [ofbiz-common.jar:?]
> {code}   
> Same error with stable demo, I did not test with R14.12, but I suppose it's 
> there also. Both works in the old demo (R12.04).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (OFBIZ-6077) Error when creating a quote report

2015-04-11 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit resolved OFBIZ-6077.
-
   Resolution: Fixed
Fix Version/s: Upcoming Branch
   14.12.01

> Error when creating a quote report
> --
>
> Key: OFBIZ-6077
> URL: https://issues.apache.org/jira/browse/OFBIZ-6077
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk, 13.07.01
>Reporter: Jacques Le Roux
>Assignee: Deepak Dixit
>  Labels: quote
> Fix For: 14.12.01, Upcoming Branch
>
>
> Create a quote (w/o items), click on Report menu entry 
> ordermgr/control/QuoteReport?quoteId=CQ1
> You get this error in log
> {code}
> 2015-02-16 07:58:10,762 |http-bio-8443-exec-3 |FOUserAgent   
> |W| "fo:table-body" is missing child elements. Required content model: 
> marker* (table-row+|table-cell+) (See position 202:32)
> 2015-02-16 07:58:10,763 |http-bio-8443-exec-3 |ScreenFopViewHandler  
> |E| Unable to transform FO file: org.apache.fop.apps.FOPException
> java.lang.NullPointerException; Screen XSL:FO text was:
> {code}
> I think when you try to send the report by email you get a related error (did 
> not check). These error has been reported at OFBIZ-6076
> {code}
> 015-02-16 08:00:32,405 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 139:40)
> 015-02-16 08:00:32,407 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 161:81)
> 015-02-16 08:00:32,410 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 190:39)
> 015-02-16 08:00:32,413 |http-bio-8443-exec-9 |FOUserAgent   
> |W| "fo:table-body" is missing child elements. Required content model: 
> marker* (table-row+|table-cell+) (See position 209:32)
> 015-02-16 08:00:32,414 |http-bio-8443-exec-9 |EmailServices 
> |E| Error rendering PDF attachment for email: 
> org.apache.fop.apps.FOPExceptionava.lang.NullPointerException
> org.apache.fop.apps.FOPException
>at 
> org.ofbiz.webapp.view.ApacheFopWorker.transform(ApacheFopWorker.java:160) 
> ~[ofbiz-webapp.jar:?]
>at 
> org.ofbiz.common.email.EmailServices.sendMailFromScreen(EmailServices.java:533)
>  [ofbiz-common.jar:?]
> {code}   
> Same error with stable demo, I did not test with R14.12, but I suppose it's 
> there also. Both works in the old demo (R12.04).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-5169) Removing Javolution from framework components

2015-04-11 Thread Nicolas Malin (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490932#comment-14490932
 ] 

Nicolas Malin commented on OFBIZ-5169:
--

Yesterday I continue to benchmark. On the ant clean-all load-demo run-tests 
between before and after the revision r1672752 on average I win 10s.
If some body can to do it under an other plateform (I'm under linux and jdk 
1.7), it's would be great :) 

For the LinkedHashMap, yes I use it when I detected an iteration on the map. I 
will realize a second pass to check if I can found other optimization, it's 
also the case for arrayList instead of linkedList. On many case the list use 
through foreach loop, but I didn't analyze all case.
 

> Removing Javolution from framework components
> -
>
> Key: OFBIZ-5169
> URL: https://issues.apache.org/jira/browse/OFBIZ-5169
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Varun Bhansaly
>Priority: Minor
> Attachments: framework-FastList-removed.patch
>
>
> a. Remove static instances of Javolution objects.
> b. Remove other uses of Javolution objects.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Reopened] (OFBIZ-6077) Error when creating a quote report

2015-04-11 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit reopened OFBIZ-6077:
-

> Error when creating a quote report
> --
>
> Key: OFBIZ-6077
> URL: https://issues.apache.org/jira/browse/OFBIZ-6077
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk, 13.07.01
>Reporter: Jacques Le Roux
>Assignee: Deepak Dixit
>  Labels: quote
> Fix For: 14.12.01, Upcoming Branch
>
>
> Create a quote (w/o items), click on Report menu entry 
> ordermgr/control/QuoteReport?quoteId=CQ1
> You get this error in log
> {code}
> 2015-02-16 07:58:10,762 |http-bio-8443-exec-3 |FOUserAgent   
> |W| "fo:table-body" is missing child elements. Required content model: 
> marker* (table-row+|table-cell+) (See position 202:32)
> 2015-02-16 07:58:10,763 |http-bio-8443-exec-3 |ScreenFopViewHandler  
> |E| Unable to transform FO file: org.apache.fop.apps.FOPException
> java.lang.NullPointerException; Screen XSL:FO text was:
> {code}
> I think when you try to send the report by email you get a related error (did 
> not check). These error has been reported at OFBIZ-6076
> {code}
> 015-02-16 08:00:32,405 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 139:40)
> 015-02-16 08:00:32,407 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 161:81)
> 015-02-16 08:00:32,410 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 190:39)
> 015-02-16 08:00:32,413 |http-bio-8443-exec-9 |FOUserAgent   
> |W| "fo:table-body" is missing child elements. Required content model: 
> marker* (table-row+|table-cell+) (See position 209:32)
> 015-02-16 08:00:32,414 |http-bio-8443-exec-9 |EmailServices 
> |E| Error rendering PDF attachment for email: 
> org.apache.fop.apps.FOPExceptionava.lang.NullPointerException
> org.apache.fop.apps.FOPException
>at 
> org.ofbiz.webapp.view.ApacheFopWorker.transform(ApacheFopWorker.java:160) 
> ~[ofbiz-webapp.jar:?]
>at 
> org.ofbiz.common.email.EmailServices.sendMailFromScreen(EmailServices.java:533)
>  [ofbiz-common.jar:?]
> {code}   
> Same error with stable demo, I did not test with R14.12, but I suppose it's 
> there also. Both works in the old demo (R12.04).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6077) Error when creating a quote report

2015-04-11 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490961#comment-14490961
 ] 

Deepak Dixit commented on OFBIZ-6077:
-

Fixed in correct hierarchy of fo:table, and if no items found then display 
message on quote item section.

Now NPE on send report by mail should be fixed.

> Error when creating a quote report
> --
>
> Key: OFBIZ-6077
> URL: https://issues.apache.org/jira/browse/OFBIZ-6077
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk, 13.07.01
>Reporter: Jacques Le Roux
>Assignee: Deepak Dixit
>  Labels: quote
> Fix For: 14.12.01, Upcoming Branch
>
>
> Create a quote (w/o items), click on Report menu entry 
> ordermgr/control/QuoteReport?quoteId=CQ1
> You get this error in log
> {code}
> 2015-02-16 07:58:10,762 |http-bio-8443-exec-3 |FOUserAgent   
> |W| "fo:table-body" is missing child elements. Required content model: 
> marker* (table-row+|table-cell+) (See position 202:32)
> 2015-02-16 07:58:10,763 |http-bio-8443-exec-3 |ScreenFopViewHandler  
> |E| Unable to transform FO file: org.apache.fop.apps.FOPException
> java.lang.NullPointerException; Screen XSL:FO text was:
> {code}
> I think when you try to send the report by email you get a related error (did 
> not check). These error has been reported at OFBIZ-6076
> {code}
> 015-02-16 08:00:32,405 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 139:40)
> 015-02-16 08:00:32,407 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 161:81)
> 015-02-16 08:00:32,410 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 190:39)
> 015-02-16 08:00:32,413 |http-bio-8443-exec-9 |FOUserAgent   
> |W| "fo:table-body" is missing child elements. Required content model: 
> marker* (table-row+|table-cell+) (See position 209:32)
> 015-02-16 08:00:32,414 |http-bio-8443-exec-9 |EmailServices 
> |E| Error rendering PDF attachment for email: 
> org.apache.fop.apps.FOPExceptionava.lang.NullPointerException
> org.apache.fop.apps.FOPException
>at 
> org.ofbiz.webapp.view.ApacheFopWorker.transform(ApacheFopWorker.java:160) 
> ~[ofbiz-webapp.jar:?]
>at 
> org.ofbiz.common.email.EmailServices.sendMailFromScreen(EmailServices.java:533)
>  [ofbiz-common.jar:?]
> {code}   
> Same error with stable demo, I did not test with R14.12, but I suppose it's 
> there also. Both works in the old demo (R12.04).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6076) Error on Sending confirm email from newly created quote

2015-04-11 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490962#comment-14490962
 ] 

Deepak Dixit commented on OFBIZ-6076:
-

Hi [~edsays73],

This should be fixed under OFBIZ-6077, Could you please check?

> Error on Sending confirm email from newly created quote
> ---
>
> Key: OFBIZ-6076
> URL: https://issues.apache.org/jira/browse/OFBIZ-6076
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
> Environment: 
> http://demo-trunk-ofbiz.apache.org/ordermgr/control/sendQuoteReportMail
>Reporter: Eduardo Arellano
>
> Error on Sending confirm email from newly created quote
> http://demo-trunk-ofbiz.apache.org/ordermgr/control/sendQuoteReportMail
> The Following Errors Occurred:
> Error rendering screen for email: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteSimple]: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteTemplate]: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteInfo]: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ListQuoteInfo]: 
> java.lang.NullPointerException (null) (Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ListQuoteInfo]: 
> java.lang.NullPointerException (null)) (Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteInfo]: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ListQuoteInfo]: 
> java.lang.NullPointerException (null) (Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ListQuoteInfo]: 
> java.lang.NullPointerException (null))) (Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteTemplate]: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteInfo]: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ListQuoteInfo]: 
> java.lang.NullPointerException (null) (Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ListQuoteInfo]: 
> java.lang.NullPointerException (null)) (Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteInfo]: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ListQuoteInfo]: 
> java.lang.NullPointerException (null) (Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ListQuoteInfo]: 
> java.lang.NullPointerException (null



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (OFBIZ-6077) Error when creating a quote report

2015-04-11 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit resolved OFBIZ-6077.
-
Resolution: Fixed

> Error when creating a quote report
> --
>
> Key: OFBIZ-6077
> URL: https://issues.apache.org/jira/browse/OFBIZ-6077
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk, 13.07.01
>Reporter: Jacques Le Roux
>Assignee: Deepak Dixit
>  Labels: quote
> Fix For: 14.12.01, Upcoming Branch
>
>
> Create a quote (w/o items), click on Report menu entry 
> ordermgr/control/QuoteReport?quoteId=CQ1
> You get this error in log
> {code}
> 2015-02-16 07:58:10,762 |http-bio-8443-exec-3 |FOUserAgent   
> |W| "fo:table-body" is missing child elements. Required content model: 
> marker* (table-row+|table-cell+) (See position 202:32)
> 2015-02-16 07:58:10,763 |http-bio-8443-exec-3 |ScreenFopViewHandler  
> |E| Unable to transform FO file: org.apache.fop.apps.FOPException
> java.lang.NullPointerException; Screen XSL:FO text was:
> {code}
> I think when you try to send the report by email you get a related error (did 
> not check). These error has been reported at OFBIZ-6076
> {code}
> 015-02-16 08:00:32,405 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 139:40)
> 015-02-16 08:00:32,407 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 161:81)
> 015-02-16 08:00:32,410 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 190:39)
> 015-02-16 08:00:32,413 |http-bio-8443-exec-9 |FOUserAgent   
> |W| "fo:table-body" is missing child elements. Required content model: 
> marker* (table-row+|table-cell+) (See position 209:32)
> 015-02-16 08:00:32,414 |http-bio-8443-exec-9 |EmailServices 
> |E| Error rendering PDF attachment for email: 
> org.apache.fop.apps.FOPExceptionava.lang.NullPointerException
> org.apache.fop.apps.FOPException
>at 
> org.ofbiz.webapp.view.ApacheFopWorker.transform(ApacheFopWorker.java:160) 
> ~[ofbiz-webapp.jar:?]
>at 
> org.ofbiz.common.email.EmailServices.sendMailFromScreen(EmailServices.java:533)
>  [ofbiz-common.jar:?]
> {code}   
> Same error with stable demo, I did not test with R14.12, but I suppose it's 
> there also. Both works in the old demo (R12.04).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-6077) Error when creating a quote report

2015-04-11 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit closed OFBIZ-6077.
---

> Error when creating a quote report
> --
>
> Key: OFBIZ-6077
> URL: https://issues.apache.org/jira/browse/OFBIZ-6077
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk, 13.07.01
>Reporter: Jacques Le Roux
>Assignee: Deepak Dixit
>  Labels: quote
> Fix For: 14.12.01, Upcoming Branch
>
>
> Create a quote (w/o items), click on Report menu entry 
> ordermgr/control/QuoteReport?quoteId=CQ1
> You get this error in log
> {code}
> 2015-02-16 07:58:10,762 |http-bio-8443-exec-3 |FOUserAgent   
> |W| "fo:table-body" is missing child elements. Required content model: 
> marker* (table-row+|table-cell+) (See position 202:32)
> 2015-02-16 07:58:10,763 |http-bio-8443-exec-3 |ScreenFopViewHandler  
> |E| Unable to transform FO file: org.apache.fop.apps.FOPException
> java.lang.NullPointerException; Screen XSL:FO text was:
> {code}
> I think when you try to send the report by email you get a related error (did 
> not check). These error has been reported at OFBIZ-6076
> {code}
> 015-02-16 08:00:32,405 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 139:40)
> 015-02-16 08:00:32,407 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 161:81)
> 015-02-16 08:00:32,410 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 190:39)
> 015-02-16 08:00:32,413 |http-bio-8443-exec-9 |FOUserAgent   
> |W| "fo:table-body" is missing child elements. Required content model: 
> marker* (table-row+|table-cell+) (See position 209:32)
> 015-02-16 08:00:32,414 |http-bio-8443-exec-9 |EmailServices 
> |E| Error rendering PDF attachment for email: 
> org.apache.fop.apps.FOPExceptionava.lang.NullPointerException
> org.apache.fop.apps.FOPException
>at 
> org.ofbiz.webapp.view.ApacheFopWorker.transform(ApacheFopWorker.java:160) 
> ~[ofbiz-webapp.jar:?]
>at 
> org.ofbiz.common.email.EmailServices.sendMailFromScreen(EmailServices.java:533)
>  [ofbiz-common.jar:?]
> {code}   
> Same error with stable demo, I did not test with R14.12, but I suppose it's 
> there also. Both works in the old demo (R12.04).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-6070) Create content for product causes exception

2015-04-11 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit closed OFBIZ-6070.
---
   Resolution: Fixed
Fix Version/s: Upcoming Branch
   13.07.02
   12.04.06
   14.12.01

Forgot to close issue.

> Create content for product causes exception
> ---
>
> Key: OFBIZ-6070
> URL: https://issues.apache.org/jira/browse/OFBIZ-6070
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Trunk
>Reporter: Wai
>Assignee: Deepak Dixit
> Fix For: 14.12.01, 12.04.06, 13.07.02, Upcoming Branch
>
>
> Using demo data.
> https://localhost:8443/catalog/control/EditProductContent?productId=CPU-586
> Console output...
> 2015-02-11 11:08:44,547 |http-bio-8443-exec-3 |ServiceEcaCondition   
> |I| From Field (contentAssocTypeId) is not found in context for 
> createContent, defaulting to null.
> 2015-02-11 11:08:44,557 |http-bio-8443-exec-3 |ServiceEcaRule
> |I| For Service ECA [createContent] on [commit] got false for condition: 
> [contentAssocTypeId][is-not-empty][true][String]
> 2015-02-11 11:08:44,564 |http-bio-8443-exec-3 |ServiceEcaCondition   
> |I| From Field (contentAssocTypeId) is not found in context for 
> createContent, defaulting to null.
> 2015-02-11 11:08:44,565 |http-bio-8443-exec-3 |ServiceEcaRule
> |I| For Service ECA [createContent] on [commit] got false for condition: 
> [contentAssocTypeId][is-not-empty][true][String]
> 2015-02-11 11:08:44,566 |http-bio-8443-exec-3 |ServiceEcaCondition   
> |I| From Field (contentPurposeTypeId) is not found in context for 
> createContent, defaulting to null.
> 2015-02-11 11:08:44,567 |http-bio-8443-exec-3 |ServiceEcaRule
> |I| For Service ECA [createContent] on [commit] got false for condition: 
> [contentPurposeTypeId][is-not-empty][true][String]
> 2015-02-11 11:08:44,568 |http-bio-8443-exec-3 |ServiceEcaRule
> |I| Running Service ECA Service: createContentAlternativeUrl, triggered by 
> rule on Service: createContent
> 2015-02-11 11:08:44,581 |http-bio-8443-exec-3 |ServiceEcaRule
> |I| For Service ECA [createProductContent] on [in-validate] got false for 
> condition: [contentId][is-empty][true][String]
> 2015-02-11 11:08:44,635 |http-bio-8443-exec-3 |GenericDelegator  
> |E| Failure in create operation for entity [ProductContent]: 
> org.ofbiz.entity.GenericEntityException: Error while inserting: 
> [GenericEntity:ProductContent][contentId,10001(java.lang.String)][createdStamp,2015-02-11
>  11:08:44.587(java.sql.Timestamp)][createdTxStamp,2015-02-11 
> 11:08:32.59(java.sql.Timestamp)][fromDate,2015-02-11 
> 11:08:23.0(java.sql.Timestamp)][lastUpdatedStamp,2015-02-11 
> 11:08:44.587(java.sql.Timestamp)][lastUpdatedTxStamp,2015-02-11 
> 11:08:32.59(java.sql.Timestamp)][productContentTypeId,XTRA_IMG_E_SMALL(java.lang.String)][productId,CPU-586(java.lang.String)][thruDate,null()]
>  (SQL Exception while executing the following:INSERT INTO PRODUCT_CONTENT 
> (PRODUCT_ID, CONTENT_ID, PRODUCT_CONTENT_TYPE_ID, FROM_DATE, THRU_DATE, 
> PURCHASE_FROM_DATE, PURCHASE_THRU_DATE, USE_COUNT_LIMIT, USE_TIME, 
> USE_TIME_UOM_ID, USE_ROLE_TYPE_ID, SEQUENCE_NUM, LAST_UPDATED_STAMP, 
> LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP) VALUES (?, ?, ?, ?, 
> ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) (Cannot add or update a child row: a 
> foreign key constraint fails (`ofbiz`.`PRODUCT_CONTENT`, CONSTRAINT 
> `PROD_CNT_TYPE` FOREIGN KEY (`PRODUCT_CONTENT_TYPE_ID`) REFERENCES 
> `PRODUCT_CONTENT_TYPE` (`PRODUCT_CONTENT_TYPE_ID`. Rolling back 
> transaction.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


buildbot success in ASF Buildbot on ofbiz-branch14

2015-04-11 Thread buildbot
The Buildbot has detected a restored build on builder ofbiz-branch14 while 
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/ofbiz-branch14/builds/95

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: lares_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-ofbiz14-commit' 
triggered this build
Build Source Stamp: [branch ofbiz/branches/release14.12] 1672863
Blamelist: deepak

Build succeeded!

Sincerely,
 -The Buildbot





[jira] [Comment Edited] (OFBIZ-6077) Error when creating a quote report

2015-04-11 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490961#comment-14490961
 ] 

Deepak Dixit edited comment on OFBIZ-6077 at 4/11/15 11:56 AM:
---

Fixed in correct hierarchy of fo:table, and if no items found then display 
message on quote item section.

Now NPE on send report by mail should be fixed.
Changes committed at 
Trunk at r#1672856, 1672862
14.12 at r#1672859, 1672863


was (Author: deepak.dixit):
Fixed in correct hierarchy of fo:table, and if no items found then display 
message on quote item section.

Now NPE on send report by mail should be fixed.

> Error when creating a quote report
> --
>
> Key: OFBIZ-6077
> URL: https://issues.apache.org/jira/browse/OFBIZ-6077
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk, 13.07.01
>Reporter: Jacques Le Roux
>Assignee: Deepak Dixit
>  Labels: quote
> Fix For: 14.12.01, Upcoming Branch
>
>
> Create a quote (w/o items), click on Report menu entry 
> ordermgr/control/QuoteReport?quoteId=CQ1
> You get this error in log
> {code}
> 2015-02-16 07:58:10,762 |http-bio-8443-exec-3 |FOUserAgent   
> |W| "fo:table-body" is missing child elements. Required content model: 
> marker* (table-row+|table-cell+) (See position 202:32)
> 2015-02-16 07:58:10,763 |http-bio-8443-exec-3 |ScreenFopViewHandler  
> |E| Unable to transform FO file: org.apache.fop.apps.FOPException
> java.lang.NullPointerException; Screen XSL:FO text was:
> {code}
> I think when you try to send the report by email you get a related error (did 
> not check). These error has been reported at OFBIZ-6076
> {code}
> 015-02-16 08:00:32,405 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 139:40)
> 015-02-16 08:00:32,407 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 161:81)
> 015-02-16 08:00:32,410 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 190:39)
> 015-02-16 08:00:32,413 |http-bio-8443-exec-9 |FOUserAgent   
> |W| "fo:table-body" is missing child elements. Required content model: 
> marker* (table-row+|table-cell+) (See position 209:32)
> 015-02-16 08:00:32,414 |http-bio-8443-exec-9 |EmailServices 
> |E| Error rendering PDF attachment for email: 
> org.apache.fop.apps.FOPExceptionava.lang.NullPointerException
> org.apache.fop.apps.FOPException
>at 
> org.ofbiz.webapp.view.ApacheFopWorker.transform(ApacheFopWorker.java:160) 
> ~[ofbiz-webapp.jar:?]
>at 
> org.ofbiz.common.email.EmailServices.sendMailFromScreen(EmailServices.java:533)
>  [ofbiz-common.jar:?]
> {code}   
> Same error with stable demo, I did not test with R14.12, but I suppose it's 
> there also. Both works in the old demo (R12.04).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-6239) Have a placeholder for the SCRUM component in the wiki

2015-04-11 Thread Pierre Smits (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits closed OFBIZ-6239.
---
Resolution: Fixed

The placeholder is created and available in the wiki.

> Have a placeholder for the SCRUM component in the wiki
> --
>
> Key: OFBIZ-6239
> URL: https://issues.apache.org/jira/browse/OFBIZ-6239
> Project: OFBiz
>  Issue Type: Bug
>  Components: site
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-6141) Have a placeholder for the 'ProjectMgr' component

2015-04-11 Thread Pierre Smits (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits closed OFBIZ-6141.
---
Resolution: Fixed

The placeholder is created and available.

> Have a placeholder for the 'ProjectMgr' component
> -
>
> Key: OFBIZ-6141
> URL: https://issues.apache.org/jira/browse/OFBIZ-6141
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: site
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>
> The placeholder should describe in a paragraph or two what the core 
> functionality of the projectmgr component is.
> The initial paragraph should be business oriented (for potential adopter) and 
> outline in broad strokes what kind of functionality a user can expect/perform.
>  
> An additional paragraph should be focused on the contributor, where he can 
> find the component specific issues (in JIRA) and view changes committed to 
> the component (in VIEWVC).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-6242) Have a placeholder for the Manufacturing component

2015-04-11 Thread Pierre Smits (JIRA)
Pierre Smits created OFBIZ-6242:
---

 Summary: Have a placeholder for the Manufacturing component
 Key: OFBIZ-6242
 URL: https://issues.apache.org/jira/browse/OFBIZ-6242
 Project: OFBiz
  Issue Type: Sub-task
  Components: site
Reporter: Pierre Smits






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6077) Error when creating a quote report

2015-04-11 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490986#comment-14490986
 ] 

Jacques Le Roux commented on OFBIZ-6077:


Thanks Deepak!

> Error when creating a quote report
> --
>
> Key: OFBIZ-6077
> URL: https://issues.apache.org/jira/browse/OFBIZ-6077
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk, 13.07.01
>Reporter: Jacques Le Roux
>Assignee: Deepak Dixit
>  Labels: quote
> Fix For: 14.12.01, Upcoming Branch
>
>
> Create a quote (w/o items), click on Report menu entry 
> ordermgr/control/QuoteReport?quoteId=CQ1
> You get this error in log
> {code}
> 2015-02-16 07:58:10,762 |http-bio-8443-exec-3 |FOUserAgent   
> |W| "fo:table-body" is missing child elements. Required content model: 
> marker* (table-row+|table-cell+) (See position 202:32)
> 2015-02-16 07:58:10,763 |http-bio-8443-exec-3 |ScreenFopViewHandler  
> |E| Unable to transform FO file: org.apache.fop.apps.FOPException
> java.lang.NullPointerException; Screen XSL:FO text was:
> {code}
> I think when you try to send the report by email you get a related error (did 
> not check). These error has been reported at OFBIZ-6076
> {code}
> 015-02-16 08:00:32,405 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 139:40)
> 015-02-16 08:00:32,407 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 161:81)
> 015-02-16 08:00:32,410 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 190:39)
> 015-02-16 08:00:32,413 |http-bio-8443-exec-9 |FOUserAgent   
> |W| "fo:table-body" is missing child elements. Required content model: 
> marker* (table-row+|table-cell+) (See position 209:32)
> 015-02-16 08:00:32,414 |http-bio-8443-exec-9 |EmailServices 
> |E| Error rendering PDF attachment for email: 
> org.apache.fop.apps.FOPExceptionava.lang.NullPointerException
> org.apache.fop.apps.FOPException
>at 
> org.ofbiz.webapp.view.ApacheFopWorker.transform(ApacheFopWorker.java:160) 
> ~[ofbiz-webapp.jar:?]
>at 
> org.ofbiz.common.email.EmailServices.sendMailFromScreen(EmailServices.java:533)
>  [ofbiz-common.jar:?]
> {code}   
> Same error with stable demo, I did not test with R14.12, but I suppose it's 
> there also. Both works in the old demo (R12.04).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-6242) Have a placeholder for the Manufacturing component

2015-04-11 Thread Pierre Smits (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-6242:
---

Assignee: Pierre Smits

> Have a placeholder for the Manufacturing component
> --
>
> Key: OFBIZ-6242
> URL: https://issues.apache.org/jira/browse/OFBIZ-6242
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: site
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (OFBIZ-6077) Error when creating a quote report

2015-04-11 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490986#comment-14490986
 ] 

Jacques Le Roux edited comment on OFBIZ-6077 at 4/11/15 12:17 PM:
--

Thanks Deepak!

R13.07 r1672868


was (Author: jacques.le.roux):
Thanks Deepak!

> Error when creating a quote report
> --
>
> Key: OFBIZ-6077
> URL: https://issues.apache.org/jira/browse/OFBIZ-6077
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk, 13.07.01
>Reporter: Jacques Le Roux
>Assignee: Deepak Dixit
>  Labels: quote
> Fix For: 14.12.01, Upcoming Branch
>
>
> Create a quote (w/o items), click on Report menu entry 
> ordermgr/control/QuoteReport?quoteId=CQ1
> You get this error in log
> {code}
> 2015-02-16 07:58:10,762 |http-bio-8443-exec-3 |FOUserAgent   
> |W| "fo:table-body" is missing child elements. Required content model: 
> marker* (table-row+|table-cell+) (See position 202:32)
> 2015-02-16 07:58:10,763 |http-bio-8443-exec-3 |ScreenFopViewHandler  
> |E| Unable to transform FO file: org.apache.fop.apps.FOPException
> java.lang.NullPointerException; Screen XSL:FO text was:
> {code}
> I think when you try to send the report by email you get a related error (did 
> not check). These error has been reported at OFBIZ-6076
> {code}
> 015-02-16 08:00:32,405 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 139:40)
> 015-02-16 08:00:32,407 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 161:81)
> 015-02-16 08:00:32,410 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 190:39)
> 015-02-16 08:00:32,413 |http-bio-8443-exec-9 |FOUserAgent   
> |W| "fo:table-body" is missing child elements. Required content model: 
> marker* (table-row+|table-cell+) (See position 209:32)
> 015-02-16 08:00:32,414 |http-bio-8443-exec-9 |EmailServices 
> |E| Error rendering PDF attachment for email: 
> org.apache.fop.apps.FOPExceptionava.lang.NullPointerException
> org.apache.fop.apps.FOPException
>at 
> org.ofbiz.webapp.view.ApacheFopWorker.transform(ApacheFopWorker.java:160) 
> ~[ofbiz-webapp.jar:?]
>at 
> org.ofbiz.common.email.EmailServices.sendMailFromScreen(EmailServices.java:533)
>  [ofbiz-common.jar:?]
> {code}   
> Same error with stable demo, I did not test with R14.12, but I suppose it's 
> there also. Both works in the old demo (R12.04).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


buildbot failure in ASF Buildbot on ofbiz-trunk

2015-04-11 Thread buildbot
The Buildbot has detected a new failure on builder ofbiz-trunk while building 
ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/ofbiz-trunk/builds/822

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: lares_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-ofbiz-commit' 
triggered this build
Build Source Stamp: [branch ofbiz/trunk] 1672862
Blamelist: deepak,nmalin

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot





[jira] [Comment Edited] (OFBIZ-5169) Removing Javolution from framework components

2015-04-11 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490907#comment-14490907
 ] 

Jacques Le Roux edited comment on OFBIZ-5169 at 4/11/15 12:22 PM:
--

Yes maybe a profiler session would be a plus. But I have no ideas on how much 
OFBIZ-5781 changes performances. I note here Adrian's comment on dev ML about 
OFBIZ-5781 and r1672752 
{quote}
This should be fine, but there might be cases where a LinkedHashMap is needed. 
{quote}


was (Author: jacques.le.roux):
Yes maybe a profiler session would be a plus. But I have no ideas on how much 
OFBIZ-5781 changes performances. I note here Adrian comment on dev ML about 
OFBIZ-5781 and r1672752 
{quote}
This should be fine, but there might be cases where a LinkedHashMap is needed. 
{quote}

> Removing Javolution from framework components
> -
>
> Key: OFBIZ-5169
> URL: https://issues.apache.org/jira/browse/OFBIZ-5169
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Varun Bhansaly
>Priority: Minor
> Attachments: framework-FastList-removed.patch
>
>
> a. Remove static instances of Javolution objects.
> b. Remove other uses of Javolution objects.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-6242) Have a placeholder for the Manufacturing component

2015-04-11 Thread Pierre Smits (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits closed OFBIZ-6242.
---
Resolution: Fixed

The placeholder is created and available

> Have a placeholder for the Manufacturing component
> --
>
> Key: OFBIZ-6242
> URL: https://issues.apache.org/jira/browse/OFBIZ-6242
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: site
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6242) Have a placeholder for the Manufacturing component

2015-04-11 Thread Pierre Smits (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490995#comment-14490995
 ] 

Pierre Smits commented on OFBIZ-6242:
-

See https://cwiki.apache.org/confluence/display/OFBIZ/Manufacturing+Management

> Have a placeholder for the Manufacturing component
> --
>
> Key: OFBIZ-6242
> URL: https://issues.apache.org/jira/browse/OFBIZ-6242
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: site
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6076) Error on Sending confirm email from newly created quote

2015-04-11 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490996#comment-14490996
 ] 

Jacques Le Roux commented on OFBIZ-6076:


Yes please :)

> Error on Sending confirm email from newly created quote
> ---
>
> Key: OFBIZ-6076
> URL: https://issues.apache.org/jira/browse/OFBIZ-6076
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
> Environment: 
> http://demo-trunk-ofbiz.apache.org/ordermgr/control/sendQuoteReportMail
>Reporter: Eduardo Arellano
>
> Error on Sending confirm email from newly created quote
> http://demo-trunk-ofbiz.apache.org/ordermgr/control/sendQuoteReportMail
> The Following Errors Occurred:
> Error rendering screen for email: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteSimple]: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteTemplate]: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteInfo]: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ListQuoteInfo]: 
> java.lang.NullPointerException (null) (Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ListQuoteInfo]: 
> java.lang.NullPointerException (null)) (Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteInfo]: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ListQuoteInfo]: 
> java.lang.NullPointerException (null) (Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ListQuoteInfo]: 
> java.lang.NullPointerException (null))) (Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteTemplate]: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteInfo]: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ListQuoteInfo]: 
> java.lang.NullPointerException (null) (Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ListQuoteInfo]: 
> java.lang.NullPointerException (null)) (Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteInfo]: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ListQuoteInfo]: 
> java.lang.NullPointerException (null) (Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ListQuoteInfo]: 
> java.lang.NullPointerException (null



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6077) Error when creating a quote report

2015-04-11 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490997#comment-14490997
 ] 

Deepak Dixit commented on OFBIZ-6077:
-

Added missing if condition at r#1672869 :)

> Error when creating a quote report
> --
>
> Key: OFBIZ-6077
> URL: https://issues.apache.org/jira/browse/OFBIZ-6077
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk, 13.07.01
>Reporter: Jacques Le Roux
>Assignee: Deepak Dixit
>  Labels: quote
> Fix For: 14.12.01, Upcoming Branch
>
>
> Create a quote (w/o items), click on Report menu entry 
> ordermgr/control/QuoteReport?quoteId=CQ1
> You get this error in log
> {code}
> 2015-02-16 07:58:10,762 |http-bio-8443-exec-3 |FOUserAgent   
> |W| "fo:table-body" is missing child elements. Required content model: 
> marker* (table-row+|table-cell+) (See position 202:32)
> 2015-02-16 07:58:10,763 |http-bio-8443-exec-3 |ScreenFopViewHandler  
> |E| Unable to transform FO file: org.apache.fop.apps.FOPException
> java.lang.NullPointerException; Screen XSL:FO text was:
> {code}
> I think when you try to send the report by email you get a related error (did 
> not check). These error has been reported at OFBIZ-6076
> {code}
> 015-02-16 08:00:32,405 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 139:40)
> 015-02-16 08:00:32,407 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 161:81)
> 015-02-16 08:00:32,410 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 190:39)
> 015-02-16 08:00:32,413 |http-bio-8443-exec-9 |FOUserAgent   
> |W| "fo:table-body" is missing child elements. Required content model: 
> marker* (table-row+|table-cell+) (See position 209:32)
> 015-02-16 08:00:32,414 |http-bio-8443-exec-9 |EmailServices 
> |E| Error rendering PDF attachment for email: 
> org.apache.fop.apps.FOPExceptionava.lang.NullPointerException
> org.apache.fop.apps.FOPException
>at 
> org.ofbiz.webapp.view.ApacheFopWorker.transform(ApacheFopWorker.java:160) 
> ~[ofbiz-webapp.jar:?]
>at 
> org.ofbiz.common.email.EmailServices.sendMailFromScreen(EmailServices.java:533)
>  [ofbiz-common.jar:?]
> {code}   
> Same error with stable demo, I did not test with R14.12, but I suppose it's 
> there also. Both works in the old demo (R12.04).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-6243) Have a readme in every component

2015-04-11 Thread Pierre Smits (JIRA)
Pierre Smits created OFBIZ-6243:
---

 Summary: Have a readme in every component
 Key: OFBIZ-6243
 URL: https://issues.apache.org/jira/browse/OFBIZ-6243
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL COMPONENTS
Affects Versions: Trunk
Reporter: Pierre Smits


A readme should be the first starting point of each component for developers 
have references to the placeholder in the wiki, in jira and in svn/viewvc



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6077) Error when creating a quote report

2015-04-11 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-6077:
---
Fix Version/s: 13.07.02

> Error when creating a quote report
> --
>
> Key: OFBIZ-6077
> URL: https://issues.apache.org/jira/browse/OFBIZ-6077
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk, 13.07.01
>Reporter: Jacques Le Roux
>Assignee: Deepak Dixit
>  Labels: quote
> Fix For: 14.12.01, 13.07.02, Upcoming Branch
>
>
> Create a quote (w/o items), click on Report menu entry 
> ordermgr/control/QuoteReport?quoteId=CQ1
> You get this error in log
> {code}
> 2015-02-16 07:58:10,762 |http-bio-8443-exec-3 |FOUserAgent   
> |W| "fo:table-body" is missing child elements. Required content model: 
> marker* (table-row+|table-cell+) (See position 202:32)
> 2015-02-16 07:58:10,763 |http-bio-8443-exec-3 |ScreenFopViewHandler  
> |E| Unable to transform FO file: org.apache.fop.apps.FOPException
> java.lang.NullPointerException; Screen XSL:FO text was:
> {code}
> I think when you try to send the report by email you get a related error (did 
> not check). These error has been reported at OFBIZ-6076
> {code}
> 015-02-16 08:00:32,405 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 139:40)
> 015-02-16 08:00:32,407 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 161:81)
> 015-02-16 08:00:32,410 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 190:39)
> 015-02-16 08:00:32,413 |http-bio-8443-exec-9 |FOUserAgent   
> |W| "fo:table-body" is missing child elements. Required content model: 
> marker* (table-row+|table-cell+) (See position 209:32)
> 015-02-16 08:00:32,414 |http-bio-8443-exec-9 |EmailServices 
> |E| Error rendering PDF attachment for email: 
> org.apache.fop.apps.FOPExceptionava.lang.NullPointerException
> org.apache.fop.apps.FOPException
>at 
> org.ofbiz.webapp.view.ApacheFopWorker.transform(ApacheFopWorker.java:160) 
> ~[ofbiz-webapp.jar:?]
>at 
> org.ofbiz.common.email.EmailServices.sendMailFromScreen(EmailServices.java:533)
>  [ofbiz-common.jar:?]
> {code}   
> Same error with stable demo, I did not test with R14.12, but I suppose it's 
> there also. Both works in the old demo (R12.04).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6077) Error when creating a quote report

2015-04-11 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490998#comment-14490998
 ] 

Jacques Le Roux commented on OFBIZ-6077:


Thanks Deepak, indeed I did not spot the 2nd commit :/

> Error when creating a quote report
> --
>
> Key: OFBIZ-6077
> URL: https://issues.apache.org/jira/browse/OFBIZ-6077
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk, 13.07.01
>Reporter: Jacques Le Roux
>Assignee: Deepak Dixit
>  Labels: quote
> Fix For: 14.12.01, 13.07.02, Upcoming Branch
>
>
> Create a quote (w/o items), click on Report menu entry 
> ordermgr/control/QuoteReport?quoteId=CQ1
> You get this error in log
> {code}
> 2015-02-16 07:58:10,762 |http-bio-8443-exec-3 |FOUserAgent   
> |W| "fo:table-body" is missing child elements. Required content model: 
> marker* (table-row+|table-cell+) (See position 202:32)
> 2015-02-16 07:58:10,763 |http-bio-8443-exec-3 |ScreenFopViewHandler  
> |E| Unable to transform FO file: org.apache.fop.apps.FOPException
> java.lang.NullPointerException; Screen XSL:FO text was:
> {code}
> I think when you try to send the report by email you get a related error (did 
> not check). These error has been reported at OFBIZ-6076
> {code}
> 015-02-16 08:00:32,405 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 139:40)
> 015-02-16 08:00:32,407 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 161:81)
> 015-02-16 08:00:32,410 |http-bio-8443-exec-9 |FOUserAgent   
> |W| The following feature isn't implemented by Apache FOP, yet: 
> table-layout="auto" (on fo:table) (See position 190:39)
> 015-02-16 08:00:32,413 |http-bio-8443-exec-9 |FOUserAgent   
> |W| "fo:table-body" is missing child elements. Required content model: 
> marker* (table-row+|table-cell+) (See position 209:32)
> 015-02-16 08:00:32,414 |http-bio-8443-exec-9 |EmailServices 
> |E| Error rendering PDF attachment for email: 
> org.apache.fop.apps.FOPExceptionava.lang.NullPointerException
> org.apache.fop.apps.FOPException
>at 
> org.ofbiz.webapp.view.ApacheFopWorker.transform(ApacheFopWorker.java:160) 
> ~[ofbiz-webapp.jar:?]
>at 
> org.ofbiz.common.email.EmailServices.sendMailFromScreen(EmailServices.java:533)
>  [ofbiz-common.jar:?]
> {code}   
> Same error with stable demo, I did not test with R14.12, but I suppose it's 
> there also. Both works in the old demo (R12.04).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6143) Incorporate the readme for the projectmgr component

2015-04-11 Thread Pierre Smits (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-6143:

Issue Type: Sub-task  (was: Improvement)
Parent: OFBIZ-6243

> Incorporate the readme for the projectmgr component
> ---
>
> Key: OFBIZ-6143
> URL: https://issues.apache.org/jira/browse/OFBIZ-6143
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: specialpurpose/projectmgr
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
> Attachments: OFBIZ-6143-ProjectMgr-README-v2.patch, 
> OFBIZ-6143-ProjectMgr-README.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6240) Incorporate the readme for the scrum component

2015-04-11 Thread Pierre Smits (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-6240:

Issue Type: Sub-task  (was: Improvement)
Parent: OFBIZ-6243

> Incorporate the readme for the scrum component
> --
>
> Key: OFBIZ-6240
> URL: https://issues.apache.org/jira/browse/OFBIZ-6240
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: specialpurpose/scrum
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
> Attachments: OFBIZ-6240-Scrum-README.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-6244) Incorporate the readme for the Manufacturing component

2015-04-11 Thread Pierre Smits (JIRA)
Pierre Smits created OFBIZ-6244:
---

 Summary: Incorporate the readme for the Manufacturing component
 Key: OFBIZ-6244
 URL: https://issues.apache.org/jira/browse/OFBIZ-6244
 Project: OFBiz
  Issue Type: Sub-task
Reporter: Pierre Smits






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6239) Have a placeholder for the SCRUM component in the wiki

2015-04-11 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490999#comment-14490999
 ] 

Jacques Le Roux commented on OFBIZ-6239:


What about a link in the README?

> Have a placeholder for the SCRUM component in the wiki
> --
>
> Key: OFBIZ-6239
> URL: https://issues.apache.org/jira/browse/OFBIZ-6239
> Project: OFBiz
>  Issue Type: Bug
>  Components: site
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-6244) Incorporate the readme for the Manufacturing component

2015-04-11 Thread Pierre Smits (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-6244:
---

Assignee: Pierre Smits

> Incorporate the readme for the Manufacturing component
> --
>
> Key: OFBIZ-6244
> URL: https://issues.apache.org/jira/browse/OFBIZ-6244
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (OFBIZ-6239) Have a placeholder for the SCRUM component in the wiki

2015-04-11 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490999#comment-14490999
 ] 

Jacques Le Roux edited comment on OFBIZ-6239 at 4/11/15 12:35 PM:
--

-What about a link in the README?- Ha forget it, just spotted OFBIZ-6243 


was (Author: jacques.le.roux):
What about a link in the README?

> Have a placeholder for the SCRUM component in the wiki
> --
>
> Key: OFBIZ-6239
> URL: https://issues.apache.org/jira/browse/OFBIZ-6239
> Project: OFBiz
>  Issue Type: Bug
>  Components: site
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6244) Incorporate the readme for the Manufacturing component

2015-04-11 Thread Pierre Smits (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-6244:

Component/s: (was: ALL COMPONENTS)
 manufacturing

> Incorporate the readme for the Manufacturing component
> --
>
> Key: OFBIZ-6244
> URL: https://issues.apache.org/jira/browse/OFBIZ-6244
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6244) Incorporate the readme for the Manufacturing component

2015-04-11 Thread Pierre Smits (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-6244:

Attachment: OFBIZ-6244-ManufacturingREADME.patch

This patch addresses the issue.

> Incorporate the readme for the Manufacturing component
> --
>
> Key: OFBIZ-6244
> URL: https://issues.apache.org/jira/browse/OFBIZ-6244
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing
>Reporter: Pierre Smits
>Assignee: Pierre Smits
> Attachments: OFBIZ-6244-ManufacturingREADME.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-6057) Quote item view FreeMarker error message due to changes made in OFBIZ-2120

2015-04-11 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit reassigned OFBIZ-6057:
---

Assignee: Deepak Dixit

> Quote item view FreeMarker error message due to changes made in OFBIZ-2120
> --
>
> Key: OFBIZ-6057
> URL: https://issues.apache.org/jira/browse/OFBIZ-6057
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting, order
>Affects Versions: Release Branch 13.07
> Environment: Linux
>Reporter: Forrest Rae
>Assignee: Deepak Dixit
>
> In order to fix OFBIZ-2120, code was added to the 
> applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl file at lines 
> 53 through 57, with the offending line being at 5:
> https://github.com/apache/ofbiz/blob/trunk/applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl##L56
> Here is the commit: 
> https://github.com/apache/ofbiz/commit/27253c4667e87721212fa8955d75c74a0d171c73
> This ends up causing the following error:
>  [java] freemarker.core.InvalidReferenceException: The following has 
> evaluated to null or missing:
>  [java] ==> null  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 56, 
> column 40]
>  [java] 
>  [java] 
>  [java] Tip: If the failing expression is known to be legally refer to 
> something that's null or missing, either specify a default value like 
> myOptionalVar!myDefault, or use <#if 
> myOptionalVar??>when-present<#else>when-missing. (These only cover the 
> last step of the expression; to cover the whole expression, use parenthesis: 
> (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??
>  [java] 
>  [java] 
>  [java] 
>  [java] FTL stack trace ("~" means nesting-related):
>  [java]   - Failed at: #assign product = null  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 56, 
> column 21]
>  [java]   - Reached through: #list quoteItems as quoteItem  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 52, 
> column 13]
> The main reason for this is because there is no concept of "null" in 
> FreeMarker 2.3, as the following thread explains: 
> http://ehc.ac/p/freemarker/discussion/2346/thread/85da30a4/  Not sure how to 
> go about fixing this error, the thread suggests setting the variable to the 
> string "null".
> There are other instances of this bug as well:
> $ grep -r "<#assign" * | grep "= null"
> applications/order/webapp/ordermgr/return/returnItems.ftl: 
> <#assign returnItemSubTotal = null >  <#-- otherwise the last item's might 
> carry over -->
> applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl:   
>  <#assign product = null> <#-- don't drag it along to the next iteration 
> -->
> applications/accounting/webapp/accounting/reports/DepositSlip.fo.ftl: 
><#assign creditCard = null/>
> framework/webtools/webapp/webtools/datafile/viewdatafile.ftl:<#assign 
> lastRecordName = null>
> Reproduction Steps:
> 1) Visit http://demo-stable-ofbiz.apache.org/ordermgr/control/FindRequest
> 2) Click "New Request"
> 3) Set
>   - Cust Request Type Id = Request for Quote
>   - Requesting Party = DemoCustomer
>   - Cust Request Name = Test Request
>   - Description = This is a test request
> 4) Click "Sumbit"
> 5) "Create Quote from request"
> 6) error will appear



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-6245) Have a placeholder for the MyPortal component

2015-04-11 Thread Pierre Smits (JIRA)
Pierre Smits created OFBIZ-6245:
---

 Summary: Have a placeholder for the MyPortal component
 Key: OFBIZ-6245
 URL: https://issues.apache.org/jira/browse/OFBIZ-6245
 Project: OFBiz
  Issue Type: Sub-task
  Components: specialpurpose/myportal
Affects Versions: Trunk
Reporter: Pierre Smits
Assignee: Pierre Smits






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-6246) Incorporate the readme for the MyPortal component

2015-04-11 Thread Pierre Smits (JIRA)
Pierre Smits created OFBIZ-6246:
---

 Summary: Incorporate the readme for the MyPortal component
 Key: OFBIZ-6246
 URL: https://issues.apache.org/jira/browse/OFBIZ-6246
 Project: OFBiz
  Issue Type: Sub-task
Reporter: Pierre Smits






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6244) Incorporate the readme for the Manufacturing component

2015-04-11 Thread Pierre Smits (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-6244:

Attachment: OFBIZ-6244-ManufacturingREADME.patch

The previous version contained a wrong reference

> Incorporate the readme for the Manufacturing component
> --
>
> Key: OFBIZ-6244
> URL: https://issues.apache.org/jira/browse/OFBIZ-6244
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing
>Reporter: Pierre Smits
>Assignee: Pierre Smits
> Attachments: OFBIZ-6244-ManufacturingREADME.patch, 
> OFBIZ-6244-ManufacturingREADME.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6244) Incorporate the readme for the Manufacturing component

2015-04-11 Thread Pierre Smits (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-6244:

Attachment: (was: OFBIZ-6244-ManufacturingREADME.patch)

> Incorporate the readme for the Manufacturing component
> --
>
> Key: OFBIZ-6244
> URL: https://issues.apache.org/jira/browse/OFBIZ-6244
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Issue Comment Deleted] (OFBIZ-6244) Incorporate the readme for the Manufacturing component

2015-04-11 Thread Pierre Smits (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-6244:

Comment: was deleted

(was: This patch addresses the issue.)

> Incorporate the readme for the Manufacturing component
> --
>
> Key: OFBIZ-6244
> URL: https://issues.apache.org/jira/browse/OFBIZ-6244
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Issue Comment Deleted] (OFBIZ-6244) Incorporate the readme for the Manufacturing component

2015-04-11 Thread Pierre Smits (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-6244:

Comment: was deleted

(was: The previous version contained a wrong reference)

> Incorporate the readme for the Manufacturing component
> --
>
> Key: OFBIZ-6244
> URL: https://issues.apache.org/jira/browse/OFBIZ-6244
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6244) Incorporate the readme for the Manufacturing component

2015-04-11 Thread Pierre Smits (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-6244:

Attachment: (was: OFBIZ-6244-ManufacturingREADME.patch)

> Incorporate the readme for the Manufacturing component
> --
>
> Key: OFBIZ-6244
> URL: https://issues.apache.org/jira/browse/OFBIZ-6244
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6244) Incorporate the readme for the Manufacturing component

2015-04-11 Thread Pierre Smits (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-6244:

Attachment: OFBIZ-6244-ManufacturingREADME.patch

This patch addresses the issue.

> Incorporate the readme for the Manufacturing component
> --
>
> Key: OFBIZ-6244
> URL: https://issues.apache.org/jira/browse/OFBIZ-6244
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing
>Reporter: Pierre Smits
>Assignee: Pierre Smits
> Attachments: OFBIZ-6244-ManufacturingREADME.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: [VOTE] [RELEASE] Apache OFBiz 13.07.02

2015-04-11 Thread Jacopo Cappellato
Ok, let's cancel this release vote then!
I will start a new one as soon as the release files are ready.

Jacopo

On Apr 11, 2015, at 3:22 AM, Deepak Dixit  
wrote:

> +1
> 
> Jacopo could you please include r#1672849 (OFBIZ-6205) into 13.07.02
> release?
> 
> 
> 
> Thanks & Regards
> --
> Deepak Dixit
> www.hotwaxsystems.com
> 
> On Fri, Apr 10, 2015 at 12:11 PM, Nicolas Malin 
> wrote:
> 
>> +1
>> 
>> ./ant load-demo run-tests -> BUILD SUCCESSFUL
>> 
>> Tested archive signature :
>> * MD5
>> andrealphus$ flowToParse="apache-ofbiz-13.07.02.zip.md5"; echo "$(cat
>> $flowToParse | tr -d [:space:] | cut -f 2 -d ':') $(cat $flowToParse |  tr
>> -d [:space:] | cut -f 1 -d ':' | tr -d [:space:])" > tmp.hash; md5sum -c
>> tmp.hash ;
>> apache-ofbiz-13.07.02.zip: Réussi
>> 
>> * SHA
>> andrealphus$ flowToParse="apache-ofbiz-13.07.02.zip.sha"; echo "$(cat
>> $flowToParse | tr -d [:space:] | cut -f 2 -d ':') $(cat $flowToParse |  tr
>> -d [:space:] | cut -f 1 -d ':' | tr -d [:space:])" > tmp.hash; sha512sum -c
>> tmp.hash ;
>> apache-ofbiz-13.07.02.zip: Réussi
>> 
>> Nicolas
>> 
>> Le 09/04/2015 22:48, Jacopo Cappellato a écrit :
>> 
>>> Let's try to do a release just in time for ApacheCon US! It would be nice
>>> to do the announcement during the conference.
>>> 
>>> This is the vote thread to release a new bug fix release for the
>>> release13.07 branch. This new release, "Apache OFBiz 13.07.02" will
>>> supersede the previous release from the same branch.
>>> The release files can be downloaded from here:
>>> 
>>> https://dist.apache.org/repos/dist/dev/ofbiz/
>>> 
>>> and are:
>>> 
>>> * apache-ofbiz-13.07.02.zip
>>> * KEYS: text file with keys
>>> * apache-ofbiz-13.07.02.zip.asc: the detached signature file
>>> * apache-ofbiz-13.07.02.zip.md5, apache-ofbiz-13.07.02.zip.sha: hashes
>>> 
>>> Please download and test the zip file and its signatures (for
>>> instructions on testing the signatures see http://www.apache.org/info/
>>> verification.html).
>>> 
>>> Vote:
>>> 
>>> [ +1] release as Apache OFBiz 13.07.02
>>> [ -1] do not release
>>> 
>>> This vote will be open for at least 3 days.
>>> For more details about this process please read http://www.apache.org/
>>> foundation/voting.html
>>> 
>>> Kind Regards,
>>> 
>>> Jacopo
>>> 
>> 
>> 



[jira] [Closed] (OFBIZ-6057) Quote item view FreeMarker error message due to changes made in OFBIZ-2120

2015-04-11 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit closed OFBIZ-6057.
---
   Resolution: Fixed
Fix Version/s: Upcoming Branch
   13.07.02
   14.12.01

> Quote item view FreeMarker error message due to changes made in OFBIZ-2120
> --
>
> Key: OFBIZ-6057
> URL: https://issues.apache.org/jira/browse/OFBIZ-6057
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting, order
>Affects Versions: Release Branch 13.07
> Environment: Linux
>Reporter: Forrest Rae
>Assignee: Deepak Dixit
> Fix For: 14.12.01, 13.07.02, Upcoming Branch
>
>
> In order to fix OFBIZ-2120, code was added to the 
> applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl file at lines 
> 53 through 57, with the offending line being at 5:
> https://github.com/apache/ofbiz/blob/trunk/applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl##L56
> Here is the commit: 
> https://github.com/apache/ofbiz/commit/27253c4667e87721212fa8955d75c74a0d171c73
> This ends up causing the following error:
>  [java] freemarker.core.InvalidReferenceException: The following has 
> evaluated to null or missing:
>  [java] ==> null  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 56, 
> column 40]
>  [java] 
>  [java] 
>  [java] Tip: If the failing expression is known to be legally refer to 
> something that's null or missing, either specify a default value like 
> myOptionalVar!myDefault, or use <#if 
> myOptionalVar??>when-present<#else>when-missing. (These only cover the 
> last step of the expression; to cover the whole expression, use parenthesis: 
> (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??
>  [java] 
>  [java] 
>  [java] 
>  [java] FTL stack trace ("~" means nesting-related):
>  [java]   - Failed at: #assign product = null  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 56, 
> column 21]
>  [java]   - Reached through: #list quoteItems as quoteItem  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 52, 
> column 13]
> The main reason for this is because there is no concept of "null" in 
> FreeMarker 2.3, as the following thread explains: 
> http://ehc.ac/p/freemarker/discussion/2346/thread/85da30a4/  Not sure how to 
> go about fixing this error, the thread suggests setting the variable to the 
> string "null".
> There are other instances of this bug as well:
> $ grep -r "<#assign" * | grep "= null"
> applications/order/webapp/ordermgr/return/returnItems.ftl: 
> <#assign returnItemSubTotal = null >  <#-- otherwise the last item's might 
> carry over -->
> applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl:   
>  <#assign product = null> <#-- don't drag it along to the next iteration 
> -->
> applications/accounting/webapp/accounting/reports/DepositSlip.fo.ftl: 
><#assign creditCard = null/>
> framework/webtools/webapp/webtools/datafile/viewdatafile.ftl:<#assign 
> lastRecordName = null>
> Reproduction Steps:
> 1) Visit http://demo-stable-ofbiz.apache.org/ordermgr/control/FindRequest
> 2) Click "New Request"
> 3) Set
>   - Cust Request Type Id = Request for Quote
>   - Requesting Party = DemoCustomer
>   - Cust Request Name = Test Request
>   - Description = This is a test request
> 4) Click "Sumbit"
> 5) "Create Quote from request"
> 6) error will appear



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6057) Quote item view FreeMarker error message due to changes made in OFBIZ-2120

2015-04-11 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14491010#comment-14491010
 ] 

Deepak Dixit commented on OFBIZ-6057:
-

Thanks  Forrest Rae for reporting the issue.
This has been fix at
Trunk at r#1672873
14.12 at r#1672874
13.07 at r#1672875

> Quote item view FreeMarker error message due to changes made in OFBIZ-2120
> --
>
> Key: OFBIZ-6057
> URL: https://issues.apache.org/jira/browse/OFBIZ-6057
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting, order
>Affects Versions: Release Branch 13.07
> Environment: Linux
>Reporter: Forrest Rae
>Assignee: Deepak Dixit
> Fix For: 14.12.01, 13.07.02, Upcoming Branch
>
>
> In order to fix OFBIZ-2120, code was added to the 
> applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl file at lines 
> 53 through 57, with the offending line being at 5:
> https://github.com/apache/ofbiz/blob/trunk/applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl##L56
> Here is the commit: 
> https://github.com/apache/ofbiz/commit/27253c4667e87721212fa8955d75c74a0d171c73
> This ends up causing the following error:
>  [java] freemarker.core.InvalidReferenceException: The following has 
> evaluated to null or missing:
>  [java] ==> null  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 56, 
> column 40]
>  [java] 
>  [java] 
>  [java] Tip: If the failing expression is known to be legally refer to 
> something that's null or missing, either specify a default value like 
> myOptionalVar!myDefault, or use <#if 
> myOptionalVar??>when-present<#else>when-missing. (These only cover the 
> last step of the expression; to cover the whole expression, use parenthesis: 
> (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??
>  [java] 
>  [java] 
>  [java] 
>  [java] FTL stack trace ("~" means nesting-related):
>  [java]   - Failed at: #assign product = null  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 56, 
> column 21]
>  [java]   - Reached through: #list quoteItems as quoteItem  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 52, 
> column 13]
> The main reason for this is because there is no concept of "null" in 
> FreeMarker 2.3, as the following thread explains: 
> http://ehc.ac/p/freemarker/discussion/2346/thread/85da30a4/  Not sure how to 
> go about fixing this error, the thread suggests setting the variable to the 
> string "null".
> There are other instances of this bug as well:
> $ grep -r "<#assign" * | grep "= null"
> applications/order/webapp/ordermgr/return/returnItems.ftl: 
> <#assign returnItemSubTotal = null >  <#-- otherwise the last item's might 
> carry over -->
> applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl:   
>  <#assign product = null> <#-- don't drag it along to the next iteration 
> -->
> applications/accounting/webapp/accounting/reports/DepositSlip.fo.ftl: 
><#assign creditCard = null/>
> framework/webtools/webapp/webtools/datafile/viewdatafile.ftl:<#assign 
> lastRecordName = null>
> Reproduction Steps:
> 1) Visit http://demo-stable-ofbiz.apache.org/ordermgr/control/FindRequest
> 2) Click "New Request"
> 3) Set
>   - Cust Request Type Id = Request for Quote
>   - Requesting Party = DemoCustomer
>   - Cust Request Name = Test Request
>   - Description = This is a test request
> 4) Click "Sumbit"
> 5) "Create Quote from request"
> 6) error will appear



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (OFBIZ-6057) Quote item view FreeMarker error message due to changes made in OFBIZ-2120

2015-04-11 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14491010#comment-14491010
 ] 

Deepak Dixit edited comment on OFBIZ-6057 at 4/11/15 12:57 PM:
---

Thanks  Forrest Rae for reporting the issue.
This has been fixed at
Trunk at r#1672873
14.12 at r#1672874
13.07 at r#1672875


was (Author: deepak.dixit):
Thanks  Forrest Rae for reporting the issue.
This has been fix at
Trunk at r#1672873
14.12 at r#1672874
13.07 at r#1672875

> Quote item view FreeMarker error message due to changes made in OFBIZ-2120
> --
>
> Key: OFBIZ-6057
> URL: https://issues.apache.org/jira/browse/OFBIZ-6057
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting, order
>Affects Versions: Release Branch 13.07
> Environment: Linux
>Reporter: Forrest Rae
>Assignee: Deepak Dixit
> Fix For: 14.12.01, 13.07.02, Upcoming Branch
>
>
> In order to fix OFBIZ-2120, code was added to the 
> applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl file at lines 
> 53 through 57, with the offending line being at 5:
> https://github.com/apache/ofbiz/blob/trunk/applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl##L56
> Here is the commit: 
> https://github.com/apache/ofbiz/commit/27253c4667e87721212fa8955d75c74a0d171c73
> This ends up causing the following error:
>  [java] freemarker.core.InvalidReferenceException: The following has 
> evaluated to null or missing:
>  [java] ==> null  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 56, 
> column 40]
>  [java] 
>  [java] 
>  [java] Tip: If the failing expression is known to be legally refer to 
> something that's null or missing, either specify a default value like 
> myOptionalVar!myDefault, or use <#if 
> myOptionalVar??>when-present<#else>when-missing. (These only cover the 
> last step of the expression; to cover the whole expression, use parenthesis: 
> (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??
>  [java] 
>  [java] 
>  [java] 
>  [java] FTL stack trace ("~" means nesting-related):
>  [java]   - Failed at: #assign product = null  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 56, 
> column 21]
>  [java]   - Reached through: #list quoteItems as quoteItem  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 52, 
> column 13]
> The main reason for this is because there is no concept of "null" in 
> FreeMarker 2.3, as the following thread explains: 
> http://ehc.ac/p/freemarker/discussion/2346/thread/85da30a4/  Not sure how to 
> go about fixing this error, the thread suggests setting the variable to the 
> string "null".
> There are other instances of this bug as well:
> $ grep -r "<#assign" * | grep "= null"
> applications/order/webapp/ordermgr/return/returnItems.ftl: 
> <#assign returnItemSubTotal = null >  <#-- otherwise the last item's might 
> carry over -->
> applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl:   
>  <#assign product = null> <#-- don't drag it along to the next iteration 
> -->
> applications/accounting/webapp/accounting/reports/DepositSlip.fo.ftl: 
><#assign creditCard = null/>
> framework/webtools/webapp/webtools/datafile/viewdatafile.ftl:<#assign 
> lastRecordName = null>
> Reproduction Steps:
> 1) Visit http://demo-stable-ofbiz.apache.org/ordermgr/control/FindRequest
> 2) Click "New Request"
> 3) Set
>   - Cust Request Type Id = Request for Quote
>   - Requesting Party = DemoCustomer
>   - Cust Request Name = Test Request
>   - Description = This is a test request
> 4) Click "Sumbit"
> 5) "Create Quote from request"
> 6) error will appear



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6246) Incorporate the readme for the MyPortal component

2015-04-11 Thread Pierre Smits (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-6246:

Component/s: (was: ALL COMPONENTS)
 specialpurpose/myportal

> Incorporate the readme for the MyPortal component
> -
>
> Key: OFBIZ-6246
> URL: https://issues.apache.org/jira/browse/OFBIZ-6246
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: specialpurpose/myportal
>Reporter: Pierre Smits
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-5970) Form RequestRolesInfo is not being accessed from Screens

2015-04-11 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-5970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-5970:

Affects Version/s: (was: Release Branch 13.07)

> Form RequestRolesInfo is not being accessed from Screens
> 
>
> Key: OFBIZ-5970
> URL: https://issues.apache.org/jira/browse/OFBIZ-5970
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/projectmgr
>Affects Versions: Release Branch 11.04, Release Branch 12.04, Trunk
>Reporter: Pierre Smits
>  Labels: customer, request, role, roles
>
> The form exists, but it isn't referenced in a Screen in ProjectMgr.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-5970) Form RequestRolesInfo is not being accessed from Screens

2015-04-11 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14491014#comment-14491014
 ] 

Deepak Dixit commented on OFBIZ-5970:
-

Removed 13.07 from affected version as this component does not exists in 13.07

> Form RequestRolesInfo is not being accessed from Screens
> 
>
> Key: OFBIZ-5970
> URL: https://issues.apache.org/jira/browse/OFBIZ-5970
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/projectmgr
>Affects Versions: Release Branch 11.04, Release Branch 12.04, Trunk
>Reporter: Pierre Smits
>  Labels: customer, request, role, roles
>
> The form exists, but it isn't referenced in a Screen in ProjectMgr.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


buildbot exception in ASF Buildbot on ofbiz-branch13

2015-04-11 Thread buildbot
The Buildbot has detected a build exception on builder ofbiz-branch13 while 
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/ofbiz-branch13/builds/284

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: lares_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-ofbiz13-commit' 
triggered this build
Build Source Stamp: [branch ofbiz/branches/release13.07] 1672875
Blamelist: deepak

BUILD FAILED: exception upload_1

Sincerely,
 -The Buildbot





buildbot success in ASF Buildbot on ofbiz-trunk

2015-04-11 Thread buildbot
The Buildbot has detected a restored build on builder ofbiz-trunk while 
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/ofbiz-trunk/builds/823

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: lares_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-ofbiz-commit' 
triggered this build
Build Source Stamp: [branch ofbiz/trunk] 1672873
Blamelist: deepak

Build succeeded!

Sincerely,
 -The Buildbot





[jira] [Commented] (OFBIZ-6076) Error on Sending confirm email from newly created quote

2015-04-11 Thread Eduardo Arellano (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14491049#comment-14491049
 ] 

Eduardo Arellano commented on OFBIZ-6076:
-

Ok...just checked it and it looks good on demo-trunk. I didn't receive the 
email I sent but I suppose that the demo server isn't setup to send them. I'll 
double check this week from my dev setup

> Error on Sending confirm email from newly created quote
> ---
>
> Key: OFBIZ-6076
> URL: https://issues.apache.org/jira/browse/OFBIZ-6076
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
> Environment: 
> http://demo-trunk-ofbiz.apache.org/ordermgr/control/sendQuoteReportMail
>Reporter: Eduardo Arellano
>
> Error on Sending confirm email from newly created quote
> http://demo-trunk-ofbiz.apache.org/ordermgr/control/sendQuoteReportMail
> The Following Errors Occurred:
> Error rendering screen for email: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteSimple]: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteTemplate]: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteInfo]: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ListQuoteInfo]: 
> java.lang.NullPointerException (null) (Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ListQuoteInfo]: 
> java.lang.NullPointerException (null)) (Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteInfo]: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ListQuoteInfo]: 
> java.lang.NullPointerException (null) (Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ListQuoteInfo]: 
> java.lang.NullPointerException (null))) (Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteTemplate]: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteInfo]: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ListQuoteInfo]: 
> java.lang.NullPointerException (null) (Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ListQuoteInfo]: 
> java.lang.NullPointerException (null)) (Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteInfo]: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ListQuoteInfo]: 
> java.lang.NullPointerException (null) (Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ListQuoteInfo]: 
> java.lang.NullPointerException (null



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[VOTE] [RELEASE] Apache OFBiz 13.07.02 - second attempt

2015-04-11 Thread Jacopo Cappellato
This is the second vote thread vote thread (after the first was cancelled to 
prepare a new release file with some latest bug fixes) to release a new bug fix 
release for the release13.07 branch. This new release, "Apache OFBiz 13.07.02" 
will supersede the previous release from the same branch.
The release files can be downloaded from here:

https://dist.apache.org/repos/dist/dev/ofbiz/

and are:

* apache-ofbiz-13.07.02.zip
* KEYS: text file with keys
* apache-ofbiz-13.07.02.zip.asc: the detached signature file
* apache-ofbiz-13.07.02.zip.md5, apache-ofbiz-13.07.02.zip.sha: hashes

Please download and test the zip file and its signatures (for instructions on 
testing the signatures see http://www.apache.org/info/verification.html).

Vote:

[ +1] release as Apache OFBiz 13.07.02
[ -1] do not release

This vote will be open for at least 3 days.
For more details about this process please read 
http://www.apache.org/foundation/voting.html

Kind Regards,

Jacopo

Re: svn commit: r1672486 - /ofbiz/site/release-notes-13.07.02.html

2015-04-11 Thread Jacopo Cappellato

On Apr 10, 2015, at 6:09 AM, Jacques Le Roux  
wrote:

> I believe it's convenient for users to at least be able to quickly discern 
> bug fixes from the rest... Let's see other opinions indeed, at least those 
> who care about delivering a better user experiences (too harsh here?)

It seems you have a very strong opinion about this: even if no one else seems 
to share your same concerns, I have updated the release notes including the 
categorizations you asked for; but if someone has a different opinion it 
doesn't mean that they don't care about users...

Jacopo



[jira] [Reopened] (OFBIZ-6057) Quote item view FreeMarker error message due to changes made in OFBIZ-2120

2015-04-11 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reopened OFBIZ-6057:


We still need to fix the other cases Forrest signaled, I reopen

> Quote item view FreeMarker error message due to changes made in OFBIZ-2120
> --
>
> Key: OFBIZ-6057
> URL: https://issues.apache.org/jira/browse/OFBIZ-6057
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting, order
>Affects Versions: Release Branch 13.07
> Environment: Linux
>Reporter: Forrest Rae
>Assignee: Deepak Dixit
> Fix For: 14.12.01, 13.07.02, Upcoming Branch
>
>
> In order to fix OFBIZ-2120, code was added to the 
> applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl file at lines 
> 53 through 57, with the offending line being at 5:
> https://github.com/apache/ofbiz/blob/trunk/applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl##L56
> Here is the commit: 
> https://github.com/apache/ofbiz/commit/27253c4667e87721212fa8955d75c74a0d171c73
> This ends up causing the following error:
>  [java] freemarker.core.InvalidReferenceException: The following has 
> evaluated to null or missing:
>  [java] ==> null  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 56, 
> column 40]
>  [java] 
>  [java] 
>  [java] Tip: If the failing expression is known to be legally refer to 
> something that's null or missing, either specify a default value like 
> myOptionalVar!myDefault, or use <#if 
> myOptionalVar??>when-present<#else>when-missing. (These only cover the 
> last step of the expression; to cover the whole expression, use parenthesis: 
> (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??
>  [java] 
>  [java] 
>  [java] 
>  [java] FTL stack trace ("~" means nesting-related):
>  [java]   - Failed at: #assign product = null  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 56, 
> column 21]
>  [java]   - Reached through: #list quoteItems as quoteItem  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 52, 
> column 13]
> The main reason for this is because there is no concept of "null" in 
> FreeMarker 2.3, as the following thread explains: 
> http://ehc.ac/p/freemarker/discussion/2346/thread/85da30a4/  Not sure how to 
> go about fixing this error, the thread suggests setting the variable to the 
> string "null".
> There are other instances of this bug as well:
> $ grep -r "<#assign" * | grep "= null"
> applications/order/webapp/ordermgr/return/returnItems.ftl: 
> <#assign returnItemSubTotal = null >  <#-- otherwise the last item's might 
> carry over -->
> applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl:   
>  <#assign product = null> <#-- don't drag it along to the next iteration 
> -->
> applications/accounting/webapp/accounting/reports/DepositSlip.fo.ftl: 
><#assign creditCard = null/>
> framework/webtools/webapp/webtools/datafile/viewdatafile.ftl:<#assign 
> lastRecordName = null>
> Reproduction Steps:
> 1) Visit http://demo-stable-ofbiz.apache.org/ordermgr/control/FindRequest
> 2) Click "New Request"
> 3) Set
>   - Cust Request Type Id = Request for Quote
>   - Requesting Party = DemoCustomer
>   - Cust Request Name = Test Request
>   - Description = This is a test request
> 4) Click "Sumbit"
> 5) "Create Quote from request"
> 6) error will appear



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (OFBIZ-6057) Quote item view FreeMarker error message due to changes made in OFBIZ-2120

2015-04-11 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14491113#comment-14491113
 ] 

Jacques Le Roux edited comment on OFBIZ-6057 at 4/11/15 5:16 PM:
-

We still need to fix the other cases Forrest signaled, and also in R12.04... I 
reopen. 


was (Author: jacques.le.roux):
We still need to fix the other cases Forrest signaled, I reopen

> Quote item view FreeMarker error message due to changes made in OFBIZ-2120
> --
>
> Key: OFBIZ-6057
> URL: https://issues.apache.org/jira/browse/OFBIZ-6057
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting, order
>Affects Versions: Release Branch 13.07
> Environment: Linux
>Reporter: Forrest Rae
>Assignee: Deepak Dixit
> Fix For: 14.12.01, 13.07.02, Upcoming Branch
>
>
> In order to fix OFBIZ-2120, code was added to the 
> applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl file at lines 
> 53 through 57, with the offending line being at 5:
> https://github.com/apache/ofbiz/blob/trunk/applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl##L56
> Here is the commit: 
> https://github.com/apache/ofbiz/commit/27253c4667e87721212fa8955d75c74a0d171c73
> This ends up causing the following error:
>  [java] freemarker.core.InvalidReferenceException: The following has 
> evaluated to null or missing:
>  [java] ==> null  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 56, 
> column 40]
>  [java] 
>  [java] 
>  [java] Tip: If the failing expression is known to be legally refer to 
> something that's null or missing, either specify a default value like 
> myOptionalVar!myDefault, or use <#if 
> myOptionalVar??>when-present<#else>when-missing. (These only cover the 
> last step of the expression; to cover the whole expression, use parenthesis: 
> (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??
>  [java] 
>  [java] 
>  [java] 
>  [java] FTL stack trace ("~" means nesting-related):
>  [java]   - Failed at: #assign product = null  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 56, 
> column 21]
>  [java]   - Reached through: #list quoteItems as quoteItem  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 52, 
> column 13]
> The main reason for this is because there is no concept of "null" in 
> FreeMarker 2.3, as the following thread explains: 
> http://ehc.ac/p/freemarker/discussion/2346/thread/85da30a4/  Not sure how to 
> go about fixing this error, the thread suggests setting the variable to the 
> string "null".
> There are other instances of this bug as well:
> $ grep -r "<#assign" * | grep "= null"
> applications/order/webapp/ordermgr/return/returnItems.ftl: 
> <#assign returnItemSubTotal = null >  <#-- otherwise the last item's might 
> carry over -->
> applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl:   
>  <#assign product = null> <#-- don't drag it along to the next iteration 
> -->
> applications/accounting/webapp/accounting/reports/DepositSlip.fo.ftl: 
><#assign creditCard = null/>
> framework/webtools/webapp/webtools/datafile/viewdatafile.ftl:<#assign 
> lastRecordName = null>
> Reproduction Steps:
> 1) Visit http://demo-stable-ofbiz.apache.org/ordermgr/control/FindRequest
> 2) Click "New Request"
> 3) Set
>   - Cust Request Type Id = Request for Quote
>   - Requesting Party = DemoCustomer
>   - Cust Request Name = Test Request
>   - Description = This is a test request
> 4) Click "Sumbit"
> 5) "Create Quote from request"
> 6) error will appear



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6057) Quote item view FreeMarker error message due to changes made in OFBIZ-2120

2015-04-11 Thread Jacopo Cappellato (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14491116#comment-14491116
 ] 

Jacopo Cappellato commented on OFBIZ-6057:
--

Please create a new ticket (that references this) for the 12.04 branch: 
otherwise the fixes for the already fixed branches will not appear in the 
release notes.

> Quote item view FreeMarker error message due to changes made in OFBIZ-2120
> --
>
> Key: OFBIZ-6057
> URL: https://issues.apache.org/jira/browse/OFBIZ-6057
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting, order
>Affects Versions: Release Branch 13.07
> Environment: Linux
>Reporter: Forrest Rae
>Assignee: Deepak Dixit
> Fix For: 14.12.01, 13.07.02, Upcoming Branch
>
>
> In order to fix OFBIZ-2120, code was added to the 
> applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl file at lines 
> 53 through 57, with the offending line being at 5:
> https://github.com/apache/ofbiz/blob/trunk/applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl##L56
> Here is the commit: 
> https://github.com/apache/ofbiz/commit/27253c4667e87721212fa8955d75c74a0d171c73
> This ends up causing the following error:
>  [java] freemarker.core.InvalidReferenceException: The following has 
> evaluated to null or missing:
>  [java] ==> null  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 56, 
> column 40]
>  [java] 
>  [java] 
>  [java] Tip: If the failing expression is known to be legally refer to 
> something that's null or missing, either specify a default value like 
> myOptionalVar!myDefault, or use <#if 
> myOptionalVar??>when-present<#else>when-missing. (These only cover the 
> last step of the expression; to cover the whole expression, use parenthesis: 
> (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??
>  [java] 
>  [java] 
>  [java] 
>  [java] FTL stack trace ("~" means nesting-related):
>  [java]   - Failed at: #assign product = null  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 56, 
> column 21]
>  [java]   - Reached through: #list quoteItems as quoteItem  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 52, 
> column 13]
> The main reason for this is because there is no concept of "null" in 
> FreeMarker 2.3, as the following thread explains: 
> http://ehc.ac/p/freemarker/discussion/2346/thread/85da30a4/  Not sure how to 
> go about fixing this error, the thread suggests setting the variable to the 
> string "null".
> There are other instances of this bug as well:
> $ grep -r "<#assign" * | grep "= null"
> applications/order/webapp/ordermgr/return/returnItems.ftl: 
> <#assign returnItemSubTotal = null >  <#-- otherwise the last item's might 
> carry over -->
> applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl:   
>  <#assign product = null> <#-- don't drag it along to the next iteration 
> -->
> applications/accounting/webapp/accounting/reports/DepositSlip.fo.ftl: 
><#assign creditCard = null/>
> framework/webtools/webapp/webtools/datafile/viewdatafile.ftl:<#assign 
> lastRecordName = null>
> Reproduction Steps:
> 1) Visit http://demo-stable-ofbiz.apache.org/ordermgr/control/FindRequest
> 2) Click "New Request"
> 3) Set
>   - Cust Request Type Id = Request for Quote
>   - Requesting Party = DemoCustomer
>   - Cust Request Name = Test Request
>   - Description = This is a test request
> 4) Click "Sumbit"
> 5) "Create Quote from request"
> 6) error will appear



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-6244) Incorporate the readme for the Manufacturing component

2015-04-11 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-6244.
--
   Resolution: Implemented
Fix Version/s: Upcoming Branch
 Assignee: Jacques Le Roux  (was: Pierre Smits)

Implemented at revision: 1672904  

> Incorporate the readme for the Manufacturing component
> --
>
> Key: OFBIZ-6244
> URL: https://issues.apache.org/jira/browse/OFBIZ-6244
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-6244-ManufacturingREADME.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-6143) Incorporate the readme for the projectmgr component

2015-04-11 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-6143.
--
   Resolution: Implemented
Fix Version/s: Upcoming Branch
 Assignee: Jacques Le Roux  (was: Pierre Smits)

Implemented at revision: 1672904  


> Incorporate the readme for the projectmgr component
> ---
>
> Key: OFBIZ-6143
> URL: https://issues.apache.org/jira/browse/OFBIZ-6143
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: specialpurpose/projectmgr
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-6143-ProjectMgr-README-v2.patch, 
> OFBIZ-6143-ProjectMgr-README.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-6240) Incorporate the readme for the scrum component

2015-04-11 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-6240.
--
   Resolution: Implemented
Fix Version/s: Upcoming Branch
 Assignee: Jacques Le Roux  (was: Pierre Smits)

Implemented at revision: 1672904 

> Incorporate the readme for the scrum component
> --
>
> Key: OFBIZ-6240
> URL: https://issues.apache.org/jira/browse/OFBIZ-6240
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: specialpurpose/scrum
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-6240-Scrum-README.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


buildbot failure in ASF Buildbot on ofbiz-trunk

2015-04-11 Thread buildbot
The Buildbot has detected a new failure on builder ofbiz-trunk while building 
ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/ofbiz-trunk/builds/824

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: lares_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-ofbiz-commit' 
triggered this build
Build Source Stamp: [branch ofbiz/trunk] 1672904
Blamelist: jleroux

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot





Re: svn commit: r1672486 - /ofbiz/site/release-notes-13.07.02.html

2015-04-11 Thread Jacques Le Roux

Le 11/04/2015 18:54, Jacopo Cappellato a écrit :

On Apr 10, 2015, at 6:09 AM, Jacques Le Roux  
wrote:


I believe it's convenient for users to at least be able to quickly discern bug 
fixes from the rest... Let's see other opinions indeed, at least those who care 
about delivering a better user experiences (too harsh here?)

It seems you have a very strong opinion about this:


I often have strong opinion :).


even if no one else seems to share your same concerns, I have updated the 
release notes including the categorizations you asked for;


Thanks Jacopo, I like it.


but if someone has a different opinion it doesn't mean that they don't care 
about users...


I agree, it's more about opinion expression. If some have a different one, then they should express it, else it's lazy consensus, in other word the 
community agree about the proposition.

I feel, we lack commitment at this level, I mean people expressing their 
opinion, if they have a different one of course.
We need more people involved not only in code and documentation (parts which are improving currently, great!) and such, but also in community 
decisions which are the fundamental ones.

OK, I'm maybe stressing things a bit too much on this trivial case ;) but I 
guess you get my point, in general...


Jacopo



Jacques


Re: svn commit: r1672486 - /ofbiz/site/release-notes-13.07.02.html

2015-04-11 Thread Jacopo Cappellato

On Apr 11, 2015, at 11:36 AM, Jacques Le Roux  
wrote:

> I feel, we lack commitment at this level, I mean people expressing their 
> opinion, if they have a different one of course

Expressing opinion is ok, but it is important, in order to build a good healthy 
environment, the way you express it. And if someone doesn't have an opinion, 
then it is fine and it is not a guilt (instead it is more annoying when someone 
has an opinion for everything).
In this specific case you implied that I and the ones that could agree with me 
or could be silent were the ones that didn't care about user experience.
This is not the case and in my opinion your proposal (that won because you were 
so strong about it) will not help users: I think that the users care about what 
has changed in the new release and not how the developers have categorized the 
changes (e.g. what is a "sub-task" or "task" etc..?).
But it is ok, this is a minor issue and I may be wrong.
In general I am happy about our community and users and I disagree about the 
negative perception that sometimes is expressed in this list.

Jacopo

Re: svn commit: r1672486 - /ofbiz/site/release-notes-13.07.02.html

2015-04-11 Thread Ron Wheeler

+1

Ron
On 11/04/2015 1:36 PM, Jacques Le Roux wrote:

Le 11/04/2015 18:54, Jacopo Cappellato a écrit :
On Apr 10, 2015, at 6:09 AM, Jacques Le Roux 
 wrote:


I believe it's convenient for users to at least be able to quickly 
discern bug fixes from the rest... Let's see other opinions indeed, 
at least those who care about delivering a better user experiences 
(too harsh here?)

It seems you have a very strong opinion about this:


I often have strong opinion :).

even if no one else seems to share your same concerns, I have updated 
the release notes including the categorizations you asked for;


Thanks Jacopo, I like it.

but if someone has a different opinion it doesn't mean that they 
don't care about users...


I agree, it's more about opinion expression. If some have a different 
one, then they should express it, else it's lazy consensus, in other 
word the community agree about the proposition.
I feel, we lack commitment at this level, I mean people expressing 
their opinion, if they have a different one of course.
We need more people involved not only in code and documentation (parts 
which are improving currently, great!) and such, but also in community 
decisions which are the fundamental ones.
OK, I'm maybe stressing things a bit too much on this trivial case ;) 
but I guess you get my point, in general...



Jacopo



Jacques




--
Ron Wheeler
President
Artifact Software Inc
email: rwhee...@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102



Re: svn commit: r1672486 - /ofbiz/site/release-notes-13.07.02.html

2015-04-11 Thread Pierre Smits
The categorisation is important, because bug fixes addresses a higher risk
level than improvements, new features and wishes. With the categorisaton
potential adopters have a quick overview to assess where to spend effort.

Best regards,

Pierre Smits

*ORRTIZ.COM *
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com

On Sat, Apr 11, 2015 at 7:56 PM, Ron Wheeler  wrote:

> +1
>
> Ron
>
> On 11/04/2015 1:36 PM, Jacques Le Roux wrote:
>
>> Le 11/04/2015 18:54, Jacopo Cappellato a écrit :
>>
>>> On Apr 10, 2015, at 6:09 AM, Jacques Le Roux <
>>> jacques.le.r...@les7arts.com> wrote:
>>>
>>>  I believe it's convenient for users to at least be able to quickly
 discern bug fixes from the rest... Let's see other opinions indeed, at
 least those who care about delivering a better user experiences (too harsh
 here?)

>>> It seems you have a very strong opinion about this:
>>>
>>
>> I often have strong opinion :).
>>
>>  even if no one else seems to share your same concerns, I have updated
>>> the release notes including the categorizations you asked for;
>>>
>>
>> Thanks Jacopo, I like it.
>>
>>  but if someone has a different opinion it doesn't mean that they don't
>>> care about users...
>>>
>>
>> I agree, it's more about opinion expression. If some have a different
>> one, then they should express it, else it's lazy consensus, in other word
>> the community agree about the proposition.
>> I feel, we lack commitment at this level, I mean people expressing their
>> opinion, if they have a different one of course.
>> We need more people involved not only in code and documentation (parts
>> which are improving currently, great!) and such, but also in community
>> decisions which are the fundamental ones.
>> OK, I'm maybe stressing things a bit too much on this trivial case ;) but
>> I guess you get my point, in general...
>>
>>  Jacopo
>>>
>>>
>> Jacques
>>
>>
>
> --
> Ron Wheeler
> President
> Artifact Software Inc
> email: rwhee...@artifact-software.com
> skype: ronaldmwheeler
> phone: 866-970-2435, ext 102
>
>


Re: svn commit: r1672486 - /ofbiz/site/release-notes-13.07.02.html

2015-04-11 Thread Pierre Smits
By the way, it is not just developers who create our JIRA issues and
(re)categorise these.

Best regards,

Pierre Smits

*ORRTIZ.COM *
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com

On Sat, Apr 11, 2015 at 8:18 PM, Pierre Smits 
wrote:

> The categorisation is important, because bug fixes addresses a higher risk
> level than improvements, new features and wishes. With the categorisaton
> potential adopters have a quick overview to assess where to spend effort.
>
> Best regards,
>
> Pierre Smits
>
> *ORRTIZ.COM *
> Services & Solutions for Cloud-
> Based Manufacturing, Professional
> Services and Retail & Trade
> http://www.orrtiz.com
>
> On Sat, Apr 11, 2015 at 7:56 PM, Ron Wheeler <
> rwhee...@artifact-software.com> wrote:
>
>> +1
>>
>> Ron
>>
>> On 11/04/2015 1:36 PM, Jacques Le Roux wrote:
>>
>>> Le 11/04/2015 18:54, Jacopo Cappellato a écrit :
>>>
 On Apr 10, 2015, at 6:09 AM, Jacques Le Roux <
 jacques.le.r...@les7arts.com> wrote:

  I believe it's convenient for users to at least be able to quickly
> discern bug fixes from the rest... Let's see other opinions indeed, at
> least those who care about delivering a better user experiences (too harsh
> here?)
>
 It seems you have a very strong opinion about this:

>>>
>>> I often have strong opinion :).
>>>
>>>  even if no one else seems to share your same concerns, I have updated
 the release notes including the categorizations you asked for;

>>>
>>> Thanks Jacopo, I like it.
>>>
>>>  but if someone has a different opinion it doesn't mean that they don't
 care about users...

>>>
>>> I agree, it's more about opinion expression. If some have a different
>>> one, then they should express it, else it's lazy consensus, in other word
>>> the community agree about the proposition.
>>> I feel, we lack commitment at this level, I mean people expressing their
>>> opinion, if they have a different one of course.
>>> We need more people involved not only in code and documentation (parts
>>> which are improving currently, great!) and such, but also in community
>>> decisions which are the fundamental ones.
>>> OK, I'm maybe stressing things a bit too much on this trivial case ;)
>>> but I guess you get my point, in general...
>>>
>>>  Jacopo


>>> Jacques
>>>
>>>
>>
>> --
>> Ron Wheeler
>> President
>> Artifact Software Inc
>> email: rwhee...@artifact-software.com
>> skype: ronaldmwheeler
>> phone: 866-970-2435, ext 102
>>
>>
>


[jira] [Commented] (OFBIZ-6057) Quote item view FreeMarker error message due to changes made in OFBIZ-2120

2015-04-11 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14491142#comment-14491142
 ] 

Jacques Le Roux commented on OFBIZ-6057:


Since I reopened, I believe I can change the "Affects Version/s:" and "Fix 
Version/s:" fields, et voilà, why a new issues?

> Quote item view FreeMarker error message due to changes made in OFBIZ-2120
> --
>
> Key: OFBIZ-6057
> URL: https://issues.apache.org/jira/browse/OFBIZ-6057
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting, order
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Release 
> Branch 14.12, Trunk
> Environment: Linux
>Reporter: Forrest Rae
>Assignee: Deepak Dixit
> Fix For: 14.12.01, 13.07.02, Upcoming Branch
>
>
> In order to fix OFBIZ-2120, code was added to the 
> applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl file at lines 
> 53 through 57, with the offending line being at 5:
> https://github.com/apache/ofbiz/blob/trunk/applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl##L56
> Here is the commit: 
> https://github.com/apache/ofbiz/commit/27253c4667e87721212fa8955d75c74a0d171c73
> This ends up causing the following error:
>  [java] freemarker.core.InvalidReferenceException: The following has 
> evaluated to null or missing:
>  [java] ==> null  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 56, 
> column 40]
>  [java] 
>  [java] 
>  [java] Tip: If the failing expression is known to be legally refer to 
> something that's null or missing, either specify a default value like 
> myOptionalVar!myDefault, or use <#if 
> myOptionalVar??>when-present<#else>when-missing. (These only cover the 
> last step of the expression; to cover the whole expression, use parenthesis: 
> (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??
>  [java] 
>  [java] 
>  [java] 
>  [java] FTL stack trace ("~" means nesting-related):
>  [java]   - Failed at: #assign product = null  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 56, 
> column 21]
>  [java]   - Reached through: #list quoteItems as quoteItem  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 52, 
> column 13]
> The main reason for this is because there is no concept of "null" in 
> FreeMarker 2.3, as the following thread explains: 
> http://ehc.ac/p/freemarker/discussion/2346/thread/85da30a4/  Not sure how to 
> go about fixing this error, the thread suggests setting the variable to the 
> string "null".
> There are other instances of this bug as well:
> $ grep -r "<#assign" * | grep "= null"
> applications/order/webapp/ordermgr/return/returnItems.ftl: 
> <#assign returnItemSubTotal = null >  <#-- otherwise the last item's might 
> carry over -->
> applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl:   
>  <#assign product = null> <#-- don't drag it along to the next iteration 
> -->
> applications/accounting/webapp/accounting/reports/DepositSlip.fo.ftl: 
><#assign creditCard = null/>
> framework/webtools/webapp/webtools/datafile/viewdatafile.ftl:<#assign 
> lastRecordName = null>
> Reproduction Steps:
> 1) Visit http://demo-stable-ofbiz.apache.org/ordermgr/control/FindRequest
> 2) Click "New Request"
> 3) Set
>   - Cust Request Type Id = Request for Quote
>   - Requesting Party = DemoCustomer
>   - Cust Request Name = Test Request
>   - Description = This is a test request
> 4) Click "Sumbit"
> 5) "Create Quote from request"
> 6) error will appear



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6057) Quote item view FreeMarker error message due to changes made in OFBIZ-2120

2015-04-11 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-6057:
---
Affects Version/s: Release Branch 12.04
   Release Branch 14.12
   Trunk

> Quote item view FreeMarker error message due to changes made in OFBIZ-2120
> --
>
> Key: OFBIZ-6057
> URL: https://issues.apache.org/jira/browse/OFBIZ-6057
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting, order
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Release 
> Branch 14.12, Trunk
> Environment: Linux
>Reporter: Forrest Rae
>Assignee: Deepak Dixit
> Fix For: 14.12.01, 13.07.02, Upcoming Branch
>
>
> In order to fix OFBIZ-2120, code was added to the 
> applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl file at lines 
> 53 through 57, with the offending line being at 5:
> https://github.com/apache/ofbiz/blob/trunk/applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl##L56
> Here is the commit: 
> https://github.com/apache/ofbiz/commit/27253c4667e87721212fa8955d75c74a0d171c73
> This ends up causing the following error:
>  [java] freemarker.core.InvalidReferenceException: The following has 
> evaluated to null or missing:
>  [java] ==> null  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 56, 
> column 40]
>  [java] 
>  [java] 
>  [java] Tip: If the failing expression is known to be legally refer to 
> something that's null or missing, either specify a default value like 
> myOptionalVar!myDefault, or use <#if 
> myOptionalVar??>when-present<#else>when-missing. (These only cover the 
> last step of the expression; to cover the whole expression, use parenthesis: 
> (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??
>  [java] 
>  [java] 
>  [java] 
>  [java] FTL stack trace ("~" means nesting-related):
>  [java]   - Failed at: #assign product = null  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 56, 
> column 21]
>  [java]   - Reached through: #list quoteItems as quoteItem  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 52, 
> column 13]
> The main reason for this is because there is no concept of "null" in 
> FreeMarker 2.3, as the following thread explains: 
> http://ehc.ac/p/freemarker/discussion/2346/thread/85da30a4/  Not sure how to 
> go about fixing this error, the thread suggests setting the variable to the 
> string "null".
> There are other instances of this bug as well:
> $ grep -r "<#assign" * | grep "= null"
> applications/order/webapp/ordermgr/return/returnItems.ftl: 
> <#assign returnItemSubTotal = null >  <#-- otherwise the last item's might 
> carry over -->
> applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl:   
>  <#assign product = null> <#-- don't drag it along to the next iteration 
> -->
> applications/accounting/webapp/accounting/reports/DepositSlip.fo.ftl: 
><#assign creditCard = null/>
> framework/webtools/webapp/webtools/datafile/viewdatafile.ftl:<#assign 
> lastRecordName = null>
> Reproduction Steps:
> 1) Visit http://demo-stable-ofbiz.apache.org/ordermgr/control/FindRequest
> 2) Click "New Request"
> 3) Set
>   - Cust Request Type Id = Request for Quote
>   - Requesting Party = DemoCustomer
>   - Cust Request Name = Test Request
>   - Description = This is a test request
> 4) Click "Sumbit"
> 5) "Create Quote from request"
> 6) error will appear



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (OFBIZ-6057) Quote item view FreeMarker error message due to changes made in OFBIZ-2120

2015-04-11 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14491142#comment-14491142
 ] 

Jacques Le Roux edited comment on OFBIZ-6057 at 4/11/15 6:33 PM:
-

Since I reopened, I believe I can change the "Affects Version/s:" and "Fix 
Version/s:" fields, et voilà, why a new issue?

I'm not sure I got your point "otherwise the fixes for the already fixed 
branches will not appear in the release notes." Did I miss something?



was (Author: jacques.le.roux):
Since I reopened, I believe I can change the "Affects Version/s:" and "Fix 
Version/s:" fields, et voilà, why a new issues?

> Quote item view FreeMarker error message due to changes made in OFBIZ-2120
> --
>
> Key: OFBIZ-6057
> URL: https://issues.apache.org/jira/browse/OFBIZ-6057
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting, order
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Release 
> Branch 14.12, Trunk
> Environment: Linux
>Reporter: Forrest Rae
>Assignee: Deepak Dixit
> Fix For: 14.12.01, 13.07.02, Upcoming Branch
>
>
> In order to fix OFBIZ-2120, code was added to the 
> applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl file at lines 
> 53 through 57, with the offending line being at 5:
> https://github.com/apache/ofbiz/blob/trunk/applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl##L56
> Here is the commit: 
> https://github.com/apache/ofbiz/commit/27253c4667e87721212fa8955d75c74a0d171c73
> This ends up causing the following error:
>  [java] freemarker.core.InvalidReferenceException: The following has 
> evaluated to null or missing:
>  [java] ==> null  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 56, 
> column 40]
>  [java] 
>  [java] 
>  [java] Tip: If the failing expression is known to be legally refer to 
> something that's null or missing, either specify a default value like 
> myOptionalVar!myDefault, or use <#if 
> myOptionalVar??>when-present<#else>when-missing. (These only cover the 
> last step of the expression; to cover the whole expression, use parenthesis: 
> (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??
>  [java] 
>  [java] 
>  [java] 
>  [java] FTL stack trace ("~" means nesting-related):
>  [java]   - Failed at: #assign product = null  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 56, 
> column 21]
>  [java]   - Reached through: #list quoteItems as quoteItem  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 52, 
> column 13]
> The main reason for this is because there is no concept of "null" in 
> FreeMarker 2.3, as the following thread explains: 
> http://ehc.ac/p/freemarker/discussion/2346/thread/85da30a4/  Not sure how to 
> go about fixing this error, the thread suggests setting the variable to the 
> string "null".
> There are other instances of this bug as well:
> $ grep -r "<#assign" * | grep "= null"
> applications/order/webapp/ordermgr/return/returnItems.ftl: 
> <#assign returnItemSubTotal = null >  <#-- otherwise the last item's might 
> carry over -->
> applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl:   
>  <#assign product = null> <#-- don't drag it along to the next iteration 
> -->
> applications/accounting/webapp/accounting/reports/DepositSlip.fo.ftl: 
><#assign creditCard = null/>
> framework/webtools/webapp/webtools/datafile/viewdatafile.ftl:<#assign 
> lastRecordName = null>
> Reproduction Steps:
> 1) Visit http://demo-stable-ofbiz.apache.org/ordermgr/control/FindRequest
> 2) Click "New Request"
> 3) Set
>   - Cust Request Type Id = Request for Quote
>   - Requesting Party = DemoCustomer
>   - Cust Request Name = Test Request
>   - Description = This is a test request
> 4) Click "Sumbit"
> 5) "Create Quote from request"
> 6) error will appear



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-6247) Have a placeholder for the AssetMaint application

2015-04-11 Thread Pierre Smits (JIRA)
Pierre Smits created OFBIZ-6247:
---

 Summary: Have a placeholder for the AssetMaint application
 Key: OFBIZ-6247
 URL: https://issues.apache.org/jira/browse/OFBIZ-6247
 Project: OFBiz
  Issue Type: Sub-task
  Components: specialpurpose/assetmaint
Affects Versions: Trunk
Reporter: Pierre Smits






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-6248) Have a placeholder for the IS Mgr application

2015-04-11 Thread Pierre Smits (JIRA)
Pierre Smits created OFBIZ-6248:
---

 Summary: Have a placeholder for the IS Mgr application
 Key: OFBIZ-6248
 URL: https://issues.apache.org/jira/browse/OFBIZ-6248
 Project: OFBiz
  Issue Type: Sub-task
  Components: specialpurpose/assetmaint
Affects Versions: Trunk
Reporter: Pierre Smits






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6057) Quote item view FreeMarker error message due to changes made in OFBIZ-2120

2015-04-11 Thread Jacopo Cappellato (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14491192#comment-14491192
 ] 

Jacopo Cappellato commented on OFBIZ-6057:
--

Until it will be closed it will disappears from the release notes, even the 
ones of the releases that are already fixed.
This is what I meant.

> Quote item view FreeMarker error message due to changes made in OFBIZ-2120
> --
>
> Key: OFBIZ-6057
> URL: https://issues.apache.org/jira/browse/OFBIZ-6057
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting, order
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Release 
> Branch 14.12, Trunk
> Environment: Linux
>Reporter: Forrest Rae
>Assignee: Deepak Dixit
> Fix For: 14.12.01, 13.07.02, Upcoming Branch
>
>
> In order to fix OFBIZ-2120, code was added to the 
> applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl file at lines 
> 53 through 57, with the offending line being at 5:
> https://github.com/apache/ofbiz/blob/trunk/applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl##L56
> Here is the commit: 
> https://github.com/apache/ofbiz/commit/27253c4667e87721212fa8955d75c74a0d171c73
> This ends up causing the following error:
>  [java] freemarker.core.InvalidReferenceException: The following has 
> evaluated to null or missing:
>  [java] ==> null  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 56, 
> column 40]
>  [java] 
>  [java] 
>  [java] Tip: If the failing expression is known to be legally refer to 
> something that's null or missing, either specify a default value like 
> myOptionalVar!myDefault, or use <#if 
> myOptionalVar??>when-present<#else>when-missing. (These only cover the 
> last step of the expression; to cover the whole expression, use parenthesis: 
> (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??
>  [java] 
>  [java] 
>  [java] 
>  [java] FTL stack trace ("~" means nesting-related):
>  [java]   - Failed at: #assign product = null  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 56, 
> column 21]
>  [java]   - Reached through: #list quoteItems as quoteItem  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 52, 
> column 13]
> The main reason for this is because there is no concept of "null" in 
> FreeMarker 2.3, as the following thread explains: 
> http://ehc.ac/p/freemarker/discussion/2346/thread/85da30a4/  Not sure how to 
> go about fixing this error, the thread suggests setting the variable to the 
> string "null".
> There are other instances of this bug as well:
> $ grep -r "<#assign" * | grep "= null"
> applications/order/webapp/ordermgr/return/returnItems.ftl: 
> <#assign returnItemSubTotal = null >  <#-- otherwise the last item's might 
> carry over -->
> applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl:   
>  <#assign product = null> <#-- don't drag it along to the next iteration 
> -->
> applications/accounting/webapp/accounting/reports/DepositSlip.fo.ftl: 
><#assign creditCard = null/>
> framework/webtools/webapp/webtools/datafile/viewdatafile.ftl:<#assign 
> lastRecordName = null>
> Reproduction Steps:
> 1) Visit http://demo-stable-ofbiz.apache.org/ordermgr/control/FindRequest
> 2) Click "New Request"
> 3) Set
>   - Cust Request Type Id = Request for Quote
>   - Requesting Party = DemoCustomer
>   - Cust Request Name = Test Request
>   - Description = This is a test request
> 4) Click "Sumbit"
> 5) "Create Quote from request"
> 6) error will appear



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-6248) Have a placeholder for the IS Mgr application

2015-04-11 Thread Pierre Smits (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits closed OFBIZ-6248.
---
Resolution: Won't Fix

The IS Mgr application isn't worthy of the classification. 

> Have a placeholder for the IS Mgr application
> -
>
> Key: OFBIZ-6248
> URL: https://issues.apache.org/jira/browse/OFBIZ-6248
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: specialpurpose/assetmaint
>Affects Versions: Trunk
>Reporter: Pierre Smits
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-6057) Quote item view FreeMarker error message due to changes made in OFBIZ-2120

2015-04-11 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-6057.
--
Resolution: Incomplete

> Quote item view FreeMarker error message due to changes made in OFBIZ-2120
> --
>
> Key: OFBIZ-6057
> URL: https://issues.apache.org/jira/browse/OFBIZ-6057
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting, order
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Release 
> Branch 14.12, Trunk
> Environment: Linux
>Reporter: Forrest Rae
>Assignee: Deepak Dixit
> Fix For: 14.12.01, 13.07.02, Upcoming Branch
>
>
> In order to fix OFBIZ-2120, code was added to the 
> applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl file at lines 
> 53 through 57, with the offending line being at 5:
> https://github.com/apache/ofbiz/blob/trunk/applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl##L56
> Here is the commit: 
> https://github.com/apache/ofbiz/commit/27253c4667e87721212fa8955d75c74a0d171c73
> This ends up causing the following error:
>  [java] freemarker.core.InvalidReferenceException: The following has 
> evaluated to null or missing:
>  [java] ==> null  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 56, 
> column 40]
>  [java] 
>  [java] 
>  [java] Tip: If the failing expression is known to be legally refer to 
> something that's null or missing, either specify a default value like 
> myOptionalVar!myDefault, or use <#if 
> myOptionalVar??>when-present<#else>when-missing. (These only cover the 
> last step of the expression; to cover the whole expression, use parenthesis: 
> (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??
>  [java] 
>  [java] 
>  [java] 
>  [java] FTL stack trace ("~" means nesting-related):
>  [java]   - Failed at: #assign product = null  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 56, 
> column 21]
>  [java]   - Reached through: #list quoteItems as quoteItem  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 52, 
> column 13]
> The main reason for this is because there is no concept of "null" in 
> FreeMarker 2.3, as the following thread explains: 
> http://ehc.ac/p/freemarker/discussion/2346/thread/85da30a4/  Not sure how to 
> go about fixing this error, the thread suggests setting the variable to the 
> string "null".
> There are other instances of this bug as well:
> $ grep -r "<#assign" * | grep "= null"
> applications/order/webapp/ordermgr/return/returnItems.ftl: 
> <#assign returnItemSubTotal = null >  <#-- otherwise the last item's might 
> carry over -->
> applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl:   
>  <#assign product = null> <#-- don't drag it along to the next iteration 
> -->
> applications/accounting/webapp/accounting/reports/DepositSlip.fo.ftl: 
><#assign creditCard = null/>
> framework/webtools/webapp/webtools/datafile/viewdatafile.ftl:<#assign 
> lastRecordName = null>
> Reproduction Steps:
> 1) Visit http://demo-stable-ofbiz.apache.org/ordermgr/control/FindRequest
> 2) Click "New Request"
> 3) Set
>   - Cust Request Type Id = Request for Quote
>   - Requesting Party = DemoCustomer
>   - Cust Request Name = Test Request
>   - Description = This is a test request
> 4) Click "Sumbit"
> 5) "Create Quote from request"
> 6) error will appear



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6057) Quote item view FreeMarker error message due to changes made in OFBIZ-2120

2015-04-11 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14491196#comment-14491196
 ] 

Jacques Le Roux commented on OFBIZ-6057:


Ho, I see your point, you have released R13.07.02 already. OK I close here... 
but we need more work for this to be really closed, only a part has been done. 
I mean not only on R12.04 but all the rest, quoting the description:
{quote}
$ grep -r "<#assign" * | grep "= null"
applications/order/webapp/ordermgr/return/returnItems.ftl: <#assign 
returnItemSubTotal = null > <#-- otherwise the last item's might carry over -->
applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl: <#assign 
product = null> <#-- don't drag it along to the next iteration -->
applications/accounting/webapp/accounting/reports/DepositSlip.fo.ftl: <#assign 
creditCard = null/>
framework/webtools/webapp/webtools/datafile/viewdatafile.ftl: <#assign 
lastRecordName = null>
{quote}

Anyway I agree, because of the release of R13.07.02, I will

> Quote item view FreeMarker error message due to changes made in OFBIZ-2120
> --
>
> Key: OFBIZ-6057
> URL: https://issues.apache.org/jira/browse/OFBIZ-6057
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting, order
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Release 
> Branch 14.12, Trunk
> Environment: Linux
>Reporter: Forrest Rae
>Assignee: Deepak Dixit
> Fix For: 14.12.01, 13.07.02, Upcoming Branch
>
>
> In order to fix OFBIZ-2120, code was added to the 
> applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl file at lines 
> 53 through 57, with the offending line being at 5:
> https://github.com/apache/ofbiz/blob/trunk/applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl##L56
> Here is the commit: 
> https://github.com/apache/ofbiz/commit/27253c4667e87721212fa8955d75c74a0d171c73
> This ends up causing the following error:
>  [java] freemarker.core.InvalidReferenceException: The following has 
> evaluated to null or missing:
>  [java] ==> null  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 56, 
> column 40]
>  [java] 
>  [java] 
>  [java] Tip: If the failing expression is known to be legally refer to 
> something that's null or missing, either specify a default value like 
> myOptionalVar!myDefault, or use <#if 
> myOptionalVar??>when-present<#else>when-missing. (These only cover the 
> last step of the expression; to cover the whole expression, use parenthesis: 
> (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??
>  [java] 
>  [java] 
>  [java] 
>  [java] FTL stack trace ("~" means nesting-related):
>  [java]   - Failed at: #assign product = null  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 56, 
> column 21]
>  [java]   - Reached through: #list quoteItems as quoteItem  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 52, 
> column 13]
> The main reason for this is because there is no concept of "null" in 
> FreeMarker 2.3, as the following thread explains: 
> http://ehc.ac/p/freemarker/discussion/2346/thread/85da30a4/  Not sure how to 
> go about fixing this error, the thread suggests setting the variable to the 
> string "null".
> There are other instances of this bug as well:
> $ grep -r "<#assign" * | grep "= null"
> applications/order/webapp/ordermgr/return/returnItems.ftl: 
> <#assign returnItemSubTotal = null >  <#-- otherwise the last item's might 
> carry over -->
> applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl:   
>  <#assign product = null> <#-- don't drag it along to the next iteration 
> -->
> applications/accounting/webapp/accounting/reports/DepositSlip.fo.ftl: 
><#assign creditCard = null/>
> framework/webtools/webapp/webtools/datafile/viewdatafile.ftl:<#assign 
> lastRecordName = null>
> Reproduction Steps:
> 1) Visit http://demo-stable-ofbiz.apache.org/ordermgr/control/FindRequest
> 2) Click "New Request"
> 3) Set
>   - Cust Request Type Id = Request for Quote
>   - Requesting Party = DemoCustomer
>   - Cust Request Name = Test Request
>   - Description = This is a test request
> 4) Click "Sumbit"
> 5) "Create Quote from request"
> 6) error will appear



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-6249) Complete OFBIZ-6057

2015-04-11 Thread Jacques Le Roux (JIRA)
Jacques Le Roux created OFBIZ-6249:
--

 Summary: Complete OFBIZ-6057
 Key: OFBIZ-6249
 URL: https://issues.apache.org/jira/browse/OFBIZ-6249
 Project: OFBiz
  Issue Type: Bug
  Components: accounting, order
Affects Versions: Trunk, Release Branch 14.12, Release Branch 13.07, 
Release Branch 12.04
Reporter: Jacques Le Roux


See OFBIZ-6057 for now, I will complete here when I will get a chance...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6057) Quote item view FreeMarker error message due to changes made in OFBIZ-2120

2015-04-11 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14491198#comment-14491198
 ] 

Jacques Le Roux commented on OFBIZ-6057:


I created OFBIZ-6249 (raw for now)

> Quote item view FreeMarker error message due to changes made in OFBIZ-2120
> --
>
> Key: OFBIZ-6057
> URL: https://issues.apache.org/jira/browse/OFBIZ-6057
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting, order
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Release 
> Branch 14.12, Trunk
> Environment: Linux
>Reporter: Forrest Rae
>Assignee: Deepak Dixit
> Fix For: 14.12.01, 13.07.02, Upcoming Branch
>
>
> In order to fix OFBIZ-2120, code was added to the 
> applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl file at lines 
> 53 through 57, with the offending line being at 5:
> https://github.com/apache/ofbiz/blob/trunk/applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl##L56
> Here is the commit: 
> https://github.com/apache/ofbiz/commit/27253c4667e87721212fa8955d75c74a0d171c73
> This ends up causing the following error:
>  [java] freemarker.core.InvalidReferenceException: The following has 
> evaluated to null or missing:
>  [java] ==> null  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 56, 
> column 40]
>  [java] 
>  [java] 
>  [java] Tip: If the failing expression is known to be legally refer to 
> something that's null or missing, either specify a default value like 
> myOptionalVar!myDefault, or use <#if 
> myOptionalVar??>when-present<#else>when-missing. (These only cover the 
> last step of the expression; to cover the whole expression, use parenthesis: 
> (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??
>  [java] 
>  [java] 
>  [java] 
>  [java] FTL stack trace ("~" means nesting-related):
>  [java]   - Failed at: #assign product = null  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 56, 
> column 21]
>  [java]   - Reached through: #list quoteItems as quoteItem  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 52, 
> column 13]
> The main reason for this is because there is no concept of "null" in 
> FreeMarker 2.3, as the following thread explains: 
> http://ehc.ac/p/freemarker/discussion/2346/thread/85da30a4/  Not sure how to 
> go about fixing this error, the thread suggests setting the variable to the 
> string "null".
> There are other instances of this bug as well:
> $ grep -r "<#assign" * | grep "= null"
> applications/order/webapp/ordermgr/return/returnItems.ftl: 
> <#assign returnItemSubTotal = null >  <#-- otherwise the last item's might 
> carry over -->
> applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl:   
>  <#assign product = null> <#-- don't drag it along to the next iteration 
> -->
> applications/accounting/webapp/accounting/reports/DepositSlip.fo.ftl: 
><#assign creditCard = null/>
> framework/webtools/webapp/webtools/datafile/viewdatafile.ftl:<#assign 
> lastRecordName = null>
> Reproduction Steps:
> 1) Visit http://demo-stable-ofbiz.apache.org/ordermgr/control/FindRequest
> 2) Click "New Request"
> 3) Set
>   - Cust Request Type Id = Request for Quote
>   - Requesting Party = DemoCustomer
>   - Cust Request Name = Test Request
>   - Description = This is a test request
> 4) Click "Sumbit"
> 5) "Create Quote from request"
> 6) error will appear



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


  1   2   >