[jira] [Closed] (OFBIZ-6380) Update Log4j 2.2 to 2.3

2015-05-20 Thread Jacopo Cappellato (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato closed OFBIZ-6380.

Resolution: Fixed

The upgrade is done with the following revisions:
trunk 1680733
14.12 1680736
13.07 1680738

> Update Log4j 2.2 to 2.3
> ---
>
> Key: OFBIZ-6380
> URL: https://issues.apache.org/jira/browse/OFBIZ-6380
> Project: OFBiz
>  Issue Type: Task
>  Components: framework
>Affects Versions: Release Branch 14.12, Trunk, 13.07.01
>Reporter: Jacques Le Roux
>Assignee: Jacopo Cappellato
>Priority: Trivial
> Fix For: 14.12.01, 13.07.03, Upcoming Branch
>
>
> http://logging.apache.org/log4j/2.x/changes-report.html#a2.3



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Reopened] (OFBIZ-4480) Need to have an option to pass file name as OrderId for the generated confirmation or invoice PDF.

2015-05-20 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit reopened OFBIZ-4480:
-

> Need to have an option to pass file name as OrderId for the generated 
> confirmation or invoice PDF.
> --
>
> Key: OFBIZ-4480
> URL: https://issues.apache.org/jira/browse/OFBIZ-4480
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Upcoming Branch
> Environment: OS - Ubuntu 
>Reporter: Ganesh Bawne
>Assignee: Michael Brohl
>  Labels: filename, order, pdf
> Fix For: Release Branch 14.12, Trunk
>
> Attachments: orderPdf-FileName.patch
>
>
> Need to have set the order pdf file name to its order number when we open the 
> pdf from backoffice orderdetail page 
> (/ordermgr/control/order.pdf?orderId=X).
> Currently, the default name of the pdf is always "order.pdf", instead need to 
> have an option to set the default pdf name to its order number?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-4480) Need to have an option to pass file name as OrderId for the generated confirmation or invoice PDF.

2015-05-20 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14553692#comment-14553692
 ] 

Deepak Dixit commented on OFBIZ-4480:
-

Pick Sheet pdf also using the OrderId.pdf pattern.


> Need to have an option to pass file name as OrderId for the generated 
> confirmation or invoice PDF.
> --
>
> Key: OFBIZ-4480
> URL: https://issues.apache.org/jira/browse/OFBIZ-4480
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Upcoming Branch
> Environment: OS - Ubuntu 
>Reporter: Ganesh Bawne
>Assignee: Michael Brohl
>  Labels: filename, order, pdf
> Fix For: Release Branch 14.12, Trunk
>
> Attachments: orderPdf-FileName.patch
>
>
> Need to have set the order pdf file name to its order number when we open the 
> pdf from backoffice orderdetail page 
> (/ordermgr/control/order.pdf?orderId=X).
> Currently, the default name of the pdf is always "order.pdf", instead need to 
> have an option to set the default pdf name to its order number?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6380) Update Log4j 2.2 to 2.3

2015-05-20 Thread Jacopo Cappellato (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-6380:
-
Fix Version/s: 13.07.03

> Update Log4j 2.2 to 2.3
> ---
>
> Key: OFBIZ-6380
> URL: https://issues.apache.org/jira/browse/OFBIZ-6380
> Project: OFBiz
>  Issue Type: Task
>  Components: framework
>Affects Versions: Release Branch 14.12, Trunk, 13.07.01
>Reporter: Jacques Le Roux
>Assignee: Jacopo Cappellato
>Priority: Trivial
> Fix For: 14.12.01, 13.07.03, Upcoming Branch
>
>
> http://logging.apache.org/log4j/2.x/changes-report.html#a2.3



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6380) Update Log4j 2.2 to 2.3

2015-05-20 Thread Jacopo Cappellato (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-6380:
-
Fix Version/s: (was: 13.07.02)
   14.12.01

> Update Log4j 2.2 to 2.3
> ---
>
> Key: OFBIZ-6380
> URL: https://issues.apache.org/jira/browse/OFBIZ-6380
> Project: OFBiz
>  Issue Type: Task
>  Components: framework
>Affects Versions: Release Branch 14.12, Trunk, 13.07.01
>Reporter: Jacques Le Roux
>Assignee: Jacopo Cappellato
>Priority: Trivial
> Fix For: 14.12.01, Upcoming Branch
>
>
> http://logging.apache.org/log4j/2.x/changes-report.html#a2.3



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-6380) Update Log4j 2.2 to 2.3

2015-05-20 Thread Jacopo Cappellato (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato reassigned OFBIZ-6380:


Assignee: Jacopo Cappellato  (was: Jacques Le Roux)

> Update Log4j 2.2 to 2.3
> ---
>
> Key: OFBIZ-6380
> URL: https://issues.apache.org/jira/browse/OFBIZ-6380
> Project: OFBiz
>  Issue Type: Task
>  Components: framework
>Affects Versions: Release Branch 14.12, Trunk, 13.07.01
>Reporter: Jacques Le Roux
>Assignee: Jacopo Cappellato
>Priority: Trivial
> Fix For: 13.07.02, Upcoming Branch
>
>
> http://logging.apache.org/log4j/2.x/changes-report.html#a2.3



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-6317) Missing BIRT libs in eclipse .classpath file

2015-05-20 Thread Michael Brohl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl reassigned OFBIZ-6317:


Assignee: Michael Brohl

> Missing BIRT libs in eclipse .classpath file
> 
>
> Key: OFBIZ-6317
> URL: https://issues.apache.org/jira/browse/OFBIZ-6317
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework, specialpurpose/birt
>Affects Versions: Trunk
>Reporter: Martin Becker
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-6317.patch
>
>
> Because of missing JARs from the specialpurpose component birt in the eclipse 
> .classpath file OFBiz could not be startet within eclipse without errors 
> (NoClassDefFoundError while starting birt component).
> With "starting within eclipse" I mean the configuration with hot code 
> replacement like this: 
> https://cwiki.apache.org/confluence/display/OFBIZ/Running+and+Debugging+OFBiz+in+Eclipse#RunningandDebuggingOFBizinEclipse-debuggingInEclipseHotClasses
> I will provide a patch for the .classpath file with 4 added libs from the 
> specialpurpose/birt/lib folder.
> It would be beneficial, at least for simple contribution of jira issue fixes, 
> if the default configuration of OFBiz from trunk is runnable as is (in a 
> common development scenario like the above), without the need to modify 
> config files which are under version control (.classpath for example). The 
> alternative could be to not put files under version control, that are related 
> to individual development environments.
> By the way, it would also be nice to have the framework/base/config folder as 
> src in the .classpath file as described in the wiki article above, so that 
> the configuration of an eclipse debug/run target for starting OFBiz in 
> eclipse is done by only selecting the project + start-class and giving some 
> JVM args.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


buildbot failure in ASF Buildbot on ofbiz-trunk

2015-05-20 Thread buildbot
The Buildbot has detected a new failure on builder ofbiz-trunk while building 
ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/ofbiz-trunk/builds/894

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: lares_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-ofbiz-commit' 
triggered this build
Build Source Stamp: [branch ofbiz/trunk] 1680675
Blamelist: mbrohl

BUILD FAILED: failed

Sincerely,
 -The Buildbot





[jira] [Closed] (OFBIZ-6238) Give the order notification email attachment the orderId as filename

2015-05-20 Thread Michael Brohl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-6238.


improved in
trunk r1680675
release 14.12 r1680675

Thanks Martin for reporting and providing the patch.

> Give the order notification email attachment the orderId as filename
> 
>
> Key: OFBIZ-6238
> URL: https://issues.apache.org/jira/browse/OFBIZ-6238
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Upcoming Branch
>Reporter: Martin Becker
>Assignee: Michael Brohl
>Priority: Trivial
> Fix For: Release Branch 14.12, Trunk
>
> Attachments: OrderServices.patch
>
>
> According to customer needs I've made a change to 
> OrderServices.sendOrderNotificationScreen to fill the attachmentName 
> parameter of the sendMailFromScreen context with the orderId to override the 
> default in sendMailFromScreen, so that the PDF attachments in standard order 
> notifications have a name like "WS10001.pdf" instead of "Details.pdf"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6238) Give the order notification email attachment the orderId as filename

2015-05-20 Thread Michael Brohl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-6238:
-
Affects Version/s: (was: Trunk)
   Upcoming Branch

> Give the order notification email attachment the orderId as filename
> 
>
> Key: OFBIZ-6238
> URL: https://issues.apache.org/jira/browse/OFBIZ-6238
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Upcoming Branch
>Reporter: Martin Becker
>Assignee: Michael Brohl
>Priority: Trivial
> Fix For: Release Branch 14.12, Trunk
>
> Attachments: OrderServices.patch
>
>
> According to customer needs I've made a change to 
> OrderServices.sendOrderNotificationScreen to fill the attachmentName 
> parameter of the sendMailFromScreen context with the orderId to override the 
> default in sendMailFromScreen, so that the PDF attachments in standard order 
> notifications have a name like "WS10001.pdf" instead of "Details.pdf"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6238) Give the order notification email attachment the orderId as filename

2015-05-20 Thread Michael Brohl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-6238:
-
Fix Version/s: Release Branch 14.12
   Trunk

> Give the order notification email attachment the orderId as filename
> 
>
> Key: OFBIZ-6238
> URL: https://issues.apache.org/jira/browse/OFBIZ-6238
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Upcoming Branch
>Reporter: Martin Becker
>Assignee: Michael Brohl
>Priority: Trivial
> Fix For: Release Branch 14.12, Trunk
>
> Attachments: OrderServices.patch
>
>
> According to customer needs I've made a change to 
> OrderServices.sendOrderNotificationScreen to fill the attachmentName 
> parameter of the sendMailFromScreen context with the orderId to override the 
> default in sendMailFromScreen, so that the PDF attachments in standard order 
> notifications have a name like "WS10001.pdf" instead of "Details.pdf"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-4480) Need to have an option to pass file name as OrderId for the generated confirmation or invoice PDF.

2015-05-20 Thread Michael Brohl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-4480.


improved in
trunk r1680671
release 14.12 r1680672

I'm closing this issue because the initial intent is done with it. There are 
some interesting additional thoughts for better file export / view handling in 
the comments. Please file an new issue if you want to work on them further.

> Need to have an option to pass file name as OrderId for the generated 
> confirmation or invoice PDF.
> --
>
> Key: OFBIZ-4480
> URL: https://issues.apache.org/jira/browse/OFBIZ-4480
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Upcoming Branch
> Environment: OS - Ubuntu 
>Reporter: Ganesh Bawne
>Assignee: Michael Brohl
>  Labels: filename, order, pdf
> Fix For: Release Branch 14.12, Trunk
>
> Attachments: orderPdf-FileName.patch
>
>
> Need to have set the order pdf file name to its order number when we open the 
> pdf from backoffice orderdetail page 
> (/ordermgr/control/order.pdf?orderId=X).
> Currently, the default name of the pdf is always "order.pdf", instead need to 
> have an option to set the default pdf name to its order number?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-4480) Need to have an option to pass file name as OrderId for the generated confirmation or invoice PDF.

2015-05-20 Thread Michael Brohl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-4480:
-
Affects Version/s: (was: Trunk)
   Upcoming Branch

> Need to have an option to pass file name as OrderId for the generated 
> confirmation or invoice PDF.
> --
>
> Key: OFBIZ-4480
> URL: https://issues.apache.org/jira/browse/OFBIZ-4480
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Upcoming Branch
> Environment: OS - Ubuntu 
>Reporter: Ganesh Bawne
>Assignee: Michael Brohl
>  Labels: filename, order, pdf
> Attachments: orderPdf-FileName.patch
>
>
> Need to have set the order pdf file name to its order number when we open the 
> pdf from backoffice orderdetail page 
> (/ordermgr/control/order.pdf?orderId=X).
> Currently, the default name of the pdf is always "order.pdf", instead need to 
> have an option to set the default pdf name to its order number?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-4480) Need to have an option to pass file name as OrderId for the generated confirmation or invoice PDF.

2015-05-20 Thread Michael Brohl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-4480:
-
Fix Version/s: Release Branch 14.12
   Trunk

> Need to have an option to pass file name as OrderId for the generated 
> confirmation or invoice PDF.
> --
>
> Key: OFBIZ-4480
> URL: https://issues.apache.org/jira/browse/OFBIZ-4480
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Upcoming Branch
> Environment: OS - Ubuntu 
>Reporter: Ganesh Bawne
>Assignee: Michael Brohl
>  Labels: filename, order, pdf
> Fix For: Release Branch 14.12, Trunk
>
> Attachments: orderPdf-FileName.patch
>
>
> Need to have set the order pdf file name to its order number when we open the 
> pdf from backoffice orderdetail page 
> (/ordermgr/control/order.pdf?orderId=X).
> Currently, the default name of the pdf is always "order.pdf", instead need to 
> have an option to set the default pdf name to its order number?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6197) Allow production runs to be generated based on OrderItemShipGroupAssoc instead of only Shipment

2015-05-20 Thread Christian Carlow (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Carlow updated OFBIZ-6197:

Attachment: OFBIZ-6197.patch

> Allow production runs to be generated based on OrderItemShipGroupAssoc 
> instead of only Shipment
> ---
>
> Key: OFBIZ-6197
> URL: https://issues.apache.org/jira/browse/OFBIZ-6197
> Project: OFBiz
>  Issue Type: New Feature
>  Components: manufacturing
>Affects Versions: Trunk
>Reporter: Christian Carlow
> Attachments: OFBIZ-6197.patch
>
>
> Manufacturing Shipment Plan requires a shipment to be created before a 
> production run can be generated to fulfill the corresponding 
> OrderItemShipGroupAssoc.  I propose adding the capability to generate 
> production runs based on OrderItemShipGroupAssoc without having to create a 
> shipment for it first.  It seems unnecesarily cumbersome and redundant to 
> require users to create a shipment and plan each order items corresponding 
> the OrderItemShipGroupAssoc they already created.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6197) Allow production runs to be generated based on OrderItemShipGroupAssoc instead of only Shipment

2015-05-20 Thread Christian Carlow (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14552929#comment-14552929
 ] 

Christian Carlow commented on OFBIZ-6197:
-

This issue depends on OFBIZ-6204 for the "Create Production Runs" button for 
each ship group assoc to create WorkOrderItemFulfillments. 

> Allow production runs to be generated based on OrderItemShipGroupAssoc 
> instead of only Shipment
> ---
>
> Key: OFBIZ-6197
> URL: https://issues.apache.org/jira/browse/OFBIZ-6197
> Project: OFBiz
>  Issue Type: New Feature
>  Components: manufacturing
>Affects Versions: Trunk
>Reporter: Christian Carlow
>
> Manufacturing Shipment Plan requires a shipment to be created before a 
> production run can be generated to fulfill the corresponding 
> OrderItemShipGroupAssoc.  I propose adding the capability to generate 
> production runs based on OrderItemShipGroupAssoc without having to create a 
> shipment for it first.  It seems unnecesarily cumbersome and redundant to 
> require users to create a shipment and plan each order items corresponding 
> the OrderItemShipGroupAssoc they already created.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: [VOTE] [RELEASE] Apache OFBiz 13.07.02 - third attempt

2015-05-20 Thread Michael Brohl

+1

Regards,

Michael Brohl
ecomify GmbH
www.ecomify.de

Am 14.05.15 um 12:10 schrieb Jacopo Cappellato:

Let's try again!

This is the vote thread to release a new bug fix release for the release13.07 branch. 
This new release, "Apache OFBiz 13.07.02" will supersede previous releases from 
the same branch.

The release files can be downloaded from here:
https://dist.apache.org/repos/dist/dev/ofbiz/

* apache-ofbiz-13.07.02.zip: the release archive
* apache-ofbiz-13.07.02.zip.md5, apache-ofbiz-13.07.02.zip.sha: hashes
* apache-ofbiz-13.07.02.zip.asc: the detached signature file
* KEYS: text file with keys

Please download and test the zip file and its signatures (for instructions on 
testing the signatures see http://www.apache.org/info/verification.html).

Release notes:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310500&version=12328788

Vote:

[ +1] release as Apache OFBiz 13.07.02
[ -1] do not release

This vote will be open for 5 days.
For more details about this process please read 
http://www.apache.org/foundation/voting.html

Kind Regards,

Jacopo





smime.p7s
Description: S/MIME Cryptographic Signature


Re: [VOTE] [RELEASE] Apache OFBiz 13.07.02 - third attempt

2015-05-20 Thread Jacques Le Roux

Le 20/05/2015 19:10, Jacopo Cappellato a écrit :

Thank you for bringing this topic up Michael.
>From what I understand Jacques upgraded Log4j but the upgrade was not complete 
and was causing issues (I will have a look at it soon) and then he reverted 
everything: I may be wrong but the commit and the revert were done after we 
created the release files... am I wrong? Jacques could you please clarify?


Yes this was done after the VOTE began. I expected it to be a simple things but forgot about http://markmail.org/message/wec5g2coydb57nmq. So I 
reverted and I just noticed I left R14.12.01 in "Fix Version/s:" field. This is because then the VOTE was not finished (still not done) hence Jira has 
still the R14.12.01 in "Unreleased". I just removed it because we need to clarify about jars dependencies and there is nothing urgent regarding the 
update of Log4j 2.2 to 2.3 which should prevent the R14.12.01 release.


Jacques



Jacopo

On May 20, 2015, at 7:03 PM, Michael Brohl  wrote:


Not sure if this is a showstopper for the release because it was introduced 
after the vote call, but we have one remaining issue for this release: 
https://issues.apache.org/jira/browse/OFBIZ-6380

Michael Brohl
ecomify GmbH
www.ecomify.de

Am 14.05.15 um 12:10 schrieb Jacopo Cappellato:

Let's try again!

This is the vote thread to release a new bug fix release for the release13.07 branch. 
This new release, "Apache OFBiz 13.07.02" will supersede previous releases from 
the same branch.

The release files can be downloaded from here:
https://dist.apache.org/repos/dist/dev/ofbiz/

* apache-ofbiz-13.07.02.zip: the release archive
* apache-ofbiz-13.07.02.zip.md5, apache-ofbiz-13.07.02.zip.sha: hashes
* apache-ofbiz-13.07.02.zip.asc: the detached signature file
* KEYS: text file with keys

Please download and test the zip file and its signatures (for instructions on 
testing the signatures see http://www.apache.org/info/verification.html).

Release notes:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310500&version=12328788

Vote:

[ +1] release as Apache OFBiz 13.07.02
[ -1] do not release

This vote will be open for 5 days.
For more details about this process please read 
http://www.apache.org/foundation/voting.html

Kind Regards,

Jacopo







[jira] [Updated] (OFBIZ-6380) Update Log4j 2.2 to 2.3

2015-05-20 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-6380:
---
Fix Version/s: (was: 14.12.01)

> Update Log4j 2.2 to 2.3
> ---
>
> Key: OFBIZ-6380
> URL: https://issues.apache.org/jira/browse/OFBIZ-6380
> Project: OFBiz
>  Issue Type: Task
>  Components: framework
>Affects Versions: Release Branch 14.12, Trunk, 13.07.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: 13.07.02, Upcoming Branch
>
>
> http://logging.apache.org/log4j/2.x/changes-report.html#a2.3



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: [VOTE] [RELEASE] Apache OFBiz 13.07.02 - third attempt

2015-05-20 Thread Jacopo Cappellato
Thank you for bringing this topic up Michael.
From what I understand Jacques upgraded Log4j but the upgrade was not complete 
and was causing issues (I will have a look at it soon) and then he reverted 
everything: I may be wrong but the commit and the revert were done after we 
created the release files... am I wrong? Jacques could you please clarify?

Jacopo

On May 20, 2015, at 7:03 PM, Michael Brohl  wrote:

> Not sure if this is a showstopper for the release because it was introduced 
> after the vote call, but we have one remaining issue for this release: 
> https://issues.apache.org/jira/browse/OFBIZ-6380
> 
> Michael Brohl
> ecomify GmbH
> www.ecomify.de
> 
> Am 14.05.15 um 12:10 schrieb Jacopo Cappellato:
>> Let's try again!
>> 
>> This is the vote thread to release a new bug fix release for the 
>> release13.07 branch. This new release, "Apache OFBiz 13.07.02" will 
>> supersede previous releases from the same branch.
>> 
>> The release files can be downloaded from here:
>> https://dist.apache.org/repos/dist/dev/ofbiz/
>> 
>> * apache-ofbiz-13.07.02.zip: the release archive
>> * apache-ofbiz-13.07.02.zip.md5, apache-ofbiz-13.07.02.zip.sha: hashes
>> * apache-ofbiz-13.07.02.zip.asc: the detached signature file
>> * KEYS: text file with keys
>> 
>> Please download and test the zip file and its signatures (for instructions 
>> on testing the signatures see http://www.apache.org/info/verification.html).
>> 
>> Release notes:
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310500&version=12328788
>> 
>> Vote:
>> 
>> [ +1] release as Apache OFBiz 13.07.02
>> [ -1] do not release
>> 
>> This vote will be open for 5 days.
>> For more details about this process please read 
>> http://www.apache.org/foundation/voting.html
>> 
>> Kind Regards,
>> 
>> Jacopo
> 
> 



Re: [VOTE] [RELEASE] Apache OFBiz 13.07.02 - third attempt

2015-05-20 Thread Michael Brohl
Not sure if this is a showstopper for the release because it was 
introduced after the vote call, but we have one remaining issue for this 
release: https://issues.apache.org/jira/browse/OFBIZ-6380


Michael Brohl
ecomify GmbH
www.ecomify.de

Am 14.05.15 um 12:10 schrieb Jacopo Cappellato:

Let's try again!

This is the vote thread to release a new bug fix release for the release13.07 branch. 
This new release, "Apache OFBiz 13.07.02" will supersede previous releases from 
the same branch.

The release files can be downloaded from here:
https://dist.apache.org/repos/dist/dev/ofbiz/

* apache-ofbiz-13.07.02.zip: the release archive
* apache-ofbiz-13.07.02.zip.md5, apache-ofbiz-13.07.02.zip.sha: hashes
* apache-ofbiz-13.07.02.zip.asc: the detached signature file
* KEYS: text file with keys

Please download and test the zip file and its signatures (for instructions on 
testing the signatures see http://www.apache.org/info/verification.html).

Release notes:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310500&version=12328788

Vote:

[ +1] release as Apache OFBiz 13.07.02
[ -1] do not release

This vote will be open for 5 days.
For more details about this process please read 
http://www.apache.org/foundation/voting.html

Kind Regards,

Jacopo





smime.p7s
Description: S/MIME Cryptographic Signature


[jira] [Commented] (OFBIZ-6384) util.js is missing licence header

2015-05-20 Thread Pierre Smits (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14552655#comment-14552655
 ] 

Pierre Smits commented on OFBIZ-6384:
-

Thanks for spotting that, Michael. Closing

> util.js is missing licence header
> -
>
> Key: OFBIZ-6384
> URL: https://issues.apache.org/jira/browse/OFBIZ-6384
> Project: OFBiz
>  Issue Type: Task
>  Components: framework
>Affects Versions: Release Branch 14.12, Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6384-util.js.patch
>
>
> For OFBIZ-5409 we introduced rather a defensive patch which secure json 
> response on services calls. It might need some changes in custom code if (not 
> recommended) an Ajax GET response is used... The util.js script was 
> introduced for that, though normally should not be needed... 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-6384) util.js is missing licence header

2015-05-20 Thread Pierre Smits (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits closed OFBIZ-6384.
---
Resolution: Fixed

> util.js is missing licence header
> -
>
> Key: OFBIZ-6384
> URL: https://issues.apache.org/jira/browse/OFBIZ-6384
> Project: OFBiz
>  Issue Type: Task
>  Components: framework
>Affects Versions: Release Branch 14.12, Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6384-util.js.patch
>
>
> For OFBIZ-5409 we introduced rather a defensive patch which secure json 
> response on services calls. It might need some changes in custom code if (not 
> recommended) an Ajax GET response is used... The util.js script was 
> introduced for that, though normally should not be needed... 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6384) util.js is missing licence header

2015-05-20 Thread Michael Brohl (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14552647#comment-14552647
 ] 

Michael Brohl commented on OFBIZ-6384:
--

Should this not be set to resolved and being closed?

> util.js is missing licence header
> -
>
> Key: OFBIZ-6384
> URL: https://issues.apache.org/jira/browse/OFBIZ-6384
> Project: OFBiz
>  Issue Type: Task
>  Components: framework
>Affects Versions: Release Branch 14.12, Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6384-util.js.patch
>
>
> For OFBIZ-5409 we introduced rather a defensive patch which secure json 
> response on services calls. It might need some changes in custom code if (not 
> recommended) an Ajax GET response is used... The util.js script was 
> introduced for that, though normally should not be needed... 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-6395) The lookup and text-area have a read-only attribute but not the std input field

2015-05-20 Thread Jacques Le Roux (JIRA)
Jacques Le Roux created OFBIZ-6395:
--

 Summary: The lookup and text-area have a read-only attribute but 
not the std input field
 Key: OFBIZ-6395
 URL: https://issues.apache.org/jira/browse/OFBIZ-6395
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: Trunk
Reporter: Jacques Le Roux
Assignee: Jacques Le Roux
Priority: Minor
 Fix For: Upcoming Branch


I will add a read-only attribute to the text input field. Using the display 
type is not enough, because it's uneasy to assign values through Javascript as 
using the lookup description-field-name shows OOTB.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6395) The lookup and text-area have a read-only attribute but not the text input field

2015-05-20 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-6395:
---
Summary: The lookup and text-area have a read-only attribute but not the 
text input field  (was: The lookup and text-area have a read-only attribute but 
not the std input field)

> The lookup and text-area have a read-only attribute but not the text input 
> field
> 
>
> Key: OFBIZ-6395
> URL: https://issues.apache.org/jira/browse/OFBIZ-6395
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> I will add a read-only attribute to the text input field. Using the display 
> type is not enough, because it's uneasy to assign values through Javascript 
> as using the lookup description-field-name shows OOTB.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-6238) Give the order notification email attachment the orderId as filename

2015-05-20 Thread Michael Brohl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl reassigned OFBIZ-6238:


Assignee: Michael Brohl  (was: Jacopo Cappellato)

> Give the order notification email attachment the orderId as filename
> 
>
> Key: OFBIZ-6238
> URL: https://issues.apache.org/jira/browse/OFBIZ-6238
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Martin Becker
>Assignee: Michael Brohl
>Priority: Trivial
> Attachments: OrderServices.patch
>
>
> According to customer needs I've made a change to 
> OrderServices.sendOrderNotificationScreen to fill the attachmentName 
> parameter of the sendMailFromScreen context with the orderId to override the 
> default in sendMailFromScreen, so that the PDF attachments in standard order 
> notifications have a name like "WS10001.pdf" instead of "Details.pdf"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6238) Give the order notification email attachment the orderId as filename

2015-05-20 Thread Michael Brohl (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14552376#comment-14552376
 ] 

Michael Brohl commented on OFBIZ-6238:
--

Ok Jacopo,

will do so.

> Give the order notification email attachment the orderId as filename
> 
>
> Key: OFBIZ-6238
> URL: https://issues.apache.org/jira/browse/OFBIZ-6238
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Martin Becker
>Assignee: Jacopo Cappellato
>Priority: Trivial
> Attachments: OrderServices.patch
>
>
> According to customer needs I've made a change to 
> OrderServices.sendOrderNotificationScreen to fill the attachmentName 
> parameter of the sendMailFromScreen context with the orderId to override the 
> default in sendMailFromScreen, so that the PDF attachments in standard order 
> notifications have a name like "WS10001.pdf" instead of "Details.pdf"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-4480) Need to have an option to pass file name as OrderId for the generated confirmation or invoice PDF.

2015-05-20 Thread Michael Brohl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl reassigned OFBIZ-4480:


Assignee: Michael Brohl

> Need to have an option to pass file name as OrderId for the generated 
> confirmation or invoice PDF.
> --
>
> Key: OFBIZ-4480
> URL: https://issues.apache.org/jira/browse/OFBIZ-4480
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
> Environment: OS - Ubuntu 
>Reporter: Ganesh Bawne
>Assignee: Michael Brohl
>  Labels: filename, order, pdf
> Attachments: orderPdf-FileName.patch
>
>
> Need to have set the order pdf file name to its order number when we open the 
> pdf from backoffice orderdetail page 
> (/ordermgr/control/order.pdf?orderId=X).
> Currently, the default name of the pdf is always "order.pdf", instead need to 
> have an option to set the default pdf name to its order number?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6238) Give the order notification email attachment the orderId as filename

2015-05-20 Thread Jacopo Cappellato (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14552358#comment-14552358
 ] 

Jacopo Cappellato commented on OFBIZ-6238:
--

I agree that the patch improves the system; further enhancements can be done on 
top of it.
[~mbrohl] if you would like to assign this ticket to yourself and go ahead and 
commit the code please feel free to do, I am sorry but I didn't find time to 
work on this since I have assigned it to myself.

> Give the order notification email attachment the orderId as filename
> 
>
> Key: OFBIZ-6238
> URL: https://issues.apache.org/jira/browse/OFBIZ-6238
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Martin Becker
>Assignee: Jacopo Cappellato
>Priority: Trivial
> Attachments: OrderServices.patch
>
>
> According to customer needs I've made a change to 
> OrderServices.sendOrderNotificationScreen to fill the attachmentName 
> parameter of the sendMailFromScreen context with the orderId to override the 
> default in sendMailFromScreen, so that the PDF attachments in standard order 
> notifications have a name like "WS10001.pdf" instead of "Details.pdf"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6238) Give the order notification email attachment the orderId as filename

2015-05-20 Thread Michael Brohl (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14552339#comment-14552339
 ] 

Michael Brohl commented on OFBIZ-6238:
--

I think these are related and both solutions provided with the patch are 
matching.

> Give the order notification email attachment the orderId as filename
> 
>
> Key: OFBIZ-6238
> URL: https://issues.apache.org/jira/browse/OFBIZ-6238
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Martin Becker
>Assignee: Jacopo Cappellato
>Priority: Trivial
> Attachments: OrderServices.patch
>
>
> According to customer needs I've made a change to 
> OrderServices.sendOrderNotificationScreen to fill the attachmentName 
> parameter of the sendMailFromScreen context with the orderId to override the 
> default in sendMailFromScreen, so that the PDF attachments in standard order 
> notifications have a name like "WS10001.pdf" instead of "Details.pdf"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6276) Fix deprecation issues in framework/entity

2015-05-20 Thread Michael Brohl (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14552098#comment-14552098
 ] 

Michael Brohl commented on OFBIZ-6276:
--

+1

> Fix deprecation issues in framework/entity
> --
>
> Key: OFBIZ-6276
> URL: https://issues.apache.org/jira/browse/OFBIZ-6276
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Reporter: Adam Heath
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-6276-variant-1.patch, OFBIZ-6276-variant-2.patch
>
>
> It appears that the storeAll() variants are being refactor; basically, the 
> useCache parameter is being removed.  However, this has caused the
> entity engine to have deprecation with itself.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6276) Fix deprecation issues in framework/entity

2015-05-20 Thread Martin Becker (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14552078#comment-14552078
 ] 

Martin Becker commented on OFBIZ-6276:
--

Good point, I would call it EntityStoreOptions according to the existing 
EntityFindOptions.

> Fix deprecation issues in framework/entity
> --
>
> Key: OFBIZ-6276
> URL: https://issues.apache.org/jira/browse/OFBIZ-6276
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Reporter: Adam Heath
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-6276-variant-1.patch, OFBIZ-6276-variant-2.patch
>
>
> It appears that the storeAll() variants are being refactor; basically, the 
> useCache parameter is being removed.  However, this has caused the
> entity engine to have deprecation with itself.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6326) Pagination doesn't render well in Bootstrap Basic

2015-05-20 Thread Julien NICOLAS (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14552026#comment-14552026
 ] 

Julien NICOLAS commented on OFBIZ-6326:
---

I see what's happen. So I'll try to solve this issue :)

> Pagination doesn't render well in Bootstrap Basic
> -
>
> Key: OFBIZ-6326
> URL: https://issues.apache.org/jira/browse/OFBIZ-6326
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: themes
>Affects Versions: Bootstrap theme
>Reporter: Pierre Smits
>  Labels: pagination
>
> When accessing an overview page (e.g. /catalog/control/FindProduct) with more 
> than the default number of records to be shown, the pagination comes out 
> garbled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-6326) Pagination doesn't render well in Bootstrap Basic

2015-05-20 Thread Julien NICOLAS (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julien NICOLAS reassigned OFBIZ-6326:
-

Assignee: Julien NICOLAS

> Pagination doesn't render well in Bootstrap Basic
> -
>
> Key: OFBIZ-6326
> URL: https://issues.apache.org/jira/browse/OFBIZ-6326
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: themes
>Affects Versions: Bootstrap theme
>Reporter: Pierre Smits
>Assignee: Julien NICOLAS
>  Labels: pagination
>
> When accessing an overview page (e.g. /catalog/control/FindProduct) with more 
> than the default number of records to be shown, the pagination comes out 
> garbled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6276) Fix deprecation issues in framework/entity

2015-05-20 Thread Gareth Carter (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14551988#comment-14551988
 ] 

Gareth Carter commented on OFBIZ-6276:
--

What about new method that allows passing in an options object

storeAll(List values, StoreOptions options) ?

You can deprecate the old methods without changes

Moving forward, you would just need to add new values to the StoreOptions class 
rather than adding new parameters to the existing one

I am not sure about the name StoreOptions though, EntityOptions ?

> Fix deprecation issues in framework/entity
> --
>
> Key: OFBIZ-6276
> URL: https://issues.apache.org/jira/browse/OFBIZ-6276
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Reporter: Adam Heath
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-6276-variant-1.patch, OFBIZ-6276-variant-2.patch
>
>
> It appears that the storeAll() variants are being refactor; basically, the 
> useCache parameter is being removed.  However, this has caused the
> entity engine to have deprecation with itself.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-4481) Adding a new attribute ignore-when (verry similar to use-when) that enable rendering or not a field in list or multi form.

2015-05-20 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-4481:
--

Assignee: Jacques Le Roux

> Adding a new attribute ignore-when (verry similar to use-when) that enable 
> rendering or not a field in list or multi form.
> --
>
> Key: OFBIZ-4481
> URL: https://issues.apache.org/jira/browse/OFBIZ-4481
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: youssef khaye
>Assignee: Jacques Le Roux
>Priority: Minor
>  Labels: form, list, use-when
> Attachments: ignoreField.patch, ignoreFiled based on trunk 
> r1680459.zip
>
>
> I need to define some parameters (using portlet attributes) that enable 
> showing or not some field in my portlet taht contains a form of type "list".
> Or on a form of type list or multi, it is not possible to completely ignore a 
> field via use-when attribute. Instead it hides the title and the column 
> header became shifted from the table content.
> For example I want to hide the description column from my form when 
> exampleName is choosen as sort-field.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6326) Pagination doesn't render well in Bootstrap Basic

2015-05-20 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14551949#comment-14551949
 ] 

Jacques Le Roux commented on OFBIZ-6326:


Image/s would be great, fortunately Adrian provided "styling_issue_3.png and 
styling_issue_4.png show styling flaws in list pagination." at 
https://issues.apache.org/jira/browse/OFBIZ-5840?focusedCommentId=14550739 :)

> Pagination doesn't render well in Bootstrap Basic
> -
>
> Key: OFBIZ-6326
> URL: https://issues.apache.org/jira/browse/OFBIZ-6326
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: themes
>Affects Versions: Bootstrap theme
>Reporter: Pierre Smits
>  Labels: pagination
>
> When accessing an overview page (e.g. /catalog/control/FindProduct) with more 
> than the default number of records to be shown, the pagination comes out 
> garbled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (OFBIZ-6353) Replace quoteReportBody.fo.ftl with form widget

2015-05-20 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14550884#comment-14550884
 ] 

Jacques Le Roux edited comment on OFBIZ-6353 at 5/20/15 7:43 AM:
-

Fixing patch by adding {code}currency="${quote.currencyUomId}"{code} to display 
currency fields at applications/order/widget/ordermgr/ReportForms.xml.


was (Author: ofbizzer):
Fixing patch by adding currency="${quote.currencyUomId}" to display currency 
fields at applications/order/widget/ordermgr/ReportForms.xml.

> Replace quoteReportBody.fo.ftl with form widget
> ---
>
> Key: OFBIZ-6353
> URL: https://issues.apache.org/jira/browse/OFBIZ-6353
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Christian Carlow
> Attachments: OFBIZ-6353.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Opinions requested on OFBIZ-6276

2015-05-20 Thread Jacques Le Roux

Hi,

Opinions on changes for OFBIZ-6276 are requested
https://issues.apache.org/jira/browse/OFBIZ-6276

Thanks

Jacques


Re: svn commit: r1680330 - /ofbiz/branches/boostrap_theme/BranchMergeToTrunk.patch

2015-05-20 Thread Pierre Smits
Hi Adrian,

Did something go wrong while aplying this patch? Or?

Best regards,


Pierre Smits

*ORRTIZ.COM *
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com

On Tue, May 19, 2015 at 6:14 PM,  wrote:

> Author: adrianc
> Date: Tue May 19 16:14:21 2015
> New Revision: 1680330
>
> URL: http://svn.apache.org/r1680330
> Log:
> Added patch file to assist with merging branch to trunk.
>
> Added:
> ofbiz/branches/boostrap_theme/BranchMergeToTrunk.patch
>
> Added: ofbiz/branches/boostrap_theme/BranchMergeToTrunk.patch
> URL:
> http://svn.apache.org/viewvc/ofbiz/branches/boostrap_theme/BranchMergeToTrunk.patch?rev=1680330&view=auto
>
> ==
> --- ofbiz/branches/boostrap_theme/BranchMergeToTrunk.patch (added)
> +++ ofbiz/branches/boostrap_theme/BranchMergeToTrunk.patch Tue May 19
> 16:14:21 2015
> @@ -0,0 +1,80 @@
> +Index: .
> +===
> +--- .  (revision 1680319)
>  .  (working copy)
> +
> +Property changes on: .
> +___
> +Modified: svn:mergeinfo
> +   Merged /ofbiz/branches/boostrap_theme:r1641659
> +Index: framework/common/widget/CommonScreens.xml
> +===
> +--- framework/common/widget/CommonScreens.xml  (revision 1680314)
>  framework/common/widget/CommonScreens.xml  (working copy)
> +@@ -191,6 +191,7 @@
> +  from-field="layoutSettings.VT_NAV_TMPLT_LOC[0]" />
> +  from-field="layoutSettings.VT_NAV_OPEN_TMPLT[0]" />
> +  from-field="layoutSettings.VT_NAV_CLOSE_TMPLT[0]" />
> ++ from-field="layoutSettings.VT_NAV_APPHDR_LOC[0]"/>
> +  from-field="layoutSettings.VT_MSG_TMPLT_LOC[0]" />
> +  value="ofbizsetup"/>
> + 
> +Index: framework/widget/src/org/ofbiz/widget/model/MenuFactory.java
> +===
> +--- framework/widget/src/org/ofbiz/widget/model/MenuFactory.java
>  (revision 1680329)
>  framework/widget/src/org/ofbiz/widget/model/MenuFactory.java
>  (working copy)
> +@@ -88,6 +88,16 @@
> + }
> +
> + public static ModelMenu getMenuFromLocation(String resourceName,
> String menuName) throws IOException, SAXException,
> ParserConfigurationException {
> ++Map modelMenuMap =
> getMenusFromLocation(resourceName);
> ++ModelMenu modelMenu = modelMenuMap.get(menuName);
> ++if (modelMenu == null) {
> ++throw new IllegalArgumentException("Could not find menu with
> name [" + menuName + "] in location [" + resourceName + "]");
> ++}
> ++return modelMenu;
> ++}
> ++
> ++public static Map getMenusFromLocation(String
> resourceName) throws IOException, SAXException,
> ++ParserConfigurationException {
> + Map modelMenuMap =
> menuLocationCache.get(resourceName);
> + if (modelMenuMap == null) {
> + URL menuFileUrl =
> FlexibleLocation.resolveLocation(resourceName);
> +@@ -100,11 +110,6 @@
> + if (UtilValidate.isEmpty(modelMenuMap)) {
> + throw new IllegalArgumentException("Could not find menu file
> in location [" + resourceName + "]");
> + }
> +-
> +-ModelMenu modelMenu = modelMenuMap.get(menuName);
> +-if (modelMenu == null) {
> +-throw new IllegalArgumentException("Could not find menu with
> name [" + menuName + "] in location [" + resourceName + "]");
> +-}
> +-return modelMenu;
> ++return modelMenuMap;
> + }
> + }
> +Index:
> framework/widget/src/org/ofbiz/widget/renderer/macro/MacroMenuRenderer.java
> +===
> +---
> framework/widget/src/org/ofbiz/widget/renderer/macro/MacroMenuRenderer.java
>   (revision 1680314)
> 
> framework/widget/src/org/ofbiz/widget/renderer/macro/MacroMenuRenderer.java
>   (working copy)
> +@@ -273,6 +273,7 @@
> + StringBuilder sb = new StringBuilder("End Menu Widget ");
> + sb.append(menu.getBoundaryCommentName());
> + parameters.put("boundaryComment", sb.toString());
> ++parameters.put("style", menu.getMenuContainerStyle(context));
> + }
> + try {
> + executeMacro(writer, "renderMenuEnd", parameters);
> +Index: framework/widget/templates/htmlMenuMacroLibrary.ftl
> +===
> +--- framework/widget/templates/htmlMenuMacroLibrary.ftl(revision
> 1680314)
>  framework/widget/templates/htmlMenuMacroLibrary.ftl(working
> copy)
> +@@ -31,7 +31,7 @@
> +   
> + 
> +
> +-<#macro renderMenuEnd boundaryComment=""

[jira] [Updated] (OFBIZ-6335) Replacing bsh code with groovy code in PROJECTMGR screens, forms and menus

2015-05-20 Thread Pierre Smits (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-6335:

Affects Version/s: Trunk

> Replacing bsh code with groovy code in PROJECTMGR screens, forms and menus
> --
>
> Key: OFBIZ-6335
> URL: https://issues.apache.org/jira/browse/OFBIZ-6335
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: specialpurpose/projectmgr
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
> Attachments: OFBIZ-6335-BSH2Groovy-ProjectMgr.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)