[jira] [Updated] (OFBIZ-6517) Form/Grid crosstab field type support

2015-06-21 Thread Christian Carlow (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Carlow updated OFBIZ-6517:

Attachment: (was: OFBIZ-6517.patch)

 Form/Grid crosstab field type support
 -

 Key: OFBIZ-6517
 URL: https://issues.apache.org/jira/browse/OFBIZ-6517
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: Trunk
Reporter: Christian Carlow
Priority: Minor

 Form/Grid widgets should be extended to support crosstab functionality:
 https://en.wikipedia.org/wiki/Pivot_table
 Option field types seem the best grid/form widget field types on which to 
 base this functionality.  For example:
 {code}
 field name=facilityId
 crosstab current-description=${quantityOnHandTotal}
 list-options key-name=facilityId list-name=facilitiesToPivot/
 /crosstab
 /field
 {code}
 This would allow a list of facilitiesIds to be used as grid column titles 
 with with cell values assigned to quantityOnHandTotal for records with 
 facilityId matching that of the title.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6276) Fix deprecation issues in framework/entity

2015-06-21 Thread Martin Becker (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14595084#comment-14595084
 ] 

Martin Becker commented on OFBIZ-6276:
--

I forgot to mention: The standard tests were all green...

 Fix deprecation issues in framework/entity
 --

 Key: OFBIZ-6276
 URL: https://issues.apache.org/jira/browse/OFBIZ-6276
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework
Reporter: Adam Heath
Assignee: Jacques Le Roux
Priority: Minor
 Attachments: OFBIZ-6276-EntityStoreOptions.patch, 
 OFBIZ-6276-variant-1.patch, OFBIZ-6276-variant-2.patch


 It appears that the storeAll() variants are being refactor; basically, the 
 useCache parameter is being removed.  However, this has caused the
 entity engine to have deprecation with itself.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6522) Potential IndexOutOfBoundsException in CategoryServices.getProductCategoryAndLimitedMembers

2015-06-21 Thread Michael Brohl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-6522:
-
Sprint: Community Day 2 - 2015

 Potential IndexOutOfBoundsException in 
 CategoryServices.getProductCategoryAndLimitedMembers
 ---

 Key: OFBIZ-6522
 URL: https://issues.apache.org/jira/browse/OFBIZ-6522
 Project: OFBiz
  Issue Type: Bug
  Components: product
Affects Versions: Upcoming Branch
Reporter: Martin Becker
Priority: Minor
 Attachments: OFBIZ-6522.patch


 If view indexes as input parameters of service 
 getProductCategoryAndLimitedMembers get manipulated (e.g. by manipulating URL 
 params or bookmarking an URL with those params an come back later), it can 
 lead to an IndexOutOfBoundsException because of a lowIndex greater list size. 
 The highIndex is checked for that, the lowIndex is not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-6522) Potential IndexOutOfBoundsException in CategoryServices.getProductCategoryAndLimitedMembers

2015-06-21 Thread Michael Brohl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl reassigned OFBIZ-6522:


Assignee: Michael Brohl

 Potential IndexOutOfBoundsException in 
 CategoryServices.getProductCategoryAndLimitedMembers
 ---

 Key: OFBIZ-6522
 URL: https://issues.apache.org/jira/browse/OFBIZ-6522
 Project: OFBiz
  Issue Type: Bug
  Components: product
Affects Versions: Upcoming Branch
Reporter: Martin Becker
Assignee: Michael Brohl
Priority: Minor
 Attachments: OFBIZ-6522.patch


 If view indexes as input parameters of service 
 getProductCategoryAndLimitedMembers get manipulated (e.g. by manipulating URL 
 params or bookmarking an URL with those params an come back later), it can 
 lead to an IndexOutOfBoundsException because of a lowIndex greater list size. 
 The highIndex is checked for that, the lowIndex is not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6522) Potential IndexOutOfBoundsException in CategoryServices.getProductCategoryAndLimitedMembers

2015-06-21 Thread Martin Becker (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Becker updated OFBIZ-6522:
-
Attachment: OFBIZ-6522.patch

Added patch with fixed potential IndexOutOfBoundsException in 
CategoryServices.getProductCategoryAndLimitedMembers.
BTW also ensured that the EntityListIterator gets closed if an error occurs and 
corrected some minor code laxness.

 Potential IndexOutOfBoundsException in 
 CategoryServices.getProductCategoryAndLimitedMembers
 ---

 Key: OFBIZ-6522
 URL: https://issues.apache.org/jira/browse/OFBIZ-6522
 Project: OFBiz
  Issue Type: Bug
  Components: product
Affects Versions: Upcoming Branch
Reporter: Martin Becker
Priority: Minor
 Attachments: OFBIZ-6522.patch


 If view indexes as input parameters of service 
 getProductCategoryAndLimitedMembers get manipulated (e.g. by manipulating URL 
 params or bookmarking an URL with those params an come back later), it can 
 lead to an IndexOutOfBoundsException because of a lowIndex greater list size. 
 The highIndex is checked for that, the lowIndex is not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6458) Upgrade OFBiz to Java JDK 8

2015-06-21 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14595073#comment-14595073
 ] 

Jacques Le Roux commented on OFBIZ-6458:


Seems it was not exactly the same change since Michael committed it yesterday, 
good catch Martin (I did not try to Java 8 source code compatibility yet)

 Upgrade OFBiz to Java JDK 8
 ---

 Key: OFBIZ-6458
 URL: https://issues.apache.org/jira/browse/OFBIZ-6458
 Project: OFBiz
  Issue Type: Improvement
Affects Versions: Upcoming Branch
Reporter: Taher Alkhateeb
Assignee: Jacques Le Roux
Priority: Critical
  Labels: java, jdk, jdk8, upgrade
 Fix For: Upcoming Branch

 Attachments: OFBIZ-6458-01-fix-test-errors.patch, 
 OFBIZ-6458-02-fix-eclipse-compiler.patch, OFBIZ-6458-03-update-to-jdk8.patch, 
 OFBIZ-6458-04-update-README.patch


 The following will be tracked through this JIRA:
 - upgrade the framework to JDK 8 and fix any errors
 - make sure that ./ant clean-all load-demo run-tests will run after the 
 upgrade
 - upgrade the infrastructure and demo server to accommodate the new change



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6489) drop-down entity-options description attribute should default to ${description} if not specified as is done for display-entity

2015-06-21 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14595081#comment-14595081
 ] 

Jacques Le Roux commented on OFBIZ-6489:


Good idea, yes please do Gil!

 drop-down entity-options description attribute should default to 
 ${description} if not specified as is done for display-entity
 

 Key: OFBIZ-6489
 URL: https://issues.apache.org/jira/browse/OFBIZ-6489
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: Trunk
Reporter: Christian Carlow
Assignee: Nicolas Malin
Priority: Trivial
 Fix For: Upcoming Branch

 Attachments: OFBIZ-6489.patch






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-6522) Potential IndexOutOfBoundsException in CategoryServices.getProductCategoryAndLimitedMembers

2015-06-21 Thread Michael Brohl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-6522.

   Resolution: Fixed
Fix Version/s: Upcoming Branch

Thanks Martin, your patch is in

trunk r1686741

 Potential IndexOutOfBoundsException in 
 CategoryServices.getProductCategoryAndLimitedMembers
 ---

 Key: OFBIZ-6522
 URL: https://issues.apache.org/jira/browse/OFBIZ-6522
 Project: OFBiz
  Issue Type: Bug
  Components: product
Affects Versions: Upcoming Branch
Reporter: Martin Becker
Assignee: Michael Brohl
Priority: Minor
 Fix For: Upcoming Branch

 Attachments: OFBIZ-6522.patch


 If view indexes as input parameters of service 
 getProductCategoryAndLimitedMembers get manipulated (e.g. by manipulating URL 
 params or bookmarking an URL with those params an come back later), it can 
 lead to an IndexOutOfBoundsException because of a lowIndex greater list size. 
 The highIndex is checked for that, the lowIndex is not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6458) Upgrade OFBiz to Java JDK 8

2015-06-21 Thread Martin Becker (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14595018#comment-14595018
 ] 

Martin Becker commented on OFBIZ-6458:
--

Hi Taher,
what i meant was, I provided a fix for that with title Compiler-Error with JDK 
1.8 and source compatibility 1.8 already 8 weeks ago, when the Java 8 
compatibility was a headline once before, but it wasn't recognized or 
forgotten...

 Upgrade OFBiz to Java JDK 8
 ---

 Key: OFBIZ-6458
 URL: https://issues.apache.org/jira/browse/OFBIZ-6458
 Project: OFBiz
  Issue Type: Improvement
Affects Versions: Upcoming Branch
Reporter: Taher Alkhateeb
Assignee: Jacques Le Roux
Priority: Critical
  Labels: java, jdk, jdk8, upgrade
 Fix For: Upcoming Branch

 Attachments: OFBIZ-6458-01-fix-test-errors.patch, 
 OFBIZ-6458-02-fix-eclipse-compiler.patch, OFBIZ-6458-03-update-to-jdk8.patch, 
 OFBIZ-6458-04-update-README.patch


 The following will be tracked through this JIRA:
 - upgrade the framework to JDK 8 and fix any errors
 - make sure that ./ant clean-all load-demo run-tests will run after the 
 upgrade
 - upgrade the infrastructure and demo server to accommodate the new change



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6518) Labels Chinese localization

2015-06-21 Thread Shi Jinghai (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shi Jinghai updated OFBIZ-6518:
---
Attachment: OFBiz-6518-specialpurpose-20150622.patch
OFBiz-6518-framework-20150622.patch
OFBiz-6518-applications-20150622.patch

Translated labels in zh locale.

 Labels Chinese localization
 ---

 Key: OFBIZ-6518
 URL: https://issues.apache.org/jira/browse/OFBIZ-6518
 Project: OFBiz
  Issue Type: Improvement
Affects Versions: Trunk
Reporter: Shi Jinghai
Assignee: Shi Jinghai
Priority: Minor
 Attachments: OFBiz-6518-applications-20150622.patch, 
 OFBiz-6518-framework-20150622.patch, OFBiz-6518-specialpurpose-20150622.patch

   Original Estimate: 48h
  Remaining Estimate: 48h

 I'll localize some missing-translation labels into Chinese.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


buildbot success in ASF Buildbot on ofbiz-trunk

2015-06-21 Thread buildbot
The Buildbot has detected a restored build on builder ofbiz-trunk while 
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/ofbiz-trunk/builds/970

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: lares_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-ofbiz-commit' 
triggered this build
Build Source Stamp: [branch ofbiz/trunk] 1686741
Blamelist: mbrohl

Build succeeded!

Sincerely,
 -The Buildbot





[jira] [Closed] (OFBIZ-6519) Remove Old deprecated code in WorkEffortEventReminder services

2015-06-21 Thread Nicolas Malin (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin closed OFBIZ-6519.


 Remove Old deprecated code in WorkEffortEventReminder services
 --

 Key: OFBIZ-6519
 URL: https://issues.apache.org/jira/browse/OFBIZ-6519
 Project: OFBiz
  Issue Type: Improvement
  Components: workeffort
Affects Versions: Upcoming Branch
Reporter: Gil Portenseigne
Assignee: Nicolas Malin
Priority: Minor
 Fix For: Upcoming Branch

 Attachments: OFBIZ-6519.patch


 Delete old migrateWorkEffortEventReminders service. This service was used to 
 migrate existing WorkEffortReminder after (guessing) a field entity renaming.
 Remove old code using screen instead of EmailTemplateSetting to send reminder.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6516) Facilitate the use of Icons in Ofbiz by adding descriptive style to the widget-style attribute in forms

2015-06-21 Thread Gavin Mabie (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14594988#comment-14594988
 ] 

Gavin Mabie commented on OFBIZ-6516:


The 'buttontext css class can be confusing because despite the name, it does 
not refer to an actual html button element. It is used to style links like 
buttons outside a form submit context (hyperlinks in forms/tables and 
menu-items). So we could well use any other name for this class.  This proposal 
is about using semantic class names in the widget-style attribute - the normal 
CRUD one which are already used in some places, plus additional ones such as 
copy, print, view etc.  Scalable icon fonts can then be used to present the 
appropriate icon, instead of the sprites currently used.  Libraries such as 
Fontawesome and Glyphicons  are freely available and can be used stand-alone 
(separately from a specific Javascript framework).

 Facilitate the use of Icons in Ofbiz by adding descriptive style to the 
 widget-style attribute in forms
 ---

 Key: OFBIZ-6516
 URL: https://issues.apache.org/jira/browse/OFBIZ-6516
 Project: OFBiz
  Issue Type: Sub-task
  Components: ALL APPLICATIONS
Affects Versions: 14.12.01, 12.04.06, 13.07.03, Upcoming Branch
 Environment: Ofbiz Web UI
Reporter: Gavin Mabie
Priority: Minor

 Icons can be used to great effect to enhance both the user experience and as 
 well as the look-and-feel of an application.  In Ofbiz this is facilitated by 
 using meaningful styles name in the widget-style attribute.  Examples are 
 buttontext create, buttontext delete/remove, buttontext update.  That 
 takes care of the basic CRUD actions.  The widget-style attribute is used by 
 front-end designers (on the presentation layer) to create their own designs 
 via macro libraries, stylesheets and javascript files.  It will be useful for 
 designers if widget-styles are defined in a standard way in widget 
 definitions (*forms.xml, *menu.xml etc).  To set this process in motion I 
 propose the following:
 1. All buttontext widget-style attributes should have a meaningful 
 additional class which describes the action linked to the button, i.e create, 
 update, delete, refresh - depending on the action.
 2. Add missing descriptive classes like copy, print, view, download, save 
 etc.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-6523) service findOrders set viewSize and viewIndex to optional

2015-06-21 Thread Nicolas Malin (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin closed OFBIZ-6523.


 service findOrders set viewSize and viewIndex to optional
 -

 Key: OFBIZ-6523
 URL: https://issues.apache.org/jira/browse/OFBIZ-6523
 Project: OFBiz
  Issue Type: Improvement
  Components: order
Affects Versions: Trunk
Reporter: Nicolas Malin
Assignee: Nicolas Malin
Priority: Minor

 The findOrder service force the value viewSize and viewIndex. Set them as 
 optionnal and if they aren't present resolve it from widgets.properties



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (OFBIZ-6523) service findOrders set viewSize and viewIndex to optional

2015-06-21 Thread Nicolas Malin (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin resolved OFBIZ-6523.
--
Resolution: Done

done on trunk at revision 1686691

 service findOrders set viewSize and viewIndex to optional
 -

 Key: OFBIZ-6523
 URL: https://issues.apache.org/jira/browse/OFBIZ-6523
 Project: OFBiz
  Issue Type: Improvement
  Components: order
Affects Versions: Trunk
Reporter: Nicolas Malin
Assignee: Nicolas Malin
Priority: Minor

 The findOrder service force the value viewSize and viewIndex. Set them as 
 optionnal and if they aren't present resolve it from widgets.properties



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


buildbot failure in ASF Buildbot on ofbiz-trunk

2015-06-21 Thread buildbot
The Buildbot has detected a new failure on builder ofbiz-trunk while building 
ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/ofbiz-trunk/builds/969

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: lares_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-ofbiz-commit' 
triggered this build
Build Source Stamp: [branch ofbiz/trunk] 1686691
Blamelist: nmalin

BUILD FAILED: failed

Sincerely,
 -The Buildbot