[jira] [Commented] (OFBIZ-4090) Add Support For Compound Screen Widget XML Files
[ https://issues.apache.org/jira/browse/OFBIZ-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966824#comment-14966824 ] Adrian Crum commented on OFBIZ-4090: The implementation basically worked, but the Eclipse editor wasn't working well with the changes. The patch is very outdated. It will need to be updated. > Add Support For Compound Screen Widget XML Files > > > Key: OFBIZ-4090 > URL: https://issues.apache.org/jira/browse/OFBIZ-4090 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Adrian Crum >Priority: Minor > Attachments: CompoundWidgetFiles.patch, CompoundWidgetFiles.patch > > > Add the ability to include screen widgets, form widgets, menu widgets, and > simple methods in a single XML file. This approach could be used in > situations where the widgets share a logical grouping - so they can be kept > in one place. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-1843) Suppress stack traces on front end due to errors in ftl files
[ https://issues.apache.org/jira/browse/OFBIZ-1843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-1843. -- Resolution: Incomplete I thought Adrian's concern were addressed then but it's not the case. So it's interesting but incomplete I close as is. > Suppress stack traces on front end due to errors in ftl files > - > > Key: OFBIZ-1843 > URL: https://issues.apache.org/jira/browse/OFBIZ-1843 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Reporter: Amit Shinde >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-1843.patch, OFBIZ-1843.patch, OFBIZ-1843.patch > > > We need to find a way to gracefully handle stack traces that appear within > freemarker on front end due to errors in ftl files. Instead of displaying > stack traces to the end user, we should have a simple, configurable way of > controlling levels of error messages that should be displayed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6691) Remove tooltip="${uiLabelMap.CommonRequired}" from fields
[
https://issues.apache.org/jira/browse/OFBIZ-6691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967315#comment-14967315
]
Jacques Le Roux commented on OFBIZ-6691:
OK I'm not used to discuss about what 3rd parties does or not. For me it's just
about what the issue title says not the description, doing so.
> Remove tooltip="${uiLabelMap.CommonRequired}" from fields
> -
>
> Key: OFBIZ-6691
> URL: https://issues.apache.org/jira/browse/OFBIZ-6691
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Pierre Smits
> Labels: validation
>
> The aspect 'required-field="true"' should deliver this. Therefor, this is
> unnecessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-1843) Suppress stack traces on front end due to errors in ftl files
[ https://issues.apache.org/jira/browse/OFBIZ-1843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-1843: --- Attachment: OFBIZ-1843.patch An updated patch (not w/o some efforts 7 year after). I will test it and I think commit > Suppress stack traces on front end due to errors in ftl files > - > > Key: OFBIZ-1843 > URL: https://issues.apache.org/jira/browse/OFBIZ-1843 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Reporter: Amit Shinde >Priority: Minor > Attachments: OFBIZ-1843.patch, OFBIZ-1843.patch, OFBIZ-1843.patch > > > We need to find a way to gracefully handle stack traces that appear within > freemarker on front end due to errors in ftl files. Instead of displaying > stack traces to the end user, we should have a simple, configurable way of > controlling levels of error messages that should be displayed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-6691) Remove tooltip="${uiLabelMap.CommonRequired}" from fields
[
https://issues.apache.org/jira/browse/OFBIZ-6691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966675#comment-14966675
]
Jacques Le Roux edited comment on OFBIZ-6691 at 10/21/15 3:24 PM:
--
I agree about simply removing all
{code}
[jira] [Assigned] (OFBIZ-619) Ability to disable single OPTION elements in form widget SELECTS
[ https://issues.apache.org/jira/browse/OFBIZ-619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-619: - Assignee: Jacques Le Roux > Ability to disable single OPTION elements in form widget SELECTS > > > Key: OFBIZ-619 > URL: https://issues.apache.org/jira/browse/OFBIZ-619 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Chris Liberty >Assignee: Jacques Le Roux >Priority: Minor > Attachments: FormWidget_DisableOption, v1.patch > > > It's nice to be able to disable an option in a select sometimes, even if > browser support isn't pervasive yet. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-1843) Suppress stack traces on front end due to errors in ftl files
[ https://issues.apache.org/jira/browse/OFBIZ-1843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-1843: -- Assignee: Jacques Le Roux > Suppress stack traces on front end due to errors in ftl files > - > > Key: OFBIZ-1843 > URL: https://issues.apache.org/jira/browse/OFBIZ-1843 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Reporter: Amit Shinde >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-1843.patch, OFBIZ-1843.patch, OFBIZ-1843.patch > > > We need to find a way to gracefully handle stack traces that appear within > freemarker on front end due to errors in ftl files. Instead of displaying > stack traces to the end user, we should have a simple, configurable way of > controlling levels of error messages that should be displayed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6691) Remove tooltip="${uiLabelMap.CommonRequired}" from fields
[
https://issues.apache.org/jira/browse/OFBIZ-6691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967326#comment-14967326
]
Jacques Le Roux commented on OFBIZ-6691:
OK, this must be done after OFBIZ-6690
> Remove tooltip="${uiLabelMap.CommonRequired}" from fields
> -
>
> Key: OFBIZ-6691
> URL: https://issues.apache.org/jira/browse/OFBIZ-6691
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Pierre Smits
> Labels: validation
>
> The aspect 'required-field="true"' should deliver this. Therefor, this is
> unnecessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6691) Remove tooltip="${uiLabelMap.CommonRequired}" from fields
[
https://issues.apache.org/jira/browse/OFBIZ-6691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967448#comment-14967448
]
Jacques Le Roux commented on OFBIZ-6691:
Commited at revision: 1709882
I don't close because this needs more work as explained above
> Remove tooltip="${uiLabelMap.CommonRequired}" from fields
> -
>
> Key: OFBIZ-6691
> URL: https://issues.apache.org/jira/browse/OFBIZ-6691
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Pierre Smits
> Labels: validation
>
> The aspect 'required-field="true"' should deliver this. Therefor, this is
> unnecessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6691) Remove tooltip="${uiLabelMap.CommonRequired}" from fields
[
https://issues.apache.org/jira/browse/OFBIZ-6691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967446#comment-14967446
]
Jacques Le Roux commented on OFBIZ-6691:
Instead of a quiet S/R action, this was an unexpected pain in the ass. A
considerable number of forms:
EmployeeForms.xml
EmploymentForms.xml
EmplPositionForms.xml
GlobalHRSettingForms.xml
RecruitmentForms.xml
QuoteForms.xml
PartyForms.xml
StoreForms.xml
ContactForms.xml
FixedAssetForms.xml
TaskForms.xml
scrumForms.xml
TaskForms.xml
contained a large number of fields with
{code}
tooltip="${uiLabelMap.CommonRequired}"
{code}
but no
{code}
required-field="true"
{code}
Of course display and display-entity should not be concerned, I spotted a
number of them in the lot.
I also removed a bunch of harcoded \* at end of labels (those followed by
*required-field="true"*) and spotted a number of others }\*" who still need to
be carefully reviewed to see if required=true is not missing there :/
> Remove tooltip="${uiLabelMap.CommonRequired}" from fields
> -
>
> Key: OFBIZ-6691
> URL: https://issues.apache.org/jira/browse/OFBIZ-6691
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Pierre Smits
> Labels: validation
>
> The aspect 'required-field="true"' should deliver this. Therefor, this is
> unnecessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-1690) Set widget default url encode value to true
[ https://issues.apache.org/jira/browse/OFBIZ-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-1690: --- Description: The bug is explained here: http://markmail.org/message/qoxevijc45yhaixo Can someone with framework access commit it please. Thanks, Bilgin was: The bug is explained here: http://www.nabble.com/Question-about-ofbiz-url-encoding-to15638660.html#a15638660 Can someone with framework access commit it please. Thanks, Bilgin > Set widget default url encode value to true > --- > > Key: OFBIZ-1690 > URL: https://issues.apache.org/jira/browse/OFBIZ-1690 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release 4.0, Trunk >Reporter: Bilgin Ibryam >Priority: Minor > Attachments: encode.patch, encode.patch > > > The bug is explained here: http://markmail.org/message/qoxevijc45yhaixo > Can someone with framework access commit it please. > Thanks, > Bilgin -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Reopened] (OFBIZ-6690) replace widget-style="required" with required-field="true"
[ https://issues.apache.org/jira/browse/OFBIZ-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-6690: I reopen because we need to deprecate and remove the required-field-style attribute > replace widget-style="required" with required-field="true" > -- > > Key: OFBIZ-6690 > URL: https://issues.apache.org/jira/browse/OFBIZ-6690 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Taher Alkhateeb > Labels: validation > Fix For: Upcoming Branch > > Attachments: OFBIZ-6690-SetupForms.xml.patch, > OFBIZ-6690-removewidgetstyle.patch > > > Currently many fields have 'widget-style="required" to indicate that input > for the field is required. Better is it to have 'required-field="true". This > not only opens up the possibility to define additional validation rules, but > the rendered also incorporates the aspects associated with > 'widget-style="required". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6690) replace widget-style="required" with required-field="true"
[ https://issues.apache.org/jira/browse/OFBIZ-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-6690. -- Resolution: Done Fix Version/s: Upcoming Branch Thanks Pierre, Taher Taher your slightly modified is committed at revision: 1709872 > replace widget-style="required" with required-field="true" > -- > > Key: OFBIZ-6690 > URL: https://issues.apache.org/jira/browse/OFBIZ-6690 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Taher Alkhateeb > Labels: validation > Fix For: Upcoming Branch > > Attachments: OFBIZ-6690-SetupForms.xml.patch, > OFBIZ-6690-removewidgetstyle.patch > > > Currently many fields have 'widget-style="required" to indicate that input > for the field is required. Better is it to have 'required-field="true". This > not only opens up the possibility to define additional validation rules, but > the rendered also incorporates the aspects associated with > 'widget-style="required". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-6691) Remove tooltip="${uiLabelMap.CommonRequired}" from fields
[ https://issues.apache.org/jira/browse/OFBIZ-6691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966675#comment-14966675 ] Jacques Le Roux edited comment on OFBIZ-6691 at 10/21/15 3:23 PM: -- I agree about simply removing all
[jira] [Closed] (OFBIZ-6690) replace widget-style="required" with required-field="true"
[ https://issues.apache.org/jira/browse/OFBIZ-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-6690. -- Resolution: Done > replace widget-style="required" with required-field="true" > -- > > Key: OFBIZ-6690 > URL: https://issues.apache.org/jira/browse/OFBIZ-6690 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Taher Alkhateeb > Labels: validation > Fix For: Upcoming Branch > > Attachments: OFBIZ-6690-SetupForms.xml.patch, > OFBIZ-6690-removewidgetstyle.patch > > > Currently many fields have 'widget-style="required" to indicate that input > for the field is required. Better is it to have 'required-field="true". This > not only opens up the possibility to define additional validation rules, but > the rendered also incorporates the aspects associated with > 'widget-style="required". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6065) Data of tenant specific component gets loaded in all instances
[ https://issues.apache.org/jira/browse/OFBIZ-6065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967588#comment-14967588 ] Taher Alkhateeb commented on OFBIZ-6065: There is no load-data target in the build file. Can you give a more concrete example to repeat? > Data of tenant specific component gets loaded in all instances > -- > > Key: OFBIZ-6065 > URL: https://issues.apache.org/jira/browse/OFBIZ-6065 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release Branch 14.12, Trunk, 14.12.01 >Reporter: Pierre Smits >Priority: Blocker > Labels: component, data, tenant > > When performing a ./ant load-data variant or using the import function in > webtools data of tenant specific component gets loaded into any tenant > (including master) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6690) replace widget-style="required" with required-field="true"
[ https://issues.apache.org/jira/browse/OFBIZ-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967496#comment-14967496 ] Taher Alkhateeb commented on OFBIZ-6690: I am not sure that we need to change anything else Jacques. We just need to stop manually assigning a CSS class using widget-style. In other words, we are just replacing manual CSS assignment with automatic one that comes from the required-field="true" attribute being set and translated at the template level. Or maybe I'm missing something? Not sure. > replace widget-style="required" with required-field="true" > -- > > Key: OFBIZ-6690 > URL: https://issues.apache.org/jira/browse/OFBIZ-6690 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Taher Alkhateeb > Labels: validation > Fix For: Upcoming Branch > > Attachments: OFBIZ-6690-SetupForms.xml.patch, > OFBIZ-6690-removewidgetstyle.patch > > > Currently many fields have 'widget-style="required" to indicate that input > for the field is required. Better is it to have 'required-field="true". This > not only opens up the possibility to define additional validation rules, but > the rendered also incorporates the aspects associated with > 'widget-style="required". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-1867) Tasks To Be Completed for Framework-only Release
[
https://issues.apache.org/jira/browse/OFBIZ-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=12660409#comment-12660409
]
Jacques Le Roux edited comment on OFBIZ-1867 at 10/21/15 5:49 PM:
--
{quote}
Jacques,
sorry for WebApp I meant actually "WebTools"
The forgot password mail is there but not strictly in the framework
(at least as I see is separable right now)
The Home application I meant is just a standard OFBiz webapp mounted
to the root so that it would be reached by http://localhost:8080
{quote}
-Bruno (from dev ML, I think we should keep such discussion in Jira issues to
keep focused and have easy access to history)
was (Author: jacques.le.roux):
Jacques,
sorry for WebApp I meant actually "WebTools"
The forgot password mail is there but not strictly in the framework
(at least as I see is separable right now)
The Home application I meant is just a standard OFBiz webapp mounted
to the root so that it would be reached by http://localhost:8080
-Bruno (from dev ML, I think we should keep such discussion in Jira issues to
keep focused and have easy access to history)
> Tasks To Be Completed for Framework-only Release
>
>
> Key: OFBIZ-1867
> URL: https://issues.apache.org/jira/browse/OFBIZ-1867
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Reporter: Adrian Crum
>Priority: Minor
>
> This is an umbrella issue intended for discussion on work that needs to be
> completed on the framework before its release. Individual efforts can be made
> sub tasks of this issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6691) Remove tooltip="${uiLabelMap.CommonRequired}" from fields
[
https://issues.apache.org/jira/browse/OFBIZ-6691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967701#comment-14967701
]
Adrian Crum commented on OFBIZ-6691:
Originally, OFBiz marked required fields with an asterisk - but it didn't
include an explanation of what the asterisk meant. So, the 'required' CSS class
and text was added to make it clearer that a field is required. The conversion
was incomplete, so there are still asterisks in the project.
> Remove tooltip="${uiLabelMap.CommonRequired}" from fields
> -
>
> Key: OFBIZ-6691
> URL: https://issues.apache.org/jira/browse/OFBIZ-6691
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Pierre Smits
> Labels: validation
>
> The aspect 'required-field="true"' should deliver this. Therefor, this is
> unnecessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6691) Remove tooltip="${uiLabelMap.CommonRequired}" from fields
[
https://issues.apache.org/jira/browse/OFBIZ-6691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967789#comment-14967789
]
Nicolas Malin commented on OFBIZ-6691:
--
Thks for the history reminding ;)
Adrian you confirm that the asterisk haven't an utility now ? My translation is
ambiguous
> Remove tooltip="${uiLabelMap.CommonRequired}" from fields
> -
>
> Key: OFBIZ-6691
> URL: https://issues.apache.org/jira/browse/OFBIZ-6691
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Pierre Smits
> Labels: validation
>
> The aspect 'required-field="true"' should deliver this. Therefor, this is
> unnecessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6691) Remove tooltip="${uiLabelMap.CommonRequired}" from fields
[
https://issues.apache.org/jira/browse/OFBIZ-6691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967692#comment-14967692
]
Nicolas Malin commented on OFBIZ-6691:
--
It's good way to clean all different case to define a require field.
I asked myself the question on the asterisk macro utility. I think is linked to
the theme and how is define, so maybe why don't need it
> Remove tooltip="${uiLabelMap.CommonRequired}" from fields
> -
>
> Key: OFBIZ-6691
> URL: https://issues.apache.org/jira/browse/OFBIZ-6691
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Pierre Smits
> Labels: validation
>
> The aspect 'required-field="true"' should deliver this. Therefor, this is
> unnecessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6379) Disentangle EC_Default theme elements from various components into separate theme
[ https://issues.apache.org/jira/browse/OFBIZ-6379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967928#comment-14967928 ] Jacques Le Roux commented on OFBIZ-6379: Hi Pierre, why did you finally closed these issues? > Disentangle EC_Default theme elements from various components into separate > theme > - > > Key: OFBIZ-6379 > URL: https://issues.apache.org/jira/browse/OFBIZ-6379 > Project: OFBiz > Issue Type: Improvement > Components: framework, specialpurpose/ecommerce >Affects Versions: Trunk >Reporter: Pierre Smits > > Currently elements of the EC_Default theme are incorporated in various > components. These elements should, however, be contained in a separate theme. > This will decrease complexity in the various components and potentially > enhance the experience of developers and/or (other) adopters. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6379) Disentangle EC_Default theme elements from various components into separate theme
[ https://issues.apache.org/jira/browse/OFBIZ-6379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits closed OFBIZ-6379. --- Resolution: Won't Fix > Disentangle EC_Default theme elements from various components into separate > theme > - > > Key: OFBIZ-6379 > URL: https://issues.apache.org/jira/browse/OFBIZ-6379 > Project: OFBiz > Issue Type: Improvement > Components: framework, specialpurpose/ecommerce >Affects Versions: Trunk >Reporter: Pierre Smits > > Currently elements of the EC_Default theme are incorporated in various > components. These elements should, however, be contained in a separate theme. > This will decrease complexity in the various components and potentially > enhance the experience of developers and/or (other) adopters. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6383) Remove EC_DEFAULT theme elements
[ https://issues.apache.org/jira/browse/OFBIZ-6383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits closed OFBIZ-6383. --- Resolution: Won't Fix > Remove EC_DEFAULT theme elements > > > Key: OFBIZ-6383 > URL: https://issues.apache.org/jira/browse/OFBIZ-6383 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6381) Create theme for EC_DEFAULT
[ https://issues.apache.org/jira/browse/OFBIZ-6381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits closed OFBIZ-6381. --- > Create theme for EC_DEFAULT > --- > > Key: OFBIZ-6381 > URL: https://issues.apache.org/jira/browse/OFBIZ-6381 > Project: OFBiz > Issue Type: Sub-task > Components: themes >Reporter: Pierre Smits >Assignee: Pierre Smits > > Currently a theme for the standard e-commerce theme is missing. Elements for > this are in the e-commerce component. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6385) adjust data sets regarding EC_DEFAULT
[ https://issues.apache.org/jira/browse/OFBIZ-6385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits closed OFBIZ-6385. --- Resolution: Won't Fix > adjust data sets regarding EC_DEFAULT > - > > Key: OFBIZ-6385 > URL: https://issues.apache.org/jira/browse/OFBIZ-6385 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-6379) Disentangle EC_Default theme elements from various components into separate theme
[ https://issues.apache.org/jira/browse/OFBIZ-6379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967928#comment-14967928 ] Jacques Le Roux edited comment on OFBIZ-6379 at 10/21/15 9:23 PM: -- Hi Pierre, why did you finally close these issues? was (Author: jacques.le.roux): Hi Pierre, why did you finally closed these issues? > Disentangle EC_Default theme elements from various components into separate > theme > - > > Key: OFBIZ-6379 > URL: https://issues.apache.org/jira/browse/OFBIZ-6379 > Project: OFBiz > Issue Type: Improvement > Components: framework, specialpurpose/ecommerce >Affects Versions: Trunk >Reporter: Pierre Smits > > Currently elements of the EC_Default theme are incorporated in various > components. These elements should, however, be contained in a separate theme. > This will decrease complexity in the various components and potentially > enhance the experience of developers and/or (other) adopters. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6379) Disentangle EC_Default theme elements from various components into separate theme
[ https://issues.apache.org/jira/browse/OFBIZ-6379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967965#comment-14967965 ] Pierre Smits commented on OFBIZ-6379: - Hi Jacques. Thanks for the question. The short answer is: I have made it available to the OFBiz community available through other channels. > Disentangle EC_Default theme elements from various components into separate > theme > - > > Key: OFBIZ-6379 > URL: https://issues.apache.org/jira/browse/OFBIZ-6379 > Project: OFBiz > Issue Type: Improvement > Components: framework, specialpurpose/ecommerce >Affects Versions: Trunk >Reporter: Pierre Smits > > Currently elements of the EC_Default theme are incorporated in various > components. These elements should, however, be contained in a separate theme. > This will decrease complexity in the various components and potentially > enhance the experience of developers and/or (other) adopters. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6618) Selenium test integration using XML files
[
https://issues.apache.org/jira/browse/OFBIZ-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968330#comment-14968330
]
Hans Bakker commented on OFBIZ-6618:
Thank you for your help in this matter and holding up further development in
the area of continuous testing.
> Selenium test integration using XML files
> -
>
> Key: OFBIZ-6618
> URL: https://issues.apache.org/jira/browse/OFBIZ-6618
> Project: OFBiz
> Issue Type: Test
> Components: framework
>Reporter: Ruud Griepsma
>Assignee: Hans Bakker
>Priority: Minor
> Labels: selenium, test, webdriver
> Fix For: Trunk
>
> Attachments: ModelTestSuite.patch, build.patch, test-suite.patch
>
>
> Added a new type of test, for testing with Selenium WebDriver, but without
> writing any Java code. This will help making GUI tests quicker and easier to
> create. Test steps and instances are defined in XML files, like example
> below, which tests the login procedure for the admin user.
> {code}
>
>
>datavalue="https://localhost:8443/example/control/checkLogin/main"/>
>dataname="username"/>
>dataname="password"/>
>webobject="input[type=submit]"/>
>
>
>
>
>
>
>
>
>
> {code}
> Git repository with example (put in 'hot-deploy' folder and check README.txt
> file):
> {code}
> git clone https://gerrit.antwebsystems.com/growerptest
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (OFBIZ-3654) Returning "failure" from a shipment estimator has no impact on subsequent processing
[ https://issues.apache.org/jira/browse/OFBIZ-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb closed OFBIZ-3654. -- Resolution: Won't Fix This issue cannot be resolved because of design problems in the entire checkout process and the way sessions are stored. Hence, we will close this issue and open another one later on to figure out how to simplify the overly complex order workflow. > Returning "failure" from a shipment estimator has no impact on subsequent > processing > > > Key: OFBIZ-3654 > URL: https://issues.apache.org/jira/browse/OFBIZ-3654 > Project: OFBiz > Issue Type: Bug > Components: product >Reporter: Ean Schuessler > > The UPS processor includes a comment "Important: DO NOT returnError here or > you could trigger a transaction rollback and break other services." > Returning a failure, however, is basically ignored and only causes the > estimate to return a zero amount estimate. It should be possible to return a > proper error message for further processing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-566) Searching on 'widgets' in the demo shouldn't tell you that the category is empty
[ https://issues.apache.org/jira/browse/OFBIZ-566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-566. - Resolution: Cannot Reproduce Assignee: Jacques Le Roux > Searching on 'widgets' in the demo shouldn't tell you that the category is > empty > > > Key: OFBIZ-566 > URL: https://issues.apache.org/jira/browse/OFBIZ-566 > Project: OFBiz > Issue Type: Improvement > Components: specialpurpose/ecommerce >Affects Versions: Trunk >Reporter: David N. Welton >Assignee: Jacques Le Roux >Priority: Trivial > > Hi, > I was perusing OFBiz again to gain some insights, and one thing jumped out at > me as a minor annoyance that ought to be fixed, so I'm reporting it. > The problem is that when you click on 'widgets' in the demo', you get a > screen saying that "There are no products in this category", as well as > getting the two subcategories expanded on the left bar. > If I am trying to sell stuff, I think I would prefer to have products in this > category's subcategories come up, if there is nothing in the category itself, > as well as a list of the subcategories that could be selected. I know that > things are meant to be customized, but the better the defaults are, the > easier it is for people to see how cool OFBiz is, and start using it with > less modification required. > Unfortunately, I don't have the time or incentives to take care of this... > the query I'd be after is something like this: > select * from product_category_member where product_category_id in (select > product_category_id from product_category where primary_parent_category_id = > '200' or product_category_id = '200') limit N; (200 is 'widgets') > But I don't know how to implement that... > Thanks, > Dave -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-566) Searching on 'widgets' in the demo shouldn't tell you that the category is empty
[ https://issues.apache.org/jira/browse/OFBIZ-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966774#comment-14966774 ] Jacques Le Roux commented on OFBIZ-566: --- Both ecommerce and ercomseo return 3 values (I did not check it's all but I guess it's OK) > Searching on 'widgets' in the demo shouldn't tell you that the category is > empty > > > Key: OFBIZ-566 > URL: https://issues.apache.org/jira/browse/OFBIZ-566 > Project: OFBiz > Issue Type: Improvement > Components: specialpurpose/ecommerce >Affects Versions: Trunk >Reporter: David N. Welton >Assignee: Jacques Le Roux >Priority: Trivial > > Hi, > I was perusing OFBiz again to gain some insights, and one thing jumped out at > me as a minor annoyance that ought to be fixed, so I'm reporting it. > The problem is that when you click on 'widgets' in the demo', you get a > screen saying that "There are no products in this category", as well as > getting the two subcategories expanded on the left bar. > If I am trying to sell stuff, I think I would prefer to have products in this > category's subcategories come up, if there is nothing in the category itself, > as well as a list of the subcategories that could be selected. I know that > things are meant to be customized, but the better the defaults are, the > easier it is for people to see how cool OFBiz is, and start using it with > less modification required. > Unfortunately, I don't have the time or incentives to take care of this... > the query I'd be after is something like this: > select * from product_category_member where product_category_id in (select > product_category_id from product_category where primary_parent_category_id = > '200' or product_category_id = '200') limit N; (200 is 'widgets') > But I don't know how to implement that... > Thanks, > Dave -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-4090) Add Support For Compound Screen Widget XML Files
[ https://issues.apache.org/jira/browse/OFBIZ-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966788#comment-14966788 ] Jacques Le Roux commented on OFBIZ-4090: HI Adrian, what's the status here? > Add Support For Compound Screen Widget XML Files > > > Key: OFBIZ-4090 > URL: https://issues.apache.org/jira/browse/OFBIZ-4090 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Adrian Crum >Priority: Minor > Attachments: CompoundWidgetFiles.patch, CompoundWidgetFiles.patch > > > Add the ability to include screen widgets, form widgets, menu widgets, and > simple methods in a single XML file. This approach could be used in > situations where the widgets share a logical grouping - so they can be kept > in one place. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-2104) Support for sub-menu is not completely implemented in the menu widget
[ https://issues.apache.org/jira/browse/OFBIZ-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966789#comment-14966789 ] Jacques Le Roux commented on OFBIZ-2104: Nobody interested? > Support for sub-menu is not completely implemented in the menu widget > - > > Key: OFBIZ-2104 > URL: https://issues.apache.org/jira/browse/OFBIZ-2104 > Project: OFBiz > Issue Type: Improvement > Components: framework >Reporter: Bruno Busco > > In the menu widget it seems to be definitions for a sub-menu tag but there is > no rendering. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-297) Have screen widgets render for in-page links
[ https://issues.apache.org/jira/browse/OFBIZ-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966794#comment-14966794 ] Jacques Le Roux commented on OFBIZ-297: --- What is the community feeling about this? > Have screen widgets render for in-page links > > > Key: OFBIZ-297 > URL: https://issues.apache.org/jira/browse/OFBIZ-297 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: Marco Risaliti >Priority: Minor > Attachments: proposed-anchorScreenWidget.patch > > > Copy of http://jira.undersunconsulting.com/browse/OFBIZ-753 from Leon Torres. > > Some pages can be very long, so it would be extra helpful to have a way to > jump to a particular part of the page using the HTML anchor tags name="">. > For instance, if the screen widget allowed, > > This is a List of Orders > > And the ListOrders form had a header-link with #ListOrders as part of the > target, it would jump back to the location of the anchor. > > > AllCommentsWork LogChange History Sort Order: > Comment by Leon Torres [17/Feb/06 07:20 PM] [ Permlink ] > Here's an update to the screen widget system that allows the use of name=""/> to render . > Not sure if the tree widget or anything else needs it or not, please double > check. > Comment by David E. Jones [26/Feb/06 01:15 AM] [ Permlink ] > I'll have to think about this a bit more... It probably does make the most > sense to put it in the screen widget, but this seems right now to me to be a > little too close to HTML and not generic enough for use in non-HTML rendering > of screens. We don't have anything to do this right now, but it is very much > part of the intent to keep this direction open and explicit. > If you have any ideas along these lines let's discuss them, and I'll think > about it as well. Perhaps just an element like this is generic enough... but > there is probably something more generally applicable we could do. > Comment by Si Chen [27/Feb/06 08:56 AM] [ Permlink ] > David, > I see what you mean. DocBook also has an "anchor" tag: > http://www.docbook.org/tdg/en/html/anchor.html > Do you think that qualifies it as a "universal" or "generic" document format > concept? > Si > Comment by David E. Jones [12/Mar/06 10:23 PM] [ Permlink ] > Si, > Yes, and I guess even more significantly HTML has such a concept (I'm > guessing there's still a lot more HTML being generated through the screen > widget than DocBook). That's what concerns me the most: it's a very document > oriented concept and not something that you find as much in applications, or > in "screens". > Still, I think it's a useful concept and perhaps one that would be nice to > have as a special screen widget element because if I understand correctly > what you're shooting for it is to have a reference point for the beginning of > different sections of a screen. > And if it is really for the beginning point of a section of a screen... we > already have a nice place that would fit in: the section element. We could > just change the HTML generation to create an anchor () for the > start of each section if the section has a name associated with it... > Does that sound like it would hit more or less the goal you are shooting for? > Comment by Leon Torres [16/Mar/06 04:39 PM] [ Permlink ] > David, > I don't like the idea of using section element names for two reasons: > 1) I would have to wrap each block that needs such an anchor in a > and then a , creating additional lines of code. While it would be > nice to reuse the code and not introduce more form elements, in > reality it would just shift additional code to the user the form-widget. > 2) Anchors are important elements of many UI applications which work with > complex documents. For example, the Eclipse IDE, like most editors, allows > you to click on a method name and then scrolls your code to the line where > the method is defined. Thus, the method name could be thought of as an > anchor. > So I still think we should have an anchor tag. > - Leon > Comment by Si Chen [22/Mar/06 07:58 AM] [ Permlink ] > David, > So do you not like this patch? If not, just let us know, and I'll close out > the issue, and we'll do it some other way. > Thanks, > Si > Comment by Marco Risaliti [13/Sep/06 04:27 PM] [ Permlink ] > What to do here, close it or move it. > Thanks > Marco -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6691) Remove tooltip="${uiLabelMap.CommonRequired}" from fields
[
https://issues.apache.org/jira/browse/OFBIZ-6691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966602#comment-14966602
]
Jacques Le Roux commented on OFBIZ-6691:
We maybe not want to systematically have the tooltip?
> Remove tooltip="${uiLabelMap.CommonRequired}" from fields
> -
>
> Key: OFBIZ-6691
> URL: https://issues.apache.org/jira/browse/OFBIZ-6691
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Pierre Smits
> Labels: validation
>
> The aspect 'required-field="true"' should deliver this. Therefor, this is
> unnecessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6690) replace widget-style="required" with required-field="true"
[ https://issues.apache.org/jira/browse/OFBIZ-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966600#comment-14966600 ] Jacques Le Roux commented on OFBIZ-6690: I agree about your conclusions. We should replace all instances and completely remove
[jira] [Comment Edited] (OFBIZ-6691) Remove tooltip="${uiLabelMap.CommonRequired}" from fields
[
https://issues.apache.org/jira/browse/OFBIZ-6691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966612#comment-14966612
]
Pierre Smits edited comment on OFBIZ-6691 at 10/21/15 10:36 AM:
So you want to have specific tooltip for required fields adding hard coded
redundancy on top of the 'required-field="true" attribute, while (at the same
time) the rendering function in htmlFormMacroLibrary.ftl can deliver the same
dynamically?
was (Author: pfm.smits):
So you want to have specific tooltip for required fields on top of the
'required-field="true" attribute adding hard coded redundancy , while at the
same time the rendering function in htmlFormMacroLibrary.ftl can deliver the
same dynamically?
> Remove tooltip="${uiLabelMap.CommonRequired}" from fields
> -
>
> Key: OFBIZ-6691
> URL: https://issues.apache.org/jira/browse/OFBIZ-6691
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Pierre Smits
> Labels: validation
>
> The aspect 'required-field="true"' should deliver this. Therefor, this is
> unnecessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6691) Remove tooltip="${uiLabelMap.CommonRequired}" from fields
[
https://issues.apache.org/jira/browse/OFBIZ-6691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966612#comment-14966612
]
Pierre Smits commented on OFBIZ-6691:
-
So you want to have specific tooltip for required fields on top of the
'required-field="true" attribute adding hard coded redundancy , while at the
same time the rendering function in htmlFormMacroLibrary.ftl can deliver the
same dynamically?
> Remove tooltip="${uiLabelMap.CommonRequired}" from fields
> -
>
> Key: OFBIZ-6691
> URL: https://issues.apache.org/jira/browse/OFBIZ-6691
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Pierre Smits
> Labels: validation
>
> The aspect 'required-field="true"' should deliver this. Therefor, this is
> unnecessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6691) Remove tooltip="${uiLabelMap.CommonRequired}" from fields
[
https://issues.apache.org/jira/browse/OFBIZ-6691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966623#comment-14966623
]
Jacques Le Roux commented on OFBIZ-6691:
Nope, simply not make the tooltip necessary
> Remove tooltip="${uiLabelMap.CommonRequired}" from fields
> -
>
> Key: OFBIZ-6691
> URL: https://issues.apache.org/jira/browse/OFBIZ-6691
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Pierre Smits
> Labels: validation
>
> The aspect 'required-field="true"' should deliver this. Therefor, this is
> unnecessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-6690) replace widget-style="required" with required-field="true"
[ https://issues.apache.org/jira/browse/OFBIZ-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb reassigned OFBIZ-6690: -- Assignee: Taher Alkhateeb > replace widget-style="required" with required-field="true" > -- > > Key: OFBIZ-6690 > URL: https://issues.apache.org/jira/browse/OFBIZ-6690 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Taher Alkhateeb > Labels: validation > Attachments: OFBIZ-6690-SetupForms.xml.patch, > OFBIZ-6690-removewidgetstyle.patch > > > Currently many fields have 'widget-style="required" to indicate that input > for the field is required. Better is it to have 'required-field="true". This > not only opens up the possibility to define additional validation rules, but > the rendered also incorporates the aspects associated with > 'widget-style="required". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-3654) Returning "failure" from a shipment estimator has no impact on subsequent processing
[ https://issues.apache.org/jira/browse/OFBIZ-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966631#comment-14966631 ] Jacques Le Roux commented on OFBIZ-3654: I agree Taher, thanks for your investigation. > Returning "failure" from a shipment estimator has no impact on subsequent > processing > > > Key: OFBIZ-3654 > URL: https://issues.apache.org/jira/browse/OFBIZ-3654 > Project: OFBiz > Issue Type: Bug > Components: product >Reporter: Ean Schuessler > > The UPS processor includes a comment "Important: DO NOT returnError here or > you could trigger a transaction rollback and break other services." > Returning a failure, however, is basically ignored and only causes the > estimate to return a zero amount estimate. It should be possible to return a > proper error message for further processing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6690) replace widget-style="required" with required-field="true"
[
https://issues.apache.org/jira/browse/OFBIZ-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966509#comment-14966509
]
Taher Alkhateeb commented on OFBIZ-6690:
Okay, so on another search in the entire framework I see the following:
||item||count in code||
|required-field="true"|62|
|widget-style="required"|140|
so this means most of the required fields are enforced with the widget-style
format instead of the required-field format. I can also see something like the
below code snippet which I think only happens in the required-field, not the
styled one.
So the question I have now is why do we have two ways of showing a field as
required, and shouldn't we remove one of the two completely from the code base
for consistency's sake? What do you think?
{code}
<#macro renderFormClose focusFieldName formName containerId hasRequiredField>
<#lt/>
<#if focusFieldName?has_content>
var form = document.${formName};
form.${focusFieldName}.focus();
<#-- enable the validation plugin for all generated forms
only enable the validation if min one field is marked as 'required' -->
if (jQuery(form).find(".required").size() > 0) {
jQuery(form).validate();
}
<#lt/>
<#if containerId?has_content && hasRequiredField?has_content>
jQuery("#${containerId}").validate({
submitHandler:
function(form) {
form.submit();
}
});
{code}
> replace widget-style="required" with required-field="true"
> --
>
> Key: OFBIZ-6690
> URL: https://issues.apache.org/jira/browse/OFBIZ-6690
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Pierre Smits
> Labels: validation
> Attachments: OFBIZ-6690-SetupForms.xml.patch,
> OFBIZ-6690-removewidgetstyle.patch
>
>
> Currently many fields have 'widget-style="required" to indicate that input
> for the field is required. Better is it to have 'required-field="true". This
> not only opens up the possibility to define additional validation rules, but
> the rendered also incorporates the aspects associated with
> 'widget-style="required".
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6689) Have more flexibility in framework and applications regarding theming frameworks.
[ https://issues.apache.org/jira/browse/OFBIZ-6689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966626#comment-14966626 ] Jacques Le Roux commented on OFBIZ-6689: Don't we have already some/a Jira like this one? > Have more flexibility in framework and applications regarding theming > frameworks. > - > > Key: OFBIZ-6689 > URL: https://issues.apache.org/jira/browse/OFBIZ-6689 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS, framework, themes >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits > > Modern theming frameworks like Bootstrap and Foundation define their own > styling elements. In order to facilitate these frameworks (and others), the > framework and applications need to be improved. > This is an umbrella issue to track associated issues and sub tasks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6691) Remove tooltip="${uiLabelMap.CommonRequired}" from fields
[
https://issues.apache.org/jira/browse/OFBIZ-6691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966703#comment-14966703
]
Pierre Smits commented on OFBIZ-6691:
-
Read my previous posting again: it said that the rendering furnction can
deliver this.
Whether third parties want to have it as such they can take care of it
themselves. And if there is consensus regarding the 'should' or must aspect
leading to changing the renderer then we have a point validating the
requirement and we can plan accordingly.
> Remove tooltip="${uiLabelMap.CommonRequired}" from fields
> -
>
> Key: OFBIZ-6691
> URL: https://issues.apache.org/jira/browse/OFBIZ-6691
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Pierre Smits
> Labels: validation
>
> The aspect 'required-field="true"' should deliver this. Therefor, this is
> unnecessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-5545) Be able to set the period the GL transaction applies to
[ https://issues.apache.org/jira/browse/OFBIZ-5545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966740#comment-14966740 ] David Hughes-Owens commented on OFBIZ-5545: --- I am revisiting the accounting functionality, as we may wish to use it for our overseas subsidiary companies, and this issue is one that I believe should be re-opened. The ability to record an accounting transaction in the correct period is a fundamental requirement for the accounting module. Currently, an ofbiz accounting transaction will attempt to post based on the transaction date. If the transaction is dated is in the past and that period has been closed, it causes an error and posts to the suspense journal. For our purchase orders, we have got around this issue by changing the accounting transaction date to allow it to post into the current open period. Thus making the transaction and posting date the same. However this is technically incorrect from an accounting/tax perspective, as the transaction date should be the date of the transaction i.e. the supplier invoice date. We currently export our invoice records to an external accounting package and therefore can send this the correct data, having posted incorrectly in Ofbiz. I feel the easiest solution, as per the title of this jira item, would be to set a period number against each accounting transaction and therefore ensure it posts to the correct accounting period. The transaction and posting dates should then represent their true values. > Be able to set the period the GL transaction applies to > --- > > Key: OFBIZ-5545 > URL: https://issues.apache.org/jira/browse/OFBIZ-5545 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk >Reporter: Pierre Smits > > Currently, when doing gl transactions (whether automated/scheduled or > manually), the transaction is always associated with the current (running) > time period. > However, it is general practice to have transactions (mainly corrective) > after a period has been past, e.g. as a result of audits and such. > Therefore, it should be possible to set a period on each gl transaction that > overrides the default. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6618) Selenium test integration using XML files
[
https://issues.apache.org/jira/browse/OFBIZ-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966635#comment-14966635
]
Pierre Smits commented on OFBIZ-6618:
-
So without existing context in the OFBiz code base this is just catering to the
needs of a particular third-party. Not the Community.
Without a vision and subsequent road-map (having the consensus of the
community) regarding testing in general and web-testing in particular, this is
just bloatware.
I advice to have this reverted, until we have the prerequisites in place.
> Selenium test integration using XML files
> -
>
> Key: OFBIZ-6618
> URL: https://issues.apache.org/jira/browse/OFBIZ-6618
> Project: OFBiz
> Issue Type: Test
> Components: framework
>Reporter: Ruud Griepsma
>Assignee: Hans Bakker
>Priority: Minor
> Labels: selenium, test, webdriver
> Fix For: Trunk
>
> Attachments: ModelTestSuite.patch, build.patch, test-suite.patch
>
>
> Added a new type of test, for testing with Selenium WebDriver, but without
> writing any Java code. This will help making GUI tests quicker and easier to
> create. Test steps and instances are defined in XML files, like example
> below, which tests the login procedure for the admin user.
> {code}
>
>
>datavalue="https://localhost:8443/example/control/checkLogin/main"/>
>dataname="username"/>
>dataname="password"/>
>webobject="input[type=submit]"/>
>
>
>
>
>
>
>
>
>
> {code}
> Git repository with example (put in 'hot-deploy' folder and check README.txt
> file):
> {code}
> git clone https://gerrit.antwebsystems.com/growerptest
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (OFBIZ-6692) Improve xsd definitions
Pierre Smits created OFBIZ-6692: --- Summary: Improve xsd definitions Key: OFBIZ-6692 URL: https://issues.apache.org/jira/browse/OFBIZ-6692 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Pierre Smits xsd files should be updated when related changes in associated framework components get persisted. This is an umbrella issue to track associated issues and subtasks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-6693) Add 'request-confirmation' to the link element
Pierre Smits created OFBIZ-6693: --- Summary: Add 'request-confirmation' to the link element Key: OFBIZ-6693 URL: https://issues.apache.org/jira/browse/OFBIZ-6693 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: Trunk Reporter: Pierre Smits -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-5354) Invoice widget to list Shipment items that have yet to be invoiced
[ https://issues.apache.org/jira/browse/OFBIZ-5354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-5354: --- Description: There should exist some widget that indicates shipment items that have yet to be invoiced. I have found no easy way to find such records. This will be needed more if the InvoiceItem statusId is implemented as mentioned in this issue: OFBIZ-5352 was: There should exist some widget that indicates shipment items that have yet to be invoiced. I have found no easy way to find such records. This will be needed more if the InvoiceItem statusId is implemented as mentioned in this issue: https://issues.apache.org/jira/browse/OFBIZ-5352?filter=-2 > Invoice widget to list Shipment items that have yet to be invoiced > -- > > Key: OFBIZ-5354 > URL: https://issues.apache.org/jira/browse/OFBIZ-5354 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Release Branch 12.04 >Reporter: Christian Carlow > > There should exist some widget that indicates shipment items that have yet to > be invoiced. > I have found no easy way to find such records. > This will be needed more if the InvoiceItem statusId is implemented as > mentioned in this issue: > OFBIZ-5352 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6689) Have more flexibility in framework and applications regarding theming frameworks.
[ https://issues.apache.org/jira/browse/OFBIZ-6689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966641#comment-14966641 ] Pierre Smits commented on OFBIZ-6689: - If and when you find the answer to that question, please add a link. > Have more flexibility in framework and applications regarding theming > frameworks. > - > > Key: OFBIZ-6689 > URL: https://issues.apache.org/jira/browse/OFBIZ-6689 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS, framework, themes >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits > > Modern theming frameworks like Bootstrap and Foundation define their own > styling elements. In order to facilitate these frameworks (and others), the > framework and applications need to be improved. > This is an umbrella issue to track associated issues and sub tasks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6667) Remove limitation regarding menu-name in ofbiz-component.xsd
[
https://issues.apache.org/jira/browse/OFBIZ-6667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Smits updated OFBIZ-6667:
Issue Type: Sub-task (was: Improvement)
Parent: OFBIZ-6692
> Remove limitation regarding menu-name in ofbiz-component.xsd
>
>
> Key: OFBIZ-6667
> URL: https://issues.apache.org/jira/browse/OFBIZ-6667
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
> Labels: menus
> Attachments: OFBIZ-6667-ofbiz-component.xsd.patch
>
>
> Currently the following is in the ofbiz-component.xsd:
> {code}
>
>
>
>
>
>
>
>
> {code}
> However, this is limiting the options that can be applied generates
> unnecessary errors when developers opt for another methodology.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-5534) Dirty reads from entity cache
[ https://issues.apache.org/jira/browse/OFBIZ-5534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966685#comment-14966685 ] Jacques Le Roux commented on OFBIZ-5534: Lack of communication does not help :( > Dirty reads from entity cache > - > > Key: OFBIZ-5534 > URL: https://issues.apache.org/jira/browse/OFBIZ-5534 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release Branch 11.04, Release Branch 12.04, Release > Branch 13.07, Trunk >Reporter: Jacopo Cappellato >Assignee: Adam Heath > Attachments: unittest-dirtyreadsfromcache.patch > > > Even if database transaction isolation level is set to "ReadCommitted", a > transaction can get uncommitted records from the entity cache, under certain > circumstances. > Here is a test case: > 1) transaction T1 creates a record > 2) T1 calls findOne to retrieve it: the read will be successful (because T1 > can read data generated in T1 even if not committed) and the record will be > added to the cache > 3) T1 calls another service with requireNewTransaction set to true: this will > run the second service in a new transaction T2 > 4) T2 calls findOne to retrieve the record created by T1: if useCache is set > to false it should fail; if useCache is set to true it will succeed (getting > the record from cache, even if the data is not committed to the db) > The result in #4 is wrong because T2 should not see the uncommitted record > We should never add uncommitted records to the entity cache. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6690) replace widget-style="required" with required-field="true"
[
https://issues.apache.org/jira/browse/OFBIZ-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966403#comment-14966403
]
Pierre Smits commented on OFBIZ-6690:
-
Hi Taher,
I counted far less in the patch I provided, but you are right: there are more
in other files.
The related aspect in the renderer in htmlFormMacroLibrary is this:
{code}
<#macro renderAsterisks requiredField requiredStyle>
<#if requiredField=="true"><#if !requiredStyle?has_content>*
{code}
And yes, I did test.
> replace widget-style="required" with required-field="true"
> --
>
> Key: OFBIZ-6690
> URL: https://issues.apache.org/jira/browse/OFBIZ-6690
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Pierre Smits
> Labels: validation
> Attachments: OFBIZ-6690-SetupForms.xml.patch,
> OFBIZ-6690-removewidgetstyle.patch
>
>
> Currently many fields have 'widget-style="required" to indicate that input
> for the field is required. Better is it to have 'required-field="true". This
> not only opens up the possibility to define additional validation rules, but
> the rendered also incorporates the aspects associated with
> 'widget-style="required".
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
