[jira] [Commented] (OFBIZ-6993) Cannot find the declaration of element 'web-app' in version 3.0 files.

2016-04-07 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15231716#comment-15231716
 ] 

Deepak Dixit commented on OFBIZ-6993:
-

Hi Forrest,

I think its not so simple, as initially I tried this but we its an chain of 
.xsd, 
- http://java.sun.com/xml/ns/javaee/web-app_3_0.xsd included web-common_3_0.xsd
- web-common_3_0.xsd  includes  javaee_6.xsd and jsp_2_2.xsd
- and so on.

So you need to put all these xsd into system. I think if you are not connected 
to internet or an network error occurred  then only you will get the reported 
error

> Cannot find the declaration of element 'web-app' in version 3.0 files.
> --
>
> Key: OFBIZ-6993
> URL: https://issues.apache.org/jira/browse/OFBIZ-6993
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk, Release Branch 15.12
> Environment: Been seeing the error below in the logs.  Strangely, 
> I've not been able to catch the exception in a debugger, but was able to 
> isolate it to the definition of the web-app with version 3.0.  The error 
> disapears when you change the definition from 
> {code:xml}
> 
> {code}
> to this:
> {code:xml}
>   xmlns="http://java.sun.com/xml/ns/javaee";
>  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>  xsi:schemaLocation="http://java.sun.com/xml/ns/javaee 
> http://java.sun.com/xml/ns/javaee/web-app_3_0.xsd";>
> {code}
> I only tested on 15.12 and Trunk, but it probably affects any release running 
> Tomcat 7.0.48 or higher.  Here is the error:
> {noformat}
>  [java] Apr 07, 2016 4:06:29 PM org.apache.tomcat.util.digester.Digester 
> error
>  [java] SEVERE: Parse Error at line 22 column 24: cvc-elt.1.a: Cannot 
> find the declaration of element 'web-app'.
>  [java] org.xml.sax.SAXParseException; lineNumber: 22; columnNumber: 24; 
> cvc-elt.1.a: Cannot find the declaration of element 'web-app'.
>  [java]   at 
> org.apache.xerces.util.ErrorHandlerWrapper.createSAXParseException(Unknown 
> Source)
>  [java]   at org.apache.xerces.util.ErrorHandlerWrapper.error(Unknown 
> Source)
>  [java]   at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown 
> Source)
>  [java]   at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown 
> Source)
>  [java]   at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown 
> Source)
>  [java]   at 
> org.apache.xerces.impl.xs.XMLSchemaValidator.handleStartElement(Unknown 
> Source)
>  [java]   at 
> org.apache.xerces.impl.xs.XMLSchemaValidator.startElement(Unknown Source)
>  [java]   at 
> org.apache.xerces.impl.XMLNSDocumentScannerImpl.scanStartElementAfterName(Unknown
>  Source)
>  [java]   at 
> org.apache.xerces.impl.XMLNSDocumentScannerImpl$NSContentDispatcher.scanRootElementHook(Unknown
>  Source)
>  [java]   at 
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown
>  Source)
>  [java]   at 
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown 
> Source)
>  [java]   at org.apache.xerces.parsers.XML11Configuration.parse(Unknown 
> Source)
>  [java]   at org.apache.xerces.parsers.XML11Configuration.parse(Unknown 
> Source)
>  [java]   at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
>  [java]   at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown 
> Source)
>  [java]   at 
> org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser.parse(Unknown Source)
>  [java]   at 
> org.apache.tomcat.util.digester.Digester.parse(Digester.java:1555)
>  [java]   at 
> org.ofbiz.webapp.WebAppUtil.parseWebXmlFile(WebAppUtil.java:160)
>  [java]   at org.ofbiz.webapp.WebAppUtil.getWebXml(WebAppUtil.java:131)
>  [java]   at 
> org.ofbiz.webapp.WebAppUtil.getControlServletPath(WebAppUtil.java:67)
>  [java]   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>  [java]   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>  [java]   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  [java]   at java.lang.reflect.Method.invoke(Method.java:498)
>  [java]   at 
> freemarker.ext.beans.BeansWrapper.invokeMethod(BeansWrapper.java:1458)
>  [java]   at 
> freemarker.ext.beans.SimpleMethodModel.exec(SimpleMethodModel.java:71)
>  [java]   at freemarker.core.MethodCall._eval(MethodCall.java:62)
>  [java]   at freemarker.core.Expression.eval(Expression.java:78)
>  [java]   at freemarker.core.Assignment.accept(Assignment.java:70)
>  [java]   at freemarker.core.Environment.visit(Environment.java:312)
>  [java]   at freemarker.core.MixedContent.accept(MixedContent.java:62)
>  [java]  

[jira] [Updated] (OFBIZ-6995) error in entity reference chart for static in webtools

2016-04-07 Thread Kongrath Suankaewmanee (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kongrath Suankaewmanee updated OFBIZ-6995:
--
Attachment: OFBIZ-6995.patch

> error in entity reference chart for static in webtools
> --
>
> Key: OFBIZ-6995
> URL: https://issues.apache.org/jira/browse/OFBIZ-6995
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Kongrath Suankaewmanee
>Priority: Minor
> Attachments: OFBIZ-6995.patch
>
>
> Hi All,
> I found the error when I try to use entity reference chart for static in 
> webtools,
> https://localhost:8443/webtools/control/entityref?forstatic=true
> and choose one from the list of left side and the error appear on right hand 
> side.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-6995) error in entity reference chart for static in webtools

2016-04-07 Thread Kongrath Suankaewmanee (JIRA)
Kongrath Suankaewmanee created OFBIZ-6995:
-

 Summary: error in entity reference chart for static in webtools
 Key: OFBIZ-6995
 URL: https://issues.apache.org/jira/browse/OFBIZ-6995
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: Trunk
Reporter: Kongrath Suankaewmanee
Priority: Minor


Hi All,

I found the error when I try to use entity reference chart for static in 
webtools,

https://localhost:8443/webtools/control/entityref?forstatic=true

and choose one from the list of left side and the error appear on right hand 
side.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6989) Editing project in Project Manager duplicates resources

2016-04-07 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15231701#comment-15231701
 ] 

Deepak Dixit commented on OFBIZ-6989:
-

I can confirm this issue exists.

> Editing project in Project Manager duplicates resources
> ---
>
> Key: OFBIZ-6989
> URL: https://issues.apache.org/jira/browse/OFBIZ-6989
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/projectmgr
>Affects Versions: Release Branch 15.12
>Reporter: Montalbano Florian
>Priority: Minor
>  Labels: duplicate, projectmgr, resources
>
> In the Ofbiz 15.12 release (i didn't test it on the other version), when 
> selecting a project from the list and trying to edit it, clicking on the save 
> button cause the Client Billing Party Id and the Organization Party Id to be 
> added again in the resources list of the project summary (and in the 
> resources tab too). It happens even when you don't edit anything.
> It doesn't seem like a wanted behaviour but I'm new to Ofbiz so, I may be 
> wrong.
> Tell me if you need more information,
> Thanks.
> Florian



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-2219) Special issue to allow submitting patches for online help update

2016-04-07 Thread Hans Bakker (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hans Bakker updated OFBIZ-2219:
---
Assignee: (was: Hans Bakker)

> Special issue to allow submitting patches for online help update
> 
>
> Key: OFBIZ-2219
> URL: https://issues.apache.org/jira/browse/OFBIZ-2219
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Attachments: HelpAccounting.jpg, 
> OFBIZ-2219_DocbookAccountingHelp10.patch, build.xml
>
>
> *This issue should not be closed, at least until the online help is 
> completed...*
> in OFBIZ-2133, Bruno Busco has used Sharan's work in wiki as an help from 
> OFBiz OOTB. You can find links in AccountingHelpUrls.xml. I have asked Sharan 
> if she could update this links, while she is improving documentation, and she 
> agreed. So this issue is to allow her, and anybody else, to submit patches to 
> improve the online help (not only accounting of course hence the ALL 
> COMPONENTS)
> We commit only the [ones 
> completed|https://issues.apache.org/jira/browse/OFBIZ-4175?focusedCommentId=12993718&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12993718]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-6989) Editing project in Project Manager duplicates resources

2016-04-07 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit reassigned OFBIZ-6989:
---

Assignee: Deepak Dixit

> Editing project in Project Manager duplicates resources
> ---
>
> Key: OFBIZ-6989
> URL: https://issues.apache.org/jira/browse/OFBIZ-6989
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/projectmgr
>Affects Versions: Release Branch 15.12
>Reporter: Montalbano Florian
>Assignee: Deepak Dixit
>Priority: Minor
>  Labels: duplicate, projectmgr, resources
>
> In the Ofbiz 15.12 release (i didn't test it on the other version), when 
> selecting a project from the list and trying to edit it, clicking on the save 
> button cause the Client Billing Party Id and the Organization Party Id to be 
> added again in the resources list of the project summary (and in the 
> resources tab too). It happens even when you don't edit anything.
> It doesn't seem like a wanted behaviour but I'm new to Ofbiz so, I may be 
> wrong.
> Tell me if you need more information,
> Thanks.
> Florian



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-4502) Improved CMS tree: more functionality and faster for large trees

2016-04-07 Thread Hans Bakker (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hans Bakker updated OFBIZ-4502:
---
Assignee: (was: Hans Bakker)

> Improved CMS tree: more functionality and faster for large trees
> 
>
> Key: OFBIZ-4502
> URL: https://issues.apache.org/jira/browse/OFBIZ-4502
> Project: OFBiz
>  Issue Type: Improvement
>  Components: content
>Affects Versions: Trunk
>Reporter: Martin Kreidenweis
> Attachments: CMS-Tree-Improvement-2.patch, CMS-Tree-Improvement.patch
>
>
> We here at [Lusini|http://www.lusini.de/] did several improvements to the CMS 
> backend to make it more useable for large CMS installations. 
> * Improved performance of CMS tree
> ** loading nodes dynamically using AJAX
> *** Created ContentJsonEvents to handle the JSON calls
> ** use OFBiz entity caches
> ** removed duplicate execution of WebSitePublishPoint.groovy
> *** removed reference from controller.xml as it is not used anywhere
> * Moving nodes in CMS tree possible now using drag'n'drop
> ** ContentJsonEvents returns updated node attributes
> ** Adjusted WebSiteCMSNav.ftl to update the moved node with the data from the 
> ajax request
> ** Needed to replace the jstree jQuery plugin by the current version 
> available on the jstree website
> * Made nodes deleteable
> ** added remove to context menu
> ** We did not want to delete the WebSitePathAlias entities right away, so we 
> added a fromDate and thruDate to it. 
> *** extended WebSitePathAlias entity definition: added fromDate and thruDate
> *** now checking for date range everywhere when accessing path aliases
> *** This also allows users to publish or unpublish contents under a certain 
> URL automatically at some time in the future. 
> ** created event to "delete" a node
> *** thruDate of all assocs pointing to this node are set to current timestamp
> *** thruDate of WebSitePathAliases pointing to this content or any contents 
> below are set to current timestamp
> *** this way nothing is actually removed from the DB and a "undo" would be 
> possible if necessary
> ** extracted context menu to variable so it can be reused for all trees
> * fixed missing references to uiLabels in CMS menu bar
> * Activated cookie plugin so the selected node is remembered
> To migrate existing path aliases the following SQL statements can be used:
> BEGIN;
> UPDATE web_site_path_alias SET from_date=w.created_stamp FROM 
> web_site_path_alias w WHERE w.path_alias=web_site_path_alias.path_alias;
> ALTER TABLE web_site_path_alias
> DROP CONSTRAINT pk_web_site_path_alias,
> ADD CONSTRAINT pk_web_site_path_alias PRIMARY KEY (web_site_id, 
> path_alias, from_date);
> COMMIT;



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-2531) Enhancements in Trainings under HR module

2016-04-07 Thread Hans Bakker (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-2531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hans Bakker updated OFBIZ-2531:
---
Assignee: (was: Hans Bakker)

> Enhancements in Trainings under HR module
> -
>
> Key: OFBIZ-2531
> URL: https://issues.apache.org/jira/browse/OFBIZ-2531
> Project: OFBiz
>  Issue Type: Improvement
>  Components: humanres
>Affects Versions: Trunk
> Environment: Windows XP
>Reporter: Simranjeet Singh
>Priority: Minor
> Attachments: ASF.LICENSE.NOT.GRANTED--Trng Write Up.txt, 
> HR_Training_improvements.patch, HR_Trainings.patch, HR_Trainings.patch, 
> HR_Trainings.patch
>
>
> Hi users,
> We are working on enhancement of "Trainings" under HR module. We have 
> modified the existing Trainings tab by adding a Training calendar to it. We 
> have planned to integrate following functionalities by doing some 
> modifications and enhancements under HR module
> *In GlobalHRSettings tab*
> 1. Added "Training Types" tab where admin can add/delete/update the types of 
> trainings available in an organization.
> 2. Implemented the functionality of "Training Calendar" where training 
> schedules are maintained. All the trainings are listed with their names, 
> from/thru date and target audience. Admin can create/update/delete any 
> calendar entry.
> *In Trainings tab*
> 1. Added "Trainings" sub-tab where employee can apply for available 
> trainings. Approver/Admin can assign any training from training calendar to 
> the employee.
> 2. Added "Trainings Status" tab where employee/approver can check their 
> training request status. Approver/Admin can approve/reject requested trainings
> We would like to upload the implemented trainings patch ASAP. Before 
> uploading patch we would like to discuss our approach with community members.
> Any comments/suggestions on this would be appreciated.
> Regards
> Simranjeet Singh
> iLabs, L & T Infotech Ltd.
> Mumbai.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6987) Exception in Form Widget Examples

2016-04-07 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15231693#comment-15231693
 ] 

Deepak Dixit commented on OFBIZ-6987:
-

Yes Jacques you are right, Its due to ModelUtil.isPotentialLocalizedField and 
EntityUtil.localizedOrderBy methods introduced in OFBIZ-3311. These method 
validate the orderByField with entity fields, as we use dash (-) or ASC/DESC 
keyword in orderBy field to sort result in specific order.

> Exception in Form Widget Examples
> -
>
> Key: OFBIZ-6987
> URL: https://issues.apache.org/jira/browse/OFBIZ-6987
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/example
>Affects Versions: Trunk
>Reporter: james yong
>Assignee: Pranay Pandey
>Priority: Minor
>
> I am running SVN version 1737587.
> Problem
> ===
> I navigate to https://localhost:8443/example/control/FormWidgetExamples, and 
> found the following error on the page:
> {code}
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://example/widget/example/FormWidgetExampleScreens.xml#FormWidgetExamples]:
>  org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://example/widget/example/CommonScreens.xml#main-decorator]: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://common/widget/CommonScreens.xml#GlobalDecorator]: 
> java.lang.RuntimeException: Error rendering included form named 
> [DropDownFieldsExampleForm] at location 
> [component://example/widget/example/FormWidgetExampleForms.xml]: 
> java.lang.IllegalArgumentException: The field name (or key) [-description] is 
> not valid for entity [ExampleType].java.lang.IllegalArgumentException: The 
> field name (or key) [-description] is not valid for entity [ExampleType]. 
> (Error rendering included form named [DropDownFieldsExampleForm] at location 
> [component://example/widget/example/FormWidgetExampleForms.xml]: 
> java.lang.IllegalArgumentException: The field name (or key) [-description] is 
> not valid for entity [ExampleType].java.lang.IllegalArgumentException: The 
> field name (or key) [-description] is not valid for entity [ExampleType].) 
> (Error rendering screen 
> [component://common/widget/CommonScreens.xml#GlobalDecorator]: 
> java.lang.RuntimeException: Error rendering included form named 
> [DropDownFieldsExampleForm] at location 
> [component://example/widget/example/FormWidgetExampleForms.xml]: 
> java.lang.IllegalArgumentException: The field name (or key) [-description] is 
> not valid for entity [ExampleType].java.lang.IllegalArgumentException: The 
> field name (or key) [-description] is not valid for entity [ExampleType]. 
> (Error rendering included form named [DropDownFieldsExampleForm] at location 
> [component://example/widget/example/FormWidgetExampleForms.xml]: 
> java.lang.IllegalArgumentException: The field name (or key) [-description] is 
> not valid for entity [ExampleType].java.lang.IllegalArgumentException: The 
> field name (or key) [-description] is not valid for entity [ExampleType].)) 
> (Error rendering screen 
> [component://example/widget/example/CommonScreens.xml#main-decorator]: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://common/widget/CommonScreens.xml#GlobalDecorator]: 
> java.lang.RuntimeException: Error rendering included form named 
> [DropDownFieldsExampleForm] at location 
> [component://example/widget/example/FormWidgetExampleForms.xml]: 
> java.lang.IllegalArgumentException: The field name (or key) [-description] is 
> not valid for entity [ExampleType].java.lang.IllegalArgumentException: The 
> field name (or key) [-description] is not valid for entity [ExampleType]. 
> (Error rendering included form named [DropDownFieldsExampleForm] at location 
> [component://example/widget/example/FormWidgetExampleForms.xml]: 
> java.lang.IllegalArgumentException: The field name (or key) [-description] is 
> not valid for entity [ExampleType].java.lang.IllegalArgumentException: The 
> field name (or key) [-description] is not valid for entity [ExampleType].) 
> (Error rendering screen 
> [component://common/widget/CommonScreens.xml#GlobalDecorator]: 
> java.lang.RuntimeException: Error rendering included form named 
> [DropDownFieldsExampleForm] at location 
> [component://example/widget/example/FormWidgetExampleForms.xml]: 
> java.lang.IllegalArgumentException: The field name (or key) [-description] is 
> not valid for entity [ExampleType].java.lang.IllegalArgumentException: The 
> field name (or key) [-description] is not valid for entity [ExampleType]. 
> (Error rendering included form named [DropDownFieldsExampleForm] at location 
> [component://example/widget/example/FormWidgetExampleForms.xml]: 
> java.lang.I

[jira] [Commented] (OFBIZ-6993) Cannot find the declaration of element 'web-app' in version 3.0 files.

2016-04-07 Thread Forrest Rae (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15231671#comment-15231671
 ] 

Forrest Rae commented on OFBIZ-6993:


Deekpak, I read that in the other thread and it really doesn't have anything to 
do with this bug.

If you review the error I pasted above, the issue is that the SAXParser is 
having trouble parsing these web.xml files because it can't validate them, so 
complains that it doesn't know what  is.  It's likely that the fix is 
simply to download http://java.sun.com/xml/ns/javaee/web-app_3_0.xsd and put it 
in the right spot in the framework so that the parser picks it up.

> Cannot find the declaration of element 'web-app' in version 3.0 files.
> --
>
> Key: OFBIZ-6993
> URL: https://issues.apache.org/jira/browse/OFBIZ-6993
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk, Release Branch 15.12
> Environment: Been seeing the error below in the logs.  Strangely, 
> I've not been able to catch the exception in a debugger, but was able to 
> isolate it to the definition of the web-app with version 3.0.  The error 
> disapears when you change the definition from 
> {code:xml}
> 
> {code}
> to this:
> {code:xml}
>   xmlns="http://java.sun.com/xml/ns/javaee";
>  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>  xsi:schemaLocation="http://java.sun.com/xml/ns/javaee 
> http://java.sun.com/xml/ns/javaee/web-app_3_0.xsd";>
> {code}
> I only tested on 15.12 and Trunk, but it probably affects any release running 
> Tomcat 7.0.48 or higher.  Here is the error:
> {noformat}
>  [java] Apr 07, 2016 4:06:29 PM org.apache.tomcat.util.digester.Digester 
> error
>  [java] SEVERE: Parse Error at line 22 column 24: cvc-elt.1.a: Cannot 
> find the declaration of element 'web-app'.
>  [java] org.xml.sax.SAXParseException; lineNumber: 22; columnNumber: 24; 
> cvc-elt.1.a: Cannot find the declaration of element 'web-app'.
>  [java]   at 
> org.apache.xerces.util.ErrorHandlerWrapper.createSAXParseException(Unknown 
> Source)
>  [java]   at org.apache.xerces.util.ErrorHandlerWrapper.error(Unknown 
> Source)
>  [java]   at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown 
> Source)
>  [java]   at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown 
> Source)
>  [java]   at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown 
> Source)
>  [java]   at 
> org.apache.xerces.impl.xs.XMLSchemaValidator.handleStartElement(Unknown 
> Source)
>  [java]   at 
> org.apache.xerces.impl.xs.XMLSchemaValidator.startElement(Unknown Source)
>  [java]   at 
> org.apache.xerces.impl.XMLNSDocumentScannerImpl.scanStartElementAfterName(Unknown
>  Source)
>  [java]   at 
> org.apache.xerces.impl.XMLNSDocumentScannerImpl$NSContentDispatcher.scanRootElementHook(Unknown
>  Source)
>  [java]   at 
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown
>  Source)
>  [java]   at 
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown 
> Source)
>  [java]   at org.apache.xerces.parsers.XML11Configuration.parse(Unknown 
> Source)
>  [java]   at org.apache.xerces.parsers.XML11Configuration.parse(Unknown 
> Source)
>  [java]   at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
>  [java]   at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown 
> Source)
>  [java]   at 
> org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser.parse(Unknown Source)
>  [java]   at 
> org.apache.tomcat.util.digester.Digester.parse(Digester.java:1555)
>  [java]   at 
> org.ofbiz.webapp.WebAppUtil.parseWebXmlFile(WebAppUtil.java:160)
>  [java]   at org.ofbiz.webapp.WebAppUtil.getWebXml(WebAppUtil.java:131)
>  [java]   at 
> org.ofbiz.webapp.WebAppUtil.getControlServletPath(WebAppUtil.java:67)
>  [java]   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>  [java]   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>  [java]   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  [java]   at java.lang.reflect.Method.invoke(Method.java:498)
>  [java]   at 
> freemarker.ext.beans.BeansWrapper.invokeMethod(BeansWrapper.java:1458)
>  [java]   at 
> freemarker.ext.beans.SimpleMethodModel.exec(SimpleMethodModel.java:71)
>  [java]   at freemarker.core.MethodCall._eval(MethodCall.java:62)
>  [java]   at freemarker.core.Expression.eval(Expression.java:78)
>  [java]   at freemarker.core.Assignment.accept(Assignment.java:70)
>  [java]   at freemarker.core.Environment.visit(Environment.java:312)
>  [java]   at freemarker.core.Mi

Re: Release Branch Demo URLs

2016-04-07 Thread Pranay Pandey
Sounds good, thanks Jacques.

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Thu, Apr 7, 2016 at 11:04 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Yes indeed!
>
> Also we will soon change stable to use R14 and old to be R13...
>
> Jacques
>
> Le 07/04/2016 16:55, Pranay Pandey a écrit :
>
>> Shouldn't we open these four URLs in new tab with target="_BLANK".
>>
>> - 13.07 Release Branch Demo (stable)
>>
>> - Front-End Store
>> 
>> - Management Apps
>> <
>> http://demo-stable-ofbiz.apache.org/catalog/control/main?USERNAME=admin&PASSWORD=ofbiz&JavaScriptEnabled=Y
>> >
>>
>> - 12.04 Release Branch Demo (old)
>>
>> - Front-End Store
>> 
>> - Management Apps
>> <
>> http://demo-old-ofbiz.apache.org/catalog/control/main?USERNAME=admin&PASSWORD=ofbiz&JavaScriptEnabled=Y
>> >
>>
>>
>> Best regards,
>>
>> Pranay Pandey
>> HotWax Systems
>> http://www.hotwaxsystems.com/
>>
>>


[jira] [Commented] (OFBIZ-6993) Cannot find the declaration of element 'web-app' in version 3.0 files.

2016-04-07 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15231653#comment-15231653
 ] 

Deepak Dixit commented on OFBIZ-6993:
-

[Deployment Descriptor | 
http://download.oracle.com/otn-pub/jcp/servlet-3.0-fr-oth-JSpec/servlet-3_0-final-spec.pdf]

{code}
The web-app element is the root deployment descriptor for a Web application. 
This element has a required attribute version to specify to which version of 
the schema the deployment descriptor conforms. All sub elements under this 
element can be in an arbitrary order.
{code}

> Cannot find the declaration of element 'web-app' in version 3.0 files.
> --
>
> Key: OFBIZ-6993
> URL: https://issues.apache.org/jira/browse/OFBIZ-6993
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk, Release Branch 15.12
> Environment: Been seeing the error below in the logs.  Strangely, 
> I've not been able to catch the exception in a debugger, but was able to 
> isolate it to the definition of the web-app with version 3.0.  The error 
> disapears when you change the definition from 
> {code:xml}
> 
> {code}
> to this:
> {code:xml}
>   xmlns="http://java.sun.com/xml/ns/javaee";
>  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>  xsi:schemaLocation="http://java.sun.com/xml/ns/javaee 
> http://java.sun.com/xml/ns/javaee/web-app_3_0.xsd";>
> {code}
> I only tested on 15.12 and Trunk, but it probably affects any release running 
> Tomcat 7.0.48 or higher.  Here is the error:
> {noformat}
>  [java] Apr 07, 2016 4:06:29 PM org.apache.tomcat.util.digester.Digester 
> error
>  [java] SEVERE: Parse Error at line 22 column 24: cvc-elt.1.a: Cannot 
> find the declaration of element 'web-app'.
>  [java] org.xml.sax.SAXParseException; lineNumber: 22; columnNumber: 24; 
> cvc-elt.1.a: Cannot find the declaration of element 'web-app'.
>  [java]   at 
> org.apache.xerces.util.ErrorHandlerWrapper.createSAXParseException(Unknown 
> Source)
>  [java]   at org.apache.xerces.util.ErrorHandlerWrapper.error(Unknown 
> Source)
>  [java]   at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown 
> Source)
>  [java]   at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown 
> Source)
>  [java]   at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown 
> Source)
>  [java]   at 
> org.apache.xerces.impl.xs.XMLSchemaValidator.handleStartElement(Unknown 
> Source)
>  [java]   at 
> org.apache.xerces.impl.xs.XMLSchemaValidator.startElement(Unknown Source)
>  [java]   at 
> org.apache.xerces.impl.XMLNSDocumentScannerImpl.scanStartElementAfterName(Unknown
>  Source)
>  [java]   at 
> org.apache.xerces.impl.XMLNSDocumentScannerImpl$NSContentDispatcher.scanRootElementHook(Unknown
>  Source)
>  [java]   at 
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown
>  Source)
>  [java]   at 
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown 
> Source)
>  [java]   at org.apache.xerces.parsers.XML11Configuration.parse(Unknown 
> Source)
>  [java]   at org.apache.xerces.parsers.XML11Configuration.parse(Unknown 
> Source)
>  [java]   at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
>  [java]   at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown 
> Source)
>  [java]   at 
> org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser.parse(Unknown Source)
>  [java]   at 
> org.apache.tomcat.util.digester.Digester.parse(Digester.java:1555)
>  [java]   at 
> org.ofbiz.webapp.WebAppUtil.parseWebXmlFile(WebAppUtil.java:160)
>  [java]   at org.ofbiz.webapp.WebAppUtil.getWebXml(WebAppUtil.java:131)
>  [java]   at 
> org.ofbiz.webapp.WebAppUtil.getControlServletPath(WebAppUtil.java:67)
>  [java]   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>  [java]   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>  [java]   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  [java]   at java.lang.reflect.Method.invoke(Method.java:498)
>  [java]   at 
> freemarker.ext.beans.BeansWrapper.invokeMethod(BeansWrapper.java:1458)
>  [java]   at 
> freemarker.ext.beans.SimpleMethodModel.exec(SimpleMethodModel.java:71)
>  [java]   at freemarker.core.MethodCall._eval(MethodCall.java:62)
>  [java]   at freemarker.core.Expression.eval(Expression.java:78)
>  [java]   at freemarker.core.Assignment.accept(Assignment.java:70)
>  [java]   at freemarker.core.Environment.visit(Environment.java:312)
>  [java]   at freemarker.core.MixedContent.accept(MixedContent.java:62)
>  [java]   at 
> freemar

[jira] [Commented] (OFBIZ-6993) Cannot find the declaration of element 'web-app' in version 3.0 files.

2016-04-07 Thread Forrest Rae (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15231644#comment-15231644
 ] 

Forrest Rae commented on OFBIZ-6993:


Okay, no, this doesn't doesn't duplicate OFBIZ-6807, it's actually introduced 
by OFBIZ-6807.

Repo:

ant start-debug (watch console)
Visit webtools in browser: /webtools/control/main
See error message.

> Cannot find the declaration of element 'web-app' in version 3.0 files.
> --
>
> Key: OFBIZ-6993
> URL: https://issues.apache.org/jira/browse/OFBIZ-6993
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk, Release Branch 15.12
> Environment: Been seeing the error below in the logs.  Strangely, 
> I've not been able to catch the exception in a debugger, but was able to 
> isolate it to the definition of the web-app with version 3.0.  The error 
> disapears when you change the definition from 
> {code:xml}
> 
> {code}
> to this:
> {code:xml}
>   xmlns="http://java.sun.com/xml/ns/javaee";
>  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>  xsi:schemaLocation="http://java.sun.com/xml/ns/javaee 
> http://java.sun.com/xml/ns/javaee/web-app_3_0.xsd";>
> {code}
> I only tested on 15.12 and Trunk, but it probably affects any release running 
> Tomcat 7.0.48 or higher.  Here is the error:
> {noformat}
>  [java] Apr 07, 2016 4:06:29 PM org.apache.tomcat.util.digester.Digester 
> error
>  [java] SEVERE: Parse Error at line 22 column 24: cvc-elt.1.a: Cannot 
> find the declaration of element 'web-app'.
>  [java] org.xml.sax.SAXParseException; lineNumber: 22; columnNumber: 24; 
> cvc-elt.1.a: Cannot find the declaration of element 'web-app'.
>  [java]   at 
> org.apache.xerces.util.ErrorHandlerWrapper.createSAXParseException(Unknown 
> Source)
>  [java]   at org.apache.xerces.util.ErrorHandlerWrapper.error(Unknown 
> Source)
>  [java]   at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown 
> Source)
>  [java]   at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown 
> Source)
>  [java]   at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown 
> Source)
>  [java]   at 
> org.apache.xerces.impl.xs.XMLSchemaValidator.handleStartElement(Unknown 
> Source)
>  [java]   at 
> org.apache.xerces.impl.xs.XMLSchemaValidator.startElement(Unknown Source)
>  [java]   at 
> org.apache.xerces.impl.XMLNSDocumentScannerImpl.scanStartElementAfterName(Unknown
>  Source)
>  [java]   at 
> org.apache.xerces.impl.XMLNSDocumentScannerImpl$NSContentDispatcher.scanRootElementHook(Unknown
>  Source)
>  [java]   at 
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown
>  Source)
>  [java]   at 
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown 
> Source)
>  [java]   at org.apache.xerces.parsers.XML11Configuration.parse(Unknown 
> Source)
>  [java]   at org.apache.xerces.parsers.XML11Configuration.parse(Unknown 
> Source)
>  [java]   at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
>  [java]   at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown 
> Source)
>  [java]   at 
> org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser.parse(Unknown Source)
>  [java]   at 
> org.apache.tomcat.util.digester.Digester.parse(Digester.java:1555)
>  [java]   at 
> org.ofbiz.webapp.WebAppUtil.parseWebXmlFile(WebAppUtil.java:160)
>  [java]   at org.ofbiz.webapp.WebAppUtil.getWebXml(WebAppUtil.java:131)
>  [java]   at 
> org.ofbiz.webapp.WebAppUtil.getControlServletPath(WebAppUtil.java:67)
>  [java]   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>  [java]   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>  [java]   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  [java]   at java.lang.reflect.Method.invoke(Method.java:498)
>  [java]   at 
> freemarker.ext.beans.BeansWrapper.invokeMethod(BeansWrapper.java:1458)
>  [java]   at 
> freemarker.ext.beans.SimpleMethodModel.exec(SimpleMethodModel.java:71)
>  [java]   at freemarker.core.MethodCall._eval(MethodCall.java:62)
>  [java]   at freemarker.core.Expression.eval(Expression.java:78)
>  [java]   at freemarker.core.Assignment.accept(Assignment.java:70)
>  [java]   at freemarker.core.Environment.visit(Environment.java:312)
>  [java]   at freemarker.core.MixedContent.accept(MixedContent.java:62)
>  [java]   at 
> freemarker.core.Environment.visitByHiddingParent(Environment.java:333)
>  [java]   at 
> freemarker.core.IteratorBlock$Context.runLoop(IteratorBlock.java:148)
>  [java]   at 
> freemarker.core.Environm

[jira] [Issue Comment Deleted] (OFBIZ-6989) Editing project in Project Manager duplicates resources

2016-04-07 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-6989:

Comment: was deleted

(was: Please ask question on user mailing list mailto:u...@ofbiz.apache.org)

> Editing project in Project Manager duplicates resources
> ---
>
> Key: OFBIZ-6989
> URL: https://issues.apache.org/jira/browse/OFBIZ-6989
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/projectmgr
>Affects Versions: Release Branch 15.12
>Reporter: Montalbano Florian
>Priority: Minor
>  Labels: duplicate, projectmgr, resources
>
> In the Ofbiz 15.12 release (i didn't test it on the other version), when 
> selecting a project from the list and trying to edit it, clicking on the save 
> button cause the Client Billing Party Id and the Organization Party Id to be 
> added again in the resources list of the project summary (and in the 
> resources tab too). It happens even when you don't edit anything.
> It doesn't seem like a wanted behaviour but I'm new to Ofbiz so, I may be 
> wrong.
> Tell me if you need more information,
> Thanks.
> Florian



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6989) Editing project in Project Manager duplicates resources

2016-04-07 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15231639#comment-15231639
 ] 

Deepak Dixit commented on OFBIZ-6989:
-

Please ask question on user mailing list mailto:u...@ofbiz.apache.org

> Editing project in Project Manager duplicates resources
> ---
>
> Key: OFBIZ-6989
> URL: https://issues.apache.org/jira/browse/OFBIZ-6989
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/projectmgr
>Affects Versions: Release Branch 15.12
>Reporter: Montalbano Florian
>Priority: Minor
>  Labels: duplicate, projectmgr, resources
>
> In the Ofbiz 15.12 release (i didn't test it on the other version), when 
> selecting a project from the list and trying to edit it, clicking on the save 
> button cause the Client Billing Party Id and the Organization Party Id to be 
> added again in the resources list of the project summary (and in the 
> resources tab too). It happens even when you don't edit anything.
> It doesn't seem like a wanted behaviour but I'm new to Ofbiz so, I may be 
> wrong.
> Tell me if you need more information,
> Thanks.
> Florian



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-5935) Sales tax adjustments manually added to purchase orders cause creation of another adjustment undoing the first

2016-04-07 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15231623#comment-15231623
 ] 

Jacques Le Roux commented on OFBIZ-5935:


Thinking about it, does *sales* tax simply make sense when purchasing? 
If I compare to VAT system (we have not sales taxes in France) it does not!

> Sales tax adjustments manually added to purchase orders cause creation of 
> another adjustment undoing the first
> --
>
> Key: OFBIZ-5935
> URL: https://issues.apache.org/jira/browse/OFBIZ-5935
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Christian Carlow
>Priority: Minor
> Attachments: Image 094.png
>
>
> For example, if a sales tax adjustment of 0.20 is manually added to a 
> purchase order, another  adjustment will be created for -0.20.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6944) streamDataResource do not manage OTHER_OBJECT dataResourceTypeId

2016-04-07 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15231619#comment-15231619
 ] 

Jacques Le Roux commented on OFBIZ-6944:


Hi Gil,

I did not review yet, but to help it: what doubts or kind of doubts did you 
have?

> streamDataResource do not manage OTHER_OBJECT dataResourceTypeId
> 
>
> Key: OFBIZ-6944
> URL: https://issues.apache.org/jira/browse/OFBIZ-6944
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Trunk
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
> Attachments: OFBIZ-6944.patch
>
>
> When using request ViewBinaryDataResource?dataResourceId=10015 with a 
> OTHER_OBJECT dataResourceTypeId, we meet the error : 
> {quote}org.ofbiz.webapp.view.ViewHandlerException: The dataResourceTypeId 
> [OTHER_OBJECT] is not supported in streamDataResource{quote}
> This is relative to an existing TODO in DataResourceWorker.java :
> {code}// TODO: remove this method in favor of getDataResourceStream {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6945) Worker class and worker methods for facility component

2016-04-07 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15231617#comment-15231617
 ] 

Jacques Le Roux commented on OFBIZ-6945:


Why not creating services rather than Worker class and worker methods?

> Worker class and worker methods for facility component
> --
>
> Key: OFBIZ-6945
> URL: https://issues.apache.org/jira/browse/OFBIZ-6945
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Mohammad Kathawala
>Priority: Minor
>
> There isn't any worker class containing worker methods for facility component 
> in OFBIZ.
>  Various generic worker methods can be implemented like:
> - 'differenceInShipCost' which will calculate the difference in estimated 
> shipping cost (quoted during checkout process) and actual shipping cost 
> (received when packing is complete and we have actual package weight) of any 
> shipment.
> - 'isPicklistPacked' which will determine whether any picklist is packed or 
> not.
> - 'getShipmentBoxTypes' for getting all the box types available for 
> particular shipment method of a particular carrier party.
> And there can be many more.
> The worker class for facility will have all such kinds of worker methods.  
> I propose to add this class and I can contribute some initial worker methods 
> . I can also use these methods at applicable places. If community members 
> agree then, I will start implementing these methods .  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-6993) Cannot find the declaration of element 'web-app' in version 3.0 files.

2016-04-07 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-6993.
--
Resolution: Duplicate

Sorry we had that already, see the duplicated issue

> Cannot find the declaration of element 'web-app' in version 3.0 files.
> --
>
> Key: OFBIZ-6993
> URL: https://issues.apache.org/jira/browse/OFBIZ-6993
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk, Release Branch 15.12
> Environment: Been seeing the error below in the logs.  Strangely, 
> I've not been able to catch the exception in a debugger, but was able to 
> isolate it to the definition of the web-app with version 3.0.  The error 
> disapears when you change the definition from 
> {code:xml}
> 
> {code}
> to this:
> {code:xml}
>   xmlns="http://java.sun.com/xml/ns/javaee";
>  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>  xsi:schemaLocation="http://java.sun.com/xml/ns/javaee 
> http://java.sun.com/xml/ns/javaee/web-app_3_0.xsd";>
> {code}
> I only tested on 15.12 and Trunk, but it probably affects any release running 
> Tomcat 7.0.48 or higher.  Here is the error:
> {noformat}
>  [java] Apr 07, 2016 4:06:29 PM org.apache.tomcat.util.digester.Digester 
> error
>  [java] SEVERE: Parse Error at line 22 column 24: cvc-elt.1.a: Cannot 
> find the declaration of element 'web-app'.
>  [java] org.xml.sax.SAXParseException; lineNumber: 22; columnNumber: 24; 
> cvc-elt.1.a: Cannot find the declaration of element 'web-app'.
>  [java]   at 
> org.apache.xerces.util.ErrorHandlerWrapper.createSAXParseException(Unknown 
> Source)
>  [java]   at org.apache.xerces.util.ErrorHandlerWrapper.error(Unknown 
> Source)
>  [java]   at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown 
> Source)
>  [java]   at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown 
> Source)
>  [java]   at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown 
> Source)
>  [java]   at 
> org.apache.xerces.impl.xs.XMLSchemaValidator.handleStartElement(Unknown 
> Source)
>  [java]   at 
> org.apache.xerces.impl.xs.XMLSchemaValidator.startElement(Unknown Source)
>  [java]   at 
> org.apache.xerces.impl.XMLNSDocumentScannerImpl.scanStartElementAfterName(Unknown
>  Source)
>  [java]   at 
> org.apache.xerces.impl.XMLNSDocumentScannerImpl$NSContentDispatcher.scanRootElementHook(Unknown
>  Source)
>  [java]   at 
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown
>  Source)
>  [java]   at 
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown 
> Source)
>  [java]   at org.apache.xerces.parsers.XML11Configuration.parse(Unknown 
> Source)
>  [java]   at org.apache.xerces.parsers.XML11Configuration.parse(Unknown 
> Source)
>  [java]   at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
>  [java]   at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown 
> Source)
>  [java]   at 
> org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser.parse(Unknown Source)
>  [java]   at 
> org.apache.tomcat.util.digester.Digester.parse(Digester.java:1555)
>  [java]   at 
> org.ofbiz.webapp.WebAppUtil.parseWebXmlFile(WebAppUtil.java:160)
>  [java]   at org.ofbiz.webapp.WebAppUtil.getWebXml(WebAppUtil.java:131)
>  [java]   at 
> org.ofbiz.webapp.WebAppUtil.getControlServletPath(WebAppUtil.java:67)
>  [java]   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>  [java]   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>  [java]   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  [java]   at java.lang.reflect.Method.invoke(Method.java:498)
>  [java]   at 
> freemarker.ext.beans.BeansWrapper.invokeMethod(BeansWrapper.java:1458)
>  [java]   at 
> freemarker.ext.beans.SimpleMethodModel.exec(SimpleMethodModel.java:71)
>  [java]   at freemarker.core.MethodCall._eval(MethodCall.java:62)
>  [java]   at freemarker.core.Expression.eval(Expression.java:78)
>  [java]   at freemarker.core.Assignment.accept(Assignment.java:70)
>  [java]   at freemarker.core.Environment.visit(Environment.java:312)
>  [java]   at freemarker.core.MixedContent.accept(MixedContent.java:62)
>  [java]   at 
> freemarker.core.Environment.visitByHiddingParent(Environment.java:333)
>  [java]   at 
> freemarker.core.IteratorBlock$Context.runLoop(IteratorBlock.java:148)
>  [java]   at 
> freemarker.core.Environment.visitIteratorBlock(Environment.java:559)
>  [java]   at freemarker.core.IteratorBlock.accept(IteratorBlock.java:67)
>  [java]   at freemarker.core.Environment.visit

[jira] [Created] (OFBIZ-6994) Multiple logins required when using help screen before navigating to another application

2016-04-07 Thread james yong (JIRA)
james yong created OFBIZ-6994:
-

 Summary: Multiple logins required when using help screen before 
navigating to another application
 Key: OFBIZ-6994
 URL: https://issues.apache.org/jira/browse/OFBIZ-6994
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: Trunk
Reporter: james yong
Priority: Minor


Problem
===

1) Go to https://localhost:8443/catalog/ and a login screen appears requiring 
login credentials. 
 
2) Click on the help button on the top right.

3) Navigate to another application, and the login screen appears again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6963) Single sign-on to OFBiz with CAS

2016-04-07 Thread james yong (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15231478#comment-15231478
 ] 

james yong commented on OFBIZ-6963:
---

Just to mention that CAS SSO is also an  Apache Licensed software

> Single sign-on to OFBiz with CAS
> 
>
> Key: OFBIZ-6963
> URL: https://issues.apache.org/jira/browse/OFBIZ-6963
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: james yong
>
> OFBiz is made up of several web applications. 
> To allow the user to sign in only once, a unique token value is presented for 
> verification each time the user navigates to an unvisited web application.
> This approach has the following limitations:
> 1) You cannot work with multiple windows, as there is only 1 valid token 
> value at any time and other token values will be invalid in older-opened 
> windows.
> 2) There is a need to refresh the whole page, so that all links will contain 
> the valid token value.
> 3) Not easy to compose a page that get contents from different web 
> applications in OFBiz
> Adding CAS SSO component as a core into OFBiz will remove the limitations 
> mentioned above. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6993) Cannot find the declaration of element 'web-app' in version 3.0 files.

2016-04-07 Thread Forrest Rae (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Forrest Rae updated OFBIZ-6993:
---
Attachment: web-app.patch

> Cannot find the declaration of element 'web-app' in version 3.0 files.
> --
>
> Key: OFBIZ-6993
> URL: https://issues.apache.org/jira/browse/OFBIZ-6993
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk, Release Branch 15.12
> Environment: Been seeing the error below in the logs.  Strangely, 
> I've not been able to catch the exception in a debugger, but was able to 
> isolate it to the definition of the web-app with version 3.0.  The error 
> disapears when you change the definition from 
> {code:xml}
> 
> {code}
> to this:
> {code:xml}
>   xmlns="http://java.sun.com/xml/ns/javaee";
>  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>  xsi:schemaLocation="http://java.sun.com/xml/ns/javaee 
> http://java.sun.com/xml/ns/javaee/web-app_3_0.xsd";>
> {code}
> I only tested on 15.12 and Trunk, but it probably affects any release running 
> Tomcat 7.0.48 or higher.  Here is the error:
> {noformat}
>  [java] Apr 07, 2016 4:06:29 PM org.apache.tomcat.util.digester.Digester 
> error
>  [java] SEVERE: Parse Error at line 22 column 24: cvc-elt.1.a: Cannot 
> find the declaration of element 'web-app'.
>  [java] org.xml.sax.SAXParseException; lineNumber: 22; columnNumber: 24; 
> cvc-elt.1.a: Cannot find the declaration of element 'web-app'.
>  [java]   at 
> org.apache.xerces.util.ErrorHandlerWrapper.createSAXParseException(Unknown 
> Source)
>  [java]   at org.apache.xerces.util.ErrorHandlerWrapper.error(Unknown 
> Source)
>  [java]   at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown 
> Source)
>  [java]   at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown 
> Source)
>  [java]   at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown 
> Source)
>  [java]   at 
> org.apache.xerces.impl.xs.XMLSchemaValidator.handleStartElement(Unknown 
> Source)
>  [java]   at 
> org.apache.xerces.impl.xs.XMLSchemaValidator.startElement(Unknown Source)
>  [java]   at 
> org.apache.xerces.impl.XMLNSDocumentScannerImpl.scanStartElementAfterName(Unknown
>  Source)
>  [java]   at 
> org.apache.xerces.impl.XMLNSDocumentScannerImpl$NSContentDispatcher.scanRootElementHook(Unknown
>  Source)
>  [java]   at 
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown
>  Source)
>  [java]   at 
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown 
> Source)
>  [java]   at org.apache.xerces.parsers.XML11Configuration.parse(Unknown 
> Source)
>  [java]   at org.apache.xerces.parsers.XML11Configuration.parse(Unknown 
> Source)
>  [java]   at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
>  [java]   at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown 
> Source)
>  [java]   at 
> org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser.parse(Unknown Source)
>  [java]   at 
> org.apache.tomcat.util.digester.Digester.parse(Digester.java:1555)
>  [java]   at 
> org.ofbiz.webapp.WebAppUtil.parseWebXmlFile(WebAppUtil.java:160)
>  [java]   at org.ofbiz.webapp.WebAppUtil.getWebXml(WebAppUtil.java:131)
>  [java]   at 
> org.ofbiz.webapp.WebAppUtil.getControlServletPath(WebAppUtil.java:67)
>  [java]   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>  [java]   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>  [java]   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  [java]   at java.lang.reflect.Method.invoke(Method.java:498)
>  [java]   at 
> freemarker.ext.beans.BeansWrapper.invokeMethod(BeansWrapper.java:1458)
>  [java]   at 
> freemarker.ext.beans.SimpleMethodModel.exec(SimpleMethodModel.java:71)
>  [java]   at freemarker.core.MethodCall._eval(MethodCall.java:62)
>  [java]   at freemarker.core.Expression.eval(Expression.java:78)
>  [java]   at freemarker.core.Assignment.accept(Assignment.java:70)
>  [java]   at freemarker.core.Environment.visit(Environment.java:312)
>  [java]   at freemarker.core.MixedContent.accept(MixedContent.java:62)
>  [java]   at 
> freemarker.core.Environment.visitByHiddingParent(Environment.java:333)
>  [java]   at 
> freemarker.core.IteratorBlock$Context.runLoop(IteratorBlock.java:148)
>  [java]   at 
> freemarker.core.Environment.visitIteratorBlock(Environment.java:559)
>  [java]   at freemarker.core.IteratorBlock.accept(IteratorBlock.java:67)
>  [java]   at freemarker.core.Environment.visit(Environment.java:312)
>  [java]   at freemarker.co

[jira] [Created] (OFBIZ-6993) Cannot find the declaration of element 'web-app' in version 3.0 files.

2016-04-07 Thread Forrest Rae (JIRA)
Forrest Rae created OFBIZ-6993:
--

 Summary: Cannot find the declaration of element 'web-app' in 
version 3.0 files.
 Key: OFBIZ-6993
 URL: https://issues.apache.org/jira/browse/OFBIZ-6993
 Project: OFBiz
  Issue Type: Bug
  Components: ALL COMPONENTS
Affects Versions: Release Branch 15.12, Trunk
 Environment: Been seeing the error below in the logs.  Strangely, I've 
not been able to catch the exception in a debugger, but was able to isolate it 
to the definition of the web-app with version 3.0.  The error disapears when 
you change the definition from 

{code:xml}

{code}

to this:

{code:xml}
http://java.sun.com/xml/ns/javaee";
 xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
 xsi:schemaLocation="http://java.sun.com/xml/ns/javaee 
http://java.sun.com/xml/ns/javaee/web-app_3_0.xsd";>
{code}

I only tested on 15.12 and Trunk, but it probably affects any release running 
Tomcat 7.0.48 or higher.  Here is the error:

{noformat}
 [java] Apr 07, 2016 4:06:29 PM org.apache.tomcat.util.digester.Digester 
error
 [java] SEVERE: Parse Error at line 22 column 24: cvc-elt.1.a: Cannot find 
the declaration of element 'web-app'.
 [java] org.xml.sax.SAXParseException; lineNumber: 22; columnNumber: 24; 
cvc-elt.1.a: Cannot find the declaration of element 'web-app'.
 [java] at 
org.apache.xerces.util.ErrorHandlerWrapper.createSAXParseException(Unknown 
Source)
 [java] at org.apache.xerces.util.ErrorHandlerWrapper.error(Unknown 
Source)
 [java] at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown 
Source)
 [java] at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown 
Source)
 [java] at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown 
Source)
 [java] at 
org.apache.xerces.impl.xs.XMLSchemaValidator.handleStartElement(Unknown Source)
 [java] at 
org.apache.xerces.impl.xs.XMLSchemaValidator.startElement(Unknown Source)
 [java] at 
org.apache.xerces.impl.XMLNSDocumentScannerImpl.scanStartElementAfterName(Unknown
 Source)
 [java] at 
org.apache.xerces.impl.XMLNSDocumentScannerImpl$NSContentDispatcher.scanRootElementHook(Unknown
 Source)
 [java] at 
org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown
 Source)
 [java] at 
org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown 
Source)
 [java] at org.apache.xerces.parsers.XML11Configuration.parse(Unknown 
Source)
 [java] at org.apache.xerces.parsers.XML11Configuration.parse(Unknown 
Source)
 [java] at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
 [java] at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown 
Source)
 [java] at 
org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser.parse(Unknown Source)
 [java] at 
org.apache.tomcat.util.digester.Digester.parse(Digester.java:1555)
 [java] at 
org.ofbiz.webapp.WebAppUtil.parseWebXmlFile(WebAppUtil.java:160)
 [java] at org.ofbiz.webapp.WebAppUtil.getWebXml(WebAppUtil.java:131)
 [java] at 
org.ofbiz.webapp.WebAppUtil.getControlServletPath(WebAppUtil.java:67)
 [java] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 [java] at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
 [java] at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 [java] at java.lang.reflect.Method.invoke(Method.java:498)
 [java] at 
freemarker.ext.beans.BeansWrapper.invokeMethod(BeansWrapper.java:1458)
 [java] at 
freemarker.ext.beans.SimpleMethodModel.exec(SimpleMethodModel.java:71)
 [java] at freemarker.core.MethodCall._eval(MethodCall.java:62)
 [java] at freemarker.core.Expression.eval(Expression.java:78)
 [java] at freemarker.core.Assignment.accept(Assignment.java:70)
 [java] at freemarker.core.Environment.visit(Environment.java:312)
 [java] at freemarker.core.MixedContent.accept(MixedContent.java:62)
 [java] at 
freemarker.core.Environment.visitByHiddingParent(Environment.java:333)
 [java] at 
freemarker.core.IteratorBlock$Context.runLoop(IteratorBlock.java:148)
 [java] at 
freemarker.core.Environment.visitIteratorBlock(Environment.java:559)
 [java] at freemarker.core.IteratorBlock.accept(IteratorBlock.java:67)
 [java] at freemarker.core.Environment.visit(Environment.java:312)
 [java] at freemarker.core.MixedContent.accept(MixedContent.java:62)
 [java] at 
freemarker.core.Environment.visitByHiddingParent(Environment.java:333)
 [java] at 
freemarker.core.ConditionalBlock.accept(ConditionalBlock.java:48)
 [java] at freemarker.core.Environment.visit(Environment.java:312)
 [java] at freemarker.core.Mix

[jira] [Commented] (OFBIZ-6987) Exception in Form Widget Examples

2016-04-07 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15231134#comment-15231134
 ] 

Jacques Le Roux commented on OFBIZ-6987:


It could be related with OFBIZ-3311, see the top of stack
{code}
2016-04-07 23:32:16,548 |http-bio-8443-exec-1 |ModelScreenWidget 
|E| Error rendering included form named [DropDownFieldsExampleForm] at location 
[component://example/widget/example/FormWidgetExamp
leForms.xml]: java.lang.IllegalArgumentException: The field name (or key) 
[-description] is not valid for entity [ExampleType].
java.lang.IllegalArgumentException: The field name (or key) [-description] is 
not valid for entity [ExampleType].
at org.ofbiz.entity.GenericEntity.get(GenericEntity.java:373) 
~[ofbiz-entity.jar:?]
at org.ofbiz.entity.GenericEntity.get(GenericEntity.java:788) 
~[ofbiz-entity.jar:?]
at org.ofbiz.entity.GenericEntity.get(GenericEntity.java:773) 
~[ofbiz-entity.jar:?]
at 
org.ofbiz.entity.util.EntityUtil.localizedOrderBy(EntityUtil.java:356) 
~[ofbiz-entity.jar:?]
at 
org.ofbiz.widget.model.ModelFormField$EntityOptions.addOptionValues(ModelFormField.java:1918)
 ~[ofbiz-widget.jar:?]
{code}

> Exception in Form Widget Examples
> -
>
> Key: OFBIZ-6987
> URL: https://issues.apache.org/jira/browse/OFBIZ-6987
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/example
>Affects Versions: Trunk
>Reporter: james yong
>Assignee: Pranay Pandey
>Priority: Minor
>
> I am running SVN version 1737587.
> Problem
> ===
> I navigate to https://localhost:8443/example/control/FormWidgetExamples, and 
> found the following error on the page:
> {code}
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://example/widget/example/FormWidgetExampleScreens.xml#FormWidgetExamples]:
>  org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://example/widget/example/CommonScreens.xml#main-decorator]: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://common/widget/CommonScreens.xml#GlobalDecorator]: 
> java.lang.RuntimeException: Error rendering included form named 
> [DropDownFieldsExampleForm] at location 
> [component://example/widget/example/FormWidgetExampleForms.xml]: 
> java.lang.IllegalArgumentException: The field name (or key) [-description] is 
> not valid for entity [ExampleType].java.lang.IllegalArgumentException: The 
> field name (or key) [-description] is not valid for entity [ExampleType]. 
> (Error rendering included form named [DropDownFieldsExampleForm] at location 
> [component://example/widget/example/FormWidgetExampleForms.xml]: 
> java.lang.IllegalArgumentException: The field name (or key) [-description] is 
> not valid for entity [ExampleType].java.lang.IllegalArgumentException: The 
> field name (or key) [-description] is not valid for entity [ExampleType].) 
> (Error rendering screen 
> [component://common/widget/CommonScreens.xml#GlobalDecorator]: 
> java.lang.RuntimeException: Error rendering included form named 
> [DropDownFieldsExampleForm] at location 
> [component://example/widget/example/FormWidgetExampleForms.xml]: 
> java.lang.IllegalArgumentException: The field name (or key) [-description] is 
> not valid for entity [ExampleType].java.lang.IllegalArgumentException: The 
> field name (or key) [-description] is not valid for entity [ExampleType]. 
> (Error rendering included form named [DropDownFieldsExampleForm] at location 
> [component://example/widget/example/FormWidgetExampleForms.xml]: 
> java.lang.IllegalArgumentException: The field name (or key) [-description] is 
> not valid for entity [ExampleType].java.lang.IllegalArgumentException: The 
> field name (or key) [-description] is not valid for entity [ExampleType].)) 
> (Error rendering screen 
> [component://example/widget/example/CommonScreens.xml#main-decorator]: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://common/widget/CommonScreens.xml#GlobalDecorator]: 
> java.lang.RuntimeException: Error rendering included form named 
> [DropDownFieldsExampleForm] at location 
> [component://example/widget/example/FormWidgetExampleForms.xml]: 
> java.lang.IllegalArgumentException: The field name (or key) [-description] is 
> not valid for entity [ExampleType].java.lang.IllegalArgumentException: The 
> field name (or key) [-description] is not valid for entity [ExampleType]. 
> (Error rendering included form named [DropDownFieldsExampleForm] at location 
> [component://example/widget/example/FormWidgetExampleForms.xml]: 
> java.lang.IllegalArgumentException: The field name (or key) [-description] is 
> not valid for entity [ExampleType].java.lang.IllegalArgumentExcepti

[jira] [Commented] (OFBIZ-6776) Amount to capture for order is in-correct after manual refund electronic transaction

2016-04-07 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15231120#comment-15231120
 ] 

Jacques Le Roux commented on OFBIZ-6776:


Quoting myself
{quote}
Could we not have an option in function of the reason of the refund?
{quote}
I mean either 
* the remaining total should be captured.
* the remaining total + the refunded amount should be captured.

Does it make sense in some scenarii?

> Amount to capture for order is in-correct after manual refund electronic 
> transaction
> 
>
> Key: OFBIZ-6776
> URL: https://issues.apache.org/jira/browse/OFBIZ-6776
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting, order
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk
>Reporter: Nameet
>Assignee: Pranay Pandey
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-6776.patch, OFBIZ-6776.patch
>
>
> Steps to regenerate-
> 1) Place a sales order of Rainbow Gizmo. Order Total was of $29.91. Order 
> will be in approved status and in *Payment Information* section you will see 
> $29.91 as authorized and available to capture. 
> 2) Capture $15.00 by using the capture button available in *Payment 
> Information* block. System should successfully capture $15.00 and also new 
> authorized payment of $14.91 should be seen in Payment Information section.
> 3) Refund $5.00 by using manual electronic transfer UI in accounting. System 
> successfully does the refund.
> 4) Click quick ship entire order from order screen. As per payment 
> requirement, now system should proceed to complete the capture process for 
> amount $19.91($29.91 - $15(Captured) + $5(Refunded)) but it captures only 
> $9.91 and not showing any remaining amount to capture on order. Also the 
> order invoice due shows $0.00.
> Possible reason of the issue is that refunded payment amount is being 
> considered by the system as received payment and hence amount to capture on 
> order is calculated wrong.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-5840) Create bootstrap theme

2016-04-07 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15231040#comment-15231040
 ] 

Jacques Le Roux commented on OFBIZ-5840:


Finally, has this branch a chance or should we drop it?

> Create bootstrap theme
> --
>
> Key: OFBIZ-5840
> URL: https://issues.apache.org/jira/browse/OFBIZ-5840
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework, themes
>Affects Versions: Bootstrap theme
>Reporter: Julien NICOLAS
>Assignee: Jacques Le Roux
>  Labels: bootstrap, theme
> Attachments: Facility.PNG, FindAgreement..png, Footer.jpg, 
> GlobalDecorator.patch, ImprovedFooter.patch, MacroMenuRenderer.patch, 
> OFBIZ-5840-Menufactory.patch, OFBIZ-5840-Menufactory.patch, 
> appbar_menu_ftl.patch, bootified.js, bootified_js_screentrans.patch, 
> bootstrap-theme.zip, bootstrap.zip, bootstrapThemeToTrunk.patch, 
> calendar.PNG, catalog.png, glyphicons-halflings-regular.zip, 
> htmlMenuMacroLibrary.patch, lookupField_patch.patch, 
> pagination_htmlFormMacroLibrary.patch, 
> panelCollapse_htmlSreenMacroLibrary.patch, party menu tab bar.PNG, 
> preferences.png, styling_issue_1.png, styling_issue_2.png, 
> styling_issue_3.png, styling_issue_4.png, styling_issue_5.png, 
> styling_issue_6.png, styling_issue_7.png, styling_issue_8.png, 
> styling_issue_9.png, tab-bar.png, workeffort.PNG
>
>
> 1- create a sub-directory called bootstrap under the image webapp to put
> the resources over there (js, css and fonts) as indicated earlier by Gavin.
> (Julien : not sure about location)
> 2- check to make sure that the current version of jQuery is compatible with
> the installed version or upgrade it accordingly
> 3- Create a new theme based on one of the existing themes as suggested by
> Julien and Gavin
> 4- Test the theme by switching to it and handle major bugs / issues.
> 5- Start to make a few test screens utilizing Bootstrap



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-3194) Quick look are showing pagination renderNextPrev pagination style when list size is greater than 20

2016-04-07 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-3194.
--
Resolution: Won't Fix
  Assignee: Jacques Le Roux

This has been fixed since notably by OFBIZ-5422 and OFBIZ-5478

> Quick look are showing pagination renderNextPrev pagination style when list 
> size is greater than 20
> ---
>
> Key: OFBIZ-3194
> URL: https://issues.apache.org/jira/browse/OFBIZ-3194
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Divesh Dutta
>Assignee: Jacques Le Roux
> Attachments: OFBiz-3194.patch
>
>
> Quick look are showing pagination renderNextPrev pagination style when list 
> size is greater than 20.
> In htmlFormMacroLibrary.ftl below given code snippet is hard-coded. :
>  {<#if listSize gt 20>}
> This can be changed to
>  {<#if listSize gt viewSize>}
> as viewSize is passed as parameter in macro renderNextPrev. This is also 
> reported by Matthieu Bollot in developer mailing list.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: User pref or not user pref

2016-04-07 Thread Christian Geisert
Am 07.04.2016 11:35, schrieb Julien NICOLAS:
> Hi all,
>
> We are thinking on a new theme (again) that will be more user friendly
> and UX oriented.
> We want to be able to customize menu (component and its sub menu).
>
> User pref could be the clue but we are not sure because if all menu
> and sub menu (and maybe 3rd or 4th level menu) user preference are
> recorded in the user pref, it could be a nightmare for the database
> access if there is a lot of users. And only for user preference, it's
> not a good idea.
> We also think about using cookies but it could be a problem if the
> user user several computers.
>
> What do you think ? Do you already try to develop this kind of feature ?
>

I think this must done on the server side, because, as you already
mentioned, a user will expect the same menu independet from the used
browser/computer.
Database access shouldn't be a problem with caching.

Christian


[jira] [Commented] (OFBIZ-6992) Field 'maxRetry' is typed as 'numeric' in entity 'JobSandbox'

2016-04-07 Thread Pierre Smits (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15230902#comment-15230902
 ] 

Pierre Smits commented on OFBIZ-6992:
-

The same also applies to field:
* currentRetryCount
* currentRecurrenceCount
* maxRecurrenceCount


> Field 'maxRetry' is typed as 'numeric' in entity 'JobSandbox'
> -
>
> Key: OFBIZ-6992
> URL: https://issues.apache.org/jira/browse/OFBIZ-6992
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>  Labels: datatype, fieldtype
>
> Currently the field 'maxRetry' in entity 'JobSandbox' in the entitydef of the 
> service component in the Framework stack is typed as 'numeric'.
> This should be typed in accordance with the various integer types (INT, 
> INTEGER, SMALLINT, BIGINT, LARGEINT, etc), as it doesn't make sense to 
> associate it with a type that is normally used for numbers with decimals. 
> Some connectors to DBMSes and/or the databases themselves are very picky 
> about this. As I have experienced when trying to have OFBiz persist on HBase.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6992) Field 'maxRetry' is typed as 'numeric' in entity 'JobSandbox'

2016-04-07 Thread Pierre Smits (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15230784#comment-15230784
 ] 

Pierre Smits commented on OFBIZ-6992:
-

Changing this to the SMALLINT variant (-32768 to +32767) should do the trick.

> Field 'maxRetry' is typed as 'numeric' in entity 'JobSandbox'
> -
>
> Key: OFBIZ-6992
> URL: https://issues.apache.org/jira/browse/OFBIZ-6992
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>  Labels: datatype, fieldtype
>
> Currently the field 'maxRetry' in entity 'JobSandbox' in the entitydef of the 
> service component in the Framework stack is typed as 'numeric'.
> This should be typed in accordance with the various integer types (INT, 
> INTEGER, SMALLINT, BIGINT, LARGEINT, etc), as it doesn't make sense to 
> associate it with a type that is normally used for numbers with decimals. 
> Some connectors to DBMSes and/or the databases themselves are very picky 
> about this. As I have experienced when trying to have OFBiz persist on HBase.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-6992) Field 'maxRetry' is typed as 'numeric in entity 'JobSandbox'

2016-04-07 Thread Pierre Smits (JIRA)
Pierre Smits created OFBIZ-6992:
---

 Summary: Field 'maxRetry' is typed as 'numeric in entity 
'JobSandbox'
 Key: OFBIZ-6992
 URL: https://issues.apache.org/jira/browse/OFBIZ-6992
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: Trunk
Reporter: Pierre Smits


Currently the field 'maxRetry' in entity 'JobSandbox' in the entitydef of the 
service component in the Framework stack is typed as 'numeric'.

This should be typed in accordance with the various integer types (INT, 
INTEGER, SMALLINT, BIGINT, LARGEINT, etc), as it doesn't make sense to 
associate it with a type that is normally used for numbers with decimals. 

Some connectors to DBMSes and/or the databases themselves are very picky about 
this. As I have experienced when trying to have OFBiz persist on HBase.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6992) Field 'maxRetry' is typed as 'numeric' in entity 'JobSandbox'

2016-04-07 Thread Pierre Smits (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-6992:

Summary: Field 'maxRetry' is typed as 'numeric' in entity 'JobSandbox'  
(was: Field 'maxRetry' is typed as 'numeric in entity 'JobSandbox')

> Field 'maxRetry' is typed as 'numeric' in entity 'JobSandbox'
> -
>
> Key: OFBIZ-6992
> URL: https://issues.apache.org/jira/browse/OFBIZ-6992
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>  Labels: datatype, fieldtype
>
> Currently the field 'maxRetry' in entity 'JobSandbox' in the entitydef of the 
> service component in the Framework stack is typed as 'numeric'.
> This should be typed in accordance with the various integer types (INT, 
> INTEGER, SMALLINT, BIGINT, LARGEINT, etc), as it doesn't make sense to 
> associate it with a type that is normally used for numbers with decimals. 
> Some connectors to DBMSes and/or the databases themselves are very picky 
> about this. As I have experienced when trying to have OFBiz persist on HBase.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-6991) Move demo data in seed data files to demo data files

2016-04-07 Thread Pierre Smits (JIRA)
Pierre Smits created OFBIZ-6991:
---

 Summary: Move demo data in seed data files to demo data files
 Key: OFBIZ-6991
 URL: https://issues.apache.org/jira/browse/OFBIZ-6991
 Project: OFBiz
  Issue Type: Improvement
  Components: content
Affects Versions: Trunk
Reporter: Pierre Smits


Currently a lot of data in seed data files is actually demo data, but is loaded 
in the ./ant load-seed process. This leads to a heavy indexation of content 
keywords and slows the loading process. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: User pref or not user pref

2016-04-07 Thread Jacques Le Roux

That also means that Javascript should be used...

Jacques

Le 07/04/2016 16:43, james_sg a écrit :

You may also consider  Web Storage
   to store the user preference.


Julien NICOLAS wrote

Hi all,

We are thinking on a new theme (again) that will be more user friendly
and UX oriented.
We want to be able to customize menu (component and its sub menu).

User pref could be the clue but we are not sure because if all menu and
sub menu (and maybe 3rd or 4th level menu) user preference are recorded
in the user pref, it could be a nightmare for the database access if
there is a lot of users. And only for user preference, it's not a good
idea.
We also think about using cookies but it could be a problem if the user
user several computers.

What do you think ? Do you already try to develop this kind of feature ?

Thanks,

Julien.





--
View this message in context: 
http://ofbiz.135035.n4.nabble.com/User-pref-or-not-user-pref-tp4679049p4679083.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.





Re: Release Branch Demo URLs

2016-04-07 Thread Jacques Le Roux

Yes indeed!

Also we will soon change stable to use R14 and old to be R13...

Jacques

Le 07/04/2016 16:55, Pranay Pandey a écrit :

Shouldn't we open these four URLs in new tab with target="_BLANK".

- 13.07 Release Branch Demo (stable)

- Front-End Store

- Management Apps



- 12.04 Release Branch Demo (old)

- Front-End Store

- Management Apps




Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/



[jira] [Updated] (OFBIZ-6990) Add Example for Compound Screen Widget

2016-04-07 Thread james yong (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

james yong updated OFBIZ-6990:
--
Attachment: OFBIZ-6990.patch

This patch includes change to the ConfigXMLReader.java, and uses the original 
xsd files.

Go to Example application and click on 'Compound Screen Widget' to view the 
example. 

> Add Example for Compound Screen Widget
> --
>
> Key: OFBIZ-6990
> URL: https://issues.apache.org/jira/browse/OFBIZ-6990
> Project: OFBiz
>  Issue Type: Improvement
>  Components: specialpurpose/example
>Affects Versions: Trunk
>Reporter: james yong
>Priority: Minor
> Attachments: OFBIZ-6990.patch
>
>
> An example to test out Compound Screen Widget



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-6990) Add Example for Compound Screen Widget

2016-04-07 Thread james yong (JIRA)
james yong created OFBIZ-6990:
-

 Summary: Add Example for Compound Screen Widget
 Key: OFBIZ-6990
 URL: https://issues.apache.org/jira/browse/OFBIZ-6990
 Project: OFBiz
  Issue Type: Improvement
  Components: specialpurpose/example
Affects Versions: Trunk
Reporter: james yong
Priority: Minor


An example to test out Compound Screen Widget



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: User pref or not user pref

2016-04-07 Thread james_sg
You may also consider  Web Storage
   to store the user preference.


Julien NICOLAS wrote
> Hi all,
> 
> We are thinking on a new theme (again) that will be more user friendly 
> and UX oriented.
> We want to be able to customize menu (component and its sub menu).
> 
> User pref could be the clue but we are not sure because if all menu and 
> sub menu (and maybe 3rd or 4th level menu) user preference are recorded 
> in the user pref, it could be a nightmare for the database access if 
> there is a lot of users. And only for user preference, it's not a good
> idea.
> We also think about using cookies but it could be a problem if the user 
> user several computers.
> 
> What do you think ? Do you already try to develop this kind of feature ?
> 
> Thanks,
> 
> Julien.





--
View this message in context: 
http://ofbiz.135035.n4.nabble.com/User-pref-or-not-user-pref-tp4679049p4679083.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.


[jira] [Closed] (OFBIZ-6669) Possible stored XSS issue with Content

2016-04-07 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-6669.
--
Resolution: Fixed

OK, it was already part of OFBIZ-1525, I feel like mucking around :/

> Possible stored XSS issue with Content
> --
>
> Key: OFBIZ-6669
> URL: https://issues.apache.org/jira/browse/OFBIZ-6669
> Project: OFBiz
>  Issue Type: Bug
>  Components: content, order, party, product, workeffort
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Release 
> Branch 14.12, Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6669.patch, OFBIZ-6669.patch
>
>
> I found a possible XSS attack through *ContentWrapper.java and ContentWorker 
> itself.
> Note that in supported releases it's hard to exploit, it's a Stored XSS 
> https://www.owasp.org/index.php/Types_of_Cross-Site_Scripting which means you 
> need 1st to somehow inject exploiting code in the DB.
> Issues in *ContentWrapper.java have already been fixed by changing the 
> ContentWrapper interface
> from
> {code}
> public interface ContentWrapper {
> public StringUtil.StringWrapper get(String contentTypeId);
> }
> {code}
> to
> {code}
> public interface ContentWrapper {
> public StringUtil.StringWrapper get(String contentTypeId, String 
> encoderType) {
> }
> {code}
> And changing the Category, Party, Product, ProductPromo, ProductConfigItem 
> and WorkEffort ContentWrapperS accordingly. This means to use 2 types of 
> encoderTypes: "html" and "url".
> The "html"  encoderType will be used for all ProductContentTypes but those 
> who contain URL in their ContentTypeIdS (actually end with, "_URL") which 
> will use "url" encoderType.
> It concerns not only the get() method but also methods like 
> getPartyContentAsText(), getProductContentAsText(), etc.
> It seems a big change but it's straightforward. It's now complete after 
> following commits in revisions (I hope I did not miss to report):
> trunk 1705329 1705417 1705427 1705532 1706159 1706162 1707857  1708930
> and related backports in R14.12 1705331 1705418 1705428 1705533 1706160 
> 1706163 1707858  1708931
> I have also committed a fix for ContentWorker. For that I have added 
> owasp-java-html-sanitizer-r239.jar and put a "content.sanitize=true" property 
> in content.properties with some explanations. The reason I put this property 
> is because the sanitizer does some (safe) changes which might be unwanted in 
> a context where you are "sure" no one can inject/exploit your DB.
> Here is for instance the changes the sanitizer does when rendering cmssite
> {code}
> @@ -19,7 +19,7 @@
>  
> -
> +
>  This is the header!
>  
> @@ -27,34 +27,26 @@
>  
>Welcome to the CmsSite Home page.
> -  
> +
>
>This is a site to demonstrate the CMS capabilities of OFBiz. 
> Its basic function is the editing of website text
>inside a browser. If you want to edit the text you are reading 
> now, logon to the backend system, select the content component
> -  click on 'cmssite' in the website list and ten click on the 
> 'cms' button. There you see on the left hand side the tree of this website.
> -  If you click on 'homepage' then you can edit the content of 
> this page at the box in the r
> +  click on 'cmssite' in the website list and ten click 
> on the 'cms' button. There you see on the left hand side the tree of 
> this website.
> +  If you click on 'homepage' then you can edit the 
> content of this page at the box in the r
>
>
>This is only the basic function of the CMS which is part of 
> the content component. The content component is actually more than a
>CMS it can also handle documents pretty well. An example is 
> the apache OFBiz document you can see when you click on the last option in 
> the list below.
> -  
> -  
> -  
> -Demo Page 1 - 
> Hard Coded Link
> -Demo Page 1 
> - Hard Coded Link using the Sub-Content Pattern
> - href="/cmssite/cms/CMSS_DEMO_PAGE1;jsessionid=014BD837D7FFB6E0F8CB31AAF35092A0.jvm1">Demo
>  Page 1 - Dynamic Link
> - href="/cmssite/cms/CMSS_DEMO_SCREEN;jsessionid=014BD837D7FFB6E0F8CB31AAF35092A0.jvm1">Demo
>  Page with screen widget and screen decorator
> - href="/cmssite/cms/CMSS_DEMO_BLOG;jsessionid=014BD837D7FFB6E0F8CB31AAF35092A0.jvm1">Demo
>  Page with blog using screen decorator
> - href="/cmssite/cms/CMSS_DEMO_TPL_DATA;jsessionid=014BD8

[jira] [Updated] (OFBIZ-6680) Backport all changes to currently supported releases

2016-04-07 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-6680:
---
Issue Type: Sub-task  (was: Bug)
Parent: OFBIZ-6669

> Backport all changes to currently supported releases
> 
>
> Key: OFBIZ-6680
> URL: https://issues.apache.org/jira/browse/OFBIZ-6680
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content, order, party, product, workeffort
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>
> The revisions to backport are 1705329 1705405 1705412 1705417 1705427 1705532 
> 1706159 1706162 1707857 1708274 1708930 1711519



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-6701) Enhancement in the content wrappers

2016-04-07 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-6701.
--
Resolution: Fixed

> Enhancement in the content wrappers
> ---
>
> Key: OFBIZ-6701
> URL: https://issues.apache.org/jira/browse/OFBIZ-6701
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Release Branch 11.04, Release Branch 12.04, Release 
> Branch 13.07, Release Branch 14.12, Trunk
>Reporter: Ritu Raj Lakhera
>Assignee: Jacques Le Roux
> Fix For: Upcoming Branch
>
> Attachments: Ofbiz-6701.patch, Ofbiz-6701_Updated_All_Wrapper.patch
>
>
> There are some enhancements in product content wrapper JAVA class. We used 
> these enhancements in our project and observed good change in website 
> performance. 
> 1. If content of product is empty string or null then method 
> 'getProductContentAsText' is not caching the result. 
> And thus every time this method is making SQL call even no content in 
> database. Method should cache the empty string and null as result.
> 2. Overloaded method 'getProductContentAsText' is also using cache method of 
> Delegator for 'ProductConetnt' entity selection and passing 'true' to use 
> cache for 'ContentWorker.renderContentAsText' method. This approach is making 
> unnecessary copies of cache for content.
>   I Product content wrapper cache
>   II ProductContent entity cache
>   III Content, Dataresource, ElectrocText and etc... entities 
> cache(ContentWorker.renderContentAsText)
> If I again call the 'getProductContentAsText' method then this will return 
> the result from product content wrapper cache. So there is no use of 
> ProductContent, Content, Dataresource and ElectrocText cache. And these cache 
> also filling the memory of application.
> We also applied the same logic for category content wrapper. I am attaching 
> the patch for trunk, please review.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6680) Backport all changes to currently supported releases

2016-04-07 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-6680:
---
Issue Type: Bug  (was: Sub-task)
Parent: (was: OFBIZ-6669)

> Backport all changes to currently supported releases
> 
>
> Key: OFBIZ-6680
> URL: https://issues.apache.org/jira/browse/OFBIZ-6680
> Project: OFBiz
>  Issue Type: Bug
>  Components: content, order, party, product, workeffort
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>
> The revisions to backport are 1705329 1705405 1705412 1705417 1705427 1705532 
> 1706159 1706162 1707857 1708274 1708930 1711519



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Reopened] (OFBIZ-6701) Enhancement in the content wrappers

2016-04-07 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reopened OFBIZ-6701:


Finally as this is a sub-task of OFBIZ-6669, I need 1st to make it a simple 
issue to be able to make OFBIZ-6669 a sub-task of OFBIZ-1525 (no sub-taks trees 
in JIra)
So temporarily reopening, I will simply associate it with OFBIZ-6669, pfew...

> Enhancement in the content wrappers
> ---
>
> Key: OFBIZ-6701
> URL: https://issues.apache.org/jira/browse/OFBIZ-6701
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Release Branch 11.04, Release Branch 12.04, Release 
> Branch 13.07, Release Branch 14.12, Trunk
>Reporter: Ritu Raj Lakhera
>Assignee: Jacques Le Roux
> Fix For: Upcoming Branch
>
> Attachments: Ofbiz-6701.patch, Ofbiz-6701_Updated_All_Wrapper.patch
>
>
> There are some enhancements in product content wrapper JAVA class. We used 
> these enhancements in our project and observed good change in website 
> performance. 
> 1. If content of product is empty string or null then method 
> 'getProductContentAsText' is not caching the result. 
> And thus every time this method is making SQL call even no content in 
> database. Method should cache the empty string and null as result.
> 2. Overloaded method 'getProductContentAsText' is also using cache method of 
> Delegator for 'ProductConetnt' entity selection and passing 'true' to use 
> cache for 'ContentWorker.renderContentAsText' method. This approach is making 
> unnecessary copies of cache for content.
>   I Product content wrapper cache
>   II ProductContent entity cache
>   III Content, Dataresource, ElectrocText and etc... entities 
> cache(ContentWorker.renderContentAsText)
> If I again call the 'getProductContentAsText' method then this will return 
> the result from product content wrapper cache. So there is no use of 
> ProductContent, Content, Dataresource and ElectrocText cache. And these cache 
> also filling the memory of application.
> We also applied the same logic for category content wrapper. I am attaching 
> the patch for trunk, please review.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Reopened] (OFBIZ-6669) Possible stored XSS issue with Content

2016-04-07 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reopened OFBIZ-6669:


Temporarily reopening, I want this to be a sub-task of OFBIZ-1525

> Possible stored XSS issue with Content
> --
>
> Key: OFBIZ-6669
> URL: https://issues.apache.org/jira/browse/OFBIZ-6669
> Project: OFBiz
>  Issue Type: Bug
>  Components: content, order, party, product, workeffort
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Release 
> Branch 14.12, Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6669.patch, OFBIZ-6669.patch
>
>
> I found a possible XSS attack through *ContentWrapper.java and ContentWorker 
> itself.
> Note that in supported releases it's hard to exploit, it's a Stored XSS 
> https://www.owasp.org/index.php/Types_of_Cross-Site_Scripting which means you 
> need 1st to somehow inject exploiting code in the DB.
> Issues in *ContentWrapper.java have already been fixed by changing the 
> ContentWrapper interface
> from
> {code}
> public interface ContentWrapper {
> public StringUtil.StringWrapper get(String contentTypeId);
> }
> {code}
> to
> {code}
> public interface ContentWrapper {
> public StringUtil.StringWrapper get(String contentTypeId, String 
> encoderType) {
> }
> {code}
> And changing the Category, Party, Product, ProductPromo, ProductConfigItem 
> and WorkEffort ContentWrapperS accordingly. This means to use 2 types of 
> encoderTypes: "html" and "url".
> The "html"  encoderType will be used for all ProductContentTypes but those 
> who contain URL in their ContentTypeIdS (actually end with, "_URL") which 
> will use "url" encoderType.
> It concerns not only the get() method but also methods like 
> getPartyContentAsText(), getProductContentAsText(), etc.
> It seems a big change but it's straightforward. It's now complete after 
> following commits in revisions (I hope I did not miss to report):
> trunk 1705329 1705417 1705427 1705532 1706159 1706162 1707857  1708930
> and related backports in R14.12 1705331 1705418 1705428 1705533 1706160 
> 1706163 1707858  1708931
> I have also committed a fix for ContentWorker. For that I have added 
> owasp-java-html-sanitizer-r239.jar and put a "content.sanitize=true" property 
> in content.properties with some explanations. The reason I put this property 
> is because the sanitizer does some (safe) changes which might be unwanted in 
> a context where you are "sure" no one can inject/exploit your DB.
> Here is for instance the changes the sanitizer does when rendering cmssite
> {code}
> @@ -19,7 +19,7 @@
>  
> -
> +
>  This is the header!
>  
> @@ -27,34 +27,26 @@
>  
>Welcome to the CmsSite Home page.
> -  
> +
>
>This is a site to demonstrate the CMS capabilities of OFBiz. 
> Its basic function is the editing of website text
>inside a browser. If you want to edit the text you are reading 
> now, logon to the backend system, select the content component
> -  click on 'cmssite' in the website list and ten click on the 
> 'cms' button. There you see on the left hand side the tree of this website.
> -  If you click on 'homepage' then you can edit the content of 
> this page at the box in the r
> +  click on 'cmssite' in the website list and ten click 
> on the 'cms' button. There you see on the left hand side the tree of 
> this website.
> +  If you click on 'homepage' then you can edit the 
> content of this page at the box in the r
>
>
>This is only the basic function of the CMS which is part of 
> the content component. The content component is actually more than a
>CMS it can also handle documents pretty well. An example is 
> the apache OFBiz document you can see when you click on the last option in 
> the list below.
> -  
> -  
> -  
> -Demo Page 1 - 
> Hard Coded Link
> -Demo Page 1 
> - Hard Coded Link using the Sub-Content Pattern
> - href="/cmssite/cms/CMSS_DEMO_PAGE1;jsessionid=014BD837D7FFB6E0F8CB31AAF35092A0.jvm1">Demo
>  Page 1 - Dynamic Link
> - href="/cmssite/cms/CMSS_DEMO_SCREEN;jsessionid=014BD837D7FFB6E0F8CB31AAF35092A0.jvm1">Demo
>  Page with screen widget and screen decorator
> - href="/cmssite/cms/CMSS_DEMO_BLOG;jsessionid=014BD837D7FFB6E0F8CB31AAF35092A0.jvm1">Demo
>  Page with blog using screen decorator
> - href="/cmssite/cms/CMSS_DEMO_TPL_DATA;jsessionid=014BD837D7FFB6E0F8CB31AAF35

[jira] [Closed] (OFBIZ-6701) Enhancement in the content wrappers

2016-04-07 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-6701.
--
Resolution: Fixed

Yikes, wrong tab :/ Closing as fixed again

> Enhancement in the content wrappers
> ---
>
> Key: OFBIZ-6701
> URL: https://issues.apache.org/jira/browse/OFBIZ-6701
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Release Branch 11.04, Release Branch 12.04, Release 
> Branch 13.07, Release Branch 14.12, Trunk
>Reporter: Ritu Raj Lakhera
>Assignee: Jacques Le Roux
> Fix For: Upcoming Branch
>
> Attachments: Ofbiz-6701.patch, Ofbiz-6701_Updated_All_Wrapper.patch
>
>
> There are some enhancements in product content wrapper JAVA class. We used 
> these enhancements in our project and observed good change in website 
> performance. 
> 1. If content of product is empty string or null then method 
> 'getProductContentAsText' is not caching the result. 
> And thus every time this method is making SQL call even no content in 
> database. Method should cache the empty string and null as result.
> 2. Overloaded method 'getProductContentAsText' is also using cache method of 
> Delegator for 'ProductConetnt' entity selection and passing 'true' to use 
> cache for 'ContentWorker.renderContentAsText' method. This approach is making 
> unnecessary copies of cache for content.
>   I Product content wrapper cache
>   II ProductContent entity cache
>   III Content, Dataresource, ElectrocText and etc... entities 
> cache(ContentWorker.renderContentAsText)
> If I again call the 'getProductContentAsText' method then this will return 
> the result from product content wrapper cache. So there is no use of 
> ProductContent, Content, Dataresource and ElectrocText cache. And these cache 
> also filling the memory of application.
> We also applied the same logic for category content wrapper. I am attaching 
> the patch for trunk, please review.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Reopened] (OFBIZ-6701) Enhancement in the content wrappers

2016-04-07 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reopened OFBIZ-6701:


Temporarily reopening, I want this to be a sub-task of OFBIZ-1525

> Enhancement in the content wrappers
> ---
>
> Key: OFBIZ-6701
> URL: https://issues.apache.org/jira/browse/OFBIZ-6701
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Release Branch 11.04, Release Branch 12.04, Release 
> Branch 13.07, Release Branch 14.12, Trunk
>Reporter: Ritu Raj Lakhera
>Assignee: Jacques Le Roux
> Fix For: Upcoming Branch
>
> Attachments: Ofbiz-6701.patch, Ofbiz-6701_Updated_All_Wrapper.patch
>
>
> There are some enhancements in product content wrapper JAVA class. We used 
> these enhancements in our project and observed good change in website 
> performance. 
> 1. If content of product is empty string or null then method 
> 'getProductContentAsText' is not caching the result. 
> And thus every time this method is making SQL call even no content in 
> database. Method should cache the empty string and null as result.
> 2. Overloaded method 'getProductContentAsText' is also using cache method of 
> Delegator for 'ProductConetnt' entity selection and passing 'true' to use 
> cache for 'ContentWorker.renderContentAsText' method. This approach is making 
> unnecessary copies of cache for content.
>   I Product content wrapper cache
>   II ProductContent entity cache
>   III Content, Dataresource, ElectrocText and etc... entities 
> cache(ContentWorker.renderContentAsText)
> If I again call the 'getProductContentAsText' method then this will return 
> the result from product content wrapper cache. So there is no use of 
> ProductContent, Content, Dataresource and ElectrocText cache. And these cache 
> also filling the memory of application.
> We also applied the same logic for category content wrapper. I am attaching 
> the patch for trunk, please review.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Release Branch Demo URLs

2016-04-07 Thread Pranay Pandey
Shouldn't we open these four URLs in new tab with target="_BLANK".

- 13.07 Release Branch Demo (stable)

   - Front-End Store
   
   - Management Apps
   


- 12.04 Release Branch Demo (old)

   - Front-End Store
   
   - Management Apps
   



Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/


[jira] [Updated] (OFBIZ-6986) Simplify getChildHRCategoryTree

2016-04-07 Thread Kulwant (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kulwant updated OFBIZ-6986:
---
Attachment: OFBIZ-6986.patch

I think we don't need any kind of test case for HumaResEvent.java as It only 
get data from entities.
But we can do one thing i.e we can provide javadoc for same to specify the 
format the json returned from this event.

> Simplify getChildHRCategoryTree
> ---
>
> Key: OFBIZ-6986
> URL: https://issues.apache.org/jira/browse/OFBIZ-6986
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, humanres
>Reporter: Kulwant
>Assignee: Pranay Pandey
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-6986.patch, OFBIZ-6986.patch, OFBIZ-6986.patch
>
>
> breaking the single long method to multiple private functions with improved 
> exception handling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6988) Estimated shipping cost resolution with breaks on price and quantity

2016-04-07 Thread Nicolas Malin (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin updated OFBIZ-6988:
-
Description: 
On the service *calcShipmentCostEstimate*, each estimated shipment cost are 
analysed to resolve who is enable to apply on the order.

During the breakQtys block analyse, OFBiz check if the estimate match the 
quantity  with their breaks and valid it if one is good
{code}
if (qv != null) {
useQty = true;
BigDecimal min = BigDecimal.ONE.movePointLeft(4);
BigDecimal max = BigDecimal.ONE.movePointLeft(4);

try {
min = qv.getBigDecimal("fromQuantity");
max = qv.getBigDecimal("thruQuantity");
} catch (Exception e) {
}
if (shippableQuantity.compareTo(min) >= 0 && 
(max.compareTo(BigDecimal.ZERO) == 0 || shippableQuantity.compareTo(max) <= 0)) 
{
qtyValid = true;
}
if (Debug.infoOn()) Debug.logInfo(" # QUANTITY SHIP min 
: " + min + ", max : " + max + ", value " + shippableQuantity + " qtyValid " + 
qtyValid, module);
}
if (pv != null) {
usePrice = true;
BigDecimal min = BigDecimal.ONE.movePointLeft(4);
BigDecimal max = BigDecimal.ONE.movePointLeft(4);

try {
min = pv.getBigDecimal("fromQuantity");
max = pv.getBigDecimal("thruQuantity");
} catch (Exception e) {
}
if (shippableTotal.compareTo(min) >= 0 && 
(max.compareTo(BigDecimal.ZERO) == 0 || shippableTotal.compareTo(max) <= 0)) {
priceValid = true;
}
if (Debug.infoOn()) Debug.logInfo(" # PRICE TOT SHIP 
min : " + min + ", max : " + max + ", value " + shippableTotal+ " qtyValid " + 
priceValid, module);
}
// Now check the tests.
if ((useWeight && weightValid)  || (useQty && qtyValid) || 
(usePrice && priceValid)) {
estimateList.add(thisEstimate);
}
{code}

I didn't understand why a estimate shippping cost that contains a break no 
valid can be apply on the order.

On a customer project I ave these rules:
||  ||Quantity Break Id||   Price Break Id|| Flat Price ||  Order Price 
Percent ||
|FR000| |   0 - 1000 [FRP4] | 25|0|
|FR001| 0 - 500,000 [FRB01]|1000 - 0 [FRP3] |   |15|
|FR004| 2,000,000 - 0 [FRB04]|  1000 - 0 [FRP3] |   |2|
|FR003| 1,000,001 - 1,999,999 [FRB03]|  1000 - 0 [FRP3] |   
 |5|
|FR002| 500,001 - 1,000,000 [FRB02]|1000 - 0 [FRP3] |   
  |8|

The problem with the previous code that for a total price more than 300€ OFBiz 
give me a random rule between FR00[1-4] and it's wrong because I have also a 
break on total quantity shipped

I propose to change the check like this 
{code}
@@ -406,7 +410,9 @@
 }
 }
 // Now check the tests.
-if ((useWeight && weightValid) || (useQty && qtyValid) || 
(usePrice && priceValid)) {
+if ((!useWeight || useWeight && weightValid) 
+&& (!useQty || useQty && qtyValid)
+&& (!usePrice || usePrice && priceValid)) {
 estimateList.add(thisEstimate);
 }
 }
{code}

To ensure that is a break is define on the estimated shipping cost, we enable 
this last only all define break are valid.

Any suggest ?

  was:
On the service *calcShipmentCostEstimate*, each estimated shipment cost are 
analysed to resolve who is enable to apply on the order.

During the breakQtys block analyse, OFBiz check if the estimate match the 
quantity  with their breaks and valid it if one is good
{code}
if (qv != null) {
useQty = true;
BigDecimal min = BigDecimal.ONE.movePointLeft(4);
BigDecimal max = BigDecimal.ONE.movePointLeft(4);

try {
min = qv.getBigDecimal("fromQuantity");
max = qv.getBigDecimal("thruQuantity");
} catch (Exception e) {
}
if (shippableQuantity.compareTo(min) >= 0 && 
(max.compareTo(BigDecimal.ZERO) == 0 || shippableQuantity.compareTo(max) <= 0)) 
{
qtyValid = true;
 

[jira] [Created] (OFBIZ-6989) Editing project in Project Manager duplicates resources

2016-04-07 Thread Montalbano Florian (JIRA)
Montalbano Florian created OFBIZ-6989:
-

 Summary: Editing project in Project Manager duplicates resources
 Key: OFBIZ-6989
 URL: https://issues.apache.org/jira/browse/OFBIZ-6989
 Project: OFBiz
  Issue Type: Bug
  Components: specialpurpose/projectmgr
Affects Versions: Release Branch 15.12
Reporter: Montalbano Florian
Priority: Minor


In the Ofbiz 15.12 release (i didn't test it on the other version), when 
selecting a project from the list and trying to edit it, clicking on the save 
button cause the Client Billing Party Id and the Organization Party Id to be 
added again in the resources list of the project summary (and in the resources 
tab too). It happens even when you don't edit anything.

It doesn't seem like a wanted behaviour but I'm new to Ofbiz so, I may be wrong.

Tell me if you need more information,

Thanks.
Florian




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Accessible Rich Internet Applications

2016-04-07 Thread Pranay Pandey
Hi James,

I am referring to a website which has to be accessible rich.

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Thu, Apr 7, 2016 at 2:58 PM, james yong  wrote:

> Hi Pranay,
>
> Are you referring to the management apps?
>
> Regards,
> James
>
>
>
> Pranay Pandey-3 wrote
> > Hello Devs,
> >
> > We have got an opportunity to work on ARIA
> > . Accessibility is the core of
> > this
> > delivery. Currently this project is under development.
> > Just wanted to check-in here if someone is having experience building
> such
> > applications top of OFBiz and would like to share their experiences and
> > learnings.
> > Do you think having one sample application OOTB following these
> guidelines
> > will be a good addition?
> >
> > Best regards,
> >
> > Pranay Pandey
> > HotWax Systems
> > http://www.hotwaxsystems.com/
>
>
>
>
>
> --
> View this message in context:
> http://ofbiz.135035.n4.nabble.com/Accessible-Rich-Internet-Applications-tp4679037p4679050.html
> Sent from the OFBiz - Dev mailing list archive at Nabble.com.
>


Re: Increasing social media reach

2016-04-07 Thread Pierre Smits
My apologies,

This is not intended for the OFBiz project.

Best regards,

Pierre Smits

ORRTIZ.COM 
OFBiz based solutions & services

OFBiz Extensions Marketplace
http://oem.ofbizci.net/oci-2/

On Thu, Apr 7, 2016 at 3:40 PM, Pierre Smits  wrote:

> Hi all,
>
> It pleases me to be able to inform you that today I received a
> notification that our project's tweet account @ApacheDS now reached and
> bested the milestone of 100 followers. While followers come and go, we
> should not deter in spreading the positive vibe and continue to inform the
> public with messages from the project that are meaningfull and without
> sentiment.
>
> Our community will grow with increased awareness at the site of potential
> adopters and other parties interested in our products and our way of
> working. A way to increase our social media reach is also following
> thoughtleaders and influencers on the subjects of our project and sub
> projects. If you happen to know an interesting party (and their tweet
> account), please share it and we'll investigate following
> him/her/them/they..
>
> Best regards
> Pierre Smits
>
> ORRTIZ.COM 
> OFBiz based solutions & services
>
> OFBiz Extensions Marketplace
> http://oem.ofbizci.net/oci-2/
>


Increasing social media reach

2016-04-07 Thread Pierre Smits
Hi all,

It pleases me to be able to inform you that today I received a notification
that our project's tweet account @ApacheDS now reached and bested the
milestone of 100 followers. While followers come and go, we should not
deter in spreading the positive vibe and continue to inform the public with
messages from the project that are meaningfull and without sentiment.

Our community will grow with increased awareness at the site of potential
adopters and other parties interested in our products and our way of
working. A way to increase our social media reach is also following
thoughtleaders and influencers on the subjects of our project and sub
projects. If you happen to know an interesting party (and their tweet
account), please share it and we'll investigate following
him/her/them/they..

Best regards
Pierre Smits

ORRTIZ.COM 
OFBiz based solutions & services

OFBiz Extensions Marketplace
http://oem.ofbizci.net/oci-2/


Re: User pref or not user pref

2016-04-07 Thread Jacques Le Roux

This could be parametrised, cookies for lot of users, cache for less users.
Without any measure, I guess it should a very high number of users before it's really a problem for caching (usual production servers have now at 
least 16GB...), so cache would be the default


Jacques

Le 07/04/2016 12:38, Julien NICOLAS a écrit :
It could be loaded in the cache but if we push all user customisation in cache, it could use too much memories only for the UI (if you have a lot of 
users).


Julien.

Le 07/04/2016 12:34, Pierre Smits a écrit :

Aren't user prefs cached somehow?

Pierre Smits

ORRTIZ.COM 
OFBiz based solutions & services

OFBiz Extensions Marketplace
http://oem.ofbizci.net/oci-2/

On Thu, Apr 7, 2016 at 11:35 AM, Julien NICOLAS 
wrote:


Hi all,

We are thinking on a new theme (again) that will be more user friendly and
UX oriented.
We want to be able to customize menu (component and its sub menu).

User pref could be the clue but we are not sure because if all menu and
sub menu (and maybe 3rd or 4th level menu) user preference are recorded in
the user pref, it could be a nightmare for the database access if there is
a lot of users. And only for user preference, it's not a good idea.
We also think about using cookies but it could be a problem if the user
user several computers.

What do you think ? Do you already try to develop this kind of feature ?

Thanks,

Julien.






[jira] [Closed] (OFBIZ-6978) Refactor Quote Screen to use Compound Screen Widget feature

2016-04-07 Thread james yong (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

james yong closed OFBIZ-6978.
-
Resolution: Unresolved

Better to use the Example component as a test bed

> Refactor Quote Screen to use Compound Screen Widget feature
> ---
>
> Key: OFBIZ-6978
> URL: https://issues.apache.org/jira/browse/OFBIZ-6978
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: james yong
>Priority: Minor
>
> This issue aims to refactor the Quote Screen according to the feature in 
> OFBIZ-4090. Will use sub-tasks to keep the patches small and incremental.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6980) Refactor Sub Screen - Create Quote

2016-04-07 Thread james yong (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

james yong updated OFBIZ-6980:
--
Attachment: (was: OFBIZ-6980-CreateQuote.patch)

> Refactor Sub Screen - Create Quote
> --
>
> Key: OFBIZ-6980
> URL: https://issues.apache.org/jira/browse/OFBIZ-6980
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: james yong
>Priority: Minor
>
> A new file QuoteEditScreen.xml for the EditQuote subscreen using Compound 
> Screen Widget feature



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6980) Refactor Sub Screen - Create Quote

2016-04-07 Thread james yong (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15230211#comment-15230211
 ] 

james yong commented on OFBIZ-6980:
---

As discussed at OFBIZ-4090, Example would be a better place to start with the 
Compound Widget Screen feature.

> Refactor Sub Screen - Create Quote
> --
>
> Key: OFBIZ-6980
> URL: https://issues.apache.org/jira/browse/OFBIZ-6980
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: james yong
>Priority: Minor
>
> A new file QuoteEditScreen.xml for the EditQuote subscreen using Compound 
> Screen Widget feature



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Accessible Rich Internet Applications

2016-04-07 Thread james_sg
Hi Pranay,

Are you referring to the management apps?

Regards,
James



Pranay Pandey-3 wrote
> Hello Devs,
> 
> We have got an opportunity to work on ARIA
> ;. Accessibility is the core of
> this
> delivery. Currently this project is under development.
> Just wanted to check-in here if someone is having experience building such
> applications top of OFBiz and would like to share their experiences and
> learnings.
> Do you think having one sample application OOTB following these guidelines
> will be a good addition?
> 
> Best regards,
> 
> Pranay Pandey
> HotWax Systems
> http://www.hotwaxsystems.com/





--
View this message in context: 
http://ofbiz.135035.n4.nabble.com/Accessible-Rich-Internet-Applications-tp4679037p4679063.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.


[jira] [Commented] (OFBIZ-6988) Estimated shipping cost resolution with breaks on price and quantity

2016-04-07 Thread Nicolas Malin (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15230185#comment-15230185
 ] 

Nicolas Malin commented on OFBIZ-6988:
--

After a second read, I thinks this service is old and need a technical refresh 
:) . 

I wait some remark on the initial subject to recode the service

> Estimated shipping cost resolution with breaks on price and quantity
> 
>
> Key: OFBIZ-6988
> URL: https://issues.apache.org/jira/browse/OFBIZ-6988
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
>  Labels: shipping
>
> On the service *calcShipmentCostEstimate*, each estimated shipment cost are 
> analysed to resolve who is enable to apply on the order.
> During the breakQtys block analyse, OFBiz check if the estimate match the 
> quantity  with their breaks and valid it if one is good
> {code}
> if (qv != null) {
> useQty = true;
> BigDecimal min = BigDecimal.ONE.movePointLeft(4);
> BigDecimal max = BigDecimal.ONE.movePointLeft(4);
> try {
> min = qv.getBigDecimal("fromQuantity");
> max = qv.getBigDecimal("thruQuantity");
> } catch (Exception e) {
> }
> if (shippableQuantity.compareTo(min) >= 0 && 
> (max.compareTo(BigDecimal.ZERO) == 0 || shippableQuantity.compareTo(max) <= 
> 0)) {
> qtyValid = true;
> }
> if (Debug.infoOn()) Debug.logInfo(" # QUANTITY SHIP 
> min : " + min + ", max : " + max + ", value " + shippableQuantity + " 
> qtyValid " + qtyValid, module);
> }
> if (pv != null) {
> usePrice = true;
> BigDecimal min = BigDecimal.ONE.movePointLeft(4);
> BigDecimal max = BigDecimal.ONE.movePointLeft(4);
> try {
> min = pv.getBigDecimal("fromQuantity");
> max = pv.getBigDecimal("thruQuantity");
> } catch (Exception e) {
> }
> if (shippableTotal.compareTo(min) >= 0 && 
> (max.compareTo(BigDecimal.ZERO) == 0 || shippableTotal.compareTo(max) <= 0)) {
> priceValid = true;
> }
> if (Debug.infoOn()) Debug.logInfo(" # PRICE TOT SHIP 
> min : " + min + ", max : " + max + ", value " + shippableTotal+ " qtyValid " 
> + priceValid, module);
> }
> // Now check the tests.
> if ((useWeight && weightValid)  || (useQty && qtyValid) 
> || (usePrice && priceValid)) {
> estimateList.add(thisEstimate);
> }
> {code}
> I didn't understand why a estimate shippping cost that contains a break no 
> valid can be apply on the order.
> On a customer project I ave these rules:
> ||||Quantity Break Id||   Price Break Id|| Flat Price ||  Order Price 
> Percent ||
> |FR000|   |   0 - 300 [FRP4]  | 15|0|
> |FR001|   0 - 30,000 [FRB01]| 300 - 0 [FRP3]  |   |5|
> |FR004|   100,000 - 0 [FRB04]|300 - 0 [FRP3]  |   |1|
> |FR003|   50,001 - 99,999 [FRB03]|300 - 0 [FRP3]  |    |2|
> |FR002|   30,001 - 50,000 [FRB02]|300 - 0 [FRP3]  |     |3|
> The problem with the previous code that for a total price more than 300€ 
> OFBiz give me a random rule between FR00[1-4] and it's wrong because I have 
> also a break on total quantity shipped
> I propose to change the check like this 
> {code}
> @@ -406,7 +410,9 @@
>  }
>  }
>  // Now check the tests.
> -if ((useWeight && weightValid) || (useQty && qtyValid) 
> || (usePrice && priceValid)) {
> +if ((!useWeight || useWeight && weightValid) 
> +&& (!useQty || useQty && qtyValid)
> +&& (!usePrice || usePrice && priceValid)) {
>  estimateList.add(thisEstimate);
>  }
>  }
> {code}
> To ensure that is a break is define on the estimated shipping cost, we enable 
> this last only all define break are valid.
> Any suggest ?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6988) Estimated shipping cost resolution with breaks on price and quantity

2016-04-07 Thread Nicolas Malin (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin updated OFBIZ-6988:
-
Summary: Estimated shipping cost resolution with breaks on price and 
quantity  (was: Estimated resolution with break on price and quantity)

> Estimated shipping cost resolution with breaks on price and quantity
> 
>
> Key: OFBIZ-6988
> URL: https://issues.apache.org/jira/browse/OFBIZ-6988
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
>  Labels: shipping
>
> On the service *calcShipmentCostEstimate*, each estimated shipment cost are 
> analysed to resolve who is enable to apply on the order.
> During the breakQtys block analyse, OFBiz check if the estimate match the 
> quantity  with their breaks and valid it if one is good
> {code}
> if (qv != null) {
> useQty = true;
> BigDecimal min = BigDecimal.ONE.movePointLeft(4);
> BigDecimal max = BigDecimal.ONE.movePointLeft(4);
> try {
> min = qv.getBigDecimal("fromQuantity");
> max = qv.getBigDecimal("thruQuantity");
> } catch (Exception e) {
> }
> if (shippableQuantity.compareTo(min) >= 0 && 
> (max.compareTo(BigDecimal.ZERO) == 0 || shippableQuantity.compareTo(max) <= 
> 0)) {
> qtyValid = true;
> }
> if (Debug.infoOn()) Debug.logInfo(" # QUANTITY SHIP 
> min : " + min + ", max : " + max + ", value " + shippableQuantity + " 
> qtyValid " + qtyValid, module);
> }
> if (pv != null) {
> usePrice = true;
> BigDecimal min = BigDecimal.ONE.movePointLeft(4);
> BigDecimal max = BigDecimal.ONE.movePointLeft(4);
> try {
> min = pv.getBigDecimal("fromQuantity");
> max = pv.getBigDecimal("thruQuantity");
> } catch (Exception e) {
> }
> if (shippableTotal.compareTo(min) >= 0 && 
> (max.compareTo(BigDecimal.ZERO) == 0 || shippableTotal.compareTo(max) <= 0)) {
> priceValid = true;
> }
> if (Debug.infoOn()) Debug.logInfo(" # PRICE TOT SHIP 
> min : " + min + ", max : " + max + ", value " + shippableTotal+ " qtyValid " 
> + priceValid, module);
> }
> // Now check the tests.
> if ((useWeight && weightValid)  || (useQty && qtyValid) 
> || (usePrice && priceValid)) {
> estimateList.add(thisEstimate);
> }
> {code}
> I didn't understand why a estimate shippping cost that contains a break no 
> valid can be apply on the order.
> On a customer project I ave these rules:
> ||||Quantity Break Id||   Price Break Id|| Flat Price ||  Order Price 
> Percent ||
> |FR000|   |   0 - 300 [FRP4]  | 15|0|
> |FR001|   0 - 30,000 [FRB01]| 300 - 0 [FRP3]  |   |5|
> |FR004|   100,000 - 0 [FRB04]|300 - 0 [FRP3]  |   |1|
> |FR003|   50,001 - 99,999 [FRB03]|300 - 0 [FRP3]  |    |2|
> |FR002|   30,001 - 50,000 [FRB02]|300 - 0 [FRP3]  |     |3|
> The problem with the previous code that for a total price more than 300€ 
> OFBiz give me a random rule between FR00[1-4] and it's wrong because I have 
> also a break on total quantity shipped
> I propose to change the check like this 
> {code}
> @@ -406,7 +410,9 @@
>  }
>  }
>  // Now check the tests.
> -if ((useWeight && weightValid) || (useQty && qtyValid) 
> || (usePrice && priceValid)) {
> +if ((!useWeight || useWeight && weightValid) 
> +&& (!useQty || useQty && qtyValid)
> +&& (!usePrice || usePrice && priceValid)) {
>  estimateList.add(thisEstimate);
>  }
>  }
> {code}
> To ensure that is a break is define on the estimated shipping cost, we enable 
> this last only all define break are valid.
> Any suggest ?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6986) Simplify getChildHRCategoryTree

2016-04-07 Thread Pranay Pandey (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15230153#comment-15230153
 ] 

Pranay Pandey commented on OFBIZ-6986:
--

Kulwant, 

Please let me know in case you need any help from my side for making 
improvement suggested by Taher. If you are able to take care of these updates, 
provide the patch for the same. 

> Simplify getChildHRCategoryTree
> ---
>
> Key: OFBIZ-6986
> URL: https://issues.apache.org/jira/browse/OFBIZ-6986
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, humanres
>Reporter: Kulwant
>Assignee: Pranay Pandey
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-6986.patch, OFBIZ-6986.patch
>
>
> breaking the single long method to multiple private functions with improved 
> exception handling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6986) Simplify getChildHRCategoryTree

2016-04-07 Thread Taher Alkhateeb (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15230148#comment-15230148
 ] 

Taher Alkhateeb commented on OFBIZ-6986:


One more thing to add to my above comments:

Please add testing to your code! A minimum of two or three tests are needed IMHO

> Simplify getChildHRCategoryTree
> ---
>
> Key: OFBIZ-6986
> URL: https://issues.apache.org/jira/browse/OFBIZ-6986
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, humanres
>Reporter: Kulwant
>Assignee: Pranay Pandey
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-6986.patch, OFBIZ-6986.patch
>
>
> breaking the single long method to multiple private functions with improved 
> exception handling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (OFBIZ-6986) Simplify getChildHRCategoryTree

2016-04-07 Thread Pranay Pandey (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15230147#comment-15230147
 ] 

Pranay Pandey edited comment on OFBIZ-6986 at 4/7/16 12:15 PM:
---

Reopening, to improve it bit further based on patterns suggested by Taher.


was (Author: pandeypranay):
Reopening, to improve it bit further based on new patterns suggested by Taher.

> Simplify getChildHRCategoryTree
> ---
>
> Key: OFBIZ-6986
> URL: https://issues.apache.org/jira/browse/OFBIZ-6986
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, humanres
>Reporter: Kulwant
>Assignee: Pranay Pandey
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-6986.patch, OFBIZ-6986.patch
>
>
> breaking the single long method to multiple private functions with improved 
> exception handling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Reopened] (OFBIZ-6986) Simplify getChildHRCategoryTree

2016-04-07 Thread Pranay Pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pranay Pandey reopened OFBIZ-6986:
--

Reopening, to improve it bit further based on new patterns suggested by Taher.

> Simplify getChildHRCategoryTree
> ---
>
> Key: OFBIZ-6986
> URL: https://issues.apache.org/jira/browse/OFBIZ-6986
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, humanres
>Reporter: Kulwant
>Assignee: Pranay Pandey
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-6986.patch, OFBIZ-6986.patch
>
>
> breaking the single long method to multiple private functions with improved 
> exception handling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-6986) Simplify getChildHRCategoryTree

2016-04-07 Thread Pranay Pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pranay Pandey closed OFBIZ-6986.

   Resolution: Fixed
Fix Version/s: Upcoming Branch

Committed at trunk revision 1738122.
Thanks [~KlwntSingh] for reporting and providing patch for the issue. Thanks 
[~deepak.dixit] for reviewing the patch and providing improvement suggestions.

> Simplify getChildHRCategoryTree
> ---
>
> Key: OFBIZ-6986
> URL: https://issues.apache.org/jira/browse/OFBIZ-6986
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, humanres
>Reporter: Kulwant
>Assignee: Pranay Pandey
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-6986.patch, OFBIZ-6986.patch
>
>
> breaking the single long method to multiple private functions with improved 
> exception handling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6986) Simplify getChildHRCategoryTree

2016-04-07 Thread Taher Alkhateeb (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15230138#comment-15230138
 ] 

Taher Alkhateeb commented on OFBIZ-6986:


Hi Kulwant,

First of all, thank you for the great efforts. I checked your patch and I have 
the below comments:

- Your code suffers from copy and paste patterns. You are repeating the below 
code in each function:
{code:java}
Delegator delegator = (Delegator) params.get("delegator");
String partyId = (String) params.get("partyId");
String onclickFunction = (String) params.get("onclickFunction");
String additionParam = (String) params.get("additionParam");ata 
String hrefString = (String) params.get("hrefString");
String hrefString2 = (String) params.get("hrefString2");
{code}

So the fix for that is to build a map once and pass it to all the functions. 
The code would be much cleaner and you would shave off at least 20 lines of 
code.

- The list building logic is still relatively complex and can be further 
simplified. Right now, JSON syntax building is still mixed with normal data 
processing. If you separate the two, your code would be much cleaner.

- The signatures of the methods are complex and exception handling should be 
unified, the try and catch blocks sprinkled every where are making the code 
rather unpleasant.

If you feel comfortable with these changes, then please go ahead, if you need 
any help with any of that stuff then please us and we'll try our best to help 
out.

> Simplify getChildHRCategoryTree
> ---
>
> Key: OFBIZ-6986
> URL: https://issues.apache.org/jira/browse/OFBIZ-6986
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, humanres
>Reporter: Kulwant
>Assignee: Pranay Pandey
> Attachments: OFBIZ-6986.patch, OFBIZ-6986.patch
>
>
> breaking the single long method to multiple private functions with improved 
> exception handling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-6988) Estimated resolution with break on price and quantity

2016-04-07 Thread Nicolas Malin (JIRA)
Nicolas Malin created OFBIZ-6988:


 Summary: Estimated resolution with break on price and quantity
 Key: OFBIZ-6988
 URL: https://issues.apache.org/jira/browse/OFBIZ-6988
 Project: OFBiz
  Issue Type: Improvement
  Components: product
Affects Versions: Trunk
Reporter: Nicolas Malin
Assignee: Nicolas Malin
Priority: Minor


On the service *calcShipmentCostEstimate*, each estimated shipment cost are 
analysed to resolve who is enable to apply on the order.

During the breakQtys block analyse, OFBiz check if the estimate match the 
quantity  with their breaks and valid it if one is good
{code}
if (qv != null) {
useQty = true;
BigDecimal min = BigDecimal.ONE.movePointLeft(4);
BigDecimal max = BigDecimal.ONE.movePointLeft(4);

try {
min = qv.getBigDecimal("fromQuantity");
max = qv.getBigDecimal("thruQuantity");
} catch (Exception e) {
}
if (shippableQuantity.compareTo(min) >= 0 && 
(max.compareTo(BigDecimal.ZERO) == 0 || shippableQuantity.compareTo(max) <= 0)) 
{
qtyValid = true;
}
if (Debug.infoOn()) Debug.logInfo(" # QUANTITY SHIP min 
: " + min + ", max : " + max + ", value " + shippableQuantity + " qtyValid " + 
qtyValid, module);
}
if (pv != null) {
usePrice = true;
BigDecimal min = BigDecimal.ONE.movePointLeft(4);
BigDecimal max = BigDecimal.ONE.movePointLeft(4);

try {
min = pv.getBigDecimal("fromQuantity");
max = pv.getBigDecimal("thruQuantity");
} catch (Exception e) {
}
if (shippableTotal.compareTo(min) >= 0 && 
(max.compareTo(BigDecimal.ZERO) == 0 || shippableTotal.compareTo(max) <= 0)) {
priceValid = true;
}
if (Debug.infoOn()) Debug.logInfo(" # PRICE TOT SHIP 
min : " + min + ", max : " + max + ", value " + shippableTotal+ " qtyValid " + 
priceValid, module);
}
// Now check the tests.
if ((useWeight && weightValid)  || (useQty && qtyValid) || 
(usePrice && priceValid)) {
estimateList.add(thisEstimate);
}
{code}

I didn't understand why a estimate shippping cost that contains a break no 
valid can be apply on the order.

On a customer project I ave these rules:
||  ||Quantity Break Id||   Price Break Id|| Flat Price ||  Order Price 
Percent ||
|FR000| |   0 - 300 [FRP4]  | 15|0|
|FR001| 0 - 30,000 [FRB01]| 300 - 0 [FRP3]  |   |5|
|FR004| 100,000 - 0 [FRB04]|300 - 0 [FRP3]  |   |1|
|FR003| 50,001 - 99,999 [FRB03]|300 - 0 [FRP3]  |    |2|
|FR002| 30,001 - 50,000 [FRB02]|300 - 0 [FRP3]  |     |3|

The problem with the previous code that for a total price more than 300€ OFBiz 
give me a random rule between FR00[1-4] and it's wrong because I have also a 
break on total quantity shipped

I propose to change the check like this 
{code}
@@ -406,7 +410,9 @@
 }
 }
 // Now check the tests.
-if ((useWeight && weightValid) || (useQty && qtyValid) || 
(usePrice && priceValid)) {
+if ((!useWeight || useWeight && weightValid) 
+&& (!useQty || useQty && qtyValid)
+&& (!usePrice || usePrice && priceValid)) {
 estimateList.add(thisEstimate);
 }
 }
{code}

To ensure that is a break is define on the estimated shipping cost, we enable 
this last only all define break are valid.

Any suggest ?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: User pref or not user pref

2016-04-07 Thread Julien NICOLAS
It could be loaded in the cache but if we push all user customisation in 
cache, it could use too much memories only for the UI (if you have a lot 
of users).


Julien.

Le 07/04/2016 12:34, Pierre Smits a écrit :

Aren't user prefs cached somehow?

Pierre Smits

ORRTIZ.COM 
OFBiz based solutions & services

OFBiz Extensions Marketplace
http://oem.ofbizci.net/oci-2/

On Thu, Apr 7, 2016 at 11:35 AM, Julien NICOLAS 
wrote:


Hi all,

We are thinking on a new theme (again) that will be more user friendly and
UX oriented.
We want to be able to customize menu (component and its sub menu).

User pref could be the clue but we are not sure because if all menu and
sub menu (and maybe 3rd or 4th level menu) user preference are recorded in
the user pref, it could be a nightmare for the database access if there is
a lot of users. And only for user preference, it's not a good idea.
We also think about using cookies but it could be a problem if the user
user several computers.

What do you think ? Do you already try to develop this kind of feature ?

Thanks,

Julien.





Re: User pref or not user pref

2016-04-07 Thread Pierre Smits
Aren't user prefs cached somehow?

Pierre Smits

ORRTIZ.COM 
OFBiz based solutions & services

OFBiz Extensions Marketplace
http://oem.ofbizci.net/oci-2/

On Thu, Apr 7, 2016 at 11:35 AM, Julien NICOLAS 
wrote:

> Hi all,
>
> We are thinking on a new theme (again) that will be more user friendly and
> UX oriented.
> We want to be able to customize menu (component and its sub menu).
>
> User pref could be the clue but we are not sure because if all menu and
> sub menu (and maybe 3rd or 4th level menu) user preference are recorded in
> the user pref, it could be a nightmare for the database access if there is
> a lot of users. And only for user preference, it's not a good idea.
> We also think about using cookies but it could be a problem if the user
> user several computers.
>
> What do you think ? Do you already try to develop this kind of feature ?
>
> Thanks,
>
> Julien.
>


Re: Accessible Rich Internet Applications

2016-04-07 Thread james yong
Hi Pranay,

Are you referring to the management apps?

Regards,
James



Pranay Pandey-3 wrote
> Hello Devs,
> 
> We have got an opportunity to work on ARIA
> ;. Accessibility is the core of
> this
> delivery. Currently this project is under development.
> Just wanted to check-in here if someone is having experience building such
> applications top of OFBiz and would like to share their experiences and
> learnings.
> Do you think having one sample application OOTB following these guidelines
> will be a good addition?
> 
> Best regards,
> 
> Pranay Pandey
> HotWax Systems
> http://www.hotwaxsystems.com/





--
View this message in context: 
http://ofbiz.135035.n4.nabble.com/Accessible-Rich-Internet-Applications-tp4679037p4679050.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.


User pref or not user pref

2016-04-07 Thread Julien NICOLAS

Hi all,

We are thinking on a new theme (again) that will be more user friendly 
and UX oriented.

We want to be able to customize menu (component and its sub menu).

User pref could be the clue but we are not sure because if all menu and 
sub menu (and maybe 3rd or 4th level menu) user preference are recorded 
in the user pref, it could be a nightmare for the database access if 
there is a lot of users. And only for user preference, it's not a good idea.
We also think about using cookies but it could be a problem if the user 
user several computers.


What do you think ? Do you already try to develop this kind of feature ?

Thanks,

Julien.


[jira] [Updated] (OFBIZ-6705) some files set viewIndex to 1 by default rather than 0

2016-04-07 Thread Gareth Carter (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gareth Carter updated OFBIZ-6705:
-
Attachment: OFBIZ-6705.patch

patch with some javadoc

> some files set viewIndex to 1 by default rather than 0
> --
>
> Key: OFBIZ-6705
> URL: https://issues.apache.org/jira/browse/OFBIZ-6705
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Gareth Carter
>Priority: Minor
> Attachments: OFBIZ-6705.patch, OFBIZ-6705.patch, 
> OFBIZ-6705_sample.patch
>
>
> The following files set viewIndex to 1
> {noformat}
> ./applications/order/src/org/ofbiz/order/order/OrderLookupServices.java:  
>   if (viewIndex == null) viewIndex = 1;
> ./applications/order/webapp/ordermgr/entry/catalog/categorydetail.ftl:
> <#--assign viewIndex = viewIndex - 1/-->
> ./applications/order/webapp/ordermgr/WEB-INF/actions/order/FindOrders.groovy:viewIndex
>  = request.getParameter("viewIndex") ? 
> Integer.valueOf(request.getParameter("viewIndex")) : 1;
> ./applications/party/webapp/partymgr/WEB-INF/actions/communication/ListCommunications.groovy:context.viewIndex
>  = 1;
> ./applications/party/webapp/partymgr/WEB-INF/actions/visit/ShowVisits.groovy: 
>viewIndex = Integer.valueOf(parameters.VIEW_INDEX  ?: 1);
> ./specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/shoppinglist/EditShoppingList.groovy:
> viewIndex = Integer.valueOf(parameters.VIEW_INDEX  ?: 1);
> {noformat}
> I ran this command to get the output:
> grep -R --exclude-dir=.svn "viewIndex = " . | grep " 1"
> As far as I am aware, viewIndex starts from 0



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6986) Simplify getChildHRCategoryTree

2016-04-07 Thread Kulwant (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kulwant updated OFBIZ-6986:
---
Attachment: OFBIZ-6986.patch

> Simplify getChildHRCategoryTree
> ---
>
> Key: OFBIZ-6986
> URL: https://issues.apache.org/jira/browse/OFBIZ-6986
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, humanres
>Reporter: Kulwant
>Assignee: Pranay Pandey
> Attachments: OFBIZ-6986.patch, OFBIZ-6986.patch
>
>
> breaking the single long method to multiple private functions with improved 
> exception handling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Permission service not on the same transaction

2016-04-07 Thread Nicolas Malin

Hello,

Currently I continue the conversion on shipment  crud service and I 
detected that many service use the same mini-lang call to check if the 
shipment status is ok for editing "checkCanChangeShipmentStatusPacked"


I convert it on service to call it directly by the permission-service 
like that :


default-entity-name="ShipmentPackageContent" engine="entity-auto" 
invoke="create" auth="true">...
service-name="checkCanChangeShipmentStatusPacked" main-action="CREATE"/>

...


The problem with this change that when I run the unit tests, I have some 
failed to due database lock on shipment.
After some analyse I founded that the permission service wasn't call on 
the same service's transaction.

I a realize this change :

Index: framework/service/src/org/ofbiz/service/ModelService.java
===
--- framework/service/src/org/ofbiz/service/ModelService.java (révision 
1737860)
+++ framework/service/src/org/ofbiz/service/ModelService.java (copie de 
travail)

@@ -985,7 +985,7 @@
 LocalDispatcher dispatcher = dctx.getDispatcher();
 Map resp;
 try {
-resp = dispatcher.runSync(permission.name, ctx, 
300, true);

+resp = dispatcher.runSync(permission.name, ctx);
 } catch (GenericServiceException e) {
 Debug.logError(e, module);
 Map result = 
ServiceUtil.returnSuccess();


All unit test pass.
Anyone know the reason to call the permission service on a new transaction ?
I couldn't spot any valid reason.

Thnaks for help ;)

Nicolas

--
#jeSuisCharlie
logoNrd 
Nicolas Malin
Ingénieur d'étude. Dernier sujet : "Les vaches portant un prénom pouvent 
trouver la sortie d'un labyrinthe en cas de toxoplasmose

informat...@nereide.fr
8 rue des Déportés 37000 TOURS, 02 47 50 30 54

Apache OFBiz  | ofbiz-fr 
 | | réseau LE 


[jira] [Comment Edited] (OFBIZ-6776) Amount to capture for order is in-correct after manual refund electronic transaction

2016-04-07 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15229843#comment-15229843
 ] 

Jacques Le Roux edited comment on OFBIZ-6776 at 4/7/16 7:55 AM:


Hi Pranay, 

You said 
{quote}
I think only the remaining total should be captured.
{quote}
Could we not have an option in function of the reason of the refund?
I must say it's already a specific scenario, but we all know specific scenari 
happen in real life...


was (Author: jacques.le.roux):
Hi Pranay, 

You said 
{quote}
I think only the remaining total should be captured.
{quote}
Could we not have an option in function of the reason of the refund (could be 
an error in initial payment, etc.)?
I must say it's already a specific scenario, but we all know specific scenari 
happen in real life...

> Amount to capture for order is in-correct after manual refund electronic 
> transaction
> 
>
> Key: OFBIZ-6776
> URL: https://issues.apache.org/jira/browse/OFBIZ-6776
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting, order
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk
>Reporter: Nameet
>Assignee: Pranay Pandey
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-6776.patch, OFBIZ-6776.patch
>
>
> Steps to regenerate-
> 1) Place a sales order of Rainbow Gizmo. Order Total was of $29.91. Order 
> will be in approved status and in *Payment Information* section you will see 
> $29.91 as authorized and available to capture. 
> 2) Capture $15.00 by using the capture button available in *Payment 
> Information* block. System should successfully capture $15.00 and also new 
> authorized payment of $14.91 should be seen in Payment Information section.
> 3) Refund $5.00 by using manual electronic transfer UI in accounting. System 
> successfully does the refund.
> 4) Click quick ship entire order from order screen. As per payment 
> requirement, now system should proceed to complete the capture process for 
> amount $19.91($29.91 - $15(Captured) + $5(Refunded)) but it captures only 
> $9.91 and not showing any remaining amount to capture on order. Also the 
> order invoice due shows $0.00.
> Possible reason of the issue is that refunded payment amount is being 
> considered by the system as received payment and hence amount to capture on 
> order is calculated wrong.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6776) Amount to capture for order is in-correct after manual refund electronic transaction

2016-04-07 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15229843#comment-15229843
 ] 

Jacques Le Roux commented on OFBIZ-6776:


Hi Pranay, 

You said 
{quote}
I think only the remaining total should be captured.
{quote}
Could we not have an option in function of the reason of the refund (could be 
an error in initial payment, etc.)?
I must say it's already a specific scenario, but we all know specific scenari 
happen in real life...

> Amount to capture for order is in-correct after manual refund electronic 
> transaction
> 
>
> Key: OFBIZ-6776
> URL: https://issues.apache.org/jira/browse/OFBIZ-6776
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting, order
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk
>Reporter: Nameet
>Assignee: Pranay Pandey
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-6776.patch, OFBIZ-6776.patch
>
>
> Steps to regenerate-
> 1) Place a sales order of Rainbow Gizmo. Order Total was of $29.91. Order 
> will be in approved status and in *Payment Information* section you will see 
> $29.91 as authorized and available to capture. 
> 2) Capture $15.00 by using the capture button available in *Payment 
> Information* block. System should successfully capture $15.00 and also new 
> authorized payment of $14.91 should be seen in Payment Information section.
> 3) Refund $5.00 by using manual electronic transfer UI in accounting. System 
> successfully does the refund.
> 4) Click quick ship entire order from order screen. As per payment 
> requirement, now system should proceed to complete the capture process for 
> amount $19.91($29.91 - $15(Captured) + $5(Refunded)) but it captures only 
> $9.91 and not showing any remaining amount to capture on order. Also the 
> order invoice due shows $0.00.
> Possible reason of the issue is that refunded payment amount is being 
> considered by the system as received payment and hence amount to capture on 
> order is calculated wrong.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: svn commit: r1738056 - /ofbiz/trunk/applications/accounting/config/AccountingEntityLabels.xml

2016-04-07 Thread Nicolas Malin

Le 06/04/2016 23:23, jler...@apache.org a écrit :

A disbursment is not a débours but a décaissement
[french] ^^ ouais c'est vachement mieux car "Je vais te débourrer le 
paiement" ça fait très berrichon [/french]


Thanks Jacques !