[jira] [Created] (OFBIZ-7259) Hide associated content related section when creating new Product/Category content

[Ravi Lodhi (JIRA)]

Ravi Lodhi created OFBIZ-7259:
-

 Summary: Hide associated content related section when creating new 
Product/Category content
 Key: OFBIZ-7259
 URL: https://issues.apache.org/jira/browse/OFBIZ-7259
 Project: OFBiz
  Issue Type: Improvement
  Components: product
Affects Versions: Trunk
Reporter: Ravi Lodhi
Assignee: Ravi Lodhi


Area:
1) Go to Catalog -> Categories
2) Find a category and go to Content page.
3) Under "Add Product Category Content" section select a content type and go to 
create new content.
4) In this screen last two section are dependent on the first block. So if we 
are preparing new category content these section should of no use.

Page shouldn't display "Associated Content Infos" and "Create Simple Text 
Content For Alternate Locale" sections when creating new content. These section 
should come only when using this page for editing content.

Note: The same case when adding product content.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7213) Override allow-html attribute do not work in service implementing any interface

[Deepak Dixit (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321939#comment-15321939
 ] 

Deepak Dixit commented on OFBIZ-7213:
-

Not a problem Jacques, you can also commit :)

> Override allow-html attribute do not work in service implementing any 
> interface
> ---
>
> Key: OFBIZ-7213
> URL: https://issues.apache.org/jira/browse/OFBIZ-7213
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Nameet Jain
>Assignee: Deepak Dixit
>Priority: Critical
> Attachments: OFBIZ-7213.patch
>
>
> To test I used an interface say "testInterface". Try as shown below
> =Add test interface and service =
> {code}
> 
> 
> 
>  location="org.ofbiz.order.order.OrderServices" 
> invoke="checkAllowHtmlForOverride">
> 
> 
> 
> {code}
> ===
> Add service definition for the service "checkAllowHtmlForOverride"  in 
> "org.ofbiz.order.order.OrderServices". 
> {code}
> public static Map checkAllowHtmlForOverride(DispatchContext 
> dctx, Map context) {
> String testData = (String) context.get("testData");
> Debug.log("==" + testData);
> return ServiceUtil.returnSuccess();
> }
> {code}
> Run service "checkAllowHtmlForOverride" from service engine. 
> {code}
> *Exception :* 
>  [java] 2016-06-07 19:07:38,429 |http-nio-8443-exec-9 |ServiceDispatcher  
>|E| Incoming context (in runSync : checkAllowHtmlForOverride) does 
> not match expected requirements
>  [java] org.ofbiz.service.ServiceValidationException: In field [testData] 
> less-than (<) and greater-than (>) symbols are not allowed.
>  [java]   at 
> org.ofbiz.service.ModelService.validate(ModelService.java:597) 
> ~[ofbiz-service.jar:?]
>  [java]   at 
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:376) 
> [ofbiz-service.jar:?]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7258) Duplicate product feature groups associated with a category when duplicating category and selected option to duplicate feature

[Ravi Lodhi (JIRA)]

Ravi Lodhi created OFBIZ-7258:
-

 Summary: Duplicate product feature groups associated with a 
category when duplicating category and selected option to duplicate feature
 Key: OFBIZ-7258
 URL: https://issues.apache.org/jira/browse/OFBIZ-7258
 Project: OFBiz
  Issue Type: Improvement
  Components: product
Affects Versions: Trunk
Reporter: Ravi Lodhi
Assignee: Ravi Lodhi


Problem Area:
1) Go to Catalog -> Categories
2) Find a category for which feature groups and feature categories are added.
3) Duplicate that category and check the option to duplicate feature.
4) Right now only features from product feature categories get duplicated not 
the feature associated with feature group.

We should duplicate features from feature group as well when duplicating 
category.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7257) View Image button on order detail page is not working

[Avnindra Sharma (JIRA)]

Avnindra Sharma created OFBIZ-7257:
--

 Summary: View Image button on order detail page is not working
 Key: OFBIZ-7257
 URL: https://issues.apache.org/jira/browse/OFBIZ-7257
 Project: OFBiz
  Issue Type: Bug
  Components: order
Reporter: Avnindra Sharma


Item image is not getting open on clicking ViewImage on order detail page.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7256) After adding child categories user should remain on the same page

[Ravi Lodhi (JIRA)]

Ravi Lodhi created OFBIZ-7256:
-

 Summary: After adding child categories user should remain on the 
same page
 Key: OFBIZ-7256
 URL: https://issues.apache.org/jira/browse/OFBIZ-7256
 Project: OFBiz
  Issue Type: Improvement
  Components: product
Affects Versions: Trunk
Reporter: Ravi Lodhi
Assignee: Ravi Lodhi


Problem Area:
1) Go to Catalog -> Categories
2) Find any category and go to the rollup screen.
3) Add any child category rollup.
4) After adding child category rollup  user is redirected to the newly added 
child category and displayed rollup of that category.

This is the case with all the operation Add/Update/Delete. User should remain 
on the rollup page of the category for which adding child category like when 
performing Add/Update/Delete with parent category rollup.





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7108) Provide an option to specify the Facility Location while producing the inventory/stock once production run gets completed

[Anuj Jain (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321902#comment-15321902
 ] 

Anuj Jain commented on OFBIZ-7108:
--

Hello,

I have attached a patch which would add a field with the lookup for 
locationSeqId on 'Production Run Produce' form.
As in lookup user have options to set the locationSeqId of any facility for the 
manufactured product, Which is not quite correct. As user should only be able 
to assign locationSeqId to the product from the facility, where it is produced.

I have also made changes in the LooupFacilityLocation. If the form for the 
lookup has facilityId in the parameters, the user then not able to select the 
facility from the drop down,

> Provide an option to specify the Facility Location while producing the 
> inventory/stock once production run gets completed
> -
>
> Key: OFBIZ-7108
> URL: https://issues.apache.org/jira/browse/OFBIZ-7108
> Project: OFBiz
>  Issue Type: New Feature
>Reporter: Swapnil Shah
> Attachments: OFBIZ-7108.patch, ProduceStock.png
>
>
> Currently there is no option to specify where the produced inventory against 
> finished good would be stocked in the facility. 
> Let's try to add the option to select and specify the facility location under 
> 'Production Run Produce' or 'Production Run Declare and Produce' section. 
> Once user submit the quantity and location same should be set over produced 
> InventoryItem.locationSeqId
> Please refer the attached screenshot for reference



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7108) Provide an option to specify the Facility Location while producing the inventory/stock once production run gets completed

[Anuj Jain (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anuj Jain updated OFBIZ-7108:
-
Attachment: OFBIZ-7108.patch

> Provide an option to specify the Facility Location while producing the 
> inventory/stock once production run gets completed
> -
>
> Key: OFBIZ-7108
> URL: https://issues.apache.org/jira/browse/OFBIZ-7108
> Project: OFBiz
>  Issue Type: New Feature
>Reporter: Swapnil Shah
> Attachments: OFBIZ-7108.patch, ProduceStock.png
>
>
> Currently there is no option to specify where the produced inventory against 
> finished good would be stocked in the facility. 
> Let's try to add the option to select and specify the facility location under 
> 'Production Run Produce' or 'Production Run Declare and Produce' section. 
> Once user submit the quantity and location same should be set over produced 
> InventoryItem.locationSeqId
> Please refer the attached screenshot for reference



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7251) Update Payment Gateway Config data for Payment Gateway Authorize.net

[Avnindra Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Avnindra Sharma updated OFBIZ-7251:
---
Attachment: OFBIZ-7251.patch

> Update Payment Gateway Config data for Payment Gateway Authorize.net 
> -
>
> Key: OFBIZ-7251
> URL: https://issues.apache.org/jira/browse/OFBIZ-7251
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Reporter: Avnindra Sharma
>Priority: Minor
> Attachments: OFBIZ-7251.patch
>
>
> As per the https://community.developer.authorize.net, the transactionUrl has 
> been updated from https://certification.authorize.net/gateway/transact.dll to 
> https://test.authorize.net/gateway/transact.dll



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7252) Error adding task to backlog

[Pritam Kute (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pritam Kute reassigned OFBIZ-7252:
--

Assignee: Pritam Kute

> Error adding task to backlog
> 
>
> Key: OFBIZ-7252
> URL: https://issues.apache.org/jira/browse/OFBIZ-7252
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/scrum
>Affects Versions: Trunk
>Reporter: Montalbano Florian
>Assignee: Pritam Kute
>  Labels: error, form, scrum, sprint, task
>
> There are several problems in the form to add a new task in a backlog. Step 
> to reproduce :
> - Go to the Scrum component and select a product sprint 
> (https://localhost:8443/scrum/control/ViewSprint?sprintId=DEMO-SPRINT-1=DEMO-PROJECT-1)
> - Scroll down to the Sprint Backlog List
> - Click on a button "Add Task"
> - See the error in the console.
> From there, it's not possible to create a new task. When clicking on the 
> create button, there is an error and the target is 
> "https://localhost:8443/scrum/control/updateSprintTask; where it should be 
> "https://localhost:8443/scrum/control/createSprintBacklogTask;. 
> I tried to solve the problem but it's beyond me. The form causing the problem 
> is scrumForms.xml#NewTaskForSprintBacklog and it extends the form 
> TaskForms.xml#EditSprintTask .
> Thanks,
> Florian



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7255) Not able to cancel quantity of order item less than ordered quantity

[Mohammad Kathawala (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mohammad Kathawala updated OFBIZ-7255:
--
Attachment: Screenshot3.png
Screenshot2.png
Screenshot1.png

> Not able to cancel quantity of order item less than ordered quantity
> 
>
> Key: OFBIZ-7255
> URL: https://issues.apache.org/jira/browse/OFBIZ-7255
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Reporter: Mohammad Kathawala
> Attachments: Screenshot1.png, Screenshot2.png, Screenshot3.png
>
>
> Steps to generate:
> 1) Create a sales order with item quantity more than 1. Lets suppose 3.
> 2) Go to order overview page and click on 'Edit Items'.
> 3) Try to cancel the item with quantity less than 3. Lets suppose 2.
> Expected result:
> Item's 2 quantity should be cancelled.
> Actual result:
> All 3 quantity gets cancelled.
> See attached screenshots for more info.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7255) Not able to cancel quantity of order item less than ordered quantity

[Mohammad Kathawala (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mohammad Kathawala updated OFBIZ-7255:
--
Description: 
Steps to generate:

1) Create a sales order with item quantity more than 1. Lets suppose 3.
2) Go to order overview page and click on 'Edit Items'.
3) Try to cancel the item with quantity less than 3. Lets suppose 2.

Expected result:
Item's 2 quantity should be cancelled.
Actual result:
All 3 quantity gets cancelled.

See attached screenshots for more info.

  was:
Steps to generate:

1) Create a sales order with item quantity more than 1. Lets suppose 3.
2) Go to order overview page and click on 'Edit Items'.
3) Try to cancel the item with quantity less than 3. Lets suppose 2.

Expected result:
Item's 2 quantity should be cancelled.
Actual result:
All 3 quantity gets cancelled.


> Not able to cancel quantity of order item less than ordered quantity
> 
>
> Key: OFBIZ-7255
> URL: https://issues.apache.org/jira/browse/OFBIZ-7255
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Reporter: Mohammad Kathawala
> Attachments: Screenshot1.png, Screenshot2.png, Screenshot3.png
>
>
> Steps to generate:
> 1) Create a sales order with item quantity more than 1. Lets suppose 3.
> 2) Go to order overview page and click on 'Edit Items'.
> 3) Try to cancel the item with quantity less than 3. Lets suppose 2.
> Expected result:
> Item's 2 quantity should be cancelled.
> Actual result:
> All 3 quantity gets cancelled.
> See attached screenshots for more info.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7255) Not able to cancel quantity of order item less than ordered quantity

[Mohammad Kathawala (JIRA)]

Mohammad Kathawala created OFBIZ-7255:
-

 Summary: Not able to cancel quantity of order item less than 
ordered quantity
 Key: OFBIZ-7255
 URL: https://issues.apache.org/jira/browse/OFBIZ-7255
 Project: OFBiz
  Issue Type: Bug
  Components: order
Reporter: Mohammad Kathawala


Steps to generate:

1) Create a sales order with item quantity more than 1. Lets suppose 3.
2) Go to order overview page and click on 'Edit Items'.
3) Try to cancel the item with quantity less than 3. Lets suppose 2.

Expected result:
Item's 2 quantity should be cancelled.
Actual result:
All 3 quantity gets cancelled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7205) Create party resume not working. ResumeId doesn't have text field to enter

[Gil Portenseigne (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321610#comment-15321610
 ] 

Gil Portenseigne commented on OFBIZ-7205:
-

Thank you for your detailed answer. The fix i just commit did fix the 
functionnality in both component.

>From my point of view, partymgr application is a global component about 
>managing general party data out of a particular process, as an integrator, it 
>can be used for data maintenance, and to build its own component using the 
>screens/forms/services/etc. of the partymgr application. So i see no problem 
>having the functionnality in it.

> Create party resume not working. ResumeId doesn't have text field to enter
> --
>
> Key: OFBIZ-7205
> URL: https://issues.apache.org/jira/browse/OFBIZ-7205
> Project: OFBiz
>  Issue Type: Bug
>  Components: humanres, party
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Amardeep Singh Jhajj
>Assignee: Gil Portenseigne
> Fix For: 14.12.01, 15.12.01, 13.07.04
>
> Attachments: OFBIZ-7205-Screen-Shot.png, OFBIZ-7205.patch
>
>
> Please refer attached screenshot.
> Steps to regenerate:
> 1. Go to 
> https://localhost:8443/partymgr/control/EditPartyResumes?partyId=admin.
> 2. Create Resume form does not have ResumeId text field. Cannot add resume to 
> party from here.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7205) Create party resume not working. ResumeId doesn't have text field to enter

[Gil Portenseigne (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gil Portenseigne closed OFBIZ-7205.
---

> Create party resume not working. ResumeId doesn't have text field to enter
> --
>
> Key: OFBIZ-7205
> URL: https://issues.apache.org/jira/browse/OFBIZ-7205
> Project: OFBiz
>  Issue Type: Bug
>  Components: humanres, party
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Amardeep Singh Jhajj
>Assignee: Gil Portenseigne
> Fix For: 14.12.01, 15.12.01, 13.07.04
>
> Attachments: OFBIZ-7205-Screen-Shot.png, OFBIZ-7205.patch
>
>
> Please refer attached screenshot.
> Steps to regenerate:
> 1. Go to 
> https://localhost:8443/partymgr/control/EditPartyResumes?partyId=admin.
> 2. Create Resume form does not have ResumeId text field. Cannot add resume to 
> party from here.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-7205) Create party resume not working. ResumeId doesn't have text field to enter

[Gil Portenseigne (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321579#comment-15321579
 ] 

Gil Portenseigne edited comment on OFBIZ-7205 at 6/8/16 10:41 PM:
--

There was a bit more than the missing field, in this patch i fixed :
- Fix the partyResume entity-one for EditPartyResumes screen
- Fix use-when condition on partyId and submit fields in EditPartyResume form
- Fix the edit and delete link to allow modification and refresh with partyId 
in context.




was (Author: gil portenseigne):
There was a bit more than the missing field, in this patch i fixed :
- the partyResume entity-one 
- use-when condition on partyId field
- use-when condition on submit button (for the label)
- delete link to refresh with partyId in context.



> Create party resume not working. ResumeId doesn't have text field to enter
> --
>
> Key: OFBIZ-7205
> URL: https://issues.apache.org/jira/browse/OFBIZ-7205
> Project: OFBiz
>  Issue Type: Bug
>  Components: humanres, party
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Amardeep Singh Jhajj
>Assignee: Gil Portenseigne
> Attachments: OFBIZ-7205-Screen-Shot.png, OFBIZ-7205.patch
>
>
> Please refer attached screenshot.
> Steps to regenerate:
> 1. Go to 
> https://localhost:8443/partymgr/control/EditPartyResumes?partyId=admin.
> 2. Create Resume form does not have ResumeId text field. Cannot add resume to 
> party from here.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7205) Create party resume not working. ResumeId doesn't have text field to enter

[Gil Portenseigne (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gil Portenseigne updated OFBIZ-7205:

Component/s: humanres

> Create party resume not working. ResumeId doesn't have text field to enter
> --
>
> Key: OFBIZ-7205
> URL: https://issues.apache.org/jira/browse/OFBIZ-7205
> Project: OFBiz
>  Issue Type: Bug
>  Components: humanres, party
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Amardeep Singh Jhajj
>Assignee: Gil Portenseigne
> Attachments: OFBIZ-7205-Screen-Shot.png, OFBIZ-7205.patch
>
>
> Please refer attached screenshot.
> Steps to regenerate:
> 1. Go to 
> https://localhost:8443/partymgr/control/EditPartyResumes?partyId=admin.
> 2. Create Resume form does not have ResumeId text field. Cannot add resume to 
> party from here.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7205) Create party resume not working. ResumeId doesn't have text field to enter

[Gil Portenseigne (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gil Portenseigne updated OFBIZ-7205:

Attachment: OFBIZ-7205.patch

There was a bit more than the missing field, in this patch i fixed :
- the partyResume entity-one 
- use-when condition on partyId field
- use-when condition on submit button (for the label)
- delete link to refresh with partyId in context.



> Create party resume not working. ResumeId doesn't have text field to enter
> --
>
> Key: OFBIZ-7205
> URL: https://issues.apache.org/jira/browse/OFBIZ-7205
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Amardeep Singh Jhajj
>Assignee: Gil Portenseigne
> Attachments: OFBIZ-7205-Screen-Shot.png, OFBIZ-7205.patch
>
>
> Please refer attached screenshot.
> Steps to regenerate:
> 1. Go to 
> https://localhost:8443/partymgr/control/EditPartyResumes?partyId=admin.
> 2. Create Resume form does not have ResumeId text field. Cannot add resume to 
> party from here.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7205) Create party resume not working. ResumeId doesn't have text field to enter

[Pierre Smits (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321570#comment-15321570
 ] 

Pierre Smits commented on OFBIZ-7205:
-

Thank you for your remark and  questions, Gil.

Functions of an HR department are more than just managing the particulars of 
only employees. This department is often also tasked with on-boarding and 
off-boarding of temporary additions to the workforce (temps and other kinds of 
contractors) and the department is also there (in combo with accounting) to 
ensure that external criteria are met (e.g. fiscal and social services 
aspects). A human res solution should reflect that. 

Over the years the partymgr application has become the catch-all of all kinds 
of data management and overview (this aspect, financial overviews, etc) 
functions related to parties, due to not thinking thinking through the 
scenarios such functionality should go in. And applications shoulld be lean and 
mean.  That decreases complexity, increases applicability and supports adoption 
growth. 

Now who do you envision to have access to the partymgr applicaion and see all 
this kind of information? The permissions are not that granular at the moment 
and thus the application seems to have a high level of demonstration purposes 
than actually delivering on specific business cases. In real life, a business 
would determine up front who in what capacitiy has access to such data (and 
when and how may execute CRUD functions). We should consider this strongly 
before committing any enhancement (whether it is a bug fix or improvement).

Fixing an inappropriate piece of functionality doesn't make it less 
inappropriate.



> Create party resume not working. ResumeId doesn't have text field to enter
> --
>
> Key: OFBIZ-7205
> URL: https://issues.apache.org/jira/browse/OFBIZ-7205
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Amardeep Singh Jhajj
>Assignee: Gil Portenseigne
> Attachments: OFBIZ-7205-Screen-Shot.png
>
>
> Please refer attached screenshot.
> Steps to regenerate:
> 1. Go to 
> https://localhost:8443/partymgr/control/EditPartyResumes?partyId=admin.
> 2. Create Resume form does not have ResumeId text field. Cannot add resume to 
> party from here.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7205) Create party resume not working. ResumeId doesn't have text field to enter

[Gil Portenseigne (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gil Portenseigne reassigned OFBIZ-7205:
---

Assignee: Gil Portenseigne  (was: Amardeep Singh Jhajj)

> Create party resume not working. ResumeId doesn't have text field to enter
> --
>
> Key: OFBIZ-7205
> URL: https://issues.apache.org/jira/browse/OFBIZ-7205
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Amardeep Singh Jhajj
>Assignee: Gil Portenseigne
> Attachments: OFBIZ-7205-Screen-Shot.png
>
>
> Please refer attached screenshot.
> Steps to regenerate:
> 1. Go to 
> https://localhost:8443/partymgr/control/EditPartyResumes?partyId=admin.
> 2. Create Resume form does not have ResumeId text field. Cannot add resume to 
> party from here.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7135) Adding role for a party show error on the second add

[Nicolas Malin (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin reassigned OFBIZ-7135:


Assignee: Nicolas Malin

> Adding role for a party show error on the second add
> 
>
> Key: OFBIZ-7135
> URL: https://issues.apache.org/jira/browse/OFBIZ-7135
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk
>Reporter: Montalbano Florian
>Assignee: Nicolas Malin
>Priority: Minor
>  Labels: addrole, party
> Attachments: OFBIZ-7135.patch
>
>
> Hi all,
> How to reproduce :
> 1) Go to the profile of a party and then to the "Role" tab : 
> https://localhost:8443/partymgr/control/viewroles?partyId=admin
> 2) Add any role
> 3) Wait for the page to reload
> 4) Try to add another role
> 5) Notice the error showing up and the redirection to the "profile" page
> Problem : The problem comes from a bad request send. When you select a "main 
> role" (without clicking on the add button), a request is send to get the form 
> for the "secondary role". On the first time, there is no problem, the request 
> is something such as : 
> https://localhost:8443/partymgr/control/addsecondaryroles
> On the second time, it becomes something like this : 
> https://localhost:8443/partymgr/control/addrole/addsecondaryroles
> When the controller receives this second request, it does both the "addrole" 
> and the "addsecondaryroles" request. So when you chose a role in the first 
> select, it actually sends a request to add the role before you even click on 
> the "add" button.
> Root of the problem :
> First, the target of the forms (PartyForms#AddPartyRole, 
> PartyForms#AddPartyMainRole and PartyForms#AddPartySecondaryRole) adding the 
> "main" and "secondary" roles is "addrole/viewroles" (it seems to be the only 
> place in the code where a target is done this way). To clear up the request, 
> I tried to remove the "/viewroles" to match what is done in another case : 
> when a task is added to a project.
> It seems to work but I want to know what is your point of view on this.
> Then, in the controller, there is a weird redirection to "viewprofile" 
> instead of allowing the user to stay on "viewroles". All of this seems 
> related to an update of the coding way in the project that didn't affect this 
> part yet.
> I'll provide a patch that seems to work.
> Thanks,
> Florian



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7249) Error on removing scrum members

[Nicolas Malin (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321478#comment-15321478
 ] 

Nicolas Malin commented on OFBIZ-7249:
--

Hi Anurag, 

Yes it's not the good solution to delete ProductRole, but don't worries because 
the function deleteScrumResource hurt my eyes.

A PartyRole would be never remove if it's use on the system because you loose 
the historicist. So If you want correct this : Check when the role is use and 
expire the relation.

If you check the function end 
{code}
 









{code}
It's also not correct, why init nowtimestamp to didn't use and delete 
userLoginSecurityGroup instead of expire it ?

:) so the best solution is more complicated than delete each data  

> Error on removing scrum members
> ---
>
> Key: OFBIZ-7249
> URL: https://issues.apache.org/jira/browse/OFBIZ-7249
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/scrum
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Anurag Chandak
>Assignee: Anurag Chandak
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7249.patch
>
>
> Steps to regenerate:
> - Go to Scrum --> Administration --> Scrum Members
> - Try to remove only those scrum members whose party and role type are 
> similar to product members
> - The following error is shown:
> {code}
> The Following Errors Occurred:
> Error:Error doing entity-auto operation for entity PartyRole in service 
> deletePartyRole: org.ofbiz.entity.GenericEntityException: 
> org.ofbiz.entity.GenericDataSourceException: Exception while deleting the 
> following entity: 
> [GenericEntity:PartyRole][partyId,SCRUMASTER(java.lang.String)][roleTypeId,SCRUM_MASTER(java.lang.String)]
>  (SQL Exception while executing the following:DELETE FROM OFBIZ.PARTY_ROLE 
> WHERE PARTY_ID=? AND ROLE_TYPE_ID=? (DELETE on table 'PARTY_ROLE' caused a 
> violation of foreign key constraint 'PROD_RLE_PTYRLE' for key 
> (SCRUMASTER,SCRUM_MASTER). The statement has been rolled back.)) (Exception 
> while deleting the following entity: 
> [GenericEntity:PartyRole][partyId,SCRUMASTER(java.lang.String)][roleTypeId,SCRUM_MASTER(java.lang.String)]
>  (SQL Exception while executing the following:DELETE FROM OFBIZ.PARTY_ROLE 
> WHERE PARTY_ID=? AND ROLE_TYPE_ID=? (DELETE on table 'PARTY_ROLE' caused a 
> violation of foreign key constraint 'PROD_RLE_PTYRLE' for key 
> (SCRUMASTER,SCRUM_MASTER). The statement has been rolled back.)))
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7155) Remove jce-jdk13-154.jar

[Nicolas Malin (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321442#comment-15321442
 ] 

Nicolas Malin commented on OFBIZ-7155:
--

No objection, you can remove Christian :)

> Remove jce-jdk13-154.jar
> 
>
> Key: OFBIZ-7155
> URL: https://issues.apache.org/jira/browse/OFBIZ-7155
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk, Release Branch 15.12
>Reporter: Christian Geisert
>Assignee: Christian Geisert
> Fix For: Upcoming Branch, 15.12.01
>
>
> After updating our project to the latest release15.12 branch we got the 
> following error when accessing OFBiz pages:
> {code}
> 2016-06-01 14:37:14,040 |http-nio-8443-exec-2 |NioEndpoint   
> |E|
> java.lang.RuntimeException: Could not generate DH keypair
> at sun.security.ssl.Handshaker.checkThrown(Handshaker.java:1429) 
> ~[?:1.8.0_77]
> ...
> Caused by: java.security.InvalidAlgorithmParameterException: parameter object 
> not a ECParameterSpec
> at 
> org.bouncycastle.jcajce.provider.asymmetric.ec.KeyPairGeneratorSpi$EC.initialize(Unknown
>  Source) ~[jce-jdk13-154.jar:1.54.0]
> ...
> {code}
> It turned out that jce-jdk13-154.jar was the culprit. After removing this Jar 
> everything worked as expected. As this jar is an optional dependency of 
> PDFBox (which is used by Tika) and is only need for Java < 1.7 I propose to 
> remove it from OFBiz.
> I'll wait a few days and if there are no objections I'll remove the jar



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7247) Humanres : Arrange UI Labels in alphabetic order according to best practice

[Nicolas Malin (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin closed OFBIZ-7247.

Resolution: Fixed
  Assignee: Nicolas Malin

It's done on trunk at revision 1747453, thanks Shivangi Tanwar

> Humanres : Arrange UI Labels in alphabetic order according to best practice
> ---
>
> Key: OFBIZ-7247
> URL: https://issues.apache.org/jira/browse/OFBIZ-7247
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: humanres
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7247_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-7248) Improve the layout of PDF documents

[Nicolas Malin (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321416#comment-15321416
 ] 

Nicolas Malin edited comment on OFBIZ-7248 at 6/8/16 8:48 PM:
--

I have a proposal :) , for many case :

# Generic Document, quick configure for a project : 
** Define a generic decorator on common oriented to rendering xsl-fo standard 
page.
** This Decorator would be use directly on application component to rendering 
document or surcharge on hot-deploy to extend for each project
** easy to realize and homogenise all document and code
# Configure Document for each party
** The document rendering through content system
** Define a partyContentTypeId for each document type
** When you render a document, you check if the party on relation (on most of 
case the defaultOrganizationPartyId) have a partyContent on this type and call 
the content rendering
** This support multi-tenant, multi organization on same instance, support 
different technology

For each document call, we use a Worker to resolve the method to render (by 
screen and what screen or by content)

I hope that would be helpfully for this issue


was (Author: soledad):
I have a proposal :) , for many case :

1. Generic Document, quick configure for a project : 
   * Define a generic decorator on common oriented to rendering xsl-fo standard 
page.
   * This Decorator would be use directly on application component to rendering 
document or surcharge on hot-deploy to extend for each project
   * easy to realize and homogenise all document and code
2. Configure Document for each party
   * The document rendering through content system
   * Define a partyContentTypeId for each document type
   * When you render a document, you check if the party on relation (on most of 
case the defaultOrganizationPartyId) have a partyContent on this type and call 
the content rendering
   * This support multi-tenant, multi organization on same instance, support 
different technology

For each document call, we use a Worker to resolve the method to render (by 
screen and what screen or by content)

I hope that would be helpfully for this issue

> Improve the layout of PDF documents
> ---
>
> Key: OFBIZ-7248
> URL: https://issues.apache.org/jira/browse/OFBIZ-7248
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Mohammad Kathawala
> Fix For: Trunk
>
>
> The layout of all the PDF documents in OFBiz like Order, Invoice, Picklist, 
> Shipment etc. does not look very good and is not very readable for end users. 
> We need to have a properly structured PDF documents which is easy to read.
> I am going  to create sub-tasks of this parent task for all the different 
> objects.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7248) Improve the layout of PDF documents

[Nicolas Malin (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321416#comment-15321416
 ] 

Nicolas Malin commented on OFBIZ-7248:
--

I have a proposal :) , for many case :

1. Generic Document, quick configure for a project : 
   * Define a generic decorator on common oriented to rendering xsl-fo standard 
page.
   * This Decorator would be use directly on application component to rendering 
document or surcharge on hot-deploy to extend for each project
   * easy to realize and homogenise all document and code
2. Configure Document for each party
   * The document rendering through content system
   * Define a partyContentTypeId for each document type
   * When you render a document, you check if the party on relation (on most of 
case the defaultOrganizationPartyId) have a partyContent on this type and call 
the content rendering
   * This support multi-tenant, multi organization on same instance, support 
different technology

For each document call, we use a Worker to resolve the method to render (by 
screen and what screen or by content)

I hope that would be helpfully for this issue

> Improve the layout of PDF documents
> ---
>
> Key: OFBIZ-7248
> URL: https://issues.apache.org/jira/browse/OFBIZ-7248
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Mohammad Kathawala
> Fix For: Trunk
>
>
> The layout of all the PDF documents in OFBiz like Order, Invoice, Picklist, 
> Shipment etc. does not look very good and is not very readable for end users. 
> We need to have a properly structured PDF documents which is easy to read.
> I am going  to create sub-tasks of this parent task for all the different 
> objects.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-382) Implement Party lookup by External Id

[Nicolas Malin (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321361#comment-15321361
 ] 

Nicolas Malin commented on OFBIZ-382:
-

Hello, I don't understand the interest to use an externalId on party while we 
have a partyIdentification entity. 

I think it would be better to use PartyIdentification like GoodIdentification 
from Product to extend the search on external ofbiz id.

[my life] I never realize a project without 3 or 4 different external party 
identification[/my life] so when I see this issue, it's a little bit light on 
comparison with the existing ;)

> Implement Party lookup by External Id
> -
>
> Key: OFBIZ-382
> URL: https://issues.apache.org/jira/browse/OFBIZ-382
> Project: OFBiz
>  Issue Type: New Feature
>  Components: party
>Reporter: John Martin
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-382.patch, OFBIZ-382_new.patch
>
>
> It would be helpful for anyone whom is integrating ofBiz with an external 
> application to be able to expose the externalId property in the Party entity. 
>  
> The tasks to complete include:
> - Update the findparty.ftl to include the prompt/form input field for the 
> external id
> - Update the PartyServices.findParty() method to include the logic to handle 
> the externalId argument
> - Add new method getPartyFromExternalId to PartyServices
> - Add getPartyFromExternalId service definition in Party 
> servicedef/services_view.xml
> - Add misc local strings to UI label resource file
> Need to determine if the External Id: input form field should be 
> configuarable so that it only appears if feature is enabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7205) Create party resume not working. ResumeId doesn't have text field to enter

[Jacques Le Roux (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321054#comment-15321054
 ] 

Jacques Le Roux commented on OFBIZ-7205:


That makes sense to me Gil, and with Forian's fix (did not test) it seems we 
have a solution (a patch would be welcome).

> Create party resume not working. ResumeId doesn't have text field to enter
> --
>
> Key: OFBIZ-7205
> URL: https://issues.apache.org/jira/browse/OFBIZ-7205
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Amardeep Singh Jhajj
>Assignee: Amardeep Singh Jhajj
> Attachments: OFBIZ-7205-Screen-Shot.png
>
>
> Please refer attached screenshot.
> Steps to regenerate:
> 1. Go to 
> https://localhost:8443/partymgr/control/EditPartyResumes?partyId=admin.
> 2. Create Resume form does not have ResumeId text field. Cannot add resume to 
> party from here.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7187) Comment added while adding products to cart are not editable at cart item level

[Mohammad Kathawala (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mohammad Kathawala updated OFBIZ-7187:
--
Attachment: OFBIZ-7187.patch

Added patch for the improvement.

In patch, added text field for item comment in cart item. Added support in 
modifyCart to update the item comment. Comment will be updated on Recalculate 
Order for selected item.

> Comment added while adding products to cart are not editable at cart item 
> level
> ---
>
> Key: OFBIZ-7187
> URL: https://issues.apache.org/jira/browse/OFBIZ-7187
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Swapnil Shah
>Assignee: Divesh Dutta
> Attachments: OFBIZ-7187.patch, PO_comment.png
>
>
> The comments added while adding any product to cart are not editable at cart 
> item level. We could try allowing user to update them and eventually transfer 
> them at order item level.
> Please refer to attached screenshot.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7213) Override allow-html attribute do not work in service implementing any interface

[Jacques Le Roux (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-7213:
--

Assignee: Deepak Dixit  (was: Jacques Le Roux)

Ha sorry Deepak, I did not refresh in browser and did not see you assigned 
yourself, I reassign you.

> Override allow-html attribute do not work in service implementing any 
> interface
> ---
>
> Key: OFBIZ-7213
> URL: https://issues.apache.org/jira/browse/OFBIZ-7213
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Nameet Jain
>Assignee: Deepak Dixit
>Priority: Critical
> Attachments: OFBIZ-7213.patch
>
>
> To test I used an interface say "testInterface". Try as shown below
> =Add test interface and service =
> {code}
> 
> 
> 
>  location="org.ofbiz.order.order.OrderServices" 
> invoke="checkAllowHtmlForOverride">
> 
> 
> 
> {code}
> ===
> Add service definition for the service "checkAllowHtmlForOverride"  in 
> "org.ofbiz.order.order.OrderServices". 
> {code}
> public static Map checkAllowHtmlForOverride(DispatchContext 
> dctx, Map context) {
> String testData = (String) context.get("testData");
> Debug.log("==" + testData);
> return ServiceUtil.returnSuccess();
> }
> {code}
> Run service "checkAllowHtmlForOverride" from service engine. 
> {code}
> *Exception :* 
>  [java] 2016-06-07 19:07:38,429 |http-nio-8443-exec-9 |ServiceDispatcher  
>|E| Incoming context (in runSync : checkAllowHtmlForOverride) does 
> not match expected requirements
>  [java] org.ofbiz.service.ServiceValidationException: In field [testData] 
> less-than (<) and greater-than (>) symbols are not allowed.
>  [java]   at 
> org.ofbiz.service.ModelService.validate(ModelService.java:597) 
> ~[ofbiz-service.jar:?]
>  [java]   at 
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:376) 
> [ofbiz-service.jar:?]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7213) Override allow-html attribute do not work in service implementing any interface

[Jacques Le Roux (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-7213:
---
Description: 
To test I used an interface say "testInterface". Try as shown below

=Add test interface and service =
{code}








{code}
===

Add service definition for the service "checkAllowHtmlForOverride"  in 
"org.ofbiz.order.order.OrderServices". 
{code}
public static Map checkAllowHtmlForOverride(DispatchContext 
dctx, Map context) {
String testData = (String) context.get("testData");
Debug.log("==" + testData);
return ServiceUtil.returnSuccess();
}
{code}

Run service "checkAllowHtmlForOverride" from service engine. 
{code}
*Exception :* 

 [java] 2016-06-07 19:07:38,429 |http-nio-8443-exec-9 |ServiceDispatcher
 |E| Incoming context (in runSync : checkAllowHtmlForOverride) does not 
match expected requirements
 [java] org.ofbiz.service.ServiceValidationException: In field [testData] 
less-than (<) and greater-than (>) symbols are not allowed.
 [java] at 
org.ofbiz.service.ModelService.validate(ModelService.java:597) 
~[ofbiz-service.jar:?]
 [java] at 
org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:376) 
[ofbiz-service.jar:?]
{code}

  was:
To test I used an interface say "testInterface". Try as shown below

=Add test interface and service =









===

Add service definition for the service "checkAllowHtmlForOverride"  in 
"org.ofbiz.order.order.OrderServices". 

public static Map checkAllowHtmlForOverride(DispatchContext 
dctx, Map context) {
String testData = (String) context.get("testData");
Debug.log("==" + testData);
return ServiceUtil.returnSuccess();
}


Run service "checkAllowHtmlForOverride" from service engine. 

*Exception :* 

 [java] 2016-06-07 19:07:38,429 |http-nio-8443-exec-9 |ServiceDispatcher
 |E| Incoming context (in runSync : checkAllowHtmlForOverride) does not 
match expected requirements
 [java] org.ofbiz.service.ServiceValidationException: In field [testData] 
less-than (<) and greater-than (>) symbols are not allowed.
 [java] at 
org.ofbiz.service.ModelService.validate(ModelService.java:597) 
~[ofbiz-service.jar:?]
 [java] at 
org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:376) 
[ofbiz-service.jar:?]



> Override allow-html attribute do not work in service implementing any 
> interface
> ---
>
> Key: OFBIZ-7213
> URL: https://issues.apache.org/jira/browse/OFBIZ-7213
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Nameet Jain
>Assignee: Jacques Le Roux
>Priority: Critical
> Attachments: OFBIZ-7213.patch
>
>
> To test I used an interface say "testInterface". Try as shown below
> =Add test interface and service =
> {code}
> 
> 
> 
>  location="org.ofbiz.order.order.OrderServices" 
> invoke="checkAllowHtmlForOverride">
> 
> 
> 
> {code}
> ===
> Add service definition for the service "checkAllowHtmlForOverride"  in 
> "org.ofbiz.order.order.OrderServices". 
> {code}
> public static Map checkAllowHtmlForOverride(DispatchContext 
> dctx, Map context) {
> String testData = (String) context.get("testData");
> Debug.log("==" + testData);
> return ServiceUtil.returnSuccess();
> }
> {code}
> Run service "checkAllowHtmlForOverride" from service engine. 
> {code}
> *Exception :* 
>  [java] 2016-06-07 19:07:38,429 |http-nio-8443-exec-9 |ServiceDispatcher  
>|E| Incoming context (in runSync : checkAllowHtmlForOverride) does 
> not match expected requirements
>  [java] org.ofbiz.service.ServiceValidationException: In field [testData] 
> less-than (<) and greater-than (>) symbols are not allowed.
>  [java]   at 
> org.ofbiz.service.ModelService.validate(ModelService.java:597) 
> ~[ofbiz-service.jar:?]
>  [java]   at 
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:376) 
> [ofbiz-service.jar:?]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7213) Override allow-html attribute do not work in service implementing any interface

[Jacques Le Roux (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-7213:
--

Assignee: Jacques Le Roux  (was: Deepak Dixit)

> Override allow-html attribute do not work in service implementing any 
> interface
> ---
>
> Key: OFBIZ-7213
> URL: https://issues.apache.org/jira/browse/OFBIZ-7213
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Nameet Jain
>Assignee: Jacques Le Roux
>Priority: Critical
> Attachments: OFBIZ-7213.patch
>
>
> To test I used an interface say "testInterface". Try as shown below
> =Add test interface and service =
> 
> 
> 
>  location="org.ofbiz.order.order.OrderServices" 
> invoke="checkAllowHtmlForOverride">
> 
> 
> 
> ===
> Add service definition for the service "checkAllowHtmlForOverride"  in 
> "org.ofbiz.order.order.OrderServices". 
> public static Map checkAllowHtmlForOverride(DispatchContext 
> dctx, Map context) {
> String testData = (String) context.get("testData");
> Debug.log("==" + testData);
> return ServiceUtil.returnSuccess();
> }
> Run service "checkAllowHtmlForOverride" from service engine. 
> *Exception :* 
>  [java] 2016-06-07 19:07:38,429 |http-nio-8443-exec-9 |ServiceDispatcher  
>|E| Incoming context (in runSync : checkAllowHtmlForOverride) does 
> not match expected requirements
>  [java] org.ofbiz.service.ServiceValidationException: In field [testData] 
> less-than (<) and greater-than (>) symbols are not allowed.
>  [java]   at 
> org.ofbiz.service.ModelService.validate(ModelService.java:597) 
> ~[ofbiz-service.jar:?]
>  [java]   at 
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:376) 
> [ofbiz-service.jar:?]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7011) Failure in Payment Capture process when ERROR is returned in referenceNum in paymentGatewayResponse

[Jacques Le Roux (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320728#comment-15320728
 ] 

Jacques Le Roux commented on OFBIZ-7011:


So this is more an improvement, right?

> Failure in Payment Capture process when ERROR is returned in referenceNum in 
> paymentGatewayResponse
> ---
>
> Key: OFBIZ-7011
> URL: https://issues.apache.org/jira/browse/OFBIZ-7011
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Reporter: Avnindra Sharma
>Assignee: Deepak Dixit
> Fix For: Trunk
>
> Attachments: OFBIZ-7011.patch
>
>
> When there is slow/no response from authorize.net while captuing payment, 
> corrupt data is prepaed in paymentGatewayResponse with "ERROR" in 
> refereneNum. 
> So while capturing the payment again it returns error as it finds the payment 
> gateway response for it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Lucene index Lock

[Jacques Le Roux]

Thanks Jacopo,

I'll create a Jira using your answer as description

Jacques


Le 08/06/2016 à 15:08, Jacopo Cappellato a écrit :

We should not worry (because the "lucene" component is just an experimental
one) but let's keep an eye on it: it is caused when two threads are trying
to update documents in the Lucene index; it may happen when two events
modify data that trigger the execution of the document update.
We could consider to enhance the DocumentIndexer to properly manage these
scenarios.

Jacopo



On Tue, Jun 7, 2016 at 10:55 AM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:


Hi,

Should we worry about this message I found in error.log?

2016-06-07 10:35:23,327 |xer_default_products |DocumentIndexer
|E| Could not obtain Lock on lucene index Lock held by this virtual
machine: C:\projectASF-Mars\ofbiz\runtime\indexes\products\write.lock

I tested indexing contents and products works w/o pb.

Jacques

buildbot success in on ofbiz-trunk

[buildbot]

The Buildbot has detected a restored build on builder ofbiz-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/ofbiz-trunk/builds/804

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-ofbiz-commit' 
triggered this build
Build Source Stamp: [branch ofbiz/trunk] 1747402
Blamelist: ashish,deepak

Build succeeded!

Sincerely,
 -The Buildbot

Re: Proposal to modify the testing framework for OFBiz

[Taher Alkhateeb]

Hi Everyone,

Thank you all for your support, JIRA created in
https://issues.apache.org/jira/browse/OFBIZ-7254

I will start working on it and try to implement ASAP to get my focus back
on refactoring.

Cheers!

Taher Alkhateeb

On Wed, Jun 8, 2016 at 4:58 PM, Deepak Dixit  wrote:

> +1
>
> Thanks & Regards
> --
> Deepak Dixit
> www.hotwaxsystems.com
>
> On Wed, Jun 8, 2016 at 7:12 PM, Mridul Pathak <
> mridul.pat...@hotwaxsystems.com> wrote:
>
> > +1
> >
> > Makes perfect sense.
> >
> > --
> > Thanks & Regards,
> > Mridul Pathak
> > Senior Manager
> > HotWax Systems
> > http://www.hotwaxsystems.com
> >
> > > On Jun 8, 2016, at 2:41 PM, Taher Alkhateeb <
> slidingfilame...@gmail.com>
> > wrote:
> > >
> > > Hello Everyone,
> > >
> > > After refactoring the start component and while starting on the base
> > > component I realized that the testing framework for OFBiz is not good.
> > You
> > > cannot do real test driven development or red-green-refactor with the
> > > current setup, hence my proposal to change it. I explain below:
> > >
> > > Problem with current design
> > > 
> > > - What we have right now is not unit tests, it's really integration
> > tests.
> > > You have to start the framework, the database, the service engine, the
> > > entity engine and pretty much everything.
> > > - Testing is very slow, because it's an integration test as I mentioned
> > > above. 10 minutes on a good computer!
> > > - There is zero mocking! We actually have to --load-data for things to
> > > work. Again, these are integration tests.
> > > - Too complex: Integration tests by their nature are grabbing too much.
> > > Mind you, I am not objecting to integration tests (I actually like
> them)
> > > but I am objecting to not having real unit-tests. Unit tests should all
> > run
> > > in a few seconds.
> > >
> > > Proposed solution
> > > --
> > > - We keep what is considered real integration tests the way they are
> > right
> > > now and keep using them
> > > - We move what should be unit tests into simple JUnit classes, and we
> do
> > > not run them using java -jar ofbiz.jar --test, but instead run them
> > > directly from the build.xml script, so these files are not identified
> in
> > > any XML document, but are simply called immediately from the build
> > scripts.
> > > - We clearly mark the difference between integration tests and unit
> tests
> > > (inside the source files or in the suite declarations).
> > > - We change the run-tests target in build.xml to run both unit tests
> and
> > > integration tests.
> > >
> > > I intend to heavily refactor the framework and I would feel better
> about
> > > introducing this change while refactoring. What do you guys think?
> Ideas?
> > > Suggestions? Approvals and thumbs up?
> > >
> > > Regards,
> > >
> > > Taher Alkhateeb
> >
> >
>

[jira] [Created] (OFBIZ-7254) provide a new unit testing framework for OFBiz

[Taher Alkhateeb (JIRA)]

Taher Alkhateeb created OFBIZ-7254:
--

 Summary: provide a new unit testing framework for OFBiz
 Key: OFBIZ-7254
 URL: https://issues.apache.org/jira/browse/OFBIZ-7254
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL COMPONENTS
Affects Versions: Upcoming Branch
Reporter: Taher Alkhateeb
Assignee: Taher Alkhateeb


The objective of this JIRA is to create a unit testing framework for OFBiz in 
addition to the existing testing framework which is used for integration tests.

This objective will be achieved using the following steps:
- Create a master suite to hold all other suites and unit tests
- Modify build.xml to incorporate unit tests and integration tests in separate 
tasks
- design at least a few test scripts to showcase usage

This JIRA has reference to the discussion on the below mail thread 
http://ofbiz.markmail.org/message/3cebkshhgyzds4e5
https://lists.apache.org/thread.html/0a5e3a02505061ac2d55f75dfb88714b5ab543c39bbadb9aa3e2d2b3@%3Cdev.ofbiz.apache.org%3E



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7011) Failure in Payment Capture process when ERROR is returned in referenceNum in paymentGatewayResponse

[Deepak Dixit (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320655#comment-15320655
 ] 

Deepak Dixit commented on OFBIZ-7011:
-

This has been committed at r#1747402

> Failure in Payment Capture process when ERROR is returned in referenceNum in 
> paymentGatewayResponse
> ---
>
> Key: OFBIZ-7011
> URL: https://issues.apache.org/jira/browse/OFBIZ-7011
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Reporter: Avnindra Sharma
>Assignee: Deepak Dixit
> Fix For: Trunk
>
> Attachments: OFBIZ-7011.patch
>
>
> When there is slow/no response from authorize.net while captuing payment, 
> corrupt data is prepaed in paymentGatewayResponse with "ERROR" in 
> refereneNum. 
> So while capturing the payment again it returns error as it finds the payment 
> gateway response for it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7253) UI issue on web pos for different themes

[Anurag Chandak (JIRA)]

Anurag Chandak created OFBIZ-7253:
-

 Summary: UI issue on web pos for different themes
 Key: OFBIZ-7253
 URL: https://issues.apache.org/jira/browse/OFBIZ-7253
 Project: OFBiz
  Issue Type: Bug
  Components: specialpurpose/pos
Affects Versions: Release Branch 15.12, Trunk, Release Branch 14.12, 
Release Branch 13.07
Reporter: Anurag Chandak
Assignee: Anurag Chandak
 Fix For: Upcoming Branch


Steps to regenerate:
- Go to web pos
- Do login with any terminal
- UI of "Cart", "Browse Categories" and "Products from this category" 
screenlets are not proper.

NOTE: This issue is found on the Flat Grey theme.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7213) Override allow-html attribute do not work in service implementing any interface

[Deepak Dixit (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit reassigned OFBIZ-7213:
---

Assignee: Deepak Dixit

> Override allow-html attribute do not work in service implementing any 
> interface
> ---
>
> Key: OFBIZ-7213
> URL: https://issues.apache.org/jira/browse/OFBIZ-7213
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Nameet Jain
>Assignee: Deepak Dixit
>Priority: Critical
> Attachments: OFBIZ-7213.patch
>
>
> To test I used an interface say "testInterface". Try as shown below
> =Add test interface and service =
> 
> 
> 
>  location="org.ofbiz.order.order.OrderServices" 
> invoke="checkAllowHtmlForOverride">
> 
> 
> 
> ===
> Add service definition for the service "checkAllowHtmlForOverride"  in 
> "org.ofbiz.order.order.OrderServices". 
> public static Map checkAllowHtmlForOverride(DispatchContext 
> dctx, Map context) {
> String testData = (String) context.get("testData");
> Debug.log("==" + testData);
> return ServiceUtil.returnSuccess();
> }
> Run service "checkAllowHtmlForOverride" from service engine. 
> *Exception :* 
>  [java] 2016-06-07 19:07:38,429 |http-nio-8443-exec-9 |ServiceDispatcher  
>|E| Incoming context (in runSync : checkAllowHtmlForOverride) does 
> not match expected requirements
>  [java] org.ofbiz.service.ServiceValidationException: In field [testData] 
> less-than (<) and greater-than (>) symbols are not allowed.
>  [java]   at 
> org.ofbiz.service.ModelService.validate(ModelService.java:597) 
> ~[ofbiz-service.jar:?]
>  [java]   at 
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:376) 
> [ofbiz-service.jar:?]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7250) Add a look-up for Product Id in Find Facility Inventory Items Screen

[Deepak Dixit (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320606#comment-15320606
 ] 

Deepak Dixit commented on OFBIZ-7250:
-

This has been done at r#1747399

Thanks Pawan for your contribution.

> Add a look-up for Product Id in Find Facility Inventory Items Screen
> 
>
> Key: OFBIZ-7250
> URL: https://issues.apache.org/jira/browse/OFBIZ-7250
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7250.patch
>
>
> Currently, In Find Facility Inventory Items Screen there is Product Id field 
> is a text field, we should have look-up for this Product Id field.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7250) Add a look-up for Product Id in Find Facility Inventory Items Screen

[Deepak Dixit (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit closed OFBIZ-7250.
---
Resolution: Fixed

> Add a look-up for Product Id in Find Facility Inventory Items Screen
> 
>
> Key: OFBIZ-7250
> URL: https://issues.apache.org/jira/browse/OFBIZ-7250
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7250.patch
>
>
> Currently, In Find Facility Inventory Items Screen there is Product Id field 
> is a text field, we should have look-up for this Product Id field.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7250) Add a look-up for Product Id in Find Facility Inventory Items Screen

[Deepak Dixit (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit reassigned OFBIZ-7250:
---

Assignee: Deepak Dixit

> Add a look-up for Product Id in Find Facility Inventory Items Screen
> 
>
> Key: OFBIZ-7250
> URL: https://issues.apache.org/jira/browse/OFBIZ-7250
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7250.patch
>
>
> Currently, In Find Facility Inventory Items Screen there is Product Id field 
> is a text field, we should have look-up for this Product Id field.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-382) Implement Party lookup by External Id

[Deepak Dixit (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320591#comment-15320591
 ] 

Deepak Dixit commented on OFBIZ-382:


This has been done at r#1747398

Thanks  John Martin for reporting the issue and Renuka for providing the patch.

> Implement Party lookup by External Id
> -
>
> Key: OFBIZ-382
> URL: https://issues.apache.org/jira/browse/OFBIZ-382
> Project: OFBiz
>  Issue Type: New Feature
>  Components: party
>Reporter: John Martin
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-382.patch, OFBIZ-382_new.patch
>
>
> It would be helpful for anyone whom is integrating ofBiz with an external 
> application to be able to expose the externalId property in the Party entity. 
>  
> The tasks to complete include:
> - Update the findparty.ftl to include the prompt/form input field for the 
> external id
> - Update the PartyServices.findParty() method to include the logic to handle 
> the externalId argument
> - Add new method getPartyFromExternalId to PartyServices
> - Add getPartyFromExternalId service definition in Party 
> servicedef/services_view.xml
> - Add misc local strings to UI label resource file
> Need to determine if the External Id: input form field should be 
> configuarable so that it only appears if feature is enabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-382) Implement Party lookup by External Id

[Deepak Dixit (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit closed OFBIZ-382.
--
   Resolution: Fixed
Fix Version/s: Upcoming Branch

> Implement Party lookup by External Id
> -
>
> Key: OFBIZ-382
> URL: https://issues.apache.org/jira/browse/OFBIZ-382
> Project: OFBiz
>  Issue Type: New Feature
>  Components: party
>Reporter: John Martin
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-382.patch, OFBIZ-382_new.patch
>
>
> It would be helpful for anyone whom is integrating ofBiz with an external 
> application to be able to expose the externalId property in the Party entity. 
>  
> The tasks to complete include:
> - Update the findparty.ftl to include the prompt/form input field for the 
> external id
> - Update the PartyServices.findParty() method to include the logic to handle 
> the externalId argument
> - Add new method getPartyFromExternalId to PartyServices
> - Add getPartyFromExternalId service definition in Party 
> servicedef/services_view.xml
> - Add misc local strings to UI label resource file
> Need to determine if the External Id: input form field should be 
> configuarable so that it only appears if feature is enabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Proposal to modify the testing framework for OFBiz

[Deepak Dixit]

+1

Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com

On Wed, Jun 8, 2016 at 7:12 PM, Mridul Pathak <
mridul.pat...@hotwaxsystems.com> wrote:

> +1
>
> Makes perfect sense.
>
> --
> Thanks & Regards,
> Mridul Pathak
> Senior Manager
> HotWax Systems
> http://www.hotwaxsystems.com
>
> > On Jun 8, 2016, at 2:41 PM, Taher Alkhateeb 
> wrote:
> >
> > Hello Everyone,
> >
> > After refactoring the start component and while starting on the base
> > component I realized that the testing framework for OFBiz is not good.
> You
> > cannot do real test driven development or red-green-refactor with the
> > current setup, hence my proposal to change it. I explain below:
> >
> > Problem with current design
> > 
> > - What we have right now is not unit tests, it's really integration
> tests.
> > You have to start the framework, the database, the service engine, the
> > entity engine and pretty much everything.
> > - Testing is very slow, because it's an integration test as I mentioned
> > above. 10 minutes on a good computer!
> > - There is zero mocking! We actually have to --load-data for things to
> > work. Again, these are integration tests.
> > - Too complex: Integration tests by their nature are grabbing too much.
> > Mind you, I am not objecting to integration tests (I actually like them)
> > but I am objecting to not having real unit-tests. Unit tests should all
> run
> > in a few seconds.
> >
> > Proposed solution
> > --
> > - We keep what is considered real integration tests the way they are
> right
> > now and keep using them
> > - We move what should be unit tests into simple JUnit classes, and we do
> > not run them using java -jar ofbiz.jar --test, but instead run them
> > directly from the build.xml script, so these files are not identified in
> > any XML document, but are simply called immediately from the build
> scripts.
> > - We clearly mark the difference between integration tests and unit tests
> > (inside the source files or in the suite declarations).
> > - We change the run-tests target in build.xml to run both unit tests and
> > integration tests.
> >
> > I intend to heavily refactor the framework and I would feel better about
> > introducing this change while refactoring. What do you guys think? Ideas?
> > Suggestions? Approvals and thumbs up?
> >
> > Regards,
> >
> > Taher Alkhateeb
>
>

[jira] [Created] (OFBIZ-7252) Error adding task to backlog

[Montalbano Florian (JIRA)]

Montalbano Florian created OFBIZ-7252:
-

 Summary: Error adding task to backlog
 Key: OFBIZ-7252
 URL: https://issues.apache.org/jira/browse/OFBIZ-7252
 Project: OFBiz
  Issue Type: Bug
  Components: specialpurpose/scrum
Affects Versions: Trunk
Reporter: Montalbano Florian


There are several problems in the form to add a new task in a backlog. Step to 
reproduce :
- Go to the Scrum component and select a product sprint 
(https://localhost:8443/scrum/control/ViewSprint?sprintId=DEMO-SPRINT-1=DEMO-PROJECT-1)
- Scroll down to the Sprint Backlog List
- Click on a button "Add Task"
- See the error in the console.

>From there, it's not possible to create a new task. When clicking on the 
>create button, there is an error and the target is 
>"https://localhost:8443/scrum/control/updateSprintTask; where it should be 
>"https://localhost:8443/scrum/control/createSprintBacklogTask;. 

I tried to solve the problem but it's beyond me. The form causing the problem 
is scrumForms.xml#NewTaskForSprintBacklog and it extends the form 
TaskForms.xml#EditSprintTask .

Thanks,
Florian



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7251) Update Payment Gateway Config data for Payment Gateway Authorize.net

[Avnindra Sharma (JIRA)]

Avnindra Sharma created OFBIZ-7251:
--

 Summary: Update Payment Gateway Config data for Payment Gateway 
Authorize.net 
 Key: OFBIZ-7251
 URL: https://issues.apache.org/jira/browse/OFBIZ-7251
 Project: OFBiz
  Issue Type: Improvement
  Components: order
Reporter: Avnindra Sharma
Priority: Minor


As per the https://community.developer.authorize.net, the transactionUrl has 
been updated from https://certification.authorize.net/gateway/transact.dll to 
https://test.authorize.net/gateway/transact.dll



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [DISCUSSION] Setting Up Mentoring

[Ron Wheeler]

There are 2 current Skype channels that are actively in use.
One (9 members) is specifically designated for the framework.
 The general channel has 35 participants.

Ron
On 08/06/2016 4:36 AM, Sharan-F wrote:

Hi Everyone

I've created a page on the wiki to try and organise the mentoring. We have a
list of people who volunteered to be mentors, so if you want to be a mentor,
then please feel free to add your name ot this list.

https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Mentors

I'm very conscious of the fact that we dont want to overload the mentors so
I suggest that we initially focus the mentoring on the framework
re-factoring work. This is a specific area where we know there is a lot of
complicated and difficult code that could be hard to understand.

My suggestion would be that anyone who has a re-factor task could be paired
up with a mentor to help them with it in case they encounter problems. What
do people think about this idea?

I've also been looking at different ways in which the mentoring could take
place. We need somewhere that is easy to use, and if one mentor isnt
available, a question could perhaps be managed by someone else. We could
make use of our existing IRC channel, Skype or Hipchat.

I think our IRC channel is underused which shows that people prefer not to
use it much. Skype is also an  option but out of the three I think Hipchat
could be a good to look at. It is the main communication method  used by our
ASF Infra team if you need to talk to anyone urgently and from experience I
know it works really well. We already have a Hipchat OFBiz room setup so
could easily implement something similar to ASF Infra with our mentors or
even create a group where our committers could hangout and quickly contact
each other.

In the past we talked about having a committers space where they could come
together, get to know each other and collaborate more, but never set
anything up so this could also be an opportunity to do that. I will send out
some invitations to our committers to join the Hipchat OFBiz room so you can
take a look around and see what you think.

As usual I'm happy to get feedback on any of the points raised.

Thanks
Sharan



--
View this message in context: 
http://ofbiz.135035.n4.nabble.com/DISCUSSION-Setting-Up-Mentoring-tp4682877.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.




--
Ron Wheeler
President
Artifact Software Inc
email: rwhee...@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102

[jira] [Commented] (OFBIZ-382) Implement Party lookup by External Id

[Deepak Dixit (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320574#comment-15320574
 ] 

Deepak Dixit commented on OFBIZ-382:


Hi Renuka, 

You can  upload patch with same name, jira internally handle it :)

> Implement Party lookup by External Id
> -
>
> Key: OFBIZ-382
> URL: https://issues.apache.org/jira/browse/OFBIZ-382
> Project: OFBiz
>  Issue Type: New Feature
>  Components: party
>Reporter: John Martin
>Assignee: Deepak Dixit
>Priority: Minor
> Attachments: OFBIZ-382.patch, OFBIZ-382_new.patch
>
>
> It would be helpful for anyone whom is integrating ofBiz with an external 
> application to be able to expose the externalId property in the Party entity. 
>  
> The tasks to complete include:
> - Update the findparty.ftl to include the prompt/form input field for the 
> external id
> - Update the PartyServices.findParty() method to include the logic to handle 
> the externalId argument
> - Add new method getPartyFromExternalId to PartyServices
> - Add getPartyFromExternalId service definition in Party 
> servicedef/services_view.xml
> - Add misc local strings to UI label resource file
> Need to determine if the External Id: input form field should be 
> configuarable so that it only appears if feature is enabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-382) Implement Party lookup by External Id

[Renuka Srishti (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Renuka Srishti updated OFBIZ-382:
-
Attachment: OFBIZ-382_new.patch

Here is updated patch for the same which covers following points :
#1. Add field externalId in PartyForms.xml.
#2. Update the PartyServices.performFindParty() method to include the logic to 
handle the externalId argument.
#3. Add new method getPartyFromExternalId to PartyServices.
#4. Add getPartyFromExternalId service definition in Party 
servicedef/services_view.xml



> Implement Party lookup by External Id
> -
>
> Key: OFBIZ-382
> URL: https://issues.apache.org/jira/browse/OFBIZ-382
> Project: OFBiz
>  Issue Type: New Feature
>  Components: party
>Reporter: John Martin
>Assignee: Deepak Dixit
>Priority: Minor
> Attachments: OFBIZ-382.patch, OFBIZ-382_new.patch
>
>
> It would be helpful for anyone whom is integrating ofBiz with an external 
> application to be able to expose the externalId property in the Party entity. 
>  
> The tasks to complete include:
> - Update the findparty.ftl to include the prompt/form input field for the 
> external id
> - Update the PartyServices.findParty() method to include the logic to handle 
> the externalId argument
> - Add new method getPartyFromExternalId to PartyServices
> - Add getPartyFromExternalId service definition in Party 
> servicedef/services_view.xml
> - Add misc local strings to UI label resource file
> Need to determine if the External Id: input form field should be 
> configuarable so that it only appears if feature is enabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7250) Add a look-up for Product Id in Find Facility Inventory Items Screen

[Pawan Verma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma updated OFBIZ-7250:
---
Summary: Add a look-up for Product Id in Find Facility Inventory Items 
Screen  (was: Add a lookup for Product Id in Find Facility Inventory Items 
Screen)

> Add a look-up for Product Id in Find Facility Inventory Items Screen
> 
>
> Key: OFBIZ-7250
> URL: https://issues.apache.org/jira/browse/OFBIZ-7250
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7250.patch
>
>
> Currently, In Find Facility Inventory Items Screen there is Product Id field 
> is a text field, we should have lookup for this Product Id field.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Proposal to modify the testing framework for OFBiz

[Mridul Pathak]

+1

Makes perfect sense.

--
Thanks & Regards,
Mridul Pathak
Senior Manager
HotWax Systems
http://www.hotwaxsystems.com

> On Jun 8, 2016, at 2:41 PM, Taher Alkhateeb  
> wrote:
> 
> Hello Everyone,
> 
> After refactoring the start component and while starting on the base
> component I realized that the testing framework for OFBiz is not good. You
> cannot do real test driven development or red-green-refactor with the
> current setup, hence my proposal to change it. I explain below:
> 
> Problem with current design
> 
> - What we have right now is not unit tests, it's really integration tests.
> You have to start the framework, the database, the service engine, the
> entity engine and pretty much everything.
> - Testing is very slow, because it's an integration test as I mentioned
> above. 10 minutes on a good computer!
> - There is zero mocking! We actually have to --load-data for things to
> work. Again, these are integration tests.
> - Too complex: Integration tests by their nature are grabbing too much.
> Mind you, I am not objecting to integration tests (I actually like them)
> but I am objecting to not having real unit-tests. Unit tests should all run
> in a few seconds.
> 
> Proposed solution
> --
> - We keep what is considered real integration tests the way they are right
> now and keep using them
> - We move what should be unit tests into simple JUnit classes, and we do
> not run them using java -jar ofbiz.jar --test, but instead run them
> directly from the build.xml script, so these files are not identified in
> any XML document, but are simply called immediately from the build scripts.
> - We clearly mark the difference between integration tests and unit tests
> (inside the source files or in the suite declarations).
> - We change the run-tests target in build.xml to run both unit tests and
> integration tests.
> 
> I intend to heavily refactor the framework and I would feel better about
> introducing this change while refactoring. What do you guys think? Ideas?
> Suggestions? Approvals and thumbs up?
> 
> Regards,
> 
> Taher Alkhateeb

[jira] [Updated] (OFBIZ-7250) Add a lookup for Product Id in Find Facility Inventory Items Screen

[Pawan Verma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma updated OFBIZ-7250:
---
Description: Currently, In Find Facility Inventory Items Screen there is 
Product Id field is a text field, we should have lookup for this Product Id 
field.  (was: Currently, In Find Facility Inventory Items Screen there is 
Product Id field is a text field, we should have drop-down for this Product Id 
field.)

> Add a lookup for Product Id in Find Facility Inventory Items Screen
> ---
>
> Key: OFBIZ-7250
> URL: https://issues.apache.org/jira/browse/OFBIZ-7250
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7250.patch
>
>
> Currently, In Find Facility Inventory Items Screen there is Product Id field 
> is a text field, we should have lookup for this Product Id field.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7250) Add a look-up for Product Id in Find Facility Inventory Items Screen

[Pawan Verma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma updated OFBIZ-7250:
---
Description: Currently, In Find Facility Inventory Items Screen there is 
Product Id field is a text field, we should have look-up for this Product Id 
field.  (was: Currently, In Find Facility Inventory Items Screen there is 
Product Id field is a text field, we should have lookup for this Product Id 
field.)

> Add a look-up for Product Id in Find Facility Inventory Items Screen
> 
>
> Key: OFBIZ-7250
> URL: https://issues.apache.org/jira/browse/OFBIZ-7250
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7250.patch
>
>
> Currently, In Find Facility Inventory Items Screen there is Product Id field 
> is a text field, we should have look-up for this Product Id field.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7250) Add a lookup for Product Id in Find Facility Inventory Items Screen

[Pawan Verma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma updated OFBIZ-7250:
---
Summary: Add a lookup for Product Id in Find Facility Inventory Items 
Screen  (was: Add a drop-down for Product Id in Find Facility Inventory Items 
Screen)

> Add a lookup for Product Id in Find Facility Inventory Items Screen
> ---
>
> Key: OFBIZ-7250
> URL: https://issues.apache.org/jira/browse/OFBIZ-7250
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7250.patch
>
>
> Currently, In Find Facility Inventory Items Screen there is Product Id field 
> is a text field, we should have drop-down for this Product Id field.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7250) Add a drop-down for Product Id in Find Facility Inventory Items Screen

[Pawan Verma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma updated OFBIZ-7250:
---
Attachment: OFBIZ-7250.patch

Providing patch for the improvement. Added ProductId look-up for Find Facility 
Inventory Items Screen.

> Add a drop-down for Product Id in Find Facility Inventory Items Screen
> --
>
> Key: OFBIZ-7250
> URL: https://issues.apache.org/jira/browse/OFBIZ-7250
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7250.patch
>
>
> Currently, In Find Facility Inventory Items Screen there is Product Id field 
> is a text field, we should have drop-down for this Product Id field.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7250) Add a drop-down for Product Id in Find Facility Inventory Items Screen

[Pawan Verma (JIRA)]

Pawan Verma created OFBIZ-7250:
--

 Summary: Add a drop-down for Product Id in Find Facility Inventory 
Items Screen
 Key: OFBIZ-7250
 URL: https://issues.apache.org/jira/browse/OFBIZ-7250
 Project: OFBiz
  Issue Type: Improvement
Affects Versions: Trunk
Reporter: Pawan Verma
Priority: Minor
 Fix For: Upcoming Branch


Currently, In Find Facility Inventory Items Screen there is Product Id field is 
a text field, we should have drop-down for this Product Id field.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7249) Error on removing scrum members

[Anurag Chandak (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anurag Chandak updated OFBIZ-7249:
--
Attachment: OFBIZ-7249.patch

I am attaching the patch which removes the product role first and then deletes 
party role for avoiding this error.

Not sure whether we have to delete product role or not, before deleting party 
role, may be any best solution exists for this.

> Error on removing scrum members
> ---
>
> Key: OFBIZ-7249
> URL: https://issues.apache.org/jira/browse/OFBIZ-7249
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/scrum
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Anurag Chandak
>Assignee: Anurag Chandak
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7249.patch
>
>
> Steps to regenerate:
> - Go to Scrum --> Administration --> Scrum Members
> - Try to remove only those scrum members whose party and role type are 
> similar to product members
> - The following error is shown:
> {code}
> The Following Errors Occurred:
> Error:Error doing entity-auto operation for entity PartyRole in service 
> deletePartyRole: org.ofbiz.entity.GenericEntityException: 
> org.ofbiz.entity.GenericDataSourceException: Exception while deleting the 
> following entity: 
> [GenericEntity:PartyRole][partyId,SCRUMASTER(java.lang.String)][roleTypeId,SCRUM_MASTER(java.lang.String)]
>  (SQL Exception while executing the following:DELETE FROM OFBIZ.PARTY_ROLE 
> WHERE PARTY_ID=? AND ROLE_TYPE_ID=? (DELETE on table 'PARTY_ROLE' caused a 
> violation of foreign key constraint 'PROD_RLE_PTYRLE' for key 
> (SCRUMASTER,SCRUM_MASTER). The statement has been rolled back.)) (Exception 
> while deleting the following entity: 
> [GenericEntity:PartyRole][partyId,SCRUMASTER(java.lang.String)][roleTypeId,SCRUM_MASTER(java.lang.String)]
>  (SQL Exception while executing the following:DELETE FROM OFBIZ.PARTY_ROLE 
> WHERE PARTY_ID=? AND ROLE_TYPE_ID=? (DELETE on table 'PARTY_ROLE' caused a 
> violation of foreign key constraint 'PROD_RLE_PTYRLE' for key 
> (SCRUMASTER,SCRUM_MASTER). The statement has been rolled back.)))
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7249) Error on removing scrum members

[Anurag Chandak (JIRA)]

Anurag Chandak created OFBIZ-7249:
-

 Summary: Error on removing scrum members
 Key: OFBIZ-7249
 URL: https://issues.apache.org/jira/browse/OFBIZ-7249
 Project: OFBiz
  Issue Type: Bug
  Components: specialpurpose/scrum
Affects Versions: Release Branch 15.12, Trunk, Release Branch 14.12, 
Release Branch 13.07
Reporter: Anurag Chandak
Assignee: Anurag Chandak
 Fix For: Upcoming Branch


Steps to regenerate:
- Go to Scrum --> Administration --> Scrum Members
- Try to remove only those scrum members whose party and role type are similar 
to product members
- The following error is shown:
{code}
The Following Errors Occurred:
Error:Error doing entity-auto operation for entity PartyRole in service 
deletePartyRole: org.ofbiz.entity.GenericEntityException: 
org.ofbiz.entity.GenericDataSourceException: Exception while deleting the 
following entity: 
[GenericEntity:PartyRole][partyId,SCRUMASTER(java.lang.String)][roleTypeId,SCRUM_MASTER(java.lang.String)]
 (SQL Exception while executing the following:DELETE FROM OFBIZ.PARTY_ROLE 
WHERE PARTY_ID=? AND ROLE_TYPE_ID=? (DELETE on table 'PARTY_ROLE' caused a 
violation of foreign key constraint 'PROD_RLE_PTYRLE' for key 
(SCRUMASTER,SCRUM_MASTER). The statement has been rolled back.)) (Exception 
while deleting the following entity: 
[GenericEntity:PartyRole][partyId,SCRUMASTER(java.lang.String)][roleTypeId,SCRUM_MASTER(java.lang.String)]
 (SQL Exception while executing the following:DELETE FROM OFBIZ.PARTY_ROLE 
WHERE PARTY_ID=? AND ROLE_TYPE_ID=? (DELETE on table 'PARTY_ROLE' caused a 
violation of foreign key constraint 'PROD_RLE_PTYRLE' for key 
(SCRUMASTER,SCRUM_MASTER). The statement has been rolled back.)))
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Lucene index Lock

[Jacopo Cappellato]

We should not worry (because the "lucene" component is just an experimental
one) but let's keep an eye on it: it is caused when two threads are trying
to update documents in the Lucene index; it may happen when two events
modify data that trigger the execution of the document update.
We could consider to enhance the DocumentIndexer to properly manage these
scenarios.

Jacopo



On Tue, Jun 7, 2016 at 10:55 AM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi,
>
> Should we worry about this message I found in error.log?
>
> 2016-06-07 10:35:23,327 |xer_default_products |DocumentIndexer
>|E| Could not obtain Lock on lucene index Lock held by this virtual
> machine: C:\projectASF-Mars\ofbiz\runtime\indexes\products\write.lock
>
> I tested indexing contents and products works w/o pb.
>
> Jacques
>
>
>
>

[jira] [Updated] (OFBIZ-7011) Failure in Payment Capture process when ERROR is returned in referenceNum in paymentGatewayResponse

[Avnindra Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Avnindra Sharma updated OFBIZ-7011:
---
Assignee: Deepak Dixit  (was: Divesh Dutta)

> Failure in Payment Capture process when ERROR is returned in referenceNum in 
> paymentGatewayResponse
> ---
>
> Key: OFBIZ-7011
> URL: https://issues.apache.org/jira/browse/OFBIZ-7011
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Reporter: Avnindra Sharma
>Assignee: Deepak Dixit
> Fix For: Trunk
>
> Attachments: OFBIZ-7011.patch
>
>
> When there is slow/no response from authorize.net while captuing payment, 
> corrupt data is prepaed in paymentGatewayResponse with "ERROR" in 
> refereneNum. 
> So while capturing the payment again it returns error as it finds the payment 
> gateway response for it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7011) Failure in Payment Capture process when ERROR is returned in referenceNum in paymentGatewayResponse

[Avnindra Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Avnindra Sharma updated OFBIZ-7011:
---
Attachment: OFBIZ-7011.patch

Updated patch

> Failure in Payment Capture process when ERROR is returned in referenceNum in 
> paymentGatewayResponse
> ---
>
> Key: OFBIZ-7011
> URL: https://issues.apache.org/jira/browse/OFBIZ-7011
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Reporter: Avnindra Sharma
>Assignee: Divesh Dutta
> Fix For: Trunk
>
> Attachments: OFBIZ-7011.patch
>
>
> When there is slow/no response from authorize.net while captuing payment, 
> corrupt data is prepaed in paymentGatewayResponse with "ERROR" in 
> refereneNum. 
> So while capturing the payment again it returns error as it finds the payment 
> gateway response for it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7011) Failure in Payment Capture process when ERROR is returned in referenceNum in paymentGatewayResponse

[Avnindra Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Avnindra Sharma updated OFBIZ-7011:
---
Attachment: (was: OFBIZ-7011.patch)

> Failure in Payment Capture process when ERROR is returned in referenceNum in 
> paymentGatewayResponse
> ---
>
> Key: OFBIZ-7011
> URL: https://issues.apache.org/jira/browse/OFBIZ-7011
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Reporter: Avnindra Sharma
>Assignee: Divesh Dutta
> Fix For: Trunk
>
>
> When there is slow/no response from authorize.net while captuing payment, 
> corrupt data is prepaed in paymentGatewayResponse with "ERROR" in 
> refereneNum. 
> So while capturing the payment again it returns error as it finds the payment 
> gateway response for it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Proposal to modify the testing framework for OFBiz

[Jacopo Cappellato]

Totally agree that what we have right now is a set of integration tests,
not unit tests.
Big +1 to the proposal to implement unit tests and mocking.

Jacopo

On Wed, Jun 8, 2016 at 11:11 AM, Taher Alkhateeb  wrote:

> Hello Everyone,
>
> After refactoring the start component and while starting on the base
> component I realized that the testing framework for OFBiz is not good. You
> cannot do real test driven development or red-green-refactor with the
> current setup, hence my proposal to change it. I explain below:
>
> Problem with current design
> 
> - What we have right now is not unit tests, it's really integration tests.
> You have to start the framework, the database, the service engine, the
> entity engine and pretty much everything.
> - Testing is very slow, because it's an integration test as I mentioned
> above. 10 minutes on a good computer!
> - There is zero mocking! We actually have to --load-data for things to
> work. Again, these are integration tests.
> - Too complex: Integration tests by their nature are grabbing too much.
> Mind you, I am not objecting to integration tests (I actually like them)
> but I am objecting to not having real unit-tests. Unit tests should all run
> in a few seconds.
>
> Proposed solution
> --
> - We keep what is considered real integration tests the way they are right
> now and keep using them
> - We move what should be unit tests into simple JUnit classes, and we do
> not run them using java -jar ofbiz.jar --test, but instead run them
> directly from the build.xml script, so these files are not identified in
> any XML document, but are simply called immediately from the build scripts.
> - We clearly mark the difference between integration tests and unit tests
> (inside the source files or in the suite declarations).
> - We change the run-tests target in build.xml to run both unit tests and
> integration tests.
>
> I intend to heavily refactor the framework and I would feel better about
> introducing this change while refactoring. What do you guys think? Ideas?
> Suggestions? Approvals and thumbs up?
>
> Regards,
>
> Taher Alkhateeb
>

[jira] [Assigned] (OFBIZ-382) Implement Party lookup by External Id

[Deepak Dixit (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit reassigned OFBIZ-382:
--

Assignee: Deepak Dixit

> Implement Party lookup by External Id
> -
>
> Key: OFBIZ-382
> URL: https://issues.apache.org/jira/browse/OFBIZ-382
> Project: OFBiz
>  Issue Type: New Feature
>  Components: party
>Reporter: John Martin
>Assignee: Deepak Dixit
>Priority: Minor
> Attachments: OFBIZ-382.patch
>
>
> It would be helpful for anyone whom is integrating ofBiz with an external 
> application to be able to expose the externalId property in the Party entity. 
>  
> The tasks to complete include:
> - Update the findparty.ftl to include the prompt/form input field for the 
> external id
> - Update the PartyServices.findParty() method to include the logic to handle 
> the externalId argument
> - Add new method getPartyFromExternalId to PartyServices
> - Add getPartyFromExternalId service definition in Party 
> servicedef/services_view.xml
> - Add misc local strings to UI label resource file
> Need to determine if the External Id: input form field should be 
> configuarable so that it only appears if feature is enabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-382) Implement Party lookup by External Id

[Renuka Srishti (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Renuka Srishti updated OFBIZ-382:
-
Attachment: OFBIZ-382.patch

Here is the patch for this feature.

> Implement Party lookup by External Id
> -
>
> Key: OFBIZ-382
> URL: https://issues.apache.org/jira/browse/OFBIZ-382
> Project: OFBiz
>  Issue Type: New Feature
>  Components: party
>Reporter: John Martin
>Priority: Minor
> Attachments: OFBIZ-382.patch
>
>
> It would be helpful for anyone whom is integrating ofBiz with an external 
> application to be able to expose the externalId property in the Party entity. 
>  
> The tasks to complete include:
> - Update the findparty.ftl to include the prompt/form input field for the 
> external id
> - Update the PartyServices.findParty() method to include the logic to handle 
> the externalId argument
> - Add new method getPartyFromExternalId to PartyServices
> - Add getPartyFromExternalId service definition in Party 
> servicedef/services_view.xml
> - Add misc local strings to UI label resource file
> Need to determine if the External Id: input form field should be 
> configuarable so that it only appears if feature is enabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Proposal to modify the testing framework for OFBiz

[Pierre Smits]

+1

I suggest the first thing to start with is bring the proposed solution over
to an improvement issue in JIRA and work from there.

Best regards,

Pierre Smits

ORRTIZ.COM 
OFBiz based solutions & services

OFBiz Extensions Marketplace
http://oem.ofbizci.net/oci-2/

On Wed, Jun 8, 2016 at 1:45 PM, Nicolas Malin 
wrote:

> I'm on the same case, +1
>
>
> Le 08/06/2016 13:42, Pranay Pandey a écrit :
>
>> thanks so much Taher for the explaining it further, makes perfect sense.
>>
>>
>> Best regards,
>>
>> Pranay Pandey
>> HotWax Systems
>> http://www.hotwaxsystems.com/
>>
>> On Wed, Jun 8, 2016 at 3:02 PM, Taher Alkhateeb <
>> slidingfilame...@gmail.com>
>> wrote:
>>
>> Hi Pranay,
>>>
>>> What you are talking about is integration tests (ones that you can run
>>> per
>>> component)
>>>
>>> Unit tests do not need to be run per component. The entire unit test
>>> library for the entire framework should run in probably less than 5
>>> seconds. So there is no need to make them run per component.
>>>
>>> My proposal is to simply have a target like run-unit-tests which would
>>> run
>>> all the unit tests. These tests do not talk to the database or server or
>>> anything, You can run them while flying in an airplane 30,000 feet above
>>> the ocean.
>>>
>>> Mind you I will not remove the integration tests, I'm just adding unit
>>> tests (and probably moving some integration tests to unit tests).
>>>
>>> Naturally, my proposition means that those tests are only JUnit tests
>>> (for
>>> now) but that is a quick solution that I think is rather clean because
>>> we're not really radically modifying anything, we're just adding JUnit
>>> classes and running them.
>>>
>>> Regards,
>>>
>>> Taher Alkhateeb
>>>
>>> On Wed, Jun 8, 2016 at 12:23 PM, Pranay Pandey <
>>> pranay.pan...@hotwaxsystems.com> wrote:
>>>
>>> Hi Taher,

 There is one thing that I want to confirm based my understanding, as
 long
 as I know, we can run tests independently as well e.g.

 *Running tests for a component: *

 java -jar ofbiz.jar -test component=‘order’

 *Running a specific test Suite from a component:*

 ant run-single-test-suite -Dtest.component=‘order’ -Dtest.suiteName='
 ordertests'

 *Running a test case from a component:*

 java -jar ofbiz.jar -test -component='order' -case='salesOrder-test'

 I may be completely wrong here but just want to confirm and understand

>>> your
>>>
 proposal.

 Best regards,

 Pranay Pandey
 HotWax Systems
 http://www.hotwaxsystems.com/

 On Wed, Jun 8, 2016 at 2:41 PM, Taher Alkhateeb <
 slidingfilame...@gmail.com>
 wrote:

 Hello Everyone,
>
> After refactoring the start component and while starting on the base
> component I realized that the testing framework for OFBiz is not good.
>
 You

> cannot do real test driven development or red-green-refactor with the
> current setup, hence my proposal to change it. I explain below:
>
> Problem with current design
> 
> - What we have right now is not unit tests, it's really integration
>
 tests.

> You have to start the framework, the database, the service engine, the
> entity engine and pretty much everything.
> - Testing is very slow, because it's an integration test as I mentioned
> above. 10 minutes on a good computer!
> - There is zero mocking! We actually have to --load-data for things to
> work. Again, these are integration tests.
> - Too complex: Integration tests by their nature are grabbing too much.
> Mind you, I am not objecting to integration tests (I actually like
>
 them)
>>>
 but I am objecting to not having real unit-tests. Unit tests should all
>
 run

> in a few seconds.
>
> Proposed solution
> --
> - We keep what is considered real integration tests the way they are
>
 right

> now and keep using them
> - We move what should be unit tests into simple JUnit classes, and we
>
 do
>>>
 not run them using java -jar ofbiz.jar --test, but instead run them
> directly from the build.xml script, so these files are not identified
>
 in
>>>
 any XML document, but are simply called immediately from the build
>
 scripts.

> - We clearly mark the difference between integration tests and unit
>
 tests
>>>
 (inside the source files or in the suite declarations).
> - We change the run-tests target in build.xml to run both unit tests
>
 and
>>>
 integration tests.
>
> I intend to heavily refactor the framework and I would feel better
>
 about
>>>
 introducing this change while refactoring. What do you guys think?
>
 Ideas?
>>>
 Suggestions? Approvals and thumbs up?

[jira] [Commented] (OFBIZ-7248) Improve the layout of PDF documents

[Pierre Smits (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320403#comment-15320403
 ] 

Pierre Smits commented on OFBIZ-7248:
-

What kind of structure do you propose?

> Improve the layout of PDF documents
> ---
>
> Key: OFBIZ-7248
> URL: https://issues.apache.org/jira/browse/OFBIZ-7248
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Mohammad Kathawala
> Fix For: Trunk
>
>
> The layout of all the PDF documents in OFBiz like Order, Invoice, Picklist, 
> Shipment etc. does not look very good and is not very readable for end users. 
> We need to have a properly structured PDF documents which is easy to read.
> I am going  to create sub-tasks of this parent task for all the different 
> objects.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Proposal to modify the testing framework for OFBiz

[Nicolas Malin]

I'm on the same case, +1

Le 08/06/2016 13:42, Pranay Pandey a écrit :

thanks so much Taher for the explaining it further, makes perfect sense.


Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Wed, Jun 8, 2016 at 3:02 PM, Taher Alkhateeb 
wrote:


Hi Pranay,

What you are talking about is integration tests (ones that you can run per
component)

Unit tests do not need to be run per component. The entire unit test
library for the entire framework should run in probably less than 5
seconds. So there is no need to make them run per component.

My proposal is to simply have a target like run-unit-tests which would run
all the unit tests. These tests do not talk to the database or server or
anything, You can run them while flying in an airplane 30,000 feet above
the ocean.

Mind you I will not remove the integration tests, I'm just adding unit
tests (and probably moving some integration tests to unit tests).

Naturally, my proposition means that those tests are only JUnit tests (for
now) but that is a quick solution that I think is rather clean because
we're not really radically modifying anything, we're just adding JUnit
classes and running them.

Regards,

Taher Alkhateeb

On Wed, Jun 8, 2016 at 12:23 PM, Pranay Pandey <
pranay.pan...@hotwaxsystems.com> wrote:


Hi Taher,

There is one thing that I want to confirm based my understanding, as long
as I know, we can run tests independently as well e.g.

*Running tests for a component: *

java -jar ofbiz.jar -test component=‘order’

*Running a specific test Suite from a component:*

ant run-single-test-suite -Dtest.component=‘order’ -Dtest.suiteName='
ordertests'

*Running a test case from a component:*

java -jar ofbiz.jar -test -component='order' -case='salesOrder-test'

I may be completely wrong here but just want to confirm and understand

your

proposal.

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Wed, Jun 8, 2016 at 2:41 PM, Taher Alkhateeb <
slidingfilame...@gmail.com>
wrote:


Hello Everyone,

After refactoring the start component and while starting on the base
component I realized that the testing framework for OFBiz is not good.

You

cannot do real test driven development or red-green-refactor with the
current setup, hence my proposal to change it. I explain below:

Problem with current design

- What we have right now is not unit tests, it's really integration

tests.

You have to start the framework, the database, the service engine, the
entity engine and pretty much everything.
- Testing is very slow, because it's an integration test as I mentioned
above. 10 minutes on a good computer!
- There is zero mocking! We actually have to --load-data for things to
work. Again, these are integration tests.
- Too complex: Integration tests by their nature are grabbing too much.
Mind you, I am not objecting to integration tests (I actually like

them)

but I am objecting to not having real unit-tests. Unit tests should all

run

in a few seconds.

Proposed solution
--
- We keep what is considered real integration tests the way they are

right

now and keep using them
- We move what should be unit tests into simple JUnit classes, and we

do

not run them using java -jar ofbiz.jar --test, but instead run them
directly from the build.xml script, so these files are not identified

in

any XML document, but are simply called immediately from the build

scripts.

- We clearly mark the difference between integration tests and unit

tests

(inside the source files or in the suite declarations).
- We change the run-tests target in build.xml to run both unit tests

and

integration tests.

I intend to heavily refactor the framework and I would feel better

about

introducing this change while refactoring. What do you guys think?

Ideas?

Suggestions? Approvals and thumbs up?

Regards,

Taher Alkhateeb

Re: Proposal to modify the testing framework for OFBiz

[Pranay Pandey]

thanks so much Taher for the explaining it further, makes perfect sense.


Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Wed, Jun 8, 2016 at 3:02 PM, Taher Alkhateeb 
wrote:

> Hi Pranay,
>
> What you are talking about is integration tests (ones that you can run per
> component)
>
> Unit tests do not need to be run per component. The entire unit test
> library for the entire framework should run in probably less than 5
> seconds. So there is no need to make them run per component.
>
> My proposal is to simply have a target like run-unit-tests which would run
> all the unit tests. These tests do not talk to the database or server or
> anything, You can run them while flying in an airplane 30,000 feet above
> the ocean.
>
> Mind you I will not remove the integration tests, I'm just adding unit
> tests (and probably moving some integration tests to unit tests).
>
> Naturally, my proposition means that those tests are only JUnit tests (for
> now) but that is a quick solution that I think is rather clean because
> we're not really radically modifying anything, we're just adding JUnit
> classes and running them.
>
> Regards,
>
> Taher Alkhateeb
>
> On Wed, Jun 8, 2016 at 12:23 PM, Pranay Pandey <
> pranay.pan...@hotwaxsystems.com> wrote:
>
> > Hi Taher,
> >
> > There is one thing that I want to confirm based my understanding, as long
> > as I know, we can run tests independently as well e.g.
> >
> > *Running tests for a component: *
> >
> > java -jar ofbiz.jar -test component=‘order’
> >
> > *Running a specific test Suite from a component:*
> >
> > ant run-single-test-suite -Dtest.component=‘order’ -Dtest.suiteName='
> > ordertests'
> >
> > *Running a test case from a component:*
> >
> > java -jar ofbiz.jar -test -component='order' -case='salesOrder-test'
> >
> > I may be completely wrong here but just want to confirm and understand
> your
> > proposal.
> >
> > Best regards,
> >
> > Pranay Pandey
> > HotWax Systems
> > http://www.hotwaxsystems.com/
> >
> > On Wed, Jun 8, 2016 at 2:41 PM, Taher Alkhateeb <
> > slidingfilame...@gmail.com>
> > wrote:
> >
> > > Hello Everyone,
> > >
> > > After refactoring the start component and while starting on the base
> > > component I realized that the testing framework for OFBiz is not good.
> > You
> > > cannot do real test driven development or red-green-refactor with the
> > > current setup, hence my proposal to change it. I explain below:
> > >
> > > Problem with current design
> > > 
> > > - What we have right now is not unit tests, it's really integration
> > tests.
> > > You have to start the framework, the database, the service engine, the
> > > entity engine and pretty much everything.
> > > - Testing is very slow, because it's an integration test as I mentioned
> > > above. 10 minutes on a good computer!
> > > - There is zero mocking! We actually have to --load-data for things to
> > > work. Again, these are integration tests.
> > > - Too complex: Integration tests by their nature are grabbing too much.
> > > Mind you, I am not objecting to integration tests (I actually like
> them)
> > > but I am objecting to not having real unit-tests. Unit tests should all
> > run
> > > in a few seconds.
> > >
> > > Proposed solution
> > > --
> > > - We keep what is considered real integration tests the way they are
> > right
> > > now and keep using them
> > > - We move what should be unit tests into simple JUnit classes, and we
> do
> > > not run them using java -jar ofbiz.jar --test, but instead run them
> > > directly from the build.xml script, so these files are not identified
> in
> > > any XML document, but are simply called immediately from the build
> > scripts.
> > > - We clearly mark the difference between integration tests and unit
> tests
> > > (inside the source files or in the suite declarations).
> > > - We change the run-tests target in build.xml to run both unit tests
> and
> > > integration tests.
> > >
> > > I intend to heavily refactor the framework and I would feel better
> about
> > > introducing this change while refactoring. What do you guys think?
> Ideas?
> > > Suggestions? Approvals and thumbs up?
> > >
> > > Regards,
> > >
> > > Taher Alkhateeb
> > >
> >
>

Re: [DISCUSSION] Setting Up Mentoring

[Sharan-F]

Hi All

A quick update - I've sent out the Hipchat invitations and see people have
already responded and are in the Hipchat room. As mentioned please take a
look around. We have the OFBiz room, and also private chat. I think it also
works on a range of devices too.

Thanks
Sharan








--
View this message in context: 
http://ofbiz.135035.n4.nabble.com/DISCUSSION-Setting-Up-Mentoring-tp4682877p4682895.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.

[jira] [Commented] (OFBIZ-7204) Arrange UI labels in alphabetic order

[Shivangi Tanwar (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320346#comment-15320346
 ] 

Shivangi Tanwar commented on OFBIZ-7204:


Here is the patch with proper fix and aligned UiLabels alphabetically according 
to best practices

> Arrange UI labels in alphabetic order
> -
>
> Key: OFBIZ-7204
> URL: https://issues.apache.org/jira/browse/OFBIZ-7204
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Mridul Pathak
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7204_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7206) Marketing : Arrange UI labels in alphabetic order

[Shivangi Tanwar (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320345#comment-15320345
 ] 

Shivangi Tanwar commented on OFBIZ-7206:


Here is the patch with proper fix and aligned UiLabels alphabetically according 
to best practices

> Marketing : Arrange UI labels in alphabetic order
> -
>
> Key: OFBIZ-7206
> URL: https://issues.apache.org/jira/browse/OFBIZ-7206
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: marketing
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Mridul Pathak
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7206_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7246) Workeffort : Arrange UI labels in alphabetic order

[Shivangi Tanwar (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320344#comment-15320344
 ] 

Shivangi Tanwar commented on OFBIZ-7246:


Here is the patch with proper fix and aligned UiLabels alphabetically according 
to best practices

> Workeffort : Arrange UI labels in alphabetic order
> --
>
> Key: OFBIZ-7246
> URL: https://issues.apache.org/jira/browse/OFBIZ-7246
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: workeffort
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7246_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7211) Content : Arrange UI labels in alphabetic order

[Shivangi Tanwar (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320343#comment-15320343
 ] 

Shivangi Tanwar commented on OFBIZ-7211:


Here is the patch with proper fix and aligned UiLabels alphabetically according 
to best practices.

> Content : Arrange UI labels in alphabetic order
> ---
>
> Key: OFBIZ-7211
> URL: https://issues.apache.org/jira/browse/OFBIZ-7211
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Mridul Pathak
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7211_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Proposal to modify the testing framework for OFBiz

[Taher Alkhateeb]

Hi Divesh,

Yes correct. To give you a metaphor, think of integration tests as taking
your car and driving it to make sure it works, and think of unit tests like
checking your car engine piece by piece in isolation by measuring and
inspecting every piece by itself.

You can read here for more information:
http://www.jamesshore.com/Blog/Red-Green-Refactor.html
https://en.wikipedia.org/wiki/Test-driven_development

Regards,

Taher Alkhateeb

On Wed, Jun 8, 2016 at 1:07 PM, Divesh Dutta  wrote:

> Hi Taher,
>
> What I understand from your proposal is, we will like to test a small unit
> which can be a Java method as well. And framework does not allows that. And
> you want to introduce such support in framework . Is that what you mean ?
>
> And if this what you are thinking, then I think its nice proposal.
>
> Also this article by Martin Fowler on Unit test is good read:
> http://martinfowler.com/bliki/UnitTest.html
>
>
> Thanks
> --
> Divesh Dutta.
>
> On Wed, Jun 8, 2016 at 3:02 PM, Taher Alkhateeb <
> slidingfilame...@gmail.com>
> wrote:
>
> > Hi Pranay,
> >
> > What you are talking about is integration tests (ones that you can run
> per
> > component)
> >
> > Unit tests do not need to be run per component. The entire unit test
> > library for the entire framework should run in probably less than 5
> > seconds. So there is no need to make them run per component.
> >
> > My proposal is to simply have a target like run-unit-tests which would
> run
> > all the unit tests. These tests do not talk to the database or server or
> > anything, You can run them while flying in an airplane 30,000 feet above
> > the ocean.
> >
> > Mind you I will not remove the integration tests, I'm just adding unit
> > tests (and probably moving some integration tests to unit tests).
> >
> > Naturally, my proposition means that those tests are only JUnit tests
> (for
> > now) but that is a quick solution that I think is rather clean because
> > we're not really radically modifying anything, we're just adding JUnit
> > classes and running them.
> >
> > Regards,
> >
> > Taher Alkhateeb
> >
> > On Wed, Jun 8, 2016 at 12:23 PM, Pranay Pandey <
> > pranay.pan...@hotwaxsystems.com> wrote:
> >
> > > Hi Taher,
> > >
> > > There is one thing that I want to confirm based my understanding, as
> long
> > > as I know, we can run tests independently as well e.g.
> > >
> > > *Running tests for a component: *
> > >
> > > java -jar ofbiz.jar -test component=‘order’
> > >
> > > *Running a specific test Suite from a component:*
> > >
> > > ant run-single-test-suite -Dtest.component=‘order’ -Dtest.suiteName='
> > > ordertests'
> > >
> > > *Running a test case from a component:*
> > >
> > > java -jar ofbiz.jar -test -component='order' -case='salesOrder-test'
> > >
> > > I may be completely wrong here but just want to confirm and understand
> > your
> > > proposal.
> > >
> > > Best regards,
> > >
> > > Pranay Pandey
> > > HotWax Systems
> > > http://www.hotwaxsystems.com/
> > >
> > > On Wed, Jun 8, 2016 at 2:41 PM, Taher Alkhateeb <
> > > slidingfilame...@gmail.com>
> > > wrote:
> > >
> > > > Hello Everyone,
> > > >
> > > > After refactoring the start component and while starting on the base
> > > > component I realized that the testing framework for OFBiz is not
> good.
> > > You
> > > > cannot do real test driven development or red-green-refactor with the
> > > > current setup, hence my proposal to change it. I explain below:
> > > >
> > > > Problem with current design
> > > > 
> > > > - What we have right now is not unit tests, it's really integration
> > > tests.
> > > > You have to start the framework, the database, the service engine,
> the
> > > > entity engine and pretty much everything.
> > > > - Testing is very slow, because it's an integration test as I
> mentioned
> > > > above. 10 minutes on a good computer!
> > > > - There is zero mocking! We actually have to --load-data for things
> to
> > > > work. Again, these are integration tests.
> > > > - Too complex: Integration tests by their nature are grabbing too
> much.
> > > > Mind you, I am not objecting to integration tests (I actually like
> > them)
> > > > but I am objecting to not having real unit-tests. Unit tests should
> all
> > > run
> > > > in a few seconds.
> > > >
> > > > Proposed solution
> > > > --
> > > > - We keep what is considered real integration tests the way they are
> > > right
> > > > now and keep using them
> > > > - We move what should be unit tests into simple JUnit classes, and we
> > do
> > > > not run them using java -jar ofbiz.jar --test, but instead run them
> > > > directly from the build.xml script, so these files are not identified
> > in
> > > > any XML document, but are simply called immediately from the build
> > > scripts.
> > > > - We clearly mark the difference between integration tests and unit
> > tests
> > > > (inside the source files or in the suite 

[jira] [Updated] (OFBIZ-7248) Improve the layout of PDF documents

[Mohammad Kathawala (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mohammad Kathawala updated OFBIZ-7248:
--
Description: 
The layout of all the PDF documents in OFBiz like Order, Invoice, Picklist, 
Shipment etc. does not look very good and is not very readable for end users. 
We need to have a properly structured PDF documents which is easy to read.

I am going  to create sub-tasks of this parent task for all the different 
objects.  

  was:
The structure of all the PDF documents of various objects in OFBiz like Order, 
Invoice, Picklist, Shipment etc. does not look very good and is not very 
readable. We need to have a properly structured PDF documents which is easy to 
read.

I am going to create sub-tasks of this parent task for all the different 
objects.  


> Improve the layout of PDF documents
> ---
>
> Key: OFBIZ-7248
> URL: https://issues.apache.org/jira/browse/OFBIZ-7248
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Mohammad Kathawala
> Fix For: Trunk
>
>
> The layout of all the PDF documents in OFBiz like Order, Invoice, Picklist, 
> Shipment etc. does not look very good and is not very readable for end users. 
> We need to have a properly structured PDF documents which is easy to read.
> I am going  to create sub-tasks of this parent task for all the different 
> objects.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7248) Improve the layout of PDF documents

[Mohammad Kathawala (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mohammad Kathawala updated OFBIZ-7248:
--
Summary: Improve the layout of PDF documents  (was: Improve the structure 
of PDF documents)

> Improve the layout of PDF documents
> ---
>
> Key: OFBIZ-7248
> URL: https://issues.apache.org/jira/browse/OFBIZ-7248
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Mohammad Kathawala
> Fix For: Trunk
>
>
> The structure of all the PDF documents of various objects in OFBiz like 
> Order, Invoice, Picklist, Shipment etc. does not look very good and is not 
> very readable. We need to have a properly structured PDF documents which is 
> easy to read.
> I am going to create sub-tasks of this parent task for all the different 
> objects.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Proposal to modify the testing framework for OFBiz

[Divesh Dutta]

Hi Taher,

What I understand from your proposal is, we will like to test a small unit
which can be a Java method as well. And framework does not allows that. And
you want to introduce such support in framework . Is that what you mean ?

And if this what you are thinking, then I think its nice proposal.

Also this article by Martin Fowler on Unit test is good read:
http://martinfowler.com/bliki/UnitTest.html


Thanks
--
Divesh Dutta.

On Wed, Jun 8, 2016 at 3:02 PM, Taher Alkhateeb 
wrote:

> Hi Pranay,
>
> What you are talking about is integration tests (ones that you can run per
> component)
>
> Unit tests do not need to be run per component. The entire unit test
> library for the entire framework should run in probably less than 5
> seconds. So there is no need to make them run per component.
>
> My proposal is to simply have a target like run-unit-tests which would run
> all the unit tests. These tests do not talk to the database or server or
> anything, You can run them while flying in an airplane 30,000 feet above
> the ocean.
>
> Mind you I will not remove the integration tests, I'm just adding unit
> tests (and probably moving some integration tests to unit tests).
>
> Naturally, my proposition means that those tests are only JUnit tests (for
> now) but that is a quick solution that I think is rather clean because
> we're not really radically modifying anything, we're just adding JUnit
> classes and running them.
>
> Regards,
>
> Taher Alkhateeb
>
> On Wed, Jun 8, 2016 at 12:23 PM, Pranay Pandey <
> pranay.pan...@hotwaxsystems.com> wrote:
>
> > Hi Taher,
> >
> > There is one thing that I want to confirm based my understanding, as long
> > as I know, we can run tests independently as well e.g.
> >
> > *Running tests for a component: *
> >
> > java -jar ofbiz.jar -test component=‘order’
> >
> > *Running a specific test Suite from a component:*
> >
> > ant run-single-test-suite -Dtest.component=‘order’ -Dtest.suiteName='
> > ordertests'
> >
> > *Running a test case from a component:*
> >
> > java -jar ofbiz.jar -test -component='order' -case='salesOrder-test'
> >
> > I may be completely wrong here but just want to confirm and understand
> your
> > proposal.
> >
> > Best regards,
> >
> > Pranay Pandey
> > HotWax Systems
> > http://www.hotwaxsystems.com/
> >
> > On Wed, Jun 8, 2016 at 2:41 PM, Taher Alkhateeb <
> > slidingfilame...@gmail.com>
> > wrote:
> >
> > > Hello Everyone,
> > >
> > > After refactoring the start component and while starting on the base
> > > component I realized that the testing framework for OFBiz is not good.
> > You
> > > cannot do real test driven development or red-green-refactor with the
> > > current setup, hence my proposal to change it. I explain below:
> > >
> > > Problem with current design
> > > 
> > > - What we have right now is not unit tests, it's really integration
> > tests.
> > > You have to start the framework, the database, the service engine, the
> > > entity engine and pretty much everything.
> > > - Testing is very slow, because it's an integration test as I mentioned
> > > above. 10 minutes on a good computer!
> > > - There is zero mocking! We actually have to --load-data for things to
> > > work. Again, these are integration tests.
> > > - Too complex: Integration tests by their nature are grabbing too much.
> > > Mind you, I am not objecting to integration tests (I actually like
> them)
> > > but I am objecting to not having real unit-tests. Unit tests should all
> > run
> > > in a few seconds.
> > >
> > > Proposed solution
> > > --
> > > - We keep what is considered real integration tests the way they are
> > right
> > > now and keep using them
> > > - We move what should be unit tests into simple JUnit classes, and we
> do
> > > not run them using java -jar ofbiz.jar --test, but instead run them
> > > directly from the build.xml script, so these files are not identified
> in
> > > any XML document, but are simply called immediately from the build
> > scripts.
> > > - We clearly mark the difference between integration tests and unit
> tests
> > > (inside the source files or in the suite declarations).
> > > - We change the run-tests target in build.xml to run both unit tests
> and
> > > integration tests.
> > >
> > > I intend to heavily refactor the framework and I would feel better
> about
> > > introducing this change while refactoring. What do you guys think?
> Ideas?
> > > Suggestions? Approvals and thumbs up?
> > >
> > > Regards,
> > >
> > > Taher Alkhateeb
> > >
> >
>

[jira] [Created] (OFBIZ-7248) Improve the structure of PDF documents

[Mohammad Kathawala (JIRA)]

Mohammad Kathawala created OFBIZ-7248:
-

 Summary: Improve the structure of PDF documents
 Key: OFBIZ-7248
 URL: https://issues.apache.org/jira/browse/OFBIZ-7248
 Project: OFBiz
  Issue Type: Improvement
Reporter: Mohammad Kathawala
 Fix For: Trunk


The structure of all the PDF documents of various objects in OFBiz like Order, 
Invoice, Picklist, Shipment etc. does not look very good and is not very 
readable. We need to have a properly structured PDF documents which is easy to 
read.

I am going to create sub-tasks of this parent task for all the different 
objects.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [DISCUSSION] Setting Up Mentoring

[Taher Alkhateeb]

Great Initiative, I'm already signed up and I look forward to helping
anyone interested.

On Wed, Jun 8, 2016 at 11:36 AM, Sharan-F  wrote:

> Hi Everyone
>
> I've created a page on the wiki to try and organise the mentoring. We have
> a
> list of people who volunteered to be mentors, so if you want to be a
> mentor,
> then please feel free to add your name ot this list.
>
> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Mentors
>
> I'm very conscious of the fact that we dont want to overload the mentors so
> I suggest that we initially focus the mentoring on the framework
> re-factoring work. This is a specific area where we know there is a lot of
> complicated and difficult code that could be hard to understand.
>
> My suggestion would be that anyone who has a re-factor task could be paired
> up with a mentor to help them with it in case they encounter problems. What
> do people think about this idea?
>
> I've also been looking at different ways in which the mentoring could take
> place. We need somewhere that is easy to use, and if one mentor isnt
> available, a question could perhaps be managed by someone else. We could
> make use of our existing IRC channel, Skype or Hipchat.
>
> I think our IRC channel is underused which shows that people prefer not to
> use it much. Skype is also an  option but out of the three I think Hipchat
> could be a good to look at. It is the main communication method  used by
> our
> ASF Infra team if you need to talk to anyone urgently and from experience I
> know it works really well. We already have a Hipchat OFBiz room setup so
> could easily implement something similar to ASF Infra with our mentors or
> even create a group where our committers could hangout and quickly contact
> each other.
>
> In the past we talked about having a committers space where they could come
> together, get to know each other and collaborate more, but never set
> anything up so this could also be an opportunity to do that. I will send
> out
> some invitations to our committers to join the Hipchat OFBiz room so you
> can
> take a look around and see what you think.
>
> As usual I'm happy to get feedback on any of the points raised.
>
> Thanks
> Sharan
>
>
>
> --
> View this message in context:
> http://ofbiz.135035.n4.nabble.com/DISCUSSION-Setting-Up-Mentoring-tp4682877.html
> Sent from the OFBiz - Dev mailing list archive at Nabble.com.
>

Re: Proposal to modify the testing framework for OFBiz

[gil portenseigne]

Same here : +1

Gil

On 08/06/2016 11:24, Jacques Le Roux wrote:

That sounds like a more than reasonable proposition to me

+ 1

Jacques


Le 08/06/2016 à 11:11, Taher Alkhateeb a écrit :

Hello Everyone,

After refactoring the start component and while starting on the base
component I realized that the testing framework for OFBiz is not 
good. You

cannot do real test driven development or red-green-refactor with the
current setup, hence my proposal to change it. I explain below:

Problem with current design

- What we have right now is not unit tests, it's really integration 
tests.

You have to start the framework, the database, the service engine, the
entity engine and pretty much everything.
- Testing is very slow, because it's an integration test as I mentioned
above. 10 minutes on a good computer!
- There is zero mocking! We actually have to --load-data for things to
work. Again, these are integration tests.
- Too complex: Integration tests by their nature are grabbing too much.
Mind you, I am not objecting to integration tests (I actually like them)
but I am objecting to not having real unit-tests. Unit tests should 
all run

in a few seconds.

Proposed solution
--
- We keep what is considered real integration tests the way they are 
right

now and keep using them
- We move what should be unit tests into simple JUnit classes, and we do
not run them using java -jar ofbiz.jar --test, but instead run them
directly from the build.xml script, so these files are not identified in
any XML document, but are simply called immediately from the build 
scripts.
- We clearly mark the difference between integration tests and unit 
tests

(inside the source files or in the suite declarations).
- We change the run-tests target in build.xml to run both unit tests and
integration tests.

I intend to heavily refactor the framework and I would feel better about
introducing this change while refactoring. What do you guys think? 
Ideas?

Suggestions? Approvals and thumbs up?

Regards,

Taher Alkhateeb

Re: Proposal to modify the testing framework for OFBiz

[Taher Alkhateeb]

Hi Pranay,

What you are talking about is integration tests (ones that you can run per
component)

Unit tests do not need to be run per component. The entire unit test
library for the entire framework should run in probably less than 5
seconds. So there is no need to make them run per component.

My proposal is to simply have a target like run-unit-tests which would run
all the unit tests. These tests do not talk to the database or server or
anything, You can run them while flying in an airplane 30,000 feet above
the ocean.

Mind you I will not remove the integration tests, I'm just adding unit
tests (and probably moving some integration tests to unit tests).

Naturally, my proposition means that those tests are only JUnit tests (for
now) but that is a quick solution that I think is rather clean because
we're not really radically modifying anything, we're just adding JUnit
classes and running them.

Regards,

Taher Alkhateeb

On Wed, Jun 8, 2016 at 12:23 PM, Pranay Pandey <
pranay.pan...@hotwaxsystems.com> wrote:

> Hi Taher,
>
> There is one thing that I want to confirm based my understanding, as long
> as I know, we can run tests independently as well e.g.
>
> *Running tests for a component: *
>
> java -jar ofbiz.jar -test component=‘order’
>
> *Running a specific test Suite from a component:*
>
> ant run-single-test-suite -Dtest.component=‘order’ -Dtest.suiteName='
> ordertests'
>
> *Running a test case from a component:*
>
> java -jar ofbiz.jar -test -component='order' -case='salesOrder-test'
>
> I may be completely wrong here but just want to confirm and understand your
> proposal.
>
> Best regards,
>
> Pranay Pandey
> HotWax Systems
> http://www.hotwaxsystems.com/
>
> On Wed, Jun 8, 2016 at 2:41 PM, Taher Alkhateeb <
> slidingfilame...@gmail.com>
> wrote:
>
> > Hello Everyone,
> >
> > After refactoring the start component and while starting on the base
> > component I realized that the testing framework for OFBiz is not good.
> You
> > cannot do real test driven development or red-green-refactor with the
> > current setup, hence my proposal to change it. I explain below:
> >
> > Problem with current design
> > 
> > - What we have right now is not unit tests, it's really integration
> tests.
> > You have to start the framework, the database, the service engine, the
> > entity engine and pretty much everything.
> > - Testing is very slow, because it's an integration test as I mentioned
> > above. 10 minutes on a good computer!
> > - There is zero mocking! We actually have to --load-data for things to
> > work. Again, these are integration tests.
> > - Too complex: Integration tests by their nature are grabbing too much.
> > Mind you, I am not objecting to integration tests (I actually like them)
> > but I am objecting to not having real unit-tests. Unit tests should all
> run
> > in a few seconds.
> >
> > Proposed solution
> > --
> > - We keep what is considered real integration tests the way they are
> right
> > now and keep using them
> > - We move what should be unit tests into simple JUnit classes, and we do
> > not run them using java -jar ofbiz.jar --test, but instead run them
> > directly from the build.xml script, so these files are not identified in
> > any XML document, but are simply called immediately from the build
> scripts.
> > - We clearly mark the difference between integration tests and unit tests
> > (inside the source files or in the suite declarations).
> > - We change the run-tests target in build.xml to run both unit tests and
> > integration tests.
> >
> > I intend to heavily refactor the framework and I would feel better about
> > introducing this change while refactoring. What do you guys think? Ideas?
> > Suggestions? Approvals and thumbs up?
> >
> > Regards,
> >
> > Taher Alkhateeb
> >
>

[jira] [Updated] (OFBIZ-7247) Humanres : Arrange UI Labels in alphabetic order according to best practice

[Shivangi Tanwar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shivangi Tanwar updated OFBIZ-7247:
---
Attachment: OFBIZ-7247_trunk.patch

Here is the patch with proper fix and aligned UiLabels alphabetically according 
to best practices.


> Humanres : Arrange UI Labels in alphabetic order according to best practice
> ---
>
> Key: OFBIZ-7247
> URL: https://issues.apache.org/jira/browse/OFBIZ-7247
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: humanres
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7247_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [DISCUSSION] Setting Up Mentoring

[Jacques Le Roux]

I use HipChat to meet the infra team for a year now and I very like it.

I did not know we (OFBiz) had a HipChat room :-o , I will volunteer as mentor

Thanks Sharan!

Jacques


Le 08/06/2016 à 10:36, Sharan-F a écrit :

Hi Everyone

I've created a page on the wiki to try and organise the mentoring. We have a
list of people who volunteered to be mentors, so if you want to be a mentor,
then please feel free to add your name ot this list.

https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Mentors

I'm very conscious of the fact that we dont want to overload the mentors so
I suggest that we initially focus the mentoring on the framework
re-factoring work. This is a specific area where we know there is a lot of
complicated and difficult code that could be hard to understand.

My suggestion would be that anyone who has a re-factor task could be paired
up with a mentor to help them with it in case they encounter problems. What
do people think about this idea?

I've also been looking at different ways in which the mentoring could take
place. We need somewhere that is easy to use, and if one mentor isnt
available, a question could perhaps be managed by someone else. We could
make use of our existing IRC channel, Skype or Hipchat.

I think our IRC channel is underused which shows that people prefer not to
use it much. Skype is also an  option but out of the three I think Hipchat
could be a good to look at. It is the main communication method  used by our
ASF Infra team if you need to talk to anyone urgently and from experience I
know it works really well. We already have a Hipchat OFBiz room setup so
could easily implement something similar to ASF Infra with our mentors or
even create a group where our committers could hangout and quickly contact
each other.

In the past we talked about having a committers space where they could come
together, get to know each other and collaborate more, but never set
anything up so this could also be an opportunity to do that. I will send out
some invitations to our committers to join the Hipchat OFBiz room so you can
take a look around and see what you think.

As usual I'm happy to get feedback on any of the points raised.

Thanks
Sharan



--
View this message in context: 
http://ofbiz.135035.n4.nabble.com/DISCUSSION-Setting-Up-Mentoring-tp4682877.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.

Re: Proposal to modify the testing framework for OFBiz

[Jacques Le Roux]

That sounds like a more than reasonable proposition to me

+ 1

Jacques


Le 08/06/2016 à 11:11, Taher Alkhateeb a écrit :

Hello Everyone,

After refactoring the start component and while starting on the base
component I realized that the testing framework for OFBiz is not good. You
cannot do real test driven development or red-green-refactor with the
current setup, hence my proposal to change it. I explain below:

Problem with current design

- What we have right now is not unit tests, it's really integration tests.
You have to start the framework, the database, the service engine, the
entity engine and pretty much everything.
- Testing is very slow, because it's an integration test as I mentioned
above. 10 minutes on a good computer!
- There is zero mocking! We actually have to --load-data for things to
work. Again, these are integration tests.
- Too complex: Integration tests by their nature are grabbing too much.
Mind you, I am not objecting to integration tests (I actually like them)
but I am objecting to not having real unit-tests. Unit tests should all run
in a few seconds.

Proposed solution
--
- We keep what is considered real integration tests the way they are right
now and keep using them
- We move what should be unit tests into simple JUnit classes, and we do
not run them using java -jar ofbiz.jar --test, but instead run them
directly from the build.xml script, so these files are not identified in
any XML document, but are simply called immediately from the build scripts.
- We clearly mark the difference between integration tests and unit tests
(inside the source files or in the suite declarations).
- We change the run-tests target in build.xml to run both unit tests and
integration tests.

I intend to heavily refactor the framework and I would feel better about
introducing this change while refactoring. What do you guys think? Ideas?
Suggestions? Approvals and thumbs up?

Regards,

Taher Alkhateeb

Re: Proposal to modify the testing framework for OFBiz

[Pranay Pandey]

Hi Taher,

There is one thing that I want to confirm based my understanding, as long
as I know, we can run tests independently as well e.g.

*Running tests for a component: *

java -jar ofbiz.jar -test component=‘order’

*Running a specific test Suite from a component:*

ant run-single-test-suite -Dtest.component=‘order’ -Dtest.suiteName='
ordertests'

*Running a test case from a component:*

java -jar ofbiz.jar -test -component='order' -case='salesOrder-test'

I may be completely wrong here but just want to confirm and understand your
proposal.

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Wed, Jun 8, 2016 at 2:41 PM, Taher Alkhateeb 
wrote:

> Hello Everyone,
>
> After refactoring the start component and while starting on the base
> component I realized that the testing framework for OFBiz is not good. You
> cannot do real test driven development or red-green-refactor with the
> current setup, hence my proposal to change it. I explain below:
>
> Problem with current design
> 
> - What we have right now is not unit tests, it's really integration tests.
> You have to start the framework, the database, the service engine, the
> entity engine and pretty much everything.
> - Testing is very slow, because it's an integration test as I mentioned
> above. 10 minutes on a good computer!
> - There is zero mocking! We actually have to --load-data for things to
> work. Again, these are integration tests.
> - Too complex: Integration tests by their nature are grabbing too much.
> Mind you, I am not objecting to integration tests (I actually like them)
> but I am objecting to not having real unit-tests. Unit tests should all run
> in a few seconds.
>
> Proposed solution
> --
> - We keep what is considered real integration tests the way they are right
> now and keep using them
> - We move what should be unit tests into simple JUnit classes, and we do
> not run them using java -jar ofbiz.jar --test, but instead run them
> directly from the build.xml script, so these files are not identified in
> any XML document, but are simply called immediately from the build scripts.
> - We clearly mark the difference between integration tests and unit tests
> (inside the source files or in the suite declarations).
> - We change the run-tests target in build.xml to run both unit tests and
> integration tests.
>
> I intend to heavily refactor the framework and I would feel better about
> introducing this change while refactoring. What do you guys think? Ideas?
> Suggestions? Approvals and thumbs up?
>
> Regards,
>
> Taher Alkhateeb
>

[jira] [Created] (OFBIZ-7247) Humanres : Arrange UI Labels in alphabetic order according to best practice

[Shivangi Tanwar (JIRA)]

Shivangi Tanwar created OFBIZ-7247:
--

 Summary: Humanres : Arrange UI Labels in alphabetic order 
according to best practice
 Key: OFBIZ-7247
 URL: https://issues.apache.org/jira/browse/OFBIZ-7247
 Project: OFBiz
  Issue Type: Sub-task
  Components: humanres
Affects Versions: Trunk
Reporter: Shivangi Tanwar
Priority: Minor
 Fix For: Trunk






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[DISCUSSION] Setting Up Mentoring

[Sharan-F]

Hi Everyone

I've created a page on the wiki to try and organise the mentoring. We have a
list of people who volunteered to be mentors, so if you want to be a mentor,
then please feel free to add your name ot this list.

https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Mentors

I'm very conscious of the fact that we dont want to overload the mentors so
I suggest that we initially focus the mentoring on the framework
re-factoring work. This is a specific area where we know there is a lot of
complicated and difficult code that could be hard to understand. 

My suggestion would be that anyone who has a re-factor task could be paired
up with a mentor to help them with it in case they encounter problems. What
do people think about this idea?

I've also been looking at different ways in which the mentoring could take
place. We need somewhere that is easy to use, and if one mentor isnt
available, a question could perhaps be managed by someone else. We could
make use of our existing IRC channel, Skype or Hipchat.  

I think our IRC channel is underused which shows that people prefer not to
use it much. Skype is also an  option but out of the three I think Hipchat
could be a good to look at. It is the main communication method  used by our
ASF Infra team if you need to talk to anyone urgently and from experience I
know it works really well. We already have a Hipchat OFBiz room setup so
could easily implement something similar to ASF Infra with our mentors or
even create a group where our committers could hangout and quickly contact
each other.

In the past we talked about having a committers space where they could come
together, get to know each other and collaborate more, but never set
anything up so this could also be an opportunity to do that. I will send out
some invitations to our committers to join the Hipchat OFBiz room so you can
take a look around and see what you think. 

As usual I'm happy to get feedback on any of the points raised.

Thanks
Sharan



--
View this message in context: 
http://ofbiz.135035.n4.nabble.com/DISCUSSION-Setting-Up-Mentoring-tp4682877.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.

[jira] [Commented] (OFBIZ-7184) 'Data Source Id' should be editable/visible on error view screen of createDataSource

[Pranay Pandey (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320273#comment-15320273
 ] 

Pranay Pandey commented on OFBIZ-7184:
--

Thanks Deepak, 

I am also thinking, why dataSourceId on the form at first place a not required 
field? and secondly Why shouldn't we auto-sequence it in service if not 
supplied by the user?

The issue can be fixed up anyway but form design should be giving user a 
predictable behavior.

If you look at the screen definition dataSourceId is being set from parameters 
and as this is the case of Create and not update, you don't get the 
dataSourceId. 
{code}

{code}
If not found in parameter it should have been set to null, that's the issue we 
have at framework level.



> 'Data Source Id' should be editable/visible on error view screen of 
> createDataSource
> 
>
> Key: OFBIZ-7184
> URL: https://issues.apache.org/jira/browse/OFBIZ-7184
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing
>Affects Versions: Trunk
>Reporter: Chandan Khandelwal
>Assignee: Vaibhav Jain
> Attachments: screenshot-1.png
>
>
> Steps to regenerate the issue-
> # Go to https://localhost:8443/marketing/control/main
> # Click on sub-menu DataSource
> # Click on create data source
> # Click "Save" without filling input fields
> # Instead of input field, label is shown Could not be found: []
> (Please refer screenshot for more details)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7205) Create party resume not working. ResumeId doesn't have text field to enter

[Gil Portenseigne (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320271#comment-15320271
 ] 

Gil Portenseigne commented on OFBIZ-7205:
-

Tell me if i'm wrong but the Human Ressource component Goal is to manage our 
society employees.

Partymgr goal is to manage every known party in the system. In some cases, i 
would like to manage skills/CV of any party, without him employed in my company 
?

Skill/CV are a general data applying to a party, so why not leave it into 
partymgr ? 


> Create party resume not working. ResumeId doesn't have text field to enter
> --
>
> Key: OFBIZ-7205
> URL: https://issues.apache.org/jira/browse/OFBIZ-7205
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Amardeep Singh Jhajj
>Assignee: Amardeep Singh Jhajj
> Attachments: OFBIZ-7205-Screen-Shot.png
>
>
> Please refer attached screenshot.
> Steps to regenerate:
> 1. Go to 
> https://localhost:8443/partymgr/control/EditPartyResumes?partyId=admin.
> 2. Create Resume form does not have ResumeId text field. Cannot add resume to 
> party from here.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Proposal to modify the testing framework for OFBiz

[Taher Alkhateeb]

Hello Everyone,

After refactoring the start component and while starting on the base
component I realized that the testing framework for OFBiz is not good. You
cannot do real test driven development or red-green-refactor with the
current setup, hence my proposal to change it. I explain below:

Problem with current design

- What we have right now is not unit tests, it's really integration tests.
You have to start the framework, the database, the service engine, the
entity engine and pretty much everything.
- Testing is very slow, because it's an integration test as I mentioned
above. 10 minutes on a good computer!
- There is zero mocking! We actually have to --load-data for things to
work. Again, these are integration tests.
- Too complex: Integration tests by their nature are grabbing too much.
Mind you, I am not objecting to integration tests (I actually like them)
but I am objecting to not having real unit-tests. Unit tests should all run
in a few seconds.

Proposed solution
--
- We keep what is considered real integration tests the way they are right
now and keep using them
- We move what should be unit tests into simple JUnit classes, and we do
not run them using java -jar ofbiz.jar --test, but instead run them
directly from the build.xml script, so these files are not identified in
any XML document, but are simply called immediately from the build scripts.
- We clearly mark the difference between integration tests and unit tests
(inside the source files or in the suite declarations).
- We change the run-tests target in build.xml to run both unit tests and
integration tests.

I intend to heavily refactor the framework and I would feel better about
introducing this change while refactoring. What do you guys think? Ideas?
Suggestions? Approvals and thumbs up?

Regards,

Taher Alkhateeb

[jira] [Commented] (OFBIZ-7205) Create party resume not working. ResumeId doesn't have text field to enter

[Pierre Smits (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320255#comment-15320255
 ] 

Pierre Smits commented on OFBIZ-7205:
-

Could you elaborate on this 'in practice mode: If I want to check)? In what 
kind of role/permission scheme do you envision this to happen in party and not 
in humanres?

It seem to me that there is some kind of misunderstanding of an appropriate 
business case/scenario here.

> Create party resume not working. ResumeId doesn't have text field to enter
> --
>
> Key: OFBIZ-7205
> URL: https://issues.apache.org/jira/browse/OFBIZ-7205
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Amardeep Singh Jhajj
>Assignee: Amardeep Singh Jhajj
> Attachments: OFBIZ-7205-Screen-Shot.png
>
>
> Please refer attached screenshot.
> Steps to regenerate:
> 1. Go to 
> https://localhost:8443/partymgr/control/EditPartyResumes?partyId=admin.
> 2. Create Resume form does not have ResumeId text field. Cannot add resume to 
> party from here.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7246) Workeffort : Arrange UI labels in alphabetic order

[Shivangi Tanwar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shivangi Tanwar updated OFBIZ-7246:
---
Attachment: OFBIZ-7246_trunk.patch

> Workeffort : Arrange UI labels in alphabetic order
> --
>
> Key: OFBIZ-7246
> URL: https://issues.apache.org/jira/browse/OFBIZ-7246
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: workeffort
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7246_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7218) Refactor components regarding groovy file locations

[Jacques Le Roux (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320242#comment-15320242
 ] 

Jacques Le Roux commented on OFBIZ-7218:


Following [Nicolas's 
comment|https://issues.apache.org/jira/browse/OFBIZ-6810?focusedCommentId=15201384]
 I also suggested to move minilang scripts from 
component://componentname/script/org/ofbiz 
to 
component://componentname/minilang
I'll create a Jira for that



> Refactor components regarding groovy file locations
> ---
>
> Key: OFBIZ-7218
> URL: https://issues.apache.org/jira/browse/OFBIZ-7218
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
>
> This is a placeholder issue to capture all tasks and related issues regarding 
> the refactoring of the directory structure of .groovy files.
> See related discussion: http://ofbiz.markmail.org/message/25dse4jke2fp64mx
> Nicolas Malin's comments from OFBIZ-6810
> {quote}
> http://markmail.org/thread/kyhgfykfiwhz#query:+page:1+mid:hemokyhcnpe4w5rn+state:results
> At the question :
> Regard to the issue, we have no problem for the java and minilang files 
> but the groovy need a community decision.
> A) All groovy script under the same path src/main/groovy/...
> B) Separate Groovy compiled and scripted like this src/main/groovy/... 
> (pre-compiled Groovy) src/main/scripts/... (parsed Groovy scripts)
> C) Separate Groovy compiled and scripted like this groovy/... 
> (pre-compiled Groovy) groovyScripts/... (parsed Groovy scripts, groovyScripts 
> rather that script because other script languages could be used in the future)
> D) other if you have an ingenious idea
> the result is :
> Total are :
> A) -5
> B) 0
> C) +7
> D) No other proposal
> Now we can move all groovy script present on 
> component://componentname/webapp/componentname/WEB-INF/actions/script.groovy 
> to component://componentname/groovyscript/script.groovy
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7246) Workeffort : Arrange UI labels in alphabetic order

[Shivangi Tanwar (JIRA)]

Shivangi Tanwar created OFBIZ-7246:
--

 Summary: Workeffort : Arrange UI labels in alphabetic order
 Key: OFBIZ-7246
 URL: https://issues.apache.org/jira/browse/OFBIZ-7246
 Project: OFBiz
  Issue Type: Sub-task
  Components: workeffort
Affects Versions: Trunk
Reporter: Shivangi Tanwar
Priority: Minor
 Fix For: Trunk






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7205) Create party resume not working. ResumeId doesn't have text field to enter

[Montalbano Florian (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320198#comment-15320198
 ] 

Montalbano Florian commented on OFBIZ-7205:
---

We could remove the actions 'add' and 'edit' in the Party component but let the 
possibility to view these informations from this component. I'm trying to think 
in practice mode : If I want to check both the Resume and the Skills of a 
Party, it may be nice to have these as tabs in the Party component, but only 
with read-only mode. 

By the way, the problem of the JIRA comes from the 
PartySrcreens#EditPartyResumes from the Party component. It was lacking the 
line :
{code}  {code}
in the action of the screen. Then in the form PartyResumeForms#EditPartyResume 
, the condition 
{code}{code}
was triggered somehow (this may mean that a non defined map is not 'null' but 
something else). And then, the field was displayed with no 'resumeId' defined.

And the list of resumes from the Party component was not working too. In the 
same screen than before PartySrcreens#EditPartyResumes, the following setting 
was missing :
{code}  
{code}
This "partyResumeCtx" is used as the input field map in the form 
PartyResumeForms#ListPartyResumes. So, the form was searching resume without 
information about the partyId.



> Create party resume not working. ResumeId doesn't have text field to enter
> --
>
> Key: OFBIZ-7205
> URL: https://issues.apache.org/jira/browse/OFBIZ-7205
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Amardeep Singh Jhajj
>Assignee: Amardeep Singh Jhajj
> Attachments: OFBIZ-7205-Screen-Shot.png
>
>
> Please refer attached screenshot.
> Steps to regenerate:
> 1. Go to 
> https://localhost:8443/partymgr/control/EditPartyResumes?partyId=admin.
> 2. Create Resume form does not have ResumeId text field. Cannot add resume to 
> party from here.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7205) Create party resume not working. ResumeId doesn't have text field to enter

[Pierre Smits (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320178#comment-15320178
 ] 

Pierre Smits commented on OFBIZ-7205:
-

Yes, lets wait a few days more and then close this issue with 'Won't implement' 
and create a new issue regarding the removal of HR functionalities (widgets, 
freemarker templates, groovy scripts, services and controller.xml refs) in the 
Party component.

But we have to ensure that we don't remove HR functionality in Party that is 
not in the special purpose Humanres component. That should move to the Humanres 
component.

> Create party resume not working. ResumeId doesn't have text field to enter
> --
>
> Key: OFBIZ-7205
> URL: https://issues.apache.org/jira/browse/OFBIZ-7205
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Amardeep Singh Jhajj
>Assignee: Amardeep Singh Jhajj
> Attachments: OFBIZ-7205-Screen-Shot.png
>
>
> Please refer attached screenshot.
> Steps to regenerate:
> 1. Go to 
> https://localhost:8443/partymgr/control/EditPartyResumes?partyId=admin.
> 2. Create Resume form does not have ResumeId text field. Cannot add resume to 
> party from here.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-6215) Have delete function of data in webtools - entity management present a failsafe.

[Pierre Smits (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-6215:

Component/s: (was: framework)
 framework/webtools

> Have delete function of data in webtools - entity management present a 
> failsafe.
> 
>
> Key: OFBIZ-6215
> URL: https://issues.apache.org/jira/browse/OFBIZ-6215
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Arun Patidar
>  Labels: entities, records, webtools
>
> When accessing an entity (or entity record) in webtools - entitiy management 
> and wanting to delete a record, the entity record is immediately deleted. 
> However, this can seriously hamper operations. It is therefore better to have 
> a failsafe in place that asks the user whether he is sure that the record is 
> to be deleted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7216) Error with GL Account Trial Balance pdf

[Ashish Vijaywargiya (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Vijaywargiya reassigned OFBIZ-7216:
--

Assignee: Ashish Vijaywargiya  (was: Ravi Lodhi)

> Error with GL Account Trial Balance pdf
> ---
>
> Key: OFBIZ-7216
> URL: https://issues.apache.org/jira/browse/OFBIZ-7216
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Ravi Lodhi
>Assignee: Ashish Vijaywargiya
> Attachments: OFBIZ-7216_trunk.patch
>
>
> Steps to regenerate:
> 1) Go to Accounting -> Organization GL Settings
> 2) Go to the accounting page of any Available Internal Accounting 
> Organizations
> 3) Now go to Reports -> GL Account Trial Balance.
> 4) Generate pdf and see the error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)