[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system

2016-06-30 Thread Jacques Le Roux (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358448#comment-15358448
 ] 

Jacques Le Roux commented on OFBIZ-7534:


If ever it can help
{code}
C:\projectASF-Mars\ofbiz>gradlew --stacktrace 'ofbiz --start'
Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8

FAILURE: Build failed with an exception.

* What went wrong:
Task ''ofbiz' not found in root project 'ofbiz'.

* Try:
Run gradlew tasks to get a list of available tasks. Run with --info or --debug 
option to get more log output.

* Exception is:
org.gradle.execution.TaskSelectionException: Task ''ofbiz' not found in root 
project 'ofbiz'.
at org.gradle.execution.TaskSelector.getSelection(TaskSelector.java:100)
at org.gradle.execution.TaskSelector.getSelection(TaskSelector.java:75)
at 
org.gradle.execution.commandline.CommandLineTaskParser.parseTasks(CommandLineTaskParser.java:42)
at 
org.gradle.execution.TaskNameResolvingBuildConfigurationAction.configure(TaskNameResolvingBuildConfigurationAction.java:44)
at 
org.gradle.execution.DefaultBuildConfigurationActionExecuter.configure(DefaultBuildConfigurationActionExecuter.java:48)
at 
org.gradle.execution.DefaultBuildConfigurationActionExecuter.access$000(DefaultBuildConfigurationActionExecuter.java:25)
at 
org.gradle.execution.DefaultBuildConfigurationActionExecuter$1.proceed(DefaultBuildConfigurationActionExecuter.java:54)
at 
org.gradle.execution.DefaultTasksBuildExecutionAction.configure(DefaultTasksBuildExecutionAction.java:44)
at 
org.gradle.execution.DefaultBuildConfigurationActionExecuter.configure(DefaultBuildConfigurationActionExecuter.java:48)
at 
org.gradle.execution.DefaultBuildConfigurationActionExecuter.access$000(DefaultBuildConfigurationActionExecuter.java:25)
at 
org.gradle.execution.DefaultBuildConfigurationActionExecuter$1.proceed(DefaultBuildConfigurationActionExecuter.java:54)
at 
org.gradle.execution.ExcludedTaskFilteringBuildConfigurationAction.configure(ExcludedTaskFilteringBuildConfigurationAction.java:47)
at 
org.gradle.execution.DefaultBuildConfigurationActionExecuter.configure(DefaultBuildConfigurationActionExecuter.java:48)
at 
org.gradle.execution.DefaultBuildConfigurationActionExecuter.select(DefaultBuildConfigurationActionExecuter.java:36)
at 
org.gradle.initialization.DefaultGradleLauncher$3.run(DefaultGradleLauncher.java:143)
at org.gradle.internal.Factories$1.create(Factories.java:22)
at 
org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:90)
at 
org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:52)
at 
org.gradle.initialization.DefaultGradleLauncher.doBuildStages(DefaultGradleLauncher.java:140)
at 
org.gradle.initialization.DefaultGradleLauncher.access$200(DefaultGradleLauncher.java:32)
at 
org.gradle.initialization.DefaultGradleLauncher$1.create(DefaultGradleLauncher.java:99)
at 
org.gradle.initialization.DefaultGradleLauncher$1.create(DefaultGradleLauncher.java:93)
at 
org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:90)
at 
org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:62)
at 
org.gradle.initialization.DefaultGradleLauncher.doBuild(DefaultGradleLauncher.java:93)
at 
org.gradle.initialization.DefaultGradleLauncher.run(DefaultGradleLauncher.java:82)
at 
org.gradle.launcher.exec.InProcessBuildActionExecuter$DefaultBuildController.run(InProcessBuildActionExecuter.java:94)
at 
org.gradle.tooling.internal.provider.ExecuteBuildActionRunner.run(ExecuteBuildActionRunner.java:28)
at 
org.gradle.launcher.exec.ChainingBuildActionRunner.run(ChainingBuildActionRunner.java:35)
at 
org.gradle.launcher.exec.InProcessBuildActionExecuter.execute(InProcessBuildActionExecuter.java:43)
at 
org.gradle.launcher.exec.InProcessBuildActionExecuter.execute(InProcessBuildActionExecuter.java:28)
at 
org.gradle.launcher.exec.ContinuousBuildActionExecuter.execute(ContinuousBuildActionExecuter.java:81)
at 
org.gradle.launcher.exec.ContinuousBuildActionExecuter.execute(ContinuousBuildActionExecuter.java:46)
at 
org.gradle.launcher.exec.DaemonUsageSuggestingBuildActionExecuter.execute(DaemonUsageSuggestingBuildActionExecuter.java:51)
at 
org.gradle.launcher.exec.DaemonUsageSuggestingBuildActionExecuter.execute(DaemonUsageSuggestingBuildActionExecuter.java:28)
at org.gradle.launcher.cli.RunBuildAction.run(RunBuildAction.java:43)
at 
org.gradle.internal.Actions$RunnableActionAdapter.execute(Actions.java:173)
at

[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system

2016-06-30 Thread Jacques Le Roux (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358445#comment-15358445
 ] 

Jacques Le Roux commented on OFBIZ-7534:


OK, one worry less, I was expecting something like that :)

> Migrate OFBiz from Apache Ant to Gradle build system
> 
>
> Key: OFBIZ-7534
> URL: https://issues.apache.org/jira/browse/OFBIZ-7534
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
>  Labels: ant, build-tools, gradle
> Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, 
> OFBIZ-7534.patch, OFBIZ-7534.patch, build.gradle, gradle-wrapper.jar
>
>
> This is a major refactoring task referring to the [email 
> thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle]
>  in which the community voted for the switch after a proposal from the PMC
> The purpose of this JIRA is to achieve the following objectives
> - Fully implement a working compiling system in Gradle that passes all tests
> - Remove all ant and maven build scripts from the system
> - update the documentation of the system to reflect these changes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system

2016-06-30 Thread Jacques Le Roux (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358443#comment-15358443
 ] 

Jacques Le Roux commented on OFBIZ-7534:


Thanks Jacopo,

Nope, Taher said me the same (it's not in the README/MD), but I get the same 
with the trailing quote, weird(?) :/

> Migrate OFBiz from Apache Ant to Gradle build system
> 
>
> Key: OFBIZ-7534
> URL: https://issues.apache.org/jira/browse/OFBIZ-7534
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
>  Labels: ant, build-tools, gradle
> Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, 
> OFBIZ-7534.patch, OFBIZ-7534.patch, build.gradle, gradle-wrapper.jar
>
>
> This is a major refactoring task referring to the [email 
> thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle]
>  in which the community voted for the switch after a proposal from the PMC
> The purpose of this JIRA is to achieve the following objectives
> - Fully implement a working compiling system in Gradle that passes all tests
> - Remove all ant and maven build scripts from the system
> - update the documentation of the system to reflect these changes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system

2016-06-30 Thread Jacopo Cappellato (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358435#comment-15358435
 ] 

Jacopo Cappellato commented on OFBIZ-7534:
--

[~jacques.le.roux] In Gradle you have full control on the version of a given 
library; you are not limited to download the latest version.

> Migrate OFBiz from Apache Ant to Gradle build system
> 
>
> Key: OFBIZ-7534
> URL: https://issues.apache.org/jira/browse/OFBIZ-7534
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
>  Labels: ant, build-tools, gradle
> Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, 
> OFBIZ-7534.patch, OFBIZ-7534.patch, build.gradle, gradle-wrapper.jar
>
>
> This is a major refactoring task referring to the [email 
> thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle]
>  in which the community voted for the switch after a proposal from the PMC
> The purpose of this JIRA is to achieve the following objectives
> - Fully implement a working compiling system in Gradle that passes all tests
> - Remove all ant and maven build scripts from the system
> - update the documentation of the system to reflect these changes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system

2016-06-30 Thread Jacques Le Roux (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358436#comment-15358436
 ] 

Jacques Le Roux commented on OFBIZ-7534:


This said I'll indeed try to facilitate the communications ;)

> Migrate OFBiz from Apache Ant to Gradle build system
> 
>
> Key: OFBIZ-7534
> URL: https://issues.apache.org/jira/browse/OFBIZ-7534
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
>  Labels: ant, build-tools, gradle
> Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, 
> OFBIZ-7534.patch, OFBIZ-7534.patch, build.gradle, gradle-wrapper.jar
>
>
> This is a major refactoring task referring to the [email 
> thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle]
>  in which the community voted for the switch after a proposal from the PMC
> The purpose of this JIRA is to achieve the following objectives
> - Fully implement a working compiling system in Gradle that passes all tests
> - Remove all ant and maven build scripts from the system
> - update the documentation of the system to reflect these changes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system

2016-06-30 Thread Jacopo Cappellato (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358432#comment-15358432
 ] 

Jacopo Cappellato commented on OFBIZ-7534:
--

[~jacques.le.roux] I think you are missing the trailing ' character:
{code}
gradlew 'ofbiz --start'
{code}


> Migrate OFBiz from Apache Ant to Gradle build system
> 
>
> Key: OFBIZ-7534
> URL: https://issues.apache.org/jira/browse/OFBIZ-7534
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
>  Labels: ant, build-tools, gradle
> Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, 
> OFBIZ-7534.patch, OFBIZ-7534.patch, build.gradle, gradle-wrapper.jar
>
>
> This is a major refactoring task referring to the [email 
> thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle]
>  in which the community voted for the switch after a proposal from the PMC
> The purpose of this JIRA is to achieve the following objectives
> - Fully implement a working compiling system in Gradle that passes all tests
> - Remove all ant and maven build scripts from the system
> - update the documentation of the system to reflect these changes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system

2016-06-30 Thread Jacques Le Roux (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358428#comment-15358428
 ] 

Jacques Le Roux commented on OFBIZ-7534:


Jacopo, Taher,

About Birt and Solr, this is what I fear with the changes with Gradle. I dont' 
know exactly either for Birt and Solr, but if ever we have OOTB code connected 
to (eg) specific Birt or Solr versions we will need to clean things in our code 
(or in Gradle setting?) if Gradle blindly downloads the last versions. For 
instance how to decide to pick Tomcat 8, 8.5 or 9? 

Also you know I put in place the OWASP Dependency Check (I have to work on that 
again, we have few vulnerabilites) I wonder if/how we will have to tweak Gradle 
to handle those aspects, still in haze for now, anyway steps after steps... ;)

> Migrate OFBiz from Apache Ant to Gradle build system
> 
>
> Key: OFBIZ-7534
> URL: https://issues.apache.org/jira/browse/OFBIZ-7534
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
>  Labels: ant, build-tools, gradle
> Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, 
> OFBIZ-7534.patch, OFBIZ-7534.patch, build.gradle, gradle-wrapper.jar
>
>
> This is a major refactoring task referring to the [email 
> thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle]
>  in which the community voted for the switch after a proposal from the PMC
> The purpose of this JIRA is to achieve the following objectives
> - Fully implement a working compiling system in Gradle that passes all tests
> - Remove all ant and maven build scripts from the system
> - update the documentation of the system to reflect these changes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system

2016-06-30 Thread Jacques Le Roux (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358426#comment-15358426
 ] 

Jacques Le Roux commented on OFBIZ-7534:


Hi Taher,

I just began to test. Here are some things I noticed so far. As you may know 
I'm working on WIndows and I got this during my 1st build
{code}
C:\projectASF-Mars\ofbiz>gradlew
:compileJava
C:\projectASF-Mars\ofbiz\framework\common\src\org\ofbiz\common\UrlServletHelper.java:249:
 error: unmappable character for encoding Cp1252
str = str.replace("´╝?", "-");
 ^
[3 other cases like that...]
{code}
I never saw (noticed?) that before and just learnt that a complete and 
definitive fix is to set JAVA_TOOL_OPTIONS env var to  -Dfile.encoding=UTF8. I 
report this here for others and I guess a word in the README.MD and the wiki 
would fit.

Apart that build and test went perfectly well. After using "gradlew eclipse" I 
got a cleaned .project but an awful .classpath :D. I guess it's no longer an 
issue for us if it builds correctly (good riddance). I though noticed in 
Eclipse (after several refreshs there) that Eclipse complained absurdly about 
the classpath, an Eclipse restart fixed that!

About README.MD and the .bat prefix. You don't need to put the prefix to run 
the commands. So "gradlew.bat cleanAll loadDefault" should be "gradlew cleanAll 
loadDefault", etc.

I tried
bq. gradlew 'ofbiz --start
but got
{code}
C:\projectASF-Mars\ofbiz>gradlew 'ofbiz --start
Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8

FAILURE: Build failed with an exception.

* What went wrong:
Task ''ofbiz' not found in root project 'ofbiz'.

* Try:
Run gradlew tasks to get a list of available tasks. Run with --stacktrace 
option to get the stack trace. Run with --info or --debug option to get more 
log output.

BUILD FAILED

Total time: 2.465 secs

C:\projectASF-Mars\ofbiz>
{code}
What could I miss?


> Migrate OFBiz from Apache Ant to Gradle build system
> 
>
> Key: OFBIZ-7534
> URL: https://issues.apache.org/jira/browse/OFBIZ-7534
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
>  Labels: ant, build-tools, gradle
> Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, 
> OFBIZ-7534.patch, OFBIZ-7534.patch, build.gradle, gradle-wrapper.jar
>
>
> This is a major refactoring task referring to the [email 
> thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle]
>  in which the community voted for the switch after a proposal from the PMC
> The purpose of this JIRA is to achieve the following objectives
> - Fully implement a working compiling system in Gradle that passes all tests
> - Remove all ant and maven build scripts from the system
> - update the documentation of the system to reflect these changes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7611) Track userlogin for status change

2016-06-30 Thread Nameet Jain (JIRA) 

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nameet Jain updated OFBIZ-7611:
---
Attachment: OFBIZ-7611.patch

Hi  [~soledad]

I already had a patch for 'entity-auto' and now attaching it to this task.

Only concern I am having is that other status entities (like OrderStatus) do 
not have 'changeByUserLoginId' field. They have fields with the diferent name 
for the same purpose. So do we need to do something about it? 
Please take a look at the patch and share your inputs.

> Track userlogin for status change
> -
>
> Key: OFBIZ-7611
> URL: https://issues.apache.org/jira/browse/OFBIZ-7611
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Nameet Jain
>Assignee: Nicolas Malin
> Attachments: OFBIZ-7611.patch
>
>
> Currently in OFBiz, 'changedByUserLoginId' field is missing from status 
> entities (like: ShipmentStatus). Using this field we can maintain the history 
> for each status change made by user.
> Update all respective service and events to ensure this field gets updated.
> Here is the list of entities with missing this field.
> 1. BudgetStatus
> 2. ContactListCommStatus
> 3. CustRequestStatus
> 4. ExampleStatus
> 5. FinAccountStatus
> 6. InventoryItemStatus
> 7. InvoiceStatus
> 8. PartyStatus
> 9. RequirementStatus
> 10. ShipmentStatus



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-7682) Define and add new entity for 'Check' as Payment Method

2016-06-30 Thread Swapnil Shah (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358339#comment-15358339
 ] 

Swapnil Shah edited comment on OFBIZ-7682 at 7/1/16 4:01 AM:
-

I feel checkbook number is also one kind of recurring information (like check#) 
although with lesser frequency. i.e., As soon as all check leafs are consumed 
then it is definitely bound to lose its existence physically and would no 
longer be in use. Not too sure but it might be better fit for payment reference 
(something like Payment.paymentRefNum)

Apart from this i think all other field mapping makes sense and are in sync 
with ticket description.




was (Author: swash78):
I feel checkbook number is also one kind of recurring information (like check#) 
although with lesser frequency. i.e., As soon as all check leafs are consumed 
then it is definitely bound to lose its existence physically and would no 
longer be in use. Not too sure but it might be better fit for payment reference.

Apart from this i think all other field mapping makes sense and are in sync 
with ticket description.



> Define and add new entity for 'Check' as Payment Method
> ---
>
> Key: OFBIZ-7682
> URL: https://issues.apache.org/jira/browse/OFBIZ-7682
> Project: OFBiz
>  Issue Type: New Feature
>  Components: accounting
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
>
> Based on the concluded requirement on OFBIZ-6899. Let's define Check as new 
> entity as follows (somewhat on similar lines as EFT_ACCOUNT) so as to store 
> all relevant details related to Check used as payment method for any party.
> PAYMENT_METHOD_ID (PK & FK with PAYMENT_METHOD)
> BANK_NAME
> ROUTING_NUMBER
> ACCOUNT_TYPE
> ACCOUNT_NUMBER
> NAME_ON_ACCOUNT
> COMPANY_NAME_ON_ACCOUNT
> CONTACT_MECH_ID (FK with CONTACT_MECH & POSTAL_ADDRESS)
> LAST_UPDATED_STAMP
> LAST_UPDATED_TX_STAMP
> CREATED_STAMP
> CREATED_TX_STAMP



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-7682) Define and add new entity for 'Check' as Payment Method

2016-06-30 Thread Swapnil Shah (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358339#comment-15358339
 ] 

Swapnil Shah edited comment on OFBIZ-7682 at 7/1/16 4:03 AM:
-

I feel checkbook number is also one kind of recurring information (like check#) 
although with lesser frequency. i.e., As soon as all check leafs are consumed 
then it is definitely bound to lose its existence physically and would no 
longer be in use. Not too sure but it might be better fit for payment reference 
(something like Payment.paymentRefNum)

Apart from this i think all other field mapping makes sense and are in sync 
with ticket description. One addition detail probably we can add here is 
"BRANCH_CODE" so that it completes the trail for storing all Bank related 
information




was (Author: swash78):
I feel checkbook number is also one kind of recurring information (like check#) 
although with lesser frequency. i.e., As soon as all check leafs are consumed 
then it is definitely bound to lose its existence physically and would no 
longer be in use. Not too sure but it might be better fit for payment reference 
(something like Payment.paymentRefNum)

Apart from this i think all other field mapping makes sense and are in sync 
with ticket description.



> Define and add new entity for 'Check' as Payment Method
> ---
>
> Key: OFBIZ-7682
> URL: https://issues.apache.org/jira/browse/OFBIZ-7682
> Project: OFBiz
>  Issue Type: New Feature
>  Components: accounting
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
>
> Based on the concluded requirement on OFBIZ-6899. Let's define Check as new 
> entity as follows (somewhat on similar lines as EFT_ACCOUNT) so as to store 
> all relevant details related to Check used as payment method for any party.
> PAYMENT_METHOD_ID (PK & FK with PAYMENT_METHOD)
> BANK_NAME
> ROUTING_NUMBER
> ACCOUNT_TYPE
> ACCOUNT_NUMBER
> NAME_ON_ACCOUNT
> COMPANY_NAME_ON_ACCOUNT
> CONTACT_MECH_ID (FK with CONTACT_MECH & POSTAL_ADDRESS)
> LAST_UPDATED_STAMP
> LAST_UPDATED_TX_STAMP
> CREATED_STAMP
> CREATED_TX_STAMP



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7682) Define and add new entity for 'Check' as Payment Method

2016-06-30 Thread Swapnil Shah (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358339#comment-15358339
 ] 

Swapnil Shah commented on OFBIZ-7682:
-

I feel checkbook number is also one kind of recurring information (like check#) 
although with lesser frequency. i.e., As soon as all check leafs are consumed 
then it is definitely bound to lose its existence physically and would no 
longer be in use. Not too sure but it might be better fit for payment reference.

Apart from this i think all other field mapping makes sense and are in sync 
with ticket description.



> Define and add new entity for 'Check' as Payment Method
> ---
>
> Key: OFBIZ-7682
> URL: https://issues.apache.org/jira/browse/OFBIZ-7682
> Project: OFBiz
>  Issue Type: New Feature
>  Components: accounting
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
>
> Based on the concluded requirement on OFBIZ-6899. Let's define Check as new 
> entity as follows (somewhat on similar lines as EFT_ACCOUNT) so as to store 
> all relevant details related to Check used as payment method for any party.
> PAYMENT_METHOD_ID (PK & FK with PAYMENT_METHOD)
> BANK_NAME
> ROUTING_NUMBER
> ACCOUNT_TYPE
> ACCOUNT_NUMBER
> NAME_ON_ACCOUNT
> COMPANY_NAME_ON_ACCOUNT
> CONTACT_MECH_ID (FK with CONTACT_MECH & POSTAL_ADDRESS)
> LAST_UPDATED_STAMP
> LAST_UPDATED_TX_STAMP
> CREATED_STAMP
> CREATED_TX_STAMP



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7682) Define and add new entity for 'Check' as Payment Method

2016-06-30 Thread Pierre Smits (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357873#comment-15357873
 ] 

Pierre Smits commented on OFBIZ-7682:
-

I agree.

> Define and add new entity for 'Check' as Payment Method
> ---
>
> Key: OFBIZ-7682
> URL: https://issues.apache.org/jira/browse/OFBIZ-7682
> Project: OFBiz
>  Issue Type: New Feature
>  Components: accounting
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
>
> Based on the concluded requirement on OFBIZ-6899. Let's define Check as new 
> entity as follows (somewhat on similar lines as EFT_ACCOUNT) so as to store 
> all relevant details related to Check used as payment method for any party.
> PAYMENT_METHOD_ID (PK & FK with PAYMENT_METHOD)
> BANK_NAME
> ROUTING_NUMBER
> ACCOUNT_TYPE
> ACCOUNT_NUMBER
> NAME_ON_ACCOUNT
> COMPANY_NAME_ON_ACCOUNT
> CONTACT_MECH_ID (FK with CONTACT_MECH & POSTAL_ADDRESS)
> LAST_UPDATED_STAMP
> LAST_UPDATED_TX_STAMP
> CREATED_STAMP
> CREATED_TX_STAMP



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-7682) Define and add new entity for 'Check' as Payment Method

2016-06-30 Thread Jacques Le Roux (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357828#comment-15357828
 ] 

Jacques Le Roux edited comment on OFBIZ-7682 at 6/30/16 8:52 PM:
-

Not sure it's of much use but I'd add a checkbookNumber field. Also no need to 
put the *_STAMP field those are automatically generated (except if set 
otherwise). I'd also add the same relations EftAccount has, so with 
PaymentMethod, ContactMech and PostalAddress. It would then be:
{code}

  
  
  
  
  
  
  
  
  
  
  
  

  
  

  
  

  

{code}

BTW, for the sake of the analysis, I'm not sure the yearsAtBank is useful. Even 
in the EftAccount, it's never used OOTB. And this characteristic is more a 
relation between 2 parties. So I don't see the need to have it there. It should 
be modeled otherwise.



was (Author: jacques.le.roux):
Not sure it's of much use but I'd add a checkbookNumber field. Also no need to 
put the *_STAMP field those are automatically generated (except if set 
otherwise). I'd also add the same relations EftAccount has, so with 
PaymentMethod, ContactMech and PostalAddress. It would then be:
{code}

  
  
  
  
  
  
  
  
  
  
  
  

  
  

  
  

  

{code}

BTW, for the sake of the analysis, I'm not sure the yearsAtBank is useful. Even 
in the EftAccount, it's never used OOTB. And this characteristic is more a 
relation between 2 parties. So I don't see the need to have it there. It should 
be modeled otherwise.


> Define and add new entity for 'Check' as Payment Method
> ---
>
> Key: OFBIZ-7682
> URL: https://issues.apache.org/jira/browse/OFBIZ-7682
> Project: OFBiz
>  Issue Type: New Feature
>  Components: accounting
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
>
> Based on the concluded requirement on OFBIZ-6899. Let's define Check as new 
> entity as follows (somewhat on similar lines as EFT_ACCOUNT) so as to store 
> all relevant details related to Check used as payment method for any party.
> PAYMENT_METHOD_ID (PK & FK with PAYMENT_METHOD)
> BANK_NAME
> ROUTING_NUMBER
> ACCOUNT_TYPE
> ACCOUNT_NUMBER
> NAME_ON_ACCOUNT
> COMPANY_NAME_ON_ACCOUNT
> CONTACT_MECH_ID (FK with CONTACT_MECH & POSTAL_ADDRESS)
> LAST_UPDATED_STAMP
> LAST_UPDATED_TX_STAMP
> CREATED_STAMP
> CREATED_TX_STAMP



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-7682) Define and add new entity for 'Check' as Payment Method

2016-06-30 Thread Jacques Le Roux (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357828#comment-15357828
 ] 

Jacques Le Roux edited comment on OFBIZ-7682 at 6/30/16 8:52 PM:
-

Not sure it's of much use but I'd add a checkbookNumber field. Also no need to 
put the *_STAMP field those are automatically generated (except if set 
otherwise). I'd also add the same relations EftAccount has, so with 
PaymentMethod, ContactMech and PostalAddress. It would then be:
{code}

  
  
  
  
  
  
  
  
  
  
  
  

  
  

  
  

  

{code}

BTW, for the sake of the analysis, I'm not sure the yearsAtBank is useful. Even 
in the EftAccount, it's never used OOTB. And this characteristic is more a 
relation between 2 parties. So I don't see the need to have it there. It should 
be modeled otherwise.



was (Author: jacques.le.roux):
Not sure it's of much use but I'd add a checkbookNumber field. Also no need to 
put the *_STAMP field those are automatically generated (except if set 
otherwise). I'd also add the same relations EftAccount has, so with 
PaymentMethod, ContactMech and PostalAddress. It would then be:
{code}

  
  
  
  
  
  
  
  
  
  
  
  

  
  

  
  

  

{code}

BTW, for the sake of the analysis, I'm not sure the yearsAtBank is useful. Even 
in the EftAccount, it's never used OOTB. And this characteristic is more a 
relation between 2 parties. So I don't see the need to have it there. It should 
be modeled otherwise.


> Define and add new entity for 'Check' as Payment Method
> ---
>
> Key: OFBIZ-7682
> URL: https://issues.apache.org/jira/browse/OFBIZ-7682
> Project: OFBiz
>  Issue Type: New Feature
>  Components: accounting
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
>
> Based on the concluded requirement on OFBIZ-6899. Let's define Check as new 
> entity as follows (somewhat on similar lines as EFT_ACCOUNT) so as to store 
> all relevant details related to Check used as payment method for any party.
> PAYMENT_METHOD_ID (PK & FK with PAYMENT_METHOD)
> BANK_NAME
> ROUTING_NUMBER
> ACCOUNT_TYPE
> ACCOUNT_NUMBER
> NAME_ON_ACCOUNT
> COMPANY_NAME_ON_ACCOUNT
> CONTACT_MECH_ID (FK with CONTACT_MECH & POSTAL_ADDRESS)
> LAST_UPDATED_STAMP
> LAST_UPDATED_TX_STAMP
> CREATED_STAMP
> CREATED_TX_STAMP



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7682) Deffine and add new entity for 'Check' as Payment Method

2016-06-30 Thread Jacques Le Roux (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357828#comment-15357828
 ] 

Jacques Le Roux commented on OFBIZ-7682:


Not sure it's of much use but I'd add a checkbookNumber field. Also no need to 
put the *_STAMP field those are automatically generated (except if set 
otherwise). I'd also add the same relations EftAccount has, so with 
PaymentMethod, ContactMech and PostalAddress. It would then be:
{code}

  
  
  
  
  
  
  
  
  
  
  
  

  
  

  
  

  

{code}

BTW, for the sake of the analysis, I'm not sure the yearsAtBank is useful. Even 
in the EftAccount, it's never used OOTB. And this characteristic is more a 
relation between 2 parties. So I don't see the need to have it there. It should 
be modeled otherwise.


> Deffine and add new entity for 'Check' as Payment Method
> 
>
> Key: OFBIZ-7682
> URL: https://issues.apache.org/jira/browse/OFBIZ-7682
> Project: OFBiz
>  Issue Type: New Feature
>  Components: accounting
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
>
> Based on the concluded requirement on OFBIZ-6899. Let's define Check as new 
> entity as follows (somewhat on similar lines as EFT_ACCOUNT) so as to store 
> all relevant details related to Check used as payment method for any party.
> PAYMENT_METHOD_ID (PK & FK with PAYMENT_METHOD)
> BANK_NAME
> ROUTING_NUMBER
> ACCOUNT_TYPE
> ACCOUNT_NUMBER
> NAME_ON_ACCOUNT
> COMPANY_NAME_ON_ACCOUNT
> CONTACT_MECH_ID (FK with CONTACT_MECH & POSTAL_ADDRESS)
> LAST_UPDATED_STAMP
> LAST_UPDATED_TX_STAMP
> CREATED_STAMP
> CREATED_TX_STAMP



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7682) Define and add new entity for 'Check' as Payment Method

2016-06-30 Thread Jacques Le Roux (JIRA) 

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-7682:
---
Summary: Define and add new entity for 'Check' as Payment Method  (was: 
Deffine and add new entity for 'Check' as Payment Method)

> Define and add new entity for 'Check' as Payment Method
> ---
>
> Key: OFBIZ-7682
> URL: https://issues.apache.org/jira/browse/OFBIZ-7682
> Project: OFBiz
>  Issue Type: New Feature
>  Components: accounting
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
>
> Based on the concluded requirement on OFBIZ-6899. Let's define Check as new 
> entity as follows (somewhat on similar lines as EFT_ACCOUNT) so as to store 
> all relevant details related to Check used as payment method for any party.
> PAYMENT_METHOD_ID (PK & FK with PAYMENT_METHOD)
> BANK_NAME
> ROUTING_NUMBER
> ACCOUNT_TYPE
> ACCOUNT_NUMBER
> NAME_ON_ACCOUNT
> COMPANY_NAME_ON_ACCOUNT
> CONTACT_MECH_ID (FK with CONTACT_MECH & POSTAL_ADDRESS)
> LAST_UPDATED_STAMP
> LAST_UPDATED_TX_STAMP
> CREATED_STAMP
> CREATED_TX_STAMP



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-6899) Overview of payment methods in party profile misses function to set company check payment

2016-06-30 Thread Jacques Le Roux (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-6899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15337036#comment-15337036
 ] 

Jacques Le Roux edited comment on OFBIZ-6899 at 6/30/16 8:45 PM:
-

Each check is associated with a bank account at a bank, they don't change, they 
are the stable part wich relies a check to a bank. If we need a recurring 
information I don't see better ones.

The ones which change are the checkbook number, the check number, the amount, 
the date and the location. The checkbook number complete the check number and 
together they are a couple which really defines the check. The checkbook number 
change only when the checkbook comes to an end. I don't see what is complicated 
here (apart maybe the checkbook number).


was (Author: jacques.le.roux):
Each check is associated with a bank account at a bank, they don't change, they 
are the stable part wich relies a check to a bank. If we need a recurring 
information I don't see better ones. 

The ones which change are the chequebook number, the check number, the amount, 
the date and the location. The chequebook number complete the check number and 
together they are a couple which really defines the check. The chequebook 
number change only when the chequebook comes to an end. I don't see what is 
complicated here (apart maybe the chequebook number).

> Overview of payment methods in party profile misses function to set company 
> check payment
> -
>
> Key: OFBIZ-6899
> URL: https://issues.apache.org/jira/browse/OFBIZ-6899
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting, order, party, specialpurpose/ecommerce
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Divesh Dutta
>  Labels: check, payment
> Fix For: Upcoming Branch
>
> Attachments: CC_1.png, CC_2.png, CC_3.png, CC_4.png, OFBIZ-6899.patch
>
>
> The payment methods overview in the party profile shows various options to 
> define and create a payment method.
> However there is no option to create payment method for a company check



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7611) Track userlogin for status change

2016-06-30 Thread Nicolas Malin (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357735#comment-15357735
 ] 

Nicolas Malin commented on OFBIZ-7611:
--

Nameet,

I am hesitant. I review your patch, no problem with you work. 
I just a doubt an the solution. I think we can realize a beautiful 
implementation of your initial proposition with improve the entity-auto and 
automatically manage this field and the statusDate by the engine.

You won't mind if I will try to improve the entity-engine before commit your 
works ?

> Track userlogin for status change
> -
>
> Key: OFBIZ-7611
> URL: https://issues.apache.org/jira/browse/OFBIZ-7611
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Nameet Jain
>Assignee: Nicolas Malin
>
> Currently in OFBiz, 'changedByUserLoginId' field is missing from status 
> entities (like: ShipmentStatus). Using this field we can maintain the history 
> for each status change made by user.
> Update all respective service and events to ensure this field gets updated.
> Here is the list of entities with missing this field.
> 1. BudgetStatus
> 2. ContactListCommStatus
> 3. CustRequestStatus
> 4. ExampleStatus
> 5. FinAccountStatus
> 6. InventoryItemStatus
> 7. InvoiceStatus
> 8. PartyStatus
> 9. RequirementStatus
> 10. ShipmentStatus



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7266) Auto-complete on lookup field should be able to support filter by date.

2016-06-30 Thread Nicolas Malin (JIRA) 

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin closed OFBIZ-7266.

   Resolution: Implemented
Fix Version/s: Upcoming Branch

I commited the last patch on trunk at rev 1750856

Thanks Kongrath for the submit and all other for remarks ;)

Pierre, you know, feel free to open issue for your ideas ^^

> Auto-complete on lookup field should be able to support filter by date.
> ---
>
> Key: OFBIZ-7266
> URL: https://issues.apache.org/jira/browse/OFBIZ-7266
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Kongrath Suankaewmanee
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7266-NMA.patch, OFBIZ-7266-NMA.patch, 
> OFBIZ-7266.patch
>
>
> Hi,
> For the general reason, if the lookup popup (like as performFind service 
> work) able to filter the result from date. so, in the auto complete for 
> lookup filed should be also able too.
> Simple :
> add this tag in action tag before call LookupDecorator
> and filter on field "fromDate", "thruDate" as default.
> {code:xml}
> 
> {code}
> Advance :
> you can customize "fromDate" and "thruDate" field names by do follow below
> {code:xml}
> 
> 
> 
> {code}
> Best Regards,
> Kongrath



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7682) Deffine and add new entity for 'Check' as Payment Method

2016-06-30 Thread Swapnil Shah (JIRA) 

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Shah updated OFBIZ-7682:

Description: 
Based on the concluded requirement on OFBIZ-6899. Let's define Check as new 
entity as follows (somewhat on similar lines as EFT_ACCOUNT) so as to store all 
relevant details related to Check used as payment method for any party.

PAYMENT_METHOD_ID (PK & FK with PAYMENT_METHOD)
BANK_NAME
ROUTING_NUMBER
ACCOUNT_TYPE
ACCOUNT_NUMBER
NAME_ON_ACCOUNT
COMPANY_NAME_ON_ACCOUNT
CONTACT_MECH_ID (FK with CONTACT_MECH & POSTAL_ADDRESS)
LAST_UPDATED_STAMP
LAST_UPDATED_TX_STAMP
CREATED_STAMP
CREATED_TX_STAMP


  was:
Based on the concluded requirement on OFBIZ-6899. Let's define Check as new 
entity as follows (somewhat on similar lines as EFT_ACCOUNT) so as to store all 
relevant details related to Check used as payment method for any party.

PAYMENT_METHOD_ID (PK & FK with PAYMENT_METHOD)
CHECK_TYPE (Can add related enumerations as PERSONAL_CHECK,COMPANY_CHECK & 
CERTIFIED_CHECK)
BANK_NAME
ROUTING_NUMBER
ACCOUNT_TYPE
ACCOUNT_NUMBER
NAME_ON_ACCOUNT
COMPANY_NAME_ON_ACCOUNT
CONTACT_MECH_ID (FK with CONTACT_MECH & POSTAL_ADDRESS)
LAST_UPDATED_STAMP
LAST_UPDATED_TX_STAMP
CREATED_STAMP
CREATED_TX_STAMP



> Deffine and add new entity for 'Check' as Payment Method
> 
>
> Key: OFBIZ-7682
> URL: https://issues.apache.org/jira/browse/OFBIZ-7682
> Project: OFBiz
>  Issue Type: New Feature
>  Components: accounting
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
>
> Based on the concluded requirement on OFBIZ-6899. Let's define Check as new 
> entity as follows (somewhat on similar lines as EFT_ACCOUNT) so as to store 
> all relevant details related to Check used as payment method for any party.
> PAYMENT_METHOD_ID (PK & FK with PAYMENT_METHOD)
> BANK_NAME
> ROUTING_NUMBER
> ACCOUNT_TYPE
> ACCOUNT_NUMBER
> NAME_ON_ACCOUNT
> COMPANY_NAME_ON_ACCOUNT
> CONTACT_MECH_ID (FK with CONTACT_MECH & POSTAL_ADDRESS)
> LAST_UPDATED_STAMP
> LAST_UPDATED_TX_STAMP
> CREATED_STAMP
> CREATED_TX_STAMP



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Check emails

2016-06-30 Thread Pierre Smits 
Checked!

Pierre Smits

ORRTIZ.COM 
OFBiz based solutions & services

OFBiz Extensions Marketplace
http://oem.ofbizci.net/oci-2/

On Thu, Jun 30, 2016 at 3:42 PM, Anil Patel 
wrote:

>
> Thanks and Regards
> Anil Patel
> COO
> Hotwax Systems
> http://www.hotwaxsystems.com/ 
> Cell: +1 509 398 3120
>
>

Check emails

2016-06-30 Thread Anil Patel 

Thanks and Regards
Anil Patel
COO
Hotwax Systems
http://www.hotwaxsystems.com/ 
Cell: +1 509 398 3120

[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system

2016-06-30 Thread Jacopo Cappellato (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357060#comment-15357060
 ] 

Jacopo Cappellato commented on OFBIZ-7534:
--

similar to birt:
all the jars in /specialpurpose/solr/lib/ are there because, from what I 
understand, the component contains actually a full solr distribution; 
maintaining all of them may be an overwhelming effort but there are users of 
this component and they may have the interest and resources to contribute this 
work ([~jacques.le.roux] may know more about them and could facilitate the 
communication).

> Migrate OFBiz from Apache Ant to Gradle build system
> 
>
> Key: OFBIZ-7534
> URL: https://issues.apache.org/jira/browse/OFBIZ-7534
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
>  Labels: ant, build-tools, gradle
> Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, 
> OFBIZ-7534.patch, OFBIZ-7534.patch, build.gradle, gradle-wrapper.jar
>
>
> This is a major refactoring task referring to the [email 
> thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle]
>  in which the community voted for the switch after a proposal from the PMC
> The purpose of this JIRA is to achieve the following objectives
> - Fully implement a working compiling system in Gradle that passes all tests
> - Remove all ant and maven build scripts from the system
> - update the documentation of the system to reflect these changes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system

2016-06-30 Thread Jacopo Cappellato (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357059#comment-15357059
 ] 

Jacopo Cappellato commented on OFBIZ-7534:
--

all the jars in /specialpurpose/birt/lib/ are there because, from what I 
understand, the component contains actually a full birt distribution; 
maintaining all of them may be an overwhelming effort but there are users of 
this component and they may have the interest and resources to contribute this 
work ([~jacques.le.roux] may know more about them and could facilitate the 
communication).

> Migrate OFBiz from Apache Ant to Gradle build system
> 
>
> Key: OFBIZ-7534
> URL: https://issues.apache.org/jira/browse/OFBIZ-7534
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
>  Labels: ant, build-tools, gradle
> Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, 
> OFBIZ-7534.patch, OFBIZ-7534.patch, build.gradle, gradle-wrapper.jar
>
>
> This is a major refactoring task referring to the [email 
> thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle]
>  in which the community voted for the switch after a proposal from the PMC
> The purpose of this JIRA is to achieve the following objectives
> - Fully implement a working compiling system in Gradle that passes all tests
> - Remove all ant and maven build scripts from the system
> - update the documentation of the system to reflect these changes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system

2016-06-30 Thread Jacopo Cappellato (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357052#comment-15357052
 ] 

Jacopo Cappellato commented on OFBIZ-7534:
--

As regards watermarker-0.0.4.jar: it seems like the jar is no more available in 
the public and there may be license concerns (i.e. we are not 100% sure of its 
origin) so we may have to remove it with the features/code dependent on it or 
refactor the code to use a different library. Volunteers?

> Migrate OFBiz from Apache Ant to Gradle build system
> 
>
> Key: OFBIZ-7534
> URL: https://issues.apache.org/jira/browse/OFBIZ-7534
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
>  Labels: ant, build-tools, gradle
> Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, 
> OFBIZ-7534.patch, OFBIZ-7534.patch, build.gradle, gradle-wrapper.jar
>
>
> This is a major refactoring task referring to the [email 
> thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle]
>  in which the community voted for the switch after a proposal from the PMC
> The purpose of this JIRA is to achieve the following objectives
> - Fully implement a working compiling system in Gradle that passes all tests
> - Remove all ant and maven build scripts from the system
> - update the documentation of the system to reflect these changes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system

2016-06-30 Thread Taher Alkhateeb (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15356955#comment-15356955
 ] 

Taher Alkhateeb edited comment on OFBIZ-7534 at 6/30/16 11:55 AM:
--

Okay, doing a bit of research, the listing of the JARs and their count in each 
component is listed below.

I would appreciate it if you can save me some time by pointing out which ones 
are not necessary and the code would compile without them.

||Component||Count of Jars||
|base|94|
|solr|43|
|birt|34|
|catalina|13|
|service|10|
|cmssite|6|
|pos|5|
|ebaystore|4|
|lucene|3|
|webapp|3|
|testtools|2|
|entity|2|
|content|2|
|product|2|
|start|1|
|demo-backup|1|
|ldap|1|
|geronimo|1|
|security|1|
|googlecheckout|1|
|*Total*|*229*|

The detailed listing of the Jars:

||component_group||component_name||JarFile||
|applications|content|./applications/content/lib/dom4j-1.6.1.jar|
|applications|content|./applications/content/lib/poi-3.13-20150929.jar|
|applications|product|./applications/product/lib/watermarker-0.0.4.jar|
|applications|product|./applications/product/lib/dozer-4.2.1.jar|
|framework|base|./framework/base/lib/scripting/bsh-2.0b4.jar|
|framework|base|./framework/base/lib/scripting/antlr-2.7.6.jar|
|framework|base|./framework/base/lib/scripting/jython-nooro.jar|
|framework|base|./framework/base/lib/scripting/jakarta-oro-2.0.8.jar|
|framework|base|./framework/base/lib/scripting/bsf-2.4.0.jar|
|framework|base|./framework/base/lib/scripting/asm-3.2.jar|
|framework|base|./framework/base/lib/scripting/groovy-all-2.4.5.jar|
|framework|base|./framework/base/lib/batik-all-1.8.jar|
|framework|base|./framework/base/lib/jdom-1.1.jar|
|framework|base|./framework/base/lib/ant-1.9.0-ant.jar|
|framework|base|./framework/base/lib/fop-2.1.jar|
|framework|base|./framework/base/lib/juel-impl-2.2.7.jar|
|framework|base|./framework/base/lib/log4j-nosql-2.3.jar|
|framework|base|./framework/base/lib/ant/ant-1.9.0-ant-apache-bsf.jar|
|framework|base|./framework/base/lib/ant/ant-contrib-1.0b3.jar|
|framework|base|./framework/base/lib/commons/commons-io-2.4.jar|
|framework|base|./framework/base/lib/commons/commons-logging-1.2.jar|
|framework|base|./framework/base/lib/commons/commons-lang-2.6.jar|
|framework|base|./framework/base/lib/commons/commons-compress-1.11.jar|
|framework|base|./framework/base/lib/commons/commons-pool2-2.3.jar|
|framework|base|./framework/base/lib/commons/commons-el-1.0.jar|
|framework|base|./framework/base/lib/commons/commons-codec-1.10.jar|
|framework|base|./framework/base/lib/commons/commons-fileupload-1.3.1.jar|
|framework|base|./framework/base/lib/commons/commons-csv-1.1.jar|
|framework|base|./framework/base/lib/commons/commons-net-3.3.jar|
|framework|base|./framework/base/lib/commons/commons-collections4-4.1.jar|
|framework|base|./framework/base/lib/commons/commons-beanutils-core-1.8.3.jar|
|framework|base|./framework/base/lib/commons/commons-validator-1.4.1.jar|
|framework|base|./framework/base/lib/xml-apis-ext-1.3.04.jar|
|framework|base|./framework/base/lib/xml-apis-1.4.01.jar|
|framework|base|./framework/base/lib/log4j-1.2-api-2.3.jar|
|framework|base|./framework/base/lib/log4j-slf4j-impl-2.3.jar|
|framework|base|./framework/base/lib/ant-1.9.0-ant-junit.jar|
|framework|base|./framework/base/lib/icu4j-57_1.jar|
|framework|base|./framework/base/lib/resolver-2.9.1.jar|
|framework|base|./framework/base/lib/barcode4j-2.1-barcode4j-fop-ext-complete.jar|
|framework|base|./framework/base/lib/xpp3-1.1.4c.jar|
|framework|base|./framework/base/lib/log4j-core-2.3.jar|
|framework|base|./framework/base/lib/junit-dep-4.10.jar|
|framework|base|./framework/base/lib/freemarker-2.3.24.jar|
|framework|base|./framework/base/lib/tika-parsers-1.12.jar|
|framework|base|./framework/base/lib/xmlrpc-client-3.1.2.jar|
|framework|base|./framework/base/lib/clhm-release-1.0-lru.jar|
|framework|base|./framework/base/lib/jpim-0.1.jar|
|framework|base|./framework/base/lib/xalan-2.7.2.jar|
|framework|base|./framework/base/lib/shiro-core-1.2.5.jar|
|framework|base|./framework/base/lib/mail-1.5.1.jar|
|framework|base|./framework/base/lib/pdfbox-1.8.12.jar|
|framework|base|./framework/base/lib/xmlrpc-common-3.1.2.jar|
|framework|base|./framework/base/lib/avalon-framework-4.2.0.jar|
|framework|base|./framework/base/lib/jempbox-1.8.11.jar|
|framework|base|./framework/base/lib/nekohtml-1.9.16.jar|
|framework|base|./framework/base/lib/jackson-core-2.4.2.jar|
|framework|base|./framework/base/lib/owasp-java-html-sanitizer-r239.jar|
|framework|base|./framework/base/lib/serializer-2.9.1.jar|
|framework|base|./framework/base/lib/httpclient-cache-4.4.1.jar|
|framework|base|./framework/base/lib/ical4j-1.0-rc2.jar|
|framework|base|./framework/base/lib/ws-commons-java5-1.0.1.jar|
|framework|base|./framework/base/lib/fontbox-1.8.11.jar|
|framework|base|./framework/base/lib/esapi-2.1.0.jar|
|framework|base|./framework/base/lib/xercesImpl-2.11.0.jar|

[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system

2016-06-30 Thread Taher Alkhateeb (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15356955#comment-15356955
 ] 

Taher Alkhateeb commented on OFBIZ-7534:


Okay, doing a bit of research, the listing of the JARs and their count in each 
component is listed below.

I would appreciate it if you can save me some time by pointing out which ones 
are not necessary and the code would compile without them.

||Component||Count of Jars||
|base|94|
|solr|43|
|birt|34|
|catalina|13|
|service|10|
|cmssite|6|
|pos|5|
|ebaystore|4|
|lucene|3|
|webapp|3|
|testtools|2|
|entity|2|
|content|2|
|product|2|
|start|1|
|demo-backup|1|
|ldap|1|
|geronimo|1|
|security|1|
|googlecheckout|1|
|Total*|*229*|

The detailed listing of the Jars:

||component_group||component_name||JarFile||
|applications|content|./applications/content/lib/dom4j-1.6.1.jar|
|applications|content|./applications/content/lib/poi-3.13-20150929.jar|
|applications|product|./applications/product/lib/watermarker-0.0.4.jar|
|applications|product|./applications/product/lib/dozer-4.2.1.jar|
|framework|base|./framework/base/lib/scripting/bsh-2.0b4.jar|
|framework|base|./framework/base/lib/scripting/antlr-2.7.6.jar|
|framework|base|./framework/base/lib/scripting/jython-nooro.jar|
|framework|base|./framework/base/lib/scripting/jakarta-oro-2.0.8.jar|
|framework|base|./framework/base/lib/scripting/bsf-2.4.0.jar|
|framework|base|./framework/base/lib/scripting/asm-3.2.jar|
|framework|base|./framework/base/lib/scripting/groovy-all-2.4.5.jar|
|framework|base|./framework/base/lib/batik-all-1.8.jar|
|framework|base|./framework/base/lib/jdom-1.1.jar|
|framework|base|./framework/base/lib/ant-1.9.0-ant.jar|
|framework|base|./framework/base/lib/fop-2.1.jar|
|framework|base|./framework/base/lib/juel-impl-2.2.7.jar|
|framework|base|./framework/base/lib/log4j-nosql-2.3.jar|
|framework|base|./framework/base/lib/ant/ant-1.9.0-ant-apache-bsf.jar|
|framework|base|./framework/base/lib/ant/ant-contrib-1.0b3.jar|
|framework|base|./framework/base/lib/commons/commons-io-2.4.jar|
|framework|base|./framework/base/lib/commons/commons-logging-1.2.jar|
|framework|base|./framework/base/lib/commons/commons-lang-2.6.jar|
|framework|base|./framework/base/lib/commons/commons-compress-1.11.jar|
|framework|base|./framework/base/lib/commons/commons-pool2-2.3.jar|
|framework|base|./framework/base/lib/commons/commons-el-1.0.jar|
|framework|base|./framework/base/lib/commons/commons-codec-1.10.jar|
|framework|base|./framework/base/lib/commons/commons-fileupload-1.3.1.jar|
|framework|base|./framework/base/lib/commons/commons-csv-1.1.jar|
|framework|base|./framework/base/lib/commons/commons-net-3.3.jar|
|framework|base|./framework/base/lib/commons/commons-collections4-4.1.jar|
|framework|base|./framework/base/lib/commons/commons-beanutils-core-1.8.3.jar|
|framework|base|./framework/base/lib/commons/commons-validator-1.4.1.jar|
|framework|base|./framework/base/lib/xml-apis-ext-1.3.04.jar|
|framework|base|./framework/base/lib/xml-apis-1.4.01.jar|
|framework|base|./framework/base/lib/log4j-1.2-api-2.3.jar|
|framework|base|./framework/base/lib/log4j-slf4j-impl-2.3.jar|
|framework|base|./framework/base/lib/ant-1.9.0-ant-junit.jar|
|framework|base|./framework/base/lib/icu4j-57_1.jar|
|framework|base|./framework/base/lib/resolver-2.9.1.jar|
|framework|base|./framework/base/lib/barcode4j-2.1-barcode4j-fop-ext-complete.jar|
|framework|base|./framework/base/lib/xpp3-1.1.4c.jar|
|framework|base|./framework/base/lib/log4j-core-2.3.jar|
|framework|base|./framework/base/lib/junit-dep-4.10.jar|
|framework|base|./framework/base/lib/freemarker-2.3.24.jar|
|framework|base|./framework/base/lib/tika-parsers-1.12.jar|
|framework|base|./framework/base/lib/xmlrpc-client-3.1.2.jar|
|framework|base|./framework/base/lib/clhm-release-1.0-lru.jar|
|framework|base|./framework/base/lib/jpim-0.1.jar|
|framework|base|./framework/base/lib/xalan-2.7.2.jar|
|framework|base|./framework/base/lib/shiro-core-1.2.5.jar|
|framework|base|./framework/base/lib/mail-1.5.1.jar|
|framework|base|./framework/base/lib/pdfbox-1.8.12.jar|
|framework|base|./framework/base/lib/xmlrpc-common-3.1.2.jar|
|framework|base|./framework/base/lib/avalon-framework-4.2.0.jar|
|framework|base|./framework/base/lib/jempbox-1.8.11.jar|
|framework|base|./framework/base/lib/nekohtml-1.9.16.jar|
|framework|base|./framework/base/lib/jackson-core-2.4.2.jar|
|framework|base|./framework/base/lib/owasp-java-html-sanitizer-r239.jar|
|framework|base|./framework/base/lib/serializer-2.9.1.jar|
|framework|base|./framework/base/lib/httpclient-cache-4.4.1.jar|
|framework|base|./framework/base/lib/ical4j-1.0-rc2.jar|
|framework|base|./framework/base/lib/ws-commons-java5-1.0.1.jar|
|framework|base|./framework/base/lib/fontbox-1.8.11.jar|
|framework|base|./framework/base/lib/esapi-2.1.0.jar|
|framework|base|./framework/base/lib/xercesImpl-2.11.0.jar|
|framework|base|./framework/base/lib/xmlrpc-server-3.1.2.jar|

[jira] [Updated] (OFBIZ-7359) Product base promotion calculation

2016-06-30 Thread Arvind Singh Tomar (JIRA) 

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arvind Singh Tomar updated OFBIZ-7359:
--
Attachment: OFBIZ-7359_trunk.patch

> Product base promotion calculation
> --
>
> Key: OFBIZ-7359
> URL: https://issues.apache.org/jira/browse/OFBIZ-7359
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Arvind Singh Tomar
>Priority: Minor
> Attachments: OFBIZ-7359_trunk.patch, Promotion1.png, Promotion2.png
>
>
> I found the behavior of product base promotion calculation a bit strange. Any 
> further insights into the issue would be very helpful.
> The promotion which I used was to give 30% discount for the item (i.e. 
> RAM1GB_BRAND). I created a sales order with 10 quantity of the product. 
> During the promotion calculation, OFBiz created 10 OrderAdjustments, one for 
> each quantity for the same promotion type.
> I was expecting that in the case if same Promotion is applicable for more 
> than one quantity of a product then a single OrderAdjustment should be 
> created instead of creating one for each quantity. It is also messing up the 
> UI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7683) Error occurred when making Shopping list public/private from Party Detail screen

2016-06-30 Thread Ankit Joshi (JIRA) 

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankit Joshi updated OFBIZ-7683:
---
Assignee: (was: Ankit Joshi)

> Error occurred when making Shopping list public/private from Party Detail 
> screen
> 
>
> Key: OFBIZ-7683
> URL: https://issues.apache.org/jira/browse/OFBIZ-7683
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Ankit Joshi
> Attachments: OFBIZ-7683-14.12.patch, OFBIZ-7683-trunk.patch
>
>
> Steps to regenerate
> 1) Navigate to party component.
> 2) Search parties and move to the detail page.
> 3) Select Shopping List tab and create shopping list for the party.
> 4) Try to update shopping list with public / private.
> Following error occurred -
> {code}
> Error while updating: 
> [GenericEntity:ShoppingList][carrierPartyId,null()][carrierRoleTypeId,null()][contactMechId,null()][createdStamp,2016-06-30
>  13:57:21.0(java.sql.Timestamp)][createdTxStamp,2016-06-30 
> 13:57:21.0(java.sql.Timestamp)][currencyUom,null()][description,null()][isActive,Y(java.lang.String)][isPublic,Yes(java.lang.String)][lastAdminModified,2016-06-30
>  
> 14:03:25.0(java.sql.Timestamp)][lastOrderedDate,null()][lastUpdatedStamp,2016-06-30
>  14:15:21.079(java.sql.Timestamp)][lastUpdatedTxStamp,2016-06-30 
> 14:15:21.008(java.sql.Timestamp)][listName,New Shopping 
> List(java.lang.String)][parentShoppingListId,null()][partyId,1(java.lang.String)][paymentMethodId,null()][productPromoCodeId,null()][productStoreId,null()][recurrenceInfoId,null()][shipmentMethodTypeId,null()][shoppingListId,10030(java.lang.String)][shoppingListTypeId,SLT_WISH_LIST(java.lang.String)][visitorId,null()]
>  (SQL Exception while executing the following:UPDATE SHOPPING_LIST SET 
> SHOPPING_LIST_TYPE_ID=?, PARENT_SHOPPING_LIST_ID=?, PRODUCT_STORE_ID=?, 
> VISITOR_ID=?, PARTY_ID=?, LIST_NAME=?, DESCRIPTION=?, IS_PUBLIC=?, 
> IS_ACTIVE=?, CURRENCY_UOM=?, SHIPMENT_METHOD_TYPE_ID=?, CARRIER_PARTY_ID=?, 
> CARRIER_ROLE_TYPE_ID=?, CONTACT_MECH_ID=?, PAYMENT_METHOD_ID=?, 
> RECURRENCE_INFO_ID=?, LAST_ORDERED_DATE=?, LAST_ADMIN_MODIFIED=?, 
> PRODUCT_PROMO_CODE_ID=?, LAST_UPDATED_STAMP=?, LAST_UPDATED_TX_STAMP=?, 
> CREATED_STAMP=?, CREATED_TX_STAMP=? WHERE SHOPPING_LIST_ID=? (Data 
> truncation: Data too long for column 'IS_PUBLIC' at row 1))
> {code}
> Here is the reference link -
> https://ofbiz-vm.apache.org:8443/partymgr/control/editShoppingList?partyId=Company



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7683) Error occurred when making Shopping list public/private from Party Detail screen

2016-06-30 Thread Ankit Joshi (JIRA) 

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankit Joshi updated OFBIZ-7683:
---
Attachment: OFBIZ-7683-trunk.patch
OFBIZ-7683-14.12.patch

Here is the patch with proper fix for the issue.

> Error occurred when making Shopping list public/private from Party Detail 
> screen
> 
>
> Key: OFBIZ-7683
> URL: https://issues.apache.org/jira/browse/OFBIZ-7683
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Ankit Joshi
>Assignee: Ankit Joshi
> Attachments: OFBIZ-7683-14.12.patch, OFBIZ-7683-trunk.patch
>
>
> Steps to regenerate
> 1) Navigate to party component.
> 2) Search parties and move to the detail page.
> 3) Select Shopping List tab and create shopping list for the party.
> 4) Try to update shopping list with public / private.
> Following error occurred -
> {code}
> Error while updating: 
> [GenericEntity:ShoppingList][carrierPartyId,null()][carrierRoleTypeId,null()][contactMechId,null()][createdStamp,2016-06-30
>  13:57:21.0(java.sql.Timestamp)][createdTxStamp,2016-06-30 
> 13:57:21.0(java.sql.Timestamp)][currencyUom,null()][description,null()][isActive,Y(java.lang.String)][isPublic,Yes(java.lang.String)][lastAdminModified,2016-06-30
>  
> 14:03:25.0(java.sql.Timestamp)][lastOrderedDate,null()][lastUpdatedStamp,2016-06-30
>  14:15:21.079(java.sql.Timestamp)][lastUpdatedTxStamp,2016-06-30 
> 14:15:21.008(java.sql.Timestamp)][listName,New Shopping 
> List(java.lang.String)][parentShoppingListId,null()][partyId,1(java.lang.String)][paymentMethodId,null()][productPromoCodeId,null()][productStoreId,null()][recurrenceInfoId,null()][shipmentMethodTypeId,null()][shoppingListId,10030(java.lang.String)][shoppingListTypeId,SLT_WISH_LIST(java.lang.String)][visitorId,null()]
>  (SQL Exception while executing the following:UPDATE SHOPPING_LIST SET 
> SHOPPING_LIST_TYPE_ID=?, PARENT_SHOPPING_LIST_ID=?, PRODUCT_STORE_ID=?, 
> VISITOR_ID=?, PARTY_ID=?, LIST_NAME=?, DESCRIPTION=?, IS_PUBLIC=?, 
> IS_ACTIVE=?, CURRENCY_UOM=?, SHIPMENT_METHOD_TYPE_ID=?, CARRIER_PARTY_ID=?, 
> CARRIER_ROLE_TYPE_ID=?, CONTACT_MECH_ID=?, PAYMENT_METHOD_ID=?, 
> RECURRENCE_INFO_ID=?, LAST_ORDERED_DATE=?, LAST_ADMIN_MODIFIED=?, 
> PRODUCT_PROMO_CODE_ID=?, LAST_UPDATED_STAMP=?, LAST_UPDATED_TX_STAMP=?, 
> CREATED_STAMP=?, CREATED_TX_STAMP=? WHERE SHOPPING_LIST_ID=? (Data 
> truncation: Data too long for column 'IS_PUBLIC' at row 1))
> {code}
> Here is the reference link -
> https://ofbiz-vm.apache.org:8443/partymgr/control/editShoppingList?partyId=Company



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7683) Error occurred when making Shopping list public/private from Party Detail screen

2016-06-30 Thread Ankit Joshi (JIRA) 
Ankit Joshi created OFBIZ-7683:
--

 Summary: Error occurred when making Shopping list public/private 
from Party Detail screen
 Key: OFBIZ-7683
 URL: https://issues.apache.org/jira/browse/OFBIZ-7683
 Project: OFBiz
  Issue Type: Bug
  Components: party
Affects Versions: Release Branch 15.12, Trunk, Release Branch 14.12, 
Release Branch 13.07
Reporter: Ankit Joshi
Assignee: Ankit Joshi


Steps to regenerate
1) Navigate to party component.
2) Search parties and move to the detail page.
3) Select Shopping List tab and create shopping list for the party.
4) Try to update shopping list with public / private.
Following error occurred -
{code}
Error while updating: 
[GenericEntity:ShoppingList][carrierPartyId,null()][carrierRoleTypeId,null()][contactMechId,null()][createdStamp,2016-06-30
 13:57:21.0(java.sql.Timestamp)][createdTxStamp,2016-06-30 
13:57:21.0(java.sql.Timestamp)][currencyUom,null()][description,null()][isActive,Y(java.lang.String)][isPublic,Yes(java.lang.String)][lastAdminModified,2016-06-30
 
14:03:25.0(java.sql.Timestamp)][lastOrderedDate,null()][lastUpdatedStamp,2016-06-30
 14:15:21.079(java.sql.Timestamp)][lastUpdatedTxStamp,2016-06-30 
14:15:21.008(java.sql.Timestamp)][listName,New Shopping 
List(java.lang.String)][parentShoppingListId,null()][partyId,1(java.lang.String)][paymentMethodId,null()][productPromoCodeId,null()][productStoreId,null()][recurrenceInfoId,null()][shipmentMethodTypeId,null()][shoppingListId,10030(java.lang.String)][shoppingListTypeId,SLT_WISH_LIST(java.lang.String)][visitorId,null()]
 (SQL Exception while executing the following:UPDATE SHOPPING_LIST SET 
SHOPPING_LIST_TYPE_ID=?, PARENT_SHOPPING_LIST_ID=?, PRODUCT_STORE_ID=?, 
VISITOR_ID=?, PARTY_ID=?, LIST_NAME=?, DESCRIPTION=?, IS_PUBLIC=?, IS_ACTIVE=?, 
CURRENCY_UOM=?, SHIPMENT_METHOD_TYPE_ID=?, CARRIER_PARTY_ID=?, 
CARRIER_ROLE_TYPE_ID=?, CONTACT_MECH_ID=?, PAYMENT_METHOD_ID=?, 
RECURRENCE_INFO_ID=?, LAST_ORDERED_DATE=?, LAST_ADMIN_MODIFIED=?, 
PRODUCT_PROMO_CODE_ID=?, LAST_UPDATED_STAMP=?, LAST_UPDATED_TX_STAMP=?, 
CREATED_STAMP=?, CREATED_TX_STAMP=? WHERE SHOPPING_LIST_ID=? (Data truncation: 
Data too long for column 'IS_PUBLIC' at row 1))
{code}

Here is the reference link -
https://ofbiz-vm.apache.org:8443/partymgr/control/editShoppingList?partyId=Company



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6709) When you add a party content the party profile screen does not refresh

2016-06-30 Thread Jacques Le Roux (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-6709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15356682#comment-15356682
 ] 

Jacques Le Roux commented on OFBIZ-6709:


Thanks Deepak, indeed I remember that now.

We can do what we want with the DOM with js. Could we not introduce a custom 
block of code to also update the logo on the page?

> When you add a party content the party profile screen does not refresh
> --
>
> Key: OFBIZ-6709
> URL: https://issues.apache.org/jira/browse/OFBIZ-6709
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Divesh Dutta
>Priority: Minor
> Attachments: OFBIZ-6709.patch
>
>
> It works when you remove



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7540) Enforce noninstantiability to FileUtil class

2016-06-30 Thread Arun Patidar (JIRA) 

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-7540.
---
   Resolution: Fixed
Fix Version/s: Upcoming Branch

Committed changes in trunk at rev: 1750663.

Thanks [~rishisolankii] and [~rohit.koushal] for your contribution.

> Enforce noninstantiability to FileUtil class
> 
>
> Key: OFBIZ-7540
> URL: https://issues.apache.org/jira/browse/OFBIZ-7540
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Arun Patidar
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7540.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make following public static class as private and move it to the top of the 
> class.
> {code}
> public static class SearchTextFilesFilter implements FilenameFilter
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6709) When you add a party content the party profile screen does not refresh

2016-06-30 Thread Deepak Dixit (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-6709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15356587#comment-15356587
 ] 

Deepak Dixit commented on OFBIZ-6709:
-

Thanks Jacques for your opinion. I forgot to post this on dev list.

Ajaxified flow for party content means we have an feature or an good example to 
use ajax here. 
At party content section on party profile we are uploading content using ajax, 
and it refresh only party content screen instead of whole page, and newly 
uploaded content reflect on content list.

> When you add a party content the party profile screen does not refresh
> --
>
> Key: OFBIZ-6709
> URL: https://issues.apache.org/jira/browse/OFBIZ-6709
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Divesh Dutta
>Priority: Minor
> Attachments: OFBIZ-6709.patch
>
>
> It works when you remove



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)