date:20160708


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gil Portenseigne updated OFBIZ-7763:

Attachment: OFBIZ-7763.patch

This patch, fix all use-when using groovyShell instead of bsh, compiling with 
all bsh lib removed.

I was forced to analyse expression to identify the groovy variable, to set non 
existent one in context to null in binding, avoiding Exception...

I will reread it this week-end, it needs more tests... 

Any comments and tests are welcome.

> Replace bshInterpreter with groovyShell
> ---
>
> Key: OFBIZ-7763
> URL: https://issues.apache.org/jira/browse/OFBIZ-7763
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
> Attachments: OFBIZ-7763.patch, OFBIZ-7763.patch, 
> beanshell-removal-part1.patch
>
>
> To support the migration to gradle, removing bsh.jar dependency from the 
> project, and improve readability and fonctionnalities following 
> [~deepak.dixit] idea expressed here 
> https://issues.apache.org/jira/browse/OFBIZ-7576?focusedCommentId=15347972



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

buildbot exception in on ofbiz-trunk

2016-07-08 Thread buildbot

The Buildbot has detected a build exception on builder ofbiz-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/ofbiz-trunk/builds/1053

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: forced: by IRC user  (privmsg): forces manual build 
trying to use gradlew (trying gradle (no path))
Build Source Stamp: HEAD
Blamelist: 

BUILD FAILED: exception shell upload_2

Sincerely,
 -The Buildbot

[jira] [Updated] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gil Portenseigne updated OFBIZ-7534:

Attachment: OFBizRemoteJarList.csv

This is the last revision with the missing lib and some fix/comments

> Migrate OFBiz from Apache Ant to Gradle build system
> 
>
> Key: OFBIZ-7534
> URL: https://issues.apache.org/jira/browse/OFBIZ-7534
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
>  Labels: ant, build-tools, gradle
> Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, 
> OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, OFBizRemoteJarList.csv, 
> OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, 
> gradle-wrapper.jar
>
>
> This is a major refactoring task referring to the [email 
> thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle]
>  in which the community voted for the switch after a proposal from the PMC
> The purpose of this JIRA is to achieve the following objectives
> - Fully implement a working compiling system in Gradle that passes all tests
> - Remove all ant and maven build scripts from the system
> - update the documentation of the system to reflect these changes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

buildbot failure in on ofbiz-trunk

2016-07-08 Thread buildbot

The Buildbot has detected a new failure on builder ofbiz-trunk while building . 
Full details are available at:
https://ci.apache.org/builders/ofbiz-trunk/builds/1051

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: forced: by IRC user  (privmsg): forces manual build 
trying to use gradlew (Clementine project way)
Build Source Stamp: HEAD
Blamelist: 

BUILD FAILED: failed shell_2

Sincerely,
 -The Buildbot

[jira] [Commented] (OFBIZ-7754) The big problem when load seed.


[ 
https://issues.apache.org/jira/browse/OFBIZ-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15368271#comment-15368271
 ] 

Wai commented on OFBIZ-7754:


Seeing this solution from a customer's point of view may seem counter-intuitive.
As previously suggested, I think using a separate readerName such as 'seed' and 
'seed-initial' for such a file would be a good idea and have it loaded when it 
is actually required as a separate step.

> The big problem when load seed.
> ---
>
> Key: OFBIZ-7754
> URL: https://issues.apache.org/jira/browse/OFBIZ-7754
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Kongrath Suankaewmanee
>Assignee: Jacques Le Roux
> Attachments: OFBIZ-7754.patch
>
>
> Hi All,
> Regarding, [OFBIZ-7112|https://issues.apache.org/jira/browse/OFBIZ-7112]
> That's good for who start on use the ofbiz with initial setup, but not for 
> the site that already online and has to update the OFBiz core. Because when 
> has update OFBiz core they will use command load-seed for update.
> The problem is if we use load-seed mean the configuration data that's already 
> exists will be replaced by the data from this file,
> *CommonSystemPropertyData.xml*
> So, for my suggestion should change the reader from *seed* to *seed-initial*  
> or remove systemPropertyValue from the data file.
> Thank you,
> Kongrath



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7754) The big problem when load seed.


[ 
https://issues.apache.org/jira/browse/OFBIZ-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15368242#comment-15368242
 ] 

Wai commented on OFBIZ-7754:


A property value can be empty.  It is the same as commenting out a property.  
In such a case, a default value in ofbiz code would be used.

"...But is it required? Please give me a number of examples where this is 
needed. As far as I can see a properties value always has content either Y/N or 
False/True or a value"

>>>A sample case in which an issue would result is if nothing is a valid 
value for a property.  In such a scenario, if the user wants to set the 
database-based version of the property to nothing, the code would proceed to 
get a value from the file-based counterpart. Which is not what is desired.

"...Further, anybody just starting with the system will try to change the most 
important properties file 'general.properties' and will see no result"

>>>It should be noted that the database-based version of property is a 
special case.  Generally, a user using ofbiz in single tenant mode would be 
using the file-based properties.  In such a situation, the user should not have 
loaded the database-base version into the database.
>>>And if seed data for database-based properties need to be loaded, it 
should be customized according to the user's requirements.  In other words, 
those properties that are not required should be edited out before seeding.


> The big problem when load seed.
> ---
>
> Key: OFBIZ-7754
> URL: https://issues.apache.org/jira/browse/OFBIZ-7754
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Kongrath Suankaewmanee
>Assignee: Jacques Le Roux
> Attachments: OFBIZ-7754.patch
>
>
> Hi All,
> Regarding, [OFBIZ-7112|https://issues.apache.org/jira/browse/OFBIZ-7112]
> That's good for who start on use the ofbiz with initial setup, but not for 
> the site that already online and has to update the OFBiz core. Because when 
> has update OFBiz core they will use command load-seed for update.
> The problem is if we use load-seed mean the configuration data that's already 
> exists will be replaced by the data from this file,
> *CommonSystemPropertyData.xml*
> So, for my suggestion should change the reader from *seed* to *seed-initial*  
> or remove systemPropertyValue from the data file.
> Thank you,
> Kongrath



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7763) Replace bshInterpreter with groovyShell


[ 
https://issues.apache.org/jira/browse/OFBIZ-7763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15368074#comment-15368074
 ] 

Jacopo Cappellato commented on OFBIZ-7763:
--

In revision 1751947 I have committed my patch named patch 
beanshell-removal-part1.patch

To summarize, the remaining tasks are now:

1) replace bshInterpreter with groovyShell
2) remove the jars: bsh-engine-modified.jar and bsh-2.0b4.jar


> Replace bshInterpreter with groovyShell
> ---
>
> Key: OFBIZ-7763
> URL: https://issues.apache.org/jira/browse/OFBIZ-7763
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
> Attachments: OFBIZ-7763.patch, beanshell-removal-part1.patch
>
>
> To support the migration to gradle, removing bsh.jar dependency from the 
> project, and improve readability and fonctionnalities following 
> [~deepak.dixit] idea expressed here 
> https://issues.apache.org/jira/browse/OFBIZ-7576?focusedCommentId=15347972



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7765) Replace call with


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato closed OFBIZ-7765.


> Replace  call with

[jira] [Resolved] (OFBIZ-7765) Replace call with


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato resolved OFBIZ-7765.
--
   Resolution: Fixed
Fix Version/s: Upcoming Branch

Thank you Deepak (and Nicolas), I have committed your code in rev. 1751945

> Replace  call with

[jira] [Comment Edited] (OFBIZ-7754) The big problem when load seed.

[
https://issues.apache.org/jira/browse/OFBIZ-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15368022#comment-15368022
]

Wai edited comment on OFBIZ-7754 at 7/8/16 5:28 PM:

Regarding property values:

A property can have both a value or empty. 'empty' simply means that a property
is commented out or present but contain an empty value. If the value is empty,
then a default value would be that coded in the software.

Ofbiz modes:

I think we need to consider ofbiz in the 1)single tenant mode and 2)
multitenant mode.
In single tenant mode, ofbiz should only be using the properties files. Using
the database to store similar properties would be redundant. If the owner
wished to change the properties, one would just modify the relevant properties
file.

Methods of deployment:

I can think of a few methods of ofbiz deployment.

Deployment#1) owner of ofbiz(in single tenant mode) is also the user

In such a setup. The user would not require a database version of property
files. The owner can simply modify the appropriate files.

Deployment#2) owner of ofbiz(in single tenant mode) is a provider of ofbiz
service to paid users.

In such a setup, multiple instances of ofbiz is run on separate
ports(perhaps in separate virtual machines). Each ofbiz instance is assigned
to a paid user.
Hence, a database equivalent of changeable properties is placed in the
database associated with each paid user. This would allow the owner to simply
modify the property values tailored to each paid user. Based on the previous
comments, it seems the paid user is able to load seed data himself.

Note#1: I believe this is the original intent of why a database version of
properties was created. In such a scenario, if the database property is
missing or contains an empty value for a given paid user, ofbiz would fallback
on the value of the file-based property value.
Note#2: The peculiar interaction between the file-based property and the
database-based property as it was coded (ie. before my patch) is as follows.
The peculiar aspect is useCase#3. why have a database-based property if it is
not going to override the file-based version. Hence, if database-based property
has an empty value then it is meant to be empty (and thus use the hardcoded
default in ofbiz code). As mentioned in the section "Regarding property
values" above. it is possible to have a property that contains an empty value.
it is the same as commenting out the property in the file.
{noformat}
database-based property file-based property result
--- --- --
useCase#1:property1=value1property1=value2use
property1=value1
useCase#2:nil property1=value2use
property1=value2
useCase#3:property1= property1=value2use
property1=value2 (this scenario is strange???)
{noformat}

Deployment#3) owner of ofbiz(in multitenant mode) is a provider of ofbiz
service to paid users.

In such a setup, one instance of ofbiz is serving multiple paid users. Each
paid user accesses his assigned database via the one instance of ofbiz. Each
database would contain it's own property values and the paid user has access
and is responsible for configuring his own property values. The properties
that are available for the paid user to modify is determined by the ofbiz owner.

The interaction between database-based property and file-based property is
as follows. Notice that if a database-entry is present, its value(or lack
thereof) would always override that of the file-based version.
{noformat}
database-based property file-based property result
--- --- --
useCase#1:property1=value1property1=value2use
property1=value1
useCase#2:nil property1=value2use
property1=value2
useCase#3:property1= property1=value2use
property1=
{noformat}

was (Author: wt):
Regarding property values:

Ofbiz modes:

Methods of deployment:

I can think of a few methods of ofbiz deployment.

Deployment#1) owner of ofbiz(in single tenant mode) is also the user

[jira] [Commented] (OFBIZ-7754) The big problem when load seed.


[ 
https://issues.apache.org/jira/browse/OFBIZ-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15368022#comment-15368022
 ] 

Wai commented on OFBIZ-7754:


Regarding property values:

A property can have both a value or empty. 'empty' simply means that a property 
is commented out or present but contain an empty value.  If the value is empty, 
then a default value would be that coded in the software.

Ofbiz modes:

I think we need to consider ofbiz in the 1)single tenant mode and 2) 
multitenant mode.
In single tenant mode, ofbiz should only be using the properties files.  Using 
the database to store similar properties would be redundant.  If the owner 
wished to change the properties, one would just modify the relevant properties 
file.


Methods of deployment:

I can think of a few methods of ofbiz deployment.

Deployment#1) owner of ofbiz(in single tenant mode) is also the user

In such a setup. The user would not require a database version of property 
files. The owner can simply modify the appropriate files.

Deployment#2) owner of ofbiz(in single tenant mode) is a provider of ofbiz 
service to  paid users.

In such a setup, multiple instances of ofbiz is run on separate 
ports(perhaps in separate virtual machines).  Each ofbiz instance is assigned 
to a paid user.
Hence, a database equivalent of changeable properties is placed in the 
database associated with each paid user.  This would allow the owner to simply 
modify the property values tailored to each paid user. Based on the previous 
comments, it seems the paid user is able to load seed data himself.

Note#1: I believe this is the original intent of why a database version of 
properties was created.  In such a scenario, if the database property is 
missing or contains an empty value for a given paid user, ofbiz would fallback 
on the value of the file-based property value.
Note#2: The peculiar interaction between the file-based property and the 
database-based property as it was coded (ie. before my patch) is as follows. 
The peculiar aspect is useCase#3. why have a database-based property if it is 
not going to override the file-based version. Hence, if database-based property 
has an empty value then it is meant to be empty (and thus use the hardcoded 
default in ofbiz code).  As mentioned in the section "Regarding property 
values" above. it is possible to have a property that contains an empty value. 
it is the same as commenting out the property in the file.
{{monospaced}}
 database-based property file-based property result
 --- --- --
useCase#1:property1=value1property1=value2use 
property1=value1
useCase#2:nil property1=value2use 
property1=value2
useCase#3:property1=  property1=value2use 
property1=value2 (this scenario is strange???)
{{monospaced}}
Deployment#3) owner of ofbiz(in multitenant mode) is a provider of ofbiz 
service to paid users.

In such a setup, one instance of ofbiz is serving multiple paid users. Each 
paid user accesses his assigned database via the one instance of ofbiz.  Each 
database would contain it's own property values and the paid user has access 
and is responsible for configuring his own property values.  The properties 
that are available for the paid user to modify is determined by the ofbiz owner.

The interaction between database-based property and file-based property is 
as follows. Notice that if a database-entry is present, its value(or lack 
thereof) would always override that of the file-based version.
{{
 database-based property file-based property result
 --- --- --
useCase#1:property1=value1property1=value2use 
property1=value1
useCase#2:nil property1=value2use 
property1=value2
useCase#3:property1=  property1=value2use 
property1=
}}

> The big problem when load seed.
> ---
>
> Key: OFBIZ-7754
> URL: https://issues.apache.org/jira/browse/OFBIZ-7754
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Kongrath Suankaewmanee
>Assignee: Jacques Le Roux
> Attachments: OFBIZ-7754.patch
>
>
> Hi All,
> Regarding, [OFBIZ-7112|https://issues.apache.org/jira/browse/OFBIZ-7112]
> That's good for who start on use the ofbiz with initial setup, but not for 
> the site that already online and has to update the OFBiz core. Because when 
> has update OFBiz core they will use command load-seed for update.
> The problem is if we use load-seed mean the configuration data that's

[jira] [Created] (OFBIZ-7766) Demo data for serialized and non-serialised product

2016-07-08 Thread james yong (JIRA)

james yong created OFBIZ-7766:
-

 Summary: Demo data for serialized and non-serialised product
 Key: OFBIZ-7766
 URL: https://issues.apache.org/jira/browse/OFBIZ-7766
 Project: OFBiz
  Issue Type: Sub-task
  Components: product
Reporter: james yong
Priority: Minor


Currently, InventoryItemTypeId attribute is empty for all Product entity's demo 
data. In real cases, there are products that are purely serialised (like 
equipments) or purely non-serialised (like liquid). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7707) Improve payment method information UI on party profile screen


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chandan Khandelwal updated OFBIZ-7707:
--
Attachment: OFBIZ-7707.patch

> Improve payment method information UI on party profile screen
> -
>
> Key: OFBIZ-7707
> URL: https://issues.apache.org/jira/browse/OFBIZ-7707
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Trunk
>Reporter: Chandan Khandelwal
>Assignee: Pranay Pandey
>Priority: Trivial
> Attachments: Improved_PaymentMethodInformation_UI.png, 
> OFBIZ-7707.patch, OFBIZ-7707.patch, OFBIZ-7707.patch, screenshot-1.png
>
>
> Improve payment method information UI on party profile screen for options of 
> creating new payment method.
> https://localhost:8443/partymgr/control/viewprofile?partyId=admin



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7707) Improve payment method information UI on party profile screen


[ 
https://issues.apache.org/jira/browse/OFBIZ-7707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367598#comment-15367598
 ] 

Chandan Khandelwal commented on OFBIZ-7707:
---

Thanks Pranay for your feedback, will update the patch.

> Improve payment method information UI on party profile screen
> -
>
> Key: OFBIZ-7707
> URL: https://issues.apache.org/jira/browse/OFBIZ-7707
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Trunk
>Reporter: Chandan Khandelwal
>Assignee: Pranay Pandey
>Priority: Trivial
> Attachments: Improved_PaymentMethodInformation_UI.png, 
> OFBIZ-7707.patch, OFBIZ-7707.patch, OFBIZ-7707.patch, screenshot-1.png
>
>
> Improve payment method information UI on party profile screen for options of 
> creating new payment method.
> https://localhost:8443/partymgr/control/viewprofile?partyId=admin



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7765) Replace call with


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin updated OFBIZ-7765:
-
Attachment: OFBIZ-7765.patch

Deepak, I relaod a new patch with two correct 

revert xml header on 
applications/product/minilang/product/test/GroupOrderTest.xml and remove ]]> on 
ShoppingCartTest.xml

now the test pass ! :)

> Replace  call with

[jira] [Commented] (OFBIZ-7711) Label not showing properly on 'Add EFT Account' screen of scrum


[ 
https://issues.apache.org/jira/browse/OFBIZ-7711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367580#comment-15367580
 ] 

Chandan Khandelwal commented on OFBIZ-7711:
---

We can add EFT account from my profile and yes, it is similar as in accounting 
and profile.

> Label not showing properly on 'Add EFT Account' screen of scrum
> ---
>
> Key: OFBIZ-7711
> URL: https://issues.apache.org/jira/browse/OFBIZ-7711
> Project: OFBiz
>  Issue Type: Improvement
>  Components: specialpurpose/scrum
>Affects Versions: Trunk
>Reporter: Chandan Khandelwal
>Assignee: Pranay Pandey
>Priority: Trivial
> Attachments: OFBIZ-7711.patch
>
>
> Accounting Uilabel resource not added in scrum main decorator.
> URL : 
> https://localhost:8443/scrum/control/editeftaccount?partyId=DemoScrumCompany



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-7711) Label not showing properly on 'Add EFT Account' screen of scrum


[ 
https://issues.apache.org/jira/browse/OFBIZ-7711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367580#comment-15367580
 ] 

Chandan Khandelwal edited comment on OFBIZ-7711 at 7/8/16 12:00 PM:


We can add EFT account from my profile and yes, it is similar as in accounting 
and party.


was (Author: chandan.khandelwal):
We can add EFT account from my profile and yes, it is similar as in accounting 
and profile.

> Label not showing properly on 'Add EFT Account' screen of scrum
> ---
>
> Key: OFBIZ-7711
> URL: https://issues.apache.org/jira/browse/OFBIZ-7711
> Project: OFBiz
>  Issue Type: Improvement
>  Components: specialpurpose/scrum
>Affects Versions: Trunk
>Reporter: Chandan Khandelwal
>Assignee: Pranay Pandey
>Priority: Trivial
> Attachments: OFBIZ-7711.patch
>
>
> Accounting Uilabel resource not added in scrum main decorator.
> URL : 
> https://localhost:8443/scrum/control/editeftaccount?partyId=DemoScrumCompany



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7752) 'parentCommEventId' is not passed in parameter from edit communication event


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chandan Khandelwal updated OFBIZ-7752:
--
Affects Version/s: Release Branch 13.07
   Release Branch 14.12
   Release Branch 15.12

> 'parentCommEventId' is not passed in parameter from edit communication event
> 
>
> Key: OFBIZ-7752
> URL: https://issues.apache.org/jira/browse/OFBIZ-7752
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing, party
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Chandan Khandelwal
>Assignee: Pranay Pandey
> Attachments: OFBIZ-7752.patch
>
>
> Steps :
> # Create 'New Communication Event' with parentCommEventId
> # Go To 'Edit Communication Event'
> # Click on 'Go To Parent' button
> No communicationEventId (parentCommEventId) passed with link. 
> Ref URL : https://localhost:8443/sfa/control/EditCommunicationEvent



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7765) Replace call with


[ 
https://issues.apache.org/jira/browse/OFBIZ-7765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367564#comment-15367564
 ] 

Nicolas Malin commented on OFBIZ-7765:
--

What you thanks me ! :/ for a work that I realized with less successful than 
you ! crazy ^^

Don't reversing the charges, the thanks is to you and Deepak.

Ok we wait Deepak, during this a detect some test failed, I will analyse the 
reason

> Replace  call with

[jira] [Commented] (OFBIZ-7765) Replace call with


[ 
https://issues.apache.org/jira/browse/OFBIZ-7765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367522#comment-15367522
 ] 

Jacopo Cappellato commented on OFBIZ-7765:
--

Thank you [~soledad]! I agree we should remove CallBsh after Deepak's commit: 
however, if you agree, I will proceed with the removal of that code and some 
other artifacts as in the patch I have attached to OFBIZ-7763... I am ready to 
commit it as soon as Deepak has completed his work.



> Replace  call with

[jira] [Commented] (OFBIZ-7765) Replace call with


[ 
https://issues.apache.org/jira/browse/OFBIZ-7765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367502#comment-15367502
 ] 

Nicolas Malin commented on OFBIZ-7765:
--

+1

> Replace  call with

[jira] [Commented] (OFBIZ-7765) Replace call with


[ 
https://issues.apache.org/jira/browse/OFBIZ-7765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367497#comment-15367497
 ] 

Nicolas Malin commented on OFBIZ-7765:
--

Ok sorry deepak, Jacopo already done on OFBIZ-7763 , I'm coming after the war :/

> Replace  call with

[jira] [Updated] (OFBIZ-7765) Replace call with


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin updated OFBIZ-7765:
-
Attachment: (was: OFBIZ-7765.patch)

> Replace  call with

[jira] [Updated] (OFBIZ-7765) Replace call with


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin updated OFBIZ-7765:
-
Attachment: OFBIZ-7765.patch

Also good to me, I update a new patch with remove callBsh class because it's 
unusable in few time.

Maybe we can improve the script documentation to indicate that it can replace 
 by

[jira] [Commented] (OFBIZ-7765) Replace call with


[ 
https://issues.apache.org/jira/browse/OFBIZ-7765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367476#comment-15367476
 ] 

Jacopo Cappellato commented on OFBIZ-7765:
--

Thank you [~deepak.dixit]: your last patch looks good to me; I would suggest 
that you commit it to trunk to let other help to test it and then we fix any 
regression (if any) in the trunk.


> Replace  call with

[jira] [Updated] (OFBIZ-7765) Replace call with


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-7765:

Attachment: OFBIZ-7765.patch

Here is the update patch, excluded PartyProfileContent.js that contains local 
changes :)

> Replace  call with

[jira] [Updated] (OFBIZ-7765) Replace call with


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-7765:

Attachment: OFBIZ-7765.patch

Here is the patch for call-bsh to script replacement. I did not check each and 
every replacement, I tested some places and its working fine. 

> Replace  call with

[jira] [Created] (OFBIZ-7765) Replace call with

Deepak Dixit created OFBIZ-7765:
---

 Summary: Replace  call with

[jira] [Commented] (OFBIZ-7763) Replace bshInterpreter with groovyShell


[ 
https://issues.apache.org/jira/browse/OFBIZ-7763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367393#comment-15367393
 ] 

Jacopo Cappellato commented on OFBIZ-7763:
--

There are 143 occurrences of  elements... we may need a call to 
action for the community to convert all of them.

> Replace bshInterpreter with groovyShell
> ---
>
> Key: OFBIZ-7763
> URL: https://issues.apache.org/jira/browse/OFBIZ-7763
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
> Attachments: OFBIZ-7763.patch, beanshell-removal-part1.patch
>
>
> To support the migration to gradle, removing bsh.jar dependency from the 
> project, and improve readability and fonctionnalities following 
> [~deepak.dixit] idea expressed here 
> https://issues.apache.org/jira/browse/OFBIZ-7576?focusedCommentId=15347972



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7586) Error in Create Billing Account From HR

2016-07-08 Thread Montalbano Florian (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Montalbano Florian updated OFBIZ-7586:
--
Attachment: OFBIZ-7586.patch

I was about to open a ticket for the same problem appearing in the party 
component. It seems that the same screen is used in both Humanres and Partymgr.

The screen is "PaymentMethodScreens.xml#EditBillingAccount". I read the parent 
ticket of this one and it was about moving common xml resources to the 
commonext component. This resource is located in the Party component. Should we 
move it along in this ticket or create a proper task for this component ?

The patch does not move the resources to the commonext component, it simply 
corrects the URI in the controller (of the Party component) and add a default 
value (BILL_TO_CUSTOMER) for the roleTypeId in the context of the screen.

What should we do about moving these resources ? 

> Error in Create Billing Account From HR
> ---
>
> Key: OFBIZ-7586
> URL: https://issues.apache.org/jira/browse/OFBIZ-7586
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: humanres
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Chandan Khandelwal
>Assignee: Pranay Pandey
> Attachments: OFBIZ-7586.patch
>
>
> # Go To HR
> # Select Comapny
> # Create Billing Account 
> # Save
> URL : 
> https://ofbiz-vm.apache.org:8443/humanres/control/EditBillingAccount?partyId=MARKETING
> getting error "org.ofbiz.webapp.control.RequestHandlerException: Unknown 
> request [createBillingAccountAndRole]; this request does not exist or cannot 
> be called directly."



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7764) converting the calls from ${bsh: to groovy calls.


[ 
https://issues.apache.org/jira/browse/OFBIZ-7764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367380#comment-15367380
 ] 

Deepak Dixit commented on OFBIZ-7764:
-

This has been committed at r#1751865, Removed references of 
TaxAuthorityVATReport forms and related controller request form code base.

> converting the calls from ${bsh: to groovy calls.
> -
>
> Key: OFBIZ-7764
> URL: https://issues.apache.org/jira/browse/OFBIZ-7764
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> converting the calls from ${bsh: to groovy calls., there are just few left in 
> the accounting component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7764) converting the calls from ${bsh: to groovy calls.


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit closed OFBIZ-7764.
---
   Resolution: Done
Fix Version/s: Upcoming Branch

> converting the calls from ${bsh: to groovy calls.
> -
>
> Key: OFBIZ-7764
> URL: https://issues.apache.org/jira/browse/OFBIZ-7764
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> converting the calls from ${bsh: to groovy calls., there are just few left in 
> the accounting component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-7764) converting the calls from ${bsh: to groovy calls.


[ 
https://issues.apache.org/jira/browse/OFBIZ-7764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367369#comment-15367369
 ] 

Deepak Dixit edited comment on OFBIZ-7764 at 7/8/16 7:58 AM:
-

${bsh: used in one form TaxAuthorityVATReport, and there is no reference of 
this form in TaxAuthorityScreens.xml.

Also controller request related to this form are commented since 2009 as WIP 
(Work In Progress).

I think we can remove this form and related commented code.




was (Author: deepak.dixit):
${bsh: used in following TaxAuthorityVATReport, and there is no reference of 
this form in TaxAuthorityScreens.xml.

Also controller request related to this form are commented since 2009 as WIP 
(Work In Progress).

I think we can remove this form and related commented code.



> converting the calls from ${bsh: to groovy calls.
> -
>
> Key: OFBIZ-7764
> URL: https://issues.apache.org/jira/browse/OFBIZ-7764
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
>Priority: Minor
>
> converting the calls from ${bsh: to groovy calls., there are just few left in 
> the accounting component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7764) converting the calls from ${bsh: to groovy calls.


[ 
https://issues.apache.org/jira/browse/OFBIZ-7764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367369#comment-15367369
 ] 

Deepak Dixit commented on OFBIZ-7764:
-

${bsh: used in following TaxAuthorityVATReport, and there is no reference of 
this form in TaxAuthorityScreens.xml.

Also controller request related to this form are commented since 2009 as WIP 
(Work In Progress).

I think we can remove this form and related commented code.



> converting the calls from ${bsh: to groovy calls.
> -
>
> Key: OFBIZ-7764
> URL: https://issues.apache.org/jira/browse/OFBIZ-7764
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
>Priority: Minor
>
> converting the calls from ${bsh: to groovy calls., there are just few left in 
> the accounting component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7763) Replace bshInterpreter with groovyShell


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-7763:
-
Attachment: beanshell-removal-part1.patch

Once all the calls to ${bsh: are converted to calls to ${groovy: and once all 
the minilang calls to  are converted into

buildbot exception in on ofbiz-trunk

2016-07-08 Thread buildbot

The Buildbot has detected a build exception on builder ofbiz-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/ofbiz-trunk/builds/1022

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: forced: by IRC user  (privmsg): forces manual build 
after using Gradle for a test
Build Source Stamp: HEAD
Blamelist: 

BUILD FAILED: exception compile upload_2

Sincerely,
 -The Buildbot

[jira] [Commented] (OFBIZ-7763) Replace bshInterpreter with groovyShell


[ 
https://issues.apache.org/jira/browse/OFBIZ-7763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367318#comment-15367318
 ] 

Jacopo Cappellato commented on OFBIZ-7763:
--

Similarly, another subtasks very useful in preparation for the removal is the 
conversion af all the minilang calls to 
into calls to

[jira] [Commented] (OFBIZ-7763) Replace bshInterpreter with groovyShell


[ 
https://issues.apache.org/jira/browse/OFBIZ-7763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367307#comment-15367307
 ] 

Deepak Dixit commented on OFBIZ-7763:
-

Here is the ticket for this work OFBIZ-7763

> Replace bshInterpreter with groovyShell
> ---
>
> Key: OFBIZ-7763
> URL: https://issues.apache.org/jira/browse/OFBIZ-7763
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
> Attachments: OFBIZ-7763.patch
>
>
> To support the migration to gradle, removing bsh.jar dependency from the 
> project, and improve readability and fonctionnalities following 
> [~deepak.dixit] idea expressed here 
> https://issues.apache.org/jira/browse/OFBIZ-7576?focusedCommentId=15347972



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7764) converting the calls from ${bsh: to groovy calls.

Deepak Dixit created OFBIZ-7764:
---

 Summary: converting the calls from ${bsh: to groovy calls.
 Key: OFBIZ-7764
 URL: https://issues.apache.org/jira/browse/OFBIZ-7764
 Project: OFBiz
  Issue Type: Sub-task
  Components: ALL COMPONENTS
Affects Versions: Trunk
Reporter: Deepak Dixit
Assignee: Deepak Dixit
Priority: Minor


converting the calls from ${bsh: to groovy calls., there are just few left in 
the accounting component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7763) Replace bshInterpreter with groovyShell


[ 
https://issues.apache.org/jira/browse/OFBIZ-7763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367297#comment-15367297
 ] 

Jacopo Cappellato commented on OFBIZ-7763:
--

One subtask that could be useful in preparation for the removal would be that 
of converting the calls to ${bsh: to groovy calls.
There are just few left in the accounting component.
Once they are gone, we can start the removal of some code.

> Replace bshInterpreter with groovyShell
> ---
>
> Key: OFBIZ-7763
> URL: https://issues.apache.org/jira/browse/OFBIZ-7763
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
> Attachments: OFBIZ-7763.patch
>
>
> To support the migration to gradle, removing bsh.jar dependency from the 
> project, and improve readability and fonctionnalities following 
> [~deepak.dixit] idea expressed here 
> https://issues.apache.org/jira/browse/OFBIZ-7576?focusedCommentId=15347972



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-1319) Split javascript files to have more generic ones includable in all screens, and the more specific ones included more locally

2016-07-08 Thread Amardeep Singh Jhajj (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367291#comment-15367291
 ] 

Amardeep Singh Jhajj commented on OFBIZ-1319:
-

Yes Paul, I agreed on it and I replied on Dev list on this thread.

My reply was:

We can split based on modules for example- autocompleter module, etc in 
different files and it can be initialized from Util.js on page load (or any 
other event). Makes complete sense.

And some of small utility functions like toggling can be in Util.js itself and 
no need to create separate modules for it.

Further, Jacques has suggested to look on require.js possibility to manage 
modules. I am looking on it now.

Thanks.

> Split javascript files to have more generic ones includable in all screens, 
> and the more specific ones included more locally
> 
>
> Key: OFBIZ-1319
> URL: https://issues.apache.org/jira/browse/OFBIZ-1319
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> From a David's E. Jones comment on ML :
> We should split up javascript files to have the more generic ones includable 
> in all screens, and the more specific ones (like the toggle* and selectAll* 
> methods in there) into a file that can be included more locally. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7763) Replace bshInterpreter with groovyShell


[ 
https://issues.apache.org/jira/browse/OFBIZ-7763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367290#comment-15367290
 ] 

Gil Portenseigne commented on OFBIZ-7763:
-

[~deepak.dixit] keep in mind thats an unfinished work, do not hesitate to 
comment/improve it :)

> Replace bshInterpreter with groovyShell
> ---
>
> Key: OFBIZ-7763
> URL: https://issues.apache.org/jira/browse/OFBIZ-7763
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
> Attachments: OFBIZ-7763.patch
>
>
> To support the migration to gradle, removing bsh.jar dependency from the 
> project, and improve readability and fonctionnalities following 
> [~deepak.dixit] idea expressed here 
> https://issues.apache.org/jira/browse/OFBIZ-7576?focusedCommentId=15347972



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7763) Replace bshInterpreter with groovyShell


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gil Portenseigne updated OFBIZ-7763:

Attachment: OFBIZ-7763.patch

This patch is that I started to do a month ago about the subject, the new issue 
implying these changes is that variable in use-when needs "context." prefix to 
be interprated by groovyShell.

> Replace bshInterpreter with groovyShell
> ---
>
> Key: OFBIZ-7763
> URL: https://issues.apache.org/jira/browse/OFBIZ-7763
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
> Attachments: OFBIZ-7763.patch
>
>
> To support the migration to gradle, removing bsh.jar dependency from the 
> project, and improve readability and fonctionnalities following 
> [~deepak.dixit] idea expressed here 
> https://issues.apache.org/jira/browse/OFBIZ-7576?focusedCommentId=15347972



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7763) Replace bshInterpreter with groovyShell