[jira] [Updated] (OFBIZ-7561) Attr Name should not be allowed to edit while updating Party Attribute record
[ https://issues.apache.org/jira/browse/OFBIZ-7561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mridul Pathak updated OFBIZ-7561: - Component/s: marketing > Attr Name should not be allowed to edit while updating Party Attribute record > - > > Key: OFBIZ-7561 > URL: https://issues.apache.org/jira/browse/OFBIZ-7561 > Project: OFBiz > Issue Type: Bug > Components: marketing, party >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk >Reporter: Ankit Joshi >Assignee: Mridul Pathak >Priority: Minor > Attachments: OFBIZ-7561-13.07.patch, OFBIZ-7561-14.12.patch, > OFBIZ-7561-trunk.patch, UpdatePartyAttribute1.png, UpdatePartyAttribute2.png > > > Steps to regenerate - > 1) Navigate to SFA -> Contacts > 2) Select any contacts and move to detail page. > 3) There is a section to Create / Update Party Attribute. > 4) Create New Party Attribute. > 5) Click on Edit button to update Party Attribute. > Actual: All fields including AttrName is allowed to edit. Process is giving > error in case when user update the AttrName. > Expected : AttrName field should be non-editable while updating the Party > Attribute record as this field is part of the primary key. > Here is the reference link - > https://ofbiz-vm.apache.org:8443/sfa/control/editPartyAttribute?partyId=DemoCustomer -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7674) Unable to perform search at "eBay Orders Import" screen of eBay component
[ https://issues.apache.org/jira/browse/OFBIZ-7674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-7674: --- Attachment: OFBIZ-7674.patch Attaching patch for this bug. While working on this found that two different services of different purpose of ebay and ebay-store component having same name "getEbayOrders". Service of ebay-store overwriting ebay component service that's why "unnecessary required parameter error" was throwing while searching ebay orders. > Unable to perform search at "eBay Orders Import" screen of eBay component > - > > Key: OFBIZ-7674 > URL: https://issues.apache.org/jira/browse/OFBIZ-7674 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/ebay >Affects Versions: Trunk >Reporter: Pawan Verma > Attachments: OFBIZ-7674.patch, ebay_order_search.png > > > Steps to regenerate : > 1) Log in into ebay component. > 2) Click on "eBay Orders Import" menu. > 3) Now select productStoreId, fromDate and thruDate and click on find button. > 4) There is error for required parameter missing. Please find attached > screenshot. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7831) Improvements in AccommodationClass entity definition and services
Rishi Solanki created OFBIZ-7831: Summary: Improvements in AccommodationClass entity definition and services Key: OFBIZ-7831 URL: https://issues.apache.org/jira/browse/OFBIZ-7831 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Rishi Solanki Priority: Minor Required improvements; - All is good with entity definition . - Add crud services using entity-auto. Make sure PK is optional while create service, so that can be generated from OFBiz sequence generator. - Do related changes if any occurrence found for direct create/update/delete of this entity, and replace them with crud services implemented. - As no status/from date/trhu date exists in entity, so nothing needs to be taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7827) Create billing account functionality not working on party profile
[ https://issues.apache.org/jira/browse/OFBIZ-7827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arvind Singh Tomar reassigned OFBIZ-7827: - Assignee: Arvind Singh Tomar > Create billing account functionality not working on party profile > - > > Key: OFBIZ-7827 > URL: https://issues.apache.org/jira/browse/OFBIZ-7827 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk >Reporter: Padmavati Rawat >Assignee: Arvind Singh Tomar > Attachments: errorinaddbilling.png > > > On party profile page when try to add billing account it throws error on > screen. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7830) Upload Communication Content functionality is not working from the Internal Note creation screen
Ravi Lodhi created OFBIZ-7830: - Summary: Upload Communication Content functionality is not working from the Internal Note creation screen Key: OFBIZ-7830 URL: https://issues.apache.org/jira/browse/OFBIZ-7830 Project: OFBiz Issue Type: Bug Components: party Affects Versions: Trunk Reporter: Ravi Lodhi Assignee: Ravi Lodhi 1) Go to Party component. 2) Navigate to My Communication page. 3) Go to create New Internal Note screen. 4) Here under Communication Content section, try to upload any content. Not be able to upload any content. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7561) Attr Name should not be allowed to edit while updating Party Attribute record
[ https://issues.apache.org/jira/browse/OFBIZ-7561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mridul Pathak reassigned OFBIZ-7561: Assignee: Mridul Pathak > Attr Name should not be allowed to edit while updating Party Attribute record > - > > Key: OFBIZ-7561 > URL: https://issues.apache.org/jira/browse/OFBIZ-7561 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk >Reporter: Ankit Joshi >Assignee: Mridul Pathak >Priority: Minor > Attachments: OFBIZ-7561-13.07.patch, OFBIZ-7561-14.12.patch, > OFBIZ-7561-trunk.patch, UpdatePartyAttribute1.png, UpdatePartyAttribute2.png > > > Steps to regenerate - > 1) Navigate to SFA -> Contacts > 2) Select any contacts and move to detail page. > 3) There is a section to Create / Update Party Attribute. > 4) Create New Party Attribute. > 5) Click on Edit button to update Party Attribute. > Actual: All fields including AttrName is allowed to edit. Process is giving > error in case when user update the AttrName. > Expected : AttrName field should be non-editable while updating the Party > Attribute record as this field is part of the primary key. > Here is the reference link - > https://ofbiz-vm.apache.org:8443/sfa/control/editPartyAttribute?partyId=DemoCustomer -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7829) hhfacility: Remove unused imports from Groovy files for code optimization
[ https://issues.apache.org/jira/browse/OFBIZ-7829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Joshi updated OFBIZ-7829: --- Assignee: (was: Ankit Joshi) > hhfacility: Remove unused imports from Groovy files for code optimization > - > > Key: OFBIZ-7829 > URL: https://issues.apache.org/jira/browse/OFBIZ-7829 > Project: OFBiz > Issue Type: Sub-task > Components: specialpurpose/hhfacility >Affects Versions: Trunk >Reporter: Ankit Joshi >Priority: Minor > Fix For: 14.12.01, 15.12.01 > > Attachments: OFBIZ-7829-trunk.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7816) Profile of contact person not shown on quick add of contact in SFA
[
https://issues.apache.org/jira/browse/OFBIZ-7816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditi Patidar updated OFBIZ-7816:
-
Attachment: OFBIZ-7816.patch
Providing the patch to fix the issue. Here 'createContact' service was not
returning 'roleTypeId' and it required to fetch the record from
'RoleTypeAndParty' entity.
{code}
roleTypeId = parameters.roleTypeId;
roleTypeAndParty = from("RoleTypeAndParty").where("partyId",
parameters.partyId, "roleTypeId", roleTypeId).queryFirst();
if ("ACCOUNT".equals(roleTypeId)) {
context.accountDescription = roleTypeAndParty.description;
} else if ("CONTACT".equals(roleTypeId)) {
context.contactDescription = roleTypeAndParty.description;
}
{code}
> Profile of contact person not shown on quick add of contact in SFA
> --
>
> Key: OFBIZ-7816
> URL: https://issues.apache.org/jira/browse/OFBIZ-7816
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12
>Reporter: Aditi Patidar
>Assignee: Aditi Patidar
> Labels: sfa
> Attachments: OFBIZ-7816.patch, quick add contact.png
>
>
> Steps to regenerate issue:
> 1. Navigate to SFA.
> 2. Enter 'First Name', 'Last Name' in 'Quick Add Contact' section and press
> 'Submit' button.
> Refer the attached screenshot to view the issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7829) hhfacility: Remove unused imports from Groovy files for code optimization
[ https://issues.apache.org/jira/browse/OFBIZ-7829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Joshi updated OFBIZ-7829: --- Attachment: OFBIZ-7829-trunk.patch Attached the patch to remove unused imports for code optimization purpose > hhfacility: Remove unused imports from Groovy files for code optimization > - > > Key: OFBIZ-7829 > URL: https://issues.apache.org/jira/browse/OFBIZ-7829 > Project: OFBiz > Issue Type: Sub-task > Components: specialpurpose/hhfacility >Affects Versions: Trunk >Reporter: Ankit Joshi >Assignee: Ankit Joshi >Priority: Minor > Fix For: 14.12.01, 15.12.01 > > Attachments: OFBIZ-7829-trunk.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7525) UiLabels missing on Examples PDF
[ https://issues.apache.org/jira/browse/OFBIZ-7525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mridul Pathak closed OFBIZ-7525. > UiLabels missing on Examples PDF > > > Key: OFBIZ-7525 > URL: https://issues.apache.org/jira/browse/OFBIZ-7525 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/example >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12 >Reporter: Ankit Joshi >Assignee: Mridul Pathak >Priority: Minor > Fix For: 14.12.01, 15.12.01 > > Attachments: OFBIZ-7525-14.12.patch, OFBIZ-7525-trunk.patch > > > Steps to regenerate - > 1) Navigate to example > 2) Search Examples and go to details page. > 3) View Example PDF > ExampleUiLabels class is missing from the screen. > Here is the reference link - > https://ofbiz-vm.apache.org:8443/example/control/ExampleReportPdf?exampleId=EX01 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7827) Create billing account functionality not working on party profile
[ https://issues.apache.org/jira/browse/OFBIZ-7827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Padmavati Rawat updated OFBIZ-7827: --- Attachment: errorinaddbilling.png > Create billing account functionality not working on party profile > - > > Key: OFBIZ-7827 > URL: https://issues.apache.org/jira/browse/OFBIZ-7827 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk >Reporter: Padmavati Rawat > Attachments: errorinaddbilling.png > > > On party profile page when try to add billing account it throws error on > screen. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7829) hhfacility: Remove unused imports from Groovy files for code optimization
Ankit Joshi created OFBIZ-7829: -- Summary: hhfacility: Remove unused imports from Groovy files for code optimization Key: OFBIZ-7829 URL: https://issues.apache.org/jira/browse/OFBIZ-7829 Project: OFBiz Issue Type: Sub-task Components: specialpurpose/hhfacility Affects Versions: Trunk Reporter: Ankit Joshi Assignee: Ankit Joshi Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7827) Create billing account functionality not working on party profile
[ https://issues.apache.org/jira/browse/OFBIZ-7827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Padmavati Rawat updated OFBIZ-7827: --- Description: On party profile page when try to add billing account it throws error on screen. (was: On party profile page when to add billing account it throws error on screen. ) > Create billing account functionality not working on party profile > - > > Key: OFBIZ-7827 > URL: https://issues.apache.org/jira/browse/OFBIZ-7827 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk >Reporter: Padmavati Rawat > > On party profile page when try to add billing account it throws error on > screen. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7828) Entity and Service definition
[ https://issues.apache.org/jira/browse/OFBIZ-7828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishi Solanki updated OFBIZ-7828: - Priority: Major (was: Minor) > Entity and Service definition > - > > Key: OFBIZ-7828 > URL: https://issues.apache.org/jira/browse/OFBIZ-7828 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Rishi Solanki > > As per discussion on dev list on email thread-: "Entity and Service > definition" Here is the parent task for the same. > TODO's from same thread, review entities/services on following parameters; > 1) Many entity definitions having relationships with view-entities, like > OrderHeader entity maintain relationship with OrderHeaderNoteView and > OrderItemAndShipGroupAssoc. We should remove it, maintain the relationship at > view-entities level if required. Also change the code where this relation is > in use. > 2) Many entities having service implementation exists but they can be simply > convert into entity-auto, that means can use the power OFBiz provides. > 3) As mentioned initially many entities do not have CRUD services exists, we > should implement or use entity-auto for them wherever applicable. Also remove > direct use of delegator for them. > 4) Many entities having from date and thru date, Or status Or Enumeration to > manage the historical data, but services actually remove those entity data. > We should change the service implementation to maintain the historical data. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7828) Entity and Service definition
Rishi Solanki created OFBIZ-7828: Summary: Entity and Service definition Key: OFBIZ-7828 URL: https://issues.apache.org/jira/browse/OFBIZ-7828 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: Trunk Reporter: Rishi Solanki Priority: Minor As per discussion on dev list on email thread-: "Entity and Service definition" Here is the parent task for the same. TODO's from same thread, review entities/services on following parameters; 1) Many entity definitions having relationships with view-entities, like OrderHeader entity maintain relationship with OrderHeaderNoteView and OrderItemAndShipGroupAssoc. We should remove it, maintain the relationship at view-entities level if required. Also change the code where this relation is in use. 2) Many entities having service implementation exists but they can be simply convert into entity-auto, that means can use the power OFBiz provides. 3) As mentioned initially many entities do not have CRUD services exists, we should implement or use entity-auto for them wherever applicable. Also remove direct use of delegator for them. 4) Many entities having from date and thru date, Or status Or Enumeration to manage the historical data, but services actually remove those entity data. We should change the service implementation to maintain the historical data. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7827) Create billing account functionality not working on party profile
Padmavati Rawat created OFBIZ-7827: -- Summary: Create billing account functionality not working on party profile Key: OFBIZ-7827 URL: https://issues.apache.org/jira/browse/OFBIZ-7827 Project: OFBiz Issue Type: Bug Components: party Affects Versions: Trunk Reporter: Padmavati Rawat On party profile page when to add billing account it throws error on screen. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7826) Clean up commented out code in Java source for Accounting
Harsh Vijaywargiya created OFBIZ-7826: - Summary: Clean up commented out code in Java source for Accounting Key: OFBIZ-7826 URL: https://issues.apache.org/jira/browse/OFBIZ-7826 Project: OFBiz Issue Type: Sub-task Components: accounting Reporter: Harsh Vijaywargiya Assignee: Harsh Vijaywargiya Priority: Minor Fix For: Upcoming Branch Clean up commented out code in Java source for Accounting -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7525) UiLabels missing on Examples PDF
[ https://issues.apache.org/jira/browse/OFBIZ-7525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mridul Pathak reassigned OFBIZ-7525: Assignee: Mridul Pathak > UiLabels missing on Examples PDF > > > Key: OFBIZ-7525 > URL: https://issues.apache.org/jira/browse/OFBIZ-7525 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/example >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12 >Reporter: Ankit Joshi >Assignee: Mridul Pathak >Priority: Minor > Attachments: OFBIZ-7525-14.12.patch, OFBIZ-7525-trunk.patch > > > Steps to regenerate - > 1) Navigate to example > 2) Search Examples and go to details page. > 3) View Example PDF > ExampleUiLabels class is missing from the screen. > Here is the reference link - > https://ofbiz-vm.apache.org:8443/example/control/ExampleReportPdf?exampleId=EX01 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7825) Form field labels are not rendered properly in the Attach Content section in the Content screen.
[ https://issues.apache.org/jira/browse/OFBIZ-7825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Patwa updated OFBIZ-7825: Attachment: screenshot-1.png > Form field labels are not rendered properly in the Attach Content section in > the Content screen. > > > Key: OFBIZ-7825 > URL: https://issues.apache.org/jira/browse/OFBIZ-7825 > Project: OFBiz > Issue Type: Bug > Components: marketing >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12 >Reporter: Aditya Patwa >Priority: Minor > Attachments: OFBIZ-7825.patch, screenshot-1.png > > > Steps to regenerate : > 1) Navigate to https://localhost:8443/sfa/control/FindCommunicationEvents > 2) Click on a communication event > 3) On the communication event screen navigate to Content sub menu. > 4) The form field labels are not rendered properly -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7825) Form field labels are not rendered properly in the Attach Content section in the Content screen.
[ https://issues.apache.org/jira/browse/OFBIZ-7825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Patwa updated OFBIZ-7825: Attachment: OFBIZ-7825.patch Added the missing UI Label resource in the main-decorator for sfa component. > Form field labels are not rendered properly in the Attach Content section in > the Content screen. > > > Key: OFBIZ-7825 > URL: https://issues.apache.org/jira/browse/OFBIZ-7825 > Project: OFBiz > Issue Type: Bug > Components: marketing >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12 >Reporter: Aditya Patwa >Priority: Minor > Attachments: OFBIZ-7825.patch > > > Steps to regenerate : > 1) Navigate to https://localhost:8443/sfa/control/FindCommunicationEvents > 2) Click on a communication event > 3) On the communication event screen navigate to Content sub menu. > 4) The form field labels are not rendered properly -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7823) Product lookup should be available while adding items in the shopping list
[ https://issues.apache.org/jira/browse/OFBIZ-7823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mridul Pathak closed OFBIZ-7823. > Product lookup should be available while adding items in the shopping list > -- > > Key: OFBIZ-7823 > URL: https://issues.apache.org/jira/browse/OFBIZ-7823 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Ankit Joshi >Assignee: Mridul Pathak >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-7823_trunk.patch > > > Steps to regenerate - > 1) Navigate to Party Component and search parties. > 2) Go to party detail page and click on shopping list tab. > 3) Create new shopping list if not exist for the party. > 4) Try to add an item to the shopping list. > There should be product lookup to add items easily to the shopping list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7823) Product lookup should be available while adding items in the shopping list
[ https://issues.apache.org/jira/browse/OFBIZ-7823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mridul Pathak updated OFBIZ-7823: - Summary: Product lookup should be available while adding items in the shopping list (was: Product lookup should be there will adding items in the shopping list) > Product lookup should be available while adding items in the shopping list > -- > > Key: OFBIZ-7823 > URL: https://issues.apache.org/jira/browse/OFBIZ-7823 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Ankit Joshi >Assignee: Mridul Pathak >Priority: Minor > Attachments: OFBIZ-7823_trunk.patch > > > Steps to regenerate - > 1) Navigate to Party Component and search parties. > 2) Go to party detail page and click on shopping list tab. > 3) Create new shopping list if not exist for the party. > 4) Try to add an item to the shopping list. > There should be product lookup to add items easily to the shopping list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7825) Form field labels are not rendered properly in the Attach Content section in the Content screen.
Aditya Patwa created OFBIZ-7825: --- Summary: Form field labels are not rendered properly in the Attach Content section in the Content screen. Key: OFBIZ-7825 URL: https://issues.apache.org/jira/browse/OFBIZ-7825 Project: OFBiz Issue Type: Bug Components: marketing Affects Versions: Release Branch 15.12, Trunk, Release Branch 14.12 Reporter: Aditya Patwa Priority: Minor Steps to regenerate : 1) Navigate to https://localhost:8443/sfa/control/FindCommunicationEvents 2) Click on a communication event 3) On the communication event screen navigate to Content sub menu. 4) The form field labels are not rendered properly -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7272) Enforce noninstantiability to all Utility classes
[
https://issues.apache.org/jira/browse/OFBIZ-7272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380557#comment-15380557
]
Rishi Solanki commented on OFBIZ-7272:
--
Few more classes needs to be taken care or discuss;
{code}
framework/entity/src/org/ofbiz/entity/transaction/TransactionUtil.java
framework/service/src/org/ofbiz/service/ServiceUtil.java
framework/service/src/org/ofbiz/service/calendar/TemporalExpressionWorker.java
DataResourceWorker.java
ProductUtil.java
CategoryUtil.java
StartupCommandUtil.java
ICalWorker.java
JNDIConfigUtil.java
{code}
> Enforce noninstantiability to all Utility classes
> -
>
> Key: OFBIZ-7272
> URL: https://issues.apache.org/jira/browse/OFBIZ-7272
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Arun Patidar
> Attachments: OFBIZ-7272.patch
>
>
> I have discusses this in past on mailing list, that Utility, helper, worker
> classes which contains only static methods should not be instantiable. Also
> we can restrict it by adding a private constructor.
> Currently OFBiz has many such classes which should have private constructor.
> Identify all the *Worker.java, *.Helper.java, and *Util.java which do not
> have any non static method/member are eligible for having a private
> constructor.
> Reference why we should do this :
> http://www.informit.com/articles/article.aspx?p=1216151&seqNum=4
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7809) Enforce noninstantiability to UtilXml class
[ https://issues.apache.org/jira/browse/OFBIZ-7809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar updated OFBIZ-7809: --- Attachment: OFBIZ-7809.patch Provided patch for the issue. Thanks [~rishisolankii] for providing the detailed explanation. > Enforce noninstantiability to UtilXml class > --- > > Key: OFBIZ-7809 > URL: https://issues.apache.org/jira/browse/OFBIZ-7809 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Arun Patidar >Assignee: Chinmay Patidar >Priority: Minor > Attachments: OFBIZ-7809.patch > > > - Make class as final. > - Add a private constructor. > No variables need to change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7802) Enforce noninstantiability to ProductWorker class
[
https://issues.apache.org/jira/browse/OFBIZ-7802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chinmay Patidar updated OFBIZ-7802:
---
Attachment: OFBIZ-7802.patch
Provided patch for the issue. Thanks [~rishisolankii] for providing detailed
explanation.
> Enforce noninstantiability to ProductWorker class
> -
>
> Key: OFBIZ-7802
> URL: https://issues.apache.org/jira/browse/OFBIZ-7802
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Chinmay Patidar
>Priority: Minor
> Attachments: OFBIZ-7802.patch
>
>
> - Make class as final.
> - Private constructor already exists, by making it final we just matching the
> patterns from other utility classes.
> - Make following public static final variables as private;
> {code}
> public static final String resource = "ProductUiLabels";
> public static final MathContext generalRounding = new MathContext(10);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7823) Product lookup should be there will adding items in the shopping list
[ https://issues.apache.org/jira/browse/OFBIZ-7823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mridul Pathak reassigned OFBIZ-7823: Assignee: Mridul Pathak > Product lookup should be there will adding items in the shopping list > - > > Key: OFBIZ-7823 > URL: https://issues.apache.org/jira/browse/OFBIZ-7823 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Ankit Joshi >Assignee: Mridul Pathak >Priority: Minor > Attachments: OFBIZ-7823_trunk.patch > > > Steps to regenerate - > 1) Navigate to Party Component and search parties. > 2) Go to party detail page and click on shopping list tab. > 3) Create new shopping list if not exist for the party. > 4) Try to add an item to the shopping list. > There should be product lookup to add items easily to the shopping list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7168) Run MRP shows all type of facilities
[ https://issues.apache.org/jira/browse/OFBIZ-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mridul Pathak closed OFBIZ-7168. > Run MRP shows all type of facilities > > > Key: OFBIZ-7168 > URL: https://issues.apache.org/jira/browse/OFBIZ-7168 > Project: OFBiz > Issue Type: Improvement > Components: manufacturing >Affects Versions: Trunk >Reporter: Sanjay Yadav >Assignee: Mridul Pathak > Fix For: Upcoming Branch > > Attachments: OFBIZ-7168_trunk.patch > > > When we go to Run MRP screen, all types of facilities (including facilities > with no type) are listed here in the Facility drop down. > I think, It's better to list only WAREHOUSE or some specific type of > facilities. Basically, there is no meaning of showing facilities which don't > have proper type or type is not available for e.g. CALL_CENTER, FLOOR etc. > Let me know if anyone have any thoughts on this. Thanks! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Issue Comment Deleted] (OFBIZ-7802) Enforce noninstantiability to ProductWorker class
[
https://issues.apache.org/jira/browse/OFBIZ-7802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chinmay Patidar updated OFBIZ-7802:
---
Comment: was deleted
(was: Providing the patch for the issue. Thanks [~rishisolankii] for the
detailed explanation.)
> Enforce noninstantiability to ProductWorker class
> -
>
> Key: OFBIZ-7802
> URL: https://issues.apache.org/jira/browse/OFBIZ-7802
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Chinmay Patidar
>Priority: Minor
>
> - Make class as final.
> - Private constructor already exists, by making it final we just matching the
> patterns from other utility classes.
> - Make following public static final variables as private;
> {code}
> public static final String resource = "ProductUiLabels";
> public static final MathContext generalRounding = new MathContext(10);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7802) Enforce noninstantiability to ProductWorker class
[
https://issues.apache.org/jira/browse/OFBIZ-7802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chinmay Patidar updated OFBIZ-7802:
---
Attachment: (was: OFBIZ-7802)
> Enforce noninstantiability to ProductWorker class
> -
>
> Key: OFBIZ-7802
> URL: https://issues.apache.org/jira/browse/OFBIZ-7802
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Chinmay Patidar
>Priority: Minor
>
> - Make class as final.
> - Private constructor already exists, by making it final we just matching the
> patterns from other utility classes.
> - Make following public static final variables as private;
> {code}
> public static final String resource = "ProductUiLabels";
> public static final MathContext generalRounding = new MathContext(10);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7802) Enforce noninstantiability to ProductWorker class
[
https://issues.apache.org/jira/browse/OFBIZ-7802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chinmay Patidar updated OFBIZ-7802:
---
Attachment: OFBIZ-7802
Providing the patch for the issue. Thanks [~rishisolankii] for the detailed
explanation.
> Enforce noninstantiability to ProductWorker class
> -
>
> Key: OFBIZ-7802
> URL: https://issues.apache.org/jira/browse/OFBIZ-7802
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Chinmay Patidar
>Priority: Minor
> Attachments: OFBIZ-7802
>
>
> - Make class as final.
> - Private constructor already exists, by making it final we just matching the
> patterns from other utility classes.
> - Make following public static final variables as private;
> {code}
> public static final String resource = "ProductUiLabels";
> public static final MathContext generalRounding = new MathContext(10);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7168) Run MRP shows all type of facilities
[ https://issues.apache.org/jira/browse/OFBIZ-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380552#comment-15380552 ] Mridul Pathak commented on OFBIZ-7168: -- Committed this change in trunk r1752893 as no further concerns were raised. Thanks [~sanjay.ya...@hotwaxsystems.com] for reporting the issue and [~ankit.joshi] for providing the patch. > Run MRP shows all type of facilities > > > Key: OFBIZ-7168 > URL: https://issues.apache.org/jira/browse/OFBIZ-7168 > Project: OFBiz > Issue Type: Improvement > Components: manufacturing >Affects Versions: Trunk >Reporter: Sanjay Yadav >Assignee: Mridul Pathak > Attachments: OFBIZ-7168_trunk.patch > > > When we go to Run MRP screen, all types of facilities (including facilities > with no type) are listed here in the Facility drop down. > I think, It's better to list only WAREHOUSE or some specific type of > facilities. Basically, there is no meaning of showing facilities which don't > have proper type or type is not available for e.g. CALL_CENTER, FLOOR etc. > Let me know if anyone have any thoughts on this. Thanks! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-7168) Run MRP shows all type of facilities
[ https://issues.apache.org/jira/browse/OFBIZ-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380552#comment-15380552 ] Mridul Pathak edited comment on OFBIZ-7168 at 7/16/16 6:20 AM: --- Committed this change in trunk r1752893 as no further concerns were raised. Thanks [~sanjay.ya...@hotwaxsystems.com] for reporting the issue and [~ankit.joshi] for providing the patch. Thanks [~pfm.smits] for review. was (Author: mridul.pathak): Committed this change in trunk r1752893 as no further concerns were raised. Thanks [~sanjay.ya...@hotwaxsystems.com] for reporting the issue and [~ankit.joshi] for providing the patch. > Run MRP shows all type of facilities > > > Key: OFBIZ-7168 > URL: https://issues.apache.org/jira/browse/OFBIZ-7168 > Project: OFBiz > Issue Type: Improvement > Components: manufacturing >Affects Versions: Trunk >Reporter: Sanjay Yadav >Assignee: Mridul Pathak > Attachments: OFBIZ-7168_trunk.patch > > > When we go to Run MRP screen, all types of facilities (including facilities > with no type) are listed here in the Facility drop down. > I think, It's better to list only WAREHOUSE or some specific type of > facilities. Basically, there is no meaning of showing facilities which don't > have proper type or type is not available for e.g. CALL_CENTER, FLOOR etc. > Let me know if anyone have any thoughts on this. Thanks! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7812) Enforce noninstantiability to DatabaseUtil class
[
https://issues.apache.org/jira/browse/OFBIZ-7812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rishi Solanki closed OFBIZ-7812.
Resolution: Invalid
Assignee: Rishi Solanki
> Enforce noninstantiability to DatabaseUtil class
>
>
> Key: OFBIZ-7812
> URL: https://issues.apache.org/jira/browse/OFBIZ-7812
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Reporter: Arun Patidar
>Assignee: Rishi Solanki
>Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> - Make following protected variable as private
> {code}
> protected ModelFieldTypeReader modelFieldTypeReader = null;
> protected Datasource datasourceInfo = null;
> protected GenericHelperInfo helperInfo = null;
> // Legacy Connections
> protected String connectionUrl = null;
> protected String driverName = null;
> protected String userName = null;
> protected String password = null;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7812) Enforce noninstantiability to DatabaseUtil class
[
https://issues.apache.org/jira/browse/OFBIZ-7812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380546#comment-15380546
]
Rishi Solanki commented on OFBIZ-7812:
--
DataBaseUtil class by name looks like a utility class which contains the static
method. But by implementation it is not a class which can not be instantiated.
So this class won't come under this effort. We can close this ticket. Thanks to
[~arunpati] and [~rohit.koushal], [~rahul.kushwah] for discussion and
finalizing.
> Enforce noninstantiability to DatabaseUtil class
>
>
> Key: OFBIZ-7812
> URL: https://issues.apache.org/jira/browse/OFBIZ-7812
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Reporter: Arun Patidar
>Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> - Make following protected variable as private
> {code}
> protected ModelFieldTypeReader modelFieldTypeReader = null;
> protected Datasource datasourceInfo = null;
> protected GenericHelperInfo helperInfo = null;
> // Legacy Connections
> protected String connectionUrl = null;
> protected String driverName = null;
> protected String userName = null;
> protected String password = null;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7812) Enforce noninstantiability to DatabaseUtil class
[
https://issues.apache.org/jira/browse/OFBIZ-7812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380549#comment-15380549
]
Rahul Singh commented on OFBIZ-7812:
DatabaseUtil class constructor was used in various other classes so closing
this issue.
> Enforce noninstantiability to DatabaseUtil class
>
>
> Key: OFBIZ-7812
> URL: https://issues.apache.org/jira/browse/OFBIZ-7812
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Reporter: Arun Patidar
>Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> - Make following protected variable as private
> {code}
> protected ModelFieldTypeReader modelFieldTypeReader = null;
> protected Datasource datasourceInfo = null;
> protected GenericHelperInfo helperInfo = null;
> // Legacy Connections
> protected String connectionUrl = null;
> protected String driverName = null;
> protected String userName = null;
> protected String password = null;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (OFBIZ-7824) Add validation for credit card number length
Padmavati Rawat created OFBIZ-7824: -- Summary: Add validation for credit card number length Key: OFBIZ-7824 URL: https://issues.apache.org/jira/browse/OFBIZ-7824 Project: OFBiz Issue Type: Improvement Components: ALL APPLICATIONS Affects Versions: Trunk Reporter: Padmavati Rawat Priority: Minor Ofbiz allows for any length for credit card numbers, as default length is 16 digits. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6302) Ftl to Widget: improve ViewCertificate to use widgets in stead of ftl
[ https://issues.apache.org/jira/browse/OFBIZ-6302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-6302: --- Attachment: OFBIZ-6302-Certificate.patch Hi Pierre, Here is the patch updated. I fixed things by hand: tabs in the groovy files and removed the ftl file because of a tree conflicts due to the recent ftl files move. I let you test because I did not find where this is used. I found the ViewCertificate and importIssuerProvision requests but they are all in common stuff so I did not know how to relate it to a webapp. Also there is still a ViewCertificate.ftl in party but it does not seem to be used > Ftl to Widget: improve ViewCertificate to use widgets in stead of ftl > - > > Key: OFBIZ-6302 > URL: https://issues.apache.org/jira/browse/OFBIZ-6302 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Jacques Le Roux > Labels: security > Attachments: OFBIZ-6302-Certificate.patch, > OFBIZ-6302-Certificate.patch > > > Currently the screen ViewCertificate uses a widget to render the form(s). > This can be replaced by widgets -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7700) File Not Found exception in export to ebay
[ https://issues.apache.org/jira/browse/OFBIZ-7700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mridul Pathak reassigned OFBIZ-7700: Assignee: Mridul Pathak > File Not Found exception in export to ebay > -- > > Key: OFBIZ-7700 > URL: https://issues.apache.org/jira/browse/OFBIZ-7700 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/ebay >Affects Versions: Trunk >Reporter: Ankit Joshi >Assignee: Mridul Pathak > Attachments: OFBIZ-7700.patch > > > Steps to regenerate - > Navigate to ebay component and perform advanced search in category. > Here is the reference link - > https://ofbiz-vm.apache.org:8443/ebay/control/keywordsearch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7823) Product lookup should be there will adding items in the shopping list
[ https://issues.apache.org/jira/browse/OFBIZ-7823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Joshi updated OFBIZ-7823: --- Assignee: (was: Ankit Joshi) > Product lookup should be there will adding items in the shopping list > - > > Key: OFBIZ-7823 > URL: https://issues.apache.org/jira/browse/OFBIZ-7823 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Ankit Joshi >Priority: Minor > Attachments: OFBIZ-7823_trunk.patch > > > Steps to regenerate - > 1) Navigate to Party Component and search parties. > 2) Go to party detail page and click on shopping list tab. > 3) Create new shopping list if not exist for the party. > 4) Try to add an item to the shopping list. > There should be product lookup to add items easily to the shopping list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7822) Make Create Menu tab bar for iCalendar consistent
[ https://issues.apache.org/jira/browse/OFBIZ-7822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Avnindra Sharma updated OFBIZ-7822: --- Attachment: OFBIZ-7822.patch Added a button bar for iCalendar in the main decorator to make it consistent throughout the app bar. > Make Create Menu tab bar for iCalendar consistent > - > > Key: OFBIZ-7822 > URL: https://issues.apache.org/jira/browse/OFBIZ-7822 > Project: OFBiz > Issue Type: Sub-task > Components: workeffort >Reporter: Avnindra Sharma >Assignee: Avnindra Sharma >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-7822.patch > > > Add a create iCalendar tab bar in the main decorator to maintain the > consistency throughout the tab bar of iCalendar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7818) Make Create Menu tab bar for workeffort consistent
[ https://issues.apache.org/jira/browse/OFBIZ-7818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Avnindra Sharma updated OFBIZ-7818: --- Attachment: OFBIZ-7818.patch Added a button bar for workeffort in the main decorator to make it consistent throughout the app bar. > Make Create Menu tab bar for workeffort consistent > -- > > Key: OFBIZ-7818 > URL: https://issues.apache.org/jira/browse/OFBIZ-7818 > Project: OFBiz > Issue Type: Sub-task > Components: workeffort >Reporter: Avnindra Sharma >Assignee: Avnindra Sharma >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-7818.patch > > > Add a create workeffort tab bar in the main decorator to maintain the > consistency throughout the tab bar of workeffort. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7823) Product lookup should be there will adding items in the shopping list
[ https://issues.apache.org/jira/browse/OFBIZ-7823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Joshi updated OFBIZ-7823: --- Attachment: OFBIZ-7823_trunk.patch Attached the patch with the proper fix. > Product lookup should be there will adding items in the shopping list > - > > Key: OFBIZ-7823 > URL: https://issues.apache.org/jira/browse/OFBIZ-7823 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Ankit Joshi >Assignee: Ankit Joshi >Priority: Minor > Attachments: OFBIZ-7823_trunk.patch > > > Steps to regenerate - > 1) Navigate to Party Component and search parties. > 2) Go to party detail page and click on shopping list tab. > 3) Create new shopping list if not exist for the party. > 4) Try to add an item to the shopping list. > There should be product lookup to add items easily to the shopping list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7810) Enforce noninstantiability to UelUtil class
[
https://issues.apache.org/jira/browse/OFBIZ-7810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rishi Solanki updated OFBIZ-7810:
-
Description:
- Make class as final.
- Add a private constructor.
- Make following protected variable as private
{code}
protected static final ExpressionFactory exprFactory =
JuelConnector.newExpressionFactory();
protected static final ELResolver defaultResolver = new
ExtendedCompositeResolver()
{code}
- Make following protected classes as private and do related changes for
variables in them;
{code}
protected static class BasicContext extends ELContext
protected static class ReadOnlyContext extends ELContext
protected static class ReadOnlyVariableMapper extends VariableMapper
protected static class BasicVariableMapper extends VariableMapper
protected static class ReadOnlyExpression extends ValueExpression
protected static class BasicValueExpression extends ValueExpression
protected static class ExtendedCompositeResolver extends CompositeELResolver
protected static class ExtendedListResolver extends ListELResolver
protected static class ExtendedMapResolver extends MapELResolver
{code}
was:
- Make class as final.
- Add a private constructor.
- Make following protected variable as private
{code}
protected static final ExpressionFactory exprFactory =
JuelConnector.newExpressionFactory();
protected static final ELResolver defaultResolver = new
ExtendedCompositeResolver()
{code}
> Enforce noninstantiability to UelUtil class
> ---
>
> Key: OFBIZ-7810
> URL: https://issues.apache.org/jira/browse/OFBIZ-7810
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> - Make following protected variable as private
> {code}
> protected static final ExpressionFactory exprFactory =
> JuelConnector.newExpressionFactory();
> protected static final ELResolver defaultResolver = new
> ExtendedCompositeResolver()
> {code}
> - Make following protected classes as private and do related changes for
> variables in them;
> {code}
> protected static class BasicContext extends ELContext
> protected static class ReadOnlyContext extends ELContext
>protected static class ReadOnlyVariableMapper extends VariableMapper
> protected static class BasicVariableMapper extends VariableMapper
> protected static class ReadOnlyExpression extends ValueExpression
> protected static class BasicValueExpression extends ValueExpression
> protected static class ExtendedCompositeResolver extends
> CompositeELResolver
> protected static class ExtendedListResolver extends ListELResolver
> protected static class ExtendedMapResolver extends MapELResolver
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (OFBIZ-7761) workeffort: Remove unused imports from groovy files for code optimization
[ https://issues.apache.org/jira/browse/OFBIZ-7761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mridul Pathak closed OFBIZ-7761. > workeffort: Remove unused imports from groovy files for code optimization > - > > Key: OFBIZ-7761 > URL: https://issues.apache.org/jira/browse/OFBIZ-7761 > Project: OFBiz > Issue Type: Sub-task > Components: workeffort >Affects Versions: Trunk >Reporter: Ankit Joshi >Assignee: Mridul Pathak >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-7761_trunk.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7823) Product lookup should be there will adding items in the shopping list
Ankit Joshi created OFBIZ-7823: -- Summary: Product lookup should be there will adding items in the shopping list Key: OFBIZ-7823 URL: https://issues.apache.org/jira/browse/OFBIZ-7823 Project: OFBiz Issue Type: Improvement Components: party Affects Versions: Trunk Reporter: Ankit Joshi Assignee: Ankit Joshi Priority: Minor Steps to regenerate - 1) Navigate to Party Component and search parties. 2) Go to party detail page and click on shopping list tab. 3) Create new shopping list if not exist for the party. 4) Try to add an item to the shopping list. There should be product lookup to add items easily to the shopping list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7822) Make Create Menu tab bar for iCalendar consistent
Avnindra Sharma created OFBIZ-7822: -- Summary: Make Create Menu tab bar for iCalendar consistent Key: OFBIZ-7822 URL: https://issues.apache.org/jira/browse/OFBIZ-7822 Project: OFBiz Issue Type: Sub-task Components: workeffort Reporter: Avnindra Sharma Assignee: Avnindra Sharma Priority: Minor Fix For: Trunk Add a create iCalendar tab bar in the main decorator to maintain the consistency throughout the tab bar of iCalendar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7761) workeffort: Remove unused imports from groovy files for code optimization
[ https://issues.apache.org/jira/browse/OFBIZ-7761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mridul Pathak updated OFBIZ-7761: - Fix Version/s: (was: 15.12.01) (was: 14.12.01) > workeffort: Remove unused imports from groovy files for code optimization > - > > Key: OFBIZ-7761 > URL: https://issues.apache.org/jira/browse/OFBIZ-7761 > Project: OFBiz > Issue Type: Sub-task > Components: workeffort >Affects Versions: Trunk >Reporter: Ankit Joshi >Assignee: Mridul Pathak >Priority: Minor > Attachments: OFBIZ-7761_trunk.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7821) Remove unused system generated fields from all data files
Suraj Khurana created OFBIZ-7821: Summary: Remove unused system generated fields from all data files Key: OFBIZ-7821 URL: https://issues.apache.org/jira/browse/OFBIZ-7821 Project: OFBiz Issue Type: Improvement Affects Versions: Trunk Reporter: Suraj Khurana Priority: Minor There are four system generated fields for every entity as lastUpdatedStamp, lastUpdatedTxStamp, createdStamp and createdTxStamp To increase readability of data files, these fields are not necessary to be there in data files, as it gets generated every time when data load occurs. This ticket will be served as a parent ticket and I will be creating child tickets component wise for all affected components. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6595) Have the ability to test solr queries through widgets (screens & forms)
[ https://issues.apache.org/jira/browse/OFBIZ-6595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380527#comment-15380527 ] Amardeep Singh Jhajj commented on OFBIZ-6595: - Hi Pierre, I have some questions in my mind about this issue- 1. How we are going to help end users here to execute query on Solr index to enhance applicability of application? 2. And how it will be different and better than Solr admin query tool (https://localhost:8443/solr/#/solrdefault/query)?. If its the same then why do we need it in the first place? 3. Are you planning to have query browser like we have in JIRA search navigator using jql? Example: https://issues.apache.org/jira/issues/?jql=project%20%3D%20OFBIZ 4. What is the status of this issue now? currently I can see functionality is incomplete (rather we would say functionality is broken). Please let us know your thoughts and let me know if I can assist you in moving forward. Thanks > Have the ability to test solr queries through widgets (screens & forms) > --- > > Key: OFBIZ-6595 > URL: https://issues.apache.org/jira/browse/OFBIZ-6595 > Project: OFBiz > Issue Type: Improvement > Components: specialpurpose/solr >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Jacques Le Roux > Attachments: OFBIZ-6595-r1.patch > > > Adding widgest (screens, forms, etc) so that an end-user can execute a search > against the data indexed would enhance the applicability of the application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7761) workeffort: Remove unused imports from groovy files for code optimization
[ https://issues.apache.org/jira/browse/OFBIZ-7761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mridul Pathak reassigned OFBIZ-7761: Assignee: Mridul Pathak > workeffort: Remove unused imports from groovy files for code optimization > - > > Key: OFBIZ-7761 > URL: https://issues.apache.org/jira/browse/OFBIZ-7761 > Project: OFBiz > Issue Type: Sub-task > Components: workeffort >Affects Versions: Trunk >Reporter: Ankit Joshi >Assignee: Mridul Pathak >Priority: Minor > Fix For: 14.12.01, 15.12.01 > > Attachments: OFBIZ-7761_trunk.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7811) Enforce noninstantiability to FreeMarkerWorker class
[
https://issues.apache.org/jira/browse/OFBIZ-7811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amit Gadaley updated OFBIZ-7811:
Attachment: OFBIZ-7811.patch
Provided patch. Thanks [~arunpaul] and [~rishisolankii] for the guidance.
> Enforce noninstantiability to FreeMarkerWorker class
>
>
> Key: OFBIZ-7811
> URL: https://issues.apache.org/jira/browse/OFBIZ-7811
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Amit Gadaley
>Priority: Minor
> Attachments: OFBIZ-7811.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make following protected method as public
> {code}
> protected static void loadTransforms(
> {code}
> No variables needs to be change for this class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-6302) Ftl to Widget: improve ViewCertificate to use widgets in stead of ftl
[ https://issues.apache.org/jira/browse/OFBIZ-6302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-6302: -- Assignee: Jacques Le Roux (was: Pierre Smits) > Ftl to Widget: improve ViewCertificate to use widgets in stead of ftl > - > > Key: OFBIZ-6302 > URL: https://issues.apache.org/jira/browse/OFBIZ-6302 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Jacques Le Roux > Labels: security > Attachments: OFBIZ-6302-Certificate.patch > > > Currently the screen ViewCertificate uses a widget to render the form(s). > This can be replaced by widgets -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7807) Enforce noninstantiability to UtilValidate class
[
https://issues.apache.org/jira/browse/OFBIZ-7807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rishi Solanki updated OFBIZ-7807:
-
Description:
- Make class as final.
- Add a private constructor.
- Make following public variable as private;
{code}
/** boolean specifying by default whether or not it is okay for a String to
be empty */
public static final boolean defaultEmptyOK = true;
/** digit characters */
public static final String digits = "0123456789";
/** hex digit characters */
public static final String hexDigits = digits + "abcdefABCDEF";
/** lower-case letter characters */
public static final String lowercaseLetters = "abcdefghijklmnopqrstuvwxyz";
/** upper-case letter characters */
public static final String uppercaseLetters = "ABCDEFGHIJKLMNOPQRSTUVWXYZ";
/** letter characters */
public static final String letters = lowercaseLetters + uppercaseLetters;
/** whitespace characters */
public static final String whitespace = " \t\n\r";
/** decimal point character differs by language and culture */
public static final String decimalPointDelimiter = ".";
/** non-digit characters which are allowed in phone numbers */
public static final String phoneNumberDelimiters = "()- ";
/** characters which are allowed in US phone numbers */
public static final String validUSPhoneChars = digits +
phoneNumberDelimiters;
/** characters which are allowed in international phone numbers(a leading +
is OK) */
public static final String validWorldPhoneChars = digits +
phoneNumberDelimiters + "+";
/** non-digit characters which are allowed in Social Security Numbers */
public static final String SSNDelimiters = "- ";
/** characters which are allowed in Social Security Numbers */
public static final String validSSNChars = digits + SSNDelimiters;
/** U.S. Social Security Numbers have 9 digits. They are formatted as
123-45-6789. */
public static final int digitsInSocialSecurityNumber = 9;
/** U.S. phone numbers have 10 digits. They are formatted as 123 456 7890
or(123) 456-7890. */
public static final int digitsInUSPhoneNumber = 10;
public static final int digitsInUSPhoneAreaCode = 3;
public static final int digitsInUSPhoneMainNumber = 7;
/** non-digit characters which are allowed in ZIP Codes */
public static final String ZipCodeDelimiters = "-";
/** our preferred delimiter for reformatting ZIP Codes */
public static final String ZipCodeDelimeter = "-";
/** characters which are allowed in Social Security Numbers */
public static final String validZipCodeChars = digits + ZipCodeDelimiters;
/** U.S. ZIP codes have 5 or 9 digits. They are formatted as 12345 or
12345-6789. */
public static final int digitsInZipCode1 = 5;
/** U.S. ZIP codes have 5 or 9 digits. They are formatted as 12345 or
12345-6789. */
public static final int digitsInZipCode2 = 9;
/** non-digit characters which are allowed in credit card numbers */
public static final String creditCardDelimiters = " -";
public static final String isNotEmptyMsg = "This field cannot be empty,
please enter a value.";
public static final String isStateCodeMsg = "The State Code must be a valid
two character U.S. state abbreviation(like CA for California).";
public static final String isContiguousStateCodeMsg = "The State Code must
be a valid two character U.S. state abbreviation for one of the 48 contiguous
United States (like CA for California).";
public static final String isZipCodeMsg = "The ZIP Code must be a 5 or 9
digit U.S. ZIP Code(like 94043).";
public static final String isUSPhoneMsg = "The US Phone must be a 10 digit
U.S. phone number(like 415-555-1212).";
public static final String isUSPhoneAreaCodeMsg = "The Phone Number Area
Code must be 3 digits.";
public static final String isUSPhoneMainNumberMsg = "The Phone Number must
be 7 digits.";
public static final String isContiguousZipCodeMsg = "Zip Code is not a
valid Zip Code for one of the 48 contiguous United States .";
public static final String isInternationalPhoneNumberMsg = "The World Phone
must be a valid international phone number.";
public static final String isSSNMsg = "The SSN must be a 9 digit U.S.
social security number(like 123-45-6789).";
public static final String isEmailMsg = "The Email must be a valid email
address(like j...@email.com). Please re-enter it now.";
public static final String isAnyCardMsg = "The credit card number is not a
valid card number.";
public static final String isCreditCardPrefixMsg = " is not a valid ";
public static final String isCreditCardSuffixMsg = " credit card number.";
public static final String isDayMsg = "The Day must be a day number between
1 and 31. ";
public static final String isMonthMsg = "The Month must be a month numbe
[jira] [Created] (OFBIZ-7820) Empty scroll bar in party component.
Akshay Modak created OFBIZ-7820: --- Summary: Empty scroll bar in party component. Key: OFBIZ-7820 URL: https://issues.apache.org/jira/browse/OFBIZ-7820 Project: OFBiz Issue Type: Improvement Components: party Reporter: Akshay Modak Assignee: Akshay Modak Priority: Minor Steps to regenerate: 1) Login to party component. 2) Switch to parties tab. 3) Under search button, an empty scroll bar can be seen. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7811) Enforce noninstantiability to FreeMarkerWorker class
[
https://issues.apache.org/jira/browse/OFBIZ-7811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amit Gadaley reassigned OFBIZ-7811:
---
Assignee: Amit Gadaley
> Enforce noninstantiability to FreeMarkerWorker class
>
>
> Key: OFBIZ-7811
> URL: https://issues.apache.org/jira/browse/OFBIZ-7811
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Amit Gadaley
>Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> - Make following protected method as public
> {code}
> protected static void loadTransforms(
> {code}
> No variables needs to be change for this class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7612) Party content in party component is not getting updated
[ https://issues.apache.org/jira/browse/OFBIZ-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Lodhi updated OFBIZ-7612: -- Assignee: Ravi Lodhi (was: Deepak Baghel) > Party content in party component is not getting updated > --- > > Key: OFBIZ-7612 > URL: https://issues.apache.org/jira/browse/OFBIZ-7612 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk >Reporter: Deepak Baghel >Assignee: Ravi Lodhi > > Step to regenerate > 1. Login into party component. > 2. Search parties from find party section and select any one of the parties. > 3. Then go to the party content section and create party content for this > particular selected party. > 4. Created party content will appear in the party content list section. > 5. Try to edit/update this party content. > 6. Party content is not getting updated. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-7749) iterateOverActiveComponents exists twice
[ https://issues.apache.org/jira/browse/OFBIZ-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380511#comment-15380511 ] Jacques Le Roux edited comment on OFBIZ-7749 at 7/16/16 5:31 AM: - Thanks Michael, Your patch is in trunk at revision: 1752890 All tests pass. For the sake of history and especially the link Michael provided, Michael asked me yesterday on HipChat: bq. have you tried this: https://docs.gradle.org/current/userguide/userguide_single.html#sec%3aconfiguring_using_external_scr... in reference to OFBIZ-7749 I replied bq. No I did not try that. Is it new with 2.14 (we use 2.13 because 2.14 is not released yet, right?) bq. Found this https://discuss.gradle.org/t/how-do-i-include-buildscript-block-from-external-gradle-script/7016/7 I checked this morning, thanks to the Gradle wrapper we use 2.14 which was released on 14th June 2016: https://gradle.org/gradle-download/ The Gradle wrapper is a bliss :) was (Author: jacques.le.roux): Thanks Michael, Your patch is in trunk at revision: 1752890 All tests pass. For the sake of history and especially the link Michael provided, Michael asked me yesterday on HipChat: bq. have you tried this: https://docs.gradle.org/current/userguide/userguide_single.html#sec%3aconfiguring_using_external_scr... in reference to OFBIZ-7749 bq. No I did not try that. Is it new with 2.14 (we use 2.13 because 2.14 is not released yet, right?) bq. Found this https://discuss.gradle.org/t/how-do-i-include-buildscript-block-from-external-gradle-script/7016/7 I checked this morning, thanks to the Gradle wrapper we use 2.14 which was released on 14th June 2016: https://gradle.org/gradle-download/ The Gradle wrapper is a bliss :) > iterateOverActiveComponents exists twice > > > Key: OFBIZ-7749 > URL: https://issues.apache.org/jira/browse/OFBIZ-7749 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Minor > Labels: gradle > Fix For: Upcoming Branch > > Attachments: OFBIZ-7749.patch > > > Currently the iterateOverActiveComponents function or tasks exists both in > build.gradle and settings.gradle. > Do we need both? Which one is superfluous? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7749) iterateOverActiveComponents exists twice
[ https://issues.apache.org/jira/browse/OFBIZ-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-7749. -- Resolution: Implemented Fix Version/s: Upcoming Branch Thanks Michael, Your patch is in trunk at revision: 1752890 All tests pass. For the sake of history and especially the link Michael provided, Michael asked me yesterday on HipChat: bq. have you tried this: https://docs.gradle.org/current/userguide/userguide_single.html#sec%3aconfiguring_using_external_scr... in reference to OFBIZ-7749 bq. No I did not try that. Is it new with 2.14 (we use 2.13 because 2.14 is not released yet, right?) bq. Found this https://discuss.gradle.org/t/how-do-i-include-buildscript-block-from-external-gradle-script/7016/7 I checked this morning, thanks to the Gradle wrapper we use 2.14 which was released on 14th June 2016: https://gradle.org/gradle-download/ The Gradle wrapper is a bliss :) > iterateOverActiveComponents exists twice > > > Key: OFBIZ-7749 > URL: https://issues.apache.org/jira/browse/OFBIZ-7749 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Minor > Labels: gradle > Fix For: Upcoming Branch > > Attachments: OFBIZ-7749.patch > > > Currently the iterateOverActiveComponents function or tasks exists both in > build.gradle and settings.gradle. > Do we need both? Which one is superfluous? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7809) Enforce noninstantiability to UtilXml class
[ https://issues.apache.org/jira/browse/OFBIZ-7809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar reassigned OFBIZ-7809: -- Assignee: Chinmay Patidar > Enforce noninstantiability to UtilXml class > --- > > Key: OFBIZ-7809 > URL: https://issues.apache.org/jira/browse/OFBIZ-7809 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Arun Patidar >Assignee: Chinmay Patidar >Priority: Minor > > - Make class as final. > - Add a private constructor. > No variables need to change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7819) Empty link icon shown in Search results of Find Subscription screen.
Akshay Modak created OFBIZ-7819: --- Summary: Empty link icon shown in Search results of Find Subscription screen. Key: OFBIZ-7819 URL: https://issues.apache.org/jira/browse/OFBIZ-7819 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Reporter: Akshay Modak Assignee: Akshay Modak Priority: Minor Steps to regenerate: 1. Login to Catalog component. 2. Switch to subscription tab. 3. Press find button, search results list will show up. In this search result list empty link buttons are visible orderId, partyId and productId columns. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7803) Enforce noninstantiability to UtilMisc class
[
https://issues.apache.org/jira/browse/OFBIZ-7803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-7803:
-
Attachment: OFBIZ-7803.patch
Added the patch to fix this issue. Thanks, Rishi Solanki for the detailed
description.
> Enforce noninstantiability to UtilMisc class
>
>
> Key: OFBIZ-7803
> URL: https://issues.apache.org/jira/browse/OFBIZ-7803
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rohit Koushal
>Priority: Minor
> Attachments: OFBIZ-7803.patch
>
>
> - Make class as final.
> - Private constructor already exists, by making it final we just matching the
> patterns from other utility classes.
> - Make following public static final variables as private;
> {code}
> public static final BigDecimal ZERO_BD = BigDecimal.ZERO;
> {code}
> - Nothing needs to be change for the private static class as it follows all
> patterns;
> {code}
> // Private lazy-initializer class
> private static class LocaleHolder
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7803) Enforce noninstantiability to UtilMisc class
[
https://issues.apache.org/jira/browse/OFBIZ-7803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal reassigned OFBIZ-7803:
Assignee: Rohit Koushal
> Enforce noninstantiability to UtilMisc class
>
>
> Key: OFBIZ-7803
> URL: https://issues.apache.org/jira/browse/OFBIZ-7803
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rohit Koushal
>Priority: Minor
>
> - Make class as final.
> - Private constructor already exists, by making it final we just matching the
> patterns from other utility classes.
> - Make following public static final variables as private;
> {code}
> public static final BigDecimal ZERO_BD = BigDecimal.ZERO;
> {code}
> - Nothing needs to be change for the private static class as it follows all
> patterns;
> {code}
> // Private lazy-initializer class
> private static class LocaleHolder
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7799) Enforce noninstantiability to CatalogWorker class
[ https://issues.apache.org/jira/browse/OFBIZ-7799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-7799: - Attachment: OFBIZ-7799.patch Thanks for the details [~rishisolankii]. Here is the patch for the issue. > Enforce noninstantiability to CatalogWorker class > - > > Key: OFBIZ-7799 > URL: https://issues.apache.org/jira/browse/OFBIZ-7799 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Rohit Koushal >Priority: Minor > Attachments: OFBIZ-7799.patch > > > - Make class as final. > - Private constructor already exists, by making it final we just matching the > patterns from other utility classes. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7800) Enforce noninstantiability to CategoryWorker class
[ https://issues.apache.org/jira/browse/OFBIZ-7800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380500#comment-15380500 ] Rahul Singh commented on OFBIZ-7800: Added the patch to fix this issue. Thanks, [~rishisolankii] for the detailed description. > Enforce noninstantiability to CategoryWorker class > --- > > Key: OFBIZ-7800 > URL: https://issues.apache.org/jira/browse/OFBIZ-7800 > Project: OFBiz > Issue Type: Sub-task > Components: product >Reporter: Rishi Solanki >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-7800.patch > > > - Make class as final. > - Private constructor already exists, by making it final we just matching the > patterns from other utility classes. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7800) Enforce noninstantiability to CategoryWorker class
[ https://issues.apache.org/jira/browse/OFBIZ-7800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rahul Singh updated OFBIZ-7800: --- Attachment: OFBIZ-7800.patch > Enforce noninstantiability to CategoryWorker class > --- > > Key: OFBIZ-7800 > URL: https://issues.apache.org/jira/browse/OFBIZ-7800 > Project: OFBiz > Issue Type: Sub-task > Components: product >Reporter: Rishi Solanki >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-7800.patch > > > - Make class as final. > - Private constructor already exists, by making it final we just matching the > patterns from other utility classes. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7818) Make Create Menu tab bar for workeffort consistent
[ https://issues.apache.org/jira/browse/OFBIZ-7818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Avnindra Sharma reassigned OFBIZ-7818: -- Assignee: Avnindra Sharma > Make Create Menu tab bar for workeffort consistent > -- > > Key: OFBIZ-7818 > URL: https://issues.apache.org/jira/browse/OFBIZ-7818 > Project: OFBiz > Issue Type: Sub-task > Components: workeffort >Reporter: Avnindra Sharma >Assignee: Avnindra Sharma >Priority: Minor > Fix For: Trunk > > > Add a create workeffort tab bar in the main decorator to maintain the > consistency throughout the tab bar of workeffort. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7818) Make Create Menu tab bar for workeffort consistent
Avnindra Sharma created OFBIZ-7818: -- Summary: Make Create Menu tab bar for workeffort consistent Key: OFBIZ-7818 URL: https://issues.apache.org/jira/browse/OFBIZ-7818 Project: OFBiz Issue Type: Sub-task Components: workeffort Reporter: Avnindra Sharma Priority: Minor Fix For: Trunk Add a create workeffort tab bar in the main decorator to maintain the consistency throughout the tab bar of workeffort. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-4956) "auth" should be true for all the request url used for Application components.
[ https://issues.apache.org/jira/browse/OFBIZ-4956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380496#comment-15380496 ] Jacques Le Roux commented on OFBIZ-4956: Last note, apart SOAPService and xmlrpc requests which need http (not https) you no longer need to worry about https="true" anywhere since OFBIZ-6849. > "auth" should be true for all the request url used for Application components. > -- > > Key: OFBIZ-4956 > URL: https://issues.apache.org/jira/browse/OFBIZ-4956 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Release Branch 11.04, Release Branch 12.04, Release > Branch 13.07, Trunk >Reporter: Amardeep Singh Jhajj >Assignee: Amardeep Singh Jhajj > Attachments: OFBIZ-4956-Release-10.04.patch, > OFBIZ-4956-Release-11.04.patch, OFBIZ-4956.patch > > > Currently there are some url present in application components with > auth="false". So anyone can hit this urls and can access any resources > without authorization. > For Example - > https://demo-trunk.ofbiz.apache.org:8443/content/control/ViewSimpleContent?dataResourceId=GZ-DIG > Currently, the above url does not need authorization (you can access any > resource by changing the dataResourceId). I think all the url should be > secure with auth="true" and https="true" in all the application components. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7817) Party manager home screen generates console error
Swapnil M Mane created OFBIZ-7817:
-
Summary: Party manager home screen generates console error
Key: OFBIZ-7817
URL: https://issues.apache.org/jira/browse/OFBIZ-7817
Project: OFBiz
Issue Type: Bug
Components: party
Affects Versions: Trunk
Reporter: Swapnil M Mane
Assignee: Swapnil M Mane
When we navigate to the 'Party' Manager component, following error is generated
{code}
2016-07-16 10:34:48,273 |ttp-nio-8443-exec-10 |GenericDelegator
|E| Error getting entity definition from model
org.ofbiz.entity.GenericModelException: Could not find definition for entity
name PartyClassificationGroupAndType
at
org.ofbiz.entity.model.ModelReader.getModelEntity(ModelReader.java:489)
~[trunk.jar:?]
at
org.ofbiz.entity.GenericDelegator.getModelEntity(GenericDelegator.java:407)
[trunk.jar:?]
at
org.ofbiz.widget.model.ModelFormField$EntityOptions.addOptionValues(ModelFormField.java:1904)
[trunk.jar:?]
at
org.ofbiz.widget.model.ModelFormField$FieldInfoWithOptions.getAllOptionValues(ModelFormField.java:2065)
[trunk.jar:?]
at
org.ofbiz.widget.renderer.macro.MacroFormRenderer.renderDropDownField(MacroFormRenderer.java:756)
[trunk.jar:?]
at
org.ofbiz.widget.model.ModelFormField$DropDownField.renderFieldString(ModelFormField.java:1811)
[trunk.jar:?]
at
org.ofbiz.widget.model.ModelFormField.renderFieldString(ModelFormField.java:722)
[trunk.jar:?]
at
org.ofbiz.widget.renderer.FormRenderer.renderSingleFormString(FormRenderer.java:1199)
[trunk.jar:?]
at org.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:264)
[trunk.jar:?]
at
org.ofbiz.widget.model.ModelScreenWidget$Form.renderWidgetString(ModelScreenWidget.java:1053)
[trunk.jar:?]
at
org.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:682)
[trunk.jar:?]
at
org.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:599)
[trunk.jar:?]
at
org.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
[trunk.jar:?]
at
org.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
[trunk.jar:?]
at
org.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
[trunk.jar:?]
at
org.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:906)
[trunk.jar:?]
at
org.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:127)
[trunk.jar:?]
at
org.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:943)
[trunk.jar:?]
at
org.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
[trunk.jar:?]
at
org.ofbiz.widget.model.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:459)
[trunk.jar:?]
at
org.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
[trunk.jar:?]
at
org.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
[trunk.jar:?]
at
org.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
[trunk.jar:?]
at
org.ofbiz.widget.model.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:459)
[trunk.jar:?]
at
org.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
[trunk.jar:?]
at
org.ofbiz.widget.model.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:459)
[trunk.jar:?]
at
org.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
[trunk.jar:?]
at
org.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
[trunk.jar:?]
at
org.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164)
[trunk.jar:?]
at
org.ofbiz.widget.model.ScreenFactory.renderReferencedScreen(ScreenFactory.java:214)
[trunk.jar:?]
at
org.ofbiz.widget.model.ModelScreenWidget$IncludeScreen.renderWidgetString(ModelScreenWidget.java:780)
[trunk.jar:?]
at
org.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
[trunk.jar:?]
at
org.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
[trunk.jar:?]
at
org.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164)
[trunk.jar:?]
at
org.ofbiz.widget.model.ScreenFactory.renderReferencedScreen(ScreenFactory.java:214)
[trunk.jar:?]
at
org.ofbiz.widget.model.ModelScreenWidget$IncludeScreen.renderWidg
[jira] [Assigned] (OFBIZ-7802) Enforce noninstantiability to ProductWorker class
[
https://issues.apache.org/jira/browse/OFBIZ-7802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chinmay Patidar reassigned OFBIZ-7802:
--
Assignee: Chinmay Patidar
> Enforce noninstantiability to ProductWorker class
> -
>
> Key: OFBIZ-7802
> URL: https://issues.apache.org/jira/browse/OFBIZ-7802
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Chinmay Patidar
>Priority: Minor
>
> - Make class as final.
> - Private constructor already exists, by making it final we just matching the
> patterns from other utility classes.
> - Make following public static final variables as private;
> {code}
> public static final String resource = "ProductUiLabels";
> public static final MathContext generalRounding = new MathContext(10);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7799) Enforce noninstantiability to CatalogWorker class
[ https://issues.apache.org/jira/browse/OFBIZ-7799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal reassigned OFBIZ-7799: Assignee: Rohit Koushal > Enforce noninstantiability to CatalogWorker class > - > > Key: OFBIZ-7799 > URL: https://issues.apache.org/jira/browse/OFBIZ-7799 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Rohit Koushal >Priority: Minor > > - Make class as final. > - Private constructor already exists, by making it final we just matching the > patterns from other utility classes. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5027) Product Facility record should be created in case of its no record when calling setLastInventoryCount service as EECA.
[ https://issues.apache.org/jira/browse/OFBIZ-5027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380489#comment-15380489 ] Amardeep Singh Jhajj commented on OFBIZ-5027: - Thanks Ashish, I will have a look on it. > Product Facility record should be created in case of its no record when > calling setLastInventoryCount service as EECA. > -- > > Key: OFBIZ-5027 > URL: https://issues.apache.org/jira/browse/OFBIZ-5027 > Project: OFBiz > Issue Type: Improvement > Components: product >Reporter: Amardeep Singh Jhajj >Assignee: Amardeep Singh Jhajj >Priority: Minor > Attachments: OFBIZ-5027-Release-10.04.patch, > OFBIZ-5027-Release-11.04.patch, OFBIZ-5027-trunk.patch > > > Currently, ProductFacility record is updated by setLastInventoryCount service > when create-store-remove operation performed on InventoryItemDetail entity > (by EECA). > This service is called to update lastInventoryCount field in ProductFacility > and this field helps us for checking product in-stock/out-of-stock. > This service helps only when ProductFacility will already present. Suppose, > if catalog manager forgot to setup facility or deleted it at > https://demo-trunk.ofbiz.apache.org:8443/catalog/control/EditProductFacilities?productId=WG-9943-B3 > and just setup Inventory during product setup then setLastInventoryCount > service would not be helpful. > So in my opinion, here ProductFacility should be first created in case of its > no record when updating lastInventoryCount in ProductFacility. > I am attaching patch for the same here. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-4956) "auth" should be true for all the request url used for Application components.
[ https://issues.apache.org/jira/browse/OFBIZ-4956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380487#comment-15380487 ] Amardeep Singh Jhajj commented on OFBIZ-4956: - Thanks Ashish, I will have a look on it. > "auth" should be true for all the request url used for Application components. > -- > > Key: OFBIZ-4956 > URL: https://issues.apache.org/jira/browse/OFBIZ-4956 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Release Branch 11.04, Release Branch 12.04, Release > Branch 13.07, Trunk >Reporter: Amardeep Singh Jhajj >Assignee: Amardeep Singh Jhajj > Attachments: OFBIZ-4956-Release-10.04.patch, > OFBIZ-4956-Release-11.04.patch, OFBIZ-4956.patch > > > Currently there are some url present in application components with > auth="false". So anyone can hit this urls and can access any resources > without authorization. > For Example - > https://demo-trunk.ofbiz.apache.org:8443/content/control/ViewSimpleContent?dataResourceId=GZ-DIG > Currently, the above url does not need authorization (you can access any > resource by changing the dataResourceId). I think all the url should be > secure with auth="true" and https="true" in all the application components. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7816) Profile of contact person not shown on quick add of contact in SFA
[ https://issues.apache.org/jira/browse/OFBIZ-7816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditi Patidar updated OFBIZ-7816: - Description: Steps to regenerate issue: 1. Navigate to SFA. 2. Enter 'First Name', 'Last Name' in 'Quick Add Contact' section and press 'Submit' button. Refer the attached screenshot to view the issue. was: Steps to regenerate issue: 1. Navigate to SFA. 2. Enter 'First Name', 'Last Name' and press 'Submit' button. Refer the attached screenshot to view the issue. > Profile of contact person not shown on quick add of contact in SFA > -- > > Key: OFBIZ-7816 > URL: https://issues.apache.org/jira/browse/OFBIZ-7816 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12 >Reporter: Aditi Patidar >Assignee: Aditi Patidar > Labels: sfa > Attachments: quick add contact.png > > > Steps to regenerate issue: > 1. Navigate to SFA. > 2. Enter 'First Name', 'Last Name' in 'Quick Add Contact' section and press > 'Submit' button. > Refer the attached screenshot to view the issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7816) Profile of contact person not shown on quick add of contact in SFA
[ https://issues.apache.org/jira/browse/OFBIZ-7816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditi Patidar updated OFBIZ-7816: - Description: Steps to regenerate issue: 1. Navigate to SFA. 2. Enter 'First Name', 'Last Name' and press 'Submit' button. Refer the attached screenshot to view the issue. was: Steps to regenerate issue: 1. Navigate to SFA. 2. Enter 'First Name', 'Last Name' and press 'Submit' button. > Profile of contact person not shown on quick add of contact in SFA > -- > > Key: OFBIZ-7816 > URL: https://issues.apache.org/jira/browse/OFBIZ-7816 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12 >Reporter: Aditi Patidar >Assignee: Aditi Patidar > Labels: sfa > Attachments: quick add contact.png > > > Steps to regenerate issue: > 1. Navigate to SFA. > 2. Enter 'First Name', 'Last Name' and press 'Submit' button. > Refer the attached screenshot to view the issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7816) Profile of contact person not shown on quick add of contact in SFA
[ https://issues.apache.org/jira/browse/OFBIZ-7816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditi Patidar updated OFBIZ-7816: - Attachment: quick add contact.png > Profile of contact person not shown on quick add of contact in SFA > -- > > Key: OFBIZ-7816 > URL: https://issues.apache.org/jira/browse/OFBIZ-7816 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12 >Reporter: Aditi Patidar >Assignee: Aditi Patidar > Labels: sfa > Attachments: quick add contact.png > > > Steps to regenerate issue: > 1. Navigate to SFA. > 2. Enter 'First Name', 'Last Name' and press 'Submit' button. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7402) Catalog : Showing error when duplicating product
[
https://issues.apache.org/jira/browse/OFBIZ-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arvind Singh Tomar reassigned OFBIZ-7402:
-
Assignee: Arvind Singh Tomar
> Catalog : Showing error when duplicating product
>
>
> Key: OFBIZ-7402
> URL: https://issues.apache.org/jira/browse/OFBIZ-7402
> Project: OFBiz
> Issue Type: Bug
> Components: product
>Affects Versions: Trunk
>Reporter: Padmavati Rawat
>Assignee: Arvind Singh Tomar
> Fix For: Trunk
>
> Attachments: Error in Duplicate Product.png
>
>
> Steps:
> 1. Navigate on Catalog, and Create New Product.
> 2. Fill all required details and click on update product.
> 3. Duplicate Product section will open with updated product.
> 4. Click on Duplicate button.
> Actual : Not able to duplicate product in Catalog. It generates a non user
> friendly error message.
> Expected : Error message should be user friendly, and should be fixed if
> there is any issue.
> {code}
> Error message :
> The Following Errors Occurred:
> Exception thrown while creating the "newProduct" GenericValue:
> org.ofbiz.entity.GenericEntityException: Error while inserting:
> [GenericEntity:Product][amountUomTypeId,null()][autoCreateKeywords,null()][billOfMaterialLevel,0(java.lang.Long)][brandName,null()][chargeShipping,null()][comments,null()][configId,null()][createdByUserLogin,admin(java.lang.String)][createdDate,2016-06-18
> 16:44:17.857(java.sql.Timestamp)][createdStamp,2016-06-18
> 16:48:03.861(java.sql.Timestamp)][createdTxStamp,2016-06-18
> 16:48:03.718(java.sql.Timestamp)][defaultShipmentBoxTypeId,null()][depthUomId,null()][description,null()][detailImageUrl,null()][detailScreen,null()][diameterUomId,null()][facilityId,null()][fixedAmount,null()][heightUomId,null()][inShippingBox,N(java.lang.String)][includeInPromotions,null()][internalName,New
>
> Product(java.lang.String)][introductionDate,null()][inventoryItemTypeId,NON_SERIAL_INV_ITEM(java.lang.String)][inventoryMessage,null()][isVariant,N(java.lang.String)][isVirtual,N(java.lang.String)][largeImageUrl,null()][lastModifiedByUserLogin,admin(java.lang.String)][lastModifiedDate,2016-06-18
> 16:44:17.857(java.sql.Timestamp)][lastUpdatedStamp,2016-06-18
> 16:48:03.861(java.sql.Timestamp)][lastUpdatedTxStamp,2016-06-18
> 16:48:03.718(java.sql.Timestamp)][longDescription,null()][lotIdFilledIn,Allowed(java.lang.String)][manufacturerPartyId,null()][mediumImageUrl,null()][orderDecimalQuantity,null()][originGeoId,null()][originalImageUrl,null()][piecesIncluded,null()][priceDetailText,null()][primaryProductCategoryId,null()][productDepth,null()][productDiameter,null()][productHeight,null()][productId,10005(java.lang.String)][productName,null()][productRating,null()][productTypeId,FINISHED_GOOD(java.lang.String)][productWeight,null()][productWidth,null()][quantityIncluded,null()][quantityUomId,null()][ratingTypeEnum,null()][releaseDate,null()][requireAmount,null()][requireInventory,null()][requirementMethodEnumId,null()][reserv2ndPPPerc,null()][reservMaxPersons,null()][reservNthPPPerc,null()][returnable,null()][salesDiscWhenNotAvail,null()][salesDiscontinuationDate,null()][shippingDepth,null()][shippingHeight,null()][shippingWeight,null()][shippingWidth,null()][smallImageUrl,null()][supportDiscontinuationDate,null()][taxable,null()][virtualVariantMethodEnum,null()][weightUomId,null()][widthUomId,null()]
> (SQL Exception while executing the following:INSERT INTO OFBIZ.PRODUCT
> (PRODUCT_ID, PRODUCT_TYPE_ID, PRIMARY_PRODUCT_CATEGORY_ID,
> MANUFACTURER_PARTY_ID, FACILITY_ID, INTRODUCTION_DATE, RELEASE_DATE,
> SUPPORT_DISCONTINUATION_DATE, SALES_DISCONTINUATION_DATE,
> SALES_DISC_WHEN_NOT_AVAIL, INTERNAL_NAME, BRAND_NAME, COMMENTS, PRODUCT_NAME,
> DESCRIPTION, LONG_DESCRIPTION, PRICE_DETAIL_TEXT,
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (OFBIZ-7816) Profile of contact person not shown on quick add of contact in SFA
Aditi Patidar created OFBIZ-7816: Summary: Profile of contact person not shown on quick add of contact in SFA Key: OFBIZ-7816 URL: https://issues.apache.org/jira/browse/OFBIZ-7816 Project: OFBiz Issue Type: Bug Affects Versions: Release Branch 15.12, Trunk, Release Branch 14.12 Reporter: Aditi Patidar Assignee: Aditi Patidar Steps to regenerate issue: 1. Navigate to SFA. 2. Enter 'First Name', 'Last Name' and press 'Submit' button. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7749) iterateOverActiveComponents exists twice
[ https://issues.apache.org/jira/browse/OFBIZ-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380473#comment-15380473 ] Taher Alkhateeb commented on OFBIZ-7749: Fantastic Michael. if all tests pass then please go ahead and commit this. I suggest in line with the old names we used you can call it common.gradle instead. > iterateOverActiveComponents exists twice > > > Key: OFBIZ-7749 > URL: https://issues.apache.org/jira/browse/OFBIZ-7749 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Minor > Labels: gradle > Attachments: OFBIZ-7749.patch > > > Currently the iterateOverActiveComponents function or tasks exists both in > build.gradle and settings.gradle. > Do we need both? Which one is superfluous? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7749) iterateOverActiveComponents exists twice
[ https://issues.apache.org/jira/browse/OFBIZ-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-7749: - Priority: Minor (was: Major) > iterateOverActiveComponents exists twice > > > Key: OFBIZ-7749 > URL: https://issues.apache.org/jira/browse/OFBIZ-7749 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Minor > Labels: gradle > Attachments: OFBIZ-7749.patch > > > Currently the iterateOverActiveComponents function or tasks exists both in > build.gradle and settings.gradle. > Do we need both? Which one is superfluous? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7749) iterateOverActiveComponents exists twice
[ https://issues.apache.org/jira/browse/OFBIZ-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-7749: - Attachment: OFBIZ-7749.patch This patch introduces a new gradle file which holds the shared method iterateOverActiveComponents which is used by build.gradle and settings.gradle. Thanks Pierre for the trigger to learn some Gradle stuff :-) > iterateOverActiveComponents exists twice > > > Key: OFBIZ-7749 > URL: https://issues.apache.org/jira/browse/OFBIZ-7749 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Jacques Le Roux > Labels: gradle > Attachments: OFBIZ-7749.patch > > > Currently the iterateOverActiveComponents function or tasks exists both in > build.gradle and settings.gradle. > Do we need both? Which one is superfluous? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-5840) Create bootstrap theme
[ https://issues.apache.org/jira/browse/OFBIZ-5840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-5840: -- Assignee: (was: Jacques Le Roux) > Create bootstrap theme > -- > > Key: OFBIZ-5840 > URL: https://issues.apache.org/jira/browse/OFBIZ-5840 > Project: OFBiz > Issue Type: New Feature > Components: framework, themes >Affects Versions: Bootstrap theme >Reporter: Julien NICOLAS > Labels: bootstrap, theme > Attachments: Facility.PNG, FindAgreement..png, Footer.jpg, > GlobalDecorator.patch, ImprovedFooter.patch, MacroMenuRenderer.patch, > OFBIZ-5840-Menufactory.patch, OFBIZ-5840-Menufactory.patch, > appbar_menu_ftl.patch, bootified.js, bootified_js_screentrans.patch, > bootstrap-theme.zip, bootstrap.zip, bootstrapThemeToTrunk.patch, > calendar.PNG, catalog.png, glyphicons-halflings-regular.zip, > htmlMenuMacroLibrary.patch, lookupField_patch.patch, > pagination_htmlFormMacroLibrary.patch, > panelCollapse_htmlSreenMacroLibrary.patch, party menu tab bar.PNG, > preferences.png, styling_issue_1.png, styling_issue_2.png, > styling_issue_3.png, styling_issue_4.png, styling_issue_5.png, > styling_issue_6.png, styling_issue_7.png, styling_issue_8.png, > styling_issue_9.png, tab-bar.png, workeffort.PNG > > > 1- create a sub-directory called bootstrap under the image webapp to put > the resources over there (js, css and fonts) as indicated earlier by Gavin. > (Julien : not sure about location) > 2- check to make sure that the current version of jQuery is compatible with > the installed version or upgrade it accordingly > 3- Create a new theme based on one of the existing themes as suggested by > Julien and Gavin > 4- Test the theme by switching to it and handle major bugs / issues. > 5- Start to make a few test screens utilizing Bootstrap -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5840) Create bootstrap theme
[ https://issues.apache.org/jira/browse/OFBIZ-5840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380025#comment-15380025 ] Taher Alkhateeb commented on OFBIZ-5840: Great stuff Paul. Thank you for sharing and best of luck with this work. I hope you'd have time to help us out if we go that route. > Create bootstrap theme > -- > > Key: OFBIZ-5840 > URL: https://issues.apache.org/jira/browse/OFBIZ-5840 > Project: OFBiz > Issue Type: New Feature > Components: framework, themes >Affects Versions: Bootstrap theme >Reporter: Julien NICOLAS >Assignee: Jacques Le Roux > Labels: bootstrap, theme > Attachments: Facility.PNG, FindAgreement..png, Footer.jpg, > GlobalDecorator.patch, ImprovedFooter.patch, MacroMenuRenderer.patch, > OFBIZ-5840-Menufactory.patch, OFBIZ-5840-Menufactory.patch, > appbar_menu_ftl.patch, bootified.js, bootified_js_screentrans.patch, > bootstrap-theme.zip, bootstrap.zip, bootstrapThemeToTrunk.patch, > calendar.PNG, catalog.png, glyphicons-halflings-regular.zip, > htmlMenuMacroLibrary.patch, lookupField_patch.patch, > pagination_htmlFormMacroLibrary.patch, > panelCollapse_htmlSreenMacroLibrary.patch, party menu tab bar.PNG, > preferences.png, styling_issue_1.png, styling_issue_2.png, > styling_issue_3.png, styling_issue_4.png, styling_issue_5.png, > styling_issue_6.png, styling_issue_7.png, styling_issue_8.png, > styling_issue_9.png, tab-bar.png, workeffort.PNG > > > 1- create a sub-directory called bootstrap under the image webapp to put > the resources over there (js, css and fonts) as indicated earlier by Gavin. > (Julien : not sure about location) > 2- check to make sure that the current version of jQuery is compatible with > the installed version or upgrade it accordingly > 3- Create a new theme based on one of the existing themes as suggested by > Julien and Gavin > 4- Test the theme by switching to it and handle major bugs / issues. > 5- Start to make a few test screens utilizing Bootstrap -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7749) iterateOverActiveComponents exists twice
[ https://issues.apache.org/jira/browse/OFBIZ-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379998#comment-15379998 ] Jacques Le Roux commented on OFBIZ-7749: Hi Pierre, if you agree please close. Of course, if you prefer to take some time to do some researches please take this time. > iterateOverActiveComponents exists twice > > > Key: OFBIZ-7749 > URL: https://issues.apache.org/jira/browse/OFBIZ-7749 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Jacques Le Roux > Labels: gradle > > Currently the iterateOverActiveComponents function or tasks exists both in > build.gradle and settings.gradle. > Do we need both? Which one is superfluous? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7783) External library files are not in the OFBiz folder structure.
[ https://issues.apache.org/jira/browse/OFBIZ-7783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379992#comment-15379992 ] Jacques Le Roux commented on OFBIZ-7783: Ivy like Ant are more manually programmed, Gradle like Maven are much more automated. They apply the convention above configuration pinciple https://en.wikipedia.org/wiki/Convention_over_configuration) > External library files are not in the OFBiz folder structure. > - > > Key: OFBIZ-7783 > URL: https://issues.apache.org/jira/browse/OFBIZ-7783 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Reporter: Pierre Smits >Assignee: Jacques Le Roux > > With the implementation of the external library download feature of > gradle/gradlew, the external libraries (jar files) are not in the folder > structure any more. > They should reside there, like before. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7677) Update documentation with respect to implementation of gradle as a replacement of ant
[ https://issues.apache.org/jira/browse/OFBIZ-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379988#comment-15379988 ] Jacques Le Roux commented on OFBIZ-7677: OK, I will close here where aforementioned tasks will be one > Update documentation with respect to implementation of gradle as a > replacement of ant > - > > Key: OFBIZ-7677 > URL: https://issues.apache.org/jira/browse/OFBIZ-7677 > Project: OFBiz > Issue Type: Sub-task > Components: site >Reporter: Pierre Smits > > Documentation must be updated before any release, that will have the > replacement of ant in place, can be cut. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7771) Allow to define which data the loadDefault Gradle task effectively loads
[ https://issues.apache.org/jira/browse/OFBIZ-7771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379983#comment-15379983 ] Jacques Le Roux commented on OFBIZ-7771: I'll hopefully address it with OFBIZ-7780 ...WIP... > Allow to define which data the loadDefault Gradle task effectively loads > > > Key: OFBIZ-7771 > URL: https://issues.apache.org/jira/browse/OFBIZ-7771 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Trivial > > The gradle task loadDefault is ambiguous, as it means different things to > different uses. This could lead to a situations where it is used in a wrong > manner, resulting in data being overwritten. > Having a more meaningful name lessens the risk of such situations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7783) External library files are not in the OFBiz folder structure.
[ https://issues.apache.org/jira/browse/OFBIZ-7783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379980#comment-15379980 ] Pierre Smits commented on OFBIZ-7783: - Thanks Jacques. I will have a look where I can find that and will see what it harbours. I don't know how Maven works. I do know how Ant IVY works. So I have a good reference point. > External library files are not in the OFBiz folder structure. > - > > Key: OFBIZ-7783 > URL: https://issues.apache.org/jira/browse/OFBIZ-7783 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Reporter: Pierre Smits >Assignee: Jacques Le Roux > > With the implementation of the external library download feature of > gradle/gradlew, the external libraries (jar files) are not in the folder > structure any more. > They should reside there, like before. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7749) iterateOverActiveComponents exists twice
[ https://issues.apache.org/jira/browse/OFBIZ-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379974#comment-15379974 ] Taher Alkhateeb commented on OFBIZ-7749: Hi Pierre, In reply to your comments: The two functions are exactly the same and that is why they have the same name. They do exactly the same thing, but we cannot write them only once (or maybe we there is a workaround in that I'm unaware of yet, feel free to help us). The reason why we cannot is that Gradle runs in three stages, Initialization, Configuration, and Execution. The initialization stage is different from the other stages and cannot reuse code. So build.gradle is not visible to settings.gradle and vice-versa because they are parsed in different time-lines. In most projects this does not happen, but because of the complexity and non-standard directory structure in OFBiz, we needed that same bit of code in both the initialization phase (to create the subprojects) and in the other phases for everything else. I hope this answers your inquiries. > iterateOverActiveComponents exists twice > > > Key: OFBIZ-7749 > URL: https://issues.apache.org/jira/browse/OFBIZ-7749 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Jacques Le Roux > Labels: gradle > > Currently the iterateOverActiveComponents function or tasks exists both in > build.gradle and settings.gradle. > Do we need both? Which one is superfluous? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7745) Have a gradle build file for the content component
[ https://issues.apache.org/jira/browse/OFBIZ-7745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379973#comment-15379973 ] Jacques Le Roux commented on OFBIZ-7745: OK thanks Pierre, so I'll close this issue and similar and will consult with the "OFBiz team" to propose a clear (simple) explanation about the plan with plugins (included short technical explanation) > Have a gradle build file for the content component > -- > > Key: OFBIZ-7745 > URL: https://issues.apache.org/jira/browse/OFBIZ-7745 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Pierre Smits > Labels: gradle > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7771) Allow to define which data the loadDefault Gradle task effectively loads
[ https://issues.apache.org/jira/browse/OFBIZ-7771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379966#comment-15379966 ] Pierre Smits commented on OFBIZ-7771: - Hi [~taher] I just closed it about 10 minutes before your posting. In my posting of 15 minutes ago, I said 'I am inclined to believe...', that means that more imput is required before such an endeavour should be undertaken. At this moment in time I am not saying that I will undertake it, and your remark feeds into that too. > Allow to define which data the loadDefault Gradle task effectively loads > > > Key: OFBIZ-7771 > URL: https://issues.apache.org/jira/browse/OFBIZ-7771 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Trivial > > The gradle task loadDefault is ambiguous, as it means different things to > different uses. This could lead to a situations where it is used in a wrong > manner, resulting in data being overwritten. > Having a more meaningful name lessens the risk of such situations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7771) Allow to define which data the loadDefault Gradle task effectively loads
[ https://issues.apache.org/jira/browse/OFBIZ-7771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379959#comment-15379959 ] Taher Alkhateeb commented on OFBIZ-7771: Hello, If all of this is due to the name of the task you know I would rather just rename the task. Let's just use loadData, loadDataSets, or even Pierre's original suggestions. I really would rather just close this JIRA and move on. Note if you actually remove the from entityconfig.xml then you would not be able to load that data as an argument at all. > Allow to define which data the loadDefault Gradle task effectively loads > > > Key: OFBIZ-7771 > URL: https://issues.apache.org/jira/browse/OFBIZ-7771 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Trivial > > The gradle task loadDefault is ambiguous, as it means different things to > different uses. This could lead to a situations where it is used in a wrong > manner, resulting in data being overwritten. > Having a more meaningful name lessens the risk of such situations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7771) Allow to define which data the loadDefault Gradle task effectively loads
[ https://issues.apache.org/jira/browse/OFBIZ-7771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits closed OFBIZ-7771. --- Resolution: Not A Problem As per discussion in the issue. > Allow to define which data the loadDefault Gradle task effectively loads > > > Key: OFBIZ-7771 > URL: https://issues.apache.org/jira/browse/OFBIZ-7771 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Trivial > > The gradle task loadDefault is ambiguous, as it means different things to > different uses. This could lead to a situations where it is used in a wrong > manner, resulting in data being overwritten. > Having a more meaningful name lessens the risk of such situations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7771) Allow to define which data the loadDefault Gradle task effectively loads
[ https://issues.apache.org/jira/browse/OFBIZ-7771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379944#comment-15379944 ] Pierre Smits commented on OFBIZ-7771: - Yes, we can. Thanks to the explanation provided by [~taher]. Though I am not certain whether the default reader definitions should reside in entityengine.xml. I am inclined to believe that it should be in a separate properties file, as the set is something generic and repeated in every datasource in entityengine.xml. But that is for later and - I believe - part of OFBIZ-6164. > Allow to define which data the loadDefault Gradle task effectively loads > > > Key: OFBIZ-7771 > URL: https://issues.apache.org/jira/browse/OFBIZ-7771 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Trivial > > The gradle task loadDefault is ambiguous, as it means different things to > different uses. This could lead to a situations where it is used in a wrong > manner, resulting in data being overwritten. > Having a more meaningful name lessens the risk of such situations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7749) iterateOverActiveComponents exists twice
[ https://issues.apache.org/jira/browse/OFBIZ-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379913#comment-15379913 ] Pierre Smits commented on OFBIZ-7749: - Yes I did - 5 days ago - and I couldn't find the difference. > iterateOverActiveComponents exists twice > > > Key: OFBIZ-7749 > URL: https://issues.apache.org/jira/browse/OFBIZ-7749 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Jacques Le Roux > Labels: gradle > > Currently the iterateOverActiveComponents function or tasks exists both in > build.gradle and settings.gradle. > Do we need both? Which one is superfluous? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7745) Have a gradle build file for the content component
[ https://issues.apache.org/jira/browse/OFBIZ-7745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379909#comment-15379909 ] Pierre Smits commented on OFBIZ-7745: - HI Jacques, I don't feel the need to revisit the sentiments as a result of the heated exchanges of the days of last week and earlier this week. I know the Apache way too, and no one - except the contributors with binding votes - really any power to decide the direction of the project or its product. And it is a done deal now. I just had hoped that more explanation was given before the work started and it seemed that that was already far under way when I created this issue. I do trust that with this 'OFBiz Team' we are not reverting back to period when there was spoken about Core Developers/FrameWork Developers and the rest were regarded as sub-par (my perception of the situation back then, and of some others) and excluded from this kind of processes... > Have a gradle build file for the content component > -- > > Key: OFBIZ-7745 > URL: https://issues.apache.org/jira/browse/OFBIZ-7745 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Pierre Smits > Labels: gradle > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7780) Improve readme.md file with respect to description of the loadDefault task
[ https://issues.apache.org/jira/browse/OFBIZ-7780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379901#comment-15379901 ] Jacques Le Roux commented on OFBIZ-7780: I was working on this but stopped because of OFBIZ-7771, still a WIP... > Improve readme.md file with respect to description of the loadDefault task > -- > > Key: OFBIZ-7780 > URL: https://issues.apache.org/jira/browse/OFBIZ-7780 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Jacques Le Roux > Labels: gradle > Attachments: OFBIZ-7780-README.md.patch > > > The supporting description in the readme.md file regarding the loadDefault > task can be better to avoid confusion. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7780) Improve readme.md file with respect to description of the loadDefault task
[ https://issues.apache.org/jira/browse/OFBIZ-7780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-7780: -- Assignee: Jacques Le Roux (was: Pierre Smits) > Improve readme.md file with respect to description of the loadDefault task > -- > > Key: OFBIZ-7780 > URL: https://issues.apache.org/jira/browse/OFBIZ-7780 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Jacques Le Roux > Labels: gradle > Attachments: OFBIZ-7780-README.md.patch > > > The supporting description in the readme.md file regarding the loadDefault > task can be better to avoid confusion. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Please stop all work on Java sources for a directory restructure
To be clear this is https://issues.apache.org/jira/browse/OFBIZ-6274 Jacques Le 15/07/2016 à 19:36, Jacques Le Roux a écrit : Hi Committers, Beware, on the meantime don't commit changes on package names as Taher is working on a solution for classpath issues he crossed We know this is a bit annoying when navigating in IDEs but it should not be too long and Taher is setting up a Git repo to share the burden Thanks Jacques Le 15/07/2016 à 16:19, Taher Alkhateeb a écrit : Hello Everyone, Thank you for your patience, our work is committed in r1752838. Java now has a new home of /src/main/java for each component :) Again thank you all for your support and thumbs up. Next step we will introduce the unit tests in /src/test/java in each component. Cheers ! Taher Alkhateeb On Fri, Jul 15, 2016 at 3:17 PM, Taher Alkhateeb wrote: Hi Everyone, In reference to https://issues.apache.org/jira/browse/OFBIZ-7790 May I suggest that you please postpone any work you have on Java source files. I have a patch ready and passes all tests which moves all java source files from /src to /src/main/java. I will commit it very soon I will send another email today once I've committed the work Thank you for your support. Taher Alkhateeb
