Re: Opinions on the "Community Days" and alike days by HotWax [Was Re: Wiki page for the "monthly Jira issues list" creation in the blog]

[Arun Patidar]

Hi Jacques,

Thanks for looking into this and help. I agree with your concern that it is
hard to review many subtickets. Also it would be more easy to apply/review
patch from one relevant ticket. For the same reason I started commiting
multiple patches from different ticket in one commit.

The reason behind the current approach with OFBIZ-7828 is that, on
community day multiple people can work on different part of a same ticket.
Devs working on subtickets are responsible for development, self review and
testing. Small chunks facilitate devs to follow this procedure for each
entity. So we can say, all services added till now completely tested from
webtools by devs.

So its easy to do distributed efforts on this long on going ticket by
sub-tickets. And for reviewing purpose I started committing multiple
tickets in single commit. I'll continue on picking multiple tickets and do
single commit.


-- 
Thanks & Regards
---
Arun Patidar
Manager,Enterprise Software Development
HotWax Mediawww.hotwaxsystems.com


On Sun, Oct 16, 2016 at 3:46 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> I have a proposition about tasks with many trivial subtasks like
> OFBIZ-8413, OFBIZ-7828 or OFBIZ-7334, etc.
>
> When I look at https://issues.apache.org/jira
> /secure/Dashboard.jspa?selectPageId=12310800 I see that we have some
> difficulties to cope with all these subtasks
>
> Yesterday, while reviewing one related commit by Arun with 20 subtasks
> embedded : http://svn.apache.org/viewvc?view=revision=1765077
>
> I wanted to help on OFBIZ-7828 but it's really a pain to
>
> 1. open so many subtasks
> 2. download the patches
> 3. apply them one by one
>
> When it's actually so easy to review the commit Arun did, so it would be
> the same before committing.
>
> So I suggest we don't create so many subtasks when they are trivial. We
> could rather create component, class or alike named patches and attach them
> to only 1 Jira.
>
> Then using a tool to download simultaneously a bunch of files from a page
> (I use http://www.downthemall.net/) and catenate them in one file it's
> very easy to achieve the same.
>
> Jacques
>
>
>
> Le 25/09/2016 à 09:42, Jacques Le Roux a écrit :
>
>> I have proposed a remedy with my answer in a new thread forked from the
>> flat grey vote one.
>>
>> BTW, what are you opinions on the "Community Days" and  alike days by
>> HotWax?
>>
>> I understand they happen on weekends when people have more spare time and
>> it's amazing to see people working together.
>> So I much appreciate the result of these days, but I find hard to follow
>> and review those bursts of activity.
>>
>> I have though nothing to remedy that, apart delaying reviews which is not
>> always a good solution.
>> Because it's sometimes too late when commits results are entangled and
>> then hard to ask to revert.
>>
>> Jacques
>>
>>
>> Le 25/09/2016 à 01:44, Scott Gray a écrit :
>>
>>> As an aside to this, and also what I mentioned in the flat grey vote
>>> thread:
>>>
>>> I think you rely on lazy consensus too much.  Not many contributors have
 as much time as you to give to the project and formulating an argument
 against something (and then continuing the discussion) can take up a
 lot of
 time and energy.  In my experience people are generally very quick to
 agree
 to good ideas (because it takes no effort other than to reply +1) so if
 you
 get *no* responses then you should IMO take pause before pushing ahead.

 Out of curiosity I took a look at your activity this month:
>>> 24 discussion begun
>>> 11 commits that triggered a discussion
>>> 80 other commits that presumably required some level of review
>>>
>>> While your contributions are appreciated, please be aware of the burden
>>> this high level of activity places on the rest of the active contributors
>>> and the time consumed is time that those contributors could be putting
>>> into
>>> pursuing their own priorities.
>>>
>>> Given this, do you really think it is fair to get annoyed when people
>>> don't
>>> respond quickly enough for you?  Does it seem wise to apply lazy
>>> consensus
>>> to decisions that don't receive much feedback?
>>>
>>> Regards
>>> Scott
>>>
>>> On 25 September 2016 at 11:00, Scott Gray 
>>> wrote:
>>>
>>> Calm down Jacques, I'm sure Michael will respond when he has a chance.
 This isn't a big deal and I don't see why there would be any rush to
 fill
 your request.

 Regards
 Scott

 On 23 September 2016 at 21:38, Jacques Le Roux <
 jacques.le.r...@les7arts.com> wrote:

 After 4 days clearly nobody cares. I guess Michael does not want to
> "open
> source" his process and nobody cares about having this information
> monthly
> in the blog or not.
>
> Closed
>
> Jacques
>
>
>
> Le 19/09/2016 à 10:26, Jacques Le Roux a écrit :
>
> Hi All, Michael,
>>
>> Like we have a 

Re: Commits r1763306 and r1761169 re enhancing services

[Nicolas Malin]

In view of the thread http://markmail.org/message/pwzgq24q7fawdzxl, I 
agree to keep service definition on datamodel if it's crud service under 
entity-auto


I opened a issue OFBIZ-6874 
 to don't forget this 
migration when I will finish the minilang to entity-auto migration


Nicolas

Le 14/10/2016 à 13:39, Arun Patidar a écrit :

Thanks Pierre for reporting this. I had discussion with Jacopo regarding
same. I will move these services to appropriate location.

Re: svn commit: r1765058 - in /ofbiz/trunk/framework/widget: dtd/ src/main/java/org/apache/ofbiz/widget/model/ src/main/java/org/apache/ofbiz/widget/renderer/ src/main/java/org/apache/ofbiz/widget/ren

[Jacques Le Roux]

Hi Mridul,

After Arun fixed a compilation issue at r1765080, I found that this introduced 
a regression. Please see https://issues.apache.org/jira/browse/OFBIZ-8505

I think it's better to revert and test this more.

Thanks

Jacques


Le 15/10/2016 à 16:25, Jacques Le Roux a écrit :

Hi Mridul,

Did you notice we have a compilation issue with this commit?

https://ci.apache.org/builders/ofbiz-trunk

https://ci.apache.org/builders/ofbiz-trunk/builds/1607/steps/shell/logs/stdio

Thanks

Jacques


Le 15/10/2016 à 15:19, mridulpat...@apache.org a écrit :

Author: mridulpathak
Date: Sat Oct 15 13:19:35 2016
New Revision: 1765058

URL: http://svn.apache.org/viewvc?rev=1765058=rev
Log:
Improved: In form widgets of list type empty header row should not render if 
list to render in file is empty.
(OFBIZ-7598)

Thanks: Suraj Khurana for contribution.

Modified:
 ofbiz/trunk/framework/widget/dtd/widget-form.xsd
ofbiz/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelForm.java
ofbiz/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/FormRenderer.java
ofbiz/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/FormStringRenderer.java
ofbiz/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java
ofbiz/trunk/framework/widget/templates/HtmlFormMacroLibrary.ftl

Modified: ofbiz/trunk/framework/widget/dtd/widget-form.xsd
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/dtd/widget-form.xsd?rev=1765058=1765057=1765058=diff
==
--- ofbiz/trunk/framework/widget/dtd/widget-form.xsd (original)
+++ ofbiz/trunk/framework/widget/dtd/widget-form.xsd Sat Oct 15 13:19:35 2016
@@ -86,6 +86,7 @@ under the License.
  
  
  
+
  
  
  
@@ -327,6 +328,7 @@ under the License.
  
  
  
+
  
  
  

Modified: 
ofbiz/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelForm.java
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelForm.java?rev=1765058=1765057=1765058=diff

==
--- 
ofbiz/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelForm.java
 (original)
+++ 
ofbiz/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelForm.java
 Sat Oct 15 13:19:35 2016
@@ -147,7 +147,7 @@ public abstract class ModelForm extends
  private final String formWidgetAreaStyle;
  private final boolean groupColumns;
  private final String headerRowStyle;
-private final boolean hideHeader;
+private boolean hideHeader;
  private final String itemIndexSeparator;
  private final List lastOrderFields;
  private final String listEntryName;
@@ -184,6 +184,7 @@ public abstract class ModelForm extends
  private final String targetType;
  private final FlexibleStringExpander targetWindowExdr;
  private final String title;
+private final String emptyFormDataMessage;
  private final String tooltip;
  private final String type;
  private final boolean useRowSubmit;
@@ -241,6 +242,13 @@ public abstract class ModelForm extends
  title = parentModel.title;
  }
  this.title = title;
+String emptyFormDataMessage = 
formElement.getAttribute("empty-form-data-message");
+if (emptyFormDataMessage.isEmpty() && parentModel != null) {
+emptyFormDataMessage = parentModel.emptyFormDataMessage;
+} else if (emptyFormDataMessage.isEmpty()) {
+emptyFormDataMessage = "No records found";
+}
+this.emptyFormDataMessage = emptyFormDataMessage;
  String tooltip = formElement.getAttribute("tooltip");
  if (tooltip.isEmpty() && parentModel != null) {
  tooltip = parentModel.tooltip;
@@ -1015,6 +1023,10 @@ public abstract class ModelForm extends
  public boolean getHideHeader() {
  return this.hideHeader;
  }
+public boolean setHideHeader(Boolean hideHeader) {
+this.hideHeader = hideHeader;
+return hideHeader;
+}
public String getItemIndexSeparator() {
  if (UtilValidate.isNotEmpty(this.itemIndexSeparator)) {
@@ -1384,6 +1396,10 @@ public abstract class ModelForm extends
  return this.title;
  }
  +public String getEmptyFormDataMessage() {
+return this.emptyFormDataMessage;
+}
+
  public String getTooltip() {
  return this.tooltip;
  }

Modified: 
ofbiz/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/FormRenderer.java
URL: 

Re: Validation messages to auto-attributes of a service

[Nicolas Malin]

I did think about this few years ago.

It's nice to put a dedicate message, and it's more powerfull to put a 
default rule to resolve the label with a pattern like :


Default file for Service error message : 
component/config/ServiceErrorLabels.xml


pattern : ServiceValidation.IN.${service-name}.${service-attribute}

And maybe use a default pattern if not found for a dedicate service

pattern : ServiceValidation.IN.common.${service-attribute}

The advantage, keep service definition light, and offer the possibility 
to surcharge if needed with the  


Nicolas


Le 13/10/2016 à 10:21, Rishi Solanki a écrit :

Applying same to your example;



 
  
 





Rishi Solanki
Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com

On Thu, Oct 13, 2016 at 1:46 PM, Rishi Solanki 
wrote:


Devanshu,

You can simply try to use override to override the default behavior of
auto-attribute. For example; if you are working on PartyContanctMech and
you want partyId and contactMechId should return custom error message if
empty. Then use the following practice to do that;



 
  
 



Override tag intended to override the default behavior set in the
auto-attributes. Simply using it suggested and implemented at service
defintion level.


HTH!



Rishi Solanki
Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com

On Thu, Oct 13, 2016 at 11:14 AM, Devanshu Vyas 

Re: Ecommerce Portal Enhancement

[Rishi Solanki]

James, Paul, Pierre,

Thank you for your response, inputs, ideas and references. We do agree to
have responsive UI/UX compatible to most devices especially mobile. Also we
tried to inlist this point in our summary but not clearly. With all the
above mentioned points, we would include the responsive web design in the
list.

Also if anyone can answer on the question, which webapp we should use to
implement all this would be great. *ecomseo* is one option, and adding one
new webapp is another option. We just wated to make sure before proceeding
because, we don't want to override the purpose of an app intended to
demonstrate very specific item. If we use *ecomseo *then we would like to
maintain the SEO and URLs purpose of that application. If not then we will
go for new webapp.

Please suggest. Thanks again for your help!


Rishi Solanki
Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com

On Mon, Oct 17, 2016 at 12:39 PM, Pierre Smits 
wrote:

> The *oshop* solution (and associated *ecbootstrap* theme) are a step in the
> direction of bringing ecommerce functions to mobile devices. See:
>
>- for the *oshop* component:
>https://oem.ofbizci.net/oci-2/products/ecommerce/p_orrtiz-oshop
>- for the *ecbootstrap* theme:
>https://oem.ofbizci.net/oci-2/products/themes/themes-front/
> p_orrtiz-ecbootstrap
>
> From there on you can link through to the code repos on Github of each.
>
> Best regards,
>
> Pierre Smits
>
> ORRTIZ.COM 
> OFBiz based solutions & services
>
> OFBiz Extensions Marketplace
> http://oem.ofbizci.net/oci-2/
>
> On Mon, Oct 17, 2016 at 2:10 AM, Paul Foxworthy 
> wrote:
>
> > On 16 October 2016 at 16:46, james_sg  wrote:
> >
> >
> > > More people are shopping with their mobile phones;
> > > Would be good to have responsive web design for ecommerce.
> > >
> >
> > Yes, responsive web design would be a good idea. But it should be done
> > using theming, so it would be applicable to all of OFBiz and not just
> > ecommerce.
> >
> > Cheers
> >
> > Paul Foxworthy
> >
>

Re: Ecommerce Portal Enhancement

[Pierre Smits]

The *oshop* solution (and associated *ecbootstrap* theme) are a step in the
direction of bringing ecommerce functions to mobile devices. See:

   - for the *oshop* component:
   https://oem.ofbizci.net/oci-2/products/ecommerce/p_orrtiz-oshop
   - for the *ecbootstrap* theme:
   
https://oem.ofbizci.net/oci-2/products/themes/themes-front/p_orrtiz-ecbootstrap

>From there on you can link through to the code repos on Github of each.

Best regards,

Pierre Smits

ORRTIZ.COM 
OFBiz based solutions & services

OFBiz Extensions Marketplace
http://oem.ofbizci.net/oci-2/

On Mon, Oct 17, 2016 at 2:10 AM, Paul Foxworthy  wrote:

> On 16 October 2016 at 16:46, james_sg  wrote:
>
>
> > More people are shopping with their mobile phones;
> > Would be good to have responsive web design for ecommerce.
> >
>
> Yes, responsive web design would be a good idea. But it should be done
> using theming, so it would be applicable to all of OFBiz and not just
> ecommerce.
>
> Cheers
>
> Paul Foxworthy
>