Re: svn commit: r1767101 - in /ofbiz/trunk: applications/accounting/servicedef/ applications/marketing/servicedef/ applications/order/servicedef/ applications/party/servicedef/ applications/product/mi
Hi Jacques, Thanks for reviewing and suggesting improvements. I will look into this and fix it in my next attempt very soon. -- Thanks & Regards --- Arun Patidar Manager,Enterprise Software Development HotWax Mediawww.hotwaxsystems.com On Wed, Nov 2, 2016 at 2:25 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi Arun, > > Very minor, but is there a reason why services_shipmentgateway.xml is > still a bit weird (compared to other changes)? > > I mean how it's sorted (not always create/update/delete order) and why > updateShipmentGatewayConfig and updateShipmentGatewayConfigType still in > minilang ? > > Thanks > > Jacques > > > > Le 29/10/2016 à 11:01, arunpati...@apache.org a écrit : > >> Author: arunpatidar >> Date: Sat Oct 29 09:01:09 2016 >> New Revision: 1767101 >> >> URL: http://svn.apache.org/viewvc?rev=1767101=rev >> Log: >> Implemented: Added CRUD services for CountryAddressFormat, >> ExampleFeatureApplType, GoodIdentificationType, InventoryItemType, >> InventoryItemTypeAttr, InvoiceContentType, InvoiceItemTypeAttr, >> InvoiceItemTypeMap, InvoiceType, NeedType, OrderAdjustmentTypeAttr, >> SalesOrderItemFact, SegmentGroupType, ShipmentGatewayConfigType, >> ShipmentGatewayDhl, ShipmentGatewayFedex, ShipmentType, ShippingDocument >> and ShoppingListType entities. >> >> (OFBIZ-8087) (OFBIZ-8204) (OFBIZ-8245) (OFBIZ-8248) (OFBIZ-8249) >> (OFBIZ-8257) (OFBIZ-8261) (OFBIZ-8267) (OFBIZ-8270) (OFBIZ-8279) >> (OFBIZ-8284) (OFBIZ-8437) (OFBIZ-8439) (OFBIZ-8455) (OFBIZ-8460) >> (OFBIZ-8461) >> (OFBIZ-8470) (OFBIZ-8473) (OFBIZ-8478) >> >> Thanks: Rohit Koushal, Aman Mishra, Chinmay Patidar and Amit Gadaley for >> the contribution. >> >> Modified: >> ofbiz/trunk/applications/accounting/servicedef/services_invoice.xml >> ofbiz/trunk/applications/marketing/servicedef/services.xml >> ofbiz/trunk/applications/order/servicedef/services.xml >> ofbiz/trunk/applications/order/servicedef/services_shoppinglist.xml >> ofbiz/trunk/applications/party/servicedef/services.xml >> ofbiz/trunk/applications/product/minilang/shipment/shipment >> /ShipmentGatewayConfigServices.xml >> ofbiz/trunk/applications/product/servicedef/services.xml >> ofbiz/trunk/applications/product/servicedef/services_facility.xml >> ofbiz/trunk/applications/product/servicedef/services_inventory.xml >> ofbiz/trunk/applications/product/servicedef/services_shipment.xml >> ofbiz/trunk/applications/product/servicedef/services_shipme >> ntgateway.xml >> ofbiz/trunk/framework/common/servicedef/services_geo.xml >> ofbiz/trunk/specialpurpose/example/servicedef/services.xml >> >> Modified: ofbiz/trunk/applications/accounting/servicedef/services_ >> invoice.xml >> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accoun >> ting/servicedef/services_invoice.xml?rev=1767101= >> 1767100=1767101=diff >> >> == >> --- ofbiz/trunk/applications/accounting/servicedef/services_invoice.xml >> (original) >> +++ ofbiz/trunk/applications/accounting/servicedef/services_invoice.xml >> Sat Oct 29 09:01:09 2016 >> @@ -528,4 +528,65 @@ under the License. >> Delete a InvoiceNote >> >> >> + >> +> default-entity-name="InvoiceContentType" engine="entity-auto" >> invoke="create" auth="true"> >> +Create a InvoiceContentType >> + >> + >> + >> +> default-entity-name="InvoiceContentType" engine="entity-auto" >> invoke="update" auth="true"> >> +Update a InvoiceContentType >> + >> + >> + >> +> default-entity-name="InvoiceContentType" engine="entity-auto" >> invoke="delete" auth="true"> >> +Delete a InvoiceContentType >> + >> + >> + >> + >> +> default-entity-name="InvoiceItemTypeAttr" engine="entity-auto" >> invoke="create" auth="true"> >> +Create InvoiceItemTypeAttr >> + >> + >> + >> +> default-entity-name="InvoiceItemTypeAttr" engine="entity-auto" >> invoke="update" auth="true"> >> +Update InvoiceItemTypeAttr >> + >> + >> + >> +> default-entity-name="InvoiceItemTypeAttr" engine="entity-auto" >> invoke="delete" auth="true"> >> +Delete InvoiceItemTypeAttr >> + >> + >> + >> +> default-entity-name="InvoiceItemTypeMap" engine="entity-auto" >> invoke="create" auth="true"> >> +Create InvoiceItemTypeMap >> + >> + >> + >> +> default-entity-name="InvoiceItemTypeMap" engine="entity-auto" >> invoke="update" auth="true"> >> +Update InvoiceItemTypeMap >> + >> + >> + >> +> default-entity-name="InvoiceItemTypeMap" engine="entity-auto" >> invoke="delete" auth="true"> >> +Delete InvoiceItemTypeMap >> + >> + >> + >> +> engine="entity-auto" invoke="create" auth="true"> >> +Create a InvoiceType >> + >> + >> + >> +>
Re: Groovy and semicolon at EOL
Hi Rishi, It's not the first time we change a *simple thing* in all the source. I can live with that, you seem well organised :) BTW after appling the patch at OFBIZ-8652 I still find 57 trailing semicolons :) Thanks Jacques Le 01/11/2016 à 07:35, Rishi Solanki a écrit : Jacques, Yes we would like to commit it as whole, but before commit for the same we have plan to test each component after applying the changes. Like browse to most pages and general work flows. We will post the updates on ticket something like; Test the party component; Pages/Work Flow tested: Find Party, Create Party, View Party, My Communications, Visits, Classification, Security, Invitation pages etc. The above is an example of how we will confirm everything is working properly, with some basic code review. We would follow the same steps for other components. Please let us know plan looks fine to you. Also in case you think we should take care anything else to minimize the possibility of regression Or may be if you think committing the changes per component will help in code review? Thanks! Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Fri, Oct 28, 2016 at 4:10 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: Hi Rishi, Will you commit as a whole? Jacques Le 28/10/2016 à 12:07, Rishi Solanki a écrit : Started effort under - https://issues.apache.org/jira/browse/OFBIZ-8652 Thanks to Rohit Kaushal for taking care of this. It will take 4-5 days for testing. Thanks! Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Sat, Sep 17, 2016 at 2:11 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: Personally I will go this way: I will add or changes lines without putting semicolons. I'm in favour of bulk changing files, but I'd prefer by component or webapp to ease reviews. Jacques Le 16/09/2016 à 15:36, Rishi Solanki a écrit : I was saying #2 as per the comment from Taher Quick Reference: One reply from Taher ... in the same thread. == Okay, given the priorities and work we have at the moment, I suggest we keep semicolons and use it as the standard unless someone volunteers to make a full switch. WDYT? == Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Fri, Sep 16, 2016 at 3:14 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: I guess you mean 2) by file, then it's OK with me. Though I'd no be against having semicolon inconsistency in Groovy files, which was my initial question. So no strong opinion about 2 here. Jacques Le 16/09/2016 à 11:31, Rishi Solanki a écrit : To summarize the overall conversation; 1) We have decided to bulk remove semicolons from groovy. 2) Until #1 is not complete, we would keep adding semicolon for consistency. Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Thu, Sep 15, 2016 at 10:00 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: Actually I was wrong on this. Thanks to Jacopo I noticed that both Subclipse and Tortoise allow you to select a range of revisions when you look for annotations. So it's no longer an issue for me and we can bulk remove trailing semicolons in Groovy files if we want. Sorry for the confusion Jacques Le 14/09/2016 à 04:42, Scott Gray a écrit : I don't particularly care one way or another if groovy files have a semi-colon at the end. I don't even care about consistency because it is such a minor thing. I say remove them if they're on a line you happen to be editing, otherwise just leave them be. Regarding the annotations, there's plenty of ways to search commit logs and personally I've never found blame to be very useful. I don't think it should be a reason to block any future bulk S/R cleanups. We've had plenty in the past (Double -> BigDecimal, Delegator -> EntityQuery, whitespace removal, etc.) and we should continue to do it to keep things clean. For searching diffs, before using git-svn I used to use: svn log -diff and then use the search in the terminal to find the string I'm looking for. Regards Scott On 14 September 2016 at 07:33, Jacques Le Roux < jacques.le.r...@les7arts.com wrote: Le 13/09/2016 à 21:28, Jacques Le Roux a écrit : OK found that the same than in Subclipse also exists in TortoiseSVN But you need to use a command line (weird for a GUI), eg (from TortoiseSVN root folder) Actually wrong, simply pick a file in Windows file explorer using TortoiseSVN context menu, et voilà! I confirm, totally comparable to Subclipse annotations Jacques TortoiseProc.exe /command:blame /path:"C:\projectASF-Mars\ofbi z\applications\product\src\main\java\org\apache\ofbiz\
Re: svn commit: r1767101 - in /ofbiz/trunk: applications/accounting/servicedef/ applications/marketing/servicedef/ applications/order/servicedef/ applications/party/servicedef/ applications/product/mi
Hi Arun, Very minor, but is there a reason why services_shipmentgateway.xml is still a bit weird (compared to other changes)? I mean how it's sorted (not always create/update/delete order) and why updateShipmentGatewayConfig and updateShipmentGatewayConfigType still in minilang ? Thanks Jacques Le 29/10/2016 à 11:01, arunpati...@apache.org a écrit : Author: arunpatidar Date: Sat Oct 29 09:01:09 2016 New Revision: 1767101 URL: http://svn.apache.org/viewvc?rev=1767101=rev Log: Implemented: Added CRUD services for CountryAddressFormat, ExampleFeatureApplType, GoodIdentificationType, InventoryItemType, InventoryItemTypeAttr, InvoiceContentType, InvoiceItemTypeAttr, InvoiceItemTypeMap, InvoiceType, NeedType, OrderAdjustmentTypeAttr, SalesOrderItemFact, SegmentGroupType, ShipmentGatewayConfigType, ShipmentGatewayDhl, ShipmentGatewayFedex, ShipmentType, ShippingDocument and ShoppingListType entities. (OFBIZ-8087) (OFBIZ-8204) (OFBIZ-8245) (OFBIZ-8248) (OFBIZ-8249) (OFBIZ-8257) (OFBIZ-8261) (OFBIZ-8267) (OFBIZ-8270) (OFBIZ-8279) (OFBIZ-8284) (OFBIZ-8437) (OFBIZ-8439) (OFBIZ-8455) (OFBIZ-8460) (OFBIZ-8461) (OFBIZ-8470) (OFBIZ-8473) (OFBIZ-8478) Thanks: Rohit Koushal, Aman Mishra, Chinmay Patidar and Amit Gadaley for the contribution. Modified: ofbiz/trunk/applications/accounting/servicedef/services_invoice.xml ofbiz/trunk/applications/marketing/servicedef/services.xml ofbiz/trunk/applications/order/servicedef/services.xml ofbiz/trunk/applications/order/servicedef/services_shoppinglist.xml ofbiz/trunk/applications/party/servicedef/services.xml ofbiz/trunk/applications/product/minilang/shipment/shipment/ShipmentGatewayConfigServices.xml ofbiz/trunk/applications/product/servicedef/services.xml ofbiz/trunk/applications/product/servicedef/services_facility.xml ofbiz/trunk/applications/product/servicedef/services_inventory.xml ofbiz/trunk/applications/product/servicedef/services_shipment.xml ofbiz/trunk/applications/product/servicedef/services_shipmentgateway.xml ofbiz/trunk/framework/common/servicedef/services_geo.xml ofbiz/trunk/specialpurpose/example/servicedef/services.xml Modified: ofbiz/trunk/applications/accounting/servicedef/services_invoice.xml URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/servicedef/services_invoice.xml?rev=1767101=1767100=1767101=diff == --- ofbiz/trunk/applications/accounting/servicedef/services_invoice.xml (original) +++ ofbiz/trunk/applications/accounting/servicedef/services_invoice.xml Sat Oct 29 09:01:09 2016 @@ -528,4 +528,65 @@ under the License. Delete a InvoiceNote + + +Create a InvoiceContentType + + + + +Update a InvoiceContentType + + + + +Delete a InvoiceContentType + + + + + +Create InvoiceItemTypeAttr + + + + +Update InvoiceItemTypeAttr + + + + +Delete InvoiceItemTypeAttr + + + + +Create InvoiceItemTypeMap + + + + +Update InvoiceItemTypeMap + + + + +Delete InvoiceItemTypeMap + + + + +Create a InvoiceType + + + + +Update a InvoiceType + + + + +Delete a InvoiceType + + Modified: ofbiz/trunk/applications/marketing/servicedef/services.xml URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/servicedef/services.xml?rev=1767101=1767100=1767101=diff == --- ofbiz/trunk/applications/marketing/servicedef/services.xml (original) +++ ofbiz/trunk/applications/marketing/servicedef/services.xml Sat Oct 29 09:01:09 2016 @@ -541,4 +541,20 @@ under the License. + + +Create SegmentGroupType + + + + +Update SegmentGroupType + + + + +Delete SegmentGroupType + + + Modified: ofbiz/trunk/applications/order/servicedef/services.xml URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/servicedef/services.xml?rev=1767101=1767100=1767101=diff == --- ofbiz/trunk/applications/order/servicedef/services.xml (original) +++ ofbiz/trunk/applications/order/servicedef/services.xml Sat Oct 29 09:01:09 2016 @@ -1204,4 +1204,34 @@ under the License. Expire a OrderContent + + +Create a OrderAdjustmentTypeAttr + + + + +Update a OrderAdjustmentTypeAttr + + + + +Delete a OrderAdjustmentTypeAttr + + + + +Create a
Re: Security page
My preference is to keep the content as it is now, or create a security.html page: this page should contain the official CVEs (similarly to what we have now) and not suggestions, or how-to guides to keep the system secure (but we could add a link to this content, that should stay in the Wiki) Jacopo On Mon, Oct 31, 2016 at 2:27 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi, > > We now have an entry at https://www.apache.org/security/projects.html > It points to secur...@ofbiz.apache.org > > We could create a specific page in wiki > > I thought about a combination of https://cwiki.apache.org/confl > uence/display/OFBIZ/Keeping+OFBiz+secure and > > We could add the content of http://ofbiz.apache.org/downlo > ad.html#vulnerabilities in this page and redirect from > http://ofbiz.apache.org/download.html to https://cwiki.apache.org/confl > uence/display/OFBIZ/Keeping+OFBiz+secure > > What do you think? > > Jacques > >
Re: Groovy and semicolon at EOL
Jacques, Yes we would like to commit it as whole, but before commit for the same we have plan to test each component after applying the changes. Like browse to most pages and general work flows. We will post the updates on ticket something like; Test the party component; Pages/Work Flow tested: Find Party, Create Party, View Party, My Communications, Visits, Classification, Security, Invitation pages etc. The above is an example of how we will confirm everything is working properly, with some basic code review. We would follow the same steps for other components. Please let us know plan looks fine to you. Also in case you think we should take care anything else to minimize the possibility of regression Or may be if you think committing the changes per component will help in code review? Thanks! Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Fri, Oct 28, 2016 at 4:10 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi Rishi, > > Will you commit as a whole? > > Jacques > > > > Le 28/10/2016 à 12:07, Rishi Solanki a écrit : > >> Started effort under - https://issues.apache.org/jira/browse/OFBIZ-8652 >> >> Thanks to Rohit Kaushal for taking care of this. It will take 4-5 days for >> testing. >> >> >> Thanks! >> >> Rishi Solanki >> Manager, Enterprise Software Development >> HotWax Systems Pvt. Ltd. >> Direct: +91-9893287847 >> http://www.hotwaxsystems.com >> >> On Sat, Sep 17, 2016 at 2:11 AM, Jacques Le Roux < >> jacques.le.r...@les7arts.com> wrote: >> >> Personally I will go this way: I will add or changes lines without putting >>> semicolons. >>> >>> I'm in favour of bulk changing files, but I'd prefer by component or >>> webapp to ease reviews. >>> >>> Jacques >>> >>> >>> Le 16/09/2016 à 15:36, Rishi Solanki a écrit : >>> >>> I was saying #2 as per the comment from Taher Quick Reference: One reply from Taher ... in the same thread. == Okay, given the priorities and work we have at the moment, I suggest we keep semicolons and use it as the standard unless someone volunteers to make a full switch. WDYT? == Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Fri, Sep 16, 2016 at 3:14 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: I guess you mean 2) by file, then it's OK with me. Though I'd no be > against having semicolon inconsistency in Groovy files, which was my > initial question. So no strong opinion about 2 here. > > Jacques > > > > Le 16/09/2016 à 11:31, Rishi Solanki a écrit : > > To summarize the overall conversation; > >> 1) We have decided to bulk remove semicolons from groovy. >> 2) Until #1 is not complete, we would keep adding semicolon for >> consistency. >> >> >> >> >> Rishi Solanki >> Manager, Enterprise Software Development >> HotWax Systems Pvt. Ltd. >> Direct: +91-9893287847 >> http://www.hotwaxsystems.com >> >> On Thu, Sep 15, 2016 at 10:00 AM, Jacques Le Roux < >> jacques.le.r...@les7arts.com> wrote: >> >> Actually I was wrong on this. Thanks to Jacopo I noticed that both >> >> Subclipse and Tortoise allow you to select a range of revisions when >>> you >>> look for annotations. >>> >>> So it's no longer an issue for me and we can bulk remove trailing >>> semicolons in Groovy files if we want. >>> >>> Sorry for the confusion >>> >>> Jacques >>> >>> >>> >>> Le 14/09/2016 à 04:42, Scott Gray a écrit : >>> >>> I don't particularly care one way or another if groovy files have a >>> >>> semi-colon at the end. I don't even care about consistency because it is such a minor thing. I say remove them if they're on a line you happen to be editing, otherwise just leave them be. Regarding the annotations, there's plenty of ways to search commit logs and personally I've never found blame to be very useful. I don't think it should be a reason to block any future bulk S/R cleanups. We've had plenty in the past (Double -> BigDecimal, Delegator -> EntityQuery, whitespace removal, etc.) and we should continue to do it to keep things clean. For searching diffs, before using git-svn I used to use: svn log -diff and then use the search in the terminal to find the string I'm looking for. Regards Scott On 14 September 2016 at 07:33, Jacques Le Roux < jacques.le.r...@les7arts.com wrote:
