Re: Groovy and semicolon at EOL
Yes we have noticed some semicolons, and it seems we need to replace them manually. Because in all groovy files we have seen the semicolon in the lincense text as well. Thank you for your help Jacques :-) Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Wed, Nov 2, 2016 at 2:36 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi Rishi, > > It's not the first time we change a *simple thing* in all the source. I > can live with that, you seem well organised :) > > BTW after appling the patch at OFBIZ-8652 I still find 57 trailing > semicolons :) > > Thanks > > Jacques > > > > Le 01/11/2016 à 07:35, Rishi Solanki a écrit : > >> Jacques, >> >> Yes we would like to commit it as whole, but before commit for the same we >> have plan to test each component after applying the changes. Like browse >> to >> most pages and general work flows. We will post the updates on ticket >> something like; >> >> Test the party component; >> Pages/Work Flow tested: Find Party, Create Party, View Party, My >> Communications, Visits, Classification, Security, Invitation pages etc. >> >> The above is an example of how we will confirm everything is working >> properly, with some basic code review. We would follow the same steps for >> other components. >> >> Please let us know plan looks fine to you. Also in case you think we >> should >> take care anything else to minimize the possibility of regression Or may >> be >> if you think committing the changes per component will help in code >> review? >> >> Thanks! >> >> >> >> Rishi Solanki >> Manager, Enterprise Software Development >> HotWax Systems Pvt. Ltd. >> Direct: +91-9893287847 >> http://www.hotwaxsystems.com >> >> On Fri, Oct 28, 2016 at 4:10 PM, Jacques Le Roux < >> jacques.le.r...@les7arts.com> wrote: >> >> Hi Rishi, >>> >>> Will you commit as a whole? >>> >>> Jacques >>> >>> >>> >>> Le 28/10/2016 à 12:07, Rishi Solanki a écrit : >>> >>> Started effort under - https://issues.apache.org/jira/browse/OFBIZ-8652 Thanks to Rohit Kaushal for taking care of this. It will take 4-5 days for testing. Thanks! Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Sat, Sep 17, 2016 at 2:11 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: Personally I will go this way: I will add or changes lines without putting > semicolons. > > I'm in favour of bulk changing files, but I'd prefer by component or > webapp to ease reviews. > > Jacques > > > Le 16/09/2016 à 15:36, Rishi Solanki a écrit : > > I was saying #2 as per the comment from Taher > >> Quick Reference: >> >> One reply from Taher ... in the same thread. >> == >> >> Okay, given the priorities and work we have at the moment, I suggest >> we >> keep semicolons and use it as the standard unless someone volunteers >> to >> make a full switch. WDYT? >> == >> >> >> >> Rishi Solanki >> Manager, Enterprise Software Development >> HotWax Systems Pvt. Ltd. >> Direct: +91-9893287847 >> http://www.hotwaxsystems.com >> >> On Fri, Sep 16, 2016 at 3:14 PM, Jacques Le Roux < >> jacques.le.r...@les7arts.com> wrote: >> >> I guess you mean 2) by file, then it's OK with me. Though I'd no be >> >> against having semicolon inconsistency in Groovy files, which was my >>> initial question. So no strong opinion about 2 here. >>> >>> Jacques >>> >>> >>> >>> Le 16/09/2016 à 11:31, Rishi Solanki a écrit : >>> >>> To summarize the overall conversation; >>> >>> 1) We have decided to bulk remove semicolons from groovy. 2) Until #1 is not complete, we would keep adding semicolon for consistency. Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Thu, Sep 15, 2016 at 10:00 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: Actually I was wrong on this. Thanks to Jacopo I noticed that both Subclipse and Tortoise allow you to select a range of revisions when > you > look for annotations. > > So it's no longer an issue for me and we can bulk remove trailing > semicolons in Groovy files if we want. > > Sorry for the confusion > > Jacques > > > > Le 14/09/2016 à 04:42, Scott Gray a écrit : > > I don't particularly care one way or another if groovy files have a > > semi-colon at the
Re: Groovy and semicolon at EOL
Hi Rishi, No need to do it by hand. I did it with regexp S/R in Eclipse and have updated the patch at OFBIZ-8652, please check Thanks Jacques Le 02/11/2016 à 09:18, Rishi Solanki a écrit : Yes we have noticed some semicolons, and it seems we need to replace them manually. Because in all groovy files we have seen the semicolon in the lincense text as well. Thank you for your help Jacques :-) Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Wed, Nov 2, 2016 at 2:36 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: Hi Rishi, It's not the first time we change a *simple thing* in all the source. I can live with that, you seem well organised :) BTW after appling the patch at OFBIZ-8652 I still find 57 trailing semicolons :) Thanks Jacques Le 01/11/2016 à 07:35, Rishi Solanki a écrit : Jacques, Yes we would like to commit it as whole, but before commit for the same we have plan to test each component after applying the changes. Like browse to most pages and general work flows. We will post the updates on ticket something like; Test the party component; Pages/Work Flow tested: Find Party, Create Party, View Party, My Communications, Visits, Classification, Security, Invitation pages etc. The above is an example of how we will confirm everything is working properly, with some basic code review. We would follow the same steps for other components. Please let us know plan looks fine to you. Also in case you think we should take care anything else to minimize the possibility of regression Or may be if you think committing the changes per component will help in code review? Thanks! Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Fri, Oct 28, 2016 at 4:10 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: Hi Rishi, Will you commit as a whole? Jacques Le 28/10/2016 à 12:07, Rishi Solanki a écrit : Started effort under - https://issues.apache.org/jira/browse/OFBIZ-8652 Thanks to Rohit Kaushal for taking care of this. It will take 4-5 days for testing. Thanks! Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Sat, Sep 17, 2016 at 2:11 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: Personally I will go this way: I will add or changes lines without putting semicolons. I'm in favour of bulk changing files, but I'd prefer by component or webapp to ease reviews. Jacques Le 16/09/2016 à 15:36, Rishi Solanki a écrit : I was saying #2 as per the comment from Taher Quick Reference: One reply from Taher ... in the same thread. == Okay, given the priorities and work we have at the moment, I suggest we keep semicolons and use it as the standard unless someone volunteers to make a full switch. WDYT? == Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Fri, Sep 16, 2016 at 3:14 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: I guess you mean 2) by file, then it's OK with me. Though I'd no be against having semicolon inconsistency in Groovy files, which was my initial question. So no strong opinion about 2 here. Jacques Le 16/09/2016 à 11:31, Rishi Solanki a écrit : To summarize the overall conversation; 1) We have decided to bulk remove semicolons from groovy. 2) Until #1 is not complete, we would keep adding semicolon for consistency. Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Thu, Sep 15, 2016 at 10:00 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: Actually I was wrong on this. Thanks to Jacopo I noticed that both Subclipse and Tortoise allow you to select a range of revisions when you look for annotations. So it's no longer an issue for me and we can bulk remove trailing semicolons in Groovy files if we want. Sorry for the confusion Jacques Le 14/09/2016 à 04:42, Scott Gray a écrit : I don't particularly care one way or another if groovy files have a semi-colon at the end. I don't even care about consistency because it is such a minor thing. I say remove them if they're on a line you happen to be editing, otherwise just leave them be. Regarding the annotations, there's plenty of ways to search commit logs and personally I've never found blame to be very useful. I don't think it should be a reason to block any future bulk S/R cleanups. We've had plenty in the past (Double -> BigDecimal, Delegator -> EntityQuery, whitespace removal, etc.) and we should continue to do it to keep things clean. For searching diffs, before using git-svn I used to use: svn log -diff and then use the search in the terminal to find the string I'm looking for. Regard
Re: Groovy and semicolon at EOL
Thank you very much Jacques. Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Wed, Nov 2, 2016 at 4:55 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi Rishi, > > No need to do it by hand. I did it with regexp S/R in Eclipse and have > updated the patch at OFBIZ-8652, please check > > Thanks > > Jacques > > > > Le 02/11/2016 à 09:18, Rishi Solanki a écrit : > >> Yes we have noticed some semicolons, and it seems we need to replace them >> manually. Because in all groovy files we have seen the semicolon in the >> lincense text as well. >> >> Thank you for your help Jacques :-) >> >> Rishi Solanki >> Manager, Enterprise Software Development >> HotWax Systems Pvt. Ltd. >> Direct: +91-9893287847 >> http://www.hotwaxsystems.com >> >> On Wed, Nov 2, 2016 at 2:36 AM, Jacques Le Roux < >> jacques.le.r...@les7arts.com> wrote: >> >> Hi Rishi, >>> >>> It's not the first time we change a *simple thing* in all the source. I >>> can live with that, you seem well organised :) >>> >>> BTW after appling the patch at OFBIZ-8652 I still find 57 trailing >>> semicolons :) >>> >>> Thanks >>> >>> Jacques >>> >>> >>> >>> Le 01/11/2016 à 07:35, Rishi Solanki a écrit : >>> >>> Jacques, Yes we would like to commit it as whole, but before commit for the same we have plan to test each component after applying the changes. Like browse to most pages and general work flows. We will post the updates on ticket something like; Test the party component; Pages/Work Flow tested: Find Party, Create Party, View Party, My Communications, Visits, Classification, Security, Invitation pages etc. The above is an example of how we will confirm everything is working properly, with some basic code review. We would follow the same steps for other components. Please let us know plan looks fine to you. Also in case you think we should take care anything else to minimize the possibility of regression Or may be if you think committing the changes per component will help in code review? Thanks! Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Fri, Oct 28, 2016 at 4:10 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: Hi Rishi, > Will you commit as a whole? > > Jacques > > > > Le 28/10/2016 à 12:07, Rishi Solanki a écrit : > > Started effort under - https://issues.apache.org/jira > /browse/OFBIZ-8652 > >> Thanks to Rohit Kaushal for taking care of this. It will take 4-5 days >> for >> testing. >> >> >> Thanks! >> >> Rishi Solanki >> Manager, Enterprise Software Development >> HotWax Systems Pvt. Ltd. >> Direct: +91-9893287847 >> http://www.hotwaxsystems.com >> >> On Sat, Sep 17, 2016 at 2:11 AM, Jacques Le Roux < >> jacques.le.r...@les7arts.com> wrote: >> >> Personally I will go this way: I will add or changes lines without >> putting >> >> semicolons. >>> >>> I'm in favour of bulk changing files, but I'd prefer by component or >>> webapp to ease reviews. >>> >>> Jacques >>> >>> >>> Le 16/09/2016 à 15:36, Rishi Solanki a écrit : >>> >>> I was saying #2 as per the comment from Taher >>> >>> Quick Reference: One reply from Taher ... in the same thread. == Okay, given the priorities and work we have at the moment, I suggest we keep semicolons and use it as the standard unless someone volunteers to make a full switch. WDYT? == Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Fri, Sep 16, 2016 at 3:14 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: I guess you mean 2) by file, then it's OK with me. Though I'd no be against having semicolon inconsistency in Groovy files, which was my > initial question. So no strong opinion about 2 here. > > Jacques > > > > Le 16/09/2016 à 11:31, Rishi Solanki a écrit : > > To summarize the overall conversation; > > 1) We have decided to bulk remove semicolons from groovy. > >> 2) Until #1 is not complete, we would keep adding semicolon for >> consistency. >> >> >> >> >> Rishi Solanki >> Manager, Enterprise Software Development >> HotWax Systems Pvt. Ltd. >> D
buildbot failure in on ofbiz-trunk
The Buildbot has detected a new failure on builder ofbiz-trunk while building . Full details are available at: https://ci.apache.org/builders/ofbiz-trunk/builds/1664 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler scheduler named 'on-ofbiz-commit' triggered this build Build Source Stamp: [branch ofbiz/trunk] 1767764 Blamelist: arunpatidar BUILD FAILED: failed shell_1 Sincerely, -The Buildbot
buildbot success in on ofbiz-trunk
The Buildbot has detected a restored build on builder ofbiz-trunk while building . Full details are available at: https://ci.apache.org/builders/ofbiz-trunk/builds/1665 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler scheduler named 'on-ofbiz-commit' triggered this build Build Source Stamp: [branch ofbiz/trunk] 1767773 Blamelist: deepak Build succeeded! Sincerely, -The Buildbot
buildbot failure in on ofbiz-trunk
The Buildbot has detected a new failure on builder ofbiz-trunk while building . Full details are available at: https://ci.apache.org/builders/ofbiz-trunk/builds/1666 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler scheduler named 'on-ofbiz-commit' triggered this build Build Source Stamp: [branch ofbiz/trunk] 176 Blamelist: deepak BUILD FAILED: failed shell_1 Sincerely, -The Buildbot
Re: Groovy and semicolon at EOL
This has been committed at rev:1767764. I have also verified application by accessing different screens of components. Please let me know if you find any issue regarding this change. -- Thanks & Regards --- Arun Patidar Manager,Enterprise Software Development HotWax Mediawww.hotwaxsystems.com On Wed, Nov 2, 2016 at 5:45 PM, Rishi Solanki wrote: > Thank you very much Jacques. > > Rishi Solanki > Manager, Enterprise Software Development > HotWax Systems Pvt. Ltd. > Direct: +91-9893287847 > http://www.hotwaxsystems.com > > On Wed, Nov 2, 2016 at 4:55 PM, Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > > > Hi Rishi, > > > > No need to do it by hand. I did it with regexp S/R in Eclipse and have > > updated the patch at OFBIZ-8652, please check > > > > Thanks > > > > Jacques > > > > > > > > Le 02/11/2016 à 09:18, Rishi Solanki a écrit : > > > >> Yes we have noticed some semicolons, and it seems we need to replace > them > >> manually. Because in all groovy files we have seen the semicolon in the > >> lincense text as well. > >> > >> Thank you for your help Jacques :-) > >> > >> Rishi Solanki > >> Manager, Enterprise Software Development > >> HotWax Systems Pvt. Ltd. > >> Direct: +91-9893287847 > >> http://www.hotwaxsystems.com > >> > >> On Wed, Nov 2, 2016 at 2:36 AM, Jacques Le Roux < > >> jacques.le.r...@les7arts.com> wrote: > >> > >> Hi Rishi, > >>> > >>> It's not the first time we change a *simple thing* in all the source. I > >>> can live with that, you seem well organised :) > >>> > >>> BTW after appling the patch at OFBIZ-8652 I still find 57 trailing > >>> semicolons :) > >>> > >>> Thanks > >>> > >>> Jacques > >>> > >>> > >>> > >>> Le 01/11/2016 à 07:35, Rishi Solanki a écrit : > >>> > >>> Jacques, > > Yes we would like to commit it as whole, but before commit for the > same > we > have plan to test each component after applying the changes. Like > browse > to > most pages and general work flows. We will post the updates on ticket > something like; > > Test the party component; > Pages/Work Flow tested: Find Party, Create Party, View Party, My > Communications, Visits, Classification, Security, Invitation pages > etc. > > The above is an example of how we will confirm everything is working > properly, with some basic code review. We would follow the same steps > for > other components. > > Please let us know plan looks fine to you. Also in case you think we > should > take care anything else to minimize the possibility of regression Or > may > be > if you think committing the changes per component will help in code > review? > > Thanks! > > > > Rishi Solanki > Manager, Enterprise Software Development > HotWax Systems Pvt. Ltd. > Direct: +91-9893287847 > http://www.hotwaxsystems.com > > On Fri, Oct 28, 2016 at 4:10 PM, Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > > Hi Rishi, > > > Will you commit as a whole? > > > > Jacques > > > > > > > > Le 28/10/2016 à 12:07, Rishi Solanki a écrit : > > > > Started effort under - https://issues.apache.org/jira > > /browse/OFBIZ-8652 > > > >> Thanks to Rohit Kaushal for taking care of this. It will take 4-5 > days > >> for > >> testing. > >> > >> > >> Thanks! > >> > >> Rishi Solanki > >> Manager, Enterprise Software Development > >> HotWax Systems Pvt. Ltd. > >> Direct: +91-9893287847 > >> http://www.hotwaxsystems.com > >> > >> On Sat, Sep 17, 2016 at 2:11 AM, Jacques Le Roux < > >> jacques.le.r...@les7arts.com> wrote: > >> > >> Personally I will go this way: I will add or changes lines without > >> putting > >> > >> semicolons. > >>> > >>> I'm in favour of bulk changing files, but I'd prefer by component > or > >>> webapp to ease reviews. > >>> > >>> Jacques > >>> > >>> > >>> Le 16/09/2016 à 15:36, Rishi Solanki a écrit : > >>> > >>> I was saying #2 as per the comment from Taher > >>> > >>> Quick Reference: > > One reply from Taher ... in the same thread. > == > > Okay, given the priorities and work we have at the moment, I > suggest > we > keep semicolons and use it as the standard unless someone > volunteers > to > make a full switch. WDYT? > == > > > > Rishi Solanki > Manager, Enterprise Software Development > HotWax Systems Pvt. Ltd. > Direct: +91-9893287847 > http://www.hotwaxsystems.com > > On Fri, Sep 16, 2016 at 3:14 PM, Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > > I guess you mean 2) by file, then it's OK with me. Though I'd no
buildbot success in on ofbiz-trunk
The Buildbot has detected a restored build on builder ofbiz-trunk while building . Full details are available at: https://ci.apache.org/builders/ofbiz-trunk/builds/1667 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler scheduler named 'on-ofbiz-commit' triggered this build Build Source Stamp: [branch ofbiz/trunk] 1767785 Blamelist: deepak Build succeeded! Sincerely, -The Buildbot
buildbot failure in on ofbiz-trunk
The Buildbot has detected a new failure on builder ofbiz-trunk while building . Full details are available at: https://ci.apache.org/builders/ofbiz-trunk/builds/1668 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler scheduler named 'on-ofbiz-commit' triggered this build Build Source Stamp: [branch ofbiz/trunk] 1767792 Blamelist: jleroux BUILD FAILED: failed shell_1 Sincerely, -The Buildbot
