date:20171217


Hi Michael,

In such case we need to ask infra for a nudge

Thanks

Jacques


Le 17/12/2017 à 22:51, Michael Brohl a écrit :

Hi,

how is the GitHub repository (https://github.com/apache/ofbiz-framework) 
updated?

It shows the last commit is 27 days ago, seems a little bit outdated...

Regards,

Michael

Re: svn commit: r1818007 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/ base/util/string: FlexibleStringExpander.java JuelConnector.java UelFunctions.java UelUtil.jav

Oh I missed your issue Jacques, thanks for catching theses commits and 
updating it.


Nicolas


Le 17/12/2017 à 22:40, Jacques Le Roux a écrit :

Thanks guys, this fixed OFBIZ-10058

Jacques


Le 17/12/2017 à 21:06, Michael Brohl a écrit :

Hi Nicolas,

great, seems I missed the 2nd similar code block. I saw too much code 
in the recent days... ;-)


Thanks for taking care,

regards,

Michael


Am 17.12.17 um 21:02 schrieb Nicolas Malin:

Thanks Michael

I applied the same correction on the second one at 1818510.

Thanks for the works !

Cheers,

Nicolas


Le 17/12/2017 à 19:10, Michael Brohl a écrit :

Hi Nicolas,

thanks for reporting!

I guess that this is the reason why there was no logging at all. At 
r1818498 I added verbose logging.


Thanks,

Michael


Am 17.12.17 um 18:00 schrieb Nicolas Malin:

Hello Michael,

Le 13/12/2017 à 14:03, mbr...@apache.org a écrit :
--- 
ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/string/JuelConnector.java 
(original)
+++ 
ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/string/JuelConnector.java 
Wed Dec 13 13:03:03 2017

@@ -78,7 +78,9 @@ public class JuelConnector {
  Object base = null;
  try {
  base = prefix.eval(bindings, context);
-    } catch (Exception e) {}
+    } catch (Exception e) {
+    Debug.log(e, module);
+    }


With this commit, my logs are now massively populate by

2017-12-17 17:32:52,542 |main |JuelConnector |F| null
javax.el.PropertyNotFoundException: Cannot resolve identifier 
'updateServiceCtx'
    at 
de.odysseus.el.tree.impl.ast.AstIdentifier.eval(AstIdentifier.java:93) 
~[juel-impl-2.2.7.jar:2.2.7]
    at 
org.apache.ofbiz.base.util.string.JuelConnector$ExtendedAstDot.setValue(JuelConnector.java:116) 
[ofbiz.jar:?]

    ...

I'm alone on this case ?
I propose, if you want display the exception, to replace all 
Debug.log(e, module); by
if (Debug.verboseOn()) {Debug.logVerbose("failed to  by " 
e.toString(), module); }


Like this we can display them without stacktrace when the verbose 
mode will be enable.


Cheers,
Nicolas

Re: GitHub repository updates

2017-12-17 Thread Deepak Dixit

Hi Michael,

We need to ask INFRA for this, It seems its related with 'LDAP issue caused
removal/re-add of Github users'


Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com
www.hotwax.co

On Mon, Dec 18, 2017 at 3:21 AM, Michael Brohl 
wrote:

> Hi,
>
> how is the GitHub repository (https://github.com/apache/ofbiz-framework)
> updated?
>
> It shows the last commit is 27 days ago, seems a little bit outdated...
>
> Regards,
>
> Michael
>
>
>
>

GitHub repository updates


Hi,

how is the GitHub repository (https://github.com/apache/ofbiz-framework) 
updated?


It shows the last commit is 27 days ago, seems a little bit outdated...

Regards,

Michael





smime.p7s
Description: S/MIME Cryptographic Signature

Re: svn commit: r1818007 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/ base/util/string: FlexibleStringExpander.java JuelConnector.java UelFunctions.java UelUtil.jav


Thanks guys, this fixed OFBIZ-10058

Jacques


Le 17/12/2017 à 21:06, Michael Brohl a écrit :

Hi Nicolas,

great, seems I missed the 2nd similar code block. I saw too much code in the 
recent days... ;-)

Thanks for taking care,

regards,

Michael


Am 17.12.17 um 21:02 schrieb Nicolas Malin:

Thanks Michael

I applied the same correction on the second one at 1818510.

Thanks for the works !

Cheers,

Nicolas


Le 17/12/2017 à 19:10, Michael Brohl a écrit :

Hi Nicolas,

thanks for reporting!

I guess that this is the reason why there was no logging at all. At r1818498 I 
added verbose logging.

Thanks,

Michael


Am 17.12.17 um 18:00 schrieb Nicolas Malin:

Hello Michael,

Le 13/12/2017 à 14:03, mbr...@apache.org a écrit :

--- 
ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/string/JuelConnector.java
 (original)
+++ 
ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/string/JuelConnector.java
 Wed Dec 13 13:03:03 2017
@@ -78,7 +78,9 @@ public class JuelConnector {
  Object base = null;
  try {
  base = prefix.eval(bindings, context);
-    } catch (Exception e) {}
+    } catch (Exception e) {
+    Debug.log(e, module);
+    }


With this commit, my logs are now massively populate by

2017-12-17 17:32:52,542 |main |JuelConnector |F| null
javax.el.PropertyNotFoundException: Cannot resolve identifier 'updateServiceCtx'
    at 
de.odysseus.el.tree.impl.ast.AstIdentifier.eval(AstIdentifier.java:93) 
~[juel-impl-2.2.7.jar:2.2.7]
    at 
org.apache.ofbiz.base.util.string.JuelConnector$ExtendedAstDot.setValue(JuelConnector.java:116)
 [ofbiz.jar:?]
    ...

I'm alone on this case ?
I propose, if you want display the exception, to replace all Debug.log(e, 
module); by
if (Debug.verboseOn()) {Debug.logVerbose("failed to  by " e.toString(), 
module); }

Like this we can display them without stacktrace when the verbose mode will be 
enable.

Cheers,
Nicolas

Re: svn commit: r1815119 - /ofbiz/ofbiz-framework/trunk/framework/start/src/main/java/org/apache/ofbiz /base/start/StartupControlPanel.java


You were right Michael,

Fixed at revision 1818514.

Like you "I saw too much code in the recent days..." ;-)
 ;)

Jacques


Le 17/12/2017 à 20:12, Michael Brohl a écrit :

Hi Jacques,

if I see it right, you have not implemented a try-with-resources block but simply moved the stream declaration inside the try block and removed the 
finally block. Please check.


Thanks,

Michael


Am 13.11.17 um 18:06 schrieb jler...@apache.org:

Author: jleroux
Date: Mon Nov 13 17:06:24 2017
New Revision: 1815119

URL: http://svn.apache.org/viewvc?rev=1815119&view=rev
Log:
Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.base.start.
(OFBIZ-9573)

No functional change, while reviewing r1811413
I noticed we can use a try-with-ress here

Modified:
ofbiz/ofbiz-framework/trunk/framework/start/src/main/java/org/apache/ofbiz/base/start/StartupControlPanel.java

Modified: 
ofbiz/ofbiz-framework/trunk/framework/start/src/main/java/org/apache/ofbiz/base/start/StartupControlPanel.java
URL: 
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/start/src/main/java/org/apache/ofbiz/base/start/StartupControlPanel.java?rev=1815119&r1=1815118&r2=1815119&view=diff

==
--- 
ofbiz/ofbiz-framework/trunk/framework/start/src/main/java/org/apache/ofbiz/base/start/StartupControlPanel.java
 (original)
+++ 
ofbiz/ofbiz-framework/trunk/framework/start/src/main/java/org/apache/ofbiz/base/start/StartupControlPanel.java
 Mon Nov 13 17:06:24 2017
@@ -150,21 +150,11 @@ final class StartupControlPanel {
  private static void loadGlobalOfbizSystemProperties(String 
globalOfbizPropertiesFileName) throws StartupException {
  String systemProperties = 
System.getProperty(globalOfbizPropertiesFileName);
  if (systemProperties != null) {
-    FileInputStream stream = null;
-    try {
-    stream = new FileInputStream(systemProperties);
-    System.getProperties().load(stream);
-    stream.close();
+    try { FileInputStream  stream = new 
FileInputStream(systemProperties);
+    System.getProperties().load(stream);
+    stream.close();
  } catch (IOException e) {
  throw new StartupException("Couldn't load global system 
props", e);
-    } finally {
-    try {
-    if (stream != null) {
-    stream.close();
-    }
-    } catch (IOException e) {
-    System.out.println("There was a problem while closing the 
Stream " + e);
-    }
  }
  }
  }

Re: buildbot failure in on ofbiz-trunk-framework-plugins

That's surely possible, I have used Jenkins in the past and it's the nice tool.

So we could indeed ask infra to take care of INFRA-15394, else we switch to
Jenkins.

But I'll not do it, so please feel free :)

Jacques

Le 17/12/2017 à 21:12, Michael Brohl a écrit :

With so much hassle using buildbot, would it be possible to set up another
build server like Jenkins?

We use it here at ecomify and have none of these issues with OFBiz.

Regards,

Michael

Am 17.12.17 um 21:06 schrieb Jacques Le Roux:

Ah also, normally Buildbot should only send email when the status change, from
good to bad or reverse.

And it does not always. It's done randomly (see email today at 13:15, 18:04, 20:14) and completely independent of our script, we don't decide on
this, Buildbot does.

I just wrote also that in INFRA-15394

Jacques

Le 17/12/2017 à 13:18, Jacques Le Roux a écrit :

Hi Taher,

I did not find something specific.

The message I try to convey is this is an external random condition, not
related to Buildbot or our script but the network+servers context.

From time to time (more often since the date I put in the Infra Jira, but I can't see a relation with changes then in our script and it was
happening before also) the tests fail and when I manually restart the same build they pass.

So for me it's not due to our script, which is only starting the tests, but to another conditions(/s?) on the network+servers context. Note that
we use 3 test servers.

Note also that it happens that the "svn up"' phase fails. I once asked Gavin and he the told me that in such case I simply have to manually
restart the tests...

That's when I learnt how to do it and that's what, among other things but
mostly, I want to document

Thanks to care!

Jacques

Le 17/12/2017 à 12:37, Taher Alkhateeb a écrit :

Hi Jacques, I still don't understand how you determined that it is
_not_ a buildbot scripting issue? I need that information in order to
isolate the cause of these annoying error messages. I find it unlikely
to be a genuine bug in buildbot and more likely a bug in our scripts.
So perhaps you can share what you found so that I focus my efforts in
the right place?

On Wed, Dec 13, 2017 at 9:07 PM, Jacques Le Roux
wrote:

Taher,

Look at
https://ci.apache.org/builders/ofbiz-trunk-framework-plugins?numbuilds=150

From time to time, when I find weird that a build fails on Buildbot but not
locally, I force a build on Buildbot manually (ie redo an existing commit)
and then it passes
Eg:
Dec 05 06:47

1817154 success #797

forced: by IRC user (privmsg): forces manual build after tests
errors Build successful
Dec 05 04:16 1817151 failure #796

The AnyBranchScheduler scheduler named 'on-ofbiz-framework-commit' triggered
this build Failed shell_4

Dec 08 19:40

1817550 success #805

The AnyBranchScheduler scheduler named 'on-ofbiz-framework-commit' triggered
this build Build successful
Dec 08 10:14 1817479 success #804

forced: by IRC user (privmsg): forces manual build after BuilBot
signaling a failure (OK locally) Build successful

Of course you can check there are no OFBiz commits between these forcings.
Remember we share SVN and Buildbot with other TLPs...

At contratrio, this one was a real issue I wanted to be sure about, see it
fails 2 times...
Dec 13 10:23

1817994 failure #869

forced: by IRC user (privmsg): forces manual build to check we
have a real error with testPerformFind Failed shell_4
Dec 13 09:23 1817989 failure #868

The AnyBranchScheduler scheduler named 'on-ofbiz-framework-commit' triggered
this build Failed shell_4

You can find the same on
https://ci.apache.org/builders/ofbiz-trunk-framework?numbuilds=150

BTW this was a good question and I'll add this info in the infra request.

I tend to forgot about how I do things. I'm really the kind of intuitive
people. But I can help myself when I need to help others :)

Jacques

Le 13/12/2017 à 17:12, Taher Alkhateeb a écrit :

How did you determine it's not the buildbot script?

On Wed, Dec 13, 2017 at 7:05 PM, Jacques Le Roux
wrote:

I fear it's not part of our BuildBot config, so I asked help from infra.
Maybe this can help

https://issues.apache.org/jira/servicedesk/customer/portal/1/INFRA-15394

Jacques

Le 13/12/2017 à 16:21, Taher Alkhateeb a écrit :

These error messages are becoming excessive and indicating a faulty
buildbot implementation. I

Re: Put the social networks icons above "Latest tweets" (OFBIZ-10050)


Forgot to mention: done with OFBIZ-10086

Jacques


Le 16/12/2017 à 14:57, Jacques Le Roux a écrit :

Le 16/12/2017 à 14:21, Taher Alkhateeb a écrit :

Social network icons are more appropriate in header than footer and the web
template allows it as I can remember.

I'll see that, thanks


I think twitter feeds are a nice feature in the website and it does not
make sense to remove them just because you're not familiar with how to code
your proposal.

The reason I explained below is

I often find myself waiting the site appears or completes because of this
part :/
And actually I think we can get rid of them w/o too much annoyance.

I'd have say sometimes instead of often and I can live with it.
What I see in general is sites depending more and more on 3rd parties services 
and waiting them to come.
Most of the time because these 3rd parties services also depend on ads network 
and such, it's a pain!

I suspect with coming no net neutrality this pain will increase...

Jacques





On Dec 16, 2017 3:37 PM, "Jacques Le Roux" 
wrote:

Le 14/12/2017 à 17:28, Jacques Le Roux a écrit :


Le 11/12/2017 à 13:29, Jacques Le Roux a écrit :


Hi,

I wanted to put the social networks icons above "Latest tweets" but it's
not as easy as I thought without breaking the layout.

Could someone with more knowledge with the site have a look please?

TIA

Jacques


I even wonder if we should not remove the Tweeter feeds from the site. I

often find myself waiting the site appears or completes because of this
part :/
And actually I think we can get rid of them w/o too much annoyance.

Jacques


Without answers in a week I'll remove the Tweeter feeds and just put links

to social networks

Jacques

Re: buildbot failure in on ofbiz-trunk-framework-plugins

With so much hassle using buildbot, would it be possible to set up 
another build server like Jenkins?


We use it here at ecomify and have none of these issues with OFBiz.

Regards,

Michael


Am 17.12.17 um 21:06 schrieb Jacques Le Roux:
Ah also, normally Buildbot should only send email when the status 
change, from good to bad or reverse.


And it does not always. It's done randomly (see email today at 13:15, 
18:04, 20:14) and completely independent of our script, we don't 
decide on this, Buildbot does.


I just wrote also that in INFRA-15394

Jacques


Le 17/12/2017 à 13:18, Jacques Le Roux a écrit :

Hi Taher,

I did not find something specific.

The message I try to convey is this is an external random condition, 
not related to Buildbot or our script but the network+servers context.


From time to time (more often since the date I put in the Infra Jira, 
but I can't see a relation with changes then in our script and it was 
happening before also) the tests fail and when I manually restart the 
same build they pass.


So for me it's not due to our script, which is only starting the 
tests, but to another conditions(/s?) on the network+servers context. 
Note that we use 3 test servers.


Note also that it happens that the "svn up"' phase fails. I once 
asked Gavin and he the told me that in such case I simply have to 
manually restart the tests...


That's when I learnt how to do it and that's what, among other things 
but mostly, I want to document


Thanks to care!

Jacques


Le 17/12/2017 à 12:37, Taher Alkhateeb a écrit :

Hi Jacques, I still don't understand how you determined that it is
_not_ a buildbot scripting issue? I need that information in order to
isolate the cause of these annoying error messages. I find it unlikely
to be a genuine bug in buildbot and more likely a bug in our scripts.
So perhaps you can share what you found so that I focus my efforts in
the right place?

On Wed, Dec 13, 2017 at 9:07 PM, Jacques Le Roux
 wrote:

Taher,

Look at
https://ci.apache.org/builders/ofbiz-trunk-framework-plugins?numbuilds=150 



 From time to time, when I find weird that a build fails on 
Buildbot but not
locally, I force a build on Buildbot manually (ie redo an existing 
commit)

and then it passes
Eg:
Dec 05 06:47

 1817154 success #797
 

forced: by IRC user  (privmsg): forces manual build after 
tests

errors Build successful
Dec 05 04:16    1817151 failure #796
 

The AnyBranchScheduler scheduler named 'on-ofbiz-framework-commit' 
triggered

this build Failed shell_4


Dec 08 19:40

 1817550 success #805
 

The AnyBranchScheduler scheduler named 'on-ofbiz-framework-commit' 
triggered

this build Build successful
Dec 08 10:14    1817479 success #804
 

forced: by IRC user  (privmsg): forces manual build after 
BuilBot

signaling a failure (OK locally) Build successful


Of course you can check there are no OFBiz commits between these 
forcings.

Remember we share SVN and Buildbot with other TLPs...

At contratrio, this one was a real issue I wanted to be sure about, 
see it

fails 2 times...
Dec 13 10:23

 1817994 failure #869
 

forced: by IRC user  (privmsg): forces manual build to 
check we

have a real error with testPerformFind Failed shell_4
Dec 13 09:23    1817989 failure #868
 

The AnyBranchScheduler scheduler named 'on-ofbiz-framework-commit' 
triggered

this build Failed shell_4


You can find the same on
https://ci.apache.org/builders/ofbiz-trunk-framework?numbuilds=150

BTW this was a good question and I'll add this info in the infra 
request.


I tend to forgot about how I do things. I'm really the kind of 
intuitive

people. But I can help myself when I need to help others :)

Jacques


Le 13/12/2017 à 17:12, Taher Alkhateeb a écrit :

How did you determine it's not the buildbot script?

On Wed, Dec 13, 2017 at 7:05 PM, Jacques Le Roux
 wrote:
I fear it's not part of our BuildBot config, so I asked help from 
infra.

Maybe this can help

https://issues.apache.org/jira/servicedesk/customer/portal/1/INFRA-15394 



Jacques



Le 13/12/2017 à 16:21, Taher Alkhateeb a écrit :

These error messages are becoming excessive and indicating a faulty
buildbot implementation. I would like to work on it. Is anyone
interested in helping me or has background information that might
help?

On Wed, Dec 13, 2017 at 5:36 PM,  wrote:

The Buildbot has detected a new failure on builder
ofbiz-trunk-framewo

Re: svn commit: r1818007 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/string: FlexibleStringExpander.java JuelConnector.java UelFunctions.java UelUtil.java


Hi Nicolas,

great, seems I missed the 2nd similar code block. I saw too much code in 
the recent days... ;-)


Thanks for taking care,

regards,

Michael


Am 17.12.17 um 21:02 schrieb Nicolas Malin:

Thanks Michael

I applied the same correction on the second one at 1818510.

Thanks for the works !

Cheers,

Nicolas


Le 17/12/2017 à 19:10, Michael Brohl a écrit :

Hi Nicolas,

thanks for reporting!

I guess that this is the reason why there was no logging at all. At 
r1818498 I added verbose logging.


Thanks,

Michael


Am 17.12.17 um 18:00 schrieb Nicolas Malin:

Hello Michael,

Le 13/12/2017 à 14:03, mbr...@apache.org a écrit :
--- 
ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/string/JuelConnector.java 
(original)
+++ 
ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/string/JuelConnector.java 
Wed Dec 13 13:03:03 2017

@@ -78,7 +78,9 @@ public class JuelConnector {
  Object base = null;
  try {
  base = prefix.eval(bindings, context);
-    } catch (Exception e) {}
+    } catch (Exception e) {
+    Debug.log(e, module);
+    }


With this commit, my logs are now massively populate by

2017-12-17 17:32:52,542 |main |JuelConnector |F| null
javax.el.PropertyNotFoundException: Cannot resolve identifier 
'updateServiceCtx'
    at 
de.odysseus.el.tree.impl.ast.AstIdentifier.eval(AstIdentifier.java:93) 
~[juel-impl-2.2.7.jar:2.2.7]
    at 
org.apache.ofbiz.base.util.string.JuelConnector$ExtendedAstDot.setValue(JuelConnector.java:116) 
[ofbiz.jar:?]

    ...

I'm alone on this case ?
I propose, if you want display the exception, to replace all 
Debug.log(e, module); by
if (Debug.verboseOn()) {Debug.logVerbose("failed to  by " 
e.toString(), module); }


Like this we can display them without stacktrace when the verbose 
mode will be enable.


Cheers,
Nicolas








smime.p7s
Description: S/MIME Cryptographic Signature

Re: buildbot failure in on ofbiz-trunk-framework-plugins

Ah also, normally Buildbot should only send email when the status change, from
good to bad or reverse.

And it does not always. It's done randomly (see email today at 13:15, 18:04, 20:14) and completely independent of our script, we don't decide on this,
Buildbot does.

I just wrote also that in INFRA-15394

Jacques

Le 17/12/2017 à 13:18, Jacques Le Roux a écrit :

Hi Taher,

I did not find something specific.

The message I try to convey is this is an external random condition, not
related to Buildbot or our script but the network+servers context.

So for me it's not due to our script, which is only starting the tests, but to another conditions(/s?) on the network+servers context. Note that we
use 3 test servers.

Note also that it happens that the "svn up"' phase fails. I once asked Gavin and he the told me that in such case I simply have to manually restart
the tests...

That's when I learnt how to do it and that's what, among other things but
mostly, I want to document

Thanks to care!

Jacques

Le 17/12/2017 à 12:37, Taher Alkhateeb a écrit :

On Wed, Dec 13, 2017 at 9:07 PM, Jacques Le Roux
wrote:

Taher,

Look at
https://ci.apache.org/builders/ofbiz-trunk-framework-plugins?numbuilds=150

From time to time, when I find weird that a build fails on Buildbot but not
locally, I force a build on Buildbot manually (ie redo an existing commit)
and then it passes
Eg:
Dec 05 06:47

1817154 success #797

forced: by IRC user (privmsg): forces manual build after tests
errors Build successful
Dec 05 04:16 1817151 failure #796

The AnyBranchScheduler scheduler named 'on-ofbiz-framework-commit' triggered
this build Failed shell_4

Dec 08 19:40

1817550 success #805

The AnyBranchScheduler scheduler named 'on-ofbiz-framework-commit' triggered
this build Build successful
Dec 08 10:14 1817479 success #804

forced: by IRC user (privmsg): forces manual build after BuilBot
signaling a failure (OK locally) Build successful

Of course you can check there are no OFBiz commits between these forcings.
Remember we share SVN and Buildbot with other TLPs...

At contratrio, this one was a real issue I wanted to be sure about, see it
fails 2 times...
Dec 13 10:23

1817994 failure #869

forced: by IRC user (privmsg): forces manual build to check we
have a real error with testPerformFind Failed shell_4
Dec 13 09:23 1817989 failure #868

The AnyBranchScheduler scheduler named 'on-ofbiz-framework-commit' triggered
this build Failed shell_4

You can find the same on
https://ci.apache.org/builders/ofbiz-trunk-framework?numbuilds=150

BTW this was a good question and I'll add this info in the infra request.

I tend to forgot about how I do things. I'm really the kind of intuitive
people. But I can help myself when I need to help others :)

Jacques

Le 13/12/2017 à 17:12, Taher Alkhateeb a écrit :

How did you determine it's not the buildbot script?

On Wed, Dec 13, 2017 at 7:05 PM, Jacques Le Roux
wrote:

I fear it's not part of our BuildBot config, so I asked help from infra.
Maybe this can help

https://issues.apache.org/jira/servicedesk/customer/portal/1/INFRA-15394

Jacques

Le 13/12/2017 à 16:21, Taher Alkhateeb a écrit :

These error messages are becoming excessive and indicating a faulty
buildbot implementation. I would like to work on it. Is anyone
interested in helping me or has background information that might
help?

On Wed, Dec 13, 2017 at 5:36 PM, wrote:

The Buildbot has detected a new failure on builder
ofbiz-trunk-framework-plugins while building . Full details are
available
at:

https://ci.apache.org/builders/ofbiz-trunk-framework-plugins/builds/877

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named
'on-ofbiz-framework-c

Re: svn commit: r1818007 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/string: FlexibleStringExpander.java JuelConnector.java UelFunctions.java UelUtil.java


Thanks Michael

I applied the same correction on the second one at 1818510.

Thanks for the works !

Cheers,

Nicolas


Le 17/12/2017 à 19:10, Michael Brohl a écrit :

Hi Nicolas,

thanks for reporting!

I guess that this is the reason why there was no logging at all. At 
r1818498 I added verbose logging.


Thanks,

Michael


Am 17.12.17 um 18:00 schrieb Nicolas Malin:

Hello Michael,

Le 13/12/2017 à 14:03, mbr...@apache.org a écrit :
--- 
ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/string/JuelConnector.java 
(original)
+++ 
ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/string/JuelConnector.java 
Wed Dec 13 13:03:03 2017

@@ -78,7 +78,9 @@ public class JuelConnector {
  Object base = null;
  try {
  base = prefix.eval(bindings, context);
-    } catch (Exception e) {}
+    } catch (Exception e) {
+    Debug.log(e, module);
+    }


With this commit, my logs are now massively populate by

2017-12-17 17:32:52,542 |main |JuelConnector |F| null
javax.el.PropertyNotFoundException: Cannot resolve identifier 
'updateServiceCtx'
    at 
de.odysseus.el.tree.impl.ast.AstIdentifier.eval(AstIdentifier.java:93) 
~[juel-impl-2.2.7.jar:2.2.7]
    at 
org.apache.ofbiz.base.util.string.JuelConnector$ExtendedAstDot.setValue(JuelConnector.java:116) 
[ofbiz.jar:?]

    ...

I'm alone on this case ?
I propose, if you want display the exception, to replace all 
Debug.log(e, module); by
if (Debug.verboseOn()) {Debug.logVerbose("failed to  by " 
e.toString(), module); }


Like this we can display them without stacktrace when the verbose 
mode will be enable.


Cheers,
Nicolas

Re: svn commit: r1815119 - /ofbiz/ofbiz-framework/trunk/framework/start/src/main/java/org/apache/ofbiz/base/start/StartupControlPanel.java


Hi Jacques,

if I see it right, you have not implemented a try-with-resources block 
but simply moved the stream declaration inside the try block and removed 
the finally block. Please check.


Thanks,

Michael


Am 13.11.17 um 18:06 schrieb jler...@apache.org:

Author: jleroux
Date: Mon Nov 13 17:06:24 2017
New Revision: 1815119

URL: http://svn.apache.org/viewvc?rev=1815119&view=rev
Log:
Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.base.start.
(OFBIZ-9573)

No functional change, while reviewing r1811413
I noticed we can use a try-with-ress here

Modified:
 
ofbiz/ofbiz-framework/trunk/framework/start/src/main/java/org/apache/ofbiz/base/start/StartupControlPanel.java

Modified: 
ofbiz/ofbiz-framework/trunk/framework/start/src/main/java/org/apache/ofbiz/base/start/StartupControlPanel.java
URL: 
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/start/src/main/java/org/apache/ofbiz/base/start/StartupControlPanel.java?rev=1815119&r1=1815118&r2=1815119&view=diff
==
--- 
ofbiz/ofbiz-framework/trunk/framework/start/src/main/java/org/apache/ofbiz/base/start/StartupControlPanel.java
 (original)
+++ 
ofbiz/ofbiz-framework/trunk/framework/start/src/main/java/org/apache/ofbiz/base/start/StartupControlPanel.java
 Mon Nov 13 17:06:24 2017
@@ -150,21 +150,11 @@ final class StartupControlPanel {
  private static void loadGlobalOfbizSystemProperties(String 
globalOfbizPropertiesFileName) throws StartupException {
  String systemProperties = 
System.getProperty(globalOfbizPropertiesFileName);
  if (systemProperties != null) {
-FileInputStream stream = null;
-try {
-stream = new FileInputStream(systemProperties);
-System.getProperties().load(stream);
-stream.close();
+try { FileInputStream  stream = new 
FileInputStream(systemProperties);
+System.getProperties().load(stream);
+stream.close();
  } catch (IOException e) {
  throw new StartupException("Couldn't load global system 
props", e);
-} finally {
-try {
-if (stream != null) {
-stream.close();
-}
-} catch (IOException e) {
-System.out.println("There was a problem while closing the 
Stream " + e);
-}
  }
  }
  }







smime.p7s
Description: S/MIME Cryptographic Signature

Re: svn commit: r1818007 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/string: FlexibleStringExpander.java JuelConnector.java UelFunctions.java UelUtil.java


Hi Nicolas,

thanks for reporting!

I guess that this is the reason why there was no logging at all. At 
r1818498 I added verbose logging.


Thanks,

Michael


Am 17.12.17 um 18:00 schrieb Nicolas Malin:

Hello Michael,

Le 13/12/2017 à 14:03, mbr...@apache.org a écrit :
--- 
ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/string/JuelConnector.java 
(original)
+++ 
ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/string/JuelConnector.java 
Wed Dec 13 13:03:03 2017

@@ -78,7 +78,9 @@ public class JuelConnector {
  Object base = null;
  try {
  base = prefix.eval(bindings, context);
-    } catch (Exception e) {}
+    } catch (Exception e) {
+    Debug.log(e, module);
+    }


With this commit, my logs are now massively populate by

2017-12-17 17:32:52,542 |main |JuelConnector |F| null
javax.el.PropertyNotFoundException: Cannot resolve identifier 
'updateServiceCtx'
    at 
de.odysseus.el.tree.impl.ast.AstIdentifier.eval(AstIdentifier.java:93) 
~[juel-impl-2.2.7.jar:2.2.7]
    at 
org.apache.ofbiz.base.util.string.JuelConnector$ExtendedAstDot.setValue(JuelConnector.java:116) 
[ofbiz.jar:?]

    ...

I'm alone on this case ?
I propose, if you want display the exception, to replace all 
Debug.log(e, module); by
if (Debug.verboseOn()) {Debug.logVerbose("failed to  by " 
e.toString(), module); }


Like this we can display them without stacktrace when the verbose mode 
will be enable.


Cheers,
Nicolas




smime.p7s
Description: S/MIME Cryptographic Signature

Re: svn commit: r1818007 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/string: FlexibleStringExpander.java JuelConnector.java UelFunctions.java UelUtil.java


Hello Michael,

Le 13/12/2017 à 14:03, mbr...@apache.org a écrit :

--- 
ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/string/JuelConnector.java
 (original)
+++ 
ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/string/JuelConnector.java
 Wed Dec 13 13:03:03 2017
@@ -78,7 +78,9 @@ public class JuelConnector {
  Object base = null;
  try {
  base = prefix.eval(bindings, context);
-} catch (Exception e) {}
+} catch (Exception e) {
+Debug.log(e, module);
+}


With this commit, my logs are now massively populate by

2017-12-17 17:32:52,542 |main |JuelConnector |F| null
javax.el.PropertyNotFoundException: Cannot resolve identifier 
'updateServiceCtx'
    at 
de.odysseus.el.tree.impl.ast.AstIdentifier.eval(AstIdentifier.java:93) 
~[juel-impl-2.2.7.jar:2.2.7]
    at 
org.apache.ofbiz.base.util.string.JuelConnector$ExtendedAstDot.setValue(JuelConnector.java:116) 
[ofbiz.jar:?]

    ...

I'm alone on this case ?
I propose, if you want display the exception, to replace all 
Debug.log(e, module); by
if (Debug.verboseOn()) {Debug.logVerbose("failed to  by " 
e.toString(), module); }


Like this we can display them without stacktrace when the verbose mode 
will be enable.


Cheers,
Nicolas

Re: WebSite and webapp


Hello, I forgot this issue on my old git branch :)

It's already good so I commited it on trunk at rev 1818494, I created an 
issue OFBIZ-10088 for the report ;)


Nicolas


Le 24/09/2016 à 07:42, Nicolas Malin a écrit :

Hi Michael,


Le 23/09/2016 à 22:00, Michael Brohl a écrit :

Hi Nicolas,

thanks for sharing!

We never had to extend the WebSite entity to implement Apache 
Webserer/OFBiz Tomcat connections, but I'm not sure if I fully 
understand your setting and the problem you have solved.

I understand, it's complex to explain without picture support


Are the webserver myEcommerce.mydomaine.com and OFBiz 
ofbiz.privatedomaine/ecommerce on the same server?

No each service are manage by a dedicate server

Nicolas


Regards,

Michael


Am 23.09.16 um 16:15 schrieb Nicolas Malin:


Hello,

For a customer site, I improved the code of RequestHandler.makeLink 
to manage a web site with an apache httpd at reverse proxy that 
force all request to use a specific webapp


Example :

myEcommerce.mydomaine.com redirect all to 
ofbiz.privatedomaine/ecommerce


Natively, all works fine with some parameters on web.xml and 
controller.xml but each link return are setted like that 
myEcommerce.mydomaine.com/ecommerce, called by apache httpd to ofbiz 
by ofbiz.privatedomaine/ecommerce/ecommerce and traducted by ofbiz 
by ERROR ecommerce request-map not found ;)


To solve the situation, I extended WebSite entity with attribute 
webappPath, init to / for websiteId ecommerce ofbiz instance and 
/ecommerce for other websiteId liked to other ofbiz instance (dev, 
back) without apache httpd with limited reverse-proxy.


It's work this 2 months without issues and I will interest to 
sharing it because I'm sure it exist an other way to solve and it's 
pleasure to compare each, and if not, I can contribute it on trunk :)


Nicolas

--
logoNrd 
    Nicolas Malin
The apache way  : *Openness* Technical 
decisions are made publicly

informat...@nereide.fr
8 rue des Déportés 37000 TOURS, 02 47 50 30 54

Apache OFBiz |The Apache Way 
|ofbiz-fr 
|réseau LE

Re: buildbot failure in on ofbiz-trunk-framework-plugins