Re: buildbot failure in on ofbiz-trunk-framework-plugins

2017-12-31 Thread Jacques Le Roux 

OK, I made another review, put a comment in INFRA-15394, reopened but did not 
revert Gavin's commit

To be discussed...

Jacques


Le 31/12/2017 à 23:50, Jacques Le Roux a écrit :

Thanks for your help

Jacques


Le 31/12/2017 à 15:06, Taher Alkhateeb a écrit :

So let's examine what was done here:
- You broke buildbot with a faulty commit in r1006626 that was later
fixed by gavin in INFRA-15394 in revision r1023028
- As a result, hundreds of messages spammed our mailing list from buildbot
- You insisted that nothing is wrong with the buildbot script
throughout this thread and when I asked you why do you believe that,
you theorized that it was related to network and infrastructure
without any justification to your reasoning.
- You wasted my time
- You wasted INFRA's time
- You wasted your time

Quite honestly, based on your lack of knowledge, I'm not reassured by
your statement "I'm confident". It seems you did not understand the
problem at all and just came up with theories while insisting nothing
is wrong with buildbot scripts. I hope you exercise more caution and
scrutiny in the future.

On Sun, Dec 31, 2017 at 10:23 AM, Jacques Le Roux
 wrote:

I think you were were right Taher, Gavin just removed a duplicate
declaration of ofbiz-trunk-framework-plugins, see INFRA-15394

Let's see, but I'm confident

Jacques


Le 13/12/2017 à 16:21, Taher Alkhateeb a écrit :

These error messages are becoming excessive and indicating a faulty
buildbot implementation. I would like to work on it. Is anyone
interested in helping me or has background information that might
help?

On Wed, Dec 13, 2017 at 5:36 PM,  wrote:

The Buildbot has detected a new failure on builder
ofbiz-trunk-framework-plugins while building . Full details are available
at:

https://ci.apache.org/builders/ofbiz-trunk-framework-plugins/builds/877

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named
'on-ofbiz-framework-commit' triggered this build
Build Source Stamp: [branch ofbiz/ofbiz-framework/trunk] 1818020
Blamelist: jleroux

BUILD FAILED: failed shell_4

Sincerely,
   -The Buildbot

Re: buildbot failure in on ofbiz-trunk-framework-plugins

2017-12-31 Thread Jacques Le Roux 

Thanks for your help

Jacques


Le 31/12/2017 à 15:06, Taher Alkhateeb a écrit :

So let's examine what was done here:
- You broke buildbot with a faulty commit in r1006626 that was later
fixed by gavin in INFRA-15394 in revision r1023028
- As a result, hundreds of messages spammed our mailing list from buildbot
- You insisted that nothing is wrong with the buildbot script
throughout this thread and when I asked you why do you believe that,
you theorized that it was related to network and infrastructure
without any justification to your reasoning.
- You wasted my time
- You wasted INFRA's time
- You wasted your time

Quite honestly, based on your lack of knowledge, I'm not reassured by
your statement "I'm confident". It seems you did not understand the
problem at all and just came up with theories while insisting nothing
is wrong with buildbot scripts. I hope you exercise more caution and
scrutiny in the future.

On Sun, Dec 31, 2017 at 10:23 AM, Jacques Le Roux
 wrote:

I think you were were right Taher, Gavin just removed a duplicate
declaration of ofbiz-trunk-framework-plugins, see INFRA-15394

Let's see, but I'm confident

Jacques


Le 13/12/2017 à 16:21, Taher Alkhateeb a écrit :

These error messages are becoming excessive and indicating a faulty
buildbot implementation. I would like to work on it. Is anyone
interested in helping me or has background information that might
help?

On Wed, Dec 13, 2017 at 5:36 PM,   wrote:

The Buildbot has detected a new failure on builder
ofbiz-trunk-framework-plugins while building . Full details are available
at:

https://ci.apache.org/builders/ofbiz-trunk-framework-plugins/builds/877

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named
'on-ofbiz-framework-commit' triggered this build
Build Source Stamp: [branch ofbiz/ofbiz-framework/trunk] 1818020
Blamelist: jleroux

BUILD FAILED: failed shell_4

Sincerely,
   -The Buildbot

Re: “ID” instead of "Id" for User Interface

2017-12-31 Thread James Yong 
Hi Jacques,

I have created a JIRA issue for this at 
https://issues.apache.org/jira/browse/OFBIZ-10131

Thanks,
James Yong

On 2017-12-30 05:00, Jacques Le Roux  wrote: 
> Labels are not programming so following
> 
> https://english.stackexchange.com/questions/101248/how-should-the-abbreviation-for-identifier-be-capitalized
> 
> https://forum.wordreference.com/threads/abbreviation-id-identification-no.685714/
> 
> I'd say yes, though this is counter-intuitive for a Frenchman :)
> 
> Jacques
> 
> 
> Le 24/12/2017 à 15:49, James Yong a écrit :
> > Hi All,
> >
> > Not sure if this has been discussed before.
> > ID is correct abbreviation for identity, in English.
> >
> > Will make the change on the labels if there is no objection.
> >
> > Regards,
> > James Yong
> >
> 
>

Re: svn commit: r1819730 [1/6] - in /ofbiz/ofbiz-framework/trunk/applications: content/src/main/java/org/apache/ofbiz/content/ content/src/main/java/org/apache/ofbiz/content/compdoc/ content/src/main/

2017-12-31 Thread Michael Brohl 
I have not the time to look at this further now but some changes seem to 
change the business logic, e.g. by returning an "error" result in events 
where they did not before, same in services. It makes a difference in 
both the controller logic as well as in the service engine logic.


This seems not to be a simple refactoring and we should have some 
thorough testing before this goes into the codebase.


Regards,

Michael


Am 31.12.17 um 15:11 schrieb Taher Alkhateeb:

I don't know what the rest of the team thinks, but I am really worried
from this commit. It is one of those mass updates which I constantly
warn against.

Can you please clarify what kind of testing was done against all the
services that were updated and the context of each service?

On Sun, Dec 31, 2017 at 2:11 PM,   wrote:

Author: jleroux
Date: Sun Dec 31 11:11:46 2017
New Revision: 1819730

URL: http://svn.apache.org/viewvc?rev=1819730=rev
Log:
Improved: Handle service response effectively
(OFBIZ-9981)

As per discussion on Dev ML:
==
Every service calling from java/groovy must handle errors by service util
methods such as isError, returnError etc.
and similarly in case of XML

Re: svn commit: r1819730 [1/6] - in /ofbiz/ofbiz-framework/trunk/applications: content/src/main/java/org/apache/ofbiz/content/ content/src/main/java/org/apache/ofbiz/content/compdoc/ content/src/main/

2017-12-31 Thread Taher Alkhateeb 
I don't know what the rest of the team thinks, but I am really worried
from this commit. It is one of those mass updates which I constantly
warn against.

Can you please clarify what kind of testing was done against all the
services that were updated and the context of each service?

On Sun, Dec 31, 2017 at 2:11 PM,   wrote:
> Author: jleroux
> Date: Sun Dec 31 11:11:46 2017
> New Revision: 1819730
>
> URL: http://svn.apache.org/viewvc?rev=1819730=rev
> Log:
> Improved: Handle service response effectively
> (OFBIZ-9981)
>
> As per discussion on Dev ML:
> ==
> Every service calling from java/groovy must handle errors by service util
> methods such as isError, returnError etc.
> and similarly in case of XML  to make sure service was executed successfully.
>
> Apart from this, one suggestion is to include *Debug.logError* in
> *ServiceUtil.returnProblem* so that in case of any error occurred and handled,
> it will always be logged on the console.
> ==
>
> jleroux: this is the applications part with some slight changes
>
> Thanks: Suraj Khurana
>
> Modified:
> 
> ofbiz/ofbiz-framework/trunk/applications/content/src/main/java/org/apache/ofbiz/content/ContentManagementEvents.java
> 
> ofbiz/ofbiz-framework/trunk/applications/content/src/main/java/org/apache/ofbiz/content/ContentManagementServices.java
> 
> ofbiz/ofbiz-framework/trunk/applications/content/src/main/java/org/apache/ofbiz/content/ConvertTree.java
> 
> ofbiz/ofbiz-framework/trunk/applications/content/src/main/java/org/apache/ofbiz/content/compdoc/CompDocEvents.java
> 
> ofbiz/ofbiz-framework/trunk/applications/content/src/main/java/org/apache/ofbiz/content/content/ContentPermissionServices.java
> 
> ofbiz/ofbiz-framework/trunk/applications/content/src/main/java/org/apache/ofbiz/content/content/ContentServices.java
> 
> ofbiz/ofbiz-framework/trunk/applications/content/src/main/java/org/apache/ofbiz/content/content/ContentWorker.java
> 
> ofbiz/ofbiz-framework/trunk/applications/content/src/main/java/org/apache/ofbiz/content/content/UploadContentAndImage.java
> 
> ofbiz/ofbiz-framework/trunk/applications/content/src/main/java/org/apache/ofbiz/content/data/DataEvents.java
> 
> ofbiz/ofbiz-framework/trunk/applications/content/src/main/java/org/apache/ofbiz/content/data/DataResourceWorker.java
> 
> ofbiz/ofbiz-framework/trunk/applications/content/src/main/java/org/apache/ofbiz/content/layout/LayoutEvents.java
> 
> ofbiz/ofbiz-framework/trunk/applications/content/src/main/java/org/apache/ofbiz/content/survey/PdfSurveyServices.java
> 
> ofbiz/ofbiz-framework/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/bom/BOMHelper.java
> 
> ofbiz/ofbiz-framework/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/bom/BOMNode.java
> 
> ofbiz/ofbiz-framework/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/bom/BOMServices.java
> 
> ofbiz/ofbiz-framework/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ProductionRun.java
> 
> ofbiz/ofbiz-framework/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ProductionRunEvents.java
> 
> ofbiz/ofbiz-framework/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
> 
> ofbiz/ofbiz-framework/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/mrp/MrpServices.java
> 
> ofbiz/ofbiz-framework/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/mrp/ProposedOrder.java
> 
> ofbiz/ofbiz-framework/trunk/applications/marketing/src/main/java/org/apache/ofbiz/sfa/vcard/VCard.java
> 
> ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/OrderManagerEvents.java
> 
> ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/order/OrderChangeHelper.java
> 
> ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/order/OrderEvents.java
> 
> ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/order/OrderLookupServices.java
> 
> ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/order/OrderReturnServices.java
> 
> ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/order/OrderServices.java
> 
> ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/quote/QuoteServices.java
> 
> ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/requirement/RequirementServices.java
> 
> ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/CheckOutEvents.java
> 
>

Re: buildbot failure in on ofbiz-trunk-framework-plugins

2017-12-31 Thread Taher Alkhateeb 
So let's examine what was done here:
- You broke buildbot with a faulty commit in r1006626 that was later
fixed by gavin in INFRA-15394 in revision r1023028
- As a result, hundreds of messages spammed our mailing list from buildbot
- You insisted that nothing is wrong with the buildbot script
throughout this thread and when I asked you why do you believe that,
you theorized that it was related to network and infrastructure
without any justification to your reasoning.
- You wasted my time
- You wasted INFRA's time
- You wasted your time

Quite honestly, based on your lack of knowledge, I'm not reassured by
your statement "I'm confident". It seems you did not understand the
problem at all and just came up with theories while insisting nothing
is wrong with buildbot scripts. I hope you exercise more caution and
scrutiny in the future.

On Sun, Dec 31, 2017 at 10:23 AM, Jacques Le Roux
 wrote:
> I think you were were right Taher, Gavin just removed a duplicate
> declaration of ofbiz-trunk-framework-plugins, see INFRA-15394
>
> Let's see, but I'm confident
>
> Jacques
>
>
> Le 13/12/2017 à 16:21, Taher Alkhateeb a écrit :
>>
>> These error messages are becoming excessive and indicating a faulty
>> buildbot implementation. I would like to work on it. Is anyone
>> interested in helping me or has background information that might
>> help?
>>
>> On Wed, Dec 13, 2017 at 5:36 PM,   wrote:
>>>
>>> The Buildbot has detected a new failure on builder
>>> ofbiz-trunk-framework-plugins while building . Full details are available
>>> at:
>>>
>>> https://ci.apache.org/builders/ofbiz-trunk-framework-plugins/builds/877
>>>
>>> Buildbot URL: https://ci.apache.org/
>>>
>>> Buildslave for this Build: silvanus_ubuntu
>>>
>>> Build Reason: The AnyBranchScheduler scheduler named
>>> 'on-ofbiz-framework-commit' triggered this build
>>> Build Source Stamp: [branch ofbiz/ofbiz-framework/trunk] 1818020
>>> Blamelist: jleroux
>>>
>>> BUILD FAILED: failed shell_4
>>>
>>> Sincerely,
>>>   -The Buildbot
>>>
>>>
>>>
>