Re: Avoiding to log Uel stacktraces (was: svn commit: r1867635 - /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/string/UelFunctions.java)
Hello Mathieu ! Done, thanks for your review, i hope it is more clear. Gil Le 16:23 - vendredi 27 sept., Mathieu Lirzin a écrit : > Hello Gil, > > p...@apache.org writes: > > > Author: pgil > > Date: Fri Sep 27 13:52:43 2019 > > New Revision: 1867635 > > > > URL: http://svn.apache.org/viewvc?rev=1867635&view=rev > > Log: > > Improved: Refactor UelFunctions.java to remove error management via > > Exception > > (OFBIZ-11213) > > > > This refacto was done to avoid logging stackTrace exception, when it is > > possible > > to manage it without exception. > > The "avoid logging stackTrace exception" part of your commit message > gives the impression that the motivation for this rewrite is to hide > programming errors inside Uel and not necessarily to make the > implementation more understandeable. > > Can you give more context regarding this issue of unwanted/unnecessary > logged stacktraces and explain why you choose the solution of silently > hiding the "stacktrace" instead of fixing the code inside the Uel? > > Thanks. > > -- > Mathieu Lirzin > GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
Avoiding to log Uel stacktraces (was: svn commit: r1867635 - /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/string/UelFunctions.java)
Hello Gil, p...@apache.org writes: > Author: pgil > Date: Fri Sep 27 13:52:43 2019 > New Revision: 1867635 > > URL: http://svn.apache.org/viewvc?rev=1867635&view=rev > Log: > Improved: Refactor UelFunctions.java to remove error management via Exception > (OFBIZ-11213) > > This refacto was done to avoid logging stackTrace exception, when it is > possible > to manage it without exception. The "avoid logging stackTrace exception" part of your commit message gives the impression that the motivation for this rewrite is to hide programming errors inside Uel and not necessarily to make the implementation more understandeable. Can you give more context regarding this issue of unwanted/unnecessary logged stacktraces and explain why you choose the solution of silently hiding the "stacktrace" instead of fixing the code inside the Uel? Thanks. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
Re: Welcome Pranay Pandey as a new PMC member
Congratulations and Welcome, Pranay! Michael Am 24.09.19 um 17:36 schrieb Jacques Le Roux: The OFBiz PMC has invited Pranay Pandey to become a new member of the committee and we are glad to announce that he has accepted the nomination. Welcome on board Pranay! Jacques (on behalf of the OFBiz PMC) smime.p7s Description: S/MIME Cryptographic Signature
Re: buildbot failure in on ofbizTrunkFramework
works well from my part On 9/27/19 9:54 AM, build...@apache.org wrote: The Buildbot has detected a new failure on builder ofbizTrunkFramework while building . Full details are available at: https://ci.apache.org/builders/ofbizTrunkFramework/builds/1081 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf945_ubuntu Build Reason: The AnyBranchScheduler scheduler named 'onTrunkFrameworkCommit' triggered this build Build Source Stamp: [branch ofbiz/ofbiz-framework/trunk] 1867620 Blamelist: nmalin BUILD FAILED: failed shell_2 Sincerely, -The Buildbot
Re: Welcome Pranay Pandey as a new PMC member
Pranay, welcome on board! Jacopo On Tue, Sep 24, 2019 at 5:37 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > The OFBiz PMC has invited Pranay Pandey to become a new member of the > committee and we are glad to announce that he has accepted the nomination. > > Welcome on board Pranay! > > Jacques (on behalf of the OFBiz PMC) > >
Re: Welcome Pranay Pandey as a new PMC member
Congratulations Pranay. On Tue, Sep 24, 2019 at 5:37 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > The OFBiz PMC has invited Pranay Pandey to become a new member of the > committee and we are glad to announce that he has accepted the nomination. > > Welcome on board Pranay! > > Jacques (on behalf of the OFBiz PMC) > >
