Re: New Helveticus theme as default
Hi, OK, no problems. For Eugen's concern, maybe it's possible to have several colours like with Rainbow Stone? Jacques Le 07/07/2021 à 09:07, Nicolas Malin a écrit : Hello, I suggest to wait some week, Marine who create this theme is currently off. I will share your remark upon her return. Nicolas On 07/07/2021 07:47, Eugen Stan wrote: The new theme looks good, the only thing that bothers me is the light blue text on white background - which is not very readable, esp. in high resolution (1080p). See here a screen capture: https://i.postimg.cc/HxcFKLt1/Captur-de-ecran-de-la-2021-07-07-08-41-31.png . I tried it on laptop 14" screen and also on a DELL desktop monitor. I think the issue is with the color contrast (light blue + white background) + small text on the accounting app main page.
Re: New Helveticus theme as default
Hello, I suggest to wait some week, Marine who create this theme is currently off. I will share your remark upon her return. Nicolas On 07/07/2021 07:47, Eugen Stan wrote: > The new theme looks good, the only thing that bothers me is the light > blue text on white background - which is not very readable, esp. in > high resolution (1080p). > > > See here a screen capture: > https://i.postimg.cc/HxcFKLt1/Captur-de-ecran-de-la-2021-07-07-08-41-31.png > . > > I tried it on laptop 14" screen and also on a DELL desktop monitor. > > I think the issue is with the color contrast (light blue + white > background) + small text on the accounting app main page. >
Re: buildbot failure in on ofbizTrunkFrameworkPlugins
Thanks Jacques for your look ! On 03/07/2021 19:35, Jacques Le Roux wrote: > Oops, actually forgot to pull before testing :/ > > Fixed now > > Le 03/07/2021 à 11:40, Jacques Le Roux a écrit : >> Hi Nicolas, >> >> Nevermind, I can't reproduce locally either and the error message >> "Each variable declaration must be in its own statement" concerns >> >> https://ci.apache.org/projects/ofbiz/logs/trunk/checkstyle.html#f-/home/buildslave/slave/ofbizTrunkFrameworkPlugins/build/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroCommonRenderer.java >> >> >> That does not make sense when you look at line 64. >> >> We will see if Checkstyle repeats that later ;) >> >> Thanks >> >> Jacques >> >> Le 02/07/2021 à 21:12, Nicolas Malin a écrit : >>> Non mais sérieux ! Why my local the check is good and not on build bot, >>> -_-' I know, it hate me ^^ >>> >>> Nicolas >>> >>> On 02/07/2021 19:04, build...@apache.org wrote: The Buildbot has detected a new failure on builder ofbizTrunkFrameworkPlugins while building ofbiz-framework. Full details are available at: https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/2135 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf945_ubuntu Build Reason: downstream Build Source Stamp: [branch trunk] 7120cf7d5f264830385105dea233c7f56998242e Blamelist: Nicolas Malin BUILD FAILED: failed check Sincerely, -The Buildbot
Re: Clojure service engine proposal for inclusion
Hello,
Thanks for this detail email and your works.
I'm not opposed to load closure in OFBiz code base for same reason that
you exposed.
For success the inclusion, I suggest to rename the namespace to
org.apache.ofbiz, add test one framework/service/testdef and an example
"hello world" service.
Thanks Eugen !
Nicolas
On 04/07/2021 14:59, Eugen Stan wrote:
> Hello,
>
> I've implemented a clojure engine for OFBiz and I would like to
> contribute this to OFBiz repo.
>
> It was simpler than I thought.
>
> NOTE: Right now the code is bundled with the ofbiz-repl-plugin in
> https://github.com/netdava/ofbiz-clojure-repl .
> Code is a draft and will be cleaned up for inclusion.
>
> == Why?
>
> * Allow OFBiz to use clojure libraries and ecosystem
> * Allow Clojure developers to work with OFBiz in a friendlier way
> * Does not increase OFBiz complexity
> * Clojure is also dynamic like Groovy
> * Enables powerful OFBiz administration and development via Clojure
> Repl (work in progress, I have working babshka scripts that I can use
> to manage OFBiz and call services remotely via REPL)
>
> == The code
>
> Code is based off of java engine:
> https://github.com/netdava/ofbiz-clojure-repl/blob/main/src/main/java/com/netdava/ofbiz/clojure/ClojureEngine.java
>
>
> Service it is defined the usual way:
> https://github.com/netdava/ofbiz-clojure-repl/blob/main/servicedef/services.xml
>
>
> A sample service looks like this
> https://github.com/netdava/ofbiz-clojure-repl/blob/main/src/main/resources/com/netdava/ofbiz/clojure/sample.clj
>
> Copy pasting code snippets from above links:
>
> name="com.netdava.ofbiz.clojure.sample/clojure-test-service"
> engine="clojure"
> location="com.netdava.ofbiz.clojure.sample"
> invoke="clojure-test-service" export="true"
> max-retry="3" use-transaction="false">
>
> Clojure repl service. Get service stats.
>
>
>
>
>
> (ns com.netdava.ofbiz.clojure.sample
> (:gen-class)
> (:import org.apache.ofbiz.service.DispatchContext))
>
> (defn clojure-test-service [^DispatchContext dctx ^java.util.Map ctx]
> (println "test " dctx " " ctx)
> {"status" {"msg" "Hello OFBiz from clojure"}})
>
> The service prints contexts and returns a clojure map with "status"
> key and a map as a value (that implements java.util.Map).
>
>
> To test out the code, clone ofbiz-clojure-repl into plugins/
> and apply two changes: clojars maven repo and the service engine
> definition.
>
> https://github.com/ieugen/ofbiz-framework/commit/d50254ed57358544c8765a2647ec4bbdd3baf6a5
>
> https://github.com/ieugen/ofbiz-framework/commit/e58ad5ed9d102210a1f1363e8337cef486cf999e
>
>
>
> Regards,
