[jira] Commented: (OFBIZ-3329) commonext component has dependency on party management component
[ https://issues.apache.org/jira/browse/OFBIZ-3329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788979#action_12788979 ] Adrian Crum commented on OFBIZ-3329: I think the problem is more fundamental. Why does Webtools need the commonext component? It seems to me that is an inappropriate dependency. If the goal is to get the framework to run independently, then we can't have any components in the applications folder enabled. > commonext component has dependency on party management component > > > Key: OFBIZ-3329 > URL: https://issues.apache.org/jira/browse/OFBIZ-3329 > Project: OFBiz > Issue Type: Bug > Components: commonext/setup >Affects Versions: SVN trunk >Reporter: chris snow > > I've just tried commenting out all components except commonext on trunk (i.e. > in component-load.xml). > I ran the ant tasks create-admin-user-login, then run and then tried to > access the url https://localhost:8443/webtools/ > I received the following error message: > org.ofbiz.widget.screen.ScreenRenderException: Error rendering > screen [component://common/widget/CommonScreens.xml#GlobalDecorator]: > org.ofbiz.base.util.GeneralException: Error running Groovy script at > location [component://commonext/script/changeOrgPartyId.groovy] (Could > not find definition for entity name PartyAcctgPrefAndGroup) (Error > running Groovy script at location > [component://commonext/script/changeOrgPartyId.groovy] (Could not find > definition for entity name PartyAcctgPrefAndGroup)) > It seems that commonext has a dependency on the party component. I'm not > sure is this is an issue - is there any guidelines on what dependencies can > go in commonext? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3329) commonext component has dependency on party management component
[ https://issues.apache.org/jira/browse/OFBIZ-3329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788992#action_12788992 ] Adrian Crum commented on OFBIZ-3329: That screen would have to be moved to the framework - along with any other security-related screens. > commonext component has dependency on party management component > > > Key: OFBIZ-3329 > URL: https://issues.apache.org/jira/browse/OFBIZ-3329 > Project: OFBiz > Issue Type: Bug > Components: commonext/setup >Affects Versions: SVN trunk >Reporter: chris snow > > I've just tried commenting out all components except commonext on trunk (i.e. > in component-load.xml). > I ran the ant tasks create-admin-user-login, then run and then tried to > access the url https://localhost:8443/webtools/ > I received the following error message: > org.ofbiz.widget.screen.ScreenRenderException: Error rendering > screen [component://common/widget/CommonScreens.xml#GlobalDecorator]: > org.ofbiz.base.util.GeneralException: Error running Groovy script at > location [component://commonext/script/changeOrgPartyId.groovy] (Could > not find definition for entity name PartyAcctgPrefAndGroup) (Error > running Groovy script at location > [component://commonext/script/changeOrgPartyId.groovy] (Could not find > definition for entity name PartyAcctgPrefAndGroup)) > It seems that commonext has a dependency on the party component. I'm not > sure is this is an issue - is there any guidelines on what dependencies can > go in commonext? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3245) Sandbox: Integrating The New Conversion Framework Into The Entity Engine
[ https://issues.apache.org/jira/browse/OFBIZ-3245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-3245: --- Attachment: conversion.patch Updated patch. This patch should fix the errors reported by Erwan and also an error reported by Jacopo when using Oracle. I still need to use the new fieldtypes*.xml attribute. I improved the code to do a better job of guessing the JDBC data type of each field, but there are still cases where it must be specified. > Sandbox: Integrating The New Conversion Framework Into The Entity Engine > > > Key: OFBIZ-3245 > URL: https://issues.apache.org/jira/browse/OFBIZ-3245 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: SVN trunk >Reporter: Adrian Crum >Assignee: Adrian Crum >Priority: Minor > Attachments: conversion.patch, conversion.patch, conversion.patch, > conversion.patch, conversion.patch > > > This issue contains a patch intended for evaluation before it is committed. > See comments for details. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2353) SequenceUtil may generate duplicate IDs in Load Balancing mode
[ https://issues.apache.org/jira/browse/OFBIZ-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790219#action_12790219 ] Adrian Crum commented on OFBIZ-2353: In addition to the issue reported here, SequenceUtil will return duplicate IDs in a heavily multi-threaded single instance. I confirmed this while testing my multi-threaded demo data loading code. The synchronization used in the class is not well thought out. > SequenceUtil may generate duplicate IDs in Load Balancing mode > --- > > Key: OFBIZ-2353 > URL: https://issues.apache.org/jira/browse/OFBIZ-2353 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release Branch 4.0, Release Branch 9.04, SVN trunk >Reporter: Philippe Mouawad >Priority: Critical > > If Ofbiz is deploy on 2 servers in Load Balancing Mode > SequenceUtil will generate duplicate IDs because synchronization is done at > JVM level instead of doing it in DB. > A good replacement implementation would be: > org.hibernate.id.enhanced.TableGenerator > But it would involve a dependency on Hibernate > Philippe > www.ubik-ingenierie.com -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3245) Sandbox: Integrating The New Conversion Framework Into The Entity Engine
[ https://issues.apache.org/jira/browse/OFBIZ-3245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790794#action_12790794 ] Adrian Crum commented on OFBIZ-3245: Nathan, I am confused. Are you saying the attached patch doesn't fix the problem? > Sandbox: Integrating The New Conversion Framework Into The Entity Engine > > > Key: OFBIZ-3245 > URL: https://issues.apache.org/jira/browse/OFBIZ-3245 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: SVN trunk >Reporter: Adrian Crum >Assignee: Adrian Crum >Priority: Minor > Attachments: conversion.patch, conversion.patch, conversion.patch, > conversion.patch, conversion.patch > > > This issue contains a patch intended for evaluation before it is committed. > See comments for details. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-3350) Fixed Asset Problem
[ https://issues.apache.org/jira/browse/OFBIZ-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-3350: -- Assignee: Adrian Crum > Fixed Asset Problem > > > Key: OFBIZ-3350 > URL: https://issues.apache.org/jira/browse/OFBIZ-3350 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Sam Hamilton >Assignee: Adrian Crum >Priority: Trivial > > Starting on > https://demo.ofbiz.org/accounting/control/EditFixedAsset?fixedAssetId=DEMO_MACHINE_GROUP > then click Children > the problems are: > 1. the box that sort of looks like a tick box does not do anything when > clicked > 2. clicking on DEMO_MACHINE adds a } on the end of the url > (https://demo.ofbiz.org/accounting/control/EditFixedAsset?fixedAssetId=DEMO_MACHINE}) > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3350) Fixed Asset Problem
[ https://issues.apache.org/jira/browse/OFBIZ-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-3350. -- Resolution: Fixed Fixed, rev 890918. Thanks Sam. The button on the left is decorative - it is not meant to do anything on leaf nodes. In a larger tree, you would see expand/collapse (+/-) icons there. > Fixed Asset Problem > > > Key: OFBIZ-3350 > URL: https://issues.apache.org/jira/browse/OFBIZ-3350 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Sam Hamilton >Assignee: Adrian Crum >Priority: Trivial > > Starting on > https://demo.ofbiz.org/accounting/control/EditFixedAsset?fixedAssetId=DEMO_MACHINE_GROUP > then click Children > the problems are: > 1. the box that sort of looks like a tick box does not do anything when > clicked > 2. clicking on DEMO_MACHINE adds a } on the end of the url > (https://demo.ofbiz.org/accounting/control/EditFixedAsset?fixedAssetId=DEMO_MACHINE}) > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3245) Sandbox: Integrating The New Conversion Framework Into The Entity Engine
[ https://issues.apache.org/jira/browse/OFBIZ-3245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-3245: --- Attachment: conversion.patch Nathan, Thank you for trying out the patch. The error you encountered was due to a bug in the patch. Please try the updated patch. > Sandbox: Integrating The New Conversion Framework Into The Entity Engine > > > Key: OFBIZ-3245 > URL: https://issues.apache.org/jira/browse/OFBIZ-3245 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: SVN trunk >Reporter: Adrian Crum >Assignee: Adrian Crum >Priority: Minor > Attachments: conversion.patch, conversion.patch, conversion.patch, > conversion.patch, conversion.patch, conversion.patch > > > This issue contains a patch intended for evaluation before it is committed. > See comments for details. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-3393) Temporal Expression Maintenance Is Missing In Webtools Application
Temporal Expression Maintenance Is Missing In Webtools Application -- Key: OFBIZ-3393 URL: https://issues.apache.org/jira/browse/OFBIZ-3393 Project: OFBiz Issue Type: Bug Affects Versions: SVN trunk Reporter: Adrian Crum The Temporal Expression maintenance screen has disappeared in the trunk Webtools application: https://demo.ofbiz.org/webtools/control/main. It exists in the R 9.04 version. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3393) Temporal Expression Maintenance Is Missing In Webtools Application
[ https://issues.apache.org/jira/browse/OFBIZ-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-3393. -- Resolution: Invalid Thanks Bruno! > Temporal Expression Maintenance Is Missing In Webtools Application > -- > > Key: OFBIZ-3393 > URL: https://issues.apache.org/jira/browse/OFBIZ-3393 > Project: OFBiz > Issue Type: Bug >Affects Versions: SVN trunk >Reporter: Adrian Crum > > The Temporal Expression maintenance screen has disappeared in the trunk > Webtools application: https://demo.ofbiz.org/webtools/control/main. It exists > in the R 9.04 version. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-3395) iCalendar Data textarea is much too small
[ https://issues.apache.org/jira/browse/OFBIZ-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-3395: -- Assignee: Adrian Crum > iCalendar Data textarea is much too small > - > > Key: OFBIZ-3395 > URL: https://issues.apache.org/jira/browse/OFBIZ-3395 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: SVN trunk >Reporter: chris snow >Assignee: Adrian Crum > Attachments: iCalendarDataPatch.txt > > > iCalendar Data textarea is much too small -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3395) iCalendar Data textarea is much too small
[ https://issues.apache.org/jira/browse/OFBIZ-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-3395. -- Resolution: Fixed Patch applied in rev 896970. Thanks Chris! > iCalendar Data textarea is much too small > - > > Key: OFBIZ-3395 > URL: https://issues.apache.org/jira/browse/OFBIZ-3395 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: SVN trunk >Reporter: chris snow >Assignee: Adrian Crum > Attachments: iCalendarDataPatch.txt > > > iCalendar Data textarea is much too small -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-3400) iCalendar Url is not the full url for accessing the ofbiz iCalendar
[ https://issues.apache.org/jira/browse/OFBIZ-3400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-3400: -- Assignee: Adrian Crum > iCalendar Url is not the full url for accessing the ofbiz iCalendar > --- > > Key: OFBIZ-3400 > URL: https://issues.apache.org/jira/browse/OFBIZ-3400 > Project: OFBiz > Issue Type: Improvement > Components: workeffort >Reporter: chris snow >Assignee: Adrian Crum >Priority: Minor > Attachments: iCalendarUriPatch.txt > > > iCalendar Url is not the full url for accessing the ofbiz iCalendar -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-3398) ofbiz iCalendar not showing sunbird create events until an ofbiz created event is added to the iCalendar
[ https://issues.apache.org/jira/browse/OFBIZ-3398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-3398: -- Assignee: Adrian Crum > ofbiz iCalendar not showing sunbird create events until an ofbiz created > event is added to the iCalendar > > > Key: OFBIZ-3398 > URL: https://issues.apache.org/jira/browse/OFBIZ-3398 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: SVN trunk > Environment: Sunbird v0.9 >Reporter: chris snow >Assignee: Adrian Crum > > I think I may be doing something wrong, but it appears that you cannot add an > event from Sunbird to an iCalendar until you have first associated an ofbiz > event to the iCalendar workeffort. > Steps: > In ofbiz (assume demo data installed and logged in as admin): > 1) Go to Workeffort > iCalendar > Add iCalendar > 2) Calendar, name = "issueTest" > 3) Click Save > 4) Go back to iCalendar and note URL (e.g. /iCalendar/10025) > In sunbird: > 1) New Calendar > 2) Select: On the Network > 3) Leave iCalendar (ICS) as is > 4) Location = "https://192.168.1.1/iCalendar/10025"; > 5) Name = "10025" > 6) Right click "Today" and enter new event: > 6.1) Title "New Event - aaa", click Save and Close > In ofbiz: > 1) Go to Calendar screen. Note "New Event - aaa" not shown > 2) Go to workeffort, find and select workeffort Id = 10025 > 3) Select Children link > 4) Select Add Existing Workeffort Child > 5) Click find next to "Work Effort Id To" > "New Event - aaa" - can't be found > 6) Go to Calendar, click "Add New", > 7) Enter Event Name "Ofbiz Event - bbb" > 8) Click Add > 9) Go to workeffort, find and select workeffort Id = 10025 > 10) Select Children link > 11) Select Add Existing Workeffort Child > 12) Click find next to "Work Effort Id To" > 13) Add "Ofbiz Event - bbb" > In Sunbird: > 1) Refresh Calendar > "Ofbiz event - bbb" is found! > 2) Now add a new Event - "New Event - ccc" > In Ofbiz: > 1) Go to calendar > 2) You can now see: all the events added by Sunbird. > CONCLUSION: > ofbiz iCalendar not showing sunbird create events until an ofbiz created > event is added to the iCalendar -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3400) iCalendar Url is not the full url for accessing the ofbiz iCalendar
[ https://issues.apache.org/jira/browse/OFBIZ-3400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-3400. -- Resolution: Fixed Committed in trunk, rev 897261. Thanks Chris! > iCalendar Url is not the full url for accessing the ofbiz iCalendar > --- > > Key: OFBIZ-3400 > URL: https://issues.apache.org/jira/browse/OFBIZ-3400 > Project: OFBiz > Issue Type: Improvement > Components: workeffort >Reporter: chris snow >Assignee: Adrian Crum >Priority: Minor > Attachments: iCalendarUriPatch.txt > > > iCalendar Url is not the full url for accessing the ofbiz iCalendar -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3400) iCalendar Url is not the full url for accessing the ofbiz iCalendar
[ https://issues.apache.org/jira/browse/OFBIZ-3400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798068#action_12798068 ] Adrian Crum commented on OFBIZ-3400: By the way, two things that will make your contributions easier to review and commit: 1. Patch files should have .patch or .diff extension 2. Update your local copy before creating the patch - so there are no version conflicts > iCalendar Url is not the full url for accessing the ofbiz iCalendar > --- > > Key: OFBIZ-3400 > URL: https://issues.apache.org/jira/browse/OFBIZ-3400 > Project: OFBiz > Issue Type: Improvement > Components: workeffort >Reporter: chris snow >Assignee: Adrian Crum >Priority: Minor > Attachments: iCalendarUriPatch.txt > > > iCalendar Url is not the full url for accessing the ofbiz iCalendar -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3398) ofbiz iCalendar not showing sunbird create events until an ofbiz created event is added to the iCalendar
[ https://issues.apache.org/jira/browse/OFBIZ-3398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-3398. -- Resolution: Fixed Fix Version/s: SVN trunk Fixed, rev 897384. Thanks Chris! > ofbiz iCalendar not showing sunbird create events until an ofbiz created > event is added to the iCalendar > > > Key: OFBIZ-3398 > URL: https://issues.apache.org/jira/browse/OFBIZ-3398 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: SVN trunk > Environment: Sunbird v0.9 >Reporter: chris snow >Assignee: Adrian Crum > Fix For: SVN trunk > > > I think I may be doing something wrong, but it appears that you cannot add an > event from Sunbird to an iCalendar until you have first associated an ofbiz > event to the iCalendar workeffort. > Steps: > In ofbiz (assume demo data installed and logged in as admin): > 1) Go to Workeffort > iCalendar > Add iCalendar > 2) Calendar, name = "issueTest" > 3) Click Save > 4) Go back to iCalendar and note URL (e.g. /iCalendar/10025) > In sunbird: > 1) New Calendar > 2) Select: On the Network > 3) Leave iCalendar (ICS) as is > 4) Location = "https://192.168.1.1/iCalendar/10025"; > 5) Name = "10025" > 6) Right click "Today" and enter new event: > 6.1) Title "New Event - aaa", click Save and Close > In ofbiz: > 1) Go to Calendar screen. Note "New Event - aaa" not shown > 2) Go to workeffort, find and select workeffort Id = 10025 > 3) Select Children link > 4) Select Add Existing Workeffort Child > 5) Click find next to "Work Effort Id To" > "New Event - aaa" - can't be found > 6) Go to Calendar, click "Add New", > 7) Enter Event Name "Ofbiz Event - bbb" > 8) Click Add > 9) Go to workeffort, find and select workeffort Id = 10025 > 10) Select Children link > 11) Select Add Existing Workeffort Child > 12) Click find next to "Work Effort Id To" > 13) Add "Ofbiz Event - bbb" > In Sunbird: > 1) Refresh Calendar > "Ofbiz event - bbb" is found! > 2) Now add a new Event - "New Event - ccc" > In Ofbiz: > 1) Go to calendar > 2) You can now see: all the events added by Sunbird. > CONCLUSION: > ofbiz iCalendar not showing sunbird create events until an ofbiz created > event is added to the iCalendar -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3245) Sandbox: Integrating The New Conversion Framework Into The Entity Engine
[ https://issues.apache.org/jira/browse/OFBIZ-3245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-3245: --- Attachment: conversion.patch Updated patch to latest trunk rev. If any one is available to test the latest patch I would really appreciate it! It needs to be tested using Postgres and Oracle databases. > Sandbox: Integrating The New Conversion Framework Into The Entity Engine > > > Key: OFBIZ-3245 > URL: https://issues.apache.org/jira/browse/OFBIZ-3245 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: SVN trunk >Reporter: Adrian Crum >Assignee: Adrian Crum >Priority: Minor > Attachments: conversion.patch, conversion.patch, conversion.patch, > conversion.patch, conversion.patch, conversion.patch, conversion.patch > > > This issue contains a patch intended for evaluation before it is committed. > See comments for details. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-3413) Add Temporal Expressions To Async Services
Add Temporal Expressions To Async Services -- Key: OFBIZ-3413 URL: https://issues.apache.org/jira/browse/OFBIZ-3413 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Adrian Crum Priority: Minor The current asynchronous service implementation uses iCalendar-style data to schedule the service. The implementation needs to be improved to support temporal expressions. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3413) Add Temporal Expressions To Async Services
[ https://issues.apache.org/jira/browse/OFBIZ-3413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801284#action_12801284 ] Adrian Crum commented on OFBIZ-3413: The service engine, CoreEvents.java, and UI artifacts all need to be changed. > Add Temporal Expressions To Async Services > -- > > Key: OFBIZ-3413 > URL: https://issues.apache.org/jira/browse/OFBIZ-3413 > Project: OFBiz > Issue Type: Improvement > Components: framework >Reporter: Adrian Crum >Priority: Minor > > The current asynchronous service implementation uses iCalendar-style data to > schedule the service. The implementation needs to be improved to support > temporal expressions. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-3414) Work Effort Appliaction Is Broken In Trunk
Work Effort Appliaction Is Broken In Trunk -- Key: OFBIZ-3414 URL: https://issues.apache.org/jira/browse/OFBIZ-3414 Project: OFBiz Issue Type: Bug Components: workeffort Affects Versions: SVN trunk Reporter: Adrian Crum The work effort application has become useless. There has been a major regression since R 9.04. See comments for details. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3414) Work Effort Appliaction Is Broken In Trunk
[ https://issues.apache.org/jira/browse/OFBIZ-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801305#action_12801305 ] Adrian Crum commented on OFBIZ-3414: Issue #1: The Find Work Efforts screen doesn't work. Click on the Find button in the 9.04 demo (https://demo904.ofbiz.org/workeffort/control/FindWorkEffort). All work efforts are displayed. Click on the Find button in the trunk demo (https://demo.ofbiz.org/workeffort/control/FindWorkEffort). Only some work efforts are displayed. > Work Effort Appliaction Is Broken In Trunk > -- > > Key: OFBIZ-3414 > URL: https://issues.apache.org/jira/browse/OFBIZ-3414 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: SVN trunk >Reporter: Adrian Crum > > The work effort application has become useless. There has been a major > regression since R 9.04. See comments for details. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3414) Work Effort Appliaction Is Broken In Trunk
[ https://issues.apache.org/jira/browse/OFBIZ-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801308#action_12801308 ] Adrian Crum commented on OFBIZ-3414: Issue #2: Create/Edit Work Effort in Calendar screen doesn't work properly. Go to the Calendar screen in the 9.04 demo (https://demo904.ofbiz.org/workeffort/control/day). Click on one of the Add New links. An Edit Work Effort screen appears that allows you to enter any type of work effort. Go to the Calendar screen in the trunk demo (https://demo.ofbiz.org/workeffort/control/calendar). Click on one of the Add New links. A screen appears that only lets you enter very limited information, and only for an event. There is no way to enter another type of work effort. > Work Effort Appliaction Is Broken In Trunk > -- > > Key: OFBIZ-3414 > URL: https://issues.apache.org/jira/browse/OFBIZ-3414 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: SVN trunk >Reporter: Adrian Crum > > The work effort application has become useless. There has been a major > regression since R 9.04. See comments for details. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3414) Work Effort Appliaction Is Broken In Trunk
[ https://issues.apache.org/jira/browse/OFBIZ-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-3414: --- Description: The work effort application has become unusable. There has been a major regression since R 9.04. See comments for details. was: The work effort application has become useless. There has been a major regression since R 9.04. See comments for details. > Work Effort Appliaction Is Broken In Trunk > -- > > Key: OFBIZ-3414 > URL: https://issues.apache.org/jira/browse/OFBIZ-3414 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: SVN trunk >Reporter: Adrian Crum > > The work effort application has become unusable. There has been a major > regression since R 9.04. See comments for details. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3414) Work Effort Application Is Broken In Trunk
[ https://issues.apache.org/jira/browse/OFBIZ-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-3414: --- Summary: Work Effort Application Is Broken In Trunk (was: Work Effort Appliaction Is Broken In Trunk) > Work Effort Application Is Broken In Trunk > -- > > Key: OFBIZ-3414 > URL: https://issues.apache.org/jira/browse/OFBIZ-3414 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: SVN trunk >Reporter: Adrian Crum > > The work effort application has become unusable. There has been a major > regression since R 9.04. See comments for details. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3414) Work Effort Application Is Broken In Trunk
[ https://issues.apache.org/jira/browse/OFBIZ-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801332#action_12801332 ] Adrian Crum commented on OFBIZ-3414: Issue #3: The temporal expression demo doesn't work in either version. Log into Work Efforts application as admin. Go to Calendar and select Month View. A staff meeting should appear on the first Monday of the month. > Work Effort Application Is Broken In Trunk > -- > > Key: OFBIZ-3414 > URL: https://issues.apache.org/jira/browse/OFBIZ-3414 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: SVN trunk >Reporter: Adrian Crum > > The work effort application has become unusable. There has been a major > regression since R 9.04. See comments for details. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3414) Work Effort Application Is Broken In Trunk
[ https://issues.apache.org/jira/browse/OFBIZ-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801334#action_12801334 ] Adrian Crum commented on OFBIZ-3414: Issue # 4: The iCalendar demo doesn't work (probably related to #3). Using an iCalendar client, view this R 9.04 calendar: https://demo904.ofbiz.org/iCalendar/CALENDAR_PUB_DEMO/test.ics The staff meeting appears. Using an iCalendar client, view this trunk calendar: https://demo.ofbiz.org/iCalendar/CALENDAR_PUB_DEMO/test.ics The calendar requires authentication. After logging in, no calendar appears. > Work Effort Application Is Broken In Trunk > -- > > Key: OFBIZ-3414 > URL: https://issues.apache.org/jira/browse/OFBIZ-3414 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: SVN trunk >Reporter: Adrian Crum > > The work effort application has become unusable. There has been a major > regression since R 9.04. See comments for details. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3414) Work Effort Application Is Broken In Trunk
[ https://issues.apache.org/jira/browse/OFBIZ-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801515#action_12801515 ] Adrian Crum commented on OFBIZ-3414: Issue # 5: When editing a work effort, after clicking Save, you are taken to a calendar screen. This issue appears when certain steps are followed in order: Go to the Calendar screen and click on any work effort that appears there. The limited edit work effort screen appears. Leave the work effort as-is and click on the application's Work Effort tab (the one that takes you to the Find Work Efforts screen). Click Find and select any work effort. Click Save on the Edit Work Effort screen. You are taken to a calendar screen after the work effort is saved. What should happen is you stay on the Edit Work Effort screen. > Work Effort Application Is Broken In Trunk > -- > > Key: OFBIZ-3414 > URL: https://issues.apache.org/jira/browse/OFBIZ-3414 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: SVN trunk >Reporter: Adrian Crum > > The work effort application has become unusable. There has been a major > regression since R 9.04. See comments for details. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3414) Work Effort Application Is Broken In Trunk
[ https://issues.apache.org/jira/browse/OFBIZ-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801516#action_12801516 ] Adrian Crum commented on OFBIZ-3414: Jacques, I put all these issues in one Jira issue because they were all caused by one person, and my hope is that person will step up to the plate and fix the things they broke. > Work Effort Application Is Broken In Trunk > -- > > Key: OFBIZ-3414 > URL: https://issues.apache.org/jira/browse/OFBIZ-3414 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: SVN trunk >Reporter: Adrian Crum > > The work effort application has become unusable. There has been a major > regression since R 9.04. See comments for details. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3414) Work Effort Application Is Broken In Trunk
[ https://issues.apache.org/jira/browse/OFBIZ-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802094#action_12802094 ] Adrian Crum commented on OFBIZ-3414: Hans, Thank you very much for taking care of this. My employer uses the Work Effort application out of the box, so it does get used. > Work Effort Application Is Broken In Trunk > -- > > Key: OFBIZ-3414 > URL: https://issues.apache.org/jira/browse/OFBIZ-3414 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: SVN trunk >Reporter: Adrian Crum >Assignee: Hans Bakker >Priority: Minor > > The work effort application has become unusable. There has been a major > regression since R 9.04. See comments for details. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Reopened: (OFBIZ-3418) Improve UtilProperties.java with a new Method getPropertyNumber which returns an Object of the Number or a defaultObject
[ https://issues.apache.org/jira/browse/OFBIZ-3418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reopened OFBIZ-3418: Mirko, Leave the issue open - the person who reviews and commits your patch will close it. The new method is a good idea. What might make this more intuitive would be to have methods like getPropertyAsInt(...), getPropertyAsLong(...), etc. I have considered adding getPropertyAsBoolean(...) because a lot of settings are true/false. > Improve UtilProperties.java with a new Method getPropertyNumber which returns > an Object of the Number or a defaultObject > > > Key: OFBIZ-3418 > URL: https://issues.apache.org/jira/browse/OFBIZ-3418 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: SVN trunk >Reporter: Mirko Vogelsmeier >Priority: Minor > Fix For: SVN trunk > > Attachments: apache_ofbiz_community.patch > > Original Estimate: 0.03h > Remaining Estimate: 0.03h > > Improvement of UtilProperties.java with a new method which returns the Number > as an Object of the specified property name from the specified > resource/properties file. > If the specified property name or properties file is not found, the > defaultObject is returned. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3414) Work Effort Application Is Broken In Trunk
[ https://issues.apache.org/jira/browse/OFBIZ-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802669#action_12802669 ] Adrian Crum commented on OFBIZ-3414: The pagination works fine for me - but not all of the work efforts appear. I don't think the problem is in the form, I think it is in the method of finding all work efforts - some of them are being excluded. > Work Effort Application Is Broken In Trunk > -- > > Key: OFBIZ-3414 > URL: https://issues.apache.org/jira/browse/OFBIZ-3414 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: SVN trunk >Reporter: Adrian Crum >Assignee: Hans Bakker >Priority: Minor > > The work effort application has become unusable. There has been a major > regression since R 9.04. See comments for details. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3414) Work Effort Application Is Broken In Trunk
[ https://issues.apache.org/jira/browse/OFBIZ-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802672#action_12802672 ] Adrian Crum commented on OFBIZ-3414: Okay, that's odd. I had 35 work efforts appear on the Find screen. I created a new work effort event, and saved it. Now only a handful of work efforts appear on the Find screen. Something very strange is going on there. > Work Effort Application Is Broken In Trunk > -- > > Key: OFBIZ-3414 > URL: https://issues.apache.org/jira/browse/OFBIZ-3414 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: SVN trunk >Reporter: Adrian Crum >Assignee: Hans Bakker >Priority: Minor > > The work effort application has become unusable. There has been a major > regression since R 9.04. See comments for details. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3414) Work Effort Application Is Broken In Trunk
[ https://issues.apache.org/jira/browse/OFBIZ-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802676#action_12802676 ] Adrian Crum commented on OFBIZ-3414: Hans, I don't have a lot of time to help you investigate, but I can give you some clues that might help. I had to fix the Find screen in revision 794327. The Find screen was listing a lot of duplicate work efforts - something it didn't do before. So, something broke between R 9.04 and trunk rev 794327. > Work Effort Application Is Broken In Trunk > -- > > Key: OFBIZ-3414 > URL: https://issues.apache.org/jira/browse/OFBIZ-3414 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: SVN trunk >Reporter: Adrian Crum >Assignee: Hans Bakker >Priority: Minor > > The work effort application has become unusable. There has been a major > regression since R 9.04. See comments for details. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3414) Work Effort Application Is Broken In Trunk
[ https://issues.apache.org/jira/browse/OFBIZ-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802692#action_12802692 ] Adrian Crum commented on OFBIZ-3414: The solution seems pretty simple to me: have project manager use the view, and put the work effort application back the way it was. > Work Effort Application Is Broken In Trunk > -- > > Key: OFBIZ-3414 > URL: https://issues.apache.org/jira/browse/OFBIZ-3414 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: SVN trunk >Reporter: Adrian Crum >Assignee: Hans Bakker >Priority: Minor > > The work effort application has become unusable. There has been a major > regression since R 9.04. See comments for details. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3414) Work Effort Application Is Broken In Trunk
[ https://issues.apache.org/jira/browse/OFBIZ-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802696#action_12802696 ] Adrian Crum commented on OFBIZ-3414: I agree on #3. When I added that comment it was not working in either online demo. I'm beginning to notice a pattern, which might be another clue. If I run ant clean-all, then ant run-install, the Work Effort application starts off working as it should. If I go to the Edit Work Effort screen and click save, then the entire Work Effort application starts to go berzerk. > Work Effort Application Is Broken In Trunk > -- > > Key: OFBIZ-3414 > URL: https://issues.apache.org/jira/browse/OFBIZ-3414 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: SVN trunk >Reporter: Adrian Crum >Assignee: Hans Bakker >Priority: Minor > > The work effort application has become unusable. There has been a major > regression since R 9.04. See comments for details. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3414) Work Effort Application Is Broken In Trunk
[ https://issues.apache.org/jira/browse/OFBIZ-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802898#action_12802898 ] Adrian Crum commented on OFBIZ-3414: Hans, I don't see where #2 has changed. It still doesn't take me to the Edit Work Effort screen. How do I enter the running time? Or the setup time? Or a temporal expression? Or percent complete? The approach you are trying to take is backwards. Instead of making Project Manager (a special purpose component) reuse work effort application artifacts, you are trying to make the work effort application BE a project manager. > Work Effort Application Is Broken In Trunk > -- > > Key: OFBIZ-3414 > URL: https://issues.apache.org/jira/browse/OFBIZ-3414 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: SVN trunk >Reporter: Adrian Crum >Assignee: Hans Bakker >Priority: Minor > > The work effort application has become unusable. There has been a major > regression since R 9.04. See comments for details. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3245) Sandbox: Integrating The New Conversion Framework Into The Entity Engine
[ https://issues.apache.org/jira/browse/OFBIZ-3245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-3245: --- Attachment: conversion.patch Updated patch. This should solve the Clob error messages. > Sandbox: Integrating The New Conversion Framework Into The Entity Engine > > > Key: OFBIZ-3245 > URL: https://issues.apache.org/jira/browse/OFBIZ-3245 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: SVN trunk >Reporter: Adrian Crum >Assignee: Adrian Crum >Priority: Minor > Attachments: conversion.patch, conversion.patch, conversion.patch, > conversion.patch, conversion.patch, conversion.patch, conversion.patch, > conversion.patch > > > This issue contains a patch intended for evaluation before it is committed. > See comments for details. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3414) Work Effort Application Is Broken In Trunk
[ https://issues.apache.org/jira/browse/OFBIZ-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828371#action_12828371 ] Adrian Crum commented on OFBIZ-3414: Issues 3 & 4 fixed in rev 905475. > Work Effort Application Is Broken In Trunk > -- > > Key: OFBIZ-3414 > URL: https://issues.apache.org/jira/browse/OFBIZ-3414 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: SVN trunk >Reporter: Adrian Crum >Assignee: Hans Bakker >Priority: Minor > > The work effort application has become unusable. There has been a major > regression since R 9.04. See comments for details. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3486) In some cases when you pass a list of GenericValues to
[
https://issues.apache.org/jira/browse/OFBIZ-3486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835280#action_12835280
]
Adrian Crum commented on OFBIZ-3486:
It appears the List of Maps is being converted to a List of Strings. From
ModelFormField.java line 1648:
data = java.lang.String:
{[GenericEntity:GeoAssocAndGeoTo][abbreviation,AA(java.lang.String)][geoAssocTypeId,REGIONS(java.lang.String)][geoCode,AA(java.lang.String)][geoId,AA(java.lang.String)][geoIdFrom,USA(java.lang.String)][geoName,Armed
Forces
Americas(java.lang.String)][geoSecCode,null()][geoTypeId,STATE(java.lang.String)][wellKnownText,null()],
[GenericEntity:GeoAssocAndGeoTo][abbreviation,AE(java.lang.String)][geoAssocTypeId,REGIONS(java.lang.String)][geoCode,AE(java.lang.String)][geoId,AE(java.lang.String)][geoIdFrom,USA(java.lang.String)][geoName,Armed
Forces
Europe(java.lang.String)][geoSecCode,null()][geoTypeId,STATE(java.lang.String)][wellKnownText,null()],
[GenericEntity:GeoAssocAndGeoTo][abbreviation,AK(java.lang.String)][geoAssocTypeId,REGIONS(java.lang.String)][geoCode,AK(java.lang.String)][geoId,AK(java.lang.String)][geoIdFrom,USA(java.lang.String)][geoName,Alaska(java.lang.String)][geoSecCode,null()][geoTypeI
I don't have time to look into this right away.
> In some cases when you pass a list of GenericValues to widget you get an error saying GenericValues are not Map
>
>
> Key: OFBIZ-3486
> URL: https://issues.apache.org/jira/browse/OFBIZ-3486
> Project: OFBiz
> Issue Type: Bug
> Components: ALL APPLICATIONS
>Affects Versions: SVN trunk
>Reporter: Jacques Le Roux
>Priority: Critical
> Fix For: SVN trunk
>
>
> In some cases when you pass a list of GenericValues to widget you get an error saying GenericValue is not Map.
> Of course this is true. But also this was working some days ago. At least it
> was working with the 909312 revision.
> It's easy to reproduce. In any OOTB form widget add these snippets:
> {code}
> type="List"/>
> {code}
> {code}
>
>
> description="${geoName}"/>
>
>
> {code}
> The error is
> cause
> -
> Exception: java.lang.ClassCastException
> Message: Not a map
> stack trace
> ---
> java.lang.ClassCastException: Not a map
> org.ofbiz.base.util.UtilGenerics.checkMap(UtilGenerics.java:77)
> org.ofbiz.widget.form.ModelFormField$ListOptions.addOptionValues(ModelFormField.java:1648)
> org.ofbiz.widget.form.ModelFormField$FieldInfoWithOptions.getAllOptionValues(ModelFormField.java:1529)
> org.ofbiz.widget.form.MacroFormRenderer.renderDropDownField(MacroFormRenderer.java:666)
> org.ofbiz.widget.form.ModelFormField$DropDownField.renderFieldString(ModelFormField.java:3043)
> org.ofbiz.widget.form.ModelFormField.renderFieldString(ModelFormField.java:595)
> org.ofbiz.widget.form.ModelForm.renderSingleFormString(ModelForm.java:1054)
> org.ofbiz.widget.form.ModelForm.renderFormString(ModelForm.java:837)
> org.ofbiz.widget.screen.ModelScreenWidget$Form.renderWidgetString(ModelScreenWidget.java:841)
> org.ofbiz.widget.screen.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:704)
> org.ofbiz.widget.screen.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:408)
> org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:137)
> org.ofbiz.widget.screen.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:704)
> org.ofbiz.widget.screen.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:167)
> org.ofbiz.widget.screen.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:736)
> org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:137)
> org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:228)
> org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:137)
> org.ofbiz.widget.screen.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:704)
> org.ofbiz.widget.screen.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:167)
> org.ofbiz.widget.screen.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:736)
> org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:137)
> org.ofbiz.widget.screen.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:296)
> org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:137)
> org.ofbiz.widget.screen.ModelScreenWidget$Se
[jira] Commented: (OFBIZ-3486) In some cases when you pass a list of GenericValues to
[
https://issues.apache.org/jira/browse/OFBIZ-3486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835519#action_12835519
]
Adrian Crum commented on OFBIZ-3486:
Adam,
Thanks to your comments, I think I know what happened. The original code would
convert the script result (a List) to a String using the home-grown
serialization code. You changed that to convert the List to a JSON String. When
you reverted your change, you didn't put it back to converting a List to the
home-grown serialization - probably because of my comment about wanting
predictable behavior and any Object converted to a String is the same as
calling that Object's toString method.
To maintain backward compatibility, I think we need to change the List to
String conversion back to the way it was.
> In some cases when you pass a list of GenericValues to widget you get an error saying GenericValues are not Map
>
>
> Key: OFBIZ-3486
> URL: https://issues.apache.org/jira/browse/OFBIZ-3486
> Project: OFBiz
> Issue Type: Bug
> Components: ALL APPLICATIONS
>Affects Versions: SVN trunk
>Reporter: Jacques Le Roux
>Priority: Critical
> Fix For: SVN trunk
>
>
> In some cases when you pass a list of GenericValues to widget you get an error saying GenericValue is not Map.
> Of course this is true. But also this was working some days ago. At least it
> was working with the 909312 revision.
> It's easy to reproduce. In any OOTB form widget add these snippets:
> {code}
> type="List"/>
> {code}
> {code}
>
>
> description="${geoName}"/>
>
>
> {code}
> The error is
> cause
> -
> Exception: java.lang.ClassCastException
> Message: Not a map
> stack trace
> ---
> java.lang.ClassCastException: Not a map
> org.ofbiz.base.util.UtilGenerics.checkMap(UtilGenerics.java:77)
> org.ofbiz.widget.form.ModelFormField$ListOptions.addOptionValues(ModelFormField.java:1648)
> org.ofbiz.widget.form.ModelFormField$FieldInfoWithOptions.getAllOptionValues(ModelFormField.java:1529)
> org.ofbiz.widget.form.MacroFormRenderer.renderDropDownField(MacroFormRenderer.java:666)
> org.ofbiz.widget.form.ModelFormField$DropDownField.renderFieldString(ModelFormField.java:3043)
> org.ofbiz.widget.form.ModelFormField.renderFieldString(ModelFormField.java:595)
> org.ofbiz.widget.form.ModelForm.renderSingleFormString(ModelForm.java:1054)
> org.ofbiz.widget.form.ModelForm.renderFormString(ModelForm.java:837)
> org.ofbiz.widget.screen.ModelScreenWidget$Form.renderWidgetString(ModelScreenWidget.java:841)
> org.ofbiz.widget.screen.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:704)
> org.ofbiz.widget.screen.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:408)
> org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:137)
> org.ofbiz.widget.screen.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:704)
> org.ofbiz.widget.screen.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:167)
> org.ofbiz.widget.screen.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:736)
> org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:137)
> org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:228)
> org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:137)
> org.ofbiz.widget.screen.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:704)
> org.ofbiz.widget.screen.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:167)
> org.ofbiz.widget.screen.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:736)
> org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:137)
> org.ofbiz.widget.screen.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:296)
> org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:137)
> org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:228)
> org.ofbiz.widget.screen.ModelScreen.renderScreenString(ModelScreen.java:394)
> org.ofbiz.widget.screen.ModelScreenWidget$IncludeScreen.renderWidgetString(ModelScreenWidget.java:576)
> org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:137)
> org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:228)
> org.ofbiz.widget.screen.ModelScreen.renderScreenString
[jira] Commented: (OFBIZ-3486) In some cases when you pass a list of GenericValues to
[
https://issues.apache.org/jira/browse/OFBIZ-3486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835528#action_12835528
]
Adrian Crum commented on OFBIZ-3486:
Okay, never mind. I just tried it in R 9.04 and it doesn't work there either.
This has nothing to do with converter code changes.
> In some cases when you pass a list of GenericValues to widget you get an error saying GenericValues are not Map
>
>
> Key: OFBIZ-3486
> URL: https://issues.apache.org/jira/browse/OFBIZ-3486
> Project: OFBiz
> Issue Type: Bug
> Components: ALL APPLICATIONS
>Affects Versions: SVN trunk
>Reporter: Jacques Le Roux
>Priority: Critical
> Fix For: SVN trunk
>
>
> In some cases when you pass a list of GenericValues to widget you get an error saying GenericValue is not Map.
> Of course this is true. But also this was working some days ago. At least it
> was working with the 909312 revision.
> It's easy to reproduce. In any OOTB form widget add these snippets:
> {code}
> type="List"/>
> {code}
> {code}
>
>
> description="${geoName}"/>
>
>
> {code}
> The error is
> cause
> -
> Exception: java.lang.ClassCastException
> Message: Not a map
> stack trace
> ---
> java.lang.ClassCastException: Not a map
> org.ofbiz.base.util.UtilGenerics.checkMap(UtilGenerics.java:77)
> org.ofbiz.widget.form.ModelFormField$ListOptions.addOptionValues(ModelFormField.java:1648)
> org.ofbiz.widget.form.ModelFormField$FieldInfoWithOptions.getAllOptionValues(ModelFormField.java:1529)
> org.ofbiz.widget.form.MacroFormRenderer.renderDropDownField(MacroFormRenderer.java:666)
> org.ofbiz.widget.form.ModelFormField$DropDownField.renderFieldString(ModelFormField.java:3043)
> org.ofbiz.widget.form.ModelFormField.renderFieldString(ModelFormField.java:595)
> org.ofbiz.widget.form.ModelForm.renderSingleFormString(ModelForm.java:1054)
> org.ofbiz.widget.form.ModelForm.renderFormString(ModelForm.java:837)
> org.ofbiz.widget.screen.ModelScreenWidget$Form.renderWidgetString(ModelScreenWidget.java:841)
> org.ofbiz.widget.screen.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:704)
> org.ofbiz.widget.screen.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:408)
> org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:137)
> org.ofbiz.widget.screen.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:704)
> org.ofbiz.widget.screen.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:167)
> org.ofbiz.widget.screen.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:736)
> org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:137)
> org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:228)
> org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:137)
> org.ofbiz.widget.screen.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:704)
> org.ofbiz.widget.screen.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:167)
> org.ofbiz.widget.screen.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:736)
> org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:137)
> org.ofbiz.widget.screen.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:296)
> org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:137)
> org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:228)
> org.ofbiz.widget.screen.ModelScreen.renderScreenString(ModelScreen.java:394)
> org.ofbiz.widget.screen.ModelScreenWidget$IncludeScreen.renderWidgetString(ModelScreenWidget.java:576)
> org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:137)
> org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:228)
> org.ofbiz.widget.screen.ModelScreen.renderScreenString(ModelScreen.java:394)
> org.ofbiz.widget.screen.ModelScreenWidget$DecoratorScreen.renderWidgetString(ModelScreenWidget.java:672)
> org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:137)
> org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:228)
> org.ofbiz.widget.screen.ModelScreen.renderScreenString(ModelScreen.java:394)
> org.ofbiz.widget.screen.ModelScreenWidget$DecoratorScreen.renderWidgetString(ModelS
[jira] Commented: (OFBIZ-3521) Rename temporal DAYOFWEEK_01 to DAYOFWEEK_SUN
[ https://issues.apache.org/jira/browse/OFBIZ-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839018#action_12839018 ] Adrian Crum commented on OFBIZ-3521: A better solution would be to add a description field to the entity. > Rename temporal DAYOFWEEK_01 to DAYOFWEEK_SUN > - > > Key: OFBIZ-3521 > URL: https://issues.apache.org/jira/browse/OFBIZ-3521 > Project: OFBiz > Issue Type: Improvement > Components: workeffort >Affects Versions: SVN trunk >Reporter: chris snow >Priority: Trivial > > To improve usability of the example DAYOFWEEK_0x expressions, they would be > more easily understood if they use the actual day name. Looking at > DAYOFWEEK_01, I wasn't sure whether this was SUN or MON without looking at > the expression definition. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3531) Methods that implement interface methods were being marked with the @Override annotation causing compile failure in Eclipse
[ https://issues.apache.org/jira/browse/OFBIZ-3531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-3531: --- Priority: Minor (was: Major) The compile errors must be due to an Eclipse setting. The override annotations were added by Eclipse automatically (Add unimplemented methods wizard) so it is puzzling that Eclipse would complain about them. The version I'm using - dated June 2009 - doesn't generate any errors. Also, it might be helpful to find out what Sun's coding standards are regarding this. Are override annotations for interface methods recommended? > Methods that implement interface methods were being marked with the @Override > annotation causing compile failure in Eclipse > --- > > Key: OFBIZ-3531 > URL: https://issues.apache.org/jira/browse/OFBIZ-3531 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk > Environment: Eclipse 3.5 on Mac OS X 10.5.8 >Reporter: Bob Morley >Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-3531_RemoveIncorrectOverrideAnnotations.patch > > > Implementations of the TemporalExpressionVisitor interface and some base > comparison methods were implementation methods but were marked with the > @Override annotation. This caused compile errors in Eclipse in these four > classes. I simply removed the @Override on these methods and I fixed one > generics related warning. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3531) Methods that implement interface methods were being marked with the @Override annotation causing compile failure in Eclipse
[ https://issues.apache.org/jira/browse/OFBIZ-3531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-3531. -- Resolution: Won't Fix I did some research too. It seems the functionality of @Override was extended in Java 6, but it wasn't documented. The reason for allowing @Override on interface method implementations is this: If the interface changes and a method is removed, the compiler will generate a warning for classes that implement the removed method. > Methods that implement interface methods were being marked with the @Override > annotation causing compile failure in Eclipse > --- > > Key: OFBIZ-3531 > URL: https://issues.apache.org/jira/browse/OFBIZ-3531 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk > Environment: Eclipse 3.5 on Mac OS X 10.5.8 >Reporter: Bob Morley >Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-3531_RemoveIncorrectOverrideAnnotations.patch > > > Implementations of the TemporalExpressionVisitor interface and some base > comparison methods were implementation methods but were marked with the > @Override annotation. This caused compile errors in Eclipse in these four > classes. I simply removed the @Override on these methods and I fixed one > generics related warning. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3534) totalYearsWorkExperience is not automatically calculated/updated
[ https://issues.apache.org/jira/browse/OFBIZ-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841363#action_12841363 ] Adrian Crum commented on OFBIZ-3534: Better yet, have fromDate and thruDate fields. > totalYearsWorkExperience is not automatically calculated/updated > > > Key: OFBIZ-3534 > URL: https://issues.apache.org/jira/browse/OFBIZ-3534 > Project: OFBiz > Issue Type: Wish > Components: party >Affects Versions: SVN trunk >Reporter: chris snow >Priority: Trivial > > totalYearsWorkExperience is not automatically calculated/updated. For > example, > 2008 - Enter person, setting totalYearsWorkExperience to 8.0 (years) > 2009 - still shows 8 years, even though the person now has 9 years > 2010 - still shows 8 years, even though the person now has 10 years > To fix this, the totalYearsWorkExperience could be periodically recalculated, > or there could be a totalYearsWorkExperienceDate field for when the > totalYearsWorkExperience field was last updated, e.g. > totalYearsWorkExperience = 8 > totalYearsWorkExperienceDate = 2001-01-01 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3519) Slightly modified Visual Theme Resource Enums for better readability
[ https://issues.apache.org/jira/browse/OFBIZ-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841365#action_12841365 ] Adrian Crum commented on OFBIZ-3519: Why not increase the length of the field and keep the seed data as it is? > Slightly modified Visual Theme Resource Enums for better readability > > > Key: OFBIZ-3519 > URL: https://issues.apache.org/jira/browse/OFBIZ-3519 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Reporter: Vikas Mayur >Priority: Minor > Fix For: SVN trunk > > Attachments: enum.patch > > > Minor enhancement to the visual theme resource enumId so that a more verbose > name of the resource or template file can be specified. > The suffix STYLESHEET and JAVASCRIPT in the enum impose a restriction on > specifying a meaningful name of the enumId field which is max 20 chars in > size. > The suffix in the enum contains following changes. > 1. STYLESHEET is replaced with CSS > 2. JAVASCRIPT is replaced with JS > 3. LOC is completely removed from TMPLT, since it is anyway specify a > template location. > With all above points the total char size of the enum decreased and it gives > an opportunity to specify better names and hence more readability. > For example VT_HDR_TMPLT_LOC becomes VT_HEADER_TMPLT -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3535) make TemporalExpression classes available as a standalone library
[ https://issues.apache.org/jira/browse/OFBIZ-3535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841384#action_12841384 ] Adrian Crum commented on OFBIZ-3535: This is something I am interested in pursuing, and I mentioned it on the dev mailing list. I have been lurking on the Apache Commons mailing lists - trying to get a feel for their community. We would need unit tests for the expressions, and then try to use the classes as an external library. Also, it would help if others were interested in supporting a stand-alone library - so I'm not doing it alone. > make TemporalExpression classes available as a standalone library > - > > Key: OFBIZ-3535 > URL: https://issues.apache.org/jira/browse/OFBIZ-3535 > Project: OFBiz > Issue Type: Wish > Components: workeffort >Affects Versions: SVN trunk >Reporter: chris snow >Priority: Trivial > > The temporal expression classes are very useful. It would be great if they > could be used outside of ofbiz. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-3535) make TemporalExpression classes available as a standalone library
[ https://issues.apache.org/jira/browse/OFBIZ-3535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-3535: -- Assignee: Adrian Crum > make TemporalExpression classes available as a standalone library > - > > Key: OFBIZ-3535 > URL: https://issues.apache.org/jira/browse/OFBIZ-3535 > Project: OFBiz > Issue Type: Wish > Components: workeffort >Affects Versions: SVN trunk >Reporter: chris snow >Assignee: Adrian Crum >Priority: Trivial > > The temporal expression classes are very useful. It would be great if they > could be used outside of ofbiz. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-3623) XHTML validation errors (framework/widget)
[ https://issues.apache.org/jira/browse/OFBIZ-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-3623: -- Assignee: Adrian Crum > XHTML validation errors (framework/widget) > -- > > Key: OFBIZ-3623 > URL: https://issues.apache.org/jira/browse/OFBIZ-3623 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk >Reporter: Blas Rodriguez Somoza >Assignee: Adrian Crum >Priority: Trivial > Fix For: SVN trunk > > Attachments: OFBIZ-3623_framework_widget_xhtml.diff > > > XHTML validation errors > * Unclosed INPUT > * attributes without values (checked, selected, disabled, etc) > * attribute values without " > * Uppercase tags or attributes. > * Unencoded ampersands in urls. > Other errors: > htmlFormMacroLibrary.ftl > Line 452. img tag must have src and alt attributes. > /> > htmlScreenMacroLibrary.ftl > Wrong markup at Line 143. Entity without final ; > >Â > Changes in java classes: > MacroFormRenderer.java (renderSortField) > The sort URL must use encoded ampersands. > HtmlFormRenderer.java (renderDisplayField) > The alert style must be included in the class attribute not appear as a > attribute name (which is what happens now) > HtmlMenuRenderer.java (renderMenuOpen, renderMenuClose) > XHTML don't like empty UL. To avoid that, the renderMenuOpen and > renderMenuClose methods need to know how many menu items pass the condition > and so will be included. > ModelMenu.java (public int passConditionCount) > New method to get how many menu items pass the condition. > ModelMenuItem (public boolean passCondition) > New method to get if the menu item pass the condition. > Patch attached -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3623) XHTML validation errors (framework/widget)
[ https://issues.apache.org/jira/browse/OFBIZ-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851253#action_12851253 ] Adrian Crum commented on OFBIZ-3623: Blas, Thank you for all the work you did on this. There are a couple of items in your patch that need attention: 1. In MacroFormRenderer.java, can we run the contents of autoCompleterTarget through UtilHttp.encodeAmpersands to encode the ampersands? 2. In HtmlFormRenderer.java you check for: "modelFormField.getWidgetStyle().length() > 0" - that check was done three lines up. Your second check is not needed. 3. Could we give modelMenu.passConditionCount a better name? Like displayedMenuItemCount? Or something similar? I know this seems trivial, but it would make more sense to others looking at the code. I struggle with giving methods meaningful names myself, so maybe others could help out here. We need to name a method that takes all available menu items, and only returns the count of the ones that pass a set of conditions. > XHTML validation errors (framework/widget) > -- > > Key: OFBIZ-3623 > URL: https://issues.apache.org/jira/browse/OFBIZ-3623 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk >Reporter: Blas Rodriguez Somoza >Assignee: Adrian Crum >Priority: Trivial > Fix For: SVN trunk > > Attachments: OFBIZ-3623_framework_widget_xhtml.diff > > > XHTML validation errors > * Unclosed INPUT > * attributes without values (checked, selected, disabled, etc) > * attribute values without " > * Uppercase tags or attributes. > * Unencoded ampersands in urls. > Other errors: > htmlFormMacroLibrary.ftl > Line 452. img tag must have src and alt attributes. > /> > htmlScreenMacroLibrary.ftl > Wrong markup at Line 143. Entity without final ; > >Â > Changes in java classes: > MacroFormRenderer.java (renderSortField) > The sort URL must use encoded ampersands. > HtmlFormRenderer.java (renderDisplayField) > The alert style must be included in the class attribute not appear as a > attribute name (which is what happens now) > HtmlMenuRenderer.java (renderMenuOpen, renderMenuClose) > XHTML don't like empty UL. To avoid that, the renderMenuOpen and > renderMenuClose methods need to know how many menu items pass the condition > and so will be included. > ModelMenu.java (public int passConditionCount) > New method to get how many menu items pass the condition. > ModelMenuItem (public boolean passCondition) > New method to get if the menu item pass the condition. > Patch attached -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-3610) XHTML validation errors (workeffort)
[ https://issues.apache.org/jira/browse/OFBIZ-3610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-3610: -- Assignee: Adrian Crum > XHTML validation errors (workeffort) > > > Key: OFBIZ-3610 > URL: https://issues.apache.org/jira/browse/OFBIZ-3610 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: SVN trunk >Reporter: Blas Rodriguez Somoza >Assignee: Adrian Crum >Priority: Trivial > Fix For: SVN trunk > > Attachments: OFBIZ-3610_workeffort_xhtml.diff > > > XHTML validation errors > * Unclosed INPUT > * attributes without values (checked, selected, disabled, etc) > * attribute values without " > * Uppercase tags or attributes. > * Unencoded ampersands in urls. > Patch attached -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3610) XHTML validation errors (workeffort)
[ https://issues.apache.org/jira/browse/OFBIZ-3610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851259#action_12851259 ] Adrian Crum commented on OFBIZ-3610: Fixed, rev 928994. Thanks Blas! > XHTML validation errors (workeffort) > > > Key: OFBIZ-3610 > URL: https://issues.apache.org/jira/browse/OFBIZ-3610 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: SVN trunk >Reporter: Blas Rodriguez Somoza >Assignee: Adrian Crum >Priority: Trivial > Fix For: SVN trunk > > Attachments: OFBIZ-3610_workeffort_xhtml.diff > > > XHTML validation errors > * Unclosed INPUT > * attributes without values (checked, selected, disabled, etc) > * attribute values without " > * Uppercase tags or attributes. > * Unencoded ampersands in urls. > Patch attached -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3610) XHTML validation errors (workeffort)
[ https://issues.apache.org/jira/browse/OFBIZ-3610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-3610. -- Resolution: Fixed > XHTML validation errors (workeffort) > > > Key: OFBIZ-3610 > URL: https://issues.apache.org/jira/browse/OFBIZ-3610 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: SVN trunk >Reporter: Blas Rodriguez Somoza >Assignee: Adrian Crum >Priority: Trivial > Fix For: SVN trunk > > Attachments: OFBIZ-3610_workeffort_xhtml.diff > > > XHTML validation errors > * Unclosed INPUT > * attributes without values (checked, selected, disabled, etc) > * attribute values without " > * Uppercase tags or attributes. > * Unencoded ampersands in urls. > Patch attached -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3623) XHTML validation errors (framework/widget)
[ https://issues.apache.org/jira/browse/OFBIZ-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-3623. -- Resolution: Fixed Fixed, rev 929173. Thanks Blas! > XHTML validation errors (framework/widget) > -- > > Key: OFBIZ-3623 > URL: https://issues.apache.org/jira/browse/OFBIZ-3623 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk >Reporter: Blas Rodriguez Somoza >Assignee: Adrian Crum >Priority: Trivial > Fix For: SVN trunk > > Attachments: OFBIZ-3623_framework_widget_xhtml.diff, > OFBIZ-3623_framework_widget_xhtml_v2.diff > > > XHTML validation errors > * Unclosed INPUT > * attributes without values (checked, selected, disabled, etc) > * attribute values without " > * Uppercase tags or attributes. > * Unencoded ampersands in urls. > Other errors: > htmlFormMacroLibrary.ftl > Line 452. img tag must have src and alt attributes. > /> > htmlScreenMacroLibrary.ftl > Wrong markup at Line 143. Entity without final ; > >Â > Changes in java classes: > MacroFormRenderer.java (renderSortField) > The sort URL must use encoded ampersands. > HtmlFormRenderer.java (renderDisplayField) > The alert style must be included in the class attribute not appear as a > attribute name (which is what happens now) > HtmlMenuRenderer.java (renderMenuOpen, renderMenuClose) > XHTML don't like empty UL. To avoid that, the renderMenuOpen and > renderMenuClose methods need to know how many menu items pass the condition > and so will be included. > ModelMenu.java (public int passConditionCount) > New method to get how many menu items pass the condition. > ModelMenuItem (public boolean passCondition) > New method to get if the menu item pass the condition. > Patch attached -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3630) Fix .classpath for hamcrest.jar inclusion
[ https://issues.apache.org/jira/browse/OFBIZ-3630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851982#action_12851982 ] Adrian Crum commented on OFBIZ-3630: I'm confused. How can this issue be fixed if it hasn't been committed? If you close an issue before it is committed, then how will committers find it when they search for open issues? > Fix .classpath for hamcrest.jar inclusion > - > > Key: OFBIZ-3630 > URL: https://issues.apache.org/jira/browse/OFBIZ-3630 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: SVN trunk >Reporter: Bob Morley > Fix For: SVN trunk > > Attachments: OFBIZ-3630_AddHamcrestToClasspath.patch > > > It appears that the hamcrest.jar has been added to help in some of the cache > related unit tests. This just adds it to the .classpath so that the project > can compile in Eclipse. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3630) Fix .classpath for hamcrest.jar inclusion
[ https://issues.apache.org/jira/browse/OFBIZ-3630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851990#action_12851990 ] Adrian Crum commented on OFBIZ-3630: Bob, Thanks for the explanation. From my perspective, no additional discussion is needed - I understand now. > Fix .classpath for hamcrest.jar inclusion > - > > Key: OFBIZ-3630 > URL: https://issues.apache.org/jira/browse/OFBIZ-3630 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: SVN trunk >Reporter: Bob Morley > Fix For: SVN trunk > > Attachments: OFBIZ-3630_AddHamcrestToClasspath.patch > > > It appears that the hamcrest.jar has been added to help in some of the cache > related unit tests. This just adds it to the .classpath so that the project > can compile in Eclipse. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3526) Expression startDate.compareTo is undefined on line 60, column 11 in component://workeffort/webapp/workeffort/calendar/week.ftl
[ https://issues.apache.org/jira/browse/OFBIZ-3526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-3526. -- Resolution: Cannot Reproduce > Expression startDate.compareTo is undefined on line 60, column 11 in > component://workeffort/webapp/workeffort/calendar/week.ftl > --- > > Key: OFBIZ-3526 > URL: https://issues.apache.org/jira/browse/OFBIZ-3526 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: SVN trunk > Environment: https://ofbiz-vm.apache.org/workeffort/control/calendar >Reporter: chris snow > > https://ofbiz-vm.apache.org/workeffort/control/calendar > returns: > Expression startDate.compareTo is undefined on line 60, column 11 in > component://workeffort/webapp/workeffort/calendar/week.ftl. The problematic > instruction: -- ==> if-else [on line 60, column 5 in > component://workeffort/webapp/workeffort/calendar/week.ftl] -- Java > backtrace for programmers: -- > freemarker.core.InvalidReferenceException: Expression startDate.compareTo is > undefined on line 60, column 11 in > component://workeffort/webapp/workeffort/calendar/week.ftl. at > freemarker.core.TemplateObject.assertNonNull(TemplateObject.java:124) at > freemarker.core.TemplateObject.invalidTypeException(TemplateObject.java:134) > at freemarker.core.MethodCall._getAsTemplateModel(MethodCall.java:114) at > freemarker.core.Expression.getAsTemplateModel(Expression.java:89) at > freemarker.core.ComparisonExpression.isTrue(ComparisonExpression.java:111) at > freemarker.core.AndExpression.isTrue(AndExpression.java:68) at > freemarker.core.AndExpression.isTrue(AndExpression.java:68) at > freemarker.core.ParentheticalExpression.isTrue(ParentheticalExpression.java:66) > at freemarker.core.IfBlock.accept(IfBlock.java:80) at > freemarker.core.Environment.visit(Environment.java:209) at > freemarker.core.MixedContent.accept(MixedContent.java:92) at > freemarker.core.Environment.visit(Environment.java:209) at > freemarker.core.ConditionalBlock.accept(ConditionalBlock.java:79) at > freemarker.core.Environment.visit(Environment.java:209) at > freemarker.core.MixedContent.accept(MixedContent.java:92) at > freemarker.core.Environment.visit(Environment.java:209) at > freemarker.core.IteratorBlock$Context.runLoop(IteratorBlock.java:167) at > freemarker.core.Environment.visit(Environment.java:416) at > freemarker.core.IteratorBlock.accept(IteratorBlock.java:102) at > freemarker.core.Environment.visit(Environment.java:209) at > freemarker.core.MixedContent.accept(MixedContent.java:92) at > freemarker.core.Environment.visit(Environment.java:209) at > freemarker.core.IteratorBlock$Context.runLoop(IteratorBlock.java:167) at > freemarker.core.Environment.visit(Environment.java:416) at > freemarker.core.IteratorBlock.accept(IteratorBlock.java:102) at > freemarker.core.Environment.visit(Environment.java:209) at > freemarker.core.MixedContent.accept(MixedContent.java:92) at > freemarker.core.Environment.visit(Environment.java:209) at > freemarker.core.IfBlock.accept(IfBlock.java:82) at > freemarker.core.Environment.visit(Environment.java:209) at > freemarker.core.MixedContent.accept(MixedContent.java:92) at > freemarker.core.Environment.visit(Environment.java:209) at > freemarker.core.Environment.process(Environment.java:189) at > org.ofbiz.base.util.template.FreeMarkerWorker.renderTemplate(FreeMarkerWorker.java:205) > at > org.ofbiz.widget.screen.HtmlWidget.renderHtmlTemplate(HtmlWidget.java:205) at > org.ofbiz.widget.screen.HtmlWidget$HtmlTemplate.renderWidgetString(HtmlWidget.java:250) > at > org.ofbiz.widget.screen.HtmlWidget.renderWidgetString(HtmlWidget.java:110) at > org.ofbiz.widget.screen.ModelScreenWidget$PlatformSpecific.renderWidgetString(ModelScreenWidget.java:1001) > at > org.ofbiz.widget.screen.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:704) > at > org.ofbiz.widget.screen.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:408) > at > org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:137) > at > org.ofbiz.widget.screen.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:296) > at > org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:137) > at > org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:228) > at > org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:137) > at > org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:228) > at > org.ofbiz.widget.screen.ModelScreen.renderScreenString(ModelScr
[jira] Closed: (OFBIZ-2969) UEL errors in picklist services
[ https://issues.apache.org/jira/browse/OFBIZ-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-2969. -- Resolution: Fixed > UEL errors in picklist services > --- > > Key: OFBIZ-2969 > URL: https://issues.apache.org/jira/browse/OFBIZ-2969 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 9.04, SVN trunk >Reporter: Wickersheimer Jeremy >Assignee: Adrian Crum > Fix For: Release Branch 9.04, SVN trunk > > Attachments: jira-2969.patch > > > Like https://issues.apache.org/jira/browse/OFBIZ-2513 but in the other simple > methods. > I had the problem in `getPickAndPackReportInfo` but since i was at it i also > fixed the other methods but did not test them. > Patch coming. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-2723) OFBiz 09.04 Chinese Localization
[ https://issues.apache.org/jira/browse/OFBIZ-2723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-2723. -- Resolution: Won't Fix Fix Version/s: Release Branch 9.04 Chinese UI labels were updated in the trunk. This issue contains the necessary patches if someone wants to patch their local 9.04 copy. > OFBiz 09.04 Chinese Localization > > > Key: OFBIZ-2723 > URL: https://issues.apache.org/jira/browse/OFBIZ-2723 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Release Branch 9.04 >Reporter: Shi Yusen >Assignee: Adrian Crum > Fix For: Release Branch 9.04 > > Attachments: localization-zh-09.04-applications-accounting.patch, > localization-zh-09.04-applications-content.patch, > localization-zh-09.04-applications-humanres.patch, > localization-zh-09.04-applications-manufacturing.patch, > localization-zh-09.04-applications-marketing.patch, > localization-zh-09.04-applications-order.patch, > localization-zh-09.04-applications-party.patch, > localization-zh-09.04-applications-product.patch, > localization-zh-09.04-applications-workeffort.patch, > localization-zh-09.04-framework-bi.patch, > localization-zh-09.04-framework-common.patch, > localization-zh-09.04-framework-example.patch, > localization-zh-09.04-framework-guiapp.patch, > localization-zh-09.04-framework-resources.patch, > localization-zh-09.04-framework-security.patch, > localization-zh-09.04-framework-webapp.patch, > localization-zh-09.04-framework-webtools.patch, > localization-zh-09.04-framework-widget.patch, > localization-zh-09.04-specialpurpose-assetmaint.patch, > localization-zh-09.04-specialpurpose-ebay.patch, > localization-zh-09.04-specialpurpose-ecommerce.patch, > localization-zh-09.04-specialpurpose-googlebase.patch, > localization-zh-09.04-specialpurpose-myportal.patch, > localization-zh-09.04-specialpurpose-oagis.patch, > localization-zh-09.04-specialpurpose-pos.patch, > localization-zh-09.04-specialpurpose-projectmgr.patch, > localization-zh-09.04-specialpurpose-shark.patch, > localization-zh-09.04-specialpurpose-webpos.patch, > localization-zh-09.04-specialpurpose-workflow.patch, ofbiz-zh_9.04.zip > > > I have started to localize OFBiz 09.04 to Chinese. I'll put all the patches > in this issue. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1361) Mark UtilDateTime.java deprecated methods as deprecated
[ https://issues.apache.org/jira/browse/OFBIZ-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-1361: -- Assignee: (was: Adrian Crum) I'm removing myself from this issue because it is too controversial. If someone else wants to work on it they are welcome to do so. > Mark UtilDateTime.java deprecated methods as deprecated > --- > > Key: OFBIZ-1361 > URL: https://issues.apache.org/jira/browse/OFBIZ-1361 > Project: OFBiz > Issue Type: Improvement > Components: framework >Reporter: Adrian Crum >Priority: Minor > Attachments: UtilDateTime.patch > > > Now that user-selected locale and time support has been added to the > framework, it's time to start weeding out date/time code that doesn't use the > Locale and TimeZone objects. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-3592) application - workeffort
[ https://issues.apache.org/jira/browse/OFBIZ-3592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-3592: -- Assignee: Adrian Crum > application - workeffort > > > Key: OFBIZ-3592 > URL: https://issues.apache.org/jira/browse/OFBIZ-3592 > Project: OFBiz > Issue Type: Sub-task >Reporter: Bob Morley >Assignee: Adrian Crum > Fix For: SVN trunk > > Attachments: OFBIZ-3592_ResolveJavaWarningsWorkeffort.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3632) Extending the service model to specify more complex permissions using permission service
[
https://issues.apache.org/jira/browse/OFBIZ-3632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12852384#action_12852384
]
Adrian Crum commented on OFBIZ-3632:
Have you looked at the new security design in
https://svn.apache.org/repos/asf/ofbiz/branches/executioncontext20091231?
> Extending the service model to specify more complex permissions using
> permission service
>
>
> Key: OFBIZ-3632
> URL: https://issues.apache.org/jira/browse/OFBIZ-3632
> Project: OFBiz
> Issue Type: Improvement
> Components: framework, product
>Reporter: Vikas Mayur
>Priority: Minor
> Fix For: SVN trunk
>
> Attachments: permission.patch
>
>
> At present in the service definition allows only one
> permission service. I have extended the tag to
> specify more then one permission services by doing an AND/OR operation.
> For instance the following code in service definition
> {code}
>
> main-action="CREATE"/>
> main-action="UPDATE"/>
>
> {code}
> will replace the following code in service implementation.
> {code}
>
>
>
>
>
>
> {code}
> Similarly the code
> {code}
>
> main-action="CREATE"/>
> main-action="UPDATE"/>
>
> {code}
> will replace
> {code}
>
>
>
>
>
> {code}
> The patch also contains additional changes where the permission service is
> defined in the service definition.
> EDITS: Added missing ending \{code\} tag for the last code snippet
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3632) Extending the service model to specify more complex permissions using permission service
[
https://issues.apache.org/jira/browse/OFBIZ-3632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12852453#action_12852453
]
Adrian Crum commented on OFBIZ-3632:
I mentioned it mostly as a reminder that there is a solution to your problem
already - it just needs to get tested and committed. The timeline depends on
the rest of the community - the sooner others spend time with it, the sooner it
will get committed.
> Extending the service model to specify more complex permissions using
> permission service
>
>
> Key: OFBIZ-3632
> URL: https://issues.apache.org/jira/browse/OFBIZ-3632
> Project: OFBiz
> Issue Type: Improvement
> Components: framework, product
>Reporter: Vikas Mayur
>Priority: Minor
> Fix For: SVN trunk
>
> Attachments: permission.patch
>
>
> At present in the service definition allows only one
> permission service. I have extended the tag to
> specify more then one permission services by doing an AND/OR operation.
> For instance the following code in service definition
> {code}
>
> main-action="CREATE"/>
> main-action="UPDATE"/>
>
> {code}
> will replace the following code in service implementation.
> {code}
>
>
>
>
>
>
> {code}
> Similarly the code
> {code}
>
> main-action="CREATE"/>
> main-action="UPDATE"/>
>
> {code}
> will replace
> {code}
>
>
>
>
>
> {code}
> The patch also contains additional changes where the permission service is
> defined in the service definition.
> EDITS: Added missing ending \{code\} tag for the last code snippet
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3582) unable to intialize tenant Database
[ https://issues.apache.org/jira/browse/OFBIZ-3582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853035#action_12853035 ] Adrian Crum commented on OFBIZ-3582: I get the same error. Maybe what is needed is an explanation of the correct steps necessary to initialize a tenant database. In other words, some basic documentation on how to use the multi-tenant capability would be helpful. > unable to intialize tenant Database > --- > > Key: OFBIZ-3582 > URL: https://issues.apache.org/jira/browse/OFBIZ-3582 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Candidate Branch 10.04, SVN trunk > Environment: SINCE version 927271 using the Tenant login. >Reporter: BJ Freeman >Assignee: Jacques Le Roux >Priority: Trivial > > use the line > java -Xmx512m -XX:MaxPermSize=128m -jar ofbiz.jar -install > -delegator=default#DEMO1 > when the Delegator is created it looks for a Tenant record with then new > delegator for DEMO1, but it has not been loaded yet so get a error. > log of error. > 2010-03-28 15:25:31,406 (main) [ EntityEcaUtil.java:128:INFO ] Loaded > [1] E > ntity ECA definitions from > C:/projects/java/ofbizf_new/applications/commonext/en > titydef/eecas.xml in loader main > 2010-03-28 15:25:31,437 (main) [DelegatorFactoryImpl.java:35 :ERROR] > exception report > -- > Error creating delegator > Exception: org.ofbiz.entity.GenericEntityException > Message: No Tenant record found for delegator [default#DEMO1] with tenantId > [DEM > O1] > stack trace > --- > org.ofbiz.entity.GenericEntityException: No Tenant record found for delegator > [d > efault#DEMO1] with tenantId [DEMO1] > org.ofbiz.entity.GenericDelegator.(GenericDelegator.java:230) > org.ofbiz.entity.DelegatorFactoryImpl.getInstance(DelegatorFactoryImpl.java:33) > org.ofbiz.entity.DelegatorFactoryImpl.getInstance(DelegatorFactoryImpl.java:25) > org.ofbiz.base.util.UtilObject.getObjectFromFactory(UtilObject.java:202) > org.ofbiz.entity.DelegatorFactory.getDelegator(DelegatorFactory.java:47) > org.ofbiz.entityext.data.EntityDataLoadContainer.start(EntityDataLoadContainer.j > ava:230) > org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:100) > org.ofbiz.base.start.Start.startStartLoaders(Start.java:272) > org.ofbiz.base.start.Start.startServer(Start.java:322) > org.ofbiz.base.start.Start.start(Start.java:326) > org.ofbiz.base.start.Start.main(Start.java:411) > > Exception in thread "main" java.lang.NullPointerException > 2010-03-28 15:25:31,437 (main) [ DelegatorFactory.java:49 :ERROR] > exception report > -- > Exception: java.lang.ClassNotFoundException > Message: java.lang.Class > stack trace > --- > java.lang.ClassNotFoundException: java.lang.Class > org.ofbiz.base.util.UtilObject.getObjectFromFactory(UtilObject.java:207) > org.ofbiz.entity.DelegatorFactory.getDelegator(DelegatorFactory.java:47) > org.ofbiz.entityext.data.EntityDataLoadContainer.start(EntityDataLoadContainer.j > ava:230) > org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:100) > org.ofbiz.base.start.Start.startStartLoaders(Start.java:272) > org.ofbiz.base.start.Start.startServer(Start.java:322) > org.ofbiz.base.start.Start.start(Start.java:326) > org.ofbiz.base.start.Start.main(Start.java:411) > > at java.util.concurrent.ConcurrentHashMap.putIfAbsent(Unknown Source) > at > org.ofbiz.entity.DelegatorFactory.getDelegator(DelegatorFactory.java: > 52) > at > org.ofbiz.entityext.data.EntityDataLoadContainer.start(EntityDataLoad > Container.java:230) > at > org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:1 > 00) > at org.ofbiz.base.start.Start.startStartLoaders(Start.java:272) > at org.ofbiz.base.start.Start.startServer(Start.java:322) > at org.ofbiz.base.start.Start.start(Start.java:326) > at org.ofbiz.base.start.Start.main(Start.java:411) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3582) unable to intialize tenant Database
[ https://issues.apache.org/jira/browse/OFBIZ-3582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853065#action_12853065 ] Adrian Crum commented on OFBIZ-3582: David, There is no need for you to comment. We will work out the problem on our own. I see part of the problem: BJ is using the command java -Xmx512m -XX:MaxPermSize=128m -jar ofbiz.jar -install -delegator=default#DEMO1 and the Wiki page says to use java -Xmx512m -XX:MaxPermSize=128m -jar ofbiz.jar -install -readers=seed -delegator=default#DEMO1 but even that command generates the error 2010-04-02 20:08:18,390 (main) [DelegatorFactoryImpl.java:35 :ERROR] exception report -- Error creating delegator Exception: org.ofbiz.entity.GenericEntityException Message: No Tenant record found for delegator [default#DEMO1] with tenantId [DEMO1] stack trace --- org.ofbiz.entity.GenericEntityException: No Tenant record found for delegator [default#DEMO1] with tenantId [DEMO1] org.ofbiz.entity.GenericDelegator.(GenericDelegator.java:230) org.ofbiz.entity.DelegatorFactoryImpl.getInstance(DelegatorFactoryImpl.java:33) org.ofbiz.entity.DelegatorFactoryImpl.getInstance(DelegatorFactoryImpl.java:25) org.ofbiz.base.util.UtilObject.getObjectFromFactory(UtilObject.java:202) org.ofbiz.entity.DelegatorFactory.getDelegator(DelegatorFactory.java:47) org.ofbiz.entityext.data.EntityDataLoadContainer.start(EntityDataLoadContainer.java:230) org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:100) org.ofbiz.base.start.Start.startStartLoaders(Start.java:272) org.ofbiz.base.start.Start.startServer(Start.java:322) org.ofbiz.base.start.Start.start(Start.java:326) org.ofbiz.base.start.Start.main(Start.java:411) 2010-04-02 20:08:18,390 (main) [ DelegatorFactory.java:49 :ERROR] exception report -- Exception: java.lang.ClassNotFoundException Message: java.lang.Class stack trace --- java.lang.ClassNotFoundException: java.lang.Class org.ofbiz.base.util.UtilObject.getObjectFromFactory(UtilObject.java:207) org.ofbiz.entity.DelegatorFactory.getDelegator(DelegatorFactory.java:47) org.ofbiz.entityext.data.EntityDataLoadContainer.start(EntityDataLoadContainer.java:230) org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:100) org.ofbiz.base.start.Start.startStartLoaders(Start.java:272) org.ofbiz.base.start.Start.startServer(Start.java:322) org.ofbiz.base.start.Start.start(Start.java:326) org.ofbiz.base.start.Start.main(Start.java:411) So, I tried executing each line on the Wiki page in sequence, in case there was an issue with skipping a command. The fourth command java -Xmx512m -XX:MaxPermSize=128m -jar ofbiz.jar -install -readers=seed -delegator=default#DEMO1 generated this error 2010-04-02 20:15:56,750 (main) [DelegatorFactoryImpl.java:35 :ERROR] exception report -- Error creating delegator Exception: org.ofbiz.entity.GenericEntityException Message: No Tenant record found for delegator [default#DEMO1] with tenantId [DEMO1] stack trace --- org.ofbiz.entity.GenericEntityException: No Tenant record found for delegator [default#DEMO1] with tenantId [DEMO1] org.ofbiz.entity.GenericDelegator.(GenericDelegator.java:230) org.ofbiz.entity.DelegatorFactoryImpl.getInstance(DelegatorFactoryImpl.java:33) org.ofbiz.entity.DelegatorFactoryImpl.getInstance(DelegatorFactoryImpl.java:25) org.ofbiz.base.util.UtilObject.getObjectFromFactory(UtilObject.java:202) org.ofbiz.entity.DelegatorFactory.getDelegator(DelegatorFactory.java:47) org.ofbiz.entityext.data.EntityDataLoadContainer.start(EntityDataLoadContainer.java:230) org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:100) org.ofbiz.base.start.Start.startStartLoaders(Start.java:272) org.ofbiz.base.start.Start.startServer(Start.java:322) org.ofbiz.base.start.Start.start(Start.java:326) org.ofbiz.base.start.Start.main(Start.java:411) 2010-04-02 20:15:56,750 (main) [ DelegatorFactory.java:49 :ERROR] exception report -- Exception: java.lang.ClassNotFoundException Message: java.lang.Class stack trace --- java.lang.ClassNotFoundException: java.lang.Class org.ofbiz.base.util.UtilObject.getObjectFromFactory(UtilObject.java:207) org.ofbiz.entity.DelegatorFactory.getDelegator(D
[jira] Closed: (OFBIZ-3582) unable to intialize tenant Database
[ https://issues.apache.org/jira/browse/OFBIZ-3582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-3582. -- Resolution: Fixed I found the problem and updated the Wiki page. The multi-tenancy works with the corrected instructions. > unable to intialize tenant Database > --- > > Key: OFBIZ-3582 > URL: https://issues.apache.org/jira/browse/OFBIZ-3582 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Candidate Branch 10.04, SVN trunk > Environment: SINCE version 927271 using the Tenant login. >Reporter: BJ Freeman >Assignee: Jacques Le Roux >Priority: Trivial > > use the line > java -Xmx512m -XX:MaxPermSize=128m -jar ofbiz.jar -install > -delegator=default#DEMO1 > when the Delegator is created it looks for a Tenant record with then new > delegator for DEMO1, but it has not been loaded yet so get a error. > log of error. > 2010-03-28 15:25:31,406 (main) [ EntityEcaUtil.java:128:INFO ] Loaded > [1] E > ntity ECA definitions from > C:/projects/java/ofbizf_new/applications/commonext/en > titydef/eecas.xml in loader main > 2010-03-28 15:25:31,437 (main) [DelegatorFactoryImpl.java:35 :ERROR] > exception report > -- > Error creating delegator > Exception: org.ofbiz.entity.GenericEntityException > Message: No Tenant record found for delegator [default#DEMO1] with tenantId > [DEM > O1] > stack trace > --- > org.ofbiz.entity.GenericEntityException: No Tenant record found for delegator > [d > efault#DEMO1] with tenantId [DEMO1] > org.ofbiz.entity.GenericDelegator.(GenericDelegator.java:230) > org.ofbiz.entity.DelegatorFactoryImpl.getInstance(DelegatorFactoryImpl.java:33) > org.ofbiz.entity.DelegatorFactoryImpl.getInstance(DelegatorFactoryImpl.java:25) > org.ofbiz.base.util.UtilObject.getObjectFromFactory(UtilObject.java:202) > org.ofbiz.entity.DelegatorFactory.getDelegator(DelegatorFactory.java:47) > org.ofbiz.entityext.data.EntityDataLoadContainer.start(EntityDataLoadContainer.j > ava:230) > org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:100) > org.ofbiz.base.start.Start.startStartLoaders(Start.java:272) > org.ofbiz.base.start.Start.startServer(Start.java:322) > org.ofbiz.base.start.Start.start(Start.java:326) > org.ofbiz.base.start.Start.main(Start.java:411) > > Exception in thread "main" java.lang.NullPointerException > 2010-03-28 15:25:31,437 (main) [ DelegatorFactory.java:49 :ERROR] > exception report > -- > Exception: java.lang.ClassNotFoundException > Message: java.lang.Class > stack trace > --- > java.lang.ClassNotFoundException: java.lang.Class > org.ofbiz.base.util.UtilObject.getObjectFromFactory(UtilObject.java:207) > org.ofbiz.entity.DelegatorFactory.getDelegator(DelegatorFactory.java:47) > org.ofbiz.entityext.data.EntityDataLoadContainer.start(EntityDataLoadContainer.j > ava:230) > org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:100) > org.ofbiz.base.start.Start.startStartLoaders(Start.java:272) > org.ofbiz.base.start.Start.startServer(Start.java:322) > org.ofbiz.base.start.Start.start(Start.java:326) > org.ofbiz.base.start.Start.main(Start.java:411) > > at java.util.concurrent.ConcurrentHashMap.putIfAbsent(Unknown Source) > at > org.ofbiz.entity.DelegatorFactory.getDelegator(DelegatorFactory.java: > 52) > at > org.ofbiz.entityext.data.EntityDataLoadContainer.start(EntityDataLoad > Container.java:230) > at > org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:1 > 00) > at org.ofbiz.base.start.Start.startStartLoaders(Start.java:272) > at org.ofbiz.base.start.Start.startServer(Start.java:322) > at org.ofbiz.base.start.Start.start(Start.java:326) > at org.ofbiz.base.start.Start.main(Start.java:411) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3592) application - workeffort
[ https://issues.apache.org/jira/browse/OFBIZ-3592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-3592. -- Resolution: Fixed Fixed, rev 930626. Thanks Bob! I didn't apply the patch to ICalRecurConverter because a utility method isn't needed. Most of those ical4j classes extend ArrayList, so they can be cast to a List to fix the warnings. Even after doing that, the code starts to look really messy. I decided to leave it as-is for now and check to see if a newer version of ical4j is available that is written for Java 5 or later. > application - workeffort > > > Key: OFBIZ-3592 > URL: https://issues.apache.org/jira/browse/OFBIZ-3592 > Project: OFBiz > Issue Type: Sub-task >Reporter: Bob Morley >Assignee: Adrian Crum > Fix For: SVN trunk > > Attachments: OFBIZ-3592_ResolveJavaWarningsWorkeffort.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-3622) XHTML validation errors (framework excluding widget)
[
https://issues.apache.org/jira/browse/OFBIZ-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrian Crum reassigned OFBIZ-3622:
--
Assignee: Adrian Crum
> XHTML validation errors (framework excluding widget)
>
>
> Key: OFBIZ-3622
> URL: https://issues.apache.org/jira/browse/OFBIZ-3622
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: SVN trunk
>Reporter: Blas Rodriguez Somoza
>Assignee: Adrian Crum
>Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ_3622-framework_nowidget_xhtml.diff
>
>
> XHTML validation errors
> * Unclosed INPUT
> * attributes without values (checked, selected, disabled, etc)
> * attribute values without "
> * Uppercase tags or attributes.
> * Unencoded ampersands in urls.
> Other errors:
> showPortalPage.ftl
> Wrong markup in line 23. td with pure numeric id and nonexistent name
> attribute
> .. id="${portalPageColumn.columnSeqId}" name="portalColumn">
> Wrong markup in line 30. div with pure numeric id and nonexistent name
> attribute
>
> Solution: make id = name value + id value and remove name
> xmlsdsdump.ftl
> Line 105 to 122 generates
>
>
>
> But xhtml don't like an empty tr.
> Solution: changing line 110 from <#if entCount % 3 == 0> to <#if entCount %
> 3 == 0 && entCount != 0> solves the problem
> SearchLabels.ftl
> Wrong markup at line 22. Text can't be directly inside tr.
> ${uiLabelMap.WebtoolsLabelManagerTemporarySearchTitle}
> Solution: added ...
> serviceResult.ftl
> Wrong markup in line 43. Entity without final ;
> Â
> threads.ftl
> Wrong markup at line 61 and 62. Unclosed p tags.
> Patch attached
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-3593) specialpurpose - assetmaint
[ https://issues.apache.org/jira/browse/OFBIZ-3593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-3593: -- Assignee: Adrian Crum > specialpurpose - assetmaint > --- > > Key: OFBIZ-3593 > URL: https://issues.apache.org/jira/browse/OFBIZ-3593 > Project: OFBiz > Issue Type: Sub-task >Reporter: Bob Morley >Assignee: Adrian Crum > Fix For: SVN trunk > > Attachments: OFBIZ-3593_ResolveJavaWarningsAssetmaint.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3543) Ability to use the actual form name in javascript snippets in extended forms
[ https://issues.apache.org/jira/browse/OFBIZ-3543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853254#action_12853254 ] Adrian Crum commented on OFBIZ-3543: Form widgets should not contain javascript snippets. Javascript is confined to HTML rendering and the form widgets are supposed to be rendering format agnostic. > Ability to use the actual form name in javascript snippets in extended forms > > > Key: OFBIZ-3543 > URL: https://issues.apache.org/jira/browse/OFBIZ-3543 > Project: OFBiz > Issue Type: Improvement >Reporter: Jacques Le Roux >Priority: Minor > > For now, when you extend a form containing javascript snippets which use the > form name (document.formName.fieldName) you have to pass the real name of the > form into the javascript snippets. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3546) FreeMarkerViewHandler should load templates via the FreeMarkerWorker
[ https://issues.apache.org/jira/browse/OFBIZ-3546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853255#action_12853255 ] Adrian Crum commented on OFBIZ-3546: A better solution would be to switch those screens to screen widgets. > FreeMarkerViewHandler should load templates via the FreeMarkerWorker > > > Key: OFBIZ-3546 > URL: https://issues.apache.org/jira/browse/OFBIZ-3546 > Project: OFBiz > Issue Type: Bug > Components: framework >Reporter: Bruno Busco > > This bug has been introduced in r920115. > A temporary fix is in r920589: Fix a problem reported by Hans Bakker, > FreeMarker templates loaded using the Configuration object don't have access > to the component:// notation reader and this causes them to fail because all > templates now attempt to retrieve the html form macro library using that > notation. This is a quick fix but we should really fix the > FreeMarkerViewHandler to load templates via the FreeMarkerWorker. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3622) XHTML validation errors (framework excluding widget)
[
https://issues.apache.org/jira/browse/OFBIZ-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrian Crum closed OFBIZ-3622.
--
Resolution: Fixed
Fixed, rev 930701. Thanks Blas!
> XHTML validation errors (framework excluding widget)
>
>
> Key: OFBIZ-3622
> URL: https://issues.apache.org/jira/browse/OFBIZ-3622
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: SVN trunk
>Reporter: Blas Rodriguez Somoza
>Assignee: Adrian Crum
>Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ_3622-framework_nowidget_xhtml.diff
>
>
> XHTML validation errors
> * Unclosed INPUT
> * attributes without values (checked, selected, disabled, etc)
> * attribute values without "
> * Uppercase tags or attributes.
> * Unencoded ampersands in urls.
> Other errors:
> showPortalPage.ftl
> Wrong markup in line 23. td with pure numeric id and nonexistent name
> attribute
> .. id="${portalPageColumn.columnSeqId}" name="portalColumn">
> Wrong markup in line 30. div with pure numeric id and nonexistent name
> attribute
>
> Solution: make id = name value + id value and remove name
> xmlsdsdump.ftl
> Line 105 to 122 generates
>
>
>
> But xhtml don't like an empty tr.
> Solution: changing line 110 from <#if entCount % 3 == 0> to <#if entCount %
> 3 == 0 && entCount != 0> solves the problem
> SearchLabels.ftl
> Wrong markup at line 22. Text can't be directly inside tr.
> ${uiLabelMap.WebtoolsLabelManagerTemporarySearchTitle}
> Solution: added ...
> serviceResult.ftl
> Wrong markup in line 43. Entity without final ;
> Â
> threads.ftl
> Wrong markup at line 61 and 62. Unclosed p tags.
> Patch attached
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3593) specialpurpose - assetmaint
[ https://issues.apache.org/jira/browse/OFBIZ-3593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-3593. -- Resolution: Fixed Fixed, rev 930706. Thanks Bob! > specialpurpose - assetmaint > --- > > Key: OFBIZ-3593 > URL: https://issues.apache.org/jira/browse/OFBIZ-3593 > Project: OFBiz > Issue Type: Sub-task >Reporter: Bob Morley >Assignee: Adrian Crum > Fix For: SVN trunk > > Attachments: OFBIZ-3593_ResolveJavaWarningsAssetmaint.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3659) Download cobertura code coverage jar so it can be used to compile and execute tests with
[ https://issues.apache.org/jira/browse/OFBIZ-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-3659: --- Priority: Minor (was: Major) Issue Type: New Feature (was: Bug) > Download cobertura code coverage jar so it can be used to compile and execute > tests with > > > Key: OFBIZ-3659 > URL: https://issues.apache.org/jira/browse/OFBIZ-3659 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: SVN trunk >Reporter: Bob Morley >Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-3659_AutomateDownloadOfCobertura.patch > > > Framework executed around allowing use of cobertura to create code coverage > metrics as part of the Ofbiz build process. Licensing restricts distribution > of cobertura with Ofbiz, so we have taken the approach to attempt to download > it before doing our build so it is available for any container that wants > instrumentation turned on (currently only test-container). Net result is > when we run our tests we will now get very nice code coverage metrics being > generated. > There is an existing target to generate the cobertura report (html) which is > not automatically being executed. Once we get more reasonable code coverage > via unit testing we can automatically generate this and expose it as > appropriate. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3659) Download cobertura code coverage jar so it can be used to compile and execute tests with
[ https://issues.apache.org/jira/browse/OFBIZ-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854794#action_12854794 ] Adrian Crum commented on OFBIZ-3659: Downloading Cobertura should be a part of the test process, not the build process. Ideally, we should have a new ant target - "reports" or "metrics" - that would include this and other code-quality reports. > Download cobertura code coverage jar so it can be used to compile and execute > tests with > > > Key: OFBIZ-3659 > URL: https://issues.apache.org/jira/browse/OFBIZ-3659 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk >Reporter: Bob Morley > Fix For: SVN trunk > > Attachments: OFBIZ-3659_AutomateDownloadOfCobertura.patch > > > Framework executed around allowing use of cobertura to create code coverage > metrics as part of the Ofbiz build process. Licensing restricts distribution > of cobertura with Ofbiz, so we have taken the approach to attempt to download > it before doing our build so it is available for any container that wants > instrumentation turned on (currently only test-container). Net result is > when we run our tests we will now get very nice code coverage metrics being > generated. > There is an existing target to generate the cobertura report (html) which is > not automatically being executed. Once we get more reasonable code coverage > via unit testing we can automatically generate this and expose it as > appropriate. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3659) Download cobertura code coverage jar so it can be used to compile and execute tests with
[ https://issues.apache.org/jira/browse/OFBIZ-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854801#action_12854801 ] Adrian Crum commented on OFBIZ-3659: Huh? If it's a local copy, you're not distributing it. If you're distributing it, you would not include metrics libraries in the distribution. > Download cobertura code coverage jar so it can be used to compile and execute > tests with > > > Key: OFBIZ-3659 > URL: https://issues.apache.org/jira/browse/OFBIZ-3659 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: SVN trunk >Reporter: Bob Morley >Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-3659_AutomateDownloadOfCobertura.patch > > > Framework executed around allowing use of cobertura to create code coverage > metrics as part of the Ofbiz build process. Licensing restricts distribution > of cobertura with Ofbiz, so we have taken the approach to attempt to download > it before doing our build so it is available for any container that wants > instrumentation turned on (currently only test-container). Net result is > when we run our tests we will now get very nice code coverage metrics being > generated. > There is an existing target to generate the cobertura report (html) which is > not automatically being executed. Once we get more reasonable code coverage > via unit testing we can automatically generate this and expose it as > appropriate. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3659) Download cobertura code coverage jar so it can be used to compile and execute tests with
[ https://issues.apache.org/jira/browse/OFBIZ-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854804#action_12854804 ] Adrian Crum commented on OFBIZ-3659: Bob, Take a look at how Apache Commons does things. They download and execute a number of reporting tools that aren't included in the final library. It's pretty slick and extremely convenient. > Download cobertura code coverage jar so it can be used to compile and execute > tests with > > > Key: OFBIZ-3659 > URL: https://issues.apache.org/jira/browse/OFBIZ-3659 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: SVN trunk >Reporter: Bob Morley >Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-3659_AutomateDownloadOfCobertura.patch > > > Framework executed around allowing use of cobertura to create code coverage > metrics as part of the Ofbiz build process. Licensing restricts distribution > of cobertura with Ofbiz, so we have taken the approach to attempt to download > it before doing our build so it is available for any container that wants > instrumentation turned on (currently only test-container). Net result is > when we run our tests we will now get very nice code coverage metrics being > generated. > There is an existing target to generate the cobertura report (html) which is > not automatically being executed. Once we get more reasonable code coverage > via unit testing we can automatically generate this and expose it as > appropriate. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3659) Download cobertura code coverage jar so it can be used to compile and execute tests with
[ https://issues.apache.org/jira/browse/OFBIZ-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854808#action_12854808 ] Adrian Crum commented on OFBIZ-3659: Scott, If the user is running a separate ant task that downloads and executes a third-party library, then the user will be aware of it. We can even include that bit of information in the ant task's description. Compiling OFBiz != Downloading and executing code metrics. > Download cobertura code coverage jar so it can be used to compile and execute > tests with > > > Key: OFBIZ-3659 > URL: https://issues.apache.org/jira/browse/OFBIZ-3659 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: SVN trunk >Reporter: Bob Morley >Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-3659_AutomateDownloadOfCobertura.patch > > > Framework executed around allowing use of cobertura to create code coverage > metrics as part of the Ofbiz build process. Licensing restricts distribution > of cobertura with Ofbiz, so we have taken the approach to attempt to download > it before doing our build so it is available for any container that wants > instrumentation turned on (currently only test-container). Net result is > when we run our tests we will now get very nice code coverage metrics being > generated. > There is an existing target to generate the cobertura report (html) which is > not automatically being executed. Once we get more reasonable code coverage > via unit testing we can automatically generate this and expose it as > appropriate. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3659) Download cobertura code coverage jar so it can be used to compile and execute tests with
[ https://issues.apache.org/jira/browse/OFBIZ-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854812#action_12854812 ] Adrian Crum commented on OFBIZ-3659: Scott, I looked at the patch, and I commented on it - "Ideally, we should have a new ant target - "reports" or "metrics" - that would include this and other code-quality reports. " Then Bob said - "We can do some refactoring on the pluggable instrumentation implementation so that it has a separate build process from the main build." > Download cobertura code coverage jar so it can be used to compile and execute > tests with > > > Key: OFBIZ-3659 > URL: https://issues.apache.org/jira/browse/OFBIZ-3659 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: SVN trunk >Reporter: Bob Morley >Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-3659_AutomateDownloadOfCobertura.patch > > > Framework executed around allowing use of cobertura to create code coverage > metrics as part of the Ofbiz build process. Licensing restricts distribution > of cobertura with Ofbiz, so we have taken the approach to attempt to download > it before doing our build so it is available for any container that wants > instrumentation turned on (currently only test-container). Net result is > when we run our tests we will now get very nice code coverage metrics being > generated. > There is an existing target to generate the cobertura report (html) which is > not automatically being executed. Once we get more reasonable code coverage > via unit testing we can automatically generate this and expose it as > appropriate. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3659) Download cobertura code coverage jar so it can be used to compile and execute tests with
[ https://issues.apache.org/jira/browse/OFBIZ-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854830#action_12854830 ] Adrian Crum commented on OFBIZ-3659: Bob, You can't see the man behind the curtain if your gaze is focused on the smokey image in front of you. Browse the Apache Commons repository to see how things are set up. Or do a checkout of one of their projects. I would recommend commons/sandbox/convert ;-). > Download cobertura code coverage jar so it can be used to compile and execute > tests with > > > Key: OFBIZ-3659 > URL: https://issues.apache.org/jira/browse/OFBIZ-3659 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: SVN trunk >Reporter: Bob Morley >Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-3659_AutomateDownloadOfCobertura.patch > > > Framework executed around allowing use of cobertura to create code coverage > metrics as part of the Ofbiz build process. Licensing restricts distribution > of cobertura with Ofbiz, so we have taken the approach to attempt to download > it before doing our build so it is available for any container that wants > instrumentation turned on (currently only test-container). Net result is > when we run our tests we will now get very nice code coverage metrics being > generated. > There is an existing target to generate the cobertura report (html) which is > not automatically being executed. Once we get more reasonable code coverage > via unit testing we can automatically generate this and expose it as > appropriate. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3659) Download cobertura code coverage jar so it can be used to compile and execute tests with
[ https://issues.apache.org/jira/browse/OFBIZ-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854842#action_12854842 ] Adrian Crum commented on OFBIZ-3659: The metrics are not run unless you invoke Maven - "mvn site:site". The normal build does not include metrics. So, we could have something similar (hopefully without Maven) that produces metrics outside a basic build. > Download cobertura code coverage jar so it can be used to compile and execute > tests with > > > Key: OFBIZ-3659 > URL: https://issues.apache.org/jira/browse/OFBIZ-3659 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: SVN trunk >Reporter: Bob Morley >Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-3659_AutomateDownloadOfCobertura.patch > > > Framework executed around allowing use of cobertura to create code coverage > metrics as part of the Ofbiz build process. Licensing restricts distribution > of cobertura with Ofbiz, so we have taken the approach to attempt to download > it before doing our build so it is available for any container that wants > instrumentation turned on (currently only test-container). Net result is > when we run our tests we will now get very nice code coverage metrics being > generated. > There is an existing target to generate the cobertura report (html) which is > not automatically being executed. Once we get more reasonable code coverage > via unit testing we can automatically generate this and expose it as > appropriate. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3666) Errors attempting to use quantities with more than 2 decimals of precision
[ https://issues.apache.org/jira/browse/OFBIZ-3666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855425#action_12855425 ] Adrian Crum commented on OFBIZ-3666: Why specify 6 decimals? What if another user needed a different precision? These issues are another example of why we need better data typing. You don't need a calculate element to perform negation: > Errors attempting to use quantities with more than 2 decimals of precision > -- > > Key: OFBIZ-3666 > URL: https://issues.apache.org/jira/browse/OFBIZ-3666 > Project: OFBiz > Issue Type: Bug > Components: order, product >Affects Versions: SVN trunk >Reporter: Bob Morley >Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-3666_DoNotRoundPreciseQuantity.patch > > > We have a need to handle inventory items with quantities up to four decimal > places. The data model currently supports 6 decimals so I thought I would > try to complete a purchase order, sales order, and a return for an item that > has this many digits of precision. What I found was ... > - The order item was calculated properly (including the total for the line) > but the totals for the entire sales order were incorrect. This was because > when OrderReadHelper was getting the OrderItemQuantity as part of calculating > the subtotal it would round it to the order's configured scale (2). Since > this is being used as a calculation it should not be rounded -- the total > itself should be rounded. > - In a number of spots in issuance and reservation services values were > (sometimes) being rounded. For example, when an order item was created it > would create an InventoryItemDetail record that would reduce the ATP by the > precise quantity, however when the order was placed the QOH was reduced by > the rounded value. All of these issues were the result of the mini-lang > calculate element being used which by default uses a scale of 2 decimals > (from the dtd). The solution was when working with quantities pass in the > precision scale (6) to ensure we do not lose precision. Again, when order > totals, taxes, things like that are being done the configured scale should > take over, but the intermediate calculations should not be losing precision. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3666) Errors attempting to use quantities with more than 2 decimals of precision
[ https://issues.apache.org/jira/browse/OFBIZ-3666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855435#action_12855435 ] Adrian Crum commented on OFBIZ-3666: No, the type conversion hasn't changed. The issue is there is no type to convert to. Quantity should be a type, and Money should be a type. Strong data typing would prevent applying quantity precision to a money, and money precision to a quantity. > Errors attempting to use quantities with more than 2 decimals of precision > -- > > Key: OFBIZ-3666 > URL: https://issues.apache.org/jira/browse/OFBIZ-3666 > Project: OFBiz > Issue Type: Bug > Components: order, product >Affects Versions: SVN trunk >Reporter: Bob Morley >Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-3666_DoNotRoundPreciseQuantity.patch > > > We have a need to handle inventory items with quantities up to four decimal > places. The data model currently supports 6 decimals so I thought I would > try to complete a purchase order, sales order, and a return for an item that > has this many digits of precision. What I found was ... > - The order item was calculated properly (including the total for the line) > but the totals for the entire sales order were incorrect. This was because > when OrderReadHelper was getting the OrderItemQuantity as part of calculating > the subtotal it would round it to the order's configured scale (2). Since > this is being used as a calculation it should not be rounded -- the total > itself should be rounded. > - In a number of spots in issuance and reservation services values were > (sometimes) being rounded. For example, when an order item was created it > would create an InventoryItemDetail record that would reduce the ATP by the > precise quantity, however when the order was placed the QOH was reduced by > the rounded value. All of these issues were the result of the mini-lang > calculate element being used which by default uses a scale of 2 decimals > (from the dtd). The solution was when working with quantities pass in the > precision scale (6) to ensure we do not lose precision. Again, when order > totals, taxes, things like that are being done the configured scale should > take over, but the intermediate calculations should not be losing precision. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3700) Convert WorkEffort (and related entities) quantities from Double -> BigDecimal
[ https://issues.apache.org/jira/browse/OFBIZ-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856921#action_12856921 ] Adrian Crum commented on OFBIZ-3700: Bob, What do you mean by converting the WorkEffort entity to BigDecimal? > Convert WorkEffort (and related entities) quantities from Double -> BigDecimal > -- > > Key: OFBIZ-3700 > URL: https://issues.apache.org/jira/browse/OFBIZ-3700 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: SVN trunk >Reporter: Bob Morley >Priority: Minor > Fix For: SVN trunk > > > It appears that this entity was missed from the BigDecimal conversion. Ran > into this when ProductionRunServices was attempting to create a WorkEffort > (it is passing the quantity to produce as a BigDecimal). A different bug in > OFBIZ-3699 was causing an auto-convert of the field from BigDecimal to Double > (which was allowing ProductionRuns to be created). At any rate, we should > convert this entity and any other quantity related entities in the WorkEffort > component. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-3700) Convert WorkEffort (and related entities) quantities from Double -> BigDecimal
[ https://issues.apache.org/jira/browse/OFBIZ-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856925#action_12856925 ] Adrian Crum commented on OFBIZ-3700: I'm still lost. The WorkEffort entity definition doesn't specify Double for field types, only "floating-point", "currency-amount", "numeric", etc. Maybe you are referring to service definitions? > Convert WorkEffort (and related entities) quantities from Double -> BigDecimal > -- > > Key: OFBIZ-3700 > URL: https://issues.apache.org/jira/browse/OFBIZ-3700 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: SVN trunk >Reporter: Bob Morley >Priority: Minor > Fix For: SVN trunk > > > It appears that this entity was missed from the BigDecimal conversion. Ran > into this when ProductionRunServices was attempting to create a WorkEffort > (it is passing the quantity to produce as a BigDecimal). A different bug in > OFBIZ-3699 was causing an auto-convert of the field from BigDecimal to Double > (which was allowing ProductionRuns to be created). At any rate, we should > convert this entity and any other quantity related entities in the WorkEffort > component. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-3700) Convert WorkEffort (and related entities) quantities from Double -> BigDecimal
[ https://issues.apache.org/jira/browse/OFBIZ-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856931#action_12856931 ] Adrian Crum commented on OFBIZ-3700: The java-type elements in the fieldtype files specify the object type the JDBC driver is expecting. In other words, the Postgres JDBC driver expects a Double for SQL type FLOAT8. So, that can't be changed without some potential compatibility issues. On the other hand, the service definitions can specify any Java object type you want. > Convert WorkEffort (and related entities) quantities from Double -> BigDecimal > -- > > Key: OFBIZ-3700 > URL: https://issues.apache.org/jira/browse/OFBIZ-3700 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: SVN trunk >Reporter: Bob Morley >Priority: Minor > Fix For: SVN trunk > > > It appears that this entity was missed from the BigDecimal conversion. Ran > into this when ProductionRunServices was attempting to create a WorkEffort > (it is passing the quantity to produce as a BigDecimal). A different bug in > OFBIZ-3699 was causing an auto-convert of the field from BigDecimal to Double > (which was allowing ProductionRuns to be created). At any rate, we should > convert this entity and any other quantity related entities in the WorkEffort > component. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-3700) Convert WorkEffort (and related entities) quantities from Double -> BigDecimal
[ https://issues.apache.org/jira/browse/OFBIZ-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856942#action_12856942 ] Adrian Crum commented on OFBIZ-3700: Okay, so the field types need to be changed from floating-point to fixed point. Are there any other changes needed in the Work Effort component that you are aware of? > Convert WorkEffort (and related entities) quantities from Double -> BigDecimal > -- > > Key: OFBIZ-3700 > URL: https://issues.apache.org/jira/browse/OFBIZ-3700 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: SVN trunk >Reporter: Bob Morley >Priority: Minor > Fix For: SVN trunk > > > It appears that this entity was missed from the BigDecimal conversion. Ran > into this when ProductionRunServices was attempting to create a WorkEffort > (it is passing the quantity to produce as a BigDecimal). A different bug in > OFBIZ-3699 was causing an auto-convert of the field from BigDecimal to Double > (which was allowing ProductionRuns to be created). At any rate, we should > convert this entity and any other quantity related entities in the WorkEffort > component. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-3700) Convert WorkEffort (and related entities) quantities from Double -> BigDecimal
[ https://issues.apache.org/jira/browse/OFBIZ-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856948#action_12856948 ] Adrian Crum commented on OFBIZ-3700: Bob, Thank you for the information. I will work on this issue this weekend if no one beats me to it. I am about to deploy Manufacturing where I work, so I'm learning it as well. Maybe between the two of us we can get some documentation on the Wiki and work out any kinks we encounter. > Convert WorkEffort (and related entities) quantities from Double -> BigDecimal > -- > > Key: OFBIZ-3700 > URL: https://issues.apache.org/jira/browse/OFBIZ-3700 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: SVN trunk >Reporter: Bob Morley >Priority: Minor > Fix For: SVN trunk > > > It appears that this entity was missed from the BigDecimal conversion. Ran > into this when ProductionRunServices was attempting to create a WorkEffort > (it is passing the quantity to produce as a BigDecimal). A different bug in > OFBIZ-3699 was causing an auto-convert of the field from BigDecimal to Double > (which was allowing ProductionRuns to be created). At any rate, we should > convert this entity and any other quantity related entities in the WorkEffort > component. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (OFBIZ-3700) Convert WorkEffort (and related entities) quantities from Double -> BigDecimal
[ https://issues.apache.org/jira/browse/OFBIZ-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-3700: -- Assignee: Adrian Crum > Convert WorkEffort (and related entities) quantities from Double -> BigDecimal > -- > > Key: OFBIZ-3700 > URL: https://issues.apache.org/jira/browse/OFBIZ-3700 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: SVN trunk >Reporter: Bob Morley >Assignee: Adrian Crum >Priority: Minor > Fix For: SVN trunk > > > It appears that this entity was missed from the BigDecimal conversion. Ran > into this when ProductionRunServices was attempting to create a WorkEffort > (it is passing the quantity to produce as a BigDecimal). A different bug in > OFBIZ-3699 was causing an auto-convert of the field from BigDecimal to Double > (which was allowing ProductionRuns to be created). At any rate, we should > convert this entity and any other quantity related entities in the WorkEffort > component. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-3708) Fields should be defined with span not div. (radio, date, lookup)
[ https://issues.apache.org/jira/browse/OFBIZ-3708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858254#action_12858254 ] Adrian Crum commented on OFBIZ-3708: I agree with Blas. A div is a block element and a span is an inline element. If a field row is a block element, then using spans within that block element to style the individual artifacts (icons, indicators, etc) in that block is appropriate. Putting those inline elements inside a ul element is incorrect also. As far as I can tell, the markup in the patch is semantically correct. > Fields should be defined with span not div. (radio, date, lookup) > - > > Key: OFBIZ-3708 > URL: https://issues.apache.org/jira/browse/OFBIZ-3708 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk >Reporter: Blas Rodriguez Somoza >Priority: Minor > Fix For: SVN trunk > > Attachments: CAL_bizznesstime_after.jpg, CAL_bizznesstime_before.jpg, > CAL_bluelight_after.jpg, CAL_bluelight_before.jpg, > CAL_droppingcrumbs_after.jpg, CAL_droppingcrumbs_before.jpg, > CAL_flatgrey_after.jpg, CAL_flatgrey_before.jpg, CAL_tomahawk_after.jpg, > CAL_tomahawk_before.jpg, LOOKUP_CAL_bizznesstime_after.jpg, > LOOKUP_CAL_bizznesstime_before.jpg, LOOKUP_CAL_bluelight_after.jpg, > LOOKUP_CAL_bluelight_before.jpg, LOOKUP_CAL_droppingcrumbs_after.jpg, > LOOKUP_CAL_droppingcrumbs_before.jpg, LOOKUP_CAL_flatgrey_after.jpg, > LOOKUP_CAL_flatgrey_before.jpg, LOOKUP_CAL_tomahawk_after.jpg, > LOOKUP_CAL_tomahawk_before.jpg, OFBIZ-3708_framework_divspan.diff > > > Field markup should be a valid inline element. > Defining fields with div (block) instead of span (inline) creates several > problems: > - Missalignments in screen. (See LOOKUP_CAL screenshots) > - Implies a end-of-line after the div. (See CAL screenshots) > - If used inside inline elements which should be OK, becames XHTML validation > errors. (Manufacturing -> MRP -> MRP log) > Because this is a markup problem, it spans to all the themes. > This patch contains 2 files in the framework/widget area and 5 in the themes > area. > Because the source of the problem is in the framework/widget area, I opt to > assign the bug to the framework area. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-3245) Sandbox: Integrating The New Conversion Framework Into The Entity Engine
[ https://issues.apache.org/jira/browse/OFBIZ-3245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858541#action_12858541 ] Adrian Crum commented on OFBIZ-3245: Thanks Jacopo. I would prefer to keep OFBiz database-agnostic, so the code you suggested won't help. > Sandbox: Integrating The New Conversion Framework Into The Entity Engine > > > Key: OFBIZ-3245 > URL: https://issues.apache.org/jira/browse/OFBIZ-3245 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: SVN trunk >Reporter: Adrian Crum >Assignee: Adrian Crum >Priority: Minor > Attachments: conversion.patch, conversion.patch, conversion.patch, > conversion.patch, conversion.patch, conversion.patch, conversion.patch, > conversion.patch > > > This issue contains a patch intended for evaluation before it is committed. > See comments for details. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3670) TestCase base classes providing ability to execute unit tests in Eclipse in "standalone" mode
[ https://issues.apache.org/jira/browse/OFBIZ-3670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858946#action_12858946 ] Adrian Crum commented on OFBIZ-3670: Bob, Your ideas kind of tie into the dual build paths mentioned recently. A test-only delegator factory would be specified in a test-only META-INF/services folder. > TestCase base classes providing ability to execute unit tests in Eclipse in > "standalone" mode > - > > Key: OFBIZ-3670 > URL: https://issues.apache.org/jira/browse/OFBIZ-3670 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: SVN trunk >Reporter: Bob Morley >Assignee: Scott Gray > Fix For: SVN trunk > > Attachments: OFBIZ-3670_StandaloneTestEnhancement.patch > > > This patch provides the framework that allows junit unit tests to be executed > directly in Eclipse (without having to invoke Start directly). It total it > contains: > - BaseTestCase - very top of the TestCase stack containing ofbiz specific > assertions > - StandaloneTestCase - determines if application has executed "Start"; if not > it will execute a scaled down "Start unittest" that is used in Eclipse > - RollbackTestCase - extends standalone and provides a transaction w/ > auto-rollback > - TestRunContainer - provides ability to disable dispatcher attributes via > configuration (used for unittest-containers.xml) > - GeoWorkerTest - unittester that provides "full" coverage of GeoWorker; can > be executed from Eclipse or from command-line as it is plugged into standard > testdef framework. Creates its own entities with transaction start/rollback > so it can be re-executed. > Would appreciate if this can be a priority so I can provide additional test > cases to boost our code coverage that will utilize these features. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3702) provide better user help
[ https://issues.apache.org/jira/browse/OFBIZ-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859828#action_12859828 ] Adrian Crum commented on OFBIZ-3702: Chris, Internationalization of entity field descriptions is already implemented. Look in framework/example/config/ExampleEntityLabels.xml for the FieldDescription.* properties. > provide better user help > > > Key: OFBIZ-3702 > URL: https://issues.apache.org/jira/browse/OFBIZ-3702 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Release Candidate Branch 10.04, SVN trunk >Reporter: chris snow > Attachments: entity_field_tooltip_screenshot.png, > fieldLabelTooltip.png, fieldLabelTooltip_DO_NOT_COMMIT.patch, help.png, > product_entitymodel.patch, tooltip_help_DO_NOT_COMMIT.patch > > > Please see http://n4.nabble.com/Providing-users-with-help-td1840416.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3702) provide better user help
[ https://issues.apache.org/jira/browse/OFBIZ-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859851#action_12859851 ] Adrian Crum commented on OFBIZ-3702: Chris, I'm not sure what your last comment means. I don't see anything in your latest patch that utilizes the existing entity field description internationalization. Please see how it is implemented in the Example component. > provide better user help > > > Key: OFBIZ-3702 > URL: https://issues.apache.org/jira/browse/OFBIZ-3702 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Release Candidate Branch 10.04, SVN trunk >Reporter: chris snow > Attachments: entity_field_tooltip_screenshot.png, > fieldLabelTooltip.png, fieldLabelTooltip_DO_NOT_COMMIT.patch, help.png, > product_entitymodel.patch, tooltip_help_DO_NOT_COMMIT.patch > > > Please see http://n4.nabble.com/Providing-users-with-help-td1840416.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-3738) ModelForm.java Is Not Thread-Safe
ModelForm.java Is Not Thread-Safe - Key: OFBIZ-3738 URL: https://issues.apache.org/jira/browse/OFBIZ-3738 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Candidate Branch 10.04, SVN trunk Reporter: Adrian Crum Revision 892371 introduces code into the ModelForm class that allows threads to modify its internal state. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-3739) PrepareFind Service Ignores timeZone Parameter When Performing Date/Time Calculations
PrepareFind Service Ignores timeZone Parameter When Performing Date/Time Calculations - Key: OFBIZ-3739 URL: https://issues.apache.org/jira/browse/OFBIZ-3739 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Candidate Branch 10.04, SVN trunk Reporter: Adrian Crum In FindServices.java, the prepareFind service calls the createCondition method, which in turn calls the dayStart method - a method that calculates the start of the day based on a Timestamp value. That calculation ignores the timeZone parameter passed to the prepareFind service, so the results are inaccurate. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3702) provide better user help
[ https://issues.apache.org/jira/browse/OFBIZ-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860961#action_12860961 ] Adrian Crum commented on OFBIZ-3702: The getHelp method looks good. I haven't tried the patch. > provide better user help > > > Key: OFBIZ-3702 > URL: https://issues.apache.org/jira/browse/OFBIZ-3702 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Release Candidate Branch 10.04, SVN trunk >Reporter: chris snow > Attachments: entity_field_tooltip_screenshot.png, > fieldLabelTooltip.png, fieldLabelTooltip2.png, > fieldLabelTooltip2__DO_NOT_COMMIT.patch, > fieldLabelTooltip_DO_NOT_COMMIT.patch, help.png, product_entitymodel.patch, > tooltip_help_DO_NOT_COMMIT.patch > > > Please see http://n4.nabble.com/Providing-users-with-help-td1840416.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3747) ProductStore missing field title help
[ https://issues.apache.org/jira/browse/OFBIZ-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862229#action_12862229 ] Adrian Crum commented on OFBIZ-3747: Chris, >From my perspective, descriptions like that border on online help. The line >between a tooltip and a more comprehensive online help system is being blurred. In my opinion (take it for what it is worth) a tooltip should be somewhere between a terse field label and full help text. In you example above, the tooltip would be the first sentence only. If the user needs more information, they can click the Help link and find the rest of your text. > ProductStore missing field title help > - > > Key: OFBIZ-3747 > URL: https://issues.apache.org/jira/browse/OFBIZ-3747 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Release Candidate Branch 10.04, SVN trunk >Reporter: chris snow > Fix For: Release Candidate Branch 10.04, SVN trunk > > Attachments: productStoreFieldDescriptions.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3747) ProductStore missing field title help
[ https://issues.apache.org/jira/browse/OFBIZ-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862262#action_12862262 ] Adrian Crum commented on OFBIZ-3747: Chris, A JavaScript popup sounds like a good compromise. One more bit of advice - try to find a way to extract the popup text from the online help file - even if that means the online help system needs to be redesigned a little. The reason I suggest that is because I can foresee two help systems with contradictory information or one system that is kept updated while the other isn't. I global JavaScript file can be loaded in the GlobalDecorator. > ProductStore missing field title help > - > > Key: OFBIZ-3747 > URL: https://issues.apache.org/jira/browse/OFBIZ-3747 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Release Candidate Branch 10.04, SVN trunk >Reporter: chris snow > Fix For: Release Candidate Branch 10.04, SVN trunk > > Attachments: productStoreFieldDescriptions.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
