[jira] [Closed] (OFBIZ-6737) block sites
[ https://issues.apache.org/jira/browse/OFBIZ-6737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-6737. -- Resolution: Invalid Fix Version/s: (was: 14.12.01) > block sites > --- > > Key: OFBIZ-6737 > URL: https://issues.apache.org/jira/browse/OFBIZ-6737 > Project: OFBiz > Issue Type: Task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: viola zanbookie >Priority: Critical > Labels: BB2015-05-TBR > Original Estimate: 86,033h 35m > Remaining Estimate: 86,033h 35m > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6726) Update commons collections 3.2.1 because of known possible exploit
[ https://issues.apache.org/jira/browse/OFBIZ-6726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15011392#comment-15011392 ] Adrian Crum commented on OFBIZ-6726: It would be nice if we had more information about the exploit and how the upgrade might affect OFBiz users. > Update commons collections 3.2.1 because of known possible exploit > -- > > Key: OFBIZ-6726 > URL: https://issues.apache.org/jira/browse/OFBIZ-6726 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Release Branch 12.04, Release Branch 13.07, Release > Branch 14.12, Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux > Fix For: 14.12.01, 12.04.06, 13.07.03, Upcoming Branch > > > Done to 3.2.2 at revision: > trunk 1714571 > R14.12 1714575 > R13.07 1714576 > R13.04 1714577 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.
[ https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15007485#comment-15007485 ] Adrian Crum commented on OFBIZ-5608: Exactly! I have gone down that road many times trying to fix problems in the framework. That is why I proposed rewriting it. > Dates Displaying Incorrectly With Negative Offest Timezones. > > > Key: OFBIZ-5608 > URL: https://issues.apache.org/jira/browse/OFBIZ-5608 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk >Reporter: Rupert Howell >Assignee: Jacques Le Roux >Priority: Minor > Attachments: DateField_1.jpg, DateField_2.jpg, IgnoreTimeZone.patch, > ObjectTypeTests.patch, dates.patch, dates_1589040.patch, sqldate_scenarios.png > > > Dates are displaying incorrectly when negative offset (relative to UTC) are > applied by the users settings. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.
[ https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15007431#comment-15007431 ] Adrian Crum edited comment on OFBIZ-5608 at 11/16/15 10:02 PM: --- The attached screenshots show the problem. https://localhost:8443/partymgr/control/editperson?partyId=admin If my locale is en, the tooltip says the format is "-MM-dd". If I type in a date in that format and click Save, the field is left empty (the typed-in date was ignored). If I select a date from the calendar popup, then the date appears as "MM/dd/", and the new value is saved. If my locale is en-GB, the tooltip shows the correct format. If I type in a date in that format and click Save, the field is saved. I added a log statement to MacroFormRenderer.java to see what value is being generated, and it is in the format specified in ModelFormField.java, line 345, but somehow the HTML macros are transforming it to another format. This is bad, because that means the date will be displayed one way in HTML, and it will be rendered as "-MM-dd" in all other formats. was (Author: adri...@hlmksw.com): The attached screenshots sow the problem. https://localhost:8443/partymgr/control/editperson?partyId=admin If my locale is en, the tooltip says the format is "-MM-dd". If I type in a date in that format and click Save, the field is left empty (the typed-in date was ignored). If I select a date from the calendar popup, then the date appears as "MM/dd/", and the new value is saved. If my locale is en-GB, the tooltip shows the correct format. If I type in a date in that format and click Save, the field is saved. I added a log statement to MacroFormRenderer.java to see what value is being generated, and it is in the format specified in ModelFormField.java, line 345, but somehow the HTML macros are transforming it to another format. This is bad, because that means the date will be displayed one way in HTML, and it will be rendered as "-MM-dd" in all other formats. > Dates Displaying Incorrectly With Negative Offest Timezones. > > > Key: OFBIZ-5608 > URL: https://issues.apache.org/jira/browse/OFBIZ-5608 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk >Reporter: Rupert Howell >Assignee: Jacques Le Roux >Priority: Minor > Attachments: DateField_1.jpg, DateField_2.jpg, IgnoreTimeZone.patch, > ObjectTypeTests.patch, dates.patch, dates_1589040.patch, sqldate_scenarios.png > > > Dates are displaying incorrectly when negative offset (relative to UTC) are > applied by the users settings. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.
[ https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-5608: --- Attachment: DateField_2.jpg DateField_1.jpg The attached screenshots sow the problem. https://localhost:8443/partymgr/control/editperson?partyId=admin If my locale is en, the tooltip says the format is "-MM-dd". If I type in a date in that format and click Save, the field is left empty (the typed-in date was ignored). If I select a date from the calendar popup, then the date appears as "MM/dd/", and the new value is saved. If my locale is en-GB, the tooltip shows the correct format. If I type in a date in that format and click Save, the field is saved. I added a log statement to MacroFormRenderer.java to see what value is being generated, and it is in the format specified in ModelFormField.java, line 345, but somehow the HTML macros are transforming it to another format. This is bad, because that means the date will be displayed one way in HTML, and it will be rendered as "-MM-dd" in all other formats. > Dates Displaying Incorrectly With Negative Offest Timezones. > > > Key: OFBIZ-5608 > URL: https://issues.apache.org/jira/browse/OFBIZ-5608 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk >Reporter: Rupert Howell >Assignee: Jacques Le Roux >Priority: Minor > Attachments: DateField_1.jpg, DateField_2.jpg, IgnoreTimeZone.patch, > ObjectTypeTests.patch, dates.patch, dates_1589040.patch, sqldate_scenarios.png > > > Dates are displaying incorrectly when negative offset (relative to UTC) are > applied by the users settings. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.
[
https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15007123#comment-15007123
]
Adrian Crum commented on OFBIZ-5608:
Please review this code:
MacroFormRenderer.java, line 549
MacroFormRenderer.java, line 561
ModelFormField.java, line 345
Then look at the UI label being used in MacroFormRenderer.java, line 561:
{code}
النمط: ي ي-ش ش-ع ع ع ع
Formát datumu: -MM-dd
Datumsformat: -MM-dd
Format: -MM-dd
Format: dd/MM/
Formato: dd/mm/
Format: JJ/MM/
प्रारूप: -MM-dd
Formato: -MM-gg
書式: -MM-dd
Format: -MM-dd
Formato: -MM-dd
Формат: -ММ-дд
รูปแบบ : -MM-dd
Định dạng ngày tháng: -MM-dd
格式: -MM-dd
格式: -MM-dd
{code}
If my locale is en-GB, the screen tells me to enter a date in the format
"dd/MM/", but ModelFormField.java, line 345 is rendering it as "-MM-dd".
> Dates Displaying Incorrectly With Negative Offest Timezones.
>
>
> Key: OFBIZ-5608
> URL: https://issues.apache.org/jira/browse/OFBIZ-5608
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk
>Reporter: Rupert Howell
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: IgnoreTimeZone.patch, ObjectTypeTests.patch,
> dates.patch, dates_1589040.patch, sqldate_scenarios.png
>
>
> Dates are displaying incorrectly when negative offset (relative to UTC) are
> applied by the users settings.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.
[ https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15006941#comment-15006941 ] Adrian Crum commented on OFBIZ-5608: Look at ModelFormField.java, line 339 and 345. The short format is ignored when the date string is created. > Dates Displaying Incorrectly With Negative Offest Timezones. > > > Key: OFBIZ-5608 > URL: https://issues.apache.org/jira/browse/OFBIZ-5608 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk >Reporter: Rupert Howell >Assignee: Jacques Le Roux >Priority: Minor > Attachments: IgnoreTimeZone.patch, ObjectTypeTests.patch, > dates.patch, dates_1589040.patch, sqldate_scenarios.png > > > Dates are displaying incorrectly when negative offset (relative to UTC) are > applied by the users settings. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6210) Replace EntityUtilProperties with EntityClassLoader
[ https://issues.apache.org/jira/browse/OFBIZ-6210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14993902#comment-14993902 ] Adrian Crum commented on OFBIZ-6210: Thank you for taking the time to review the code. I won't be able to continue work on this, so if someone wants to take over, they are welcome to do so. > Replace EntityUtilProperties with EntityClassLoader > --- > > Key: OFBIZ-6210 > URL: https://issues.apache.org/jira/browse/OFBIZ-6210 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Upcoming Branch >Reporter: Adrian Crum >Priority: Minor > > The EntityUtilProperties implementation is very limited and requires > rewriting a lot of code. Using EntityClassLoader will achieve the same result > without changing any code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6712) Increase the number of EntityUtilProperties methods which really use getSystemPropertyValue()
[ https://issues.apache.org/jira/browse/OFBIZ-6712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14992381#comment-14992381 ] Adrian Crum commented on OFBIZ-6712: Have you tested the performance impact of the current implementation? > Increase the number of EntityUtilProperties methods which really use > getSystemPropertyValue() > - > > Key: OFBIZ-6712 > URL: https://issues.apache.org/jira/browse/OFBIZ-6712 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > Currently a number of EntityUtilProperties methods, notably > getPropertyNumber, > getPropertyAsBoolean/Integer/Long/Float/Double/BigInteger/BigDecimal, > propertyValueEquals (but not propertyValueEqualsIgnoreCase), etc. don't rely > on getSystemPropertyValue > Note that getProperties methods are already covered by OFBIZ-6675 > If that would be done we could deprecate and ultimately replace > UtilProperties by EntityUtilProperties -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6712) Increase the number of EntityUtilProperties methods which really use getSystemPropertyValue()
[ https://issues.apache.org/jira/browse/OFBIZ-6712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14992205#comment-14992205 ] Adrian Crum commented on OFBIZ-6712: Yes, I see what you are trying to do. What YOU are not seeing is that, in the time you took to create this issue and type all of your replies, you could have instead committed the alternative fix. And in the time it will take for you to continue this pointless argument, you could instead put some @Deprecation annotations on some code and commit them. But you aren't going to invest any time in an alternative solution, because... I don't know. Many of your commits make no sense, and this issue continues that tradition. > Increase the number of EntityUtilProperties methods which really use > getSystemPropertyValue() > - > > Key: OFBIZ-6712 > URL: https://issues.apache.org/jira/browse/OFBIZ-6712 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > Currently a number of EntityUtilProperties methods, notably > getPropertyNumber, > getPropertyAsBoolean/Integer/Long/Float/Double/BigInteger/BigDecimal, > propertyValueEquals (but not propertyValueEqualsIgnoreCase), etc. don't rely > on getSystemPropertyValue > Note that getProperties methods are already covered by OFBIZ-6675 > If that would be done we could deprecate and ultimately replace > UtilProperties by EntityUtilProperties -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6712) Increase the number of EntityUtilProperties methods which really use getSystemPropertyValue()
[ https://issues.apache.org/jira/browse/OFBIZ-6712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14992144#comment-14992144 ] Adrian Crum commented on OFBIZ-6712: You are contradicting yourself. You describe an alternative, then say there is no alternative. Let's stop wasting effort on that piece of crap and fix the problem properly. > Increase the number of EntityUtilProperties methods which really use > getSystemPropertyValue() > - > > Key: OFBIZ-6712 > URL: https://issues.apache.org/jira/browse/OFBIZ-6712 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > Currently a number of EntityUtilProperties methods, notably > getPropertyNumber, > getPropertyAsBoolean/Integer/Long/Float/Double/BigInteger/BigDecimal, > propertyValueEquals (but not propertyValueEqualsIgnoreCase), etc. don't rely > on getSystemPropertyValue > Note that getProperties methods are already covered by OFBIZ-6675 > If that would be done we could deprecate and ultimately replace > UtilProperties by EntityUtilProperties -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6712) Increase the number of EntityUtilProperties methods which really use getSystemPropertyValue()
[ https://issues.apache.org/jira/browse/OFBIZ-6712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14991860#comment-14991860 ] Adrian Crum commented on OFBIZ-6712: NO NO NO!!! You cannot replace UtilProperties with EntityUtilProperties! That would create a dependency on the entity engine. This has been discussed before in another issue. EntityUtilProperties is an awful implementation that needs to go away. > Increase the number of EntityUtilProperties methods which really use > getSystemPropertyValue() > - > > Key: OFBIZ-6712 > URL: https://issues.apache.org/jira/browse/OFBIZ-6712 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > Currently a number of EntityUtilProperties methods, notably > getPropertyNumber, > getPropertyAsBoolean/Integer/Long/Float/Double/BigInteger/BigDecimal, > propertyValueEquals (but not propertyValueEqualsIgnoreCase), etc. don't rely > on getSystemPropertyValue > Note that getProperties methods are already covered by OFBIZ-6675 > If that would be done we could deprecate and ultimately replace > UtilProperties by EntityUtilProperties -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6704) Creating & Closing Custom Time Periods
[ https://issues.apache.org/jira/browse/OFBIZ-6704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14980325#comment-14980325 ] Adrian Crum commented on OFBIZ-6704: https://ci.apache.org/projects/ofbiz/site/javadocs/org/ofbiz/base/util/UtilDateTime.html#getDayEnd(java.sql.Timestamp,%20java.util.TimeZone,%20java.util.Locale) > Creating & Closing Custom Time Periods > -- > > Key: OFBIZ-6704 > URL: https://issues.apache.org/jira/browse/OFBIZ-6704 > Project: OFBiz > Issue Type: Bug >Reporter: David Hughes-Owens > > I have been looking at the functionality around creating and closing time > periods. > I have uncovered a potential issue with the Thru Date of a period and the > closing process. > For example, January period runs form 01-01-2015 to 31-01-2015. The form & > thru dates are date formats and require no time input. > When you do a period close the code creates the accounting transaction > between P&L and Retained Earnings. > However, this transaction is time stamped and creates a transaction date of > 30-01-2015 23:59:59. I believe this is due to the service taking the thru > date as 31-01-2015 00:00:00. When it should be 31-01-2015 23:59:59. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6691) Remove tooltip="${uiLabelMap.CommonRequired}" from fields
[
https://issues.apache.org/jira/browse/OFBIZ-6691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14967701#comment-14967701
]
Adrian Crum commented on OFBIZ-6691:
Originally, OFBiz marked required fields with an asterisk - but it didn't
include an explanation of what the asterisk meant. So, the 'required' CSS class
and text was added to make it clearer that a field is required. The conversion
was incomplete, so there are still asterisks in the project.
> Remove tooltip="${uiLabelMap.CommonRequired}" from fields
> -
>
> Key: OFBIZ-6691
> URL: https://issues.apache.org/jira/browse/OFBIZ-6691
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Pierre Smits
> Labels: validation
>
> The aspect 'required-field="true"' should deliver this. Therefor, this is
> unnecessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-4090) Add Support For Compound Screen Widget XML Files
[ https://issues.apache.org/jira/browse/OFBIZ-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14966824#comment-14966824 ] Adrian Crum commented on OFBIZ-4090: The implementation basically worked, but the Eclipse editor wasn't working well with the changes. The patch is very outdated. It will need to be updated. > Add Support For Compound Screen Widget XML Files > > > Key: OFBIZ-4090 > URL: https://issues.apache.org/jira/browse/OFBIZ-4090 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Adrian Crum >Priority: Minor > Attachments: CompoundWidgetFiles.patch, CompoundWidgetFiles.patch > > > Add the ability to include screen widgets, form widgets, menu widgets, and > simple methods in a single XML file. This approach could be used in > situations where the widgets share a logical grouping - so they can be kept > in one place. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5534) Dirty reads from entity cache
[ https://issues.apache.org/jira/browse/OFBIZ-5534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14961924#comment-14961924 ] Adrian Crum commented on OFBIZ-5534: FYI - my pk cache fix worked, but there were a number of bug reports afterward. The fix design depended on the wrapping transaction, but there are places in OFBiz where a transaction isn't used - so those places are where the bugs appeared. > Dirty reads from entity cache > - > > Key: OFBIZ-5534 > URL: https://issues.apache.org/jira/browse/OFBIZ-5534 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release Branch 11.04, Release Branch 12.04, Release > Branch 13.07, Trunk >Reporter: Jacopo Cappellato >Assignee: Adam Heath > Attachments: unittest-dirtyreadsfromcache.patch > > > Even if database transaction isolation level is set to "ReadCommitted", a > transaction can get uncommitted records from the entity cache, under certain > circumstances. > Here is a test case: > 1) transaction T1 creates a record > 2) T1 calls findOne to retrieve it: the read will be successful (because T1 > can read data generated in T1 even if not committed) and the record will be > added to the cache > 3) T1 calls another service with requireNewTransaction set to true: this will > run the second service in a new transaction T2 > 4) T2 calls findOne to retrieve the record created by T1: if useCache is set > to false it should fail; if useCache is set to true it will succeed (getting > the record from cache, even if the data is not committed to the db) > The result in #4 is wrong because T2 should not see the uncommitted record > We should never add uncommitted records to the entity cache. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6405) Grid widget requires cache clear before modifications are rendered
[ https://issues.apache.org/jira/browse/OFBIZ-6405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-6405. -- Resolution: Fixed Fix Version/s: Upcoming Branch Fixed in rev 1709. Thanks! > Grid widget requires cache clear before modifications are rendered > -- > > Key: OFBIZ-6405 > URL: https://issues.apache.org/jira/browse/OFBIZ-6405 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Adrian Crum > Fix For: Upcoming Branch > > Attachments: OFBIZ-6405.patch > > > This issue was encountered when replacing with for OFBIZ-6402 > as suggested by Adrian. I simply changed to but it > wouldn't render the change until the cache was cleared. Grid widget changes > should be rendered without requiring cache clear as is the case for -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-6405) Grid widget requires cache clear before modifications are rendered
[ https://issues.apache.org/jira/browse/OFBIZ-6405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-6405: -- Assignee: Adrian Crum > Grid widget requires cache clear before modifications are rendered > -- > > Key: OFBIZ-6405 > URL: https://issues.apache.org/jira/browse/OFBIZ-6405 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Adrian Crum > Attachments: OFBIZ-6405.patch > > > This issue was encountered when replacing with for OFBIZ-6402 > as suggested by Adrian. I simply changed to but it > wouldn't render the change until the cache was cleared. Grid widget changes > should be rendered without requiring cache clear as is the case for -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6654) Display of a recurrent workeffort in workeffort calendar do not respect estimatedStart/CompletionDate
[ https://issues.apache.org/jira/browse/OFBIZ-6654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14908788#comment-14908788 ] Adrian Crum commented on OFBIZ-6654: Using the actual date-time fields does not make sense. The temporal expression is used to indicate something that happens repeatedly, like a scheduled event. Using the DAILY_GRIND expression as an example, the expression tells you when your work day is supposed to start, but you might show up late. Your actual arrival time is stored in the actual date-time fields. > Display of a recurrent workeffort in workeffort calendar do not respect > estimatedStart/CompletionDate > - > > Key: OFBIZ-6654 > URL: https://issues.apache.org/jira/browse/OFBIZ-6654 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: Trunk >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne > Attachments: OFBIZ-6654.patch, screenshot-1.png, screenshot-2.png > > > I created DAILY_GRIND recurrent workeffort with estimated start date to > 2015-09-02 and estimated completion date to 2015-09-22. The task is displayed > every day in the month. > Haven't tested it on branches... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6654) Display of a recurrent workeffort in workeffort calendar do not respect estimatedStart/CompletionDate
[ https://issues.apache.org/jira/browse/OFBIZ-6654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14908712#comment-14908712 ] Adrian Crum commented on OFBIZ-6654: The good news is the expression recognized September 7 as a federal holiday. > Display of a recurrent workeffort in workeffort calendar do not respect > estimatedStart/CompletionDate > - > > Key: OFBIZ-6654 > URL: https://issues.apache.org/jira/browse/OFBIZ-6654 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: Trunk >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne > Attachments: screenshot-1.png > > > I created DAILY_GRIND recurrent workeffort with estimated start date to > 2015-09-02 and estimated completion date to 2015-09-22. The task is displayed > every day in the month. > Haven't tested it on branches... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6637) Work Effort Month Calendar View Is Broken
[ https://issues.apache.org/jira/browse/OFBIZ-6637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14903650#comment-14903650 ] Adrian Crum commented on OFBIZ-6637: Thank you for working on this! > Work Effort Month Calendar View Is Broken > - > > Key: OFBIZ-6637 > URL: https://issues.apache.org/jira/browse/OFBIZ-6637 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: Upcoming Branch >Reporter: Adrian Crum >Assignee: Gil Portenseigne > Attachments: OFBIZ-6637.patch > > > The Work Effort Month calendar view does not work. The screen does not > display: > https://localhost:8443/workeffort/control/calendar?period=month > and CPU utilization remains high. It appears to be in an endless loop. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6647) Refactoring to consolidate different Calendar implementations
[ https://issues.apache.org/jira/browse/OFBIZ-6647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900893#comment-14900893 ] Adrian Crum commented on OFBIZ-6647: ICU4J was chosen for 2 reasons: 1. Better calendar selection (Java has only 2 if I recall correctly). 2. Time zone data can be updated easily by downloading the latest library version (versus waiting for the next Java revision). ICU4J is used as the default Calendar implementation in OFBiz. The java.util.Calendar class is used where an API requires one. > Refactoring to consolidate different Calendar implementations > - > > Key: OFBIZ-6647 > URL: https://issues.apache.org/jira/browse/OFBIZ-6647 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > > This came up in reference to > [6594|https://issues.apache.org/jira/browse/OFBIZ-6594]: > Piere Smits: "Currently we are using 'import com.ibm.icu.util.Calendar' at > various places. But we're also using 'java.util.Calendar' at other places. > Better is it to make a choice for consistency." > We should fisrt analyze the usage of different implementations and the impact > of replacing one with the other (e.g. what's the difference of these > implementations). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6642) Non-breaking space incorrectly encoded in forms
[
https://issues.apache.org/jira/browse/OFBIZ-6642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900079#comment-14900079
]
Adrian Crum commented on OFBIZ-6642:
It would be best to get rid of the HTML markup. Just use plain spaces.
> Non-breaking space incorrectly encoded in forms
> ---
>
> Key: OFBIZ-6642
> URL: https://issues.apache.org/jira/browse/OFBIZ-6642
> Project: OFBiz
> Issue Type: Bug
> Components: party, product
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Release
> Branch 14.12, Trunk
>Reporter: Oleg Andreyev
>Priority: Trivial
> Attachments: nbsp.diff
>
>
> There are a few places where forms include non-breaking space encoded as
> {noformat} {noformat} This does not work really. It should be
> {noformat} {noformat} One of such places is the list of parties in party
> classification group.
> Patch is good for all mentioned releases.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6637) Work Effort Month Calendar View Is Broken
[ https://issues.apache.org/jira/browse/OFBIZ-6637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14877196#comment-14877196 ] Adrian Crum commented on OFBIZ-6637: It might be caused by having a recurring work effort that uses a temporal expression. > Work Effort Month Calendar View Is Broken > - > > Key: OFBIZ-6637 > URL: https://issues.apache.org/jira/browse/OFBIZ-6637 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: Upcoming Branch >Reporter: Adrian Crum > > The Work Effort Month calendar view does not work. The screen does not > display: > https://localhost:8443/workeffort/control/calendar?period=month > and CPU utilization remains high. It appears to be in an endless loop. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6637) Work Effort Month Calendar View Is Broken
[ https://issues.apache.org/jira/browse/OFBIZ-6637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14877195#comment-14877195 ] Adrian Crum commented on OFBIZ-6637: The problem exists on my local unmodified copy, and it also exists on the demo site. > Work Effort Month Calendar View Is Broken > - > > Key: OFBIZ-6637 > URL: https://issues.apache.org/jira/browse/OFBIZ-6637 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: Upcoming Branch >Reporter: Adrian Crum > > The Work Effort Month calendar view does not work. The screen does not > display: > https://localhost:8443/workeffort/control/calendar?period=month > and CPU utilization remains high. It appears to be in an endless loop. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-6637) Work Effort Month Calendar View Is Broken
Adrian Crum created OFBIZ-6637: -- Summary: Work Effort Month Calendar View Is Broken Key: OFBIZ-6637 URL: https://issues.apache.org/jira/browse/OFBIZ-6637 Project: OFBiz Issue Type: Bug Components: workeffort Affects Versions: Upcoming Branch Reporter: Adrian Crum The Work Effort Month calendar view does not work. The screen does not display: https://localhost:8443/workeffort/control/calendar?period=month and CPU utilization remains high. It appears to be in an endless loop. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6621) MapContext.entrySet() slows down when ByteBuffer objects are in the context
[
https://issues.apache.org/jira/browse/OFBIZ-6621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14781586#comment-14781586
]
Adrian Crum commented on OFBIZ-6621:
Since ListSet.java is a special purpose class meant to be used with
MapContext.java, it might be best to make it a private inner class - so other
developers will not be tempted to use it for other things.
> MapContext.entrySet() slows down when ByteBuffer objects are in the context
> ---
>
> Key: OFBIZ-6621
> URL: https://issues.apache.org/jira/browse/OFBIZ-6621
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Gareth Carter
>Priority: Critical
> Attachments: MapContext.patch
>
>
> When MapContext is used anywhere (eg FlexibleStringExpander) and the context
> contains ByteBuffer objects (either key or value), java will slow down when
> calling MapContext.entrySet().
> Here is the code in ofbiz, highlighted is the line of code that I believe is
> the culprit
> {code:title=MapContext.java}
> public Set> entrySet() {
> // walk the stackList and the entries for each Map and if nothing is in
> for the current key, put it in
> Set resultKeySet = new HashSet();
> culprit --> Set> resultEntrySet = new
> ListSet>();
> for (Map curMap: this.stackList) {
> for (Map.Entry curEntry: curMap.entrySet()) {
> if (!resultKeySet.contains(curEntry.getKey())) {
> resultKeySet.add(curEntry.getKey());
> resultEntrySet.add(curEntry);
> }
> }
> }
> return Collections.unmodifiableSet(resultEntrySet);
> }
> {code}
> Looking at the java api for Map.Entry, the hashCode method for Map.Entry is
> the result of the hashCode from both key and value. ByteBuffer hash code is
> dependent upon its content. If a 2mb file is uploaded, the hashCode method
> of ByteBuffer will scan 2mb to generate the hashCode
> ByteBuffer
> http://docs.oracle.com/javase/7/docs/api/java/nio/ByteBuffer.html#hashCode()
> {quote}Because buffer hash codes are content-dependent, it is inadvisable to
> use buffers as keys in hash maps or similar data structures unless it is
> known that their contents will not change.{quote}
> Map.Entry
> http://docs.oracle.com/javase/7/docs/api/java/util/Map.Entry.html#hashCode()
> {quote}(e.getKey()==null ? 0 : e.getKey().hashCode()) ^ (e.getValue()==null
> ? 0 : e.getValue().hashCode()){quote}
> HashSet
> http://docs.oracle.com/javase/7/docs/api/java/util/HashSet.html
> {quote}This class implements the Set interface, backed by a hash table
> (actually a HashMap instance{quote}
> Example where ByteBuffer objects are created
> {code}org.ofbiz.webapp.event.ServiceEventHandler{code}
> Example stack trace
> {noformat}
> "ajp-bio-8009-exec-1894" daemon prio=10 tid=0x7fa52c07 nid=0x5c73
> runnable [0x7fa51151b000]
>java.lang.Thread.State: RUNNABLE
> at java.nio.HeapByteBuffer.ix(HeapByteBuffer.java:131)
> at java.nio.HeapByteBuffer.get(HeapByteBuffer.java:139)
> at java.nio.ByteBuffer.hashCode(ByteBuffer.java:1083)
> at java.util.Objects.hashCode(Objects.java:96)
> at java.util.HashMap$Entry.hashCode(HashMap.java:847)
> at java.util.AbstractMap.hashCode(AbstractMap.java:494)
> at java.util.Objects.hashCode(Objects.java:96)
> at java.util.HashMap$Entry.hashCode(HashMap.java:847)
> at java.util.HashMap.hash(HashMap.java:362)
> at java.util.HashMap.put(HashMap.java:492)
> at java.util.HashSet.add(HashSet.java:217)
> at
> org.ofbiz.base.util.collections.MapContext.entrySet(MapContext.java:306)
> at java.util.HashMap.putAll(HashMap.java:642)
> at
> org.ofbiz.widget.model.ModelFormField$ListOptions.addOptionValues(ModelFormField.java:2716)
> at
> org.ofbiz.widget.model.ModelFormField$FieldInfoWithOptions.getAllOptionValues(ModelFormField.java:1985)
> at
> org.ofbiz.widget.renderer.macro.MacroFormRenderer.renderDropDownField(MacroFormRenderer.java:747)
> at
> org.ofbiz.widget.model.ModelFormField$DropDownField.renderFieldString(ModelFormField.java:1739)
> at
> org.ofbiz.widget.model.ModelFormField.renderFieldString(ModelFormField.java:693)
> at
> org.ofbiz.widget.renderer.FormRenderer.renderSingleFormString(FormRenderer.java:1195)
> at org.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:261)
> at
> org.ofbiz.widget.model.ModelScreenWidget$Form.renderWidgetString(ModelScreenWidget.java:1052)
> at
> org.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:677)
> at
> org.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.ja
[jira] [Commented] (OFBIZ-6614) Error when using org.ofbiz.base.util.UtilDateTime.toTimestamp("12/30/1899 00:00:00")
[
https://issues.apache.org/jira/browse/OFBIZ-6614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14740968#comment-14740968
]
Adrian Crum commented on OFBIZ-6614:
Most likely there is a flaw in your code. Try using the methods that take a
TimeZone and Locale.
> Error when using org.ofbiz.base.util.UtilDateTime.toTimestamp("12/30/1899
> 00:00:00")
>
>
> Key: OFBIZ-6614
> URL: https://issues.apache.org/jira/browse/OFBIZ-6614
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Reporter: Wei Zhang
>
> The UtilDateTime.toTimestamp("12/30/1899 00:00:00") returns "1899-12-29
> 23:54:03.0". It's caused by com.ibm.icu.util.Calendar. I am not sure if we
> should to use java.util.Calendar instead of
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6561) GenericDelegator.store fails to clear userLogin cache on password update from ecommerce profile
[
https://issues.apache.org/jira/browse/OFBIZ-6561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14642917#comment-14642917
]
Adrian Crum commented on OFBIZ-6561:
Reverting rev 1668267 will probably fix this issue. I have been meaning to do
it, but I haven't had any time.
> GenericDelegator.store fails to clear userLogin cache on password update from
> ecommerce profile
> ---
>
> Key: OFBIZ-6561
> URL: https://issues.apache.org/jira/browse/OFBIZ-6561
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Deepak Dixit
> Attachments: OFBIZ-6561.patch, Screen Shot 2015-07-22 at 2.12.47
> PM.png
>
>
> Here is the steps to regenerate issue:
> - Go to http://demo-trunk-ofbiz.apache.org/ecommerce/control/viewprofile
> - Login with DemoCustomer
> - Go to http://demo-trunk-ofbiz.apache.org/ecommerce/control/changepassword
> - Update password and click on save button
> Password successfully updated, while redirecting to profile page you will get
> following error message:
> {quote}
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen
> [component://ecommerce/widget/CustomerScreens.xml#viewprofile]:
> java.lang.IllegalArgumentException: Error running script at location
> [component://ecommerce/webapp/ecommerce/WEB-INF/actions/customer/ViewProfile.groovy]:
> org.ofbiz.service.ExecutionServiceException: You must be logged in to
> complete the [Get Summary Information About Orders for a Customer] process.
> (Error running script at location
> [component://ecommerce/webapp/ecommerce/WEB-INF/actions/customer/ViewProfile.groovy]:
> org.ofbiz.service.ExecutionServiceException: You must be logged in to
> complete the [Get Summary Information About Orders for a Customer]
> process.){quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-6537) Unable to change users timezone for session
[ https://issues.apache.org/jira/browse/OFBIZ-6537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-6537: -- Assignee: Adrian Crum > Unable to change users timezone for session > --- > > Key: OFBIZ-6537 > URL: https://issues.apache.org/jira/browse/OFBIZ-6537 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Gareth Carter >Assignee: Adrian Crum > > Login as admin and change the timezone, the timezone displayed at the bottom > does not change however the lastTimeZone value in UserLogin does change. > If you log out and login again, you may see the page after login will display > the correct timezone but all other pages accessed afterwards display either > the previous value or the system timezone. > Caching issue? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6537) Unable to change users timezone for session
[ https://issues.apache.org/jira/browse/OFBIZ-6537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14603693#comment-14603693 ] Adrian Crum commented on OFBIZ-6537: The problem is caused by rev 1668267. I will try to fix it first, and if that doesn't work, I will revert rev 1668267. > Unable to change users timezone for session > --- > > Key: OFBIZ-6537 > URL: https://issues.apache.org/jira/browse/OFBIZ-6537 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Gareth Carter > > Login as admin and change the timezone, the timezone displayed at the bottom > does not change however the lastTimeZone value in UserLogin does change. > If you log out and login again, you may see the page after login will display > the correct timezone but all other pages accessed afterwards display either > the previous value or the system timezone. > Caching issue? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6538) How I can place an order for sale, according to a sales agreement already made?
[ https://issues.apache.org/jira/browse/OFBIZ-6538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-6538. -- Resolution: Invalid Please ask your questions on the user mailing list. > How I can place an order for sale, according to a sales agreement already > made? > --- > > Key: OFBIZ-6538 > URL: https://issues.apache.org/jira/browse/OFBIZ-6538 > Project: OFBiz > Issue Type: Task > Components: accounting, order >Affects Versions: Trunk > Environment: How I can place an order for sale, according to a sales > agreement already made? >Reporter: Jonathan > Fix For: Trunk > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6537) Unable to change users timezone for session
[ https://issues.apache.org/jira/browse/OFBIZ-6537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14603079#comment-14603079 ] Adrian Crum commented on OFBIZ-6537: I can confirm this is a bug in the trunk, but not in the R14 branch. > Unable to change users timezone for session > --- > > Key: OFBIZ-6537 > URL: https://issues.apache.org/jira/browse/OFBIZ-6537 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Gareth Carter > > Login as admin and change the timezone, the timezone displayed at the bottom > does not change however the lastTimeZone value in UserLogin does change. > If you log out and login again, you may see the page after login will display > the correct timezone but all other pages accessed afterwards display either > the previous value or the system timezone. > Caching issue? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.
[ https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14601397#comment-14601397 ] Adrian Crum commented on OFBIZ-5608: I need to know if the patch solves your problem. The feature can be used wherever we need a java.util.Date (or one of its subclasses) that does not reference the user's time zone. > Dates Displaying Incorrectly With Negative Offest Timezones. > > > Key: OFBIZ-5608 > URL: https://issues.apache.org/jira/browse/OFBIZ-5608 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk >Reporter: Rupert Howell >Priority: Minor > Attachments: IgnoreTimeZone.patch, ObjectTypeTests.patch, > dates.patch, dates_1589040.patch, sqldate_scenarios.png > > > Dates are displaying incorrectly when negative offset (relative to UTC) are > applied by the users settings. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6531) Support transaction-timout for
[ https://issues.apache.org/jira/browse/OFBIZ-6531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14601352#comment-14601352 ] Adrian Crum commented on OFBIZ-6531: The patch does not do what you describe. > Support transaction-timout for > -- > > Key: OFBIZ-6531 > URL: https://issues.apache.org/jira/browse/OFBIZ-6531 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Priority: Minor > Attachments: OFBIZ-6531.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6531) Support transaction-timout for
[ https://issues.apache.org/jira/browse/OFBIZ-6531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14601245#comment-14601245 ] Adrian Crum commented on OFBIZ-6531: What is the patch supposed to do? > Support transaction-timout for > -- > > Key: OFBIZ-6531 > URL: https://issues.apache.org/jira/browse/OFBIZ-6531 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Priority: Minor > Attachments: OFBIZ-6531.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.
[ https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-5608: --- Attachment: IgnoreTimeZone.patch Gareth - try out the attached file: IgnoreTimeZone.patch. I added an attribute called "ignore-time-zone" to the date-time field widget and the service parameters. Set the attribute to "true" on date-time field widgets you are having problems with, and also set it to true for the corresponding service IN parameters. > Dates Displaying Incorrectly With Negative Offest Timezones. > > > Key: OFBIZ-5608 > URL: https://issues.apache.org/jira/browse/OFBIZ-5608 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk >Reporter: Rupert Howell >Priority: Minor > Attachments: IgnoreTimeZone.patch, ObjectTypeTests.patch, > dates.patch, dates_1589040.patch, sqldate_scenarios.png > > > Dates are displaying incorrectly when negative offset (relative to UTC) are > applied by the users settings. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.
[ https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14600253#comment-14600253 ] Adrian Crum commented on OFBIZ-5608: The Derby driver will "round" the time component of java.sql.Date when it stores it in the DB - that is why I updated the converters to remove the time component. Well, we can try using the default time zone. I was concerned about data corruption if all servers in a cluster do not have the same time zone. > Dates Displaying Incorrectly With Negative Offest Timezones. > > > Key: OFBIZ-5608 > URL: https://issues.apache.org/jira/browse/OFBIZ-5608 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk >Reporter: Rupert Howell >Priority: Minor > Attachments: ObjectTypeTests.patch, dates.patch, dates_1589040.patch, > sqldate_scenarios.png > > > Dates are displaying incorrectly when negative offset (relative to UTC) are > applied by the users settings. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.
[ https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14600234#comment-14600234 ] Adrian Crum commented on OFBIZ-5608: Thank you Gareth! I think we need an option in the form widget date field to "ignore" the user's time zone. The implementation would use UTC for conversions instead of the user's (or server's) time zone. > Dates Displaying Incorrectly With Negative Offest Timezones. > > > Key: OFBIZ-5608 > URL: https://issues.apache.org/jira/browse/OFBIZ-5608 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk >Reporter: Rupert Howell >Priority: Minor > Attachments: ObjectTypeTests.patch, dates.patch, dates_1589040.patch, > sqldate_scenarios.png > > > Dates are displaying incorrectly when negative offset (relative to UTC) are > applied by the users settings. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6334) Widget Refactoring: Have 'request-confirmation' and 'confirmation-message' available for screens and menus
[ https://issues.apache.org/jira/browse/OFBIZ-6334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14594756#comment-14594756 ] Adrian Crum commented on OFBIZ-6334: Widget models and schemas updated in rev 168. If someone will supply a patch for the renderers, I will commit it. > Widget Refactoring: Have 'request-confirmation' and 'confirmation-message' > available for screens and menus > -- > > Key: OFBIZ-6334 > URL: https://issues.apache.org/jira/browse/OFBIZ-6334 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Release Branch 14.12, Upcoming Branch >Reporter: Pierre Smits >Assignee: Adrian Crum >Priority: Minor > Labels: xsd > > Currently 'request-confirmation' and 'confirmation-message' are only defined > in the xsd for forms, yet they can also be applied in screen and menu links. > Having it for screens and menu links improves the developer experience. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6334) Widget Refactoring: Have 'request-confirmation' and 'confirmation-message' available for screens and menus
[ https://issues.apache.org/jira/browse/OFBIZ-6334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-6334: --- Priority: Minor (was: Major) Affects Version/s: Upcoming Branch Release Branch 14.12 > Widget Refactoring: Have 'request-confirmation' and 'confirmation-message' > available for screens and menus > -- > > Key: OFBIZ-6334 > URL: https://issues.apache.org/jira/browse/OFBIZ-6334 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Release Branch 14.12, Upcoming Branch >Reporter: Pierre Smits >Assignee: Adrian Crum >Priority: Minor > Labels: xsd > > Currently 'request-confirmation' and 'confirmation-message' are only defined > in the xsd for forms, yet they can also be applied in screen and menu links. > Having it for screens and menu links improves the developer experience. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6334) Widget Refactoring: Have 'request-confirmation' and 'confirmation-message' available for screens and menus
[ https://issues.apache.org/jira/browse/OFBIZ-6334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14594718#comment-14594718 ] Adrian Crum commented on OFBIZ-6334: The 'request-confirmation' and 'confirmation-message' menu item attributes were available prior to the recent widget refactor, but they were only used by the HTML renderer (not the macro renderer). So, I removed them. I will put them back in the menu widget models, but someone else will need to update the renderers to use them. > Widget Refactoring: Have 'request-confirmation' and 'confirmation-message' > available for screens and menus > -- > > Key: OFBIZ-6334 > URL: https://issues.apache.org/jira/browse/OFBIZ-6334 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Pierre Smits >Assignee: Adrian Crum > Labels: xsd > > Currently 'request-confirmation' and 'confirmation-message' are only defined > in the xsd for forms, yet they can also be applied in screen and menu links. > Having it for screens and menu links improves the developer experience. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-6334) Widget Refactoring: Have 'request-confirmation' and 'confirmation-message' available for screens and menus
[ https://issues.apache.org/jira/browse/OFBIZ-6334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-6334: -- Assignee: Adrian Crum > Widget Refactoring: Have 'request-confirmation' and 'confirmation-message' > available for screens and menus > -- > > Key: OFBIZ-6334 > URL: https://issues.apache.org/jira/browse/OFBIZ-6334 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Pierre Smits >Assignee: Adrian Crum > Labels: xsd > > Currently 'request-confirmation' and 'confirmation-message' are only defined > in the xsd for forms, yet they can also be applied in screen and menu links. > Having it for screens and menu links improves the developer experience. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6362) Move js & css references from CommonDecorator(s) to themes
[ https://issues.apache.org/jira/browse/OFBIZ-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-6362. -- Resolution: Fixed Fix Version/s: Upcoming Branch Fixed in rev 1686655. I did not add the new visual themes because that is out of scope for this issue. > Move js & css references from CommonDecorator(s) to themes > -- > > Key: OFBIZ-6362 > URL: https://issues.apache.org/jira/browse/OFBIZ-6362 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk, Upcoming Branch >Reporter: Pierre Smits >Assignee: Adrian Crum >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-6263-BlueLight-header.ftl.patch, > OFBIZ-6362-BizznessTime-header.ftl.patch, > OFBIZ-6362-BizznessTimeThemeData.xml.patch, > OFBIZ-6362-BlueLightThemeData.xml.patch, OFBIZ-6362-CommonScreens.xml.patch, > OFBIZ-6362-DroppingCrumbs-header.ftl.patch, > OFBIZ-6362-DroppingCrumbsThemeData.xml.patch, > OFBIZ-6362-FlatGrey-header.ftl.patch, OFBIZ-6362-FlatGreyThemeData.xml.patch, > OFBIZ-6362-Tomahawk-header.ftl.patch, OFBIZ-6362-TomahawkThemeData.xml.patch, > OFBIZ-6362-bbasic-theme.patch, OFBIZ-6362-sunrise-theme.patch, bbasic.zip, > sunrise.zip > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6516) Facilitate the use of Icons in Ofbiz by adding descriptive style to the widget-style attribute in forms
[ https://issues.apache.org/jira/browse/OFBIZ-6516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14593624#comment-14593624 ] Adrian Crum commented on OFBIZ-6516: That needs to go away. "Buttons" are styled by their containing HTML element. > Facilitate the use of Icons in Ofbiz by adding descriptive style to the > widget-style attribute in forms > --- > > Key: OFBIZ-6516 > URL: https://issues.apache.org/jira/browse/OFBIZ-6516 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: 14.12.01, 12.04.06, 13.07.03, Upcoming Branch > Environment: Ofbiz Web UI >Reporter: Gavin Mabie >Priority: Minor > > Icons can be used to great effect to enhance both the user experience and as > well as the look-and-feel of an application. In Ofbiz this is facilitated by > using meaningful styles name in the widget-style attribute. Examples are > "buttontext create", buttontext delete/remove", "buttontext update". That > takes care of the basic CRUD actions. The widget-style attribute is used by > front-end designers (on the presentation layer) to create their own designs > via macro libraries, stylesheets and javascript files. It will be useful for > designers if widget-styles are defined in a standard way in widget > definitions (*forms.xml, *menu.xml etc). To set this process in motion I > propose the following: > 1. All "buttontext" widget-style attributes should have a meaningful > additional class which describes the action linked to the button, i.e create, > update, delete, refresh - depending on the action. > 2. Add missing descriptive classes like "copy, print, view, download, save" > etc. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6516) Facilitate the use of Icons in Ofbiz by adding descriptive style to the widget-style attribute in forms
[ https://issues.apache.org/jira/browse/OFBIZ-6516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592187#comment-14592187 ] Adrian Crum commented on OFBIZ-6516: I don't think "buttontext" is a valid CSS class: https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+maincss.css+HTML+Element+Collection+Styles > Facilitate the use of Icons in Ofbiz by adding descriptive style to the > widget-style attribute in forms > --- > > Key: OFBIZ-6516 > URL: https://issues.apache.org/jira/browse/OFBIZ-6516 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: 14.12.01, 12.04.06, 13.07.03, Upcoming Branch > Environment: Ofbiz Web UI >Reporter: Gavin Mabie >Priority: Minor > > Icons can be used to great effect to enhance both the user experience and as > well as the look-and-feel of an application. In Ofbiz this is facilitated by > using meaningful styles name in the widget-style attribute. Examples are > "buttontext create", buttontext delete/remove", "buttontext update". That > takes care of the basic CRUD actions. The widget-style attribute is used by > front-end designers (on the presentation layer) to create their own designs > via macro libraries, stylesheets and javascript files. It will be useful for > designers if widget-styles are defined in a standard way in widget > definitions (*forms.xml, *menu.xml etc). To set this process in motion I > propose the following: > 1. All "buttontext" widget-style attributes should have a meaningful > additional class which describes the action linked to the button, i.e create, > update, delete, refresh - depending on the action. > 2. Add missing descriptive classes like "copy, print, view, download, save" > etc. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6404) Allow form/grid widget hyperlinks to be grouped into a single column
[ https://issues.apache.org/jira/browse/OFBIZ-6404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14585212#comment-14585212 ] Adrian Crum commented on OFBIZ-6404: The widget model changes look okay to me. I don't have time to review the entire patch. > Allow form/grid widget hyperlinks to be grouped into a single column > > > Key: OFBIZ-6404 > URL: https://issues.apache.org/jira/browse/OFBIZ-6404 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow > Attachments: OFBIZ-6404.patch, OFBIZ-6404_2.patch > > > This issue was created from a Nicholas Malin's suggestion in OFBIZ-6402 to > support hyperlink rendering similar to the original FTL that was replaced by > the patch for that issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6456) Make sort by field type by default
[ https://issues.apache.org/jira/browse/OFBIZ-6456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575857#comment-14575857 ] Adrian Crum commented on OFBIZ-6456: I don't agree that sorting input fields by type is easier to interpret. From my perspective, fields that are most relevant should appear first, followed by fields that are less relevant, and then fields that are least relevant should appear last. That approach allows a user to enter only relevant data, and then skip the rest of the form. > Make sort by field type by default > --- > > Key: OFBIZ-6456 > URL: https://issues.apache.org/jira/browse/OFBIZ-6456 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow > Attachments: OFBIZ-6456_3.patch > > > IMO, form widgets are generally easier to interpret when the field types are > sorted by type but this has to be done manually using . I > propose improving auto-fields-entity to sort fields by type by default such > as text, then dates, then numbers, etc. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6468) Add support for ModelFormField.type tracking from ModelFormFieldBuilder
[ https://issues.apache.org/jira/browse/OFBIZ-6468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-6468: --- Summary: Add support for ModelFormField.type tracking from ModelFormFieldBuilder (was: Add support for ModelForm.type tracking from ModelFormFieldBuilder) > Add support for ModelFormField.type tracking from ModelFormFieldBuilder > --- > > Key: OFBIZ-6468 > URL: https://issues.apache.org/jira/browse/OFBIZ-6468 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Priority: Minor > Attachments: OFBIZ-6468_2.patch > > > This could be done by adding ModelFormFieldBuilder.modelField as new member > for tracking the entire ModelField object or if thats overkill adding > ModelFormFieldBuilder.modelFieldType for just the type. > This functionality would provide a way for OFBIZ-6456 to ignore the default > field sequence sort for id type fields that are hyperlinks which typically > appear as beginning fields. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6463) ordermgr/control/deleteCustRequestParty should delete the record rather than updating the through date
[ https://issues.apache.org/jira/browse/OFBIZ-6463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575559#comment-14575559 ] Adrian Crum commented on OFBIZ-6463: That would make more sense. > ordermgr/control/deleteCustRequestParty should delete the record rather than > updating the through date > -- > > Key: OFBIZ-6463 > URL: https://issues.apache.org/jira/browse/OFBIZ-6463 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Christian Carlow >Priority: Minor > Attachments: OFBIZ-6463.patch > > > Users expect to be able to remove accidentally added faulty CustRequestParty > but the current implementation only updates the through date when the delete > button is clicked. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-6463) ordermgr/control/deleteCustRequestParty should delete the record rather than updating the through date
[ https://issues.apache.org/jira/browse/OFBIZ-6463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575544#comment-14575544 ] Adrian Crum edited comment on OFBIZ-6463 at 6/6/15 3:11 AM: The attached patch breaks the design pattern that exists throughout the project. Intersection entities that include a date range are expired, not deleted. Instead of replacing expiration with deletion, maybe deletion could be ADDED to expiration. was (Author: adri...@hlmksw.com): The attached patch breaks the design pattern that exists throughout the project. Intersection entities that include a date range a re expired, not deleted. Instead of replacing expiration with deletion, maybe deletion could be ADDED to expiration. > ordermgr/control/deleteCustRequestParty should delete the record rather than > updating the through date > -- > > Key: OFBIZ-6463 > URL: https://issues.apache.org/jira/browse/OFBIZ-6463 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Christian Carlow >Priority: Minor > Attachments: OFBIZ-6463.patch > > > Users expect to be able to remove accidentally added faulty CustRequestParty > but the current implementation only updates the through date when the delete > button is clicked. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6463) ordermgr/control/deleteCustRequestParty should delete the record rather than updating the through date
[ https://issues.apache.org/jira/browse/OFBIZ-6463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575544#comment-14575544 ] Adrian Crum commented on OFBIZ-6463: The attached patch breaks the design pattern that exists throughout the project. Intersection entities that include a date range a re expired, not deleted. Instead of replacing expiration with deletion, maybe deletion could be ADDED to expiration. > ordermgr/control/deleteCustRequestParty should delete the record rather than > updating the through date > -- > > Key: OFBIZ-6463 > URL: https://issues.apache.org/jira/browse/OFBIZ-6463 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Christian Carlow >Priority: Minor > Attachments: OFBIZ-6463.patch > > > Users expect to be able to remove accidentally added faulty CustRequestParty > but the current implementation only updates the through date when the delete > button is clicked. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6407) Replace find fields at webtools/control/FindGeneric with whatever would be rendered using
[ https://issues.apache.org/jira/browse/OFBIZ-6407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14558263#comment-14558263 ] Adrian Crum commented on OFBIZ-6407: The screen that you are trying to convert to widgets is particularly unique, therefore it is not suitable for a generic rendering method like the screen widgets. From my perspective, there are two options here: 1. Keep the existing template, and make sure it follows HTML/CSS best practices. 2. Extend the widgets to enable rendering entity/service models. > Replace find fields at webtools/control/FindGeneric with whatever would be > rendered using default-field-type="find"/> > - > > Key: OFBIZ-6407 > URL: https://issues.apache.org/jira/browse/OFBIZ-6407 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow > Attachments: OFBIZ-6407.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6410) Allow form widget entity-name attribute be set dynamically from context
[ https://issues.apache.org/jira/browse/OFBIZ-6410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14557884#comment-14557884 ] Adrian Crum commented on OFBIZ-6410: Please take some time to understand how the widget models work. You cannot supply a context Map to the constructor because each request/thread will have its own context Map, and model instances are shared by multiple requests/threads. Evaluating the entity name while rendering will be tricky, maybe impossible. > Allow form widget entity-name attribute be set > dynamically from context > > > Key: OFBIZ-6410 > URL: https://issues.apache.org/jira/browse/OFBIZ-6410 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow > Attachments: OFBIZ-6410.patch > > > This functionality will be used to provide a simple solution for OFBIZ-6407. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6408) Adding a group order generates an error
[
https://issues.apache.org/jira/browse/OFBIZ-6408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14557556#comment-14557556
]
Adrian Crum commented on OFBIZ-6408:
The invalid expression (and its containing form widget) were introduced in rev
1204805, so this has never worked.
> Adding a group order generates an error
> ---
>
> Key: OFBIZ-6408
> URL: https://issues.apache.org/jira/browse/OFBIZ-6408
> Project: OFBiz
> Issue Type: Bug
> Components: product
>Affects Versions: Trunk, 13.07.01
>Reporter: Pierre Smits
> Labels: GroupOrder, catalog
>
> When adding a Group Order for a product the following error is returned:
> {code}
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen
> [component://product/widget/catalog/ProductScreens.xml#ViewProductGroupOrder]:
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen
> [component://product/widget/catalog/ProductScreens.xml#CommonProductDecorator]:
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen
> [component://product/widget/catalog/CommonScreens.xml#main-decorator]:
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen
> [component://commonext/widget/CommonScreens.xml#ApplicationDecorator]:
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen
> [component://common/widget/CommonScreens.xml#GlobalDecorator]:
> java.lang.RuntimeException: Error rendering included form named
> [ListProductGroupOrder] at location
> [component://product/widget/catalog/ProductForms.xml]:
> java.lang.IllegalArgumentException: Error evaluating BeanShell use-when
> condition [true&&] on the field editLink of form ListProductGroupOrder: In
> file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7.
> java.lang.IllegalArgumentException: Error evaluating BeanShell use-when
> condition [true&&] on the field editLink of form ListProductGroupOrder: In
> file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7.
> (Error rendering included form named [ListProductGroupOrder] at location
> [component://product/widget/catalog/ProductForms.xml]:
> java.lang.IllegalArgumentException: Error evaluating BeanShell use-when
> condition [true&&] on the field editLink of form ListProductGroupOrder: In
> file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7.
> java.lang.IllegalArgumentException: Error evaluating BeanShell use-when
> condition [true&&] on the field editLink of form ListProductGroupOrder: In
> file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7.
> ) (Error rendering screen
> [component://common/widget/CommonScreens.xml#GlobalDecorator]:
> java.lang.RuntimeException: Error rendering included form named
> [ListProductGroupOrder] at location
> [component://product/widget/catalog/ProductForms.xml]:
> java.lang.IllegalArgumentException: Error evaluating BeanShell use-when
> condition [true&&] on the field editLink of form ListProductGroupOrder: In
> file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7.
> java.lang.IllegalArgumentException: Error evaluating BeanShell use-when
> condition [true&&] on the field editLink of form ListProductGroupOrder: In
> file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7.
> (Error rendering included form named [ListProductGroupOrder] at location
> [component://product/widget/catalog/ProductForms.xml]:
> java.lang.IllegalArgumentException: Error evaluating BeanShell use-when
> condition [true&&] on the field editLink of form ListProductGroupOrder: In
> file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7.
> java.lang.IllegalArgumentException: Error evaluating BeanShell use-when
> condition [true&&] on the field editLink of form ListProductGroupOrder: In
> file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7.
> )) (Error rendering screen
> [component://commonext/widget/CommonScreens.xml#ApplicationDecorator]:
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen
> [component://common/widget/CommonScreens.xml#GlobalDecorator]:
> java.lang.RuntimeException: Error rendering included form named
> [ListProductGroupOrder] at location
> [component://product/widget/catalog/ProductForms.xml]:
> java.lang.IllegalArgumentException: Error evaluating BeanShell use-when
> condition [true&&] on the field editLink of form ListProductGroupOrder: In
> file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7.
> java.lang.IllegalArgumentException: Error evaluating BeanShell use-when
> condition [true&&] on the field editLink of form ListProductGroupOrder: In
> file: inline evaluation of: ``true&&;'' Enco
[jira] [Commented] (OFBIZ-6408) Adding a group order generates an error
[
https://issues.apache.org/jira/browse/OFBIZ-6408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14557553#comment-14557553
]
Adrian Crum commented on OFBIZ-6408:
The error is caused by an invalid expression, as the log entries make clear:
{code}
{code}
> Adding a group order generates an error
> ---
>
> Key: OFBIZ-6408
> URL: https://issues.apache.org/jira/browse/OFBIZ-6408
> Project: OFBiz
> Issue Type: Bug
> Components: product
>Affects Versions: Trunk, 13.07.01
>Reporter: Pierre Smits
> Labels: GroupOrder, catalog
>
> When adding a Group Order for a product the following error is returned:
> {code}
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen
> [component://product/widget/catalog/ProductScreens.xml#ViewProductGroupOrder]:
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen
> [component://product/widget/catalog/ProductScreens.xml#CommonProductDecorator]:
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen
> [component://product/widget/catalog/CommonScreens.xml#main-decorator]:
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen
> [component://commonext/widget/CommonScreens.xml#ApplicationDecorator]:
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen
> [component://common/widget/CommonScreens.xml#GlobalDecorator]:
> java.lang.RuntimeException: Error rendering included form named
> [ListProductGroupOrder] at location
> [component://product/widget/catalog/ProductForms.xml]:
> java.lang.IllegalArgumentException: Error evaluating BeanShell use-when
> condition [true&&] on the field editLink of form ListProductGroupOrder: In
> file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7.
> java.lang.IllegalArgumentException: Error evaluating BeanShell use-when
> condition [true&&] on the field editLink of form ListProductGroupOrder: In
> file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7.
> (Error rendering included form named [ListProductGroupOrder] at location
> [component://product/widget/catalog/ProductForms.xml]:
> java.lang.IllegalArgumentException: Error evaluating BeanShell use-when
> condition [true&&] on the field editLink of form ListProductGroupOrder: In
> file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7.
> java.lang.IllegalArgumentException: Error evaluating BeanShell use-when
> condition [true&&] on the field editLink of form ListProductGroupOrder: In
> file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7.
> ) (Error rendering screen
> [component://common/widget/CommonScreens.xml#GlobalDecorator]:
> java.lang.RuntimeException: Error rendering included form named
> [ListProductGroupOrder] at location
> [component://product/widget/catalog/ProductForms.xml]:
> java.lang.IllegalArgumentException: Error evaluating BeanShell use-when
> condition [true&&] on the field editLink of form ListProductGroupOrder: In
> file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7.
> java.lang.IllegalArgumentException: Error evaluating BeanShell use-when
> condition [true&&] on the field editLink of form ListProductGroupOrder: In
> file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7.
> (Error rendering included form named [ListProductGroupOrder] at location
> [component://product/widget/catalog/ProductForms.xml]:
> java.lang.IllegalArgumentException: Error evaluating BeanShell use-when
> condition [true&&] on the field editLink of form ListProductGroupOrder: In
> file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7.
> java.lang.IllegalArgumentException: Error evaluating BeanShell use-when
> condition [true&&] on the field editLink of form ListProductGroupOrder: In
> file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7.
> )) (Error rendering screen
> [component://commonext/widget/CommonScreens.xml#ApplicationDecorator]:
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen
> [component://common/widget/CommonScreens.xml#GlobalDecorator]:
> java.lang.RuntimeException: Error rendering included form named
> [ListProductGroupOrder] at location
> [component://product/widget/catalog/ProductForms.xml]:
> java.lang.IllegalArgumentException: Error evaluating BeanShell use-when
> condition [true&&] on the field editLink of form ListProductGroupOrder: In
> file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7.
> java.lang.IllegalArgumentException: Error evaluating BeanShell use-when
> condition [true&&] on the field editLink of form ListProductGroupO
[jira] [Commented] (OFBIZ-6402) Replace FTL at webtools/control/entitymaint with widgets
[
https://issues.apache.org/jira/browse/OFBIZ-6402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14556552#comment-14556552
]
Adrian Crum commented on OFBIZ-6402:
Christian,
I you want a single form, use the widget, if you want a list or grid,
use the widget. In both widgets, the type attribute is not needed. Your
patch needs to be fixed.
To clarify,
{code}
{code}
has been replaced by
{code}
{code}
and
{code}
{code}
has been replaced by
{code}
{code}
I hope that makes sense.
> Replace FTL at webtools/control/entitymaint with widgets
>
>
> Key: OFBIZ-6402
> URL: https://issues.apache.org/jira/browse/OFBIZ-6402
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Christian Carlow
> Attachments: OFBIZ-6402_3.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6402) Replace FTL at webtools/control/entitymaint with widgets
[
https://issues.apache.org/jira/browse/OFBIZ-6402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14556413#comment-14556413
]
Adrian Crum commented on OFBIZ-6402:
This is a good start. The "Find By First Letter" feature doesn't work. The grid
needs a link added to it. Also,
{code}
{code}
should be
{code}
{code}
> Replace FTL at webtools/control/entitymaint with widgets
>
>
> Key: OFBIZ-6402
> URL: https://issues.apache.org/jira/browse/OFBIZ-6402
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Christian Carlow
> Attachments: OFBIZ-6402.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6396) Field Lookup do not show description when widget-verbose is set to false
[
https://issues.apache.org/jira/browse/OFBIZ-6396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554322#comment-14554322
]
Adrian Crum commented on OFBIZ-6396:
It worked fine for me. I did not see any "bad spaces."
> Field Lookup do not show description when widget-verbose is set to false
>
>
> Key: OFBIZ-6396
> URL: https://issues.apache.org/jira/browse/OFBIZ-6396
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Release
> Branch 14.12, Trunk
>Reporter: Gil Portenseigne
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 14.12.01, 13.07.03, Upcoming Branch
>
> Attachments: OFBIZ-6396.patch, fieldlookup.js.patch
>
>
> When widget verbose is set to false and using field lookup, the description
> of the selected object is not displayed (not using auto completion but the
> popup).
> To reproduice : Set in framework/widget/config/widget.properties
> {code}widget.verbose=false{code}
> Clear OFBiz cache then go to :
> https://localhost:8443/partymgr/control/EditPartyRelationships?partyId=Company
> In the partyRelationship creation form, in party Id From field, click on
> lookup, search, select AUTHOR_MADMAX, and so no description displayed.
> Using autocompletion it's fine.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-6396) Field Lookup do not show description when widget-verbose is set to false
[
https://issues.apache.org/jira/browse/OFBIZ-6396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrian Crum updated OFBIZ-6396:
---
Attachment: fieldlookup.js.patch
See the attached patch.
> Field Lookup do not show description when widget-verbose is set to false
>
>
> Key: OFBIZ-6396
> URL: https://issues.apache.org/jira/browse/OFBIZ-6396
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Release
> Branch 14.12, Trunk
>Reporter: Gil Portenseigne
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 14.12.01, 13.07.03, Upcoming Branch
>
> Attachments: OFBIZ-6396.patch, fieldlookup.js.patch
>
>
> When widget verbose is set to false and using field lookup, the description
> of the selected object is not displayed (not using auto completion but the
> popup).
> To reproduice : Set in framework/widget/config/widget.properties
> {code}widget.verbose=false{code}
> Clear OFBiz cache then go to :
> https://localhost:8443/partymgr/control/EditPartyRelationships?partyId=Company
> In the partyRelationship creation form, in party Id From field, click on
> lookup, search, select AUTHOR_MADMAX, and so no description displayed.
> Using autocompletion it's fine.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6396) Field Lookup do not show description when widget-verbose is set to false
[
https://issues.apache.org/jira/browse/OFBIZ-6396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554273#comment-14554273
]
Adrian Crum commented on OFBIZ-6396:
Jacques,
I have this fixed on my local copy. The attached patch is not necessary.
> Field Lookup do not show description when widget-verbose is set to false
>
>
> Key: OFBIZ-6396
> URL: https://issues.apache.org/jira/browse/OFBIZ-6396
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Release
> Branch 14.12, Trunk
>Reporter: Gil Portenseigne
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-6396.patch
>
>
> When widget verbose is set to false and using field lookup, the description
> of the selected object is not displayed (not using auto completion but the
> popup).
> To reproduice : Set in framework/widget/config/widget.properties
> {code}widget.verbose=false{code}
> Clear OFBiz cache then go to :
> https://localhost:8443/partymgr/control/EditPartyRelationships?partyId=Company
> In the partyRelationship creation form, in party Id From field, click on
> lookup, search, select AUTHOR_MADMAX, and so no description displayed.
> Using autocompletion it's fine.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-5840) Create bootstrap theme
[ https://issues.apache.org/jira/browse/OFBIZ-5840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-5840: --- Attachment: styling_issue_9.png styling_issue_9.png shows styling issues in the Layout Demo screen: https://localhost:8443/webtools/control/WebtoolsLayoutDemo > Create bootstrap theme > -- > > Key: OFBIZ-5840 > URL: https://issues.apache.org/jira/browse/OFBIZ-5840 > Project: OFBiz > Issue Type: New Feature > Components: framework, themes >Affects Versions: Bootstrap theme >Reporter: Julien NICOLAS > Labels: bootstrap, theme > Attachments: Facility.PNG, FindAgreement..png, Footer.jpg, > GlobalDecorator.patch, ImprovedFooter.patch, MacroMenuRenderer.patch, > OFBIZ-5840-Menufactory.patch, OFBIZ-5840-Menufactory.patch, > appbar_menu_ftl.patch, bootified.js, bootified_js_screentrans.patch, > bootstrap-theme.zip, bootstrap.zip, calendar.PNG, catalog.png, > htmlMenuMacroLibrary.patch, pagination_htmlFormMacroLibrary.patch, > panelCollapse_htmlSreenMacroLibrary.patch, party menu tab bar.PNG, > preferences.png, styling_issue_1.png, styling_issue_2.png, > styling_issue_3.png, styling_issue_4.png, styling_issue_5.png, > styling_issue_6.png, styling_issue_7.png, styling_issue_8.png, > styling_issue_9.png, tab-bar.png, workeffort.PNG > > > 1- create a sub-directory called bootstrap under the image webapp to put > the resources over there (js, css and fonts) as indicated earlier by Gavin. > (Julien : not sure about location) > 2- check to make sure that the current version of jQuery is compatible with > the installed version or upgrade it accordingly > 3- Create a new theme based on one of the existing themes as suggested by > Julien and Gavin > 4- Test the theme by switching to it and handle major bugs / issues. > 5- Start to make a few test screens utilizing Bootstrap -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-6394) Have login screen rendered in bootstrap-basic theme
[ https://issues.apache.org/jira/browse/OFBIZ-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14550824#comment-14550824 ] Adrian Crum edited comment on OFBIZ-6394 at 5/19/15 5:28 PM: - This is normal behavior in all themes. When a user is logged out, OFBiz reverts to the configured default visual theme. was (Author: adri...@hlmksw.com): This normal behavior in all themes. When a user is logged out, OFBiz reverts to the configured default visual theme. > Have login screen rendered in bootstrap-basic theme > --- > > Key: OFBIZ-6394 > URL: https://issues.apache.org/jira/browse/OFBIZ-6394 > Project: OFBiz > Issue Type: Sub-task > Components: themes >Affects Versions: Bootstrap theme >Reporter: Pierre Smits > > When logging out - or accessing OFBiz in a new session - while using the > Bootstrap-Basic theme, the theme used is that of Tomahawk. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6394) Have login screen rendered in bootstrap-basic theme
[ https://issues.apache.org/jira/browse/OFBIZ-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-6394. -- Resolution: Invalid > Have login screen rendered in bootstrap-basic theme > --- > > Key: OFBIZ-6394 > URL: https://issues.apache.org/jira/browse/OFBIZ-6394 > Project: OFBiz > Issue Type: Sub-task > Components: themes >Affects Versions: Bootstrap theme >Reporter: Pierre Smits > > When logging out - or accessing OFBiz in a new session - while using the > Bootstrap-Basic theme, the theme used is that of Tomahawk. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6394) Have login screen rendered in bootstrap-basic theme
[ https://issues.apache.org/jira/browse/OFBIZ-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14550824#comment-14550824 ] Adrian Crum commented on OFBIZ-6394: This normal behavior in all themes. When a user is logged out, OFBiz reverts to the configured default visual theme. > Have login screen rendered in bootstrap-basic theme > --- > > Key: OFBIZ-6394 > URL: https://issues.apache.org/jira/browse/OFBIZ-6394 > Project: OFBiz > Issue Type: Sub-task > Components: themes >Affects Versions: Bootstrap theme >Reporter: Pierre Smits > > When logging out - or accessing OFBiz in a new session - while using the > Bootstrap-Basic theme, the theme used is that of Tomahawk. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-5840) Create bootstrap theme
[ https://issues.apache.org/jira/browse/OFBIZ-5840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-5840: --- Attachment: styling_issue_8.png styling_issue_8.png shows some styling flaws in the lookup screen. The dialog window style does not match the rest of the screen, and the Close button seems to be missing an icon. > Create bootstrap theme > -- > > Key: OFBIZ-5840 > URL: https://issues.apache.org/jira/browse/OFBIZ-5840 > Project: OFBiz > Issue Type: New Feature > Components: framework, themes >Affects Versions: Bootstrap theme >Reporter: Julien NICOLAS > Labels: bootstrap, theme > Attachments: Facility.PNG, FindAgreement..png, Footer.jpg, > GlobalDecorator.patch, ImprovedFooter.patch, MacroMenuRenderer.patch, > OFBIZ-5840-Menufactory.patch, OFBIZ-5840-Menufactory.patch, > appbar_menu_ftl.patch, bootified.js, bootified_js_screentrans.patch, > bootstrap-theme.zip, bootstrap.zip, calendar.PNG, catalog.png, > htmlMenuMacroLibrary.patch, pagination_htmlFormMacroLibrary.patch, > panelCollapse_htmlSreenMacroLibrary.patch, party menu tab bar.PNG, > preferences.png, styling_issue_1.png, styling_issue_2.png, > styling_issue_3.png, styling_issue_4.png, styling_issue_5.png, > styling_issue_6.png, styling_issue_7.png, styling_issue_8.png, tab-bar.png, > workeffort.PNG > > > 1- create a sub-directory called bootstrap under the image webapp to put > the resources over there (js, css and fonts) as indicated earlier by Gavin. > (Julien : not sure about location) > 2- check to make sure that the current version of jQuery is compatible with > the installed version or upgrade it accordingly > 3- Create a new theme based on one of the existing themes as suggested by > Julien and Gavin > 4- Test the theme by switching to it and handle major bugs / issues. > 5- Start to make a few test screens utilizing Bootstrap -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-5840) Create bootstrap theme
[ https://issues.apache.org/jira/browse/OFBIZ-5840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14550786#comment-14550786 ] Adrian Crum edited comment on OFBIZ-5840 at 5/19/15 5:12 PM: - styling_issue_7.png shows flaws in how sub-menus are handled. Clicking on the Facility menu item should bring up a Find Facility screen, but instead it brings up a Create New Facility screen. The Create New Facility screen layout is broken. was (Author: adri...@hlmksw.com): styling_issue_7.png shows flaws in how sub-menus are handled. Clicking on the Facility menu item should bring up a Find Facility screen, but instead it brings up a Create New Facility screen. The Create New Faility screen layout is broken. > Create bootstrap theme > -- > > Key: OFBIZ-5840 > URL: https://issues.apache.org/jira/browse/OFBIZ-5840 > Project: OFBiz > Issue Type: New Feature > Components: framework, themes >Affects Versions: Bootstrap theme >Reporter: Julien NICOLAS > Labels: bootstrap, theme > Attachments: Facility.PNG, FindAgreement..png, Footer.jpg, > GlobalDecorator.patch, ImprovedFooter.patch, MacroMenuRenderer.patch, > OFBIZ-5840-Menufactory.patch, OFBIZ-5840-Menufactory.patch, > appbar_menu_ftl.patch, bootified.js, bootified_js_screentrans.patch, > bootstrap-theme.zip, bootstrap.zip, calendar.PNG, catalog.png, > htmlMenuMacroLibrary.patch, pagination_htmlFormMacroLibrary.patch, > panelCollapse_htmlSreenMacroLibrary.patch, party menu tab bar.PNG, > preferences.png, styling_issue_1.png, styling_issue_2.png, > styling_issue_3.png, styling_issue_4.png, styling_issue_5.png, > styling_issue_6.png, styling_issue_7.png, tab-bar.png, workeffort.PNG > > > 1- create a sub-directory called bootstrap under the image webapp to put > the resources over there (js, css and fonts) as indicated earlier by Gavin. > (Julien : not sure about location) > 2- check to make sure that the current version of jQuery is compatible with > the installed version or upgrade it accordingly > 3- Create a new theme based on one of the existing themes as suggested by > Julien and Gavin > 4- Test the theme by switching to it and handle major bugs / issues. > 5- Start to make a few test screens utilizing Bootstrap -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-5840) Create bootstrap theme
[ https://issues.apache.org/jira/browse/OFBIZ-5840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-5840: --- Attachment: styling_issue_7.png styling_issue_7.png shows flaws in how sub-menus are handled. Clicking on the Facility menu item should bring up a Find Facility screen, but instead it brings up a Create New Facility screen. The Create New Faility screen layout is broken. > Create bootstrap theme > -- > > Key: OFBIZ-5840 > URL: https://issues.apache.org/jira/browse/OFBIZ-5840 > Project: OFBiz > Issue Type: New Feature > Components: framework, themes >Affects Versions: Bootstrap theme >Reporter: Julien NICOLAS > Labels: bootstrap, theme > Attachments: Facility.PNG, FindAgreement..png, Footer.jpg, > GlobalDecorator.patch, ImprovedFooter.patch, MacroMenuRenderer.patch, > OFBIZ-5840-Menufactory.patch, OFBIZ-5840-Menufactory.patch, > appbar_menu_ftl.patch, bootified.js, bootified_js_screentrans.patch, > bootstrap-theme.zip, bootstrap.zip, calendar.PNG, catalog.png, > htmlMenuMacroLibrary.patch, pagination_htmlFormMacroLibrary.patch, > panelCollapse_htmlSreenMacroLibrary.patch, party menu tab bar.PNG, > preferences.png, styling_issue_1.png, styling_issue_2.png, > styling_issue_3.png, styling_issue_4.png, styling_issue_5.png, > styling_issue_6.png, styling_issue_7.png, tab-bar.png, workeffort.PNG > > > 1- create a sub-directory called bootstrap under the image webapp to put > the resources over there (js, css and fonts) as indicated earlier by Gavin. > (Julien : not sure about location) > 2- check to make sure that the current version of jQuery is compatible with > the installed version or upgrade it accordingly > 3- Create a new theme based on one of the existing themes as suggested by > Julien and Gavin > 4- Test the theme by switching to it and handle major bugs / issues. > 5- Start to make a few test screens utilizing Bootstrap -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-5840) Create bootstrap theme
[ https://issues.apache.org/jira/browse/OFBIZ-5840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-5840: --- Attachment: styling_issue_6.png styling_issue_5.png styling_issue_5.png and styling_issue_6.png show a flaw in how sub-menus are handled. The menu items under Facility should not appear unless a Facility has been selected. If I click on the Children menu item, I get the error message in styling_issue_6.png. > Create bootstrap theme > -- > > Key: OFBIZ-5840 > URL: https://issues.apache.org/jira/browse/OFBIZ-5840 > Project: OFBiz > Issue Type: New Feature > Components: framework, themes >Affects Versions: Bootstrap theme >Reporter: Julien NICOLAS > Labels: bootstrap, theme > Attachments: Facility.PNG, FindAgreement..png, Footer.jpg, > GlobalDecorator.patch, ImprovedFooter.patch, MacroMenuRenderer.patch, > OFBIZ-5840-Menufactory.patch, OFBIZ-5840-Menufactory.patch, > appbar_menu_ftl.patch, bootified.js, bootified_js_screentrans.patch, > bootstrap-theme.zip, bootstrap.zip, calendar.PNG, catalog.png, > htmlMenuMacroLibrary.patch, pagination_htmlFormMacroLibrary.patch, > panelCollapse_htmlSreenMacroLibrary.patch, party menu tab bar.PNG, > preferences.png, styling_issue_1.png, styling_issue_2.png, > styling_issue_3.png, styling_issue_4.png, styling_issue_5.png, > styling_issue_6.png, tab-bar.png, workeffort.PNG > > > 1- create a sub-directory called bootstrap under the image webapp to put > the resources over there (js, css and fonts) as indicated earlier by Gavin. > (Julien : not sure about location) > 2- check to make sure that the current version of jQuery is compatible with > the installed version or upgrade it accordingly > 3- Create a new theme based on one of the existing themes as suggested by > Julien and Gavin > 4- Test the theme by switching to it and handle major bugs / issues. > 5- Start to make a few test screens utilizing Bootstrap -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-5840) Create bootstrap theme
[ https://issues.apache.org/jira/browse/OFBIZ-5840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-5840: --- Attachment: styling_issue_4.png styling_issue_3.png styling_issue_3.png and styling_issue_4.png show styling flaws in list pagination. > Create bootstrap theme > -- > > Key: OFBIZ-5840 > URL: https://issues.apache.org/jira/browse/OFBIZ-5840 > Project: OFBiz > Issue Type: New Feature > Components: framework, themes >Affects Versions: Bootstrap theme >Reporter: Julien NICOLAS > Labels: bootstrap, theme > Attachments: Facility.PNG, FindAgreement..png, Footer.jpg, > GlobalDecorator.patch, ImprovedFooter.patch, MacroMenuRenderer.patch, > OFBIZ-5840-Menufactory.patch, OFBIZ-5840-Menufactory.patch, > appbar_menu_ftl.patch, bootified.js, bootified_js_screentrans.patch, > bootstrap-theme.zip, bootstrap.zip, calendar.PNG, catalog.png, > htmlMenuMacroLibrary.patch, pagination_htmlFormMacroLibrary.patch, > panelCollapse_htmlSreenMacroLibrary.patch, party menu tab bar.PNG, > preferences.png, styling_issue_1.png, styling_issue_2.png, > styling_issue_3.png, styling_issue_4.png, tab-bar.png, workeffort.PNG > > > 1- create a sub-directory called bootstrap under the image webapp to put > the resources over there (js, css and fonts) as indicated earlier by Gavin. > (Julien : not sure about location) > 2- check to make sure that the current version of jQuery is compatible with > the installed version or upgrade it accordingly > 3- Create a new theme based on one of the existing themes as suggested by > Julien and Gavin > 4- Test the theme by switching to it and handle major bugs / issues. > 5- Start to make a few test screens utilizing Bootstrap -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6390) Change btn-sm to btn-xs for buttons regarding calendar and field lookup in Bootstrap-Basic
[ https://issues.apache.org/jira/browse/OFBIZ-6390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-6390. -- Resolution: Fixed Fix Version/s: Bootstrap theme Fixed in rev 1680335. Thanks! > Change btn-sm to btn-xs for buttons regarding calendar and field lookup in > Bootstrap-Basic > -- > > Key: OFBIZ-6390 > URL: https://issues.apache.org/jira/browse/OFBIZ-6390 > Project: OFBiz > Issue Type: Sub-task > Components: themes >Affects Versions: Bootstrap theme >Reporter: Pierre Smits >Assignee: Pierre Smits > Fix For: Bootstrap theme > > Attachments: OFBIZ-6390-Bootstrap-templates.patch > > > Currently buttons associated with field lookup and from/through date exceed > the height of the associated fields. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-5840) Create bootstrap theme
[ https://issues.apache.org/jira/browse/OFBIZ-5840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-5840: --- Attachment: styling_issue_2.png styling_issue_1.png styling_issue_1.png shows a styling flaw when hovering over the Visual Themes button styling_issue_2.png shows a styling flaw in the New Fixed Asset button. The button disappears when hovering over it. > Create bootstrap theme > -- > > Key: OFBIZ-5840 > URL: https://issues.apache.org/jira/browse/OFBIZ-5840 > Project: OFBiz > Issue Type: New Feature > Components: framework, themes >Affects Versions: Bootstrap theme >Reporter: Julien NICOLAS > Labels: bootstrap, theme > Attachments: Facility.PNG, FindAgreement..png, Footer.jpg, > GlobalDecorator.patch, ImprovedFooter.patch, MacroMenuRenderer.patch, > OFBIZ-5840-Menufactory.patch, OFBIZ-5840-Menufactory.patch, > appbar_menu_ftl.patch, bootified.js, bootified_js_screentrans.patch, > bootstrap-theme.zip, bootstrap.zip, calendar.PNG, catalog.png, > htmlMenuMacroLibrary.patch, pagination_htmlFormMacroLibrary.patch, > panelCollapse_htmlSreenMacroLibrary.patch, party menu tab bar.PNG, > preferences.png, styling_issue_1.png, styling_issue_2.png, tab-bar.png, > workeffort.PNG > > > 1- create a sub-directory called bootstrap under the image webapp to put > the resources over there (js, css and fonts) as indicated earlier by Gavin. > (Julien : not sure about location) > 2- check to make sure that the current version of jQuery is compatible with > the installed version or upgrade it accordingly > 3- Create a new theme based on one of the existing themes as suggested by > Julien and Gavin > 4- Test the theme by switching to it and handle major bugs / issues. > 5- Start to make a few test screens utilizing Bootstrap -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6291) Update code to check for types rather than throw ClassCastException
[ https://issues.apache.org/jira/browse/OFBIZ-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-6291. -- Resolution: Fixed Fix Version/s: Upcoming Branch ClassCastException fixed in rev 1680058. Thanks! > Update code to check for types rather than throw ClassCastException > --- > > Key: OFBIZ-6291 > URL: https://issues.apache.org/jira/browse/OFBIZ-6291 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk, Upcoming Branch >Reporter: Gareth Carter >Assignee: Adrian Crum >Priority: Trivial > Fix For: Upcoming Branch > > Attachments: LocalizedConverters.patch, minilang_compare.patch, > minilang_compare_r1675655.patch > > > framework/minilang/src/org/ofbiz/minilang/method/conditional/Compare.java > framework/base/src/org/ofbiz/base/util/ObjectType.java > framework/minilang/src/org/ofbiz/minilang/MiniLangUtil.java > all throw ClassCastExceptions and are ignored instead of checking types > This caused issues in debugging when adding a ClassCastException breakpoint -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6386) compareBigDecimals in org.ofbiz.minilang.method.conditional.Compare does not compare certain values correctly
[ https://issues.apache.org/jira/browse/OFBIZ-6386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14548329#comment-14548329 ] Adrian Crum commented on OFBIZ-6386: Do you have a patch for this issue? > compareBigDecimals in org.ofbiz.minilang.method.conditional.Compare does not > compare certain values correctly > - > > Key: OFBIZ-6386 > URL: https://issues.apache.org/jira/browse/OFBIZ-6386 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Gareth Carter >Priority: Minor > Attachments: compareBigDecimals.png > > > Moving the conversation from https://issues.apache.org/jira/browse/OFBIZ-6291 > to this issue. > compareBigDecimals scales down and rounds up meaning you lose information and > the comparison result is not as expected -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6291) Update code to check for types rather than throw ClassCastException
[ https://issues.apache.org/jira/browse/OFBIZ-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-6291: --- Affects Version/s: Upcoming Branch > Update code to check for types rather than throw ClassCastException > --- > > Key: OFBIZ-6291 > URL: https://issues.apache.org/jira/browse/OFBIZ-6291 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk, Upcoming Branch >Reporter: Gareth Carter >Assignee: Adrian Crum >Priority: Trivial > Attachments: LocalizedConverters.patch, minilang_compare.patch, > minilang_compare_r1675655.patch > > > framework/minilang/src/org/ofbiz/minilang/method/conditional/Compare.java > framework/base/src/org/ofbiz/base/util/ObjectType.java > framework/minilang/src/org/ofbiz/minilang/MiniLangUtil.java > all throw ClassCastExceptions and are ignored instead of checking types > This caused issues in debugging when adding a ClassCastException breakpoint -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-6291) Update code to check for types rather than throw ClassCastException
[ https://issues.apache.org/jira/browse/OFBIZ-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-6291: -- Assignee: Adrian Crum > Update code to check for types rather than throw ClassCastException > --- > > Key: OFBIZ-6291 > URL: https://issues.apache.org/jira/browse/OFBIZ-6291 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Gareth Carter >Assignee: Adrian Crum >Priority: Trivial > Attachments: LocalizedConverters.patch, minilang_compare.patch, > minilang_compare_r1675655.patch > > > framework/minilang/src/org/ofbiz/minilang/method/conditional/Compare.java > framework/base/src/org/ofbiz/base/util/ObjectType.java > framework/minilang/src/org/ofbiz/minilang/MiniLangUtil.java > all throw ClassCastExceptions and are ignored instead of checking types > This caused issues in debugging when adding a ClassCastException breakpoint -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6386) compareBigDecimals in org.ofbiz.minilang.method.conditional.Compare does not compare certain values correctly
[ https://issues.apache.org/jira/browse/OFBIZ-6386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14548249#comment-14548249 ] Adrian Crum commented on OFBIZ-6386: It doesn't matter where you find the comparisons, they are still making a comparison and NOT performing a calculation. > compareBigDecimals in org.ofbiz.minilang.method.conditional.Compare does not > compare certain values correctly > - > > Key: OFBIZ-6386 > URL: https://issues.apache.org/jira/browse/OFBIZ-6386 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Gareth Carter >Priority: Minor > Attachments: compareBigDecimals.png > > > Moving the conversation from https://issues.apache.org/jira/browse/OFBIZ-6291 > to this issue. > compareBigDecimals scales down and rounds up meaning you lose information and > the comparison result is not as expected -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6378) assetmaint/control/calendar show events by WorkEffortFixedAssetAssign.fromDate and thruDate
[ https://issues.apache.org/jira/browse/OFBIZ-6378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14546475#comment-14546475 ] Adrian Crum commented on OFBIZ-6378: Okay, oops. I mis-read the description. I apologize for the confusion. > assetmaint/control/calendar show events by > WorkEffortFixedAssetAssign.fromDate and thruDate > --- > > Key: OFBIZ-6378 > URL: https://issues.apache.org/jira/browse/OFBIZ-6378 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk >Reporter: Christian Carlow > > Fixed Asset calendar should support displaying events by assignments date > range. Currently WorkEffort.estimatedStartDate and estimatedCompletionDate > are used but WorkEffortFixedAssetAssign.fromDate and thruDate are the fields > that control the visibility of the event based on its date range being > active. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6378) assetmaint/control/calendar show events by WorkEffortFixedAssetAssign.fromDate and thruDate
[ https://issues.apache.org/jira/browse/OFBIZ-6378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14546139#comment-14546139 ] Adrian Crum commented on OFBIZ-6378: Could you clarify the description please? The calendar shows when events are due to occur, not when a party was assigned to an event. If a maintenance person is viewing the calendar, they need to know when a maintenance task occurs, not when they were assigned to the task. > assetmaint/control/calendar show events by > WorkEffortFixedAssetAssign.fromDate and thruDate > --- > > Key: OFBIZ-6378 > URL: https://issues.apache.org/jira/browse/OFBIZ-6378 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk >Reporter: Christian Carlow > > Fixed Asset calendar should support displaying events by assignments date > range. Currently WorkEffort.estimatedStartDate and estimatedCompletionDate > are used but WorkEffortFixedAssetAssign.fromDate and thruDate are the fields > that control the visibility of the event based on its date range being > active. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6362) Move js & css references from CommonDecorator(s) to themes
[ https://issues.apache.org/jira/browse/OFBIZ-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14544199#comment-14544199 ] Adrian Crum commented on OFBIZ-6362: JQuery is still referenced in the Global Decorator - lines 147-151. Those lines will need to be moved to the theme's header.ftl file. > Move js & css references from CommonDecorator(s) to themes > -- > > Key: OFBIZ-6362 > URL: https://issues.apache.org/jira/browse/OFBIZ-6362 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk, Upcoming Branch >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Minor > Attachments: OFBIZ-6263-BlueLight-header.ftl.patch, > OFBIZ-6362-BizznessTime-header.ftl.patch, > OFBIZ-6362-BizznessTimeThemeData.xml.patch, > OFBIZ-6362-BlueLightThemeData.xml.patch, OFBIZ-6362-CommonScreens.xml.patch, > OFBIZ-6362-DroppingCrumbs-header.ftl.patch, > OFBIZ-6362-DroppingCrumbsThemeData.xml.patch, > OFBIZ-6362-FlatGrey-header.ftl.patch, OFBIZ-6362-FlatGreyThemeData.xml.patch, > OFBIZ-6362-Tomahawk-header.ftl.patch, OFBIZ-6362-TomahawkThemeData.xml.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6362) Move js & css references from CommonDecorator(s) to themes
[ https://issues.apache.org/jira/browse/OFBIZ-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14543947#comment-14543947 ] Adrian Crum commented on OFBIZ-6362: The SimpleDecorator can be treated the same as GlobalDecorator. > Move js & css references from CommonDecorator(s) to themes > -- > > Key: OFBIZ-6362 > URL: https://issues.apache.org/jira/browse/OFBIZ-6362 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk, Upcoming Branch >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Minor > Attachments: OFBIZ-6263-BlueLight-header.ftl.patch, > OFBIZ-6362-BizznessTime-header.ftl.patch, > OFBIZ-6362-BizznessTimeThemeData.xml.patch, > OFBIZ-6362-BlueLightThemeData.xml.patch, OFBIZ-6362-CommonScreens.xml.patch, > OFBIZ-6362-DroppingCrumbs-header.ftl.patch, > OFBIZ-6362-DroppingCrumbsThemeData.xml.patch, > OFBIZ-6362-FlatGrey-header.ftl.patch, OFBIZ-6362-FlatGreyThemeData.xml.patch, > OFBIZ-6362-Tomahawk-header.ftl.patch, OFBIZ-6362-TomahawkThemeData.xml.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6362) Move js & css references from CommonDecorator(s) to themes
[ https://issues.apache.org/jira/browse/OFBIZ-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14543706#comment-14543706 ] Adrian Crum commented on OFBIZ-6362: Pierre, Thank you for working on this. When you are finished, please assign it to me. > Move js & css references from CommonDecorator(s) to themes > -- > > Key: OFBIZ-6362 > URL: https://issues.apache.org/jira/browse/OFBIZ-6362 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk, Upcoming Branch >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Minor > Attachments: OFBIZ-6263-BlueLight-header.ftl.patch, > OFBIZ-6362-BizznessTime-header.ftl.patch, > OFBIZ-6362-BizznessTimeThemeData.xml.patch, > OFBIZ-6362-BlueLightThemeData.xml.patch, > OFBIZ-6362-DroppingCrumbs-header.ftl.patch, > OFBIZ-6362-DroppingCrumbsThemeData.xml.patch, > OFBIZ-6362-FlatGrey-header.ftl.patch, OFBIZ-6362-FlatGreyThemeData.xml.patch, > OFBIZ-6362-Tomahawk-header.ftl.patch, OFBIZ-6362-TomahawkThemeData.xml.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6362) Move js & css references from CommonDecorator(s) to themes
[ https://issues.apache.org/jira/browse/OFBIZ-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-6362: --- Priority: Minor (was: Major) Affects Version/s: Upcoming Branch > Move js & css references from CommonDecorator(s) to themes > -- > > Key: OFBIZ-6362 > URL: https://issues.apache.org/jira/browse/OFBIZ-6362 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk, Upcoming Branch >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Minor > Attachments: OFBIZ-6263-BlueLight-header.ftl.patch, > OFBIZ-6362-BizznessTime-header.ftl.patch, > OFBIZ-6362-BizznessTimeThemeData.xml.patch, > OFBIZ-6362-BlueLightThemeData.xml.patch, > OFBIZ-6362-DroppingCrumbs-header.ftl.patch, > OFBIZ-6362-DroppingCrumbsThemeData.xml.patch, > OFBIZ-6362-FlatGrey-header.ftl.patch, OFBIZ-6362-FlatGreyThemeData.xml.patch, > OFBIZ-6362-Tomahawk-header.ftl.patch, OFBIZ-6362-TomahawkThemeData.xml.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6329) Malfunction of configurable FTL-Template caching in DataResourceWorker.renderDataResourceAsText
[ https://issues.apache.org/jira/browse/OFBIZ-6329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14527172#comment-14527172 ] Adrian Crum commented on OFBIZ-6329: OFBiz uses Subversion, not Git. > Malfunction of configurable FTL-Template caching in > DataResourceWorker.renderDataResourceAsText > --- > > Key: OFBIZ-6329 > URL: https://issues.apache.org/jira/browse/OFBIZ-6329 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Trunk >Reporter: Martin Becker > Attachments: OFBIZ-6329_FTL-Caching.patch, > OFBIZ-6329_Non-Template-Caching.patch > > > There are several problems with the current caching logic in > DataResourceWorker.renderDataResourceAsText(...). > Enabling the caching of rendered FTL-Templates from DataResources with the > property disable.ftl.template.cache in content.properties enables a > non-functioning block of code that handles the rendering of the cached > template. And if it is deactivated (default), the FTL-Templates are still > cached by the FreeMarkerWorker. > However the correct logic for caching and using the rendered FTL-Template is > already implemented in the FreeMarkerWorker and controlled by an optional > useCache parameter. > In addition there is an API call to DataResourceWorker.writeDataResourceText > for non template content with a static "true" for useCache instead of using > the given cache parameter value of the renderDataResourceAsText method > itself, so even if the caller do not want to use caching at all, the non > template text data is cached an FTL-Templates are cached also. > I will provide a patch for those two issues in the mentioned method. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6329) Malfunction of configurable FTL-Template caching in DataResourceWorker.renderDataResourceAsText
[ https://issues.apache.org/jira/browse/OFBIZ-6329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14526847#comment-14526847 ] Adrian Crum commented on OFBIZ-6329: Thank you for working on this, but the patch file format is wrong. Please use a unified diff format. > Malfunction of configurable FTL-Template caching in > DataResourceWorker.renderDataResourceAsText > --- > > Key: OFBIZ-6329 > URL: https://issues.apache.org/jira/browse/OFBIZ-6329 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Trunk >Reporter: Martin Becker > Attachments: OFBIZ-6329_FTL-Caching.patch, > OFBIZ-6329_Non-Template-Caching.patch > > > There are several problems with the current caching logic in > DataResourceWorker.renderDataResourceAsText(...). > Enabling the caching of rendered FTL-Templates from DataResources with the > property disable.ftl.template.cache in content.properties enables a > non-functioning block of code that handles the rendering of the cached > template. And if it is deactivated (default), the FTL-Templates are still > cached by the FreeMarkerWorker. > However the correct logic for caching and using the rendered FTL-Template is > already implemented in the FreeMarkerWorker and controlled by an optional > useCache parameter. > In addition there is an API call to DataResourceWorker.writeDataResourceText > for non template content with a static "true" for useCache instead of using > the given cache parameter value of the renderDataResourceAsText method > itself, so even if the caller do not want to use caching at all, the non > template text data is cached an FTL-Templates are cached also. > I will provide a patch for those two issues in the mentioned method. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6325) Locale selection presents errors
[ https://issues.apache.org/jira/browse/OFBIZ-6325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525309#comment-14525309 ] Adrian Crum commented on OFBIZ-6325: This may be a duplicate of OFBIZ-6309. > Locale selection presents errors > > > Key: OFBIZ-6325 > URL: https://issues.apache.org/jira/browse/OFBIZ-6325 > Project: OFBiz > Issue Type: Bug >Affects Versions: Bootstrap theme >Reporter: Pierre Smits > Labels: locale, theme > Attachments: OFBIZ-6325-error.rtf > > > When opening the locale selector a set of errors are shown. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6316) Have the WorkEffort entity retain revisions
[ https://issues.apache.org/jira/browse/OFBIZ-6316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14521379#comment-14521379 ] Adrian Crum commented on OFBIZ-6316: The entity audit feature might work for this. > Have the WorkEffort entity retain revisions > --- > > Key: OFBIZ-6316 > URL: https://issues.apache.org/jira/browse/OFBIZ-6316 > Project: OFBiz > Issue Type: Improvement > Components: workeffort >Affects Versions: Trunk >Reporter: Pierre Smits > > Currently the WorkEffort entity has a field called revisionNumber. This field > is updated through the simple method 'updateWorkEffort' in > WorkEffortSimpleServices.xml. However, this method overwrites the existing > record, in stead of creating a new record. > In order to retain the changes on a workeffort the method should create a new > record for each revision. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6217) fix warnings in trunk on java source code
[ https://issues.apache.org/jira/browse/OFBIZ-6217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14521250#comment-14521250 ] Adrian Crum commented on OFBIZ-6217: I see a number of problems with the latest patch and I don't feel confident applying it. I prefer to wait for Adam to merge his fixes to the trunk, then we can resume from there. > fix warnings in trunk on java source code > - > > Key: OFBIZ-6217 > URL: https://issues.apache.org/jira/browse/OFBIZ-6217 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Taher Alkhateeb >Assignee: Adrian Crum >Priority: Minor > Labels: java, warning > Fix For: Upcoming Branch > > Attachments: OFBIZ-6217-patch-4.patch, remove_unused_imports.patch, > warnings_patch_2.patch, warnings_patch_2.patch > > > Right now, we have 528 warnings on trunk out of which 238 are about raw types > and 118 never used imports. So we can already eliminate most of the warning > quite quickly. > I will issue multiple patches to resolve most of these warnings. It might be > a bit of a challenge to eliminate the raw types because the generics are not > always deducable from the code especially when relying on external APIs -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6268) Improve Start.java Component Loading
[ https://issues.apache.org/jira/browse/OFBIZ-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-6268. -- Resolution: Fixed Fix Version/s: Upcoming Branch Fixed in rev 1676746. Thank you Jacopo for the review and feedback. > Improve Start.java Component Loading > > > Key: OFBIZ-6268 > URL: https://issues.apache.org/jira/browse/OFBIZ-6268 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Upcoming Branch >Reporter: Adrian Crum >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-6268.patch, OFBIZ-6268.patch > > > The current code for loading components parses configuration files twice. > This issue is intended for review of code improvements. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6271) build management with maven
[ https://issues.apache.org/jira/browse/OFBIZ-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-6271: --- Attachment: console.log Windows 8.1 console log attached. (Sorry for the oversized comment folks.) > build management with maven > --- > > Key: OFBIZ-6271 > URL: https://issues.apache.org/jira/browse/OFBIZ-6271 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Reporter: Adam Heath >Priority: Minor > Attachments: console.log > > > This is a new build system; the primary goal will be to not require any > changes to existing ofbiz layouts(for backwards compatibility, at least > initially). > These pom.xml files are completely new; the existing build.xml infrastructure > will continue to exist. The existing build.xml will never call into > maven(which is what processes the pom.xml), and maven will never call into > build.xml either. > I have already committed a working pom.xml for the top level, and > framework/start. Shortly, I will be adding framework/base and > framework/entity, but into this branch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Issue Comment Deleted] (OFBIZ-6271) build management with maven
[
https://issues.apache.org/jira/browse/OFBIZ-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrian Crum updated OFBIZ-6271:
---
Comment: was deleted
(was: Windows 8.1:
[INFO] Scanning for projects...
[WARNING]
[WARNING] Some problems were encountered while building the effective model for
org.apache.ofbiz:ofbiz-start:jar:TRUNK
[WARNING] 'build.plugins.plugin.version' for
org.apache.maven.plugins:maven-compiler-plugin is missing. @
org.apache.ofbiz:ofbiz-parent:TRUNK, C:\Develop\ofbiz\pom.xml, line 58, column
15
[WARNING] 'build.plugins.plugin.version' for
org.apache.maven.plugins:maven-jar-plugin is missing. @
org.apache.ofbiz:ofbiz-start:[unknown-version],
C:\Develop\ofbiz\framework\start\pom.xml, line 34, column 15
[WARNING]
[WARNING] Some problems were encountered while building the effective model for
org.apache.ofbiz:ofbiz-parent:pom:TRUNK
[WARNING] 'build.plugins.plugin.version' for
org.apache.maven.plugins:maven-compiler-plugin is missing. @ line 58, column 15
[WARNING] The expression ${artifactId} is deprecated. Please use
${project.artifactId} instead.
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten
the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support
building such malformed projects.
[WARNING]
[INFO]
[INFO] Reactor Build Order:
[INFO]
[INFO] ofbiz-parent
[INFO] ofbiz-start
[INFO]
[INFO]
[INFO] Building ofbiz-parent TRUNK
[INFO]
[INFO]
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ ofbiz-parent ---
[INFO]
[INFO]
[INFO] Building ofbiz-start TRUNK
[INFO]
[INFO]
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ ofbiz-start ---
[INFO] Deleting C:\Develop\ofbiz\framework\start\build\lib
[INFO] Deleting C:\Develop\ofbiz\framework\start\build\classes
[INFO]
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @
ofbiz-start ---
[WARNING] Using platform encoding (Cp1252 actually) to copy filtered resources,
i.e. build is platform dependent!
[INFO] Copying 7 resources
[INFO] Copying 2 resources
[INFO]
[INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ ofbiz-start ---
[INFO] Changes detected - recompiling the module!
[WARNING] File encoding has not been set, using platform encoding Cp1252, i.e.
build is platform dependent!
[INFO] Compiling 10 source files to
C:\Develop\ofbiz\framework\start\build\classes
[INFO]
[INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @
ofbiz-start ---
[WARNING] Using platform encoding (Cp1252 actually) to copy filtered resources,
i.e. build is platform dependent!
[INFO] skip non existing resourceDirectory
C:\Develop\ofbiz\framework\start\src\test\resources
[INFO]
[INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @
ofbiz-start ---
[INFO] No sources to compile
[INFO]
[INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @ ofbiz-start ---
[INFO] Tests are skipped.
[INFO]
[INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ ofbiz-start ---
[INFO] Building jar: C:\Develop\ofbiz\framework\start\build\lib\ofbiz.jar
[INFO]
[INFO] --- maven-antrun-plugin:1.3:run (default) @ ofbiz-start ---
[INFO] Executing tasks
[copy] Copying 1 file to C:\Develop\ofbiz
[INFO] Executed tasks
[INFO]
[INFO] Reactor Summary:
[INFO]
[INFO] ofbiz-parent ... SUCCESS [ 0.203 s]
[INFO] ofbiz-start SUCCESS [ 2.855 s]
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 3.214 s
[INFO] Finished at: 2015-04-29T18:49:01+01:00
[INFO] Final Memory: 15M/219M
[INFO]
)
> build management with maven
> ---
>
> Key: OFBIZ-6271
> URL: https://issues.apache.org/jira/browse/OFBIZ-6271
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Reporter: Adam Heath
>Priority: Minor
>
> This is a new build system; the primary goal will be to not require any
> changes to existing ofbiz layouts(for backwards compatibility, at least
> initia
[jira] [Commented] (OFBIZ-6271) build management with maven
[
https://issues.apache.org/jira/browse/OFBIZ-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14519821#comment-14519821
]
Adrian Crum commented on OFBIZ-6271:
Windows 8.1:
[INFO] Scanning for projects...
[WARNING]
[WARNING] Some problems were encountered while building the effective model for
org.apache.ofbiz:ofbiz-start:jar:TRUNK
[WARNING] 'build.plugins.plugin.version' for
org.apache.maven.plugins:maven-compiler-plugin is missing. @
org.apache.ofbiz:ofbiz-parent:TRUNK, C:\Develop\ofbiz\pom.xml, line 58, column
15
[WARNING] 'build.plugins.plugin.version' for
org.apache.maven.plugins:maven-jar-plugin is missing. @
org.apache.ofbiz:ofbiz-start:[unknown-version],
C:\Develop\ofbiz\framework\start\pom.xml, line 34, column 15
[WARNING]
[WARNING] Some problems were encountered while building the effective model for
org.apache.ofbiz:ofbiz-parent:pom:TRUNK
[WARNING] 'build.plugins.plugin.version' for
org.apache.maven.plugins:maven-compiler-plugin is missing. @ line 58, column 15
[WARNING] The expression ${artifactId} is deprecated. Please use
${project.artifactId} instead.
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten
the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support
building such malformed projects.
[WARNING]
[INFO]
[INFO] Reactor Build Order:
[INFO]
[INFO] ofbiz-parent
[INFO] ofbiz-start
[INFO]
[INFO]
[INFO] Building ofbiz-parent TRUNK
[INFO]
[INFO]
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ ofbiz-parent ---
[INFO]
[INFO]
[INFO] Building ofbiz-start TRUNK
[INFO]
[INFO]
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ ofbiz-start ---
[INFO] Deleting C:\Develop\ofbiz\framework\start\build\lib
[INFO] Deleting C:\Develop\ofbiz\framework\start\build\classes
[INFO]
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @
ofbiz-start ---
[WARNING] Using platform encoding (Cp1252 actually) to copy filtered resources,
i.e. build is platform dependent!
[INFO] Copying 7 resources
[INFO] Copying 2 resources
[INFO]
[INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ ofbiz-start ---
[INFO] Changes detected - recompiling the module!
[WARNING] File encoding has not been set, using platform encoding Cp1252, i.e.
build is platform dependent!
[INFO] Compiling 10 source files to
C:\Develop\ofbiz\framework\start\build\classes
[INFO]
[INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @
ofbiz-start ---
[WARNING] Using platform encoding (Cp1252 actually) to copy filtered resources,
i.e. build is platform dependent!
[INFO] skip non existing resourceDirectory
C:\Develop\ofbiz\framework\start\src\test\resources
[INFO]
[INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @
ofbiz-start ---
[INFO] No sources to compile
[INFO]
[INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @ ofbiz-start ---
[INFO] Tests are skipped.
[INFO]
[INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ ofbiz-start ---
[INFO] Building jar: C:\Develop\ofbiz\framework\start\build\lib\ofbiz.jar
[INFO]
[INFO] --- maven-antrun-plugin:1.3:run (default) @ ofbiz-start ---
[INFO] Executing tasks
[copy] Copying 1 file to C:\Develop\ofbiz
[INFO] Executed tasks
[INFO]
[INFO] Reactor Summary:
[INFO]
[INFO] ofbiz-parent ... SUCCESS [ 0.203 s]
[INFO] ofbiz-start SUCCESS [ 2.855 s]
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 3.214 s
[INFO] Finished at: 2015-04-29T18:49:01+01:00
[INFO] Final Memory: 15M/219M
[INFO]
> build management with maven
> ---
>
> Key: OFBIZ-6271
> URL: https://issues.apache.org/jira/browse/OFBIZ-6271
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Reporter: Adam Heath
>Priority: Minor
>
> This is a new build system; the primary goal will be to not require any
> changes to existing ofbiz layouts(for backwards compatib
[jira] [Commented] (OFBIZ-6313) change language cause exception
[
https://issues.apache.org/jira/browse/OFBIZ-6313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518755#comment-14518755
]
Adrian Crum commented on OFBIZ-6313:
What JRE version are you using?
> change language cause exception
> ---
>
> Key: OFBIZ-6313
> URL: https://issues.apache.org/jira/browse/OFBIZ-6313
> Project: OFBiz
> Issue Type: Bug
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Wai
>
> select the link to change language.
> ...console output...
> 2015-04-28 23:31:34,542 |http-bio-8443-exec-3 |ServiceDispatcher
> |T| Sync service [catalog/getUserPreferenceGroup] finished in [5] milliseconds
> 2015-04-28 23:31:34,567 |http-bio-8443-exec-3 |ServiceDispatcher
> |T| Sync service [catalog/getVisualThemeResources] finished in [24]
> milliseconds
> 2015-04-28 23:31:34,724 |http-bio-8443-exec-3 |ScreenFactory
> |I| Got 9 screens in 0.064s from:
> file:/home/wt/wt-mystuff/eclipse/workspace/ofbiz-trunk-wrk-restapi/framework/common/widget/LookupScreens.xml
> 2015-04-28 23:31:34,741 |http-bio-8443-exec-3 |ScreenFactory
> |I| Got 24 screens in 0.015s from:
> file:/home/wt/wt-mystuff/eclipse/workspace/ofbiz-trunk-wrk-restapi/framework/common/widget/CommonScreens.xml
> 2015-04-28 23:31:34,746 |http-bio-8443-exec-3 |ServiceDispatcher
> |T| Sync service [catalog/getUserPreferenceGroup] finished in [1] milliseconds
> 2015-04-28 23:31:34,749 |http-bio-8443-exec-3 |ServiceDispatcher
> |T| Sync service [catalog/getVisualThemeResources] finished in [2]
> milliseconds
> 2015-04-28 23:31:35,146 |http-bio-8443-exec-3 |runtime
> |E| Error executing FreeMarker template
> freemarker.core._TemplateModelException: ?substring(...) argument #2 had
> invalid value: The index mustn't be greater than the length of the string, 0,
> but it was 2.
>
> FTL stack trace ("~" means nesting-related):
> - Failed at: #if "ar.iw"?contains(langAttr?substri... [in template
> "component://common/webcommon/includes/listLocales.ftl" at line 34, column 9]
>
> at
> freemarker.core.MessageUtil.newMethodArgInvalidValueException(MessageUtil.java:262)
> ~[freemarker-2.3.22.jar:2.3.22]
> at
> freemarker.core.BuiltInsForStringsBasic$substringBI$1.newIndexGreaterThanLengthException(BuiltInsForStringsBasic.java:598)
> ~[freemarker-2.3.22.jar:2.3.22]
> at
> freemarker.core.BuiltInsForStringsBasic$substringBI$1.exec(BuiltInsForStringsBasic.java:581)
> ~[freemarker-2.3.22.jar:2.3.22]
> at freemarker.core.MethodCall._eval(MethodCall.java:62)
> ~[freemarker-2.3.22.jar:2.3.22]
> at freemarker.core.Expression.eval(Expression.java:78)
> ~[freemarker-2.3.22.jar:2.3.22]
> at freemarker.core.ListLiteral.getModelList(ListLiteral.java:89)
> ~[freemarker-2.3.22.jar:2.3.22]
> at freemarker.core.MethodCall._eval(MethodCall.java:60)
> ~[freemarker-2.3.22.jar:2.3.22]
> at freemarker.core.Expression.eval(Expression.java:78)
> ~[freemarker-2.3.22.jar:2.3.22]
> at freemarker.core.Expression.evalToBoolean(Expression.java:118)
> ~[freemarker-2.3.22.jar:2.3.22]
> at freemarker.core.Expression.evalToBoolean(Expression.java:110)
> ~[freemarker-2.3.22.jar:2.3.22]
> at freemarker.core.ConditionalBlock.accept(ConditionalBlock.java:46)
> ~[freemarker-2.3.22.jar:2.3.22]
> at freemarker.core.Environment.visit(Environment.java:312)
> [freemarker-2.3.22.jar:2.3.22]
> at freemarker.core.MixedContent.accept(MixedContent.java:62)
> [freemarker-2.3.22.jar:2.3.22]
> at
> freemarker.core.Environment.visitByHiddingParent(Environment.java:333)
> [freemarker-2.3.22.jar:2.3.22]
> at
> freemarker.core.IteratorBlock$Context.runLoop(IteratorBlock.java:148)
> [freemarker-2.3.22.jar:2.3.22]
> at freemarker.core.Environment.visitIteratorBlock(Environment.java:559)
> [freemarker-2.3.22.jar:2.3.22]
> at freemarker.core.IteratorBlock.accept(IteratorBlock.java:67)
> [freemarker-2.3.22.jar:2.3.22]
> at freemarker.core.Environment.visit(Environment.java:312)
> [freemarker-2.3.22.jar:2.3.22]
> at freemarker.core.MixedContent.accept(MixedContent.java:62)
> [freemarker-2.3.22.jar:2.3.22]
> at freemarker.core.Environment.visit(Environment.java:312)
> [freemarker-2.3.22.jar:2.3.22]
> at freemarker.core.Environment.process(Environment.java:290)
> [freemarker-2.3.22.jar:2.3.22]
> at
> org.ofbiz.base.util.template.FreeMarkerWorker.renderTemplate(FreeMarkerWorker.java:257)
> [ofbiz-base.jar:?]
> at
> org.ofbiz.widget.model.HtmlWidget.renderHtmlTemplate(HtmlWidget.java:167)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.HtmlWidget$HtmlTemplate.renderWidgetString(HtmlWidget.java:216)
> [ofbiz-widget.jar
[jira] [Commented] (OFBIZ-6309) Freemarker errors at lanaguge change page due to locale with no display name returned by Locale.getAvailableLocales() in UtilMisc.java#getAvailableLocaleList
[ https://issues.apache.org/jira/browse/OFBIZ-6309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518898#comment-14518898 ] Adrian Crum commented on OFBIZ-6309: FYI: The JavaDoc says the getDisplayName() method can return an empty String, so the bug was in our code, not in the JRE. > Freemarker errors at lanaguge change page due to locale with no display name > returned by Locale.getAvailableLocales() in > UtilMisc.java#getAvailableLocaleList > - > > Key: OFBIZ-6309 > URL: https://issues.apache.org/jira/browse/OFBIZ-6309 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Adrian Crum > Fix For: 14.12.01, 13.07.02, Upcoming Branch > > Attachments: OFBIZ-6309.patch > > > For some reason Locale.getAvailableLocales() returns an array list whose > first member is a locale without a display name which causes an FTL error at > ListLocales page. The error is not occurring for the demo trunk. The > attached patch adds a line to UtilMisc to check that a displayName exists > before adding the locale to the list in case the same happens for other users. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-6309) Freemarker errors at lanaguge change page due to locale with no display name returned by Locale.getAvailableLocales() in UtilMisc.java#getAvailableLocaleList
[ https://issues.apache.org/jira/browse/OFBIZ-6309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-6309: -- Assignee: Adrian Crum > Freemarker errors at lanaguge change page due to locale with no display name > returned by Locale.getAvailableLocales() in > UtilMisc.java#getAvailableLocaleList > - > > Key: OFBIZ-6309 > URL: https://issues.apache.org/jira/browse/OFBIZ-6309 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Adrian Crum > Attachments: OFBIZ-6309.patch > > > For some reason Locale.getAvailableLocales() returns an array list whose > first member is a locale without a display name which causes an FTL error at > ListLocales page. The error is not occurring for the demo trunk. The > attached patch adds a line to UtilMisc to check that a displayName exists > before adding the locale to the list in case the same happens for other users. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6309) Freemarker errors at lanaguge change page due to locale with no display name returned by Locale.getAvailableLocales() in UtilMisc.java#getAvailableLocaleList
[ https://issues.apache.org/jira/browse/OFBIZ-6309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-6309. -- Resolution: Fixed Fix Version/s: Upcoming Branch 13.07.02 14.12.01 Fixed in rev 167674. Thanks! > Freemarker errors at lanaguge change page due to locale with no display name > returned by Locale.getAvailableLocales() in > UtilMisc.java#getAvailableLocaleList > - > > Key: OFBIZ-6309 > URL: https://issues.apache.org/jira/browse/OFBIZ-6309 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Adrian Crum > Fix For: 14.12.01, 13.07.02, Upcoming Branch > > Attachments: OFBIZ-6309.patch > > > For some reason Locale.getAvailableLocales() returns an array list whose > first member is a locale without a display name which causes an FTL error at > ListLocales page. The error is not occurring for the demo trunk. The > attached patch adds a line to UtilMisc to check that a displayName exists > before adding the locale to the list in case the same happens for other users. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6309) Freemarker errors at lanaguge change page due to locale with no display name returned by Locale.getAvailableLocales() in UtilMisc.java#getAvailableLocaleList
[ https://issues.apache.org/jira/browse/OFBIZ-6309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14517956#comment-14517956 ] Adrian Crum commented on OFBIZ-6309: What JRE version are you using? There is no error on my local copy, so I suspect this is a bug in the JRE. > Freemarker errors at lanaguge change page due to locale with no display name > returned by Locale.getAvailableLocales() in > UtilMisc.java#getAvailableLocaleList > - > > Key: OFBIZ-6309 > URL: https://issues.apache.org/jira/browse/OFBIZ-6309 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow > Attachments: OFBIZ-6309.patch > > > For some reason Locale.getAvailableLocales() returns an array list whose > first member is a locale without a display name which causes an FTL error at > ListLocales page. The error is not occurring for the demo trunk. The > attached patch adds a line to UtilMisc to check that a displayName exists > before adding the locale to the list in case the same happens for other users. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6268) Improve Start.java Component Loading
[ https://issues.apache.org/jira/browse/OFBIZ-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-6268: --- Attachment: OFBIZ-6268.patch Improved patch. Hard-coded class paths have been replaced with properties. The instrumentation still doesn't work (enabled in this patch). I'm still struggling to figure out why. > Improve Start.java Component Loading > > > Key: OFBIZ-6268 > URL: https://issues.apache.org/jira/browse/OFBIZ-6268 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Upcoming Branch >Reporter: Adrian Crum >Priority: Minor > Attachments: OFBIZ-6268.patch, OFBIZ-6268.patch > > > The current code for loading components parses configuration files twice. > This issue is intended for review of code improvements. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-6304) Add Unit Tests For Startup Code
Adrian Crum created OFBIZ-6304: -- Summary: Add Unit Tests For Startup Code Key: OFBIZ-6304 URL: https://issues.apache.org/jira/browse/OFBIZ-6304 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Upcoming Branch Reporter: Adrian Crum Priority: Minor The current unit test implementation requires OFBiz itself to start before the tests are run - preventing the OFBiz startup code from being tested. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6299) Field order is not correct in the auto-complete for look-ups.
[ https://issues.apache.org/jira/browse/OFBIZ-6299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510749#comment-14510749 ] Adrian Crum commented on OFBIZ-6299: Please do not use Javolution classes in new contributions. > Field order is not correct in the auto-complete for look-ups. > - > > Key: OFBIZ-6299 > URL: https://issues.apache.org/jira/browse/OFBIZ-6299 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Francis Douet >Priority: Minor > Labels: lookup > Attachments: OFBIZ-6299.patch > > > Field order is not correct in the auto-complete all look-ups, for example if > I set the searchFields as such: > > The look-up auto-complete and tooltip will display the last name first. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
