Re: Adding fromDate and thruDate in GoodIdentification Entity
Thanks so much, everyone for the valuable feedback. This indeed increases my understanding. Based on inputs I will have more look into this. For now, I have discarded the ticket OFBIZ-10963 [1], we can reopen it in the future if required. [1] https://issues.apache.org/jira/browse/OFBIZ-10963 Kind Regards, *Aishwary Shrivastava* | Senior Enterprise Software Engineer HotWax Systems <http://www.hotwaxsystems.com/> Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore, M.P 452010 Cell phone: +91-8962244998 Linkedin: *Aishwary Shrivastava* <https://www.linkedin.com/in/aishwaryshrivastava/> On Sat, Apr 27, 2019 at 8:08 PM Devanshu Vyas wrote: > Agree with Rishi here, and a -1 for the proposal. > > The GoodIdentification or the PartyIdentification entity should only > contain the information to uniquely identify a product(which said by > everyone, is rarely), so adding fromDate/thruDate will not be much > beneficial. > On the other hand, the GoodIdentificationHistory could be a good > alternative approach to what you are suggesting here. > > Thanks & Regards, > Devanshu Vyas. > > > On Sat, Apr 27, 2019 at 7:22 PM Rishi Solanki > wrote: > > > -1 for the proposal. > > For a product identification code will be one of one type. The universal > > data model book by Len Silverston suggested the same. > > > > Best Regards, > > -- > > *Rishi Solanki* | Sr Manager, Enterprise Software Development > > HotWax Systems <http://www.hotwaxsystems.com/> > > Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, > > Indore, > > M.P 452010 > > Linkedin: *Rishi Solanki* > > <https://www.linkedin.com/in/rishi-solanki-62271b7/> > > Direct: +91-9893287847 > > > > > > On Sat, Apr 27, 2019 at 4:03 PM Michael Brohl > > wrote: > > > > > Hi Aishwary, > > > > > > can you elaborate a bit more why a history of GoodIdentification is > > needed? > > > > > > It is used for identification numbers as ISBN, EAN etc.. Those numbers > > > are rarely subject to change for the same product. > > > > > > I don't see any use case for history tracking so I would appreciate > some > > > examples. > > > > > > Thanks, > > > > > > Michael Brohl > > > > > > ecomify GmbH - www.ecomify.de > > > > > > > > > Am 27.04.19 um 09:11 schrieb Aishwary Shrivastava: > > > > Hello, Devs > > > > > > > > We should add support of fromDate and thruDate in the > > GoodIdentification > > > > entity for tracking and history purpose. > > > > > > > > As of now, if we need to update any Good Identification record for a > > > > product, then we have to replace its value and this history isn't > > > > maintained. > > > > It will also enable the user to maintain multiple goodIdentifications > > of > > > a > > > > product. > > > > > > > > Best, > > > > *Aishwary Shrivastava* | HotWax Systems < > http://www.hotwaxsystems.com/ > > > > > > > > > > > > > > > >
Re: Adding fromDate and thruDate in GoodIdentification Entity
Thanks so much, everyone for the valuable feedback. This indeed increases my understanding. Based on inputs I will have more look into this. For now, I have discarded the ticket OFBIZ-10963 [1], we can reopen it in the future if required. [1] https://issues.apache.org/jira/browse/OFBIZ-10963 Kind Regards, *Aishwary Shrivastava* | Senior Enterprise Software Engineer HotWax Systems <http://www.hotwaxsystems.com/> Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore, M.P 452010 Cell phone: +91-8962244998 Linkedin: *Aishwary Shrivastava* <https://www.linkedin.com/in/aishwaryshrivastava/> On Sat, Apr 27, 2019 at 7:22 PM Rishi Solanki wrote: > -1 for the proposal. > For a product identification code will be one of one type. The universal > data model book by Len Silverston suggested the same. > > Best Regards, > -- > *Rishi Solanki* | Sr Manager, Enterprise Software Development > HotWax Systems <http://www.hotwaxsystems.com/> > Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, > Indore, > M.P 452010 > Linkedin: *Rishi Solanki* > <https://www.linkedin.com/in/rishi-solanki-62271b7/> > Direct: +91-9893287847 > > > On Sat, Apr 27, 2019 at 4:03 PM Michael Brohl > wrote: > > > Hi Aishwary, > > > > can you elaborate a bit more why a history of GoodIdentification is > needed? > > > > It is used for identification numbers as ISBN, EAN etc.. Those numbers > > are rarely subject to change for the same product. > > > > I don't see any use case for history tracking so I would appreciate some > > examples. > > > > Thanks, > > > > Michael Brohl > > > > ecomify GmbH - www.ecomify.de > > > > > > Am 27.04.19 um 09:11 schrieb Aishwary Shrivastava: > > > Hello, Devs > > > > > > We should add support of fromDate and thruDate in the > GoodIdentification > > > entity for tracking and history purpose. > > > > > > As of now, if we need to update any Good Identification record for a > > > product, then we have to replace its value and this history isn't > > > maintained. > > > It will also enable the user to maintain multiple goodIdentifications > of > > a > > > product. > > > > > > Best, > > > *Aishwary Shrivastava* | HotWax Systems <http://www.hotwaxsystems.com/ > > > > > > > > > >
Re: Adding fromDate and thruDate in GoodIdentification Entity
Thanks so much, everyone for the valuable feedback. This indeed increases my understanding. Based on inputs I will have more look into this. For now, I have discarded the ticket OFBIZ-10963 [1], we can reopen it in the future if required. [1] https://issues.apache.org/jira/browse/OFBIZ-10963 Best, *Aishwary Shrivastava* On Sat, Apr 27, 2019 at 8:08 PM Devanshu Vyas wrote: > Agree with Rishi here, and a -1 for the proposal. > > The GoodIdentification or the PartyIdentification entity should only > contain the information to uniquely identify a product(which said by > everyone, is rarely), so adding fromDate/thruDate will not be much > beneficial. > On the other hand, the GoodIdentificationHistory could be a good > alternative approach to what you are suggesting here. > > Thanks & Regards, > Devanshu Vyas. > > > On Sat, Apr 27, 2019 at 7:22 PM Rishi Solanki > wrote: > > > -1 for the proposal. > > For a product identification code will be one of one type. The universal > > data model book by Len Silverston suggested the same. > > > > Best Regards, > > -- > > *Rishi Solanki* | Sr Manager, Enterprise Software Development > > HotWax Systems <http://www.hotwaxsystems.com/> > > Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, > > Indore, > > M.P 452010 > > Linkedin: *Rishi Solanki* > > <https://www.linkedin.com/in/rishi-solanki-62271b7/> > > Direct: +91-9893287847 > > > > > > On Sat, Apr 27, 2019 at 4:03 PM Michael Brohl > > wrote: > > > > > Hi Aishwary, > > > > > > can you elaborate a bit more why a history of GoodIdentification is > > needed? > > > > > > It is used for identification numbers as ISBN, EAN etc.. Those numbers > > > are rarely subject to change for the same product. > > > > > > I don't see any use case for history tracking so I would appreciate > some > > > examples. > > > > > > Thanks, > > > > > > Michael Brohl > > > > > > ecomify GmbH - www.ecomify.de > > > > > > > > > Am 27.04.19 um 09:11 schrieb Aishwary Shrivastava: > > > > Hello, Devs > > > > > > > > We should add support of fromDate and thruDate in the > > GoodIdentification > > > > entity for tracking and history purpose. > > > > > > > > As of now, if we need to update any Good Identification record for a > > > > product, then we have to replace its value and this history isn't > > > > maintained. > > > > It will also enable the user to maintain multiple goodIdentifications > > of > > > a > > > > product. > > > > > > > > Best, > > > > *Aishwary Shrivastava* | HotWax Systems < > http://www.hotwaxsystems.com/ > > > > > > > > > > > > > > > >
Re: Adding fromDate and thruDate in GoodIdentification Entity
Hello Deepak, We might need to change good identification value anytime due to change in the third-party system or due to other reason. So to track the previous/old value we may need to maintain it by date constraint. At a time only one identification will be active for a product of the same type. Best, *Aishwary Shrivastava* On Sat, Apr 27, 2019 at 1:17 PM Nicolas Malin wrote: > I'm mixed about that idea. > > GoodIdentification like PartyIdentification are useful to search on > multiple identification shared by other system. Add life-stamp will add > complexity the resolve quickly a element. Like a name 99% case it's more > important to have the current identification list. Maybe a history > entity (as GoodIdentificationHistory) would be more simple to implement > and sufficient to your problematic ? > > Nicolas > > On 27/04/2019 09:22, Arun Patidar wrote: > > +1, looks good to me. > > > > This will require changes in existing CRUD operations related to > > GoodIdentifications. Also may need migration service or SQL scripts. > > > > > > -- > > Best Regards, > > Arun Patidar > > www.hotwax.co > > > > > > > > On Sat, Apr 27, 2019 at 12:42 PM Aishwary Shrivastava < > > aishwary.shrivast...@hotwaxsystems.com> wrote: > > > >> Hello, Devs > >> > >> We should add support of fromDate and thruDate in the GoodIdentification > >> entity for tracking and history purpose. > >> > >> As of now, if we need to update any Good Identification record for a > >> product, then we have to replace its value and this history isn't > >> maintained. > >> It will also enable the user to maintain multiple goodIdentifications > of a > >> product. > >> > >> Best, > >> *Aishwary Shrivastava* | HotWax Systems <http://www.hotwaxsystems.com/> > >> >
Adding fromDate and thruDate in GoodIdentification Entity
Hello, Devs We should add support of fromDate and thruDate in the GoodIdentification entity for tracking and history purpose. As of now, if we need to update any Good Identification record for a product, then we have to replace its value and this history isn't maintained. It will also enable the user to maintain multiple goodIdentifications of a product. Best, *Aishwary Shrivastava* | HotWax Systems <http://www.hotwaxsystems.com/>
Re: Welcome to Suraj Khurana as new committer!
Many Congratulations Suraj!!! Thanks and Regards, *Aishwary Shrivastava* | Enterprise Software Engineer HotWax Commerce <http://www.hotwax.co/> by HotWax Systems <http://www.hotwaxsystems.com/> Cell phone: +91-8962244998 I Linkedin: *Aishwary Shrivastava* <https://www.linkedin.com/in/aishwaryshrivastava/> <http://www.hotwaxsystems.com/> <http://www.hotwaxsystems.com/> On Wed, Jun 27, 2018 at 9:39 AM, Akash Jain wrote: > Many Congratulations Suraj! > > Thanks and Regards > -- > Akash Jain > > > On Wed, Jun 27, 2018 at 1:30 AM, Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > > > The OFBiz PMC has invited Suraj to become a new committer and we > > arepleased to announce that he has accepted. > > > > Suraj has proved to be committed for a long time now and is doing a very > > good work as a contributor. > > > > He helped in a lot of Jiras, answered properly on MLs and proposed a few > > quite interesting subjects. > > > > Please join me in welcoming and congratulating Suraj. > > > > Jacques > > > > >
Re: Welcome to Swapnil M. Mane as new committer!
Many Congratulations Swapnil Mane :) Thanks and Regards, *Aishwary Shrivastava* | Enterprise Software Engineer HotWax Commerce <http://www.hotwax.co/> by HotWax Systems <http://www.hotwaxsystems.com/> Cell phone: +91-8962244998 I Linkedin: *Aishwary Shrivastava* <https://www.linkedin.com/in/aishwaryshrivastava/> <http://www.hotwaxsystems.com/> <http://www.hotwaxsystems.com/> On Wed, Jun 27, 2018 at 9:40 AM, Akash Jain wrote: > Many Congratulations Swapnil Mane! > > Thanks and Regards > -- > Akash Jain > > > On Wed, Jun 27, 2018 at 1:30 AM, Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > > > The OFBiz PMC has invited Swapnil to become a new committer and we > > arepleased to announce that he has accepted. > > > > Swapnil has a high level of commitment for Apache OFBiz and consistently > > works with the community. > > > > He is one of the most advanced contributors (including committers) in the > > functional domain. > > Please join me in welcoming and congratulating Swapnil. > > > > Jacques > > > > >
Re: Welcome to Aditya Sharma as new committer!
Many Congratulations Aditya. You indeed contributed a lot. Thanks and Regards, *Aishwary Shrivastava* | Enterprise Software Engineer HotWax Commerce <http://www.hotwax.co/> by HotWax Systems <http://www.hotwaxsystems.com/> Cell phone: +91-8962244998 I Linkedin: *Aishwary Shrivastava* <https://www.linkedin.com/in/aishwaryshrivastava/> <http://www.hotwaxsystems.com/> <http://www.hotwaxsystems.com/> On Wed, Jun 27, 2018 at 9:51 AM, Garima Jain wrote: > Congratulations Aditya. > > > > On Wed, Jun 27, 2018 at 9:39 AM Akash Jain > wrote: > > > Many Congratulations Aditya! > > > > Thanks and Regards > > -- > > Akash Jain > > > > On Wed, Jun 27, 2018 at 1:29 AM, Jacques Le Roux < > > jacques.le.r...@les7arts.com> wrote: > > > > > The OFBiz PMC has invited Aditya to become a new committer and we > > > arepleased to announce that he has accepted. > > > > > > Aditya has proved to be committed and doing a very good work as a > > > contributor. > > > > > > He notably coordinated the work around the refactoring of the data > model > > > documents, helped in a lot of Jiras and answered appropriately on MLs. > > > > > > Please join me in welcoming and congratulating Aditya. > > > > > > Jacques > > > > > > > > > > > -- > > > *Kind Regards* > Garima Jain >
Re: [Proposal] Support for more decimals in price fields
+1 Chinmay Patidar, As it will be good for users who want to use Bitcoins as a mode of Payments. On Wed, Sep 27, 2017 at 6:12 PM, Chinmay Patidar < chinmay.pati...@hotwaxsystems.com> wrote: > Hello Devs, > > Ofbiz places a restriction on saving more than 3 decimal places in price > related entity-fields. But there can be a number of use cases where a user > needs to store more than 2 or 3 decimal places in the currency related > entity-fields. > > I even saw some discussions related to this but didn't found any > conclusions from them. Even one issue > <https://issues.apache.org/jira/browse/OFBIZ-494> has been created but for > limited fields. So, I would like to propose support for multiple or more > than 2/3 decimals in price related fields. > > Following are some findings related to the currency fields which would be > helpful to examine the requirement: > Ofbiz uses two field types to store the currency related entity-fields. > These two types are 'currency-amount' and 'currency-precise' with their > respective types being NUMBER(18,2) and NUMBER(18,3). > > Upon initial research, one can conclude that changing the field definitions > of 'currency-amount' and 'currency-precise' would achieve the requirement. > But doing so will raise following questions which need to be answered. Feel > free to add in them. > >- What would be the precise value of precision(number of decimals)? >- Will these changes can make the system inconsistent? > > In addition, I would like to know the significance of having two separate > field types, i.e. 'currency-amount' and 'currency-precise'. > > Also, I have marked one improvement which will be needed to realize the > solution. There are multiple occurrences where hardcoded scaling of 2 has > been set to either display or store a currency field. This needs to be > changed and must be set dynamically. > > I'd like to hear your thoughts. > > Thanks, > *Chinmay Patidar* > -- Thanks and Regards, *Aishwary Shrivastava* | Enterprise Software Engineer HotWax Commerce <http://www.hotwax.co/> by HotWax Systems <http://www.hotwaxsystems.com/>
Re: Tracking Data Model changes
Indeed it's a great idea, Aditya!! +1 On Wed, Aug 30, 2017 at 7:06 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > +1 clearly > > Jacques > > > > Le 30/08/2017 à 15:23, Aditya Sharma a écrit : > >> Hello everyone, >> >> For one of my assignments, I need to find out entity changes that took >> place between an older release and the latest release. >> >> One of the solutions that came up was comparing the database using MySQL >> Workbench or some other utility. I found around 60+ new entity changes and >> a lot of minor field changes since last big book was published (OFBiz 9 I >> suppose). >> It's fascinating for me that around 8 years passed since then and data >> model still stands well (Kudos to Universal Data Model that we followed in >> OFBiz) >> >> >> Just a proposal, since we don't have so many frequent changes in the data >> model. It will be good to have a page or some other method defined to keep >> a track of such changes. >> >> I feel such information can be quite helpful when migrating from an older >> to some newer release. >> >> Please share your thoughts. >> >> Thanks and Regards, >> >> *Aditya Sharma* | Enterprise Software Engineer >> HotWax Systems <http://www.hotwaxsystems.com/> >> <https://www.linkedin.com/in/aditya-sharma-78291810a/> >> >> > -- Best regards, Aishwary Shrivastava Enterprise Software Engineer HotWax Systems <http://www.hotwaxsystems.com/>
