[jira] [Commented] (OFBIZ-4313) setUserPreference goes to main page instead last view if current form includes any lookup field
[ https://issues.apache.org/jira/browse/OFBIZ-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13051659#comment-13051659 ] Bruno Busco commented on OFBIZ-4313: Could it be related to the button used to expand/collapse the header ? setUserPreference goes to main page instead last view if current form includes any lookup field - Key: OFBIZ-4313 URL: https://issues.apache.org/jira/browse/OFBIZ-4313 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Leon Priority: Minor Fix For: SVN trunk Attachments: lookup_lastViewName.patch When I open a form which include lookup field and then click the set User Preference button around the upper right corner, the page will go to main after user preference is setted. The cause is the requests initiated by lookup field does not remeber the last view name. It simply use main instead. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (OFBIZ-4187) The lookup widget does not support the target-parameter tag anymore
[ https://issues.apache.org/jira/browse/OFBIZ-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco resolved OFBIZ-4187. Resolution: Fixed The lookup widget does not support the target-parameter tag anymore --- Key: OFBIZ-4187 URL: https://issues.apache.org/jira/browse/OFBIZ-4187 Project: OFBiz Issue Type: Sub-task Components: framework Reporter: Bruno Busco Assignee: Jacques Le Roux The actual call_fieldlookup2 and call_fieldlookup3 javascript functions do not accept the optional document.${formName}.${item}.value parameters that are passed when one or more target-parameter tags are used in the lookup widget. This causes that the lookup screens do not receive the parameters. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4187) The lookup widget does not support the target-parameter tag anymore
[ https://issues.apache.org/jira/browse/OFBIZ-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco closed OFBIZ-4187. -- The lookup widget does not support the target-parameter tag anymore --- Key: OFBIZ-4187 URL: https://issues.apache.org/jira/browse/OFBIZ-4187 Project: OFBiz Issue Type: Sub-task Components: framework Reporter: Bruno Busco Assignee: Jacques Le Roux The actual call_fieldlookup2 and call_fieldlookup3 javascript functions do not accept the optional document.${formName}.${item}.value parameters that are passed when one or more target-parameter tags are used in the lookup widget. This causes that the lookup screens do not receive the parameters. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-4187) The lookup widget does not support the target-parameter tag anymore
[ https://issues.apache.org/jira/browse/OFBIZ-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12997188#comment-12997188 ] Bruno Busco commented on OFBIZ-4187: Hi Jacques, I discovered this bug while using the lookup widget in a my own application. In any case, an example could be the lookup you get in: https://localhost:8443/marketing/control/EditContactListParty?contactListId=9000partyId=DemoCustAgentfromDate=2001-05-13%2000:00:00.000 or any other you can find searching for target-parameter The lookup widget does not support the target-parameter tag anymore --- Key: OFBIZ-4187 URL: https://issues.apache.org/jira/browse/OFBIZ-4187 Project: OFBiz Issue Type: Bug Components: framework Reporter: Bruno Busco Assignee: Jacques Le Roux The actual call_fieldlookup2 and call_fieldlookup3 javascript functions do not accept the optional document.${formName}.${item}.value parameters that are passed when one or more target-parameter tags are used in the lookup widget. This causes that the lookup screens do not receive the parameters. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (OFBIZ-4187) The lookup widget does not support the target-parameter tag anymore
The lookup widget does not support the target-parameter tag anymore --- Key: OFBIZ-4187 URL: https://issues.apache.org/jira/browse/OFBIZ-4187 Project: OFBiz Issue Type: Bug Components: framework Reporter: Bruno Busco The actual call_fieldlookup2 and call_fieldlookup3 javascript functions do not accept the optional document.${formName}.${item}.value parameters that are passed when one or more target-parameter tags are used in the lookup widget. This causes that the lookup screens do not receive the parameters. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-3373) Adding menu merging feature
[ https://issues.apache.org/jira/browse/OFBIZ-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12988571#action_12988571 ] Bruno Busco commented on OFBIZ-3373: Hi Scott, is there something I can do to help finalizing this? Thank you, Bruno Adding menu merging feature --- Key: OFBIZ-3373 URL: https://issues.apache.org/jira/browse/OFBIZ-3373 Project: OFBiz Issue Type: Wish Components: framework Reporter: Bruno Busco Priority: Minor Attachments: googlebase-inject.patch, injections.patch, injections.patch, links.jpg, partymenu.JPG Hi devs, while discussing in the ML about modules and framework separation I thought to this new feature that I would like to discuss here with you. We have now the possibility to extend a menu from one other. This is great in order to have an high level of code reuse and great consistency all over OFBiz. I was thinking to a sort of merges-to property for the menu widget. This would allow a new module to specify an already exixting menu name (in the framework core or in a lower level module) that should be somewhat changed by the actual menu. For instance, in the attached image partymenu.jpg there is a a tipical use of this feature: in the party module there are lot of links that co to order application, account etc. Those menu link could be used defining a simple menu (say it partylinks_menu) in the party application that contains only party or framework related links (i.e. profile); additional components like order or accounting could define more menus that merges-to the partylinks_manu so that when the menu is rendered IN THE PARTY APPLICATION the new menu items added in the order and accounting applications are also rendered. This would allow us to dramatically reduce the component dependence and help us to have the framework-only distribution. To eventually implement this I think there should be an entity that defines such mergin menus and the menu rendered should lookup the entity to check if one or more merges to the actually rendering menu is defined. I would appreciate to hear from you if this idea can help. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4127) Styles for the button-bar buttons are not created
[ https://issues.apache.org/jira/browse/OFBIZ-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12988464#action_12988464 ] Bruno Busco commented on OFBIZ-4127: Hi, I have posted something in the DEV ML and later I have seen this JIRA. Well, could we definitively remove these two button-styles? There is no reason IMO to let the user know that a button links to intra-app or inter-app. The only reason the user should know about it is if it is not allowed to access a different applicationbut, in this case, a disabled button should be used (or no button at all). In any case if we would keep these styles they should better be named intra-app-button and inter-app-button. This means use functional names for styles. Styles for the button-bar buttons are not created - Key: OFBIZ-4127 URL: https://issues.apache.org/jira/browse/OFBIZ-4127 Project: OFBiz Issue Type: Bug Components: themes Affects Versions: SVN trunk Reporter: Erwan de FERRIERES Assignee: Adrian Crum Priority: Minor Fix For: SVN trunk Attachments: disabledBtn.patch, fg_button-bar.png The buttons in button-bar have no style definition. You can see it through the screenshot, or going to the layout demo page (nice idea, BTW!). Cheers, -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982778#action_12982778 ] Bruno Busco commented on OFBIZ-4092: This new Flat grey theme looks really good! Thank you guys. Update The Flat Grey Visual Theme - Key: OFBIZ-4092 URL: https://issues.apache.org/jira/browse/OFBIZ-4092 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: ac_flatgrey.patch, ac_flatgrey.patch, ac_images.zip, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, rf_flatgrey.patch, rf_flatgrey_images.zip, screenshot.gif, timeSheet.png Update the Flat Grey visual theme. Design objectives: 1. Floating, flexible layout - screen can be resized. 2. Sight impaired accessible - users can change font size in their browser. 3. Supports RTL layout. 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4112) Page title missing in the Tomahawk theme.
[ https://issues.apache.org/jira/browse/OFBIZ-4112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982261#action_12982261 ] Bruno Busco commented on OFBIZ-4112: The main idea on the Tomahawk theme is that the navigation bar works both as a drop-down application selection menu and as a breadcrumbs indicator of the actually selected screen. The last part of the breadcrumbs (the one with the yellow background) shows the actually selected item from the Application Menu (headerItem). If the headerItem menu item takes to a multi-screen then a TabBar is shown and the information about the screen the user is actually using is given by the breadcrumb plus the selected tab in the TabBar. With this logic an additional title string in the screen itself seemed to not add any information to the user but only a waste of screen space. This was the reason I hided the title string. Page title missing in the Tomahawk theme. - Key: OFBIZ-4112 URL: https://issues.apache.org/jira/browse/OFBIZ-4112 Project: OFBiz Issue Type: Sub-task Reporter: Jacques Le Roux Priority: Minor -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4112) Page title missing in the Tomahawk theme.
[ https://issues.apache.org/jira/browse/OFBIZ-4112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982271#action_12982271 ] Bruno Busco commented on OFBIZ-4112: Yes Jacques, this is wanted. While in an application main page the breadcrumbs ends with the application name and shows the menu icon to highight that more options are available. Page title missing in the Tomahawk theme. - Key: OFBIZ-4112 URL: https://issues.apache.org/jira/browse/OFBIZ-4112 Project: OFBiz Issue Type: Sub-task Reporter: Jacques Le Roux Priority: Minor -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4112) Page title missing in the Tomahawk theme.
[ https://issues.apache.org/jira/browse/OFBIZ-4112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982272#action_12982272 ] Bruno Busco commented on OFBIZ-4112: Of course this happens if the application main page is defined with headerItem=main. This does not happen actually with the example application. I think we should change this since we normally use the example application as a template. This is the code in the appBarClose.ftl file: #if headerItem!=main div class=breadcrumbs-sep ${appModelMenu.getModelMenuItemByName(headerItem).getTitle(context)} /div /#if Page title missing in the Tomahawk theme. - Key: OFBIZ-4112 URL: https://issues.apache.org/jira/browse/OFBIZ-4112 Project: OFBiz Issue Type: Sub-task Reporter: Jacques Le Roux Priority: Minor -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4112) Page title missing in the Tomahawk theme.
[ https://issues.apache.org/jira/browse/OFBIZ-4112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982286#action_12982286 ] Bruno Busco commented on OFBIZ-4112: Yes, the Example application actually has not a proper main screen as i.e. Accounting does. There was discussion about using a PortalPage as the main screen of each application. May be we could discuss this in the ML and if approved we could use this pattern. I think we could close this. Page title missing in the Tomahawk theme. - Key: OFBIZ-4112 URL: https://issues.apache.org/jira/browse/OFBIZ-4112 Project: OFBiz Issue Type: Sub-task Reporter: Jacques Le Roux Priority: Minor -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4081) Form widget improvements
[ https://issues.apache.org/jira/browse/OFBIZ-4081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12978241#action_12978241 ] Bruno Busco commented on OFBIZ-4081: Looking at other open source ERP systems I found that many of the improvement proposed here as sub-tasks are implemented in openCRX (http://demo.opencrx.org). I put here this reference because it could be usefull in our design. Form widget improvements Key: OFBIZ-4081 URL: https://issues.apache.org/jira/browse/OFBIZ-4081 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Bruno Busco Priority: Minor I have a list of ideas about improvements that could be done on the frame widget. I think that creating jiras for these could be a good starting point to discuss, and eventually design and implement them. This issue is an umbrella task for them. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12978243#action_12978243 ] Bruno Busco commented on OFBIZ-4092: I have an idea for the tab bar. We all agree that it does not show well when it comes to two or three rows. Well, we could only show the tabs that fit in one row and add a tab as last tab. When hovering on the tab the remaining tabs appear like a pull down menu allowing the user to select one of them. The actually selected tab should always be showed as the fist element on the left. What do you think? Could it be done with some jquery script? Update The Flat Grey Visual Theme - Key: OFBIZ-4092 URL: https://issues.apache.org/jira/browse/OFBIZ-4092 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: accounting800x600.png, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png Update the Flat Grey visual theme. Design objectives: 1. Floating, flexible layout - screen can be resized. 2. Sight impaired accessible - users can change font size in their browser. 3. Supports RTL layout. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-4080) Implement a Column Widget
Implement a Column Widget - Key: OFBIZ-4080 URL: https://issues.apache.org/jira/browse/OFBIZ-4080 Project: OFBiz Issue Type: Wish Components: framework Reporter: Bruno Busco Priority: Minor Some time ago there was a discussion on the dev mailing list about how to implement something to display contents in columns on screens. I cut and past an Adrian's idea that is something we should consider to implement. -- From the screen widget XML perspective, it could look like this: column-container column name=first-column !-- column contents -- /column column name=second-column !-- column contents -- /column ... /column-container The column elements can contain additional column-container elements. The column element can have an attribute to specify its width as a percentage of the column-container width. Pixel widths should be avoided since the screen widgets are supposed to be rendering device agnostic. The column-container and column elements will support the common screen widget attributes like name, style, id, etc. The column-container could support a type attribute that controls how the contained columns behave. For example, type=splitter will render the contained columns as a splitter window. From the widget model perspective, the column-container manages resizing columns when one of them is collapsed or its width changes. Column size information needs to be kept in the rendering context. The information would start off with some default values that are overridden by user preferences. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-4081) Form widget improvements
Form widget improvements Key: OFBIZ-4081 URL: https://issues.apache.org/jira/browse/OFBIZ-4081 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Bruno Busco Priority: Minor I have a list of ideas about improvements that could be done on the frame widget. I think that creating jiras for these could be a good starting point to discuss, and eventually design and implement them. This issue is an umbrella task for them. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-4082) Adding a Print this form icon to the top frame bar
Adding a Print this form icon to the top frame bar Key: OFBIZ-4082 URL: https://issues.apache.org/jira/browse/OFBIZ-4082 Project: OFBiz Issue Type: Improvement Reporter: Bruno Busco There should be a new frame tag attribute that would specify that a Print this form icon should be displayed in the top frame bar. This icon should allow the user to print the actual frame in a consistent way (all frame will have the same icon). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-4083) Adding a Go to next record and a Go to previous record icons in the frame top bar
Adding a Go to next record and a Go to previous record icons in the frame top bar - Key: OFBIZ-4083 URL: https://issues.apache.org/jira/browse/OFBIZ-4083 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Bruno Busco Priority: Minor These icons should allow to navigate through all the records of a list. These should only be available for single type forms. The list to navigate should be for example the list of records that has been selected by a previous find operation. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-4084) Adding a Return to search icon in the single frame top bar
Adding a Return to search icon in the single frame top bar Key: OFBIZ-4084 URL: https://issues.apache.org/jira/browse/OFBIZ-4084 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Bruno Busco Priority: Minor If the single frame being displyied comes from a previous search this button icon should allow to go back to the previous search query. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-4085) Adding a View attachments button icon to the single form's top bar
Adding a View attachments button icon to the single form's top bar Key: OFBIZ-4085 URL: https://issues.apache.org/jira/browse/OFBIZ-4085 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Bruno Busco Priority: Minor There should be a standard way to allow the display of a list of attachments to a single record. The Attachments icon button with the relative attachments list screen should be a standard feature that should be easily implemented on any single frame record. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-4080) Implement a Column Widget
[ https://issues.apache.org/jira/browse/OFBIZ-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-4080: --- Issue Type: Sub-task (was: Wish) Parent: OFBIZ-4081 Implement a Column Widget - Key: OFBIZ-4080 URL: https://issues.apache.org/jira/browse/OFBIZ-4080 Project: OFBiz Issue Type: Sub-task Components: framework Reporter: Bruno Busco Priority: Minor Some time ago there was a discussion on the dev mailing list about how to implement something to display contents in columns on screens. I cut and past an Adrian's idea that is something we should consider to implement. -- From the screen widget XML perspective, it could look like this: column-container column name=first-column !-- column contents -- /column column name=second-column !-- column contents -- /column ... /column-container The column elements can contain additional column-container elements. The column element can have an attribute to specify its width as a percentage of the column-container width. Pixel widths should be avoided since the screen widgets are supposed to be rendering device agnostic. The column-container and column elements will support the common screen widget attributes like name, style, id, etc. The column-container could support a type attribute that controls how the contained columns behave. For example, type=splitter will render the contained columns as a splitter window. From the widget model perspective, the column-container manages resizing columns when one of them is collapsed or its width changes. Column size information needs to be kept in the rendering context. The information would start off with some default values that are overridden by user preferences. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-4083) Adding a Go to next record and a Go to previous record icons in the frame top bar
[ https://issues.apache.org/jira/browse/OFBIZ-4083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-4083: --- Issue Type: Sub-task (was: Improvement) Parent: OFBIZ-4081 Adding a Go to next record and a Go to previous record icons in the frame top bar - Key: OFBIZ-4083 URL: https://issues.apache.org/jira/browse/OFBIZ-4083 Project: OFBiz Issue Type: Sub-task Components: framework Reporter: Bruno Busco Priority: Minor These icons should allow to navigate through all the records of a list. These should only be available for single type forms. The list to navigate should be for example the list of records that has been selected by a previous find operation. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-4084) Adding a Return to search icon in the single frame top bar
[ https://issues.apache.org/jira/browse/OFBIZ-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-4084: --- Issue Type: Sub-task (was: Improvement) Parent: OFBIZ-4081 Adding a Return to search icon in the single frame top bar Key: OFBIZ-4084 URL: https://issues.apache.org/jira/browse/OFBIZ-4084 Project: OFBiz Issue Type: Sub-task Components: framework Reporter: Bruno Busco Priority: Minor If the single frame being displyied comes from a previous search this button icon should allow to go back to the previous search query. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-4085) Adding a View attachments button icon to the single form's top bar
[ https://issues.apache.org/jira/browse/OFBIZ-4085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-4085: --- Issue Type: Sub-task (was: Improvement) Parent: OFBIZ-4081 Adding a View attachments button icon to the single form's top bar Key: OFBIZ-4085 URL: https://issues.apache.org/jira/browse/OFBIZ-4085 Project: OFBiz Issue Type: Sub-task Components: framework Reporter: Bruno Busco Priority: Minor There should be a standard way to allow the display of a list of attachments to a single record. The Attachments icon button with the relative attachments list screen should be a standard feature that should be easily implemented on any single frame record. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-4021) Adding columns filtering fields in form widget
[ https://issues.apache.org/jira/browse/OFBIZ-4021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-4021: --- Issue Type: Sub-task (was: New Feature) Parent: OFBIZ-4081 Adding columns filtering fields in form widget -- Key: OFBIZ-4021 URL: https://issues.apache.org/jira/browse/OFBIZ-4021 Project: OFBiz Issue Type: Sub-task Components: framework Reporter: Bruno Busco Priority: Minor Attachments: column_filter_disabled.JPG, column_filter_enabled.JPG, content_list.JPG, FilterForm.patch, FilterForm.patch, img_for_tomahawk.zip This patch includes an initial implementation of a list-form column filtering feature. The aim is to add the possibility to configure a list form to show, in its header, some fields that could be used to filter the rows displayed in the form. This is a feature quite standard in many systems and could be seen into OFBiz as a quick search; the standard way of searching using a complete single-type form could be seen as an advanced search. Please find attached to this JIRA two screenshots that show you how the filtering option appears on the screen. *How the user uses this feature* The part of the screen that is normally used for the pagination controls (only the upper one) has been extended so that two icons are shown on the left. The first one (a funnel) is used to show or hide the filtering fields. The second one (a magnifing glass) is used to run the search with the filter content. *How the developer uses this feature* The filtering feature can be enabled on any list-type form specifying the filter-form-name attribute. This must be the name of a form that contains the details about how the filtering fields should be rendered. When a list form with the filter-form-name option set is rendered, any column field is searched for in the filter-form. If a field with the same name is found, its field rendering options are used to render the filter field. A new field attribute filter-field has also been added. This defaults to true but if it is set to false the filter field is not rendered for this column, even if a field with the same name is present in the filter-form. This feature allows to use as filter-form an already existent form such as a regular FindXXX form. In the patch the ListExample form has been changed to use this feature. You can check it there. Unfortunately the patch does not work yet 100% but I hope that if someone finds it interesting could help me. *What is there still to do* 1) There is a FIXME in MacroFormRenderer.java file. I cannot make it work. If I enable the code that is commented there I get an error when a search is run. 2) I cannot make the filtering fields show the actual content after a search is run. They are always rendered as empty. 3) The filter row hide/show status should be saved so that it is maintained after a pagination. I submit this patch as it is becouse I cannot easily improve it further but I hope someone could help. The img_for_tamahawk.zip file includes imgs that should be added in the tomahawk images folder to make the patch work. Thank you for any help! -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-4086) Adding a download CSV file button icon for list forms
Adding a download CSV file button icon for list forms - Key: OFBIZ-4086 URL: https://issues.apache.org/jira/browse/OFBIZ-4086 Project: OFBiz Issue Type: Sub-task Reporter: Bruno Busco -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4086) Adding a download CSV file button icon for list forms
[ https://issues.apache.org/jira/browse/OFBIZ-4086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12975775#action_12975775 ] Bruno Busco commented on OFBIZ-4086: From the DEV ML Hi Jacopo, thank you for your proposal. In my mind there was only something like your #1. This would allow to embed an export link in the form (I would like to include a standard download icon in the list form pagination bar) whose target is automatically derived from the form's target. This link could be rendered if the cvs-export=true is added to the frame attributes. #2 will for sure add more generality and would allow the export to any screen even not just a form. This would be great. #3 Yes, but I would prefer to have specific icons i the top bars (i.e. the form pagination or the screenlet title bar) The export link should perform a request with the same search parameters as the last one. Thank you very much for discussing on this. -Bruno 2010/12/4 Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com Hi Bruno, this is not exactly the same topic but I would like to share some of my ideas for enhancements for the macro screen widget. Currently, in order to get an html and a csv version of a screen we have to create the two screen definitions (with different decorators) and setup entries in the controller like: view-map name=InventoryItemTotals type=screen page=component://product/widget/facility/FacilityScreens.xml#InventoryItemTotals/ view-map name=InventoryItemTotalsExport type=screencsv page=component://product/widget/facility/FacilityScreens.xml#InventoryItemTotalsExport content-type=text/csv encoding=none/ The following improvements will make the rendering in different formats more dynamic: 1) in the controller, the two view-maps could be grouped into one where the content-type is dynamically retrieved from the request (then the view handler will use screen or screencsv etc based on the content type) 2) enhance the global decorator to render properly on different formats; if the decorator contains screens/forms widgets then the widget should render themselves in the proper format; if the decorator contains ftl templates, we will have to provide alternative ones like: platform-specific htmlhtml-template location=component://common/webcommon/includes/simple.ftl//html xsl-fohtml-template location=component://common/webcommon/includes/simple.fo.ftl//xsl-fo xmlhtml-template location=component://common/webcommon/includes/minimal-decorator.ftl//xml /platform-specific 3) in the search form we could add a drop down for the selection of the content-type At this point we may be able to export in different formats virtually any screen in OFBiz simply by adding a drop down box for the output format at the top of the screen (in a decorator): export to PDF, export to xml. Jacopo On Dec 4, 2010, at 12:22 AM, Bruno Busco wrote: Hi, I was thinking that having a CSV export feature embedded in the list form widget could be nice. I mean a feature that, simply adding something like a csv-export=true attribute in the form widget, would show a link or an icon in the top form pagination bar that would export the actual data listed in the form. Does this make sense? Any idea on how to implement this? Many thanks to everybody wants to share ideas on this. -Bruno Adding a download CSV file button icon for list forms - Key: OFBIZ-4086 URL: https://issues.apache.org/jira/browse/OFBIZ-4086 Project: OFBiz Issue Type: Sub-task Reporter: Bruno Busco -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-4011) Implement saved searches and other persisted requests
[ https://issues.apache.org/jira/browse/OFBIZ-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-4011: --- Issue Type: Sub-task (was: New Feature) Parent: OFBIZ-4081 Implement saved searches and other persisted requests - Key: OFBIZ-4011 URL: https://issues.apache.org/jira/browse/OFBIZ-4011 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: SVN trunk Reporter: Scott Gray Priority: Minor Attachments: saved-search.patch https://cwiki.apache.org/confluence/display/OFBIZ/Saved+Searches -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4080) Implement a Column Widget
[ https://issues.apache.org/jira/browse/OFBIZ-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12975777#action_12975777 ] Bruno Busco commented on OFBIZ-4080: This is not strictly related to the frame widget but to the screen one. In any case it could be useful to have it in the frame widget also to replace the actual position attribute for fields. Implement a Column Widget - Key: OFBIZ-4080 URL: https://issues.apache.org/jira/browse/OFBIZ-4080 Project: OFBiz Issue Type: Sub-task Components: framework Reporter: Bruno Busco Priority: Minor Some time ago there was a discussion on the dev mailing list about how to implement something to display contents in columns on screens. I cut and past an Adrian's idea that is something we should consider to implement. -- From the screen widget XML perspective, it could look like this: column-container column name=first-column !-- column contents -- /column column name=second-column !-- column contents -- /column ... /column-container The column elements can contain additional column-container elements. The column element can have an attribute to specify its width as a percentage of the column-container width. Pixel widths should be avoided since the screen widgets are supposed to be rendering device agnostic. The column-container and column elements will support the common screen widget attributes like name, style, id, etc. The column-container could support a type attribute that controls how the contained columns behave. For example, type=splitter will render the contained columns as a splitter window. From the widget model perspective, the column-container manages resizing columns when one of them is collapsed or its width changes. Column size information needs to be kept in the rendering context. The information would start off with some default values that are overridden by user preferences. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4062) Fix Portal Drag'n'Drop
[ https://issues.apache.org/jira/browse/OFBIZ-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12972790#action_12972790 ] Bruno Busco commented on OFBIZ-4062: This is a minor comment but please use two spaces indentation for .ftl files and not four. Fix Portal Drag'n'Drop -- Key: OFBIZ-4062 URL: https://issues.apache.org/jira/browse/OFBIZ-4062 Project: OFBiz Issue Type: Sub-task Components: specialpurpose/myportal Affects Versions: SVN trunk Reporter: Sascha Rodekamp Assignee: Erwan de FERRIERES Fix For: SVN trunk Attachments: OFBIZ-4062_FixPortalDragnDrop.patch Hi, during the last works on the my portal module, the Drag'n'Drop functionality was lost. Here is a fix which enables the Drag'n'Drop again. Have a goody day Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Reopened: (OFBIZ-4037) Moving the user SignUp feature from MyPortal to the Framework
[ https://issues.apache.org/jira/browse/OFBIZ-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco reopened OFBIZ-4037: The commit has been reverted as suggested by Adam. The reason was that the patch adds in the framework several dependencies from the applications (mainly Party). A rework must be done. A possible solution could be to move the register stuff to the commonext component instead of common. What do you think? Moving the user SignUp feature from MyPortal to the Framework - Key: OFBIZ-4037 URL: https://issues.apache.org/jira/browse/OFBIZ-4037 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco Assignee: Bruno Busco Attachments: ofbiz_signup.patch Hi Devs! In the attached patch I have reworked the feature that allows a new user to SignUp for an account. This feature is actually only available when logging in at the MyPortal application. Well, IMO it should be centrally available so that the login screen is exactly the same regardless of the application. The Captcha feature is already implemented (captcha.java) partially in the framework and so this patch should be seen as a clean up also. I added full internationalization of all labels and created some labels in the CommonUiLabels.xml file. I would like some review so that I could then commit if nobody finds something wrong. By the way, there is for sure some improvement that could be done at a later stage: - Eliminate the labels that have been created in the CommonUiLabels from Party and MyPortal - Add an encription of the Captcha code so that it will not be easily broken by robots. Thank you for any comment you could provide. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-4037) Moving the user SignUp feature from MyPortal to the Framework
[ https://issues.apache.org/jira/browse/OFBIZ-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco closed OFBIZ-4037. -- Resolution: Fixed Assignee: Bruno Busco Committed to the trunk At revision: 1042196 Moving the user SignUp feature from MyPortal to the Framework - Key: OFBIZ-4037 URL: https://issues.apache.org/jira/browse/OFBIZ-4037 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco Assignee: Bruno Busco Attachments: ofbiz_signup.patch Hi Devs! In the attached patch I have reworked the feature that allows a new user to SignUp for an account. This feature is actually only available when logging in at the MyPortal application. Well, IMO it should be centrally available so that the login screen is exactly the same regardless of the application. The Captcha feature is already implemented (captcha.java) partially in the framework and so this patch should be seen as a clean up also. I added full internationalization of all labels and created some labels in the CommonUiLabels.xml file. I would like some review so that I could then commit if nobody finds something wrong. By the way, there is for sure some improvement that could be done at a later stage: - Eliminate the labels that have been created in the CommonUiLabels from Party and MyPortal - Add an encription of the Captcha code so that it will not be easily broken by robots. Thank you for any comment you could provide. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4037) Moving the user SignUp feature from MyPortal to the Framework
[ https://issues.apache.org/jira/browse/OFBIZ-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12966712#action_12966712 ] Bruno Busco commented on OFBIZ-4037: Hi, I would like to commit this patch. Does somebody see any issue? I would set the OOTB values for the configuration parameters so that the SignUp feature is enabled with Captcha code check. Are you OK with this setting or do you think that by default the feature should be disabled? Right now we have that it is disabled on all application but MyPortal. After the patch the feature will be enabled/disabled for all applications. Moving the user SignUp feature from MyPortal to the Framework - Key: OFBIZ-4037 URL: https://issues.apache.org/jira/browse/OFBIZ-4037 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco Attachments: ofbiz_signup.patch Hi Devs! In the attached patch I have reworked the feature that allows a new user to SignUp for an account. This feature is actually only available when logging in at the MyPortal application. Well, IMO it should be centrally available so that the login screen is exactly the same regardless of the application. The Captcha feature is already implemented (captcha.java) partially in the framework and so this patch should be seen as a clean up also. I added full internationalization of all labels and created some labels in the CommonUiLabels.xml file. I would like some review so that I could then commit if nobody finds something wrong. By the way, there is for sure some improvement that could be done at a later stage: - Eliminate the labels that have been created in the CommonUiLabels from Party and MyPortal - Add an encription of the Captcha code so that it will not be easily broken by robots. Thank you for any comment you could provide. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4021) Adding columns filtering fields in form widget
[ https://issues.apache.org/jira/browse/OFBIZ-4021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12966723#action_12966723 ] Bruno Busco commented on OFBIZ-4021: Hi, is anybody interested in this feature? Thank you, Bruno Adding columns filtering fields in form widget -- Key: OFBIZ-4021 URL: https://issues.apache.org/jira/browse/OFBIZ-4021 Project: OFBiz Issue Type: New Feature Components: framework Reporter: Bruno Busco Priority: Minor Attachments: column_filter_disabled.JPG, column_filter_enabled.JPG, content_list.JPG, FilterForm.patch, FilterForm.patch, img_for_tomahawk.zip This patch includes an initial implementation of a list-form column filtering feature. The aim is to add the possibility to configure a list form to show, in its header, some fields that could be used to filter the rows displayed in the form. This is a feature quite standard in many systems and could be seen into OFBiz as a quick search; the standard way of searching using a complete single-type form could be seen as an advanced search. Please find attached to this JIRA two screenshots that show you how the filtering option appears on the screen. *How the user uses this feature* The part of the screen that is normally used for the pagination controls (only the upper one) has been extended so that two icons are shown on the left. The first one (a funnel) is used to show or hide the filtering fields. The second one (a magnifing glass) is used to run the search with the filter content. *How the developer uses this feature* The filtering feature can be enabled on any list-type form specifying the filter-form-name attribute. This must be the name of a form that contains the details about how the filtering fields should be rendered. When a list form with the filter-form-name option set is rendered, any column field is searched for in the filter-form. If a field with the same name is found, its field rendering options are used to render the filter field. A new field attribute filter-field has also been added. This defaults to true but if it is set to false the filter field is not rendered for this column, even if a field with the same name is present in the filter-form. This feature allows to use as filter-form an already existent form such as a regular FindXXX form. In the patch the ListExample form has been changed to use this feature. You can check it there. Unfortunately the patch does not work yet 100% but I hope that if someone finds it interesting could help me. *What is there still to do* 1) There is a FIXME in MacroFormRenderer.java file. I cannot make it work. If I enable the code that is commented there I get an error when a search is run. 2) I cannot make the filtering fields show the actual content after a search is run. They are always rendered as empty. 3) The filter row hide/show status should be saved so that it is maintained after a pagination. I submit this patch as it is becouse I cannot easily improve it further but I hope someone could help. The img_for_tamahawk.zip file includes imgs that should be added in the tomahawk images folder to make the patch work. Thank you for any help! -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4037) Moving the user SignUp feature from MyPortal to the Framework
[ https://issues.apache.org/jira/browse/OFBIZ-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12966793#action_12966793 ] Bruno Busco commented on OFBIZ-4037: As Hans suggests on the dev ML having the feature enabled would be better to show OOTB the feature. Thank you Hans. Moving the user SignUp feature from MyPortal to the Framework - Key: OFBIZ-4037 URL: https://issues.apache.org/jira/browse/OFBIZ-4037 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco Attachments: ofbiz_signup.patch Hi Devs! In the attached patch I have reworked the feature that allows a new user to SignUp for an account. This feature is actually only available when logging in at the MyPortal application. Well, IMO it should be centrally available so that the login screen is exactly the same regardless of the application. The Captcha feature is already implemented (captcha.java) partially in the framework and so this patch should be seen as a clean up also. I added full internationalization of all labels and created some labels in the CommonUiLabels.xml file. I would like some review so that I could then commit if nobody finds something wrong. By the way, there is for sure some improvement that could be done at a later stage: - Eliminate the labels that have been created in the CommonUiLabels from Party and MyPortal - Add an encription of the Captcha code so that it will not be easily broken by robots. Thank you for any comment you could provide. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4036) encode-output does not working for display tag description
[ https://issues.apache.org/jira/browse/OFBIZ-4036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12964545#action_12964545 ] Bruno Busco commented on OFBIZ-4036: Thank you Scott, I also backported to R10.4 at revision: 1039878. encode-output does not working for display tag description -- Key: OFBIZ-4036 URL: https://issues.apache.org/jira/browse/OFBIZ-4036 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco Assignee: Scott Gray Fix For: SVN trunk I want to show some HTML text in a form field. I used this code below: field name=carCount title=${uiLabelMap.FMC_CarCount} encode-output=false display description=${carCountLink} / /field The carCountLink is a string containing some HTML code. The HTML code itself is shown in the form field instead of being processed as HTML and renderd accordingly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-4037) Moving the user SignUp feature from MyPortal to the Framework
Moving the user SignUp feature from MyPortal to the Framework - Key: OFBIZ-4037 URL: https://issues.apache.org/jira/browse/OFBIZ-4037 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco Hi Devs! In the attached patch I have reworked the feature that allows a new user to SignUp for an account. This feature is actually only available when logging in at the MyPortal application. Well, IMO it should be centrally available so that the login screen is exactly the same regardless of the application. The Captcha feature is already implemented (captcha.java) partially in the framework and so this patch should be seen as a clean up also. I added full internationalization of all labels and created some labels in the CommonUiLabels.xml file. I would like some review so that I could then commit if nobody finds something wrong. By the way, there is for sure some improvement that could be done at a later stage: - Eliminate the labels that have been created in the CommonUiLabels from Party and MyPortal - Add an encription of the Captcha code so that it will not be easily broken by robots. Thank you for any comment you could provide. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-4037) Moving the user SignUp feature from MyPortal to the Framework
[ https://issues.apache.org/jira/browse/OFBIZ-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-4037: --- Attachment: ofbiz_signup.patch Moving the user SignUp feature from MyPortal to the Framework - Key: OFBIZ-4037 URL: https://issues.apache.org/jira/browse/OFBIZ-4037 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco Attachments: ofbiz_signup.patch Hi Devs! In the attached patch I have reworked the feature that allows a new user to SignUp for an account. This feature is actually only available when logging in at the MyPortal application. Well, IMO it should be centrally available so that the login screen is exactly the same regardless of the application. The Captcha feature is already implemented (captcha.java) partially in the framework and so this patch should be seen as a clean up also. I added full internationalization of all labels and created some labels in the CommonUiLabels.xml file. I would like some review so that I could then commit if nobody finds something wrong. By the way, there is for sure some improvement that could be done at a later stage: - Eliminate the labels that have been created in the CommonUiLabels from Party and MyPortal - Add an encription of the Captcha code so that it will not be easily broken by robots. Thank you for any comment you could provide. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-4036) encode-output does not working for display tag description
[ https://issues.apache.org/jira/browse/OFBIZ-4036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-4036: --- Affects Version/s: SVN trunk encode-output does not working for display tag description -- Key: OFBIZ-4036 URL: https://issues.apache.org/jira/browse/OFBIZ-4036 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco I want to show some HTML text in a form field. I used this code below: field name=carCount title=${uiLabelMap.FMC_CarCount} encode-output=false display description=${carCountLink} / /field The carCountLink is a string containing some HTML code. The HTML code itself is shown in the form field instead of being processed as HTML and renderd accordingly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-4036) encode-output does not working for display tag description
encode-output does not working for display tag description -- Key: OFBIZ-4036 URL: https://issues.apache.org/jira/browse/OFBIZ-4036 Project: OFBiz Issue Type: Bug Components: framework Reporter: Bruno Busco I want to show some HTML text in a form field. I used this code below: field name=carCount title=${uiLabelMap.FMC_CarCount} encode-output=false display description=${carCountLink} / /field The carCountLink is a string containing some HTML code. The HTML code itself is shown in the form field instead of being processed as HTML and renderd accordingly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-4021) Adding columns filtering fields in form widget
[ https://issues.apache.org/jira/browse/OFBIZ-4021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-4021: --- Attachment: content_list.JPG FilterForm.patch Hi, I updated the patch to compile with the latest trunk. In addition I introduced the filter feature in the ListContent form as you can see in the new screenshot (will nedd some CSS hack to better display). In the ListContent I showed the use of the new filter-field attribute of the filter tag. Could you please review the patch? I am still encontering the runtime error described above. The bug only shows up in the Example form and not in the ListContent form. Thank you for your help. Adding columns filtering fields in form widget -- Key: OFBIZ-4021 URL: https://issues.apache.org/jira/browse/OFBIZ-4021 Project: OFBiz Issue Type: New Feature Components: framework Reporter: Bruno Busco Priority: Minor Attachments: column_filter_disabled.JPG, column_filter_enabled.JPG, content_list.JPG, FilterForm.patch, FilterForm.patch, img_for_tomahawk.zip This patch includes an initial implementation of a list-form column filtering feature. The aim is to add the possibility to configure a list form to show, in its header, some fields that could be used to filter the rows displayed in the form. This is a feature quite standard in many systems and could be seen into OFBiz as a quick search; the standard way of searching using a complete single-type form could be seen as an advanced search. Please find attached to this JIRA two screenshots that show you how the filtering option appears on the screen. *How the user uses this feature* The part of the screen that is normally used for the pagination controls (only the upper one) has been extended so that two icons are shown on the left. The first one (a funnel) is used to show or hide the filtering fields. The second one (a magnifing glass) is used to run the search with the filter content. *How the developer uses this feature* The filtering feature can be enabled on any list-type form specifying the filter-form-name attribute. This must be the name of a form that contains the details about how the filtering fields should be rendered. When a list form with the filter-form-name option set is rendered, any column field is searched for in the filter-form. If a field with the same name is found, its field rendering options are used to render the filter field. A new field attribute filter-field has also been added. This defaults to true but if it is set to false the filter field is not rendered for this column, even if a field with the same name is present in the filter-form. This feature allows to use as filter-form an already existent form such as a regular FindXXX form. In the patch the ListExample form has been changed to use this feature. You can check it there. Unfortunately the patch does not work yet 100% but I hope that if someone finds it interesting could help me. *What is there still to do* 1) There is a FIXME in MacroFormRenderer.java file. I cannot make it work. If I enable the code that is commented there I get an error when a search is run. 2) I cannot make the filtering fields show the actual content after a search is run. They are always rendered as empty. 3) The filter row hide/show status should be saved so that it is maintained after a pagination. I submit this patch as it is becouse I cannot easily improve it further but I hope someone could help. The img_for_tamahawk.zip file includes imgs that should be added in the tomahawk images folder to make the patch work. Thank you for any help! -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-4021) Adding columns filtering fields in form widget
Adding columns filtering fields in form widget -- Key: OFBIZ-4021 URL: https://issues.apache.org/jira/browse/OFBIZ-4021 Project: OFBiz Issue Type: New Feature Components: framework Reporter: Bruno Busco Priority: Minor This patch includes an initial implementation of a list-form column filtering feature. The aim is to add the possibility to configure a list form to show, in its header, some fields that could be used to filter the rows displayed in the form. This is a feature quite standard in many systems and could be seen into OFBiz as a quick search; the standard way of searching using a complete single-type form could be seen as an advanced search. Please find attached to this JIRA two screenshots that show you how the filtering option appears on the screen. *How the user uses this feature* The part of the screen that is normally used for the pagination controls (only the upper one) has been extended so that two icons are shown on the left. The first one (a funnel) is used to show or hide the filtering fields. The second one (a magnifing glass) is used to run the search with the filter content. *How the developer uses this feature* The filtering feature can be enabled on any list-type form specifying the filter-form-name attribute. This must be the name of a form that contains the details about how the filtering fields should be rendered. When a list form with the filter-form-name option set is rendered, any column field is searched for in the filter-form. If a field with the same name is found, its field rendering options are used to render the filter field. A new field attribute filter-field has also been added. This defaults to true but if it is set to false the filter field is not rendered for this column, even if a field with the same name is present in the filter-form. This feature allows to use as filter-form an already existent form such as a regular FindXXX form. In the patch the ListExample form has been changed to use this feature. You can check it there. Unfortunately the patch does not work yet 100% but I hope that if someone finds it interesting could help me. *What is there still to do* 1) There is a FIXME in MacroFormRenderer.java file. I cannot make it work. If I enable the code that is commented there I get an error when a search is run. 2) I cannot make the filtering fields show the actual content after a search is run. They are always rendered as empty. 3) The filter row hide/show status should be saved so that it is maintained after a pagination. I submit this patch as it is becouse I cannot easily improve it further but I hope someone could help. The img_for_tamahawk.zip file includes imgs that should be added in the tomahawk images folder to make the patch work. Thank you for any help! -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-4021) Adding columns filtering fields in form widget
[ https://issues.apache.org/jira/browse/OFBIZ-4021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-4021: --- Attachment: column_filter_enabled.JPG column_filter_disabled.JPG FilterForm.patch Adding columns filtering fields in form widget -- Key: OFBIZ-4021 URL: https://issues.apache.org/jira/browse/OFBIZ-4021 Project: OFBiz Issue Type: New Feature Components: framework Reporter: Bruno Busco Priority: Minor Attachments: column_filter_disabled.JPG, column_filter_enabled.JPG, FilterForm.patch This patch includes an initial implementation of a list-form column filtering feature. The aim is to add the possibility to configure a list form to show, in its header, some fields that could be used to filter the rows displayed in the form. This is a feature quite standard in many systems and could be seen into OFBiz as a quick search; the standard way of searching using a complete single-type form could be seen as an advanced search. Please find attached to this JIRA two screenshots that show you how the filtering option appears on the screen. *How the user uses this feature* The part of the screen that is normally used for the pagination controls (only the upper one) has been extended so that two icons are shown on the left. The first one (a funnel) is used to show or hide the filtering fields. The second one (a magnifing glass) is used to run the search with the filter content. *How the developer uses this feature* The filtering feature can be enabled on any list-type form specifying the filter-form-name attribute. This must be the name of a form that contains the details about how the filtering fields should be rendered. When a list form with the filter-form-name option set is rendered, any column field is searched for in the filter-form. If a field with the same name is found, its field rendering options are used to render the filter field. A new field attribute filter-field has also been added. This defaults to true but if it is set to false the filter field is not rendered for this column, even if a field with the same name is present in the filter-form. This feature allows to use as filter-form an already existent form such as a regular FindXXX form. In the patch the ListExample form has been changed to use this feature. You can check it there. Unfortunately the patch does not work yet 100% but I hope that if someone finds it interesting could help me. *What is there still to do* 1) There is a FIXME in MacroFormRenderer.java file. I cannot make it work. If I enable the code that is commented there I get an error when a search is run. 2) I cannot make the filtering fields show the actual content after a search is run. They are always rendered as empty. 3) The filter row hide/show status should be saved so that it is maintained after a pagination. I submit this patch as it is becouse I cannot easily improve it further but I hope someone could help. The img_for_tamahawk.zip file includes imgs that should be added in the tomahawk images folder to make the patch work. Thank you for any help! -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-4021) Adding columns filtering fields in form widget
[ https://issues.apache.org/jira/browse/OFBIZ-4021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-4021: --- Attachment: img_for_tomahawk.zip Adding columns filtering fields in form widget -- Key: OFBIZ-4021 URL: https://issues.apache.org/jira/browse/OFBIZ-4021 Project: OFBiz Issue Type: New Feature Components: framework Reporter: Bruno Busco Priority: Minor Attachments: column_filter_disabled.JPG, column_filter_enabled.JPG, FilterForm.patch, img_for_tomahawk.zip This patch includes an initial implementation of a list-form column filtering feature. The aim is to add the possibility to configure a list form to show, in its header, some fields that could be used to filter the rows displayed in the form. This is a feature quite standard in many systems and could be seen into OFBiz as a quick search; the standard way of searching using a complete single-type form could be seen as an advanced search. Please find attached to this JIRA two screenshots that show you how the filtering option appears on the screen. *How the user uses this feature* The part of the screen that is normally used for the pagination controls (only the upper one) has been extended so that two icons are shown on the left. The first one (a funnel) is used to show or hide the filtering fields. The second one (a magnifing glass) is used to run the search with the filter content. *How the developer uses this feature* The filtering feature can be enabled on any list-type form specifying the filter-form-name attribute. This must be the name of a form that contains the details about how the filtering fields should be rendered. When a list form with the filter-form-name option set is rendered, any column field is searched for in the filter-form. If a field with the same name is found, its field rendering options are used to render the filter field. A new field attribute filter-field has also been added. This defaults to true but if it is set to false the filter field is not rendered for this column, even if a field with the same name is present in the filter-form. This feature allows to use as filter-form an already existent form such as a regular FindXXX form. In the patch the ListExample form has been changed to use this feature. You can check it there. Unfortunately the patch does not work yet 100% but I hope that if someone finds it interesting could help me. *What is there still to do* 1) There is a FIXME in MacroFormRenderer.java file. I cannot make it work. If I enable the code that is commented there I get an error when a search is run. 2) I cannot make the filtering fields show the actual content after a search is run. They are always rendered as empty. 3) The filter row hide/show status should be saved so that it is maintained after a pagination. I submit this patch as it is becouse I cannot easily improve it further but I hope someone could help. The img_for_tamahawk.zip file includes imgs that should be added in the tomahawk images folder to make the patch work. Thank you for any help! -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4021) Adding columns filtering fields in form widget
[ https://issues.apache.org/jira/browse/OFBIZ-4021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12933087#action_12933087 ] Bruno Busco commented on OFBIZ-4021: When I include the FIXME code MacroFormRenderer.java like this: public void renderFormFilterRowOpen(Appendable writer, MapString, Object context, ModelForm modelForm) throws IOException { String formName = modelForm.getCurrentFormName(context); String targetType = modelForm.getFilterForm().getTargetType(); String targ = modelForm.getFilterForm().getTarget(context, targetType); StringBuilder linkUrl = new StringBuilder(); if (UtilValidate.isNotEmpty(targ)) { WidgetWorker.buildHyperlinkUrl(linkUrl, targ, targetType, null, null, false, false, true, request, response, context); } StringWriter sr = new StringWriter(); sr.append(@renderFormFilterRowOpen ); sr.append( formName=\); sr.append(formName); sr.append(\ linkUrl=\); sr.append(linkUrl); sr.append(\ /); executeMacro(writer, sr.toString()); } I get this error in the log. exception report -- Error in request handler: Exception: org.ofbiz.widget.screen.ScreenRenderException Message: Error rendering screen [component://common/widget/CommonScreens.xml#FindScreenDecorator]: java.lang.IllegalArgumentException: Error evaluating BeanShell style conditions on form ListExamples (Error evaluating BeanShell style conditions on form ListExamples) cause - Exception: java.lang.IllegalArgumentException Message: Error evaluating BeanShell style conditions on form ListExamples stack trace --- java.lang.IllegalArgumentException: Error evaluating BeanShell style conditions on form ListExamples org.ofbiz.widget.form.ModelForm.getStyleAltRowStyle(ModelForm.java:2775) org.ofbiz.widget.form.MacroFormRenderer.renderFormatItemRowOpen(MacroFormRenderer.java:1616) org.ofbiz.widget.form.ModelForm.renderItemRow(ModelForm.java:1696) org.ofbiz.widget.form.ModelForm.renderItemRows(ModelForm.java:1660) org.ofbiz.widget.form.ModelForm.renderListFormString(ModelForm.java:1139) org.ofbiz.widget.form.ModelForm.renderFormString(ModelForm.java:873) org.ofbiz.widget.screen.ModelScreenWidget$Form.renderWidgetString(ModelScreenWidget.java:753) org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:104) org.ofbiz.widget.screen.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:613) org.ofbiz.widget.screen.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:129) org.ofbiz.widget.screen.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:646) org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:104) org.ofbiz.widget.screen.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:260) org.ofbiz.widget.screen.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:652) org.ofbiz.widget.screen.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:373) Adding columns filtering fields in form widget -- Key: OFBIZ-4021 URL: https://issues.apache.org/jira/browse/OFBIZ-4021 Project: OFBiz Issue Type: New Feature Components: framework Reporter: Bruno Busco Priority: Minor Attachments: column_filter_disabled.JPG, column_filter_enabled.JPG, FilterForm.patch, img_for_tomahawk.zip This patch includes an initial implementation of a list-form column filtering feature. The aim is to add the possibility to configure a list form to show, in its header, some fields that could be used to filter the rows displayed in the form. This is a feature quite standard in many systems and could be seen into OFBiz as a quick search; the standard way of searching using a complete single-type form could be seen as an advanced search. Please find attached to this JIRA two screenshots that show you how the filtering option appears on the screen. *How the user uses this feature* The part of the screen that is normally used for the pagination controls (only the upper one) has been extended so that two icons are shown on the left. The first one (a funnel) is used to show or hide the filtering fields. The second one (a magnifing glass) is used to run the search with the filter content. *How the developer uses this feature* The filtering feature can be enabled on any list-type form specifying the filter-form-name attribute. This must be the name of a form that contains the details about how
[jira] Closed: (OFBIZ-4005) Buttons are too short in tomhawak with long text
[ https://issues.apache.org/jira/browse/OFBIZ-4005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco closed OFBIZ-4005. -- Resolution: Fixed Fixed in trunk at revision 1029792 and in release 10.04 branch at revision 1029794 Thank you Jacques and Erwan for reporting Buttons are too short in tomhawak with long text Key: OFBIZ-4005 URL: https://issues.apache.org/jira/browse/OFBIZ-4005 Project: OFBiz Issue Type: Sub-task Components: themes Affects Versions: Release Branch 10.04, SVN trunk Reporter: Erwan de FERRIERES Assignee: Bruno Busco Fix For: Release Branch 10.04, SVN trunk Attachments: create_en.png, create_fr.png When using styles on the buttons, like create, with the tomahawk theme, and a long text (sometimes in French), the text is too long. The button should resize itself automatically to be always under the text. Please see the attached screenshots. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-4002) Background of app-navigation (breadcrumbs of backend) isn't right
[ https://issues.apache.org/jira/browse/OFBIZ-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco closed OFBIZ-4002. -- Resolution: Fixed Hi David, your patch is in release 10.04 branch at rev. 1027744. No need to commit also in jquery because Jacques regularly merges the trunk to the jquery branch. Your patch has been created against a repository that was at revision 65 that is for sure not the ASF one. Background of app-navigation (breadcrumbs of backend) isn't right --- Key: OFBIZ-4002 URL: https://issues.apache.org/jira/browse/OFBIZ-4002 Project: OFBiz Issue Type: Bug Components: themes Affects Versions: Release Branch 10.04, jQuery, SVN trunk Environment: ALL Reporter: David - DiSiD Technologies Assignee: Bruno Busco Priority: Minor Attachments: OFBIZ-4002.patch, OFBIZ-4002_withoutRightBG.jpg, OFBIZ-4002_withRightBG.jpg Original Estimate: 0.5h Remaining Estimate: 0.5h The background of 'app-navigation' (that is, a component in the breadcrumbs of backend) doesn't display the arrow indicating that have sections. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-4002) Background of app-navigation (breadcrumbs of backend) isn't right
[ https://issues.apache.org/jira/browse/OFBIZ-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco reassigned OFBIZ-4002: -- Assignee: Bruno Busco Background of app-navigation (breadcrumbs of backend) isn't right --- Key: OFBIZ-4002 URL: https://issues.apache.org/jira/browse/OFBIZ-4002 Project: OFBiz Issue Type: Bug Components: themes Affects Versions: Release Branch 10.04, jQuery, SVN trunk Environment: ALL Reporter: David - DiSiD Technologies Assignee: Bruno Busco Priority: Minor Fix For: Release Branch 10.04, jQuery, SVN trunk Attachments: OFBIZ-4002.patch, OFBIZ-4002_withoutRightBG.jpg, OFBIZ-4002_withRightBG.jpg Original Estimate: 0.5h Remaining Estimate: 0.5h The background of 'app-navigation' (that is, a component in the breadcrumbs of backend) doesn't display the arrow indicating that have sections. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-4002) Background of app-navigation (breadcrumbs of backend) isn't right
[ https://issues.apache.org/jira/browse/OFBIZ-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco closed OFBIZ-4002. -- Resolution: Fixed Fix Version/s: (was: jQuery) (was: Release Branch 10.04) (was: SVN trunk) Thank you David, your patch is in trunk at revision 1027267. BTW I think your patch was created against a your local SVN repository. For future patches please be sure to work on a directory that has been checked out from the apache SVN repository. Background of app-navigation (breadcrumbs of backend) isn't right --- Key: OFBIZ-4002 URL: https://issues.apache.org/jira/browse/OFBIZ-4002 Project: OFBiz Issue Type: Bug Components: themes Affects Versions: Release Branch 10.04, jQuery, SVN trunk Environment: ALL Reporter: David - DiSiD Technologies Assignee: Bruno Busco Priority: Minor Attachments: OFBIZ-4002.patch, OFBIZ-4002_withoutRightBG.jpg, OFBIZ-4002_withRightBG.jpg Original Estimate: 0.5h Remaining Estimate: 0.5h The background of 'app-navigation' (that is, a component in the breadcrumbs of backend) doesn't display the arrow indicating that have sections. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3981) List form using jquery
[ https://issues.apache.org/jira/browse/OFBIZ-3981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12918838#action_12918838 ] Bruno Busco commented on OFBIZ-3981: IMO this is not a 100% jquery task. I mean: - For #1 and #3 we should use UserPreferences to make those settings persistent for each user. - For #4 we generally need to export all records and not the current page only. This means that a proper request must be done to the server. No much jquery involved here but a standard exporting icon embedded in the form widget would be nice. - #2 what do you mean for this? List form using jquery -- Key: OFBIZ-3981 URL: https://issues.apache.org/jira/browse/OFBIZ-3981 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: jQuery Reporter: Michael Xu Fix For: jQuery Replace/enhance current list form with jquery table, which allow users to: # show/hide any columns # group by any column # change the position of columns by dragdrop # export table to csv/excel -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3981) List form using jquery
[ https://issues.apache.org/jira/browse/OFBIZ-3981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12918869#action_12918869 ] Bruno Busco commented on OFBIZ-3981: Hi Michael, for #1 and #3 I understand what you mean and I agree. The UserPreferences should be used so that in a user hides column A, shows column F and then leaves the application, these settings are automatically retrieved whenever he gets back to that form. for #2, may be you mean this: http://dev.sencha.com/deploy/dev/examples/grid/grouping.html OK than List form using jquery -- Key: OFBIZ-3981 URL: https://issues.apache.org/jira/browse/OFBIZ-3981 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: jQuery Reporter: Michael Xu Fix For: jQuery Replace/enhance current list form with jquery table, which allow users to: # show/hide any columns # group by any column # change the position of columns by dragdrop # export table to csv/excel -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3981) List form using jquery
[ https://issues.apache.org/jira/browse/OFBIZ-3981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12919056#action_12919056 ] Bruno Busco commented on OFBIZ-3981: This http://www.flexigrid.info/ is a jquery based library that implements forms with server-side pagination, column resizing etc. List form using jquery -- Key: OFBIZ-3981 URL: https://issues.apache.org/jira/browse/OFBIZ-3981 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: jQuery Reporter: Michael Xu Fix For: jQuery Replace/enhance current list form with jquery table, which allow users to: # show/hide any columns # group by any column # change the position of columns by dragdrop # export table to csv/excel -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3981) List form using jquery
[ https://issues.apache.org/jira/browse/OFBIZ-3981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12919149#action_12919149 ] Bruno Busco commented on OFBIZ-3981: This was only a first result of a search for something that was based on jquery. Never used. Yes we definitively need to exchange more before starting using anything. List form using jquery -- Key: OFBIZ-3981 URL: https://issues.apache.org/jira/browse/OFBIZ-3981 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: jQuery Reporter: Michael Xu Fix For: jQuery Replace/enhance current list form with jquery table, which allow users to: # show/hide any columns # group by any column # change the position of columns by dragdrop # export table to csv/excel -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3814) jQuery Implementtion - Umbrella Main Task
[ https://issues.apache.org/jira/browse/OFBIZ-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12918787#action_12918787 ] Bruno Busco commented on OFBIZ-3814: Michael, I think those form features would be very interesting to have in OFBiz. Thank you for any effort you would provide on this topic. jQuery Implementtion - Umbrella Main Task - Key: OFBIZ-3814 URL: https://issues.apache.org/jira/browse/OFBIZ-3814 Project: OFBiz Issue Type: New Feature Components: ALL COMPONENTS Reporter: Sascha Rodekamp Assignee: Erwan de FERRIERES Fix For: jQuery This task is to group the related sub-tasks. We plan to replace all prototype/ dojo based javascript Code with jQuery based code. For this task a special development branch exists: jquery. It will be merged into the trunk after all problems/issue are solved. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Reopened: (OFBIZ-3027) view-last-noparam
[ https://issues.apache.org/jira/browse/OFBIZ-3027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco reopened OFBIZ-3027: Hi, it seems that the view-last-noparam just works (resets the parameters) if it is used with a request that has the parameters in the URL. Since we have now moved to form submitted parameters I found that the view-last-noparam is not able to remove the parameters from the context. Does anyone have any idea of how to fix this? view-last-noparam - Key: OFBIZ-3027 URL: https://issues.apache.org/jira/browse/OFBIZ-3027 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Matarazzo Angelo Assignee: Jacques Le Roux Fix For: SVN trunk Attachments: view-last-noparam.patch I have created another response attribute view-last-noparam that has functionality of view-last but without last parameters like request-redirect-noparam. Could it be useful? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3625) Adding a portal-page widget
[ https://issues.apache.org/jira/browse/OFBIZ-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910922#action_12910922 ] Bruno Busco commented on OFBIZ-3625: Hi Nicolas, thank you for your review. Creating a portalPage widget was something David suggested from the beginning of the portlet system design. And now time has come! ;-) I have stepped further with this implementation but I did not find the time to update the patch. Unfortunately the portlet system has been complicated in the last time introducing elements with a bad design (IMO). For example a lot of duplicated requests has been added and a strange paginate-target=AddPortlet${Adm} pattern has been used. The correct way for doing this would have been IMO using the alt-target tag. This is requesting a bigger effort to finish my task. Adding a portal-page widget --- Key: OFBIZ-3625 URL: https://issues.apache.org/jira/browse/OFBIZ-3625 Project: OFBiz Issue Type: New Feature Components: framework Reporter: Bruno Busco Attachments: ofbiz.log, portalPageWidget.patch, portalPageWidget.patch, portalPageWidget.patch, portalPageWidget.patch Hi, sometime ago we discussed about the opportunity to have the portalPage implemented as a widget. This would allow a greater integration of the portal/portlet system in every OFBiz screen. I have done some work on it following how other widgets have been implemented. I am not a java expert and I have difficulties to step further. I would like you java gurus to give a look to it and please help in finalizing it. With the actual patch a portal-page id=EXAMPLE / is added at the bottom of the https://localhost:8443/example/control/FindExample page. This is only a test page. From the error I get it seems that it is not possible to render the following ftl in the htmlScreenMacroLibrary.ftl - #if screenName?has_content #assign portletFields = 'input name=portalPageId value=' + portalPageId + ' type=hidden/input name=portalPortletId value=' + portalPortletId + ' type=hidden/input name=portletSeqId value=' + portletSeqId + ' type=hidden/' form method=post action=movePortletToPortalPage name=movePP_${portletIndex}${portletFields}input name=newPortalPageId value=${portalPageId} type=hidden//form div id=${portletIndex} name=portalPortlet class=noClass ${setRequestAttribute(portalPageId, portalPageId)} ${setRequestAttribute(portalPortletId, portalPortletId)} ${setRequestAttribute(portletSeqId, portletSeqId)} ${screens.render(screenLocation, screenName)} ${screens.setRenderFormUniqueSeq(portletIndex)} /div #-- DragNDrop is only activated, when the portal Page isn't the Default page -- #if originalPortalPageId?has_contentscriptsetMousePointer(${portletIndex})/script/#if #if originalPortalPageId?has_contentscript type=text/javascriptmakeDragable(${portletIndex});/script/#if #if originalPortalPageId?has_contentscript type=text/javascriptmakeDroppable(${portletIndex});/script/#if form method=post action=@ofbizUrlupdatePortalPagePortletAjax/@ofbizUrl name=freeMove_${portletIndex}${portletFields}input name=columnSeqId value=${columnSeqId} type=hidden/input name=mode value=RIGHT type=hidden//form /#if - Thank you for any collaboration to step this to the trunk. -Bruno -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3625) Adding a portal-page widget
[ https://issues.apache.org/jira/browse/OFBIZ-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12911067#action_12911067 ] Bruno Busco commented on OFBIZ-3625: Thank you Jacques. I have removed them. Adding a portal-page widget --- Key: OFBIZ-3625 URL: https://issues.apache.org/jira/browse/OFBIZ-3625 Project: OFBiz Issue Type: New Feature Components: framework Reporter: Bruno Busco Attachments: ofbiz.log, portalPageWidget.patch, portalPageWidget.patch, portalPageWidget.patch, portalPageWidget.patch Hi, sometime ago we discussed about the opportunity to have the portalPage implemented as a widget. This would allow a greater integration of the portal/portlet system in every OFBiz screen. I have done some work on it following how other widgets have been implemented. I am not a java expert and I have difficulties to step further. I would like you java gurus to give a look to it and please help in finalizing it. With the actual patch a portal-page id=EXAMPLE / is added at the bottom of the https://localhost:8443/example/control/FindExample page. This is only a test page. From the error I get it seems that it is not possible to render the following ftl in the htmlScreenMacroLibrary.ftl - #if screenName?has_content #assign portletFields = 'input name=portalPageId value=' + portalPageId + ' type=hidden/input name=portalPortletId value=' + portalPortletId + ' type=hidden/input name=portletSeqId value=' + portletSeqId + ' type=hidden/' form method=post action=movePortletToPortalPage name=movePP_${portletIndex}${portletFields}input name=newPortalPageId value=${portalPageId} type=hidden//form div id=${portletIndex} name=portalPortlet class=noClass ${setRequestAttribute(portalPageId, portalPageId)} ${setRequestAttribute(portalPortletId, portalPortletId)} ${setRequestAttribute(portletSeqId, portletSeqId)} ${screens.render(screenLocation, screenName)} ${screens.setRenderFormUniqueSeq(portletIndex)} /div #-- DragNDrop is only activated, when the portal Page isn't the Default page -- #if originalPortalPageId?has_contentscriptsetMousePointer(${portletIndex})/script/#if #if originalPortalPageId?has_contentscript type=text/javascriptmakeDragable(${portletIndex});/script/#if #if originalPortalPageId?has_contentscript type=text/javascriptmakeDroppable(${portletIndex});/script/#if form method=post action=@ofbizUrlupdatePortalPagePortletAjax/@ofbizUrl name=freeMove_${portletIndex}${portletFields}input name=columnSeqId value=${columnSeqId} type=hidden/input name=mode value=RIGHT type=hidden//form /#if - Thank you for any collaboration to step this to the trunk. -Bruno -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3625) Adding a portal-page widget
[ https://issues.apache.org/jira/browse/OFBIZ-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco closed OFBIZ-3625. -- Resolution: Fixed Committed in trunk at revision 998570 Adding a portal-page widget --- Key: OFBIZ-3625 URL: https://issues.apache.org/jira/browse/OFBIZ-3625 Project: OFBiz Issue Type: New Feature Components: framework Reporter: Bruno Busco Attachments: ofbiz.log, portalPageWidget.patch, portalPageWidget.patch, portalPageWidget.patch, portalPageWidget.patch Hi, sometime ago we discussed about the opportunity to have the portalPage implemented as a widget. This would allow a greater integration of the portal/portlet system in every OFBiz screen. I have done some work on it following how other widgets have been implemented. I am not a java expert and I have difficulties to step further. I would like you java gurus to give a look to it and please help in finalizing it. With the actual patch a portal-page id=EXAMPLE / is added at the bottom of the https://localhost:8443/example/control/FindExample page. This is only a test page. From the error I get it seems that it is not possible to render the following ftl in the htmlScreenMacroLibrary.ftl - #if screenName?has_content #assign portletFields = 'input name=portalPageId value=' + portalPageId + ' type=hidden/input name=portalPortletId value=' + portalPortletId + ' type=hidden/input name=portletSeqId value=' + portletSeqId + ' type=hidden/' form method=post action=movePortletToPortalPage name=movePP_${portletIndex}${portletFields}input name=newPortalPageId value=${portalPageId} type=hidden//form div id=${portletIndex} name=portalPortlet class=noClass ${setRequestAttribute(portalPageId, portalPageId)} ${setRequestAttribute(portalPortletId, portalPortletId)} ${setRequestAttribute(portletSeqId, portletSeqId)} ${screens.render(screenLocation, screenName)} ${screens.setRenderFormUniqueSeq(portletIndex)} /div #-- DragNDrop is only activated, when the portal Page isn't the Default page -- #if originalPortalPageId?has_contentscriptsetMousePointer(${portletIndex})/script/#if #if originalPortalPageId?has_contentscript type=text/javascriptmakeDragable(${portletIndex});/script/#if #if originalPortalPageId?has_contentscript type=text/javascriptmakeDroppable(${portletIndex});/script/#if form method=post action=@ofbizUrlupdatePortalPagePortletAjax/@ofbizUrl name=freeMove_${portletIndex}${portletFields}input name=columnSeqId value=${columnSeqId} type=hidden/input name=mode value=RIGHT type=hidden//form /#if - Thank you for any collaboration to step this to the trunk. -Bruno -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3625) Adding a portal-page widget
[ https://issues.apache.org/jira/browse/OFBIZ-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910465#action_12910465 ] Bruno Busco commented on OFBIZ-3625: Hi guys, I think I will commit this patch during this week end. Please, comment if you have something against it. Thank you, Bruno Adding a portal-page widget --- Key: OFBIZ-3625 URL: https://issues.apache.org/jira/browse/OFBIZ-3625 Project: OFBiz Issue Type: New Feature Components: framework Reporter: Bruno Busco Attachments: ofbiz.log, portalPageWidget.patch, portalPageWidget.patch, portalPageWidget.patch, portalPageWidget.patch Hi, sometime ago we discussed about the opportunity to have the portalPage implemented as a widget. This would allow a greater integration of the portal/portlet system in every OFBiz screen. I have done some work on it following how other widgets have been implemented. I am not a java expert and I have difficulties to step further. I would like you java gurus to give a look to it and please help in finalizing it. With the actual patch a portal-page id=EXAMPLE / is added at the bottom of the https://localhost:8443/example/control/FindExample page. This is only a test page. From the error I get it seems that it is not possible to render the following ftl in the htmlScreenMacroLibrary.ftl - #if screenName?has_content #assign portletFields = 'input name=portalPageId value=' + portalPageId + ' type=hidden/input name=portalPortletId value=' + portalPortletId + ' type=hidden/input name=portletSeqId value=' + portletSeqId + ' type=hidden/' form method=post action=movePortletToPortalPage name=movePP_${portletIndex}${portletFields}input name=newPortalPageId value=${portalPageId} type=hidden//form div id=${portletIndex} name=portalPortlet class=noClass ${setRequestAttribute(portalPageId, portalPageId)} ${setRequestAttribute(portalPortletId, portalPortletId)} ${setRequestAttribute(portletSeqId, portletSeqId)} ${screens.render(screenLocation, screenName)} ${screens.setRenderFormUniqueSeq(portletIndex)} /div #-- DragNDrop is only activated, when the portal Page isn't the Default page -- #if originalPortalPageId?has_contentscriptsetMousePointer(${portletIndex})/script/#if #if originalPortalPageId?has_contentscript type=text/javascriptmakeDragable(${portletIndex});/script/#if #if originalPortalPageId?has_contentscript type=text/javascriptmakeDroppable(${portletIndex});/script/#if form method=post action=@ofbizUrlupdatePortalPagePortletAjax/@ofbizUrl name=freeMove_${portletIndex}${portletFields}input name=columnSeqId value=${columnSeqId} type=hidden/input name=mode value=RIGHT type=hidden//form /#if - Thank you for any collaboration to step this to the trunk. -Bruno -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3625) Adding a portal-page widget
[ https://issues.apache.org/jira/browse/OFBIZ-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-3625: --- Attachment: portalPageWidget.patch Hi guys, I got it. Now the patch works on the latest trunk. Could you please review so that if there are not objections I can commit? Once committed we could slightly move all Portals from the showPortalPage.ftl method to the include-portla-page one. I have added a menu item in the example menu that simply call a screen where a PortalPage is rendered using the include-portal-page. Thank you, Bruno Adding a portal-page widget --- Key: OFBIZ-3625 URL: https://issues.apache.org/jira/browse/OFBIZ-3625 Project: OFBiz Issue Type: New Feature Components: framework Reporter: Bruno Busco Attachments: ofbiz.log, portalPageWidget.patch, portalPageWidget.patch, portalPageWidget.patch Hi, sometime ago we discussed about the opportunity to have the portalPage implemented as a widget. This would allow a greater integration of the portal/portlet system in every OFBiz screen. I have done some work on it following how other widgets have been implemented. I am not a java expert and I have difficulties to step further. I would like you java gurus to give a look to it and please help in finalizing it. With the actual patch a portal-page id=EXAMPLE / is added at the bottom of the https://localhost:8443/example/control/FindExample page. This is only a test page. From the error I get it seems that it is not possible to render the following ftl in the htmlScreenMacroLibrary.ftl - #if screenName?has_content #assign portletFields = 'input name=portalPageId value=' + portalPageId + ' type=hidden/input name=portalPortletId value=' + portalPortletId + ' type=hidden/input name=portletSeqId value=' + portletSeqId + ' type=hidden/' form method=post action=movePortletToPortalPage name=movePP_${portletIndex}${portletFields}input name=newPortalPageId value=${portalPageId} type=hidden//form div id=${portletIndex} name=portalPortlet class=noClass ${setRequestAttribute(portalPageId, portalPageId)} ${setRequestAttribute(portalPortletId, portalPortletId)} ${setRequestAttribute(portletSeqId, portletSeqId)} ${screens.render(screenLocation, screenName)} ${screens.setRenderFormUniqueSeq(portletIndex)} /div #-- DragNDrop is only activated, when the portal Page isn't the Default page -- #if originalPortalPageId?has_contentscriptsetMousePointer(${portletIndex})/script/#if #if originalPortalPageId?has_contentscript type=text/javascriptmakeDragable(${portletIndex});/script/#if #if originalPortalPageId?has_contentscript type=text/javascriptmakeDroppable(${portletIndex});/script/#if form method=post action=@ofbizUrlupdatePortalPagePortletAjax/@ofbizUrl name=freeMove_${portletIndex}${portletFields}input name=columnSeqId value=${columnSeqId} type=hidden/input name=mode value=RIGHT type=hidden//form /#if - Thank you for any collaboration to step this to the trunk. -Bruno -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3625) Adding a portal-page widget
[ https://issues.apache.org/jira/browse/OFBIZ-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-3625: --- Attachment: portalPageWidget.patch Patch improved. - Added missing portlets sorting to have the correct portlet sequence in the column - Fixed the column width markup rendering - Rewritten the Catalog and SFA main screens using the include-portal-page widget. Each one of those screens are now PortalPages. All the included screens have been deined as portlets and included in the PortalPages so that the main screens look as the original one. Adding a portal-page widget --- Key: OFBIZ-3625 URL: https://issues.apache.org/jira/browse/OFBIZ-3625 Project: OFBiz Issue Type: New Feature Components: framework Reporter: Bruno Busco Attachments: ofbiz.log, portalPageWidget.patch, portalPageWidget.patch, portalPageWidget.patch, portalPageWidget.patch Hi, sometime ago we discussed about the opportunity to have the portalPage implemented as a widget. This would allow a greater integration of the portal/portlet system in every OFBiz screen. I have done some work on it following how other widgets have been implemented. I am not a java expert and I have difficulties to step further. I would like you java gurus to give a look to it and please help in finalizing it. With the actual patch a portal-page id=EXAMPLE / is added at the bottom of the https://localhost:8443/example/control/FindExample page. This is only a test page. From the error I get it seems that it is not possible to render the following ftl in the htmlScreenMacroLibrary.ftl - #if screenName?has_content #assign portletFields = 'input name=portalPageId value=' + portalPageId + ' type=hidden/input name=portalPortletId value=' + portalPortletId + ' type=hidden/input name=portletSeqId value=' + portletSeqId + ' type=hidden/' form method=post action=movePortletToPortalPage name=movePP_${portletIndex}${portletFields}input name=newPortalPageId value=${portalPageId} type=hidden//form div id=${portletIndex} name=portalPortlet class=noClass ${setRequestAttribute(portalPageId, portalPageId)} ${setRequestAttribute(portalPortletId, portalPortletId)} ${setRequestAttribute(portletSeqId, portletSeqId)} ${screens.render(screenLocation, screenName)} ${screens.setRenderFormUniqueSeq(portletIndex)} /div #-- DragNDrop is only activated, when the portal Page isn't the Default page -- #if originalPortalPageId?has_contentscriptsetMousePointer(${portletIndex})/script/#if #if originalPortalPageId?has_contentscript type=text/javascriptmakeDragable(${portletIndex});/script/#if #if originalPortalPageId?has_contentscript type=text/javascriptmakeDroppable(${portletIndex});/script/#if form method=post action=@ofbizUrlupdatePortalPagePortletAjax/@ofbizUrl name=freeMove_${portletIndex}${portletFields}input name=columnSeqId value=${columnSeqId} type=hidden/input name=mode value=RIGHT type=hidden//form /#if - Thank you for any collaboration to step this to the trunk. -Bruno -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3625) Adding a portal-page widget
[ https://issues.apache.org/jira/browse/OFBIZ-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12908617#action_12908617 ] Bruno Busco commented on OFBIZ-3625: Hi Hans, the patch does not touch the actual portlet system but adds a new include-portal-page tag that can be used. Once committed we will eliminate redundant code and move definitively to the new pattern. Adding a portal-page widget --- Key: OFBIZ-3625 URL: https://issues.apache.org/jira/browse/OFBIZ-3625 Project: OFBiz Issue Type: New Feature Components: framework Reporter: Bruno Busco Attachments: ofbiz.log, portalPageWidget.patch, portalPageWidget.patch, portalPageWidget.patch, portalPageWidget.patch Hi, sometime ago we discussed about the opportunity to have the portalPage implemented as a widget. This would allow a greater integration of the portal/portlet system in every OFBiz screen. I have done some work on it following how other widgets have been implemented. I am not a java expert and I have difficulties to step further. I would like you java gurus to give a look to it and please help in finalizing it. With the actual patch a portal-page id=EXAMPLE / is added at the bottom of the https://localhost:8443/example/control/FindExample page. This is only a test page. From the error I get it seems that it is not possible to render the following ftl in the htmlScreenMacroLibrary.ftl - #if screenName?has_content #assign portletFields = 'input name=portalPageId value=' + portalPageId + ' type=hidden/input name=portalPortletId value=' + portalPortletId + ' type=hidden/input name=portletSeqId value=' + portletSeqId + ' type=hidden/' form method=post action=movePortletToPortalPage name=movePP_${portletIndex}${portletFields}input name=newPortalPageId value=${portalPageId} type=hidden//form div id=${portletIndex} name=portalPortlet class=noClass ${setRequestAttribute(portalPageId, portalPageId)} ${setRequestAttribute(portalPortletId, portalPortletId)} ${setRequestAttribute(portletSeqId, portletSeqId)} ${screens.render(screenLocation, screenName)} ${screens.setRenderFormUniqueSeq(portletIndex)} /div #-- DragNDrop is only activated, when the portal Page isn't the Default page -- #if originalPortalPageId?has_contentscriptsetMousePointer(${portletIndex})/script/#if #if originalPortalPageId?has_contentscript type=text/javascriptmakeDragable(${portletIndex});/script/#if #if originalPortalPageId?has_contentscript type=text/javascriptmakeDroppable(${portletIndex});/script/#if form method=post action=@ofbizUrlupdatePortalPagePortletAjax/@ofbizUrl name=freeMove_${portletIndex}${portletFields}input name=columnSeqId value=${columnSeqId} type=hidden/input name=mode value=RIGHT type=hidden//form /#if - Thank you for any collaboration to step this to the trunk. -Bruno -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3625) Adding a portal-page widget
[ https://issues.apache.org/jira/browse/OFBIZ-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-3625: --- Attachment: portalPageWidget.patch Hi, I have completed the implementation but still need help :-( In the updated patch there is the implementation of a include-portal-page widget. This can be used as: include-portal-page id=PartyProfile/ so that a PortalPage can be simply added in any screen. At a later stage the following syntax will also be available: include-portal-page id=PartyProfile edit-mode=true/ So that the Portal page will show all controls to be edited. The patch is working if applied in trunk rev. 935330 (where I developed it) but when I tryed to update to the latest trunk I was not able to manage the Widget factory update recently done. Could please someone (Adrian ?) give a look and help? Thank you. Adding a portal-page widget --- Key: OFBIZ-3625 URL: https://issues.apache.org/jira/browse/OFBIZ-3625 Project: OFBiz Issue Type: New Feature Components: framework Reporter: Bruno Busco Attachments: ofbiz.log, portalPageWidget.patch, portalPageWidget.patch Hi, sometime ago we discussed about the opportunity to have the portalPage implemented as a widget. This would allow a greater integration of the portal/portlet system in every OFBiz screen. I have done some work on it following how other widgets have been implemented. I am not a java expert and I have difficulties to step further. I would like you java gurus to give a look to it and please help in finalizing it. With the actual patch a portal-page id=EXAMPLE / is added at the bottom of the https://localhost:8443/example/control/FindExample page. This is only a test page. From the error I get it seems that it is not possible to render the following ftl in the htmlScreenMacroLibrary.ftl - #if screenName?has_content #assign portletFields = 'input name=portalPageId value=' + portalPageId + ' type=hidden/input name=portalPortletId value=' + portalPortletId + ' type=hidden/input name=portletSeqId value=' + portletSeqId + ' type=hidden/' form method=post action=movePortletToPortalPage name=movePP_${portletIndex}${portletFields}input name=newPortalPageId value=${portalPageId} type=hidden//form div id=${portletIndex} name=portalPortlet class=noClass ${setRequestAttribute(portalPageId, portalPageId)} ${setRequestAttribute(portalPortletId, portalPortletId)} ${setRequestAttribute(portletSeqId, portletSeqId)} ${screens.render(screenLocation, screenName)} ${screens.setRenderFormUniqueSeq(portletIndex)} /div #-- DragNDrop is only activated, when the portal Page isn't the Default page -- #if originalPortalPageId?has_contentscriptsetMousePointer(${portletIndex})/script/#if #if originalPortalPageId?has_contentscript type=text/javascriptmakeDragable(${portletIndex});/script/#if #if originalPortalPageId?has_contentscript type=text/javascriptmakeDroppable(${portletIndex});/script/#if form method=post action=@ofbizUrlupdatePortalPagePortletAjax/@ofbizUrl name=freeMove_${portletIndex}${portletFields}input name=columnSeqId value=${columnSeqId} type=hidden/input name=mode value=RIGHT type=hidden//form /#if - Thank you for any collaboration to step this to the trunk. -Bruno -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3625) Adding a portal-page widget
[ https://issues.apache.org/jira/browse/OFBIZ-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-3625: --- Attachment: portalPageWidget.patch Missed ASF inclusion licence flag Adding a portal-page widget --- Key: OFBIZ-3625 URL: https://issues.apache.org/jira/browse/OFBIZ-3625 Project: OFBiz Issue Type: New Feature Components: framework Reporter: Bruno Busco Attachments: ofbiz.log, portalPageWidget.patch, portalPageWidget.patch Hi, sometime ago we discussed about the opportunity to have the portalPage implemented as a widget. This would allow a greater integration of the portal/portlet system in every OFBiz screen. I have done some work on it following how other widgets have been implemented. I am not a java expert and I have difficulties to step further. I would like you java gurus to give a look to it and please help in finalizing it. With the actual patch a portal-page id=EXAMPLE / is added at the bottom of the https://localhost:8443/example/control/FindExample page. This is only a test page. From the error I get it seems that it is not possible to render the following ftl in the htmlScreenMacroLibrary.ftl - #if screenName?has_content #assign portletFields = 'input name=portalPageId value=' + portalPageId + ' type=hidden/input name=portalPortletId value=' + portalPortletId + ' type=hidden/input name=portletSeqId value=' + portletSeqId + ' type=hidden/' form method=post action=movePortletToPortalPage name=movePP_${portletIndex}${portletFields}input name=newPortalPageId value=${portalPageId} type=hidden//form div id=${portletIndex} name=portalPortlet class=noClass ${setRequestAttribute(portalPageId, portalPageId)} ${setRequestAttribute(portalPortletId, portalPortletId)} ${setRequestAttribute(portletSeqId, portletSeqId)} ${screens.render(screenLocation, screenName)} ${screens.setRenderFormUniqueSeq(portletIndex)} /div #-- DragNDrop is only activated, when the portal Page isn't the Default page -- #if originalPortalPageId?has_contentscriptsetMousePointer(${portletIndex})/script/#if #if originalPortalPageId?has_contentscript type=text/javascriptmakeDragable(${portletIndex});/script/#if #if originalPortalPageId?has_contentscript type=text/javascriptmakeDroppable(${portletIndex});/script/#if form method=post action=@ofbizUrlupdatePortalPagePortletAjax/@ofbizUrl name=freeMove_${portletIndex}${portletFields}input name=columnSeqId value=${columnSeqId} type=hidden/input name=mode value=RIGHT type=hidden//form /#if - Thank you for any collaboration to step this to the trunk. -Bruno -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3625) Adding a portal-page widget
[ https://issues.apache.org/jira/browse/OFBIZ-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-3625: --- Attachment: (was: portalPageWidget.patch) Adding a portal-page widget --- Key: OFBIZ-3625 URL: https://issues.apache.org/jira/browse/OFBIZ-3625 Project: OFBiz Issue Type: New Feature Components: framework Reporter: Bruno Busco Attachments: ofbiz.log, portalPageWidget.patch, portalPageWidget.patch Hi, sometime ago we discussed about the opportunity to have the portalPage implemented as a widget. This would allow a greater integration of the portal/portlet system in every OFBiz screen. I have done some work on it following how other widgets have been implemented. I am not a java expert and I have difficulties to step further. I would like you java gurus to give a look to it and please help in finalizing it. With the actual patch a portal-page id=EXAMPLE / is added at the bottom of the https://localhost:8443/example/control/FindExample page. This is only a test page. From the error I get it seems that it is not possible to render the following ftl in the htmlScreenMacroLibrary.ftl - #if screenName?has_content #assign portletFields = 'input name=portalPageId value=' + portalPageId + ' type=hidden/input name=portalPortletId value=' + portalPortletId + ' type=hidden/input name=portletSeqId value=' + portletSeqId + ' type=hidden/' form method=post action=movePortletToPortalPage name=movePP_${portletIndex}${portletFields}input name=newPortalPageId value=${portalPageId} type=hidden//form div id=${portletIndex} name=portalPortlet class=noClass ${setRequestAttribute(portalPageId, portalPageId)} ${setRequestAttribute(portalPortletId, portalPortletId)} ${setRequestAttribute(portletSeqId, portletSeqId)} ${screens.render(screenLocation, screenName)} ${screens.setRenderFormUniqueSeq(portletIndex)} /div #-- DragNDrop is only activated, when the portal Page isn't the Default page -- #if originalPortalPageId?has_contentscriptsetMousePointer(${portletIndex})/script/#if #if originalPortalPageId?has_contentscript type=text/javascriptmakeDragable(${portletIndex});/script/#if #if originalPortalPageId?has_contentscript type=text/javascriptmakeDroppable(${portletIndex});/script/#if form method=post action=@ofbizUrlupdatePortalPagePortletAjax/@ofbizUrl name=freeMove_${portletIndex}${portletFields}input name=columnSeqId value=${columnSeqId} type=hidden/input name=mode value=RIGHT type=hidden//form /#if - Thank you for any collaboration to step this to the trunk. -Bruno -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1425) Improve the ModelField.getDescription method
[ https://issues.apache.org/jira/browse/OFBIZ-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12906259#action_12906259 ] Bruno Busco commented on OFBIZ-1425: Hi, it seems that this feature does not allow to add an help string on form field titles that do not come from an Entity but from a Map. For instance I would like to add the following in WebToolsUiLabels.xml: property key=FieldDescription.useSoftReference value xml:lang=enThis property is used to specify whether soft references should be used for cache entries. Soft references help keep large caches from taking too much memory by allowing the garbage collector to clear these entries when more memory is needed. Possible values: true/false./value /property so that user can get help on the useSoftReference field when accessing https://localhost:8443/webtools/control/EditUtilCache The FormFieldTitle_*** pattern, on the contrary, seems to be able to work on field titles that are not strictly related to entities field. Shouldn't we follow a similar approach replacing the FieldDescription.*** with FormFieldDescription_***. The field description is supposed to be used by an user that is in front of a field in a *form* and not strictly in an *entity*. What do you think about? Improve the ModelField.getDescription method Key: OFBIZ-1425 URL: https://issues.apache.org/jira/browse/OFBIZ-1425 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Adrian Crum Priority: Minor Attachments: example.patch, example.patch Based upon discussion on the dev mailing list and in the OFBIZ-1387 issue, modify the ModelField.getDescription method so it uses a more comprehensive way to resolve a field description. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-3902) Improving the Party Find Screen
Improving the Party Find Screen --- Key: OFBIZ-3902 URL: https://issues.apache.org/jira/browse/OFBIZ-3902 Project: OFBiz Issue Type: Improvement Components: party Reporter: Bruno Busco Priority: Minor I have done some work to improve the Party Find Screen. Now it uses a standard FindScreenDecorator. Almost all column are sortable, the pagination is flexible as the standard. I have created a new entity for the form used in this screen PartyDetails. The contact fields like PostalAddress etc. are still missing The button on the right to access the orders, requests etc. are not available becouse I do not know how to add them in a form field. In any case I think it is better to not have them to remove a dependence of Party from Orders etc. These buttons are still available on the SubTabBar of the Party details screen. So, now, the user should go to the party details screen (clicking on the PartyID) and then use the menu. This menu could at a later stage be injected by the Order application so that the dependence issue will definitively be solved. Could someone please give a look to the patch and give some help? - How to add the contact fields that are still missing? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3902) Improving the Party Find Screen
[ https://issues.apache.org/jira/browse/OFBIZ-3902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-3902: --- Attachment: NewFindParty.patch Improving the Party Find Screen --- Key: OFBIZ-3902 URL: https://issues.apache.org/jira/browse/OFBIZ-3902 Project: OFBiz Issue Type: Improvement Components: party Reporter: Bruno Busco Priority: Minor Attachments: NewFindParty.patch I have done some work to improve the Party Find Screen. Now it uses a standard FindScreenDecorator. Almost all column are sortable, the pagination is flexible as the standard. I have created a new entity for the form used in this screen PartyDetails. The contact fields like PostalAddress etc. are still missing The button on the right to access the orders, requests etc. are not available becouse I do not know how to add them in a form field. In any case I think it is better to not have them to remove a dependence of Party from Orders etc. These buttons are still available on the SubTabBar of the Party details screen. So, now, the user should go to the party details screen (clicking on the PartyID) and then use the menu. This menu could at a later stage be injected by the Order application so that the dependence issue will definitively be solved. Could someone please give a look to the patch and give some help? - How to add the contact fields that are still missing? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3894) Refactor Email handling
[ https://issues.apache.org/jira/browse/OFBIZ-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12901773#action_12901773 ] Bruno Busco commented on OFBIZ-3894: I perfectly agree on having a content based email data model similar to the one that you suggest. A set of screens in the content (?) component could allow the user to browse between the available email templates and define new ones. Refactor Email handling --- Key: OFBIZ-3894 URL: https://issues.apache.org/jira/browse/OFBIZ-3894 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: BJ Freeman Priority: Minor Fix For: SVN trunk Original Estimate: 1344h Remaining Estimate: 1344h with the addition of the Website for each component 1) create product store for Order entry, or use the B2C product store. 2) move the email widgets from ecommerce to order compontent. 3) modify the seed data so that Order entry has it own emails from order component.this would be to add emails to note: as I go through the different items this is turning out to be a bigger project than I first anticipated. so consider this so far just ideas. Maybe break down in to small tasks as I have time to do something. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3894) Refactor Ecommerce and Order
[ https://issues.apache.org/jira/browse/OFBIZ-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12901327#action_12901327 ] Bruno Busco commented on OFBIZ-3894: How the productstore and the email templates are linked together is just something I was looking at. I have found the EmailTemplateSetting entity defined in the framework common component and the ProductStoreEmailSetting defined in the product component. The ProductStoreEmailSetting entity is a copy of the EmailTemplateSetting since many fields are duplicated and it is used for instance in the sendCreatePartyEmailNotification service to send an email to newly added parties while sendMailFromTemplateSetting should have been used. As a result of all this we have that the party component (where the sendCreatePartyEmailNotification is defined) depends on the product component (where the ProductStoreEmailSetting is defined). Could we think to reuse the EmailTemplateSetting instead of duplicating it in the ProductStoreEmailSetting and then having the services defined in party only use the EmailTemplateSetting so to avoid dependence on the product component ? I am still looking at having only the party and content (and a better myportal) components distributed with the framework and this would help. Any ideas? Refactor Ecommerce and Order Key: OFBIZ-3894 URL: https://issues.apache.org/jira/browse/OFBIZ-3894 Project: OFBiz Issue Type: Improvement Components: order, specialpurpose/ecommerce Affects Versions: SVN trunk Reporter: BJ Freeman Priority: Minor Fix For: SVN trunk Original Estimate: 1344h Remaining Estimate: 1344h with the addition of the Website for each component 1) create product store for Order entry, or use the B2C product store. 2) move the email widgets from ecommerce to order compontent. 3) modify the seed data so that Order entry has it own emails from order component.this would be to add emails to note: as I go through the different items this is turning out to be a bigger project than I first anticipated. so consider this so far just ideas. Maybe break down in to small tasks as I have time to do something. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3894) Refactor Ecommerce and Order
[ https://issues.apache.org/jira/browse/OFBIZ-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12901337#action_12901337 ] Bruno Busco commented on OFBIZ-3894: BJ, the entity entity-name=EmailTemplateSetting package-name=org.ofbiz.common.email is already defined in common and it should be used for every base email sending service. I mean for example for system notifications, mailing list, new user confirmation. Then the product component should have extended this entity adding all needed fields. The way it is done right now does not seem really clean to me. Refactor Ecommerce and Order Key: OFBIZ-3894 URL: https://issues.apache.org/jira/browse/OFBIZ-3894 Project: OFBiz Issue Type: Improvement Components: order, specialpurpose/ecommerce Affects Versions: SVN trunk Reporter: BJ Freeman Priority: Minor Fix For: SVN trunk Original Estimate: 1344h Remaining Estimate: 1344h with the addition of the Website for each component 1) create product store for Order entry, or use the B2C product store. 2) move the email widgets from ecommerce to order compontent. 3) modify the seed data so that Order entry has it own emails from order component.this would be to add emails to note: as I go through the different items this is turning out to be a bigger project than I first anticipated. so consider this so far just ideas. Maybe break down in to small tasks as I have time to do something. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3894) Refactor Ecommerce and Order
[ https://issues.apache.org/jira/browse/OFBIZ-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12901507#action_12901507 ] Bruno Busco commented on OFBIZ-3894: If we want to preserve compatibility we will never get the framework independence. We can create a branch where those major changes happen. Refactor Ecommerce and Order Key: OFBIZ-3894 URL: https://issues.apache.org/jira/browse/OFBIZ-3894 Project: OFBiz Issue Type: Improvement Components: order, specialpurpose/ecommerce Affects Versions: SVN trunk Reporter: BJ Freeman Priority: Minor Fix For: SVN trunk Original Estimate: 1344h Remaining Estimate: 1344h with the addition of the Website for each component 1) create product store for Order entry, or use the B2C product store. 2) move the email widgets from ecommerce to order compontent. 3) modify the seed data so that Order entry has it own emails from order component.this would be to add emails to note: as I go through the different items this is turning out to be a bigger project than I first anticipated. so consider this so far just ideas. Maybe break down in to small tasks as I have time to do something. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3807) Application name localizations should not be defined in the CommonUiLabels framework file
[ https://issues.apache.org/jira/browse/OFBIZ-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-3807: --- Attachment: POC_InjectedMainMenu.patch I started playing with the menu injection patch Scott has provided in OFBIZ-3373 to see how we could use this mechanism to allow all applications inject their main menu in a framework defined common MainMenu. In the attached patch there is a very simple POC of this (you need to apply the https://issues.apache.org/jira/secure/attachment/12448859/injections.patch from OFBIZ-3373 to test it). The Party and ProjectMgr applications inject their main menus in a framework defined MainMenu. This new main menu is rendered directly under the header (just to see if it works). - It seems we should be able to inject complete menus and not only menu items so that a two levels menu could be formed. - Being able to inject a complete already defined menu would be IMO the best. - It seems that the uiLabel handling still has some issue. The Party menu is well rendered while the Project not. Application name localizations should not be defined in the CommonUiLabels framework file - Key: OFBIZ-3807 URL: https://issues.apache.org/jira/browse/OFBIZ-3807 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Bruno Busco Priority: Minor Attachments: POC_InjectedMainMenu.patch There is a weak dependence from the framework to ALL applications because the application name localization for the application menu is defined in CommonUiLabels.xml file. Whenever a user wants to add an application and localize its name, a new entry in CommonUiLabels.xml framework file needs to be created. How could we have the application menu use the application specific labels file to get the localitazion? The injectable menu we are speaking about could be the solution. A simple main menu could be defined in the framework with only the Webtools and Example menu entries. Every application could inject its own application menu entries. An application could also inject menu entries in several different menus so that, for example all application's administrations could be placed in one unique high level admin menu entry. This could also allow a party/content binding component to inject menu entries into otherwise stand-alone party and content applications. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3373) Adding menu merging feature
[ https://issues.apache.org/jira/browse/OFBIZ-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12896799#action_12896799 ] Bruno Busco commented on OFBIZ-3373: Scott, what you think it should be done better in the patch to be committed? Adding menu merging feature --- Key: OFBIZ-3373 URL: https://issues.apache.org/jira/browse/OFBIZ-3373 Project: OFBiz Issue Type: Wish Components: framework Reporter: Bruno Busco Priority: Minor Attachments: googlebase-inject.patch, injections.patch, injections.patch, links.jpg, partymenu.JPG Hi devs, while discussing in the ML about modules and framework separation I thought to this new feature that I would like to discuss here with you. We have now the possibility to extend a menu from one other. This is great in order to have an high level of code reuse and great consistency all over OFBiz. I was thinking to a sort of merges-to property for the menu widget. This would allow a new module to specify an already exixting menu name (in the framework core or in a lower level module) that should be somewhat changed by the actual menu. For instance, in the attached image partymenu.jpg there is a a tipical use of this feature: in the party module there are lot of links that co to order application, account etc. Those menu link could be used defining a simple menu (say it partylinks_menu) in the party application that contains only party or framework related links (i.e. profile); additional components like order or accounting could define more menus that merges-to the partylinks_manu so that when the menu is rendered IN THE PARTY APPLICATION the new menu items added in the order and accounting applications are also rendered. This would allow us to dramatically reduce the component dependence and help us to have the framework-only distribution. To eventually implement this I think there should be an entity that defines such mergin menus and the menu rendered should lookup the entity to check if one or more merges to the actually rendering menu is defined. I would appreciate to hear from you if this idea can help. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3373) Adding menu merging feature
[ https://issues.apache.org/jira/browse/OFBIZ-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12896867#action_12896867 ] Bruno Busco commented on OFBIZ-3373: That's great! Once commited I will try to use the new feature to get more components independence. Adding menu merging feature --- Key: OFBIZ-3373 URL: https://issues.apache.org/jira/browse/OFBIZ-3373 Project: OFBiz Issue Type: Wish Components: framework Reporter: Bruno Busco Priority: Minor Attachments: googlebase-inject.patch, injections.patch, injections.patch, links.jpg, partymenu.JPG Hi devs, while discussing in the ML about modules and framework separation I thought to this new feature that I would like to discuss here with you. We have now the possibility to extend a menu from one other. This is great in order to have an high level of code reuse and great consistency all over OFBiz. I was thinking to a sort of merges-to property for the menu widget. This would allow a new module to specify an already exixting menu name (in the framework core or in a lower level module) that should be somewhat changed by the actual menu. For instance, in the attached image partymenu.jpg there is a a tipical use of this feature: in the party module there are lot of links that co to order application, account etc. Those menu link could be used defining a simple menu (say it partylinks_menu) in the party application that contains only party or framework related links (i.e. profile); additional components like order or accounting could define more menus that merges-to the partylinks_manu so that when the menu is rendered IN THE PARTY APPLICATION the new menu items added in the order and accounting applications are also rendered. This would allow us to dramatically reduce the component dependence and help us to have the framework-only distribution. To eventually implement this I think there should be an entity that defines such mergin menus and the menu rendered should lookup the entity to check if one or more merges to the actually rendering menu is defined. I would appreciate to hear from you if this idea can help. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3373) Adding menu merging feature
[ https://issues.apache.org/jira/browse/OFBIZ-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12880558#action_12880558 ] Bruno Busco commented on OFBIZ-3373: I am sorry to say that I was not able to fix this. Could someone interested, and more expert than me with java, try to fix the patch so that could be committed? I think it will definitively help in the framework separation. Thank you, Bruno Adding menu merging feature --- Key: OFBIZ-3373 URL: https://issues.apache.org/jira/browse/OFBIZ-3373 Project: OFBiz Issue Type: Wish Components: framework Reporter: Bruno Busco Priority: Minor Attachments: googlebase-inject.patch, injections.patch, links.jpg, partymenu.JPG Hi devs, while discussing in the ML about modules and framework separation I thought to this new feature that I would like to discuss here with you. We have now the possibility to extend a menu from one other. This is great in order to have an high level of code reuse and great consistency all over OFBiz. I was thinking to a sort of merges-to property for the menu widget. This would allow a new module to specify an already exixting menu name (in the framework core or in a lower level module) that should be somewhat changed by the actual menu. For instance, in the attached image partymenu.jpg there is a a tipical use of this feature: in the party module there are lot of links that co to order application, account etc. Those menu link could be used defining a simple menu (say it partylinks_menu) in the party application that contains only party or framework related links (i.e. profile); additional components like order or accounting could define more menus that merges-to the partylinks_manu so that when the menu is rendered IN THE PARTY APPLICATION the new menu items added in the order and accounting applications are also rendered. This would allow us to dramatically reduce the component dependence and help us to have the framework-only distribution. To eventually implement this I think there should be an entity that defines such mergin menus and the menu rendered should lookup the entity to check if one or more merges to the actually rendering menu is defined. I would appreciate to hear from you if this idea can help. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3373) Adding menu merging feature
[ https://issues.apache.org/jira/browse/OFBIZ-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12876006#action_12876006 ] Bruno Busco commented on OFBIZ-3373: Thank you Scott! I will try the patch soon. I have seen it does not include an example of injections. Do you have one available I could start from? If not I will try to create one on the example application. Adding menu merging feature --- Key: OFBIZ-3373 URL: https://issues.apache.org/jira/browse/OFBIZ-3373 Project: OFBiz Issue Type: Wish Components: framework Reporter: Bruno Busco Priority: Minor Attachments: injections.patch, links.jpg, partymenu.JPG Hi devs, while discussing in the ML about modules and framework separation I thought to this new feature that I would like to discuss here with you. We have now the possibility to extend a menu from one other. This is great in order to have an high level of code reuse and great consistency all over OFBiz. I was thinking to a sort of merges-to property for the menu widget. This would allow a new module to specify an already exixting menu name (in the framework core or in a lower level module) that should be somewhat changed by the actual menu. For instance, in the attached image partymenu.jpg there is a a tipical use of this feature: in the party module there are lot of links that co to order application, account etc. Those menu link could be used defining a simple menu (say it partylinks_menu) in the party application that contains only party or framework related links (i.e. profile); additional components like order or accounting could define more menus that merges-to the partylinks_manu so that when the menu is rendered IN THE PARTY APPLICATION the new menu items added in the order and accounting applications are also rendered. This would allow us to dramatically reduce the component dependence and help us to have the framework-only distribution. To eventually implement this I think there should be an entity that defines such mergin menus and the menu rendered should lookup the entity to check if one or more merges to the actually rendering menu is defined. I would appreciate to hear from you if this idea can help. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3373) Adding menu merging feature
[ https://issues.apache.org/jira/browse/OFBIZ-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12876009#action_12876009 ] Bruno Busco commented on OFBIZ-3373: GREAT! Adding menu merging feature --- Key: OFBIZ-3373 URL: https://issues.apache.org/jira/browse/OFBIZ-3373 Project: OFBiz Issue Type: Wish Components: framework Reporter: Bruno Busco Priority: Minor Attachments: googlebase-inject.patch, injections.patch, links.jpg, partymenu.JPG Hi devs, while discussing in the ML about modules and framework separation I thought to this new feature that I would like to discuss here with you. We have now the possibility to extend a menu from one other. This is great in order to have an high level of code reuse and great consistency all over OFBiz. I was thinking to a sort of merges-to property for the menu widget. This would allow a new module to specify an already exixting menu name (in the framework core or in a lower level module) that should be somewhat changed by the actual menu. For instance, in the attached image partymenu.jpg there is a a tipical use of this feature: in the party module there are lot of links that co to order application, account etc. Those menu link could be used defining a simple menu (say it partylinks_menu) in the party application that contains only party or framework related links (i.e. profile); additional components like order or accounting could define more menus that merges-to the partylinks_manu so that when the menu is rendered IN THE PARTY APPLICATION the new menu items added in the order and accounting applications are also rendered. This would allow us to dramatically reduce the component dependence and help us to have the framework-only distribution. To eventually implement this I think there should be an entity that defines such mergin menus and the menu rendered should lookup the entity to check if one or more merges to the actually rendering menu is defined. I would appreciate to hear from you if this idea can help. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3373) Adding menu merging feature
[ https://issues.apache.org/jira/browse/OFBIZ-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12876015#action_12876015 ] Bruno Busco commented on OFBIZ-3373: Adrian, a pattern that I have seen to be very powerful is to have a *unique* reference page for each topic and have this improved as long as new features come available on the system. The new feature can become available installing new components but the user should not know if a new feature is contained in a new component or in the old component that has been changed. I mean, coming to the profile page example, the system user should only now that whatever is related to the party profile is in a certain page, say Party-Profile. Then if he is logged into a system where the only thing that is possible to do is to change the user name and password he will find only these UI elements. If, in the system, the party profile has more parameters becouse more business components are installed than the party profile page UI should grow up allowing all the available options and controls. Using the ofbiz standard extension mechanism forces the user to change the screen, or the application where to go as long as new components (with new screens) are installed on the system. Another example could be a unique Settings page where all settings for all installed components are added. When we introduced the Portal system we already did a step in this direction. Right now, if a PortalPage is available in a base component, a newly installed component can add, to that PortalPage, one or more Portlets defined by itself. This would allow a central define Party Profile or a Settings page to be added with dinamically elements Portlets and Menus. Adding menu merging feature --- Key: OFBIZ-3373 URL: https://issues.apache.org/jira/browse/OFBIZ-3373 Project: OFBiz Issue Type: Wish Components: framework Reporter: Bruno Busco Priority: Minor Attachments: googlebase-inject.patch, injections.patch, links.jpg, partymenu.JPG Hi devs, while discussing in the ML about modules and framework separation I thought to this new feature that I would like to discuss here with you. We have now the possibility to extend a menu from one other. This is great in order to have an high level of code reuse and great consistency all over OFBiz. I was thinking to a sort of merges-to property for the menu widget. This would allow a new module to specify an already exixting menu name (in the framework core or in a lower level module) that should be somewhat changed by the actual menu. For instance, in the attached image partymenu.jpg there is a a tipical use of this feature: in the party module there are lot of links that co to order application, account etc. Those menu link could be used defining a simple menu (say it partylinks_menu) in the party application that contains only party or framework related links (i.e. profile); additional components like order or accounting could define more menus that merges-to the partylinks_manu so that when the menu is rendered IN THE PARTY APPLICATION the new menu items added in the order and accounting applications are also rendered. This would allow us to dramatically reduce the component dependence and help us to have the framework-only distribution. To eventually implement this I think there should be an entity that defines such mergin menus and the menu rendered should lookup the entity to check if one or more merges to the actually rendering menu is defined. I would appreciate to hear from you if this idea can help. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3373) Adding menu merging feature
[ https://issues.apache.org/jira/browse/OFBIZ-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12876022#action_12876022 ] Bruno Busco commented on OFBIZ-3373: Hi Scott, installed the patches. The menu injection works well, I can see the new item in the Catalog menu. It seems that I cannot have the controller injections working since if I choose the Google base integration menu item I get the error: org.ofbiz.webapp.control.RequestHandlerException: Unknown request [gbaseadvancedsearch]; this request does not exist or cannot be called directly. Adding menu merging feature --- Key: OFBIZ-3373 URL: https://issues.apache.org/jira/browse/OFBIZ-3373 Project: OFBiz Issue Type: Wish Components: framework Reporter: Bruno Busco Priority: Minor Attachments: googlebase-inject.patch, injections.patch, links.jpg, partymenu.JPG Hi devs, while discussing in the ML about modules and framework separation I thought to this new feature that I would like to discuss here with you. We have now the possibility to extend a menu from one other. This is great in order to have an high level of code reuse and great consistency all over OFBiz. I was thinking to a sort of merges-to property for the menu widget. This would allow a new module to specify an already exixting menu name (in the framework core or in a lower level module) that should be somewhat changed by the actual menu. For instance, in the attached image partymenu.jpg there is a a tipical use of this feature: in the party module there are lot of links that co to order application, account etc. Those menu link could be used defining a simple menu (say it partylinks_menu) in the party application that contains only party or framework related links (i.e. profile); additional components like order or accounting could define more menus that merges-to the partylinks_manu so that when the menu is rendered IN THE PARTY APPLICATION the new menu items added in the order and accounting applications are also rendered. This would allow us to dramatically reduce the component dependence and help us to have the framework-only distribution. To eventually implement this I think there should be an entity that defines such mergin menus and the menu rendered should lookup the entity to check if one or more merges to the actually rendering menu is defined. I would appreciate to hear from you if this idea can help. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3373) Adding menu merging feature
[ https://issues.apache.org/jira/browse/OFBIZ-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12876028#action_12876028 ] Bruno Busco commented on OFBIZ-3373: Thank you Scott, I will find out. Adding menu merging feature --- Key: OFBIZ-3373 URL: https://issues.apache.org/jira/browse/OFBIZ-3373 Project: OFBiz Issue Type: Wish Components: framework Reporter: Bruno Busco Priority: Minor Attachments: googlebase-inject.patch, injections.patch, links.jpg, partymenu.JPG Hi devs, while discussing in the ML about modules and framework separation I thought to this new feature that I would like to discuss here with you. We have now the possibility to extend a menu from one other. This is great in order to have an high level of code reuse and great consistency all over OFBiz. I was thinking to a sort of merges-to property for the menu widget. This would allow a new module to specify an already exixting menu name (in the framework core or in a lower level module) that should be somewhat changed by the actual menu. For instance, in the attached image partymenu.jpg there is a a tipical use of this feature: in the party module there are lot of links that co to order application, account etc. Those menu link could be used defining a simple menu (say it partylinks_menu) in the party application that contains only party or framework related links (i.e. profile); additional components like order or accounting could define more menus that merges-to the partylinks_manu so that when the menu is rendered IN THE PARTY APPLICATION the new menu items added in the order and accounting applications are also rendered. This would allow us to dramatically reduce the component dependence and help us to have the framework-only distribution. To eventually implement this I think there should be an entity that defines such mergin menus and the menu rendered should lookup the entity to check if one or more merges to the actually rendering menu is defined. I would appreciate to hear from you if this idea can help. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3807) Application name localizations should not be defined in the CommonUiLabels framework file
[ https://issues.apache.org/jira/browse/OFBIZ-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12875873#action_12875873 ] Bruno Busco commented on OFBIZ-3807: Many thanks for the feedbacks on this. Having Scott's starting point for the injectable menus will be great. About Adrian's proposal of improving the property protocol and related, I would better try to see if it could be possible to completely replace the actual application title with a complete injected application menu. I mean: Assumed that we have the injection menu, the framework would define the first level menu with the Web Tools and the Example entries. All other application wouuld inject their own menu. The injected menu could be not just the Application Title entry but the complete TabBarMenu that is normally rendered when accessing the application main page. This would allow to render a two levels application menu: - Application 1 - Entry 1.1 - Entry 1.2 - Entry 1.3 - Application 2 - Entry 2.1 - Entry 2.2 - Entry 2.3 that would allow direct access to second level applications screens. Application name localizations should not be defined in the CommonUiLabels framework file - Key: OFBIZ-3807 URL: https://issues.apache.org/jira/browse/OFBIZ-3807 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Bruno Busco Priority: Minor There is a weak dependence from the framework to ALL applications because the application name localization for the application menu is defined in CommonUiLabels.xml file. Whenever a user wants to add an application and localize its name, a new entry in CommonUiLabels.xml framework file needs to be created. How could we have the application menu use the application specific labels file to get the localitazion? The injectable menu we are speaking about could be the solution. A simple main menu could be defined in the framework with only the Webtools and Example menu entries. Every application could inject its own application menu entries. An application could also inject menu entries in several different menus so that, for example all application's administrations could be placed in one unique high level admin menu entry. This could also allow a party/content binding component to inject menu entries into otherwise stand-alone party and content applications. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-3807) Application name localizations should not be defined in the CommonUiLabels framework file
Application name localizations should not be defined in the CommonUiLabels framework file - Key: OFBIZ-3807 URL: https://issues.apache.org/jira/browse/OFBIZ-3807 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Bruno Busco Priority: Minor There is a weak dependence of the framework from ALL applications because the application name localization for the application menu is defined in CommonUiLabels.xml file. Whenever a user wants to add an application and localize its name, a new entry in CommonUiLabels.xml framework file needs to be created. How could we have the application menu use the application specific labels file to get the localitazion? The injectable menu we are speaking about could be the solution. A simple main menu could be defined in the framework with only the Webtools and Example menu entries. Every application could inject its own application menu entries. An application could also inject menu entries in several different menus so that, for example all application's administrations could be placed in one unique high level admin menu entry. This could also allow a party/content binding component to inject menu entries into otherwise stand-alone party and content applications. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3747) ProductStore missing field title help
[ https://issues.apache.org/jira/browse/OFBIZ-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco closed OFBIZ-3747. -- Assignee: Bruno Busco (was: Erwan de FERRIERES) Resolution: Fixed Thank you Chris, your patch is in trunk at revision: 944675 ProductStore missing field title help - Key: OFBIZ-3747 URL: https://issues.apache.org/jira/browse/OFBIZ-3747 Project: OFBiz Issue Type: Sub-task Components: product Affects Versions: Release Branch 10.04, SVN trunk Reporter: chris snow Assignee: Bruno Busco Fix For: Release Branch 10.04, SVN trunk Attachments: productStoreFieldDescriptions2.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2104) Support for sub-menu is not completely implemented in the menu widget
[ https://issues.apache.org/jira/browse/OFBIZ-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12863665#action_12863665 ] Bruno Busco commented on OFBIZ-2104: Hi Erwan, what is needed at first is a menu widget renderer update so that it renders the HTML for the submenus with a ulli nested structure. Then the visual theme should render a proper drop-down menu. Support for sub-menu is not completely implemented in the menu widget - Key: OFBIZ-2104 URL: https://issues.apache.org/jira/browse/OFBIZ-2104 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Bruno Busco In the menu widget it seems to be definitions for a sub-menu tag but there is no rendering. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3701) Errors (with visible stacktraces) in screen: Order - Order List - Select (a sales order) - Edit items
[ https://issues.apache.org/jira/browse/OFBIZ-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco closed OFBIZ-3701. -- Assignee: Bruno Busco Resolution: Fixed Thank you Blas, your patch is in trunk at revision: 939938 Errors (with visible stacktraces) in screen: Order - Order List - Select (a sales order) - Edit items - Key: OFBIZ-3701 URL: https://issues.apache.org/jira/browse/OFBIZ-3701 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Blas Rodriguez Somoza Assignee: Bruno Busco Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-3701_duplicated_field_v2.jpg, OFBIZ-3701_order_edititems_v5.diff Two errors in edit items from a sales order with visible stacktraces Error 1 - Expression orderItemStatus.statusDatetime is undefined on line 133, column 37 in component://order/webapp/ordermgr/order/editorderitems.ftl editorderitems.ftl lines: 132 #assign loopStatusItem = orderItemStatus.getRelatedOne(StatusItem) 133 ${orderItemStatus.statusDatetime.toString()}nbsp;${loopStatusItem.get(description,locale)?default(orderItemStatus.statusId)}br / 134 /#list The same editorderitems.ftl seems to work OK for purchase order. Error 2 - Expression catalogCol is undefined on line 37, column 18 in component://order/webapp/ordermgr/order/appendorderitem.ftl. appendorderitem.ftl lines: 37#if catalogCol?size == 1 38input type=hidden name=prodCatalogId value=${catalogCol.first}/ 39/#if The same appendorderitem.ftl seems to work OK for purchase orders. Probably related with the catalog issue, in Order Entry - Sales order continue, the choose catalog select field has no option values. Please, commit OFBIZ-3685 before working on this issue. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3747) ProductStore missing field title help
[ https://issues.apache.org/jira/browse/OFBIZ-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12862993#action_12862993 ] Bruno Busco commented on OFBIZ-3747: +1 on having a sort of structured help page in the help file that would allow to extract the short description and show it in the tooltip. Clicking in the tooltip the complete help page could be shown (in the help window) with the full field description. ProductStore missing field title help - Key: OFBIZ-3747 URL: https://issues.apache.org/jira/browse/OFBIZ-3747 Project: OFBiz Issue Type: Sub-task Components: product Affects Versions: Release Candidate Branch 10.04, SVN trunk Reporter: chris snow Fix For: Release Candidate Branch 10.04, SVN trunk Attachments: productStoreFieldDescriptions.patch, productStoreFieldDescriptions2.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3734) XHTML validation errors round 2+ (specialpurpose/ecommerce)
[ https://issues.apache.org/jira/browse/OFBIZ-3734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco closed OFBIZ-3734. -- Assignee: Bruno Busco Resolution: Fixed Thank you Blas, your patch is in trunk at revision 939749 XHTML validation errors round 2+ (specialpurpose/ecommerce) --- Key: OFBIZ-3734 URL: https://issues.apache.org/jira/browse/OFBIZ-3734 Project: OFBiz Issue Type: Bug Components: specialpurpose/ecommerce Affects Versions: SVN trunk Reporter: Blas Rodriguez Somoza Assignee: Bruno Busco Priority: Trivial Fix For: SVN trunk Attachments: OFBIZ-3734_specommerce_xhtml.diff TextImage.ftl attributes without values billsettings.ftl attributes without values paymentinformation.ftl attributes without values quickAnonOptionSettings.ftl attributes without values -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3732) XHTML validation errors round 2++ (framework excluding widgets)
[ https://issues.apache.org/jira/browse/OFBIZ-3732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco closed OFBIZ-3732. -- Assignee: Bruno Busco Resolution: Fixed Thank you Blas, your patch is in trunk at revision: 939757 XHTML validation errors round 2++ (framework excluding widgets) --- Key: OFBIZ-3732 URL: https://issues.apache.org/jira/browse/OFBIZ-3732 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Blas Rodriguez Somoza Assignee: Bruno Busco Priority: Trivial Fix For: SVN trunk Attachments: OFBIZ-3732_framework_xhtml.diff geolocation.ftl Script content need to be inside markup comment to avoid character encoding issues. EntityImport.ftl attributes without values EntityImportDir.ftl attributes without values EntityImportReaders.ftl attributes without values -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3721) XHTML validation errors round 2+ (order)
[ https://issues.apache.org/jira/browse/OFBIZ-3721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco closed OFBIZ-3721. -- Assignee: Bruno Busco Resolution: Fixed Thank you Blas, your patch is in trunk at revision: 939760 XHTML validation errors round 2+ (order) Key: OFBIZ-3721 URL: https://issues.apache.org/jira/browse/OFBIZ-3721 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Blas Rodriguez Somoza Assignee: Bruno Busco Priority: Trivial Fix For: SVN trunk Attachments: OFBIZ-3721_order_xhtml_v2.diff billsettings.ftl attributes without values orderagreements.ftl Removed catalog select when there are no catalogs available. shipsettings.ftl attributes without values showcart.ftl attributes without values configproductdetail.ftl attributes without values quickReturn.ftl attributes without values -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3722) XHTML validation errors round 2+ (party)
[ https://issues.apache.org/jira/browse/OFBIZ-3722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco closed OFBIZ-3722. -- Resolution: Fixed Thank you Blas, your patch is in trunk at revision: 939767 XHTML validation errors round 2+ (party) Key: OFBIZ-3722 URL: https://issues.apache.org/jira/browse/OFBIZ-3722 Project: OFBiz Issue Type: Bug Components: party Affects Versions: SVN trunk Reporter: Blas Rodriguez Somoza Priority: Trivial Fix For: SVN trunk Attachments: OFBIZ-3722_party_xhtml.diff PaymentMethods.ftl Line 139: td open needed. UserLogin.ftl Line 31: wrong if condition (creates an empty table and don't show the ${uiLabelMap.PartyNoUserLogin} message) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-3722) XHTML validation errors round 2+ (party)
[ https://issues.apache.org/jira/browse/OFBIZ-3722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco reassigned OFBIZ-3722: -- Assignee: Bruno Busco XHTML validation errors round 2+ (party) Key: OFBIZ-3722 URL: https://issues.apache.org/jira/browse/OFBIZ-3722 Project: OFBiz Issue Type: Bug Components: party Affects Versions: SVN trunk Reporter: Blas Rodriguez Somoza Assignee: Bruno Busco Priority: Trivial Fix For: SVN trunk Attachments: OFBIZ-3722_party_xhtml.diff PaymentMethods.ftl Line 139: td open needed. UserLogin.ftl Line 31: wrong if condition (creates an empty table and don't show the ${uiLabelMap.PartyNoUserLogin} message) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3723) XHTML validation errors round 2+ (workeffort)
[ https://issues.apache.org/jira/browse/OFBIZ-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco closed OFBIZ-3723. -- Assignee: Bruno Busco Resolution: Fixed Thank you Blas, your patch is in trunk at revision: 939769 XHTML validation errors round 2+ (workeffort) - Key: OFBIZ-3723 URL: https://issues.apache.org/jira/browse/OFBIZ-3723 Project: OFBiz Issue Type: Bug Components: workeffort Affects Versions: SVN trunk Reporter: Blas Rodriguez Somoza Assignee: Bruno Busco Priority: Trivial Fix For: SVN trunk Attachments: OFBIZ-3723_workeffort_xhtml.diff day.ftl Line 28: attribute value without month.ftl Line 19: style tag is not allowed outside head, attribute must be used instead upcoming.ftl Line 49: invalid div close -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3730) XHTML validation errors round 2+ (content)
[ https://issues.apache.org/jira/browse/OFBIZ-3730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco closed OFBIZ-3730. -- Assignee: Bruno Busco Resolution: Fixed Thank you Blas, your patch is in trunk at revision: 939788 XHTML validation errors round 2+ (content) -- Key: OFBIZ-3730 URL: https://issues.apache.org/jira/browse/OFBIZ-3730 Project: OFBiz Issue Type: Bug Components: content Affects Versions: SVN trunk Reporter: Blas Rodriguez Somoza Assignee: Bruno Busco Priority: Trivial Fix For: SVN trunk Attachments: OFBIZ-3730_content_xhtml_v2.diff addSubSite.ftl script without type attribute CMSContentEdit.ftl Attributes without value CMSSites.ftl Attributes without value UserPermissions.ftl Attributes without value -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3731) XHTML validation errors round 2+ (product)
[ https://issues.apache.org/jira/browse/OFBIZ-3731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco closed OFBIZ-3731. -- Assignee: Bruno Busco Resolution: Fixed Thank you Blas, your patch is in trunk at revision: 939794 XHTML validation errors round 2+ (product) -- Key: OFBIZ-3731 URL: https://issues.apache.org/jira/browse/OFBIZ-3731 Project: OFBiz Issue Type: Bug Components: product Affects Versions: SVN trunk Reporter: Blas Rodriguez Somoza Assignee: Bruno Busco Priority: Trivial Fix For: SVN trunk Attachments: OFBIZ-3731_product_xhtml_v2.diff advancedsearch.ftl Line 30: input can't be directly inside table. LInes 108,109,253: attribute without value CreateVirtualWithVariantsForm.ftl Line 20: Form can't be located directly inside table. EditProductQuickAdmin.ftl Line 135: attribute without value EditFacility.ftl Line 85: uppercase attribute without value FindFacilityLocation.ftl Line 33: input can't be directly inside table. Line 42: duplicated tr open Line 30,44,48,52,56,60,54: unclosed input PicklistOptions.ftl Lines 32,34,36: attribute without value Line 38: text can't be directly inside tr Line 52: invalid attribute align in tag a PickMoveStock.ftl Line 164: tr open needed Line 172: td close needed Line 176: tr open needed Line 173: unencoded ampersand Lines 168,175: unclosed inputs ViewContactMechs.ftl Line 100: form close without character receiveInventory.ftl Line 19:236: script without type attribute FindShipment.ftl Line 149: duplicated id. PackOrder.ftl Line 508,512: script without type attribute Lines 516,517: invalid div closings ReceiveInventoryAgainstPurchaseOrder.ftl Line 238: script without type attribute VerifyPick.ftl Lines 363,367,372: script without type attribute -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3733) XHTML validation errors round 2+ (specialpurpose/ebay)
[ https://issues.apache.org/jira/browse/OFBIZ-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco closed OFBIZ-3733. -- Assignee: Bruno Busco Resolution: Fixed Thank you Blas, your patch is in trunk at revision: 939796 XHTML validation errors round 2+ (specialpurpose/ebay) -- Key: OFBIZ-3733 URL: https://issues.apache.org/jira/browse/OFBIZ-3733 Project: OFBiz Issue Type: Bug Components: specialpurpose/ebay Affects Versions: SVN trunk Reporter: Blas Rodriguez Somoza Assignee: Bruno Busco Priority: Trivial Fix For: SVN trunk Attachments: OFBIZ-3733_spebay_xhtml.diff productsExportToEbay.ftl attributes without values ebayApiKeywordSearch.ftl attributes without values -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3701) Errors (with visible stacktraces) in screen: Order - Order List - Select (a sales order) - Edit items
[ https://issues.apache.org/jira/browse/OFBIZ-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12862843#action_12862843 ] Bruno Busco commented on OFBIZ-3701: Hi Blas, I got a conflict when applying this patch. Could you please update it? Thank you. Errors (with visible stacktraces) in screen: Order - Order List - Select (a sales order) - Edit items - Key: OFBIZ-3701 URL: https://issues.apache.org/jira/browse/OFBIZ-3701 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Blas Rodriguez Somoza Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-3701_duplicated_field.jpg, OFBIZ-3701_order_edititems_v3.diff Two errors in edit items from a sales order with visible stacktraces Error 1 - Expression orderItemStatus.statusDatetime is undefined on line 133, column 37 in component://order/webapp/ordermgr/order/editorderitems.ftl editorderitems.ftl lines: 132 #assign loopStatusItem = orderItemStatus.getRelatedOne(StatusItem) 133 ${orderItemStatus.statusDatetime.toString()}nbsp;${loopStatusItem.get(description,locale)?default(orderItemStatus.statusId)}br / 134 /#list The same editorderitems.ftl seems to work OK for purchase order. Error 2 - Expression catalogCol is undefined on line 37, column 18 in component://order/webapp/ordermgr/order/appendorderitem.ftl. appendorderitem.ftl lines: 37#if catalogCol?size == 1 38input type=hidden name=prodCatalogId value=${catalogCol.first}/ 39/#if The same appendorderitem.ftl seems to work OK for purchase orders. Probably related with the catalog issue, in Order Entry - Sales order continue, the choose catalog select field has no option values. Please, commit OFBIZ-3685 before working on this issue. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3720) XHTML validation errors round 2+ (accounting)
[ https://issues.apache.org/jira/browse/OFBIZ-3720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco closed OFBIZ-3720. -- Resolution: Fixed Thank you Blas, your patch is in trunk at revision: 937670 XHTML validation errors round 2+ (accounting) - Key: OFBIZ-3720 URL: https://issues.apache.org/jira/browse/OFBIZ-3720 Project: OFBiz Issue Type: Bug Components: accounting Affects Versions: SVN trunk Reporter: Blas Rodriguez Somoza Priority: Trivial Fix For: SVN trunk Attachments: OFBIZ-3720_accounting_xhtml.diff GlReconciledFinAccountTrans.ftl Line 149: input can't be directly table must be inside td. Line 203: invalid td close manualCCTx.ftl Lines 64,54,62: script can't be directly inside table must be inside td. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-3720) XHTML validation errors round 2+ (accounting)
[ https://issues.apache.org/jira/browse/OFBIZ-3720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco reassigned OFBIZ-3720: -- Assignee: Bruno Busco XHTML validation errors round 2+ (accounting) - Key: OFBIZ-3720 URL: https://issues.apache.org/jira/browse/OFBIZ-3720 Project: OFBiz Issue Type: Bug Components: accounting Affects Versions: SVN trunk Reporter: Blas Rodriguez Somoza Assignee: Bruno Busco Priority: Trivial Fix For: SVN trunk Attachments: OFBIZ-3720_accounting_xhtml.diff GlReconciledFinAccountTrans.ftl Line 149: input can't be directly table must be inside td. Line 203: invalid td close manualCCTx.ftl Lines 64,54,62: script can't be directly inside table must be inside td. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3702) provide better user help
[ https://issues.apache.org/jira/browse/OFBIZ-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12859039#action_12859039 ] Bruno Busco commented on OFBIZ-3702: Could we think to have the tooltip help shown putting the mous on the field name instead of the new ? icon? Having a ? for every field could get the page too much crowded and get the user confused. Anyway I really like the idea of havig such help feature. Just lets think a way to have it less invasive. provide better user help Key: OFBIZ-3702 URL: https://issues.apache.org/jira/browse/OFBIZ-3702 Project: OFBiz Issue Type: Improvement Affects Versions: Release Candidate Branch 10.04, SVN trunk Reporter: chris snow Attachments: entity_field_tooltip_screenshot.png, help.png, product_entitymodel.patch, tooltip_help_DO_NOT_COMMIT.patch Please see http://n4.nabble.com/Providing-users-with-help-td1840416.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.