[jira] [Updated] (OFBIZ-7873) Improvements in BillingAccountTermAttr entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-7873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar updated OFBIZ-7873: --- Attachment: OFBIZ-7873.patch Providing the patch for the improvement needed for BillingAccountTermAttr entity. Also verified the changes from webtools. Thanks [~rishisolankii] for the detailed explanation. > Improvements in BillingAccountTermAttr entity definition and services > - > > Key: OFBIZ-7873 > URL: https://issues.apache.org/jira/browse/OFBIZ-7873 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Chinmay Patidar >Priority: Minor > Attachments: OFBIZ-7873.patch > > > Required improvements; > - All is good with entity definition . > - Add crud services using entity-auto. Make sure PK is not optional while > create service. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As no status/from date/thru date exists in entity, so nothing needs to be > taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7869) Improvements in AgreementTermAttribute entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-7869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar updated OFBIZ-7869: --- Attachment: OFBIZ-7869.patch > Improvements in AgreementTermAttribute entity definition and services > - > > Key: OFBIZ-7869 > URL: https://issues.apache.org/jira/browse/OFBIZ-7869 > Project: OFBiz > Issue Type: Sub-task > Components: party >Reporter: Arun Patidar >Assignee: Chinmay Patidar >Priority: Minor > Attachments: OFBIZ-7869.patch > > > Required improvements; > - All is good with entity definition . > - Add CRUD services using entity-auto. Make sure PK is not optional while > create service as there is composite primary key. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As no status/from date/thru date exists in entity, so nothing needs to be > taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7869) Improvements in AgreementTermAttribute entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-7869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar updated OFBIZ-7869: --- Attachment: (was: OFBIZ-7869.patch) > Improvements in AgreementTermAttribute entity definition and services > - > > Key: OFBIZ-7869 > URL: https://issues.apache.org/jira/browse/OFBIZ-7869 > Project: OFBiz > Issue Type: Sub-task > Components: party >Reporter: Arun Patidar >Assignee: Chinmay Patidar >Priority: Minor > > Required improvements; > - All is good with entity definition . > - Add CRUD services using entity-auto. Make sure PK is not optional while > create service as there is composite primary key. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As no status/from date/thru date exists in entity, so nothing needs to be > taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-7869) Improvements in AgreementTermAttribute entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-7869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380750#comment-15380750 ] Chinmay Patidar edited comment on OFBIZ-7869 at 7/20/16 5:02 AM: - Providing the patch for the improvement needed for AgreementTermAttribute entity. Also verified the changes from webtools. Thanks [~arunpati] for the detailed explanation. was (Author: chinmay.patidar): Providing the patch for the improvement needed for AgreementTermAttribute entity. Also verified the changes from webtools. Thanks [~rishisolankii] for the detailed explanation. > Improvements in AgreementTermAttribute entity definition and services > - > > Key: OFBIZ-7869 > URL: https://issues.apache.org/jira/browse/OFBIZ-7869 > Project: OFBiz > Issue Type: Sub-task > Components: party >Reporter: Arun Patidar >Assignee: Chinmay Patidar >Priority: Minor > Attachments: OFBIZ-7869.patch > > > Required improvements; > - All is good with entity definition . > - Add CRUD services using entity-auto. Make sure PK is not optional while > create service as there is composite primary key. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As no status/from date/thru date exists in entity, so nothing needs to be > taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7869) Improvements in AgreementTermAttribute entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-7869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar updated OFBIZ-7869: --- Attachment: OFBIZ-7869.patch Providing the patch for the improvement needed for AgreementTermAttribute entity. Also verified the changes from webtools. Thanks [~rishisolankii] for the detailed explanation. > Improvements in AgreementTermAttribute entity definition and services > - > > Key: OFBIZ-7869 > URL: https://issues.apache.org/jira/browse/OFBIZ-7869 > Project: OFBiz > Issue Type: Sub-task > Components: party >Reporter: Arun Patidar >Assignee: Chinmay Patidar >Priority: Minor > Attachments: OFBIZ-7869.patch > > > Required improvements; > - All is good with entity definition . > - Add CRUD services using entity-auto. Make sure PK is not optional while > create service as there is composite primary key. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As no status/from date/thru date exists in entity, so nothing needs to be > taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7873) Improvements in BillingAccountTermAttr entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-7873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar reassigned OFBIZ-7873: -- Assignee: Chinmay Patidar > Improvements in BillingAccountTermAttr entity definition and services > - > > Key: OFBIZ-7873 > URL: https://issues.apache.org/jira/browse/OFBIZ-7873 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Chinmay Patidar >Priority: Minor > > Required improvements; > - All is good with entity definition . > - Add crud services using entity-auto. Make sure PK is not optional while > create service. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As no status/from date/thru date exists in entity, so nothing needs to be > taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7869) Improvements in AgreementTermAttribute entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-7869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar reassigned OFBIZ-7869: -- Assignee: Chinmay Patidar > Improvements in AgreementTermAttribute entity definition and services > - > > Key: OFBIZ-7869 > URL: https://issues.apache.org/jira/browse/OFBIZ-7869 > Project: OFBiz > Issue Type: Sub-task > Components: party >Reporter: Arun Patidar >Assignee: Chinmay Patidar >Priority: Minor > > Required improvements; > - All is good with entity definition . > - Add CRUD services using entity-auto. Make sure PK is not optional while > create service as there is composite primary key. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As no status/from date/thru date exists in entity, so nothing needs to be > taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7847) Improvements in AcctgTransEntryType entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-7847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar updated OFBIZ-7847: --- Attachment: OFBIZ-7847.patch Providing the patch for the improvement needed for AcctgTransEntryType entity. Also verified the changes from webtools. Thanks [~rishisolankii] for the detailed explanation. > Improvements in AcctgTransEntryType entity definition and services > -- > > Key: OFBIZ-7847 > URL: https://issues.apache.org/jira/browse/OFBIZ-7847 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Chinmay Patidar >Priority: Minor > Attachments: OFBIZ-7847.patch > > > Required improvements; > - All is good with entity definition . > - Add crud services using entity-auto. Make sure PK is optional while create > service, so that can be generated from OFBiz sequence generator. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As no status/from date/trhu date exists in entity, so nothing needs to be > taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7847) Improvements in AcctgTransEntryType entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-7847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar reassigned OFBIZ-7847: -- Assignee: Chinmay Patidar > Improvements in AcctgTransEntryType entity definition and services > -- > > Key: OFBIZ-7847 > URL: https://issues.apache.org/jira/browse/OFBIZ-7847 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Chinmay Patidar >Priority: Minor > > Required improvements; > - All is good with entity definition . > - Add crud services using entity-auto. Make sure PK is optional while create > service, so that can be generated from OFBiz sequence generator. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As no status/from date/trhu date exists in entity, so nothing needs to be > taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7809) Enforce noninstantiability to UtilXml class
[ https://issues.apache.org/jira/browse/OFBIZ-7809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar updated OFBIZ-7809: --- Attachment: OFBIZ-7809.patch Provided patch for the issue. Thanks [~rishisolankii] for providing the detailed explanation. > Enforce noninstantiability to UtilXml class > --- > > Key: OFBIZ-7809 > URL: https://issues.apache.org/jira/browse/OFBIZ-7809 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Arun Patidar >Assignee: Chinmay Patidar >Priority: Minor > Attachments: OFBIZ-7809.patch > > > - Make class as final. > - Add a private constructor. > No variables need to change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7802) Enforce noninstantiability to ProductWorker class
[
https://issues.apache.org/jira/browse/OFBIZ-7802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chinmay Patidar updated OFBIZ-7802:
---
Attachment: OFBIZ-7802.patch
Provided patch for the issue. Thanks [~rishisolankii] for providing detailed
explanation.
> Enforce noninstantiability to ProductWorker class
> -
>
> Key: OFBIZ-7802
> URL: https://issues.apache.org/jira/browse/OFBIZ-7802
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Chinmay Patidar
>Priority: Minor
> Attachments: OFBIZ-7802.patch
>
>
> - Make class as final.
> - Private constructor already exists, by making it final we just matching the
> patterns from other utility classes.
> - Make following public static final variables as private;
> {code}
> public static final String resource = "ProductUiLabels";
> public static final MathContext generalRounding = new MathContext(10);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Issue Comment Deleted] (OFBIZ-7802) Enforce noninstantiability to ProductWorker class
[
https://issues.apache.org/jira/browse/OFBIZ-7802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chinmay Patidar updated OFBIZ-7802:
---
Comment: was deleted
(was: Providing the patch for the issue. Thanks [~rishisolankii] for the
detailed explanation.)
> Enforce noninstantiability to ProductWorker class
> -
>
> Key: OFBIZ-7802
> URL: https://issues.apache.org/jira/browse/OFBIZ-7802
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Chinmay Patidar
>Priority: Minor
>
> - Make class as final.
> - Private constructor already exists, by making it final we just matching the
> patterns from other utility classes.
> - Make following public static final variables as private;
> {code}
> public static final String resource = "ProductUiLabels";
> public static final MathContext generalRounding = new MathContext(10);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7802) Enforce noninstantiability to ProductWorker class
[
https://issues.apache.org/jira/browse/OFBIZ-7802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chinmay Patidar updated OFBIZ-7802:
---
Attachment: (was: OFBIZ-7802)
> Enforce noninstantiability to ProductWorker class
> -
>
> Key: OFBIZ-7802
> URL: https://issues.apache.org/jira/browse/OFBIZ-7802
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Chinmay Patidar
>Priority: Minor
>
> - Make class as final.
> - Private constructor already exists, by making it final we just matching the
> patterns from other utility classes.
> - Make following public static final variables as private;
> {code}
> public static final String resource = "ProductUiLabels";
> public static final MathContext generalRounding = new MathContext(10);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7802) Enforce noninstantiability to ProductWorker class
[
https://issues.apache.org/jira/browse/OFBIZ-7802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chinmay Patidar updated OFBIZ-7802:
---
Attachment: OFBIZ-7802
Providing the patch for the issue. Thanks [~rishisolankii] for the detailed
explanation.
> Enforce noninstantiability to ProductWorker class
> -
>
> Key: OFBIZ-7802
> URL: https://issues.apache.org/jira/browse/OFBIZ-7802
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Chinmay Patidar
>Priority: Minor
> Attachments: OFBIZ-7802
>
>
> - Make class as final.
> - Private constructor already exists, by making it final we just matching the
> patterns from other utility classes.
> - Make following public static final variables as private;
> {code}
> public static final String resource = "ProductUiLabels";
> public static final MathContext generalRounding = new MathContext(10);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7809) Enforce noninstantiability to UtilXml class
[ https://issues.apache.org/jira/browse/OFBIZ-7809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar reassigned OFBIZ-7809: -- Assignee: Chinmay Patidar > Enforce noninstantiability to UtilXml class > --- > > Key: OFBIZ-7809 > URL: https://issues.apache.org/jira/browse/OFBIZ-7809 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Arun Patidar >Assignee: Chinmay Patidar >Priority: Minor > > - Make class as final. > - Add a private constructor. > No variables need to change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7802) Enforce noninstantiability to ProductWorker class
[
https://issues.apache.org/jira/browse/OFBIZ-7802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chinmay Patidar reassigned OFBIZ-7802:
--
Assignee: Chinmay Patidar
> Enforce noninstantiability to ProductWorker class
> -
>
> Key: OFBIZ-7802
> URL: https://issues.apache.org/jira/browse/OFBIZ-7802
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Chinmay Patidar
>Priority: Minor
>
> - Make class as final.
> - Private constructor already exists, by making it final we just matching the
> patterns from other utility classes.
> - Make following public static final variables as private;
> {code}
> public static final String resource = "ProductUiLabels";
> public static final MathContext generalRounding = new MathContext(10);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7687) Enforce noninstantiability to KeywordSearchUtil class
[
https://issues.apache.org/jira/browse/OFBIZ-7687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chinmay Patidar reassigned OFBIZ-7687:
--
Assignee: Chinmay Patidar
> Enforce noninstantiability to KeywordSearchUtil class
> -
>
> Key: OFBIZ-7687
> URL: https://issues.apache.org/jira/browse/OFBIZ-7687
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Chinmay Patidar
>Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static Set thesaurusRelsToInclude = new HashSet();
> public static Set thesaurusRelsForReplace = new HashSet();
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7688) Enforce noninstantiability to StatusWorker class
[ https://issues.apache.org/jira/browse/OFBIZ-7688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar reassigned OFBIZ-7688: -- Assignee: Chinmay Patidar > Enforce noninstantiability to StatusWorker class > > > Key: OFBIZ-7688 > URL: https://issues.apache.org/jira/browse/OFBIZ-7688 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Chinmay Patidar >Priority: Minor > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7455) ImportProductHelper class
[
https://issues.apache.org/jira/browse/OFBIZ-7455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chinmay Patidar updated OFBIZ-7455:
---
Attachment: OFBIZ-7455.patch
Attached the patch for the issue. Thanks [~rishisolankii] for the detailed
description.
> ImportProductHelper class
> -
>
> Key: OFBIZ-7455
> URL: https://issues.apache.org/jira/browse/OFBIZ-7455
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Chinmay Patidar
>Priority: Minor
> Attachments: OFBIZ-7455.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following static variable as public static final.
> {code}
> static String module = ImportProductHelper.class.getName();
> {code}
> No variables needs to be change for this class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7447) ImageManagementHelper class
[ https://issues.apache.org/jira/browse/OFBIZ-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar updated OFBIZ-7447: --- Attachment: OFBIZ-7447.patch Attached the patch for the issue. Thanks [~rishisolankii] for the detailed description. > ImageManagementHelper class > --- > > Key: OFBIZ-7447 > URL: https://issues.apache.org/jira/browse/OFBIZ-7447 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Chinmay Patidar >Priority: Minor > Attachments: OFBIZ-7447.patch > > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7447) ImageManagementHelper class
[ https://issues.apache.org/jira/browse/OFBIZ-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar reassigned OFBIZ-7447: -- Assignee: Chinmay Patidar > ImageManagementHelper class > --- > > Key: OFBIZ-7447 > URL: https://issues.apache.org/jira/browse/OFBIZ-7447 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Chinmay Patidar >Priority: Minor > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7455) ImportProductHelper class
[
https://issues.apache.org/jira/browse/OFBIZ-7455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chinmay Patidar reassigned OFBIZ-7455:
--
Assignee: Chinmay Patidar
> ImportProductHelper class
> -
>
> Key: OFBIZ-7455
> URL: https://issues.apache.org/jira/browse/OFBIZ-7455
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Chinmay Patidar
>Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> - Make the following static variable as public static final.
> {code}
> static String module = ImportProductHelper.class.getName();
> {code}
> No variables needs to be change for this class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7431) SeoUrlUtil class
[ https://issues.apache.org/jira/browse/OFBIZ-7431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar updated OFBIZ-7431: --- Attachment: OFBIZ-7431.patch Attached the patch for the issue. > SeoUrlUtil class > > > Key: OFBIZ-7431 > URL: https://issues.apache.org/jira/browse/OFBIZ-7431 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Chinmay Patidar >Priority: Minor > Attachments: OFBIZ-7431.patch > > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7419) PartyRelationshipHelper class
[ https://issues.apache.org/jira/browse/OFBIZ-7419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar updated OFBIZ-7419: --- Attachment: OFBIZ-7419.patch Attached the patch for the issue. > PartyRelationshipHelper class > - > > Key: OFBIZ-7419 > URL: https://issues.apache.org/jira/browse/OFBIZ-7419 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Chinmay Patidar >Priority: Minor > Attachments: OFBIZ-7419.patch > > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7431) SeoUrlUtil class
[ https://issues.apache.org/jira/browse/OFBIZ-7431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar reassigned OFBIZ-7431: -- Assignee: Chinmay Patidar > SeoUrlUtil class > > > Key: OFBIZ-7431 > URL: https://issues.apache.org/jira/browse/OFBIZ-7431 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Chinmay Patidar >Priority: Minor > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7419) PartyRelationshipHelper class
[ https://issues.apache.org/jira/browse/OFBIZ-7419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar reassigned OFBIZ-7419: -- Assignee: Chinmay Patidar > PartyRelationshipHelper class > - > > Key: OFBIZ-7419 > URL: https://issues.apache.org/jira/browse/OFBIZ-7419 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Chinmay Patidar >Priority: Minor > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7398) SolrUtil Class
[
https://issues.apache.org/jira/browse/OFBIZ-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chinmay Patidar updated OFBIZ-7398:
---
Attachment: OFBIZ-7398.patch
Attached is the patch for the issue. Thanks [~arunpati] for detailed
description which made the effort so smooth.
> SolrUtil Class
> --
>
> Key: OFBIZ-7398
> URL: https://issues.apache.org/jira/browse/OFBIZ-7398
> Project: OFBiz
> Issue Type: Sub-task
> Components: specialpurpose/solr
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Chinmay Patidar
>Priority: Minor
> Attachments: OFBIZ-7398.patch
>
>
> - Add a private constructor.
> - Make the following private static variable as final.
> {code}
> private static String[] solrProdAttribute = { "productId",
> "internalName", "manu", "size", "smallImage", "mediumImage", "largeImage",
> "listPrice", "defaultPrice", "inStock", "isVirtual" };
> {code}
> - Make the following public static variables as private
> {code}
> public static final String solrConfigName = "solrconfig.properties";
> public static final String solrUrl = makeSolrWebappUrl();
> {code}
> - Make the following protected static variables as private
> {code}
> protected static final String socketTimeoutString =
> UtilProperties.getPropertyValue(solrConfigName, "solr.client.socket.timeout");
>
> protected static final String connectionTimeoutString =
> UtilProperties.getPropertyValue(solrConfigName,
> "solr.client.connection.timeout");
>
> protected static final String clientUsername =
> UtilProperties.getPropertyValue(solrConfigName, "solr.client.username");
>
> protected static final String clientPassword =
> UtilProperties.getPropertyValue(solrConfigName, "solr.client.password");
> protected static final Integer socketTimeout = getSocketTimeout();
>
> protected static final Integer connectionTimeout = getConnectionTimeout();
>
> protected static final String trustSelfSignedCertString =
> UtilProperties.getPropertyValue(solrConfigName,
> "solr.client.trust.selfsigned.cert", "false");
>
> protected static final boolean trustSelfSignedCert =
> getTrustSelfSignedCert();
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7398) SolrUtil Class
[
https://issues.apache.org/jira/browse/OFBIZ-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chinmay Patidar reassigned OFBIZ-7398:
--
Assignee: Chinmay Patidar
> SolrUtil Class
> --
>
> Key: OFBIZ-7398
> URL: https://issues.apache.org/jira/browse/OFBIZ-7398
> Project: OFBiz
> Issue Type: Sub-task
> Components: specialpurpose/solr
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Chinmay Patidar
>Priority: Minor
>
> - Add a private constructor.
> - Make the following private static variable as final.
> {code}
> private static String[] solrProdAttribute = { "productId",
> "internalName", "manu", "size", "smallImage", "mediumImage", "largeImage",
> "listPrice", "defaultPrice", "inStock", "isVirtual" };
> {code}
> - Make the following public static variables as private
> {code}
> public static final String solrConfigName = "solrconfig.properties";
> public static final String solrUrl = makeSolrWebappUrl();
> {code}
> - Make the following protected static variables as private
> {code}
> protected static final String socketTimeoutString =
> UtilProperties.getPropertyValue(solrConfigName, "solr.client.socket.timeout");
>
> protected static final String connectionTimeoutString =
> UtilProperties.getPropertyValue(solrConfigName,
> "solr.client.connection.timeout");
>
> protected static final String clientUsername =
> UtilProperties.getPropertyValue(solrConfigName, "solr.client.username");
>
> protected static final String clientPassword =
> UtilProperties.getPropertyValue(solrConfigName, "solr.client.password");
> protected static final Integer socketTimeout = getSocketTimeout();
>
> protected static final Integer connectionTimeout = getConnectionTimeout();
>
> protected static final String trustSelfSignedCertString =
> UtilProperties.getPropertyValue(solrConfigName,
> "solr.client.trust.selfsigned.cert", "false");
>
> protected static final boolean trustSelfSignedCert =
> getTrustSelfSignedCert();
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7380) SagePayUtil class
[ https://issues.apache.org/jira/browse/OFBIZ-7380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar updated OFBIZ-7380: --- Attachment: OFBIZ-7380.patch Providing the patch for the issue. Thanks, Arun and Rishi for the discussion. > SagePayUtil class > - > > Key: OFBIZ-7380 > URL: https://issues.apache.org/jira/browse/OFBIZ-7380 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Chinmay Patidar >Priority: Minor > Attachments: OFBIZ-7380.patch > > > - Make class as final. > - Add a private constructor. > No variables exists in the class so nothing to change here. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7380) SagePayUtil class
[ https://issues.apache.org/jira/browse/OFBIZ-7380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar reassigned OFBIZ-7380: -- Assignee: Chinmay Patidar > SagePayUtil class > - > > Key: OFBIZ-7380 > URL: https://issues.apache.org/jira/browse/OFBIZ-7380 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Chinmay Patidar >Priority: Minor > > - Make class as final. > - Add a private constructor. > No variables exists in the class so nothing to change here. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7272) Enforce noninstantiability with a private constructor
[
https://issues.apache.org/jira/browse/OFBIZ-7272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chinmay Patidar updated OFBIZ-7272:
---
Attachment: OFBIZ-7272.patch
Here is the patch for the issue. Thanks Rishi Solanki and Arun Patidar for
guidance and the discussion. Following are the classes on which added private
constructor:
{code}
applications/accounting/src/org/ofbiz/accounting/invoice/InvoiceWorker.java
applications/accounting/src/org/ofbiz/accounting/payment/PaymentWorker.java
applications/accounting/src/org/ofbiz/accounting/thirdparty/sagepay/SagePayUtil.java
applications/accounting/src/org/ofbiz/accounting/util/UtilAccounting.java
applications/content/src/org/ofbiz/content/ContentManagementWorker.java
applications/content/src/org/ofbiz/content/data/DataResourceWorker.java
applications/content/src/org/ofbiz/content/layout/LayoutWorker.java
applications/content/src/org/ofbiz/content/openoffice/OpenOfficeWorker.java
applications/manufacturing/src/org/ofbiz/manufacturing/bom/BOMHelper.java
applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunHelper.java
applications/marketing/src/org/ofbiz/marketing/report/ReportHelper.java
applications/order/src/org/ofbiz/order/order/OrderChangeHelper.java
applications/order/src/org/ofbiz/order/shoppingcart/product/ProductDisplayWorker.java
applications/order/src/org/ofbiz/order/shoppingcart/product/ProductPromoWorker.java
applications/order/src/org/ofbiz/order/task/TaskWorker.java
applications/party/src/org/ofbiz/party/party/PartyRelationshipHelper.java
applications/party/src/org/ofbiz/party/party/PartyTypeHelper.java
applications/product/src/org/ofbiz/product/category/SeoConfigUtil.java
applications/product/src/org/ofbiz/product/category/SeoUrlUtil.java
applications/product/src/org/ofbiz/product/config/ProductConfigWorker.java
applications/product/src/org/ofbiz/product/imagemanagement/ImageManagementHelper.java
applications/product/src/org/ofbiz/product/inventory/InventoryWorker.java
applications/product/src/org/ofbiz/product/product/ProductUtilServices.java
applications/product/src/org/ofbiz/product/spreadsheetimport/ImportProductHelper.java
applications/product/src/org/ofbiz/product/store/ProductStoreWorker.java
applications/product/src/org/ofbiz/shipment/shipment/ShipmentWorker.java
applications/workeffort/src/org/ofbiz/workeffort/workeffort/ICalWorker.java
applications/workeffort/src/org/ofbiz/workeffort/workeffort/WorkEffortWorker.java
framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
framework/base/src/org/ofbiz/base/util/BshUtil.java
framework/base/src/org/ofbiz/base/util/FileUtil.java
framework/base/src/org/ofbiz/base/util/KeyStoreUtil.java
framework/base/src/org/ofbiz/base/util/SSLUtil.java
framework/base/src/org/ofbiz/base/util/UtilCodec.java
framework/base/src/org/ofbiz/base/util/UtilDateTime.java
framework/base/src/org/ofbiz/base/util/UtilFormatOut.java
framework/base/src/org/ofbiz/base/util/UtilGenerics.java
framework/base/src/org/ofbiz/base/util/UtilHttp.java
framework/base/src/org/ofbiz/base/util/UtilIO.java
framework/base/src/org/ofbiz/base/util/UtilJavaParse.java
framework/base/src/org/ofbiz/base/util/UtilNumber.java
framework/base/src/org/ofbiz/base/util/UtilPlist.java
framework/base/src/org/ofbiz/base/util/UtilProperties.java
framework/base/src/org/ofbiz/base/util/UtilURL.java
framework/base/src/org/ofbiz/base/util/UtilValidate.java
framework/base/src/org/ofbiz/base/util/UtilXml.java
framework/base/src/org/ofbiz/base/util/string/UelUtil.java
framework/base/src/org/ofbiz/base/util/template/FreeMarkerWorker.java
framework/common/src/org/ofbiz/common/CommonWorkers.java
framework/common/src/org/ofbiz/common/KeywordSearchUtil.java
framework/common/src/org/ofbiz/common/UrlServletHelper.java
framework/common/src/org/ofbiz/common/authentication/AuthHelper.java
framework/common/src/org/ofbiz/common/geo/GeoWorker.java
framework/common/src/org/ofbiz/common/period/PeriodWorker.java
framework/common/src/org/ofbiz/common/preferences/PreferenceWorker.java
framework/common/src/org/ofbiz/common/status/StatusWorker.java
framework/entity/src/org/ofbiz/entity/finder/EntityFinderUtil.java
framework/entity/src/org/ofbiz/entity/jdbc/DatabaseUtil.java
framework/entity/src/org/ofbiz/entity/jdbc/SqlJdbcUtil.java
framework/entity/src/org/ofbiz/entity/model/ModelUtil.java
framework/entity/src/org/ofbiz/entity/transaction/TransactionUtil.java
framework/entity/src/org/ofbiz/entity/util/EntityTypeUtil.java
framework/entity/src/org/ofbiz/entity/util/EntityUtil.java
framework/entity/src/org/ofbiz/entity/util/EntityUtilProperties.java
framework/entityext/src/org/ofbiz/entityext/EntityGroupUtil.java
framework/entityext/src/org/ofbiz/entityext/eca/EntityEcaUtil.java
framework/service/src/org/ofbiz/service/ServiceUtil.java
framework/service/src/org/ofbiz/service/calendar/RecurrenceUtil.java
framework/service/src/org/ofbiz/service/calendar/TemporalExpressionWorker.java
