[jira] Created: (OFBIZ-3946) add an SQL query manager

[Gaudin Pierre (JIRA)]

add an SQL query manager


 Key: OFBIZ-3946
 URL: https://issues.apache.org/jira/browse/OFBIZ-3946
 Project: OFBiz
  Issue Type: New Feature
  Components: framework
Affects Versions: SVN trunk
Reporter: Gaudin Pierre
 Fix For: SVN trunk


This is a new feature to manage SQL queries.
You can :
  - store/update/delete SQL query
  - store/update/delete parameters for this query
  - execute query and view results into worksheet

This SQL query manager is usefull to run frequently queries (ie: for 
maintenance report)

How to use it : 
  - goes to webtools/Entity Engine Tools
  - select "SQL queries library" item
  - create a new query and fill in SQL. If you want to use parameters, add them 
like this : select * from facility where facility_Id = '${facilityId}'
  - to declare parameters for this query then goes to  "Add or update query 
parameter" screenlet and fill in fields : description = facility id ; Parameter 
=   facilityId
  - to execute SQl query then press  buton "run"
  - fill in parameters value adn press buton "run"
  - worksheet should automaticaly open
  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (OFBIZ-3946) add an SQL query manager

[Gaudin Pierre (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-3946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gaudin Pierre updated OFBIZ-3946:
-

Attachment: query_manager_patch.txt

The patch to apply on OFBiz-trunck

> add an SQL query manager
> 
>
> Key: OFBIZ-3946
> URL: https://issues.apache.org/jira/browse/OFBIZ-3946
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: SVN trunk
>Reporter: Gaudin Pierre
> Fix For: SVN trunk
>
> Attachments: query_manager_patch.txt
>
>
> This is a new feature to manage SQL queries.
> You can :
>   - store/update/delete SQL query
>   - store/update/delete parameters for this query
>   - execute query and view results into worksheet
> This SQL query manager is usefull to run frequently queries (ie: for 
> maintenance report)
> How to use it : 
>   - goes to webtools/Entity Engine Tools
>   - select "SQL queries library" item
>   - create a new query and fill in SQL. If you want to use parameters, add 
> them like this : select * from facility where facility_Id = '${facilityId}'
>   - to declare parameters for this query then goes to  "Add or update query 
> parameter" screenlet and fill in fields : description = facility id ; 
> Parameter =   facilityId
>   - to execute SQl query then press  buton "run"
>   - fill in parameters value adn press buton "run"
>   - worksheet should automaticaly open
>   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (OFBIZ-3946) add an SQL query manager

[Gaudin Pierre (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-3946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12912457#action_12912457
 ] 

Gaudin Pierre commented on OFBIZ-3946:
--

Hi Erwan,

Thank you very mutch for this "quick look".

Could you please attach to JIRA screenshots about formating issues ?

I'll update @author tag and send you a new patch.

Best regards

Pierre



> add an SQL query manager
> 
>
> Key: OFBIZ-3946
> URL: https://issues.apache.org/jira/browse/OFBIZ-3946
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: SVN trunk
>Reporter: Gaudin Pierre
>Assignee: Erwan de FERRIERES
> Fix For: SVN trunk
>
> Attachments: query_manager_patch.txt
>
>
> This is a new feature to manage SQL queries.
> You can :
>   - store/update/delete SQL query
>   - store/update/delete parameters for this query
>   - execute query and view results into worksheet
> This SQL query manager is usefull to run frequently queries (ie: for 
> maintenance report)
> How to use it : 
>   - goes to webtools/Entity Engine Tools
>   - select "SQL queries library" item
>   - create a new query and fill in SQL. If you want to use parameters, add 
> them like this : select * from facility where facility_Id = '${facilityId}'
>   - to declare parameters for this query then goes to  "Add or update query 
> parameter" screenlet and fill in fields : description = facility id ; 
> Parameter =   facilityId
>   - to execute SQl query then press  buton "run"
>   - fill in parameters value adn press buton "run"
>   - worksheet should automaticaly open
>   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] [Created] (OFBIZ-4249) error in pagination target with on-event-update-area parameters

[Gaudin Pierre (JIRA)]

error in pagination target with on-event-update-area parameters
---

 Key: OFBIZ-4249
 URL: https://issues.apache.org/jira/browse/OFBIZ-4249
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: SVN trunk
Reporter: Gaudin Pierre


In forms, when we use the tag "on-event-update-area" with parameters, in 
certain case the parameters of the tag are not taken back in the links of 
pagination.

This is due to the fact that in certain case the url of pagination contains an 
anchor at the end of the link and parameters of the tag "on-event-update-area"  
are added after this anchor.

This patch corrects this problem by adding the parameters of the tag 
"on-event-update-area" before parameter of the form and thus before those of 
the anchor.

This is the old url : portalPortletId is a parameter of tag 
"on-event-update-area"
javascript:ajaxUpdateAreas('hhh,/myportal/control/ggg,portalPageId=MYPORTAL_EMPLOYEE1&parentPortalPageId=MYPORTAL_EMPLOYEE&partyId=admin&noConditionFind=N&VIEW_SIZE_2=3&VIEW_INDEX_2=1#portalPortletId=ListProduct')

This is the url patched :portalPortletId is a parameter of tag 
"on-event-update-area"
javascript:ajaxUpdateAreas('hhh,/myportal/control/ggg,portalPortletId=ListProduct&portalPageId=MYPORTAL_EMPLOYEE1&parentPortalPageId=MYPORTAL_EMPLOYEE&partyId=admin&noConditionFind=N&VIEW_SIZE_2=3&VIEW_INDEX_2=1#')


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (OFBIZ-4249) error in pagination target with on-event-update-area parameters

[Gaudin Pierre (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gaudin Pierre updated OFBIZ-4249:
-

Attachment: MacroFormRenderer.java.patch

> error in pagination target with on-event-update-area parameters
> ---
>
> Key: OFBIZ-4249
> URL: https://issues.apache.org/jira/browse/OFBIZ-4249
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: SVN trunk
>Reporter: Gaudin Pierre
> Attachments: MacroFormRenderer.java.patch
>
>
> In forms, when we use the tag "on-event-update-area" with parameters, in 
> certain case the parameters of the tag are not taken back in the links of 
> pagination.
> This is due to the fact that in certain case the url of pagination contains 
> an anchor at the end of the link and parameters of the tag 
> "on-event-update-area"  are added after this anchor.
> This patch corrects this problem by adding the parameters of the tag 
> "on-event-update-area" before parameter of the form and thus before those of 
> the anchor.
> This is the old url : portalPortletId is a parameter of tag 
> "on-event-update-area"
> javascript:ajaxUpdateAreas('hhh,/myportal/control/ggg,portalPageId=MYPORTAL_EMPLOYEE1&parentPortalPageId=MYPORTAL_EMPLOYEE&partyId=admin&noConditionFind=N&VIEW_SIZE_2=3&VIEW_INDEX_2=1#portalPortletId=ListProduct')
> This is the url patched :portalPortletId is a parameter of tag 
> "on-event-update-area"
> javascript:ajaxUpdateAreas('hhh,/myportal/control/ggg,portalPortletId=ListProduct&portalPageId=MYPORTAL_EMPLOYEE1&parentPortalPageId=MYPORTAL_EMPLOYEE&partyId=admin&noConditionFind=N&VIEW_SIZE_2=3&VIEW_INDEX_2=1#')

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (OFBIZ-4249) error in pagination target with on-event-update-area parameters

[Gaudin Pierre (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gaudin Pierre updated OFBIZ-4249:
-

Attachment: MacroFormRenderer.java.patch

> error in pagination target with on-event-update-area parameters
> ---
>
> Key: OFBIZ-4249
> URL: https://issues.apache.org/jira/browse/OFBIZ-4249
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: SVN trunk
>Reporter: Gaudin Pierre
> Attachments: MacroFormRenderer.java.patch
>
>
> In forms, when we use the tag "on-event-update-area" with parameters, in 
> certain case the parameters of the tag are not taken back in the links of 
> pagination.
> This is due to the fact that in certain case the url of pagination contains 
> an anchor at the end of the link and parameters of the tag 
> "on-event-update-area"  are added after this anchor.
> This patch corrects this problem by adding the parameters of the tag 
> "on-event-update-area" before parameter of the form and thus before those of 
> the anchor.
> This is the old url : portalPortletId is a parameter of tag 
> "on-event-update-area"
> javascript:ajaxUpdateAreas('hhh,/myportal/control/ggg,portalPageId=MYPORTAL_EMPLOYEE1&parentPortalPageId=MYPORTAL_EMPLOYEE&partyId=admin&noConditionFind=N&VIEW_SIZE_2=3&VIEW_INDEX_2=1#portalPortletId=ListProduct')
> This is the url patched :portalPortletId is a parameter of tag 
> "on-event-update-area"
> javascript:ajaxUpdateAreas('hhh,/myportal/control/ggg,portalPortletId=ListProduct&portalPageId=MYPORTAL_EMPLOYEE1&parentPortalPageId=MYPORTAL_EMPLOYEE&partyId=admin&noConditionFind=N&VIEW_SIZE_2=3&VIEW_INDEX_2=1#')

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (OFBIZ-4249) error in pagination target with on-event-update-area parameters

[Gaudin Pierre (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gaudin Pierre updated OFBIZ-4249:
-

Attachment: (was: MacroFormRenderer.java.patch)

> error in pagination target with on-event-update-area parameters
> ---
>
> Key: OFBIZ-4249
> URL: https://issues.apache.org/jira/browse/OFBIZ-4249
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: SVN trunk
>Reporter: Gaudin Pierre
> Attachments: MacroFormRenderer.java.patch
>
>
> In forms, when we use the tag "on-event-update-area" with parameters, in 
> certain case the parameters of the tag are not taken back in the links of 
> pagination.
> This is due to the fact that in certain case the url of pagination contains 
> an anchor at the end of the link and parameters of the tag 
> "on-event-update-area"  are added after this anchor.
> This patch corrects this problem by adding the parameters of the tag 
> "on-event-update-area" before parameter of the form and thus before those of 
> the anchor.
> This is the old url : portalPortletId is a parameter of tag 
> "on-event-update-area"
> javascript:ajaxUpdateAreas('hhh,/myportal/control/ggg,portalPageId=MYPORTAL_EMPLOYEE1&parentPortalPageId=MYPORTAL_EMPLOYEE&partyId=admin&noConditionFind=N&VIEW_SIZE_2=3&VIEW_INDEX_2=1#portalPortletId=ListProduct')
> This is the url patched :portalPortletId is a parameter of tag 
> "on-event-update-area"
> javascript:ajaxUpdateAreas('hhh,/myportal/control/ggg,portalPortletId=ListProduct&portalPageId=MYPORTAL_EMPLOYEE1&parentPortalPageId=MYPORTAL_EMPLOYEE&partyId=admin&noConditionFind=N&VIEW_SIZE_2=3&VIEW_INDEX_2=1#')

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (OFBIZ-4250) error in stock reception on same inventory item with same unit price

[Gaudin Pierre (JIRA)]

error in stock reception on same inventory item with same unit price


 Key: OFBIZ-4250
 URL: https://issues.apache.org/jira/browse/OFBIZ-4250
 Project: OFBiz
  Issue Type: Bug
  Components: accounting
Affects Versions: SVN trunk
Reporter: Gaudin Pierre
 Fix For: SVN trunk
 Attachments: GeneralLedgerServices.xml.patch

During the reception of stock, if the reception is made on a line of stock 
which already exists with the same unit price, an accounting transaction due to 
the stock price value change is created with an amount of debit and credit of 0.

This is not normal and generate an error in the service postAcctgTrans.

This aim of this patch is to avoid creation of accounting transaction linked to 
the stock price value change if the unit price does not change.


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (OFBIZ-4250) error in stock reception on same inventory item with same unit price

[Gaudin Pierre (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gaudin Pierre updated OFBIZ-4250:
-

Attachment: GeneralLedgerServices.xml.patch

> error in stock reception on same inventory item with same unit price
> 
>
> Key: OFBIZ-4250
> URL: https://issues.apache.org/jira/browse/OFBIZ-4250
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: SVN trunk
>Reporter: Gaudin Pierre
> Fix For: SVN trunk
>
> Attachments: GeneralLedgerServices.xml.patch
>
>
> During the reception of stock, if the reception is made on a line of stock 
> which already exists with the same unit price, an accounting transaction due 
> to the stock price value change is created with an amount of debit and credit 
> of 0.
> This is not normal and generate an error in the service postAcctgTrans.
> This aim of this patch is to avoid creation of accounting transaction linked 
> to the stock price value change if the unit price does not change.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (OFBIZ-4257) add a parameter to forbid order decimal quantity

[Gaudin Pierre (JIRA)]

add a parameter to forbid order decimal quantity


 Key: OFBIZ-4257
 URL: https://issues.apache.org/jira/browse/OFBIZ-4257
 Project: OFBiz
  Issue Type: Improvement
  Components: order, specialpurpose/ecommerce
Affects Versions: SVN trunk
Reporter: Gaudin Pierre
 Fix For: SVN trunk
 Attachments: 
OFBIZ-4257_add_a_parameter_to_forbid_order_decimal_quantity.patch

This is a patch to add a parameter to forbid order decimal quantity

Behavior before the patch :
   - you can add decimal quantity on shopping cart item (front office and back 
office) even if the product is a unit
   - there is no rounding on quantity on shopping cart item thus you get amount 
with a large number of decimal
   - reorder widget display quantity to reorder with a large number of decimal

What does this patch :
   - a new field "orderDecimalQuantity" is added into ProducStore entity. The 
value of this field can be set from EditProducStore form (into shopping cart 
section). Value can be "Y", "N" or empty.
   - a new field "orderDecimalQuantity" is added into Product entity. The value 
of this field can be set from EditProduc form (into shopping cart section). 
Value can be "Y", "N" or empty.
   - a new method "isDecimalQuantityOrderAllowed" have been add into 
productWorker class. This method test if order decimal quantity is allow for a 
product and a productStore. Product is superior on producStore. Here is the 
table of value :
- ProductStore.orderDecimalQuantity = "Y" &&   
Product.orderDecimalQuantity = "Y" => return True
- ProductStore.orderDecimalQuantity = "N" &&   
Product.orderDecimalQuantity = "Y" => return True
- ProductStore.orderDecimalQuantity = empty &&   
Product.orderDecimalQuantity = "Y" => return True
- ProductStore.orderDecimalQuantity = "Y" &&   
Product.orderDecimalQuantity = "N" => return False
- ProductStore.orderDecimalQuantity = "N" &&   
Product.orderDecimalQuantity = "N" => return False
- ProductStore.orderDecimalQuantity = empty &&   
Product.orderDecimalQuantity = "N" => return False
- ProductStore.orderDecimalQuantity = "Y" &&   
Product.orderDecimalQuantity = empty => return True
- ProductStore.orderDecimalQuantity = "N" &&   
Product.orderDecimalQuantity = empty => return False
- ProductStore.orderDecimalQuantity = empty &&   
Product.orderDecimalQuantity = empty => return True
   - addToCat and modifyCart car method have been modify to call 
isDecimalQuantityOrderAllowed. If result is true then quantity is rounding with 
order config value. If result is false then quantity is rounding to 0. No 
message is return.
   - to fix reorder quantity, then getQuickReorderProducts method have been 
modify to call isDecimalQuantityOrderAllowed. If result is true then quantity 
is rounding with order config value. If result is false then quantity is 
rounding to 0.

What the result :
   - You can forbid or accept to manage order decimal quantity for all product
   - You can forbid or accept to manage order decimal quantity for one product
   - Decimal quantity are now rounded with order config value.
   - reorder quantity is rounded with order config value or rounding to 0

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (OFBIZ-4257) add a parameter to forbid order decimal quantity

[Gaudin Pierre (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gaudin Pierre updated OFBIZ-4257:
-

Attachment: 
OFBIZ-4257_add_a_parameter_to_forbid_order_decimal_quantity.patch

> add a parameter to forbid order decimal quantity
> 
>
> Key: OFBIZ-4257
> URL: https://issues.apache.org/jira/browse/OFBIZ-4257
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order, specialpurpose/ecommerce
>Affects Versions: SVN trunk
>Reporter: Gaudin Pierre
> Fix For: SVN trunk
>
> Attachments: 
> OFBIZ-4257_add_a_parameter_to_forbid_order_decimal_quantity.patch
>
>
> This is a patch to add a parameter to forbid order decimal quantity
> Behavior before the patch :
>- you can add decimal quantity on shopping cart item (front office and 
> back office) even if the product is a unit
>- there is no rounding on quantity on shopping cart item thus you get 
> amount with a large number of decimal
>- reorder widget display quantity to reorder with a large number of decimal
> What does this patch :
>- a new field "orderDecimalQuantity" is added into ProducStore entity. The 
> value of this field can be set from EditProducStore form (into shopping cart 
> section). Value can be "Y", "N" or empty.
>- a new field "orderDecimalQuantity" is added into Product entity. The 
> value of this field can be set from EditProduc form (into shopping cart 
> section). Value can be "Y", "N" or empty.
>- a new method "isDecimalQuantityOrderAllowed" have been add into 
> productWorker class. This method test if order decimal quantity is allow for 
> a product and a productStore. Product is superior on producStore. Here is the 
> table of value :
> - ProductStore.orderDecimalQuantity = "Y" &&   
> Product.orderDecimalQuantity = "Y" => return True
> - ProductStore.orderDecimalQuantity = "N" &&   
> Product.orderDecimalQuantity = "Y" => return True
> - ProductStore.orderDecimalQuantity = empty &&   
> Product.orderDecimalQuantity = "Y" => return True
> - ProductStore.orderDecimalQuantity = "Y" &&   
> Product.orderDecimalQuantity = "N" => return False
> - ProductStore.orderDecimalQuantity = "N" &&   
> Product.orderDecimalQuantity = "N" => return False
> - ProductStore.orderDecimalQuantity = empty &&   
> Product.orderDecimalQuantity = "N" => return False
> - ProductStore.orderDecimalQuantity = "Y" &&   
> Product.orderDecimalQuantity = empty => return True
> - ProductStore.orderDecimalQuantity = "N" &&   
> Product.orderDecimalQuantity = empty => return False
> - ProductStore.orderDecimalQuantity = empty &&   
> Product.orderDecimalQuantity = empty => return True
>- addToCat and modifyCart car method have been modify to call 
> isDecimalQuantityOrderAllowed. If result is true then quantity is rounding 
> with order config value. If result is false then quantity is rounding to 0. 
> No message is return.
>- to fix reorder quantity, then getQuickReorderProducts method have been 
> modify to call isDecimalQuantityOrderAllowed. If result is true then quantity 
> is rounding with order config value. If result is false then quantity is 
> rounding to 0.
> What the result :
>- You can forbid or accept to manage order decimal quantity for all product
>- You can forbid or accept to manage order decimal quantity for one product
>- Decimal quantity are now rounded with order config value.
>- reorder quantity is rounded with order config value or rounding to 0

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4257) add a parameter to forbid order decimal quantity

[Gaudin Pierre (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13020858#comment-13020858
 ] 

Gaudin Pierre commented on OFBIZ-4257:
--

Thank you Jacques for the quick commite !!

Pierre


> add a parameter to forbid order decimal quantity
> 
>
> Key: OFBIZ-4257
> URL: https://issues.apache.org/jira/browse/OFBIZ-4257
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order, specialpurpose/ecommerce
>Affects Versions: SVN trunk
>Reporter: Gaudin Pierre
>Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: 
> OFBIZ-4257_add_a_parameter_to_forbid_order_decimal_quantity.patch
>
>
> This is a patch to add a parameter to forbid order decimal quantity
> Behavior before the patch :
>- you can add decimal quantity on shopping cart item (front office and 
> back office) even if the product is a unit
>- there is no rounding on quantity on shopping cart item thus you get 
> amount with a large number of decimal
>- reorder widget display quantity to reorder with a large number of decimal
> What does this patch :
>- a new field "orderDecimalQuantity" is added into ProducStore entity. The 
> value of this field can be set from EditProducStore form (into shopping cart 
> section). Value can be "Y", "N" or empty.
>- a new field "orderDecimalQuantity" is added into Product entity. The 
> value of this field can be set from EditProduc form (into shopping cart 
> section). Value can be "Y", "N" or empty.
>- a new method "isDecimalQuantityOrderAllowed" have been add into 
> productWorker class. This method test if order decimal quantity is allow for 
> a product and a productStore. Product is superior on producStore. Here is the 
> table of value :
> - ProductStore.orderDecimalQuantity = "Y" &&   
> Product.orderDecimalQuantity = "Y" => return True
> - ProductStore.orderDecimalQuantity = "N" &&   
> Product.orderDecimalQuantity = "Y" => return True
> - ProductStore.orderDecimalQuantity = empty &&   
> Product.orderDecimalQuantity = "Y" => return True
> - ProductStore.orderDecimalQuantity = "Y" &&   
> Product.orderDecimalQuantity = "N" => return False
> - ProductStore.orderDecimalQuantity = "N" &&   
> Product.orderDecimalQuantity = "N" => return False
> - ProductStore.orderDecimalQuantity = empty &&   
> Product.orderDecimalQuantity = "N" => return False
> - ProductStore.orderDecimalQuantity = "Y" &&   
> Product.orderDecimalQuantity = empty => return True
> - ProductStore.orderDecimalQuantity = "N" &&   
> Product.orderDecimalQuantity = empty => return False
> - ProductStore.orderDecimalQuantity = empty &&   
> Product.orderDecimalQuantity = empty => return True
>- addToCat and modifyCart car method have been modify to call 
> isDecimalQuantityOrderAllowed. If result is true then quantity is rounding 
> with order config value. If result is false then quantity is rounding to 0. 
> No message is return.
>- to fix reorder quantity, then getQuickReorderProducts method have been 
> modify to call isDecimalQuantityOrderAllowed. If result is true then quantity 
> is rounding with order config value. If result is false then quantity is 
> rounding to 0.
> What the result :
>- You can forbid or accept to manage order decimal quantity for all product
>- You can forbid or accept to manage order decimal quantity for one product
>- Decimal quantity are now rounded with order config value.
>- reorder quantity is rounded with order config value or rounding to 0

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4250) error in stock reception on same inventory item with same unit price

[Gaudin Pierre (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-4250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13020860#comment-13020860
 ] 

Gaudin Pierre commented on OFBIZ-4250:
--

Many thanks Jacques !

Pierre

> error in stock reception on same inventory item with same unit price
> 
>
> Key: OFBIZ-4250
> URL: https://issues.apache.org/jira/browse/OFBIZ-4250
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: SVN trunk
>Reporter: Gaudin Pierre
>Assignee: Jacques Le Roux
> Fix For: Release Branch 09.04, Release Branch 10.04, SVN trunk
>
> Attachments: GeneralLedgerServices.xml.patch
>
>
> During the reception of stock, if the reception is made on a line of stock 
> which already exists with the same unit price, an accounting transaction due 
> to the stock price value change is created with an amount of debit and credit 
> of 0.
> This is not normal and generate an error in the service postAcctgTrans.
> This aim of this patch is to avoid creation of accounting transaction linked 
> to the stock price value change if the unit price does not change.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4249) error in pagination target with on-event-update-area parameters

[Gaudin Pierre (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-4249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025414#comment-13025414
 ] 

Gaudin Pierre commented on OFBIZ-4249:
--

Many thanks Erwan !

> error in pagination target with on-event-update-area parameters
> ---
>
> Key: OFBIZ-4249
> URL: https://issues.apache.org/jira/browse/OFBIZ-4249
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: SVN trunk
>Reporter: Gaudin Pierre
>Assignee: Erwan de FERRIERES
> Fix For: SVN trunk
>
> Attachments: MacroFormRenderer.java.patch
>
>
> In forms, when we use the tag "on-event-update-area" with parameters, in 
> certain case the parameters of the tag are not taken back in the links of 
> pagination.
> This is due to the fact that in certain case the url of pagination contains 
> an anchor at the end of the link and parameters of the tag 
> "on-event-update-area"  are added after this anchor.
> This patch corrects this problem by adding the parameters of the tag 
> "on-event-update-area" before parameter of the form and thus before those of 
> the anchor.
> This is the old url : portalPortletId is a parameter of tag 
> "on-event-update-area"
> javascript:ajaxUpdateAreas('hhh,/myportal/control/ggg,portalPageId=MYPORTAL_EMPLOYEE1&parentPortalPageId=MYPORTAL_EMPLOYEE&partyId=admin&noConditionFind=N&VIEW_SIZE_2=3&VIEW_INDEX_2=1#portalPortletId=ListProduct')
> This is the url patched :portalPortletId is a parameter of tag 
> "on-event-update-area"
> javascript:ajaxUpdateAreas('hhh,/myportal/control/ggg,portalPortletId=ListProduct&portalPageId=MYPORTAL_EMPLOYEE1&parentPortalPageId=MYPORTAL_EMPLOYEE&partyId=admin&noConditionFind=N&VIEW_SIZE_2=3&VIEW_INDEX_2=1#')

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Reopened] (OFBIZ-4257) add a parameter to forbid order decimal quantity

[Gaudin Pierre (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gaudin Pierre reopened OFBIZ-4257:
--


There is an issue on Purchase order because when you try do add a quantity more 
than one because cart.getProductStoreId() return a null value... 

Is that normal that cart.getProductStoreId() is null for PO ?

Thanks

Pierre

> add a parameter to forbid order decimal quantity
> 
>
> Key: OFBIZ-4257
> URL: https://issues.apache.org/jira/browse/OFBIZ-4257
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order, specialpurpose/ecommerce
>Affects Versions: SVN trunk
>Reporter: Gaudin Pierre
>Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: 
> OFBIZ-4257_add_a_parameter_to_forbid_order_decimal_quantity.patch
>
>
> This is a patch to add a parameter to forbid order decimal quantity
> Behavior before the patch :
>- you can add decimal quantity on shopping cart item (front office and 
> back office) even if the product is a unit
>- there is no rounding on quantity on shopping cart item thus you get 
> amount with a large number of decimal
>- reorder widget display quantity to reorder with a large number of decimal
> What does this patch :
>- a new field "orderDecimalQuantity" is added into ProducStore entity. The 
> value of this field can be set from EditProducStore form (into shopping cart 
> section). Value can be "Y", "N" or empty.
>- a new field "orderDecimalQuantity" is added into Product entity. The 
> value of this field can be set from EditProduc form (into shopping cart 
> section). Value can be "Y", "N" or empty.
>- a new method "isDecimalQuantityOrderAllowed" have been add into 
> productWorker class. This method test if order decimal quantity is allow for 
> a product and a productStore. Product is superior on producStore. Here is the 
> table of value :
> - ProductStore.orderDecimalQuantity = "Y" &&   
> Product.orderDecimalQuantity = "Y" => return True
> - ProductStore.orderDecimalQuantity = "N" &&   
> Product.orderDecimalQuantity = "Y" => return True
> - ProductStore.orderDecimalQuantity = empty &&   
> Product.orderDecimalQuantity = "Y" => return True
> - ProductStore.orderDecimalQuantity = "Y" &&   
> Product.orderDecimalQuantity = "N" => return False
> - ProductStore.orderDecimalQuantity = "N" &&   
> Product.orderDecimalQuantity = "N" => return False
> - ProductStore.orderDecimalQuantity = empty &&   
> Product.orderDecimalQuantity = "N" => return False
> - ProductStore.orderDecimalQuantity = "Y" &&   
> Product.orderDecimalQuantity = empty => return True
> - ProductStore.orderDecimalQuantity = "N" &&   
> Product.orderDecimalQuantity = empty => return False
> - ProductStore.orderDecimalQuantity = empty &&   
> Product.orderDecimalQuantity = empty => return True
>- addToCat and modifyCart car method have been modify to call 
> isDecimalQuantityOrderAllowed. If result is true then quantity is rounding 
> with order config value. If result is false then quantity is rounding to 0. 
> No message is return.
>- to fix reorder quantity, then getQuickReorderProducts method have been 
> modify to call isDecimalQuantityOrderAllowed. If result is true then quantity 
> is rounding with order config value. If result is false then quantity is 
> rounding to 0.
> What the result :
>- You can forbid or accept to manage order decimal quantity for all product
>- You can forbid or accept to manage order decimal quantity for one product
>- Decimal quantity are now rounded with order config value.
>- reorder quantity is rounded with order config value or rounding to 0

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4257) add a parameter to forbid order decimal quantity

[Gaudin Pierre (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025703#comment-13025703
 ] 

Gaudin Pierre commented on OFBIZ-4257:
--

No I didn't try but i will.

But can we imagine an order without productStore ?? i don't think so.

Pierre


> add a parameter to forbid order decimal quantity
> 
>
> Key: OFBIZ-4257
> URL: https://issues.apache.org/jira/browse/OFBIZ-4257
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order, specialpurpose/ecommerce
>Affects Versions: SVN trunk
>Reporter: Gaudin Pierre
>Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: 
> OFBIZ-4257_add_a_parameter_to_forbid_order_decimal_quantity.patch
>
>
> This is a patch to add a parameter to forbid order decimal quantity
> Behavior before the patch :
>- you can add decimal quantity on shopping cart item (front office and 
> back office) even if the product is a unit
>- there is no rounding on quantity on shopping cart item thus you get 
> amount with a large number of decimal
>- reorder widget display quantity to reorder with a large number of decimal
> What does this patch :
>- a new field "orderDecimalQuantity" is added into ProducStore entity. The 
> value of this field can be set from EditProducStore form (into shopping cart 
> section). Value can be "Y", "N" or empty.
>- a new field "orderDecimalQuantity" is added into Product entity. The 
> value of this field can be set from EditProduc form (into shopping cart 
> section). Value can be "Y", "N" or empty.
>- a new method "isDecimalQuantityOrderAllowed" have been add into 
> productWorker class. This method test if order decimal quantity is allow for 
> a product and a productStore. Product is superior on producStore. Here is the 
> table of value :
> - ProductStore.orderDecimalQuantity = "Y" &&   
> Product.orderDecimalQuantity = "Y" => return True
> - ProductStore.orderDecimalQuantity = "N" &&   
> Product.orderDecimalQuantity = "Y" => return True
> - ProductStore.orderDecimalQuantity = empty &&   
> Product.orderDecimalQuantity = "Y" => return True
> - ProductStore.orderDecimalQuantity = "Y" &&   
> Product.orderDecimalQuantity = "N" => return False
> - ProductStore.orderDecimalQuantity = "N" &&   
> Product.orderDecimalQuantity = "N" => return False
> - ProductStore.orderDecimalQuantity = empty &&   
> Product.orderDecimalQuantity = "N" => return False
> - ProductStore.orderDecimalQuantity = "Y" &&   
> Product.orderDecimalQuantity = empty => return True
> - ProductStore.orderDecimalQuantity = "N" &&   
> Product.orderDecimalQuantity = empty => return False
> - ProductStore.orderDecimalQuantity = empty &&   
> Product.orderDecimalQuantity = empty => return True
>- addToCat and modifyCart car method have been modify to call 
> isDecimalQuantityOrderAllowed. If result is true then quantity is rounding 
> with order config value. If result is false then quantity is rounding to 0. 
> No message is return.
>- to fix reorder quantity, then getQuickReorderProducts method have been 
> modify to call isDecimalQuantityOrderAllowed. If result is true then quantity 
> is rounding with order config value. If result is false then quantity is 
> rounding to 0.
> What the result :
>- You can forbid or accept to manage order decimal quantity for all product
>- You can forbid or accept to manage order decimal quantity for one product
>- Decimal quantity are now rounded with order config value.
>- reorder quantity is rounded with order config value or rounding to 0

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4257) add a parameter to forbid order decimal quantity

[Gaudin Pierre (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025714#comment-13025714
 ] 

Gaudin Pierre commented on OFBIZ-4257:
--

OK i just try to create PO on demo Trunck and demo 9.04

OrderHeader.productStoreId is empty on Trunck
OrderHeader.productStoreId is NOT empty on 9.04

So i will create a new JIRA on this regression and close this one if you agree 
with me.

Pierre


> add a parameter to forbid order decimal quantity
> 
>
> Key: OFBIZ-4257
> URL: https://issues.apache.org/jira/browse/OFBIZ-4257
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order, specialpurpose/ecommerce
>Affects Versions: SVN trunk
>Reporter: Gaudin Pierre
>Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: 
> OFBIZ-4257_add_a_parameter_to_forbid_order_decimal_quantity.patch
>
>
> This is a patch to add a parameter to forbid order decimal quantity
> Behavior before the patch :
>- you can add decimal quantity on shopping cart item (front office and 
> back office) even if the product is a unit
>- there is no rounding on quantity on shopping cart item thus you get 
> amount with a large number of decimal
>- reorder widget display quantity to reorder with a large number of decimal
> What does this patch :
>- a new field "orderDecimalQuantity" is added into ProducStore entity. The 
> value of this field can be set from EditProducStore form (into shopping cart 
> section). Value can be "Y", "N" or empty.
>- a new field "orderDecimalQuantity" is added into Product entity. The 
> value of this field can be set from EditProduc form (into shopping cart 
> section). Value can be "Y", "N" or empty.
>- a new method "isDecimalQuantityOrderAllowed" have been add into 
> productWorker class. This method test if order decimal quantity is allow for 
> a product and a productStore. Product is superior on producStore. Here is the 
> table of value :
> - ProductStore.orderDecimalQuantity = "Y" &&   
> Product.orderDecimalQuantity = "Y" => return True
> - ProductStore.orderDecimalQuantity = "N" &&   
> Product.orderDecimalQuantity = "Y" => return True
> - ProductStore.orderDecimalQuantity = empty &&   
> Product.orderDecimalQuantity = "Y" => return True
> - ProductStore.orderDecimalQuantity = "Y" &&   
> Product.orderDecimalQuantity = "N" => return False
> - ProductStore.orderDecimalQuantity = "N" &&   
> Product.orderDecimalQuantity = "N" => return False
> - ProductStore.orderDecimalQuantity = empty &&   
> Product.orderDecimalQuantity = "N" => return False
> - ProductStore.orderDecimalQuantity = "Y" &&   
> Product.orderDecimalQuantity = empty => return True
> - ProductStore.orderDecimalQuantity = "N" &&   
> Product.orderDecimalQuantity = empty => return False
> - ProductStore.orderDecimalQuantity = empty &&   
> Product.orderDecimalQuantity = empty => return True
>- addToCat and modifyCart car method have been modify to call 
> isDecimalQuantityOrderAllowed. If result is true then quantity is rounding 
> with order config value. If result is false then quantity is rounding to 0. 
> No message is return.
>- to fix reorder quantity, then getQuickReorderProducts method have been 
> modify to call isDecimalQuantityOrderAllowed. If result is true then quantity 
> is rounding with order config value. If result is false then quantity is 
> rounding to 0.
> What the result :
>- You can forbid or accept to manage order decimal quantity for all product
>- You can forbid or accept to manage order decimal quantity for one product
>- Decimal quantity are now rounded with order config value.
>- reorder quantity is rounded with order config value or rounding to 0

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (OFBIZ-4257) add a parameter to forbid order decimal quantity

[Gaudin Pierre (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gaudin Pierre resolved OFBIZ-4257.
--

Resolution: Fixed

> add a parameter to forbid order decimal quantity
> 
>
> Key: OFBIZ-4257
> URL: https://issues.apache.org/jira/browse/OFBIZ-4257
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order, specialpurpose/ecommerce
>Affects Versions: SVN trunk
>Reporter: Gaudin Pierre
>Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: 
> OFBIZ-4257_add_a_parameter_to_forbid_order_decimal_quantity.patch
>
>
> This is a patch to add a parameter to forbid order decimal quantity
> Behavior before the patch :
>- you can add decimal quantity on shopping cart item (front office and 
> back office) even if the product is a unit
>- there is no rounding on quantity on shopping cart item thus you get 
> amount with a large number of decimal
>- reorder widget display quantity to reorder with a large number of decimal
> What does this patch :
>- a new field "orderDecimalQuantity" is added into ProducStore entity. The 
> value of this field can be set from EditProducStore form (into shopping cart 
> section). Value can be "Y", "N" or empty.
>- a new field "orderDecimalQuantity" is added into Product entity. The 
> value of this field can be set from EditProduc form (into shopping cart 
> section). Value can be "Y", "N" or empty.
>- a new method "isDecimalQuantityOrderAllowed" have been add into 
> productWorker class. This method test if order decimal quantity is allow for 
> a product and a productStore. Product is superior on producStore. Here is the 
> table of value :
> - ProductStore.orderDecimalQuantity = "Y" &&   
> Product.orderDecimalQuantity = "Y" => return True
> - ProductStore.orderDecimalQuantity = "N" &&   
> Product.orderDecimalQuantity = "Y" => return True
> - ProductStore.orderDecimalQuantity = empty &&   
> Product.orderDecimalQuantity = "Y" => return True
> - ProductStore.orderDecimalQuantity = "Y" &&   
> Product.orderDecimalQuantity = "N" => return False
> - ProductStore.orderDecimalQuantity = "N" &&   
> Product.orderDecimalQuantity = "N" => return False
> - ProductStore.orderDecimalQuantity = empty &&   
> Product.orderDecimalQuantity = "N" => return False
> - ProductStore.orderDecimalQuantity = "Y" &&   
> Product.orderDecimalQuantity = empty => return True
> - ProductStore.orderDecimalQuantity = "N" &&   
> Product.orderDecimalQuantity = empty => return False
> - ProductStore.orderDecimalQuantity = empty &&   
> Product.orderDecimalQuantity = empty => return True
>- addToCat and modifyCart car method have been modify to call 
> isDecimalQuantityOrderAllowed. If result is true then quantity is rounding 
> with order config value. If result is false then quantity is rounding to 0. 
> No message is return.
>- to fix reorder quantity, then getQuickReorderProducts method have been 
> modify to call isDecimalQuantityOrderAllowed. If result is true then quantity 
> is rounding with order config value. If result is false then quantity is 
> rounding to 0.
> What the result :
>- You can forbid or accept to manage order decimal quantity for all product
>- You can forbid or accept to manage order decimal quantity for one product
>- Decimal quantity are now rounded with order config value.
>- reorder quantity is rounded with order config value or rounding to 0

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (OFBIZ-4266) productStore is empty for Purcahse Order

[Gaudin Pierre (JIRA)]

productStore is empty for Purcahse Order


 Key: OFBIZ-4266
 URL: https://issues.apache.org/jira/browse/OFBIZ-4266
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: SVN trunk
Reporter: Gaudin Pierre


The field orderHeader.productStoreId is empty for purchase order. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4266) productStore is empty for Purcahse Order

[Gaudin Pierre (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-4266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025757#comment-13025757
 ] 

Gaudin Pierre commented on OFBIZ-4266:
--

Gaudin Pierre added a comment - 27/Apr/11 08:59

There is an issue on Purchase order because when you try do add a quantity more 
than one because cart.getProductStoreId() return a null value...

Is that normal that cart.getProductStoreId() is null for PO ?

Thanks

Pierre
Show
Gaudin Pierre added a comment - 27/Apr/11 08:59 There is an issue on Purchase 
order because when you try do add a quantity more than one because 
cart.getProductStoreId() return a null value... Is that normal that 
cart.getProductStoreId() is null for PO ? Thanks Pierre
Hide
Permalink
Jacques Le Roux added a comment - 27/Apr/11 09:49

Hi Pierre,

Did you test the same with R10.04 or even R9.04 demo ? (to see if it's not a 
regression)
Show
Jacques Le Roux added a comment - 27/Apr/11 09:49 Hi Pierre, Did you test the 
same with R10.04 or even R9.04 demo ? (to see if it's not a regression)
Hide
Permalink Edit Delete
Gaudin Pierre added a comment - 27/Apr/11 10:02

No I didn't try but i will.

But can we imagine an order without productStore ?? i don't think so.

Pierre
Show
Gaudin Pierre added a comment - 27/Apr/11 10:02 No I didn't try but i will. But 
can we imagine an order without productStore ?? i don't think so. Pierre
Hide
Permalink Edit Delete
Gaudin Pierre added a comment - 27/Apr/11 10:18

OK i just try to create PO on demo Trunck and demo 9.04

OrderHeader.productStoreId is empty on Trunck
OrderHeader.productStoreId is NOT empty on 9.04

So i will create a new JIRA on this regression and close this one if you agree 
with me.

Pierre
Show
Gaudin Pierre added a comment - 27/Apr/11 10:18 OK i just try to create PO on 
demo Trunck and demo 9.04 OrderHeader.productStoreId is empty on Trunck 
OrderHeader.productStoreId is NOT empty on 9.04 So i will create a new JIRA on 
this regression and close this one if you agree with me. Pierre
Hide
Permalink
Jacques Le Roux added a comment - 27/Apr/11 10:24

This has been recently discussed on user ML. In Opentaps they created a dummy 
Product Store for that, but I tend to agree with Paul...
Show
Jacques Le Roux added a comment - 27/Apr/11 10:24 This has been recently 
discussed on user ML. In Opentaps they created a dummy Product Store for that, 
but I tend to agree with Paul...
Hide
Permalink
Jacques Le Roux added a comment - 27/Apr/11 11:00

Pierre,

Interesting, our comments crossed on wire. So it was working in R9.04, yes we 
need to investigate at least. I agree a Jira for that is welcome...


> productStore is empty for Purcahse Order
> 
>
> Key: OFBIZ-4266
> URL: https://issues.apache.org/jira/browse/OFBIZ-4266
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: SVN trunk
>Reporter: Gaudin Pierre
>
> The field orderHeader.productStoreId is empty for purchase order. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Issue Comment Edited] (OFBIZ-4266) productStore is empty for Purcahse Order

[Gaudin Pierre (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-4266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025757#comment-13025757
 ] 

Gaudin Pierre edited comment on OFBIZ-4266 at 4/27/11 12:13 PM:


Previous comment : 

=> Gaudin Pierre added a comment - 27/Apr/11 08:59

There is an issue on Purchase order because when you try do add a quantity more 
than one because cart.getProductStoreId() return a null value...

Is that normal that cart.getProductStoreId() is null for PO ?

Thanks

Pierre
Show


=> Jacques Le Roux added a comment - 27/Apr/11 09:49

Hi Pierre,

Did you test the same with R10.04 or even R9.04 demo ? (to see if it's not a 
regression)
Show

=> Gaudin Pierre added a comment - 27/Apr/11 10:02

No I didn't try but i will.

But can we imagine an order without productStore ?? i don't think so.

Pierre


=> Gaudin Pierre added a comment - 27/Apr/11 10:18

OK i just try to create PO on demo Trunck and demo 9.04

OrderHeader.productStoreId is empty on Trunck
OrderHeader.productStoreId is NOT empty on 9.04

So i will create a new JIRA on this regression and close this one if you agree 
with me.

Pierre


=> Jacques Le Roux added a comment - 27/Apr/11 10:24

This has been recently discussed on user ML. In Opentaps they created a dummy 
Product Store for that, but I tend to agree with Paul...
Show


=> Jacques Le Roux added a comment - 27/Apr/11 11:00

Pierre,

Interesting, our comments crossed on wire. So it was working in R9.04, yes we 
need to investigate at least. I agree a Jira for that is welcome...


  was (Author: gpierre):
Gaudin Pierre added a comment - 27/Apr/11 08:59

There is an issue on Purchase order because when you try do add a quantity more 
than one because cart.getProductStoreId() return a null value...

Is that normal that cart.getProductStoreId() is null for PO ?

Thanks

Pierre
Show
Gaudin Pierre added a comment - 27/Apr/11 08:59 There is an issue on Purchase 
order because when you try do add a quantity more than one because 
cart.getProductStoreId() return a null value... Is that normal that 
cart.getProductStoreId() is null for PO ? Thanks Pierre
Hide
Permalink
Jacques Le Roux added a comment - 27/Apr/11 09:49

Hi Pierre,

Did you test the same with R10.04 or even R9.04 demo ? (to see if it's not a 
regression)
Show
Jacques Le Roux added a comment - 27/Apr/11 09:49 Hi Pierre, Did you test the 
same with R10.04 or even R9.04 demo ? (to see if it's not a regression)
Hide
Permalink Edit Delete
Gaudin Pierre added a comment - 27/Apr/11 10:02

No I didn't try but i will.

But can we imagine an order without productStore ?? i don't think so.

Pierre
Show
Gaudin Pierre added a comment - 27/Apr/11 10:02 No I didn't try but i will. But 
can we imagine an order without productStore ?? i don't think so. Pierre
Hide
Permalink Edit Delete
Gaudin Pierre added a comment - 27/Apr/11 10:18

OK i just try to create PO on demo Trunck and demo 9.04

OrderHeader.productStoreId is empty on Trunck
OrderHeader.productStoreId is NOT empty on 9.04

So i will create a new JIRA on this regression and close this one if you agree 
with me.

Pierre
Show
Gaudin Pierre added a comment - 27/Apr/11 10:18 OK i just try to create PO on 
demo Trunck and demo 9.04 OrderHeader.productStoreId is empty on Trunck 
OrderHeader.productStoreId is NOT empty on 9.04 So i will create a new JIRA on 
this regression and close this one if you agree with me. Pierre
Hide
Permalink
Jacques Le Roux added a comment - 27/Apr/11 10:24

This has been recently discussed on user ML. In Opentaps they created a dummy 
Product Store for that, but I tend to agree with Paul...
Show
Jacques Le Roux added a comment - 27/Apr/11 10:24 This has been recently 
discussed on user ML. In Opentaps they created a dummy Product Store for that, 
but I tend to agree with Paul...
Hide
Permalink
Jacques Le Roux added a comment - 27/Apr/11 11:00

Pierre,

Interesting, our comments crossed on wire. So it was working in R9.04, yes we 
need to investigate at least. I agree a Jira for that is welcome...

  
> productStore is empty for Purcahse Order
> 
>
> Key: OFBIZ-4266
> URL: https://issues.apache.org/jira/browse/OFBIZ-4266
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: SVN trunk
>Reporter: Gaudin Pierre
>
> The field orderHeader.productStoreId is empty for purchase order. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4266) productStore is empty for Purcahse Order

[Gaudin Pierre (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-4266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025762#comment-13025762
 ] 

Gaudin Pierre commented on OFBIZ-4266:
--

Thank you for the link Jacques.

A simple way should be to add a drop down with available productStore on the PO 
creation order form such as SO creation form.

Pierre


> productStore is empty for Purcahse Order
> 
>
> Key: OFBIZ-4266
> URL: https://issues.apache.org/jira/browse/OFBIZ-4266
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: SVN trunk
>Reporter: Gaudin Pierre
>
> The field orderHeader.productStoreId is empty for purchase order. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4266) ProductStore is empty for Purchase Order

[Gaudin Pierre (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-4266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025777#comment-13025777
 ] 

Gaudin Pierre commented on OFBIZ-4266:
--

Thank you Hans for the reply,

Can you explain why "productStoreid is empty for purchase orders is normal" ?

thanks,

Pierre

> ProductStore is empty for Purchase Order
> 
>
> Key: OFBIZ-4266
> URL: https://issues.apache.org/jira/browse/OFBIZ-4266
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: SVN trunk
>Reporter: Gaudin Pierre
>
> The field orderHeader.productStoreId is empty for purchase order. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4266) ProductStore is empty for Purchase Order

[Gaudin Pierre (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-4266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026003#comment-13026003
 ] 

Gaudin Pierre commented on OFBIZ-4266:
--

Hi Hans,
On 27/04/2011 15:01, Hans Bakker wrote:
> As i wrote, product stores are for selling , not buying.
>
> So, if you going to purchase a product, why would you like to have it
> connected to a productStore? What is the advantage?

I understand the logic, but shouldn’t you see the productStore also as the 
place where to set parameters for the cart and order entities? PO and the SO 
use the same objects, so it is not illogical that the productStore is used for 
sales and purchases.

For example, if I want to send e-mail to the suppliers on order status change 
why not to use the available configuration at the productStore?
I think that there are other possible examples.

Without making productStore mandatory, I think that it would be necessary to be 
able to at least specify it in parameter of creation of the purchase order.
> I did not initiate this change although it sound logical to me
>
> search the mailing list archives i can remember there was a discussion
> about it.
I found a main thread but with not enough explanation
http://ofbiz.135035.n4.nabble.com/jira-Created-OFBIZ-1172-Order-Entry-unclear-error-when-no-ProductStore-set-td204660.html

Regards,

Pierre 

> ProductStore is empty for Purchase Order
> 
>
> Key: OFBIZ-4266
> URL: https://issues.apache.org/jira/browse/OFBIZ-4266
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: SVN trunk
>Reporter: Gaudin Pierre
>
> The field orderHeader.productStoreId is empty for purchase order. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (OFBIZ-4266) ProductStore is empty for Purchase Order

[Gaudin Pierre (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gaudin Pierre closed OFBIZ-4266.


Resolution: Not A Problem

> ProductStore is empty for Purchase Order
> 
>
> Key: OFBIZ-4266
> URL: https://issues.apache.org/jira/browse/OFBIZ-4266
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: SVN trunk
>Reporter: Gaudin Pierre
>
> The field orderHeader.productStoreId is empty for purchase order. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4266) ProductStore is empty for Purchase Order

[Gaudin Pierre (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-4266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026926#comment-13026926
 ] 

Gaudin Pierre commented on OFBIZ-4266:
--

OK,

Thank you for your points of seen. 

I am going to close this JIRA. 

> ProductStore is empty for Purchase Order
> 
>
> Key: OFBIZ-4266
> URL: https://issues.apache.org/jira/browse/OFBIZ-4266
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: SVN trunk
>Reporter: Gaudin Pierre
>
> The field orderHeader.productStoreId is empty for purchase order. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Reopened] (OFBIZ-4257) add a parameter to forbid order decimal quantity

[Gaudin Pierre (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gaudin Pierre reopened OFBIZ-4257:
--


I finaly reopen this JIRA and add a patch to fix NPE

Pierre

> add a parameter to forbid order decimal quantity
> 
>
> Key: OFBIZ-4257
> URL: https://issues.apache.org/jira/browse/OFBIZ-4257
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order, specialpurpose/ecommerce
>Affects Versions: SVN trunk
>Reporter: Gaudin Pierre
>Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: 
> OFBIZ-4257_add_a_parameter_to_forbid_order_decimal_quantity.patch
>
>
> This is a patch to add a parameter to forbid order decimal quantity
> Behavior before the patch :
>- you can add decimal quantity on shopping cart item (front office and 
> back office) even if the product is a unit
>- there is no rounding on quantity on shopping cart item thus you get 
> amount with a large number of decimal
>- reorder widget display quantity to reorder with a large number of decimal
> What does this patch :
>- a new field "orderDecimalQuantity" is added into ProducStore entity. The 
> value of this field can be set from EditProducStore form (into shopping cart 
> section). Value can be "Y", "N" or empty.
>- a new field "orderDecimalQuantity" is added into Product entity. The 
> value of this field can be set from EditProduc form (into shopping cart 
> section). Value can be "Y", "N" or empty.
>- a new method "isDecimalQuantityOrderAllowed" have been add into 
> productWorker class. This method test if order decimal quantity is allow for 
> a product and a productStore. Product is superior on producStore. Here is the 
> table of value :
> - ProductStore.orderDecimalQuantity = "Y" &&   
> Product.orderDecimalQuantity = "Y" => return True
> - ProductStore.orderDecimalQuantity = "N" &&   
> Product.orderDecimalQuantity = "Y" => return True
> - ProductStore.orderDecimalQuantity = empty &&   
> Product.orderDecimalQuantity = "Y" => return True
> - ProductStore.orderDecimalQuantity = "Y" &&   
> Product.orderDecimalQuantity = "N" => return False
> - ProductStore.orderDecimalQuantity = "N" &&   
> Product.orderDecimalQuantity = "N" => return False
> - ProductStore.orderDecimalQuantity = empty &&   
> Product.orderDecimalQuantity = "N" => return False
> - ProductStore.orderDecimalQuantity = "Y" &&   
> Product.orderDecimalQuantity = empty => return True
> - ProductStore.orderDecimalQuantity = "N" &&   
> Product.orderDecimalQuantity = empty => return False
> - ProductStore.orderDecimalQuantity = empty &&   
> Product.orderDecimalQuantity = empty => return True
>- addToCat and modifyCart car method have been modify to call 
> isDecimalQuantityOrderAllowed. If result is true then quantity is rounding 
> with order config value. If result is false then quantity is rounding to 0. 
> No message is return.
>- to fix reorder quantity, then getQuickReorderProducts method have been 
> modify to call isDecimalQuantityOrderAllowed. If result is true then quantity 
> is rounding with order config value. If result is false then quantity is 
> rounding to 0.
> What the result :
>- You can forbid or accept to manage order decimal quantity for all product
>- You can forbid or accept to manage order decimal quantity for one product
>- Decimal quantity are now rounded with order config value.
>- reorder quantity is rounded with order config value or rounding to 0

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Issue Comment Edited] (OFBIZ-4257) add a parameter to forbid order decimal quantity

[Gaudin Pierre (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026943#comment-13026943
 ] 

Gaudin Pierre edited comment on OFBIZ-4257 at 4/29/11 11:59 AM:


I finaly reopen this JIRA and add a patch to fix NPE when shopping cart have no 
productStoreId

Pierre

  was (Author: gpierre):
I finaly reopen this JIRA and add a patch to fix NPE

Pierre
  
> add a parameter to forbid order decimal quantity
> 
>
> Key: OFBIZ-4257
> URL: https://issues.apache.org/jira/browse/OFBIZ-4257
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order, specialpurpose/ecommerce
>Affects Versions: SVN trunk
>Reporter: Gaudin Pierre
>Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: 
> OFBIZ-4257_add_a_parameter_to_forbid_order_decimal_quantity.patch
>
>
> This is a patch to add a parameter to forbid order decimal quantity
> Behavior before the patch :
>- you can add decimal quantity on shopping cart item (front office and 
> back office) even if the product is a unit
>- there is no rounding on quantity on shopping cart item thus you get 
> amount with a large number of decimal
>- reorder widget display quantity to reorder with a large number of decimal
> What does this patch :
>- a new field "orderDecimalQuantity" is added into ProducStore entity. The 
> value of this field can be set from EditProducStore form (into shopping cart 
> section). Value can be "Y", "N" or empty.
>- a new field "orderDecimalQuantity" is added into Product entity. The 
> value of this field can be set from EditProduc form (into shopping cart 
> section). Value can be "Y", "N" or empty.
>- a new method "isDecimalQuantityOrderAllowed" have been add into 
> productWorker class. This method test if order decimal quantity is allow for 
> a product and a productStore. Product is superior on producStore. Here is the 
> table of value :
> - ProductStore.orderDecimalQuantity = "Y" &&   
> Product.orderDecimalQuantity = "Y" => return True
> - ProductStore.orderDecimalQuantity = "N" &&   
> Product.orderDecimalQuantity = "Y" => return True
> - ProductStore.orderDecimalQuantity = empty &&   
> Product.orderDecimalQuantity = "Y" => return True
> - ProductStore.orderDecimalQuantity = "Y" &&   
> Product.orderDecimalQuantity = "N" => return False
> - ProductStore.orderDecimalQuantity = "N" &&   
> Product.orderDecimalQuantity = "N" => return False
> - ProductStore.orderDecimalQuantity = empty &&   
> Product.orderDecimalQuantity = "N" => return False
> - ProductStore.orderDecimalQuantity = "Y" &&   
> Product.orderDecimalQuantity = empty => return True
> - ProductStore.orderDecimalQuantity = "N" &&   
> Product.orderDecimalQuantity = empty => return False
> - ProductStore.orderDecimalQuantity = empty &&   
> Product.orderDecimalQuantity = empty => return True
>- addToCat and modifyCart car method have been modify to call 
> isDecimalQuantityOrderAllowed. If result is true then quantity is rounding 
> with order config value. If result is false then quantity is rounding to 0. 
> No message is return.
>- to fix reorder quantity, then getQuickReorderProducts method have been 
> modify to call isDecimalQuantityOrderAllowed. If result is true then quantity 
> is rounding with order config value. If result is false then quantity is 
> rounding to 0.
> What the result :
>- You can forbid or accept to manage order decimal quantity for all product
>- You can forbid or accept to manage order decimal quantity for one product
>- Decimal quantity are now rounded with order config value.
>- reorder quantity is rounded with order config value or rounding to 0

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (OFBIZ-4257) add a parameter to forbid order decimal quantity

[Gaudin Pierre (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gaudin Pierre updated OFBIZ-4257:
-

Attachment: 
OFBIZ-4257_add_a_parameter_to_forbid_order_decimal_quantity_v2.patch

> add a parameter to forbid order decimal quantity
> 
>
> Key: OFBIZ-4257
> URL: https://issues.apache.org/jira/browse/OFBIZ-4257
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order, specialpurpose/ecommerce
>Affects Versions: SVN trunk
>Reporter: Gaudin Pierre
>Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: 
> OFBIZ-4257_add_a_parameter_to_forbid_order_decimal_quantity.patch, 
> OFBIZ-4257_add_a_parameter_to_forbid_order_decimal_quantity_v2.patch
>
>
> This is a patch to add a parameter to forbid order decimal quantity
> Behavior before the patch :
>- you can add decimal quantity on shopping cart item (front office and 
> back office) even if the product is a unit
>- there is no rounding on quantity on shopping cart item thus you get 
> amount with a large number of decimal
>- reorder widget display quantity to reorder with a large number of decimal
> What does this patch :
>- a new field "orderDecimalQuantity" is added into ProducStore entity. The 
> value of this field can be set from EditProducStore form (into shopping cart 
> section). Value can be "Y", "N" or empty.
>- a new field "orderDecimalQuantity" is added into Product entity. The 
> value of this field can be set from EditProduc form (into shopping cart 
> section). Value can be "Y", "N" or empty.
>- a new method "isDecimalQuantityOrderAllowed" have been add into 
> productWorker class. This method test if order decimal quantity is allow for 
> a product and a productStore. Product is superior on producStore. Here is the 
> table of value :
> - ProductStore.orderDecimalQuantity = "Y" &&   
> Product.orderDecimalQuantity = "Y" => return True
> - ProductStore.orderDecimalQuantity = "N" &&   
> Product.orderDecimalQuantity = "Y" => return True
> - ProductStore.orderDecimalQuantity = empty &&   
> Product.orderDecimalQuantity = "Y" => return True
> - ProductStore.orderDecimalQuantity = "Y" &&   
> Product.orderDecimalQuantity = "N" => return False
> - ProductStore.orderDecimalQuantity = "N" &&   
> Product.orderDecimalQuantity = "N" => return False
> - ProductStore.orderDecimalQuantity = empty &&   
> Product.orderDecimalQuantity = "N" => return False
> - ProductStore.orderDecimalQuantity = "Y" &&   
> Product.orderDecimalQuantity = empty => return True
> - ProductStore.orderDecimalQuantity = "N" &&   
> Product.orderDecimalQuantity = empty => return False
> - ProductStore.orderDecimalQuantity = empty &&   
> Product.orderDecimalQuantity = empty => return True
>- addToCat and modifyCart car method have been modify to call 
> isDecimalQuantityOrderAllowed. If result is true then quantity is rounding 
> with order config value. If result is false then quantity is rounding to 0. 
> No message is return.
>- to fix reorder quantity, then getQuickReorderProducts method have been 
> modify to call isDecimalQuantityOrderAllowed. If result is true then quantity 
> is rounding with order config value. If result is false then quantity is 
> rounding to 0.
> What the result :
>- You can forbid or accept to manage order decimal quantity for all product
>- You can forbid or accept to manage order decimal quantity for one product
>- Decimal quantity are now rounded with order config value.
>- reorder quantity is rounded with order config value or rounding to 0

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4257) add a parameter to forbid order decimal quantity

[Gaudin Pierre (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026966#comment-13026966
 ] 

Gaudin Pierre commented on OFBIZ-4257:
--

Thank you Jacques

> add a parameter to forbid order decimal quantity
> 
>
> Key: OFBIZ-4257
> URL: https://issues.apache.org/jira/browse/OFBIZ-4257
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order, specialpurpose/ecommerce
>Affects Versions: SVN trunk
>Reporter: Gaudin Pierre
>Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: 
> OFBIZ-4257_add_a_parameter_to_forbid_order_decimal_quantity.patch, 
> OFBIZ-4257_add_a_parameter_to_forbid_order_decimal_quantity_v2.patch
>
>
> This is a patch to add a parameter to forbid order decimal quantity
> Behavior before the patch :
>- you can add decimal quantity on shopping cart item (front office and 
> back office) even if the product is a unit
>- there is no rounding on quantity on shopping cart item thus you get 
> amount with a large number of decimal
>- reorder widget display quantity to reorder with a large number of decimal
> What does this patch :
>- a new field "orderDecimalQuantity" is added into ProducStore entity. The 
> value of this field can be set from EditProducStore form (into shopping cart 
> section). Value can be "Y", "N" or empty.
>- a new field "orderDecimalQuantity" is added into Product entity. The 
> value of this field can be set from EditProduc form (into shopping cart 
> section). Value can be "Y", "N" or empty.
>- a new method "isDecimalQuantityOrderAllowed" have been add into 
> productWorker class. This method test if order decimal quantity is allow for 
> a product and a productStore. Product is superior on producStore. Here is the 
> table of value :
> - ProductStore.orderDecimalQuantity = "Y" &&   
> Product.orderDecimalQuantity = "Y" => return True
> - ProductStore.orderDecimalQuantity = "N" &&   
> Product.orderDecimalQuantity = "Y" => return True
> - ProductStore.orderDecimalQuantity = empty &&   
> Product.orderDecimalQuantity = "Y" => return True
> - ProductStore.orderDecimalQuantity = "Y" &&   
> Product.orderDecimalQuantity = "N" => return False
> - ProductStore.orderDecimalQuantity = "N" &&   
> Product.orderDecimalQuantity = "N" => return False
> - ProductStore.orderDecimalQuantity = empty &&   
> Product.orderDecimalQuantity = "N" => return False
> - ProductStore.orderDecimalQuantity = "Y" &&   
> Product.orderDecimalQuantity = empty => return True
> - ProductStore.orderDecimalQuantity = "N" &&   
> Product.orderDecimalQuantity = empty => return False
> - ProductStore.orderDecimalQuantity = empty &&   
> Product.orderDecimalQuantity = empty => return True
>- addToCat and modifyCart car method have been modify to call 
> isDecimalQuantityOrderAllowed. If result is true then quantity is rounding 
> with order config value. If result is false then quantity is rounding to 0. 
> No message is return.
>- to fix reorder quantity, then getQuickReorderProducts method have been 
> modify to call isDecimalQuantityOrderAllowed. If result is true then quantity 
> is rounding with order config value. If result is false then quantity is 
> rounding to 0.
> What the result :
>- You can forbid or accept to manage order decimal quantity for all product
>- You can forbid or accept to manage order decimal quantity for one product
>- Decimal quantity are now rounded with order config value.
>- reorder quantity is rounded with order config value or rounding to 0

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (OFBIZ-4298) fix js Gantt display for milestone and associated workeffort

[Gaudin Pierre (JIRA)]

fix js Gantt display for milestone and associated workeffort


 Key: OFBIZ-4298
 URL: https://issues.apache.org/jira/browse/OFBIZ-4298
 Project: OFBiz
  Issue Type: Bug
  Components: specialpurpose/projectmgr
Affects Versions: SVN trunk
Reporter: Gaudin Pierre
 Fix For: SVN trunk


The aim of this patch is to fix the display of the milestones and the task on 
the diagram of gantt.

Here are the errors at present:
 1 - If a task has several associated tasks only the last one appears as bound 
 2 - the milestones seem systematically ended even if the status is not ended 
 3 - duration is not display for milestone in ressource column

The patch corrects these three points.

To validate the patch it is necessary to:
 1 - Create a new project
 2 - Create 1 phase 
 3 - Create 3 tasks 
 4 - Associated first task with the last two tasks 
Result = > the first task appears connected to both following ones on the 
diagram of gantt

 5 - Edit one of the task and set the type to milestone
Result = > it appears as not ended on the diagram
Result = > the column "ressource" contains the number the estimated duration of 
the task

  5 - Put the status of the milestone as "ended"
Result = > it appears as ended on the diagram


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (OFBIZ-4298) fix js Gantt display for milestone and associated workeffort

[Gaudin Pierre (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gaudin Pierre updated OFBIZ-4298:
-

Attachment: 
OFBIZ-4298_fix_js_Gantt_display_for_milestone_and_associated_workeffort.patch

> fix js Gantt display for milestone and associated workeffort
> 
>
> Key: OFBIZ-4298
> URL: https://issues.apache.org/jira/browse/OFBIZ-4298
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/projectmgr
>Affects Versions: SVN trunk
>Reporter: Gaudin Pierre
> Fix For: SVN trunk
>
> Attachments: 
> OFBIZ-4298_fix_js_Gantt_display_for_milestone_and_associated_workeffort.patch
>
>
> The aim of this patch is to fix the display of the milestones and the task on 
> the diagram of gantt.
> Here are the errors at present:
>  1 - If a task has several associated tasks only the last one appears as 
> bound 
>  2 - the milestones seem systematically ended even if the status is not ended 
>  3 - duration is not display for milestone in ressource column
> The patch corrects these three points.
> To validate the patch it is necessary to:
>  1 - Create a new project
>  2 - Create 1 phase 
>  3 - Create 3 tasks 
>  4 - Associated first task with the last two tasks 
> Result = > the first task appears connected to both following ones on the 
> diagram of gantt
>  5 - Edit one of the task and set the type to milestone
> Result = > it appears as not ended on the diagram
> Result = > the column "ressource" contains the number the estimated duration 
> of the task
>   5 - Put the status of the milestone as "ended"
> Result = > it appears as ended on the diagram

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4298) fix js Gantt display for milestone and associated workeffort

[Gaudin Pierre (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-4298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042126#comment-13042126
 ] 

Gaudin Pierre commented on OFBIZ-4298:
--

Hi commiters !

Is there any one of you interested by this patch?

Thanks

Pierre

> fix js Gantt display for milestone and associated workeffort
> 
>
> Key: OFBIZ-4298
> URL: https://issues.apache.org/jira/browse/OFBIZ-4298
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/projectmgr
>Affects Versions: SVN trunk
>Reporter: Gaudin Pierre
> Fix For: SVN trunk
>
> Attachments: 
> OFBIZ-4298_fix_js_Gantt_display_for_milestone_and_associated_workeffort.patch
>
>
> The aim of this patch is to fix the display of the milestones and the task on 
> the diagram of gantt.
> Here are the errors at present:
>  1 - If a task has several associated tasks only the last one appears as 
> bound 
>  2 - the milestones seem systematically ended even if the status is not ended 
>  3 - duration is not display for milestone in ressource column
> The patch corrects these three points.
> To validate the patch it is necessary to:
>  1 - Create a new project
>  2 - Create 1 phase 
>  3 - Create 3 tasks 
>  4 - Associated first task with the last two tasks 
> Result = > the first task appears connected to both following ones on the 
> diagram of gantt
>  5 - Edit one of the task and set the type to milestone
> Result = > it appears as not ended on the diagram
> Result = > the column "ressource" contains the number the estimated duration 
> of the task
>   5 - Put the status of the milestone as "ended"
> Result = > it appears as ended on the diagram

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (OFBIZ-4306) Error in display of date-time field

[Gaudin Pierre (JIRA)]

Error in display of date-time field
---

 Key: OFBIZ-4306
 URL: https://issues.apache.org/jira/browse/OFBIZ-4306
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: SVN trunk
Reporter: Gaudin Pierre


I meet an error of formatting of date during the use of field date-time.

I am on the screen: https: // 
demo-trunk.ofbiz.apache.org/projectmgr/control/EditProjectTasks?ProjectId=9000 
login as admin
My local is fr_FR and the format is dd/MM/.

If I change the date with the calendar and if the day of the month in the date 
is > 12 then the display format is : dd/MM/
If I change the date with the calendar and if the day of the month in the date 
is < = 12 then the display format is: MM/dd/

There is thus an error during the formatting(layout) of date. By looking at 
this error I found that the problem came from the macro ftl: 
renderDateTimeField more exactly it is during conversion to string that the 
error is produced:
  The dateObj Var = Date.parse ( initDate );
  The formatedObj Var = dateObj.toString ( dateFormat );
It is the toString method that is at the origin of this inversion.

Somebody knows how to fix this problem?

Thank you in advance,



Pierre



--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (OFBIZ-4306) Error in display of date-time field

[Gaudin Pierre (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gaudin Pierre updated OFBIZ-4306:
-

Description: 
I meet an error of formatting of date during the use of field date-time.

I am on the screen: https: // 
demo-trunk.ofbiz.apache.org/projectmgr/control/EditProjectTasks?ProjectId=9000 
login as admin
My local is fr_FR and the format is dd/MM/.

If I change the date with the calendar and if the day of the month in the date 
is > 12 then the display format is : dd/MM/
If I change the date with the calendar and if the day of the month in the date 
is < = 12 then the display format is: MM/dd/

There is thus an error during the formatting of date. By looking at this error 
I found that the problem came from the macro ftl: renderDateTimeField more 
exactly it is during conversion to string that the error is produced:
   dateObj Var = Date.parse ( initDate );
   formatedObj Var = dateObj.toString ( dateFormat );
It is the toString method that is at the origin of this inversion.
in both cases dateFormat is always dd/MM/  : dateObj.toString ( dd/MM/ 
);

Somebody knows how to fix this problem?

Thank you in advance,



Pierre



  was:
I meet an error of formatting of date during the use of field date-time.

I am on the screen: https: // 
demo-trunk.ofbiz.apache.org/projectmgr/control/EditProjectTasks?ProjectId=9000 
login as admin
My local is fr_FR and the format is dd/MM/.

If I change the date with the calendar and if the day of the month in the date 
is > 12 then the display format is : dd/MM/
If I change the date with the calendar and if the day of the month in the date 
is < = 12 then the display format is: MM/dd/

There is thus an error during the formatting(layout) of date. By looking at 
this error I found that the problem came from the macro ftl: 
renderDateTimeField more exactly it is during conversion to string that the 
error is produced:
  The dateObj Var = Date.parse ( initDate );
  The formatedObj Var = dateObj.toString ( dateFormat );
It is the toString method that is at the origin of this inversion.

Somebody knows how to fix this problem?

Thank you in advance,



Pierre




> Error in display of date-time field
> ---
>
> Key: OFBIZ-4306
> URL: https://issues.apache.org/jira/browse/OFBIZ-4306
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: SVN trunk
>Reporter: Gaudin Pierre
>
> I meet an error of formatting of date during the use of field date-time.
> I am on the screen: https: // 
> demo-trunk.ofbiz.apache.org/projectmgr/control/EditProjectTasks?ProjectId=9000
>  login as admin
> My local is fr_FR and the format is dd/MM/.
> If I change the date with the calendar and if the day of the month in the 
> date is > 12 then the display format is : dd/MM/
> If I change the date with the calendar and if the day of the month in the 
> date is < = 12 then the display format is: MM/dd/
> There is thus an error during the formatting of date. By looking at this 
> error I found that the problem came from the macro ftl: renderDateTimeField 
> more exactly it is during conversion to string that the error is produced:
>dateObj Var = Date.parse ( initDate );
>formatedObj Var = dateObj.toString ( dateFormat );
> It is the toString method that is at the origin of this inversion.
> in both cases dateFormat is always dd/MM/  : dateObj.toString ( 
> dd/MM/ );
> Somebody knows how to fix this problem?
> Thank you in advance,
> Pierre

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (OFBIZ-4320) can't select good phase into task edit form

[Gaudin Pierre (JIRA)]

can't select good phase into task edit form
---

 Key: OFBIZ-4320
 URL: https://issues.apache.org/jira/browse/OFBIZ-4320
 Project: OFBiz
  Issue Type: Bug
Reporter: Gaudin Pierre


In the project management module, in the view of task, if we want to add a new 
task, it is necessary to select a phase. The phases appear in a drop-down list. 
The list of the phases is not correct because they do not correspond to the 
current project.

To see the error it is necessary to go on this page as admin:
https://demo-trunk.ofbiz.apache.org/projectmgr/control/EditProjectTasks?projectId=9200

In the form "Add Task" look at fields "Parent Phase" the list does not 
correspond has phases of the project

Once the patch is applied, the list of phases corresponds to the actual project.


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (OFBIZ-4320) can't select good phase into task edit form

[Gaudin Pierre (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gaudin Pierre updated OFBIZ-4320:
-

  Component/s: specialpurpose/projectmgr
Affects Version/s: SVN trunk

> can't select good phase into task edit form
> ---
>
> Key: OFBIZ-4320
> URL: https://issues.apache.org/jira/browse/OFBIZ-4320
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/projectmgr
>Affects Versions: SVN trunk
>Reporter: Gaudin Pierre
>
> In the project management module, in the view of task, if we want to add a 
> new task, it is necessary to select a phase. The phases appear in a drop-down 
> list. The list of the phases is not correct because they do not correspond to 
> the current project.
> To see the error it is necessary to go on this page as admin:
> https://demo-trunk.ofbiz.apache.org/projectmgr/control/EditProjectTasks?projectId=9200
> In the form "Add Task" look at fields "Parent Phase" the list does not 
> correspond has phases of the project
> Once the patch is applied, the list of phases corresponds to the actual 
> project.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (OFBIZ-4320) can't select good phase into task edit form

[Gaudin Pierre (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gaudin Pierre updated OFBIZ-4320:
-

Attachment: OFBIZ-4320_can_t_select_good_phase_into_task_edit_form.patch

> can't select good phase into task edit form
> ---
>
> Key: OFBIZ-4320
> URL: https://issues.apache.org/jira/browse/OFBIZ-4320
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/projectmgr
>Affects Versions: SVN trunk
>Reporter: Gaudin Pierre
> Attachments: 
> OFBIZ-4320_can_t_select_good_phase_into_task_edit_form.patch
>
>
> In the project management module, in the view of task, if we want to add a 
> new task, it is necessary to select a phase. The phases appear in a drop-down 
> list. The list of the phases is not correct because they do not correspond to 
> the current project.
> To see the error it is necessary to go on this page as admin:
> https://demo-trunk.ofbiz.apache.org/projectmgr/control/EditProjectTasks?projectId=9200
> In the form "Add Task" look at fields "Parent Phase" the list does not 
> correspond has phases of the project
> Once the patch is applied, the list of phases corresponds to the actual 
> project.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4306) Error in display of date-time field

[Gaudin Pierre (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-4306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055390#comment-13055390
 ] 

Gaudin Pierre commented on OFBIZ-4306:
--

Many thanks, that fixe the issue!

Pierre

> Error in display of date-time field
> ---
>
> Key: OFBIZ-4306
> URL: https://issues.apache.org/jira/browse/OFBIZ-4306
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: SVN trunk
>Reporter: Gaudin Pierre
>Assignee: Scott Gray
> Fix For: Release Branch 11.04, SVN trunk
>
>
> I meet an error of formatting of date during the use of field date-time.
> I am on the screen: https: // 
> demo-trunk.ofbiz.apache.org/projectmgr/control/EditProjectTasks?ProjectId=9000
>  login as admin
> My local is fr_FR and the format is dd/MM/.
> If I change the date with the calendar and if the day of the month in the 
> date is > 12 then the display format is : dd/MM/
> If I change the date with the calendar and if the day of the month in the 
> date is < = 12 then the display format is: MM/dd/
> There is thus an error during the formatting of date. By looking at this 
> error I found that the problem came from the macro ftl: renderDateTimeField 
> more exactly it is during conversion to string that the error is produced:
>dateObj Var = Date.parse ( initDate );
>formatedObj Var = dateObj.toString ( dateFormat );
> It is the toString method that is at the origin of this inversion.
> in both cases dateFormat is always dd/MM/  : dateObj.toString ( 
> dd/MM/ );
> Somebody knows how to fix this problem?
> Thank you in advance,
> Pierre

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4320) can't select good phase into task edit form

[Gaudin Pierre (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-4320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055393#comment-13055393
 ] 

Gaudin Pierre commented on OFBIZ-4320:
--

Thanks Erwan !

> can't select good phase into task edit form
> ---
>
> Key: OFBIZ-4320
> URL: https://issues.apache.org/jira/browse/OFBIZ-4320
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/projectmgr
>Affects Versions: SVN trunk
>Reporter: Gaudin Pierre
>Assignee: Erwan de FERRIERES
> Fix For: SVN trunk
>
> Attachments: 
> OFBIZ-4320_can_t_select_good_phase_into_task_edit_form.patch
>
>
> In the project management module, in the view of task, if we want to add a 
> new task, it is necessary to select a phase. The phases appear in a drop-down 
> list. The list of the phases is not correct because they do not correspond to 
> the current project.
> To see the error it is necessary to go on this page as admin:
> https://demo-trunk.ofbiz.apache.org/projectmgr/control/EditProjectTasks?projectId=9200
> In the form "Add Task" look at fields "Parent Phase" the list does not 
> correspond has phases of the project
> Once the patch is applied, the list of phases corresponds to the actual 
> project.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (OFBIZ-5822) use requestParameters for customMethod call

[Gaudin Pierre (JIRA)]

Gaudin Pierre created OFBIZ-5822:


 Summary: use requestParameters for customMethod call
 Key: OFBIZ-5822
 URL: https://issues.apache.org/jira/browse/OFBIZ-5822
 Project: OFBiz
  Issue Type: Improvement
  Components: content
Affects Versions: Trunk
Reporter: Gaudin Pierre
Priority: Minor
 Fix For: Trunk


For a content, you can set a custom method that perform an action before 
content's rendering.

Unfortunately, in the customMethod call, the request Parameters can't be used 
because they are not set into the map that is used to create custom method IN 
parameters.

This patch solves this problem



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-5822) use requestParameters for customMethod call

[Gaudin Pierre (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-5822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gaudin Pierre updated OFBIZ-5822:
-
Attachment: ContentWorker.java.patch

> use requestParameters for customMethod call
> ---
>
> Key: OFBIZ-5822
> URL: https://issues.apache.org/jira/browse/OFBIZ-5822
> Project: OFBiz
>  Issue Type: Improvement
>  Components: content
>Affects Versions: Trunk
>Reporter: Gaudin Pierre
>Priority: Minor
> Fix For: Trunk
>
> Attachments: ContentWorker.java.patch
>
>
> For a content, you can set a custom method that perform an action before 
> content's rendering.
> Unfortunately, in the customMethod call, the request Parameters can't be used 
> because they are not set into the map that is used to create custom method IN 
> parameters.
> This patch solves this problem



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-5823) Add CMS metadata into renderer context

[Gaudin Pierre (JIRA)]

Gaudin Pierre created OFBIZ-5823:


 Summary: Add CMS metadata into renderer context
 Key: OFBIZ-5823
 URL: https://issues.apache.org/jira/browse/OFBIZ-5823
 Project: OFBiz
  Issue Type: Improvement
  Components: content, specialpurpose/cmssite
Affects Versions: Trunk
Reporter: Gaudin Pierre
Priority: Minor
 Fix For: Trunk


In website CMS, for a page, you can specify metadata.
Unfortunatly those metadata are not availables into the cms page context.

This patch add metadata into context of all pages. Thus you can use them.

To test this patch, add metadata  associated to a cms page (ie metaDescription).
Edit the cms page to add ${metaDescription}.
Then display the page 




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-5823) Add CMS metadata into renderer context

[Gaudin Pierre (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gaudin Pierre updated OFBIZ-5823:
-
Attachment: CMSMetadata.patch

> Add CMS metadata into renderer context
> --
>
> Key: OFBIZ-5823
> URL: https://issues.apache.org/jira/browse/OFBIZ-5823
> Project: OFBiz
>  Issue Type: Improvement
>  Components: content, specialpurpose/cmssite
>Affects Versions: Trunk
>Reporter: Gaudin Pierre
>Priority: Minor
> Fix For: Trunk
>
> Attachments: CMSMetadata.patch
>
>
> In website CMS, for a page, you can specify metadata.
> Unfortunatly those metadata are not availables into the cms page context.
> This patch add metadata into context of all pages. Thus you can use them.
> To test this patch, add metadata  associated to a cms page (ie 
> metaDescription).
> Edit the cms page to add ${metaDescription}.
> Then display the page 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-5823) Add CMS metadata into renderer context

[Gaudin Pierre (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14175910#comment-14175910
 ] 

Gaudin Pierre commented on OFBIZ-5823:
--

Hi Deepak,

Ok thanks, i haven't seen that the metada were in the contentMapFacade... 

I use dataResource entity because in the CMS tree view of a website entity 
DataResource is used to store metadata.
Maybe we could add both  in metadata contentMapFacade : the ones from 
DataResource and the ones from ContentMetaData ?
Another solution is to use ContentMetaData in CMS tree view instead of 
dataResource ? 

Pierre

ps : My first mane is Pierre ;-)



> Add CMS metadata into renderer context
> --
>
> Key: OFBIZ-5823
> URL: https://issues.apache.org/jira/browse/OFBIZ-5823
> Project: OFBiz
>  Issue Type: Improvement
>  Components: content, specialpurpose/cmssite
>Affects Versions: Trunk
>Reporter: Gaudin Pierre
>Priority: Minor
> Fix For: Trunk
>
> Attachments: CMSMetadata.patch
>
>
> In website CMS, for a page, you can specify metadata.
> Unfortunatly those metadata are not availables into the cms page context.
> This patch add metadata into context of all pages. Thus you can use them.
> To test this patch, add metadata  associated to a cms page (ie 
> metaDescription).
> Edit the cms page to add ${metaDescription}.
> Then display the page 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-5823) Add CMS metadata into renderer context

[Gaudin Pierre (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14175964#comment-14175964
 ] 

Gaudin Pierre commented on OFBIZ-5823:
--

Many thanks Deepak, I was on the wrong way !!

But i think that we should change the way CMS tree view of a website stores 
metadata because it is store into DataResource entity, not  into 
ContentMetaData.
I'd like to provide a patch to fix this.

Do you agree with it?

Many thanks,

Pierre




> Add CMS metadata into renderer context
> --
>
> Key: OFBIZ-5823
> URL: https://issues.apache.org/jira/browse/OFBIZ-5823
> Project: OFBiz
>  Issue Type: Improvement
>  Components: content, specialpurpose/cmssite
>Affects Versions: Trunk
>Reporter: Gaudin Pierre
>Priority: Minor
> Fix For: Trunk
>
> Attachments: CMSMetadata.patch
>
>
> In website CMS, for a page, you can specify metadata.
> Unfortunatly those metadata are not availables into the cms page context.
> This patch add metadata into context of all pages. Thus you can use them.
> To test this patch, add metadata  associated to a cms page (ie 
> metaDescription).
> Edit the cms page to add ${metaDescription}.
> Then display the page 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-5823) Add CMS metadata into renderer context

[Gaudin Pierre (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176014#comment-14176014
 ] 

Gaudin Pierre commented on OFBIZ-5823:
--

Hi Deepak,

Yes, if you select one page and add meta data, then for each meta data a 
Content with a DataResource is created.

Thanks

Pierre

> Add CMS metadata into renderer context
> --
>
> Key: OFBIZ-5823
> URL: https://issues.apache.org/jira/browse/OFBIZ-5823
> Project: OFBiz
>  Issue Type: Improvement
>  Components: content, specialpurpose/cmssite
>Affects Versions: Trunk
>Reporter: Gaudin Pierre
>Priority: Minor
> Fix For: Trunk
>
> Attachments: CMSMetadata.patch
>
>
> In website CMS, for a page, you can specify metadata.
> Unfortunatly those metadata are not availables into the cms page context.
> This patch add metadata into context of all pages. Thus you can use them.
> To test this patch, add metadata  associated to a cms page (ie 
> metaDescription).
> Edit the cms page to add ${metaDescription}.
> Then display the page 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-5823) Add CMS metadata into renderer context

[Gaudin Pierre (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176039#comment-14176039
 ] 

Gaudin Pierre commented on OFBIZ-5823:
--

Hi Deepak,

OK,

Click one page from the content tree (ie CMS Site Demo blog screen example [ 
CMSS_DEMO_BLOG ])
On the right side of the tree, the content is shown. Above shown content , 
there is 3 links in black color. Select link "Meta Tags" . Then add the value 
and save. 

Please, find a screen shot as attachment.

Thanks,

Pierre

> Add CMS metadata into renderer context
> --
>
> Key: OFBIZ-5823
> URL: https://issues.apache.org/jira/browse/OFBIZ-5823
> Project: OFBiz
>  Issue Type: Improvement
>  Components: content, specialpurpose/cmssite
>Affects Versions: Trunk
>Reporter: Gaudin Pierre
>Priority: Minor
> Fix For: Trunk
>
> Attachments: CMSMetadata.patch, Screen Shot 2014-10-18 at 8.19.17 
> PM.png
>
>
> In website CMS, for a page, you can specify metadata.
> Unfortunatly those metadata are not availables into the cms page context.
> This patch add metadata into context of all pages. Thus you can use them.
> To test this patch, add metadata  associated to a cms page (ie 
> metaDescription).
> Edit the cms page to add ${metaDescription}.
> Then display the page 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-5823) Add CMS metadata into renderer context

[Gaudin Pierre (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gaudin Pierre updated OFBIZ-5823:
-
Attachment: screenshot-1.png

> Add CMS metadata into renderer context
> --
>
> Key: OFBIZ-5823
> URL: https://issues.apache.org/jira/browse/OFBIZ-5823
> Project: OFBiz
>  Issue Type: Improvement
>  Components: content, specialpurpose/cmssite
>Affects Versions: Trunk
>Reporter: Gaudin Pierre
>Priority: Minor
> Fix For: Trunk
>
> Attachments: CMSMetadata.patch, Screen Shot 2014-10-18 at 8.19.17 
> PM.png, screenshot-1.png
>
>
> In website CMS, for a page, you can specify metadata.
> Unfortunatly those metadata are not availables into the cms page context.
> This patch add metadata into context of all pages. Thus you can use them.
> To test this patch, add metadata  associated to a cms page (ie 
> metaDescription).
> Edit the cms page to add ${metaDescription}.
> Then display the page 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-5822) use requestParameters for customMethod call

[Gaudin Pierre (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-5822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14217604#comment-14217604
 ] 

Gaudin Pierre commented on OFBIZ-5822:
--

Thanks Jacques  !! 

> use requestParameters for customMethod call
> ---
>
> Key: OFBIZ-5822
> URL: https://issues.apache.org/jira/browse/OFBIZ-5822
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk
>Reporter: Gaudin Pierre
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Trunk, 12.04.06, 13.07.02
>
> Attachments: ContentWorker.java.patch
>
>
> For a content, you can set a custom method that perform an action before 
> content's rendering.
> Unfortunately, in the customMethod call, the request Parameters can't be used 
> because they are not set into the map that is used to create custom method IN 
> parameters.
> This patch solves this problem



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-6023) Jrowl to display alerts

[Gaudin Pierre (JIRA)]

Gaudin Pierre created OFBIZ-6023:


 Summary: Jrowl to display alerts 
 Key: OFBIZ-6023
 URL: https://issues.apache.org/jira/browse/OFBIZ-6023
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: Trunk
Reporter: Gaudin Pierre
 Fix For: Trunk


Hi all,

I've been working on Jgrowl integration for a project. 
(https://github.com/stanlemon/jGrowl)

This allow to display system's messages in a popup at the top of the windows 
even if you scroll. This is also useful for ajax call because there is no need 
to scroll to the top of the screen to view message.
Message can stick to the screen until it is intentionally closed by the user or 
not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-6023) Jrowl to display alerts

[Gaudin Pierre (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gaudin Pierre updated OFBIZ-6023:
-
Attachment: Simple error message.png

> Jrowl to display alerts 
> 
>
> Key: OFBIZ-6023
> URL: https://issues.apache.org/jira/browse/OFBIZ-6023
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gaudin Pierre
> Fix For: Trunk
>
> Attachments: Simple error message.png
>
>
> Hi all,
> I've been working on Jgrowl integration for a project. 
> (https://github.com/stanlemon/jGrowl)
> This allow to display system's messages in a popup at the top of the windows 
> even if you scroll. This is also useful for ajax call because there is no 
> need to scroll to the top of the screen to view message.
> Message can stick to the screen until it is intentionally closed by the user 
> or not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-6023) Jrowl to display alerts

[Gaudin Pierre (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gaudin Pierre updated OFBIZ-6023:
-
Attachment: Scrolling-1.png

> Jrowl to display alerts 
> 
>
> Key: OFBIZ-6023
> URL: https://issues.apache.org/jira/browse/OFBIZ-6023
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gaudin Pierre
> Fix For: Trunk
>
> Attachments: Scrolling-1.png, Simple error message.png
>
>
> Hi all,
> I've been working on Jgrowl integration for a project. 
> (https://github.com/stanlemon/jGrowl)
> This allow to display system's messages in a popup at the top of the windows 
> even if you scroll. This is also useful for ajax call because there is no 
> need to scroll to the top of the screen to view message.
> Message can stick to the screen until it is intentionally closed by the user 
> or not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-6023) Jrowl to display alerts

[Gaudin Pierre (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gaudin Pierre updated OFBIZ-6023:
-
Attachment: Scrolling-2.png

> Jrowl to display alerts 
> 
>
> Key: OFBIZ-6023
> URL: https://issues.apache.org/jira/browse/OFBIZ-6023
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gaudin Pierre
> Fix For: Trunk
>
> Attachments: Scrolling-1.png, Scrolling-2.png, Simple error 
> message.png
>
>
> Hi all,
> I've been working on Jgrowl integration for a project. 
> (https://github.com/stanlemon/jGrowl)
> This allow to display system's messages in a popup at the top of the windows 
> even if you scroll. This is also useful for ajax call because there is no 
> need to scroll to the top of the screen to view message.
> Message can stick to the screen until it is intentionally closed by the user 
> or not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-6023) Jrowl to display alerts

[Gaudin Pierre (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gaudin Pierre updated OFBIZ-6023:
-
Attachment: large-message-by-default.png

> Jrowl to display alerts 
> 
>
> Key: OFBIZ-6023
> URL: https://issues.apache.org/jira/browse/OFBIZ-6023
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gaudin Pierre
> Fix For: Trunk
>
> Attachments: Scrolling-1.png, Scrolling-2.png, Simple error 
> message.png, large-message-by-default.png
>
>
> Hi all,
> I've been working on Jgrowl integration for a project. 
> (https://github.com/stanlemon/jGrowl)
> This allow to display system's messages in a popup at the top of the windows 
> even if you scroll. This is also useful for ajax call because there is no 
> need to scroll to the top of the screen to view message.
> Message can stick to the screen until it is intentionally closed by the user 
> or not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-6023) Jrowl to display alerts

[Gaudin Pierre (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gaudin Pierre updated OFBIZ-6023:
-
Attachment: same-large-message-show-all.png

> Jrowl to display alerts 
> 
>
> Key: OFBIZ-6023
> URL: https://issues.apache.org/jira/browse/OFBIZ-6023
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gaudin Pierre
> Fix For: Trunk
>
> Attachments: Scrolling-1.png, Scrolling-2.png, Simple error 
> message.png, large-message-by-default.png, same-large-message-show-all.png
>
>
> Hi all,
> I've been working on Jgrowl integration for a project. 
> (https://github.com/stanlemon/jGrowl)
> This allow to display system's messages in a popup at the top of the windows 
> even if you scroll. This is also useful for ajax call because there is no 
> need to scroll to the top of the screen to view message.
> Message can stick to the screen until it is intentionally closed by the user 
> or not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-6023) Jrowl to display alerts

[Gaudin Pierre (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gaudin Pierre updated OFBIZ-6023:
-
Attachment: event-message.png

> Jrowl to display alerts 
> 
>
> Key: OFBIZ-6023
> URL: https://issues.apache.org/jira/browse/OFBIZ-6023
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gaudin Pierre
> Fix For: Trunk
>
> Attachments: Scrolling-1.png, Scrolling-2.png, Simple error 
> message.png, event-message.png, large-message-by-default.png, 
> same-large-message-show-all.png
>
>
> Hi all,
> I've been working on Jgrowl integration for a project. 
> (https://github.com/stanlemon/jGrowl)
> This allow to display system's messages in a popup at the top of the windows 
> even if you scroll. This is also useful for ajax call because there is no 
> need to scroll to the top of the screen to view message.
> Message can stick to the screen until it is intentionally closed by the user 
> or not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6023) Jrowl to display alerts

[Gaudin Pierre (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-6023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14285614#comment-14285614
 ] 

Gaudin Pierre commented on OFBIZ-6023:
--

Add some screenshots

> Jrowl to display alerts 
> 
>
> Key: OFBIZ-6023
> URL: https://issues.apache.org/jira/browse/OFBIZ-6023
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gaudin Pierre
> Fix For: Trunk
>
> Attachments: Scrolling-1.png, Scrolling-2.png, Simple error 
> message.png, event-message.png, large-message-by-default.png, 
> same-large-message-show-all.png
>
>
> Hi all,
> I've been working on Jgrowl integration for a project. 
> (https://github.com/stanlemon/jGrowl)
> This allow to display system's messages in a popup at the top of the windows 
> even if you scroll. This is also useful for ajax call because there is no 
> need to scroll to the top of the screen to view message.
> Message can stick to the screen until it is intentionally closed by the user 
> or not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-6023) JGrowl to display alerts

[Gaudin Pierre (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gaudin Pierre updated OFBIZ-6023:
-
Summary: JGrowl to display alerts   (was: Jrowl to display alerts )

> JGrowl to display alerts 
> -
>
> Key: OFBIZ-6023
> URL: https://issues.apache.org/jira/browse/OFBIZ-6023
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gaudin Pierre
> Fix For: Trunk
>
> Attachments: Scrolling-1.png, Scrolling-2.png, Simple error 
> message.png, event-message.png, large-message-by-default.png, 
> same-large-message-show-all.png
>
>
> Hi all,
> I've been working on Jgrowl integration for a project. 
> (https://github.com/stanlemon/jGrowl)
> This allow to display system's messages in a popup at the top of the windows 
> even if you scroll. This is also useful for ajax call because there is no 
> need to scroll to the top of the screen to view message.
> Message can stick to the screen until it is intentionally closed by the user 
> or not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6023) JGrowl to display alerts

[Gaudin Pierre (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-6023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14286201#comment-14286201
 ] 

Gaudin Pierre commented on OFBIZ-6023:
--

Thanks,

This feature also use another component : readmore 
(https://github.com/jedfoster/Readmore.js) under MIT licence 

> JGrowl to display alerts 
> -
>
> Key: OFBIZ-6023
> URL: https://issues.apache.org/jira/browse/OFBIZ-6023
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gaudin Pierre
> Fix For: Trunk
>
> Attachments: Scrolling-1.png, Scrolling-2.png, Simple error 
> message.png, event-message.png, large-message-by-default.png, 
> same-large-message-show-all.png
>
>
> Hi all,
> I've been working on Jgrowl integration for a project. 
> (https://github.com/stanlemon/jGrowl)
> This allow to display system's messages in a popup at the top of the windows 
> even if you scroll. This is also useful for ajax call because there is no 
> need to scroll to the top of the screen to view message.
> Message can stick to the screen until it is intentionally closed by the user 
> or not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6023) JGrowl to display alerts

[Gaudin Pierre (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-6023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14583169#comment-14583169
 ] 

Gaudin Pierre commented on OFBIZ-6023:
--

Hi all,

Sorry for the very long delay As attachment you can find a patch for trunk 
to display message in jgrowl.
This is available for all the themes excepted the theme bizzness.

> JGrowl to display alerts 
> -
>
> Key: OFBIZ-6023
> URL: https://issues.apache.org/jira/browse/OFBIZ-6023
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gaudin Pierre
> Fix For: Trunk
>
> Attachments: Scrolling-1.png, Scrolling-2.png, Simple error 
> message.png, event-message.png, large-message-by-default.png, 
> same-large-message-show-all.png
>
>
> Hi all,
> I've been working on Jgrowl integration for a project. 
> (https://github.com/stanlemon/jGrowl)
> This allow to display system's messages in a popup at the top of the windows 
> even if you scroll. This is also useful for ajax call because there is no 
> need to scroll to the top of the screen to view message.
> Message can stick to the screen until it is intentionally closed by the user 
> or not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-6023) JGrowl to display alerts

[Gaudin Pierre (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gaudin Pierre updated OFBIZ-6023:
-
Attachment: jgrowl.patch

> JGrowl to display alerts 
> -
>
> Key: OFBIZ-6023
> URL: https://issues.apache.org/jira/browse/OFBIZ-6023
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gaudin Pierre
> Fix For: Trunk
>
> Attachments: Scrolling-1.png, Scrolling-2.png, Simple error 
> message.png, event-message.png, jgrowl.patch, large-message-by-default.png, 
> same-large-message-show-all.png
>
>
> Hi all,
> I've been working on Jgrowl integration for a project. 
> (https://github.com/stanlemon/jGrowl)
> This allow to display system's messages in a popup at the top of the windows 
> even if you scroll. This is also useful for ajax call because there is no 
> need to scroll to the top of the screen to view message.
> Message can stick to the screen until it is intentionally closed by the user 
> or not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-6496) error in parsing array in ajaxUpdateAreas

[Gaudin Pierre (JIRA)]

Gaudin Pierre created OFBIZ-6496:


 Summary: error in parsing array in  ajaxUpdateAreas
 Key: OFBIZ-6496
 URL: https://issues.apache.org/jira/browse/OFBIZ-6496
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: Trunk
Reporter: Gaudin Pierre
 Fix For: Trunk


I had to use ajaxupdateareas to update dynamically data.
The call ajax contains parameters of type array.
IE : Parameter1 = {has, b, c}, parameter2=A, parameter3=B

Unfortunately, the function ajaxupdateareas Split the arguments via a simple 
Split(","). This also split the array...  . It is necessary to add a more 
complex regex to avoid to make Split into array. As attachment I put an 
available patch for the trunk version



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-6496) error in parsing array in ajaxUpdateAreas

[Gaudin Pierre (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gaudin Pierre updated OFBIZ-6496:
-
Attachment: selectall.js.patch

> error in parsing array in  ajaxUpdateAreas
> --
>
> Key: OFBIZ-6496
> URL: https://issues.apache.org/jira/browse/OFBIZ-6496
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gaudin Pierre
> Fix For: Trunk
>
> Attachments: selectall.js.patch
>
>
> I had to use ajaxupdateareas to update dynamically data.
> The call ajax contains parameters of type array.
> IE : Parameter1 = {has, b, c}, parameter2=A, parameter3=B
> Unfortunately, the function ajaxupdateareas Split the arguments via a simple 
> Split(","). This also split the array...  . It is necessary to add a more 
> complex regex to avoid to make Split into array. As attachment I put an 
> available patch for the trunk version



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-6496) error in parsing array in ajaxUpdateAreas

[Gaudin Pierre (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gaudin Pierre updated OFBIZ-6496:
-
Description: 
I had to use ajaxupdateareas to update dynamically data.
The call ajax contains parameters of type array.
{quote}
Parameter1={has,b,c},parameter2=A,parameter3=B
{quote}

Unfortunately, the function ajaxupdateareas Split the arguments via a simple 
Split(","). This also split the array...  . It is necessary to add a more 
complex regex to avoid to make Split into array. As attachment I put an 
available patch for the trunk version

  was:
I had to use ajaxupdateareas to update dynamically data.
The call ajax contains parameters of type array.
IE : Parameter1 = {has, b, c}, parameter2=A, parameter3=B

Unfortunately, the function ajaxupdateareas Split the arguments via a simple 
Split(","). This also split the array...  . It is necessary to add a more 
complex regex to avoid to make Split into array. As attachment I put an 
available patch for the trunk version


> error in parsing array in  ajaxUpdateAreas
> --
>
> Key: OFBIZ-6496
> URL: https://issues.apache.org/jira/browse/OFBIZ-6496
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gaudin Pierre
> Fix For: Trunk
>
> Attachments: selectall.js.patch
>
>
> I had to use ajaxupdateareas to update dynamically data.
> The call ajax contains parameters of type array.
> {quote}
> Parameter1={has,b,c},parameter2=A,parameter3=B
> {quote}
> Unfortunately, the function ajaxupdateareas Split the arguments via a simple 
> Split(","). This also split the array...  . It is necessary to add a more 
> complex regex to avoid to make Split into array. As attachment I put an 
> available patch for the trunk version



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-6624) error in isValidEan util

[Gaudin Pierre (JIRA)]

Gaudin Pierre created OFBIZ-6624:


 Summary: error in isValidEan util
 Key: OFBIZ-6624
 URL: https://issues.apache.org/jira/browse/OFBIZ-6624
 Project: OFBiz
  Issue Type: Bug
Affects Versions: Release Branch 14.12
Reporter: Gaudin Pierre


Hi,
There is an error in isValidEan util. It should be 12 and not 13 in the methods 
charAt and calcChecksum  because they start at 0.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-6624) error in isValidEan util

[Gaudin Pierre (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gaudin Pierre updated OFBIZ-6624:
-
Attachment: UtilValidate.java.patch

> error in isValidEan util
> 
>
> Key: OFBIZ-6624
> URL: https://issues.apache.org/jira/browse/OFBIZ-6624
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 14.12
>Reporter: Gaudin Pierre
> Attachments: UtilValidate.java.patch
>
>
> Hi,
> There is an error in isValidEan util. It should be 12 and not 13 in the 
> methods charAt and calcChecksum  because they start at 0.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6624) error in isValidEan util

[Gaudin Pierre (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-6624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14803058#comment-14803058
 ] 

Gaudin Pierre commented on OFBIZ-6624:
--

Many thanks jacques !!

> error in isValidEan util
> 
>
> Key: OFBIZ-6624
> URL: https://issues.apache.org/jira/browse/OFBIZ-6624
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 14.12
>Reporter: Gaudin Pierre
>Assignee: Jacques Le Roux
> Fix For: 14.12.01, 12.04.06, 13.07.03, Upcoming Branch
>
> Attachments: UtilValidate.java.patch
>
>
> Hi,
> There is an error in isValidEan util. It should be 12 and not 13 in the 
> methods charAt and calcChecksum  because they start at 0.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] Updated: (OFBIZ-2127) mime type template render context error

[Gaudin Pierre (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-2127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gaudin Pierre updated OFBIZ-2127:
-

Attachment: patch.txt

here is a patch

> mime type template render context error
> ---
>
> Key: OFBIZ-2127
> URL: https://issues.apache.org/jira/browse/OFBIZ-2127
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: SVN trunk
>Reporter: Gaudin Pierre
> Fix For: SVN trunk
>
> Attachments: patch.txt
>
>
> Hi all,
> There is a small error into writeText() method form DataResourceWorker. 
> The static method renderMimeTypeTemplate is calling with "context" object 
> instead of "mimeContext". There are more Objects in the "mimeContext" so we 
> can display more elements.
> I think this is an error because "mimeContext" is never use.
> Thanks in advance
> Pierre

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Created: (OFBIZ-2127) mime type template render context error

[Gaudin Pierre (JIRA)]

mime type template render context error
---

 Key: OFBIZ-2127
 URL: https://issues.apache.org/jira/browse/OFBIZ-2127
 Project: OFBiz
  Issue Type: Bug
  Components: content
Affects Versions: SVN trunk
Reporter: Gaudin Pierre
 Fix For: SVN trunk
 Attachments: patch.txt

Hi all,

There is a small error into writeText() method form DataResourceWorker. 

The static method renderMimeTypeTemplate is calling with "context" object 
instead of "mimeContext". There are more Objects in the "mimeContext" so we can 
display more elements.

I think this is an error because "mimeContext" is never use.

Thanks in advance

Pierre




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Created: (OFBIZ-1152) error in view-size used for paginate = "false" form

[Gaudin Pierre (JIRA)]

error in view-size used for paginate = "false" form 


 Key: OFBIZ-1152
 URL: https://issues.apache.org/jira/browse/OFBIZ-1152
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: SVN trunk
Reporter: Gaudin Pierre
 Fix For: SVN trunk


If paginate is set to false then wiev-size is never used. Only  
DEFAULT_PAGE_SIZE is used.

1/ in init() Modelform wiev-size is getting : 
setDefaultViewSize(formElement.getAttribute("view-size"));
=>OK

2/ this value is set to defaultViewSize
defaultViewSize = sz.intValue();
=> OK

3/ in getListLimits() Modelform if paginate is false then DEFAULT_PAGE_SIZE is 
used and not defaultViewSize
  viewSize = DEFAULT_PAGE_SIZE;
=> KO



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (OFBIZ-1152) error in view-size used for paginate = "false" form

[Gaudin Pierre (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gaudin Pierre updated OFBIZ-1152:
-

Attachment: defaultViewSize.patch

here is the patch from revision 556832

> error in view-size used for paginate = "false" form 
> 
>
> Key: OFBIZ-1152
> URL: https://issues.apache.org/jira/browse/OFBIZ-1152
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: SVN trunk
>Reporter: Gaudin Pierre
> Fix For: SVN trunk
>
> Attachments: defaultViewSize.patch
>
>
> If paginate is set to false then wiev-size is never used. Only  
> DEFAULT_PAGE_SIZE is used.
> 1/ in init() Modelform wiev-size is getting : 
> setDefaultViewSize(formElement.getAttribute("view-size"));
> =>OK
> 2/ this value is set to defaultViewSize
> defaultViewSize = sz.intValue();
> => OK
> 3/ in getListLimits() Modelform if paginate is false then DEFAULT_PAGE_SIZE 
> is used and not defaultViewSize
>   viewSize = DEFAULT_PAGE_SIZE;
> => KO

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (OFBIZ-1152) error in view-size used for paginate = "false" form

[Gaudin Pierre (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12513846
 ] 

Gaudin Pierre commented on OFBIZ-1152:
--

Hi all,

Is there any body to have a look at this patch ?

This is a very simple but important fix.

Thanks

Pierre

> error in view-size used for paginate = "false" form 
> 
>
> Key: OFBIZ-1152
> URL: https://issues.apache.org/jira/browse/OFBIZ-1152
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: SVN trunk
>Reporter: Gaudin Pierre
> Fix For: SVN trunk
>
> Attachments: defaultViewSize.patch
>
>
> If paginate is set to false then wiev-size is never used. Only  
> DEFAULT_PAGE_SIZE is used.
> 1/ in init() Modelform wiev-size is getting : 
> setDefaultViewSize(formElement.getAttribute("view-size"));
> =>OK
> 2/ this value is set to defaultViewSize
> defaultViewSize = sz.intValue();
> => OK
> 3/ in getListLimits() Modelform if paginate is false then DEFAULT_PAGE_SIZE 
> is used and not defaultViewSize
>   viewSize = DEFAULT_PAGE_SIZE;
> => KO

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (OFBIZ-1152) error in view-size used for paginate = "false" form

[Gaudin Pierre (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12513866
 ] 

Gaudin Pierre commented on OFBIZ-1152:
--

Many thanks Jacques !

Pierre

> error in view-size used for paginate = "false" form 
> 
>
> Key: OFBIZ-1152
> URL: https://issues.apache.org/jira/browse/OFBIZ-1152
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: SVN trunk
>Reporter: Gaudin Pierre
>Assignee: Jacques Le Roux
> Fix For: SVN trunk, Release Branch 4.0
>
> Attachments: defaultViewSize.patch
>
>
> If paginate is set to false then wiev-size is never used. Only  
> DEFAULT_PAGE_SIZE is used.
> 1/ in init() Modelform wiev-size is getting : 
> setDefaultViewSize(formElement.getAttribute("view-size"));
> =>OK
> 2/ this value is set to defaultViewSize
> defaultViewSize = sz.intValue();
> => OK
> 3/ in getListLimits() Modelform if paginate is false then DEFAULT_PAGE_SIZE 
> is used and not defaultViewSize
>   viewSize = DEFAULT_PAGE_SIZE;
> => KO

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.