Community Over Code Bratislava 2024

[Giulio Speri - MpStyle Srl]

Good morning devs,

Me and my colleague Nicola are attending the Community Over Code Event in
Bratislava.
Is any of you also participating? It would be great to meet you in person!
:)

Have a nice day,
Giulio

Re: [VOTE] [RELEASE] Apache OFBiz 18.12.12 - third attempt

[Giulio Speri - MpStyle Srl]

Hi Jacopo,

+1

BUILD SUCCESSFUL in 35m 59s
30 actionable tasks: 25 executed, 5 up-to-date
Done processing files for release apache-ofbiz-18.12.12

Linux/Ubuntu 22.04.03 LTS, OpenJDK Runtime Environment (build
17.0.9+9-Ubuntu-122.04)

Thanks,
Giulio

Il giorno mer 14 feb 2024 alle ore 08:56 Jacques Le Roux <
jacques.le.r...@les7arts.com> ha scritto:

> Hi,
>
> And this is what get on Ubuntu 20.04, better for SHA512 (but not right it
> seems), weird for GPG. All that was working before, notably with last
> versions of apache-ofbiz-18.12.12.
>
> jacques@jacques-VirtualBox:~/ofbiz-tools$ ./verify-ofbiz-release.sh -v
> apache-ofbiz-18.12.12  2>&1 | tee verify.log
> Processing files for release: apache-ofbiz-18.12.12...
> Verifying files...
> sha check of file: apache-ofbiz-18.12.12.zip
> Using sha file: apache-ofbiz-18.12.12.zip.sha512
> apache-ofbiz-18.12.12.zip: 67AA5932 53FFF35F 3AA89DC9 73951B33 8396F95D
> ECF26EBD 1DB58C66 50EE37E5 D053CD02 C9CB3FC4 B06D8CCC 747FAAA1 45B251CA
> 5F95A606 B1CC6C1A A8CBC42C
> apache-ofbiz-18.12.12.zip: 67AA5932 53FFF35F 3AA89DC9 73951B33 8396F95D
> ECF26EBD 1DB58C66 50EE37E5 D053CD02 C9CB3FC4 B06D8CCC 747FAAA1 45B251CA
> 5F95A606 B1CC6C1A A8CBC42C
> sha sums mismatch!
>
> GPG verification output
> gpg: Signature made jeu. 08 févr. 2024 11:03:49 CET
> gpg:using RSA key 3545C5E31CC2D029B2CCAD067A580908847AF9E0
> gpg: Can't check signature: No public key
>
> Done processing files for release apache-ofbiz-18.12.12
>
> "sha sums mismatch!" sounds weird to me as the two lines compare
>
> Also I don't understand what's going on with GPG since I have both KEYS
> and apache-ofbiz-18.12.12.zip.asc
>
> Do I miss something?
>
> Jacques
>
>
> Le 13/02/2024 à 14:09, Jacques Le Roux a écrit :
> > Since I'm on win7 using PowerShell:
> >
> >PS C:\projectsASF\Git\ofbiz-framework\tools> Get-Filehash
> apache-ofbiz-18.12.12.zip -a SHA512
> >Algorithm Hash Path
> >-  
> >SHA512
> D6CC35969BD53A4C34E267A9221AE76AF416E2A0D442A2195B16227F2A431B2CBDC...
> C:\projectsASF\Git\ofbiz-framework\tools\apache-ofbiz-18.12.12.zip
> >
> >PS C:\projectsASF\Git\ofbiz-framework\tools> Get-Filehash
> apache-ofbiz-18.12.12.zip.sha512 -a SHA512
> >Algorithm Hash Path
> >-  
> >SHA512
> EB5E9CEAF1250D1D78BE0ADC9F729BCDBB90646EBFC7434F47EAEE73BCF5008...
> > C:\projectsASF\Git\ofbiz-framework\tools\apache-ofbiz-18.12.12.zip.sha512
> >
> > Not sure why it's different from verify-ofbiz-release.sh result :/
> >
> > Le 13/02/2024 à 13:51, Jacques Le Roux a écrit :
> >> Hi Jacopo,
> >>
> >> It seems there is at least a hash issue:
> >>
> >> sha check of file: apache-ofbiz-18.12.12.zip
> >> Using sha file: apache-ofbiz-18.12.12.zip.sha512
> >> apache-ofbiz-18.12.12.zip: D6CC3596 9BD53A4C 34E267A9 221AE76A F416E2A0
> D442A219 5B16227F 2A431B2C BDCB0E05 87C334C6 19DB5EE4 ED0D1F21 5EC90253
> >> 88AB6487 DC5B71E7 5BA97A17
> >> apache-ofbiz-18.12.12.zip: 67AA5932 53FFF35F 3AA89DC9 73951B33 8396F95D
> ECF26EBD 1DB58C66 50EE37E5 D053CD02 C9CB3FC4 B06D8CCC 747FAAA1 45B251CA
> >> 5F95A606 B1CC6C1A A8CBC42C
> >> sha sums mismatch!
> >>
> >> Thanks
> >>
> >> Jacques
> >>
> >> Le 13/02/2024 à 09:34, Jacopo Cappellato a écrit :
> >>> This is the vote thread, third attempt, to publish "Apache OFBiz
> >>> 18.12.12", twelfth
> >>> release from the release18.12 branch.
> >>>
> >>> The release files can be downloaded from here:
> >>> https://dist.apache.org/repos/dist/dev/ofbiz/
> >>> and are:
> >>> * apache-ofbiz-18.12.12.zip
> >>> * KEYS: text file with keys
> >>> * apache-ofbiz-18.12.12.zip.asc: the detached signature file
> >>> * apache-ofbiz-18.12.12.zip.sha512: checksum file
> >>>
> >>> Please download and test the zip file and its signatures (for
> >>> instructions on testing the signatures see
> >>> http://www.apache.org/info/verification.html).
> >>>
> >>> Vote:
> >>> [ +1] release as Apache OFBiz 18.12.12
> >>> [ -1] do not release
> >>>
> >>> This vote is open for at least 5 days.
> >>>
> >>> For more details about this process please refer to
> >>> http://www.apache.org/foundation/voting.html
>


-- 
Giulio Speri
Full Stack Web Developer


*Mp Styl**e Srl*
via Antonio Meucci, 37
41019 Limidi di Soliera (MO)
T 059/684916
M 347/0965506

www.mpstyle.it

Re: [VOTE] [RELEASE] Apache OFBiz 18.12.12 - second attempt

[Giulio Speri - MpStyle Srl]

Good morning,

BUILD SUCCESSFUL in 19m 28s
> 30 actionable tasks: 25 executed, 5 up-to-date
> Done processing files for release apache-ofbiz-18.12.12


Linux/Ubuntu 22.04 LTS, OpenJDK 11

+1

Thank you Jacopo

Il giorno gio 8 feb 2024 alle ore 18:29 Jacques Le Roux <
jacques.le.r...@les7arts.com> ha scritto:

> Thanks Jacopo,
>
> All works as expected Win7
>
> +1
>
> Jacques
>
> Le 08/02/2024 à 14:29, Jacopo Cappellato a écrit :
> > This is the vote thread, second attempt, to publish "Apache OFBiz
> > 18.12.12", twelfth
> > release from the release18.12 branch.
> >
> > The release files can be downloaded from here:
> > https://dist.apache.org/repos/dist/dev/ofbiz/
> > and are:
> > * apache-ofbiz-18.12.12.zip
> > * KEYS: text file with keys
> > * apache-ofbiz-18.12.12.zip.asc: the detached signature file
> > * apache-ofbiz-18.12.12.zip.sha512: checksum file
> >
> > Please download and test the zip file and its signatures (for
> > instructions on testing the signatures see
> > http://www.apache.org/info/verification.html).
> >
> > Vote:
> > [ +1] release as Apache OFBiz 18.12.12
> > [ -1] do not release
> >
> > This vote is open for at least 5 days.
> >
> > For more details about this process please refer to
> > http://www.apache.org/foundation/voting.html
>


-- 
Giulio Speri
Full Stack Web Developer


*Mp Styl**e Srl*
via Antonio Meucci, 37
41019 Limidi di Soliera (MO)
T 059/684916
M 347/0965506

www.mpstyle.it

Re: [VOTE] Release Apache OFBiz 18.12.11

[Giulio Speri - MpStyle Srl]

+1

BUILD SUCCESSFUL in 20m 43s
30 actionable tasks: 25 executed, 5 up-to-date
Done processing files for release apache-ofbiz-18.12.11

Ubuntu/Linux 22.04 LTS, OpenJDK 17

Thanks Jacopo


Il giorno lun 18 dic 2023 alle ore 15:39 Ashish Vijaywargiya <
vijaywargiya.ash...@gmail.com> ha scritto:

> Tried the following two commands:
>
> ./verify-ofbiz-release.sh -v apache-ofbiz-18.12.11
>
> &
>
> ./verify-ofbiz-release.sh -a apache-ofbiz-18.12.11
>
> All good. ✅✅
>
> +1
>
> Thank you, Jacopo.
>
> --
> Kind Regards,
> Ashish Vijaywargiya
>
>
> On Sat, 16 Dec 2023 at 15:32, Jacopo Cappellato <
> jacopo.cappell...@gmail.com>
> wrote:
>
> > This is the vote thread to publish "Apache OFBiz 18.12.11", eleventh
> > release from the release18.12 branch.
> >
> > The release files can be downloaded from here:
> > https://dist.apache.org/repos/dist/dev/ofbiz/
> > and are:
> > * apache-ofbiz-18.12.11.zip
> > * KEYS: text file with keys
> > * apache-ofbiz-18.12.11.zip.asc: the detached signature file
> > * apache-ofbiz-18.12.11.zip.sha512: checksum file
> >
> > Please download and test the zip file and its signatures (for
> > instructions on testing the signatures see
> > http://www.apache.org/info/verification.html).
> >
> > Vote:
> > [ +1] release as Apache OFBiz 18.12.11
> > [ -1] do not release
> >
> > This vote is open for at least 5 days.
> >
> > For more details about this process please refer to
> > http://www.apache.org/foundation/voting.html
> >
>


-- 
Giulio Speri
Full Stack Web Developer


*Mp Styl**e Srl*
via Antonio Meucci, 37
41019 Limidi di Soliera (MO)
T 059/684916
M 347/0965506

www.mpstyle.it

Re: [VOTE] Apache OFBiz 18.12.10

[Giulio Speri - MpStyle Srl]

+1

BUILD SUCCESSFUL in 18m 44s
30 actionable tasks: 25 executed, 5 up-to-date
Done processing files for release apache-ofbiz-18.12.10

Thanks Jacopo

Il giorno lun 27 nov 2023 alle ore 16:44 Jacques Le Roux <
jacques.le.r...@les7arts.com> ha scritto:

> Thanks Jacopo,
>
> All works as expected
>
> +1
>
> Jacques
>
> Le 27/11/2023 à 11:48, Jacopo Cappellato a écrit :
> > This is the vote thread to publish "Apache OFBiz 18.12.10", tenth
> > release from the release18.12 branch.
> >
> > The release files can be downloaded from here:
> > https://dist.apache.org/repos/dist/dev/ofbiz/
> > and are:
> > * apache-ofbiz-18.12.10.zip
> > * KEYS: text file with keys
> > * apache-ofbiz-18.12.10.zip.asc: the detached signature file
> > * apache-ofbiz-18.12.10.zip.sha512: checksum file
> >
> > Please download and test the zip file and its signatures (for
> > instructions on testing the signatures see
> > http://www.apache.org/info/verification.html).
> >
> > Vote:
> > [ +1] release as Apache OFBiz 18.12.10
> > [ -1] do not release
> >
> > This vote is open for at least 5 days.
> >
> > For more details about this process please refer to
> > http://www.apache.org/foundation/voting.html
>


-- 
Giulio Speri
Full Stack Web Developer


*Mp Styl**e Srl*
via Antonio Meucci, 37
41019 Limidi di Soliera (MO)
T 059/684916
M 347/0965506

www.mpstyle.it

Re: [VOTE] Apache OFBiz 18.12.09

[Giulio Speri - MpStyle Srl]

Hi,

+1

BUILD SUCCESSFUL in 19m 20s
30 actionable tasks: 25 executed, 5 up-to-date
Done processing files for release apache-ofbiz-18.12.09

On Linux/Ubuntu 20.04 LTS, Java 8

Thank you Jacopo

Il giorno lun 30 ott 2023 alle ore 16:25 Jacques Le Roux <
jacques.le.r...@les7arts.com> ha scritto:

> Hi Michael,
>
> This did no happen to me. And yes the plugins are part of the release.
> Also as you know attachments rarely works for Apache ML.
>
> Le 30/10/2023 à 14:41, Michael Brohl a écrit :
> > -1
> >
> > The build fails with some exceptions for converters, solr-server and
> others (see attached log).
> >
> > I'm not completely sure but I do not expect the plugins to be shipped in
> the framework distribution?
> >
> > Best regards,
> >
> > Michael Brohl
> >
> > ecomify GmbH - www.ecomify.de
> >
> >
> > Am 29.10.23 um 13:16 schrieb Jacopo Cappellato:
> >> This is the vote thread to publish "Apache OFBiz 18.12.09", ninth
> >> release from the release18.12 branch.
> >>
> >> The release files can be downloaded from here:
> >> https://dist.apache.org/repos/dist/dev/ofbiz/
> >> and are:
> >> * apache-ofbiz-18.12.09.zip
> >> * KEYS: text file with keys
> >> * apache-ofbiz-18.12.09.zip.asc: the detached signature file
> >> * apache-ofbiz-18.12.09.zip.sha512: checksum file
> >>
> >> Please download and test the zip file and its signatures (for
> >> instructions on testing the signatures see
> >> http://www.apache.org/info/verification.html).
> >>
> >> Vote:
> >> [ +1] release as Apache OFBiz 18.12.09
> >> [ -1] do not release
> >>
> >> This vote is open for at least 5 days.
> >>
> >> For more details about this process please refer to
> >> http://www.apache.org/foundation/voting.html
>


-- 
Giulio Speri


*Mp Styl**e Srl*
via Antonio Meucci, 37
41019 Limidi di Soliera (MO)
T 059/684916
M 347/0965506

www.mpstyle.it

Re: Problems in pushing changes to trunk GitHub repository

[Giulio Speri - MpStyle Srl]

Hello Daniel,

I can confirm you that using git push from CLI worked correctly, so it has
to be an issue with the git integrated plugin of Eclipse.

Thank you for the suggestion,
Giulio

Il giorno ven 25 nov 2022 alle ore 14:51 Giulio Speri - MpStyle Srl <
giulio.sp...@mpstyle.it> ha scritto:

> Hi Daniel,
>
> I will give git cli a try and return to you with feedback.
>
> Thank you,
> Giulio
>
> Il giorno ven 25 nov 2022 alle ore 09:15 Daniel Watford 
> ha scritto:
>
>> Hi Giulio,
>>
>> Do you see the same issue if running 'git push' from the command line?
>>
>> One theory is the paths used by the Git integration in eclipse reference a
>> different version of JDK to your regular builds.
>>
>> On Thu, 24 Nov 2022 at 23:42, Giulio Speri - MpStyle Srl <
>> giulio.sp...@mpstyle.it> wrote:
>>
>> > Hello devs,
>> >
>> > I hope you're doing great.
>> > I am currently having some problems in pushing ("Preview") a commit to
>> the
>> > GitHub trunk repository.
>> > I am using Eclipse with the integrated git plugin and I am getting this
>> > error:
>> >
>> > Can't connect to any URI: https://github.com/apache/ofbiz-framework.git
>> > > (Rejected by "pre-push" hook.
>> > > FAILURE: Build failed with an exception
>> > > * What went wrong:
>> > > Execution failed for task ':compileJava'.
>> > > >java.lang.IllegalAccessError:class
>> > > org.gradle.internal.compiler.java.ClassNameCollector(in unnamed
>> > > module @0x5cfb4510) cannot access class
>> > > com.sun.tools.javac.code.Symbol$TypeSymbol (in module jdk.compiler)
>> > because
>> > > module jdk.compiler does not export com.sun.tools.javac.code to
>> unnamed
>> > > module @0x5cfb4510
>> >
>> > ...
>> > > BUILD FAILED in 3s
>> >
>> >
>> > I am using openjdk-11 as java and the project itself correctly builds
>> and
>> > run using standard commands *./gradlew build* - *./gradlew ofbiz*
>> >
>> > The error above shows up with the standard gradlew build command only
>> when
>> > trying to compile the code using openjdk-17 (but I am not using it),
>> and as
>> > I mentioned when trying to "Preview" the push of the HEAD.
>> >
>> > Anyone have had a similar issue or have some suggestions regarding it?
>> >
>> > Thank you in advance,
>> > Giulio
>> >
>> >
>> >
>> > --
>> > Giulio Speri
>> >
>> >
>> > *Mp Styl**e Srl*
>> > via Antonio Meucci, 37
>> > 41019 Limidi di Soliera (MO)
>> > T 059/684916
>> > M 347/0965506
>> >
>> > www.mpstyle.it
>> >
>>
>>
>> --
>> Daniel Watford
>>
>
>
> --
> Giulio Speri
>
>
> *Mp Styl**e Srl*
> via Antonio Meucci, 37
> 41019 Limidi di Soliera (MO)
> T 059/684916
> M 347/0965506
>
> www.mpstyle.it
>
>
>

-- 
Giulio Speri


*Mp Styl**e Srl*
via Antonio Meucci, 37
41019 Limidi di Soliera (MO)
T 059/684916
M 347/0965506

www.mpstyle.it

Re: Problems in pushing changes to trunk GitHub repository

[Giulio Speri - MpStyle Srl]

Hi Daniel,

I will give git cli a try and return to you with feedback.

Thank you,
Giulio

Il giorno ven 25 nov 2022 alle ore 09:15 Daniel Watford 
ha scritto:

> Hi Giulio,
>
> Do you see the same issue if running 'git push' from the command line?
>
> One theory is the paths used by the Git integration in eclipse reference a
> different version of JDK to your regular builds.
>
> On Thu, 24 Nov 2022 at 23:42, Giulio Speri - MpStyle Srl <
> giulio.sp...@mpstyle.it> wrote:
>
> > Hello devs,
> >
> > I hope you're doing great.
> > I am currently having some problems in pushing ("Preview") a commit to
> the
> > GitHub trunk repository.
> > I am using Eclipse with the integrated git plugin and I am getting this
> > error:
> >
> > Can't connect to any URI: https://github.com/apache/ofbiz-framework.git
> > > (Rejected by "pre-push" hook.
> > > FAILURE: Build failed with an exception
> > > * What went wrong:
> > > Execution failed for task ':compileJava'.
> > > >java.lang.IllegalAccessError:class
> > > org.gradle.internal.compiler.java.ClassNameCollector(in unnamed
> > > module @0x5cfb4510) cannot access class
> > > com.sun.tools.javac.code.Symbol$TypeSymbol (in module jdk.compiler)
> > because
> > > module jdk.compiler does not export com.sun.tools.javac.code to unnamed
> > > module @0x5cfb4510
> >
> > ...
> > > BUILD FAILED in 3s
> >
> >
> > I am using openjdk-11 as java and the project itself correctly builds and
> > run using standard commands *./gradlew build* - *./gradlew ofbiz*
> >
> > The error above shows up with the standard gradlew build command only
> when
> > trying to compile the code using openjdk-17 (but I am not using it), and
> as
> > I mentioned when trying to "Preview" the push of the HEAD.
> >
> > Anyone have had a similar issue or have some suggestions regarding it?
> >
> > Thank you in advance,
> > Giulio
> >
> >
> >
> > --
> > Giulio Speri
> >
> >
> > *Mp Styl**e Srl*
> > via Antonio Meucci, 37
> > 41019 Limidi di Soliera (MO)
> > T 059/684916
> > M 347/0965506
> >
> > www.mpstyle.it
> >
>
>
> --
> Daniel Watford
>


-- 
Giulio Speri


*Mp Styl**e Srl*
via Antonio Meucci, 37
41019 Limidi di Soliera (MO)
T 059/684916
M 347/0965506

www.mpstyle.it

Problems in pushing changes to trunk GitHub repository

[Giulio Speri - MpStyle Srl]

Hello devs,

I hope you're doing great.
I am currently having some problems in pushing ("Preview") a commit to the
GitHub trunk repository.
I am using Eclipse with the integrated git plugin and I am getting this
error:

Can't connect to any URI: https://github.com/apache/ofbiz-framework.git
> (Rejected by "pre-push" hook.
> FAILURE: Build failed with an exception
> * What went wrong:
> Execution failed for task ':compileJava'.
> >java.lang.IllegalAccessError:class
> org.gradle.internal.compiler.java.ClassNameCollector(in unnamed
> module @0x5cfb4510) cannot access class
> com.sun.tools.javac.code.Symbol$TypeSymbol (in module jdk.compiler) because
> module jdk.compiler does not export com.sun.tools.javac.code to unnamed
> module @0x5cfb4510

...
> BUILD FAILED in 3s


I am using openjdk-11 as java and the project itself correctly builds and
run using standard commands *./gradlew build* - *./gradlew ofbiz*

The error above shows up with the standard gradlew build command only when
trying to compile the code using openjdk-17 (but I am not using it), and as
I mentioned when trying to "Preview" the push of the HEAD.

Anyone have had a similar issue or have some suggestions regarding it?

Thank you in advance,
Giulio



-- 
Giulio Speri


*Mp Styl**e Srl*
via Antonio Meucci, 37
41019 Limidi di Soliera (MO)
T 059/684916
M 347/0965506

www.mpstyle.it

Re: How committers should handle old Jira Issues (and patches)

[Giulio Speri - MpStyle Srl]

Thank you Michael and Taher for your feedback and suggestions on how to
approach issues.
I'll try my best to evaluate and handle them for the goodness of the
project.

Have a nice day,
Giulio

Il giorno dom 30 ott 2022 alle ore 07:56 Taher Alkhateeb
 ha scritto:

>
> I think I would be in favor of always closing tickets instead of letting
> them hang indefinitely. In my experience old and stale tickets are really
> never handled, they eventually get outdated and irrelevant, and after
> enough accumulation everyone stops caring to attend to them. On the other
> hand, having very few but really active and really happening tickets
> encourages everyone to try and get everything done because it is "possible"
> as opposed to having mountains of those things around which just leads to
> overwhelm and chaos.
>
> I find many of the tickets difficult to understand, missing repeat steps,
> vague, or simply not too necessary or critical. Closing these off would
> probably bring relief to the project.
>
> my 2 cents
>
> Taher Alkhateeb
>
> On Saturday, October 29, 2022 16:34 +03, Michael Brohl <
> michael.br...@ecomify.de> wrote:
>  Hi Giulio,
>
> thanks for taking care of the Jira issues and bringing this up.
>
> As to my knowledge, there is no strict rule on how to handle this. We
> are a community of volunteers and sometimes contributors come and go so
> it is common that you will get late or no responses to an issue comment.
>
> Personally, I ask 1-3 times and then decide for myself on how to proceed
> with the issue. The action taken depends on the issue (working on it,
> closing it because of no response, ...).
>
> So I encourage you to decide what you think would be the best for the
> project and go on. If there is an objection, it will be raised.
>
> Regarding the mentioned OFBIT-9362, your comment is only 4 days old. You
> should give people at least 1-2 weeks to respond.  What you can also do
> is to mention how you will proceed with the issue if there is no
> response within xx days/weeks.
>
> Hope this helps,
>
> best regards,
>
> Michael Brohl
>
> ecomify GmbH - www.ecomify.de
>
>
> Am 28.10.22 um 19:14 schrieb Giulio Speri - MpStyle Srl:
> > Hello devs,
> >
> > I hope you're doing great.
> > I recently started to give a check to the old ofbiz issues in Jira with
> the
> > status "patch available", both to increase my contribution as (new)
> > committer and also to try to reduce the bug list.
> > To warm up I started with the "trivia" issues and then I'll proceed. :)
> >
> > I came across some (quite) old issues and I tried to gather informations
> by
> > contacting the original reporter or the assignee of that task (ie:
> > OFBIZ-9362).
> > What if nobody replies for some time (maybe the original
> reporter/assignee
> > is no more involved in the project so not able to respond), as for the
> case
> > of the issue OFBIZ-9362 ? Are there some community guidelines for this
> kind
> > of situation? Should I keep waiting for a response or should I re-analyze
> > the issue, assign it to me and then work on it?
> >
> >
> > Thank you in advance,
> >
> > Giulio
> >
> >
> >
> >
>


-- 
Giulio Speri


*Mp Styl**e Srl*
via Antonio Meucci, 37
41019 Limidi di Soliera (MO)
T 059/684916
M 347/0965506

www.mpstyle.it

How committers should handle old Jira Issues (and patches)

[Giulio Speri - MpStyle Srl]

Hello devs,

I hope you're doing great.
I recently started to give a check to the old ofbiz issues in Jira with the
status "patch available", both to increase my contribution as (new)
committer and also to try to reduce the bug list.
To warm up I started with the "trivia" issues and then I'll proceed. :)

I came across some (quite) old issues and I tried to gather informations by
contacting the original reporter or the assignee of that task (ie:
OFBIZ-9362).
What if nobody replies for some time (maybe the original reporter/assignee
is no more involved in the project so not able to respond), as for the case
of the issue OFBIZ-9362 ? Are there some community guidelines for this kind
of situation? Should I keep waiting for a response or should I re-analyze
the issue, assign it to me and then work on it?


Thank you in advance,

Giulio




-- 
Giulio Speri


*Mp Styl**e Srl*
via Antonio Meucci, 37
41019 Limidi di Soliera (MO)
T 059/684916
M 347/0965506

www.mpstyle.it

Re: Gradlew build issue in trunk revision

[Giulio Speri - MpStyle Srl]

Hello devs,

forget the previous email, I solved it.
I've changed the java version to correct one (11), but the gradle bash
script did read the JAVA_HOME env variable that was set in
/etc/environment, so it kept reading the older Java version. 

All fine.

Have a nice weekend.

Giulio


Il giorno gio 6 ott 2022 alle ore 15:41 Giulio Speri - MpStyle Srl <
giulio.sp...@mpstyle.it> ha scritto:

> Hello devs,
>
> I am writing because I am facing a build issue with the trunk revision.
>
> The error is the following:
>
> FAILURE: Build failed with an exception.
>
> * What went wrong:
>> java.lang.UnsupportedClassVersionError:
>> at/bxm/gradleplugins/svntools/SvnToolsPlugin has been compiled by a more
>> recent version of the Java Runtime (class file version 55.0), this version
>> of the Java Runtime only recognizes class file versions up to 52.0
>> > at/bxm/gradleplugins/svntools/SvnToolsPlugin has been compiled by a
>> more recent version of the Java Runtime (class file version 55.0), this
>> version of the Java Runtime only recognizes class file versions up to 52.0
>
>
> I already tried the following without success:
> - changed local Java version (JDK 8, openjdk11, openjdk17) and made a
> build try after each change;
> - cleared local gradle cache;
> - deleted and re-cloned local trunk repository;
>
> I am sure I am missing something easy, but I really can't point out what.
> I read that there has been something similar for R18, that has been fixed
> (indeed it builds).
>
> Has anyone faced a similar issue ?
>
> Thank you in advance,
>
> Giulio
>
> --
> Giulio Speri
>
>
> *Mp Styl**e Srl*
> via Antonio Meucci, 37
> 41019 Limidi di Soliera (MO)
> T 059/684916
> M 347/0965506
>
> www.mpstyle.it
>
>
>

-- 
Giulio Speri


*Mp Styl**e Srl*
via Antonio Meucci, 37
41019 Limidi di Soliera (MO)
T 059/684916
M 347/0965506

www.mpstyle.it

Gradlew build issue in trunk revision

[Giulio Speri - MpStyle Srl]

Hello devs,

I am writing because I am facing a build issue with the trunk revision.

The error is the following:

FAILURE: Build failed with an exception.

* What went wrong:
> java.lang.UnsupportedClassVersionError:
> at/bxm/gradleplugins/svntools/SvnToolsPlugin has been compiled by a more
> recent version of the Java Runtime (class file version 55.0), this version
> of the Java Runtime only recognizes class file versions up to 52.0
> > at/bxm/gradleplugins/svntools/SvnToolsPlugin has been compiled by a more
> recent version of the Java Runtime (class file version 55.0), this version
> of the Java Runtime only recognizes class file versions up to 52.0


I already tried the following without success:
- changed local Java version (JDK 8, openjdk11, openjdk17) and made a build
try after each change;
- cleared local gradle cache;
- deleted and re-cloned local trunk repository;

I am sure I am missing something easy, but I really can't point out what.
I read that there has been something similar for R18, that has been fixed
(indeed it builds).

Has anyone faced a similar issue ?

Thank you in advance,

Giulio

-- 
Giulio Speri


*Mp Styl**e Srl*
via Antonio Meucci, 37
41019 Limidi di Soliera (MO)
T 059/684916
M 347/0965506

www.mpstyle.it

Re: Welcome to Leila Mekika as new committer

[Giulio Speri - MpStyle Srl]

Congratulations Leila and welcome aboard!

Kind regards,
Giulio



On Wed, Oct 5, 2022, 03:35 Michael Brohl  wrote:

> Congratulations and welcome from me as well, Leila!
>
> Looking forward to your contributions and working together.
>
> Best regards,
>
> Michael
>
> Am 04.10.22 um 09:30 schrieb MLeila:
> > Hello all,
> >
> > Thanks for your welcome!
> > I am glad to join the team and be able to contribute more actively on
> > the project
> >
> > Regards,
> > Leila
> >
> > Le 04/10/2022 à 07:38, Devanshu Vyas a écrit :
> >> Many congratulations and welcome aboard Leila!!
> >>
> >> Thanks & Regards,
> >> Devanshu Vyas.
> >>
> >>
> >> On Mon, Oct 3, 2022 at 6:27 PM Nicolas Malin 
> >> wrote:
> >>
> >>> The OFBiz PMC has invited Leila Mekika as new
> >>> committer and we are glad to announce that she have accepted the
> >>> nomination.
> >>>
> >>> On behalf of the OFBiz PMC, welcome on board!
> >>>
> >>>
> >>>
> >
>

Re: Possible issue in balanceInventoryItems/reassignInventoryReservation service

[Giulio Speri - MpStyle Srl]

Hi Nicolas,

Thank you for your feedback and I will be happy to help you in the
conversion process. :)
How would you like to proceed?

Giulio

Il giorno ven 8 lug 2022 alle ore 15:33 Nicolas Malin <
nicolas.ma...@nereide.fr> ha scritto:

> Hello Giulio,
>
> I thinks it's good to remove hard coded value and move it on the
> productStore.
>
> Keep the N as default if you didn't found any value.
>
> I use your focus on this subject to know if you want to help me to
> convert the minilang inventory service to groovy.
> I can realize the conversion without problem, but I like to have some
> production data to be ensure that I didn't introduce a regression not
> cover by ofbiz test.
>
> My problem, our project don't use the inventory at a correct level, so
> if you are available to help me on this testing task it would be great :)
>
> Nicolas
>
> On 08/07/2022 13:05, Giulio Speri - MpStyle Srl wrote:
> > Hello devs,
> >
> > I hope you're doing good!
> > I write because I think I found a possible issue in minilang service
> > *reassignInventoryReservation*.
> >
> > This service is called as a SECA on createPhysicalInventoryAndVariance
> > service and at the end it deletes inventory reservation for an order
> items
> > that has quantityNotReserved .gt. 0 and then re-reserve the inventory
> > calling the service *reserveProductInventoryByFacility, *implemented by
> the
> > method *reserveProductInventory*
> >
> (applications/product/minilang/product/inventory/InventoryReserveServices.xml).
> >
> > The *reserveProductInventoryByFacility has some parameters passed in and
> > among them there is requireInventory parameter, that is hardcoded to N,
> to
> > allow back-orders (negative ATP).*
> >
> > In our ecommerce context this is not recommendable and the productStores
> > are all configured to requireInventory=Y, because we do not want
> > back-orders, but the hard-coded requireInventory "N", overrides the store
> > setting, making the order "available" even if stock is not present for an
> > order item.
> >
> > I think that it is better to check the productStore setting of the
> > requireInventory parameter, and pass that value to the
> > *reserveProductInventoryByFacility,* instead of a hard-coded "N".
> >
> > What do you think about it?
> > If you agree I could take care of it in a Jira Task and provide a patch.
> >
> > Thanks in advance,
> > Giulio
> >
>
>

-- 
Giulio Speri


*Mp Styl**e Srl*
via Antonio Meucci, 37
41019 Limidi di Soliera (MO)
T 059/684916
M 347/0965506

www.mpstyle.it

Re: Possible issue in balanceInventoryItems/reassignInventoryReservation service

[Giulio Speri - MpStyle Srl]

Hi Scott,

I'll explain a little in depth the context: the e-commerce sites in OFBiz
use an ERP as the main source of data, both for products and their
inventory.
The ERP has different facilities and every night a scheduled procedure sync
Inventory quantities between the ERP and the e-commerce.
One of the ERP facilities, let's say facility A, is used not only for the
e-commerce availabilities but also for wholesale order, retail orders,
internal orders of the Company, so there could be more than one "party"
that could use the same inventory on the facility A: here the rule is: the
first order that comes in is served.

The logistic service that ships the orders is the same for both ERP and
ecommerce orders, but the e-commerce orders are not "real-time" synced with
the ERP system (they are synced once in the evening), and the
logistic service is notified only once a day (in the morning) for the
e-commerce orders they have to prepare for shipping.

This could lead to a scenario where an ecommerce order for a Product X
comes in on OFBiz, and an "ERP" order comes in before the notification for
the e-commerce order could arrive: since the logistic service is unaware of
e-commerce orders until the email notification,  happen that they ship the
ERP order, sending the availability for Product X to 0; during the night
ERP sync its inventory with OFBiz and at this point we have the problem I
described.
The ATP of the inventory item related to the orderItem reservation is no
longer sufficient to fulfill that order row and the system creates a new
reservation for quantityNotReserved quantity in a new InventoryItem: the
problem is that, that item can not and will not be shipped because
physically the logistic has no stock for the product.

For this reason I suggested checking the store configuration, to have the
same behaviour in case of an "out-of-stock" order.

I got your point and it makes sense: there is a reservation for an order
and after an inventory update that reservation disappears in silence.
Could we think about a SECA notification (like the ones for the order
status changes) for items that could not be re-reserved ?

I know that inventory reservation is always a critical point and an
"Out-of-stock" could always happen in some way, so this will not be an
ultimate solution to this, but we could make the e-commerce
managers/operators more aware of what is going on.

What do you think about it?

Thanks in advance,
Giulio


Il giorno ven 8 lug 2022 alle ore 17:34 Scott Gray <
scott.g...@hotwaxsystems.com> ha scritto:

> Hi Giulio,
>
> I think the hardcoded "N" is used there because a reservation is being
> deleted and then recreated.  The assumption there is that if a reservation
> existed before the process, then it should also exist after the process and
> should not simply disappear because a physical inventory was recorded.  In
> your situation (if I understand correctly), you require inventory for an
> order to be created but if you then reduce inventory to the point there is
> no longer enough to cover all orders then you want the reservations to
> disappear?  What happens to the order?
>
> Regards
> Scott
>
> On Fri, 8 Jul 2022 at 12:05, Giulio Speri - MpStyle Srl <
> giulio.sp...@mpstyle.it> wrote:
>
> > Hello devs,
> >
> > I hope you're doing good!
> > I write because I think I found a possible issue in minilang service
> > *reassignInventoryReservation*.
> >
> > This service is called as a SECA on createPhysicalInventoryAndVariance
> > service and at the end it deletes inventory reservation for an order
> items
> > that has quantityNotReserved .gt. 0 and then re-reserve the inventory
> > calling the service *reserveProductInventoryByFacility, *implemented by
> the
> > method *reserveProductInventory*
> >
> >
> (applications/product/minilang/product/inventory/InventoryReserveServices.xml).
> >
> > The *reserveProductInventoryByFacility has some parameters passed in and
> > among them there is requireInventory parameter, that is hardcoded to N,
> to
> > allow back-orders (negative ATP).*
> >
> > In our ecommerce context this is not recommendable and the productStores
> > are all configured to requireInventory=Y, because we do not want
> > back-orders, but the hard-coded requireInventory "N", overrides the store
> > setting, making the order "available" even if stock is not present for an
> > order item.
> >
> > I think that it is better to check the productStore setting of the
> > requireInventory parameter, and pass that value to the
> > *reserveProductInventoryByFacility,* instead of a hard-coded "N".
> >
> > What do you think about it?
> > If you agree I could

Possible issue in balanceInventoryItems/reassignInventoryReservation service

[Giulio Speri - MpStyle Srl]

Hello devs,

I hope you're doing good!
I write because I think I found a possible issue in minilang service
*reassignInventoryReservation*.

This service is called as a SECA on createPhysicalInventoryAndVariance
service and at the end it deletes inventory reservation for an order items
that has quantityNotReserved .gt. 0 and then re-reserve the inventory
calling the service *reserveProductInventoryByFacility, *implemented by the
method *reserveProductInventory*
 (applications/product/minilang/product/inventory/InventoryReserveServices.xml).

The *reserveProductInventoryByFacility has some parameters passed in and
among them there is requireInventory parameter, that is hardcoded to N, to
allow back-orders (negative ATP).*

In our ecommerce context this is not recommendable and the productStores
are all configured to requireInventory=Y, because we do not want
back-orders, but the hard-coded requireInventory "N", overrides the store
setting, making the order "available" even if stock is not present for an
order item.

I think that it is better to check the productStore setting of the
requireInventory parameter, and pass that value to the
*reserveProductInventoryByFacility,* instead of a hard-coded "N".

What do you think about it?
If you agree I could take care of it in a Jira Task and provide a patch.

Thanks in advance,
Giulio

-- 
Giulio Speri


*Mp Styl**e Srl*
via Antonio Meucci, 37
41019 Limidi di Soliera (MO)
T 059/684916
M 347/0965506

www.mpstyle.it

Re: "New commiter first steps" wiki page proposal

[Giulio Speri - MpStyle Srl]

Hello Devs,

I hope you are all doing well!
I finally had some time to write a little guide regarding the steps to
perform as a new committer in order to start working with online OFBiz
repositories.
I published the page in the section Community ->  Apache OFBiz Contribution
and Development : OFBiz New Committer's first steps
<https://cwiki.apache.org/confluence/x/nBihD>

All the feedbacks and suggestions about it are happily appreciated. :)

Thanks in advance and have a great WE ahead,
Giulio

Il giorno sab 2 apr 2022 alle ore 15:03 Jacques Le Roux <
jacques.le.r...@les7arts.com> ha scritto:

> That's indeed a good idea.
>
> There is already
> https://infra.apache.org/new-committers-guide.html#set-up-subversion-or-git-access
> ,
> but I guess something simplified and focused for OFBiz new committers in
> wiki may be useful indeed.
>
> Giulio, this morning you also asked about
>
> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Committers+Roles+and+Responsibilities#OFBizCommittersRolesandResponsibilities-Howshouldcommittershandlebackporting?
>
>
>
> It would need some update there, feel free to do so. Else I'll certainly
> do it... one day... or... another...
>
> TIA
>
> Le 02/04/2022 à 14:19, Taher Alkhateeb a écrit :
> > Hello Guilio,
> >
> > I think that's a good idea. It would be helpful to complement whatever
> ASF steps are needed to complete the on-boarding process.
> >
> > On 4/2/22 15:07, Giulio Speri - MpStyle Srl wrote:
> >> Hello devs,
> >>
> >> I hope you're all doing well.
> >>
> >> Few days ago me and Nicola became committers of this project and we are
> >> really happy to be part of it.
> >>
> >> We read the wiki pages related to committers Roles And Responsibilities
> and
> >> we started to set up all things to be ready to work with GitHub repos:
> in
> >> this process we struggled for couple of days before everything was
> >> correctly set up and gain the rights to push into the repos, because the
> >> various steps wasn't so clear, at least for us (create a github account,
> >> then go back to your apache account and put in it the GitHub username to
> >> link both together to correctly use GitBox,...).
> >>
> >> We noted down the various actions taken to be fully ready to work with
> >> online repository and we thought that, writing a specific wiki page that
> >> describes the very first steps to perform after a contributor becomes a
> new
> >> committer, could be helpful to future new committers to get easily
> involved
> >> in the project.
> >>
> >> We could take this task and write it.
> >>
> >> What do you think about this?
> >>
> >> Thank you in advance for your feedback and suggestions,
> >>
> >> Giulio
> >>
> >>
> >>
>


-- 
Giulio Speri


*Mp Styl**e Srl*
via Antonio Meucci, 37
41019 Limidi di Soliera (MO)
T 059/684916
M 347/0965506

www.mpstyle.it

"New commiter first steps" wiki page proposal

[Giulio Speri - MpStyle Srl]

Hello devs,

I hope you're all doing well.

Few days ago me and Nicola became committers of this project and we are
really happy to be part of it.

We read the wiki pages related to committers Roles And Responsibilities and
we started to set up all things to be ready to work with GitHub repos: in
this process we struggled for couple of days before everything was
correctly set up and gain the rights to push into the repos, because the
various steps wasn't so clear, at least for us (create a github account,
then go back to your apache account and put in it the GitHub username to
link both together to correctly use GitBox,...).

We noted down the various actions taken to be fully ready to work with
online repository and we thought that, writing a specific wiki page that
describes the very first steps to perform after a contributor becomes a new
committer, could be helpful to future new committers to get easily involved
in the project.

We could take this task and write it.

What do you think about this?

Thank you in advance for your feedback and suggestions,

Giulio



-- 
Giulio Speri


*Mp Styl**e Srl*
via Antonio Meucci, 37
41019 Limidi di Soliera (MO)
T 059/684916
M 347/0965506

www.mpstyle.it

Re: Welcome to Nicola Mazzoni and Giulio Speri as new committers

[Giulio Speri - MpStyle Srl]

Thank you all! Can't wait to work together with the community and
contribute to the OFBiz project!

Have a nice day,
Giulio



Il giorno mer 23 mar 2022 alle ore 09:50 Nicola Mazzoni <
nicola.mazz...@mpstyle.it> ha scritto:

> Thank you! I hope that I (and my team) can make a contribution to OFBiz,
> working together with the community!
>
> On 22/03/22 18:09, Priya Sharma wrote:
> > Congratulations Nicola and Giulio !!
> >
> > On Tue, 22 Mar 2022 at 18:02, Swapnil Shah<
> swapnil.s...@hotwaxsystems.com>
> > wrote:
> >
> >> Welcome aboard Nicola & Giulio !!
> >>
> >> Regards,
> >> Swapnil
> >>
> >> -Original Message-
> >> From: Jacopo Cappellato
> >> Sent: 22 March 2022 01:56 AM
> >> To: Dev list
> >> Subject: Welcome to Nicola Mazzoni and Giulio Speri as new committers
> >>
> >> The OFBiz PMC has invited Nicola Mazzoni and Giulio Speri as new
> committers
> >> and we are glad to announce that they have accepted the nomination.
> >>
> >> On behalf of the OFBiz PMC, welcome on board!
> >>
> >
> --
>
> *Nicola Mazzoni* | /CEO/CTO/
>
> Mobile: +39 347 990 5529
>
> *Mp Style srl*
>
> Via Meucci, 37 | 41019 Limidi di Soliera (MO)
>
> p.i / c.f IT03679300362
>


-- 
Giulio Speri


*Mp Styl**e Srl*
via Antonio Meucci, 37
41019 Limidi di Soliera (MO)
T 059/684916
M 347/0965506

www.mpstyle.it

Re: JobPoller strange behavior with multiple ofbiz instances in Docker Containers

[Giulio Speri - MpStyle Srl]

Hello Devs,

I'll reach you with an update on this.
Me and my colleagues (@Nicola Mazzoni is in this ML) have found the issue
and a possible solution that we applied almost a week ago in our production
environment.
We found no issue or bug in OFBiz JobPoller and JobManager code, but it was
more a "timing" problem.

I explain: each container started an instance of OFbiz, each instance also
started its JobPoller thread with all the JobManagers associated with a
specific tenant.
All the instances had the poll-enable parameter set to true and all run
services from the pool "pool", and since all has access to the same MySQL
database, what happened was that the "first" (in terms of time) thread
between all the containers that polled the JobSandbox entity (of that
tenant), run the service.
This explains why we saw jobs always executed by different *ofbiz_instanceIds,
*and why output files were written in a container different from the one we
would expect.

We've been able to prove this behaviour, proceeding step-by-step:
1 - at first we disabled (poll-enabled=false) all the JobPoller thread in
all the containers, except one; this was the simple case and JobPoller
behaves as expected: service and output file were executed and written to
the correct container.
2 - put some debug prints into the JobManager poll() method outputting
instanceId - service name and timing of execution;
3 - rebuilt container images and enabled a second JobPoller thread in
another instance;
4 - scheduled the same service in the tenants related to each
container/ofbiz instance, repeated for 5/10 times every 3 minutes (just to
be sure to catch something);
5 - observed the live tail output of the ofbiz log files on both container
consoles;
6 - visually check and confirm that the thread which woke up earlier (but
after job schedule time) did execute the job, and that happened regardless
of the container we scheduled the job from;
7 - repeated this test re-enabling all the JobPollers one after another,
with the same result as step 6.

In short:
Container A - tenant A - ofbiz_instanceId = 1 - JobPoller-A - pool="pool"
Container B - tenant B - ofbiz_instanceId = 2 - JobPoller-B - pool="pool"

Service "MY_SERVICE" scheduled in container/tenant A at time X.
Service "MY_SERVICE" scheduled in container/tenant B at time Y.

JobPoller-A, that has all the tenant managers registered, polls after
schedule time Y of MY_SERVICE for tenant B, but before JobPoller-B: then
MY_SERVICE of tenant B is executed by ofbiz_instanceId = 1.

Once we were sure about this behavior we could think of a solution and we
came up with two possibilities.

*[1]* Start a new ofbiz container with the JobPoller enabled and in the
meanwhile disable all the other JobPoller threads, so that only one poller
thread between all containers would be active.

*[2]* JobManager search/schedule/queue/run jobs looking also at the
thread-pool of execution: giving each container a different
.. configuration for parameters *send-to-pool*
and *run-from-pool* (ie for Container A: send-to-pool="poolA" and
run-from-pool name="poolA", and so on for Container B,C,D,...), will cause
each JobPoller run services only of its specific pool name, so that if I
schedule a service in the Container A, only the JobPoller in that container
will run the job, since the JobPoller in the container B, will search in
tenants for jobs with pool="poolB".

We decided to proceed with the solution [2], because we think that it's
correct in this scenario to have each container run its own (per tenant)
jobs, in order to keep each container/customer logically separated from the
others.
The last point done to complete this configuration was to update JobSandbox
entities and assign to already scheduled services the proper and specific
thread execution pool.

The checks we've done throughout the week had successful results, but we
will keep monitoring the situation still for some days.

I don't know if other devs/contributors/users are using ofbiz in docker
containers in the same way as we do, but this problem gave us more than a
headache for a lot of time, so I hope that our experience could be helpful
in saving some precious time to anyone will face this kind of situation.

Have a great weekend ahead.
Kind Regards,
Giulio









Il giorno gio 20 gen 2022 alle ore 20:27 Giulio Speri - MpStyle Srl <
giulio.sp...@mpstyle.it> ha scritto:

> Hello everyone,
>
> I hope you are all well and healthy.
> I am writing because we are facing a weird behavior of the JobPoller in a
> Docker environment.
> I list here env execution data:
> - ofbiz version is 13.07.03
> - Ubuntu 18 server
> - Docker container server
> - Multiple docker containers running: 1 container -> 1 customer -> 1 full
> ofbiz instance
> - Multi-tenant enabled : 1 container -> 1 tenant
> - 1 container running MySQL Se

JobPoller strange behavior with multiple ofbiz instances in Docker Containers

[Giulio Speri - MpStyle Srl]

Hello everyone,

I hope you are all well and healthy.
I am writing because we are facing a weird behavior of the JobPoller in a
Docker environment.
I list here env execution data:
- ofbiz version is 13.07.03
- Ubuntu 18 server
- Docker container server
- Multiple docker containers running: 1 container -> 1 customer -> 1 full
ofbiz instance
- Multi-tenant enabled : 1 container -> 1 tenant
- 1 container running MySQL Server (shared by all the ofbiz containers)
- 1 container with Apache Web Server, acting as a proxy
- each container has its own volumes to persist data and one of the files
is *general.properties*
- each ofbiz-container is set up with its own and specific unique.instanceId

*Problem context*
Each ofbiz instance has some scheduled services that run at some time
mostly for external integration with ERP systems.
We have in particular one job that reads shipped sales order data and
creates a csv file in a position inside the ofbiz-home directory: this
location is kept as a volume to let an external program, to come and read
the generated file from the "physical" server.
The problem is that often, we can see that the service runs with no
problems, order header processed records are marked/flagged as processed,
but the file is not generated inside the container I expect to see it, but
in another container.
This leads to a customer that has registered on his ERP systems, orders
data of another customer; no good.

I know that when there are multiple ofbiz instances running, the unique id
is crucial to keep the things going so I double-checked them and I can
confirm that each instance has its unique id.

What I did, then is to give a look at the JOB_SANDBOX entity of each tenant
and here I noticed that services, when executed from the JobPoller, have an
instance id, different from the one of "its container", and that means that
the job is executed by the "wrong" container.
I also add that the JobPoller does not always pick up the same "wrong"
uniqueId, but it often differs from job execution to job execution.

This happens only when the service is run by the JobManager; if I execute
the same service by hand on the proper container all is good.

To summarize, it seems that when the JobManager reads the instanceId by the
general.properties file, it picks the id belonging to another (random)
container: if we are lucky it picks up its own unique id making the service
run correctly.

Does anyone have ever experienced this or a similar issue?

Thank you very much in advance,

Giulio

-- 
Giulio Speri


*Mp Styl**e Srl*
via Antonio Meucci, 37
41019 Limidi di Soliera (MO)
T 059/684916
M 347/0965506

www.mpstyle.it

Re: [VOTE] [RELEASE] Apache OFBiz 18.12.04

[Giulio Speri - MpStyle Srl]

+1

$ /bin/bash ../OFBIZ_TOOLS_REPO/ofbiz-tools/verify-ofbiz-release.sh -a
apache-ofbiz-18.12.04 2>&1 | tee verify_181204.log

sha check of file: apache-ofbiz-18.12.04.zip
Using sha file: apache-ofbiz-18.12.04.zip.sha512
apache-ofbiz-18.12.04.zip: 7485AC40 D643CC4E C1A98F68 73383C69 206C6B0D
C7CAB713 8594D53F FAE0457E 9774CF50 781C9C7D 54C031E8 DED27B8F CB5BD9D5
65136F7E E0743030 9E55B9D6
apache-ofbiz-18.12.04.zip: 7485AC40 D643CC4E C1A98F68 73383C69 206C6B0D
C7CAB713 8594D53F FAE0457E 9774CF50 781C9C7D 54C031E8 DED27B8F CB5BD9D5
65136F7E E0743030 9E55B9D6
sha checksum OK

GPG verification output
../OFBIZ_TOOLS_REPO/ofbiz-tools/verify-ofbiz-release.sh: line 128: warning:
setlocale: LC_MESSAGES: cannot change locale (en_EN.UTF-8): No such file or
directory
gpg: Signature made Fri Dec 17 10:08:50 2021 CET
gpg:using RSA key 7A580908847AF9E0
gpg: Good signature from "Jacopo Cappellato (CODE SIGNING KEY) <
jaco...@apache.org>" [unknown]

...
BUILD SUCCESSFUL in 7m 17s
27 actionable tasks: 22 executed, 5 up-to-date
Done processing files for release apache-ofbiz-18.12.04

Thanks,
Giulio



Il giorno ven 17 dic 2021 alle ore 18:14 Jacques Le Roux <
jacques.le.r...@les7arts.com> ha scritto:

> +1
>
> $ ./verify-ofbiz-release.sh apache-ofbiz-18.12.04.zip
> sha check of file: apache-ofbiz-18.12.04.zip
> Using sha file: apache-ofbiz-18.12.04.zip.sha512
> apache-ofbiz-18.12.04.zip: 7485AC40 D643CC4E C1A98F68 73383C69 206C6B0D
> C7CAB713 8594D53F FAE0457E 9774CF50 781C9C7D 54C031E8 DED27B8F CB5BD9D5
> 65136F7E E0743030 9E55B9D6
> apache-ofbiz-18.12.04.zip: 7485AC40 D643CC4E C1A98F68 73383C69 206C6B0D
> C7CAB713 8594D53F FAE0457E 9774CF50 781C9C7D 54C031E8 DED27B8F CB5BD9D5
> 65136F7E E0743030 9E55B9D6
> sha checksum OK
>
> GPG verification output
> gpg: Signature made Fri Dec 17 10:08:50 2021
> gpg:using RSA key 7A580908847AF9E0
> gpg: Good signature from "Jacopo Cappellato (CODE SIGNING KEY) <
> jaco...@apache.org>"
>
> Tests and UIs OK
>
> Jacques
>
> Le 17/12/2021 à 10:32, Jacopo Cappellato a écrit :
> > This is the vote thread to release a new bug fix release for the
> > release18.12 branch. This new release, "Apache OFBiz 18.12.04" will
> > supersede all the previous releases from the same branch.
> >
> > The release files can be downloaded from here:
> >
> > https://dist.apache.org/repos/dist/dev/ofbiz/
> >
> > and are:
> > * apache-ofbiz-18.12.04.zip
> > * KEYS: text file with keys
> > * apache-ofbiz-18.12.04.zip.asc: the detached signature file
> > * apache-ofbiz-18.12.04.zip.sha512: checksum file
> >
> > Please download and test the zip file and its signatures (for
> > instructions on testing the signatures see [*]).
> >
> > Vote:
> >
> > [ +1] release as Apache OFBiz 18.12.04
> > [ -1] do not release
> >
> > For more details about this process please read [**].
> > [*]
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz#ReleaseManagementGuideforOFBiz-Votingonarelease
> > [**] http://www.apache.org/foundation/voting.html
>
>

-- 
Giulio Speri


*Mp Styl**e Srl*
via Antonio Meucci, 37
41019 Limidi di Soliera (MO)
T 059/684916
M 347/0965506

www.mpstyle.it

Re: [ANNOUNCE] Apache OFBiz 18.12.02 released

[Giulio Speri - MpStyle Srl]

Great, thank you Jacopo!

Giulio


On Wed, Nov 24, 2021, 11:50 Jacopo Cappellato  wrote:

> The Apache OFBiz community is pleased to announce the new release "Apache
> OFBiz 18.12.02".
>
> Apache OFBiz® is an open source product for the automation of enterprise
> processes that includes framework components and business applications.
>
> http://ofbiz.apache.org/
>
> "Apache OFBiz 18.12.02" is the second release of the 18.12 series.
>
> For more details of the changes introduced with this new version
> please refer to http://ofbiz.apache.org/release-notes-18.12.02.html
>
> The release file can be downloaded following the instructions in the OFBiz
> download page:
>
> http://ofbiz.apache.org/download.html
>

Re: [VOTE] Apache OFBiz 18.12.02 (second attempt)

[Giulio Speri - MpStyle Srl]

+1

/bin/bash ../OFBIZ_TOOLS_REPO/ofbiz-tools/verify-ofbiz-release.sh -a
apache-ofbiz-18.12.02
Processing files for release: apache-ofbiz-18.12.02...
Downloading files for apache-ofbiz-18.12.02.zip...
--2021-11-17 13:35:12--  https://dist.apache.org/repos/dist/dev/ofbiz/KEYS
...
2021-11-17 13:35:12 (200 KB/s) - 'KEYS' saved [21796/21796]
..
--2021-11-17 13:35:18--
https://dist.apache.org/repos/dist/dev/ofbiz/apache-ofbiz-18.12.02.zip.asc
...
2021-11-17 13:35:18 (283 MB/s) - 'apache-ofbiz-18.12.02.zip.asc' saved
[841/841]
...
--2021-11-17 13:35:18--
https://dist.apache.org/repos/dist/dev/ofbiz/apache-ofbiz-18.12.02.zip.sha512
...
2021-11-17 13:35:19 (31.4 MB/s) - 'apache-ofbiz-18.12.02.zip.sha512' saved
[225/225]

Done!

Verifying files...
sha check of file: apache-ofbiz-18.12.02.zip
Using sha file: apache-ofbiz-18.12.02.zip.sha512
apache-ofbiz-18.12.02.zip: BED7D644 ED80DDE3 C94FDD53 473E49DD 5A29CF84
0FFC53D5 2CDBA1F3 FFE5F8B8 48DF123E EB816159 708C01A8 31ECBF7F D7476CD3
59369170 F73EEB60 491768AC
apache-ofbiz-18.12.02.zip: BED7D644 ED80DDE3 C94FDD53 473E49DD 5A29CF84
0FFC53D5 2CDBA1F3 FFE5F8B8 48DF123E EB816159 708C01A8 31ECBF7F D7476CD3
59369170 F73EEB60 491768AC
sha checksum OK

GPG verification output
gpg: Signature made Tue Nov 16 17:00:38 2021 CET
gpg:using RSA key 7A580908847AF9E0
gpg: Good signature from "Jacopo Cappellato (CODE SIGNING KEY) <
jaco...@apache.org>" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg:  There is no indication that the signature belongs to the
owner.
 The checksum is ok, but I think I am out of the web of trust here.
*...*
Initializing Gradle wrapper...
...
gradlew: OK
Running tests...
...
BUILD SUCCESSFUL in 7m 3s
27 actionable tasks: 22 executed, 5 up-to-date
Done processing files for release apache-ofbiz-18.12.02

Thanks,

Giulio

Il giorno mer 17 nov 2021 alle ore 12:23 Michael Brohl <
michael.br...@ecomify.de> ha scritto:

> +1
>
> ~/Projects/apache-ofbiz/dist  ../ofbiz-tools/verify-ofbiz-release.sh -a
> apache-ofbiz-18.12.02
> Processing files for release: apache-ofbiz-18.12.02...
> Downloading files for apache-ofbiz-18.12.02.zip...
> ...
>
> Done!
>
> Verifying files...
> sha check of file: apache-ofbiz-18.12.02.zip
> Using sha file: apache-ofbiz-18.12.02.zip.sha512
> apache-ofbiz-18.12.02.zip: BED7D644 ED80DDE3 C94FDD53 473E49DD 5A29CF84
> 0FFC53D5 2CDBA1F3 FFE5F8B8 48DF123E EB816159 708C01A8 31ECBF7F D7476CD3
> 59369170 F73EEB60 491768AC
> apache-ofbiz-18.12.02.zip: BED7D644 ED80DDE3 C94FDD53 473E49DD 5A29CF84
> 0FFC53D5 2CDBA1F3 FFE5F8B8 48DF123E EB816159 708C01A8 31ECBF7F D7476CD3
> 59369170 F73EEB60 491768AC
> sha checksum OK
>
> GPG verification output
> gpg: Signature made Tue Nov 16 17:00:38 2021 CET
> gpg:using RSA key 7A580908847AF9E0
> gpg: Good signature from "Jacopo Cappellato (CODE SIGNING KEY)
> " [ultimate]
>
> ...
> Initializing Gradle wrapper...
> ...
> Running tests...
> ...
> BUILD SUCCESSFUL in 4m 40s
> 27 actionable tasks: 22 executed, 5 up-to-date
> Done processing files for release apache-ofbiz-18.12.02
>
>
> Thanks,
>
> Michael Brohl
>
> ecomify GmbH - www.ecomify.de
>
>
> Am 16.11.21 um 17:26 schrieb Jacopo Cappellato:
> > This is the second vote thread to publish "Apache OFBiz 18.12.02", the
> > second release from the release18.12 branch.
> >
> > The release files can be downloaded from here:
> > https://dist.apache.org/repos/dist/dev/ofbiz/
> > and are:
> > * apache-ofbiz-18.12.02.zip
> > * KEYS: text file with keys
> > * apache-ofbiz-18.12.02.zip.asc: the detached signature file
> > * apache-ofbiz-18.12.02.zip.sha512: checksum file
> >
> > Please download and test the zip file and its signatures (for
> instructions
> > on testing the signatures see
> http://www.apache.org/info/verification.html).
> >
> > Vote:
> > [ +1] release as Apache OFBiz 18.12.02
> > [ -1] do not release
> >
> > This vote will be open for 5 days.
> >
> > For more details about this process please refer to
> > http://www.apache.org/foundation/voting.html
> >
> > Best Regards,
> >
> > Jacopo
> >
>


-- 
Giulio Speri


*Mp Styl**e Srl*
via Antonio Meucci, 37
41019 Limidi di Soliera (MO)
T 059/684916
M 347/0965506

www.mpstyle.it

Re: Validating a release with verify-ofbiz-release.sh was: [VOTE] Apache OFBiz 18.12.02

[Giulio Speri - MpStyle Srl]

Hi Micheal,

I Will use it for sure next time.

Thanks You very much,
Giulio





On Wed, Nov 3, 2021, 15:18 Michael Brohl  wrote:

> Hi Giulio, all,
>
> for convenience, I've contributed a verification script for releases
> which will automatically download the release files, validates checksums
> and runs the tests in a single run or several steps.
>
> Please check out verify-ofbiz-release.sh in the ofbiz-tools repository [1]
>
> Best regards,
>
> Michael Brohl
>
> ecomify GmbH - www.ecomify.de
>
>
> [1] https://gitbox.apache.org/repos/asf/ofbiz-tools.git
>
> Am 03.11.21 um 15:03 schrieb Giulio Speri - MpStyle Srl:
> > Hi everyone,
> >
> > I have to revert my previous +1 (I just tested the checksums, not the
> build
> > and I apologize for that), since the build still fails with the same
> error
> > of 18.12.01.
> >
> > My official vote is now
> >
> > -1
> >
> > Giulio
> >
> > Il giorno mer 3 nov 2021 alle ore 14:21 Wiebke Pätzold <
> > wiebke.paetz...@ecomify.de> ha scritto:
> >
> >> -1 The reason for the new release is a fix for
> >> https://issues.apache.org/jira/browse/OFBIZ-12351, but as far as I can
> >> see the temporary fix is only applied to trunk. So the Release18.12.02
> >> has no changes to Release18.12.01 or am I something missing?
> >>
> >> I also provided a PR for the 18.12 branch with a better fix, since this
> >> one does not depend on jcenter.
> >>
> >> Am 02.11.21 um 08:37 schrieb Jacques Le Roux:
> >>> +1
> >>>
> >>> $ ./verify-ofbiz-release.sh apache-ofbiz-18.12.02.zip
> >>> sha check of file: apache-ofbiz-18.12.02.zip
> >>> Using sha file: apache-ofbiz-18.12.02.zip.sha512
> >>> apache-ofbiz-18.12.02.zip: D553F8DC C8360B4B 7B1A3181 463EB1C2
> >>> 3B0E8A89 1DEEB786 AF269072 1DE385CF 23BB1171 0EC9EDAE 6ECF598F
> >>> 2355019F 23E5A33C C968493E 54AF5848 91F406DD
> >>> apache-ofbiz-18.12.02.zip: D553F8DC C8360B4B 7B1A3181 463EB1C2
> >>> 3B0E8A89 1DEEB786 AF269072 1DE385CF 23BB1171 0EC9EDAE 6ECF598F
> >>> 2355019F 23E5A33C C968493E 54AF5848 91F406DD
> >>> sha checksum OK
> >>>
> >>> GPG verification output
> >>> gpg: Signature made Mon Nov  1 15:11:59 2021
> >>> gpg:using RSA key 7A580908847AF9E0
> >>> gpg: Good signature from "Jacopo Cappellato (CODE SIGNING KEY)
> >>> "
> >>>
> >>> Tests are OK but I had to change 38802 to 39676 in
> >>> checkstyle::maxErrors, not sure why. Seems like last time, checkstyle
> >>> disallow building. Seems more an issue on my side, not the same than
> >>> last time. I'll investigate
> >>>
> >>> Jacques
> >>>
> >>> Le 01/11/2021 à 15:34, Jacopo Cappellato a écrit :
> >>>> This is the vote thread to publish "Apache OFBiz 18.12.02", the second
> >>>> release from the release18.12 branch.
> >>>>
> >>>> The release files can be downloaded from here:
> >>>> https://dist.apache.org/repos/dist/dev/ofbiz/
> >>>> and are:
> >>>> * apache-ofbiz-18.12.02.zip
> >>>> * KEYS: text file with keys
> >>>> * apache-ofbiz-18.12.02.zip.asc: the detached signature file
> >>>> * apache-ofbiz-18.12.02.zip.sha512: checksum file
> >>>>
> >>>> Please download and test the zip file and its signatures (for
> >>>> instructions
> >>>> on testing the signatures see
> >>>> http://www.apache.org/info/verification.html).
> >>>>
> >>>> Vote:
> >>>> [ +1] release as Apache OFBiz 18.12.02
> >>>> [ -1] do not release
> >>>>
> >>>> This vote will be open for 5 days.
> >>>>
> >>>> For more details about this process please refer to
> >>>> http://www.apache.org/foundation/voting.html
> >>>>
> >>>> Best Regards,
> >>>>
> >>>> Jacopo
> >> --
> >> Wiebke Pätzold
> >> Developer und Consultant
> >>
> >> ecomify GmbH, Gustav-Winkler-Str. 22, 33699 Bielefeld
> >> Fon: +49 521 448157-90 | Fax: +49 521 448157-99 | www.ecomify.de
> >> Court Registration: Amtsgericht Bielefeld, HRB 41683 | CEO: Martin
> Becker,
> >> Michael Brohl
> >>
> >>
>

Re: [VOTE] Apache OFBiz 18.12.02

[Giulio Speri - MpStyle Srl]

Hi everyone,

I have to revert my previous +1 (I just tested the checksums, not the build
and I apologize for that), since the build still fails with the same error
of 18.12.01.

My official vote is now

-1

Giulio

Il giorno mer 3 nov 2021 alle ore 14:21 Wiebke Pätzold <
wiebke.paetz...@ecomify.de> ha scritto:

> -1 The reason for the new release is a fix for
> https://issues.apache.org/jira/browse/OFBIZ-12351, but as far as I can
> see the temporary fix is only applied to trunk. So the Release18.12.02
> has no changes to Release18.12.01 or am I something missing?
>
> I also provided a PR for the 18.12 branch with a better fix, since this
> one does not depend on jcenter.
>
> Am 02.11.21 um 08:37 schrieb Jacques Le Roux:
> > +1
> >
> > $ ./verify-ofbiz-release.sh apache-ofbiz-18.12.02.zip
> > sha check of file: apache-ofbiz-18.12.02.zip
> > Using sha file: apache-ofbiz-18.12.02.zip.sha512
> > apache-ofbiz-18.12.02.zip: D553F8DC C8360B4B 7B1A3181 463EB1C2
> > 3B0E8A89 1DEEB786 AF269072 1DE385CF 23BB1171 0EC9EDAE 6ECF598F
> > 2355019F 23E5A33C C968493E 54AF5848 91F406DD
> > apache-ofbiz-18.12.02.zip: D553F8DC C8360B4B 7B1A3181 463EB1C2
> > 3B0E8A89 1DEEB786 AF269072 1DE385CF 23BB1171 0EC9EDAE 6ECF598F
> > 2355019F 23E5A33C C968493E 54AF5848 91F406DD
> > sha checksum OK
> >
> > GPG verification output
> > gpg: Signature made Mon Nov  1 15:11:59 2021
> > gpg:using RSA key 7A580908847AF9E0
> > gpg: Good signature from "Jacopo Cappellato (CODE SIGNING KEY)
> > "
> >
> > Tests are OK but I had to change 38802 to 39676 in
> > checkstyle::maxErrors, not sure why. Seems like last time, checkstyle
> > disallow building. Seems more an issue on my side, not the same than
> > last time. I'll investigate
> >
> > Jacques
> >
> > Le 01/11/2021 à 15:34, Jacopo Cappellato a écrit :
> >> This is the vote thread to publish "Apache OFBiz 18.12.02", the second
> >> release from the release18.12 branch.
> >>
> >> The release files can be downloaded from here:
> >> https://dist.apache.org/repos/dist/dev/ofbiz/
> >> and are:
> >> * apache-ofbiz-18.12.02.zip
> >> * KEYS: text file with keys
> >> * apache-ofbiz-18.12.02.zip.asc: the detached signature file
> >> * apache-ofbiz-18.12.02.zip.sha512: checksum file
> >>
> >> Please download and test the zip file and its signatures (for
> >> instructions
> >> on testing the signatures see
> >> http://www.apache.org/info/verification.html).
> >>
> >> Vote:
> >> [ +1] release as Apache OFBiz 18.12.02
> >> [ -1] do not release
> >>
> >> This vote will be open for 5 days.
> >>
> >> For more details about this process please refer to
> >> http://www.apache.org/foundation/voting.html
> >>
> >> Best Regards,
> >>
> >> Jacopo
> >
> --
> Wiebke Pätzold
> Developer und Consultant
>
> ecomify GmbH, Gustav-Winkler-Str. 22, 33699 Bielefeld
> Fon: +49 521 448157-90 | Fax: +49 521 448157-99 | www.ecomify.de
> Court Registration: Amtsgericht Bielefeld, HRB 41683 | CEO: Martin Becker,
> Michael Brohl
>
>

-- 
Giulio Speri


*Mp Styl**e Srl*
via Antonio Meucci, 37
41019 Limidi di Soliera (MO)
T 059/684916
M 347/0965506

www.mpstyle.it

Re: [VOTE] Apache OFBiz 18.12.02

[Giulio Speri - MpStyle Srl]

+1

On Mon, Nov 1, 2021, 15:42 Jacopo Cappellato 
wrote:

> This is the vote thread to publish "Apache OFBiz 18.12.02", the second
> release from the release18.12 branch.
>
> The release files can be downloaded from here:
> https://dist.apache.org/repos/dist/dev/ofbiz/
> and are:
> * apache-ofbiz-18.12.02.zip
> * KEYS: text file with keys
> * apache-ofbiz-18.12.02.zip.asc: the detached signature file
> * apache-ofbiz-18.12.02.zip.sha512: checksum file
>
> Please download and test the zip file and its signatures (for instructions
> on testing the signatures see http://www.apache.org/info/verification.html
> ).
>
> Vote:
> [ +1] release as Apache OFBiz 18.12.02
> [ -1] do not release
>
> This vote will be open for 5 days.
>
> For more details about this process please refer to
> http://www.apache.org/foundation/voting.html
>
> Best Regards,
>
> Jacopo
>

ProductFacility on ecommerce listing product issue

[Giulio Speri - MpStyle Srl]

Hello everyone,

I hope you're doing well.

I write here because I think I faced an issue in the ecommerce listing of
products related to the ProductFacility entity and the filtering of out of
stock products.

Here's the context:
- an ecommerce site where products are configured as a virtual-variant
relationship.
- a virtual product (parent) has color and size features associated as
selectable, and its variants are all the combinations of colors and sizes.
- in such a configuration InventoryItem records are registered for variant
products (the actual sold products) and not for virtual products.
- the product store is configured to not show out of stock products.
- a record of ProductFacility is created for each product variant where its
lastInventoryCount is automatically updated as soon as availability are
imported/created (through PHYSICAL INVENTORY);
- virtual products are associated to some ProductCategories;

*Issue*:
Products are not shown in category listing also if they have stock
availability.

*Issue details:*
Listing of products is done through the screen "
*CatalogScreens.xml#categorydetail*" and the *CategoryDetail.groovy* script
is used to retrieve the list of products to show.

In the groovy script the service responsible to get the product category
members to show is *getProductCategoryAndLimitedMembers, *which checks and
filters out of stock products (if ProductStore is configured to do so).

Filtering out of stock products is done using
*ProductWorker.java#filterOutOfStockProducts
*method, that sums up all the lastInventoryCount (in all the facilities) of
each category member and if sum is GT 0 the (virtual) product is kept and
shown in listing.

The lastInventoryCount field in the table ProductFacility is updated
through the eeca service *setLastInventoryCount* on create/update on entity
InventoryItemDetail.
This service works only on the product on which a stock move is committed
(in my case a specific product variant): it's (virtual) parent is never
considered.

That behaviour, in addition to the fact that filterOutOfStock method works
on the category members that are the virtual parents, leads to products to
not be shown in listing also if they have stock availability.

*Possible solutions:*
>From my point of view there are two ways to fix this.

*1)* add the handling of lastInventoryCount on virtual parents to the
service setLastInventoryCount; the lastInventoryCount of the parent should
be the sum of all its variant in the same facility, and each time a variant
is modified, the related parent should be modified too.

*2)* add the handling of virtual products in the ProductWorker.java#
*filterOutOfStockProducts*: here when a virtual product category member is
processed, all its variants should be retrieved and their
lastInventoryCount added up through all facilities.
Only if the sum of all the variants in all the facilities is GT 0, then we
can keep and show the virtual product.

*Considerations:*
After a bit of research within the whole OFBiz project (R17.12.06) the
lastInventoryCount field has quite limited direct usage (basically only for
ecommerce scopes).
I think solution 2) is better, because I think that the ProductFacility
entity should not contain record for "virtual" products (products that
physically won't be sold, since you will sell a variant of it; for the same
reason virtual products should not have InventoryItem records associated).

I think that solution 1) instead is not so clean and forced to adopt
inventory item concepts also for virtual products, that in my opinion it
does not make too much sense.


Sorry for the long email, but I tried to retrieve as many details as
possible and I would be very happy to know your thoughts about it.

I opened an issue in Jira (OFBIZ-12359
) for this.

Thanks in advance for your attention and help.

Giulio

-- 
Giulio Speri


*Mp Styl**e Srl*
via Antonio Meucci, 37
41019 Limidi di Soliera (MO)
T 059/684916
M 347/0965506

www.mpstyle.it

Re: Release 18.12.02

[Giulio Speri - MpStyle Srl]

Hi everyone,

We adopted the temporary solution proposed by Mart in the issue
OFBIZ-12351 (alternative
implementation of the package) in our OFBiz R17, since it runs in a
production environment and we adopted it in our local dev envs too to be
able to carry on maintenance.

I agree with Jacques for the new release.

Thank You Jacopo,
Giulio

Il giorno lun 1 nov 2021 alle ore 12:54 Jacques Le Roux <
jacques.le.r...@les7arts.com> ha scritto:

> Hi Jacopo,
>
> Yes, I think so
>
> TIA
>
> Le 01/11/2021 à 11:24, Jacopo Cappellato a écrit :
> > Should I start the preparation of the release files today?
> >
> > Jacopo
> >
> > On Mon, Nov 1, 2021 at 9:16 AM Jacques Le Roux
> >  wrote:
> >> Hi,
> >>
> >> Because of OFBIZ-12351 "Builds fail due to unauthorized access to
> repo.spring.io/plugins-release" I think we should release 18.12.02.
> >>
> >> The reasons is, even if it's not our fault, not everybody like Mart
> Naum will report or ask for help, will simply think that OFBiz is BS and
> drop it
> >> forever.
> >>
> >> Opinions?
> >>
> >> Jacques
> >>
>


-- 
Giulio Speri


*Mp Styl**e Srl*
via Antonio Meucci, 37
41019 Limidi di Soliera (MO)
T 059/684916
M 347/0965506

www.mpstyle.it

Re: [VOTE] Apache OFBiz 18.12.01

[Giulio Speri - MpStyle Srl]

+1

Thanks,
Giulio

Il giorno mer 27 ott 2021 alle ore 11:05 Ashish Vijaywargiya <
ash...@apache.org> ha scritto:

> +1
>
> Thanks,
> Ashish Vijaywargiya
>
> On Sat, Oct 23, 2021 at 8:38 PM Jacopo Cappellato <
> jacopo.cappell...@gmail.com> wrote:
>
> > This is the vote thread to publish "Apache OFBiz 18.12.01", the first
> > release from the release17.12 branch.
> >
> > The release files can be downloaded from here:
> > https://dist.apache.org/repos/dist/dev/ofbiz/
> > and are:
> > * apache-ofbiz-18.12.01.zip
> > * KEYS: text file with keys
> > * apache-ofbiz-18.12.01.zip.asc: the detached signature file
> > * apache-ofbiz-18.12.01.zip.sha512: checksum file
> >
> > Please download and test the zip file and its signatures (for
> instructions
> > on testing the signatures see
> http://www.apache.org/info/verification.html
> > ).
> >
> > Vote:
> > [ +1] release as Apache OFBiz 18.12.01
> > [ -1] do not release
> >
> > This vote will be open for 5 days.
> >
> > For more details about this process please refer to
> > http://www.apache.org/foundation/voting.html
> >
> > Best Regards,
> >
> > Jacopo
> >
>


-- 
Giulio Speri


*Mp Styl**e Srl*
via Antonio Meucci, 37
41019 Limidi di Soliera (MO)
T 059/684916
M 347/0965506

www.mpstyle.it

Re: Possible issue in reserveStoreInventory service

[Giulio Speri - MpStyle Srl]

Hi Suraj,

I attached a patch for the service to the ticket.
I also did some considerations in the comment section and I would
appreciate it if you could share your thoughts on it.

Thank you in advance,
Giulio

Il giorno mer 23 giu 2021 alle ore 20:21 Giulio Speri - MpStyle Srl <
giulio.sp...@mpstyle.it> ha scritto:

> Hi Suraj,
>
> ticket created: OFBIZ-12264.
> I'll soon start working on a patch.
>
> Regards,
> Giulio
>
> Il giorno mer 23 giu 2021 alle ore 09:20 Giulio Speri - MpStyle Srl <
> giulio.sp...@mpstyle.it> ha scritto:
>
>> HI Suraj,
>>
>> thanks. I will proceed with the Jira ticket.
>>
>> Giulio
>>
>> Il giorno mer 23 giu 2021 alle ore 06:24 Suraj Khurana <
>> suraj.khur...@hotwax.co> ha scritto:
>>
>>> Hello Giulio,
>>>
>>> Thanks for pointing that out. A Jira perfectly fits here.
>>>
>>> --
>>> Best Regards,
>>> Suraj Khurana
>>> Senior Technical Consultant
>>>
>>>
>>> On Wed, Jun 23, 2021 at 5:32 AM Giulio Speri - MpStyle Srl <
>>> giulio.sp...@mpstyle.it> wrote:
>>>
>>> > Hello everyone,
>>> >
>>> > I hope you are all doing well.
>>> > I write because today I faced an unexpected behaviour in one of our
>>> > ecommerce applications, during creation of an order and related
>>> inventory
>>> > reservation.
>>> >
>>> > The ProductStore is set up to reserve inventory from more than one
>>> > facility, so the flag oneInventoryFacility is set to N.
>>> > The we have 8 different facilities configured (each with a specific
>>> > sequence num from 1 to 8) in the entity ProductStoreFacility.
>>> >
>>> > Due to customer requests I had to disable 6 out of 8 facilities
>>> associated
>>> > with the store, so basically only facilities with (sequence) numbers 1
>>> and
>>> > 2 are left. To achieve this I set the thruDate on the other six
>>> records.
>>> >
>>> > After that, an order came in with a variant product that had only 1
>>> > quantity left available in one of the disabled facilities and 0 in
>>> both the
>>> > two facilities left enabled, but despite this the system reserved
>>> inventory
>>> > from the disabled facility: I wouldn't expect that.
>>> >
>>> > The service responsible for the reservation is *reserveStoreInventory
>>> *that
>>> > in our ofbiz version (13.07.03) is minilang and is implemented in
>>> > ProductStoreServices.xml: I checked that service and I noticed that
>>> when
>>> > the ProductStore is set to multi facility (oneInventoryFacility to N)
>>> and
>>> > the list of productStoreFacility records are retrieved, they are not
>>> > filtered by date, and this lead to a "bad" reservation.
>>> > I took a look also at the current revision of ofbiz and the code
>>> (groovy
>>> > script) is basically the same, so the issue is present there also.
>>> >
>>> > Is this a real issue/bug or this behaviour was intended to act this
>>> way?
>>> >
>>> > If this is an issue I can open a Jira Ticket, add more details and
>>> start
>>> > working on a patch for both versions.
>>> >
>>> > What do you think about it?
>>> >
>>> > Thank you in advance for your attention.
>>> >
>>> > Best regards,
>>> > Giulio
>>> >
>>> >
>>> >
>>> >
>>> > --
>>> > Giulio Speri
>>> >
>>> >
>>> > *Mp Styl**e Srl*
>>> > via Antonio Meucci, 37
>>> > 41019 Limidi di Soliera (MO)
>>> > T 059/684916
>>> > M 334/3779851
>>> >
>>> > www.mpstyle.it
>>> >
>>>
>>
>>
>> --
>> Giulio Speri
>>
>>
>> *Mp Styl**e Srl*
>> via Antonio Meucci, 37
>> 41019 Limidi di Soliera (MO)
>> T 059/684916
>> M 334/3779851
>>
>> www.mpstyle.it
>>
>>
>>
>
> --
> Giulio Speri
>
>
> *Mp Styl**e Srl*
> via Antonio Meucci, 37
> 41019 Limidi di Soliera (MO)
> T 059/684916
> M 334/3779851
>
> www.mpstyle.it
>
>
>

-- 
Giulio Speri


*Mp Styl**e Srl*
via Antonio Meucci, 37
41019 Limidi di Soliera (MO)
T 059/684916
M 334/3779851

www.mpstyle.it

Re: Possible issue in reserveStoreInventory service

[Giulio Speri - MpStyle Srl]

Hi Suraj,

ticket created: OFBIZ-12264.
I'll soon start working on a patch.

Regards,
Giulio

Il giorno mer 23 giu 2021 alle ore 09:20 Giulio Speri - MpStyle Srl <
giulio.sp...@mpstyle.it> ha scritto:

> HI Suraj,
>
> thanks. I will proceed with the Jira ticket.
>
> Giulio
>
> Il giorno mer 23 giu 2021 alle ore 06:24 Suraj Khurana <
> suraj.khur...@hotwax.co> ha scritto:
>
>> Hello Giulio,
>>
>> Thanks for pointing that out. A Jira perfectly fits here.
>>
>> --
>> Best Regards,
>> Suraj Khurana
>> Senior Technical Consultant
>>
>>
>> On Wed, Jun 23, 2021 at 5:32 AM Giulio Speri - MpStyle Srl <
>> giulio.sp...@mpstyle.it> wrote:
>>
>> > Hello everyone,
>> >
>> > I hope you are all doing well.
>> > I write because today I faced an unexpected behaviour in one of our
>> > ecommerce applications, during creation of an order and related
>> inventory
>> > reservation.
>> >
>> > The ProductStore is set up to reserve inventory from more than one
>> > facility, so the flag oneInventoryFacility is set to N.
>> > The we have 8 different facilities configured (each with a specific
>> > sequence num from 1 to 8) in the entity ProductStoreFacility.
>> >
>> > Due to customer requests I had to disable 6 out of 8 facilities
>> associated
>> > with the store, so basically only facilities with (sequence) numbers 1
>> and
>> > 2 are left. To achieve this I set the thruDate on the other six records.
>> >
>> > After that, an order came in with a variant product that had only 1
>> > quantity left available in one of the disabled facilities and 0 in both
>> the
>> > two facilities left enabled, but despite this the system reserved
>> inventory
>> > from the disabled facility: I wouldn't expect that.
>> >
>> > The service responsible for the reservation is *reserveStoreInventory
>> *that
>> > in our ofbiz version (13.07.03) is minilang and is implemented in
>> > ProductStoreServices.xml: I checked that service and I noticed that when
>> > the ProductStore is set to multi facility (oneInventoryFacility to N)
>> and
>> > the list of productStoreFacility records are retrieved, they are not
>> > filtered by date, and this lead to a "bad" reservation.
>> > I took a look also at the current revision of ofbiz and the code (groovy
>> > script) is basically the same, so the issue is present there also.
>> >
>> > Is this a real issue/bug or this behaviour was intended to act this way?
>> >
>> > If this is an issue I can open a Jira Ticket, add more details and start
>> > working on a patch for both versions.
>> >
>> > What do you think about it?
>> >
>> > Thank you in advance for your attention.
>> >
>> > Best regards,
>> > Giulio
>> >
>> >
>> >
>> >
>> > --
>> > Giulio Speri
>> >
>> >
>> > *Mp Styl**e Srl*
>> > via Antonio Meucci, 37
>> > 41019 Limidi di Soliera (MO)
>> > T 059/684916
>> > M 334/3779851
>> >
>> > www.mpstyle.it
>> >
>>
>
>
> --
> Giulio Speri
>
>
> *Mp Styl**e Srl*
> via Antonio Meucci, 37
> 41019 Limidi di Soliera (MO)
> T 059/684916
> M 334/3779851
>
> www.mpstyle.it
>
>
>

-- 
Giulio Speri


*Mp Styl**e Srl*
via Antonio Meucci, 37
41019 Limidi di Soliera (MO)
T 059/684916
M 334/3779851

www.mpstyle.it

Re: Possible issue in reserveStoreInventory service

[Giulio Speri - MpStyle Srl]

HI Suraj,

thanks. I will proceed with the Jira ticket.

Giulio

Il giorno mer 23 giu 2021 alle ore 06:24 Suraj Khurana <
suraj.khur...@hotwax.co> ha scritto:

> Hello Giulio,
>
> Thanks for pointing that out. A Jira perfectly fits here.
>
> --
> Best Regards,
> Suraj Khurana
> Senior Technical Consultant
>
>
> On Wed, Jun 23, 2021 at 5:32 AM Giulio Speri - MpStyle Srl <
> giulio.sp...@mpstyle.it> wrote:
>
> > Hello everyone,
> >
> > I hope you are all doing well.
> > I write because today I faced an unexpected behaviour in one of our
> > ecommerce applications, during creation of an order and related inventory
> > reservation.
> >
> > The ProductStore is set up to reserve inventory from more than one
> > facility, so the flag oneInventoryFacility is set to N.
> > The we have 8 different facilities configured (each with a specific
> > sequence num from 1 to 8) in the entity ProductStoreFacility.
> >
> > Due to customer requests I had to disable 6 out of 8 facilities
> associated
> > with the store, so basically only facilities with (sequence) numbers 1
> and
> > 2 are left. To achieve this I set the thruDate on the other six records.
> >
> > After that, an order came in with a variant product that had only 1
> > quantity left available in one of the disabled facilities and 0 in both
> the
> > two facilities left enabled, but despite this the system reserved
> inventory
> > from the disabled facility: I wouldn't expect that.
> >
> > The service responsible for the reservation is *reserveStoreInventory
> *that
> > in our ofbiz version (13.07.03) is minilang and is implemented in
> > ProductStoreServices.xml: I checked that service and I noticed that when
> > the ProductStore is set to multi facility (oneInventoryFacility to N) and
> > the list of productStoreFacility records are retrieved, they are not
> > filtered by date, and this lead to a "bad" reservation.
> > I took a look also at the current revision of ofbiz and the code (groovy
> > script) is basically the same, so the issue is present there also.
> >
> > Is this a real issue/bug or this behaviour was intended to act this way?
> >
> > If this is an issue I can open a Jira Ticket, add more details and start
> > working on a patch for both versions.
> >
> > What do you think about it?
> >
> > Thank you in advance for your attention.
> >
> > Best regards,
> > Giulio
> >
> >
> >
> >
> > --
> > Giulio Speri
> >
> >
> > *Mp Styl**e Srl*
> > via Antonio Meucci, 37
> > 41019 Limidi di Soliera (MO)
> > T 059/684916
> > M 334/3779851
> >
> > www.mpstyle.it
> >
>


-- 
Giulio Speri


*Mp Styl**e Srl*
via Antonio Meucci, 37
41019 Limidi di Soliera (MO)
T 059/684916
M 334/3779851

www.mpstyle.it

Possible issue in reserveStoreInventory service

[Giulio Speri - MpStyle Srl]

Hello everyone,

I hope you are all doing well.
I write because today I faced an unexpected behaviour in one of our
ecommerce applications, during creation of an order and related inventory
reservation.

The ProductStore is set up to reserve inventory from more than one
facility, so the flag oneInventoryFacility is set to N.
The we have 8 different facilities configured (each with a specific
sequence num from 1 to 8) in the entity ProductStoreFacility.

Due to customer requests I had to disable 6 out of 8 facilities associated
with the store, so basically only facilities with (sequence) numbers 1 and
2 are left. To achieve this I set the thruDate on the other six records.

After that, an order came in with a variant product that had only 1
quantity left available in one of the disabled facilities and 0 in both the
two facilities left enabled, but despite this the system reserved inventory
from the disabled facility: I wouldn't expect that.

The service responsible for the reservation is *reserveStoreInventory *that
in our ofbiz version (13.07.03) is minilang and is implemented in
ProductStoreServices.xml: I checked that service and I noticed that when
the ProductStore is set to multi facility (oneInventoryFacility to N) and
the list of productStoreFacility records are retrieved, they are not
filtered by date, and this lead to a "bad" reservation.
I took a look also at the current revision of ofbiz and the code (groovy
script) is basically the same, so the issue is present there also.

Is this a real issue/bug or this behaviour was intended to act this way?

If this is an issue I can open a Jira Ticket, add more details and start
working on a patch for both versions.

What do you think about it?

Thank you in advance for your attention.

Best regards,
Giulio




-- 
Giulio Speri


*Mp Styl**e Srl*
via Antonio Meucci, 37
41019 Limidi di Soliera (MO)
T 059/684916
M 334/3779851

www.mpstyle.it

Re: Kickoff Meeting - Apache OFBiz Tutorial Project

[Giulio Speri - MpStyle Srl]

Hi Pranay,

I share mine and Nicola Slack member IDs :
Giulio : UBT8JJ6HE
Nicola: U01HE23PMUG

Thank you,
Giulio

Il giorno ven 11 dic 2020 alle ore 12:05 Pranay Pandey <
pranay.pan...@hotwaxsystems.com> ha scritto:

> Talk to you in 2 hours from now on the given Zoom meeting. Thanks!
>
> Kind regards,
> Pranay Pandey
>
>
> On Thu, Dec 10, 2020 at 10:37 PM Pranay Pandey <
> pranay.pan...@hotwaxsystems.com> wrote:
>
> > Thank you so much!
> >
> > Meeting scheduled. All the interested contributors must have received the
> > invitation.
> >
> > Here are details for easy reference:
> >
> > December 11, 2020 1:00 PM - 2 PM GMT
> >
> > Join Zoom Meeting
> >
> https://us02web.zoom.us/j/87242467577?pwd=SVF5dXlBTHZQS3NIa3JrL0N5ajMxUT09
> >
> > Meeting ID: 872 4246 7577
> > Passcode: 117215
> > One tap mobile
> > +13017158592,,87242467577#,,0#,,117215# US (Washington D.C)
> > +13126266799,,87242467577#,,0#,,117215# US (Chicago)
> >
> > Dial by your location
> > +1 301 715 8592 US (Washington D.C)
> > +1 312 626 6799 US (Chicago)
> > +1 346 248 7799 US (Houston)
> > +1 646 558 8656 US (New York)
> > +1 669 900 9128 US (San Jose)
> > +1 253 215 8782 US (Tacoma)
> > Meeting ID: 872 4246 7577
> > Passcode: 117215
> > Find your local number: https://us02web.zoom.us/u/kcr3qH2BGt
> >
> > Kind regards,
> > Pranay Pandey
> >
> > On Thu, 10 Dec 2020 at 7:16 PM, Giulio Speri - MpStyle Srl <
> > giulio.sp...@mpstyle.it> wrote:
> >
> >> +1
> >>
> >> Thanks,
> >> Giulio
> >>
> >> Il giorno gio 10 dic 2020 alle ore 13:13 Devanshu Vyas <
> >> vyas.devansh...@gmail.com> ha scritto:
> >>
> >> > +1
> >> >
> >> > Thanks & Regards,
> >> > Devanshu Vyas.
> >> >
> >> >
> >> > On Wed, Dec 9, 2020 at 3:05 PM Nicola Mazzoni <
> >> nicola.mazz...@mpstyle.it>
> >> > wrote:
> >> >
> >> > > +1
> >> > >
> >> > > Il giorno mer 9 dic 2020 alle ore 10:28 Aditya Sharma <
> >> > > adityasha...@apache.org> ha scritto:
> >> > >
> >> > > > +1
> >> > > >
> >> > > > Thanks and regards,
> >> > > > Aditya Sharma
> >> > > >
> >> > > > On Wed, Dec 9, 2020 at 1:09 PM Pranay Pandey <
> >> > > > pranay.pan...@hotwaxsystems.com> wrote:
> >> > > >
> >> > > > > Hello Tutorial Project Volunteers,
> >> > > > >
> >> > > > > First of all thank you so much for showing interest in
> >> volunteering
> >> > the
> >> > > > > Apache OFBiz Tutorial Project.
> >> > > > >
> >> > > > > With this email I want to propose an online meeting to kickoff
> the
> >> > > > project.
> >> > > > > This meeting will help us in knowing each other. After this
> >> meeting
> >> > we
> >> > > > will
> >> > > > > continue doing offline communication on email, OFBiz mailing
> list,
> >> > > Slack
> >> > > > > Channel to make progress with our work. We can surely plan
> online
> >> > > > meetings
> >> > > > > in future as well as and when needed. This way the community
> will
> >> > also
> >> > > be
> >> > > > > updated all the time.
> >> > > > >
> >> > > > > It's a great opportunity for all of us to learn from each other
> >> and
> >> > to
> >> > > > also
> >> > > > > prepare some robust content for OFBiz
> developers/users/evaluators.
> >> > What
> >> > > > > we'll generate will be a next level set of tutorials and guides
> >> for
> >> > the
> >> > > > > community and will be a proven asset for the project.
> >> > > > >
> >> > > > > How about meeting on this Friday 1:00 PM GMT? Does this day and
> >> time
> >> > > work
> >> > > > > for all of you? Please confirm your availability and we'll go
> from
> >> > > there.
> >> > > > >
> >> > > > > Available: +1
> >> > > > > May be: 0
> >> > > > > Not Available: -1
> >> > > > >
> >> > > > > Kind regards,
> >> > > > > Pranay Pandey
> >> > > > > https://ofbiz.apache.org/
> >> > > > >
> >> > > >
> >> > >
> >> > >
> >> > > --
> >> > > Nicola Mazzoni
> >> > >
> >> > >
> >> > > *Mp Styl**e Srl*
> >> > > via Meucci, 37
> >> > > 41019 Limidi di Soliera (MO)
> >> > > T 059/684916
> >> > > M 347/9905529
> >> > >
> >> > > www.mpstyle.it
> >> > >
> >> >
> >>
> >>
> >> --
> >> Giulio Speri
> >>
> >>
> >> *Mp Styl**e Srl*
> >> via Antonio Meucci, 37
> >> 41019 Limidi di Soliera (MO)
> >> T 059/684916
> >> M 334/3779851
> >>
> >> www.mpstyle.it
> >>
> > --
> > Best regards,
> >
> > Pranay Pandey
> > mobile: +91 9826035576
> > email: pranay.pan...@hotwax.co
> > www.hotwax.co
> >
>


-- 
Giulio Speri


*Mp Styl**e Srl*
via Antonio Meucci, 37
41019 Limidi di Soliera (MO)
T 059/684916
M 334/3779851

www.mpstyle.it

Re: Kickoff Meeting - Apache OFBiz Tutorial Project

[Giulio Speri - MpStyle Srl]

+1

Thanks,
Giulio

Il giorno gio 10 dic 2020 alle ore 13:13 Devanshu Vyas <
vyas.devansh...@gmail.com> ha scritto:

> +1
>
> Thanks & Regards,
> Devanshu Vyas.
>
>
> On Wed, Dec 9, 2020 at 3:05 PM Nicola Mazzoni 
> wrote:
>
> > +1
> >
> > Il giorno mer 9 dic 2020 alle ore 10:28 Aditya Sharma <
> > adityasha...@apache.org> ha scritto:
> >
> > > +1
> > >
> > > Thanks and regards,
> > > Aditya Sharma
> > >
> > > On Wed, Dec 9, 2020 at 1:09 PM Pranay Pandey <
> > > pranay.pan...@hotwaxsystems.com> wrote:
> > >
> > > > Hello Tutorial Project Volunteers,
> > > >
> > > > First of all thank you so much for showing interest in volunteering
> the
> > > > Apache OFBiz Tutorial Project.
> > > >
> > > > With this email I want to propose an online meeting to kickoff the
> > > project.
> > > > This meeting will help us in knowing each other. After this meeting
> we
> > > will
> > > > continue doing offline communication on email, OFBiz mailing list,
> > Slack
> > > > Channel to make progress with our work. We can surely plan online
> > > meetings
> > > > in future as well as and when needed. This way the community will
> also
> > be
> > > > updated all the time.
> > > >
> > > > It's a great opportunity for all of us to learn from each other and
> to
> > > also
> > > > prepare some robust content for OFBiz developers/users/evaluators.
> What
> > > > we'll generate will be a next level set of tutorials and guides for
> the
> > > > community and will be a proven asset for the project.
> > > >
> > > > How about meeting on this Friday 1:00 PM GMT? Does this day and time
> > work
> > > > for all of you? Please confirm your availability and we'll go from
> > there.
> > > >
> > > > Available: +1
> > > > May be: 0
> > > > Not Available: -1
> > > >
> > > > Kind regards,
> > > > Pranay Pandey
> > > > https://ofbiz.apache.org/
> > > >
> > >
> >
> >
> > --
> > Nicola Mazzoni
> >
> >
> > *Mp Styl**e Srl*
> > via Meucci, 37
> > 41019 Limidi di Soliera (MO)
> > T 059/684916
> > M 347/9905529
> >
> > www.mpstyle.it
> >
>


-- 
Giulio Speri


*Mp Styl**e Srl*
via Antonio Meucci, 37
41019 Limidi di Soliera (MO)
T 059/684916
M 334/3779851

www.mpstyle.it

ShowPromoText/ProductPromoWorker nulls all product promotions after a single condition check failure

[Giulio Speri - MpStyle Srl]

Hello everyone,

I am facing a strange behaviour regarding Product Store Promotions that are
active for one of the ecommerce sites that my company manage.

In all the pages of the sites, we have included the ShowPromoText.groovy
script that retrieves the promotions active for a specific store: we then
use data gathered from the script to make some customizations (ftl-side) on
how the promos are shown to the end user customers.
The main method that the script uses to get all the promos for a store
is *getStoreProductPromos
*of the class* ProductPromoWorker.java.*

Right now there are active on the site ten/fifteen different kind of
promotions like order discount promotions, ship charge discount promotions,
promocodes linked to a specific party and more; what I noticed is that the
groovy script cannot always retrieve all the available promos for a store
so I started check out a bit the method getStoreProductPromos: this method
loops over all the ProductStorePromoAppl records, tests each promo and if
the promo conditions are met then the record is added to a list of valid
promos; if the conditions are not met then the promo is nulled.
I found that if one of the first promo processed fails the rule conditions
check, due to a boolean flag *condResult *that switches to* false* then,
all the following promos in the (ProductStorePromoAppl) list are never
checked and nulled,  and at the end never shown to the end user customer.


I would like to ask if this is actually an issue of the
getStoreProductPromos method or if is not the case, what are the reasons
behind that piece of logic.


Thank you in advance for your help.

Kind regards,
Giulio



-- 
Giulio Speri


*Mp Styl**e Srl*
via Antonio Meucci, 37
41019 Limidi di Soliera (MO)
T 059/684916
M 334/3779851

www.mpstyle.it

Re: Visit/Visitor specific client IPs tracking exclusion

[Giulio Speri - MpStyle Srl]

Hello everyone,

I have created a Jira task for this.

OFBIZ-10957 <https://issues.apache.org/jira/browse/OFBIZ-10957>


Giulio

Il giorno sab 13 apr 2019 alle ore 16:30 Giulio Speri - MpStyle Srl <
giulio.sp...@mpstyle.it> ha scritto:

> Hi Nicolas,
>
> thank you for the suggestion.
> For HaProxy in fact, we prepared a simple request "hacheck" used
> specifically for Health Checks; I tried to set the attributes "track-visit"
> and "track-serverhit" to "false" on the request-map and made some test
> (with the help JMeter) but they affect only "firstvisit" events and the
> tracking of the server hit.
> The problem is that records for Visit and Visitor are created in the
> *ControlServlet#doGet*, before the *RequestHandler#trackVisit* and
> *RequestHandler#trackStats* are executed.
>
> In particular, the trackVisit method, evaluated to check if
> *FIRST_VISIT_EVENTS* should be run, is executed in the
> *RequestHandler#doRequest* method, called in the ControlServlet after the
> setup of some initial request attributes and after these two statements:
>
> *VisitHandler.getVisitor(request, response);*
>
> and
>
> *String visitId = VisitHandler.getVisitId(session);*
>
> If the ip is not filtered before the statements above, the HaProxy that
> requests for its health check page with the track-visit and track-serverhit
> set to "false", will end up to store Visit/Visitor records anyway.
>
> I think that setting those two parameters on the check page should be used
> along with our solution, in order to achieve what we are looking for.
>
>
> @Arun Yes, your summary is accurate.
>
> Thank you and Regards,
> Giulio
>
>
>
>
> Il giorno ven 12 apr 2019 alle ore 09:19 Nicolas Malin <
> nicolas.ma...@nereide.fr> ha scritto:
>
>> Hello,
>>
>> To manage own load balancer we use a dedicate uri like this :
>>
>> > track-visit="false">
>>
>> It would be help to redirect your monitoring traffic.
>>
>> Nicolas
>>
>> On 12/04/2019 08:49, Arun Patidar wrote:
>> > Hello Giulio,
>> >
>> > Thanks for the the detailed and clear message. My understanding with
>> your
>> > proposal is as below:
>> >
>> > 1) We should enable configuration settings to ignore visit entries for
>> > Internal IPs and known requests (like HaProxy/load balancer, monitoring
>> > requests) etc.
>> > 2) For large DB size due to visits and hits, we can use a separate Stats
>> > database for visit entity group.
>> > 3) Also, idea to purge old visits using a scheduled job is good, We can
>> set
>> > number of days configurable as per need.
>> >
>> >
>> >
>> > --
>> > Best Regards,
>> > Arun Patidar
>> > www.hotwax.co
>> >
>> >
>> >
>> > On Fri, Apr 12, 2019 at 5:17 AM Giulio Speri - MpStyle Srl <
>> > giulio.sp...@mpstyle.it> wrote:
>> >
>> >> Hello devs,
>> >>
>> >> I'm writing because I would like to explain a problem my company,
>> MpStyle,
>> >> faced with an OFBiz installation with two active ecommerce sites, for
>> one
>> >> of our customers.
>> >> I am writing this email to the dev mailing list, because I could not
>> find
>> >> any reference in the mailings to the kind of problem we faced, and I
>> think
>> >> that the solution we built, could be an improvement to the OFBiz
>> >> visit/visitor tracking capabilites.
>> >>
>> >> I shortly explain the server architecture on which OFBiz is running:
>> hosted
>> >> by a third party supplier, there are two (virtual) machines where
>> Apache
>> >> OFBiz 13.07.03 is running behind Apache2 web server (so we have two web
>> >> fronts).
>> >> On other two different machines there are the database (MariaDB) and
>> >> HaProxy has a load balancer.
>> >> HaProxy is configured to perform its Health Checks on the backend
>> servers
>> >> with a Http GET on the Home Page of one of the two sites.
>> >> Visit and Visitor tracking are enabled, for BI and analytics purposes,
>> so
>> >> we cannot turn them off.
>> >> These two combined things caused the Visit and Visitor tables to
>> explode in
>> >> dimensions (we counted about 19M records of Visit and about 67M of
>> >> Visitors, with the 86% of those caused by the load balancer), since
>> each
>> >> hi

Re: Visit/Visitor specific client IPs tracking exclusion

[Giulio Speri - MpStyle Srl]

Hi Nicolas,

thank you for the suggestion.
For HaProxy in fact, we prepared a simple request "hacheck" used
specifically for Health Checks; I tried to set the attributes "track-visit"
and "track-serverhit" to "false" on the request-map and made some test
(with the help JMeter) but they affect only "firstvisit" events and the
tracking of the server hit.
The problem is that records for Visit and Visitor are created in the
*ControlServlet#doGet*, before the *RequestHandler#trackVisit* and
*RequestHandler#trackStats* are executed.

In particular, the trackVisit method, evaluated to check if
*FIRST_VISIT_EVENTS* should be run, is executed in the
*RequestHandler#doRequest* method, called in the ControlServlet after the
setup of some initial request attributes and after these two statements:

*VisitHandler.getVisitor(request, response);*

and

*String visitId = VisitHandler.getVisitId(session);*

If the ip is not filtered before the statements above, the HaProxy that
requests for its health check page with the track-visit and track-serverhit
set to "false", will end up to store Visit/Visitor records anyway.

I think that setting those two parameters on the check page should be used
along with our solution, in order to achieve what we are looking for.


@Arun Yes, your summary is accurate.

Thank you and Regards,
Giulio




Il giorno ven 12 apr 2019 alle ore 09:19 Nicolas Malin <
nicolas.ma...@nereide.fr> ha scritto:

> Hello,
>
> To manage own load balancer we use a dedicate uri like this :
>
>  track-visit="false">
>
> It would be help to redirect your monitoring traffic.
>
> Nicolas
>
> On 12/04/2019 08:49, Arun Patidar wrote:
> > Hello Giulio,
> >
> > Thanks for the the detailed and clear message. My understanding with your
> > proposal is as below:
> >
> > 1) We should enable configuration settings to ignore visit entries for
> > Internal IPs and known requests (like HaProxy/load balancer, monitoring
> > requests) etc.
> > 2) For large DB size due to visits and hits, we can use a separate Stats
> > database for visit entity group.
> > 3) Also, idea to purge old visits using a scheduled job is good, We can
> set
> > number of days configurable as per need.
> >
> >
> >
> > --
> > Best Regards,
> > Arun Patidar
> > www.hotwax.co
> >
> >
> >
> > On Fri, Apr 12, 2019 at 5:17 AM Giulio Speri - MpStyle Srl <
> > giulio.sp...@mpstyle.it> wrote:
> >
> >> Hello devs,
> >>
> >> I'm writing because I would like to explain a problem my company,
> MpStyle,
> >> faced with an OFBiz installation with two active ecommerce sites, for
> one
> >> of our customers.
> >> I am writing this email to the dev mailing list, because I could not
> find
> >> any reference in the mailings to the kind of problem we faced, and I
> think
> >> that the solution we built, could be an improvement to the OFBiz
> >> visit/visitor tracking capabilites.
> >>
> >> I shortly explain the server architecture on which OFBiz is running:
> hosted
> >> by a third party supplier, there are two (virtual) machines where Apache
> >> OFBiz 13.07.03 is running behind Apache2 web server (so we have two web
> >> fronts).
> >> On other two different machines there are the database (MariaDB) and
> >> HaProxy has a load balancer.
> >> HaProxy is configured to perform its Health Checks on the backend
> servers
> >> with a Http GET on the Home Page of one of the two sites.
> >> Visit and Visitor tracking are enabled, for BI and analytics purposes,
> so
> >> we cannot turn them off.
> >> These two combined things caused the Visit and Visitor tables to
> explode in
> >> dimensions (we counted about 19M records of Visit and about 67M of
> >> Visitors, with the 86% of those caused by the load balancer), since each
> >> hit of the HaProxy store a Visit and a Visitor record on the db (plus
> some
> >> other record of other entities, like ShoppingList, due to 
> and
> >>  events).
> >> A bad side effect of this situation, on the long run, is an overall
> >> performance degradation, and an increase in webfront unavailability time
> >> windows during the day: it's not necessary to say that our customer was
> not
> >> so happy about this.
> >>
> >> The difficult part of figuring out this problem, was that we did not
> have
> >> direct access to HaProxy and DB machines, to check logs.
> >>
> >> The solution we thought and implemented, was to exclude from
> 

Visit/Visitor specific client IPs tracking exclusion

[Giulio Speri - MpStyle Srl]

Hello devs,

I'm writing because I would like to explain a problem my company, MpStyle,
faced with an OFBiz installation with two active ecommerce sites, for one
of our customers.
I am writing this email to the dev mailing list, because I could not find
any reference in the mailings to the kind of problem we faced, and I think
that the solution we built, could be an improvement to the OFBiz
visit/visitor tracking capabilites.

I shortly explain the server architecture on which OFBiz is running: hosted
by a third party supplier, there are two (virtual) machines where Apache
OFBiz 13.07.03 is running behind Apache2 web server (so we have two web
fronts).
On other two different machines there are the database (MariaDB) and
HaProxy has a load balancer.
HaProxy is configured to perform its Health Checks on the backend servers
with a Http GET on the Home Page of one of the two sites.
Visit and Visitor tracking are enabled, for BI and analytics purposes, so
we cannot turn them off.
These two combined things caused the Visit and Visitor tables to explode in
dimensions (we counted about 19M records of Visit and about 67M of
Visitors, with the 86% of those caused by the load balancer), since each
hit of the HaProxy store a Visit and a Visitor record on the db (plus some
other record of other entities, like ShoppingList, due to  and
 events).
A bad side effect of this situation, on the long run, is an overall
performance degradation, and an increase in webfront unavailability time
windows during the day: it's not necessary to say that our customer was not
so happy about this.

The difficult part of figuring out this problem, was that we did not have
direct access to HaProxy and DB machines, to check logs.

The solution we thought and implemented, was to exclude from Visit/Visitor
tracking specific IP addresses (for our case we were interested in HaProxy
IP).
The Visit and Visitor records (along with firstvisit and preprocessor
events) are created mainly in the ControlServlet class, using VisitHandler
getVisit/getVisitor/getVisitId methods.

Our idea consist in reading from a .properties file one or more IP
addresses we would like to exclude from tracking and then check them
against the client ip address the request is coming from.
If the client ip address is in the "exclusion list", then do not persist
visit/visitor and do not run firstvisit events neither for it.

The idea is quite simple, but we noticed in few days, a meaningful
improvement in overall system performance and stability/availability.

This kind of exclusion could be also useful in case we do not want to track
or register internal IP addresses (ie: mainly used for testing).

However this solution, should be integrated with a service (cron or
scheduled in ofbiz) that keeps the number of records in the tables limited
(for example keep only the last month of visit/visitor); I think that these
two solutions together, could do the job well.

I hope my explanation was clear enough and I would be happy to know what do
you think about this.

Thank you all for the attention!

Regards,

Giulio



























-- 
Giulio Speri


*Mp Styl**e Srl*
via Antonio Meucci, 37
41019 Limidi di Soliera (MO)
T 059/684916
M 334/3779851

www.mpstyle.it

Re: [ANNOUNCE] The Big Book for Apache OFBiz Data Model 2017 Released

[Giulio Speri - MpStyle Srl]

Really great work!

Thanks Aditya!

Regards,

Giulio

2017-10-04 13:15 GMT+02:00 Aditya Sharma :

> Hello All,
>
> It gives me immense pleasure informing you all that we have updated *The
> Big
> Book of Apache OFBiz Data Model* according to the latest trunk version.
>
> The key features:
> * Colored content with titles according to the internal color pattern.
> * Addition of a separate page for integration specific entities.
> * Removal of technical process diagrams, making it specific for entities.
> * Addition of 77 new entities.
> * Removal of 8 entities.
> * Addition of around 200+ new fields in entities (Though major portion
> includes the addition of description or attrDescription fields in
> *Attribute or *TypeAttr entities).
> * Removal of 24 fields.
>
> I have uploaded the files on Data Model Diagrams page. Here is the link
> .
>
> Cheers!
>
> *Aditya Sharma* | Enterprise Software Engineer
> HotWax Systems 
> 
>



-- 
Giulio Speri

*Mp Styl**e Srl*
via Antonio Meucci, 37
41019 Limidi di Soliera (MO)
T 059/684916
M 334/3779851

www.mpstyle.it

Re: Please add me as Apache OFBiz Contributor

[Giulio Speri - MpStyle Srl]

Great! I'm really happy to be part of the OFBiz community!

Thank You very much Sharan,

Giulio

2017-04-13 10:18 GMT+02:00 Sharan Foga <sha...@apache.org>:

> Hi Guilio
>
> Thanks for filing the ICLA. 've updated your confluence permissions for
> the wiki so you should have create and edit access now. If you have any
> problems then please let me know.
>
> I also checked Jira (our issue tracking system) and couldn't find a user
> profile for you. As a contributor you also get added to the contributors
> group in Jira too. In general it means that you can assign yourself to any
> issues you are working on.
>
> Thanks
> Sharan
>
> On 2017-04-12 23:53 (+0200), Giulio Speri - MpStyle Srl <
> giulio.sp...@mpstyle.it> wrote:
> > ​Good evening Sharan,
> > I compiled the form and emailed it to the address indicated in the
> > reference you gave me (secret...@apache.org).
> >
> > Thanks again for your help,
> > Giulio​
> >
> > 2017-04-12 17:26 GMT+02:00 Sharan Foga <sha...@apache.org>:
> >
> > > Hi Guilo
> > >
> > > Welcome and thanks very much for wanting to contribute to the project.
> > >
> > > We ask that all contributors complete an ICLA before getting update
> access
> > > to our wiki. Details of the process can be found here
> > >
> > > https://cwiki.apache.org/confluence/display/OFBIZ/
> > > Apache+OFBiz+Contributors
> > >
> > > If you have completed the ICLA form then please let me know and I will
> > > check that it has been filed.
> > >
> > > Alternatively you can ask someone to update the page for you.
> > >
> > > Thanks
> > > Sharan
> > >
> > > On 2017-04-12 17:08 (+0200), Giulio Speri - MpStyle Srl <
> > > giulio.sp...@mpstyle.it> wrote:
> > > > Hello everyone,
> > > >
> > > > I would like to ask you to add me as Apache OFBiz contributor in
> order to
> > > > add my eCommerce project to the Confluence relative page.
> > > > My Confluence account username is : giulio.speri
> > > >
> > > > Thank you very much!
> > > >
> > > > Kind regards,
> > > >
> > > > Giulio Speri
> > > >
> > > >
> > > > --
> > > > Giulio Speri
> > > >
> > > > *Mp Styl**e Srl*
> > > > via Antonio Meucci, 37
> > > > 41019 Limidi di Soliera (MO)
> > > > T 059/684916
> > > > M 334/3779851
> > > >
> > > > www.mpstyle.it
> > > >
> > >
> >
> >
> >
> > --
> > Giulio Speri
> >
> > *Mp Styl**e Srl*
> > via Antonio Meucci, 37
> > 41019 Limidi di Soliera (MO)
> > T 059/684916
> > M 334/3779851
> >
> > www.mpstyle.it
> >
>



-- 
Giulio Speri

*Mp Styl**e Srl*
via Antonio Meucci, 37
41019 Limidi di Soliera (MO)
T 059/684916
M 334/3779851

www.mpstyle.it

Re: Please add me as Apache OFBiz Contributor

[Giulio Speri - MpStyle Srl]

​Good evening Sharan,
I compiled the form and emailed it to the address indicated in the
reference you gave me (secret...@apache.org).

Thanks again for your help,
Giulio​

2017-04-12 17:26 GMT+02:00 Sharan Foga <sha...@apache.org>:

> Hi Guilo
>
> Welcome and thanks very much for wanting to contribute to the project.
>
> We ask that all contributors complete an ICLA before getting update access
> to our wiki. Details of the process can be found here
>
> https://cwiki.apache.org/confluence/display/OFBIZ/
> Apache+OFBiz+Contributors
>
> If you have completed the ICLA form then please let me know and I will
> check that it has been filed.
>
> Alternatively you can ask someone to update the page for you.
>
> Thanks
> Sharan
>
> On 2017-04-12 17:08 (+0200), Giulio Speri - MpStyle Srl <
> giulio.sp...@mpstyle.it> wrote:
> > Hello everyone,
> >
> > I would like to ask you to add me as Apache OFBiz contributor in order to
> > add my eCommerce project to the Confluence relative page.
> > My Confluence account username is : giulio.speri
> >
> > Thank you very much!
> >
> > Kind regards,
> >
> > Giulio Speri
> >
> >
> > --
> > Giulio Speri
> >
> > *Mp Styl**e Srl*
> > via Antonio Meucci, 37
> > 41019 Limidi di Soliera (MO)
> > T 059/684916
> > M 334/3779851
> >
> > www.mpstyle.it
> >
>



-- 
Giulio Speri

*Mp Styl**e Srl*
via Antonio Meucci, 37
41019 Limidi di Soliera (MO)
T 059/684916
M 334/3779851

www.mpstyle.it

Re: Please add me as Apache OFBiz Contributor

[Giulio Speri - MpStyle Srl]

Thank You very much Sharan, I'll fill the ICLA form as soon as possible!

Giulio

2017-04-12 17:26 GMT+02:00 Sharan Foga <sha...@apache.org>:

> Hi Guilo
>
> Welcome and thanks very much for wanting to contribute to the project.
>
> We ask that all contributors complete an ICLA before getting update access
> to our wiki. Details of the process can be found here
>
> https://cwiki.apache.org/confluence/display/OFBIZ/
> Apache+OFBiz+Contributors
>
> If you have completed the ICLA form then please let me know and I will
> check that it has been filed.
>
> Alternatively you can ask someone to update the page for you.
>
> Thanks
> Sharan
>
> On 2017-04-12 17:08 (+0200), Giulio Speri - MpStyle Srl <
> giulio.sp...@mpstyle.it> wrote:
> > Hello everyone,
> >
> > I would like to ask you to add me as Apache OFBiz contributor in order to
> > add my eCommerce project to the Confluence relative page.
> > My Confluence account username is : giulio.speri
> >
> > Thank you very much!
> >
> > Kind regards,
> >
> > Giulio Speri
> >
> >
> > --
> > Giulio Speri
> >
> > *Mp Styl**e Srl*
> > via Antonio Meucci, 37
> > 41019 Limidi di Soliera (MO)
> > T 059/684916
> > M 334/3779851
> >
> > www.mpstyle.it
> >
>



-- 
Giulio Speri

*Mp Styl**e Srl*
via Antonio Meucci, 37
41019 Limidi di Soliera (MO)
T 059/684916
M 334/3779851

www.mpstyle.it

Please add me as Apache OFBiz Contributor

[Giulio Speri - MpStyle Srl]

Hello everyone,

I would like to ask you to add me as Apache OFBiz contributor in order to
add my eCommerce project to the Confluence relative page.
My Confluence account username is : giulio.speri

Thank you very much!

Kind regards,

Giulio Speri


-- 
Giulio Speri

*Mp Styl**e Srl*
via Antonio Meucci, 37
41019 Limidi di Soliera (MO)
T 059/684916
M 334/3779851

www.mpstyle.it