[jira] [Updated] (OFBIZ-4811) Improving view-entity creation in both XML and DynamicViewEntity to exclude fields declared as Alias from the SQL Select strings

2012-04-16 Thread Jacques Le Roux (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-4811:
---

  Component/s: (was: ALL APPLICATIONS)
   (was: ALL COMPONENTS)
   framework
  Environment: (was: Windows, Linux)
Affects Version/s: (was: Release Branch 11.04)
   SVN trunk

> Improving view-entity creation in both XML and DynamicViewEntity to exclude 
> fields declared as Alias from the SQL Select strings
> 
>
> Key: OFBIZ-4811
> URL: https://issues.apache.org/jira/browse/OFBIZ-4811
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: SVN trunk
>Reporter: FooShyn
>
> To have additional feature for view-entity creation so that
> - Alias can be excluded from the SQL Select strings. This feature is 
> particularly useful when working on reports that need aggregation on the data 
> with fields that need to be use as filter. E.g.: select a.salesman_id, 
> sum(b.sales) as total_sales from salesman a, daily_sales b where 
> a.salesman_id = b.salesman_id and b.sales_date < '02-02-2012' group by 
> a.salesman_id
> - To have constant values that can be use in view-link.
> E.g.
> 
> 
>  
> 
> This produces something like this:
> select * from a left join b on a.importSessionId = b.sessionId and
> status='ERROR'

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (OFBIZ-4797) eCommerce Edit Contact Information use Dependent drop-downs

2012-04-15 Thread Jacques Le Roux (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-4797:
---

Attachment: OFBIZ-4797 eCommerce Draft.patch

Tom,

For the rejected part forget it. I just figured out that it came from 
http://svn.apache.org/viewvc?rev=1326270&view=rev

For those interested here is an updated patch

> eCommerce Edit Contact Information use Dependent drop-downs
> ---
>
> Key: OFBIZ-4797
> URL: https://issues.apache.org/jira/browse/OFBIZ-4797
> Project: OFBiz
>  Issue Type: Improvement
>  Components: specialpurpose/ecommerce
>Affects Versions: SVN trunk
> Environment: demo-trunk
>Reporter: Tom Burns
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-4797 eCommerce Draft.patch, OFBIZ-4797 eCommerce 
> Draft.patch
>
>
> Using Dependent drop-downs to filter the State drop down based on the 
> selection in the Country drop-down will improve the usability of the 
> component.
> Current Behavior:
> 1. Open eCommerce application
> 2. Log in as user with Postal Address say Demo Customer
> 3. In the menu bar select Profile
> 4. In "Contact Information" > "Postal Address" select update.
> 5. The "Country" drop-down value is "United States" and the "State/Province" 
> drop-down list displays all geo values.
> After improvement:
> 5. The "Country" drop-down value is "United States" and the "State/Province" 
> drop-down list is limited to States in the United States.
> 6. Changing the value in the "Country" drop-down will update "State/Province" 
> drop-down list with values for the selected country.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (OFBIZ-4808) Missing helpscreens for Project Mgr application

2012-04-15 Thread Jacques Le Roux (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-4808:
---

  Priority: Trivial  (was: Major)
Issue Type: Improvement  (was: Bug)

Trivial improvement

> Missing helpscreens for Project Mgr application
> ---
>
> Key: OFBIZ-4808
> URL: https://issues.apache.org/jira/browse/OFBIZ-4808
> Project: OFBiz
>  Issue Type: Improvement
>  Components: specialpurpose/projectmgr
>Affects Versions: Release Branch 11.04
>Reporter: Pierre Smits
>Priority: Trivial
> Fix For: Release Branch 11.04
>
> Attachments: OFBIZ-4808-r11_04-ProjectMgr-helpscreens.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Fixing the missing help screens in project mgr app of R11.04 branch

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (OFBIZ-3155) Enhancing the useability of SFA by including an overview of the agreements of the account into the Account Screen

2012-04-14 Thread Jacques Le Roux (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-3155:
---

Attachment: OFBIZ-3155 sfa-accounts-agreements.patch

Pierre,

Here is a new patch which applies on trunk. I applied yours with few fuzz. No 
review

> Enhancing the useability of SFA by including an overview of the agreements of 
> the account into the Account Screen
> -
>
> Key: OFBIZ-3155
> URL: https://issues.apache.org/jira/browse/OFBIZ-3155
> Project: OFBiz
>  Issue Type: Improvement
>  Components: marketing
>Reporter: Pierre Smits
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3155 sfa-accounts-agreements.patch, 
> sfa-accounts-agreements.patch
>
>
> This improvement includes:
> Adding an overview of associated agreements with the account to the account 
> screen
> Adding the functionality to create agreements from the account screen, with 
> setting the default agreement parties (Company and the account)
> The modifications are realized on:
> \applications\accounting\widgets\agreementscreen.xml - setting default 
> agreement parties
> \applications\party\webapp\partymgr\static\partymgr.css - including of style 
> elements for overviews in the bottom position of account screen
> \applications\party\widget\partymgr\profilescreens.xml  - including a screen 
> for partyAgreements
> \applications\party\widget\partymgr\partyforms.xml - including a form to 
> render the overview of agreements for accounts
> \applications\marketing\widget\sfa\sfamenus.xml - including the menu to 
> create new agreements from the acount screen
> \applications\marketing\widget\sfa\commonscreen.xml - including functionality 
> to add the overview of agreements to the bottom of the account screen.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (OFBIZ-4242) CatalinaContainer Doesn't Respect Node for web.xml files.

2012-04-14 Thread Jacques Le Roux (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-4242:
---

 Priority: Minor  (was: Major)
Affects Version/s: (was: Release 09.04)
   SVN trunk
   Issue Type: Improvement  (was: Bug)

Changes from bug to improvement, major to minor, R09.04 to trunk.

> CatalinaContainer Doesn't Respect  Node for web.xml files.
> --
>
> Key: OFBIZ-4242
> URL: https://issues.apache.org/jira/browse/OFBIZ-4242
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: SVN trunk
>Reporter: Lon F. Binder
>Assignee: Jacques Le Roux
>Priority: Minor
>  Labels: cluster, clustering, tomcat
> Attachments: ofbiz-4242-patch.txt
>
>
> Per the servlet specification, the {{web.xml}} file should allow an optional 
> {{}} node to indicate that the application is clusterable.  
> Currently, OFBiz does not respect this setting and assumes all applications 
> should be distributed if any cluster configuration is provided in the 
> {{ofbiz-containers.xml}} file.  As a result, if, for example, the 
> {{DeltaManager}} is enable, all applications attempt to cluster and 
> communicate via {{DeltaManager}}.
> The expected and proper functionality is to check the individual 
> application's web.xml file for the {{}} node and only use the 
> {{DeltaManager}} if found; otherwise the {{StandardManager}} should be used 
> for sessions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (OFBIZ-4041) Materialized views

2012-04-13 Thread Jacques Le Roux (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-4041:
---

Attachment: (was: OFBIZ-4041.patch)

> Materialized views
> --
>
> Key: OFBIZ-4041
> URL: https://issues.apache.org/jira/browse/OFBIZ-4041
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: SVN trunk
>Reporter: Marc Morin
>Assignee: Jacques Le Roux
> Attachments: OFBIZ-4041.patch
>
>
> We make extensive use of view entities in our ofbiz application.  We have 
> noticed that when there is a large dataset and under some complex views, the 
> query performance was not the best (not a index issue, just complex joins, 
> etc...).
> With some commercial databases like Oracle, etc... we would have used 
> materialized view semantics available for these dbms, but we are using 
> PostgreSQL.
> So, we have extended the entity layer in Ofbiz to perform the 
> materialization.  This is pretty slick as all you need to do is the following:
> ...
> and the system will do the following:
> - create a backing entity called "myView" that has the same fields as the view
> - backing entity has all the indexes inherited from the component entities
> - relations (fk,...) inherited from the component entities.
> - perform all the ECA actions automatically on all entities used in the view 
> (direct members and nested members if case of view on views). (This is an 
> eager update strategy only).
> So, the application doesn't change, it still accesses "myView", but now, it's 
> result is returned from the backing entity instead of the complex SQL 
> statement.
> We're pretty excited about this feature!!!  Really pushes Ofbiz framework to 
> next level and allows materialized views to be more broadly used on dbms that 
> don't naturally support it.
> We are prepared to contribute this feature back to the community if desired.  
> A note of caution about it though we have added a visitor pattern to the 
> model entities and this feature makes use of it.  It would need to come with 
> it.   

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (OFBIZ-4041) Materialized views

2012-04-13 Thread Jacques Le Roux (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-4041:
---

Affects Version/s: (was: Release Branch 10.04)
   SVN trunk

New features applie only on trunk

> Materialized views
> --
>
> Key: OFBIZ-4041
> URL: https://issues.apache.org/jira/browse/OFBIZ-4041
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: SVN trunk
>Reporter: Marc Morin
>Assignee: Jacques Le Roux
> Attachments: OFBIZ-4041.patch, OFBIZ-4041.patch
>
>
> We make extensive use of view entities in our ofbiz application.  We have 
> noticed that when there is a large dataset and under some complex views, the 
> query performance was not the best (not a index issue, just complex joins, 
> etc...).
> With some commercial databases like Oracle, etc... we would have used 
> materialized view semantics available for these dbms, but we are using 
> PostgreSQL.
> So, we have extended the entity layer in Ofbiz to perform the 
> materialization.  This is pretty slick as all you need to do is the following:
> ...
> and the system will do the following:
> - create a backing entity called "myView" that has the same fields as the view
> - backing entity has all the indexes inherited from the component entities
> - relations (fk,...) inherited from the component entities.
> - perform all the ECA actions automatically on all entities used in the view 
> (direct members and nested members if case of view on views). (This is an 
> eager update strategy only).
> So, the application doesn't change, it still accesses "myView", but now, it's 
> result is returned from the backing entity instead of the complex SQL 
> statement.
> We're pretty excited about this feature!!!  Really pushes Ofbiz framework to 
> next level and allows materialized views to be more broadly used on dbms that 
> don't naturally support it.
> We are prepared to contribute this feature back to the community if desired.  
> A note of caution about it though we have added a visitor pattern to the 
> model entities and this feature makes use of it.  It would need to come with 
> it.   

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (OFBIZ-4041) Materialized views

2012-04-13 Thread Jacques Le Roux (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-4041:
---

Attachment: OFBIZ-4041.patch

This is an interesting piece of code.

Here is a patch update which applies to trunk. I have replaced all tabs and 
removed some problematic chunks

> Materialized views
> --
>
> Key: OFBIZ-4041
> URL: https://issues.apache.org/jira/browse/OFBIZ-4041
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Release Branch 10.04
>Reporter: Marc Morin
>Assignee: Jacques Le Roux
> Attachments: OFBIZ-4041.patch, OFBIZ-4041.patch
>
>
> We make extensive use of view entities in our ofbiz application.  We have 
> noticed that when there is a large dataset and under some complex views, the 
> query performance was not the best (not a index issue, just complex joins, 
> etc...).
> With some commercial databases like Oracle, etc... we would have used 
> materialized view semantics available for these dbms, but we are using 
> PostgreSQL.
> So, we have extended the entity layer in Ofbiz to perform the 
> materialization.  This is pretty slick as all you need to do is the following:
> ...
> and the system will do the following:
> - create a backing entity called "myView" that has the same fields as the view
> - backing entity has all the indexes inherited from the component entities
> - relations (fk,...) inherited from the component entities.
> - perform all the ECA actions automatically on all entities used in the view 
> (direct members and nested members if case of view on views). (This is an 
> eager update strategy only).
> So, the application doesn't change, it still accesses "myView", but now, it's 
> result is returned from the backing entity instead of the complex SQL 
> statement.
> We're pretty excited about this feature!!!  Really pushes Ofbiz framework to 
> next level and allows materialized views to be more broadly used on dbms that 
> don't naturally support it.
> We are prepared to contribute this feature back to the community if desired.  
> A note of caution about it though we have added a visitor pattern to the 
> model entities and this feature makes use of it.  It would need to come with 
> it.   

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (OFBIZ-4804) Update Company Contact Infromrtion Fails

2012-04-13 Thread Jacques Le Roux (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-4804:
---

Priority: Minor  (was: Major)

Minor issue

> Update Company Contact Infromrtion Fails
> 
>
> Key: OFBIZ-4804
> URL: https://issues.apache.org/jira/browse/OFBIZ-4804
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Tom Burns
>Priority: Minor
> Attachments: OFBIZ-4804 DemoFinAcctData.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (OFBIZ-4792) Add a yui-compressor-ant-task

2012-04-08 Thread Jacques Le Roux (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-4792:
---

Description: 
The idea is to create an ant task which uses 
[YUICompressor|http://developer.yahoo.com/yui/compressor/] to dynamically 
minify our own (or custom for users) js and css files (most of the bigest 
external ones are already compressed)


  was:
The idea is to create an ant task using 
[yui-compressor-ant-task|http://code.google.com/p/yui-compressor-ant-task/] to 
dynamically minify our own (or custom for users) js and css files (most of the 
bigest external ones are already compressed)



Changes description to refer to http://developer.yahoo.com/yui/compressor/ 
directly rather

> Add a yui-compressor-ant-task
> -
>
> Key: OFBIZ-4792
> URL: https://issues.apache.org/jira/browse/OFBIZ-4792
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: SVN trunk
> Environment: Windows/Linux
>Reporter: Mandeep Sidhu
>Priority: Trivial
>  Labels: build, compression, css, features, javascript
> Fix For: SVN trunk
>
>
> The idea is to create an ant task which uses 
> [YUICompressor|http://developer.yahoo.com/yui/compressor/] to dynamically 
> minify our own (or custom for users) js and css files (most of the bigest 
> external ones are already compressed)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (OFBIZ-4792) Add a yui-compressor-ant-task

2012-04-08 Thread Jacques Le Roux (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-4792:
---

Description: 
The idea is to create an ant task using 
[yui-compressor-ant-task|http://code.google.com/p/yui-compressor-ant-task/] to 
dynamically minify our own (or custom for users) js and css files (most of the 
bigest external ones are already compressed)


  was:


The idea is to create an ant task using 
[yui-compressor-ant-task|http://code.google.com/p/yui-compressor-ant-task/]to 
dynamically compress our own js and css files (most of the bigest external ones 
are already compressed)



Fixes typos in description

> Add a yui-compressor-ant-task
> -
>
> Key: OFBIZ-4792
> URL: https://issues.apache.org/jira/browse/OFBIZ-4792
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: SVN trunk
> Environment: Windows/Linux
>Reporter: Mandeep Sidhu
>Priority: Trivial
>  Labels: build, compression, css, features, javascript
> Fix For: SVN trunk
>
>
> The idea is to create an ant task using 
> [yui-compressor-ant-task|http://code.google.com/p/yui-compressor-ant-task/] 
> to dynamically minify our own (or custom for users) js and css files (most of 
> the bigest external ones are already compressed)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (OFBIZ-4792) Add a yui-compressor-ant-task

2012-04-08 Thread Jacques Le Roux (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-4792:
---

   Component/s: (was: ALL APPLICATIONS)
(was: specialpurpose/ecommerce)
framework
   Description: 


The idea is to create an ant task using 
[yui-compressor-ant-task|http://code.google.com/p/yui-compressor-ant-task/]to 
dynamically compress our own js and css files (most of the bigest external ones 
are already compressed)


  was:
I was wondering if it is possible to reduce the size of external 
javascript's/css files being fetched by making use of GZip encoding.

The feeding server does understand and responds to GZip encoding, however Ofbiz 
is not requesting the content in GZip format.

Kindly include this feature so that Ofbiz will include the GZip encoding option 
in the http header while requesting the external javascript file ?

Also, if possible integrate the compressor module 
http://code.google.com/p/yui-compressor-ant-task/
as suggested by Jacques (Jacques Le Roux jacques.le.roux)

Labels: build compression css features javascript  (was: build 
compression features javascript)
Remaining Estimate: (was: 72h)
 Original Estimate: (was: 72h)
   Summary: Add a yui-compressor-ant-task  (was: Using GZip 
compression for js/css files)

I changed the description and removed the estimate

> Add a yui-compressor-ant-task
> -
>
> Key: OFBIZ-4792
> URL: https://issues.apache.org/jira/browse/OFBIZ-4792
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: SVN trunk
> Environment: Windows/Linux
>Reporter: Mandeep Sidhu
>Priority: Trivial
>  Labels: build, compression, css, features, javascript
> Fix For: SVN trunk
>
>
> The idea is to create an ant task using 
> [yui-compressor-ant-task|http://code.google.com/p/yui-compressor-ant-task/]to 
> dynamically compress our own js and css files (most of the bigest external 
> ones are already compressed)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (OFBIZ-4792) Using GZip compression for js/css files

2012-04-08 Thread Jacques Le Roux (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-4792:
---

 Priority: Trivial  (was: Major)
Affects Version/s: (was: Release Branch 11.04)
   SVN trunk
Fix Version/s: (was: Release Branch 11.04)
   SVN trunk

We commit only bug fixes in releases

> Using GZip compression for js/css files
> ---
>
> Key: OFBIZ-4792
> URL: https://issues.apache.org/jira/browse/OFBIZ-4792
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL APPLICATIONS, specialpurpose/ecommerce
>Affects Versions: SVN trunk
> Environment: Windows/Linux
>Reporter: Mandeep Sidhu
>Priority: Trivial
>  Labels: build, features, javascript
> Fix For: SVN trunk
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> I was wondering if it is possible to reduce the size of external 
> javascript's/css files being fetched by making use of GZip encoding.
> The feeding server does understand and responds to GZip encoding, however 
> Ofbiz is not requesting the content in GZip format.
> Kindly include this feature so that Ofbiz will include the GZip encoding 
> option in the http header while requesting the external javascript file ?
> Also, if possible integrate the compressor module 
> http://code.google.com/p/yui-compressor-ant-task/
> as suggested by Jacques (Jacques Le Roux jacques.le.roux)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (OFBIZ-4592) Try to see if we can integrate Commons-dbcp-jmx tool to monitor DBCP connections with JMX+JConsole

2012-04-06 Thread Jacques Le Roux (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-4592:
---

Attachment: OFBIZ-4592-Add-Commons-DBCP-JMX-Tool.svn.patch

A non related change had slipped in previous patch

> Try to see if we can integrate Commons-dbcp-jmx tool to monitor DBCP 
> connections with JMX+JConsole
> --
>
> Key: OFBIZ-4592
> URL: https://issues.apache.org/jira/browse/OFBIZ-4592
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: SVN trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
>  Labels: DBCP, JConsole, JMX, monitor
> Attachments: OFBIZ-4592-Add-Commons-DBCP-JMX-Tool.svn.patch, 
> OFBIZ-4592-Add-Commons-DBCP-JMX-Tool.svn.patch, 
> OFBIZ-4592-add-username-and-uri.patch
>
>
> See [Mbean wrappers around Apache Commons DBCP 
> datasources.|https://github.com/nicoulaj/commons-dbcp-jmx#readme]

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (OFBIZ-4592) Try to see if we can integrate Commons-dbcp-jmx tool to monitor DBCP connections with JMX+JConsole

2012-04-06 Thread Jacques Le Roux (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-4592:
---

Attachment: (was: OFBIZ-4592-Add-Commons-DBCP-JMX-Tool.svn.patch)

> Try to see if we can integrate Commons-dbcp-jmx tool to monitor DBCP 
> connections with JMX+JConsole
> --
>
> Key: OFBIZ-4592
> URL: https://issues.apache.org/jira/browse/OFBIZ-4592
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: SVN trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
>  Labels: DBCP, JConsole, JMX, monitor
> Attachments: OFBIZ-4592-Add-Commons-DBCP-JMX-Tool.svn.patch, 
> OFBIZ-4592-add-username-and-uri.patch
>
>
> See [Mbean wrappers around Apache Commons DBCP 
> datasources.|https://github.com/nicoulaj/commons-dbcp-jmx#readme]

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (OFBIZ-4592) Try to see if we can integrate Commons-dbcp-jmx tool to monitor DBCP connections with JMX+JConsole

2012-04-06 Thread Jacques Le Roux (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-4592:
---

Attachment: OFBIZ-4592-Add-Commons-DBCP-JMX-Tool.svn.patch

Hi Markus,

I had a quick look. It misses this imports

import org.weakref.jmx.MBeanExporter;
import org.weakref.jmx.Managed;

I looked into the zip of https://github.com/nicoulaj/commons-dbcp-jmx and gave 
up. Here is attach an upated patch

Anyway, I think I will more focus on bug fixes for a while...To be continued...

Thanks for you effort!

> Try to see if we can integrate Commons-dbcp-jmx tool to monitor DBCP 
> connections with JMX+JConsole
> --
>
> Key: OFBIZ-4592
> URL: https://issues.apache.org/jira/browse/OFBIZ-4592
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: SVN trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
>  Labels: DBCP, JConsole, JMX, monitor
> Attachments: OFBIZ-4592-Add-Commons-DBCP-JMX-Tool.svn.patch, 
> OFBIZ-4592-Add-Commons-DBCP-JMX-Tool.svn.patch, 
> OFBIZ-4592-add-username-and-uri.patch
>
>
> See [Mbean wrappers around Apache Commons DBCP 
> datasources.|https://github.com/nicoulaj/commons-dbcp-jmx#readme]

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (OFBIZ-4765) Allows a build.xml file in hot-deploy folder to build components in a specific order

2012-04-02 Thread Jacques Le Roux (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-4765:
---

  Assignee: Jacques Le Roux
Issue Type: Improvement  (was: Wish)
   Summary: Allows a build.xml file in hot-deploy folder to build 
components in a specific order  (was: build.xml in hot-deploy folder is not 
called correctly in the main build.xml)

Changed the title to better reflect the improvment

> Allows a build.xml file in hot-deploy folder to build components in a 
> specific order
> 
>
> Key: OFBIZ-4765
> URL: https://issues.apache.org/jira/browse/OFBIZ-4765
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: SVN trunk
>Reporter: Markus M. May
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4765-fix-buildxml.patch, 
> OFBIZ-4765-use-hotdeploy-buildxml-if-available-2.patch, 
> OFBIZ-4765-use-hotdeploy-buildxml-if-available.patch
>
>
> In the current build.xml in the ofbiz-Home-folder, the build target is 
> executed for each subdirectory (framework, application, specialpurpose) with 
> the fileset: 
> 
> Only for the hot-deploy folder the fileset is quite different:
> 
>
>
> 
> This is calling the build.xml directly in the hot-deploy components, which is 
> an error, if you do have several dependent components in there, which needs 
> to get build in the right order. I propose to use the following filelist:
> 
> Problem could be, that not every project do have an build.xml file in this 
> folder (or is this already a requirement?). If it is not then we would need 
> to check, if this build.xml is there, then execute this, and otherwise use 
> the already existing one.
> A patch will be applied for the first solution.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (OFBIZ-4764) Add German PostalAddress Templates

2012-03-28 Thread Jacques Le Roux (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-4764:
---

Description: Now that [OFBIZ-4715] is closed, I would like to add some 
templates for the usage in Germany.  (was: Now that [#OFBIZ-4715] is closed, I 
would like to add some templates for the usage in Germany.)
   Assignee: (was: Jacopo Cappellato)

I removed the # in [#OFBIZ-4715]. Markus, in Jira, if you put a # there, the 
issue will refer to itself

> Add German PostalAddress Templates
> --
>
> Key: OFBIZ-4764
> URL: https://issues.apache.org/jira/browse/OFBIZ-4764
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: SVN trunk
>Reporter: Markus M. May
>Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4764-add-german-postaladdress-templates.patch
>
>
> Now that [OFBIZ-4715] is closed, I would like to add some templates for the 
> usage in Germany.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (OFBIZ-528) Upgrade Beanshell library to version 2.0b4

2012-03-25 Thread Jacques Le Roux (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-528:
--

Description: 
As discussed recently on ofbiz-users mailing list, I proposed to upgrade the 
Beanshell jar used by OFBiz (framework/base/lib/scripting/bsh.jar), which is 
based on a 1.3a1, to the current "stable" version, 2.0b4.

This has the following advantages:
 - JDK1.5 interpretation capability
 - various bugfixes

However as explained by David E. Jones here:
https://cwiki.apache.org/confluence/display/OFBTECH/OFBiz+Customized+BeanShell+Source+(with+ParsedScript+object)

...it will be necessary to patch the source to allow for the script parsing on 
which OFBiz depends.

This fix MAY also resolve this bug:
https://issues.apache.org/jira/browse/OFBIZ-303

  was:
As discussed recently on ofbiz-users mailing list, I proposed to upgrade the 
Beanshell jar used by OFBiz (framework/base/lib/scripting/bsh.jar), which is 
based on a 1.3a1, to the current "stable" version, 2.0b4.

This has the following advantages:
 - JDK1.5 interpretation capability
 - various bugfixes

However as explained by David E. Jones here:
http://docs.ofbiz.org/display/OFBTECH/OFBiz+Customized+BeanShell+Source+%28with+ParsedScript+object%29

...it will be necessary to patch the source to allow for the script parsing on 
which OFBiz depends.

This fix MAY also resolve this bug:
https://issues.apache.org/jira/browse/OFBIZ-303


Updated the link to <> in wiki


> Upgrade Beanshell library to version 2.0b4
> --
>
> Key: OFBIZ-528
> URL: https://issues.apache.org/jira/browse/OFBIZ-528
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: SVN trunk
> Environment: Windows XP, MySQL 5.0, JDK1.5, ofbiz_opentaps_473442
>Reporter: Cameron Smith
>Assignee: David E. Jones
> Fix For: SVN trunk
>
> Attachments: BshClassManager.java, Interpreter.java, 
> ParsedScriptObjectExtension.patch, viewprofile.bsh
>
>
> As discussed recently on ofbiz-users mailing list, I proposed to upgrade the 
> Beanshell jar used by OFBiz (framework/base/lib/scripting/bsh.jar), which is 
> based on a 1.3a1, to the current "stable" version, 2.0b4.
> This has the following advantages:
>  - JDK1.5 interpretation capability
>  - various bugfixes
> However as explained by David E. Jones here:
> https://cwiki.apache.org/confluence/display/OFBTECH/OFBiz+Customized+BeanShell+Source+(with+ParsedScript+object)
> ...it will be necessary to patch the source to allow for the script parsing 
> on which OFBiz depends.
> This fix MAY also resolve this bug:
> https://issues.apache.org/jira/browse/OFBIZ-303

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (OFBIZ-4723) Support validation of resource xml files

2012-03-24 Thread Jacques Le Roux (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-4723:
---

Attachment: OFBIZ-4723_both.patch

I attach both patches in one when applied to trunk HEAD (r1304738)


> Support validation of resource xml files
> 
>
> Key: OFBIZ-4723
> URL: https://issues.apache.org/jira/browse/OFBIZ-4723
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: SVN trunk
> Environment: REV 1297286
>Reporter: Anne Jessel
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4723_both.patch, OFBIZ-4723_code_cleanups.patch, 
> OFBIZ-4723_support-validation-resource-xml.patch
>
>
> The xsd for the resource xml files is invalid. In addition, the format of the 
> value of the xml:lang attribute in resource xml files is invalid, according 
> to the xml standard.
> The attached patch:
> * provides a valid xsd
> * updates UtilProperties and the Label Manager to deal with the correct 
> formatting of the xml:lang value, while still working with the old format, 
> following Adrian Crum's recommendation on the mailing list
> * includes simple unit tests for UtilProperties to ensure it does work with 
> both formats
> * changes the Label Manager to include a reference to the new xsd, and to use 
> the correct format of the xml:lang value, when writing a resource xml file.
> This problem exists in released versions, but I doubt it is important enough 
> to back port.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (OFBIZ-4627) contribute Ofbiz Vietnamese tranlasting to community from HaNoi

2012-03-22 Thread Jacques Le Roux (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-4627:
---

Attachment: OFBIZ-427_VietnameseUiLabels.patch

> contribute Ofbiz Vietnamese tranlasting to community from HaNoi
> ---
>
> Key: OFBIZ-4627
> URL: https://issues.apache.org/jira/browse/OFBIZ-4627
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: SVN trunk
>Reporter: Tri Duc Vo
>Assignee: Jacques Le Roux
>  Labels: features
> Fix For: SVN trunk
>
> Attachments: CommonUiLabels.xml.patch, CommonUiLabels.xml.patch, 
> CommonUiLabels.xml.patch, CommonUiLabels.xml.patch, EcommerceUiLabels.xml, 
> EcommerceUiLabels.xml.patch, EcommerceUiLabels.xml.patch, 
> EcommerceUiLabels.xml.patch, EcommerceUiLabels.xml.patch, 
> MarketingUiLabels.xml.patch, MarketingUiLabels.xml.patch, 
> MarketingUiLabels.xml.patch, MarketingUiLabels.xml.patch, 
> OFBIZ-427_VietnameseCommonUiLabels.patch, 
> OFBIZ-427_VietnameseEcommerceUiLabels.patch, 
> OFBIZ-427_VietnameseMarketingUiLabels.patch, 
> OFBIZ-427_VietnameseOrderEntityLabels.patch, 
> OFBIZ-427_VietnameseOrderUiLabels.patch, 
> OFBIZ-427_VietnameseProductEntityLabels.patch, 
> OFBIZ-427_VietnameseProductUiLabels.patch, 
> OFBIZ-427_VietnameseUiLabels.patch, OrderEntityLabels.xml.patch, 
> OrderEntityLabels.xml.patch, OrderEntityLabels.xml.patch, 
> OrderEntityLabels.xml.patch, OrderUiLabels.xml.patch, 
> OrderUiLabels.xml.patch, OrderUiLabels.xml.patch, OrderUiLabels.xml.patch, 
> ProductEntityLabels.xml.patch, ProductEntityLabels.xml.patch, 
> ProductEntityLabels.xml.patch, ProductEntityLabels.xml.patch, 
> ProductUiLabels.xml, ProductUiLabels.xml.patch, ProductUiLabels.xml.patch, 
> ProductUiLabels.xml.patch, ProductUiLabels.xml.patch
>
>   Original Estimate: 1,344h
>  Remaining Estimate: 1,344h
>
>Dear Ofbiz community
>I'm Tri, from HaNoi, VietNam, and now our team build ERP based on Ofbiz 
> opensource. 
>Now we're completed translating 80% Ecommerce , 50% Catalog of Ofbiz. And 
> we're going to complete 100% Vietnamese Ofbiz tranlasting and contribute them 
> to community.
>We'll attach files soon
>Thank you

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (OFBIZ-3868) Adding de UI Lables on framework CommonUILabels

2012-02-16 Thread Jacques Le Roux (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-3868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-3868:
---

Attachment: 0001-OFBIZ-3868_UI_Labels_on_CommonUiLabels.patch

Good work Markus (but the patch format ;o)

This (new attached) patch applies but I'd like to have a review by another 
German speaking committer or contributor, because some labels are replaced and 
my German is not good enough (it's not good at all) to be able to take a 
decision by myslef

Here are the points I'm unsure about
{code}
-Forderungen
+Debitoren

-Klicken Sie hier
+Hier klicken

-Ansehen
+Suchen

-Neues Passwort (zur Überprüfung)
+Neues Passwort (Wiederholung)

-Erstellt von Benutzeranmeldung
+Erstellt von Benutzer

-Zuletzt geändert von Benutzeranmeldung
+Zuletzt geändert von Benutzer
{code}

If nobody answer, in few days I will apply as is...

> Adding de UI Lables on framework CommonUILabels
> ---
>
> Key: OFBIZ-3868
> URL: https://issues.apache.org/jira/browse/OFBIZ-3868
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: SVN trunk
> Environment: irrelevant; XML config data
>Reporter: Carsten Schinzer
>Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: 0001-OFBIZ-3868_UI_Labels_on_CommonUiLabels.patch, 
> 0001-OFBIZ-3868_UI_Labels_on_CommonUiLabels.patch, OFBIZ-3868_Adding de UI 
> Lables on framework CommonUILabels.patch, OFBIZ-3868_Adding de UI Lables on 
> framework CommonUILabels.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> All missing de UI labels have been added in the CommonUiLables.xml file.
> Note: This patch also includes the UI Labels required for JIRA issue 
> OFBIZ-3844 (i.e. replacing the OFBIZ-3844_Splitting CommonRate and 
> CommonProductRating_part2.patch which has now been removed from OFBIY-3844.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (OFBIZ-4700) Add german translation to TemporalExpressionUiLabels.xml

2012-02-16 Thread Jacques Le Roux (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-4700:
---

Attachment: OFBIZ-4700 german translation TemporalExpression.patch

Correct patch to apply (with some Fuzz)

> Add german translation to TemporalExpressionUiLabels.xml
> 
>
> Key: OFBIZ-4700
> URL: https://issues.apache.org/jira/browse/OFBIZ-4700
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: SVN trunk
>Reporter: Markus M. May
>Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: 0001-Add-de-locale.svn.patch, OFBIZ-4700 german 
> translation TemporalExpression.patch
>
>
> Add a patch for the german language for the TemporalExpressionUiLabels.xml

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (OFBIZ-4580) Categories - calculated trails

2012-01-22 Thread Jacques Le Roux (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-4580:
---

Attachment: OFBIZ-4580-CategoryWorker-with-trail-export.patch

Hi Paul,

I think it's an interesting feature.

For now, just for the sake of the form (did not review complaty functional 
aspects yet) and in order of importance:

# +ServiceUtil.isError(results);
+ServiceUtil.isError(results);
are not supposed to be used like that. See comment there /** A little short-cut 
method to check to see if a service returned an error */
I guess you wanted to use rather 
ServiceUtil.returnSuccess();
return ServiceUtil.returnError(e.toString());
See new attached patch for more changes on this point (notably how to better 
log/return error in service, BTW doing this I found that the 
CommonDatabaseProblem label was missing an ${errMessage} parameter)
# duplicated Java doc with 2 tabs just before
# wrong formatting (tab related I guess)
+if (trailElements.contains(trailCategoryId)) {
+break;
+}else{
+trailElements.add(trailCategoryId);
+}
# (revision 3173): this might work but not always, notably if you have others 
changes in your working copy. To avoid this be sure to use a 
fresh-checkout/updated working copy of Apache OFBiz trunk (or release) when 
creating your patch, else committers might cross issues with your patches.
** create a patch from your custom working copy (like you did)
** apply it on a fresh-checkout/updated working copy of Apache OFBiz trunk. If 
it works contribute, else create a patch to contribute from there...

This said, thanks for your contribution, I will review later before 
committing... 
PS: Note that the right way to name a patch is to prefix it by the Jira issue. 
This is helpful for committers who have several patches pending, waiting to be 
committed

> Categories - calculated trails
> --
>
> Key: OFBIZ-4580
> URL: https://issues.apache.org/jira/browse/OFBIZ-4580
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Paul Piper
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: CategoryWorker-with-trail-export.patch, 
> CategoryWorker.patch, OFBIZ-4580-CategoryWorker-with-trail-export.patch
>
>
> Hey folks,
> been a while since I contributed. I noticed that currently ofbiz misses a 
> simple function to generate a category trail. Generating a trail, however, is 
> often useful when generating breadcrums, facetted search results, and proper 
> category trees in general. Hence I created the following as a timesaver:
> {code:title=getCategoryTrail|borderStyle=solid}
> public static  List getCategoryTrail(String productCategoryId,DispatchContext 
> dctx){
>   GenericDelegator delegator = (GenericDelegator) 
> dctx.getDelegator();
>   List trailElements = FastList.newInstance();
> trailElements.add(productCategoryId);
> String parentProductCategoryId = productCategoryId;
> while (UtilValidate.isNotEmpty(parentProductCategoryId)) {
> // find product category rollup
> try {
> List rolllupConds = FastList.newInstance();
> 
> rolllupConds.add(EntityCondition.makeCondition("productCategoryId", 
> parentProductCategoryId));
> rolllupConds.add(EntityUtil.getFilterByDateExpr());
> List productCategoryRollups = 
> delegator.findList("ProductCategoryRollup", 
> EntityCondition.makeCondition(rolllupConds), null, 
> UtilMisc.toList("-fromDate"), null, true);
> if (UtilValidate.isNotEmpty(productCategoryRollups)) {
> // add only categories that belong to the top category to 
> trail
> for (GenericValue productCategoryRollup : 
> productCategoryRollups) {
> String trailCategoryId = 
> productCategoryRollup.getString("parentProductCategoryId");
> parentProductCategoryId = trailCategoryId;
> if (trailElements.contains(trailCategoryId)) {
> break;
> }else{
>   trailElements.add(trailCategoryId);
> }
> }
> } else {
> parentProductCategoryId = null;
> }
> } catch (GenericEntityException e) {
> Debug.logError(e, "Cannot generate trail from product 
> category", module);
> }
> }
> Collections.reverse(trailElements);
> return trailElements;
>   }
> {code}
> I suggest to add this to the CategoryWorker.java

-

[jira] [Updated] (OFBIZ-4663) ERROR in log file when starting OFBiz, debug-xa-resources is commented in entityengine.xml

2012-01-19 Thread Jacques Le Roux (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-4663:
---

Attachment: OFBIZ-4663-debug-xa-resources is commented in 
entityengine.xml.patch

This fix the issue, but not sure why, Oxygen complains after it in 
entityengine.xml

I tried to change the xsd definition, using same than for connection-factory, 
noways

Help appreciated, else I will review later

> ERROR in log file when starting OFBiz, debug-xa-resources is commented in 
> entityengine.xml
> --
>
> Key: OFBIZ-4663
> URL: https://issues.apache.org/jira/browse/OFBIZ-4663
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: SVN trunk
>Reporter: Erwan de FERRIERES
>Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4663-debug-xa-resources is commented in 
> entityengine.xml.patch
>
>
> 3229 [main] INFO org.ofbiz.base.container.ClassLoaderContainer - 
> CachedClassLoader created
> 3466 [main] INFO org.ofbiz.entity.DelegatorFactoryImpl - Creating new 
> delegator [default] (main)
> 3530 [main] ERROR org.ofbiz.base.util.UtilXml - XmlFileLoader: File 
> file:/home/erwan/workspace/Apache_OFBiz/ofbiz/framework/entity/config/entityengine.xml
>  process error. Line: 53. Error message: cvc-complex-type.2.4.a: Invalid 
> content was found starting with element 'delegator'. One of 
> '{debug-xa-resources}' is expected.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (OFBIZ-4665) cardType is not prepopulated on checkout page

2012-01-17 Thread Jacques Le Roux (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-4665:
---

Fix Version/s: Release Branch 09.04

While at it, also merged in R9.04 revision: 1232542  


> cardType is not prepopulated on checkout page
> -
>
> Key: OFBIZ-4665
> URL: https://issues.apache.org/jira/browse/OFBIZ-4665
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 11.04, SVN trunk
>Reporter: Kiran Gawde
>Assignee: Jacques Le Roux
> Fix For: Release Branch 09.04, Release Branch 10.04, Release 
> Branch 11.04, SVN trunk
>
> Attachments: OFBIZ-4665-EditBillingAddressGroovy.patch
>
>
> On Checkout page, credit card information is prepopulated based upon earlier 
> order. But the card Type shows always the first type in the list.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (OFBIZ-3913) Automated action triggered by event

2011-12-18 Thread Jacques Le Roux (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-3913:
---

Attachment: What I did with PDFCreator.jpg

What I did with PDFCreator

> Automated action triggered by event
> ---
>
> Key: OFBIZ-3913
> URL: https://issues.apache.org/jira/browse/OFBIZ-3913
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: SVN trunk
>Reporter: Nicolas Malin
>Assignee: Jacques Le Roux
> Attachments: ExternalDevice.patch, ExternalDevice.patch, 
> ExternalDevice.patch, ExternalDevice.png, OFBIZ-3913.ogv, OFBIZ-3913.patch, 
> OFBIZ-3913.patch, PDFCreator.png, What I did with PDFCreator.jpg
>
>
> Following a thread on the dev list, related to a printer automated selection, 
> by an user and an event, here is a first draft.
> I added a new entity, ExternalDevice, which list all devices OFBiz can reach 
> (and the associated command). This entity is related to an ExternalDeviceType 
> and each record has a status, so we know if the device is available, out of 
> order, in maintenance, waiting, etc...
> Then I added another entity, ExternalDeviceUserAction, which defines a device 
> for an user, and/or an action through Enumeration. Finally, I added a service 
> which find the commnand to execute based on an action and/or an user.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (OFBIZ-3913) Automated action triggered by event

2011-12-18 Thread Jacques Le Roux (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-3913:
---

Attachment: PDFCreator.png

Thanks for your effort Nicolas,

I applied your patch (still a necessary 5 fuzz - I guess changes in trunk from 
your submission - and UTF8+BOM change - I guess it's due to my XP platform -, 
anyway forget these trivial issues ;o) and followed your video. I used 
PDFCreator name where you used PDF (see screen copy). But maybe as I'm using XP 
i don't see any SECA call of sendPrintFromScreenByUserAction in log when 
creating an example, hence no PDFCreator print, any ideas what I could do 
wrong? Or coult it be platform relate?


> Automated action triggered by event
> ---
>
> Key: OFBIZ-3913
> URL: https://issues.apache.org/jira/browse/OFBIZ-3913
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: SVN trunk
>Reporter: Nicolas Malin
>Assignee: Jacques Le Roux
> Attachments: ExternalDevice.patch, ExternalDevice.patch, 
> ExternalDevice.patch, ExternalDevice.png, OFBIZ-3913.ogv, OFBIZ-3913.patch, 
> OFBIZ-3913.patch, PDFCreator.png
>
>
> Following a thread on the dev list, related to a printer automated selection, 
> by an user and an event, here is a first draft.
> I added a new entity, ExternalDevice, which list all devices OFBiz can reach 
> (and the associated command). This entity is related to an ExternalDeviceType 
> and each record has a status, so we know if the device is available, out of 
> order, in maintenance, waiting, etc...
> Then I added another entity, ExternalDeviceUserAction, which defines a device 
> for an user, and/or an action through Enumeration. Finally, I added a service 
> which find the commnand to execute based on an action and/or an user.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (OFBIZ-4623) layout for image management does not work under Flat Grey visual theme

2011-12-17 Thread Jacques Le Roux (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-4623:
---

  Priority: Trivial  (was: Major)
Issue Type: Improvement  (was: Bug)

> layout for image management does not work under Flat Grey visual theme
> --
>
> Key: OFBIZ-4623
> URL: https://issues.apache.org/jira/browse/OFBIZ-4623
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: SVN trunk
>Reporter: Wai
>Priority: Trivial
>
> Image management screens do not look correct when using Flatgrey visual theme.
> https://demo-trunk.ofbiz.apache.org:8443/catalog/control/Imagemanagement

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (OFBIZ-4625) Project, Phase, Task actualsHours, plannedHours is wrong in some case after last modification done on ProjectServices.xml

2011-12-15 Thread Jacques Le Roux (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-4625:
---

Description: 
Last modification on ProjectServices.xml has been done by OFBIZ-4584, it was 
script optimization done by replacing multiple database request and iterate by 
request on view to obtain directly the result.

These optimizations are very efficient, but in some case result are wrong.

Correction are on 
1)view definition, 
2)plannedHours retreiving separation from  start and end date retreiving 
3)clear-field at the beginning of process.

these corrections have been tested on production sites with large project. 

  was:
Last modification on ProjectServices.xml has been done by JIRA-4584, it was 
script optimization done by replacing multiple database request and iterate by 
request on view to obtain directly the result.

These optimizations are very efficient, but in some case result are wrong.

Correction are on 
1)view definition, 
2)plannedHours retreiving separation from  start and end date retreiving 
3)clear-field at the beginning of process.

these corrections have been tested on production sites with large project. 


> Project, Phase, Task actualsHours, plannedHours is wrong in some case after 
> last modification done on ProjectServices.xml
> -
>
> Key: OFBIZ-4625
> URL: https://issues.apache.org/jira/browse/OFBIZ-4625
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/projectmgr
>Affects Versions: SVN trunk
>Reporter: Olivier Heintz
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4625.patch
>
>
> Last modification on ProjectServices.xml has been done by OFBIZ-4584, it was 
> script optimization done by replacing multiple database request and iterate 
> by request on view to obtain directly the result.
> These optimizations are very efficient, but in some case result are wrong.
> Correction are on 
> 1)view definition, 
> 2)plannedHours retreiving separation from  start and end date retreiving 
> 3)clear-field at the beginning of process.
> these corrections have been tested on production sites with large project. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (OFBIZ-4620) fail uploading audio/video files to database

2011-12-14 Thread Jacques Le Roux (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-4620:
---

Fix Version/s: SVN trunk
   Release Branch 11.04

> fail uploading audio/video files to database
> 
>
> Key: OFBIZ-4620
> URL: https://issues.apache.org/jira/browse/OFBIZ-4620
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: SVN trunk
>Reporter: Wai
>Assignee: Jacques Le Roux
> Fix For: Release Branch 11.04, SVN trunk
>
> Attachments: OFBIZ-4620.patch
>
>
> When uploading binary files (eg. image/audio/video) to the database, ofbiz 
> throws a type casting exception because it is trying to type cast 
> HeapByteBuffer to byte[].
> I think the problem stems from configuring ofbiz to use java.nio.ByteBuffer 
> and its subclass java.nio.HeapByteBuffer to contain uploaded binary data but 
> no accommodation is made in the code to work with this type of object.
> To test this, you need to set 
> content.properties/content.upload.always.local.file=false
> use 
> https://http://demo-trunk.ofbiz.apache.org/partymgr/control/viewprofile?partyId=Company
>  and upload an image file.
> java.nio.HeapByteBuffer comes from java's rt.jar (make sure your classpath 
> includes this)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (OFBIZ-4585) Cannot save scrum preferences

2011-11-22 Thread Jacques Le Roux (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-4585:
---

  Component/s: specialpurpose/scrum
Affects Version/s: SVN trunk

Put component and affected release

> Cannot save scrum preferences
> -
>
> Key: OFBIZ-4585
> URL: https://issues.apache.org/jira/browse/OFBIZ-4585
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/scrum
>Affects Versions: SVN trunk
>Reporter: Wai
>
> https://demo-trunk.ofbiz.apache.org:8443/scrum/control/Preferences
> Logged in as "admin".
> The preferences shown on this page cannot be saved.  The submit button is not 
> available.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (OFBIZ-4393) View entity condition-expr doesn't handle null

2011-11-11 Thread Jacques Le Roux (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-4393:
---

Affects Version/s: Release Branch 11.04
   Release Branch 10.04

>From Deepak's remark
{quote}
This is a bug, so this should be go in branches as well(10.04 and 11.04).
I have tested it for release10.04 (did manual merge) and it works fine.
{quote}

I have added the releases, I can backport if necessary



> View entity condition-expr doesn't handle null
> --
>
> Key: OFBIZ-4393
> URL: https://issues.apache.org/jira/browse/OFBIZ-4393
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Release Branch 10.04, Release Branch 11.04, SVN trunk
> Environment: Rev 1165137
>Reporter: Anne Jessel
>Assignee: Adrian Crum
> Attachments: OFBIZ-4393-view-entity_condition-expr_null.patch, 
> OFBIZ-4393-view-entity_condition-expr_null.patch, 
> OFBIZ-4393-view-entity_condition-expr_null.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> condition-expr tag in view-entity can't be used to compare a field with null. 
> An absent value attribute is read as an empty string, and the code currently 
> checks for value being null to know when to compare against null.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (OFBIZ-2813) ProductStore did not allow the default timezone to be set

2011-11-06 Thread Jacques Le Roux (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-2813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-2813:
---

Attachment: OFBIZ-2813.patch

Here is attachec an updated and amended version of the patch.

 I have removed the
__
line in _applications/product/webapp/catalog/store/ProductStoreForms.xml_ which 
I have renamed _applications/product/widget/catalog/ProductStoreForms.xml_ (it 
has certainly moved did not check anyway it works then)

I think we should take into account Adrian's remark in getTimeZone (at the end 
use ofbiz.timeZone.default if it exist)

> ProductStore did not allow the default timezone to be set
> -
>
> Key: OFBIZ-2813
> URL: https://issues.apache.org/jira/browse/OFBIZ-2813
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: SVN trunk
>Reporter: Bob Morley
>Priority: Minor
> Attachments: OFBIZ-2813.patch, OFBIZ-2813.patch
>
>
> The ProductStore has the defaultLocaleString and the defaultCurrencyUomId but 
> does not have a defaultTimeZoneString.  What happens when a store is selected 
> (from e-commerce or the pos) is that it will look to the user for a 
> lastTimeZone and if that is not set, it would simply revert to the 
> TimeZone.getDefault() (so the timezone based on the server).
> The trouble we had was that you may have an application server that is 
> running in a completely different timezone than what is desired for the store.
> I will be attaching a patch to this ticket with changes related to this 
> improvement.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (OFBIZ-4498) Store Facility tab is messed up in admin console

2011-10-23 Thread Jacques Le Roux (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-4498:
---

Comment: was deleted

(was: BTW I found another (not related) bug 
http://markmail.org/message/ac26ylhecxuv7kqu)

> Store Facility tab is messed up in admin console
> 
>
> Key: OFBIZ-4498
> URL: https://issues.apache.org/jira/browse/OFBIZ-4498
> Project: OFBiz
>  Issue Type: Bug
>  Components: product, specialpurpose/ecommerce
>Affects Versions: Release Branch 11.04, SVN trunk
>Reporter: Kiran Gawde
>Priority: Minor
> Attachments: OFBIZ-4498-ProductStoreFacilities.png
>
>
> In admin console, 
> select store
> Click on facility tab.
> You will see entire admin console again. Seems like wrong decorator is used.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (OFBIZ-904) Error when "Inventory Facility Id" is left blank in product store settings

2011-10-16 Thread Jacques Le Roux (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-904:
--

  Priority: Major  (was: Minor)
Issue Type: Bug  (was: Improvement)

Done as Kiran asked

> Error when "Inventory Facility Id" is left blank in product store settings
> --
>
> Key: OFBIZ-904
> URL: https://issues.apache.org/jira/browse/OFBIZ-904
> Project: OFBiz
>  Issue Type: Bug
>  Components: product, specialpurpose/ecommerce
> Environment: OFBiz Rev. 529997 on Windows XP.
>Reporter: Michel Dielissen
>
> When creating a new store and the "Inventory Facility Id" field is left blank 
> (with the store settings) then the productlist (Browse categories in the 
> e-commerce store) gives an error and is not rendered.
> Error:
> 2007-04-19 10:13:16,515 (http-0.0.0.0-8080-Processor3) [
> ModelScreen.java:148:ERROR] Error rendering screen 
> [component://ecommerce/widget/CatalogScreens.xml#productsummary]: 
> org.ofbiz.base.util.GeneralException: Error running BSH script at location 
> [component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh]:
>  org.ofbiz.base.util.GeneralException: Error running BSH script at 
> [component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh],
>  line [65]: Sourced file: 
> component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh
>  internal Error: Null value in getAssignableForm. : at Line: 65 : in file: 
> component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh
>  : if ( product != null ) {
>  (Sourced file: 
> component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh
>  internal Error: Null value in getAssignableForm.) (Error running BSH script 
> at 
> [component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh],
>  line [65]: Sourced file: 
> component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh
>  internal Error: Null value in getAssignableForm. : at Line: 65 : in file: 
> component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh
>  : if ( product != null ) {
>  (Sourced file: 
> component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh
>  internal Error: Null value in getAssignableForm.)). Rolling back transaction.
> Think it has something todo with:
> file:/D:/ofbiz/applications/product/script/org/ofbiz/product/inventory/InventoryServices.xml
> 2007-04-19 10:12:27,843 (http-0.0.0.0-8080-Processor3) [  
> ServiceDispatcher.java:459:DEBUG] Sync service 
> [ecommerce/getInventoryAvailableByFacility]
> So maybe the "Inventory Facility Id" field has to be a required field? Or 
> maybe better to run the "getInventoryAvailableByFacility" only when an 
> Inventory Facility is filled with the store settings?
> Comment Jacopo: this should be improved; for example the facility in the 
> store should be mandatory if the requireInventory flag is set.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (OFBIZ-4386) Order not completed when filled from more than one InventoryItem

2011-10-13 Thread Jacques Le Roux (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-4386:
---

Attachment: OFBIZ-4386_IssuanceServices.patch

Paul,

I have reviewed your patch again.

I have changed
# 
to

there is no "inventoryItemId" value
# used "info" in all logs (as previously mentionned)
# removed trailing white spaces (not a big deal, I'm just used to)

This seems OK for with me now. Could you please double-check before I commit, 
thanks

> Order not completed when filled from more than one InventoryItem
> 
>
> Key: OFBIZ-4386
> URL: https://issues.apache.org/jira/browse/OFBIZ-4386
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: SVN trunk
> Environment: rev 1163479
>Reporter: Paul Foxworthy
>Assignee: Jacques Le Roux
>  Labels: issuance, order, shipment
> Attachments: OFBIZ-4386_IssuanceServices.patch, 
> OFBIZ-4386_IssuanceServices.patch, OFBIZ-4386_IssuanceServices.patch, 
> OFBIZ-4386_IssuanceServices.patch, OFBIZ-4386_IssuanceServices.patch, 
> OFBIZ-4386_IssuanceTests.patch
>
>
> There is a nasty bug in IssuanceServices in the situation where the order is 
> filled from more than one InventoryItem. When the order is created, there are 
> OrderItemShipGrpInvRes reservations created for all the inventory items 
> needed to fill the order.
> In the simple method issueOrderItemShipGrpInvResToShipment in 
> IssuanceServices, at line 173 
> (https://fisheye6.atlassian.com/browse/ofbiz/trunk/applications/product/script/org/ofbiz/shipment/issuance/IssuanceServices.xml?hb=true#to173),
>  there is an assumption that if the OrderShipment already exists, we are some 
> sort of adjustment, and we should adjust the OrderShipment quantity by the 
> difference between the old OrderShipment quantity and the new one. This all 
> works fine in the situation where there is only one InventoryItem needed to 
> fill the order. However, if there are two or more InventoryItems, the simple 
> method is called twice, and an incorrect quantity is calculated.
> The crux of the problem is that OrderShipment doesn't care about 
> InventoryItems, so there will be only one OrderShipment row for a given 
> product. In contrast, ItemIssuance does care about InventoryItems, so there 
> will be more than one if the product is supplied from more than one 
> InventoryItem. The ItemIssuance code doesn't take account of this distinction.
> I have provided two patches. One is a new unit test that exemplifies the bug. 
> If you just apply this patch to trunk, the unit test will fail with an 
> OrderShipment quantity of 4 when it ought to be 6.
> The other patch is my fix for IssuanceServices, which now looks for a 
> relevant ItemIssuance to decide if we are adjusting quantities, or creating a 
> new ItemIssuance (and possibly a new OrderShipment).
> Feedback welcomed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira