[jira] [Commented] (OFBIZ-7922) Pagination through marketing campains is broken
[ https://issues.apache.org/jira/browse/OFBIZ-7922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390652#comment-15390652 ] Michael Brohl commented on OFBIZ-7922: -- Should be, the patch was created on the 13.07 release branch :-) Thanks, Jacques! > Pagination through marketing campains is broken > --- > > Key: OFBIZ-7922 > URL: https://issues.apache.org/jira/browse/OFBIZ-7922 > Project: OFBiz > Issue Type: Bug > Components: marketing >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > Release Branch 15.12 >Reporter: Michael Brohl >Assignee: Jacques Le Roux > Fix For: Release Branch 13.07, Release Branch 14.12, Release > Branch 15.12 > > Attachments: MarketingCampaign.xml, OFBIZ-7922.patch > > > Go to /marketing/control/FindMarketingCampaign and select another view size > or paginate - an error occurs because the forms target is > listMarketingCampain which does not exist in the controller. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7922) Pagination through marketing campains is broken
[ https://issues.apache.org/jira/browse/OFBIZ-7922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390302#comment-15390302 ] Michael Brohl commented on OFBIZ-7922: -- Thanky for committing, Jacques! Shouldn't this go into 13.07 also? > Pagination through marketing campains is broken > --- > > Key: OFBIZ-7922 > URL: https://issues.apache.org/jira/browse/OFBIZ-7922 > Project: OFBiz > Issue Type: Bug > Components: marketing >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > Release Branch 15.12 >Reporter: Michael Brohl >Assignee: Jacques Le Roux > Fix For: Release Branch 14.12, Release Branch 15.12 > > Attachments: MarketingCampaign.xml, OFBIZ-7922.patch > > > Go to /marketing/control/FindMarketingCampaign and select another view size > or paginate - an error occurs because the forms target is > listMarketingCampain which does not exist in the controller. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7922) Pagination through marketing campains is broken
[ https://issues.apache.org/jira/browse/OFBIZ-7922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-7922: - Attachment: OFBIZ-7922.patch This is the patch for the issue. > Pagination through marketing campains is broken > --- > > Key: OFBIZ-7922 > URL: https://issues.apache.org/jira/browse/OFBIZ-7922 > Project: OFBiz > Issue Type: Bug > Components: marketing >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > Release Branch 15.12 >Reporter: Michael Brohl > Attachments: OFBIZ-7922.patch > > > Go to /marketing/control/FindMarketingCampaign and select another view size > or paginate - an error occurs because the forms target is > listMarketingCampain which does not exist in the controller. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7922) Pagination through marketing campains is broken
Michael Brohl created OFBIZ-7922: Summary: Pagination through marketing campains is broken Key: OFBIZ-7922 URL: https://issues.apache.org/jira/browse/OFBIZ-7922 Project: OFBiz Issue Type: Bug Components: marketing Affects Versions: Release Branch 15.12, Trunk, Release Branch 14.12, Release Branch 13.07 Reporter: Michael Brohl Go to /marketing/control/FindMarketingCampaign and select another view size or paginate - an error occurs because the forms target is listMarketingCampain which does not exist in the controller. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7749) iterateOverActiveComponents exists twice
[ https://issues.apache.org/jira/browse/OFBIZ-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-7749: - Priority: Minor (was: Major) > iterateOverActiveComponents exists twice > > > Key: OFBIZ-7749 > URL: https://issues.apache.org/jira/browse/OFBIZ-7749 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Minor > Labels: gradle > Attachments: OFBIZ-7749.patch > > > Currently the iterateOverActiveComponents function or tasks exists both in > build.gradle and settings.gradle. > Do we need both? Which one is superfluous? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7749) iterateOverActiveComponents exists twice
[ https://issues.apache.org/jira/browse/OFBIZ-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-7749: - Attachment: OFBIZ-7749.patch This patch introduces a new gradle file which holds the shared method iterateOverActiveComponents which is used by build.gradle and settings.gradle. Thanks Pierre for the trigger to learn some Gradle stuff :-) > iterateOverActiveComponents exists twice > > > Key: OFBIZ-7749 > URL: https://issues.apache.org/jira/browse/OFBIZ-7749 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Jacques Le Roux > Labels: gradle > Attachments: OFBIZ-7749.patch > > > Currently the iterateOverActiveComponents function or tasks exists both in > build.gradle and settings.gradle. > Do we need both? Which one is superfluous? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5840) Create bootstrap theme
[ https://issues.apache.org/jira/browse/OFBIZ-5840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15379091#comment-15379091 ] Michael Brohl commented on OFBIZ-5840: -- +1, that would be very useful. Do we need a flag or can it be organised in some kind of roadmap out of release groups or else? > Create bootstrap theme > -- > > Key: OFBIZ-5840 > URL: https://issues.apache.org/jira/browse/OFBIZ-5840 > Project: OFBiz > Issue Type: New Feature > Components: framework, themes >Affects Versions: Bootstrap theme >Reporter: Julien NICOLAS >Assignee: Jacques Le Roux > Labels: bootstrap, theme > Attachments: Facility.PNG, FindAgreement..png, Footer.jpg, > GlobalDecorator.patch, ImprovedFooter.patch, MacroMenuRenderer.patch, > OFBIZ-5840-Menufactory.patch, OFBIZ-5840-Menufactory.patch, > appbar_menu_ftl.patch, bootified.js, bootified_js_screentrans.patch, > bootstrap-theme.zip, bootstrap.zip, bootstrapThemeToTrunk.patch, > calendar.PNG, catalog.png, glyphicons-halflings-regular.zip, > htmlMenuMacroLibrary.patch, lookupField_patch.patch, > pagination_htmlFormMacroLibrary.patch, > panelCollapse_htmlSreenMacroLibrary.patch, party menu tab bar.PNG, > preferences.png, styling_issue_1.png, styling_issue_2.png, > styling_issue_3.png, styling_issue_4.png, styling_issue_5.png, > styling_issue_6.png, styling_issue_7.png, styling_issue_8.png, > styling_issue_9.png, tab-bar.png, workeffort.PNG > > > 1- create a sub-directory called bootstrap under the image webapp to put > the resources over there (js, css and fonts) as indicated earlier by Gavin. > (Julien : not sure about location) > 2- check to make sure that the current version of jQuery is compatible with > the installed version or upgrade it accordingly > 3- Create a new theme based on one of the existing themes as suggested by > Julien and Gavin > 4- Test the theme by switching to it and handle major bugs / issues. > 5- Start to make a few test screens utilizing Bootstrap -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5840) Create bootstrap theme
[ https://issues.apache.org/jira/browse/OFBIZ-5840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15379048#comment-15379048 ] Michael Brohl commented on OFBIZ-5840: -- +1 Pierre Let's take one step after the other. > Create bootstrap theme > -- > > Key: OFBIZ-5840 > URL: https://issues.apache.org/jira/browse/OFBIZ-5840 > Project: OFBiz > Issue Type: New Feature > Components: framework, themes >Affects Versions: Bootstrap theme >Reporter: Julien NICOLAS >Assignee: Jacques Le Roux > Labels: bootstrap, theme > Attachments: Facility.PNG, FindAgreement..png, Footer.jpg, > GlobalDecorator.patch, ImprovedFooter.patch, MacroMenuRenderer.patch, > OFBIZ-5840-Menufactory.patch, OFBIZ-5840-Menufactory.patch, > appbar_menu_ftl.patch, bootified.js, bootified_js_screentrans.patch, > bootstrap-theme.zip, bootstrap.zip, bootstrapThemeToTrunk.patch, > calendar.PNG, catalog.png, glyphicons-halflings-regular.zip, > htmlMenuMacroLibrary.patch, lookupField_patch.patch, > pagination_htmlFormMacroLibrary.patch, > panelCollapse_htmlSreenMacroLibrary.patch, party menu tab bar.PNG, > preferences.png, styling_issue_1.png, styling_issue_2.png, > styling_issue_3.png, styling_issue_4.png, styling_issue_5.png, > styling_issue_6.png, styling_issue_7.png, styling_issue_8.png, > styling_issue_9.png, tab-bar.png, workeffort.PNG > > > 1- create a sub-directory called bootstrap under the image webapp to put > the resources over there (js, css and fonts) as indicated earlier by Gavin. > (Julien : not sure about location) > 2- check to make sure that the current version of jQuery is compatible with > the installed version or upgrade it accordingly > 3- Create a new theme based on one of the existing themes as suggested by > Julien and Gavin > 4- Test the theme by switching to it and handle major bugs / issues. > 5- Start to make a few test screens utilizing Bootstrap -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7781) Have a configurable solution with respect to the default fields of all entities
[ https://issues.apache.org/jira/browse/OFBIZ-7781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15373667#comment-15373667 ] Michael Brohl commented on OFBIZ-7781: -- Thanks for your lengthy lecture about how to come to implementation decisions. You seem to imply that "we" meant only the contributors, which is not the case with my posting. That said, I wonder if we really have strong *user* requirements for overall tracking fields and if yes, how many. Not sure if we have an "academic" discussion here. The original issue was about user tracking of status changes and you brought up the idea of user tracking for all entities. It seemed to me that this requirement came out of the discussion and not from OFBiz adopters. So, do we have a relevant user base who wants this feature? > Have a configurable solution with respect to the default fields of all > entities > --- > > Key: OFBIZ-7781 > URL: https://issues.apache.org/jira/browse/OFBIZ-7781 > Project: OFBiz > Issue Type: Improvement > Components: datamodel >Affects Versions: Trunk >Reporter: Pierre Smits > > This issue follows up on comments posted in the OFBIZ-7622 sub-task. > Currently the fields to be added to all entities are defined in > ModelEntity.java. This is a limited list consisting of: > * public static final String STAMP_FIELD = "lastUpdatedStamp"; > * public static final String STAMP_TX_FIELD = "lastUpdatedTxStamp"; > * public static final String CREATE_STAMP_FIELD = "createdStamp"; > * public static final String CREATE_STAMP_TX_FIELD = "createdTxStamp"; > After the implemented code change of the sub task mentioned above, a new > discussion evolved through postings of comments on the subject of how to get > more flexibility in. > This issue is a starting point and potentially a place holder for sub > subtasks to get to a more flexible solution. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7622) Add "changeByUserLoginId" field for CustRequestStatus
[
https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372940#comment-15372940
]
Michael Brohl commented on OFBIZ-7622:
--
The discussion about making this configurable comes from Pierre's suggestion:
{quote}
Isn't it much better to extend the ModelEntity in ModelEntity.java, with
something like 'STAMP_FIELD' and such? And have that applied in GenericDAO.java?
Now it seems we have something implemented for a set of specific cases. But
having a 'changeByUserLoginId on every entity makes sense.
{quote}
I then stated:
{quote}
That could be a problem at least in Germany, where it is a very sensitive
subject because you could track when employees changed data and could monitor
their working behaviour. I did not deeply think about it, just a short notice
to think about before we implement such a feature.
{quote}
Maybe we should first decide *if* we want the "changeByUserLoginId" in every
entity. If the answer is "yes", we may have to deal with configuration of some
sort to switch it off.
> Add "changeByUserLoginId" field for CustRequestStatus
> -
>
> Key: OFBIZ-7622
> URL: https://issues.apache.org/jira/browse/OFBIZ-7622
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Nameet Jain
>Assignee: Julien NICOLAS
> Attachments: OFBIZ-7622.patch, OFBIZ-7622.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7622) Add "changeByUserLoginId" field for CustRequestStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372607#comment-15372607 ] Michael Brohl commented on OFBIZ-7622: -- We should take care that this does not happen. It has to be very limited. My suggestion would cover the initial feature request and the general tracking as well of switching it off. Let's see what others think. > Add "changeByUserLoginId" field for CustRequestStatus > - > > Key: OFBIZ-7622 > URL: https://issues.apache.org/jira/browse/OFBIZ-7622 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Julien NICOLAS > Attachments: OFBIZ-7622.patch, OFBIZ-7622.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7622) Add "changeByUserLoginId" field for CustRequestStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372590#comment-15372590 ] Michael Brohl commented on OFBIZ-7622: -- I'd suggest track.user= off | always | status off = no tracking at all always = track for every entity status = only track status entities We may have to think about other cases like status changes and how to handle a change in this configuration, but that's for later (at least for me) > Add "changeByUserLoginId" field for CustRequestStatus > - > > Key: OFBIZ-7622 > URL: https://issues.apache.org/jira/browse/OFBIZ-7622 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Julien NICOLAS > Attachments: OFBIZ-7622.patch, OFBIZ-7622.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7622) Add "changeByUserLoginId" field for CustRequestStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372538#comment-15372538 ] Michael Brohl commented on OFBIZ-7622: -- Maybe... I am no lawyer and not sure where to draw the line between particular status changes and the overall implementation of user change tracking. We could make in configurable. What do others think? > Add "changeByUserLoginId" field for CustRequestStatus > - > > Key: OFBIZ-7622 > URL: https://issues.apache.org/jira/browse/OFBIZ-7622 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Julien NICOLAS > Attachments: OFBIZ-7622.patch, OFBIZ-7622.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7622) Add "changeByUserLoginId" field for CustRequestStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372518#comment-15372518 ] Michael Brohl commented on OFBIZ-7622: -- That could be a problem at least in Germany, where it is a very sensitive subject because you could track when employees changed data and could monitor their working behaviour. I did not deeply think about it, just a short notice to think about before we implement such a feature. > Add "changeByUserLoginId" field for CustRequestStatus > - > > Key: OFBIZ-7622 > URL: https://issues.apache.org/jira/browse/OFBIZ-7622 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Julien NICOLAS > Attachments: OFBIZ-7622.patch, OFBIZ-7622.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7767) Have gradle produce logs
[ https://issues.apache.org/jira/browse/OFBIZ-7767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-7767: - Priority: Minor (was: Blocker) > Have gradle produce logs > > > Key: OFBIZ-7767 > URL: https://issues.apache.org/jira/browse/OFBIZ-7767 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Minor > > Currently executing gradle tasks doesn't generate logs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7771) Rename loadDefault to something less ambiguous
[ https://issues.apache.org/jira/browse/OFBIZ-7771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369478#comment-15369478 ] Michael Brohl commented on OFBIZ-7771: -- Pierre, it would be really helpful if you could at least provide a concrete solution, in this case propose some "less ambigous" names for the tasks. I don't see this as a major issue in relation to the huge effort and work in progress state of this. I think it would help much more to either discuss these minor issues or hold them back until the main tasks are done. This would help Taher and others to focus on the main issues and prevent digging too much noise on the way. Thank you, Michael > Rename loadDefault to something less ambiguous > -- > > Key: OFBIZ-7771 > URL: https://issues.apache.org/jira/browse/OFBIZ-7771 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits > > The gradle task loadDefault is ambiguous, as it means different things to > different uses. This could lead to a situations where it is used in a wrong > manner, resulting in data being overwritten. > Having a more meaningful name lessens the risk of such situations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7771) Rename loadDefault to something less ambiguous
[ https://issues.apache.org/jira/browse/OFBIZ-7771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-7771: - Priority: Minor (was: Major) > Rename loadDefault to something less ambiguous > -- > > Key: OFBIZ-7771 > URL: https://issues.apache.org/jira/browse/OFBIZ-7771 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Minor > > The gradle task loadDefault is ambiguous, as it means different things to > different uses. This could lead to a situations where it is used in a wrong > manner, resulting in data being overwritten. > Having a more meaningful name lessens the risk of such situations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369466#comment-15369466 ] Michael Brohl commented on OFBIZ-7534: -- +1, sometimes less is more... > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, OFBizRemoteJarList.csv, > OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, > gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362374#comment-15362374 ] Michael Brohl commented on OFBIZ-7534: -- Just a short opinion about the database part: I think the build tool should not be responsible for checking the database connection. That should be part of the startup sequence (and is). I think the learning for a developer will be quick if he once forgets to configure his database right and has to wait until some timeout occurcs and the startup is terminated. So, with regard to the huge amount of other tasks, I suggest to leave this as a minor glitch for later (or any volunteer ;-) ). > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, build.gradle, > gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360695#comment-15360695 ] Michael Brohl commented on OFBIZ-7534: -- Lucene and solr jars are added to the list and compiled ok. > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, build.gradle, > gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360553#comment-15360553 ] Michael Brohl commented on OFBIZ-7534: -- Ok, I have tested the tomcat/catalina and entity libs. They compile ok. > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, build.gradle, > gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-7334) Remove unused imports from Groovy files
[ https://issues.apache.org/jira/browse/OFBIZ-7334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338781#comment-15338781 ] Michael Brohl edited comment on OFBIZ-7334 at 6/19/16 8:23 PM: --- [~ankit.joshi], I've closed this umbrella task because al subtasks are closed. Please reopen if there will be more subtasks added. Thanks, Michael was (Author: mbrohl): [[~ankit.joshi]], I've closed this umbrella task because al subtasks are closed. Please reopen if there will be more subtasks added. Thanks, Michael > Remove unused imports from Groovy files > --- > > Key: OFBIZ-7334 > URL: https://issues.apache.org/jira/browse/OFBIZ-7334 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Ankit Joshi >Assignee: Ankit Joshi >Priority: Minor > > Groovy files in various components have unused package imports. These can be > removed for code optimzation purpose. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-7334) Remove unused imports from Groovy files
[ https://issues.apache.org/jira/browse/OFBIZ-7334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338781#comment-15338781 ] Michael Brohl edited comment on OFBIZ-7334 at 6/19/16 8:22 PM: --- [[~ankit.joshi]], I've closed this umbrella task because al subtasks are closed. Please reopen if there will be more subtasks added. Thanks, Michael was (Author: mbrohl): [[~ankit.joshi]]], I've closed this umbrella task because al subtasks are closed. Please reopen if there will be more subtasks added. Thanks, Michael > Remove unused imports from Groovy files > --- > > Key: OFBIZ-7334 > URL: https://issues.apache.org/jira/browse/OFBIZ-7334 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Ankit Joshi >Assignee: Ankit Joshi >Priority: Minor > > Groovy files in various components have unused package imports. These can be > removed for code optimzation purpose. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7334) Remove unused imports from Groovy files
[ https://issues.apache.org/jira/browse/OFBIZ-7334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338781#comment-15338781 ] Michael Brohl commented on OFBIZ-7334: -- [[~ankit.joshi]]], I've closed this umbrella task because al subtasks are closed. Please reopen if there will be more subtasks added. Thanks, Michael > Remove unused imports from Groovy files > --- > > Key: OFBIZ-7334 > URL: https://issues.apache.org/jira/browse/OFBIZ-7334 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Ankit Joshi >Assignee: Ankit Joshi >Priority: Minor > > Groovy files in various components have unused package imports. These can be > removed for code optimzation purpose. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7334) Remove unused imports from Groovy files
[ https://issues.apache.org/jira/browse/OFBIZ-7334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-7334: - Fix Version/s: (was: 15.12.01) (was: 14.12.01) > Remove unused imports from Groovy files > --- > > Key: OFBIZ-7334 > URL: https://issues.apache.org/jira/browse/OFBIZ-7334 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Ankit Joshi >Assignee: Ankit Joshi >Priority: Minor > > Groovy files in various components have unused package imports. These can be > removed for code optimzation purpose. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7334) Remove unused imports from Groovy files
[ https://issues.apache.org/jira/browse/OFBIZ-7334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-7334. Resolution: Fixed Fix Version/s: (was: Trunk) 15.12.01 14.12.01 > Remove unused imports from Groovy files > --- > > Key: OFBIZ-7334 > URL: https://issues.apache.org/jira/browse/OFBIZ-7334 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Ankit Joshi >Assignee: Ankit Joshi >Priority: Minor > Fix For: 14.12.01, 15.12.01 > > > Groovy files in various components have unused package imports. These can be > removed for code optimzation purpose. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6300) Compiler-Error with JDK 1.8 and source compatibility 1.8
[ https://issues.apache.org/jira/browse/OFBIZ-6300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-6300: - Fix Version/s: (was: Upcoming Branch) 15.12.01 > Compiler-Error with JDK 1.8 and source compatibility 1.8 > > > Key: OFBIZ-6300 > URL: https://issues.apache.org/jira/browse/OFBIZ-6300 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Martin Becker >Assignee: Michael Brohl > Fix For: 15.12.01 > > Attachments: OFBIZ-6300-EntityFieldMap.patch > > > I just found another error compiling the code with JDK 1.8 with source code > compatibility switched to 1.8 in my eclipse workspace. The external ant build > is working because there is java version 1.7 defined as target in the > macros.xml. > The error is an issue regarding generics in EntityFieldMap.java. > I will provide a patch her soon. > The code is the same in the release branches. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6793) Have configuration options for the ecommerce component.
[ https://issues.apache.org/jira/browse/OFBIZ-6793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-6793: - Fix Version/s: (was: Upcoming Branch) 15.12.01 > Have configuration options for the ecommerce component. > --- > > Key: OFBIZ-6793 > URL: https://issues.apache.org/jira/browse/OFBIZ-6793 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS, ALL COMPONENTS >Reporter: Pierre Smits >Assignee: Michael Brohl > Fix For: 15.12.01 > > Attachments: OFBIZ-6793-ecommerce.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6258) Trivial perfomance improvement for creating OrderItemAttributes during store/update Order
[
https://issues.apache.org/jira/browse/OFBIZ-6258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl updated OFBIZ-6258:
-
Fix Version/s: (was: Upcoming Branch)
15.12.01
> Trivial perfomance improvement for creating OrderItemAttributes during
> store/update Order
> -
>
> Key: OFBIZ-6258
> URL: https://issues.apache.org/jira/browse/OFBIZ-6258
> Project: OFBiz
> Issue Type: Improvement
> Components: order
>Affects Versions: Upcoming Branch
>Reporter: Martin Becker
>Assignee: Michael Brohl
>Priority: Trivial
> Fix For: 15.12.01
>
> Attachments: ShoppingCart-makeAllOrderItemAttributes.patch
>
>
> Improved use of given mode parameter in {{makeAllOrderItemAttributes(String
> orderId, int mode)}} to avoid creating new OrderItemAttribute GenericValues
> that have not to be created according to the value for mode (FILLED_ONLY,
> EMPTY_ONLY).
> Change was made for a project with massive use of OrderItemAttributes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-6521) German translations for the Accounting Component
[ https://issues.apache.org/jira/browse/OFBIZ-6521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-6521: - Fix Version/s: (was: Upcoming Branch) 15.12.01 > German translations for the Accounting Component > > > Key: OFBIZ-6521 > URL: https://issues.apache.org/jira/browse/OFBIZ-6521 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Upcoming Branch >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > Fix For: 15.12.01 > > Attachments: OFBIZ-6521.patch > > > Will provide a patch for it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6319) Add missing entries to .gitignore to ignore typical Idea/eclipse folders/files
[ https://issues.apache.org/jira/browse/OFBIZ-6319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-6319: - Fix Version/s: (was: Upcoming Branch) 15.12.01 > Add missing entries to .gitignore to ignore typical Idea/eclipse folders/files > -- > > Key: OFBIZ-6319 > URL: https://issues.apache.org/jira/browse/OFBIZ-6319 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Martin Becker >Assignee: Michael Brohl >Priority: Trivial > Fix For: 15.12.01 > > Attachments: OFBIZ-6319.patch > > > Some folder/filenames that are configured for SVN to be ignored are missing > in the current .gitignore file. Especially the internal config folders > created by eclipse in the project root (.settings and .groovy) are missing > for me, so that they get displayed as modification while using git. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6522) Potential IndexOutOfBoundsException in CategoryServices.getProductCategoryAndLimitedMembers
[ https://issues.apache.org/jira/browse/OFBIZ-6522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-6522: - Fix Version/s: (was: Upcoming Branch) 15.12.01 > Potential IndexOutOfBoundsException in > CategoryServices.getProductCategoryAndLimitedMembers > --- > > Key: OFBIZ-6522 > URL: https://issues.apache.org/jira/browse/OFBIZ-6522 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Upcoming Branch >Reporter: Martin Becker >Assignee: Michael Brohl >Priority: Minor > Fix For: 15.12.01 > > Attachments: OFBIZ-6522.patch > > > If view indexes as input parameters of service > getProductCategoryAndLimitedMembers get manipulated (e.g. by manipulating URL > params or bookmarking an URL with those params an come back later), it can > lead to an IndexOutOfBoundsException because of a lowIndex greater list size. > The highIndex is checked for that, the lowIndex is not. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6305) German translations for various applications
[ https://issues.apache.org/jira/browse/OFBIZ-6305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-6305: - Fix Version/s: (was: Upcoming Branch) 15.12.01 > German translations for various applications > > > Key: OFBIZ-6305 > URL: https://issues.apache.org/jira/browse/OFBIZ-6305 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Upcoming Branch >Reporter: Martin Becker >Assignee: Michael Brohl > Fix For: 15.12.01 > > Attachments: OFBIZ-6305-PartyComponent.patch, > OFBIZ-6305-ProductEntityLabels.patch, OFBIZ-6305-ProductErrorUiLabels.patch, > OFBIZ-6305-ProductUiLabels.patch > > > We would like to contribute missing german translations for the OFBiz > applications based on the current trunk. There will arrive patches for this > per application within this ticket. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6420) Improve ModelFormField Code
[ https://issues.apache.org/jira/browse/OFBIZ-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-6420: - Fix Version/s: (was: Upcoming Branch) 15.12.01 > Improve ModelFormField Code > --- > > Key: OFBIZ-6420 > URL: https://issues.apache.org/jira/browse/OFBIZ-6420 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Upcoming Branch >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > Fix For: 15.12.01 > > > The ModelFormField Code should be improved. It contains unnecessary code, > catched exceptions are too broad etc. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6414) drop-down widget field with allow-multiple="true" does not display current value
[ https://issues.apache.org/jira/browse/OFBIZ-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-6414: - Fix Version/s: (was: Upcoming Branch) 15.12.01 > drop-down widget field with allow-multiple="true" does not display current > value > > > Key: OFBIZ-6414 > URL: https://issues.apache.org/jira/browse/OFBIZ-6414 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Gareth Carter >Assignee: Michael Brohl >Priority: Minor > Fix For: 15.12.01 > > Attachments: ModelFormField.patch > > > ModelFormField.getEntry returns the string representation of the value > corresponding to the field in either the context map or parameters map but > when the value is returned as a list [X, Y, Z], the opening and closing > brackets are encoded X, Y, Z > This prevents the FormRenderer (atleast MacroFormRenderer) from detecting a > list object from the string and converting it back to a list > eg - currentValueList = StringUtil.toList(currentValue); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6492) FTL errors at facility/control/authview/ViewContactMechs when TELECOM_NUMBER countryCode or contactNumber is blank
[ https://issues.apache.org/jira/browse/OFBIZ-6492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-6492: - Fix Version/s: (was: Upcoming Branch) > FTL errors at facility/control/authview/ViewContactMechs when TELECOM_NUMBER > countryCode or contactNumber is blank > -- > > Key: OFBIZ-6492 > URL: https://issues.apache.org/jira/browse/OFBIZ-6492 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 13.07, Release Branch 14.12, Upcoming > Branch >Reporter: Christian Carlow >Assignee: Michael Brohl >Priority: Minor > Fix For: 14.12.01, 12.04.06, 13.07.03 > > Attachments: OFBIZ-6492.patch > > > Backported in R12.04 at r1693699 > Fixed "Fix Version/s" field -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6594) Wrong Documentation for Temporal Expressions
[ https://issues.apache.org/jira/browse/OFBIZ-6594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-6594: - Fix Version/s: (was: Upcoming Branch) > Wrong Documentation for Temporal Expressions > > > Key: OFBIZ-6594 > URL: https://issues.apache.org/jira/browse/OFBIZ-6594 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 12.04, Release Branch 13.07, Release > Branch 14.12, Upcoming Branch >Reporter: Mirko Vogelsmeier >Assignee: Michael Brohl >Priority: Minor > Fix For: 14.12.01, 12.04.06, 13.07.03 > > Attachments: ServiceDemoData.xml.patch > > > If the temporal expression is referring to com.ibm.icu.util.Calendar, > the HOUR is ment to be a 10 instead of an 11. > The mechanism works fine, just the documentation is wrong. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6647) Refactoring to consolidate different Calendar implementations
[ https://issues.apache.org/jira/browse/OFBIZ-6647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-6647: - Fix Version/s: (was: Upcoming Branch) > Refactoring to consolidate different Calendar implementations > - > > Key: OFBIZ-6647 > URL: https://issues.apache.org/jira/browse/OFBIZ-6647 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > > This came up in reference to > [6594|https://issues.apache.org/jira/browse/OFBIZ-6594]: > Piere Smits: "Currently we are using 'import com.ibm.icu.util.Calendar' at > various places. But we're also using 'java.util.Calendar' at other places. > Better is it to make a choice for consistency." > We should fisrt analyze the usage of different implementations and the impact > of replacing one with the other (e.g. what's the difference of these > implementations). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6635) Old UserLogin from userLoginId-change is not correctly disabled
[ https://issues.apache.org/jira/browse/OFBIZ-6635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-6635: - Fix Version/s: (was: Upcoming Branch) > Old UserLogin from userLoginId-change is not correctly disabled > --- > > Key: OFBIZ-6635 > URL: https://issues.apache.org/jira/browse/OFBIZ-6635 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release Branch 13.07, Release Branch 14.12, Upcoming > Branch >Reporter: Martin Becker >Assignee: Michael Brohl >Priority: Critical > Fix For: Release Branch 13.07, 14.12.01 > > Attachments: OFBIZ-6635-FixedDisablingOldUserLogin.patch > > > If a userLoginId of an existing user is updated by > LoginServices.updateUserLoginId, a new UserLogin value is created with the > data of the old one and the old one is disabled afterwards. In addition to > switch the enabled flag to "N" the disabledDateTime is set to current date. > This is wrong because this makes it possible to reenable the old UserLogin by > just do a login with the old userLoginId (standard mechanism to lock the > login for a while after subsequent failed login requests). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6515) partymgr/control/EditPartyRelationships add odd-row="alternate-row" for ListPartRelationships and remove navigation-form-name for containing screenlet for better UI
[ https://issues.apache.org/jira/browse/OFBIZ-6515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-6515: - Fix Version/s: (was: Upcoming Branch) > partymgr/control/EditPartyRelationships add odd-row="alternate-row" for > ListPartRelationships and remove navigation-form-name for containing > screenlet for better UI > > > Key: OFBIZ-6515 > URL: https://issues.apache.org/jira/browse/OFBIZ-6515 > Project: OFBiz > Issue Type: Improvement > Components: themes >Affects Versions: Release Branch 14.12, Upcoming Branch >Reporter: Christian Carlow >Assignee: Michael Brohl >Priority: Minor > Fix For: 14.12.01 > > Attachments: OFBIZ-6515.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6632) Incorrect comparison in TemporalExpressionWorker.java
[
https://issues.apache.org/jira/browse/OFBIZ-6632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl updated OFBIZ-6632:
-
Fix Version/s: (was: Upcoming Branch)
> Incorrect comparison in TemporalExpressionWorker.java
> -
>
> Key: OFBIZ-6632
> URL: https://issues.apache.org/jira/browse/OFBIZ-6632
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release Branch 14.12, Upcoming Branch
>Reporter: Vyom Jain
>Assignee: Michael Brohl
> Fix For: 14.12.01, 12.04.06, 13.07.03
>
> Attachments: OFBIZ-6632-Fixed-exprAssocType-values.patch
>
>
> Line 128 in TemporalExpressionWorker.java does incorrect comparison
> {code}
> if ("SUBSTITUTION".equals(childExpression.get("exprAssocType"))) {
> {code} should be
> {code}
> if ("SUBSTITUTE".equals(childExpression.get("exprAssocType"))) {
> {code}
> Also documentation of field exprAssocType in entity definition of
> TemporalExpressionAssoc needs to be fixed. INCLUDED & EXCLUDED should be
> INCLUDE & EXCLUDE respectively.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-6630) Update ShoppingCartItem locale if ShoppingCart locale is changed
[ https://issues.apache.org/jira/browse/OFBIZ-6630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-6630: - Fix Version/s: (was: Upcoming Branch) > Update ShoppingCartItem locale if ShoppingCart locale is changed > > > Key: OFBIZ-6630 > URL: https://issues.apache.org/jira/browse/OFBIZ-6630 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 12.04, Release Branch 13.07, Release > Branch 14.12, Upcoming Branch >Reporter: Martin Becker >Assignee: Michael Brohl >Priority: Minor > Fix For: Release Branch 12.04, Release Branch 13.07, 14.12.01 > > Attachments: OFBIZ-6630-KeepCartItemLocalInSync.patch > > > If the locale of the cart is changed, for example by choosing the language in > frontend and setting the locale by CommonEvents.setSessionLocale and updating > the cart locale by keepCartUpdated event, the locale stored in each cart item > isn't updated. A call to item.getName() for example uses the wrong locale > afterwards. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6526) ordermgr/control/searchorders findOrders service returns incorrect orderCount and therefore viewSize
[ https://issues.apache.org/jira/browse/OFBIZ-6526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-6526: - Fix Version/s: (was: Upcoming Branch) > ordermgr/control/searchorders findOrders service returns incorrect orderCount > and therefore viewSize > > > Key: OFBIZ-6526 > URL: https://issues.apache.org/jira/browse/OFBIZ-6526 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 12.04, Release Branch 13.07, Release > Branch 14.12, Upcoming Branch >Reporter: Christian Carlow >Assignee: Michael Brohl > Fix For: Release Branch 12.04, Release Branch 13.07, 14.12.01 > > Attachments: OFBIZ-6526.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6621) MapContext.entrySet() slows down when ByteBuffer objects are in the context
[
https://issues.apache.org/jira/browse/OFBIZ-6621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl updated OFBIZ-6621:
-
Fix Version/s: (was: Upcoming Branch)
> MapContext.entrySet() slows down when ByteBuffer objects are in the context
> ---
>
> Key: OFBIZ-6621
> URL: https://issues.apache.org/jira/browse/OFBIZ-6621
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Release Branch 14.12, Upcoming Branch
>Reporter: Gareth Carter
>Assignee: Michael Brohl
>Priority: Critical
> Fix For: 14.12.01
>
> Attachments: MapContext-v2.patch, MapContext.patch
>
>
> When MapContext is used anywhere (eg FlexibleStringExpander) and the context
> contains ByteBuffer objects (either key or value), java will slow down when
> calling MapContext.entrySet().
> Here is the code in ofbiz, highlighted is the line of code that I believe is
> the culprit
> {code:title=MapContext.java}
> public Set> entrySet() {
> // walk the stackList and the entries for each Map and if nothing is in
> for the current key, put it in
> Set resultKeySet = new HashSet();
> culprit --> Set> resultEntrySet = new
> ListSet>();
> for (Map curMap: this.stackList) {
> for (Map.Entry curEntry: curMap.entrySet()) {
> if (!resultKeySet.contains(curEntry.getKey())) {
> resultKeySet.add(curEntry.getKey());
> resultEntrySet.add(curEntry);
> }
> }
> }
> return Collections.unmodifiableSet(resultEntrySet);
> }
> {code}
> Looking at the java api for Map.Entry, the hashCode method for Map.Entry is
> the result of the hashCode from both key and value. ByteBuffer hash code is
> dependent upon its content. If a 2mb file is uploaded, the hashCode method
> of ByteBuffer will scan 2mb to generate the hashCode
> ByteBuffer
> http://docs.oracle.com/javase/7/docs/api/java/nio/ByteBuffer.html#hashCode()
> {quote}Because buffer hash codes are content-dependent, it is inadvisable to
> use buffers as keys in hash maps or similar data structures unless it is
> known that their contents will not change.{quote}
> Map.Entry
> http://docs.oracle.com/javase/7/docs/api/java/util/Map.Entry.html#hashCode()
> {quote}(e.getKey()==null ? 0 : e.getKey().hashCode()) ^ (e.getValue()==null
> ? 0 : e.getValue().hashCode()){quote}
> HashSet
> http://docs.oracle.com/javase/7/docs/api/java/util/HashSet.html
> {quote}This class implements the Set interface, backed by a hash table
> (actually a HashMap instance{quote}
> Example where ByteBuffer objects are created
> {code}org.ofbiz.webapp.event.ServiceEventHandler{code}
> Example stack trace
> {noformat}
> "ajp-bio-8009-exec-1894" daemon prio=10 tid=0x7fa52c07 nid=0x5c73
> runnable [0x7fa51151b000]
>java.lang.Thread.State: RUNNABLE
> at java.nio.HeapByteBuffer.ix(HeapByteBuffer.java:131)
> at java.nio.HeapByteBuffer.get(HeapByteBuffer.java:139)
> at java.nio.ByteBuffer.hashCode(ByteBuffer.java:1083)
> at java.util.Objects.hashCode(Objects.java:96)
> at java.util.HashMap$Entry.hashCode(HashMap.java:847)
> at java.util.AbstractMap.hashCode(AbstractMap.java:494)
> at java.util.Objects.hashCode(Objects.java:96)
> at java.util.HashMap$Entry.hashCode(HashMap.java:847)
> at java.util.HashMap.hash(HashMap.java:362)
> at java.util.HashMap.put(HashMap.java:492)
> at java.util.HashSet.add(HashSet.java:217)
> at
> org.ofbiz.base.util.collections.MapContext.entrySet(MapContext.java:306)
> at java.util.HashMap.putAll(HashMap.java:642)
> at
> org.ofbiz.widget.model.ModelFormField$ListOptions.addOptionValues(ModelFormField.java:2716)
> at
> org.ofbiz.widget.model.ModelFormField$FieldInfoWithOptions.getAllOptionValues(ModelFormField.java:1985)
> at
> org.ofbiz.widget.renderer.macro.MacroFormRenderer.renderDropDownField(MacroFormRenderer.java:747)
> at
> org.ofbiz.widget.model.ModelFormField$DropDownField.renderFieldString(ModelFormField.java:1739)
> at
> org.ofbiz.widget.model.ModelFormField.renderFieldString(ModelFormField.java:693)
> at
> org.ofbiz.widget.renderer.FormRenderer.renderSingleFormString(FormRenderer.java:1195)
> at org.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:261)
> at
> org.ofbiz.widget.model.ModelScreenWidget$Form.renderWidgetString(ModelScreenWidget.java:1052)
> at
> org.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:677)
> at
> org.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:598)
> at
>
[jira] [Updated] (OFBIZ-6631) Optimize ShoppingCart.removeCartItem (skip price calc and inventory check)
[ https://issues.apache.org/jira/browse/OFBIZ-6631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-6631: - Fix Version/s: (was: Upcoming Branch) > Optimize ShoppingCart.removeCartItem (skip price calc and inventory check) > -- > > Key: OFBIZ-6631 > URL: https://issues.apache.org/jira/browse/OFBIZ-6631 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Release Branch 12.04, Release Branch 13.07, Release > Branch 14.12, Upcoming Branch >Reporter: Martin Becker >Assignee: Michael Brohl >Priority: Minor > Fix For: Release Branch 12.04, Release Branch 13.07, 14.12.01 > > Attachments: OFBIZ-6631-Optimized-RemoveCartItem.patch > > > Based on the standard parameter completion from the overloaded API of > ShoppingCartItem.setQuantity, the use of the ShoppingCart.removeCartItem > method leads to an unnecessary price calculation and inventory check for the > item being removed. > By using the setQuantity method with full parameter list in this case, this > can be avoided. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6398) Print Pick Sheet PDF using orderId.pdf as attachement name.
[ https://issues.apache.org/jira/browse/OFBIZ-6398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-6398: - Fix Version/s: (was: Upcoming Branch) > Print Pick Sheet PDF using orderId.pdf as attachement name. > --- > > Key: OFBIZ-6398 > URL: https://issues.apache.org/jira/browse/OFBIZ-6398 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 14.12, Upcoming Branch >Reporter: Deepak Dixit >Assignee: Michael Brohl >Priority: Minor > Fix For: 14.12.01 > > > Print Pick Sheet PDF using .pdf as attachement name. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6310) createConditionList doesn't handle widget dropdown multi-submitted values when called by performFind
[ https://issues.apache.org/jira/browse/OFBIZ-6310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-6310: - Fix Version/s: (was: Upcoming Branch) > createConditionList doesn't handle widget dropdown multi-submitted values > when called by performFind > > > Key: OFBIZ-6310 > URL: https://issues.apache.org/jira/browse/OFBIZ-6310 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl > Fix For: Release Branch 13.07, 14.12.01 > > Attachments: OFBIZ-6310.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6317) Missing BIRT libs in eclipse .classpath file
[ https://issues.apache.org/jira/browse/OFBIZ-6317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-6317: - Fix Version/s: (was: Upcoming Branch) > Missing BIRT libs in eclipse .classpath file > > > Key: OFBIZ-6317 > URL: https://issues.apache.org/jira/browse/OFBIZ-6317 > Project: OFBiz > Issue Type: Bug > Components: framework, specialpurpose/birt >Affects Versions: Release Branch 14.12, Upcoming Branch >Reporter: Martin Becker >Assignee: Michael Brohl >Priority: Minor > Fix For: 14.12.01 > > Attachments: OFBIZ-6317.patch, OFBIZ-6317_14-12.patch, > OFBIZ-6317_trunk_framework-base-config.patch > > > Because of missing JARs from the specialpurpose component birt in the eclipse > .classpath file OFBiz could not be startet within eclipse without errors > (NoClassDefFoundError while starting birt component). > With "starting within eclipse" I mean the configuration with hot code > replacement like this: > https://cwiki.apache.org/confluence/display/OFBIZ/Running+and+Debugging+OFBiz+in+Eclipse#RunningandDebuggingOFBizinEclipse-debuggingInEclipseHotClasses > I will provide a patch for the .classpath file with 4 added libs from the > specialpurpose/birt/lib folder. > It would be beneficial, at least for simple contribution of jira issue fixes, > if the default configuration of OFBiz from trunk is runnable as is (in a > common development scenario like the above), without the need to modify > config files which are under version control (.classpath for example). The > alternative could be to not put files under version control, that are related > to individual development environments. > By the way, it would also be nice to have the framework/base/config folder as > src in the .classpath file as described in the wiki article above, so that > the configuration of an eclipse debug/run target for starting OFBiz in > eclipse is done by only selecting the project + start-class and giving some > JVM args. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-5679) Functionality to add WebSitePathAlias records is missing
[ https://issues.apache.org/jira/browse/OFBIZ-5679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-5679: - Fix Version/s: (was: Upcoming Branch) > Functionality to add WebSitePathAlias records is missing > > > Key: OFBIZ-5679 > URL: https://issues.apache.org/jira/browse/OFBIZ-5679 > Project: OFBiz > Issue Type: Improvement > Components: content >Affects Versions: 11.04.04, 12.04.03, Upcoming Branch >Reporter: Pierre Smits >Assignee: Michael Brohl > Fix For: 14.12.01 > > Attachments: addWebSitePathAlias.diff > > > On websites in Content Mgr an overview to show path aliases (WebSitePathAlias > entity) is available. > However, the functionality to add path aliases is not available in the menu > for the website. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6373) CategoryWorker.getRelatedCategoriesRet ignores recursive-flag
[ https://issues.apache.org/jira/browse/OFBIZ-6373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-6373: - Fix Version/s: (was: Upcoming Branch) > CategoryWorker.getRelatedCategoriesRet ignores recursive-flag > - > > Key: OFBIZ-6373 > URL: https://issues.apache.org/jira/browse/OFBIZ-6373 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Release Branch 14.12, Trunk, 13.07.01 >Reporter: Sebastian Leitner >Assignee: Michael Brohl >Priority: Minor > Fix For: Release Branch 13.07, 14.12.01 > > Attachments: CategoryWorker.patch > > > Some of the CategoryWorker.getRelatedCategoriesRet methods have a flag in > their signature (boolean) to switch on/off recursiveness. But they ignore > this flag and pass 'false' to further processing. > Will attach a patch in a second. > Might also affect 14.x releases as it's in trunk and 13.07.01 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-5610) Labels for UK date formats
[ https://issues.apache.org/jira/browse/OFBIZ-5610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-5610: - Fix Version/s: (was: Upcoming Branch) > Labels for UK date formats > -- > > Key: OFBIZ-5610 > URL: https://issues.apache.org/jira/browse/OFBIZ-5610 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk >Reporter: Gareth Carter >Assignee: Michael Brohl >Priority: Trivial > Fix For: Release Branch 13.07, 14.12.01 > > Attachments: gb_labels.patch > > > Date formats displayed in the title of the input field are not correctly > showing the default format for UK but the actual date itself is correct -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7400) Humanres : Remove unused imports from groovy files for code optimization.
[ https://issues.apache.org/jira/browse/OFBIZ-7400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-7400: - Fix Version/s: (was: Upcoming Branch) > Humanres : Remove unused imports from groovy files for code optimization. > - > > Key: OFBIZ-7400 > URL: https://issues.apache.org/jira/browse/OFBIZ-7400 > Project: OFBiz > Issue Type: Sub-task > Components: humanres >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12 >Reporter: Ankit Joshi >Assignee: Michael Brohl >Priority: Minor > Fix For: 14.12.01, 15.12.01 > > Attachments: OFBIZ-7400-trunk.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7396) Marketing : Remove unused imports from groovy files for code optimization.
[ https://issues.apache.org/jira/browse/OFBIZ-7396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-7396: - Fix Version/s: (was: Upcoming Branch) > Marketing : Remove unused imports from groovy files for code optimization. > --- > > Key: OFBIZ-7396 > URL: https://issues.apache.org/jira/browse/OFBIZ-7396 > Project: OFBiz > Issue Type: Sub-task > Components: marketing >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12 >Reporter: Shivangi Tanwar >Assignee: Michael Brohl >Priority: Minor > Fix For: 14.12.01, 15.12.01 > > Attachments: OFBIZ-7396_trunk.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7411) Commonext : Remove unused imports from groovy files for code optimization.
[ https://issues.apache.org/jira/browse/OFBIZ-7411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-7411: - Fix Version/s: (was: Upcoming Branch) > Commonext : Remove unused imports from groovy files for code optimization. > -- > > Key: OFBIZ-7411 > URL: https://issues.apache.org/jira/browse/OFBIZ-7411 > Project: OFBiz > Issue Type: Sub-task > Components: commonext/setup >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12 >Reporter: Ankit Joshi >Assignee: Michael Brohl >Priority: Minor > Fix For: 14.12.01, 15.12.01 > > Attachments: OFBIZ-7411-trunk.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7400) Humanres : Remove unused imports from groovy files for code optimization.
[ https://issues.apache.org/jira/browse/OFBIZ-7400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338216#comment-15338216 ] Michael Brohl commented on OFBIZ-7400: -- Ok, I will change the fix versions. The issues I have been working on today are already set to the sprint or am I missing something? > Humanres : Remove unused imports from groovy files for code optimization. > - > > Key: OFBIZ-7400 > URL: https://issues.apache.org/jira/browse/OFBIZ-7400 > Project: OFBiz > Issue Type: Sub-task > Components: humanres >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12 >Reporter: Ankit Joshi >Assignee: Michael Brohl >Priority: Minor > Fix For: 14.12.01, Upcoming Branch, 15.12.01 > > Attachments: OFBIZ-7400-trunk.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7400) Humanres : Remove unused imports from groovy files for code optimization.
[ https://issues.apache.org/jira/browse/OFBIZ-7400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338167#comment-15338167 ] Michael Brohl commented on OFBIZ-7400: -- Hi Jaqcues, I get always confused which versions to set on afftected/fixed versions. Can you please point me to the discussion, I cannot find it. Do you want me to change all these issues of the provided Jira research or is it just an example? > Humanres : Remove unused imports from groovy files for code optimization. > - > > Key: OFBIZ-7400 > URL: https://issues.apache.org/jira/browse/OFBIZ-7400 > Project: OFBiz > Issue Type: Sub-task > Components: humanres >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12 >Reporter: Ankit Joshi >Assignee: Michael Brohl >Priority: Minor > Fix For: 14.12.01, Upcoming Branch, 15.12.01 > > Attachments: OFBIZ-7400-trunk.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7411) Commonext : Remove unused imports from groovy files for code optimization.
[ https://issues.apache.org/jira/browse/OFBIZ-7411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-7411. Resolution: Fixed Fix Version/s: (was: Trunk) 15.12.01 Upcoming Branch 14.12.01 Thanks Ankit, your patch is in trunk r1748956 R14.12 r1748959 R15.12 r1748957 > Commonext : Remove unused imports from groovy files for code optimization. > -- > > Key: OFBIZ-7411 > URL: https://issues.apache.org/jira/browse/OFBIZ-7411 > Project: OFBiz > Issue Type: Sub-task > Components: commonext/setup >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12 >Reporter: Ankit Joshi >Assignee: Michael Brohl >Priority: Minor > Fix For: 14.12.01, Upcoming Branch, 15.12.01 > > Attachments: OFBIZ-7411-trunk.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7411) Commonext : Remove unused imports from groovy files for code optimization.
[ https://issues.apache.org/jira/browse/OFBIZ-7411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-7411: - Affects Version/s: Release Branch 14.12 Release Branch 15.12 > Commonext : Remove unused imports from groovy files for code optimization. > -- > > Key: OFBIZ-7411 > URL: https://issues.apache.org/jira/browse/OFBIZ-7411 > Project: OFBiz > Issue Type: Sub-task > Components: commonext/setup >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12 >Reporter: Ankit Joshi >Assignee: Michael Brohl >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-7411-trunk.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7411) Commonext : Remove unused imports from groovy files for code optimization.
[ https://issues.apache.org/jira/browse/OFBIZ-7411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-7411: Assignee: Michael Brohl > Commonext : Remove unused imports from groovy files for code optimization. > -- > > Key: OFBIZ-7411 > URL: https://issues.apache.org/jira/browse/OFBIZ-7411 > Project: OFBiz > Issue Type: Sub-task > Components: commonext/setup >Affects Versions: Trunk >Reporter: Ankit Joshi >Assignee: Michael Brohl >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-7411-trunk.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Issue Comment Deleted] (OFBIZ-7395) Require check on facility type ID while creating New Facility
[ https://issues.apache.org/jira/browse/OFBIZ-7395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-7395: - Comment: was deleted (was: [~avnindra.sharma]], facility type is not a mandatory field, I think we do not need this tooltip added.) > Require check on facility type ID while creating New Facility > - > > Key: OFBIZ-7395 > URL: https://issues.apache.org/jira/browse/OFBIZ-7395 > Project: OFBiz > Issue Type: Improvement >Reporter: Avnindra Sharma >Assignee: Michael Brohl >Priority: Minor > Attachments: OFBIZ-7395.patch > > > While creating a new facility, facility type ID is a mandatory field. Require > check is needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-7395) Require check on facility type ID while creating New Facility
[ https://issues.apache.org/jira/browse/OFBIZ-7395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15337704#comment-15337704 ] Michael Brohl edited comment on OFBIZ-7395 at 6/18/16 10:11 AM: [~avnindra.sharma], facility type is not a mandatory field, I think we do not need this tooltip added. was (Author: mbrohl): [~avnindra.sharma]], facility type is not a mandatory field, I think we do not need this tooltip added. > Require check on facility type ID while creating New Facility > - > > Key: OFBIZ-7395 > URL: https://issues.apache.org/jira/browse/OFBIZ-7395 > Project: OFBiz > Issue Type: Improvement >Reporter: Avnindra Sharma >Assignee: Michael Brohl >Priority: Minor > Attachments: OFBIZ-7395.patch > > > While creating a new facility, facility type ID is a mandatory field. Require > check is needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6549) workeffort/control/addTimesheetToInvoice missing workEffort for call to createTimeEntryInvoiceItemsInline
[ https://issues.apache.org/jira/browse/OFBIZ-6549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15337717#comment-15337717 ] Michael Brohl commented on OFBIZ-6549: -- [~ofbizzer]], any chance to work on this? > workeffort/control/addTimesheetToInvoice missing workEffort for call to > createTimeEntryInvoiceItemsInline > - > > Key: OFBIZ-6549 > URL: https://issues.apache.org/jira/browse/OFBIZ-6549 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: Upcoming Branch >Reporter: Christian Carlow >Assignee: Michael Brohl >Priority: Minor > Attachments: OFBIZ-6549.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6977) Update content type data - sql queries
[ https://issues.apache.org/jira/browse/OFBIZ-6977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-6977. Resolution: Won't Fix We first should discuss the overall topic in the dev list. Please open a new issue for the conceptual work and discussion of a better SQL processor functionality as well as webtools refactoring. > Update content type data - sql queries > -- > > Key: OFBIZ-6977 > URL: https://issues.apache.org/jira/browse/OFBIZ-6977 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Michael Brohl >Priority: Minor > Attachments: OFBIZ-6977-ContentTypeData.xml.patch > > > Adding a new content type for sql queries -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7395) Require check on facility type ID while creating New Facility
[ https://issues.apache.org/jira/browse/OFBIZ-7395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15337703#comment-15337703 ] Michael Brohl commented on OFBIZ-7395: -- [~avnindra.sharma]], facility type is not a mandatory field, I think we do not need this tooltip added. > Require check on facility type ID while creating New Facility > - > > Key: OFBIZ-7395 > URL: https://issues.apache.org/jira/browse/OFBIZ-7395 > Project: OFBiz > Issue Type: Improvement >Reporter: Avnindra Sharma >Assignee: Michael Brohl >Priority: Minor > Attachments: OFBIZ-7395.patch > > > While creating a new facility, facility type ID is a mandatory field. Require > check is needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7395) Require check on facility type ID while creating New Facility
[ https://issues.apache.org/jira/browse/OFBIZ-7395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15337704#comment-15337704 ] Michael Brohl commented on OFBIZ-7395: -- [~avnindra.sharma]], facility type is not a mandatory field, I think we do not need this tooltip added. > Require check on facility type ID while creating New Facility > - > > Key: OFBIZ-7395 > URL: https://issues.apache.org/jira/browse/OFBIZ-7395 > Project: OFBiz > Issue Type: Improvement >Reporter: Avnindra Sharma >Assignee: Michael Brohl >Priority: Minor > Attachments: OFBIZ-7395.patch > > > While creating a new facility, facility type ID is a mandatory field. Require > check is needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7396) Marketing : Remove unused imports from groovy files for code optimization.
[ https://issues.apache.org/jira/browse/OFBIZ-7396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-7396. Resolution: Fixed Fix Version/s: (was: Trunk) 15.12.01 Upcoming Branch 14.12.01 Thanks Shivangi, your patch is in trunk r1748937 R14.12 r1748938 R15.12 r1748941 > Marketing : Remove unused imports from groovy files for code optimization. > --- > > Key: OFBIZ-7396 > URL: https://issues.apache.org/jira/browse/OFBIZ-7396 > Project: OFBiz > Issue Type: Sub-task > Components: marketing >Affects Versions: Release Branch 14.12, Upcoming Branch, Release Branch > 15.12 >Reporter: Shivangi Tanwar >Assignee: Michael Brohl >Priority: Minor > Fix For: 14.12.01, Upcoming Branch, 15.12.01 > > Attachments: OFBIZ-7396_trunk.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7396) Marketing : Remove unused imports from groovy files for code optimization.
[ https://issues.apache.org/jira/browse/OFBIZ-7396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-7396: - Affects Version/s: (was: Trunk) Upcoming Branch Release Branch 14.12 Release Branch 15.12 > Marketing : Remove unused imports from groovy files for code optimization. > --- > > Key: OFBIZ-7396 > URL: https://issues.apache.org/jira/browse/OFBIZ-7396 > Project: OFBiz > Issue Type: Sub-task > Components: marketing >Affects Versions: Release Branch 14.12, Upcoming Branch, Release Branch > 15.12 >Reporter: Shivangi Tanwar >Assignee: Michael Brohl >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-7396_trunk.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7400) Humanres : Remove unused imports from groovy files for code optimization.
[ https://issues.apache.org/jira/browse/OFBIZ-7400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-7400. Resolution: Fixed Fix Version/s: (was: Trunk) 15.12.01 Upcoming Branch 14.12.01 Thanks Ankit, you patch is in trunk r1748933 R14.12 r1748934 R15.12 r1748940 > Humanres : Remove unused imports from groovy files for code optimization. > - > > Key: OFBIZ-7400 > URL: https://issues.apache.org/jira/browse/OFBIZ-7400 > Project: OFBiz > Issue Type: Sub-task > Components: humanres >Affects Versions: Release Branch 14.12, Upcoming Branch, Release Branch > 15.12 >Reporter: Ankit Joshi >Assignee: Michael Brohl >Priority: Minor > Fix For: 14.12.01, Upcoming Branch, 15.12.01 > > Attachments: OFBIZ-7400-trunk.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7400) Humanres : Remove unused imports from groovy files for code optimization.
[ https://issues.apache.org/jira/browse/OFBIZ-7400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-7400: - Affects Version/s: (was: Trunk) Upcoming Branch Release Branch 14.12 Release Branch 15.12 > Humanres : Remove unused imports from groovy files for code optimization. > - > > Key: OFBIZ-7400 > URL: https://issues.apache.org/jira/browse/OFBIZ-7400 > Project: OFBiz > Issue Type: Sub-task > Components: humanres >Affects Versions: Release Branch 14.12, Upcoming Branch, Release Branch > 15.12 >Reporter: Ankit Joshi >Assignee: Michael Brohl >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-7400-trunk.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7395) Require check on facility type ID while creating New Facility
[ https://issues.apache.org/jira/browse/OFBIZ-7395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-7395: - Sprint: Community Day 2 - 2016 > Require check on facility type ID while creating New Facility > - > > Key: OFBIZ-7395 > URL: https://issues.apache.org/jira/browse/OFBIZ-7395 > Project: OFBiz > Issue Type: Improvement >Reporter: Avnindra Sharma >Assignee: Michael Brohl >Priority: Minor > Attachments: OFBIZ-7395.patch > > > While creating a new facility, facility type ID is a mandatory field. Require > check is needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7395) Require check on facility type ID while creating New Facility
[ https://issues.apache.org/jira/browse/OFBIZ-7395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-7395: Assignee: Michael Brohl > Require check on facility type ID while creating New Facility > - > > Key: OFBIZ-7395 > URL: https://issues.apache.org/jira/browse/OFBIZ-7395 > Project: OFBiz > Issue Type: Improvement >Reporter: Avnindra Sharma >Assignee: Michael Brohl >Priority: Minor > Attachments: OFBIZ-7395.patch > > > While creating a new facility, facility type ID is a mandatory field. Require > check is needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7396) Marketing : Remove unused imports from groovy files for code optimization.
[ https://issues.apache.org/jira/browse/OFBIZ-7396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-7396: Assignee: Michael Brohl > Marketing : Remove unused imports from groovy files for code optimization. > --- > > Key: OFBIZ-7396 > URL: https://issues.apache.org/jira/browse/OFBIZ-7396 > Project: OFBiz > Issue Type: Sub-task > Components: marketing >Affects Versions: Trunk >Reporter: Shivangi Tanwar >Assignee: Michael Brohl >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-7396_trunk.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7334) Remove unused imports from Groovy files
[ https://issues.apache.org/jira/browse/OFBIZ-7334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-7334: - Sprint: Community Day 2 - 2016 > Remove unused imports from Groovy files > --- > > Key: OFBIZ-7334 > URL: https://issues.apache.org/jira/browse/OFBIZ-7334 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Ankit Joshi >Assignee: Ankit Joshi >Priority: Minor > Fix For: Trunk > > > Groovy files in various components have unused package imports. These can be > removed for code optimzation purpose. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7400) Humanres : Remove unused imports from groovy files for code optimization.
[ https://issues.apache.org/jira/browse/OFBIZ-7400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-7400: Assignee: Michael Brohl > Humanres : Remove unused imports from groovy files for code optimization. > - > > Key: OFBIZ-7400 > URL: https://issues.apache.org/jira/browse/OFBIZ-7400 > Project: OFBiz > Issue Type: Sub-task > Components: humanres >Affects Versions: Trunk >Reporter: Ankit Joshi >Assignee: Michael Brohl >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-7400-trunk.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6793) Have configuration options for the ecommerce component.
[ https://issues.apache.org/jira/browse/OFBIZ-6793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-6793. Resolution: Implemented Fix Version/s: Upcoming Branch Thanks Pierre, your improvement is in trunk at revision: 1739982. > Have configuration options for the ecommerce component. > --- > > Key: OFBIZ-6793 > URL: https://issues.apache.org/jira/browse/OFBIZ-6793 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS, ALL COMPONENTS >Reporter: Pierre Smits >Assignee: Michael Brohl > Fix For: Upcoming Branch > > Attachments: OFBIZ-6793-ecommerce.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6977) Update content type data - sql queries
[ https://issues.apache.org/jira/browse/OFBIZ-6977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15247671#comment-15247671 ] Michael Brohl commented on OFBIZ-6977: -- We are going far away from the origin issue, don't we? I suggest to close this issue as "won't fix" and open a new one for the conceptual work and discussion of a better SQL processor functionality as well as webtools refactoring, ok? > Update content type data - sql queries > -- > > Key: OFBIZ-6977 > URL: https://issues.apache.org/jira/browse/OFBIZ-6977 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Michael Brohl >Priority: Minor > Attachments: OFBIZ-6977-ContentTypeData.xml.patch > > > Adding a new content type for sql queries -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6977) Update content type data - sql queries
[ https://issues.apache.org/jira/browse/OFBIZ-6977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15246399#comment-15246399 ] Michael Brohl commented on OFBIZ-6977: -- Thanks for the reference, Gil! We definetely don't want to introduce a framework to content dependency, this approach needs further conceptual work. > Update content type data - sql queries > -- > > Key: OFBIZ-6977 > URL: https://issues.apache.org/jira/browse/OFBIZ-6977 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Michael Brohl >Priority: Minor > Attachments: OFBIZ-6977-ContentTypeData.xml.patch > > > Adding a new content type for sql queries -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6977) Update content type data - sql queries
[ https://issues.apache.org/jira/browse/OFBIZ-6977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15246219#comment-15246219 ] Michael Brohl commented on OFBIZ-6977: -- I like this idea, in fact I use the SQL Processor regularly and this is a missing functionality. Do you plan to provide this feature together with the above new content type? > Update content type data - sql queries > -- > > Key: OFBIZ-6977 > URL: https://issues.apache.org/jira/browse/OFBIZ-6977 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Michael Brohl >Priority: Minor > Attachments: OFBIZ-6977-ContentTypeData.xml.patch > > > Adding a new content type for sql queries -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6793) Have configuration options for the ecommerce component.
[ https://issues.apache.org/jira/browse/OFBIZ-6793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15244676#comment-15244676 ] Michael Brohl commented on OFBIZ-6793: -- No, that's not what I'm saying. My point is: if you introduce new configuration options for tenants (tagcloud.* in this case), there should also be the changed functionality to read the tenant specific configuration from this. This should be in the patch also. Just introducing the configuration without the functionality is the same case as in OFBIZ-6976. > Have configuration options for the ecommerce component. > --- > > Key: OFBIZ-6793 > URL: https://issues.apache.org/jira/browse/OFBIZ-6793 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS, ALL COMPONENTS >Reporter: Pierre Smits >Assignee: Michael Brohl > Attachments: OFBIZ-6793-ecommerce.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6977) Update content type data - sql queries
[ https://issues.apache.org/jira/browse/OFBIZ-6977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15244651#comment-15244651 ] Michael Brohl commented on OFBIZ-6977: -- I would strongly recommend to first provide the full functionality before we add single pieces of it beforehand. Then we can be sure that we add consistent code and don't leave artifacts from unfinished approaches in the codebase. > Update content type data - sql queries > -- > > Key: OFBIZ-6977 > URL: https://issues.apache.org/jira/browse/OFBIZ-6977 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Michael Brohl >Priority: Minor > Attachments: OFBIZ-6977-ContentTypeData.xml.patch > > > Adding a new content type for sql queries -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6793) Have configuration options for the ecommerce component.
[ https://issues.apache.org/jira/browse/OFBIZ-6793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15244648#comment-15244648 ] Michael Brohl commented on OFBIZ-6793: -- Where are these configuration options used? Where is the changed functionality which are using them? I cannot see the meaning of this patch, maybe it's my fault but please be more elaborate. Thank you. > Have configuration options for the ecommerce component. > --- > > Key: OFBIZ-6793 > URL: https://issues.apache.org/jira/browse/OFBIZ-6793 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS, ALL COMPONENTS >Reporter: Pierre Smits >Assignee: Michael Brohl > Attachments: OFBIZ-6793-ecommerce.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6976) Updating data sets
[ https://issues.apache.org/jira/browse/OFBIZ-6976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15244645#comment-15244645 ] Michael Brohl commented on OFBIZ-6976: -- I have noticed that this is a placeholder issue but cannot see the sense in the current state (one placeholder and a single data entry). In my opinion a placeholder issue makes sense if it works as an umbrella task for several subtasks which have a specific goal (like the examples you have given). "Updating data sets" is, in my opinion, a little bit too open. The data sets are used for specific functions, processes or demo cases. So if we have new/changed functions or processes which need new data, I would agree. For the data sets itself I do not, notably because the only subtask does not support any new/changed function, process or demo case. Please give us a more detailed picture of what will be in this issue and subtasks, apart from that I would tend to close this issue. > Updating data sets > -- > > Key: OFBIZ-6976 > URL: https://issues.apache.org/jira/browse/OFBIZ-6976 > Project: OFBiz > Issue Type: Improvement > Components: content >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Michael Brohl > > This is a placeholder issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-6976) Updating data sets
[ https://issues.apache.org/jira/browse/OFBIZ-6976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-6976: Assignee: Michael Brohl > Updating data sets > -- > > Key: OFBIZ-6976 > URL: https://issues.apache.org/jira/browse/OFBIZ-6976 > Project: OFBiz > Issue Type: Improvement > Components: content >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Michael Brohl > > This is a placeholder issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6510) Replace webtools/control/view/ModelInduceFromDb with widgets
[ https://issues.apache.org/jira/browse/OFBIZ-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15244613#comment-15244613 ] Michael Brohl commented on OFBIZ-6510: -- I like the idea to change this, it seems to be the last functionality written in jsp. I haven't reviewed the patch(es) though, will do it if we want to follow this approach. What do others think? > Replace webtools/control/view/ModelInduceFromDb with widgets > > > Key: OFBIZ-6510 > URL: https://issues.apache.org/jira/browse/OFBIZ-6510 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl > Attachments: OFBIZ-6510.patch > > > The page is written in JSP probably from very long ago when FTL and widgets > didn't even exist yet. It should be implemented in widgets now that they are > available. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-6508) webtools/control/view/ModelInduceFromDb should support
[ https://issues.apache.org/jira/browse/OFBIZ-6508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-6508: Assignee: Michael Brohl > webtools/control/view/ModelInduceFromDb should support > - > > Key: OFBIZ-6508 > URL: https://issues.apache.org/jira/browse/OFBIZ-6508 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl > Attachments: OFBIZ-6508.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-6509) webtools/control/view/ModelInduceFromDb should support package-name attribute setting
[ https://issues.apache.org/jira/browse/OFBIZ-6509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-6509: Assignee: Michael Brohl > webtools/control/view/ModelInduceFromDb should support package-name > attribute setting > -- > > Key: OFBIZ-6509 > URL: https://issues.apache.org/jira/browse/OFBIZ-6509 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl > > OFBIZ-6508 added support for generating from ModelInduceFromDb > by adding groupName field for setting group-name attribute. > The field should be reused to allow setting the package-name > attribute also. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-6510) Replace webtools/control/view/ModelInduceFromDb with widgets
[ https://issues.apache.org/jira/browse/OFBIZ-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-6510: Assignee: Michael Brohl > Replace webtools/control/view/ModelInduceFromDb with widgets > > > Key: OFBIZ-6510 > URL: https://issues.apache.org/jira/browse/OFBIZ-6510 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl > Attachments: OFBIZ-6510.patch > > > The page is written in JSP probably from very long ago when FTL and widgets > didn't even exist yet. It should be implemented in widgets now that they are > available. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6738) Enhance PartyTypeAttr with a description field
[ https://issues.apache.org/jira/browse/OFBIZ-6738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15244610#comment-15244610 ] Michael Brohl commented on OFBIZ-6738: -- +1 > Enhance PartyTypeAttr with a description field > -- > > Key: OFBIZ-6738 > URL: https://issues.apache.org/jira/browse/OFBIZ-6738 > Project: OFBiz > Issue Type: Improvement > Components: party >Reporter: Pierre Smits >Assignee: Pierre Smits > Attachments: OFBIZ-6738-entitymodel.xml.patch > > > Currently the PartyTypeAttr entity doesn't have a means to store a > description for a PartyTypeAttr record. Having it enhances the user > experience. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-6793) Have configuration options for the ecommerce component.
[ https://issues.apache.org/jira/browse/OFBIZ-6793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-6793: Assignee: Michael Brohl (was: Pierre Smits) > Have configuration options for the ecommerce component. > --- > > Key: OFBIZ-6793 > URL: https://issues.apache.org/jira/browse/OFBIZ-6793 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS, ALL COMPONENTS >Reporter: Pierre Smits >Assignee: Michael Brohl > Attachments: OFBIZ-6793-ecommerce.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-6977) Update content type data - sql queries
[ https://issues.apache.org/jira/browse/OFBIZ-6977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-6977: Assignee: Michael Brohl (was: Pierre Smits) > Update content type data - sql queries > -- > > Key: OFBIZ-6977 > URL: https://issues.apache.org/jira/browse/OFBIZ-6977 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Michael Brohl >Priority: Minor > Attachments: OFBIZ-6977-ContentTypeData.xml.patch > > > Adding a new content type for sql queries -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6793) Have configuration options for the ecommerce component.
[ https://issues.apache.org/jira/browse/OFBIZ-6793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15244608#comment-15244608 ] Michael Brohl commented on OFBIZ-6793: -- Piere, can you be more specific about this issue and what it tries to solve? Is there any functionality corresponding to these properties? > Have configuration options for the ecommerce component. > --- > > Key: OFBIZ-6793 > URL: https://issues.apache.org/jira/browse/OFBIZ-6793 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS, ALL COMPONENTS >Reporter: Pierre Smits >Assignee: Pierre Smits > Attachments: OFBIZ-6793-ecommerce.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6976) Updating data sets
[ https://issues.apache.org/jira/browse/OFBIZ-6976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15244607#comment-15244607 ] Michael Brohl commented on OFBIZ-6976: -- Pierre, can you be more specific what this issue is used for and how the solution should work? > Updating data sets > -- > > Key: OFBIZ-6976 > URL: https://issues.apache.org/jira/browse/OFBIZ-6976 > Project: OFBiz > Issue Type: Improvement > Components: content >Affects Versions: Trunk >Reporter: Pierre Smits > > This is a placeholder issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6977) Update content type data - sql queries
[ https://issues.apache.org/jira/browse/OFBIZ-6977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15244606#comment-15244606 ] Michael Brohl commented on OFBIZ-6977: -- Will this content type be used in any standard OFBiz functionality or demo data? If not, I would not add this to the standard. If a user needs a special content type, he can add it in his project. > Update content type data - sql queries > -- > > Key: OFBIZ-6977 > URL: https://issues.apache.org/jira/browse/OFBIZ-6977 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Minor > Attachments: OFBIZ-6977-ContentTypeData.xml.patch > > > Adding a new content type for sql queries -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6373) CategoryWorker.getRelatedCategoriesRet ignores recursive-flag
[ https://issues.apache.org/jira/browse/OFBIZ-6373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-6373: - Fix Version/s: (was: Release Branch 14.12) 14.12.01 > CategoryWorker.getRelatedCategoriesRet ignores recursive-flag > - > > Key: OFBIZ-6373 > URL: https://issues.apache.org/jira/browse/OFBIZ-6373 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Release Branch 14.12, Trunk, 13.07.01 >Reporter: Sebastian Leitner >Assignee: Michael Brohl >Priority: Minor > Fix For: Release Branch 13.07, 14.12.01, Upcoming Branch > > Attachments: CategoryWorker.patch > > > Some of the CategoryWorker.getRelatedCategoriesRet methods have a flag in > their signature (boolean) to switch on/off recursiveness. But they ignore > this flag and pass 'false' to further processing. > Will attach a patch in a second. > Might also affect 14.x releases as it's in trunk and 13.07.01 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-5610) Labels for UK date formats
[ https://issues.apache.org/jira/browse/OFBIZ-5610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-5610: - Fix Version/s: (was: Release Branch 14.12) > Labels for UK date formats > -- > > Key: OFBIZ-5610 > URL: https://issues.apache.org/jira/browse/OFBIZ-5610 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk >Reporter: Gareth Carter >Assignee: Michael Brohl >Priority: Trivial > Fix For: Release Branch 13.07, 14.12.01, Upcoming Branch > > Attachments: gb_labels.patch > > > Date formats displayed in the title of the input field are not correctly > showing the default format for UK but the actual date itself is correct -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-5610) Labels for UK date formats
[ https://issues.apache.org/jira/browse/OFBIZ-5610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-5610: - Fix Version/s: 14.12.01 > Labels for UK date formats > -- > > Key: OFBIZ-5610 > URL: https://issues.apache.org/jira/browse/OFBIZ-5610 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk >Reporter: Gareth Carter >Assignee: Michael Brohl >Priority: Trivial > Fix For: Release Branch 13.07, 14.12.01, Upcoming Branch > > Attachments: gb_labels.patch > > > Date formats displayed in the title of the input field are not correctly > showing the default format for UK but the actual date itself is correct -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6310) createConditionList doesn't handle widget dropdown multi-submitted values when called by performFind
[ https://issues.apache.org/jira/browse/OFBIZ-6310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-6310: - Fix Version/s: (was: Release Branch 14.12) 14.12.01 > createConditionList doesn't handle widget dropdown multi-submitted values > when called by performFind > > > Key: OFBIZ-6310 > URL: https://issues.apache.org/jira/browse/OFBIZ-6310 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl > Fix For: Release Branch 13.07, 14.12.01, Upcoming Branch > > Attachments: OFBIZ-6310.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6398) Print Pick Sheet PDF using orderId.pdf as attachement name.
[ https://issues.apache.org/jira/browse/OFBIZ-6398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-6398: - Fix Version/s: (was: Release Branch 14.12) 14.12.01 > Print Pick Sheet PDF using orderId.pdf as attachement name. > --- > > Key: OFBIZ-6398 > URL: https://issues.apache.org/jira/browse/OFBIZ-6398 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 14.12, Upcoming Branch >Reporter: Deepak Dixit >Assignee: Michael Brohl >Priority: Minor > Fix For: 14.12.01, Upcoming Branch > > > Print Pick Sheet PDF using .pdf as attachement name. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6238) Give the order notification email attachment the orderId as filename
[ https://issues.apache.org/jira/browse/OFBIZ-6238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-6238: - Fix Version/s: (was: Release Branch 14.12) 14.12.01 > Give the order notification email attachment the orderId as filename > > > Key: OFBIZ-6238 > URL: https://issues.apache.org/jira/browse/OFBIZ-6238 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Upcoming Branch >Reporter: Martin Becker >Assignee: Michael Brohl >Priority: Trivial > Fix For: Trunk, 14.12.01 > > Attachments: OrderServices.patch > > > According to customer needs I've made a change to > OrderServices.sendOrderNotificationScreen to fill the attachmentName > parameter of the sendMailFromScreen context with the orderId to override the > default in sendMailFromScreen, so that the PDF attachments in standard order > notifications have a name like "WS10001.pdf" instead of "Details.pdf" -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-4480) Need to have an option to pass file name as OrderId for the generated confirmation or invoice PDF.
[ https://issues.apache.org/jira/browse/OFBIZ-4480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-4480: - Fix Version/s: (was: Release Branch 14.12) 14.12.01 > Need to have an option to pass file name as OrderId for the generated > confirmation or invoice PDF. > -- > > Key: OFBIZ-4480 > URL: https://issues.apache.org/jira/browse/OFBIZ-4480 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Upcoming Branch > Environment: OS - Ubuntu >Reporter: Ganesh Bawne >Assignee: Michael Brohl > Labels: filename, order, pdf > Fix For: Trunk, 14.12.01 > > Attachments: orderPdf-FileName.patch > > > Need to have set the order pdf file name to its order number when we open the > pdf from backoffice orderdetail page > (/ordermgr/control/order.pdf?orderId=X). > Currently, the default name of the pdf is always "order.pdf", instead need to > have an option to set the default pdf name to its order number? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
