[jira] [Commented] (OFBIZ-7868) Improvements in AgreementAttribute entity definition and services

2016-07-16 Thread Rahul Singh (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380738#comment-15380738
 ] 

Rahul Singh commented on OFBIZ-7868:


Added the patch to fix this issue. Thanks, [~arun.patidar] for the detailed 
description.

> Improvements in AgreementAttribute entity definition and services
> -
>
> Key: OFBIZ-7868
> URL: https://issues.apache.org/jira/browse/OFBIZ-7868
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: party
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-7868.patch
>
>
> Required improvements;
> - All is good with entity definition .
> - Add crud services using entity-auto. Make sure PK is not optional while 
> create service.
> - Do related changes if any occurrence found for direct create/update/delete 
> of this entity, and replace them with crud services implemented.
> - As no status/from date/trhu date exists in entity, so nothing needs to be 
> taken care while deleting the records from service.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7868) Improvements in AgreementAttribute entity definition and services

2016-07-16 Thread Rahul Singh (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rahul Singh updated OFBIZ-7868:
---
Attachment: OFBIZ-7868.patch

> Improvements in AgreementAttribute entity definition and services
> -
>
> Key: OFBIZ-7868
> URL: https://issues.apache.org/jira/browse/OFBIZ-7868
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: party
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-7868.patch
>
>
> Required improvements;
> - All is good with entity definition .
> - Add crud services using entity-auto. Make sure PK is not optional while 
> create service.
> - Do related changes if any occurrence found for direct create/update/delete 
> of this entity, and replace them with crud services implemented.
> - As no status/from date/trhu date exists in entity, so nothing needs to be 
> taken care while deleting the records from service.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (OFBIZ-7859) Improvements in AcctgTransTypeAttr entity definition and services

2016-07-16 Thread Rahul Singh (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380711#comment-15380711
 ] 

Rahul Singh edited comment on OFBIZ-7859 at 7/16/16 12:32 PM:
--

Added the patch to fix this issue. Thanks, [~arun.patidar] for the detailed 
description. Also, verify the same from entity engine.


was (Author: rahul.kushwah):
Added the patch to fix this issue. Thanks, [~arun.patidar] for the detailed 
description. Also, verify the same from service engine.

> Improvements in AcctgTransTypeAttr entity definition and services
> -
>
> Key: OFBIZ-7859
> URL: https://issues.apache.org/jira/browse/OFBIZ-7859
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7859.patch
>
>
> Required improvements;
>  - All is good with entity definition .
>  - Add CRUD services using entity-auto. Make sure PK is not optional while 
> create service.
>  - Do related changes if any occurrence found for direct create/update/delete 
> of this entity, and replace them with crud services implemented.
>  - As no status/from date/thru date exists in entity, so nothing needs to be 
> taken care while deleting the records from service.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7862) Improvements in AgreementItemTypeAttr entity definition and services

2016-07-16 Thread Rahul Singh (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380725#comment-15380725
 ] 

Rahul Singh commented on OFBIZ-7862:


Added the patch to fix this issue. Thanks, [~arun.patidar] for the detailed 
description. Also, verify the same from entity engine.

> Improvements in AgreementItemTypeAttr entity definition and services
> 
>
> Key: OFBIZ-7862
> URL: https://issues.apache.org/jira/browse/OFBIZ-7862
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7862.patch
>
>
> Required improvements;
>  - All is good with entity definition .
>  - Add CRUD services using entity-auto. Make sure PK is not optional while 
> create service as there is composite primary key.
>  - Do related changes if any occurrence found for direct create/update/delete 
> of this entity, and replace them with crud services implemented.
>  - As no status/from date/thru date exists in entity, so nothing needs to be 
> taken care while deleting the records from service.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7862) Improvements in AgreementItemTypeAttr entity definition and services

2016-07-16 Thread Rahul Singh (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rahul Singh updated OFBIZ-7862:
---
Attachment: OFBIZ-7862.patch

> Improvements in AgreementItemTypeAttr entity definition and services
> 
>
> Key: OFBIZ-7862
> URL: https://issues.apache.org/jira/browse/OFBIZ-7862
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7862.patch
>
>
> Required improvements;
>  - All is good with entity definition .
>  - Add CRUD services using entity-auto. Make sure PK is not optional while 
> create service as there is composite primary key.
>  - Do related changes if any occurrence found for direct create/update/delete 
> of this entity, and replace them with crud services implemented.
>  - As no status/from date/thru date exists in entity, so nothing needs to be 
> taken care while deleting the records from service.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7859) Improvements in AcctgTransTypeAttr entity definition and services

2016-07-16 Thread Rahul Singh (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380711#comment-15380711
 ] 

Rahul Singh commented on OFBIZ-7859:


Added the patch to fix this issue. Thanks, [~arun.patidar] for the detailed 
description. Also, verify the same from service engine.

> Improvements in AcctgTransTypeAttr entity definition and services
> -
>
> Key: OFBIZ-7859
> URL: https://issues.apache.org/jira/browse/OFBIZ-7859
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7859.patch
>
>
> Required improvements;
>  - All is good with entity definition .
>  - Add CRUD services using entity-auto. Make sure PK is not optional while 
> create service.
>  - Do related changes if any occurrence found for direct create/update/delete 
> of this entity, and replace them with crud services implemented.
>  - As no status/from date/thru date exists in entity, so nothing needs to be 
> taken care while deleting the records from service.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7859) Improvements in AcctgTransTypeAttr entity definition and services

2016-07-16 Thread Rahul Singh (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rahul Singh updated OFBIZ-7859:
---
Attachment: OFBIZ-7859.patch

> Improvements in AcctgTransTypeAttr entity definition and services
> -
>
> Key: OFBIZ-7859
> URL: https://issues.apache.org/jira/browse/OFBIZ-7859
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7859.patch
>
>
> Required improvements;
>  - All is good with entity definition .
>  - Add CRUD services using entity-auto. Make sure PK is not optional while 
> create service.
>  - Do related changes if any occurrence found for direct create/update/delete 
> of this entity, and replace them with crud services implemented.
>  - As no status/from date/thru date exists in entity, so nothing needs to be 
> taken care while deleting the records from service.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7837) Improvements in AccommodationMapType entity definition and services

2016-07-16 Thread Rahul Singh (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rahul Singh updated OFBIZ-7837:
---
Attachment: OFBIZ-7837.patch

> Improvements in AccommodationMapType entity definition and services
> ---
>
> Key: OFBIZ-7837
> URL: https://issues.apache.org/jira/browse/OFBIZ-7837
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7837.patch
>
>
> Required improvements;
>  - All is good with entity definition .
>  - Add crud services using entity-auto. Make sure PK is optional while create 
> service, so that can be generated from OFBiz sequence generator.
>  - Do related changes if any occurrence found for direct create/update/delete 
> of this entity, and replace them with crud services implemented.
>  - As no status/from date/thru date exists in entity, so nothing needs to be 
> taken care while deleting the records from service.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7837) Improvements in AccommodationMapType entity definition and services

2016-07-16 Thread Rahul Singh (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rahul Singh updated OFBIZ-7837:
---
Attachment: (was: OFBIZ-7837.patch)

> Improvements in AccommodationMapType entity definition and services
> ---
>
> Key: OFBIZ-7837
> URL: https://issues.apache.org/jira/browse/OFBIZ-7837
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Priority: Minor
>
> Required improvements;
>  - All is good with entity definition .
>  - Add crud services using entity-auto. Make sure PK is optional while create 
> service, so that can be generated from OFBiz sequence generator.
>  - Do related changes if any occurrence found for direct create/update/delete 
> of this entity, and replace them with crud services implemented.
>  - As no status/from date/thru date exists in entity, so nothing needs to be 
> taken care while deleting the records from service.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7837) Improvements in AccommodationMapType entity definition and services

2016-07-16 Thread Rahul Singh (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380672#comment-15380672
 ] 

Rahul Singh commented on OFBIZ-7837:


Added the patch to fix this issue. Thanks, [~arun.patidar] for the detailed 
description.

> Improvements in AccommodationMapType entity definition and services
> ---
>
> Key: OFBIZ-7837
> URL: https://issues.apache.org/jira/browse/OFBIZ-7837
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7837.patch
>
>
> Required improvements;
>  - All is good with entity definition .
>  - Add crud services using entity-auto. Make sure PK is optional while create 
> service, so that can be generated from OFBiz sequence generator.
>  - Do related changes if any occurrence found for direct create/update/delete 
> of this entity, and replace them with crud services implemented.
>  - As no status/from date/thru date exists in entity, so nothing needs to be 
> taken care while deleting the records from service.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7837) Improvements in AccommodationMapType entity definition and services

2016-07-16 Thread Rahul Singh (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rahul Singh updated OFBIZ-7837:
---
Attachment: OFBIZ-7837.patch

> Improvements in AccommodationMapType entity definition and services
> ---
>
> Key: OFBIZ-7837
> URL: https://issues.apache.org/jira/browse/OFBIZ-7837
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7837.patch
>
>
> Required improvements;
>  - All is good with entity definition .
>  - Add crud services using entity-auto. Make sure PK is optional while create 
> service, so that can be generated from OFBiz sequence generator.
>  - Do related changes if any occurrence found for direct create/update/delete 
> of this entity, and replace them with crud services implemented.
>  - As no status/from date/thru date exists in entity, so nothing needs to be 
> taken care while deleting the records from service.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7807) Enforce noninstantiability to UtilValidate class

2016-07-16 Thread Rahul Singh (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380579#comment-15380579
 ] 

Rahul Singh commented on OFBIZ-7807:


Added the patch to fix this issue. Thanks, [~arun.patidar] for the detailed 
description. Also, made other variables private.

> Enforce noninstantiability to UtilValidate class
> 
>
> Key: OFBIZ-7807
> URL: https://issues.apache.org/jira/browse/OFBIZ-7807
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7807.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make following public variable as private;
> {code}
> /** boolean specifying by default whether or not it is okay for a String 
> to be empty */
> public static final boolean defaultEmptyOK = true;
> /** digit characters */
> public static final String digits = "0123456789";
> /** hex digit characters */
> public static final String hexDigits = digits + "abcdefABCDEF";
> /** lower-case letter characters */
> public static final String lowercaseLetters = 
> "abcdefghijklmnopqrstuvwxyz";
> /** upper-case letter characters */
> public static final String uppercaseLetters = 
> "ABCDEFGHIJKLMNOPQRSTUVWXYZ";
> /** letter characters */
> public static final String letters = lowercaseLetters + uppercaseLetters;
> /** whitespace characters */
> public static final String whitespace = " \t\n\r";
> /** decimal point character differs by language and culture */
> public static final String decimalPointDelimiter = ".";
> /** non-digit characters which are allowed in phone numbers */
> public static final String phoneNumberDelimiters = "()- ";
> /** characters which are allowed in US phone numbers */
> public static final String validUSPhoneChars = digits + 
> phoneNumberDelimiters;
> /** characters which are allowed in international phone numbers(a leading 
> + is OK) */
> public static final String validWorldPhoneChars = digits + 
> phoneNumberDelimiters + "+";
> /** non-digit characters which are allowed in Social Security Numbers */
> public static final String SSNDelimiters = "- ";
> /** characters which are allowed in Social Security Numbers */
> public static final String validSSNChars = digits + SSNDelimiters;
> /** U.S. Social Security Numbers have 9 digits. They are formatted as 
> 123-45-6789. */
> public static final int digitsInSocialSecurityNumber = 9;
> /** U.S. phone numbers have 10 digits. They are formatted as 123 456 7890 
> or(123) 456-7890. */
> public static final int digitsInUSPhoneNumber = 10;
> public static final int digitsInUSPhoneAreaCode = 3;
> public static final int digitsInUSPhoneMainNumber = 7;
> /** non-digit characters which are allowed in ZIP Codes */
> public static final String ZipCodeDelimiters = "-";
> /** our preferred delimiter for reformatting ZIP Codes */
> public static final String ZipCodeDelimeter = "-";
> /** characters which are allowed in Social Security Numbers */
> public static final String validZipCodeChars = digits + ZipCodeDelimiters;
> /** U.S. ZIP codes have 5 or 9 digits. They are formatted as 12345 or 
> 12345-6789. */
> public static final int digitsInZipCode1 = 5;
> /** U.S. ZIP codes have 5 or 9 digits. They are formatted as 12345 or 
> 12345-6789. */
> public static final int digitsInZipCode2 = 9;
> /** non-digit characters which are allowed in credit card numbers */
> public static final String creditCardDelimiters = " -";
> public static final String isNotEmptyMsg = "This field cannot be empty, 
> please enter a value.";
> public static final String isStateCodeMsg = "The State Code must be a 
> valid two character U.S. state abbreviation(like CA for California).";
> public static final String isContiguousStateCodeMsg = "The State Code 
> must be a valid two character U.S. state abbreviation for one of the 48 
> contiguous United States (like CA for California).";
> public static final String isZipCodeMsg = "The ZIP Code must be a 5 or 9 
> digit U.S. ZIP Code(like 94043).";
> public static final String isUSPhoneMsg = "The US Phone must be a 10 
> digit U.S. phone number(like 415-555-1212).";
> public static final String isUSPhoneAreaCodeMsg = "The Phone Number Area 
> Code must be 3 digits.";
> public static final String isUSPhoneMainNumberMsg = "The Phone Number 
> must be 7 digits.";
> public static final String isContiguousZipCodeMsg = "Zip Code is not a 
> valid Zip Code for one of the 48 contiguous United States .";
> public static final String isInternationalPhoneNumberMsg = "The

[jira] [Updated] (OFBIZ-7807) Enforce noninstantiability to UtilValidate class

2016-07-16 Thread Rahul Singh (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rahul Singh updated OFBIZ-7807:
---
Attachment: OFBIZ-7807.patch

> Enforce noninstantiability to UtilValidate class
> 
>
> Key: OFBIZ-7807
> URL: https://issues.apache.org/jira/browse/OFBIZ-7807
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7807.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make following public variable as private;
> {code}
> /** boolean specifying by default whether or not it is okay for a String 
> to be empty */
> public static final boolean defaultEmptyOK = true;
> /** digit characters */
> public static final String digits = "0123456789";
> /** hex digit characters */
> public static final String hexDigits = digits + "abcdefABCDEF";
> /** lower-case letter characters */
> public static final String lowercaseLetters = 
> "abcdefghijklmnopqrstuvwxyz";
> /** upper-case letter characters */
> public static final String uppercaseLetters = 
> "ABCDEFGHIJKLMNOPQRSTUVWXYZ";
> /** letter characters */
> public static final String letters = lowercaseLetters + uppercaseLetters;
> /** whitespace characters */
> public static final String whitespace = " \t\n\r";
> /** decimal point character differs by language and culture */
> public static final String decimalPointDelimiter = ".";
> /** non-digit characters which are allowed in phone numbers */
> public static final String phoneNumberDelimiters = "()- ";
> /** characters which are allowed in US phone numbers */
> public static final String validUSPhoneChars = digits + 
> phoneNumberDelimiters;
> /** characters which are allowed in international phone numbers(a leading 
> + is OK) */
> public static final String validWorldPhoneChars = digits + 
> phoneNumberDelimiters + "+";
> /** non-digit characters which are allowed in Social Security Numbers */
> public static final String SSNDelimiters = "- ";
> /** characters which are allowed in Social Security Numbers */
> public static final String validSSNChars = digits + SSNDelimiters;
> /** U.S. Social Security Numbers have 9 digits. They are formatted as 
> 123-45-6789. */
> public static final int digitsInSocialSecurityNumber = 9;
> /** U.S. phone numbers have 10 digits. They are formatted as 123 456 7890 
> or(123) 456-7890. */
> public static final int digitsInUSPhoneNumber = 10;
> public static final int digitsInUSPhoneAreaCode = 3;
> public static final int digitsInUSPhoneMainNumber = 7;
> /** non-digit characters which are allowed in ZIP Codes */
> public static final String ZipCodeDelimiters = "-";
> /** our preferred delimiter for reformatting ZIP Codes */
> public static final String ZipCodeDelimeter = "-";
> /** characters which are allowed in Social Security Numbers */
> public static final String validZipCodeChars = digits + ZipCodeDelimiters;
> /** U.S. ZIP codes have 5 or 9 digits. They are formatted as 12345 or 
> 12345-6789. */
> public static final int digitsInZipCode1 = 5;
> /** U.S. ZIP codes have 5 or 9 digits. They are formatted as 12345 or 
> 12345-6789. */
> public static final int digitsInZipCode2 = 9;
> /** non-digit characters which are allowed in credit card numbers */
> public static final String creditCardDelimiters = " -";
> public static final String isNotEmptyMsg = "This field cannot be empty, 
> please enter a value.";
> public static final String isStateCodeMsg = "The State Code must be a 
> valid two character U.S. state abbreviation(like CA for California).";
> public static final String isContiguousStateCodeMsg = "The State Code 
> must be a valid two character U.S. state abbreviation for one of the 48 
> contiguous United States (like CA for California).";
> public static final String isZipCodeMsg = "The ZIP Code must be a 5 or 9 
> digit U.S. ZIP Code(like 94043).";
> public static final String isUSPhoneMsg = "The US Phone must be a 10 
> digit U.S. phone number(like 415-555-1212).";
> public static final String isUSPhoneAreaCodeMsg = "The Phone Number Area 
> Code must be 3 digits.";
> public static final String isUSPhoneMainNumberMsg = "The Phone Number 
> must be 7 digits.";
> public static final String isContiguousZipCodeMsg = "Zip Code is not a 
> valid Zip Code for one of the 48 contiguous United States .";
> public static final String isInternationalPhoneNumberMsg = "The World 
> Phone must be a valid international phone number.";
> public static final String isSSNMsg = "The SSN must be a 9 digit U.S. 
> social sec

[jira] [Commented] (OFBIZ-7812) Enforce noninstantiability to DatabaseUtil class

2016-07-15 Thread Rahul Singh (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380549#comment-15380549
 ] 

Rahul Singh commented on OFBIZ-7812:


DatabaseUtil class constructor was used in various other classes so closing 
this issue.

> Enforce noninstantiability to DatabaseUtil class
> 
>
> Key: OFBIZ-7812
> URL: https://issues.apache.org/jira/browse/OFBIZ-7812
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Reporter: Arun Patidar
>Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> - Make following protected variable as private
> {code}
>   protected ModelFieldTypeReader modelFieldTypeReader = null;
> protected Datasource datasourceInfo = null;
> protected GenericHelperInfo helperInfo = null;
> // Legacy Connections
> protected String connectionUrl = null;
> protected String driverName = null;
> protected String userName = null;
> protected String password = null;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7800) Enforce noninstantiability to CategoryWorker class

2016-07-15 Thread Rahul Singh (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380500#comment-15380500
 ] 

Rahul Singh commented on OFBIZ-7800:


Added the patch to fix this issue. Thanks, [~rishisolankii] for the detailed 
description.

> Enforce noninstantiability to  CategoryWorker class
> ---
>
> Key: OFBIZ-7800
> URL: https://issues.apache.org/jira/browse/OFBIZ-7800
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Reporter: Rishi Solanki
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7800.patch
>
>
> - Make class as final.
> - Private constructor already exists, by making it final we just matching the 
> patterns from other utility classes.
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7800) Enforce noninstantiability to CategoryWorker class

2016-07-15 Thread Rahul Singh (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rahul Singh updated OFBIZ-7800:
---
Attachment: OFBIZ-7800.patch

> Enforce noninstantiability to  CategoryWorker class
> ---
>
> Key: OFBIZ-7800
> URL: https://issues.apache.org/jira/browse/OFBIZ-7800
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Reporter: Rishi Solanki
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7800.patch
>
>
> - Make class as final.
> - Private constructor already exists, by making it final we just matching the 
> patterns from other utility classes.
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7717) Enforce noninstantiability to EntityTypeUtil class

2016-07-03 Thread Rahul Singh (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rahul Singh updated OFBIZ-7717:
---
Attachment: OFBIZ-7717.patch

> Enforce noninstantiability to EntityTypeUtil class
> --
>
> Key: OFBIZ-7717
> URL: https://issues.apache.org/jira/browse/OFBIZ-7717
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-7717.patch
>
>
> - Make class as final.
> - Add a private constructor.
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7717) Enforce noninstantiability to EntityTypeUtil class

2016-07-03 Thread Rahul Singh (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360818#comment-15360818
 ] 

Rahul Singh commented on OFBIZ-7717:


Added the patch to fix this issue. Thanks, [~rishisolankii] for the detailed 
description.

> Enforce noninstantiability to EntityTypeUtil class
> --
>
> Key: OFBIZ-7717
> URL: https://issues.apache.org/jira/browse/OFBIZ-7717
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7716) Enforce noninstantiability to CommonWorkers class

2016-07-02 Thread Rahul Singh (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rahul Singh updated OFBIZ-7716:
---
Attachment: OFBIZ-7716.patch

> Enforce noninstantiability to CommonWorkers class
> -
>
> Key: OFBIZ-7716
> URL: https://issues.apache.org/jira/browse/OFBIZ-7716
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-7716.patch
>
>
> - Make class as final.
> - Add a private constructor.
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7716) Enforce noninstantiability to CommonWorkers class

2016-07-02 Thread Rahul Singh (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360100#comment-15360100
 ] 

Rahul Singh commented on OFBIZ-7716:


Added the patch to fix this issue. Thanks, [~rishisolankii] for the detailed 
description.

> Enforce noninstantiability to CommonWorkers class
> -
>
> Key: OFBIZ-7716
> URL: https://issues.apache.org/jira/browse/OFBIZ-7716
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-7716.patch
>
>
> - Make class as final.
> - Add a private constructor.
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7708) Enforce noninstantiability to UrlServletHelper class

2016-07-02 Thread Rahul Singh (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rahul Singh updated OFBIZ-7708:
---
Attachment: OFBIZ-7708.patch

> Enforce noninstantiability to UrlServletHelper class
> 
>
> Key: OFBIZ-7708
> URL: https://issues.apache.org/jira/browse/OFBIZ-7708
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-7708.patch
>
>
> - Make class as final.
> - Add a private constructor.
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7708) Enforce noninstantiability to UrlServletHelper class

2016-07-02 Thread Rahul Singh (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360050#comment-15360050
 ] 

Rahul Singh commented on OFBIZ-7708:


Added the patch to fix this issue. Thanks, [~rishisolankii] for the detailed 
description.

> Enforce noninstantiability to UrlServletHelper class
> 
>
> Key: OFBIZ-7708
> URL: https://issues.apache.org/jira/browse/OFBIZ-7708
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-7708.patch
>
>
> - Make class as final.
> - Add a private constructor.
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7684) Enforce noninstantiability to ServiceConfigUtil class

2016-07-02 Thread Rahul Singh (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360048#comment-15360048
 ] 

Rahul Singh commented on OFBIZ-7684:


Added the patch to fix this issue. Thanks, [~rishisolankii] for the detailed 
description.

> Enforce noninstantiability to ServiceConfigUtil class
> -
>
> Key: OFBIZ-7684
> URL: https://issues.apache.org/jira/browse/OFBIZ-7684
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-7684.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final String engine = "default";
> public static final String SERVICE_ENGINE_XML_FILENAME = 
> "serviceengine.xml";
> {code}
> - Add public static method as getServiceEngineXmlFileName(), getEngine() and 
> use them in following class
> {code}
> ServiceEcaUtil.java
> ServiceGroupReader.java
> DispatchContext.java
> JobPoller.java
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7684) Enforce noninstantiability to ServiceConfigUtil class

2016-07-02 Thread Rahul Singh (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rahul Singh updated OFBIZ-7684:
---
Attachment: OFBIZ-7684.patch

> Enforce noninstantiability to ServiceConfigUtil class
> -
>
> Key: OFBIZ-7684
> URL: https://issues.apache.org/jira/browse/OFBIZ-7684
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-7684.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final String engine = "default";
> public static final String SERVICE_ENGINE_XML_FILENAME = 
> "serviceengine.xml";
> {code}
> - Add public static method as getServiceEngineXmlFileName(), getEngine() and 
> use them in following class
> {code}
> ServiceEcaUtil.java
> ServiceGroupReader.java
> DispatchContext.java
> JobPoller.java
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7689) Enforce noninstantiability to PeriodWorker class

2016-07-01 Thread Rahul Singh (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360027#comment-15360027
 ] 

Rahul Singh commented on OFBIZ-7689:


Added the patch to fix this issue. Thanks, [~rishisolankii] for the detailed 
description.

> Enforce noninstantiability to PeriodWorker class
> 
>
> Key: OFBIZ-7689
> URL: https://issues.apache.org/jira/browse/OFBIZ-7689
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-7689.patch
>
>
> - Make class as final.
> - Add a private constructor.
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7689) Enforce noninstantiability to PeriodWorker class

2016-07-01 Thread Rahul Singh (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rahul Singh updated OFBIZ-7689:
---
Attachment: OFBIZ-7689.patch

> Enforce noninstantiability to PeriodWorker class
> 
>
> Key: OFBIZ-7689
> URL: https://issues.apache.org/jira/browse/OFBIZ-7689
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-7689.patch
>
>
> - Make class as final.
> - Add a private constructor.
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7692) Enforce noninstantiability to AuthHelper class

2016-07-01 Thread Rahul Singh (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360022#comment-15360022
 ] 

Rahul Singh commented on OFBIZ-7692:


Added the patch to fix this issue. Thanks, [~rishisolankii] for the detailed 
description.

> Enforce noninstantiability to AuthHelper class
> --
>
> Key: OFBIZ-7692
> URL: https://issues.apache.org/jira/browse/OFBIZ-7692
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-7692.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following protected static variables as private
> {code}
> protected static List authenticators = new 
> ArrayList();
> protected static boolean authenticatorsLoaded = false;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7692) Enforce noninstantiability to AuthHelper class

2016-07-01 Thread Rahul Singh (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rahul Singh updated OFBIZ-7692:
---
Attachment: OFBIZ-7692.patch

> Enforce noninstantiability to AuthHelper class
> --
>
> Key: OFBIZ-7692
> URL: https://issues.apache.org/jira/browse/OFBIZ-7692
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-7692.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following protected static variables as private
> {code}
> protected static List authenticators = new 
> ArrayList();
> protected static boolean authenticatorsLoaded = false;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7691) Enforce noninstantiability to GeoWorker class

2016-07-01 Thread Rahul Singh (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rahul Singh updated OFBIZ-7691:
---
Attachment: OFBIZ-7691.patch

> Enforce noninstantiability to GeoWorker class
> -
>
> Key: OFBIZ-7691
> URL: https://issues.apache.org/jira/browse/OFBIZ-7691
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-7691.patch
>
>
> - Make class as final.
> - Add a private constructor.
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7691) Enforce noninstantiability to GeoWorker class

2016-07-01 Thread Rahul Singh (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rahul Singh updated OFBIZ-7691:
---
Attachment: (was: OFBIZ-7691.patch)

> Enforce noninstantiability to GeoWorker class
> -
>
> Key: OFBIZ-7691
> URL: https://issues.apache.org/jira/browse/OFBIZ-7691
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7691) Enforce noninstantiability to GeoWorker class

2016-07-01 Thread Rahul Singh (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360020#comment-15360020
 ] 

Rahul Singh commented on OFBIZ-7691:


Added the patch to fix this issue. Thanks, [~rishisolankii] for the detailed 
description.

> Enforce noninstantiability to GeoWorker class
> -
>
> Key: OFBIZ-7691
> URL: https://issues.apache.org/jira/browse/OFBIZ-7691
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-7691.patch
>
>
> - Make class as final.
> - Add a private constructor.
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7691) Enforce noninstantiability to GeoWorker class

2016-07-01 Thread Rahul Singh (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rahul Singh updated OFBIZ-7691:
---
Attachment: OFBIZ-7691.patch

> Enforce noninstantiability to GeoWorker class
> -
>
> Key: OFBIZ-7691
> URL: https://issues.apache.org/jira/browse/OFBIZ-7691
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-7691.patch
>
>
> - Make class as final.
> - Add a private constructor.
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7479) BshUtil class

2016-06-18 Thread Rahul Singh (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15337939#comment-15337939
 ] 

Rahul Singh commented on OFBIZ-7479:


Added the patch to fix this issue. Thanks, [~rishisolankii] for the detailed 
description.

> BshUtil class
> -
>
> Key: OFBIZ-7479
> URL: https://issues.apache.org/jira/browse/OFBIZ-7479
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-7479.patch
>
>
> - Add a private constructor.
> - Make the following protected variables as private
> {code}
> protected static ConcurrentHashMap 
> masterClassManagers = new ConcurrentHashMap();
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7479) BshUtil class

2016-06-18 Thread Rahul Singh (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rahul Singh updated OFBIZ-7479:
---
Attachment: OFBIZ-7479.patch

> BshUtil class
> -
>
> Key: OFBIZ-7479
> URL: https://issues.apache.org/jira/browse/OFBIZ-7479
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-7479.patch
>
>
> - Add a private constructor.
> - Make the following protected variables as private
> {code}
> protected static ConcurrentHashMap 
> masterClassManagers = new ConcurrentHashMap();
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7463) ShipmentWorker class

2016-06-18 Thread Rahul Singh (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15337911#comment-15337911
 ] 

Rahul Singh commented on OFBIZ-7463:


Added the patch to fix this issue. Thanks, [~rishisolankii] for the detailed 
description.

> ShipmentWorker class
> 
>
> Key: OFBIZ-7463
> URL: https://issues.apache.org/jira/browse/OFBIZ-7463
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-7463.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final MathContext generalRounding = new MathContext(10);
> {code}
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7463) ShipmentWorker class

2016-06-18 Thread Rahul Singh (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rahul Singh updated OFBIZ-7463:
---
Attachment: OFBIZ-7463.patch

> ShipmentWorker class
> 
>
> Key: OFBIZ-7463
> URL: https://issues.apache.org/jira/browse/OFBIZ-7463
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-7463.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final MathContext generalRounding = new MathContext(10);
> {code}
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7433) UtilCacheEvents Class

2016-06-18 Thread Rahul Singh (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15337811#comment-15337811
 ] 

Rahul Singh commented on OFBIZ-7433:


Added the patch to fix this issue. Thanks, [~arunpati] for the detailed 
description.

> UtilCacheEvents Class
> -
>
> Key: OFBIZ-7433
> URL: https://issues.apache.org/jira/browse/OFBIZ-7433
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7433.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final String err_resource = "WebtoolsErrorUiLabels";
> {code}
> Also, use 'err_resource' instead of UtilCacheEvents.err_resource in same class



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7433) UtilCacheEvents Class

2016-06-18 Thread Rahul Singh (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rahul Singh updated OFBIZ-7433:
---
Attachment: OFBIZ-7433.patch

> UtilCacheEvents Class
> -
>
> Key: OFBIZ-7433
> URL: https://issues.apache.org/jira/browse/OFBIZ-7433
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7433.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final String err_resource = "WebtoolsErrorUiLabels";
> {code}
> Also, use 'err_resource' instead of UtilCacheEvents.err_resource in same class



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7420) WidgetPortalPageWorker Class

2016-06-18 Thread Rahul Singh (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15337707#comment-15337707
 ] 

Rahul Singh commented on OFBIZ-7420:


Added the patch to fix this issue. Thanks, [~arunpati] for the detailed 
description.

> WidgetPortalPageWorker Class
> 
>
> Key: OFBIZ-7420
> URL: https://issues.apache.org/jira/browse/OFBIZ-7420
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7420.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static PortalPageWorkerInterface portalPageWorker = null;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7420) WidgetPortalPageWorker Class

2016-06-18 Thread Rahul Singh (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rahul Singh updated OFBIZ-7420:
---
Attachment: OFBIZ-7420.patch

> WidgetPortalPageWorker Class
> 
>
> Key: OFBIZ-7420
> URL: https://issues.apache.org/jira/browse/OFBIZ-7420
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7420.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static PortalPageWorkerInterface portalPageWorker = null;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7405) SearchWorker Class

2016-06-18 Thread Rahul Singh (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15337647#comment-15337647
 ] 

Rahul Singh commented on OFBIZ-7405:


Added the patch to fix this issue. Thanks, [~arunpati] for the detailed 
description.

> SearchWorker Class
> --
>
> Key: OFBIZ-7405
> URL: https://issues.apache.org/jira/browse/OFBIZ-7405
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: specialpurpose/lucene
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7405.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final Version LUCENE_VERSION = Version.LUCENE_5_3_1;
> {code}
> - Add a getLuceneVersion() method for getting value of private variable 
> 'LUCENE_VERSION' and Also replace the use of 'SearchWorker.LUCENE_VERSION' 
> with SearchWorker.getLuceneVersion() in class 'DocumentIndexer.java' and 
> 'LuceneTests.java'



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7405) SearchWorker Class

2016-06-18 Thread Rahul Singh (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rahul Singh updated OFBIZ-7405:
---
Attachment: OFBIZ-7405.patch

> SearchWorker Class
> --
>
> Key: OFBIZ-7405
> URL: https://issues.apache.org/jira/browse/OFBIZ-7405
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: specialpurpose/lucene
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7405.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final Version LUCENE_VERSION = Version.LUCENE_5_3_1;
> {code}
> - Add a getLuceneVersion() method for getting value of private variable 
> 'LUCENE_VERSION' and Also replace the use of 'SearchWorker.LUCENE_VERSION' 
> with SearchWorker.getLuceneVersion() in class 'DocumentIndexer.java' and 
> 'LuceneTests.java'



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (OFBIZ-7388) LayoutWorker class

2016-06-17 Thread Rahul Singh (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15337605#comment-15337605
 ] 

Rahul Singh edited comment on OFBIZ-7388 at 6/18/16 6:35 AM:
-

Provide a patch for this issue. Thanks [~rishisolankii] for the detailed 
description.


was (Author: rahul.kushwah):
Provide a patch for this issue. Thanks [~rishisolankii] for the detailed 
comment.

> LayoutWorker class
> --
>
> Key: OFBIZ-7388
> URL: https://issues.apache.org/jira/browse/OFBIZ-7388
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-7388.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final String err_resource = "ContentErrorUiLabels";
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7388) LayoutWorker class

2016-06-17 Thread Rahul Singh (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15337605#comment-15337605
 ] 

Rahul Singh commented on OFBIZ-7388:


Provide a patch for this issue. Thanks [~rishisolankii] for the detailed 
comment.

> LayoutWorker class
> --
>
> Key: OFBIZ-7388
> URL: https://issues.apache.org/jira/browse/OFBIZ-7388
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-7388.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final String err_resource = "ContentErrorUiLabels";
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7388) LayoutWorker class

2016-06-17 Thread Rahul Singh (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rahul Singh updated OFBIZ-7388:
---
Attachment: (was: LayoutWorker.patch)

> LayoutWorker class
> --
>
> Key: OFBIZ-7388
> URL: https://issues.apache.org/jira/browse/OFBIZ-7388
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-7388.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final String err_resource = "ContentErrorUiLabels";
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7388) LayoutWorker class

2016-06-17 Thread Rahul Singh (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rahul Singh updated OFBIZ-7388:
---
Attachment: OFBIZ-7388.patch

> LayoutWorker class
> --
>
> Key: OFBIZ-7388
> URL: https://issues.apache.org/jira/browse/OFBIZ-7388
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-7388.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final String err_resource = "ContentErrorUiLabels";
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7388) LayoutWorker class

2016-06-17 Thread Rahul Singh (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rahul Singh updated OFBIZ-7388:
---
Attachment: LayoutWorker.patch

> LayoutWorker class
> --
>
> Key: OFBIZ-7388
> URL: https://issues.apache.org/jira/browse/OFBIZ-7388
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
> Attachments: LayoutWorker.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final String err_resource = "ContentErrorUiLabels";
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7339) Replace EntityUtilProperties getPropertyValue method with correct method calls

2016-06-14 Thread Rahul Singh (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15331193#comment-15331193
 ] 

Rahul Singh commented on OFBIZ-7339:


Here is the patch to use methods as per their purpose at various places in the 
system. Thanks to Arun Patidar and Rishi Solanki for discussion and review.

> Replace EntityUtilProperties getPropertyValue method with correct method calls
> --
>
> Key: OFBIZ-7339
> URL: https://issues.apache.org/jira/browse/OFBIZ-7339
> Project: OFBiz
>  Issue Type: Bug
>  Components: content, framework, manufacturing, party, product, 
> securityext, specialpurpose/ecommerce, specialpurpose/lucene, 
> specialpurpose/passport, workeffort
>Affects Versions: Trunk
>Reporter: Rishi Solanki
> Attachments: EntityUtilProperties.patch
>
>
> In current OFBiz system at many places many methods implemented but not used 
> as per their purpose. One example is in EntityUtilProperties we have 
> getPropertyAsInteger() and getPropertyAsBigDecimal() and other methods which 
> returns specific type data. But at most places system uses getPropertyValue() 
> which returns string and then do explicit conversions.
> System should use proper methods for which they have been implemented.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7339) Replace EntityUtilProperties getPropertyValue method with correct method calls

2016-06-14 Thread Rahul Singh (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rahul Singh updated OFBIZ-7339:
---
Attachment: EntityUtilProperties.patch

> Replace EntityUtilProperties getPropertyValue method with correct method calls
> --
>
> Key: OFBIZ-7339
> URL: https://issues.apache.org/jira/browse/OFBIZ-7339
> Project: OFBiz
>  Issue Type: Bug
>  Components: content, framework, manufacturing, party, product, 
> securityext, specialpurpose/ecommerce, specialpurpose/lucene, 
> specialpurpose/passport, workeffort
>Affects Versions: Trunk
>Reporter: Rishi Solanki
> Attachments: EntityUtilProperties.patch
>
>
> In current OFBiz system at many places many methods implemented but not used 
> as per their purpose. One example is in EntityUtilProperties we have 
> getPropertyAsInteger() and getPropertyAsBigDecimal() and other methods which 
> returns specific type data. But at most places system uses getPropertyValue() 
> which returns string and then do explicit conversions.
> System should use proper methods for which they have been implemented.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7122) Showing Invoice address from PartyContactMech

2016-06-04 Thread Rahul Singh (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rahul Singh updated OFBIZ-7122:
---
Attachment: InvoiceWorker.patch

Adding patch to address this issue.

> Showing Invoice address from PartyContactMech
> -
>
> Key: OFBIZ-7122
> URL: https://issues.apache.org/jira/browse/OFBIZ-7122
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Upcoming Branch
>Reporter: Arun Patidar
>Assignee: Arun Patidar
> Attachments: InvoiceWorker.patch
>
>
> In getInvoiceAddressByType() method of InvoiceWorker, it is fetching address 
> from PartyContactWithPurpose in case of empty InvoiceContactMech.
> This method calls from two methods getBillToAddress() and 
> getSendFromAddress() of same class.
> Here, my concerns are:
> - There is no way to check that returned address is invoice associated 
> address or party address. It is misleading.
> - There is no control of user to get the address linked to invoice only.
> My proposals is:
> 1). System should return party address only if user really demand for it. We 
> can override method and pass additional parameter for achieving this. Systems 
> default behavior should same as current.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6870) Mismatch between time entry field display and persisted data

2016-04-16 Thread Rahul Singh (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15244183#comment-15244183
 ] 

Rahul Singh commented on OFBIZ-6870:


[~pfm.smits],

Based on your comment, Below is the proposed solution:

 We can add a property for week start day preference in general.properties 
which will be the default week start preference. Apart from this, we can also 
introduce user preference related data for the same. If the system doesn’t have 
user preference data then the default will be read from general.properties.

I will start working on it once the community is agreed upon the give solution.

Thanks,
--
Rahul Singh

> Mismatch between time entry field display and persisted data
> 
>
> Key: OFBIZ-6870
> URL: https://issues.apache.org/jira/browse/OFBIZ-6870
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/projectmgr
>Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12
>Reporter: Pierre Smits
>
> When a new time sheet is created, the fields for entering the time spent 
> starts on Monday and end on Sunday, however the date range start on Sunday 
> and ends on Saturday. And the latter range is used to persist the data. 
> So when a time entry is done in the field for Monday it is persisted on the 
> Sunday.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6870) Mismatch between time entry field display and persisted data

2016-04-16 Thread Rahul Singh (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15244166#comment-15244166
 ] 

Rahul Singh commented on OFBIZ-6870:


Hi [~pfm.smits], [~jacques.le.roux],

I looked into this issue and made following findings:

When creating a new time sheet, entry field shows a week from Monday to Sunday, 
while actually created timesheet span from Sunday to Saturday(As already 
mentioned).

While searching for the root cause of it, found 'createTimesheetForThisWeek' 
method of 'TimesheetServices' is used to set week start and end date. To set 
week start, 'getWeekStart' method of 'UtilDateTime' is called which set the 
first day of the week using Calendar's API .i.e., Sunday, and rightly as also 
mentioned in 
Document(https://cwiki.apache.org/confluence/display/OFBIZ/Calendars,+Dates,+and+Times)
 made by Adrian.

*Solutions:*
If still we agree to set week start day from Monday then following line of 
getWeekStart() method from UtilDateTime,
*tempCal.set(Calendar.DAY_OF_WEEK, tempCal.getFirstDayOfWeek());*
could be replaced with:
*tempCal.set(Calendar.DAY_OF_WEEK, tempCal.MONDAY);*
But it will have affect through out the application.

  *OR*

For time sheet which shows entry(UI) from Monday to Sunday can be changed to 
Sunday to Saturday.

Please let me know, if you have any other idea.

Thanks,
Rahul Singh

> Mismatch between time entry field display and persisted data
> 
>
> Key: OFBIZ-6870
> URL: https://issues.apache.org/jira/browse/OFBIZ-6870
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/projectmgr
>Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12
>Reporter: Pierre Smits
>
> When a new time sheet is created, the fields for entering the time spent 
> starts on Monday and end on Sunday, however the date range start on Sunday 
> and ends on Saturday. And the latter range is used to persist the data. 
> So when a time entry is done in the field for Monday it is persisted on the 
> Sunday.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Issue Comment Deleted] (OFBIZ-6870) Mismatch between time entry field display and persisted data

2016-04-16 Thread Rahul Singh (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rahul Singh updated OFBIZ-6870:
---
Comment: was deleted

(was: Hi [~pfm.smits], [~jacques.le.roux],

I looked into this issue and made following findings:

When creating a new time sheet, entry field shows a week from Monday to Sunday 
while actually created timesheet span from Sunday to Saturday(As already 
mentioned).

While searching for the root cause of it, found createTimesheetForThisWeek 
method of TimesheetServices is used to set week start and end date. To set week 
start, getWeekStart method of UtilDateTime is called which set the first day of 
the week using Calendar's API .i.e., Sunday, and rightly as also mentioned in 
Document(https://cwiki.apache.org/confluence/display/OFBIZ/Calendars,+Dates,+and+Times)
 made by Adrian.

*Solutions:*
If still we agree to set week start day from Monday then following line of 
getWeekStart() method from UtilDateTime,
*tempCal.set(Calendar.DAY_OF_WEEK, tempCal.getFirstDayOfWeek());*
could be replaced with:
*tempCal.set(Calendar.DAY_OF_WEEK, tempCal.MONDAY);*
But it will affect through out the application.

  *OR*

For time sheet which shows entry(UI) from Monday to Sunday can be changed to 
Sunday to Saturday.

Please let me know, if you have any other idea.

Thanks,
Rahul Singh)

> Mismatch between time entry field display and persisted data
> 
>
> Key: OFBIZ-6870
> URL: https://issues.apache.org/jira/browse/OFBIZ-6870
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/projectmgr
>Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12
>Reporter: Pierre Smits
>
> When a new time sheet is created, the fields for entering the time spent 
> starts on Monday and end on Sunday, however the date range start on Sunday 
> and ends on Saturday. And the latter range is used to persist the data. 
> So when a time entry is done in the field for Monday it is persisted on the 
> Sunday.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6870) Mismatch between time entry field display and persisted data

2016-04-16 Thread Rahul Singh (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15244157#comment-15244157
 ] 

Rahul Singh commented on OFBIZ-6870:


Hi [~pfm.smits], [~jacques.le.roux],

I looked into this issue and made following findings:

When creating a new time sheet, entry field shows a week from Monday to Sunday 
while actually created timesheet span from Sunday to Saturday(As already 
mentioned).

While searching for the root cause of it, found createTimesheetForThisWeek 
method of TimesheetServices is used to set week start and end date. To set week 
start, getWeekStart method of UtilDateTime is called which set the first day of 
the week using Calendar's API .i.e., Sunday, and rightly as also mentioned in 
Document(https://cwiki.apache.org/confluence/display/OFBIZ/Calendars,+Dates,+and+Times)
 made by Adrian.

*Solutions:*
If still we agree to set week start day from Monday then following line of 
getWeekStart() method from UtilDateTime,
*tempCal.set(Calendar.DAY_OF_WEEK, tempCal.getFirstDayOfWeek());*
could be replaced with:
*tempCal.set(Calendar.DAY_OF_WEEK, tempCal.MONDAY);*
But it will affect through out the application.

  *OR*

For time sheet which shows entry(UI) from Monday to Sunday can be changed to 
Sunday to Saturday.

Please let me know, if you have any other idea.

Thanks,
Rahul Singh

> Mismatch between time entry field display and persisted data
> 
>
> Key: OFBIZ-6870
> URL: https://issues.apache.org/jira/browse/OFBIZ-6870
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/projectmgr
>Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12
>Reporter: Pierre Smits
>
> When a new time sheet is created, the fields for entering the time spent 
> starts on Monday and end on Sunday, however the date range start on Sunday 
> and ends on Saturday. And the latter range is used to persist the data. 
> So when a time entry is done in the field for Monday it is persisted on the 
> Sunday.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (OFBIZ-6900) EFT payment method in party profile can't be associated with a financial account

2016-04-16 Thread Rahul Singh (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15244018#comment-15244018
 ] 

Rahul Singh edited comment on OFBIZ-6900 at 4/16/16 10:32 AM:
--

Hi [~pfm.smits], did you get chance to look into this issue?


was (Author: rahul.kushwah):
Hi Pierre, did you get chance to look into this issue?

> EFT payment method in party profile can't be associated with a financial 
> account
> 
>
> Key: OFBIZ-6900
> URL: https://issues.apache.org/jira/browse/OFBIZ-6900
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting, party
>Affects Versions: Trunk
>Reporter: Pierre Smits
>  Labels: EFT, payment, payment-method
> Attachments: EFTSetup.png, FinAccountSetup.png, financialAccount.png
>
>
> In order to be able to generate payments that will be processed through an 
> EFT account, there must be an association between a financial account and an 
> EFT account.
> However, this can't be set in either the appropriate accounting function 
> (financial account) or in the party function (set payment method).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6900) EFT payment method in party profile can't be associated with a financial account

2016-04-15 Thread Rahul Singh (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15244018#comment-15244018
 ] 

Rahul Singh commented on OFBIZ-6900:


Hi Pierre, did you get chance to look into this issue?

> EFT payment method in party profile can't be associated with a financial 
> account
> 
>
> Key: OFBIZ-6900
> URL: https://issues.apache.org/jira/browse/OFBIZ-6900
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting, party
>Affects Versions: Trunk
>Reporter: Pierre Smits
>  Labels: EFT, payment, payment-method
> Attachments: EFTSetup.png, FinAccountSetup.png, financialAccount.png
>
>
> In order to be able to generate payments that will be processed through an 
> EFT account, there must be an association between a financial account and an 
> EFT account.
> However, this can't be set in either the appropriate accounting function 
> (financial account) or in the party function (set payment method).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (OFBIZ-6900) EFT payment method in party profile can't be associated with a financial account

2016-03-19 Thread Rahul Singh (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15202784#comment-15202784
 ] 

Rahul Singh edited comment on OFBIZ-6900 at 3/19/16 2:03 PM:
-

Hi Pierre,

I have tried to regenerate it, but found it seems to work file.

Sets I followed:
1) Made an EFT account for certain party from partymgr. Please refer 
EFTSetup.png.

2) Create a new financial account with payment Id for previously made EFT. 
Please refer FinAccountSetup.png.

3) On financial account previous financial account appeared. Please refer 
financialAccount.png.

Please, let me know if you intended something else.

Regards,
Rahul Singh


was (Author: rahul.kushwah):
Hi Pierre,

I have tried to regenerate it, but found it seems to work file.

Sets I followed:
1) Made an EFT account for certain party from partymgr.
!EFTSetup.png|thumbnail!

2) Create a new financial account with payment Id for previously made EFT.
!FinAccountSetup.png|thumbnail!

3) On financial account previous financial account appeared.
!financialAccount.png|thumbnail!

Please, let me know if you intended something else.

Regards,
Rahul Singh

> EFT payment method in party profile can't be associated with a financial 
> account
> 
>
> Key: OFBIZ-6900
> URL: https://issues.apache.org/jira/browse/OFBIZ-6900
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting, party
>Affects Versions: Trunk
>Reporter: Pierre Smits
>  Labels: EFT, payment, payment-method
> Attachments: EFTSetup.png, FinAccountSetup.png, financialAccount.png
>
>
> In order to be able to generate payments that will be processed through an 
> EFT account, there must be an association between a financial account and an 
> EFT account.
> However, this can't be set in either the appropriate accounting function 
> (financial account) or in the party function (set payment method).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (OFBIZ-6900) EFT payment method in party profile can't be associated with a financial account

2016-03-19 Thread Rahul Singh (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15202784#comment-15202784
 ] 

Rahul Singh edited comment on OFBIZ-6900 at 3/19/16 2:05 PM:
-

Hi Pierre,

I have tried to regenerate it, but found it seems to work fine.

Steps I followed:
1) Made an EFT account for certain party from partymgr. Please refer 
EFTSetup.png.

2) Create a new financial account with payment Id for previously made EFT. 
Please refer FinAccountSetup.png.

3) On financial account previous financial account appeared. Please refer 
financialAccount.png.

Please, let me know if you intended something else.

Regards,
Rahul Singh


was (Author: rahul.kushwah):
Hi Pierre,

I have tried to regenerate it, but found it seems to work file.

Sets I followed:
1) Made an EFT account for certain party from partymgr. Please refer 
EFTSetup.png.

2) Create a new financial account with payment Id for previously made EFT. 
Please refer FinAccountSetup.png.

3) On financial account previous financial account appeared. Please refer 
financialAccount.png.

Please, let me know if you intended something else.

Regards,
Rahul Singh

> EFT payment method in party profile can't be associated with a financial 
> account
> 
>
> Key: OFBIZ-6900
> URL: https://issues.apache.org/jira/browse/OFBIZ-6900
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting, party
>Affects Versions: Trunk
>Reporter: Pierre Smits
>  Labels: EFT, payment, payment-method
> Attachments: EFTSetup.png, FinAccountSetup.png, financialAccount.png
>
>
> In order to be able to generate payments that will be processed through an 
> EFT account, there must be an association between a financial account and an 
> EFT account.
> However, this can't be set in either the appropriate accounting function 
> (financial account) or in the party function (set payment method).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6900) EFT payment method in party profile can't be associated with a financial account

2016-03-19 Thread Rahul Singh (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15202784#comment-15202784
 ] 

Rahul Singh commented on OFBIZ-6900:


Hi Pierre,

I have tried to regenerate it, but found it seems to work file.

Sets I followed:
1) Made an EFT account for certain party from partymgr.
!EFTSetup.png|thumbnail!

2) Create a new financial account with payment Id for previously made EFT.
!FinAccountSetup.png|thumbnail!

3) On financial account previous financial account appeared.
!financialAccount.png|thumbnail!

Please, let me know if you intended something else.

Regards,
Rahul Singh

> EFT payment method in party profile can't be associated with a financial 
> account
> 
>
> Key: OFBIZ-6900
> URL: https://issues.apache.org/jira/browse/OFBIZ-6900
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting, party
>Affects Versions: Trunk
>Reporter: Pierre Smits
>  Labels: EFT, payment, payment-method
> Attachments: EFTSetup.png, FinAccountSetup.png, financialAccount.png
>
>
> In order to be able to generate payments that will be processed through an 
> EFT account, there must be an association between a financial account and an 
> EFT account.
> However, this can't be set in either the appropriate accounting function 
> (financial account) or in the party function (set payment method).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6900) EFT payment method in party profile can't be associated with a financial account

2016-03-19 Thread Rahul Singh (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rahul Singh updated OFBIZ-6900:
---
Attachment: EFTSetup.png
financialAccount.png
FinAccountSetup.png

> EFT payment method in party profile can't be associated with a financial 
> account
> 
>
> Key: OFBIZ-6900
> URL: https://issues.apache.org/jira/browse/OFBIZ-6900
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting, party
>Affects Versions: Trunk
>Reporter: Pierre Smits
>  Labels: EFT, payment, payment-method
> Attachments: EFTSetup.png, FinAccountSetup.png, financialAccount.png
>
>
> In order to be able to generate payments that will be processed through an 
> EFT account, there must be an association between a financial account and an 
> EFT account.
> However, this can't be set in either the appropriate accounting function 
> (financial account) or in the party function (set payment method).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)