[jira] [Updated] (OFBIZ-7913) Enforce noninstantiability to TemporalExpressionWorker class
[
https://issues.apache.org/jira/browse/OFBIZ-7913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rishi Solanki updated OFBIZ-7913:
-
Description:
- Make class as final.
- Add a private constructor.
- Make the following public static variables as private
{code}
// Temporal expression type constants
public final static String DateRange = "DATE_RANGE";
public final static String DayInMonth = "DAY_IN_MONTH";
public final static String DayOfMonthRange = "DAY_OF_MONTH_RANGE";
public final static String DayOfWeekRange = "DAY_OF_WEEK_RANGE";
public final static String Difference = "DIFFERENCE";
public final static String Frequency = "FREQUENCY";
public final static String HourRange = "HOUR_RANGE";
public final static String Intersection = "INTERSECTION";
public final static String MinuteRange = "MINUTE_RANGE";
public final static String MonthRange = "MONTH_RANGE";
public final static String Substitution = "SUBSTITUTION";
public final static String Union = "UNION";
public final static String ExpressionTypeList[] = {DateRange, DayInMonth,
DayOfMonthRange, DayOfWeekRange,
Difference, Frequency, HourRange, Intersection, MinuteRange,
MonthRange, Substitution, Union};
// Temporal expression assoc type constants
public final static String INCLUDE = "INCLUDE";
public final static String EXCLUDE = "EXCLUDE";
public final static String SUBSTITUTE = "SUBSTITUTE";
{code}
- Add public static method getExpressionTypeList() and use it in the following
classes;
{code}
ExpressionUiHelper.java
{code}
- Make following protected methods as private;
{code}
protected static Set getChildExpressions(Delegator
delegator, String tempExprId) throws GenericEntityException
protected static TemporalExpression setExpressionId(GenericValue value,
TemporalExpression expression)
{code}
was:
- Make class as final.
- Add a private constructor.
- Make the following public static variables as private
{code}
// Temporal expression type constants
public final static String DateRange = "DATE_RANGE";
public final static String DayInMonth = "DAY_IN_MONTH";
public final static String DayOfMonthRange = "DAY_OF_MONTH_RANGE";
public final static String DayOfWeekRange = "DAY_OF_WEEK_RANGE";
public final static String Difference = "DIFFERENCE";
public final static String Frequency = "FREQUENCY";
public final static String HourRange = "HOUR_RANGE";
public final static String Intersection = "INTERSECTION";
public final static String MinuteRange = "MINUTE_RANGE";
public final static String MonthRange = "MONTH_RANGE";
public final static String Substitution = "SUBSTITUTION";
public final static String Union = "UNION";
public final static String ExpressionTypeList[] = {DateRange, DayInMonth,
DayOfMonthRange, DayOfWeekRange,
Difference, Frequency, HourRange, Intersection, MinuteRange,
MonthRange, Substitution, Union};
// Temporal expression assoc type constants
public final static String INCLUDE = "INCLUDE";
public final static String EXCLUDE = "EXCLUDE";
public final static String SUBSTITUTE = "SUBSTITUTE";
{code}
- Add public static method getExpressionTypeList() and use it in the following
classes;
{code}
ExpressionUiHelper.java
{code}
> Enforce noninstantiability to TemporalExpressionWorker class
>
>
> Key: OFBIZ-7913
> URL: https://issues.apache.org/jira/browse/OFBIZ-7913
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> // Temporal expression type constants
> public final static String DateRange = "DATE_RANGE";
> public final static String DayInMonth = "DAY_IN_MONTH";
> public final static String DayOfMonthRange = "DAY_OF_MONTH_RANGE";
> public final static String DayOfWeekRange = "DAY_OF_WEEK_RANGE";
> public final static String Difference = "DIFFERENCE";
> public final static String Frequency = "FREQUENCY";
> public final static String HourRange = "HOUR_RANGE";
> public final static String Intersection = "INTERSECTION";
> public final static String MinuteRange = "MINUTE_RANGE";
> public final static String MonthRange = "MONTH_RANGE";
> public final static String Substitution = "SUBSTITUTION";
> public final static String Union = "UNION";
> public final static String ExpressionTypeList[] = {DateRange, DayInMonth,
> DayOfMonthRange, DayOfWeekRange,
> Difference, Frequency, HourRange, Intersection, MinuteRange,
> MonthRange, Substitution, Union};
> // Temporal expression assoc type
[jira] [Commented] (OFBIZ-7915) Enforce noninstantiability to CategoryUtil class
[ https://issues.apache.org/jira/browse/OFBIZ-7915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385564#comment-15385564 ] Rishi Solanki commented on OFBIZ-7915: -- Community, we are going to remove it from abstract class and making it final. Please raise flag in case anyone could see problem in doing so. Thanks! > Enforce noninstantiability to CategoryUtil class > > > Key: OFBIZ-7915 > URL: https://issues.apache.org/jira/browse/OFBIZ-7915 > Project: OFBiz > Issue Type: Sub-task > Components: specialpurpose/solr >Affects Versions: Trunk >Reporter: Rishi Solanki >Priority: Minor > > - Make class as final. Also remove abstract from class. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7915) Enforce noninstantiability to CategoryUtil class
Rishi Solanki created OFBIZ-7915: Summary: Enforce noninstantiability to CategoryUtil class Key: OFBIZ-7915 URL: https://issues.apache.org/jira/browse/OFBIZ-7915 Project: OFBiz Issue Type: Sub-task Components: specialpurpose/solr Affects Versions: Trunk Reporter: Rishi Solanki Priority: Minor - Make class as final. Also remove abstract from class. - Add a private constructor. No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7914) Enforce noninstantiability to ProductUtil class
[ https://issues.apache.org/jira/browse/OFBIZ-7914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385558#comment-15385558 ] Rishi Solanki commented on OFBIZ-7914: -- Community, we are going to remove it from abstract class and making it final. Please raise flag in case anyone could see problem in doing so. Thanks! > Enforce noninstantiability to ProductUtil class > --- > > Key: OFBIZ-7914 > URL: https://issues.apache.org/jira/browse/OFBIZ-7914 > Project: OFBiz > Issue Type: Sub-task > Components: specialpurpose/solr >Affects Versions: Trunk >Reporter: Rishi Solanki >Priority: Minor > > - Make class as final. Also remove abstract from class. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7914) Enforce noninstantiability to ProductUtil class
Rishi Solanki created OFBIZ-7914: Summary: Enforce noninstantiability to ProductUtil class Key: OFBIZ-7914 URL: https://issues.apache.org/jira/browse/OFBIZ-7914 Project: OFBiz Issue Type: Sub-task Components: specialpurpose/solr Affects Versions: Trunk Reporter: Rishi Solanki Priority: Minor - Make class as final. Also remove abstract from class. - Add a private constructor. No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7913) Enforce noninstantiability to TemporalExpressionWorker class
Rishi Solanki created OFBIZ-7913:
Summary: Enforce noninstantiability to TemporalExpressionWorker
class
Key: OFBIZ-7913
URL: https://issues.apache.org/jira/browse/OFBIZ-7913
Project: OFBiz
Issue Type: Sub-task
Components: framework
Affects Versions: Trunk
Reporter: Rishi Solanki
Priority: Minor
- Make class as final.
- Add a private constructor.
- Make the following public static variables as private
{code}
// Temporal expression type constants
public final static String DateRange = "DATE_RANGE";
public final static String DayInMonth = "DAY_IN_MONTH";
public final static String DayOfMonthRange = "DAY_OF_MONTH_RANGE";
public final static String DayOfWeekRange = "DAY_OF_WEEK_RANGE";
public final static String Difference = "DIFFERENCE";
public final static String Frequency = "FREQUENCY";
public final static String HourRange = "HOUR_RANGE";
public final static String Intersection = "INTERSECTION";
public final static String MinuteRange = "MINUTE_RANGE";
public final static String MonthRange = "MONTH_RANGE";
public final static String Substitution = "SUBSTITUTION";
public final static String Union = "UNION";
public final static String ExpressionTypeList[] = {DateRange, DayInMonth,
DayOfMonthRange, DayOfWeekRange,
Difference, Frequency, HourRange, Intersection, MinuteRange,
MonthRange, Substitution, Union};
// Temporal expression assoc type constants
public final static String INCLUDE = "INCLUDE";
public final static String EXCLUDE = "EXCLUDE";
public final static String SUBSTITUTE = "SUBSTITUTE";
{code}
- Add public static method getExpressionTypeList() and use it in the following
classes;
{code}
ExpressionUiHelper.java
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (OFBIZ-7912) Enforce noninstantiability to ServiceUtil class
Rishi Solanki created OFBIZ-7912:
Summary: Enforce noninstantiability to ServiceUtil class
Key: OFBIZ-7912
URL: https://issues.apache.org/jira/browse/OFBIZ-7912
Project: OFBiz
Issue Type: Sub-task
Components: framework
Affects Versions: Trunk
Reporter: Rishi Solanki
Priority: Minor
- Make class as final.
- Add a private constructor.
- Make following public static final variables as private;
{code}
public static final String resource = "ServiceErrorUiLabels";
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (OFBIZ-7911) Enforce noninstantiability to TransactionUtil class
Rishi Solanki created OFBIZ-7911: Summary: Enforce noninstantiability to TransactionUtil class Key: OFBIZ-7911 URL: https://issues.apache.org/jira/browse/OFBIZ-7911 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: Trunk Reporter: Rishi Solanki Priority: Minor - Make class as final. - Add a private constructor. No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7891) Improvements in BudgetRevisionImpact entity definition and services
Rishi Solanki created OFBIZ-7891: Summary: Improvements in BudgetRevisionImpact entity definition and services Key: OFBIZ-7891 URL: https://issues.apache.org/jira/browse/OFBIZ-7891 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Rishi Solanki Priority: Minor Required improvements; - All is good with entity definition . - Add crud services using entity-auto. Make sure PK is not optional while create service. - Do related changes if any occurrence found for direct create/update/delete of this entity, and replace them with crud services implemented. - As no status/from date/thru date exists in entity, so nothing needs to be taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7890) Improvements in BudgetRevision entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381317#comment-15381317 ] Rishi Solanki commented on OFBIZ-7890: -- Community, we decided to not provide delete operation for this entity, could you please help us here, what should we do in such cases. Here no from date/thru date or status field exists. But it contains the historical data IMO, and as per the entity def it can not (and should not) expire. We have two option; 1) Do not provide delete service for such cases. (In ticket description I proposed to follow this.) 2) Provide delete service and let the business user decide weather to remove any record or not. We can add description in the service something like; "Entity contains historical data, and ideally not used." > Improvements in BudgetRevision entity definition and services > - > > Key: OFBIZ-7890 > URL: https://issues.apache.org/jira/browse/OFBIZ-7890 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rishi Solanki >Priority: Minor > > Required improvements; > - All is good with entity definition . > - Add crud services using entity-auto. Make sure PK is not optional while > create service. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As no status/from date/thru date exists in entity, but it looks like it > will contain the revisions of same data so history needs to be maintain. We > should not provide service for delete its record. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7890) Improvements in BudgetRevision entity definition and services
Rishi Solanki created OFBIZ-7890: Summary: Improvements in BudgetRevision entity definition and services Key: OFBIZ-7890 URL: https://issues.apache.org/jira/browse/OFBIZ-7890 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Rishi Solanki Priority: Minor Required improvements; - All is good with entity definition . - Add crud services using entity-auto. Make sure PK is not optional while create service. - Do related changes if any occurrence found for direct create/update/delete of this entity, and replace them with crud services implemented. - As no status/from date/thru date exists in entity, but it looks like it will contain the revisions of same data so history needs to be maintain. We should not provide service for delete its record. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7889) Improvements in BudgetReviewResultType entity definition and services
Rishi Solanki created OFBIZ-7889: Summary: Improvements in BudgetReviewResultType entity definition and services Key: OFBIZ-7889 URL: https://issues.apache.org/jira/browse/OFBIZ-7889 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Rishi Solanki Priority: Minor Required improvements; - All is good with entity definition . - Add crud services using entity-auto. Make sure PK is optional while create service, so that can be generated from OFBiz sequence generator. - Do related changes if any occurrence found for direct create/update/delete of this entity, and replace them with crud services implemented. - As no status/from date/thru date exists in entity, so nothing needs to be taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7868) Improvements in AgreementAttribute entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-7868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishi Solanki updated OFBIZ-7868: - Description: Required improvements; - All is good with entity definition . - Add crud services using entity-auto. Make sure PK is not optional while create service. - Do related changes if any occurrence found for direct create/update/delete of this entity, and replace them with crud services implemented. - As no status/from date/thru date exists in entity, so nothing needs to be taken care while deleting the records from service. was: Required improvements; - All is good with entity definition . - Add crud services using entity-auto. Make sure PK is not optional while create service. - Do related changes if any occurrence found for direct create/update/delete of this entity, and replace them with crud services implemented. - As no status/from date/trhu date exists in entity, so nothing needs to be taken care while deleting the records from service. > Improvements in AgreementAttribute entity definition and services > - > > Key: OFBIZ-7868 > URL: https://issues.apache.org/jira/browse/OFBIZ-7868 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: Trunk >Reporter: Rishi Solanki >Priority: Minor > Attachments: OFBIZ-7868.patch > > > Required improvements; > - All is good with entity definition . > - Add crud services using entity-auto. Make sure PK is not optional while > create service. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As no status/from date/thru date exists in entity, so nothing needs to be > taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7847) Improvements in AcctgTransEntryType entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-7847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishi Solanki updated OFBIZ-7847: - Description: Required improvements; - All is good with entity definition . - Add crud services using entity-auto. Make sure PK is optional while create service, so that can be generated from OFBiz sequence generator. - Do related changes if any occurrence found for direct create/update/delete of this entity, and replace them with crud services implemented. - As no status/from date/thru date exists in entity, so nothing needs to be taken care while deleting the records from service. was: Required improvements; - All is good with entity definition . - Add crud services using entity-auto. Make sure PK is optional while create service, so that can be generated from OFBiz sequence generator. - Do related changes if any occurrence found for direct create/update/delete of this entity, and replace them with crud services implemented. - As no status/from date/trhu date exists in entity, so nothing needs to be taken care while deleting the records from service. > Improvements in AcctgTransEntryType entity definition and services > -- > > Key: OFBIZ-7847 > URL: https://issues.apache.org/jira/browse/OFBIZ-7847 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Chinmay Patidar >Priority: Minor > Attachments: OFBIZ-7847.patch > > > Required improvements; > - All is good with entity definition . > - Add crud services using entity-auto. Make sure PK is optional while create > service, so that can be generated from OFBiz sequence generator. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As no status/from date/thru date exists in entity, so nothing needs to be > taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7831) Improvements in AccommodationClass entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-7831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishi Solanki updated OFBIZ-7831: - Description: Required improvements; - All is good with entity definition . - Add crud services using entity-auto. Make sure PK is optional while create service, so that can be generated from OFBiz sequence generator. - Do related changes if any occurrence found for direct create/update/delete of this entity, and replace them with crud services implemented. - As no status/from date/thru date exists in entity, so nothing needs to be taken care while deleting the records from service. was: Required improvements; - All is good with entity definition . - Add crud services using entity-auto. Make sure PK is optional while create service, so that can be generated from OFBiz sequence generator. - Do related changes if any occurrence found for direct create/update/delete of this entity, and replace them with crud services implemented. - As no status/from date/trhu date exists in entity, so nothing needs to be taken care while deleting the records from service. > Improvements in AccommodationClass entity definition and services > - > > Key: OFBIZ-7831 > URL: https://issues.apache.org/jira/browse/OFBIZ-7831 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Rohit Koushal >Priority: Minor > Attachments: OFBIZ-7831.patch > > > Required improvements; > - All is good with entity definition . > - Add crud services using entity-auto. Make sure PK is optional while create > service, so that can be generated from OFBiz sequence generator. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As no status/from date/thru date exists in entity, so nothing needs to be > taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7821) Remove unused system generated fields from all data files
[ https://issues.apache.org/jira/browse/OFBIZ-7821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381285#comment-15381285 ] Rishi Solanki commented on OFBIZ-7821: -- +1 for the effort, it takes time to understand a data in data file with four extra fields. Also these fields contains older dates, and create confusions. > Remove unused system generated fields from all data files > - > > Key: OFBIZ-7821 > URL: https://issues.apache.org/jira/browse/OFBIZ-7821 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Suraj Khurana >Priority: Minor > > There are four system generated fields for every entity as lastUpdatedStamp, > lastUpdatedTxStamp, createdStamp and createdTxStamp > To increase readability of data files, these fields are not necessary to be > there in data files, as it gets generated every time when data load occurs. > This ticket will be served as a parent ticket and I will be creating child > tickets component wise for all affected components. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7883) Improvements in BudgetItemTypeAttr entity definition and services
Rishi Solanki created OFBIZ-7883: Summary: Improvements in BudgetItemTypeAttr entity definition and services Key: OFBIZ-7883 URL: https://issues.apache.org/jira/browse/OFBIZ-7883 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Rishi Solanki Priority: Minor Required improvements; - All is good with entity definition . - Add CRUD services using entity-auto. Make sure PK is not optional while create service as there is composite primary key. - Do related changes if any occurrence found for direct create/update/delete of this entity, and replace them with crud services implemented. - As no status/from date/thru date exists in entity, so nothing needs to be taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7871) Improvements in AgreementType entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishi Solanki updated OFBIZ-7871: - Description: Required improvements; - All is good with entity definition . - Add crud services using entity-auto. Make sure PK is optional while create service, so that can be generated from OFBiz sequence generator. - Do related changes if any occurrence found for direct create/update/delete of this entity, and replace them with crud services implemented. - As no status/from date/thru date exists in entity, so nothing needs to be taken care while deleting the records from service. was: Required improvements; - All is good with entity definition . - Add crud services using entity-auto. Make sure PK is optional while create service, so that can be generated from OFBiz sequence generator. - Do related changes if any occurrence found for direct create/update/delete of this entity, and replace them with crud services implemented. - As no status/from date/trhu date exists in entity, so nothing needs to be taken care while deleting the records from service. > Improvements in AgreementType entity definition and services > > > Key: OFBIZ-7871 > URL: https://issues.apache.org/jira/browse/OFBIZ-7871 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: Trunk >Reporter: Rishi Solanki >Priority: Minor > Attachments: OFBIZ-7871.patch > > > Required improvements; > - All is good with entity definition . > - Add crud services using entity-auto. Make sure PK is optional while create > service, so that can be generated from OFBiz sequence generator. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As no status/from date/thru date exists in entity, so nothing needs to be > taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7882) Improvements in BudgetItemType entity definition and services
Rishi Solanki created OFBIZ-7882: Summary: Improvements in BudgetItemType entity definition and services Key: OFBIZ-7882 URL: https://issues.apache.org/jira/browse/OFBIZ-7882 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Rishi Solanki Priority: Minor Required improvements; - All is good with entity definition . - Add crud services using entity-auto. Make sure PK is optional while create service, so that can be generated from OFBiz sequence generator. - Do related changes if any occurrence found for direct create/update/delete of this entity, and replace them with crud services implemented. - As no status/from date/thru date exists in entity, so nothing needs to be taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7880) Improvements in BudgetItemAttribute entity definition and services
Rishi Solanki created OFBIZ-7880: Summary: Improvements in BudgetItemAttribute entity definition and services Key: OFBIZ-7880 URL: https://issues.apache.org/jira/browse/OFBIZ-7880 Project: OFBiz Issue Type: Sub-task Reporter: Rishi Solanki Priority: Minor Required improvements; - All is good with entity definition . - Add CRUD services using entity-auto. Make sure PK is not optional while create service as there is composite primary key. - Do related changes if any occurrence found for direct create/update/delete of this entity, and replace them with crud services implemented. - As no status/from date/thru date exists in entity, so nothing needs to be taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7878) Improvements in BudgetAttribute entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishi Solanki updated OFBIZ-7878: - Summary: Improvements in BudgetAttribute entity definition and services (was: BudgetAttribute) > Improvements in BudgetAttribute entity definition and services > -- > > Key: OFBIZ-7878 > URL: https://issues.apache.org/jira/browse/OFBIZ-7878 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rishi Solanki >Priority: Minor > > Required improvements; > - All is good with entity definition . > - Add CRUD services using entity-auto. Make sure PK is not optional while > create service as there is composite primary key. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As no status/from date/thru date exists in entity, so nothing needs to be > taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7878) BudgetAttribute
[ https://issues.apache.org/jira/browse/OFBIZ-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishi Solanki updated OFBIZ-7878: - Priority: Minor (was: Major) > BudgetAttribute > --- > > Key: OFBIZ-7878 > URL: https://issues.apache.org/jira/browse/OFBIZ-7878 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rishi Solanki >Priority: Minor > > Required improvements; > - All is good with entity definition . > - Add CRUD services using entity-auto. Make sure PK is not optional while > create service as there is composite primary key. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As no status/from date/thru date exists in entity, so nothing needs to be > taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7878) BudgetAttribute
Rishi Solanki created OFBIZ-7878: Summary: BudgetAttribute Key: OFBIZ-7878 URL: https://issues.apache.org/jira/browse/OFBIZ-7878 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Rishi Solanki Required improvements; - All is good with entity definition . - Add CRUD services using entity-auto. Make sure PK is not optional while create service as there is composite primary key. - Do related changes if any occurrence found for direct create/update/delete of this entity, and replace them with crud services implemented. - As no status/from date/thru date exists in entity, so nothing needs to be taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7845) Improvements in AcctgTransAttribute entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishi Solanki updated OFBIZ-7845: - Description: Required improvements; - All is good with entity definition . - Add crud services using entity-auto. Make sure PK is not optional while create service. - Do related changes if any occurrence found for direct create/update/delete of this entity, and replace them with crud services implemented. - As no status/from date/thru date exists in entity, so nothing needs to be taken care while deleting the records from service. was: Required improvements; - All is good with entity definition . - Add crud services using entity-auto. Make sure PK is not optional while create service. - Do related changes if any occurrence found for direct create/update/delete of this entity, and replace them with crud services implemented. - As no status/from date/trhu date exists in entity, so nothing needs to be taken care while deleting the records from service. > Improvements in AcctgTransAttribute entity definition and services > -- > > Key: OFBIZ-7845 > URL: https://issues.apache.org/jira/browse/OFBIZ-7845 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rishi Solanki >Priority: Minor > Attachments: OFBIZ-7845.patch > > > Required improvements; > - All is good with entity definition . > - Add crud services using entity-auto. Make sure PK is not optional while > create service. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As no status/from date/thru date exists in entity, so nothing needs to be > taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7839) Improvements in AccommodationMap entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-7839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishi Solanki updated OFBIZ-7839: - Description: Required improvements; - All is good with entity definition . - Add crud services using entity-auto. Make sure PK is optional while create service, so that can be generated from OFBiz sequence generator. - Do related changes if any occurrence found for direct create/update/delete of this entity, and replace them with crud services implemented. - As no status/from date/thru date exists in entity, so nothing needs to be taken care while deleting the records from service. was: Required improvements; - All is good with entity definition . - Add crud services using entity-auto. Make sure PK is optional while create service, so that can be generated from OFBiz sequence generator. - Do related changes if any occurrence found for direct create/update/delete of this entity, and replace them with crud services implemented. - As no status/from date/trhu date exists in entity, so nothing needs to be taken care while deleting the records from service. > Improvements in AccommodationMap entity definition and services > --- > > Key: OFBIZ-7839 > URL: https://issues.apache.org/jira/browse/OFBIZ-7839 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rishi Solanki >Priority: Minor > Attachments: OFBIZ-7839.patch > > > Required improvements; > - All is good with entity definition . > - Add crud services using entity-auto. Make sure PK is optional while create > service, so that can be generated from OFBiz sequence generator. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As no status/from date/thru date exists in entity, so nothing needs to be > taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7874) Improvements in BenefitType entity definition and services
Rishi Solanki created OFBIZ-7874: Summary: Improvements in BenefitType entity definition and services Key: OFBIZ-7874 URL: https://issues.apache.org/jira/browse/OFBIZ-7874 Project: OFBiz Issue Type: Sub-task Components: humanres Affects Versions: Trunk Reporter: Rishi Solanki Priority: Minor Required improvements; - All is good with entity definition . - Add crud services using entity-auto. Make sure PK is optional while create service, so that can be generated from OFBiz sequence generator. - Do related changes if any occurrence found for direct create/update/delete of this entity, and replace them with crud services implemented. - As no status/from date/trhu date exists in entity, so nothing needs to be taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7873) Improvements in BillingAccountTermAttr entity definition and services
Rishi Solanki created OFBIZ-7873: Summary: Improvements in BillingAccountTermAttr entity definition and services Key: OFBIZ-7873 URL: https://issues.apache.org/jira/browse/OFBIZ-7873 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Rishi Solanki Priority: Minor Required improvements; - All is good with entity definition . - Add crud services using entity-auto. Make sure PK is not optional while create service. - Do related changes if any occurrence found for direct create/update/delete of this entity, and replace them with crud services implemented. - As no status/from date/thru date exists in entity, so nothing needs to be taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7871) Improvements in AgreementType entity definition and services
Rishi Solanki created OFBIZ-7871: Summary: Improvements in AgreementType entity definition and services Key: OFBIZ-7871 URL: https://issues.apache.org/jira/browse/OFBIZ-7871 Project: OFBiz Issue Type: Sub-task Components: party Affects Versions: Trunk Reporter: Rishi Solanki Priority: Minor Required improvements; - All is good with entity definition . - Add crud services using entity-auto. Make sure PK is optional while create service, so that can be generated from OFBiz sequence generator. - Do related changes if any occurrence found for direct create/update/delete of this entity, and replace them with crud services implemented. - As no status/from date/trhu date exists in entity, so nothing needs to be taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7868) Improvements in AgreementAttribute entity definition and services
Rishi Solanki created OFBIZ-7868: Summary: Improvements in AgreementAttribute entity definition and services Key: OFBIZ-7868 URL: https://issues.apache.org/jira/browse/OFBIZ-7868 Project: OFBiz Issue Type: Sub-task Components: party Affects Versions: Trunk Reporter: Rishi Solanki Priority: Minor Required improvements; - All is good with entity definition . - Add crud services using entity-auto. Make sure PK is not optional while create service. - Do related changes if any occurrence found for direct create/update/delete of this entity, and replace them with crud services implemented. - As no status/from date/trhu date exists in entity, so nothing needs to be taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7828) Entity and Service definition
[ https://issues.apache.org/jira/browse/OFBIZ-7828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380679#comment-15380679 ] Rishi Solanki commented on OFBIZ-7828: -- For service definition we need to follow pattern derived from entities package-name. For example; for AccommodationClass entity, we have package-name="org.ofbiz.accounting.fixedasset" then we will add its service definition under accounting/servicedef/services_fixedasset.xml. And for AccommodationSpot entity, we have package-name="org.ofbiz.order.reservations" then we will add its service defintion under order/servicedef/services_reservations.xml. Community, please raise flag in case of concerns in this pattern. Thanks! > Entity and Service definition > - > > Key: OFBIZ-7828 > URL: https://issues.apache.org/jira/browse/OFBIZ-7828 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Arun Patidar > > As per discussion on dev list on email thread-: "Entity and Service > definition" Here is the parent task for the same. > TODO's from same thread, review entities/services on following parameters; > 1) Many entity definitions having relationships with view-entities, like > OrderHeader entity maintain relationship with OrderHeaderNoteView and > OrderItemAndShipGroupAssoc. We should remove it, maintain the relationship at > view-entities level if required. Also change the code where this relation is > in use. > 2) Many entities having service implementation exists but they can be simply > convert into entity-auto, that means can use the power OFBiz provides. > 3) As mentioned initially many entities do not have CRUD services exists, we > should implement or use entity-auto for them wherever applicable. Also remove > direct use of delegator for them. > 4) Many entities having from date and thru date, Or status Or Enumeration to > manage the historical data, but services actually remove those entity data. > We should change the service implementation to maintain the historical data. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7847) Improvements in AcctgTransEntryType entity definition and services
Rishi Solanki created OFBIZ-7847: Summary: Improvements in AcctgTransEntryType entity definition and services Key: OFBIZ-7847 URL: https://issues.apache.org/jira/browse/OFBIZ-7847 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Rishi Solanki Priority: Minor Required improvements; - All is good with entity definition . - Add crud services using entity-auto. Make sure PK is optional while create service, so that can be generated from OFBiz sequence generator. - Do related changes if any occurrence found for direct create/update/delete of this entity, and replace them with crud services implemented. - As no status/from date/trhu date exists in entity, so nothing needs to be taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7845) Improvements in AcctgTransAttribute entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishi Solanki updated OFBIZ-7845: - Description: Required improvements; - All is good with entity definition . - Add crud services using entity-auto. Make sure PK is not optional while create service. - Do related changes if any occurrence found for direct create/update/delete of this entity, and replace them with crud services implemented. - As no status/from date/trhu date exists in entity, so nothing needs to be taken care while deleting the records from service. was: Required improvements; - All is good with entity definition . - Add crud services using entity-auto. Make sure PK is not optional while create service, so that can be generated from OFBiz sequence generator. - Do related changes if any occurrence found for direct create/update/delete of this entity, and replace them with crud services implemented. - As no status/from date/trhu date exists in entity, so nothing needs to be taken care while deleting the records from service. > Improvements in AcctgTransAttribute entity definition and services > -- > > Key: OFBIZ-7845 > URL: https://issues.apache.org/jira/browse/OFBIZ-7845 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rishi Solanki >Priority: Minor > > Required improvements; > - All is good with entity definition . > - Add crud services using entity-auto. Make sure PK is not optional while > create service. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As no status/from date/trhu date exists in entity, so nothing needs to be > taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7845) Improvements in AcctgTransAttribute entity definition and services
Rishi Solanki created OFBIZ-7845: Summary: Improvements in AcctgTransAttribute entity definition and services Key: OFBIZ-7845 URL: https://issues.apache.org/jira/browse/OFBIZ-7845 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Rishi Solanki Priority: Minor Required improvements; - All is good with entity definition . - Add crud services using entity-auto. Make sure PK is not optional while create service, so that can be generated from OFBiz sequence generator. - Do related changes if any occurrence found for direct create/update/delete of this entity, and replace them with crud services implemented. - As no status/from date/trhu date exists in entity, so nothing needs to be taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7839) Improvements in AccommodationMap entity definition and services
Rishi Solanki created OFBIZ-7839: Summary: Improvements in AccommodationMap entity definition and services Key: OFBIZ-7839 URL: https://issues.apache.org/jira/browse/OFBIZ-7839 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Rishi Solanki Priority: Minor Required improvements; - All is good with entity definition . - Add crud services using entity-auto. Make sure PK is optional while create service, so that can be generated from OFBiz sequence generator. - Do related changes if any occurrence found for direct create/update/delete of this entity, and replace them with crud services implemented. - As no status/from date/trhu date exists in entity, so nothing needs to be taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7831) Improvements in AccommodationClass entity definition and services
Rishi Solanki created OFBIZ-7831: Summary: Improvements in AccommodationClass entity definition and services Key: OFBIZ-7831 URL: https://issues.apache.org/jira/browse/OFBIZ-7831 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Rishi Solanki Priority: Minor Required improvements; - All is good with entity definition . - Add crud services using entity-auto. Make sure PK is optional while create service, so that can be generated from OFBiz sequence generator. - Do related changes if any occurrence found for direct create/update/delete of this entity, and replace them with crud services implemented. - As no status/from date/trhu date exists in entity, so nothing needs to be taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7828) Entity and Service definition
[ https://issues.apache.org/jira/browse/OFBIZ-7828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishi Solanki updated OFBIZ-7828: - Priority: Major (was: Minor) > Entity and Service definition > - > > Key: OFBIZ-7828 > URL: https://issues.apache.org/jira/browse/OFBIZ-7828 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Rishi Solanki > > As per discussion on dev list on email thread-: "Entity and Service > definition" Here is the parent task for the same. > TODO's from same thread, review entities/services on following parameters; > 1) Many entity definitions having relationships with view-entities, like > OrderHeader entity maintain relationship with OrderHeaderNoteView and > OrderItemAndShipGroupAssoc. We should remove it, maintain the relationship at > view-entities level if required. Also change the code where this relation is > in use. > 2) Many entities having service implementation exists but they can be simply > convert into entity-auto, that means can use the power OFBiz provides. > 3) As mentioned initially many entities do not have CRUD services exists, we > should implement or use entity-auto for them wherever applicable. Also remove > direct use of delegator for them. > 4) Many entities having from date and thru date, Or status Or Enumeration to > manage the historical data, but services actually remove those entity data. > We should change the service implementation to maintain the historical data. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7828) Entity and Service definition
Rishi Solanki created OFBIZ-7828: Summary: Entity and Service definition Key: OFBIZ-7828 URL: https://issues.apache.org/jira/browse/OFBIZ-7828 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: Trunk Reporter: Rishi Solanki Priority: Minor As per discussion on dev list on email thread-: "Entity and Service definition" Here is the parent task for the same. TODO's from same thread, review entities/services on following parameters; 1) Many entity definitions having relationships with view-entities, like OrderHeader entity maintain relationship with OrderHeaderNoteView and OrderItemAndShipGroupAssoc. We should remove it, maintain the relationship at view-entities level if required. Also change the code where this relation is in use. 2) Many entities having service implementation exists but they can be simply convert into entity-auto, that means can use the power OFBiz provides. 3) As mentioned initially many entities do not have CRUD services exists, we should implement or use entity-auto for them wherever applicable. Also remove direct use of delegator for them. 4) Many entities having from date and thru date, Or status Or Enumeration to manage the historical data, but services actually remove those entity data. We should change the service implementation to maintain the historical data. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7272) Enforce noninstantiability to all Utility classes
[
https://issues.apache.org/jira/browse/OFBIZ-7272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380557#comment-15380557
]
Rishi Solanki commented on OFBIZ-7272:
--
Few more classes needs to be taken care or discuss;
{code}
framework/entity/src/org/ofbiz/entity/transaction/TransactionUtil.java
framework/service/src/org/ofbiz/service/ServiceUtil.java
framework/service/src/org/ofbiz/service/calendar/TemporalExpressionWorker.java
DataResourceWorker.java
ProductUtil.java
CategoryUtil.java
StartupCommandUtil.java
ICalWorker.java
JNDIConfigUtil.java
{code}
> Enforce noninstantiability to all Utility classes
> -
>
> Key: OFBIZ-7272
> URL: https://issues.apache.org/jira/browse/OFBIZ-7272
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Arun Patidar
> Attachments: OFBIZ-7272.patch
>
>
> I have discusses this in past on mailing list, that Utility, helper, worker
> classes which contains only static methods should not be instantiable. Also
> we can restrict it by adding a private constructor.
> Currently OFBiz has many such classes which should have private constructor.
> Identify all the *Worker.java, *.Helper.java, and *Util.java which do not
> have any non static method/member are eligible for having a private
> constructor.
> Reference why we should do this :
> http://www.informit.com/articles/article.aspx?p=1216151=4
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (OFBIZ-7812) Enforce noninstantiability to DatabaseUtil class
[
https://issues.apache.org/jira/browse/OFBIZ-7812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rishi Solanki closed OFBIZ-7812.
Resolution: Invalid
Assignee: Rishi Solanki
> Enforce noninstantiability to DatabaseUtil class
>
>
> Key: OFBIZ-7812
> URL: https://issues.apache.org/jira/browse/OFBIZ-7812
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Reporter: Arun Patidar
>Assignee: Rishi Solanki
>Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> - Make following protected variable as private
> {code}
> protected ModelFieldTypeReader modelFieldTypeReader = null;
> protected Datasource datasourceInfo = null;
> protected GenericHelperInfo helperInfo = null;
> // Legacy Connections
> protected String connectionUrl = null;
> protected String driverName = null;
> protected String userName = null;
> protected String password = null;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7812) Enforce noninstantiability to DatabaseUtil class
[
https://issues.apache.org/jira/browse/OFBIZ-7812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380546#comment-15380546
]
Rishi Solanki commented on OFBIZ-7812:
--
DataBaseUtil class by name looks like a utility class which contains the static
method. But by implementation it is not a class which can not be instantiated.
So this class won't come under this effort. We can close this ticket. Thanks to
[~arunpati] and [~rohit.koushal], [~rahul.kushwah] for discussion and
finalizing.
> Enforce noninstantiability to DatabaseUtil class
>
>
> Key: OFBIZ-7812
> URL: https://issues.apache.org/jira/browse/OFBIZ-7812
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Reporter: Arun Patidar
>Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> - Make following protected variable as private
> {code}
> protected ModelFieldTypeReader modelFieldTypeReader = null;
> protected Datasource datasourceInfo = null;
> protected GenericHelperInfo helperInfo = null;
> // Legacy Connections
> protected String connectionUrl = null;
> protected String driverName = null;
> protected String userName = null;
> protected String password = null;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7810) Enforce noninstantiability to UelUtil class
[
https://issues.apache.org/jira/browse/OFBIZ-7810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rishi Solanki updated OFBIZ-7810:
-
Description:
- Make class as final.
- Add a private constructor.
- Make following protected variable as private
{code}
protected static final ExpressionFactory exprFactory =
JuelConnector.newExpressionFactory();
protected static final ELResolver defaultResolver = new
ExtendedCompositeResolver()
{code}
- Make following protected classes as private and do related changes for
variables in them;
{code}
protected static class BasicContext extends ELContext
protected static class ReadOnlyContext extends ELContext
protected static class ReadOnlyVariableMapper extends VariableMapper
protected static class BasicVariableMapper extends VariableMapper
protected static class ReadOnlyExpression extends ValueExpression
protected static class BasicValueExpression extends ValueExpression
protected static class ExtendedCompositeResolver extends CompositeELResolver
protected static class ExtendedListResolver extends ListELResolver
protected static class ExtendedMapResolver extends MapELResolver
{code}
was:
- Make class as final.
- Add a private constructor.
- Make following protected variable as private
{code}
protected static final ExpressionFactory exprFactory =
JuelConnector.newExpressionFactory();
protected static final ELResolver defaultResolver = new
ExtendedCompositeResolver()
{code}
> Enforce noninstantiability to UelUtil class
> ---
>
> Key: OFBIZ-7810
> URL: https://issues.apache.org/jira/browse/OFBIZ-7810
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> - Make following protected variable as private
> {code}
> protected static final ExpressionFactory exprFactory =
> JuelConnector.newExpressionFactory();
> protected static final ELResolver defaultResolver = new
> ExtendedCompositeResolver()
> {code}
> - Make following protected classes as private and do related changes for
> variables in them;
> {code}
> protected static class BasicContext extends ELContext
> protected static class ReadOnlyContext extends ELContext
>protected static class ReadOnlyVariableMapper extends VariableMapper
> protected static class BasicVariableMapper extends VariableMapper
> protected static class ReadOnlyExpression extends ValueExpression
> protected static class BasicValueExpression extends ValueExpression
> protected static class ExtendedCompositeResolver extends
> CompositeELResolver
> protected static class ExtendedListResolver extends ListELResolver
> protected static class ExtendedMapResolver extends MapELResolver
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7807) Enforce noninstantiability to UtilValidate class
[
https://issues.apache.org/jira/browse/OFBIZ-7807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rishi Solanki updated OFBIZ-7807:
-
Description:
- Make class as final.
- Add a private constructor.
- Make following public variable as private;
{code}
/** boolean specifying by default whether or not it is okay for a String to
be empty */
public static final boolean defaultEmptyOK = true;
/** digit characters */
public static final String digits = "0123456789";
/** hex digit characters */
public static final String hexDigits = digits + "abcdefABCDEF";
/** lower-case letter characters */
public static final String lowercaseLetters = "abcdefghijklmnopqrstuvwxyz";
/** upper-case letter characters */
public static final String uppercaseLetters = "ABCDEFGHIJKLMNOPQRSTUVWXYZ";
/** letter characters */
public static final String letters = lowercaseLetters + uppercaseLetters;
/** whitespace characters */
public static final String whitespace = " \t\n\r";
/** decimal point character differs by language and culture */
public static final String decimalPointDelimiter = ".";
/** non-digit characters which are allowed in phone numbers */
public static final String phoneNumberDelimiters = "()- ";
/** characters which are allowed in US phone numbers */
public static final String validUSPhoneChars = digits +
phoneNumberDelimiters;
/** characters which are allowed in international phone numbers(a leading +
is OK) */
public static final String validWorldPhoneChars = digits +
phoneNumberDelimiters + "+";
/** non-digit characters which are allowed in Social Security Numbers */
public static final String SSNDelimiters = "- ";
/** characters which are allowed in Social Security Numbers */
public static final String validSSNChars = digits + SSNDelimiters;
/** U.S. Social Security Numbers have 9 digits. They are formatted as
123-45-6789. */
public static final int digitsInSocialSecurityNumber = 9;
/** U.S. phone numbers have 10 digits. They are formatted as 123 456 7890
or(123) 456-7890. */
public static final int digitsInUSPhoneNumber = 10;
public static final int digitsInUSPhoneAreaCode = 3;
public static final int digitsInUSPhoneMainNumber = 7;
/** non-digit characters which are allowed in ZIP Codes */
public static final String ZipCodeDelimiters = "-";
/** our preferred delimiter for reformatting ZIP Codes */
public static final String ZipCodeDelimeter = "-";
/** characters which are allowed in Social Security Numbers */
public static final String validZipCodeChars = digits + ZipCodeDelimiters;
/** U.S. ZIP codes have 5 or 9 digits. They are formatted as 12345 or
12345-6789. */
public static final int digitsInZipCode1 = 5;
/** U.S. ZIP codes have 5 or 9 digits. They are formatted as 12345 or
12345-6789. */
public static final int digitsInZipCode2 = 9;
/** non-digit characters which are allowed in credit card numbers */
public static final String creditCardDelimiters = " -";
public static final String isNotEmptyMsg = "This field cannot be empty,
please enter a value.";
public static final String isStateCodeMsg = "The State Code must be a valid
two character U.S. state abbreviation(like CA for California).";
public static final String isContiguousStateCodeMsg = "The State Code must
be a valid two character U.S. state abbreviation for one of the 48 contiguous
United States (like CA for California).";
public static final String isZipCodeMsg = "The ZIP Code must be a 5 or 9
digit U.S. ZIP Code(like 94043).";
public static final String isUSPhoneMsg = "The US Phone must be a 10 digit
U.S. phone number(like 415-555-1212).";
public static final String isUSPhoneAreaCodeMsg = "The Phone Number Area
Code must be 3 digits.";
public static final String isUSPhoneMainNumberMsg = "The Phone Number must
be 7 digits.";
public static final String isContiguousZipCodeMsg = "Zip Code is not a
valid Zip Code for one of the 48 contiguous United States .";
public static final String isInternationalPhoneNumberMsg = "The World Phone
must be a valid international phone number.";
public static final String isSSNMsg = "The SSN must be a 9 digit U.S.
social security number(like 123-45-6789).";
public static final String isEmailMsg = "The Email must be a valid email
address(like j...@email.com). Please re-enter it now.";
public static final String isAnyCardMsg = "The credit card number is not a
valid card number.";
public static final String isCreditCardPrefixMsg = " is not a valid ";
public static final String isCreditCardSuffixMsg = " credit card number.";
public static final String isDayMsg = "The Day must be a day number between
1 and 31. ";
public static final String isMonthMsg = "The Month must be a month
[jira] [Created] (OFBIZ-7803) Enforce noninstantiability to UtilMisc class
Rishi Solanki created OFBIZ-7803:
Summary: Enforce noninstantiability to UtilMisc class
Key: OFBIZ-7803
URL: https://issues.apache.org/jira/browse/OFBIZ-7803
Project: OFBiz
Issue Type: Sub-task
Components: framework
Affects Versions: Trunk
Reporter: Rishi Solanki
Priority: Minor
- Make class as final.
- Private constructor already exists, by making it final we just matching the
patterns from other utility classes.
- Make following public static final variables as private;
{code}
public static final BigDecimal ZERO_BD = BigDecimal.ZERO;
{code}
- Nothing needs to be change for the private static class as it follows all
patterns;
{code}
// Private lazy-initializer class
private static class LocaleHolder
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (OFBIZ-7802) Enforce noninstantiability to ProductWorker class
Rishi Solanki created OFBIZ-7802:
Summary: Enforce noninstantiability to ProductWorker class
Key: OFBIZ-7802
URL: https://issues.apache.org/jira/browse/OFBIZ-7802
Project: OFBiz
Issue Type: Sub-task
Components: product
Affects Versions: Trunk
Reporter: Rishi Solanki
Priority: Minor
- Make class as final.
- Private constructor already exists, by making it final we just matching the
patterns from other utility classes.
- Make following public static final variables as private;
{code}
public static final String resource = "ProductUiLabels";
public static final MathContext generalRounding = new MathContext(10);
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (OFBIZ-7800) Enforce noninstantiability to CategoryWorker class
Rishi Solanki created OFBIZ-7800: Summary: Enforce noninstantiability to CategoryWorker class Key: OFBIZ-7800 URL: https://issues.apache.org/jira/browse/OFBIZ-7800 Project: OFBiz Issue Type: Sub-task Components: product Reporter: Rishi Solanki Priority: Minor Fix For: Trunk - Make class as final. - Private constructor already exists, by making it final we just matching the patterns from other utility classes. No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7799) Enforce noninstantiability to CatalogWorker class
[ https://issues.apache.org/jira/browse/OFBIZ-7799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishi Solanki updated OFBIZ-7799: - Affects Version/s: Trunk > Enforce noninstantiability to CatalogWorker class > - > > Key: OFBIZ-7799 > URL: https://issues.apache.org/jira/browse/OFBIZ-7799 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Rishi Solanki >Priority: Minor > > - Make class as final. > - Private constructor already exists, by making it final we just matching the > patterns from other utility classes. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7799) Enforce noninstantiability to CatalogWorker class
[ https://issues.apache.org/jira/browse/OFBIZ-7799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishi Solanki updated OFBIZ-7799: - Component/s: (was: ALL COMPONENTS) product > Enforce noninstantiability to CatalogWorker class > - > > Key: OFBIZ-7799 > URL: https://issues.apache.org/jira/browse/OFBIZ-7799 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Rishi Solanki >Priority: Minor > > - Make class as final. > - Private constructor already exists, by making it final we just matching the > patterns from other utility classes. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7799) Enforce noninstantiability to CatalogWorker class
Rishi Solanki created OFBIZ-7799: Summary: Enforce noninstantiability to CatalogWorker class Key: OFBIZ-7799 URL: https://issues.apache.org/jira/browse/OFBIZ-7799 Project: OFBiz Issue Type: Sub-task Reporter: Rishi Solanki Priority: Minor - Make class as final. - Private constructor already exists, by making it final we just matching the patterns from other utility classes. No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7622) Add "changeByUserLoginId" field for CustRequestStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372913#comment-15372913 ] Rishi Solanki commented on OFBIZ-7622: -- [~julien.nicolas]: Sorry I still disagree on this, to manage fields creation and its relationship in this way. In case we found more entities which requires the same field then we will be altering the final static map probably (defined to manage the list of entities manage this extra field). I think its better to have the entities fields with them, instead of create them from any configuration. Also we are increasing responsibilities of EntityAutoEngine or GenericDAO or ModelEntity. It could be out of scope but we should consider this before assigning more responsibilities to same class. I'm good, if we found some good reason to make it configurable. As I see for few entities change by user login is must from business perspective and for few it may be optional. So enabling/disabling all from one configuration seems okay to me, and managing it at entity level seems better. Thanks! > Add "changeByUserLoginId" field for CustRequestStatus > - > > Key: OFBIZ-7622 > URL: https://issues.apache.org/jira/browse/OFBIZ-7622 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Julien NICOLAS > Attachments: OFBIZ-7622.patch, OFBIZ-7622.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-7622) Add "changeByUserLoginId" field for CustRequestStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372707#comment-15372707 ] Rishi Solanki edited comment on OFBIZ-7622 at 7/12/16 11:32 AM: Adding user login at each entity and logging an additional filed for all and maintaining the relationship by default with UserLogin entity. In first look it looks like good idea, but it will come with many challenges. IMO, we should check the business needs of each entity and decide weather to do this for that entity or not. For example, for all the type entities do we really need change by userLogin?. Type entities are in hundreds, why should they maintain the relationship. Also all the intersection entities like PartyContactMech, ProductCategoryMember, ProductAssoc, ProductCategoryRollup and many more, why these entities requires this extra field and relationship? Also for each relationship databases manage indexes, which will increase the db size for the same data. I would say many entities may require user login field, but all requires some discussion, review, and closer look before proceeding. Maintaining this like DATE fields is not look a good idea to me, instead adding this field wherever required after discussion looks better to me. In that process (reviewing and adding user login field to other entities) if we found all the entities should maintain user login then we can proceed and think of adding user login for all. was (Author: rishisolankii): Adding user login at each entity and logging an additional filed for all and maintaining the relationship by default with UserLogin entity. In first look it looks like good idea, but it will come with many challenges. IMO, we should check the business needs of each entity and decide weather to do this for that entity or not. For example, for all the type entities do we really need change by userLogin?. Type entities are in hundreds, why should they maintain the relationship. Also all the intersection entities like PartyContactMech, ProductCategoryMember, ProductAssoc, ProductCategoryRollup and many more, why these entities requires this extra field and relationship? Also for each relationship databases manage indexes, which will increase the db size with for the same data. I would say many entities may require user login field, but all requires some discussion, review, and closer look before proceeding. Maintaining this like DATE fields is not look a good idea to me, instead adding this field wherever required after discussion looks better to me. In that process (reviewing and adding user login field to other entities) if we found all the entities should maintain user login then we can proceed and think of adding user login for all. > Add "changeByUserLoginId" field for CustRequestStatus > - > > Key: OFBIZ-7622 > URL: https://issues.apache.org/jira/browse/OFBIZ-7622 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Julien NICOLAS > Attachments: OFBIZ-7622.patch, OFBIZ-7622.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-7622) Add "changeByUserLoginId" field for CustRequestStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372707#comment-15372707 ] Rishi Solanki edited comment on OFBIZ-7622 at 7/12/16 11:31 AM: Adding user login at each entity and logging an additional filed for all and maintaining the relationship by default with UserLogin entity. In first look it looks like good idea, but it will come with many challenges. IMO, we should check the business needs of each entity and decide weather to do this for that entity or not. For example, for all the type entities do we really need change by userLogin?. Type entities are in hundreds, why should they maintain the relationship. Also all the intersection entities like PartyContactMech, ProductCategoryMember, ProductAssoc, ProductCategoryRollup and many more, why these entities requires this extra field and relationship? Also for each relationship databases manage indexes, which will increase the db size with for the same data. I would say many entities may require user login field, but all requires some discussion, review, and closer look before proceeding. Maintaining this like DATE fields is not look a good idea to me, instead adding this field wherever required after discussion looks better to me. In that process (reviewing and adding user login field to other entities) if we found all the entities should maintain user login then we can proceed and think of adding user login for all. was (Author: rishisolankii): Adding user login at each entity and logging an additional filed for all and maintaining the relationship by default with UserLogin entity. In first look it looks like good idea, but it will come with many challenges. IMO, we should check the business needs of each entity and decide weather to do this for that entity or not. For example, for all the type entities do we really need change by userLogin?. Type entities are in hundreds, why should they maintain the relationship. Also all the intersection entities like PartyContactMech, ProductCategoryMember, ProductAssoc, ProductCategoryRollup and many more, why these entities requires this extra field and relationship? I would say many entities may require user login field, but all requires some discussion, review, and closer look before proceeding. Maintaining this like DATE fields is not look a good idea to me, instead adding this field wherever required after discussion looks better to me. In that process (reviewing) if we found all the entities should maintain user login then we can proceed and think of adding user login for all. > Add "changeByUserLoginId" field for CustRequestStatus > - > > Key: OFBIZ-7622 > URL: https://issues.apache.org/jira/browse/OFBIZ-7622 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Julien NICOLAS > Attachments: OFBIZ-7622.patch, OFBIZ-7622.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7622) Add "changeByUserLoginId" field for CustRequestStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372707#comment-15372707 ] Rishi Solanki commented on OFBIZ-7622: -- Adding user login at each entity and logging an additional filed for all and maintaining the relationship by default with UserLogin entity. In first look it looks like good idea, but it will come with many challenges. IMO, we should check the business needs of each entity and decide weather to do this for that entity or not. For example, for all the type entities do we really need change by userLogin?. Type entities are in hundreds, why should they maintain the relationship. Also all the intersection entities like PartyContactMech, ProductCategoryMember, ProductAssoc, ProductCategoryRollup and many more, why these entities requires this extra field and relationship? I would say many entities may require user login field, but all requires some discussion, review, and closer look before proceeding. Maintaining this like DATE fields is not look a good idea to me, instead adding this field wherever required after discussion looks better to me. In that process (reviewing) if we found all the entities should maintain user login then we can proceed and think of adding user login for all. > Add "changeByUserLoginId" field for CustRequestStatus > - > > Key: OFBIZ-7622 > URL: https://issues.apache.org/jira/browse/OFBIZ-7622 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Julien NICOLAS > Attachments: OFBIZ-7622.patch, OFBIZ-7622.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7765) Replace call with
[ https://issues.apache.org/jira/browse/OFBIZ-7765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15370599#comment-15370599 ] Rishi Solanki commented on OFBIZ-7765: -- Thanks Deepak! > Replace call with
[jira] [Commented] (OFBIZ-7763) Replace bshInterpreter with groovyShell
[ https://issues.apache.org/jira/browse/OFBIZ-7763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15370508#comment-15370508 ] Rishi Solanki commented on OFBIZ-7763: -- Reported issue with probable solution on sub-ticket: https://issues.apache.org/jira/browse/OFBIZ-7765 > Replace bshInterpreter with groovyShell > --- > > Key: OFBIZ-7763 > URL: https://issues.apache.org/jira/browse/OFBIZ-7763 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne > Attachments: OFBIZ-7763.patch, OFBIZ-7763.patch, > beanshell-removal-part1.patch > > > To support the migration to gradle, removing bsh.jar dependency from the > project, and improve readability and fonctionnalities following > [~deepak.dixit] idea expressed here > https://issues.apache.org/jira/browse/OFBIZ-7576?focusedCommentId=15347972 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7765) Replace call with
[
https://issues.apache.org/jira/browse/OFBIZ-7765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15370505#comment-15370505
]
Rishi Solanki commented on OFBIZ-7765:
--
Not sure if this is right ticket to report this issue;
When user tries to browse - https://localhost:8443/webtools/control/ServiceList
receives following exception:
{code}
org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen
[component://webtools/widget/ServiceScreens.xml#ServiceList]:
java.lang.IllegalArgumentException: Error running script at location
[component://webtools/groovyScripts/service/AvailableServices.groovy]:
org.ofbiz.service.GenericServiceException: Cannot locate service by name
(testBsh) (Error running script at location
[component://webtools/groovyScripts/service/AvailableServices.groovy]:
org.ofbiz.service.GenericServiceException: Cannot locate service by name
(testBsh))
{code}
On further look into the issue found that testBsh service definition commented
in the services_test.xml and removed from other places. But this is in use
groups_test.xml and secas_test.xml of framework/common/./. After commenting
both entries I'm able to browse the shared screen of service list.
Thanks!
> Replace call with
[jira] [Commented] (OFBIZ-7272) Enforce noninstantiability to all Utility classes
[ https://issues.apache.org/jira/browse/OFBIZ-7272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364242#comment-15364242 ] Rishi Solanki commented on OFBIZ-7272: -- [~jacques.le.roux]: Thanks for review and feedback, it is like energy booster for us. [~arunpati]: I have extracted few more classes which are under discussion, I'll sync with you on this in next week and try to complete the effort. > Enforce noninstantiability to all Utility classes > - > > Key: OFBIZ-7272 > URL: https://issues.apache.org/jira/browse/OFBIZ-7272 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Arun Patidar > Attachments: OFBIZ-7272.patch > > > I have discusses this in past on mailing list, that Utility, helper, worker > classes which contains only static methods should not be instantiable. Also > we can restrict it by adding a private constructor. > Currently OFBiz has many such classes which should have private constructor. > Identify all the *Worker.java, *.Helper.java, and *Util.java which do not > have any non static method/member are eligible for having a private > constructor. > Reference why we should do this : > http://www.informit.com/articles/article.aspx?p=1216151=4 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7717) Enforce noninstantiability to EntityTypeUtil class
Rishi Solanki created OFBIZ-7717: Summary: Enforce noninstantiability to EntityTypeUtil class Key: OFBIZ-7717 URL: https://issues.apache.org/jira/browse/OFBIZ-7717 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: Trunk Reporter: Rishi Solanki Priority: Minor - Make class as final. - Add a private constructor. No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7716) Enforce noninstantiability to CommonWorkers class
Rishi Solanki created OFBIZ-7716: Summary: Enforce noninstantiability to CommonWorkers class Key: OFBIZ-7716 URL: https://issues.apache.org/jira/browse/OFBIZ-7716 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: Trunk Reporter: Rishi Solanki Priority: Minor - Make class as final. - Add a private constructor. No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7715) Enforce noninstantiability to SqlJdbcUtil class
Rishi Solanki created OFBIZ-7715:
Summary: Enforce noninstantiability to SqlJdbcUtil class
Key: OFBIZ-7715
URL: https://issues.apache.org/jira/browse/OFBIZ-7715
Project: OFBiz
Issue Type: Sub-task
Components: framework
Affects Versions: Trunk
Reporter: Rishi Solanki
Priority: Minor
- Make class as final.
- Add a private constructor.
- Make the following public static variables as private
{code}
public static final int CHAR_BUFFER_SIZE = 4096;
{code}
- Make the following protected variable as private and move it and static block
to top of class.
{code}
protected static Map fieldTypeMap = new HashMap();
static {
fieldTypeMap.put("java.lang.String", 1);
fieldTypeMap.put("String", 1);
fieldTypeMap.put("java.sql.Timestamp", 2);
fieldTypeMap.put("Timestamp", 2);
fieldTypeMap.put("java.sql.Time", 3);
fieldTypeMap.put("Time", 3);
fieldTypeMap.put("java.sql.Date", 4);
fieldTypeMap.put("Date", 4);
fieldTypeMap.put("java.lang.Integer", 5);
fieldTypeMap.put("Integer", 5);
fieldTypeMap.put("java.lang.Long", 6);
fieldTypeMap.put("Long", 6);
fieldTypeMap.put("java.lang.Float", 7);
fieldTypeMap.put("Float", 7);
fieldTypeMap.put("java.lang.Double", 8);
fieldTypeMap.put("Double", 8);
fieldTypeMap.put("java.math.BigDecimal", 9);
fieldTypeMap.put("BigDecimal", 9);
fieldTypeMap.put("java.lang.Boolean", 10);
fieldTypeMap.put("Boolean", 10);
fieldTypeMap.put("java.lang.Object", 11);
fieldTypeMap.put("Object", 11);
fieldTypeMap.put("java.sql.Blob", 12);
fieldTypeMap.put("Blob", 12);
fieldTypeMap.put("byte[]", 12);
fieldTypeMap.put("java.nio.ByteBuffer", 12);
fieldTypeMap.put("java.nio.HeapByteBuffer", 12);
fieldTypeMap.put("java.sql.Clob", 13);
fieldTypeMap.put("Clob", 13);
fieldTypeMap.put("java.util.Date", 14);
// all of these treated as Collection
fieldTypeMap.put("java.util.ArrayList", 15);
fieldTypeMap.put("java.util.HashSet", 15);
fieldTypeMap.put("java.util.LinkedHashSet", 15);
fieldTypeMap.put("java.util.LinkedList", 15);
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (OFBIZ-7710) Enforce noninstantiability to EntityFinderUtil class
Rishi Solanki created OFBIZ-7710: Summary: Enforce noninstantiability to EntityFinderUtil class Key: OFBIZ-7710 URL: https://issues.apache.org/jira/browse/OFBIZ-7710 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: Trunk Reporter: Rishi Solanki Priority: Minor - Make class as final. - Add a private constructor. - Many public static classes are defined, but all are in use outside of the class. No changes required. No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7708) Enforce noninstantiability to UrlServletHelper class
[ https://issues.apache.org/jira/browse/OFBIZ-7708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishi Solanki updated OFBIZ-7708: - Affects Version/s: Trunk Component/s: (was: ALL COMPONENTS) framework > Enforce noninstantiability to UrlServletHelper class > > > Key: OFBIZ-7708 > URL: https://issues.apache.org/jira/browse/OFBIZ-7708 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Rishi Solanki >Priority: Minor > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7708) Enforce noninstantiability to UrlServletHelper class
Rishi Solanki created OFBIZ-7708: Summary: Enforce noninstantiability to UrlServletHelper class Key: OFBIZ-7708 URL: https://issues.apache.org/jira/browse/OFBIZ-7708 Project: OFBiz Issue Type: Sub-task Reporter: Rishi Solanki Priority: Minor - Make class as final. - Add a private constructor. No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7686) Enforce noninstantiability to EntityEcaUtil class
[
https://issues.apache.org/jira/browse/OFBIZ-7686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rishi Solanki updated OFBIZ-7686:
-
Description:
- Make class as final.
- Add a private constructor.
- Make the following protected static methods as private
{code}
protected static Callable
createEcaLoaderCallable(final ResourceHandler handler)
protected static void readConfig(String entityEcaReaderName, Map> ecaCache)
{code}
No variables needs to be change for this class.
was:
- Make class as final.
- Add a private constructor.
- Make the following protected static methods as private
{code}
protected static Callable
createEcaLoaderCallable(final ResourceHandler handler)
{code}
No variables needs to be change for this class.
> Enforce noninstantiability to EntityEcaUtil class
> -
>
> Key: OFBIZ-7686
> URL: https://issues.apache.org/jira/browse/OFBIZ-7686
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> - Make the following protected static methods as private
> {code}
> protected static Callable
> createEcaLoaderCallable(final ResourceHandler handler)
> protected static void readConfig(String entityEcaReaderName, Map Map> ecaCache)
> {code}
> No variables needs to be change for this class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7590) Enforce noninstantiability to UtilIO class
[ https://issues.apache.org/jira/browse/OFBIZ-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360005#comment-15360005 ] Rishi Solanki commented on OFBIZ-7590: -- Thanks [~rohit.koushal] changes looks good to me. > Enforce noninstantiability to UtilIO class > -- > > Key: OFBIZ-7590 > URL: https://issues.apache.org/jira/browse/OFBIZ-7590 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Arun Patidar >Priority: Minor > Attachments: OFBIZ-7590.patch > > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7692) Enforce noninstantiability to AuthHelper class
Rishi Solanki created OFBIZ-7692:
Summary: Enforce noninstantiability to AuthHelper class
Key: OFBIZ-7692
URL: https://issues.apache.org/jira/browse/OFBIZ-7692
Project: OFBiz
Issue Type: Sub-task
Components: framework
Affects Versions: Trunk
Reporter: Rishi Solanki
Priority: Minor
- Make class as final.
- Add a private constructor.
- Make the following protected static variables as private
{code}
protected static List authenticators = new
ArrayList();
protected static boolean authenticatorsLoaded = false;
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (OFBIZ-7691) Enforce noninstantiability to GeoWorker class
Rishi Solanki created OFBIZ-7691: Summary: Enforce noninstantiability to GeoWorker class Key: OFBIZ-7691 URL: https://issues.apache.org/jira/browse/OFBIZ-7691 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: Trunk Reporter: Rishi Solanki Priority: Minor - Make class as final. - Add a private constructor. No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7690) Enforce noninstantiability to PreferenceWorker class
Rishi Solanki created OFBIZ-7690:
Summary: Enforce noninstantiability to PreferenceWorker class
Key: OFBIZ-7690
URL: https://issues.apache.org/jira/browse/OFBIZ-7690
Project: OFBiz
Issue Type: Sub-task
Components: framework
Affects Versions: Trunk
Reporter: Rishi Solanki
Priority: Minor
- Make class as final.
- Add a private constructor.
- Make the following public static final variables as private
{code}
public static final String ADMIN_PERMISSION = "USERPREF_ADMIN";
public static final String LOGINID_PARAMETER_NAME = "userPrefLoginId";
public static final String DEFAULT_UID = "_NA_";
{code}
No variables needs to be change for this class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (OFBIZ-7689) Enforce noninstantiability to PeriodWorker class
Rishi Solanki created OFBIZ-7689: Summary: Enforce noninstantiability to PeriodWorker class Key: OFBIZ-7689 URL: https://issues.apache.org/jira/browse/OFBIZ-7689 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: Trunk Reporter: Rishi Solanki Priority: Minor - Make class as final. - Add a private constructor. No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7688) Enforce noninstantiability to StatusWorker class
Rishi Solanki created OFBIZ-7688: Summary: Enforce noninstantiability to StatusWorker class Key: OFBIZ-7688 URL: https://issues.apache.org/jira/browse/OFBIZ-7688 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: Trunk Reporter: Rishi Solanki Priority: Minor - Make class as final. - Add a private constructor. No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7687) Enforce noninstantiability to KeywordSearchUtil class
Rishi Solanki created OFBIZ-7687:
Summary: Enforce noninstantiability to KeywordSearchUtil class
Key: OFBIZ-7687
URL: https://issues.apache.org/jira/browse/OFBIZ-7687
Project: OFBiz
Issue Type: Sub-task
Components: framework
Affects Versions: Trunk
Reporter: Rishi Solanki
Priority: Minor
- Make class as final.
- Add a private constructor.
- Make the following public static variables as private
{code}
public static Set thesaurusRelsToInclude = new HashSet();
public static Set thesaurusRelsForReplace = new HashSet();
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (OFBIZ-7686) Enforce noninstantiability to EntityEcaUtil class
Rishi Solanki created OFBIZ-7686:
Summary: Enforce noninstantiability to EntityEcaUtil class
Key: OFBIZ-7686
URL: https://issues.apache.org/jira/browse/OFBIZ-7686
Project: OFBiz
Issue Type: Sub-task
Components: framework
Affects Versions: Trunk
Reporter: Rishi Solanki
Priority: Minor
- Make class as final.
- Add a private constructor.
- Make the following protected static methods as private
{code}
protected static Callable
createEcaLoaderCallable(final ResourceHandler handler)
{code}
No variables needs to be change for this class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (OFBIZ-7685) Enforce noninstantiability to RecurrenceUtil class
Rishi Solanki created OFBIZ-7685: Summary: Enforce noninstantiability to RecurrenceUtil class Key: OFBIZ-7685 URL: https://issues.apache.org/jira/browse/OFBIZ-7685 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: Trunk Reporter: Rishi Solanki Priority: Minor - Make class as final. - Add a private constructor. No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7684) Enforce noninstantiability to ServiceConfigUtil class
Rishi Solanki created OFBIZ-7684:
Summary: Enforce noninstantiability to ServiceConfigUtil class
Key: OFBIZ-7684
URL: https://issues.apache.org/jira/browse/OFBIZ-7684
Project: OFBiz
Issue Type: Sub-task
Components: framework
Affects Versions: Trunk
Reporter: Rishi Solanki
Priority: Minor
- Make class as final.
- Add a private constructor.
- Make the following public static variables as private
{code}
public static final String engine = "default";
public static final String SERVICE_ENGINE_XML_FILENAME =
"serviceengine.xml";
{code}
- Add public static method as getServiceEngineXmlFileName(), getEngine() and
use them in following class
{code}
ServiceEcaUtil.java
ServiceGroupReader.java
DispatchContext.java
JobPoller.java
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-7648) Page bottom navigation problem with grid and include-grid
[ https://issues.apache.org/jira/browse/OFBIZ-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352547#comment-15352547 ] Rishi Solanki edited comment on OFBIZ-7648 at 6/28/16 9:21 AM: --- [~rohit.koushal] I see you have put the PAGINATOR_NUMBER in the page context as well. Also removed the NO_PAGINATOR usage from globalContext in PartyForms. Does it mean putting the values in the global context is of no use? Thanks! was (Author: rishisolankii): [~rohit.koushal] I see you have put the PAGINATOR_NUMBER in the page context as well. Also removed the NO_PAGINATOR usage from globalContext in PartForms. Does it mean putting the values in the global context is of no use? Thanks! > Page bottom navigation problem with grid and include-grid > - > > Key: OFBIZ-7648 > URL: https://issues.apache.org/jira/browse/OFBIZ-7648 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Rohit Koushal >Assignee: Rohit Koushal > Attachments: OFBIZ-7648.patch > > > This ticket is in reference of issue OFBIZ-7020. In the fix we need to > manually specify the "NO_PAGINATOR" in golbalContext to stop inner grid > pagination. Under this ticket we looking for a framework level fix. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7648) Page bottom navigation problem with grid and include-grid
[ https://issues.apache.org/jira/browse/OFBIZ-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352547#comment-15352547 ] Rishi Solanki commented on OFBIZ-7648: -- [~rohit.koushal] I see you have put the PAGINATOR_NUMBER in the page context as well. Also removed the NO_PAGINATOR usage from globalContext in PartForms. Does it mean putting the values in the global context is of no use? Thanks! > Page bottom navigation problem with grid and include-grid > - > > Key: OFBIZ-7648 > URL: https://issues.apache.org/jira/browse/OFBIZ-7648 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Rohit Koushal >Assignee: Rohit Koushal > Attachments: OFBIZ-7648.patch > > > This ticket is in reference of issue > [OFBIZ-7020|https://issues.apache.org/jira/browse/OFBIZ-7020]. In the fix we > need to manually specify the "NO_PAGINATOR" in golbalContext to stop inner > grid pagination. Under this ticket we looking for a framework level fix. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7630) Enforce noninstantiability to ServiceEcaUtil class
Rishi Solanki created OFBIZ-7630:
Summary: Enforce noninstantiability to ServiceEcaUtil class
Key: OFBIZ-7630
URL: https://issues.apache.org/jira/browse/OFBIZ-7630
Project: OFBiz
Issue Type: Sub-task
Components: framework
Affects Versions: Trunk
Reporter: Rishi Solanki
Priority: Minor
- Make class as final.
- Add a private constructor.
- Make the following public static variables as private
{code}
public static Map> ecaCache = new
ConcurrentHashMap>();
{code}
- Make the following protected static methods as private
{code}
protected static Callable createEcaLoaderCallable(final
ResourceHandler handler)
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (OFBIZ-7601) Enforce noninstantiability to UtilURL class
Rishi Solanki created OFBIZ-7601: Summary: Enforce noninstantiability to UtilURL class Key: OFBIZ-7601 URL: https://issues.apache.org/jira/browse/OFBIZ-7601 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: Trunk Reporter: Rishi Solanki Priority: Minor - Make class as final. - Add a private constructor. No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7600) Enforce noninstantiability to UtilPlist class
[
https://issues.apache.org/jira/browse/OFBIZ-7600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rishi Solanki updated OFBIZ-7600:
-
Attachment: OFBIZ-7600.patch
Providing patch as per the details mentioned in the ticket.
> Enforce noninstantiability to UtilPlist class
> -
>
> Key: OFBIZ-7600
> URL: https://issues.apache.org/jira/browse/OFBIZ-7600
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-7600.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final String indentFourString = "";
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7600) Enforce noninstantiability to UtilPlist class
[
https://issues.apache.org/jira/browse/OFBIZ-7600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rishi Solanki reassigned OFBIZ-7600:
Assignee: Rishi Solanki
> Enforce noninstantiability to UtilPlist class
> -
>
> Key: OFBIZ-7600
> URL: https://issues.apache.org/jira/browse/OFBIZ-7600
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rishi Solanki
>Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final String indentFourString = "";
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (OFBIZ-7600) Enforce noninstantiability to UtilPlist class
Rishi Solanki created OFBIZ-7600:
Summary: Enforce noninstantiability to UtilPlist class
Key: OFBIZ-7600
URL: https://issues.apache.org/jira/browse/OFBIZ-7600
Project: OFBiz
Issue Type: Sub-task
Components: framework
Affects Versions: Trunk
Reporter: Rishi Solanki
Priority: Minor
- Make class as final.
- Add a private constructor.
- Make the following public static variables as private
{code}
public static final String indentFourString = "";
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (OFBIZ-7593) Enforce noninstantiability to UtilNumber class
Rishi Solanki created OFBIZ-7593:
Summary: Enforce noninstantiability to UtilNumber class
Key: OFBIZ-7593
URL: https://issues.apache.org/jira/browse/OFBIZ-7593
Project: OFBiz
Issue Type: Sub-task
Components: framework
Affects Versions: Trunk
Reporter: Rishi Solanki
Priority: Minor
- Make class as final.
- Add a private constructor.
- Make the following public static variables as private and move it to top with
static block
{code}
// ICU4J rule sets for the en_US locale. To add more rules, expand this
string.
// For reference, see the RbnfSampleRuleSets.java file distributed with
ICU4J
public static final String ruleSet_en_US =
/*
* These rules format a number in one of the two styles often used
* on checks. %dollars-and-hundredths formats cents as hundredths of
* a dollar (23.40 comes out as "twenty-three and 40/100 dollars").
* %dollars-and-cents formats in dollars and cents (23.40 comes out as
* "twenty-three dollars and forty cents")
*/
"%dollars-and-cents:\n"
+ "x.0: << [and >%%cents>];\n"
+ "0.x: >%%cents>;\n"
+ "0: zero dollars; one dollar; =%%main= dollars;\n"
+ "%%main:\n"
+ "zero; one; two; three; four; five; six; seven; eight; nine;\n"
+ "ten; eleven; twelve; thirteen; fourteen; fifteen; sixteen;\n"
+ "seventeen; eighteen; nineteen;\n"
+ "20: twenty[->>];\n"
+ "30: thirty[->>];\n"
+ "40: forty[->>];\n"
+ "50: fifty[->>];\n"
+ "60: sixty[->>];\n"
+ "70: seventy[->>];\n"
+ "80: eighty[->>];\n"
+ "90: ninety[->>];\n"
+ "100: << hundred[ >>];\n"
+ "1000: << thousand[ >>];\n"
+ "1,000,000: << million[ >>];\n"
+ "1,000,000,000: << billion[ >>];\n"
+ "1,000,000,000,000: << trillion[ >>];\n"
+ "1,000,000,000,000,000: =#,##0=;\n"
+ "%%cents:\n"
+ "100: <%%main< cent[s];\n"
+ "%dollars-and-hundredths:\n"
+ "x.0: <%%main< and >%%hundredths>/100;\n" // this used to end in
'dollars' but that should be added later
+ "%%hundredths:\n"
+ "100: <00<;\n";
// ICU4J rule sets for the th_TH locale. To add more rules, expand this
string.
// For reference, see the RbnfSampleRuleSets.java file distributed with
ICU4J
public static final String ruleSet_th_TH =
/*
* These rules format a number in one of the two styles often used
* on checks. %bahts-and-hundredths formats stangs as hundredths of
* a baht (23.40 comes out as "twenty-three and 40/100 bahts").
* %bahts-and-stangs formats in bahts and stangs (23.40 comes out as
* "twenty-three bahts and forty stangs")
*/
"%bahts-and-stangs:\n"
+ "x.0: << [and >%%stangs>];\n"
+ "0.x: >%%stangs>;\n"
+ "0: zero bahts; one baht; =%%main= bahts;\n"
+ "%%main:\n"
+ "zero; one; two; three; four; five; six; seven; eight; nine;\n"
+ "ten; eleven; twelve; thirteen; fourteen; fifteen; sixteen;\n"
+ "seventeen; eighteen; nineteen;\n"
+ "20: twenty[->>];\n"
+ "30: thirty[->>];\n"
+ "40: forty[->>];\n"
+ "50: fifty[->>];\n"
+ "60: sixty[->>];\n"
+ "70: seventy[->>];\n"
+ "80: eighty[->>];\n"
+ "90: ninety[->>];\n"
+ "100: << hundred[ >>];\n"
+ "1000: << thousand[ >>];\n"
+ "1,000,000: << million[ >>];\n"
+ "1,000,000,000: << billion[ >>];\n"
+ "1,000,000,000,000: << trillion[ >>];\n"
+ "1,000,000,000,000,000: =#,##0=;\n"
+ "%%stangs:\n"
+ "100: <%%main< stang[s];\n"
+ "%bahts-and-hundredths:\n"
+ "x.0: <%%main< and >%%hundredths>/100;\n" // this used to end in
'bahts' but that should be added later
+ "%%hundredths:\n"
+ "100: <00<;\n";
// hash map to store ICU4J rule sets keyed to Locale
public static HashMap rbnfRuleSets;
static {
rbnfRuleSets = new HashMap();
rbnfRuleSets.put(Locale.US, ruleSet_en_US);
rbnfRuleSets.put(new Locale("th"), ruleSet_th_TH);
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (OFBIZ-7591) Enforce noninstantiability to UtilJavaParse class
Rishi Solanki created OFBIZ-7591:
Summary: Enforce noninstantiability to UtilJavaParse class
Key: OFBIZ-7591
URL: https://issues.apache.org/jira/browse/OFBIZ-7591
Project: OFBiz
Issue Type: Sub-task
Components: framework
Affects Versions: Trunk
Reporter: Rishi Solanki
Priority: Minor
- Make class as final.
- Add a private constructor.
- Make the following public static variables as private and move them to top of
class. Also move the static block initializing it.
{code}
// FIXME: Not thread safe
public static Set serviceMethodNames = new HashSet();
static {
serviceMethodNames.add("runSync");
serviceMethodNames.add("runSyncIgnore");
serviceMethodNames.add("runAsync");
serviceMethodNames.add("runAsyncWait");
serviceMethodNames.add("registerCallback");
serviceMethodNames.add("schedule"); // NOTE: the service name may be
the 1st, 2nd or 3rd param for variations on this
serviceMethodNames.add("addRollbackService");
serviceMethodNames.add("addCommitService");
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (OFBIZ-7590) Enforce noninstantiability to UtilIO class
Rishi Solanki created OFBIZ-7590: Summary: Enforce noninstantiability to UtilIO class Key: OFBIZ-7590 URL: https://issues.apache.org/jira/browse/OFBIZ-7590 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: Trunk Reporter: Rishi Solanki Priority: Minor - Make class as final. - Add a private constructor. No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7589) Enforce noninstantiability to UtilHttp class
Rishi Solanki created OFBIZ-7589:
Summary: Enforce noninstantiability to UtilHttp class
Key: OFBIZ-7589
URL: https://issues.apache.org/jira/browse/OFBIZ-7589
Project: OFBiz
Issue Type: Sub-task
Components: framework
Affects Versions: Trunk
Reporter: Rishi Solanki
Priority: Minor
- Make class as final.
- Add a private constructor.
- Make the following public static variables as private
{code}
public static final String MULTI_ROW_DELIMITER = "_o_";
public static final String ROW_SUBMIT_PREFIX = "_rowSubmit_o_";
public static final String COMPOSITE_DELIMITER = "_c_";
public static final int MULTI_ROW_DELIMITER_LENGTH =
MULTI_ROW_DELIMITER.length();
public static final int ROW_SUBMIT_PREFIX_LENGTH =
ROW_SUBMIT_PREFIX.length();
public static final int COMPOSITE_DELIMITER_LENGTH =
COMPOSITE_DELIMITER.length();
public static final String SESSION_KEY_TIMEZONE = "timeZone";
{code}
- Add public static methods as getMultiRowDelimiter(), getRowSubmitPrefix(),
and use them in following classes/scripts;
{code}
GlEvents.java
ShoppingCartEvents.java
CheckAction.groovy
CheckRejected.groovy
ServiceMultiEventHandler.java
EbayEvents.java
{code}
No variables needs to be change for this class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (OFBIZ-7588) Enforce noninstantiability to UtilGenerics class
Rishi Solanki created OFBIZ-7588: Summary: Enforce noninstantiability to UtilGenerics class Key: OFBIZ-7588 URL: https://issues.apache.org/jira/browse/OFBIZ-7588 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: Trunk Reporter: Rishi Solanki Priority: Minor - Make class as final. - Add a private constructor. No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7587) Enforce noninstantiability to UtilFormatOut class
Rishi Solanki created OFBIZ-7587:
Summary: Enforce noninstantiability to UtilFormatOut class
Key: OFBIZ-7587
URL: https://issues.apache.org/jira/browse/OFBIZ-7587
Project: OFBiz
Issue Type: Sub-task
Components: framework
Affects Versions: Trunk
Reporter: Rishi Solanki
Priority: Minor
- Make class as final.
- Add a private constructor.
- Make the following static variable as private static final. Also move it to
begining of the class with FIXME: comment
{code}
// --- price format handlers ---
// FIXME: This is not thread-safe! DecimalFormat is not synchronized.
static DecimalFormat priceDecimalFormat = new
DecimalFormat(UtilProperties.getPropertyValue("general",
"currency.decimal.format", "#,##0.00"));
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7540) Enforce noninstantiability to FileUtil class
[
https://issues.apache.org/jira/browse/OFBIZ-7540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rishi Solanki updated OFBIZ-7540:
-
Description:
- Make class as final.
- Add a private constructor.
- Make following public static class as private and move it to the top of the
class.
{code}
public static class SearchTextFilesFilter implements FilenameFilter
{code}
was:
- Make class as final.
- Add a private constructor.
No variables needs to be change.
> Enforce noninstantiability to FileUtil class
>
>
> Key: OFBIZ-7540
> URL: https://issues.apache.org/jira/browse/OFBIZ-7540
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> - Make following public static class as private and move it to the top of the
> class.
> {code}
> public static class SearchTextFilesFilter implements FilenameFilter
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (OFBIZ-7562) Enforce noninstantiability to UtilDateTime class
Rishi Solanki created OFBIZ-7562:
Summary: Enforce noninstantiability to UtilDateTime class
Key: OFBIZ-7562
URL: https://issues.apache.org/jira/browse/OFBIZ-7562
Project: OFBiz
Issue Type: Sub-task
Components: framework
Affects Versions: Trunk
Reporter: Rishi Solanki
Priority: Minor
- Make class as final.
- Add a private constructor.
- Make the following public static variables as private
{code}
public static final String[] months = {
"January", "February", "March", "April", "May", "June",
"July", "August", "September", "October", "November",
"December"
};
public static final String[] days = {
"Monday", "Tuesday", "Wednesday",
"Thursday", "Friday", "Saturday", "Sunday"
};
public static final String[][] timevals = {
{"1000", "millisecond"},
{"60", "second"},
{"60", "minute"},
{"24", "hour"},
{"168", "week"}
};
public static final DecimalFormat df = new DecimalFormat("0.00;-0.00");
public static final String DATE_FORMAT = "-MM-dd";
public static final String DATE_TIME_FORMAT = "-MM-dd HH:mm:ss.SSS";
public static final String TIME_FORMAT = "HH:mm:ss";
{code}
- Add public static methods as getDateFormat(), getDateTimeFormat() and
getTimeFormat() methods and use them in following classes;
{code}
DateTimeConverters.java
UelFunctions.java
CommonWidgetModels.java
ModelFormField.java
SetCalendar.java
EbayStoreAutoPreferences.java
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (OFBIZ-7551) Enforce noninstantiability to SSLUtil class
Rishi Solanki created OFBIZ-7551:
Summary: Enforce noninstantiability to SSLUtil class
Key: OFBIZ-7551
URL: https://issues.apache.org/jira/browse/OFBIZ-7551
Project: OFBiz
Issue Type: Sub-task
Components: framework
Affects Versions: Trunk
Reporter: Rishi Solanki
Priority: Minor
- Make class as final.
- Add a private constructor.
- Make the following public static variables as private
{code}
public static final int HOSTCERT_NO_CHECK = 0;
public static final int HOSTCERT_MIN_CHECK = 1;
public static final int HOSTCERT_NORMAL_CHECK = 2;
{code}
- Add getHostCertNoCheck(), getHostCertMinCheck() and getHostCertNormalCheck()
public static methods and use them in following classes, Also check if any
class remains;
{code}
HttpClient.java
URLConnector.java
AliasSupportedTransportFactory.java
WidgetMacroLibraryTests.java
OagisServices.java
{code}
- Move following static class at top and make it private.
{code}
static class TrustAnyManager implements X509TrustManager
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (OFBIZ-7541) Enforce noninstantiability to KeyStoreUtil class
Rishi Solanki created OFBIZ-7541: Summary: Enforce noninstantiability to KeyStoreUtil class Key: OFBIZ-7541 URL: https://issues.apache.org/jira/browse/OFBIZ-7541 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: Trunk Reporter: Rishi Solanki Priority: Minor - Make class as final. - Add a private constructor. No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7540) Enforce noninstantiability to FileUtil class
Rishi Solanki created OFBIZ-7540: Summary: Enforce noninstantiability to FileUtil class Key: OFBIZ-7540 URL: https://issues.apache.org/jira/browse/OFBIZ-7540 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: Trunk Reporter: Rishi Solanki Priority: Minor - Make class as final. - Add a private constructor. No variables needs to be change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7423) Enforce noninstantiability to PartyTypeHelper class
[ https://issues.apache.org/jira/browse/OFBIZ-7423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishi Solanki updated OFBIZ-7423: - Summary: Enforce noninstantiability to PartyTypeHelper class (was: PartyTypeHelper class) > Enforce noninstantiability to PartyTypeHelper class > --- > > Key: OFBIZ-7423 > URL: https://issues.apache.org/jira/browse/OFBIZ-7423 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: Trunk >Reporter: Rishi Solanki >Priority: Minor > Attachments: OFBIZ-7423.patch > > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7433) Enforce noninstantiability to UtilCacheEvents Class
[
https://issues.apache.org/jira/browse/OFBIZ-7433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rishi Solanki updated OFBIZ-7433:
-
Summary: Enforce noninstantiability to UtilCacheEvents Class (was:
UtilCacheEvents Class)
> Enforce noninstantiability to UtilCacheEvents Class
> ---
>
> Key: OFBIZ-7433
> URL: https://issues.apache.org/jira/browse/OFBIZ-7433
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7433.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final String err_resource = "WebtoolsErrorUiLabels";
> {code}
> Also, use 'err_resource' instead of UtilCacheEvents.err_resource in same class
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7431) Enforce noninstantiability to SeoUrlUtil class
[ https://issues.apache.org/jira/browse/OFBIZ-7431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishi Solanki updated OFBIZ-7431: - Summary: Enforce noninstantiability to SeoUrlUtil class (was: SeoUrlUtil class) > Enforce noninstantiability to SeoUrlUtil class > -- > > Key: OFBIZ-7431 > URL: https://issues.apache.org/jira/browse/OFBIZ-7431 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Chinmay Patidar >Priority: Minor > Attachments: OFBIZ-7431.patch > > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7446) Enforce noninstantiability to WebSiteWorker Class
[ https://issues.apache.org/jira/browse/OFBIZ-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishi Solanki updated OFBIZ-7446: - Summary: Enforce noninstantiability to WebSiteWorker Class (was: WebSiteWorker Class) > Enforce noninstantiability to WebSiteWorker Class > - > > Key: OFBIZ-7446 > URL: https://issues.apache.org/jira/browse/OFBIZ-7446 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Arun Patidar >Assignee: Rohit Koushal >Priority: Minor > Attachments: OFBIZ-7446.patch > > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7428) Enforce noninstantiability to WidgetContentWorker Class
[
https://issues.apache.org/jira/browse/OFBIZ-7428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rishi Solanki updated OFBIZ-7428:
-
Summary: Enforce noninstantiability to WidgetContentWorker Class (was:
WidgetContentWorker Class)
> Enforce noninstantiability to WidgetContentWorker Class
> ---
>
> Key: OFBIZ-7428
> URL: https://issues.apache.org/jira/browse/OFBIZ-7428
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Reporter: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7428.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static ContentWorkerInterface contentWorker = null;
> {code}
> - Add a static getContentWorker() and replace use of
> WidgetContentWorker.contentWorker in classes 'MenuWrapTransform',
> 'MacroScreenRenderer' 'HtmlScreenRenderer', 'HtmlMenuRendererImage',
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7422) Enforce noninstantiability to WidgetDataResourceWorker Class
[
https://issues.apache.org/jira/browse/OFBIZ-7422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rishi Solanki updated OFBIZ-7422:
-
Summary: Enforce noninstantiability to WidgetDataResourceWorker Class
(was: WidgetDataResourceWorker Class)
> Enforce noninstantiability to WidgetDataResourceWorker Class
>
>
> Key: OFBIZ-7422
> URL: https://issues.apache.org/jira/browse/OFBIZ-7422
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Rohit Koushal
>Priority: Minor
> Attachments: OFBIZ-7422.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static DataResourceWorkerInterface dataresourceWorker = null;
> {code}
> - Add a getDataresourceWorker() method and replace use of
> DataResourceWorkerInterface.dataresourceWorker from classes
> 'HtmlScreenRenderer' and 'MacroScreenRenderer'
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7419) Enforce noninstantiability to PartyRelationshipHelper class
[ https://issues.apache.org/jira/browse/OFBIZ-7419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishi Solanki updated OFBIZ-7419: - Summary: Enforce noninstantiability to PartyRelationshipHelper class (was: PartyRelationshipHelper class) > Enforce noninstantiability to PartyRelationshipHelper class > --- > > Key: OFBIZ-7419 > URL: https://issues.apache.org/jira/browse/OFBIZ-7419 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Chinmay Patidar >Priority: Minor > Attachments: OFBIZ-7419.patch > > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7420) Enforce noninstantiability to WidgetPortalPageWorker Class
[
https://issues.apache.org/jira/browse/OFBIZ-7420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rishi Solanki updated OFBIZ-7420:
-
Summary: Enforce noninstantiability to WidgetPortalPageWorker Class (was:
WidgetPortalPageWorker Class)
> Enforce noninstantiability to WidgetPortalPageWorker Class
> --
>
> Key: OFBIZ-7420
> URL: https://issues.apache.org/jira/browse/OFBIZ-7420
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7420.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static PortalPageWorkerInterface portalPageWorker = null;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7412) Enforce noninstantiability to UtilHelpText Class
[ https://issues.apache.org/jira/browse/OFBIZ-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishi Solanki updated OFBIZ-7412: - Summary: Enforce noninstantiability to UtilHelpText Class (was: UtilHelpText Class) > Enforce noninstantiability to UtilHelpText Class > > > Key: OFBIZ-7412 > URL: https://issues.apache.org/jira/browse/OFBIZ-7412 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Arun Patidar >Priority: Minor > Attachments: OFBIZ-7412.patch > > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
