from:"Sascha Rodekamp"


[ 
https://issues.apache.org/jira/browse/OFBIZ-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13464605#comment-13464605
 ] 

Sascha Rodekamp commented on OFBIZ-2628:


Hm, the patch OFBIZ-2628-encoding-hidden-post-params.patch break the encoding 
again.

 No Url encoding for get parameters
 --

 Key: OFBIZ-2628
 URL: https://issues.apache.org/jira/browse/OFBIZ-2628
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: Release Branch 4.0, Release Branch 09.04, SVN trunk
 Environment: All
Reporter: Patrick Antivackis
Assignee: Sascha Rodekamp
Priority: Critical
 Fix For: Release Branch 11.04, SVN trunk, Release Branch 12.04

 Attachments: OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, 
 OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, 
 OFBIZ-2628-encoding-hidden-post-params.patch, 
 OFBIZ-2628-encoding-request-redirect-params.patch

   Original Estimate: 4h
  Remaining Estimate: 4h

 Let's say I want to create a new category which ID is  DVD+R
 Creation is ok through the admin interface, but whenever i want to access 
 this category, the get parameter productCategoryId= of the url is wrong 
 as it's not url encoded, so we have :
 https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD#43;R
  instead of
 https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD%2BR
 Both @ofbizUrl tag and menu widgets are not encoding get parameters.
 Way to correct :
 framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java modify the 
 makeLink function
 framework/widget/src/org/ofbiz/widget/WidgetWorker.java : function 
 buildhyperlinkUrl need to use defaultWebEncoder.encodeForURL instead of 
 simpleEncoder
 Beofre i do the fix, can a core developper let me know about possible side 
 effects

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-2628) No Url encoding for get parameters


[ 
https://issues.apache.org/jira/browse/OFBIZ-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13464627#comment-13464627
 ] 

Sascha Rodekamp commented on OFBIZ-2628:


I applied the patch on trunk. Which causes the same issue as described in the 
in the bug description. 



 No Url encoding for get parameters
 --

 Key: OFBIZ-2628
 URL: https://issues.apache.org/jira/browse/OFBIZ-2628
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: Release Branch 4.0, Release Branch 09.04, SVN trunk
 Environment: All
Reporter: Patrick Antivackis
Assignee: Sascha Rodekamp
Priority: Critical
 Fix For: Release Branch 11.04, SVN trunk, Release Branch 12.04

 Attachments: OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, 
 OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, 
 OFBIZ-2628-encoding-hidden-post-params.patch, 
 OFBIZ-2628-encoding-request-redirect-params.patch

   Original Estimate: 4h
  Remaining Estimate: 4h

 Let's say I want to create a new category which ID is  DVD+R
 Creation is ok through the admin interface, but whenever i want to access 
 this category, the get parameter productCategoryId= of the url is wrong 
 as it's not url encoded, so we have :
 https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD#43;R
  instead of
 https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD%2BR
 Both @ofbizUrl tag and menu widgets are not encoding get parameters.
 Way to correct :
 framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java modify the 
 makeLink function
 framework/widget/src/org/ofbiz/widget/WidgetWorker.java : function 
 buildhyperlinkUrl need to use defaultWebEncoder.encodeForURL instead of 
 simpleEncoder
 Beofre i do the fix, can a core developper let me know about possible side 
 effects

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-2628) No Url encoding for get parameters


[ 
https://issues.apache.org/jira/browse/OFBIZ-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13464682#comment-13464682
 ] 

Sascha Rodekamp commented on OFBIZ-2628:


Ok no problem, can you give me a short example of your problem that I can 
reproduce it here on my machine?

 No Url encoding for get parameters
 --

 Key: OFBIZ-2628
 URL: https://issues.apache.org/jira/browse/OFBIZ-2628
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: Release Branch 4.0, Release Branch 09.04, SVN trunk
 Environment: All
Reporter: Patrick Antivackis
Assignee: Sascha Rodekamp
Priority: Critical
 Fix For: Release Branch 11.04, SVN trunk, Release Branch 12.04

 Attachments: OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, 
 OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, 
 OFBIZ-2628-encoding-hidden-post-params.patch, 
 OFBIZ-2628-encoding-request-redirect-params.patch

   Original Estimate: 4h
  Remaining Estimate: 4h

 Let's say I want to create a new category which ID is  DVD+R
 Creation is ok through the admin interface, but whenever i want to access 
 this category, the get parameter productCategoryId= of the url is wrong 
 as it's not url encoded, so we have :
 https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD#43;R
  instead of
 https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD%2BR
 Both @ofbizUrl tag and menu widgets are not encoding get parameters.
 Way to correct :
 framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java modify the 
 makeLink function
 framework/widget/src/org/ofbiz/widget/WidgetWorker.java : function 
 buildhyperlinkUrl need to use defaultWebEncoder.encodeForURL instead of 
 simpleEncoder
 Beofre i do the fix, can a core developper let me know about possible side 
 effects

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-2628) No Url encoding for get parameters


[ 
https://issues.apache.org/jira/browse/OFBIZ-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13464773#comment-13464773
 ] 

Sascha Rodekamp commented on OFBIZ-2628:


Hey,
thanks for the new patch. The encoding of the parameters works now. But I get 
NPE's when loading the global decorator on different pages i.e.: 
https://localhost:8443/content/control/ListWebSiteContent?webSiteId=CmsSite
The exception occurs in: WidgetWorker.makeHiddenFormLinkForm


 No Url encoding for get parameters
 --

 Key: OFBIZ-2628
 URL: https://issues.apache.org/jira/browse/OFBIZ-2628
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: Release Branch 4.0, Release Branch 09.04, SVN trunk
 Environment: All
Reporter: Patrick Antivackis
Assignee: Sascha Rodekamp
Priority: Critical
 Fix For: Release Branch 11.04, SVN trunk, Release Branch 12.04

 Attachments: OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, 
 OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, 
 OFBIZ-2628-encoding-hidden-post-params (list forms).patch, 
 OFBIZ-2628-encoding-hidden-post-params.patch, 
 OFBIZ-2628-encoding-request-redirect-params.patch

   Original Estimate: 4h
  Remaining Estimate: 4h

 Let's say I want to create a new category which ID is  DVD+R
 Creation is ok through the admin interface, but whenever i want to access 
 this category, the get parameter productCategoryId= of the url is wrong 
 as it's not url encoded, so we have :
 https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD#43;R
  instead of
 https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD%2BR
 Both @ofbizUrl tag and menu widgets are not encoding get parameters.
 Way to correct :
 framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java modify the 
 makeLink function
 framework/widget/src/org/ofbiz/widget/WidgetWorker.java : function 
 buildhyperlinkUrl need to use defaultWebEncoder.encodeForURL instead of 
 simpleEncoder
 Beofre i do the fix, can a core developper let me know about possible side 
 effects

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-2628) No Url encoding for get parameters

2012-09-26 Thread Sascha Rodekamp (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13463783#comment-13463783
 ] 

Sascha Rodekamp commented on OFBIZ-2628:


I finally back form my holiday. 

Great observation Wojciech, I will check that.



 No Url encoding for get parameters
 --

 Key: OFBIZ-2628
 URL: https://issues.apache.org/jira/browse/OFBIZ-2628
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: Release Branch 4.0, Release Branch 09.04, SVN trunk
 Environment: All
Reporter: Patrick Antivackis
Assignee: Sascha Rodekamp
Priority: Critical
 Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk

 Attachments: OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, 
 OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch

   Original Estimate: 4h
  Remaining Estimate: 4h

 Let's say I want to create a new category which ID is  DVD+R
 Creation is ok through the admin interface, but whenever i want to access 
 this category, the get parameter productCategoryId= of the url is wrong 
 as it's not url encoded, so we have :
 https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD#43;R
  instead of
 https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD%2BR
 Both @ofbizUrl tag and menu widgets are not encoding get parameters.
 Way to correct :
 framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java modify the 
 makeLink function
 framework/widget/src/org/ofbiz/widget/WidgetWorker.java : function 
 buildhyperlinkUrl need to use defaultWebEncoder.encodeForURL instead of 
 simpleEncoder
 Beofre i do the fix, can a core developper let me know about possible side 
 effects

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Comment Edited] (OFBIZ-2628) No Url encoding for get parameters

2012-09-26 Thread Sascha Rodekamp (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13463783#comment-13463783
 ] 

Sascha Rodekamp edited comment on OFBIZ-2628 at 9/27/12 2:07 AM:
-

I'm finally back form my holiday. 

Great observation Wojciech, I will check that.

Edit: The changes work great, I can't identify any side effects.
I committed the changes in 
Trunk @Rev1390542
12.04 @Rev1390546
11.04 @Rev1390544



  was (Author: sascha):
I finally back form my holiday. 

Great observation Wojciech, I will check that.


  
 No Url encoding for get parameters
 --

 Key: OFBIZ-2628
 URL: https://issues.apache.org/jira/browse/OFBIZ-2628
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: Release Branch 4.0, Release Branch 09.04, SVN trunk
 Environment: All
Reporter: Patrick Antivackis
Assignee: Sascha Rodekamp
Priority: Critical
 Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk

 Attachments: OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, 
 OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch

   Original Estimate: 4h
  Remaining Estimate: 4h

 Let's say I want to create a new category which ID is  DVD+R
 Creation is ok through the admin interface, but whenever i want to access 
 this category, the get parameter productCategoryId= of the url is wrong 
 as it's not url encoded, so we have :
 https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD#43;R
  instead of
 https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD%2BR
 Both @ofbizUrl tag and menu widgets are not encoding get parameters.
 Way to correct :
 framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java modify the 
 makeLink function
 framework/widget/src/org/ofbiz/widget/WidgetWorker.java : function 
 buildhyperlinkUrl need to use defaultWebEncoder.encodeForURL instead of 
 simpleEncoder
 Beofre i do the fix, can a core developper let me know about possible side 
 effects

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (OFBIZ-2628) No Url encoding for get parameters

2012-09-26 Thread Sascha Rodekamp (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sascha Rodekamp closed OFBIZ-2628.
--

   Resolution: Fixed
Fix Version/s: (was: Release Branch 10.04)
   Release Branch 12.04

 No Url encoding for get parameters
 --

 Key: OFBIZ-2628
 URL: https://issues.apache.org/jira/browse/OFBIZ-2628
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: Release Branch 4.0, Release Branch 09.04, SVN trunk
 Environment: All
Reporter: Patrick Antivackis
Assignee: Sascha Rodekamp
Priority: Critical
 Fix For: Release Branch 11.04, SVN trunk, Release Branch 12.04

 Attachments: OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, 
 OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch

   Original Estimate: 4h
  Remaining Estimate: 4h

 Let's say I want to create a new category which ID is  DVD+R
 Creation is ok through the admin interface, but whenever i want to access 
 this category, the get parameter productCategoryId= of the url is wrong 
 as it's not url encoded, so we have :
 https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD#43;R
  instead of
 https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD%2BR
 Both @ofbizUrl tag and menu widgets are not encoding get parameters.
 Way to correct :
 framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java modify the 
 makeLink function
 framework/widget/src/org/ofbiz/widget/WidgetWorker.java : function 
 buildhyperlinkUrl need to use defaultWebEncoder.encodeForURL instead of 
 simpleEncoder
 Beofre i do the fix, can a core developper let me know about possible side 
 effects

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4915) Lookup Form not working with Arabic characters

2012-08-28 Thread Sascha Rodekamp (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13442993#comment-13442993
 ] 

Sascha Rodekamp commented on OFBIZ-4915:


Hi Taher,
thanks for working on this issue. I committed your patch in
release 11.04 @Rev 1377987
release 12.04 @Rev 1377986
trunk @Rev 1377988

Regards Sascha

 Lookup Form not working with Arabic characters
 --

 Key: OFBIZ-4915
 URL: https://issues.apache.org/jira/browse/OFBIZ-4915
 Project: OFBiz
  Issue Type: Bug
  Components: ALL COMPONENTS
Affects Versions: Release Branch 11.04, Release Branch 12.04
Reporter: Taher Alkhateeb
Assignee: Jacques Le Roux
Priority: Minor
  Labels: form, jQuery, javascript, lookup
 Fix For: Release Branch 12.04

 Attachments: fieldlookup.patch, search_party_after_submit.png, 
 search_party_before_submit.png, XHR_Screenshot_27_06_2012.png


 Any field in a form that uses the lookup target-form-name=WhateverForm/ 
 would not return results when searching in Arabic. I suspect the main 
 offender is javascript/jQuery when parsing user input.
 For example, if I go to https://localhost:8443/ordermgr/control/findorders 
 and click on Party ID, and search the firstname or lastname in arabic, no 
 values are returned and the value in the search box changes from arabic to 
 some weird encoding ( e.g. حسن becomes ØØ³Ù )
 Also, after some investigation, I came to the realization that this only 
 happens when the lookup field has presentation=layer, if however, the 
 presentation=window then it works normally which leads me to conclude 
 definitely that this is javascript/jQuery issue of parsing input data. More 
 specifically, this is javascript not processing with the correct encoding 
 (unicode in this case). I know this because if I paste the unicode 
 representation directly to the input box then it searches correctly

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: svn commit: r1375953 - /ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/project/gantChart.ftl

2012-08-22 Thread Sascha Rodekamp

You're welcome :-)

On 22.08.2012, at 12:40, Hans Bakker mailingl...@antwebsystems.com wrote:

 You saved my day, I have a presentation tomorrow,
 
 Thanks!
 
 Regards,
 Hans
 
 On 08/22/2012 04:23 PM, sascharodek...@apache.org wrote:
 Author: sascharodekamp
 Date: Wed Aug 22 09:23:52 2012
 New Revision: 1375953
 
 URL: http://svn.apache.org/viewvc?rev=1375953view=rev
 Log:
 - Fixed a bug, the Projectmgr GantChart was not shown anymore. Thanks Hans 
 for reposting on the user ML
 
 Modified:
 
 ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/project/gantChart.ftl
 
 Modified: 
 ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/project/gantChart.ftl
 URL: 
 http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/project/gantChart.ftl?rev=1375953r1=1375952r2=1375953view=diff
 ==
 --- 
 ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/project/gantChart.ftl
  (original)
 +++ 
 ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/project/gantChart.ftl
  Wed Aug 22 09:23:52 2012
 @@ -33,7 +33,7 @@ g.setShowComp(1); // Show/Hide % Complet
  g.AddTaskItem(new JSGantt.TaskItem(${t.phaseNr}, 
 ${t.phaseSeqNum?if_exists}. ${t.phaseName}, , , 00ff00, , 0, , 
 0, 1, 0, 1));
  /#if
  #if t.workEffortTypeId == TASK
 -g.AddTaskItem(new 
 JSGantt.TaskItem(${t.taskNr},${t.taskSeqNum?if_exists}. 
 ${t.taskName},${StringUtil.wrapString(t.estimatedStartDate)}, 
 ${StringUtil.wrapString(t.estimatedCompletionDate)},009900, ${t.url}, 
 0 , ${t.resource?if_exists}, ${t.completion?if_exists} , 0, ${t.phaseNr}, 
 1#if t.preDecessor?exists, ${t.preDecessor}/#if));
 +g.AddTaskItem(new 
 JSGantt.TaskItem(${t.taskNr},${t.taskSeqNum?if_exists}. 
 ${t.taskName},${StringUtil.wrapString(t.estimatedStartDate)}, 
 ${StringUtil.wrapString(t.estimatedCompletionDate)},009900, ${t.url}, 
 0 , ${t.resource?if_exists}, ${t.completion?if_exists} , 0, ${t.phaseNr}, 
 1#if t.preDecessor?exists, ${t.preDecessor}/#if));
  /#if
  #if t.workEffortTypeId == MILESTONE
  g.AddTaskItem(new 
 JSGantt.TaskItem(${t.taskNr},${t.taskName},${StringUtil.wrapString(t.estimatedStartDate)},
  ${StringUtil.wrapString(t.estimatedCompletionDate)},00ff00, , 1 , 
 ${t.resource?if_exists}, ${t.completion?if_exists} , 0,${t.phaseNr}, , 
  ));

[jira] [Assigned] (OFBIZ-4982) js issue causes error when invalid dates are entered

2012-08-06 Thread Sascha Rodekamp (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sascha Rodekamp reassigned OFBIZ-4982:
--

Assignee: Sascha Rodekamp

 js issue causes error when invalid dates are entered
 

 Key: OFBIZ-4982
 URL: https://issues.apache.org/jira/browse/OFBIZ-4982
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: SVN trunk
Reporter: Christoph Neuroth
Assignee: Sascha Rodekamp
Priority: Minor
 Attachments: ofbiz-i18n_dateinput_null_fix.patch


 Reproduce: Enter 123 in a DateField. This will trigger a JS exception and 
 the invalid value will be sent to the server on form submission, probably 
 causing server-side exceptions in badly written backend code, resulting in 
 really bad error messages for the user.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4982) js issue causes error when invalid dates are entered

2012-08-06 Thread Sascha Rodekamp (JIRA)

[
https://issues.apache.org/jira/browse/OFBIZ-4982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13429114#comment-13429114
]

Sascha Rodekamp commented on OFBIZ-4982:

Hi Christoph,
thanks for the patch.
One thought that comes in my mind: Is it a good idea to remove wrong date
inputs? It's obvious when you type 123 in the Date/Time field. But what if
the user accidentally switched day and month which could also result in an
exception. If we remove the wrong input field this wouldn't be noticed at all.
Is it possible to use a custom validation to highlight the field on a wrong
input?

Many thanks
Sascha

js issue causes error when invalid dates are entered

Key: OFBIZ-4982
URL: https://issues.apache.org/jira/browse/OFBIZ-4982
Project: OFBiz
Issue Type: Bug
Components: framework
Affects Versions: SVN trunk
Reporter: Christoph Neuroth
Assignee: Sascha Rodekamp
Priority: Minor
Attachments: ofbiz-i18n_dateinput_null_fix.patch

Reproduce: Enter 123 in a DateField. This will trigger a JS exception and
the invalid value will be sent to the server on form submission, probably
causing server-side exceptions in badly written backend code, resulting in
really bad error messages for the user.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (OFBIZ-4982) js issue causes error when invalid dates are entered

2012-08-06 Thread Sascha Rodekamp (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sascha Rodekamp closed OFBIZ-4982.
--

   Resolution: Fixed
Fix Version/s: SVN trunk

Hi Christoph,

you're patch is in trunk @Rev 1370123

Many thanks
Sascha

 js issue causes error when invalid dates are entered
 

 Key: OFBIZ-4982
 URL: https://issues.apache.org/jira/browse/OFBIZ-4982
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: SVN trunk
Reporter: Christoph Neuroth
Assignee: Sascha Rodekamp
Priority: Minor
 Fix For: SVN trunk

 Attachments: ofbiz-i18n_dateinput_null_fix.patch


 Reproduce: Enter 123 in a DateField. This will trigger a JS exception and 
 the invalid value will be sent to the server on form submission, probably 
 causing server-side exceptions in badly written backend code, resulting in 
 really bad error messages for the user.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (OFBIZ-4752) Error in Content CMS click Find

2012-08-02 Thread Sascha Rodekamp (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sascha Rodekamp closed OFBIZ-4752.
--

   Resolution: Not A Problem
Fix Version/s: SVN trunk

Will close this issue now. If this error occurs again we can reopen it.

 Error in Content  CMS click Find
 -

 Key: OFBIZ-4752
 URL: https://issues.apache.org/jira/browse/OFBIZ-4752
 Project: OFBiz
  Issue Type: Bug
  Components: content
Affects Versions: SVN trunk
 Environment: demo-trunk
Reporter: Tom Burns
Assignee: Sascha Rodekamp
Priority: Minor
 Fix For: SVN trunk


 To reproduce:
 In Content Manager 
 (https://demo-trunk.ofbiz.apache.org/content/control/CMSContentFind)
 select CMS then click Find button located above the title CMS Content 
 Find 
 Expected: ?
 Actual: Error message
 org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen 
 [component://content/widget/cms/CMSScreens.xml#AdminSearch]: 
 java.lang.IllegalArgumentException: Error running script at location 
 [component://content/webapp/content/WEB-INF/actions/cms/Search.groovy]: 
 javax.script.ScriptException: org.apache.lucene.index.IndexNotFoundException: 
 no segments* file found in 
 org.apache.lucene.store.MMapDirectory@/home/ofbiz/trunk/applications/content/index
  lockFactory=org.apache.lucene.store.NativeFSLockFactory@4bbbf4ee: files: 
 [indexhere.txt] (Error running script at location 
 [component://content/webapp/content/WEB-INF/actions/cms/Search.groovy]: 
 javax.script.ScriptException: org.apache.lucene.index.IndexNotFoundException: 
 no segments* file found in 
 org.apache.lucene.store.MMapDirectory@/home/ofbiz/trunk/applications/content/index
  lockFactory=org.apache.lucene.store.NativeFSLockFactory@4bbbf4ee: files: 
 [indexhere.txt])

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (OFBIZ-4281) parse javascript link wrongly in lookup layer dialog if there's slash '/' in data

2012-07-09 Thread Sascha Rodekamp (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sascha Rodekamp closed OFBIZ-4281.
--

Resolution: Fixed

Thanks Leon fixed in Trunk @Rev1358988

 parse javascript link wrongly in lookup layer dialog if there's slash '/' in 
 data
 -

 Key: OFBIZ-4281
 URL: https://issues.apache.org/jira/browse/OFBIZ-4281
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: SVN trunk
Reporter: Leon
Assignee: Sascha Rodekamp
Priority: Trivial
 Fix For: SVN trunk

 Attachments: fieldlookup.js.patch


 e.g. in lookup dialog (in layer mode), one href value of a link is 
 javascript:set_value('123/ABC');, then the ofbiz framework will parse it to 
 javascript:lookupAjaxRequest('ABC'');presentation=layer'). It's wrong. 
 Correct one should be given href itself.
 to fix:
 judge whether the link contains javascript:set_ before split it by slash 
 '/'.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (OFBIZ-4950) Lookup filed with target-parameter attribute set cannot be displayed.

2012-07-04 Thread Sascha Rodekamp (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sascha Rodekamp reassigned OFBIZ-4950:
--

Assignee: Sascha Rodekamp

 Lookup filed with target-parameter attribute set cannot be displayed.
 -

 Key: OFBIZ-4950
 URL: https://issues.apache.org/jira/browse/OFBIZ-4950
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: SVN trunk
Reporter: Leon
Assignee: Sascha Rodekamp
Priority: Minor
 Fix For: SVN trunk

 Attachments: OFBIZ-4950.patch


 if lookup field has attribute target-parameter set, then there's 
 javascript error in front end and lookup icon disappears.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (OFBIZ-4950) Lookup filed with target-parameter attribute set cannot be displayed.

2012-07-04 Thread Sascha Rodekamp (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sascha Rodekamp closed OFBIZ-4950.
--

Resolution: Fixed

Hi Leon,
many thanks. I committed your patch in Trunk @Rev1357098

Have a good day
Sascha

 Lookup filed with target-parameter attribute set cannot be displayed.
 -

 Key: OFBIZ-4950
 URL: https://issues.apache.org/jira/browse/OFBIZ-4950
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: SVN trunk
Reporter: Leon
Assignee: Sascha Rodekamp
Priority: Minor
 Fix For: SVN trunk

 Attachments: OFBIZ-4950.patch


 if lookup field has attribute target-parameter set, then there's 
 javascript error in front end and lookup icon disappears.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (OFBIZ-4951) entity/src ommited in .classpath that makes project built failed in eclipse.

2012-07-04 Thread Sascha Rodekamp (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sascha Rodekamp closed OFBIZ-4951.
--

Resolution: Duplicate
  Assignee: Sascha Rodekamp

Right, it's already fixed.
Anyway thanks for reporting Leon!

Have a good day
Sascha

 entity/src ommited in .classpath that makes project built failed in eclipse.
 --

 Key: OFBIZ-4951
 URL: https://issues.apache.org/jira/browse/OFBIZ-4951
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: SVN trunk
Reporter: Leon
Assignee: Sascha Rodekamp
Priority: Trivial
 Fix For: SVN trunk

 Attachments: OFBIZ-4951.patch


 in latest revision of trunk, the classpathentry of entity/src is removed 
 for some reason, it causes eclipse unalbe to build project successfully.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (OFBIZ-4948) Render checkbox field as same behavior as radiobox

2012-06-29 Thread Sascha Rodekamp (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sascha Rodekamp closed OFBIZ-4948.
--

Resolution: Fixed
  Assignee: Sascha Rodekamp

Hi Leon, thanks for the patch.

It's committed in trunk @Rev1355291

 Render checkbox field as same behavior as radiobox
 --

 Key: OFBIZ-4948
 URL: https://issues.apache.org/jira/browse/OFBIZ-4948
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: Leon
Assignee: Sascha Rodekamp
Priority: Trivial
 Fix For: SVN trunk

 Attachments: OFBIZ-4948.patch


 when rendering a radio field in form widget, the generated html codes looks 
 like: spaninput type=radio ...blahblah/span. The radio box and its 
 description are wrapped by span and it's easy to change css style for both 
 of them (radio and description), not only for radio type input. But the check 
 box is rendered in another way without span around.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4915) Lookup Form not working with Arabic characters

2012-06-28 Thread Sascha Rodekamp (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13402881#comment-13402881
 ] 

Sascha Rodekamp commented on OFBIZ-4915:


Hi Taher,
when sending data to the server I used the jQuery serialize() function to read 
the input parameter form the form. The serialize function uses standard URL 
encoding. Could this be a problem.
you can find the code in the function lookupFormAjaxRequest().

Have a good day
Sascha

 Lookup Form not working with Arabic characters
 --

 Key: OFBIZ-4915
 URL: https://issues.apache.org/jira/browse/OFBIZ-4915
 Project: OFBiz
  Issue Type: Bug
  Components: ALL COMPONENTS
Affects Versions: Release Branch 11.04, Release Branch 12.04
Reporter: Taher Alkhateeb
Assignee: Jacques Le Roux
Priority: Minor
  Labels: form, jQuery, javascript, lookup
 Attachments: XHR_Screenshot_27_06_2012.png, 
 search_party_after_submit.png, search_party_before_submit.png


 Any field in a form that uses the lookup target-form-name=WhateverForm/ 
 would not return results when searching in Arabic. I suspect the main 
 offender is javascript/jQuery when parsing user input.
 For example, if I go to https://localhost:8443/ordermgr/control/findorders 
 and click on Party ID, and search the firstname or lastname in arabic, no 
 values are returned and the value in the search box changes from arabic to 
 some weird encoding ( e.g. حسن becomes ØØ³Ù )
 Also, after some investigation, I came to the realization that this only 
 happens when the lookup field has presentation=layer, if however, the 
 presentation=window then it works normally which leads me to conclude 
 definitely that this is javascript/jQuery issue of parsing input data. More 
 specifically, this is javascript not processing with the correct encoding 
 (unicode in this case). I know this because if I paste the unicode 
 representation directly to the input box then it searches correctly

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: Proposal for a GUI/Web debug mode

2012-06-26 Thread Sascha Rodekamp

Hi Brian,
that looks good indeed. But is there a higher value of this debug mode
compared to browser tools like Firebug?

Have a good day
Sascha



2012/6/25 Brian Cunningham nakoma...@gmail.com:
 Hi Dev group,

 I'm very new to OFBiz, so I may be covering old ground. If not, I'd like to
 propose a debug mode for the UI of OFBiz along the lines of that in OLAT.

 If you've never seen it, take a look at:

 http://demo.olat.org/demo/dmz/

  - click the word System Administrator in the dropdown to fill in the
 username/password form.

  - once you are logged in as System Administrator click the tiny green bug
 icon in the upper left corner of the page to turn on debug mode.

  - click the word Debug in the panel that appears.

  - move your mouse around the rest of the screen to see the templates and
 controllers associated with the various parts of the view.

 I find that with this debug mode available I can be productive modifying the
 front end of OLAT right away, whereas after a few weeks of looking at OFBiz
 I still struggle to find/remember where things are located.

 I'd be willing to work on this, but really at this point I'm just wondering
 if others think it's a useful (and feasible) feature, and/or if something
 similar already exists that I just missed.

 Brian


 --
 View this message in context: 
 http://ofbiz.135035.n4.nabble.com/Proposal-for-a-GUI-Web-debug-mode-tp4634080.html
 Sent from the OFBiz - Dev mailing list archive at Nabble.com.



-- 

Sascha Rodekamp
    Visit the new german OFBiz Blog: http://www.ofbiz.biz
    Lynx-Consulting GmbH
    Johanniskirchplatz 6
    D-33615 Bielefeld
    http://www.lynx.de

locale lookups

2012-06-19 Thread Sascha Rodekamp

Hi,

as discussed in https://issues.apache.org/jira/browse/OFBIZ-4741 it
turns out, that the locale lookups (i.e. used in
https://demo-trunk.ofbiz.apache.org/content/control/findContent) have
no working filter functionality because the lookup find calls each
time UtilMisc.availableLocales() without filtering.

One solution could be to
- revert the changes to the old drop down list

an alternative is
- create a database table for locales that the Search Services could
be used, that's of course a bigger change

What do you think?

Best regards,
Sascha

-- 

Sascha Rodekamp
    Visit the new german OFBiz Blog: http://www.ofbiz.biz
    Lynx-Consulting GmbH
    Johanniskirchplatz 6
    D-33615 Bielefeld
    http://www.lynx.de

[jira] [Closed] (OFBIZ-4633) Contact List Lookup is not working in catalog for products.

2012-06-19 Thread Sascha Rodekamp (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sascha Rodekamp closed OFBIZ-4633.
--

Resolution: Fixed
  Assignee: Sascha Rodekamp

Hi Arpit,
thanks for the patch it's committed in turnk @Rev 1351584

 Contact List Lookup is not working in catalog for products.
 ---

 Key: OFBIZ-4633
 URL: https://issues.apache.org/jira/browse/OFBIZ-4633
 Project: OFBiz
  Issue Type: Bug
  Components: product
Affects Versions: SVN trunk
Reporter: Arpit Singh Pandya
Assignee: Sascha Rodekamp
Priority: Minor
 Fix For: SVN trunk

 Attachments: OFBIZ-4633.patch


 Contact List Lookup is not working in catalog for product in Communications 
 tab, when creating new Communication Event for new product. I have tested it 
 on local and on demo-trunk, not sure about other versions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: locale lookups

2012-06-19 Thread Sascha Rodekamp

Hans added the locale lookups.
@Hans are you ok with reverting the lookups to the original drop down list?


2012/6/19 Ankit Jain ankit.i...@gmail.com:
 Locale Lookup is used in few places only, so I think reverting it to
 dropdown is good instead of creating new entity.


 Regards,
 Ankit Jain




 On Tue, Jun 19, 2012 at 11:57 AM, Sascha Rodekamp 
 sascha.rodekamp.lynx...@googlemail.com wrote:

 Hi,

 as discussed in https://issues.apache.org/jira/browse/OFBIZ-4741 it
 turns out, that the locale lookups (i.e. used in
 https://demo-trunk.ofbiz.apache.org/content/control/findContent) have
 no working filter functionality because the lookup find calls each
 time UtilMisc.availableLocales() without filtering.

 One solution could be to
 - revert the changes to the old drop down list

 an alternative is
 - create a database table for locales that the Search Services could
 be used, that's of course a bigger change

 What do you think?

 Best regards,
 Sascha

 --

 Sascha Rodekamp
     Visit the new german OFBiz Blog: http://www.ofbiz.biz
     Lynx-Consulting GmbH
     Johanniskirchplatz 6
     D-33615 Bielefeld
     http://www.lynx.de




-- 

Sascha Rodekamp
    Visit the new german OFBiz Blog: http://www.ofbiz.biz
    Lynx-Consulting GmbH
    Johanniskirchplatz 6
    D-33615 Bielefeld
    http://www.lynx.de

Re: locale lookups

2012-06-19 Thread Sascha Rodekamp

Ok thanks Hans.
Done in Rev 1351614

Have a good day
Sascha

2012/6/19 Hans Bakker mailingl...@antwebsystems.com:
 On 06/19/2012 02:45 PM, Sascha Rodekamp wrote:

 Hans added the locale lookups.
 @Hans are you ok with reverting the lookups to the original drop down
 list?

 sure, if that work better..


 2012/6/19 Ankit Jainankit.i...@gmail.com:

 Locale Lookup is used in few places only, so I think reverting it to
 dropdown is good instead of creating new entity.


 Regards,
 Ankit Jain




 On Tue, Jun 19, 2012 at 11:57 AM, Sascha Rodekamp
 sascha.rodekamp.lynx...@googlemail.com  wrote:

 Hi,

 as discussed in https://issues.apache.org/jira/browse/OFBIZ-4741 it
 turns out, that the locale lookups (i.e. used in
 https://demo-trunk.ofbiz.apache.org/content/control/findContent) have
 no working filter functionality because the lookup find calls each
 time UtilMisc.availableLocales() without filtering.

 One solution could be to
 - revert the changes to the old drop down list

 an alternative is
 - create a database table for locales that the Search Services could
 be used, that's of course a bigger change

 What do you think?

 Best regards,
 Sascha

 --

 Sascha Rodekamp
     Visit the new german OFBiz Blog: http://www.ofbiz.biz
     Lynx-Consulting GmbH
     Johanniskirchplatz 6
     D-33615 Bielefeld
     http://www.lynx.de







-- 

Sascha Rodekamp
    Visit the new german OFBiz Blog: http://www.ofbiz.biz
    Lynx-Consulting GmbH
    Johanniskirchplatz 6
    D-33615 Bielefeld
    http://www.lynx.de

[jira] [Closed] (OFBIZ-3504) possible null exception in CompanyHeader.groovy due to incorrect check (fix included)

2012-06-19 Thread Sascha Rodekamp (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-3504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sascha Rodekamp closed OFBIZ-3504.
--

Resolution: Fixed
  Assignee: Sascha Rodekamp

Already fixed in Rev956402

 possible null exception in CompanyHeader.groovy due to incorrect check (fix 
 included)
 -

 Key: OFBIZ-3504
 URL: https://issues.apache.org/jira/browse/OFBIZ-3504
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: SVN trunk
Reporter: Mike Voytovich
Assignee: Sascha Rodekamp
Priority: Minor
 Fix For: SVN trunk

 Attachments: CompanyHeader.groovy.patch

   Original Estimate: 0h
  Remaining Estimate: 0h

 There's a minor bug in 
 applications/order/webapp/ordermgr/WEB-INF/actions/order/CompanyHeader.groovy 
 which can cause a null exception.
 It should be checking orh.getBillFromParty() for null, instead of 
 orh.getBillToParty(). 
 Here's the fix:
 Index: 
 repos/ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/order/CompanyHeader.groovy
 ===
 --- 
 repos/ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/order/CompanyHeader.groovy
(revision 73)
 +++ 
 repos/ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/order/CompanyHeader.groovy
(revision 74)
 @@ -67,7 +67,7 @@
  orh = new OrderReadHelper(orderHeader);
  // for sales order, the logo party is the BILL_FROM_VENDOR of the 
 order.  If that's not available, we'll use the OrderHeader's ProductStore's 
 payToPartyId
  if (SALES_ORDER.equals(orderHeader.orderTypeId)) {
 -if (orh.getBillToParty()) {
 +if (orh.getBillFromParty()) {
  partyId = orh.getBillFromParty().partyId;
  } else {
  productStore = orderHeader.getRelatedOne(ProductStore);

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (OFBIZ-4741) Error in Find Content Lookup


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sascha Rodekamp closed OFBIZ-4741.
--

   Resolution: Not A Problem
Fix Version/s: SVN trunk
 Assignee: Sascha Rodekamp

Hi Tom,
seems that the lookup works again, i'm able to select a locale string in the 
trunk when searching for content.

Thanks for reporting.
Sascha


 Error in Find Content Lookup
 

 Key: OFBIZ-4741
 URL: https://issues.apache.org/jira/browse/OFBIZ-4741
 Project: OFBiz
  Issue Type: Bug
  Components: content
Affects Versions: SVN trunk
Reporter: Tom Burns
Assignee: Sascha Rodekamp
Priority: Minor
 Fix For: SVN trunk


 To reproduce:
 In Content Manager select Content
 (https://demo-trunk.ofbiz.apache.org/content/control/findContent)
 Click Lookup Icon for Locale String
 Expected: Lookup Locale dialog
 Actual: Error message
 org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen 
 [component://common/widget/CommonScreens.xml#LookupDecorator]: 
 java.lang.ClassCastException: java.util.LinkedHashMap cannot be cast to 
 java.util.Locale (java.util.LinkedHashMap cannot be cast to java.util.Locale)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4752) Error in Content CMS click Find


[ 
https://issues.apache.org/jira/browse/OFBIZ-4752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13395845#comment-13395845
 ] 

Sascha Rodekamp commented on OFBIZ-4752:


Hi Tom,
seems that you hadn't create your search index. 

{code}
javax.script.ScriptException: org.apache.lucene.index.IndexNotFoundException: 
no segments* file found in 
org.apache.lucene.store.MMapDirectory@/home/ofbiz/trunk/applications/content/index
 
{code}

Go to WebTools - Run Service and run the indexTree service. After creating 
the index the search should work.

Let me now if this work for you.

Have a good day
Sascha

 Error in Content  CMS click Find
 -

 Key: OFBIZ-4752
 URL: https://issues.apache.org/jira/browse/OFBIZ-4752
 Project: OFBiz
  Issue Type: Bug
  Components: content
Affects Versions: SVN trunk
 Environment: demo-trunk
Reporter: Tom Burns
Priority: Minor

 To reproduce:
 In Content Manager 
 (https://demo-trunk.ofbiz.apache.org/content/control/CMSContentFind)
 select CMS then click Find button located above the title CMS Content 
 Find 
 Expected: ?
 Actual: Error message
 org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen 
 [component://content/widget/cms/CMSScreens.xml#AdminSearch]: 
 java.lang.IllegalArgumentException: Error running script at location 
 [component://content/webapp/content/WEB-INF/actions/cms/Search.groovy]: 
 javax.script.ScriptException: org.apache.lucene.index.IndexNotFoundException: 
 no segments* file found in 
 org.apache.lucene.store.MMapDirectory@/home/ofbiz/trunk/applications/content/index
  lockFactory=org.apache.lucene.store.NativeFSLockFactory@4bbbf4ee: files: 
 [indexhere.txt] (Error running script at location 
 [component://content/webapp/content/WEB-INF/actions/cms/Search.groovy]: 
 javax.script.ScriptException: org.apache.lucene.index.IndexNotFoundException: 
 no segments* file found in 
 org.apache.lucene.store.MMapDirectory@/home/ofbiz/trunk/applications/content/index
  lockFactory=org.apache.lucene.store.NativeFSLockFactory@4bbbf4ee: files: 
 [indexhere.txt])

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (OFBIZ-4752) Error in Content CMS click Find


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sascha Rodekamp reassigned OFBIZ-4752:
--

Assignee: Sascha Rodekamp

 Error in Content  CMS click Find
 -

 Key: OFBIZ-4752
 URL: https://issues.apache.org/jira/browse/OFBIZ-4752
 Project: OFBiz
  Issue Type: Bug
  Components: content
Affects Versions: SVN trunk
 Environment: demo-trunk
Reporter: Tom Burns
Assignee: Sascha Rodekamp
Priority: Minor

 To reproduce:
 In Content Manager 
 (https://demo-trunk.ofbiz.apache.org/content/control/CMSContentFind)
 select CMS then click Find button located above the title CMS Content 
 Find 
 Expected: ?
 Actual: Error message
 org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen 
 [component://content/widget/cms/CMSScreens.xml#AdminSearch]: 
 java.lang.IllegalArgumentException: Error running script at location 
 [component://content/webapp/content/WEB-INF/actions/cms/Search.groovy]: 
 javax.script.ScriptException: org.apache.lucene.index.IndexNotFoundException: 
 no segments* file found in 
 org.apache.lucene.store.MMapDirectory@/home/ofbiz/trunk/applications/content/index
  lockFactory=org.apache.lucene.store.NativeFSLockFactory@4bbbf4ee: files: 
 [indexhere.txt] (Error running script at location 
 [component://content/webapp/content/WEB-INF/actions/cms/Search.groovy]: 
 javax.script.ScriptException: org.apache.lucene.index.IndexNotFoundException: 
 no segments* file found in 
 org.apache.lucene.store.MMapDirectory@/home/ofbiz/trunk/applications/content/index
  lockFactory=org.apache.lucene.store.NativeFSLockFactory@4bbbf4ee: files: 
 [indexhere.txt])

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4741) Error in Find Content Lookup


[ 
https://issues.apache.org/jira/browse/OFBIZ-4741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13395874#comment-13395874
 ] 

Sascha Rodekamp commented on OFBIZ-4741:


Hi Ankit, Hi Tom
my button is also displaied (FF13, IE8). 
But you are right the filtering doesn't work. The GetLocaleList.groovy calls 
every time:

{code}
availableLocales = UtilMisc.availableLocales()
{code} 

and gets the full locale list (and not a filtered one).

 Error in Find Content Lookup
 

 Key: OFBIZ-4741
 URL: https://issues.apache.org/jira/browse/OFBIZ-4741
 Project: OFBiz
  Issue Type: Bug
  Components: content
Affects Versions: SVN trunk
Reporter: Tom Burns
Assignee: Sascha Rodekamp
Priority: Minor
 Fix For: SVN trunk

 Attachments: Content Missing Locale Lookup.jpg, Content With Locale 
 Lookup on localhost.jpg


 To reproduce:
 In Content Manager select Content
 (https://demo-trunk.ofbiz.apache.org/content/control/findContent)
 Click Lookup Icon for Locale String
 Expected: Lookup Locale dialog
 Actual: Error message
 org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen 
 [component://common/widget/CommonScreens.xml#LookupDecorator]: 
 java.lang.ClassCastException: java.util.LinkedHashMap cannot be cast to 
 java.util.Locale (java.util.LinkedHashMap cannot be cast to java.util.Locale)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Comment Edited] (OFBIZ-4741) Error in Find Content Lookup


[ 
https://issues.apache.org/jira/browse/OFBIZ-4741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13395874#comment-13395874
 ] 

Sascha Rodekamp edited comment on OFBIZ-4741 at 6/18/12 1:16 PM:
-

Hi Ankit, Hi Tom
my button is also visible (FF13, IE8). 
But you are right the filtering doesn't work. The GetLocaleList.groovy calls 
every time:

{code}
availableLocales = UtilMisc.availableLocales()
{code} 

and gets the full locale list (and not a filtered one).

  was (Author: sascha):
Hi Ankit, Hi Tom
my button is also displaied (FF13, IE8). 
But you are right the filtering doesn't work. The GetLocaleList.groovy calls 
every time:

{code}
availableLocales = UtilMisc.availableLocales()
{code} 

and gets the full locale list (and not a filtered one).
  
 Error in Find Content Lookup
 

 Key: OFBIZ-4741
 URL: https://issues.apache.org/jira/browse/OFBIZ-4741
 Project: OFBiz
  Issue Type: Bug
  Components: content
Affects Versions: SVN trunk
Reporter: Tom Burns
Assignee: Sascha Rodekamp
Priority: Minor
 Fix For: SVN trunk

 Attachments: Content Missing Locale Lookup.jpg, Content With Locale 
 Lookup on localhost.jpg


 To reproduce:
 In Content Manager select Content
 (https://demo-trunk.ofbiz.apache.org/content/control/findContent)
 Click Lookup Icon for Locale String
 Expected: Lookup Locale dialog
 Actual: Error message
 org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen 
 [component://common/widget/CommonScreens.xml#LookupDecorator]: 
 java.lang.ClassCastException: java.util.LinkedHashMap cannot be cast to 
 java.util.Locale (java.util.LinkedHashMap cannot be cast to java.util.Locale)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4741) Error in Find Content Lookup


[ 
https://issues.apache.org/jira/browse/OFBIZ-4741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13396524#comment-13396524
 ] 

Sascha Rodekamp commented on OFBIZ-4741:


Hi Tom, 
yes good point. The Locale lookup form seems useless. 
We should discuss in the ML if we should rollback.



 Error in Find Content Lookup
 

 Key: OFBIZ-4741
 URL: https://issues.apache.org/jira/browse/OFBIZ-4741
 Project: OFBiz
  Issue Type: Bug
  Components: content
Affects Versions: SVN trunk
Reporter: Tom Burns
Assignee: Sascha Rodekamp
Priority: Minor
 Fix For: SVN trunk

 Attachments: Content Missing Locale Lookup.jpg, Content With Locale 
 Lookup on localhost.jpg


 To reproduce:
 In Content Manager select Content
 (https://demo-trunk.ofbiz.apache.org/content/control/findContent)
 Click Lookup Icon for Locale String
 Expected: Lookup Locale dialog
 Actual: Error message
 org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen 
 [component://common/widget/CommonScreens.xml#LookupDecorator]: 
 java.lang.ClassCastException: java.util.LinkedHashMap cannot be cast to 
 java.util.Locale (java.util.LinkedHashMap cannot be cast to java.util.Locale)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (OFBIZ-4836) Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz

2012-06-13 Thread Sascha Rodekamp (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sascha Rodekamp updated OFBIZ-4836:
---

Affects Version/s: (was: SVN trunk)
Fix Version/s: (was: SVN trunk)
 Assignee: Sascha Rodekamp

 Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz
 -

 Key: OFBIZ-4836
 URL: https://issues.apache.org/jira/browse/OFBIZ-4836
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework
Reporter: Pierre Smits
Assignee: Sascha Rodekamp
Priority: Blocker
 Attachments: OFBIZ-4836-jcr-entity.patch, OFBIZ-4836_JCR_MultiTenancy 
 .patch, OFBIZ-4836_JCR_MultiTenancy.patch, jcr-config.xml


 When having multiple tenants and one of the users (of a tenant) creates 
 (uploads) a file to JCR then this file is visible to all users of all tenants

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (OFBIZ-4836) Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz

2012-06-13 Thread Sascha Rodekamp (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sascha Rodekamp closed OFBIZ-4836.
--

Resolution: Fixed

Issue fixed in jackrabbit20120501 branch @ Rev 1347578

 Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz
 -

 Key: OFBIZ-4836
 URL: https://issues.apache.org/jira/browse/OFBIZ-4836
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework
Reporter: Pierre Smits
Assignee: Sascha Rodekamp
Priority: Blocker
 Attachments: OFBIZ-4836-jcr-entity.patch, OFBIZ-4836_JCR_MultiTenancy 
 .patch, OFBIZ-4836_JCR_MultiTenancy.patch, jcr-config.xml


 When having multiple tenants and one of the users (of a tenant) creates 
 (uploads) a file to JCR then this file is visible to all users of all tenants

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: Moving framework/jcr out of trunk and back to experimental branch

2012-05-31 Thread Sascha Rodekamp

Hey guys,
sry for the late response.

The new branch is for the further jackrabbit / ofbiz integration, to
keep the new experimental features away from the trunk until they work
reliable. I didn't remove the jcr code form the trunk because the
basic content repository functionality works and can be used.

But it seems that not many people are interested in the JCR feature
(or haven't time to support it). So it's ok to me to remove it from
the trunk for now.

Regards
Sascha

2012/5/26 Jacques Le Roux jacques.le.r...@les7arts.com:
 +1

 I saw that Sascha did it already at
 http://svn.apache.org/viewvc?rev=1332706view=rev
 I don't know why he did not remove from trunk...

 Sascha?

 Jacques

 From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com

 Here are some of the arguments for moving it out of trunk:
 * it is still a work in progress, and not really used in OFBiz (afaik
 apart from some examples in the example component)
 * the architecture and goals of this component that should replace or
 enhance the OFBiz content framework are still to be defined
 * a lot of code under jcr component is clearly a work in progress and not
 ready for distribution: several files are missing the license header (have
 they been copied?)
 * most of the jars in it are not listed under the LICENSE and NOTICE files
 * logging from JCR are not properly formatted (and make me think that we
 do not have proper configuration in log4j for it)
 * the development on it is staling

 In summary, I think it was moved too early out of the experimental branch.
 What do you think?

 Kind regards,

 Jacopo






-- 

Sascha Rodekamp
    Visit the new german OFBiz Blog: http://www.ofbiz.biz
    Lynx-Consulting GmbH
    Johanniskirchplatz 6
    D-33615 Bielefeld
    http://www.lynx.de

Re: Moving framework/jcr out of trunk and back to experimental branch

2012-05-31 Thread Sascha Rodekamp

Hi Jacopo,
nope the branch is up to date so i don't lose anything if you remove it.



2012/5/31 Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com:
 Thank you Sascha,

 please see inline:

 On May 31, 2012, at 11:23 AM, Sascha Rodekamp wrote:

 Hey guys,
 sry for the late response.

 The new branch is for the further jackrabbit / ofbiz integration, to
 keep the new experimental features away from the trunk until they work
 reliable. I didn't remove the jcr code form the trunk because the
 basic content repository functionality works and can be used.

 But it seems that not many people are interested in the JCR feature
 (or haven't time to support it). So it's ok to me to remove it from
 the trunk for now.

 My concern is not on the number of people interested that could grow over 
 time but on the fact that the code in trunk is still too 
 experimental/incomplete (I have mentioned a few issues earlier in this 
 thread): this is why I think that at the moment the release branch would be a 
 better place for it.
 If I will find time to remove it will be fine or you will loose any work? I 
 mean, is the branch updated or do you have a good checkout of your code?

 Regards,

 Jacopo



 Regards
 Sascha

 2012/5/26 Jacques Le Roux jacques.le.r...@les7arts.com:
 +1

 I saw that Sascha did it already at
 http://svn.apache.org/viewvc?rev=1332706view=rev
 I don't know why he did not remove from trunk...

 Sascha?

 Jacques

 From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com

 Here are some of the arguments for moving it out of trunk:
 * it is still a work in progress, and not really used in OFBiz (afaik
 apart from some examples in the example component)
 * the architecture and goals of this component that should replace or
 enhance the OFBiz content framework are still to be defined
 * a lot of code under jcr component is clearly a work in progress and not
 ready for distribution: several files are missing the license header (have
 they been copied?)
 * most of the jars in it are not listed under the LICENSE and NOTICE files
 * logging from JCR are not properly formatted (and make me think that we
 do not have proper configuration in log4j for it)
 * the development on it is staling

 In summary, I think it was moved too early out of the experimental branch.
 What do you think?

 Kind regards,

 Jacopo






 --

 Sascha Rodekamp
     Visit the new german OFBiz Blog: http://www.ofbiz.biz
     Lynx-Consulting GmbH
     Johanniskirchplatz 6
     D-33615 Bielefeld
     http://www.lynx.de




-- 

Sascha Rodekamp
    Visit the new german OFBiz Blog: http://www.ofbiz.biz
    Lynx-Consulting GmbH
    Johanniskirchplatz 6
    D-33615 Bielefeld
    http://www.lynx.de

[jira] [Updated] (OFBIZ-4836) Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz

2012-05-10 Thread Sascha Rodekamp (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sascha Rodekamp updated OFBIZ-4836:
---

Attachment: OFBIZ-4836_JCR_MultiTenancy.patch

Hi,

now we have different repositories for each tenant. 

We have to make sure, that the JcrDataSource is filled for the tenant user. If 
there is no entry in the entity for a certain tenant defined, i create a 
default repository path: /data/jcr/tenantId


 Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz
 -

 Key: OFBIZ-4836
 URL: https://issues.apache.org/jira/browse/OFBIZ-4836
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework
Affects Versions: SVN trunk
Reporter: Pierre Smits
Priority: Blocker
 Fix For: SVN trunk

 Attachments: OFBIZ-4836-jcr-entity.patch, OFBIZ-4836_JCR_MultiTenancy 
 .patch, OFBIZ-4836_JCR_MultiTenancy.patch, jcr-config.xml


 When having multiple tenants and one of the users (of a tenant) creates 
 (uploads) a file to JCR then this file is visible to all users of all tenants

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4836) Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz

2012-05-09 Thread Sascha Rodekamp (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13271349#comment-13271349
 ] 

Sascha Rodekamp commented on OFBIZ-4836:


Hi Pierre,
nope. I think I did something wrong with my tenant setup. I will try to 
reproduce your issue.

Btw. I use now the new jackrabbit branch for development.

Regards,
Sascha

 Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz
 -

 Key: OFBIZ-4836
 URL: https://issues.apache.org/jira/browse/OFBIZ-4836
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework
Affects Versions: SVN trunk
Reporter: Pierre Smits
Priority: Blocker
 Fix For: SVN trunk

 Attachments: OFBIZ-4836-jcr-entity.patch, OFBIZ-4836_JCR_MultiTenancy 
 .patch, jcr-config.xml


 When having multiple tenants and one of the users (of a tenant) creates 
 (uploads) a file to JCR then this file is visible to all users of all tenants

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (OFBIZ-4836) Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz

2012-05-08 Thread Sascha Rodekamp (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sascha Rodekamp updated OFBIZ-4836:
---

Attachment: OFBIZ-4836_JCR_MultiTenancy .patch

Hi Pierre, here is a first suggestions for multi tenancy and jackrabbit.

In this version each tenant gets is own repository.

 Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz
 -

 Key: OFBIZ-4836
 URL: https://issues.apache.org/jira/browse/OFBIZ-4836
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework
Affects Versions: SVN trunk
Reporter: Pierre Smits
Priority: Blocker
 Fix For: SVN trunk

 Attachments: OFBIZ-4836-jcr-entity.patch, OFBIZ-4836_JCR_MultiTenancy 
 .patch, jcr-config.xml


 When having multiple tenants and one of the users (of a tenant) creates 
 (uploads) a file to JCR then this file is visible to all users of all tenants

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (OFBIZ-4846) Trying to cache Visit, but Visit has neverCache-option set

2012-04-26 Thread Sascha Rodekamp (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sascha Rodekamp reassigned OFBIZ-4846:
--

Assignee: Sascha Rodekamp

 Trying to cache Visit, but Visit has neverCache-option set
 --

 Key: OFBIZ-4846
 URL: https://issues.apache.org/jira/browse/OFBIZ-4846
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: Sebastian Leitner
Assignee: Sascha Rodekamp
Priority: Trivial
 Fix For: SVN trunk

 Attachments: ServerHitBin_CacheUsageVisit.patch


 The Visit-entity has the neverCache-option set, but ServerHitBin is trying to 
 cache it anyway. This should be avoided.
 I will attach a patch for this (rather trivial change).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (OFBIZ-4846) Trying to cache Visit, but Visit has neverCache-option set

2012-04-26 Thread Sascha Rodekamp (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sascha Rodekamp closed OFBIZ-4846.
--

Resolution: Fixed

Thanks Sebastian your patch is in
Trunk @Rev 1330768

 Trying to cache Visit, but Visit has neverCache-option set
 --

 Key: OFBIZ-4846
 URL: https://issues.apache.org/jira/browse/OFBIZ-4846
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: Sebastian Leitner
Assignee: Sascha Rodekamp
Priority: Trivial
 Fix For: SVN trunk

 Attachments: ServerHitBin_CacheUsageVisit.patch


 The Visit-entity has the neverCache-option set, but ServerHitBin is trying to 
 cache it anyway. This should be avoided.
 I will attach a patch for this (rather trivial change).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: svn commit: r1330779 - in /ofbiz/trunk/framework/jcr/src/org/ofbiz/jcr/loader: JCRContainer.java JCRFactory.java JCRFactoryUtil.java JCRJndi.java RepositoryFactory.java RepositoryLoader.java jackr

2012-04-26 Thread Sascha Rodekamp

, (Repository)
 JNDIContextFactory.getInitialContext(localjndi).lookup(jndiName));
 +                    repos.put(name, (Repository)
 JNDIContextFactory.getInitialContext(default).lookup(jndiName));
                 } catch (NamingException e) {
                     Debug.logError(e, module);
                 } catch (GenericConfigException e) {

 Modified:
 ofbiz/trunk/framework/jcr/src/org/ofbiz/jcr/loader/jackrabbit/JCRFactoryImpl.java
 URL:
 http://svn.apache.org/viewvc/ofbiz/trunk/framework/jcr/src/org/ofbiz/jcr/loader/jackrabbit/JCRFactoryImpl.java?rev=1330779r1=1330778r2=1330779view=diff

 ==
 ---
 ofbiz/trunk/framework/jcr/src/org/ofbiz/jcr/loader/jackrabbit/JCRFactoryImpl.java
 (original)
 +++
 ofbiz/trunk/framework/jcr/src/org/ofbiz/jcr/loader/jackrabbit/JCRFactoryImpl.java
 Thu Apr 26 11:18:51 2012
 @@ -47,7 +47,9 @@ import org.apache.jackrabbit.spi.QNodeTy
  import org.ofbiz.base.util.Debug;
  import org.ofbiz.base.util.UtilValidate;
  import org.ofbiz.base.util.UtilXml;
 +import org.ofbiz.entity.Delegator;
  import org.ofbiz.jcr.loader.JCRFactory;
 +import org.ofbiz.jcr.loader.JCRJndi;
  import org.ofbiz.jcr.orm.jackrabbit.data.JackrabbitArticle;
  import org.ofbiz.jcr.orm.jackrabbit.file.JackrabbitFile;
  import org.ofbiz.jcr.orm.jackrabbit.file.JackrabbitFolder;
 @@ -71,21 +73,28 @@ public class JCRFactoryImpl implements J

     protected static Repository repository = null;
     protected Session session = null;
 +
     protected static Mapper mapper = null;

 +    private JCRJndi jndi;
 +
     /*
      * (non-Javadoc)
      *
      * @see org.ofbiz.jcr.JCRFactory#initialize(org.w3c.dom.Element)
      */
     @Override
 -    public void initialize(Element configRootElement) throws
 RepositoryException {
 +    public void initialize(Element configRootElement, Element
 factoryImplDefinition) throws RepositoryException {
 +        homeDir = UtilXml.childElementAttribute(configRootElement,
 home-dir, path, runtime/data/jcr/);
 +        String factoryJndiName =
 factoryImplDefinition.getAttribute(jndi-name);
 +
 +        jndi = new JCRJndi(jackrabbitConfigFile, factoryJndiName,
 homeDir);
 +
         Element childElement =
 UtilXml.firstChildElement(configRootElement, jcr-credentials);
         CREDENTIALS_USERNAME = UtilXml.elementAttribute(childElement,
 username, null);
         CREDENTIALS_PASSWORD = UtilXml.elementAttribute(childElement,
 password, null).toCharArray();

         jackrabbitConfigFile =
 UtilXml.childElementAttribute(configRootElement, config-file-path,
 path, framework/jcr/config/jackrabbit.xml);
 -        homeDir = UtilXml.childElementAttribute(configRootElement,
 home-dir, path, runtime/data/jcr/);
     }

     /*
 @@ -113,6 +122,8 @@ public class JCRFactoryImpl implements J
         classes.add(JackrabbitArticle.class);

         mapper = new AnnotationMapperImpl(classes);
 +
 +        jndi.registerJcrToJndi();
     }

     /*
 @@ -136,6 +147,8 @@ public class JCRFactoryImpl implements J
                 }
             }
         }
 +
 +        jndi.unbindRepository();
     }

     /*
 @@ -186,7 +199,7 @@ public class JCRFactoryImpl implements J
     /*
      * Register some new node types
      */
 -    protected void registerNodeTypes(Session session) throws
 InvalidNodeTypeDefException, javax.jcr.RepositoryException, IOException {
 +    private void registerNodeTypes(Session session) throws
 InvalidNodeTypeDefException, javax.jcr.RepositoryException, IOException {
         InputStream xml = new FileInputStream(CUSTOM_NODE_TYPES);

         // HINT: throws InvalidNodeTypeDefException, IOException






-- 

Sascha Rodekamp
    Visit the new german OFBiz Blog: http://www.ofbiz.biz
    Lynx-Consulting GmbH
    Johanniskirchplatz 6
    D-33615 Bielefeld
    http://www.lynx.de

Re: svn commit: r1330779 - in /ofbiz/trunk/framework/jcr/src/org/ofbiz/jcr/loader: JCRContainer.java JCRFactory.java JCRFactoryUtil.java JCRJndi.java RepositoryFactory.java RepositoryLoader.java jackr

2012-04-26 Thread Sascha Rodekamp

Hm after the merge i was not able to sync it again against the trunk.
Seems that something went wrong during the reintegration. Feel free to
try... but before spending to much time i would suggest to create a
new one.

btw. the nt:unstructured issue should be solved.

2012/4/26 Pierre Smits pierre.sm...@gmail.com:
 Sascha,

 We have branch jackrabbit20100709 in svn. Can't we use that one?

 Regards,

 Pierre

 Op 26 april 2012 15:58 schreef Sascha Rodekamp 
 sascha.rodekamp.lynx...@googlemail.com het volgende:

 Hi Pierre,
 the last patch had no functional changes. It just prepares the
 repository loading for the following changes.

 That the nt:unstructured node is not found seems do be another issue.
 I will check that.

 For further implementations we definitely should create a new branch.
 But before creating it i wanted to clean up some code parts. By the
 end of this week (tomorrow) i will create one, is this ok for you?

 Thanks and regards,
 Sascha


 2012/4/26 Pierre Smits pierre.sm...@gmail.com:
  Sascha,
 
  I did a small test against this revision.
 
  Creating content in jcr works ok, but is still visible to other tenants.
 
  Upload of a file triggered following:
 
  The Following Errors Occurred:
 
  Error calling event: org.ofbiz.webapp.event.EventHandlerException:
 Problems
  processing event:
  org.apache.jackrabbit.ocm.exception.IncorrectPersistentClassException:
 Node
  type: nt:unstructured has no descriptor. (Node type: nt:unstructured has
 no
  descriptor.)
 
  Although the previous situation wasn't perfect, maybe we should implement
  and test first in the jcr branch before bringing it to trunk.
 
  Regards,
 
  Pierre
 
  Op 26 april 2012 13:18 schreef sascharodek...@apache.org het volgende:
 
  Author: sascharodekamp
  Date: Thu Apr 26 11:18:51 2012
  New Revision: 1330779
 
  URL: http://svn.apache.org/viewvc?rev=1330779view=rev
  Log:
  Clean Up the repository loding code. No functional changes.
 
  Added:
     ofbiz/trunk/framework/jcr/src/org/ofbiz/jcr/loader/JCRJndi.java
 (with
  props)
  Modified:
     ofbiz/trunk/framework/jcr/src/org/ofbiz/jcr/loader/JCRContainer.java
     ofbiz/trunk/framework/jcr/src/org/ofbiz/jcr/loader/JCRFactory.java
 
  ofbiz/trunk/framework/jcr/src/org/ofbiz/jcr/loader/JCRFactoryUtil.java
 
 
  ofbiz/trunk/framework/jcr/src/org/ofbiz/jcr/loader/RepositoryFactory.java
 
  ofbiz/trunk/framework/jcr/src/org/ofbiz/jcr/loader/RepositoryLoader.java
 
 
  ofbiz/trunk/framework/jcr/src/org/ofbiz/jcr/loader/jackrabbit/JCRFactoryImpl.java
 
  Modified:
  ofbiz/trunk/framework/jcr/src/org/ofbiz/jcr/loader/JCRContainer.java
  URL:
 
 http://svn.apache.org/viewvc/ofbiz/trunk/framework/jcr/src/org/ofbiz/jcr/loader/JCRContainer.java?rev=1330779r1=1330778r2=1330779view=diff
 
 
 ==
  --- ofbiz/trunk/framework/jcr/src/org/ofbiz/jcr/loader/JCRContainer.java
  (original)
  +++ ofbiz/trunk/framework/jcr/src/org/ofbiz/jcr/loader/JCRContainer.java
  Thu Apr 26 11:18:51 2012
  @@ -18,20 +18,13 @@
 
 
  ***/
   package org.ofbiz.jcr.loader;
 
  -import javax.jcr.Repository;
   import javax.jcr.RepositoryException;
  -import javax.naming.Context;
  -import javax.naming.NamingException;
  -import javax.naming.Reference;
  -import javax.naming.StringRefAddr;
 
   import org.ofbiz.base.config.GenericConfigException;
   import org.ofbiz.base.config.ResourceLoader;
   import org.ofbiz.base.container.Container;
   import org.ofbiz.base.container.ContainerConfig;
   import org.ofbiz.base.container.ContainerException;
  -import org.ofbiz.base.util.Debug;
  -import org.ofbiz.base.util.JNDIContextFactory;
   import org.ofbiz.base.util.UtilXml;
   import org.w3c.dom.Element;
 
  @@ -44,18 +37,9 @@ public class JCRContainer implements Con
      public static final String module = JCRContainer.class.getName();
 
      public static final String DEFAULT_JCR_CONFIG_PATH =
  framework/jcr/config/jcr-config.xml;
  -    public static final String REP_HOME_DIR = 0;
  -    public static final String CONFIG_FILE_PATH = 1;
  -
  -    private static String jndiName = null;
  -    private static String factoryClassName = null;
  -    private static String jcrContextName = null;
 
      private static String configFilePath = null;
      private boolean removeRepositoryOnShutdown = false;
  -    private String homeDir = null;
  -
  -    Context jndiContext = null;
 
      /*
       * (non-Javadoc)
  @@ -65,52 +49,12 @@ public class JCRContainer implements Con
       */
      @Override
      public void init(String[] args, String configFile) throws
  ContainerException {
  -        // get the container configuration
  -        ContainerConfig.Container cc =
  ContainerConfig.getContainer(jcr-container, configFile);
  -        if (cc == null) {
  -            throw new ContainerException(No jcr-container
 configuration
  found in container config

[jira] [Commented] (OFBIZ-4841) Have a workspace for each application/component in a repository

2012-04-25 Thread Sascha Rodekamp (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13261347#comment-13261347
 ] 

Sascha Rodekamp commented on OFBIZ-4841:


Separating the concerns in the repository by using different workspaces is, 
IMHO, a good approach. That could make maintenance of the repository and right 
management easier. 


 Have a workspace for each application/component in a repository
 ---

 Key: OFBIZ-4841
 URL: https://issues.apache.org/jira/browse/OFBIZ-4841
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework
Affects Versions: SVN trunk
Reporter: Pierre Smits
Priority: Critical

 In order to separate access to jcr content each application should have its 
 own workspace in the repository.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4842) Write configuration documentation for the Jackrabbit integration

2012-04-25 Thread Sascha Rodekamp (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13261406#comment-13261406
 ] 

Sascha Rodekamp commented on OFBIZ-4842:


I started a configuration document: 
https://cwiki.apache.org/confluence/display/OFBIZ/Configuration+document

 Write configuration documentation for the Jackrabbit integration
 

 Key: OFBIZ-4842
 URL: https://issues.apache.org/jira/browse/OFBIZ-4842
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework
Affects Versions: SVN trunk
Reporter: Pierre Smits
 Fix For: SVN trunk


 Good documentation on the implementation and configuration assist the 
 adoption of the solution

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (OFBIZ-4836) Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sascha Rodekamp updated OFBIZ-4836:
---

Issue Type: Sub-task  (was: Bug)
Parent: OFBIZ-4659

 Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz
 -

 Key: OFBIZ-4836
 URL: https://issues.apache.org/jira/browse/OFBIZ-4836
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework
Affects Versions: SVN trunk
Reporter: Pierre Smits
Priority: Blocker
 Fix For: SVN trunk


 When having multiple tenants and one of the users (of a tenant) creates 
 (uploads) a file to JCR then this file is visible to all users of all tenants

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4836) Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz


[ 
https://issues.apache.org/jira/browse/OFBIZ-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13260348#comment-13260348
 ] 

Sascha Rodekamp commented on OFBIZ-4836:


Hi Pierre, 
yes that's possible. A multi-tenancy support isn't implemented yet. 
You welcome to provide a patch. 

Which information do we need in a content node to provide multi-tenancy?
 

 Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz
 -

 Key: OFBIZ-4836
 URL: https://issues.apache.org/jira/browse/OFBIZ-4836
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: SVN trunk
Reporter: Pierre Smits
Priority: Blocker
 Fix For: SVN trunk


 When having multiple tenants and one of the users (of a tenant) creates 
 (uploads) a file to JCR then this file is visible to all users of all tenants

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4836) Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz


[ 
https://issues.apache.org/jira/browse/OFBIZ-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13260423#comment-13260423
 ] 

Sascha Rodekamp commented on OFBIZ-4836:


Hi Pierre,
yes i would also go this way. A separate repository for each tenant. Having 
tenant nodes would be a high effort and a lot of code. A lot of code means 
many potential security issues :-)






 Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz
 -

 Key: OFBIZ-4836
 URL: https://issues.apache.org/jira/browse/OFBIZ-4836
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework
Affects Versions: SVN trunk
Reporter: Pierre Smits
Priority: Blocker
 Fix For: SVN trunk


 When having multiple tenants and one of the users (of a tenant) creates 
 (uploads) a file to JCR then this file is visible to all users of all tenants

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4840) Make homedir for JCR configurable


[ 
https://issues.apache.org/jira/browse/OFBIZ-4840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13260540#comment-13260540
 ] 

Sascha Rodekamp commented on OFBIZ-4840:


Hi,
the homedir can be configured in the jcr-config.xml file. The 
JCRFactoryImpl.java read the homedir from the xml file.


 Make homedir for JCR configurable
 -

 Key: OFBIZ-4840
 URL: https://issues.apache.org/jira/browse/OFBIZ-4840
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework
Affects Versions: SVN trunk
Reporter: Pierre Smits
Priority: Critical
 Fix For: SVN trunk


 Currently the homedir for jcr is set in JCRFactoryImpl.java.
 This should be set through a property in a configuration file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4836) Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz


[ 
https://issues.apache.org/jira/browse/OFBIZ-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13260550#comment-13260550
 ] 

Sascha Rodekamp commented on OFBIZ-4836:


Hi Pierre,
not sure if i understand you right. Why we have to inject the delegator in the 
homedir?

I'm looking for a way to configure different homedirs in the jcr-config.xml.

Somthing like:
{code}
!-- jcr home directory --
home-dirs
home-dir path=runtime/data/jcr_1/ /
home-dir path=runtime/data/jcr_2/ /
/home-dirs
{code}

Than i'm able to load a repository instance for each tenant. But I'm not sure 
where to store the reference between the tenant and his repository instance, do 
you have an idea?


 Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz
 -

 Key: OFBIZ-4836
 URL: https://issues.apache.org/jira/browse/OFBIZ-4836
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework
Affects Versions: SVN trunk
Reporter: Pierre Smits
Priority: Blocker
 Fix For: SVN trunk


 When having multiple tenants and one of the users (of a tenant) creates 
 (uploads) a file to JCR then this file is visible to all users of all tenants

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (OFBIZ-4836) Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sascha Rodekamp updated OFBIZ-4836:
---

Attachment: jcr-config.xml

Maybe it's better to extend the whole config not only the home dir. That gives 
us the possibility to use a tenant independent JCR implementation.
What do you think?

 Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz
 -

 Key: OFBIZ-4836
 URL: https://issues.apache.org/jira/browse/OFBIZ-4836
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework
Affects Versions: SVN trunk
Reporter: Pierre Smits
Priority: Blocker
 Fix For: SVN trunk

 Attachments: jcr-config.xml


 When having multiple tenants and one of the users (of a tenant) creates 
 (uploads) a file to JCR then this file is visible to all users of all tenants

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Issue Comment Edited] (OFBIZ-4836) Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz


[ 
https://issues.apache.org/jira/browse/OFBIZ-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13260582#comment-13260582
 ] 

Sascha Rodekamp edited comment on OFBIZ-4836 at 4/24/12 2:09 PM:
-

Maybe it's better to extend the whole config not only the home dir (see 
jcr-config.xml file). That gives us the possibility to use a tenant independent 
JCR implementation.
What do you think?

  was (Author: sascha):
Maybe it's better to extend the whole config not only the home dir. That 
gives us the possibility to use a tenant independent JCR implementation.
What do you think?
  
 Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz
 -

 Key: OFBIZ-4836
 URL: https://issues.apache.org/jira/browse/OFBIZ-4836
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework
Affects Versions: SVN trunk
Reporter: Pierre Smits
Priority: Blocker
 Fix For: SVN trunk

 Attachments: jcr-config.xml


 When having multiple tenants and one of the users (of a tenant) creates 
 (uploads) a file to JCR then this file is visible to all users of all tenants

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4840) Make homedir for JCR configurable


[ 
https://issues.apache.org/jira/browse/OFBIZ-4840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13260596#comment-13260596
 ] 

Sascha Rodekamp commented on OFBIZ-4840:


Nevermind.

The last one is the default value. 
{code}
homeDir = UtilXml.childElementAttribute(configRootElement, home-dir, path, 
runtime/data/jcr/);
{code}

 Make homedir for JCR configurable
 -

 Key: OFBIZ-4840
 URL: https://issues.apache.org/jira/browse/OFBIZ-4840
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework
Affects Versions: SVN trunk
Reporter: Pierre Smits
Priority: Critical
 Fix For: SVN trunk


 Currently the homedir for jcr is set in JCRFactoryImpl.java.
 This should be set through a property in a configuration file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4836) Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz