[jira] [Updated] (OFBIZ-7946) Data load error on Web Pos component due to removal of POS component

2016-08-06 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7946:
-
Attachment: OFBIZ-7946.patch

Attached patch with proper fix.

> Data load error on Web Pos component due to removal of POS component
> 
>
> Key: OFBIZ-7946
> URL: https://issues.apache.org/jira/browse/OFBIZ-7946
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/webpos
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Critical
> Attachments: OFBIZ-7946.patch
>
>
> ProductStoreId=9100 is not available due to removal of POS component from 
> specialPurpose



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7946) Data load error on Web Pos component due to removal of POS component

2016-08-06 Thread Suraj Khurana (JIRA)
Suraj Khurana created OFBIZ-7946:


 Summary: Data load error on Web Pos component due to removal of 
POS component
 Key: OFBIZ-7946
 URL: https://issues.apache.org/jira/browse/OFBIZ-7946
 Project: OFBiz
  Issue Type: Bug
  Components: specialpurpose/webpos
Affects Versions: Trunk
Reporter: Suraj Khurana
Assignee: Suraj Khurana
Priority: Critical


ProductStoreId=9100 is not available due to removal of POS component from 
specialPurpose



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7909) Remove system generated fields - Accounting

2016-07-20 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7909:
-
Attachment: OFBIZ-7909.patch

Attached file with required changes.

> Remove system generated fields - Accounting
> ---
>
> Key: OFBIZ-7909
> URL: https://issues.apache.org/jira/browse/OFBIZ-7909
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-7909.patch
>
>
> Remove all system generated fields from accounting component



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7909) Remove system generated fields - Accounting

2016-07-20 Thread Suraj Khurana (JIRA)
Suraj Khurana created OFBIZ-7909:


 Summary: Remove system generated fields - Accounting
 Key: OFBIZ-7909
 URL: https://issues.apache.org/jira/browse/OFBIZ-7909
 Project: OFBiz
  Issue Type: Sub-task
  Components: accounting
Affects Versions: Trunk
Reporter: Suraj Khurana
Assignee: Suraj Khurana
Priority: Minor


Remove all system generated fields from accounting component




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7908) Remove system generated fields - POS

2016-07-20 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7908:
-
Attachment: OFBIZ-7908.patch

Attached patch with required changes.

> Remove system generated fields - POS
> 
>
> Key: OFBIZ-7908
> URL: https://issues.apache.org/jira/browse/OFBIZ-7908
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: specialpurpose/pos
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-7908.patch
>
>
> Remove all system generated fields from pos component



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7908) Remove system generated fields - POS

2016-07-20 Thread Suraj Khurana (JIRA)
Suraj Khurana created OFBIZ-7908:


 Summary: Remove system generated fields - POS
 Key: OFBIZ-7908
 URL: https://issues.apache.org/jira/browse/OFBIZ-7908
 Project: OFBiz
  Issue Type: Sub-task
  Components: specialpurpose/pos
Affects Versions: Trunk
Reporter: Suraj Khurana
Assignee: Suraj Khurana
Priority: Minor


Remove all system generated fields from pos component




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7905) Remove system generated fields - Scrum

2016-07-19 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7905:
-
Attachment: OFBIZ-7905.patch

Attached patch with required changes.

> Remove system generated fields - Scrum
> --
>
> Key: OFBIZ-7905
> URL: https://issues.apache.org/jira/browse/OFBIZ-7905
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: specialpurpose/scrum
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-7905.patch
>
>
> Remove all system generated fields from scrum component



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7903) Remove system generated fields - Marketing

2016-07-19 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7903:
-
Attachment: OFBIZ-7903.patch

Attached patch with required changes.

> Remove system generated fields - Marketing
> --
>
> Key: OFBIZ-7903
> URL: https://issues.apache.org/jira/browse/OFBIZ-7903
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: marketing
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-7903.patch
>
>
> Remove all system generated fields from marketing component



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7904) Remove system generated fields - Product

2016-07-19 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7904:
-
Attachment: OFBIZ-7904.patch

Attached patch with required changes.

> Remove system generated fields - Product
> 
>
> Key: OFBIZ-7904
> URL: https://issues.apache.org/jira/browse/OFBIZ-7904
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-7904.patch
>
>
> Remove all system generated fields from product component



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7902) Remove system generated fields - Ecommerce

2016-07-19 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7902:
-
Attachment: OFBIZ-7902.patch

Attached patch with required changes.

> Remove system generated fields - Ecommerce
> --
>
> Key: OFBIZ-7902
> URL: https://issues.apache.org/jira/browse/OFBIZ-7902
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: specialpurpose/ecommerce
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-7902.patch
>
>
> Remove all system generated fields from ecommerce component



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7902) Remove system generated fields - Ecommerce

2016-07-19 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7902:
-
Affects Version/s: Trunk

> Remove system generated fields - Ecommerce
> --
>
> Key: OFBIZ-7902
> URL: https://issues.apache.org/jira/browse/OFBIZ-7902
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: specialpurpose/ecommerce
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-7902.patch
>
>
> Remove all system generated fields from ecommerce component



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7902) Remove system generated fields - Ecommerce

2016-07-19 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7902:
-
Component/s: specialpurpose/ecommerce

> Remove system generated fields - Ecommerce
> --
>
> Key: OFBIZ-7902
> URL: https://issues.apache.org/jira/browse/OFBIZ-7902
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: specialpurpose/ecommerce
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-7902.patch
>
>
> Remove all system generated fields from ecommerce component



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7901) Remove system generated fields - Content

2016-07-19 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7901:
-
Attachment: OFBIZ-7901.patch

Attached patch with required changes.

> Remove system generated fields - Content
> 
>
> Key: OFBIZ-7901
> URL: https://issues.apache.org/jira/browse/OFBIZ-7901
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-7901.patch
>
>
> Remove all system generated fields from content component



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7905) Remove system generated fields - Scrum

2016-07-19 Thread Suraj Khurana (JIRA)
Suraj Khurana created OFBIZ-7905:


 Summary: Remove system generated fields - Scrum
 Key: OFBIZ-7905
 URL: https://issues.apache.org/jira/browse/OFBIZ-7905
 Project: OFBiz
  Issue Type: Sub-task
  Components: specialpurpose/scrum
Affects Versions: Trunk
Reporter: Suraj Khurana
Assignee: Suraj Khurana
Priority: Minor


Remove all system generated fields from scrum component



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7904) Remove system generated fields - Product

2016-07-19 Thread Suraj Khurana (JIRA)
Suraj Khurana created OFBIZ-7904:


 Summary: Remove system generated fields - Product
 Key: OFBIZ-7904
 URL: https://issues.apache.org/jira/browse/OFBIZ-7904
 Project: OFBiz
  Issue Type: Sub-task
  Components: product
Affects Versions: Trunk
Reporter: Suraj Khurana
Assignee: Suraj Khurana
Priority: Minor


Remove all system generated fields from product component



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7903) Remove system generated fields - Marketing

2016-07-19 Thread Suraj Khurana (JIRA)
Suraj Khurana created OFBIZ-7903:


 Summary: Remove system generated fields - Marketing
 Key: OFBIZ-7903
 URL: https://issues.apache.org/jira/browse/OFBIZ-7903
 Project: OFBiz
  Issue Type: Sub-task
  Components: marketing
Affects Versions: Trunk
Reporter: Suraj Khurana
Assignee: Suraj Khurana
Priority: Minor


Remove all system generated fields from marketing component



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7902) Remove system generated fields - Ecommerce

2016-07-19 Thread Suraj Khurana (JIRA)
Suraj Khurana created OFBIZ-7902:


 Summary: Remove system generated fields - Ecommerce
 Key: OFBIZ-7902
 URL: https://issues.apache.org/jira/browse/OFBIZ-7902
 Project: OFBiz
  Issue Type: Sub-task
Reporter: Suraj Khurana
Assignee: Suraj Khurana
Priority: Minor


Remove all system generated fields from ecommerce component



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7901) Remove system generated fields - Content

2016-07-19 Thread Suraj Khurana (JIRA)
Suraj Khurana created OFBIZ-7901:


 Summary: Remove system generated fields - Content
 Key: OFBIZ-7901
 URL: https://issues.apache.org/jira/browse/OFBIZ-7901
 Project: OFBiz
  Issue Type: Sub-task
  Components: content
Affects Versions: Trunk
Reporter: Suraj Khurana
Assignee: Suraj Khurana
Priority: Minor


Remove all system generated fields from content component



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7821) Remove unused system generated fields from all data files

2016-07-16 Thread Suraj Khurana (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380678#comment-15380678
 ] 

Suraj Khurana commented on OFBIZ-7821:
--

Thanks [~pfm.smits] for your inputs.
In this ticket, I am just proposing to clean up existing data files as per the 
current practices around these fields.


> Remove unused system generated fields from all data files
> -
>
> Key: OFBIZ-7821
> URL: https://issues.apache.org/jira/browse/OFBIZ-7821
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Priority: Minor
>
> There are four system generated fields for every entity as lastUpdatedStamp, 
> lastUpdatedTxStamp, createdStamp and createdTxStamp
> To increase readability of data files, these fields are not necessary to be 
> there in data files, as it gets generated every time when data load occurs. 
> This ticket will be served as a parent ticket and I will be creating child 
> tickets component wise for all affected components.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7821) Remove unused system generated fields from all data files

2016-07-15 Thread Suraj Khurana (JIRA)
Suraj Khurana created OFBIZ-7821:


 Summary: Remove unused system generated fields from all data files
 Key: OFBIZ-7821
 URL: https://issues.apache.org/jira/browse/OFBIZ-7821
 Project: OFBiz
  Issue Type: Improvement
Affects Versions: Trunk
Reporter: Suraj Khurana
Priority: Minor


There are four system generated fields for every entity as lastUpdatedStamp, 
lastUpdatedTxStamp, createdStamp and createdTxStamp
To increase readability of data files, these fields are not necessary to be 
there in data files, as it gets generated every time when data load occurs. 
This ticket will be served as a parent ticket and I will be creating child 
tickets component wise for all affected components.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7598) Empty header row should not render if list to render in file is empty

2016-07-05 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7598:
-
Attachment: OFBIZ-7598.patch

Added patch with proper fix.
Please review this patch. I have run tests as well and results are positive :) 

> Empty header row should not render if list to render in file is empty
> -
>
> Key: OFBIZ-7598
> URL: https://issues.apache.org/jira/browse/OFBIZ-7598
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
> Attachments: OFBIZ-7598.patch, OFBIZ-7598.png
>
>
> If list inside form doesn't contain data, then header row should not render 
> from better UI perspective and proper message should be shown to user.
> Please refer screenshot for details.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7757) Unable to set thru date

2016-07-05 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7757:
-
Attachment: OFBIZ-7757.patch

Attached patch with proper fix.

> Unable to set thru date  
> -
>
> Key: OFBIZ-7757
> URL: https://issues.apache.org/jira/browse/OFBIZ-7757
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/projectmgr
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
> Attachments: OFBIZ-7757.patch
>
>
> Step to regenerate
> 1. Login into project component.
> 2. Go to the task section.
> 3. Find the task.
> 4. Go to the any of the task from the list.
> 5. Then go to surveys section
> 6. If multiple records are found, then datepicker icon is not visible to set 
> thru date.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7757) Unable to set thru date

2016-07-05 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7757:
-
Priority: Minor  (was: Major)

> Unable to set thru date  
> -
>
> Key: OFBIZ-7757
> URL: https://issues.apache.org/jira/browse/OFBIZ-7757
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/projectmgr
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Minor
>
> Step to regenerate
> 1. Login into project component.
> 2. Go to the task section.
> 3. Find the task.
> 4. Go to the any of the task from the list.
> 5. Then go to surveys section
> 6. If multiple records are found, then datepicker icon is not visible to set 
> thru date.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7757) Unable to set thru date

2016-07-05 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7757:
-
Priority: Major  (was: Minor)

> Unable to set thru date  
> -
>
> Key: OFBIZ-7757
> URL: https://issues.apache.org/jira/browse/OFBIZ-7757
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/projectmgr
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>
> Step to regenerate
> 1. Login into project component.
> 2. Go to the task section.
> 3. Find the task.
> 4. Go to the any of the task from the list.
> 5. Then go to surveys section
> 6. If multiple records are found, then datepicker icon is not visible to set 
> thru date.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7757) Unable to set thru date

2016-07-05 Thread Suraj Khurana (JIRA)
Suraj Khurana created OFBIZ-7757:


 Summary: Unable to set thru date  
 Key: OFBIZ-7757
 URL: https://issues.apache.org/jira/browse/OFBIZ-7757
 Project: OFBiz
  Issue Type: Bug
  Components: specialpurpose/projectmgr
Reporter: Suraj Khurana
Assignee: Suraj Khurana


Step to regenerate
1. Login into project component.
2. Go to the task section.
3. Find the task.
4. Go to the any of the task from the list.
5. Then go to surveys section
6. If multiple records are found, then datepicker icon is not visible to set 
thru date.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7297) Migrate promotext.properties to UiLabels

2016-07-05 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7297:
-
Attachment: OFBIZ-7297-2.patch

Thanks [~mridul.pathak]. Added another patch with required changes, deleted old 
files as well. I will be creating another ticket for such type of old property 
driven UiLabel files.

> Migrate promotext.properties to UiLabels
> 
>
> Key: OFBIZ-7297
> URL: https://issues.apache.org/jira/browse/OFBIZ-7297
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Trunk
>Reporter: Mridul Pathak
>Assignee: Mridul Pathak
>Priority: Minor
> Attachments: OFBIZ-7297-2.patch, OFBIZ-7297.patch
>
>
> promotext.properties file is used only in 
> ProductPromoWorker.makeAutoDescription() method and was implemented way back 
> when UI Labels were managed in *.properties files. It should be moved to 
> UiLabels file because all the properties defined in the file are text 
> descriptions and not system configurations, which makes them a candidate of 
> internationalization.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7594) Unable to delete a survey in project component

2016-07-01 Thread Suraj Khurana (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358852#comment-15358852
 ] 

Suraj Khurana commented on OFBIZ-7594:
--

[~deepak.baghel] I think this is an existing behaviour, records won't get 
deleted only get expired.

Please correct me if I am wrong.
If it makes sense to you as well, this ticket can be discarded as well.

> Unable to delete a survey in project component
> --
>
> Key: OFBIZ-7594
> URL: https://issues.apache.org/jira/browse/OFBIZ-7594
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/projectmgr
>Affects Versions: Trunk
>Reporter: Deepak Baghel
>Assignee: Deepak Baghel
>
> Step to regenerate 
> 1. Login into project component.
> 2. Go to the task section.
> 3. Find the task.
> 4. Go to the any of the task from the list.
> 5. Then go to surveys section
> 6. Try to delete the survey, if any exist.
> 7. Surveys are unable to delete.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7597) Entity auto services doesn't returns success message

2016-06-29 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7597:
-
Attachment: OFBIZ-7597.patch

Please find the attached patch with proper fix.

> Entity auto services doesn't returns success message
> 
>
> Key: OFBIZ-7597
> URL: https://issues.apache.org/jira/browse/OFBIZ-7597
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
> Attachments: OFBIZ-7597.patch
>
>
> All the services which uses entity-auto engine should return proper success 
> messages according to action.
> With reference to EntityAutoEngine.java, proposed messages according to 
> action:
> For Create:  created successfully
> For Update:  updated successfully
> For Delete:  deleted successfully
> For Expire:  expired successfully



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7673) Create demo PartyStatus data for existing parties for applications component

2016-06-29 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7673:
-
Attachment: OFBIZ-7673.patch

> Create demo PartyStatus data for existing parties for applications component
> 
>
> Key: OFBIZ-7673
> URL: https://issues.apache.org/jira/browse/OFBIZ-7673
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
> Attachments: OFBIZ-7673.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7672) Create demo PartyStatus data for existing parties for special purpose component

2016-06-29 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7672:
-
Attachment: OFBIZ-7672.patch

> Create demo PartyStatus data for existing parties for special purpose 
> component
> ---
>
> Key: OFBIZ-7672
> URL: https://issues.apache.org/jira/browse/OFBIZ-7672
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: specialpurpose/ebaystore, specialpurpose/ecommerce, 
> specialpurpose/projectmgr, specialpurpose/scrum
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
> Attachments: OFBIZ-7672.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7672) Create demo PartyStatus data for existing parties for special purpose component

2016-06-29 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7672:
-
Component/s: (was: specialpurpose/webpos)

> Create demo PartyStatus data for existing parties for special purpose 
> component
> ---
>
> Key: OFBIZ-7672
> URL: https://issues.apache.org/jira/browse/OFBIZ-7672
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: specialpurpose/ebaystore, specialpurpose/ecommerce, 
> specialpurpose/projectmgr, specialpurpose/scrum
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
> Attachments: OFBIZ-7672.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7603) There should be a demo data set for the PartyStatus entity

2016-06-28 Thread Suraj Khurana (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15354547#comment-15354547
 ] 

Suraj Khurana commented on OFBIZ-7603:
--

I have checked and there are approx 150 parties in the system currently, 
created two child task for this ticket so that it will be easy from 
verification perspective. 

> There should be a demo data set for the PartyStatus entity
> --
>
> Key: OFBIZ-7603
> URL: https://issues.apache.org/jira/browse/OFBIZ-7603
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Trunk
>Reporter: Pierre Smits
>
> Currently there is no demo data for the PartyStatus entity. This complicates 
> tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7673) Create demo PartyStatus data for existing parties for applications component

2016-06-28 Thread Suraj Khurana (JIRA)
Suraj Khurana created OFBIZ-7673:


 Summary: Create demo PartyStatus data for existing parties for 
applications component
 Key: OFBIZ-7673
 URL: https://issues.apache.org/jira/browse/OFBIZ-7673
 Project: OFBiz
  Issue Type: Sub-task
  Components: ALL APPLICATIONS
Reporter: Suraj Khurana
Assignee: Suraj Khurana






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7672) Create demo PartyStatus data for existing parties for special purpose component

2016-06-28 Thread Suraj Khurana (JIRA)
Suraj Khurana created OFBIZ-7672:


 Summary: Create demo PartyStatus data for existing parties for 
special purpose component
 Key: OFBIZ-7672
 URL: https://issues.apache.org/jira/browse/OFBIZ-7672
 Project: OFBiz
  Issue Type: Sub-task
  Components: specialpurpose/ebaystore, specialpurpose/ecommerce, 
specialpurpose/projectmgr, specialpurpose/scrum, specialpurpose/webpos
Reporter: Suraj Khurana
Assignee: Suraj Khurana






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7598) Empty header row should not render if list to render in file is empty

2016-06-24 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7598:
-
Attachment: OFBIZ-7598.png

> Empty header row should not render if list to render in file is empty
> -
>
> Key: OFBIZ-7598
> URL: https://issues.apache.org/jira/browse/OFBIZ-7598
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
> Attachments: OFBIZ-7598.png
>
>
> If list inside form doesn't contain data, then header row should not render 
> from better UI perspective and proper message should be shown to user.
> Please refer screenshot for details.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7598) Empty header row should not render if list to render in file is empty

2016-06-24 Thread Suraj Khurana (JIRA)
Suraj Khurana created OFBIZ-7598:


 Summary: Empty header row should not render if list to render in 
file is empty
 Key: OFBIZ-7598
 URL: https://issues.apache.org/jira/browse/OFBIZ-7598
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Reporter: Suraj Khurana
Assignee: Suraj Khurana


If list inside form doesn't contain data, then header row should not render 
from better UI perspective and proper message should be shown to user.
Please refer screenshot for details.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7597) Entity auto services doesn't returns success message

2016-06-24 Thread Suraj Khurana (JIRA)
Suraj Khurana created OFBIZ-7597:


 Summary: Entity auto services doesn't returns success message
 Key: OFBIZ-7597
 URL: https://issues.apache.org/jira/browse/OFBIZ-7597
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Reporter: Suraj Khurana
Assignee: Suraj Khurana


All the services which uses entity-auto engine should return proper success 
messages according to action.

With reference to EntityAutoEngine.java, proposed messages according to action:
For Create:  created successfully
For Update:  updated successfully
For Delete:  deleted successfully
For Expire:  expired successfully




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7563) Error message not visible properly after adding item in webpos

2016-06-24 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7563:
-
Attachment: OFBIZ-7563

Attached patch with proper fix. Increased section top-margin so that it won't 
overlap in above section.

> Error message not visible properly after adding item in webpos
> --
>
> Key: OFBIZ-7563
> URL: https://issues.apache.org/jira/browse/OFBIZ-7563
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/webpos
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-7563, OFBIZ-7563.png
>
>
> Steps to generate:
> - Go to Web Pos:
> - Click on search button on product search.
> - Click on product CPU 586 to add it to cart.
> - As no valid product price is not associated with product, then it should 
> not be added to cart, and show proper error message.
> - Error message is not properly visible to user due to overlapped div. 
> (Please refer screenshot)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7563) Error message not visible properly after adding item in webpos

2016-06-23 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7563:
-
Attachment: OFBIZ-7563.png

> Error message not visible properly after adding item in webpos
> --
>
> Key: OFBIZ-7563
> URL: https://issues.apache.org/jira/browse/OFBIZ-7563
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/webpos
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-7563.png
>
>
> Steps to generate:
> - Go to Web Pos:
> - Click on search button on product search.
> - Click on product CPU 586 to add it to cart.
> - As no valid product price is not associated with product, then it should 
> not be added to cart, and show proper error message.
> - Error message is not properly visible to user due to overlapped div. 
> (Please refer screenshot)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7563) Error message not visible properly after adding item in webpos

2016-06-23 Thread Suraj Khurana (JIRA)
Suraj Khurana created OFBIZ-7563:


 Summary: Error message not visible properly after adding item in 
webpos
 Key: OFBIZ-7563
 URL: https://issues.apache.org/jira/browse/OFBIZ-7563
 Project: OFBiz
  Issue Type: Bug
  Components: specialpurpose/webpos
Reporter: Suraj Khurana
Assignee: Suraj Khurana
Priority: Minor


Steps to generate:

- Go to Web Pos:
- Click on search button on product search.
- Click on product CPU 586 to add it to cart.
- As no valid product price is not associated with product, then it should not 
be added to cart, and show proper error message.
- Error message is not properly visible to user due to overlapped div. (Please 
refer screenshot)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7482) Deposit price support

2016-06-18 Thread Suraj Khurana (JIRA)
Suraj Khurana created OFBIZ-7482:


 Summary: Deposit price support 
 Key: OFBIZ-7482
 URL: https://issues.apache.org/jira/browse/OFBIZ-7482
 Project: OFBiz
  Issue Type: New Feature
  Components: product
Reporter: Suraj Khurana
Assignee: Suraj Khurana


Business requirements: 
In many business industry this is very common pattern that you need to pay some 
amount as deposit for particular products. Such as when you purchase wine or 
other bottle products, you need to pay some amount as deposit and whenever you 
return back that bottle, that deposited amount will be refunded to you.
Technical Details:
Create a new ProductPricePurpose as 'DEPOSIT' and for similar products we will 
create product price record with productPriceTypeId as 'DEFAULT_PRICE' and 
productPricePurposeId as 'DEPOSIT'. At the time of Order creation simply create 
order adjustments for such products.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7481) ProductFacility record must exist before creating inventoryItem for a facility

2016-06-18 Thread Suraj Khurana (JIRA)
Suraj Khurana created OFBIZ-7481:


 Summary: ProductFacility record must exist before creating 
inventoryItem for a facility
 Key: OFBIZ-7481
 URL: https://issues.apache.org/jira/browse/OFBIZ-7481
 Project: OFBiz
  Issue Type: Bug
  Components: product
Affects Versions: 14.12.01, Upcoming Branch, 15.12.01, 13.07.04
Reporter: Suraj Khurana
Assignee: Suraj Khurana


ProductFacility entity is used to decide that  a particular  product is 
maintained in which facility. So, in case of receiving a product in a facility 
or in case creating InventoryItem for a facility, the ProductFacility record 
must exist. But in these cases, currently in OFBiz inventoryItem gets created 
even if ProductFacility record doesn't exist.

Proposed solution:

1) In receiveInventoryProduct service check and create ProductFacility record 
if not exist.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7452) Proper validation must be there while creating product attributes

2016-06-18 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7452:
-
Summary: Proper validation must be there while creating product attributes  
(was: Proper validation must be there while creating product associations)

> Proper validation must be there while creating product attributes
> -
>
> Key: OFBIZ-7452
> URL: https://issues.apache.org/jira/browse/OFBIZ-7452
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-7452.patch
>
>
> Go to Catalog -> product
> Select any product and then switch to attributes tab
> Find Add Product Attribute form, proper validations must be there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-7452) Proper validation must be there while creating product associations

2016-06-18 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-7452:


Assignee: Suraj Khurana

> Proper validation must be there while creating product associations
> ---
>
> Key: OFBIZ-7452
> URL: https://issues.apache.org/jira/browse/OFBIZ-7452
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-7452.patch
>
>
> Go to Catalog -> product
> Select any product and then switch to attributes tab
> Find Add Product Attribute form, proper validations must be there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7452) Proper validation must be there while creating product associations

2016-06-18 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7452:
-
Attachment: OFBIZ-7452.patch

Added patch with proper fix

> Proper validation must be there while creating product associations
> ---
>
> Key: OFBIZ-7452
> URL: https://issues.apache.org/jira/browse/OFBIZ-7452
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-7452.patch
>
>
> Go to Catalog -> product
> Select any product and then switch to attributes tab
> Find Add Product Attribute form, proper validations must be there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7452) Proper validation must be there while creating product associations

2016-06-18 Thread Suraj Khurana (JIRA)
Suraj Khurana created OFBIZ-7452:


 Summary: Proper validation must be there while creating product 
associations
 Key: OFBIZ-7452
 URL: https://issues.apache.org/jira/browse/OFBIZ-7452
 Project: OFBiz
  Issue Type: Improvement
Reporter: Suraj Khurana
Priority: Minor


Go to Catalog -> product
Select any product and then switch to attributes tab
Find Add Product Attribute form, proper validations must be there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7297) Migrate promotext.properties to UiLabels

2016-06-18 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7297:
-
Attachment: OFBIZ-7297.patch

Added patch with proper fix.

> Migrate promotext.properties to UiLabels
> 
>
> Key: OFBIZ-7297
> URL: https://issues.apache.org/jira/browse/OFBIZ-7297
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Trunk
>Reporter: Mridul Pathak
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-7297.patch
>
>
> promotext.properties file is used only in 
> ProductPromoWorker.makeAutoDescription() method and was implemented way back 
> when UI Labels were managed in *.properties files. It should be moved to 
> UiLabels file because all the properties defined in the file are text 
> descriptions and not system configurations, which makes them a candidate of 
> internationalization.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7434) Client side validation on AddProductCostComponentCalc form on catalog

2016-06-18 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7434:
-
Attachment: OFBIZ-7434

Attached patch with proper fix.

> Client side validation on AddProductCostComponentCalc form on catalog
> -
>
> Key: OFBIZ-7434
> URL: https://issues.apache.org/jira/browse/OFBIZ-7434
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-7434
>
>
> Go to Catalog -> product
> Select any product and then move to costs tab
> You will see a Add Product Cost Component Calc form in which client side 
> validation is not properly handled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7434) Client side validation on AddProductCostComponentCalc form on catalog

2016-06-18 Thread Suraj Khurana (JIRA)
Suraj Khurana created OFBIZ-7434:


 Summary: Client side validation on AddProductCostComponentCalc 
form on catalog
 Key: OFBIZ-7434
 URL: https://issues.apache.org/jira/browse/OFBIZ-7434
 Project: OFBiz
  Issue Type: Improvement
  Components: product
Affects Versions: Trunk
Reporter: Suraj Khurana
Assignee: Suraj Khurana
Priority: Minor


Go to Catalog -> product
Select any product and then move to costs tab
You will see a Add Product Cost Component Calc form in which client side 
validation is not properly handled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7425) Client side validation on Add product categories form in catalog

2016-06-18 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7425:
-
Attachment: OFBIZ-7425.patch

Added patch with proper fix.

> Client side validation on Add product categories form in catalog
> 
>
> Key: OFBIZ-7425
> URL: https://issues.apache.org/jira/browse/OFBIZ-7425
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-7425.patch
>
>
> Go to catalog -> product -> categories
> You will see add product category form in which categoryId and fromDate in 
> mandatory fields for service. So there should be client side validation as 
> well for them. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7425) Client side validation on Add product categories form in catalog

2016-06-18 Thread Suraj Khurana (JIRA)
Suraj Khurana created OFBIZ-7425:


 Summary: Client side validation on Add product categories form in 
catalog
 Key: OFBIZ-7425
 URL: https://issues.apache.org/jira/browse/OFBIZ-7425
 Project: OFBiz
  Issue Type: Improvement
  Components: product
Reporter: Suraj Khurana
Assignee: Suraj Khurana
Priority: Minor


Go to catalog -> product -> categories
You will see add product category form in which categoryId and fromDate in 
mandatory fields for service. So there should be client side validation as well 
for them. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-7418) Minor Allignment issue at Reviews page

2016-06-18 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-7418:


Assignee: Suraj Khurana

> Minor Allignment issue at Reviews page
> --
>
> Key: OFBIZ-7418
> URL: https://issues.apache.org/jira/browse/OFBIZ-7418
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Sanjay Yadav
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: TextAllignmentIssue.png
>
>
> Go to:
> Application -> Catalog Manager -> Reviews
> Actual - Text field is not properly aligned. Also check update button 
> alignment. Please refer attachment.
> Expected - Fix this alignment issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-7220) Need to correct generated error message

2016-06-17 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-7220:


Assignee: Suraj Khurana

> Need to correct generated error message 
> 
>
> Key: OFBIZ-7220
> URL: https://issues.apache.org/jira/browse/OFBIZ-7220
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Reporter: Padmavati Rawat
>Assignee: Suraj Khurana
> Attachments: Incorrect error message.png
>
>
> Actual : When I tried to Quick-ship for an order for back-ordered product. It 
> generated some error exceptions which describe technical things as shown in 
> screen shot.
> Expected : Message should be user friendly, can be corrected.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7307) Proper client side validation while creating price rule from catalog manager

2016-06-10 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7307:
-
Attachment: OFBIZ-7307.patch

Provided patch with proper fix for trunk.

> Proper client side validation while creating price rule from catalog manager
> 
>
> Key: OFBIZ-7307
> URL: https://issues.apache.org/jira/browse/OFBIZ-7307
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-7307.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7307) Proper client side validation while creating price rule from catalog manager

2016-06-10 Thread Suraj Khurana (JIRA)
Suraj Khurana created OFBIZ-7307:


 Summary: Proper client side validation while creating price rule 
from catalog manager
 Key: OFBIZ-7307
 URL: https://issues.apache.org/jira/browse/OFBIZ-7307
 Project: OFBiz
  Issue Type: Improvement
  Components: product
Reporter: Suraj Khurana
Assignee: Suraj Khurana
Priority: Minor






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-7297) Migrate promotext.properties to UiLabels

2016-06-10 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-7297:


Assignee: Suraj Khurana

> Migrate promotext.properties to UiLabels
> 
>
> Key: OFBIZ-7297
> URL: https://issues.apache.org/jira/browse/OFBIZ-7297
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Trunk
>Reporter: Mridul Pathak
>Assignee: Suraj Khurana
>Priority: Minor
>
> promotext.properties file is used only in 
> ProductPromoWorker.makeAutoDescription() method and was implemented way back 
> when UI Labels were managed in *.properties files. It should be moved to 
> UiLabels file because all the properties defined in the file are text 
> descriptions and not system configurations, which makes them a candidate of 
> internationalization.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7037) Have QRCodeServices.java use EntityUtilProperties

2016-05-21 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7037:
-
Attachment: OFBIZ-7037.patch

Done with some code improvements along with using EntityUtilProperties instead 
of UtilProperties. Removed unused data variables and used them directly inside 
the service (as they were not used anywhere else and also part of service IN 
parameters so making no sense to declare them as static variables.) 
Please find attached patch for the same.
All run-tests passed.

> Have QRCodeServices.java use EntityUtilProperties
> -
>
> Key: OFBIZ-7037
> URL: https://issues.apache.org/jira/browse/OFBIZ-7037
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Mridul Pathak
> Attachments: OFBIZ-7037.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7098) Remove restriction of setting PARTY_ENABLED as first default status of party

2016-05-21 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7098:
-
Description: I was creating a new Party through custom service and tried to 
set its initial status as "PARTY_DISABLED" using setPartyStatus service but it 
defaults set as PARTY_ENABLED. In setPartyStatus service of PartyServices.java, 
if oldStatusId is not found then  party status is set to "PARTY_ENABLED" (which 
is not necessary for all scenarios), a user can also set "PARTY_DISABLED" as 
first default party status.  (was: In setPartyStatus service of 
PartyServices.java, if oldStatusId is not found then  party status is set to 
"PARTY_ENABLED" (which is not necessary for all scenarios), a user can also set 
"PARTY_DISABLED" as first default party status.)

> Remove restriction of setting PARTY_ENABLED as first default status of party
> 
>
> Key: OFBIZ-7098
> URL: https://issues.apache.org/jira/browse/OFBIZ-7098
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Suraj Khurana
>Assignee: Mridul Pathak
> Attachments: OFBIZ-7098.patch
>
>
> I was creating a new Party through custom service and tried to set its 
> initial status as "PARTY_DISABLED" using setPartyStatus service but it 
> defaults set as PARTY_ENABLED. In setPartyStatus service of 
> PartyServices.java, if oldStatusId is not found then  party status is set to 
> "PARTY_ENABLED" (which is not necessary for all scenarios), a user can also 
> set "PARTY_DISABLED" as first default party status.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7098) Remove restriction of setting PARTY_ENABLED as first default status of party

2016-05-21 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7098:
-
Issue Type: Bug  (was: Improvement)

> Remove restriction of setting PARTY_ENABLED as first default status of party
> 
>
> Key: OFBIZ-7098
> URL: https://issues.apache.org/jira/browse/OFBIZ-7098
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Suraj Khurana
>Assignee: Mridul Pathak
> Attachments: OFBIZ-7098.patch
>
>
> In setPartyStatus service of PartyServices.java, if oldStatusId is not found 
> then  party status is set to "PARTY_ENABLED" (which is not necessary for all 
> scenarios), a user can also set "PARTY_DISABLED" as first default party 
> status.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7098) Remove restriction of setting PARTY_ENABLED as first default status of party

2016-05-21 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7098:
-
Attachment: OFBIZ-7098.patch

Attached patch with proper fix. 

> Remove restriction of setting PARTY_ENABLED as first default status of party
> 
>
> Key: OFBIZ-7098
> URL: https://issues.apache.org/jira/browse/OFBIZ-7098
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Release Branch 14.12, Upcoming Branch, Release Branch 
> 15.12
>Reporter: Suraj Khurana
> Attachments: OFBIZ-7098.patch
>
>
> In setPartyStatus service of PartyServices.java, if oldStatusId is not found 
> then  party status is set to "PARTY_ENABLED" (which is not necessary for all 
> scenarios), a user can also set "PARTY_DISABLED" as first default party 
> status.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7098) Remove restriction of setting PARTY_ENABLED as first default status of party

2016-05-21 Thread Suraj Khurana (JIRA)
Suraj Khurana created OFBIZ-7098:


 Summary: Remove restriction of setting PARTY_ENABLED as first 
default status of party
 Key: OFBIZ-7098
 URL: https://issues.apache.org/jira/browse/OFBIZ-7098
 Project: OFBiz
  Issue Type: Improvement
  Components: party
Affects Versions: Release Branch 15.12, Release Branch 14.12, Upcoming 
Branch
Reporter: Suraj Khurana


In setPartyStatus service of PartyServices.java, if oldStatusId is not found 
then  party status is set to "PARTY_ENABLED" (which is not necessary for all 
scenarios), a user can also set "PARTY_DISABLED" as first default party status.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7035) Have https://localhost:8443/example/control/fonts.pdf open in a new window

2016-05-21 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7035:
-
Attachment: OFBIZ-7035.patch

Attached patch as per the requirements.

> Have  https://localhost:8443/example/control/fonts.pdf open in a new window
> ---
>
> Key: OFBIZ-7035
> URL: https://issues.apache.org/jira/browse/OFBIZ-7035
> Project: OFBiz
>  Issue Type: Improvement
>  Components: specialpurpose/example
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Mridul Pathak
> Attachments: OFBIZ-7035.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6781) Incorrect order adjustment after order item is cancelled

2016-04-16 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-6781:
-
Attachment: OFBIZ-6781-trunk.patch

Attaching patch with proper fix.
Here two changes are done inside recreateOrderAdjustments service.
-While calculating newOrderAdjustmentTotal we should only consider cart 
adjustments with No orderAdjustmentId, so adding condition for the same.
-While calculating existingOrderAdjustmentTotal, adding check for 
orderAdjustmentTypeId instead of productPromoId, so that Promotion adjustments 
due to order change will also be included in the same.

> Incorrect order adjustment after order item is cancelled
> 
>
> Key: OFBIZ-6781
> URL: https://issues.apache.org/jira/browse/OFBIZ-6781
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Vyom Jain
> Attachments: OFBIZ-6781-trunk.patch
>
>
> Steps to replicate (tested on trunk at r1721093) - 
> 1. Make sure promotion 
> https://localhost:8443/catalog/control/EditProductPromo?productPromoId=9011 
> is enabled.
> 2. Create a sales order after adding to cart 1 x GZ-1001 @ $25.99 & 1 x 
> GZ-1000 @ $15.99
> 3. order view screen shows Total Other Order Adjustments as -$4.2, which is 
> correct.
> 4. Cancel 1 x GZ-1001 @ $25.99
> 5. Reload order view screen.
> Observed - 
> 1. order view screen shows Total Other Order Adjustments as -($4.20 + $1.6) = 
> -$5.8
> Expected - 
> 1. order view screen should show Total Other Order Adjustments as -$1.6



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6042) Allow inventory transfers based on Product instead of only InventoryItem

2016-03-19 Thread Suraj Khurana (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202777#comment-15202777
 ] 

Suraj Khurana commented on OFBIZ-6042:
--

These locationTypeEnumIds are used as 'transfer from' location of product not 
as 'transfer to' location of product and there are only these three type of 
possible locationTypeEnumIds, so patch is allowing to transfer inventory from 
all types inventory item location.

> Allow inventory transfers based on Product instead of only InventoryItem
> 
>
> Key: OFBIZ-6042
> URL: https://issues.apache.org/jira/browse/OFBIZ-6042
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Trunk
>Reporter: Christian Carlow
>Priority: Minor
> Attachments: OFBIZ-6042.patch, OFBIZ-6042.patch
>
>
> Stock moves takes productId as a parameter and finds all inventoryItems of 
> that product until the move quantity is met.  InventoryTransfers should 
> support simliar auto-finding of inventoryItems so that 100 inventoryItems 
> with quantityOnHand = 1 don't have to be individually manually transferred to 
> meet the overall move of 100 for the product.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6042) Allow inventory transfers based on Product instead of only InventoryItem

2016-03-19 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-6042:
-
Attachment: OFBIZ-6042.patch

I have verified the patch and tested the functionality, changes looks good to 
me. Just need to remove inventory item lookup as it was not working because it 
is not designed for generic purpose. So removing the inventory item lookup and 
uploading the updated patch for the same.

> Allow inventory transfers based on Product instead of only InventoryItem
> 
>
> Key: OFBIZ-6042
> URL: https://issues.apache.org/jira/browse/OFBIZ-6042
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Trunk
>Reporter: Christian Carlow
>Priority: Minor
> Attachments: OFBIZ-6042.patch, OFBIZ-6042.patch
>
>
> Stock moves takes productId as a parameter and finds all inventoryItems of 
> that product until the move quantity is met.  InventoryTransfers should 
> support simliar auto-finding of inventoryItems so that 100 inventoryItems 
> with quantityOnHand = 1 don't have to be individually manually transferred to 
> meet the overall move of 100 for the product.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6901) Payment application should only be selected for the appropriate party

2016-02-20 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-6901:
-
Attachment: OFBIZ-6901.patch

Thanks Pierre for clarification,
Uploaded the patch with proper fix as suggested.

> Payment application should only be selected for the appropriate party
> -
>
> Key: OFBIZ-6901
> URL: https://issues.apache.org/jira/browse/OFBIZ-6901
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>  Labels: payment, payment-application
> Attachments: OFBIZ-6901.patch
>
>
> In the payment application form of control/editPaymentApplications? the user 
> can select various invoices for the payment to be applied to. This selection 
> method allows all invoices to be selected (and the lookup shows all).
> However, this function should only show the invoices of the appropriate 
> party, e.g.
> * sales invoices for the customer selected,
> * purchase invoice for the supplier selected,
> * commission invoice for the agent selected
> * etc.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-4850) When Use Add Tax button on invoice summary, duplicate existed tax line

2016-02-20 Thread Suraj Khurana (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155503#comment-15155503
 ] 

Suraj Khurana commented on OFBIZ-4850:
--

Hi [~soledad],

Thanks for providing the patch,
I checked the functionality and verified the patch.
Changes looks good to me and can be merged.

> When Use Add Tax button  on invoice summary, duplicate existed tax line
> ---
>
> Key: OFBIZ-4850
> URL: https://issues.apache.org/jira/browse/OFBIZ-4850
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-4850.patch
>
>
> When you click on "add tax" button on invoice summary, the service create a 
> invoice item list and generate sale tax by list iterate.
> Two problem :
>  1. When you have 3 lignes with one without productId, the service may skip 
> to set tax on valid invoice item
>  2. If sale tax is present, the service duplicate it and generate a tax on 
> the tax (since a productId is on the line).
> I propose a patch to :
>  1. remove all exiting tax associate to a product before analyze
>  2. take only invoice item with a productId



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6901) Payment application should only be selected for the appropriate party

2016-02-19 Thread Suraj Khurana (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155408#comment-15155408
 ] 

Suraj Khurana commented on OFBIZ-6901:
--

Hi Pierre,

In the screen editPaymentApplications, if no appropriate payment applications 
applied for the payment, system automatically shows "Possible invoice to apply" 
section which helps user to select invoices with remaining payment amount of 
selected party.
Also the section 'Add this Payment to' is there if user wants to add any other 
invoice, this is expected system behaviour. It helps user to add payments and 
invoices of other parties as well to particular Payment Application.
Can you please elaborate what should be exact scenario how system should behave.
Thanks in advance.

> Payment application should only be selected for the appropriate party
> -
>
> Key: OFBIZ-6901
> URL: https://issues.apache.org/jira/browse/OFBIZ-6901
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>  Labels: payment, payment-application
>
> In the payment application form of control/editPaymentApplications? the user 
> can select various invoices for the payment to be applied to. This selection 
> method allows all invoices to be selected (and the lookup shows all).
> However, this function should only show the invoices of the appropriate 
> party, e.g.
> * sales invoices for the customer selected,
> * purchase invoice for the supplier selected,
> * commission invoice for the agent selected
> * etc.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6588) buildSurveyResponseFromPdf generates an NPE

2016-01-16 Thread Suraj Khurana (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15103115#comment-15103115
 ] 

Suraj Khurana commented on OFBIZ-6588:
--

This ticket is duplicate to OFBIZ-6587.
Can we please close this one.

> buildSurveyResponseFromPdf generates an NPE
> ---
>
> Key: OFBIZ-6588
> URL: https://issues.apache.org/jira/browse/OFBIZ-6588
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Trunk
>Reporter: Pierre Smits
>  Labels: survey
>
> {code}
>  [java] 2015-08-28 21:29:43,574 |ttp-bio-8443-exec-42 |ControlServlet 
>|T| [[[buildSurveyResponseFromPdf(Domain:https://localhost)] 
> Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
>  [java] 2015-08-28 21:29:43,580 |ttp-bio-8443-exec-42 |PdfSurveyServices  
>|E| Error generating PDF: java.lang.NullPointerException
>  [java] java.lang.NullPointerException
>  [java]   at 
> org.ofbiz.content.survey.PdfSurveyServices.buildSurveyResponseFromPdf(PdfSurveyServices.java:263)
>  [ofbiz-content.jar:?]
>  [java]   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> ~[?:1.8.0_45]
>  [java]   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
> ~[?:1.8.0_45]
>  [java]   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_45]
>  [java]   at java.lang.reflect.Method.invoke(Method.java:497) 
> ~[?:1.8.0_45]
>  [java]   at 
> org.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:100)
>  [ofbiz-service.jar:?]
>  [java]   at 
> org.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:57)
>  [ofbiz-service.jar:?]
>  [java]   at 
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:395) 
> [ofbiz-service.jar:?]
>  [java]   at 
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:227) 
> [ofbiz-service.jar:?]
>  [java]   at 
> org.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
>  [ofbiz-service.jar:?]
>  [java]   at 
> org.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java:340)
>  [ofbiz-webapp.jar:?]
>  [java]   at 
> org.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:759) 
> [ofbiz-webapp.jar:?]
>  [java]   at 
> org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:476) 
> [ofbiz-webapp.jar:?]
>  [java]   at 
> org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:213) 
> [ofbiz-webapp.jar:?]
>  [java]   at 
> org.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:88) 
> [ofbiz-webapp.jar:?]
>  [java]   at javax.servlet.http.HttpServlet.service(HttpServlet.java:646) 
> [servlet-api-3.0.jar:?]
>  [java]   at javax.servlet.http.HttpServlet.service(HttpServlet.java:727) 
> [servlet-api-3.0.jar:?]
>  [java]   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:303)
>  [tomcat-7.0.59-catalina.jar:7.0.59]
>  [java]   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
>  [tomcat-7.0.59-catalina.jar:7.0.59]
>  [java]   at 
> org.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:324) 
> [ofbiz-webapp.jar:?]
>  [java]   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
>  [tomcat-7.0.59-catalina.jar:7.0.59]
>  [java]   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
>  [tomcat-7.0.59-catalina.jar:7.0.59]
>  [java]   at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:220)
>  [tomcat-7.0.59-catalina.jar:7.0.59]
>  [java]   at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:122)
>  [tomcat-7.0.59-catalina.jar:7.0.59]
>  [java]   at 
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:504)
>  [tomcat-7.0.59-catalina.jar:7.0.59]
>  [java]   at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:170) 
> [tomcat-7.0.59-catalina.jar:7.0.59]
>  [java]   at 
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:103) 
> [tomcat-7.0.59-catalina.jar:7.0.59]
>  [java]   at 
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:116)
>  [tomcat-7.0.59-catalina.jar:7.0.59]
>  [java]   at 
> org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:950) 
> [tomcat-7.0.59-catalina.jar:7.0.59]
>  [java]   at 
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:421) 
> 

[jira] [Updated] (OFBIZ-6588) buildSurveyResponseFromPdf generates an NPE

2016-01-16 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-6588:
-
Attachment: OFBIZ-6588.patch

There was some confusion in my previous comment. Pardon me for the same.

Initial fix for this is available in the patch in which proper error message is 
displayed if user doesn't provide 'PDF file name in' or PDF 'contentId'.
Please have a look, adding patch for the same.

> buildSurveyResponseFromPdf generates an NPE
> ---
>
> Key: OFBIZ-6588
> URL: https://issues.apache.org/jira/browse/OFBIZ-6588
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Trunk
>Reporter: Pierre Smits
>  Labels: survey
> Attachments: OFBIZ-6588.patch
>
>
> {code}
>  [java] 2015-08-28 21:29:43,574 |ttp-bio-8443-exec-42 |ControlServlet 
>|T| [[[buildSurveyResponseFromPdf(Domain:https://localhost)] 
> Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
>  [java] 2015-08-28 21:29:43,580 |ttp-bio-8443-exec-42 |PdfSurveyServices  
>|E| Error generating PDF: java.lang.NullPointerException
>  [java] java.lang.NullPointerException
>  [java]   at 
> org.ofbiz.content.survey.PdfSurveyServices.buildSurveyResponseFromPdf(PdfSurveyServices.java:263)
>  [ofbiz-content.jar:?]
>  [java]   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> ~[?:1.8.0_45]
>  [java]   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
> ~[?:1.8.0_45]
>  [java]   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_45]
>  [java]   at java.lang.reflect.Method.invoke(Method.java:497) 
> ~[?:1.8.0_45]
>  [java]   at 
> org.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:100)
>  [ofbiz-service.jar:?]
>  [java]   at 
> org.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:57)
>  [ofbiz-service.jar:?]
>  [java]   at 
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:395) 
> [ofbiz-service.jar:?]
>  [java]   at 
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:227) 
> [ofbiz-service.jar:?]
>  [java]   at 
> org.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
>  [ofbiz-service.jar:?]
>  [java]   at 
> org.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java:340)
>  [ofbiz-webapp.jar:?]
>  [java]   at 
> org.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:759) 
> [ofbiz-webapp.jar:?]
>  [java]   at 
> org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:476) 
> [ofbiz-webapp.jar:?]
>  [java]   at 
> org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:213) 
> [ofbiz-webapp.jar:?]
>  [java]   at 
> org.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:88) 
> [ofbiz-webapp.jar:?]
>  [java]   at javax.servlet.http.HttpServlet.service(HttpServlet.java:646) 
> [servlet-api-3.0.jar:?]
>  [java]   at javax.servlet.http.HttpServlet.service(HttpServlet.java:727) 
> [servlet-api-3.0.jar:?]
>  [java]   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:303)
>  [tomcat-7.0.59-catalina.jar:7.0.59]
>  [java]   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
>  [tomcat-7.0.59-catalina.jar:7.0.59]
>  [java]   at 
> org.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:324) 
> [ofbiz-webapp.jar:?]
>  [java]   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
>  [tomcat-7.0.59-catalina.jar:7.0.59]
>  [java]   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
>  [tomcat-7.0.59-catalina.jar:7.0.59]
>  [java]   at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:220)
>  [tomcat-7.0.59-catalina.jar:7.0.59]
>  [java]   at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:122)
>  [tomcat-7.0.59-catalina.jar:7.0.59]
>  [java]   at 
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:504)
>  [tomcat-7.0.59-catalina.jar:7.0.59]
>  [java]   at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:170) 
> [tomcat-7.0.59-catalina.jar:7.0.59]
>  [java]   at 
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:103) 
> [tomcat-7.0.59-catalina.jar:7.0.59]
>  [java]   at 
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:116)
>  [tomcat-7.0.59-catalina.jar:7.0.59]
>  

[jira] [Commented] (OFBIZ-6578) POS not calculating Tax While doing return

2016-01-16 Thread Suraj Khurana (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15103079#comment-15103079
 ] 

Suraj Khurana commented on OFBIZ-6578:
--

Hi Mandeep,

This is not an issue. Everything is working fine as expected.
Steps followed for verification:
1) Login to POS terminal.
2) Create an order with some Items, verified that tax is applied properly in 
this order.
3) Now click on config menu and then void a sale option.
4) Enter orderId for which return should be created.
5) Success message shows on screen.
6) Goto find return screen and navigate to return detail page.
7) Return items are showing sales tax information as well.

Please let me know if it looks good to you, so that this ticket can be closed.

> POS not calculating Tax While doing return
> --
>
> Key: OFBIZ-6578
> URL: https://issues.apache.org/jira/browse/OFBIZ-6578
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/pos
>Affects Versions: Release Branch 14.12
>Reporter: Mandeep Mavi
>
> POS not calculating Tax While doing return.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6587) buildSurveyFromPdf generates an NPE

2016-01-16 Thread Suraj Khurana (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15103120#comment-15103120
 ] 

Suraj Khurana commented on OFBIZ-6587:
--

Initial fix for this is available in the patch in which we have restricted user 
at client as well as server side.
User should not be able to submit the form without contentId (PDF Content Id).
Please have a look, adding patch for the same.

> buildSurveyFromPdf generates an NPE
> ---
>
> Key: OFBIZ-6587
> URL: https://issues.apache.org/jira/browse/OFBIZ-6587
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Reporter: Pierre Smits
>  Labels: survey
> Attachments: OFBIZ-6587.patch
>
>
> {code}
> [java] 2015-08-28 18:25:42,712 |ttp-bio-8443-exec-43 |ControlServlet  
>   |T| [[[buildSurveyFromPdf(Domain:https://localhost)] Request Done- 
> total:0.214,since last([buildSurveyFromP...):0.214]]
>  [java] 2015-08-28 18:25:47,756 |ttp-bio-8443-exec-43 |ControlServlet 
>|T| [[[buildSurveyFromPdf(Domain:https://localhost)] Request 
> Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
>  [java] 2015-08-28 18:25:47,761 |ttp-bio-8443-exec-43 |PdfSurveyServices  
>|E| Error generating PDF: java.lang.NullPointerException
>  [java] java.lang.NullPointerException
>  [java]   at 
> org.ofbiz.content.survey.PdfSurveyServices.buildSurveyFromPdf(PdfSurveyServices.java:90)
>  [ofbiz-content.jar:?]
>  [java]   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> ~[?:1.8.0_45]
>  [java]   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
> ~[?:1.8.0_45]
>  [java]   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_45]
>  [java]   at java.lang.reflect.Method.invoke(Method.java:497) 
> ~[?:1.8.0_45]
>  [java]   at 
> org.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:100)
>  [ofbiz-service.jar:?]
>  [java]   at 
> org.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:57)
>  [ofbiz-service.jar:?]
>  [java]   at 
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:395) 
> [ofbiz-service.jar:?]
>  [java]   at 
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:227) 
> [ofbiz-service.jar:?]
>  [java]   at 
> org.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
>  [ofbiz-service.jar:?]
>  [java]   at 
> org.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java:340)
>  [ofbiz-webapp.jar:?]
>  [java]   at 
> org.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:759) 
> [ofbiz-webapp.jar:?]
>  [java]   at 
> org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:476) 
> [ofbiz-webapp.jar:?]
>  [java]   at 
> org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:213) 
> [ofbiz-webapp.jar:?]
>  [java]   at 
> org.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:88) 
> [ofbiz-webapp.jar:?]
>  [java]   at javax.servlet.http.HttpServlet.service(HttpServlet.java:646) 
> [servlet-api-3.0.jar:?]
>  [java]   at javax.servlet.http.HttpServlet.service(HttpServlet.java:727) 
> [servlet-api-3.0.jar:?]
>  [java]   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:303)
>  [tomcat-7.0.59-catalina.jar:7.0.59]
>  [java]   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
>  [tomcat-7.0.59-catalina.jar:7.0.59]
>  [java]   at 
> org.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:324) 
> [ofbiz-webapp.jar:?]
>  [java]   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
>  [tomcat-7.0.59-catalina.jar:7.0.59]
>  [java]   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
>  [tomcat-7.0.59-catalina.jar:7.0.59]
>  [java]   at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:220)
>  [tomcat-7.0.59-catalina.jar:7.0.59]
>  [java]   at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:122)
>  [tomcat-7.0.59-catalina.jar:7.0.59]
>  [java]   at 
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:504)
>  [tomcat-7.0.59-catalina.jar:7.0.59]
>  [java]   at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:170) 
> [tomcat-7.0.59-catalina.jar:7.0.59]
>  [java]   at 
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:103) 
> [tomcat-7.0.59-catalina.jar:7.0.59]
>  [java]   at 
> 

[jira] [Updated] (OFBIZ-6587) buildSurveyFromPdf generates an NPE

2016-01-16 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-6587:
-
Attachment: OFBIZ-6587.patch

> buildSurveyFromPdf generates an NPE
> ---
>
> Key: OFBIZ-6587
> URL: https://issues.apache.org/jira/browse/OFBIZ-6587
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Reporter: Pierre Smits
>  Labels: survey
> Attachments: OFBIZ-6587.patch
>
>
> {code}
> [java] 2015-08-28 18:25:42,712 |ttp-bio-8443-exec-43 |ControlServlet  
>   |T| [[[buildSurveyFromPdf(Domain:https://localhost)] Request Done- 
> total:0.214,since last([buildSurveyFromP...):0.214]]
>  [java] 2015-08-28 18:25:47,756 |ttp-bio-8443-exec-43 |ControlServlet 
>|T| [[[buildSurveyFromPdf(Domain:https://localhost)] Request 
> Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
>  [java] 2015-08-28 18:25:47,761 |ttp-bio-8443-exec-43 |PdfSurveyServices  
>|E| Error generating PDF: java.lang.NullPointerException
>  [java] java.lang.NullPointerException
>  [java]   at 
> org.ofbiz.content.survey.PdfSurveyServices.buildSurveyFromPdf(PdfSurveyServices.java:90)
>  [ofbiz-content.jar:?]
>  [java]   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> ~[?:1.8.0_45]
>  [java]   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
> ~[?:1.8.0_45]
>  [java]   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_45]
>  [java]   at java.lang.reflect.Method.invoke(Method.java:497) 
> ~[?:1.8.0_45]
>  [java]   at 
> org.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:100)
>  [ofbiz-service.jar:?]
>  [java]   at 
> org.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:57)
>  [ofbiz-service.jar:?]
>  [java]   at 
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:395) 
> [ofbiz-service.jar:?]
>  [java]   at 
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:227) 
> [ofbiz-service.jar:?]
>  [java]   at 
> org.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
>  [ofbiz-service.jar:?]
>  [java]   at 
> org.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java:340)
>  [ofbiz-webapp.jar:?]
>  [java]   at 
> org.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:759) 
> [ofbiz-webapp.jar:?]
>  [java]   at 
> org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:476) 
> [ofbiz-webapp.jar:?]
>  [java]   at 
> org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:213) 
> [ofbiz-webapp.jar:?]
>  [java]   at 
> org.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:88) 
> [ofbiz-webapp.jar:?]
>  [java]   at javax.servlet.http.HttpServlet.service(HttpServlet.java:646) 
> [servlet-api-3.0.jar:?]
>  [java]   at javax.servlet.http.HttpServlet.service(HttpServlet.java:727) 
> [servlet-api-3.0.jar:?]
>  [java]   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:303)
>  [tomcat-7.0.59-catalina.jar:7.0.59]
>  [java]   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
>  [tomcat-7.0.59-catalina.jar:7.0.59]
>  [java]   at 
> org.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:324) 
> [ofbiz-webapp.jar:?]
>  [java]   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
>  [tomcat-7.0.59-catalina.jar:7.0.59]
>  [java]   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
>  [tomcat-7.0.59-catalina.jar:7.0.59]
>  [java]   at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:220)
>  [tomcat-7.0.59-catalina.jar:7.0.59]
>  [java]   at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:122)
>  [tomcat-7.0.59-catalina.jar:7.0.59]
>  [java]   at 
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:504)
>  [tomcat-7.0.59-catalina.jar:7.0.59]
>  [java]   at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:170) 
> [tomcat-7.0.59-catalina.jar:7.0.59]
>  [java]   at 
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:103) 
> [tomcat-7.0.59-catalina.jar:7.0.59]
>  [java]   at 
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:116)
>  [tomcat-7.0.59-catalina.jar:7.0.59]
>  [java]   at 
> org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:950) 
> 

[jira] [Updated] (OFBIZ-6226) Webpos F4-F11 label mismatch

2015-12-19 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-6226:
-
Attachment: OFBIZ-6226.patch

Here is the updated patch.
IMO we can close this one after applying this patch.
We can continue discussion related to use of function keys at OFBIZ-5241. 

> Webpos F4-F11 label mismatch
> 
>
> Key: OFBIZ-6226
> URL: https://issues.apache.org/jira/browse/OFBIZ-6226
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/webpos
>Affects Versions: Trunk
>Reporter: Christian Carlow
> Attachments: OFBIZ-6226.patch, OFBIZ-6226.patch
>
>
> At webpos/control/Login the payGiftCard F4 button incorrectly uses label 
> WebPosShortcutF5 (Pay Pin) when it should be using WebPosShortcutF6.  The 
> same mismatch applies to all buttons higher than F4 and should be incremented 
> by 1 as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6226) Webpos F4-F11 label mismatch

2015-12-19 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-6226:
-
Attachment: OFBIZ-6226.patch

> Webpos F4-F11 label mismatch
> 
>
> Key: OFBIZ-6226
> URL: https://issues.apache.org/jira/browse/OFBIZ-6226
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/webpos
>Affects Versions: Trunk
>Reporter: Christian Carlow
> Attachments: OFBIZ-6226.patch, OFBIZ-6226.patch
>
>
> At webpos/control/Login the payGiftCard F4 button incorrectly uses label 
> WebPosShortcutF5 (Pay Pin) when it should be using WebPosShortcutF6.  The 
> same mismatch applies to all buttons higher than F4 and should be incremented 
> by 1 as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6226) Webpos F4-F11 label mismatch

2015-12-19 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-6226:
-
Attachment: (was: OFBIZ-6226.patch)

> Webpos F4-F11 label mismatch
> 
>
> Key: OFBIZ-6226
> URL: https://issues.apache.org/jira/browse/OFBIZ-6226
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/webpos
>Affects Versions: Trunk
>Reporter: Christian Carlow
> Attachments: OFBIZ-6226.patch
>
>
> At webpos/control/Login the payGiftCard F4 button incorrectly uses label 
> WebPosShortcutF5 (Pay Pin) when it should be using WebPosShortcutF6.  The 
> same mismatch applies to all buttons higher than F4 and should be incremented 
> by 1 as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6777) Product weight field enhancements

2015-12-19 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-6777:
-
Attachment: OFBIZ-6777.patch

Please use this query as well for MYSQL database:
ALTER TABLE PRODUCT CHANGE WEIGHT SHIPPING_WEIGHT decimal(18,6);

> Product weight field enhancements
> -
>
> Key: OFBIZ-6777
> URL: https://issues.apache.org/jira/browse/OFBIZ-6777
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk
>Reporter: Suraj Khurana
> Attachments: OFBIZ-6777.patch
>
>
> There are three sets of dimensions in the Product entity.
> (productHeight, shippingHeight), (productWidth,  shippingWidth), 
> (productDepth, shippingDepth) but in case of weight, there is another set of 
> dimension field weight and productWeight which are inconsistent in nature.
> Fix this thing and correct all instances of this in the framework.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6226) Webpos F4-F11 label mismatch

2015-12-19 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-6226:
-
Attachment: OFBIZ-6226-1412.patch

Patch for -r14.12

> Webpos F4-F11 label mismatch
> 
>
> Key: OFBIZ-6226
> URL: https://issues.apache.org/jira/browse/OFBIZ-6226
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/webpos
>Affects Versions: Trunk
>Reporter: Christian Carlow
> Attachments: OFBIZ-6226-1412.patch, OFBIZ-6226.patch, OFBIZ-6226.patch
>
>
> At webpos/control/Login the payGiftCard F4 button incorrectly uses label 
> WebPosShortcutF5 (Pay Pin) when it should be using WebPosShortcutF6.  The 
> same mismatch applies to all buttons higher than F4 and should be incremented 
> by 1 as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6226) Webpos F4-F11 label mismatch

2015-12-19 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-6226:
-
Attachment: OFBIZ-6226-1204.patch

> Webpos F4-F11 label mismatch
> 
>
> Key: OFBIZ-6226
> URL: https://issues.apache.org/jira/browse/OFBIZ-6226
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/webpos
>Affects Versions: Release Branch 14.12, Trunk
>Reporter: Christian Carlow
>Assignee: Mridul Pathak
> Attachments: OFBIZ-6226-1204.patch, OFBIZ-6226-1412.patch, 
> OFBIZ-6226.patch, OFBIZ-6226.patch
>
>
> At webpos/control/Login the payGiftCard F4 button incorrectly uses label 
> WebPosShortcutF5 (Pay Pin) when it should be using WebPosShortcutF6.  The 
> same mismatch applies to all buttons higher than F4 and should be incremented 
> by 1 as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6777) Product weight field enhancements

2015-12-18 Thread Suraj Khurana (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15065235#comment-15065235
 ] 

Suraj Khurana commented on OFBIZ-6777:
--

Copying Jacopo's comment from dev list:

There are indeed some data model inconsistencies in this area.
After reviewing the commit (817605) that introduced the field productWeight
I think that the following applies:
"weight" should be used to specify the "shipping weight" of the product
"productWeight" should be used to specify the actual weight of the product.

However since its introduction, productWeight was never used and "weight"
has been used both to specify the shipping weight and to specify the actual
weight.

How can we fix this situation? I see two options:
1) review all usages of "weight" and fix according to the definition above
2) rename "productWeight" into "shippingWeight" and fix the codebase to use
this field only when the shipping weight is required and use "weight" in
all the other cases.

Maybe #2 would be easier to implement and would have a limited impact on
existing instances.
===

> Product weight field enhancements
> -
>
> Key: OFBIZ-6777
> URL: https://issues.apache.org/jira/browse/OFBIZ-6777
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk
>Reporter: Suraj Khurana
>
> There are three sets of dimensions in the Product entity.
> (productHeight, shippingHeight), (productWidth,  shippingWidth), 
> (productDepth, shippingDepth) but in case of weight, there is another set of 
> dimension field weight and productWeight which are inconsistent in nature.
> Fix this thing and correct all instances of this in the framework.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-6777) Product weight field enhancements

2015-12-18 Thread Suraj Khurana (JIRA)
Suraj Khurana created OFBIZ-6777:


 Summary: Product weight field enhancements
 Key: OFBIZ-6777
 URL: https://issues.apache.org/jira/browse/OFBIZ-6777
 Project: OFBiz
  Issue Type: Improvement
  Components: product
Affects Versions: Trunk, Release Branch 14.12, Release Branch 13.07
Reporter: Suraj Khurana


There are three sets of dimensions in the Product entity.
(productHeight, shippingHeight), (productWidth,  shippingWidth), (productDepth, 
shippingDepth) but in case of weight, there is another set of dimension field 
weight and productWeight which are inconsistent in nature.
Fix this thing and correct all instances of this in the framework.
 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)