[jira] [Created] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
Taher Alkhateeb created OFBIZ-7534: -- Summary: Migrate OFBiz from Apache Ant to Gradle build system Key: OFBIZ-7534 URL: https://issues.apache.org/jira/browse/OFBIZ-7534 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: Upcoming Branch Reporter: Taher Alkhateeb Assignee: Taher Alkhateeb This is a major refactoring task referring to the [email thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] in which the community voted for the switch after a proposal from the PMC The purpose of this JIRA is to achieve the following objectives - Fully implement a working compiling system in Gradle that passes all tests - Remove all ant and maven build scripts from the system - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-7534: --- Attachment: ANT_GRADLE_COMPARISON.txt This is a file that shows the old ant commands in comparison with their gradle counterparts. I need feedback to make sure I'm doing things correctly. > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346992#comment-15346992 ] Taher Alkhateeb commented on OFBIZ-7534: Hi Jacques, Thank you for the feedback. To note: - I think the start-batch and start-batch-secure should simply be replaced as follows: linux: ./gradlew 'ofbiz --start' & windows: start gradlew.bat 'ofbiz --start' (I think we might need a flag) - No need for shell scripts, I can make "shortcut tasks" but then are there any default values for these parameters? If yes, tell me their values and I will create a task for it. - Please note there are two types of tasks as I designed it. The first is OFBiz server tasks, they always start with 'ofbiz' or 'ofbizDebug' or 'ofbizSecure' They are really just a replacement to java -jar ofbiz.jar with the correct JVM arguments. The other set of tasks are called directly by name. I designed it this way so people talk to the server directly. Again, it is very easy to create shortcut tasks, but I just prefer minimalism. If you want shortcut or convenience tasks, I will add them. For example, loadDemo and testInteg are shortcut tasks. loadDemo translates to 'ofbiz --load-data' Again, thank you for your feedback, and feel free to pitch in anything else you want. > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-7534: --- Attachment: build.gradle This file is not complete, and the classpath issue needs a major change, please do not use this file now, I am just attaching it to show my work so far and to keep a backup copy on JIRA and for you to get a clue what is it that I'm doing. Enjoy! > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, build.gradle > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-7534: --- Affects Version/s: (was: Trunk) Upcoming Branch > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, build.gradle > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-7534: --- Attachment: OFBIZ-7534.patch Ok, this is my first patch on migrating to gradle. This patch does the following: - Add a build.gradle which takes care of everything that build.xml used to do - Replace the old README file with a new file called README.md. I used markdown to make easier to read with a markdown viewer. This README.md file serves both as a quick reference and documentation for gradle and how it operates within OFBiz. - Move license related stuff to the correct file. This is a big patch and requires a LOT of testing. I appreciate all the help I can get. > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, build.gradle > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-7534: --- Attachment: gradle-wrapper.jar OFBIZ-7534.patch This patch includes the gradle wrapper. Just make sure to copy gradle-wrapper.jar to ./gradle/wrapper/ > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, build.gradle, gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6986) Simplify getChildHRCategoryTree
[ https://issues.apache.org/jira/browse/OFBIZ-6986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352546#comment-15352546 ] Taher Alkhateeb commented on OFBIZ-6986: Hi Jacques, I will put this on my list at least to look at it once I'm done with Gradle, if Pranay wants to tackle this then it would be even better so I can focus on the core stuff. > Simplify getChildHRCategoryTree > --- > > Key: OFBIZ-6986 > URL: https://issues.apache.org/jira/browse/OFBIZ-6986 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS, humanres >Reporter: Kulwant > Fix For: Upcoming Branch > > Attachments: OFBIZ-6986.patch, OFBIZ-6986.patch, OFBIZ-6986.patch > > > breaking the single long method to multiple private functions with improved > exception handling. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6986) Simplify getChildHRCategoryTree
[ https://issues.apache.org/jira/browse/OFBIZ-6986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352652#comment-15352652 ] Taher Alkhateeb commented on OFBIZ-6986: Yeah that would be great. I would really rather focus on framework core ATM > Simplify getChildHRCategoryTree > --- > > Key: OFBIZ-6986 > URL: https://issues.apache.org/jira/browse/OFBIZ-6986 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS, humanres >Reporter: Kulwant > Fix For: Upcoming Branch > > Attachments: OFBIZ-6986.patch, OFBIZ-6986.patch, OFBIZ-6986.patch > > > breaking the single long method to multiple private functions with improved > exception handling. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-7534: --- Attachment: OFBIZ-7534.patch Ok, attaching a new updated patch which has the following improvements: - First, change testInteg to testIntegration. Gradle has cool shortcuts so you can call this task with ./gradlew tI .. so no need to keep names very short - Introduced the gradle eclipse plugin. Now the files .plugin and .classpath are automatically generated from gradle with a simple command: ./gradlew eclipse - Added two new server command patterns. ofbizBackground and ofbizBackgroundSecure. These two patterns allow you to execute OFBiz commands in the background and to redirect output runtime/logs/console.log. I did this with a hack using the ProcessBuilder API - deleted a line that breaks the build from framework/common/src/org/ofbiz/common/email/EmailServices.java. This line calls legacy Java code which is no longer necessary (I think since JDK 1.4) - updated the documentation to reflect all the above As usual, you need to copy the gradle-wrapper.jar file to gradle/wrapper/ for everything to work correctly in addition to applying the patch > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, build.gradle, gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355315#comment-15355315 ] Taher Alkhateeb commented on OFBIZ-7534: Hi Pierre, Thank you for your feedback. in reply: - Yes I realize ant is not removed, this will happen in a later commit. This is a big task and I'm taking it in bite sizes, keeping ant as backup before I delete it - It's better to use readme.md than readme because of the clarity of the output given that most of the readme is rewritten anyway. - A simple find would suffice to find the eclipse command, anyway, no problem I can make a reference to it - Your permission problem is there because I'm attaching a patch, not applying a commit. Patches do not preserve permissions. This issue will be resolved once a commit is pushed to trunk. You don't need to "stop" because of simple file permission issues. - I did not remove the jars despite removing the .classpath file just to show that it works. There is a simple command ./gradlew eclipse which immediately generates the files you need - the ./gradlew ofbiz command is named like that because this is a rule, not a fixed command. You can read more on gradle rules, but in essence, ./gradlw ofbiz is comparable to java -jar ofbiz.jar ... it's a gateway to all OFBiz commands. > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, build.gradle, gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355404#comment-15355404 ] Taher Alkhateeb commented on OFBIZ-7534: Hi Pierre, You are making a simple problem into a big one. chmod +x gradlew ... that's it! no need for branch or checking or anything else, it's a simple file permission. Set it to executable and the whole issue is done. > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, build.gradle, gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356955#comment-15356955 ] Taher Alkhateeb commented on OFBIZ-7534: Okay, doing a bit of research, the listing of the JARs and their count in each component is listed below. I would appreciate it if you can save me some time by pointing out which ones are not necessary and the code would compile without them. ||Component||Count of Jars|| |base|94| |solr|43| |birt|34| |catalina|13| |service|10| |cmssite|6| |pos|5| |ebaystore|4| |lucene|3| |webapp|3| |testtools|2| |entity|2| |content|2| |product|2| |start|1| |demo-backup|1| |ldap|1| |geronimo|1| |security|1| |googlecheckout|1| |Total*|*229*| The detailed listing of the Jars: ||component_group||component_name||JarFile|| |applications|content|./applications/content/lib/dom4j-1.6.1.jar| |applications|content|./applications/content/lib/poi-3.13-20150929.jar| |applications|product|./applications/product/lib/watermarker-0.0.4.jar| |applications|product|./applications/product/lib/dozer-4.2.1.jar| |framework|base|./framework/base/lib/scripting/bsh-2.0b4.jar| |framework|base|./framework/base/lib/scripting/antlr-2.7.6.jar| |framework|base|./framework/base/lib/scripting/jython-nooro.jar| |framework|base|./framework/base/lib/scripting/jakarta-oro-2.0.8.jar| |framework|base|./framework/base/lib/scripting/bsf-2.4.0.jar| |framework|base|./framework/base/lib/scripting/asm-3.2.jar| |framework|base|./framework/base/lib/scripting/groovy-all-2.4.5.jar| |framework|base|./framework/base/lib/batik-all-1.8.jar| |framework|base|./framework/base/lib/jdom-1.1.jar| |framework|base|./framework/base/lib/ant-1.9.0-ant.jar| |framework|base|./framework/base/lib/fop-2.1.jar| |framework|base|./framework/base/lib/juel-impl-2.2.7.jar| |framework|base|./framework/base/lib/log4j-nosql-2.3.jar| |framework|base|./framework/base/lib/ant/ant-1.9.0-ant-apache-bsf.jar| |framework|base|./framework/base/lib/ant/ant-contrib-1.0b3.jar| |framework|base|./framework/base/lib/commons/commons-io-2.4.jar| |framework|base|./framework/base/lib/commons/commons-logging-1.2.jar| |framework|base|./framework/base/lib/commons/commons-lang-2.6.jar| |framework|base|./framework/base/lib/commons/commons-compress-1.11.jar| |framework|base|./framework/base/lib/commons/commons-pool2-2.3.jar| |framework|base|./framework/base/lib/commons/commons-el-1.0.jar| |framework|base|./framework/base/lib/commons/commons-codec-1.10.jar| |framework|base|./framework/base/lib/commons/commons-fileupload-1.3.1.jar| |framework|base|./framework/base/lib/commons/commons-csv-1.1.jar| |framework|base|./framework/base/lib/commons/commons-net-3.3.jar| |framework|base|./framework/base/lib/commons/commons-collections4-4.1.jar| |framework|base|./framework/base/lib/commons/commons-beanutils-core-1.8.3.jar| |framework|base|./framework/base/lib/commons/commons-validator-1.4.1.jar| |framework|base|./framework/base/lib/xml-apis-ext-1.3.04.jar| |framework|base|./framework/base/lib/xml-apis-1.4.01.jar| |framework|base|./framework/base/lib/log4j-1.2-api-2.3.jar| |framework|base|./framework/base/lib/log4j-slf4j-impl-2.3.jar| |framework|base|./framework/base/lib/ant-1.9.0-ant-junit.jar| |framework|base|./framework/base/lib/icu4j-57_1.jar| |framework|base|./framework/base/lib/resolver-2.9.1.jar| |framework|base|./framework/base/lib/barcode4j-2.1-barcode4j-fop-ext-complete.jar| |framework|base|./framework/base/lib/xpp3-1.1.4c.jar| |framework|base|./framework/base/lib/log4j-core-2.3.jar| |framework|base|./framework/base/lib/junit-dep-4.10.jar| |framework|base|./framework/base/lib/freemarker-2.3.24.jar| |framework|base|./framework/base/lib/tika-parsers-1.12.jar| |framework|base|./framework/base/lib/xmlrpc-client-3.1.2.jar| |framework|base|./framework/base/lib/clhm-release-1.0-lru.jar| |framework|base|./framework/base/lib/jpim-0.1.jar| |framework|base|./framework/base/lib/xalan-2.7.2.jar| |framework|base|./framework/base/lib/shiro-core-1.2.5.jar| |framework|base|./framework/base/lib/mail-1.5.1.jar| |framework|base|./framework/base/lib/pdfbox-1.8.12.jar| |framework|base|./framework/base/lib/xmlrpc-common-3.1.2.jar| |framework|base|./framework/base/lib/avalon-framework-4.2.0.jar| |framework|base|./framework/base/lib/jempbox-1.8.11.jar| |framework|base|./framework/base/lib/nekohtml-1.9.16.jar| |framework|base|./framework/base/lib/jackson-core-2.4.2.jar| |framework|base|./framework/base/lib/owasp-java-html-sanitizer-r239.jar| |framework|base|./framework/base/lib/serializer-2.9.1.jar| |framework|base|./framework/base/lib/httpclient-cache-4.4.1.jar| |framework|base|./framework/base/lib/ical4j-1.0-rc2.jar| |framework|base|./framework/base/lib/ws-commons-java5-1.0.1.jar| |framework|base|./framework/base/lib/fontbox-1.8.11.jar| |framework|base|./framework/base/lib/esapi-2.1.0.jar| |framework|base|./framework/base/lib/xercesImpl-2.11.0.jar| |framework|base|./framework/base/lib/xmlrpc-ser
[jira] [Comment Edited] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356955#comment-15356955 ] Taher Alkhateeb edited comment on OFBIZ-7534 at 6/30/16 11:55 AM: -- Okay, doing a bit of research, the listing of the JARs and their count in each component is listed below. I would appreciate it if you can save me some time by pointing out which ones are not necessary and the code would compile without them. ||Component||Count of Jars|| |base|94| |solr|43| |birt|34| |catalina|13| |service|10| |cmssite|6| |pos|5| |ebaystore|4| |lucene|3| |webapp|3| |testtools|2| |entity|2| |content|2| |product|2| |start|1| |demo-backup|1| |ldap|1| |geronimo|1| |security|1| |googlecheckout|1| |*Total*|*229*| The detailed listing of the Jars: ||component_group||component_name||JarFile|| |applications|content|./applications/content/lib/dom4j-1.6.1.jar| |applications|content|./applications/content/lib/poi-3.13-20150929.jar| |applications|product|./applications/product/lib/watermarker-0.0.4.jar| |applications|product|./applications/product/lib/dozer-4.2.1.jar| |framework|base|./framework/base/lib/scripting/bsh-2.0b4.jar| |framework|base|./framework/base/lib/scripting/antlr-2.7.6.jar| |framework|base|./framework/base/lib/scripting/jython-nooro.jar| |framework|base|./framework/base/lib/scripting/jakarta-oro-2.0.8.jar| |framework|base|./framework/base/lib/scripting/bsf-2.4.0.jar| |framework|base|./framework/base/lib/scripting/asm-3.2.jar| |framework|base|./framework/base/lib/scripting/groovy-all-2.4.5.jar| |framework|base|./framework/base/lib/batik-all-1.8.jar| |framework|base|./framework/base/lib/jdom-1.1.jar| |framework|base|./framework/base/lib/ant-1.9.0-ant.jar| |framework|base|./framework/base/lib/fop-2.1.jar| |framework|base|./framework/base/lib/juel-impl-2.2.7.jar| |framework|base|./framework/base/lib/log4j-nosql-2.3.jar| |framework|base|./framework/base/lib/ant/ant-1.9.0-ant-apache-bsf.jar| |framework|base|./framework/base/lib/ant/ant-contrib-1.0b3.jar| |framework|base|./framework/base/lib/commons/commons-io-2.4.jar| |framework|base|./framework/base/lib/commons/commons-logging-1.2.jar| |framework|base|./framework/base/lib/commons/commons-lang-2.6.jar| |framework|base|./framework/base/lib/commons/commons-compress-1.11.jar| |framework|base|./framework/base/lib/commons/commons-pool2-2.3.jar| |framework|base|./framework/base/lib/commons/commons-el-1.0.jar| |framework|base|./framework/base/lib/commons/commons-codec-1.10.jar| |framework|base|./framework/base/lib/commons/commons-fileupload-1.3.1.jar| |framework|base|./framework/base/lib/commons/commons-csv-1.1.jar| |framework|base|./framework/base/lib/commons/commons-net-3.3.jar| |framework|base|./framework/base/lib/commons/commons-collections4-4.1.jar| |framework|base|./framework/base/lib/commons/commons-beanutils-core-1.8.3.jar| |framework|base|./framework/base/lib/commons/commons-validator-1.4.1.jar| |framework|base|./framework/base/lib/xml-apis-ext-1.3.04.jar| |framework|base|./framework/base/lib/xml-apis-1.4.01.jar| |framework|base|./framework/base/lib/log4j-1.2-api-2.3.jar| |framework|base|./framework/base/lib/log4j-slf4j-impl-2.3.jar| |framework|base|./framework/base/lib/ant-1.9.0-ant-junit.jar| |framework|base|./framework/base/lib/icu4j-57_1.jar| |framework|base|./framework/base/lib/resolver-2.9.1.jar| |framework|base|./framework/base/lib/barcode4j-2.1-barcode4j-fop-ext-complete.jar| |framework|base|./framework/base/lib/xpp3-1.1.4c.jar| |framework|base|./framework/base/lib/log4j-core-2.3.jar| |framework|base|./framework/base/lib/junit-dep-4.10.jar| |framework|base|./framework/base/lib/freemarker-2.3.24.jar| |framework|base|./framework/base/lib/tika-parsers-1.12.jar| |framework|base|./framework/base/lib/xmlrpc-client-3.1.2.jar| |framework|base|./framework/base/lib/clhm-release-1.0-lru.jar| |framework|base|./framework/base/lib/jpim-0.1.jar| |framework|base|./framework/base/lib/xalan-2.7.2.jar| |framework|base|./framework/base/lib/shiro-core-1.2.5.jar| |framework|base|./framework/base/lib/mail-1.5.1.jar| |framework|base|./framework/base/lib/pdfbox-1.8.12.jar| |framework|base|./framework/base/lib/xmlrpc-common-3.1.2.jar| |framework|base|./framework/base/lib/avalon-framework-4.2.0.jar| |framework|base|./framework/base/lib/jempbox-1.8.11.jar| |framework|base|./framework/base/lib/nekohtml-1.9.16.jar| |framework|base|./framework/base/lib/jackson-core-2.4.2.jar| |framework|base|./framework/base/lib/owasp-java-html-sanitizer-r239.jar| |framework|base|./framework/base/lib/serializer-2.9.1.jar| |framework|base|./framework/base/lib/httpclient-cache-4.4.1.jar| |framework|base|./framework/base/lib/ical4j-1.0-rc2.jar| |framework|base|./framework/base/lib/ws-commons-java5-1.0.1.jar| |framework|base|./framework/base/lib/fontbox-1.8.11.jar| |framework|base|./framework/base/lib/esapi-2.1.0.jar| |framework|base|./framework/base/lib/xercesImpl-2.11.0.
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15358680#comment-15358680 ] Taher Alkhateeb commented on OFBIZ-7534: Hi Jacques, Ok, figured it out, just use "double quotes" instead of 'single quotes' So gradlew "ofbiz --start" I will update the README.md. Thank you for the valuable feedback. > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, build.gradle, gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-7534: --- Attachment: OFBIZ-7534.patch In addition to everything mentioned in the previous patches, this patch introduces a skeleton for an OFBiz plug-in system. How did we design it -- - Add all the components defined in framework/component-load.xml as gradle subprojects - Add all the components defined in applications/component-load.xml as gradle subprojects - Add all the components defined in specialcomponents/component-load.xml as gradle subprojects - Add the start component as a gradle subproject - Add all the components in /hot-deploy as gradle subprojects - Each subproject can _optionally_ have a build.gradle script - If a directory exists in framework, applications or specialpurpose but is not defined in component-load.xml, then it will be considered a dead folder, it will not even compile and it will not be part of OFBiz and your IDE will ignore it. What are the benefits --- - Each subproject can declare its own library dependencies in its own build.gradle away from the framework - Compilation, running, and testing is centralized at the master build script, making the subproject build scripts very small - It is very easy now to "turn on" or "turn off" a plugin with a build script that simply removes/adds it to component-load.xml! - We can now design a full plug-in API and can design a full eco-system around OFBiz. - If we decide to, we do not _have to_ compile and test everything, we can offload the maintenance of plugins to specialized teams, or even to third parties. > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, build.gradle, > gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360901#comment-15360901 ] Taher Alkhateeb commented on OFBIZ-7534: Hi Pierre Please visit OFBIZ-6783 and look at the number of patches and comments. I am comfortable with the rate of change, it is minimal impact per commit. The first patch to go inside is for minor changes with the big change only in the gradle files themselves.. With that being said, we appreciate if you can help out. We are trying to identify the libraries from jcenter (described above). > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, build.gradle, > gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361077#comment-15361077 ] Taher Alkhateeb commented on OFBIZ-7534: Hi Jacques, Ok good idea, I'll keep the files for now. Why did I remove the JVM arguments comment? because the JVM arguments are now automatically inserted from gradle, and there is no java -jar ofbiz.jar anymore. So no need to warn people about JVM arguments. > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, build.gradle, > gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361457#comment-15361457 ] Taher Alkhateeb commented on OFBIZ-7534: Thank you everybody for your wonderful support and feedback We have the first commit in r1751309. As of right now, ant lives side-by-side with ant and will be replaced in the upcoming few commits > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, build.gradle, > gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15362352#comment-15362352 ] Taher Alkhateeb commented on OFBIZ-7534: Thank you for the wonderful feedback Ashish! So, a few feedback points: - Ant is an imperative tool (do things in sequence) whereas Gradle is declarative. Because of this difference, the Gradle output is very different from ant when doing ./gradlew whatever --info. So we have multiple solutions for this, for example, we can loop over all components and compile them one by one separately in a different configuration classpath and then combine them together at the end. It's a bit of a pain to get the code right but nothing major. Another solution is to write custom logger.info or println statements to show what is going on during the compilation process. Yet another option is to break the compilation process into the subprojects. I will think some more of the best solution and I'll put it in the list of future things to do to improve the output of Gradle - Ctrl-C does not work with Gradle because it is a powerful engine that can do multiple tasks in parallel by spawning threads and processes. So a simple Ctrl-C does not work because it only kills gradle, not the other sub-processes. So I am going to work on a new task called terminateOfbiz which searches for running instances of OFBiz and kill them. - H, very good point on the database. Should I let Gradle check if a database exists, and if not then terminate with a clear message? It would be easy to check if a derby database exists, but what about the others? should I establish a JDBC connection? Great feedback, very useful information, thank you! > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, build.gradle, > gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15363861#comment-15363861 ] Taher Alkhateeb commented on OFBIZ-7534: Hi Jacques, In feedback to your comments: - agreed with .gradle ans build directories hiding in root as well as ofbiz.jar - It's okay but not very necessary to modify the commit saying we will remove .classpath and .project. Many other files will go away, maybe we should mention it in its own commit? - I hesitate about the build directory in each component. Under the current design each component is a gradle subproject. If any of these subprojects applies the Java plugin for whatever reason a build directory will be created. I am not sure we will use it but a little delay on this point would be better until the picture is clear. Cheers! > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, build.gradle, > gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15366006#comment-15366006 ] Taher Alkhateeb commented on OFBIZ-7534: Committed a new task as discussed above called terminateOfbiz which force kills all running OFBiz server instances in r1751785. It was not as easy as I thought, but we ended up using a very nice solution on windows (in fact, better and cleaner than linux implementation) > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, OFBizRemoteJarList.csv, > OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, build.gradle, > gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15366012#comment-15366012 ] Taher Alkhateeb commented on OFBIZ-7534: Huh, I don't understand what you mean Jacques? What does the timestamp above refer to? > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, OFBizRemoteJarList.csv, > OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, build.gradle, > gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15366025#comment-15366025 ] Taher Alkhateeb commented on OFBIZ-7534: Added documentation to terminateOfbiz in README.md in r1751789. > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, OFBizRemoteJarList.csv, > OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, build.gradle, > gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-7534: --- Attachment: (was: build.gradle) > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, OFBizRemoteJarList.csv, > OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15366045#comment-15366045 ] Taher Alkhateeb commented on OFBIZ-7534: Oh got ya! deleted > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, OFBizRemoteJarList.csv, > OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369223#comment-15369223 ] Taher Alkhateeb commented on OFBIZ-7534: Applied a new major commit in r1752033. which does the following: - delete all ant and maven old scripts - delete 169 jars and replace them with remote jars downloaded by gradle - update the build scripts accordingly All tests are passing successfully. We need help from everyone to complete the replacements of all Jars in the framework. Thank you all for your wonderful help and support, this has been a great teamwork and I appreciate everyone's help. > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, OFBizRemoteJarList.csv, > OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, > gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369278#comment-15369278 ] Taher Alkhateeb commented on OFBIZ-7534: Hi Pierre, Ant is no longer sustainable from this point forward. Moving towards remote libraries (already started) means all ant scripts are now broken. We already kept ant for the longest possible period while testing functionality. Are there any specific tasks which worry you? > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, OFBizRemoteJarList.csv, > OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, > gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369424#comment-15369424 ] Taher Alkhateeb commented on OFBIZ-7534: Yeah, totally forgot about UI labels, ok I'm on it > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, OFBizRemoteJarList.csv, > OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, > gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369429#comment-15369429 ] Taher Alkhateeb commented on OFBIZ-7534: ok, great feedback: - It is fantastic that gradlew javadoc fails. It is detecting all the bad stuff we have in our javadocs. For example, some methods declare throwing some exception in javadoc but not in method signature. This task can actually help us clean up our documentation :) Nice ! - Yeah got it on windows, it's file format issue .. I'm on it. > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, OFBizRemoteJarList.csv, > OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, > gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369437#comment-15369437 ] Taher Alkhateeb commented on OFBIZ-7534: Fixed the issue in r1752059. Only Windows detected the error, nevertheless it's a very minor issue. The subprojects were being evaluated before the master script and they did not know what the definition of the pluginLibsCompile and pluginLibsRuntime means. One line fixed the issue by simply removing "evaluationDependsOnChildren()" declaration. This runs the subprojects before the master project. > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, OFBizRemoteJarList.csv, > OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, > gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[
https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369442#comment-15369442
]
Taher Alkhateeb commented on OFBIZ-7534:
Ok Jacques, after further checking we slightly changed the old format of the
footer. The old format used only the translated words
_uiLabelMap.CommonBuiltOn_ and _uiLabelMap.CommonWith_. On the other hand, the
new format contains the words Branch, Revision, Built On and Java Version.
Should we translate all four words in the CommonUiLabels.xml and then
incorporate them?
old version:
" - Release-revision : ${releasePath}-r${info.entry.commit(revision)},
${uiLabelMap.CommonBuiltOn} ${dateTime} ${uiLabelMap.CommonWith} Java
${java.version}
new version:
"Branch: ${info.entry.url.text()}" + System.lineSeparator()
"Revision: ${info.entry.commit.@revision}" + System.lineSeparator()
"Built on: ${timestamp}" + System.lineSeparator()
"Java Version: ${org.gradle.internal.jvm.Jvm.current()}"
> Migrate OFBiz from Apache Ant to Gradle build system
>
>
> Key: OFBIZ-7534
> URL: https://issues.apache.org/jira/browse/OFBIZ-7534
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
> Labels: ant, build-tools, gradle
> Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch,
> OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, OFBizRemoteJarList.csv,
> OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, OFBizRemoteJarList.csv,
> gradle-wrapper.jar
>
>
> This is a major refactoring task referring to the [email
> thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle]
> in which the community voted for the switch after a proposal from the PMC
> The purpose of this JIRA is to achieve the following objectives
> - Fully implement a working compiling system in Gradle that passes all tests
> - Remove all ant and maven build scripts from the system
> - update the documentation of the system to reflect these changes
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[
https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369442#comment-15369442
]
Taher Alkhateeb edited comment on OFBIZ-7534 at 7/10/16 6:45 AM:
-
Ok Jacques, after further checking we slightly changed the old format of the
footer. The old format used only the translated words
_uiLabelMap.CommonBuiltOn_ and _uiLabelMap.CommonWith_. On the other hand, the
new format contains the words Branch, Revision, Built On and Java Version.
Should we translate all four words in the CommonUiLabels.xml and then
incorporate them?
old version:
{code}
" - Release-revision : ${releasePath}-r${info.entry.commit(revision)},
${uiLabelMap.CommonBuiltOn} ${dateTime} ${uiLabelMap.CommonWith} Java
${java.version}
{code}
new version:
{code}
"Branch: ${info.entry.url.text()}" + System.lineSeparator()
"Revision: ${info.entry.commit.@revision}" + System.lineSeparator()
"Built on: ${timestamp}" + System.lineSeparator()
"Java Version: ${org.gradle.internal.jvm.Jvm.current()}"
{code}
was (Author: taher):
Ok Jacques, after further checking we slightly changed the old format of the
footer. The old format used only the translated words
_uiLabelMap.CommonBuiltOn_ and _uiLabelMap.CommonWith_. On the other hand, the
new format contains the words Branch, Revision, Built On and Java Version.
Should we translate all four words in the CommonUiLabels.xml and then
incorporate them?
old version:
" - Release-revision : ${releasePath}-r${info.entry.commit(revision)},
${uiLabelMap.CommonBuiltOn} ${dateTime} ${uiLabelMap.CommonWith} Java
${java.version}
new version:
"Branch: ${info.entry.url.text()}" + System.lineSeparator()
"Revision: ${info.entry.commit.@revision}" + System.lineSeparator()
"Built on: ${timestamp}" + System.lineSeparator()
"Java Version: ${org.gradle.internal.jvm.Jvm.current()}"
> Migrate OFBiz from Apache Ant to Gradle build system
>
>
> Key: OFBIZ-7534
> URL: https://issues.apache.org/jira/browse/OFBIZ-7534
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
> Labels: ant, build-tools, gradle
> Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch,
> OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, OFBizRemoteJarList.csv,
> OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, OFBizRemoteJarList.csv,
> gradle-wrapper.jar
>
>
> This is a major refactoring task referring to the [email
> thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle]
> in which the community voted for the switch after a proposal from the PMC
> The purpose of this JIRA is to achieve the following objectives
> - Fully implement a working compiling system in Gradle that passes all tests
> - Remove all ant and maven build scripts from the system
> - update the documentation of the system to reflect these changes
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7749) iterateOverActiveComponents exists twice
[ https://issues.apache.org/jira/browse/OFBIZ-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369460#comment-15369460 ] Taher Alkhateeb commented on OFBIZ-7749: Yes we need both, one for declaring subprojects and one for other custom logic. The code cannot be shared between both files because each one is visible in a different stage (one in the initialization stage of gradle and the other one during the configuration & execution phases). Hence this JIRA is unnecessary > iterateOverActiveComponents exists twice > > > Key: OFBIZ-7749 > URL: https://issues.apache.org/jira/browse/OFBIZ-7749 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits > Labels: gradle > > Currently the iterateOverActiveComponents function or tasks exists both in > build.gradle and settings.gradle. > Do we need both? Which one is superfluous? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7729) Eclipse IDE gets messed up
[ https://issues.apache.org/jira/browse/OFBIZ-7729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369461#comment-15369461 ] Taher Alkhateeb commented on OFBIZ-7729: Cannot repeat, seems improper setup at your end as multiple people already have it setup correctly on multiple platforms > Eclipse IDE gets messed up > -- > > Key: OFBIZ-7729 > URL: https://issues.apache.org/jira/browse/OFBIZ-7729 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Blocker > Labels: gradle > Attachments: Screen Shot 2016-07-04 at 09.26.09.png, Screen Shot > 2016-07-04 at 09.26.39.png > > > When applying the patches from OFBIZ-7534 and executing the eclipse > configuration task, my IDE gets messed up. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7771) Rename loadDefault to something less ambiguous
[ https://issues.apache.org/jira/browse/OFBIZ-7771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369462#comment-15369462 ] Taher Alkhateeb commented on OFBIZ-7771: loadDefault is more clear than loadDemo. Furthermore, the README.md clearly identifies what loadDefault means. Furthermore, loadDefault is the correct name because it is actually the default data to be loaded. If you call ./gradlew "ofbiz --load-data" without any arguments then the default data is loaded. Now it does not matter "what is the default data" because that is identified inside the server and not the build script level. At least it was that way for many years. > Rename loadDefault to something less ambiguous > -- > > Key: OFBIZ-7771 > URL: https://issues.apache.org/jira/browse/OFBIZ-7771 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits > > The gradle task loadDefault is ambiguous, as it means different things to > different uses. This could lead to a situations where it is used in a wrong > manner, resulting in data being overwritten. > Having a more meaningful name lessens the risk of such situations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369464#comment-15369464 ] Taher Alkhateeb commented on OFBIZ-7534: Pierre ... It would be great if you stop issuing so many JIRAs before at least you discuss them here. For example, your request to create build.gradle files in many subtasks is unnecessary because there is no reason to incorporate them unless you have specific tasks to implement. Even then, you can assign multiple things to one JIRA instead of having this micro JIRAs everywhere. Many other JIRAs you issued are also irrelevant due to either being not applicable or not fully understanding how gradle operates. Excessive issuing of JIRAs without properly formulating the problem might slow us down as we need to read them and reply with a proper answer. If you look at the exchange above, Jacques and I were discussing multiple issues which we fixed immediately in this JIRA without even issuing any further JIRAs > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, OFBizRemoteJarList.csv, > OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, > gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7773) createTenant tasks fails
[
https://issues.apache.org/jira/browse/OFBIZ-7773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369468#comment-15369468
]
Taher Alkhateeb commented on OFBIZ-7773:
You are using the command incorrectly, please read the README.md file, it is
thoroughly documented on this task
> createTenant tasks fails
>
>
> Key: OFBIZ-7773
> URL: https://issues.apache.org/jira/browse/OFBIZ-7773
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Blocker
>
> When executing the gradle createTenant tasks, the following error is thrown:
> {code}
> FAILURE: Build failed with an exception.
> * Where:
> Build file '/Users/pierre/dev/ofbiz/ofbiz-gradle/build.gradle' line: 328
> * What went wrong:
> Execution failed for task ':prepareAndValidateTenantArguments'.
> > Project property tenantId is missing
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or
> --debug option to get more log output.
> BUILD FAILED
> {code}
> The function/process is missing the guided-through approach that ./ant
> create-tenant has.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7772) createComponent tasks fails
[
https://issues.apache.org/jira/browse/OFBIZ-7772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369470#comment-15369470
]
Taher Alkhateeb commented on OFBIZ-7772:
You are using the command incorrectly, please review the documentation on
README.md
> createComponent tasks fails
> ---
>
> Key: OFBIZ-7772
> URL: https://issues.apache.org/jira/browse/OFBIZ-7772
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>
> When executing the gradle createComponent tasks the following error is thrown:
> {code}
> :createComponent FAILED
> FAILURE: Build failed with an exception.
> * Where:
> Build file '/Users/pierre/dev/ofbiz/ofbiz-gradle/build.gradle' line: 412
> * What went wrong:
> Execution failed for task ':createComponent'.
> > Could not find property 'componentName' on task ':createComponent'.
> {code}
> The function is missing the same guided-through approach as ./ant
> create-component has.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7769) Have a gradle build file for the entity component
[ https://issues.apache.org/jira/browse/OFBIZ-7769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369471#comment-15369471 ] Taher Alkhateeb commented on OFBIZ-7769: Unnecessary > Have a gradle build file for the entity component > - > > Key: OFBIZ-7769 > URL: https://issues.apache.org/jira/browse/OFBIZ-7769 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7767) Have gradle produce logs
[ https://issues.apache.org/jira/browse/OFBIZ-7767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369472#comment-15369472 ] Taher Alkhateeb commented on OFBIZ-7767: You can change the log levels with a simple --info or --debug. Furthermore, this is not a blocking JIRA > Have gradle produce logs > > > Key: OFBIZ-7767 > URL: https://issues.apache.org/jira/browse/OFBIZ-7767 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Blocker > > Currently executing gradle tasks doesn't generate logs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7771) Rename loadDefault to something less ambiguous
[ https://issues.apache.org/jira/browse/OFBIZ-7771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369479#comment-15369479 ] Taher Alkhateeb commented on OFBIZ-7771: LoadDefault loads the default data as decided by the OFBiz server, which was working this way for many years! All that I did was change load-demo to loadDefault. load-demo is more confusing because it means load the demo data for a demo system which is not true. load-demo is used for multiple other purposes. Now, ofbiz by default loads certain data, hence the name loadDefault, it's the default by the server ... This is the most correct version. Now it happens that the server default data is seed, seed-initial and demo. However, this is done inside the code of the server, not the build system, and again, this was the case for many, many years. So all that we are doing is calling a spade a spade! With that being said, we can put a comment in the README.md file to explain what the default data is. > Rename loadDefault to something less ambiguous > -- > > Key: OFBIZ-7771 > URL: https://issues.apache.org/jira/browse/OFBIZ-7771 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Minor > > The gradle task loadDefault is ambiguous, as it means different things to > different uses. This could lead to a situations where it is used in a wrong > manner, resulting in data being overwritten. > Having a more meaningful name lessens the risk of such situations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7746) Have a gradle build file for the product component
[ https://issues.apache.org/jira/browse/OFBIZ-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369485#comment-15369485 ] Taher Alkhateeb commented on OFBIZ-7746: unnecessary, no tasks defined to implement > Have a gradle build file for the product component > -- > > Key: OFBIZ-7746 > URL: https://issues.apache.org/jira/browse/OFBIZ-7746 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Pierre Smits > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7748) Have a gradle build file for the catalina component
[ https://issues.apache.org/jira/browse/OFBIZ-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369483#comment-15369483 ] Taher Alkhateeb commented on OFBIZ-7748: unnecessary, no tasks defined to implement > Have a gradle build file for the catalina component > --- > > Key: OFBIZ-7748 > URL: https://issues.apache.org/jira/browse/OFBIZ-7748 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits > Labels: gradle > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7743) Move files in gradle folder to a location within base component of the framework stack
[ https://issues.apache.org/jira/browse/OFBIZ-7743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369482#comment-15369482 ] Taher Alkhateeb commented on OFBIZ-7743: Not applicable, the gradle folder should stay in its place because it is needed by the gradle wrapper. Furthermore, the build system is not part of the framework but covers the entire system. Hence this JIRA is unnecessary > Move files in gradle folder to a location within base component of the > framework stack > -- > > Key: OFBIZ-7743 > URL: https://issues.apache.org/jira/browse/OFBIZ-7743 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits > > Currently the gradle folder and its content is in the root of the OFBiz > implementation. This should be - as part of the framework stack - reside in > the base component of the framework folder. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7747) Have a gradle build file for the base component
[ https://issues.apache.org/jira/browse/OFBIZ-7747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369484#comment-15369484 ] Taher Alkhateeb commented on OFBIZ-7747: unnecessary, no tasks defined to implement > Have a gradle build file for the base component > --- > > Key: OFBIZ-7747 > URL: https://issues.apache.org/jira/browse/OFBIZ-7747 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits > Labels: gradle > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7745) Have a gradle build file for the content component
[ https://issues.apache.org/jira/browse/OFBIZ-7745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369486#comment-15369486 ] Taher Alkhateeb commented on OFBIZ-7745: unnecessary, no tasks defined to implement > Have a gradle build file for the content component > -- > > Key: OFBIZ-7745 > URL: https://issues.apache.org/jira/browse/OFBIZ-7745 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Pierre Smits > Labels: gradle > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7745) Have a gradle build file for the content component
[ https://issues.apache.org/jira/browse/OFBIZ-7745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369491#comment-15369491 ] Taher Alkhateeb commented on OFBIZ-7745: all libraries in framework and core apps are defined in the master build.gradle External libraries per component are only done for the specialpurpose components in preparation for the OFBiz plugin system. If you review the master build.gradle file you will find all core libraries residing in there. > Have a gradle build file for the content component > -- > > Key: OFBIZ-7745 > URL: https://issues.apache.org/jira/browse/OFBIZ-7745 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Pierre Smits > Labels: gradle > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7745) Have a gradle build file for the content component
[ https://issues.apache.org/jira/browse/OFBIZ-7745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369499#comment-15369499 ] Taher Alkhateeb commented on OFBIZ-7745: because framework and applications are not plugins, so having a centralized location for the core libraries reduces the risk of dependency problems which are extremely difficult in Java. In fact it is so difficult I was not able to replace everything yet. If you run ./gradlew dependencies you will understand how complex this is and how valuable it is to reduce the libraries at the core. Hence, plugins plug in with their dependencies, and core is centralized in the master build script. This substantially reduces the complexity which we are still trying to untangle and appreciate any help with. > Have a gradle build file for the content component > -- > > Key: OFBIZ-7745 > URL: https://issues.apache.org/jira/browse/OFBIZ-7745 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Pierre Smits > Labels: gradle > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369506#comment-15369506 ] Taher Alkhateeb commented on OFBIZ-7534: Hi Pierre, Please point out issues missing or neglected. > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, OFBizRemoteJarList.csv, > OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, > gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369510#comment-15369510 ] Taher Alkhateeb commented on OFBIZ-7534: Hi Jacques ... This actually might be a blessing in disguise. I'm working on it! > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, OFBizRemoteJarList.csv, > OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, > gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369511#comment-15369511 ] Taher Alkhateeb commented on OFBIZ-7534: Hi Jacques, Good point, the only pending main issue I can think of is replacing remaining remote libraries (in the attached CSV). I suggest we close this task after completing the remote libs as this is the most critical part. Totally agree on discussing things before issuing JIRAs. > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, OFBizRemoteJarList.csv, > OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, > gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7771) Rename loadDefault to something less ambiguous
[ https://issues.apache.org/jira/browse/OFBIZ-7771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369530#comment-15369530 ] Taher Alkhateeb commented on OFBIZ-7771: loadDefault does not load all datasets and hence the name loadAllDatasets is wrong. Please read what I wrote above! Furthermore, the other variations are not needed with shortcut tasks because they are specific to each user, you can call them with the readers argument yourself. It's all documented in the README.md > Rename loadDefault to something less ambiguous > -- > > Key: OFBIZ-7771 > URL: https://issues.apache.org/jira/browse/OFBIZ-7771 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Minor > > The gradle task loadDefault is ambiguous, as it means different things to > different uses. This could lead to a situations where it is used in a wrong > manner, resulting in data being overwritten. > Having a more meaningful name lessens the risk of such situations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7767) Have gradle produce logs
[ https://issues.apache.org/jira/browse/OFBIZ-7767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369620#comment-15369620 ] Taher Alkhateeb commented on OFBIZ-7767: This is a new feature and not something that used to exist in the ant scripts. And it was implemented using bash scripts and then ONLY for the server tasks. By default ./gradlw "ofbizBackground --start" would fork a new process and send the output to runtime/logs/console.log. For other logging capabilities of the server you should modify the log4j xml settings file. Hence, this JIRA is unnecessary and should be closed unless changed to a new feature wishlist. I personally don't find it very important to convert all console output to a file. > Have gradle produce logs > > > Key: OFBIZ-7767 > URL: https://issues.apache.org/jira/browse/OFBIZ-7767 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Minor > > Currently executing gradle tasks doesn't generate logs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7677) Update documentation with respect to implementation of gradle as a replacement of ant
[ https://issues.apache.org/jira/browse/OFBIZ-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369633#comment-15369633 ] Taher Alkhateeb commented on OFBIZ-7677: Comprehensive documentation was provided in README.md for how to use Gradle. Futhermore Jacques started a task specifically to pull from README.md to the web in OFBIZ-7723. Hence I recommend closing this task unless there are specific locations or steps to be taken > Update documentation with respect to implementation of gradle as a > replacement of ant > - > > Key: OFBIZ-7677 > URL: https://issues.apache.org/jira/browse/OFBIZ-7677 > Project: OFBiz > Issue Type: Sub-task > Components: site >Reporter: Pierre Smits > > Documentation must be updated before any release, that will have the > replacement of ant in place, can be cut. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15370267#comment-15370267 ] Taher Alkhateeb commented on OFBIZ-7534: Hi Jacques and all, Committed work in r1752125. I am very happy to announce that I made a fix in the build script which handles the above error in Windows but also has multiple other benefits. I will explain below: - Instead of a massive process name in the operating system (due to classpath) I created instead a jar that hides all this classpath away. This makes the command line process name much nicer - I declared a dependency for all OFBiz server tasks on the build task to ensure building the jar mentioned above. Now any residual issues (executing multiple commands sometimes fail) are now resolved This was difficult to implement mainly because of bugs I encountered in the Jar manifest. It was very tricky and after a lot of searching I realized that Jar manifests in windows have a weird syntax that we need to adhere to. I am very happy also to report that all tests pass on windows and linux from my side. > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, OFBizRemoteJarList.csv, > OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, > gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7775) Fixes Javadoc in sources
[
https://issues.apache.org/jira/browse/OFBIZ-7775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15370389#comment-15370389
]
Taher Alkhateeb commented on OFBIZ-7775:
Committed a fix in r1752131
This fix is a temporary solution. Gradle does not allow generating JavaDocs if
they have javadocs that are not properly formatted. This commit will override
this behavior by adding the following code snippet:
{code:groovy}
javadoc.failOnError = false
{code}
However, the long term proper solution is to actually fix all the JavaDoc
errors in our current OFBiz API. This JIRA will remain open to complete
cleaning up the JavaDocs in our code base.
> Fixes Javadoc in sources
>
>
> Key: OFBIZ-7775
> URL: https://issues.apache.org/jira/browse/OFBIZ-7775
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
> Fix For: Upcoming Branch
>
>
> To check what to fix simply run gradlew javadoc
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7775) Cleanup JavaDocs to be standards compliant
[ https://issues.apache.org/jira/browse/OFBIZ-7775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-7775: --- Summary: Cleanup JavaDocs to be standards compliant (was: Fixes Javadoc in sources) > Cleanup JavaDocs to be standards compliant > -- > > Key: OFBIZ-7775 > URL: https://issues.apache.org/jira/browse/OFBIZ-7775 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Jacques Le Roux > Fix For: Upcoming Branch > > > To check what to fix simply run gradlew javadoc -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7771) Rename loadDefault to something less ambiguous
[ https://issues.apache.org/jira/browse/OFBIZ-7771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372272#comment-15372272 ] Taher Alkhateeb commented on OFBIZ-7771: You can choose which data sets to load manually with the argument readers=ext,demo,whatever Therefore it is not hard coded and you can change it however you like. This only affects default data. Anybody can override the default data. For instructions on how to do that please review the readme file. > Rename loadDefault to something less ambiguous > -- > > Key: OFBIZ-7771 > URL: https://issues.apache.org/jira/browse/OFBIZ-7771 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Trivial > > The gradle task loadDefault is ambiguous, as it means different things to > different uses. This could lead to a situations where it is used in a wrong > manner, resulting in data being overwritten. > Having a more meaningful name lessens the risk of such situations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7771) Rename loadDefault to something less ambiguous
[ https://issues.apache.org/jira/browse/OFBIZ-7771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372285#comment-15372285 ] Taher Alkhateeb commented on OFBIZ-7771: You issue a command directly to the build system. Please READ the README.md file! > Rename loadDefault to something less ambiguous > -- > > Key: OFBIZ-7771 > URL: https://issues.apache.org/jira/browse/OFBIZ-7771 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Trivial > > The gradle task loadDefault is ambiguous, as it means different things to > different uses. This could lead to a situations where it is used in a wrong > manner, resulting in data being overwritten. > Having a more meaningful name lessens the risk of such situations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7771) Rename loadDefault to something less ambiguous
[ https://issues.apache.org/jira/browse/OFBIZ-7771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372382#comment-15372382 ] Taher Alkhateeb commented on OFBIZ-7771: This is a new feature that did not exist in the old system. You are welcome to implement it yourself. All I did was to fix an old incorrect naming convention. If you wish to create a "default by user perspective" feature then go ahead and work on it, but then this is not a subtask of migrating from Ant to Gradle so please cut this JIRA from the parent JIRA. > Rename loadDefault to something less ambiguous > -- > > Key: OFBIZ-7771 > URL: https://issues.apache.org/jira/browse/OFBIZ-7771 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Trivial > > The gradle task loadDefault is ambiguous, as it means different things to > different uses. This could lead to a situations where it is used in a wrong > manner, resulting in data being overwritten. > Having a more meaningful name lessens the risk of such situations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372540#comment-15372540 ] Taher Alkhateeb commented on OFBIZ-7534: Hi Charl, Thank you for the feedback, It's great that you mentioned this item. I'm working on it and will deliver something very soon for this. Hopefully this will be a big improvement to the way it was done in the past because before Gradle Ivy just used to download the latest version of the database driver. This might not be suitable for your DB in your computer :) So sit tight, I'll have something up very soon > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, OFBizRemoteJarList.csv, > OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, > gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7771) Allow to define which data the loadDefault Gradle task effectively loads
[ https://issues.apache.org/jira/browse/OFBIZ-7771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372653#comment-15372653 ] Taher Alkhateeb commented on OFBIZ-7771: Ok, just a quick comment, After further investigation, I realized that the system does _Exactly_ what Pierre wants. Namely: - If you go to the EntityDataLoadContainer.java you will see that the system sets a default value of "none" if no readers are selected - If the values is "none", then it will fetch the readers list for each data source from the elements So there you go, your default data is already decided by entityengine.xml. Thank you for your feedback, we all learned something in the process. > Allow to define which data the loadDefault Gradle task effectively loads > > > Key: OFBIZ-7771 > URL: https://issues.apache.org/jira/browse/OFBIZ-7771 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Trivial > > The gradle task loadDefault is ambiguous, as it means different things to > different uses. This could lead to a situations where it is used in a wrong > manner, resulting in data being overwritten. > Having a more meaningful name lessens the risk of such situations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7779) Update wiki Eclipse pages regarding Gradle
[
https://issues.apache.org/jira/browse/OFBIZ-7779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Taher Alkhateeb updated OFBIZ-7779:
---
Attachment: OFBIZ-7779.patch
Hi Jacques,
So I have done multiple improvements to the eclipse plugin. These improvements
achieve the following
1- Fix some path issues for folders
2- Remove unnecessary config source directories
I got eclipse working correctly with Gradle by applying the following:
1- create a normal java project
2- create a run/debug configuration of type gradle
3- run it
That's it.
> Update wiki Eclipse pages regarding Gradle
> --
>
> Key: OFBIZ-7779
> URL: https://issues.apache.org/jira/browse/OFBIZ-7779
> Project: OFBiz
> Issue Type: Task
> Components: Confluence
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
> Attachments: OFBIZ-7779.patch
>
>
> I wanted to update the 2 wiki Eclipse pages regarding Gradle. But so far got
> some issues in my environment (still Windows 7).
> I use both Eclipse Luna and Mars (Mars at 98%). Luna does not support Gradle.
> First I must say my Mars instance works perfectly, but for few months I'm
> unable to update. I did not try yet to create another Mars instance because I
> guess it will anyway screws its update mechanism later :/
> Mars comes with the embedded ["Gradle Buildship"
> plugin|https://gradle.org/eclipse/], I have the 1.0.5 version from
> 2015-09-22. I found this tuto
> http://www.vogella.com/tutorials/EclipseGradle/article.html (with a 6/7
> clone/redundant section).
> Few remarks: I see no Gradle context menu entrie, maybe due to my unability
> to update Mars, so I'm unable to "add Gradle support to existing Eclipse
> project ". So I created a Gradle "trunk" side project following , but, though
> all work well in command line, in Eclipse building with Gradle does not work.
> I always get
> {code}
> org.gradle.api.tasks.TaskExecutionException: Execution failed for task
> ':compileJava'.
> at
> org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:69)
> at
> org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:46)
> at
> org.gradle.api.internal.tasks.execution.PostExecutionAnalysisTaskExecuter.execute(PostExecutionAnalysisTaskExecuter.java:35)
> at
> org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:64)
> at
> org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:58)
> at
> org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:52)
> at
> org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:52)
> at
> org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:53)
> at
> org.gradle.api.internal.tasks.execution.ExecuteAtMostOnceTaskExecuter.execute(ExecuteAtMostOnceTaskExecuter.java:43)
> at
> org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:203)
> at
> org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:185)
> at
> org.gradle.execution.taskgraph.AbstractTaskPlanExecutor$TaskExecutorWorker.processTask(AbstractTaskPlanExecutor.java:62)
> at
> org.gradle.execution.taskgraph.AbstractTaskPlanExecutor$TaskExecutorWorker.run(AbstractTaskPlanExecutor.java:50)
> at
> org.gradle.execution.taskgraph.DefaultTaskPlanExecutor.process(DefaultTaskPlanExecutor.java:25)
> at
> org.gradle.execution.taskgraph.DefaultTaskGraphExecuter.execute(DefaultTaskGraphExecuter.java:110)
> at
> org.gradle.execution.SelectedTaskExecutionAction.execute(SelectedTaskExecutionAction.java:37)
> at
> org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:37)
> at
> org.gradle.execution.DefaultBuildExecuter.access$000(DefaultBuildExecuter.java:23)
> at
> org.gradle.execution.DefaultBuildExecuter$1.proceed(DefaultBuildExecuter.java:43)
> at
> org.gradle.execution.DryRunBuildExecutionAction.execute(DryRunBuildExecutionAction.java:32)
> at
> org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:37)
> at
> org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:30)
> at
> org.gradle.initialization.DefaultGradleLauncher$4.run(DefaultGradleLauncher.java:158)
> at org.gradle.internal.Factories$1.create(Factories.java:22)
> at
> org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOpe
[jira] [Updated] (OFBIZ-7779) Update wiki Eclipse pages regarding Gradle
[
https://issues.apache.org/jira/browse/OFBIZ-7779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Taher Alkhateeb updated OFBIZ-7779:
---
Attachment: OFBIZ-7779.patch
Attaching a more improved version that fixes the path issues everywhere
> Update wiki Eclipse pages regarding Gradle
> --
>
> Key: OFBIZ-7779
> URL: https://issues.apache.org/jira/browse/OFBIZ-7779
> Project: OFBiz
> Issue Type: Task
> Components: Confluence
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
> Attachments: OFBIZ-7779.patch, OFBIZ-7779.patch
>
>
> I wanted to update the 2 wiki Eclipse pages regarding Gradle. But so far got
> some issues in my environment (still Windows 7).
> I use both Eclipse Luna and Mars (Mars at 98%). Luna does not support Gradle.
> First I must say my Mars instance works perfectly, but for few months I'm
> unable to update. I did not try yet to create another Mars instance because I
> guess it will anyway screws its update mechanism later :/
> Mars comes with the embedded ["Gradle Buildship"
> plugin|https://gradle.org/eclipse/], I have the 1.0.5 version from
> 2015-09-22. I found this tuto
> http://www.vogella.com/tutorials/EclipseGradle/article.html (with a 6/7
> clone/redundant section).
> Few remarks: I see no Gradle context menu entrie, maybe due to my unability
> to update Mars, so I'm unable to "add Gradle support to existing Eclipse
> project ". So I created a Gradle "trunk" side project following , but, though
> all work well in command line, in Eclipse building with Gradle does not work.
> I always get
> {code}
> org.gradle.api.tasks.TaskExecutionException: Execution failed for task
> ':compileJava'.
> at
> org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:69)
> at
> org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:46)
> at
> org.gradle.api.internal.tasks.execution.PostExecutionAnalysisTaskExecuter.execute(PostExecutionAnalysisTaskExecuter.java:35)
> at
> org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:64)
> at
> org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:58)
> at
> org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:52)
> at
> org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:52)
> at
> org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:53)
> at
> org.gradle.api.internal.tasks.execution.ExecuteAtMostOnceTaskExecuter.execute(ExecuteAtMostOnceTaskExecuter.java:43)
> at
> org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:203)
> at
> org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:185)
> at
> org.gradle.execution.taskgraph.AbstractTaskPlanExecutor$TaskExecutorWorker.processTask(AbstractTaskPlanExecutor.java:62)
> at
> org.gradle.execution.taskgraph.AbstractTaskPlanExecutor$TaskExecutorWorker.run(AbstractTaskPlanExecutor.java:50)
> at
> org.gradle.execution.taskgraph.DefaultTaskPlanExecutor.process(DefaultTaskPlanExecutor.java:25)
> at
> org.gradle.execution.taskgraph.DefaultTaskGraphExecuter.execute(DefaultTaskGraphExecuter.java:110)
> at
> org.gradle.execution.SelectedTaskExecutionAction.execute(SelectedTaskExecutionAction.java:37)
> at
> org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:37)
> at
> org.gradle.execution.DefaultBuildExecuter.access$000(DefaultBuildExecuter.java:23)
> at
> org.gradle.execution.DefaultBuildExecuter$1.proceed(DefaultBuildExecuter.java:43)
> at
> org.gradle.execution.DryRunBuildExecutionAction.execute(DryRunBuildExecutionAction.java:32)
> at
> org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:37)
> at
> org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:30)
> at
> org.gradle.initialization.DefaultGradleLauncher$4.run(DefaultGradleLauncher.java:158)
> at org.gradle.internal.Factories$1.create(Factories.java:22)
> at
> org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:90)
> at
> org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:52)
> at
> org.gradle.initialization.DefaultGradleLauncher.doBuildStages(DefaultGradleLauncher.java:155)
> at
> org.gradle.initialization
[jira] [Commented] (OFBIZ-7779) Update wiki Eclipse pages regarding Gradle
[ https://issues.apache.org/jira/browse/OFBIZ-7779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372983#comment-15372983 ] Taher Alkhateeb commented on OFBIZ-7779: H strange. I did not know eclipse behaves differently on different platforms as it works fine with Gradle on my Linux machine. I'll try to reproduce on windows on virtualbox to see whats up Either way this patch improves things so I will commit it > Update wiki Eclipse pages regarding Gradle > -- > > Key: OFBIZ-7779 > URL: https://issues.apache.org/jira/browse/OFBIZ-7779 > Project: OFBiz > Issue Type: Task > Components: Confluence >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux > Attachments: OFBIZ-7779.patch, OFBIZ-7779.patch, compile.error, > neon.error > > > I wanted to update the 2 wiki Eclipse pages regarding Gradle. But so far got > some issues in my environment (still Windows 7). > I use both Eclipse Luna and Mars (Mars at 98%). Luna does not support Gradle. > First I must say my Mars instance works perfectly, but for few months I'm > unable to update. I did not try yet to create another Mars instance because I > guess it will anyway screws its update mechanism later :/ > Mars comes with the embedded ["Gradle Buildship" > plugin|https://gradle.org/eclipse/], I have the 1.0.5 version from > 2015-09-22. I found this tuto > http://www.vogella.com/tutorials/EclipseGradle/article.html (with a 6/7 > clone/redundant section). > Few remarks: I see no Gradle context menu entrie, maybe due to my unability > to update Mars, so I'm unable to "add Gradle support to existing Eclipse > project ". So I created a Gradle "trunk" side project following , but, though > all work well in command line, in Eclipse building with Gradle does not work. > I always get (see compile.error) > Of course I tried (4th) to install Eclipse Neon, to no avail, so far the best > I got (at least I eventually got something) is in neon.error > I'll continue later... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374362#comment-15374362 ] Taher Alkhateeb commented on OFBIZ-7534: Hi Charl, As I mentioned in my previous comment, the download targets in apache ant which used to exist in the past only provide the latest JDBC driver for each database. Also, after further investigation, I realized that each database vendor can provide multiple different drivers used for different purposes. So, downloading the correct database driver is environment-centric. That's why in the old Ant scripts you will notice a message if you run one of the download targets that tells you to "Please check that this version is appropriate for you!". Again this shows you that the whole approach is flawed because it is very specific to each computer on each database. Therefore, it is my recommendation that you simply download the required database driver yourself. My recommendation for now is just to place it in /framework/base/lib. Or we can create a new top-level folder (/libs) that holds all user downloaded libraries. What do you think? > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, OFBizRemoteJarList.csv, > OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, > gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374476#comment-15374476 ] Taher Alkhateeb commented on OFBIZ-7534: Hi Pierre, Thank you for the feedback. I repeat what I always mention in these points, if something _did_ exist in the past then it does not mean that it was implemented correctly nor that it was the right thing to do. You can have MySQL of a different version on your computer than a MySQL on my computer. Furthermore, you might choose a driver implementation different from my driver. Another point to add, the download targets were only for MySQL, Postgres and Oracle when more data resources are defined in the entity engine So, the old implementation was not appropriate for each computer and missing databases. Hence it is fragile. As always, I'm not suggesting avoiding implementation due to difficulty (very easy) but due to correctness. If something is too specific to a certain environment, then it is not generic and should not be included. With that being said, we should not leave our users confused, and hence I suggest we provide proper documentation on how to switch to a different database vendor. If we have a well written document then people can understand the general idea but also provide the specifics for their environment. > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, OFBizRemoteJarList.csv, > OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, > gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374491#comment-15374491 ] Taher Alkhateeb commented on OFBIZ-7534: Good point Pierre, also works well. > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, OFBizRemoteJarList.csv, > OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, > gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374584#comment-15374584 ] Taher Alkhateeb commented on OFBIZ-7534: Hi Pierre, Can you give me an example of any external library that is dependent on your environment other than the database libraries so we can have a more general solution? I don't know any other libraries that require you to install certain software of a certain version on your computer. > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, OFBizRemoteJarList.csv, > OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, > gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374628#comment-15374628 ] Taher Alkhateeb commented on OFBIZ-7534: Hi Pierre, You are confusing two completely different things here. Using an older or a newer version of a library for your custom requirements is different from installing a specific version of a software on your computer and downloading the specific library needed for this software which is installed on _your_ computer. You are asking us to download jar files that are totally dependent on YOUR computer. The downloaded version may or may not work on your computer because it depends on the version of the database installed. Hence, there are no other libraries in OFBiz that I am aware of that require installing certain software on your computer. Hence, these libraries are left to the user to determine the best database version. > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, OFBizRemoteJarList.csv, > OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, > gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374744#comment-15374744 ] Taher Alkhateeb commented on OFBIZ-7534: Hi Pierre, I tried to explain this the best I can. If other users are interested after my above explanation and dialog with you then I will happily move things forward. > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, OFBizRemoteJarList.csv, > OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, > gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6274) Rename OFBiz artefacts from 'org.ofbiz.*' to org.apache.ofbiz.*'
[ https://issues.apache.org/jira/browse/OFBIZ-6274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-6274: --- Attachment: RENAME_OFBIZ_TO_APACHE.patch Attaching first attempt Getting some classpath problems, appreciate help > Rename OFBiz artefacts from 'org.ofbiz.*' to org.apache.ofbiz.*' > > > Key: OFBIZ-6274 > URL: https://issues.apache.org/jira/browse/OFBIZ-6274 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Pierre Smits > Attachments: RENAME_OFBIZ_TO_APACHE.patch > > > Currently (a lot of) our java and other artefacts sport the name/reference > 'org.ofbiz'. This should be renamed to 'org.apache.ofbiz' to bring more > consistency across the projects under the Apache umbrella. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7773) createTenant tasks does not ask for parameters
[
https://issues.apache.org/jira/browse/OFBIZ-7773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376505#comment-15376505
]
Taher Alkhateeb commented on OFBIZ-7773:
Hi Pierre,
Sorry maybe I was not very clear. Perhaps the word I should have used is "more
people". I did not hear from anyone else this request so I thought to at least
delay the effort until we resolve the big problems (completing remote
libraries, fixing the org.apache.ofbiz, fixing the directory structure)
I would also happily help Jacques where I can in his above initiatives (GUI or
groovysh). Both solutions seem more appropriate than shell scripts. If you
would like to take an initiative there I would also gladly help you out if you
would like that.
> createTenant tasks does not ask for parameters
> --
>
> Key: OFBIZ-7773
> URL: https://issues.apache.org/jira/browse/OFBIZ-7773
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Blocker
> Attachments: OFBIZ-7773-ofbiz.patch
>
>
> When executing the gradle createTenant tasks, the following error is thrown:
> {code}
> FAILURE: Build failed with an exception.
> * Where:
> Build file '/Users/pierre/dev/ofbiz/ofbiz-gradle/build.gradle' line: 328
> * What went wrong:
> Execution failed for task ':prepareAndValidateTenantArguments'.
> > Project property tenantId is missing
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or
> --debug option to get more log output.
> BUILD FAILED
> {code}
> The function/process is missing the guided-through approach that ./ant
> create-tenant has.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7779) Update wiki Eclipse pages regarding Gradle
[ https://issues.apache.org/jira/browse/OFBIZ-7779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376885#comment-15376885 ] Taher Alkhateeb commented on OFBIZ-7779: What I thought would be a quick fix took me a while and I uncovered a lot of problems in the build script. Anyway, now it is working perfectly on both Windows and Linux after the commit r1752658 with all tests passing. Cheers :) > Update wiki Eclipse pages regarding Gradle > -- > > Key: OFBIZ-7779 > URL: https://issues.apache.org/jira/browse/OFBIZ-7779 > Project: OFBiz > Issue Type: Task > Components: Confluence >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux > Attachments: Image 007.png, OFBIZ-7779.patch, OFBIZ-7779.patch, > compile.error, neon.error > > > I wanted to update the 2 wiki Eclipse pages regarding Gradle. But so far got > some issues in my environment (still Windows 7). > I use both Eclipse Luna and Mars (Mars at 98%). Luna does not support Gradle. > First I must say my Mars instance works perfectly, but for few months I'm > unable to update. I did not try yet to create another Mars instance because I > guess it will anyway screws its update mechanism later :/ > Mars comes with the embedded ["Gradle Buildship" > plugin|https://gradle.org/eclipse/], I have the 1.0.5 version from > 2015-09-22. I found this tuto > http://www.vogella.com/tutorials/EclipseGradle/article.html (with a 6/7 > clone/redundant section). > Few remarks: I see no Gradle context menu entrie, maybe due to my unability > to update Mars, so I'm unable to "add Gradle support to existing Eclipse > project ". So I created a Gradle "trunk" side project following , but, though > all work well in command line, in Eclipse building with Gradle does not work. > I always get (see compile.error) > Of course I tried (4th) to install Eclipse Neon, to no avail, so far the best > I got (at least I eventually got something) is in neon.error > I'll continue later... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15378809#comment-15378809 ] Taher Alkhateeb commented on OFBIZ-7534: Hi Jacques, I believe we definitely have more cases like this one. Now you can go to each library and set the exclusions by hand. However I think the original dependencies and libraries were not properly setup because they were scattered among different components and hand picked by different individuals. Having automatic dependency resolution means you don't worry about what gets pulled. Also the dependencies graph because of the huge number of libraries in OFBiz is very complex. So I would recommend instead of trying to replicate what we had before dependency management we instead focus on actually removing as many libraries as we can. 229 libraries is a number I don't recall seeing in any other project. > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, OFBizRemoteJarList.csv, > OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, > gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15378884#comment-15378884 ] Taher Alkhateeb commented on OFBIZ-7534: Hi Jacques, no I just wanted to break it into newlines. Now that you mentioned it maybe it is better to actually generate html instead? I did it quickly and did not think too much about formatting. > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, OFBizRemoteJarList.csv, > OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, > gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5840) Create bootstrap theme
[ https://issues.apache.org/jira/browse/OFBIZ-5840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379018#comment-15379018 ] Taher Alkhateeb commented on OFBIZ-5840: Hi Jacques and Derek, Maybe what I say is too early, but sharing my thoughts only, I would like to tackle the whole theming system in OFBiz. it is currently poorly designed and not modular or composable and it does not have any standard API. The widgets are not translated to html properly and other problems in the design exist. The changes I would like to introduce probably will not make it to our 16 branch but likely to hit 17 I hope. It depends of course if the community agrees with our proposal and complexity of implementation. > Create bootstrap theme > -- > > Key: OFBIZ-5840 > URL: https://issues.apache.org/jira/browse/OFBIZ-5840 > Project: OFBiz > Issue Type: New Feature > Components: framework, themes >Affects Versions: Bootstrap theme >Reporter: Julien NICOLAS >Assignee: Jacques Le Roux > Labels: bootstrap, theme > Attachments: Facility.PNG, FindAgreement..png, Footer.jpg, > GlobalDecorator.patch, ImprovedFooter.patch, MacroMenuRenderer.patch, > OFBIZ-5840-Menufactory.patch, OFBIZ-5840-Menufactory.patch, > appbar_menu_ftl.patch, bootified.js, bootified_js_screentrans.patch, > bootstrap-theme.zip, bootstrap.zip, bootstrapThemeToTrunk.patch, > calendar.PNG, catalog.png, glyphicons-halflings-regular.zip, > htmlMenuMacroLibrary.patch, lookupField_patch.patch, > pagination_htmlFormMacroLibrary.patch, > panelCollapse_htmlSreenMacroLibrary.patch, party menu tab bar.PNG, > preferences.png, styling_issue_1.png, styling_issue_2.png, > styling_issue_3.png, styling_issue_4.png, styling_issue_5.png, > styling_issue_6.png, styling_issue_7.png, styling_issue_8.png, > styling_issue_9.png, tab-bar.png, workeffort.PNG > > > 1- create a sub-directory called bootstrap under the image webapp to put > the resources over there (js, css and fonts) as indicated earlier by Gavin. > (Julien : not sure about location) > 2- check to make sure that the current version of jQuery is compatible with > the installed version or upgrade it accordingly > 3- Create a new theme based on one of the existing themes as suggested by > Julien and Gavin > 4- Test the theme by switching to it and handle major bugs / issues. > 5- Start to make a few test screens utilizing Bootstrap -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5840) Create bootstrap theme
[ https://issues.apache.org/jira/browse/OFBIZ-5840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379059#comment-15379059 ] Taher Alkhateeb commented on OFBIZ-5840: Hi Michael and Pierre, Agree with both of you. It was only a brain dump, and I am swimming in tough code at the moment. Just wanted to share that it exists in the todo list let's say :) > Create bootstrap theme > -- > > Key: OFBIZ-5840 > URL: https://issues.apache.org/jira/browse/OFBIZ-5840 > Project: OFBiz > Issue Type: New Feature > Components: framework, themes >Affects Versions: Bootstrap theme >Reporter: Julien NICOLAS >Assignee: Jacques Le Roux > Labels: bootstrap, theme > Attachments: Facility.PNG, FindAgreement..png, Footer.jpg, > GlobalDecorator.patch, ImprovedFooter.patch, MacroMenuRenderer.patch, > OFBIZ-5840-Menufactory.patch, OFBIZ-5840-Menufactory.patch, > appbar_menu_ftl.patch, bootified.js, bootified_js_screentrans.patch, > bootstrap-theme.zip, bootstrap.zip, bootstrapThemeToTrunk.patch, > calendar.PNG, catalog.png, glyphicons-halflings-regular.zip, > htmlMenuMacroLibrary.patch, lookupField_patch.patch, > pagination_htmlFormMacroLibrary.patch, > panelCollapse_htmlSreenMacroLibrary.patch, party menu tab bar.PNG, > preferences.png, styling_issue_1.png, styling_issue_2.png, > styling_issue_3.png, styling_issue_4.png, styling_issue_5.png, > styling_issue_6.png, styling_issue_7.png, styling_issue_8.png, > styling_issue_9.png, tab-bar.png, workeffort.PNG > > > 1- create a sub-directory called bootstrap under the image webapp to put > the resources over there (js, css and fonts) as indicated earlier by Gavin. > (Julien : not sure about location) > 2- check to make sure that the current version of jQuery is compatible with > the installed version or upgrade it accordingly > 3- Create a new theme based on one of the existing themes as suggested by > Julien and Gavin > 4- Test the theme by switching to it and handle major bugs / issues. > 5- Start to make a few test screens utilizing Bootstrap -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7795) Clean the tools directory
[ https://issues.apache.org/jira/browse/OFBIZ-7795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379111#comment-15379111 ] Taher Alkhateeb commented on OFBIZ-7795: I think the issue with POS happened after the first commit which introduced remote libraries. So it is one of those "jar dependency hell" problems. It is a good idea either way to remove it from the start component and fix it outside with its own bootstrapping code away from the framework. > Clean the tools directory > - > > Key: OFBIZ-7795 > URL: https://issues.apache.org/jira/browse/OFBIZ-7795 > Project: OFBiz > Issue Type: Sub-task > Components: tools >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux > Fix For: Upcoming Branch > > > Some scripts, at least, are meaningless after the Gradel move. They need to > be amended or removed -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7790) Change the Java Directory Structure to Main and Test
[ https://issues.apache.org/jira/browse/OFBIZ-7790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379450#comment-15379450 ] Taher Alkhateeb commented on OFBIZ-7790: Ok, the first step (introducing src/main/java) is fully implemented in r1752838. The next step is to setup the unit tests > Change the Java Directory Structure to Main and Test > > > Key: OFBIZ-7790 > URL: https://issues.apache.org/jira/browse/OFBIZ-7790 > Project: OFBiz > Issue Type: Improvement >Reporter: Sharan Foga >Assignee: Taher Alkhateeb > > Change of the directory structure so that we can separate the Java files > between main and test. This will help us simplify the implementation of a > testing framework. The new directory structure will be as follows: >componentname/src/main/java >componentname/src/test/java > This JIRA will we used for the migration of all compoenents -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7771) Allow to define which data the loadDefault Gradle task effectively loads
[ https://issues.apache.org/jira/browse/OFBIZ-7771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379959#comment-15379959 ] Taher Alkhateeb commented on OFBIZ-7771: Hello, If all of this is due to the name of the task you know I would rather just rename the task. Let's just use loadData, loadDataSets, or even Pierre's original suggestions. I really would rather just close this JIRA and move on. Note if you actually remove the from entityconfig.xml then you would not be able to load that data as an argument at all. > Allow to define which data the loadDefault Gradle task effectively loads > > > Key: OFBIZ-7771 > URL: https://issues.apache.org/jira/browse/OFBIZ-7771 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Trivial > > The gradle task loadDefault is ambiguous, as it means different things to > different uses. This could lead to a situations where it is used in a wrong > manner, resulting in data being overwritten. > Having a more meaningful name lessens the risk of such situations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7749) iterateOverActiveComponents exists twice
[ https://issues.apache.org/jira/browse/OFBIZ-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379974#comment-15379974 ] Taher Alkhateeb commented on OFBIZ-7749: Hi Pierre, In reply to your comments: The two functions are exactly the same and that is why they have the same name. They do exactly the same thing, but we cannot write them only once (or maybe we there is a workaround in that I'm unaware of yet, feel free to help us). The reason why we cannot is that Gradle runs in three stages, Initialization, Configuration, and Execution. The initialization stage is different from the other stages and cannot reuse code. So build.gradle is not visible to settings.gradle and vice-versa because they are parsed in different time-lines. In most projects this does not happen, but because of the complexity and non-standard directory structure in OFBiz, we needed that same bit of code in both the initialization phase (to create the subprojects) and in the other phases for everything else. I hope this answers your inquiries. > iterateOverActiveComponents exists twice > > > Key: OFBIZ-7749 > URL: https://issues.apache.org/jira/browse/OFBIZ-7749 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Jacques Le Roux > Labels: gradle > > Currently the iterateOverActiveComponents function or tasks exists both in > build.gradle and settings.gradle. > Do we need both? Which one is superfluous? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5840) Create bootstrap theme
[ https://issues.apache.org/jira/browse/OFBIZ-5840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380025#comment-15380025 ] Taher Alkhateeb commented on OFBIZ-5840: Great stuff Paul. Thank you for sharing and best of luck with this work. I hope you'd have time to help us out if we go that route. > Create bootstrap theme > -- > > Key: OFBIZ-5840 > URL: https://issues.apache.org/jira/browse/OFBIZ-5840 > Project: OFBiz > Issue Type: New Feature > Components: framework, themes >Affects Versions: Bootstrap theme >Reporter: Julien NICOLAS >Assignee: Jacques Le Roux > Labels: bootstrap, theme > Attachments: Facility.PNG, FindAgreement..png, Footer.jpg, > GlobalDecorator.patch, ImprovedFooter.patch, MacroMenuRenderer.patch, > OFBIZ-5840-Menufactory.patch, OFBIZ-5840-Menufactory.patch, > appbar_menu_ftl.patch, bootified.js, bootified_js_screentrans.patch, > bootstrap-theme.zip, bootstrap.zip, bootstrapThemeToTrunk.patch, > calendar.PNG, catalog.png, glyphicons-halflings-regular.zip, > htmlMenuMacroLibrary.patch, lookupField_patch.patch, > pagination_htmlFormMacroLibrary.patch, > panelCollapse_htmlSreenMacroLibrary.patch, party menu tab bar.PNG, > preferences.png, styling_issue_1.png, styling_issue_2.png, > styling_issue_3.png, styling_issue_4.png, styling_issue_5.png, > styling_issue_6.png, styling_issue_7.png, styling_issue_8.png, > styling_issue_9.png, tab-bar.png, workeffort.PNG > > > 1- create a sub-directory called bootstrap under the image webapp to put > the resources over there (js, css and fonts) as indicated earlier by Gavin. > (Julien : not sure about location) > 2- check to make sure that the current version of jQuery is compatible with > the installed version or upgrade it accordingly > 3- Create a new theme based on one of the existing themes as suggested by > Julien and Gavin > 4- Test the theme by switching to it and handle major bugs / issues. > 5- Start to make a few test screens utilizing Bootstrap -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7749) iterateOverActiveComponents exists twice
[ https://issues.apache.org/jira/browse/OFBIZ-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380473#comment-15380473 ] Taher Alkhateeb commented on OFBIZ-7749: Fantastic Michael. if all tests pass then please go ahead and commit this. I suggest in line with the old names we used you can call it common.gradle instead. > iterateOverActiveComponents exists twice > > > Key: OFBIZ-7749 > URL: https://issues.apache.org/jira/browse/OFBIZ-7749 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Minor > Labels: gradle > Attachments: OFBIZ-7749.patch > > > Currently the iterateOverActiveComponents function or tasks exists both in > build.gradle and settings.gradle. > Do we need both? Which one is superfluous? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6274) Rename OFBiz artefacts from 'org.ofbiz.*' to org.apache.ofbiz.*'
[ https://issues.apache.org/jira/browse/OFBIZ-6274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381103#comment-15381103 ] Taher Alkhateeb commented on OFBIZ-6274: Thanks to Deepak for committing his work in r1752920 we have now fully converted all artifacts from org.ofbiz to org.apache.ofbiz However, we have a regression that we did not catch the first time (fooled us). The tests are unstable. Sometimes they all pass, and sometimes they crash randomly (I observed 6, 14, and 58 tests crashing at different points). This is probably a minor issue somewhere, but is difficult to track down because the tests fail randomly and so it is hard to tell exactly where the source of the trouble is. Under investigation at the moment. > Rename OFBiz artefacts from 'org.ofbiz.*' to org.apache.ofbiz.*' > > > Key: OFBIZ-6274 > URL: https://issues.apache.org/jira/browse/OFBIZ-6274 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Deepak Dixit > Attachments: RENAME_OFBIZ_TO_APACHE.patch > > > Currently (a lot of) our java and other artefacts sport the name/reference > 'org.ofbiz'. This should be renamed to 'org.apache.ofbiz' to bring more > consistency across the projects under the Apache umbrella. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7790) Change the Java Directory Structure to Main and Test
[ https://issues.apache.org/jira/browse/OFBIZ-7790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381108#comment-15381108 ] Taher Alkhateeb commented on OFBIZ-7790: The unit testing framework task already has a JIRA OFBIZ-7254 and hence we will implement the unit tests over there > Change the Java Directory Structure to Main and Test > > > Key: OFBIZ-7790 > URL: https://issues.apache.org/jira/browse/OFBIZ-7790 > Project: OFBiz > Issue Type: Improvement >Reporter: Sharan Foga >Assignee: Taher Alkhateeb > > Change of the directory structure so that we can separate the Java files > between main and test. This will help us simplify the implementation of a > testing framework. The new directory structure will be as follows: >componentname/src/main/java >componentname/src/test/java > This JIRA will we used for the migration of all compoenents -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7790) Change the Java Directory Structure to Main and Test
[ https://issues.apache.org/jira/browse/OFBIZ-7790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381107#comment-15381107 ] Taher Alkhateeb commented on OFBIZ-7790: The unit testing framework task already has a JIRA OFBIZ-7254 and hence we will implement the unit tests over there > Change the Java Directory Structure to Main and Test > > > Key: OFBIZ-7790 > URL: https://issues.apache.org/jira/browse/OFBIZ-7790 > Project: OFBiz > Issue Type: Improvement >Reporter: Sharan Foga >Assignee: Taher Alkhateeb > > Change of the directory structure so that we can separate the Java files > between main and test. This will help us simplify the implementation of a > testing framework. The new directory structure will be as follows: >componentname/src/main/java >componentname/src/test/java > This JIRA will we used for the migration of all compoenents -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7790) Change the Java Directory Structure to Main and Test
[ https://issues.apache.org/jira/browse/OFBIZ-7790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb closed OFBIZ-7790. -- Resolution: Fixed Fix Version/s: Upcoming Branch The rest of the work for introducing unit tests will happen in OFBIZ-7254 hence closing this task. > Change the Java Directory Structure to Main and Test > > > Key: OFBIZ-7790 > URL: https://issues.apache.org/jira/browse/OFBIZ-7790 > Project: OFBiz > Issue Type: Improvement >Reporter: Sharan Foga >Assignee: Taher Alkhateeb > Fix For: Upcoming Branch > > > Change of the directory structure so that we can separate the Java files > between main and test. This will help us simplify the implementation of a > testing framework. The new directory structure will be as follows: >componentname/src/main/java >componentname/src/test/java > This JIRA will we used for the migration of all compoenents -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6274) Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'
[ https://issues.apache.org/jira/browse/OFBIZ-6274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-6274: --- Summary: Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*' (was: Rename OFBiz artefacts from 'org.ofbiz.*' to org.apache.ofbiz.*') > Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*' > > > Key: OFBIZ-6274 > URL: https://issues.apache.org/jira/browse/OFBIZ-6274 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Deepak Dixit > Attachments: RENAME_OFBIZ_TO_APACHE.patch > > > Currently (a lot of) our java and other artefacts sport the name/reference > 'org.ofbiz'. This should be renamed to 'org.apache.ofbiz' to bring more > consistency across the projects under the Apache umbrella. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6274) Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'
[ https://issues.apache.org/jira/browse/OFBIZ-6274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-6274: --- Description: Currently (a lot of) our java and other artifacts sport the name/reference 'org.ofbiz'. This should be renamed to 'org.apache.ofbiz' to bring more consistency across the projects under the Apache umbrella. (was: Currently (a lot of) our java and other artefacts sport the name/reference 'org.ofbiz'. This should be renamed to 'org.apache.ofbiz' to bring more consistency across the projects under the Apache umbrella.) > Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*' > > > Key: OFBIZ-6274 > URL: https://issues.apache.org/jira/browse/OFBIZ-6274 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Deepak Dixit > Attachments: RENAME_OFBIZ_TO_APACHE.patch > > > Currently (a lot of) our java and other artifacts sport the name/reference > 'org.ofbiz'. This should be renamed to 'org.apache.ofbiz' to bring more > consistency across the projects under the Apache umbrella. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6274) Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'
[ https://issues.apache.org/jira/browse/OFBIZ-6274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-6274: --- Attachment: FIX_LOGGING_OUPUT.patch OK, so the first thing I did (which made things much clearer) is to restore logging to correct output which is as per attached patch > Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*' > > > Key: OFBIZ-6274 > URL: https://issues.apache.org/jira/browse/OFBIZ-6274 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Deepak Dixit > Attachments: FIX_LOGGING_OUPUT.patch, RENAME_OFBIZ_TO_APACHE.patch > > > Currently (a lot of) our java and other artifacts sport the name/reference > 'org.ofbiz'. This should be renamed to 'org.apache.ofbiz' to bring more > consistency across the projects under the Apache umbrella. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6274) Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'
[
https://issues.apache.org/jira/browse/OFBIZ-6274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381119#comment-15381119
]
Taher Alkhateeb commented on OFBIZ-6274:
The first thing I notice in the logs that is different:
{noformat:title=OFBiz log output}
2016-07-17 08:46:23,677 |OFBiz-batch-1|DatabaseUtil
|W| Entity [CurrencyDimension] has no table in the database
2016-07-17 08:46:23,678 |OFBiz-batch-1|DatabaseUtil
|W| Entity [DateDimension] has no table in the database
2016-07-17 08:46:23,678 |OFBiz-batch-1|DatabaseUtil
|W| Entity [InventoryItemFact] has no table in the database
2016-07-17 08:46:23,679 |OFBiz-batch-3|DatabaseUtil
|W| Entity [Component] has no table in the database
{noformat}
> Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'
>
>
> Key: OFBIZ-6274
> URL: https://issues.apache.org/jira/browse/OFBIZ-6274
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Deepak Dixit
> Attachments: FIX_LOGGING_OUPUT.patch, RENAME_OFBIZ_TO_APACHE.patch
>
>
> Currently (a lot of) our java and other artifacts sport the name/reference
> 'org.ofbiz'. This should be renamed to 'org.apache.ofbiz' to bring more
> consistency across the projects under the Apache umbrella.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6274) Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'
[ https://issues.apache.org/jira/browse/OFBIZ-6274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381162#comment-15381162 ] Taher Alkhateeb commented on OFBIZ-6274: Hmmm, something does not feel right about this. We should not have two loggers, we should have only one logger. Having two loggers means the java code (or XML I don't know) is defining it twice. This business of switching to org.apache.ofbiz is proving more complex than on first attempt. > Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*' > > > Key: OFBIZ-6274 > URL: https://issues.apache.org/jira/browse/OFBIZ-6274 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Deepak Dixit > Attachments: FIX_LOGGING_OUPUT.patch, RENAME_OFBIZ_TO_APACHE.patch > > > Currently (a lot of) our java and other artifacts sport the name/reference > 'org.ofbiz'. This should be renamed to 'org.apache.ofbiz' to bring more > consistency across the projects under the Apache umbrella. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6274) Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'
[ https://issues.apache.org/jira/browse/OFBIZ-6274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381209#comment-15381209 ] Taher Alkhateeb commented on OFBIZ-6274: It's not a problem at all, it's only strange that we need to add it now. I would imagine an org.apache logger should not exist, there should only be org.apache.ofbiz or org.ofbiz (on the older revision). Having both means somewhere in the code something is requesting the org.apache when it should instead request org.apache.ofbiz. I could be wrong of course. I see no problem in applying your fix but it means we still did not hit root-cause. > Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*' > > > Key: OFBIZ-6274 > URL: https://issues.apache.org/jira/browse/OFBIZ-6274 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Deepak Dixit > Attachments: FIX_LOGGING_OUPUT.patch, RENAME_OFBIZ_TO_APACHE.patch > > > Currently (a lot of) our java and other artifacts sport the name/reference > 'org.ofbiz'. This should be renamed to 'org.apache.ofbiz' to bring more > consistency across the projects under the Apache umbrella. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6274) Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'
[
https://issues.apache.org/jira/browse/OFBIZ-6274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381235#comment-15381235
]
Taher Alkhateeb commented on OFBIZ-6274:
A now it makes sense. So the rename is adding more because org.apache.ofbiz
is a subset of org.apache. Ok it clicks in place now.
But now I am not sure about your patch, by comparing your work with the older
code isn't order important? Meaning should it not be:
{code: xml}
{code}
Instead of
{code: xml}
...
{code}
> Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'
>
>
> Key: OFBIZ-6274
> URL: https://issues.apache.org/jira/browse/OFBIZ-6274
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Deepak Dixit
> Attachments: FIX_LOGGING_OUPUT.patch, RENAME_OFBIZ_TO_APACHE.patch
>
>
> Currently (a lot of) our java and other artifacts sport the name/reference
> 'org.ofbiz'. This should be renamed to 'org.apache.ofbiz' to bring more
> consistency across the projects under the Apache umbrella.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-6274) Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'
[
https://issues.apache.org/jira/browse/OFBIZ-6274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381235#comment-15381235
]
Taher Alkhateeb edited comment on OFBIZ-6274 at 7/17/16 8:40 AM:
-
A now it makes sense. So the rename is adding more because org.apache.ofbiz
is a subset of org.apache. Ok it clicks in place now.
But now I am not sure about your patch, by comparing your work with the older
code isn't order important? Meaning should it not be:
{code:xml}
{code}
Instead of
{code:xml}
...
{code}
was (Author: taher):
A now it makes sense. So the rename is adding more because org.apache.ofbiz
is a subset of org.apache. Ok it clicks in place now.
But now I am not sure about your patch, by comparing your work with the older
code isn't order important? Meaning should it not be:
{code: xml}
{code}
Instead of
{code:xml}
...
{code}
> Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'
>
>
> Key: OFBIZ-6274
> URL: https://issues.apache.org/jira/browse/OFBIZ-6274
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Deepak Dixit
> Attachments: FIX_LOGGING_OUPUT.patch, RENAME_OFBIZ_TO_APACHE.patch
>
>
> Currently (a lot of) our java and other artifacts sport the name/reference
> 'org.ofbiz'. This should be renamed to 'org.apache.ofbiz' to bring more
> consistency across the projects under the Apache umbrella.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-6274) Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'
[
https://issues.apache.org/jira/browse/OFBIZ-6274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381235#comment-15381235
]
Taher Alkhateeb edited comment on OFBIZ-6274 at 7/17/16 8:39 AM:
-
A now it makes sense. So the rename is adding more because org.apache.ofbiz
is a subset of org.apache. Ok it clicks in place now.
But now I am not sure about your patch, by comparing your work with the older
code isn't order important? Meaning should it not be:
{code: xml}
{code}
Instead of
{code:xml}
...
{code}
was (Author: taher):
A now it makes sense. So the rename is adding more because org.apache.ofbiz
is a subset of org.apache. Ok it clicks in place now.
But now I am not sure about your patch, by comparing your work with the older
code isn't order important? Meaning should it not be:
{code: xml}
{code}
Instead of
{code: xml}
...
{code}
> Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'
>
>
> Key: OFBIZ-6274
> URL: https://issues.apache.org/jira/browse/OFBIZ-6274
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Deepak Dixit
> Attachments: FIX_LOGGING_OUPUT.patch, RENAME_OFBIZ_TO_APACHE.patch
>
>
> Currently (a lot of) our java and other artifacts sport the name/reference
> 'org.ofbiz'. This should be renamed to 'org.apache.ofbiz' to bring more
> consistency across the projects under the Apache umbrella.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6274) Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'
[ https://issues.apache.org/jira/browse/OFBIZ-6274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381260#comment-15381260 ] Taher Alkhateeb commented on OFBIZ-6274: I'm very happy to report that we believe the issue is resolved. The problems we discovered were due to heavy resource usage from logging. The logging system got polluted with too many messages because upon renaming the old logger (org.apache) became the parent of all OFBiz classes (org.apache.ofbiz) so the messages were numerous and causing system strain. 3 tests passed on my computer, 1 on Jacques, and 2 tests passed on the buildbot. I think this marks the issue as resolved :) > Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*' > > > Key: OFBIZ-6274 > URL: https://issues.apache.org/jira/browse/OFBIZ-6274 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Deepak Dixit > Attachments: FIX_LOGGING_OUPUT.patch, RENAME_OFBIZ_TO_APACHE.patch > > > Currently (a lot of) our java and other artifacts sport the name/reference > 'org.ofbiz'. This should be renamed to 'org.apache.ofbiz' to bring more > consistency across the projects under the Apache umbrella. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (OFBIZ-6274) Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'
[ https://issues.apache.org/jira/browse/OFBIZ-6274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb resolved OFBIZ-6274. Resolution: Fixed Fix Version/s: Upcoming Branch This issue is resolved, we should keep it open for a few days just to ensure no further regressions arise. > Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*' > > > Key: OFBIZ-6274 > URL: https://issues.apache.org/jira/browse/OFBIZ-6274 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Deepak Dixit > Fix For: Upcoming Branch > > Attachments: FIX_LOGGING_OUPUT.patch, RENAME_OFBIZ_TO_APACHE.patch > > > Currently (a lot of) our java and other artifacts sport the name/reference > 'org.ofbiz'. This should be renamed to 'org.apache.ofbiz' to bring more > consistency across the projects under the Apache umbrella. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
