[jira] [Commented] (OFBIZ-293) data import - nulling fields impossible
[ https://issues.apache.org/jira/browse/OFBIZ-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14939932#comment-14939932 ] Nicolas Malin commented on OFBIZ-293: - +1, my proposition is an other improvement ;) the Martin's Solution is easier. > data import - nulling fields impossible > --- > > Key: OFBIZ-293 > URL: https://issues.apache.org/jira/browse/OFBIZ-293 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Marco Risaliti >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-293_set-empty-strings-as-null.patch, > ofbiz-293-patch.txt, ofbiz-462-patch.txt > > > It's a copy of the old-jira issue > http://jira.undersunconsulting.com/browse/OFBIZ-462 Tarlika Elisabeth Schmitz > = > I am on rev 5274. > data import from .xml file: empty attributes (e.g. description="") are > ignored and the field retains its former value. > Comment by Chris Juettner [04/Oct/05 01:51 PM] > This patch comments out the check for null or empty values in the data XML > file found by the EntitySaxReader. I also added an additional warning message > in case you do not want to persist empty values to the database but still > would like to know what happened. > Comment by Si Chen [04/Oct/05 01:59 PM] > Chris- > Just a comment: it's very important that a field in the entity engine is set > to null ONLY when the XML file specifically has an empty attribute (ie, > description=""). Otherwise, there's a lot of seed data that is in separate > XML files, and they could overwrite each other. > Comment by Chris Juettner [10/Oct/05 11:56 AM] [ Permlink ] > Si, > I'm not sure I understand your comment about seed data in seperate XML files > overwriting each other. Shouldn't seed data XML files be entity specific? Why > would one seed data XML file overwrite another? > Do you have any comment on what a better solution is for seed data values > that could be empty? > Thanks > Chris -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-293) data import - nulling fields impossible
[ https://issues.apache.org/jira/browse/OFBIZ-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14939986#comment-14939986 ] Jacques Le Roux commented on OFBIZ-293: --- Thanks for feedback Nicolas > data import - nulling fields impossible > --- > > Key: OFBIZ-293 > URL: https://issues.apache.org/jira/browse/OFBIZ-293 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Marco Risaliti >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-293_set-empty-strings-as-null.patch, > ofbiz-293-patch.txt, ofbiz-462-patch.txt > > > It's a copy of the old-jira issue > http://jira.undersunconsulting.com/browse/OFBIZ-462 Tarlika Elisabeth Schmitz > = > I am on rev 5274. > data import from .xml file: empty attributes (e.g. description="") are > ignored and the field retains its former value. > Comment by Chris Juettner [04/Oct/05 01:51 PM] > This patch comments out the check for null or empty values in the data XML > file found by the EntitySaxReader. I also added an additional warning message > in case you do not want to persist empty values to the database but still > would like to know what happened. > Comment by Si Chen [04/Oct/05 01:59 PM] > Chris- > Just a comment: it's very important that a field in the entity engine is set > to null ONLY when the XML file specifically has an empty attribute (ie, > description=""). Otherwise, there's a lot of seed data that is in separate > XML files, and they could overwrite each other. > Comment by Chris Juettner [10/Oct/05 11:56 AM] [ Permlink ] > Si, > I'm not sure I understand your comment about seed data in seperate XML files > overwriting each other. Shouldn't seed data XML files be entity specific? Why > would one seed data XML file overwrite another? > Do you have any comment on what a better solution is for seed data values > that could be empty? > Thanks > Chris -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-293) data import - nulling fields impossible
[ https://issues.apache.org/jira/browse/OFBIZ-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14907096#comment-14907096 ] Jacques Le Roux commented on OFBIZ-293: --- I carefully reviewed propositions/comments by Adrian, Nicolas and Paul above (with corresponding code review) and I must say I agree with Martin. His proposition is simple, neat and fits in the current implementation of handling null fields while importing (see r1425813). So I will commit it soon, except if someone really identifies an issue or propose a better (and still simple ;)) solution. I though still regret that we have this dichotomy with null and null-field (nullField) between Entities and Minilang. It makes things confusing and it would be best if we would have used only one. I guess null, but in my OFBIZ-1602 comment above I wrote that nullField was introduced because of a Freemarker issue with null (I did not research again, I guess I was right then). At least in Minilang having only one form would definitively clarify this aspect. I remember having tried to use "null" instead of "nullField" in a condition-expr and not succeeded when nullField worked. I though can OOTB find condition-exprS using "null" which now makes me doubt :/. And also why not using nullField in if-compare. Also we have this difference in screen/form action? OK, too much for tonight but I feel we are almost there... > data import - nulling fields impossible > --- > > Key: OFBIZ-293 > URL: https://issues.apache.org/jira/browse/OFBIZ-293 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Marco Risaliti >Priority: Minor > Attachments: OFBIZ-293_set-empty-strings-as-null.patch, > ofbiz-293-patch.txt, ofbiz-462-patch.txt > > > It's a copy of the old-jira issue > http://jira.undersunconsulting.com/browse/OFBIZ-462 Tarlika Elisabeth Schmitz > = > I am on rev 5274. > data import from .xml file: empty attributes (e.g. description="") are > ignored and the field retains its former value. > Comment by Chris Juettner [04/Oct/05 01:51 PM] > This patch comments out the check for null or empty values in the data XML > file found by the EntitySaxReader. I also added an additional warning message > in case you do not want to persist empty values to the database but still > would like to know what happened. > Comment by Si Chen [04/Oct/05 01:59 PM] > Chris- > Just a comment: it's very important that a field in the entity engine is set > to null ONLY when the XML file specifically has an empty attribute (ie, > description=""). Otherwise, there's a lot of seed data that is in separate > XML files, and they could overwrite each other. > Comment by Chris Juettner [10/Oct/05 11:56 AM] [ Permlink ] > Si, > I'm not sure I understand your comment about seed data in seperate XML files > overwriting each other. Shouldn't seed data XML files be entity specific? Why > would one seed data XML file overwrite another? > Do you have any comment on what a better solution is for seed data values > that could be empty? > Thanks > Chris -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-293) data import - nulling fields impossible
[ https://issues.apache.org/jira/browse/OFBIZ-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14907098#comment-14907098 ] Jacques Le Roux commented on OFBIZ-293: --- Clarifying these points would also help to fix OFBIZ-4602 > data import - nulling fields impossible > --- > > Key: OFBIZ-293 > URL: https://issues.apache.org/jira/browse/OFBIZ-293 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Marco Risaliti >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-293_set-empty-strings-as-null.patch, > ofbiz-293-patch.txt, ofbiz-462-patch.txt > > > It's a copy of the old-jira issue > http://jira.undersunconsulting.com/browse/OFBIZ-462 Tarlika Elisabeth Schmitz > = > I am on rev 5274. > data import from .xml file: empty attributes (e.g. description="") are > ignored and the field retains its former value. > Comment by Chris Juettner [04/Oct/05 01:51 PM] > This patch comments out the check for null or empty values in the data XML > file found by the EntitySaxReader. I also added an additional warning message > in case you do not want to persist empty values to the database but still > would like to know what happened. > Comment by Si Chen [04/Oct/05 01:59 PM] > Chris- > Just a comment: it's very important that a field in the entity engine is set > to null ONLY when the XML file specifically has an empty attribute (ie, > description=""). Otherwise, there's a lot of seed data that is in separate > XML files, and they could overwrite each other. > Comment by Chris Juettner [10/Oct/05 11:56 AM] [ Permlink ] > Si, > I'm not sure I understand your comment about seed data in seperate XML files > overwriting each other. Shouldn't seed data XML files be entity specific? Why > would one seed data XML file overwrite another? > Do you have any comment on what a better solution is for seed data values > that could be empty? > Thanks > Chris -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-293) data import - nulling fields impossible
[ https://issues.apache.org/jira/browse/OFBIZ-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14904278#comment-14904278 ] Martin Becker commented on OFBIZ-293: - The use of the xsi:nil attribute is basically correct but is no solution for the problem we have to represent NULL values in XML element attributes, used for entity attributes. As I see, the xsi:nil attribute is only for defining a XML element as NULL, in our use case the entity itself. My thought was to improve the current logic without compromising current legacy data and usage. For now, empty string attribute values are ignored when loading XML entity data, that is just not correct. If we treat them as empty string, what would be the most correct solution, we not really gain a functional benefit but need to fix existing entity data files with for example ...parentTypeId=""... in it. For a full update while syncing data over the entity xml mechanism, the current solution with an additional specified action like "REPLACE" meets the requirements and the "XML Standard" by interpreting missing entity field (xml attributes) as NULL values. The gap I want to fill is the default action for loading entity XML data, where only explicitly defined fields are part of an update and there should be the possibility to "clear" single field values. There should only be very rare cases where someone would want to define and insert empty strings instead of NULL. Not even the current logic support this. > data import - nulling fields impossible > --- > > Key: OFBIZ-293 > URL: https://issues.apache.org/jira/browse/OFBIZ-293 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Marco Risaliti >Priority: Minor > Attachments: OFBIZ-293_set-empty-strings-as-null.patch, > ofbiz-293-patch.txt, ofbiz-462-patch.txt > > > It's a copy of the old-jira issue > http://jira.undersunconsulting.com/browse/OFBIZ-462 Tarlika Elisabeth Schmitz > = > I am on rev 5274. > data import from .xml file: empty attributes (e.g. description="") are > ignored and the field retains its former value. > Comment by Chris Juettner [04/Oct/05 01:51 PM] > This patch comments out the check for null or empty values in the data XML > file found by the EntitySaxReader. I also added an additional warning message > in case you do not want to persist empty values to the database but still > would like to know what happened. > Comment by Si Chen [04/Oct/05 01:59 PM] > Chris- > Just a comment: it's very important that a field in the entity engine is set > to null ONLY when the XML file specifically has an empty attribute (ie, > description=""). Otherwise, there's a lot of seed data that is in separate > XML files, and they could overwrite each other. > Comment by Chris Juettner [10/Oct/05 11:56 AM] [ Permlink ] > Si, > I'm not sure I understand your comment about seed data in seperate XML files > overwriting each other. Shouldn't seed data XML files be entity specific? Why > would one seed data XML file overwrite another? > Do you have any comment on what a better solution is for seed data values > that could be empty? > Thanks > Chris -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-293) data import - nulling fields impossible
[ https://issues.apache.org/jira/browse/OFBIZ-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14903008#comment-14903008 ] Jacques Le Roux commented on OFBIZ-293: --- I had assigned myself but unassigned, the reason is my [comment|https://issues.apache.org/jira/browse/OFBIZ-4602?focusedCommentId=13216812=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13216812] I then put in OFBIZ-1602. For now at least, I have other priorities... > data import - nulling fields impossible > --- > > Key: OFBIZ-293 > URL: https://issues.apache.org/jira/browse/OFBIZ-293 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Marco Risaliti >Priority: Minor > Attachments: OFBIZ-293_set-empty-strings-as-null.patch, > ofbiz-293-patch.txt, ofbiz-462-patch.txt > > > It's a copy of the old-jira issue > http://jira.undersunconsulting.com/browse/OFBIZ-462 Tarlika Elisabeth Schmitz > = > I am on rev 5274. > data import from .xml file: empty attributes (e.g. description="") are > ignored and the field retains its former value. > Comment by Chris Juettner [04/Oct/05 01:51 PM] > This patch comments out the check for null or empty values in the data XML > file found by the EntitySaxReader. I also added an additional warning message > in case you do not want to persist empty values to the database but still > would like to know what happened. > Comment by Si Chen [04/Oct/05 01:59 PM] > Chris- > Just a comment: it's very important that a field in the entity engine is set > to null ONLY when the XML file specifically has an empty attribute (ie, > description=""). Otherwise, there's a lot of seed data that is in separate > XML files, and they could overwrite each other. > Comment by Chris Juettner [10/Oct/05 11:56 AM] [ Permlink ] > Si, > I'm not sure I understand your comment about seed data in seperate XML files > overwriting each other. Shouldn't seed data XML files be entity specific? Why > would one seed data XML file overwrite another? > Do you have any comment on what a better solution is for seed data values > that could be empty? > Thanks > Chris -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-293) data import - nulling fields impossible
[
https://issues.apache.org/jira/browse/OFBIZ-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14901905#comment-14901905
]
Paul Foxworthy commented on OFBIZ-293:
--
Please see my discussion in OFBIZ-4602. The canonical XML way to specify a null
value is to use the xsi:nil *attribute* (references to XML standards in
OFBIZ-4602). The content of an element should be *the data*, and no matter what
special value you attempt to reserve (an empty string, "[null]", "{null}", etc)
something will misinterpret that.
> data import - nulling fields impossible
> ---
>
> Key: OFBIZ-293
> URL: https://issues.apache.org/jira/browse/OFBIZ-293
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Marco Risaliti
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-293_set-empty-strings-as-null.patch,
> ofbiz-293-patch.txt, ofbiz-462-patch.txt
>
>
> It's a copy of the old-jira issue
> http://jira.undersunconsulting.com/browse/OFBIZ-462 Tarlika Elisabeth Schmitz
> =
> I am on rev 5274.
> data import from .xml file: empty attributes (e.g. description="") are
> ignored and the field retains its former value.
> Comment by Chris Juettner [04/Oct/05 01:51 PM]
> This patch comments out the check for null or empty values in the data XML
> file found by the EntitySaxReader. I also added an additional warning message
> in case you do not want to persist empty values to the database but still
> would like to know what happened.
> Comment by Si Chen [04/Oct/05 01:59 PM]
> Chris-
> Just a comment: it's very important that a field in the entity engine is set
> to null ONLY when the XML file specifically has an empty attribute (ie,
> description=""). Otherwise, there's a lot of seed data that is in separate
> XML files, and they could overwrite each other.
> Comment by Chris Juettner [10/Oct/05 11:56 AM] [ Permlink ]
> Si,
> I'm not sure I understand your comment about seed data in seperate XML files
> overwriting each other. Shouldn't seed data XML files be entity specific? Why
> would one seed data XML file overwrite another?
> Do you have any comment on what a better solution is for seed data values
> that could be empty?
> Thanks
> Chris
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-293) data import - nulling fields impossible
[
https://issues.apache.org/jira/browse/OFBIZ-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14901311#comment-14901311
]
Nicolas Malin commented on OFBIZ-293:
-
Maybe an other idea to manage null field, would be authorize
FlexibleStringExpender and prepare the context with standard variable. The
result will be as example :
{code:xml}
{code}
> data import - nulling fields impossible
> ---
>
> Key: OFBIZ-293
> URL: https://issues.apache.org/jira/browse/OFBIZ-293
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Marco Risaliti
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-293_set-empty-strings-as-null.patch,
> ofbiz-293-patch.txt, ofbiz-462-patch.txt
>
>
> It's a copy of the old-jira issue
> http://jira.undersunconsulting.com/browse/OFBIZ-462 Tarlika Elisabeth Schmitz
> =
> I am on rev 5274.
> data import from .xml file: empty attributes (e.g. description="") are
> ignored and the field retains its former value.
> Comment by Chris Juettner [04/Oct/05 01:51 PM]
> This patch comments out the check for null or empty values in the data XML
> file found by the EntitySaxReader. I also added an additional warning message
> in case you do not want to persist empty values to the database but still
> would like to know what happened.
> Comment by Si Chen [04/Oct/05 01:59 PM]
> Chris-
> Just a comment: it's very important that a field in the entity engine is set
> to null ONLY when the XML file specifically has an empty attribute (ie,
> description=""). Otherwise, there's a lot of seed data that is in separate
> XML files, and they could overwrite each other.
> Comment by Chris Juettner [10/Oct/05 11:56 AM] [ Permlink ]
> Si,
> I'm not sure I understand your comment about seed data in seperate XML files
> overwriting each other. Shouldn't seed data XML files be entity specific? Why
> would one seed data XML file overwrite another?
> Do you have any comment on what a better solution is for seed data values
> that could be empty?
> Thanks
> Chris
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-293) data import - nulling fields impossible
[ https://issues.apache.org/jira/browse/OFBIZ-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13015379#comment-13015379 ] Jacques Le Roux commented on OFBIZ-293: --- revision 8458 ? data import - nulling fields impossible --- Key: OFBIZ-293 URL: https://issues.apache.org/jira/browse/OFBIZ-293 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Marco Risaliti Priority: Minor Attachments: ofbiz-293-patch.txt, ofbiz-462-patch.txt It's a copy of the old-jira issue http://jira.undersunconsulting.com/browse/OFBIZ-462 Tarlika Elisabeth Schmitz = I am on rev 5274. data import from .xml file: empty attributes (e.g. description=) are ignored and the field retains its former value. AllCommentsWork LogChange History Sort Order: Comment by Chris Juettner [04/Oct/05 01:51 PM] [ Permlink ] This patch comments out the check for null or empty values in the data XML file found by the EntitySaxReader. I also added an additional warning message in case you do not want to persist empty values to the database but still would like to know what happened. Comment by Si Chen [04/Oct/05 01:59 PM] [ Permlink ] Chris- Just a comment: it's very important that a field in the entity engine is set to null ONLY when the XML file specifically has an empty attribute (ie, description=). Otherwise, there's a lot of seed data that is in separate XML files, and they could overwrite each other. Si Comment by Chris Juettner [10/Oct/05 11:56 AM] [ Permlink ] Si, I'm not sure I understand your comment about seed data in seperate XML files overwriting each other. Shouldn't seed data XML files be entity specific? Why would one seed data XML file overwrite another? Do you have any comment on what a better solution is for seed data values that could be empty? Thanks Chris -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-293) data import - nulling fields impossible
[
https://issues.apache.org/jira/browse/OFBIZ-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12661287#action_12661287
]
Adrian Crum commented on OFBIZ-293:
---
What if we used something like description=${null} and modified the reader to
look for that string and treat it as a null value?
data import - nulling fields impossible
---
Key: OFBIZ-293
URL: https://issues.apache.org/jira/browse/OFBIZ-293
Project: OFBiz
Issue Type: Bug
Components: framework
Affects Versions: SVN trunk
Reporter: Marco Risaliti
Priority: Minor
Attachments: ofbiz-462-patch.txt
It's a copy of the old-jira issue
http://jira.undersunconsulting.com/browse/OFBIZ-462 Tarlika Elisabeth Schmitz
=
I am on rev 5274.
data import from .xml file: empty attributes (e.g. description=) are
ignored and the field retains its former value.
AllCommentsWork LogChange History Sort Order:
Comment by Chris Juettner [04/Oct/05 01:51 PM] [ Permlink ]
This patch comments out the check for null or empty values in the data XML
file found by the EntitySaxReader. I also added an additional warning message
in case you do not want to persist empty values to the database but still
would like to know what happened.
Comment by Si Chen [04/Oct/05 01:59 PM] [ Permlink ]
Chris-
Just a comment: it's very important that a field in the entity engine is set
to null ONLY when the XML file specifically has an empty attribute (ie,
description=). Otherwise, there's a lot of seed data that is in separate
XML files, and they could overwrite each other.
Si
Comment by Chris Juettner [10/Oct/05 11:56 AM] [ Permlink ]
Si,
I'm not sure I understand your comment about seed data in seperate XML files
overwriting each other. Shouldn't seed data XML files be entity specific? Why
would one seed data XML file overwrite another?
Do you have any comment on what a better solution is for seed data values
that could be empty?
Thanks
Chris
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-293) data import - nulling fields impossible
[ https://issues.apache.org/jira/browse/OFBIZ-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12661398#action_12661398 ] Hans Bakker commented on OFBIZ-293: --- isn't it so that in minilanguage we can use the environment variable nullField? isn't the same true here? data import - nulling fields impossible --- Key: OFBIZ-293 URL: https://issues.apache.org/jira/browse/OFBIZ-293 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Marco Risaliti Priority: Minor Attachments: ofbiz-462-patch.txt It's a copy of the old-jira issue http://jira.undersunconsulting.com/browse/OFBIZ-462 Tarlika Elisabeth Schmitz = I am on rev 5274. data import from .xml file: empty attributes (e.g. description=) are ignored and the field retains its former value. AllCommentsWork LogChange History Sort Order: Comment by Chris Juettner [04/Oct/05 01:51 PM] [ Permlink ] This patch comments out the check for null or empty values in the data XML file found by the EntitySaxReader. I also added an additional warning message in case you do not want to persist empty values to the database but still would like to know what happened. Comment by Si Chen [04/Oct/05 01:59 PM] [ Permlink ] Chris- Just a comment: it's very important that a field in the entity engine is set to null ONLY when the XML file specifically has an empty attribute (ie, description=). Otherwise, there's a lot of seed data that is in separate XML files, and they could overwrite each other. Si Comment by Chris Juettner [10/Oct/05 11:56 AM] [ Permlink ] Si, I'm not sure I understand your comment about seed data in seperate XML files overwriting each other. Shouldn't seed data XML files be entity specific? Why would one seed data XML file overwrite another? Do you have any comment on what a better solution is for seed data values that could be empty? Thanks Chris -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-293) data import - nulling fields impossible
[ https://issues.apache.org/jira/browse/OFBIZ-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552735 ] Marco Risaliti commented on OFBIZ-293: -- Someone knows if is this still an issue or can I close it ? I'm the reporter only because I have copy it from the old jira issue. data import - nulling fields impossible --- Key: OFBIZ-293 URL: https://issues.apache.org/jira/browse/OFBIZ-293 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Marco Risaliti Priority: Minor Attachments: ofbiz-462-patch.txt It's a copy of the old-jira issue http://jira.undersunconsulting.com/browse/OFBIZ-462 Tarlika Elisabeth Schmitz = I am on rev 5274. data import from .xml file: empty attributes (e.g. description=) are ignored and the field retains its former value. AllCommentsWork LogChange History Sort Order: Comment by Chris Juettner [04/Oct/05 01:51 PM] [ Permlink ] This patch comments out the check for null or empty values in the data XML file found by the EntitySaxReader. I also added an additional warning message in case you do not want to persist empty values to the database but still would like to know what happened. Comment by Si Chen [04/Oct/05 01:59 PM] [ Permlink ] Chris- Just a comment: it's very important that a field in the entity engine is set to null ONLY when the XML file specifically has an empty attribute (ie, description=). Otherwise, there's a lot of seed data that is in separate XML files, and they could overwrite each other. Si Comment by Chris Juettner [10/Oct/05 11:56 AM] [ Permlink ] Si, I'm not sure I understand your comment about seed data in seperate XML files overwriting each other. Shouldn't seed data XML files be entity specific? Why would one seed data XML file overwrite another? Do you have any comment on what a better solution is for seed data values that could be empty? Thanks Chris -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-293) data import - nulling fields impossible
[ https://issues.apache.org/jira/browse/OFBIZ-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552753 ] Jacopo Cappellato commented on OFBIZ-293: - Marco, this is still an open issue... I'd suggest to keep it open. data import - nulling fields impossible --- Key: OFBIZ-293 URL: https://issues.apache.org/jira/browse/OFBIZ-293 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Marco Risaliti Priority: Minor Attachments: ofbiz-462-patch.txt It's a copy of the old-jira issue http://jira.undersunconsulting.com/browse/OFBIZ-462 Tarlika Elisabeth Schmitz = I am on rev 5274. data import from .xml file: empty attributes (e.g. description=) are ignored and the field retains its former value. AllCommentsWork LogChange History Sort Order: Comment by Chris Juettner [04/Oct/05 01:51 PM] [ Permlink ] This patch comments out the check for null or empty values in the data XML file found by the EntitySaxReader. I also added an additional warning message in case you do not want to persist empty values to the database but still would like to know what happened. Comment by Si Chen [04/Oct/05 01:59 PM] [ Permlink ] Chris- Just a comment: it's very important that a field in the entity engine is set to null ONLY when the XML file specifically has an empty attribute (ie, description=). Otherwise, there's a lot of seed data that is in separate XML files, and they could overwrite each other. Si Comment by Chris Juettner [10/Oct/05 11:56 AM] [ Permlink ] Si, I'm not sure I understand your comment about seed data in seperate XML files overwriting each other. Shouldn't seed data XML files be entity specific? Why would one seed data XML file overwrite another? Do you have any comment on what a better solution is for seed data values that could be empty? Thanks Chris -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
