[jira] [Commented] (OFBIZ-382) Implement Party lookup by External Id

2016-06-09 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15322209#comment-15322209
 ] 

Jacques Le Roux commented on OFBIZ-382:
---

That's an interesting point of view Nicolas, thanks!

> Implement Party lookup by External Id
> -
>
> Key: OFBIZ-382
> URL: https://issues.apache.org/jira/browse/OFBIZ-382
> Project: OFBiz
>  Issue Type: New Feature
>  Components: party
>Reporter: John Martin
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-382.patch, OFBIZ-382_new.patch
>
>
> It would be helpful for anyone whom is integrating ofBiz with an external 
> application to be able to expose the externalId property in the Party entity. 
>  
> The tasks to complete include:
> - Update the findparty.ftl to include the prompt/form input field for the 
> external id
> - Update the PartyServices.findParty() method to include the logic to handle 
> the externalId argument
> - Add new method getPartyFromExternalId to PartyServices
> - Add getPartyFromExternalId service definition in Party 
> servicedef/services_view.xml
> - Add misc local strings to UI label resource file
> Need to determine if the External Id: input form field should be 
> configuarable so that it only appears if feature is enabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-382) Implement Party lookup by External Id

2016-06-08 Thread Nicolas Malin (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321361#comment-15321361
 ] 

Nicolas Malin commented on OFBIZ-382:
-

Hello, I don't understand the interest to use an externalId on party while we 
have a partyIdentification entity. 

I think it would be better to use PartyIdentification like GoodIdentification 
from Product to extend the search on external ofbiz id.

[my life] I never realize a project without 3 or 4 different external party 
identification[/my life] so when I see this issue, it's a little bit light on 
comparison with the existing ;)

> Implement Party lookup by External Id
> -
>
> Key: OFBIZ-382
> URL: https://issues.apache.org/jira/browse/OFBIZ-382
> Project: OFBiz
>  Issue Type: New Feature
>  Components: party
>Reporter: John Martin
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-382.patch, OFBIZ-382_new.patch
>
>
> It would be helpful for anyone whom is integrating ofBiz with an external 
> application to be able to expose the externalId property in the Party entity. 
>  
> The tasks to complete include:
> - Update the findparty.ftl to include the prompt/form input field for the 
> external id
> - Update the PartyServices.findParty() method to include the logic to handle 
> the externalId argument
> - Add new method getPartyFromExternalId to PartyServices
> - Add getPartyFromExternalId service definition in Party 
> servicedef/services_view.xml
> - Add misc local strings to UI label resource file
> Need to determine if the External Id: input form field should be 
> configuarable so that it only appears if feature is enabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-382) Implement Party lookup by External Id

2016-06-08 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320591#comment-15320591
 ] 

Deepak Dixit commented on OFBIZ-382:


This has been done at r#1747398

Thanks  John Martin for reporting the issue and Renuka for providing the patch.

> Implement Party lookup by External Id
> -
>
> Key: OFBIZ-382
> URL: https://issues.apache.org/jira/browse/OFBIZ-382
> Project: OFBiz
>  Issue Type: New Feature
>  Components: party
>Reporter: John Martin
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-382.patch, OFBIZ-382_new.patch
>
>
> It would be helpful for anyone whom is integrating ofBiz with an external 
> application to be able to expose the externalId property in the Party entity. 
>  
> The tasks to complete include:
> - Update the findparty.ftl to include the prompt/form input field for the 
> external id
> - Update the PartyServices.findParty() method to include the logic to handle 
> the externalId argument
> - Add new method getPartyFromExternalId to PartyServices
> - Add getPartyFromExternalId service definition in Party 
> servicedef/services_view.xml
> - Add misc local strings to UI label resource file
> Need to determine if the External Id: input form field should be 
> configuarable so that it only appears if feature is enabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-382) Implement Party lookup by External Id

2016-06-08 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320574#comment-15320574
 ] 

Deepak Dixit commented on OFBIZ-382:


Hi Renuka, 

You can  upload patch with same name, jira internally handle it :)

> Implement Party lookup by External Id
> -
>
> Key: OFBIZ-382
> URL: https://issues.apache.org/jira/browse/OFBIZ-382
> Project: OFBiz
>  Issue Type: New Feature
>  Components: party
>Reporter: John Martin
>Assignee: Deepak Dixit
>Priority: Minor
> Attachments: OFBIZ-382.patch, OFBIZ-382_new.patch
>
>
> It would be helpful for anyone whom is integrating ofBiz with an external 
> application to be able to expose the externalId property in the Party entity. 
>  
> The tasks to complete include:
> - Update the findparty.ftl to include the prompt/form input field for the 
> external id
> - Update the PartyServices.findParty() method to include the logic to handle 
> the externalId argument
> - Add new method getPartyFromExternalId to PartyServices
> - Add getPartyFromExternalId service definition in Party 
> servicedef/services_view.xml
> - Add misc local strings to UI label resource file
> Need to determine if the External Id: input form field should be 
> configuarable so that it only appears if feature is enabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)