[jira] [Commented] (OFBIZ-4652) The Label Manager is wrongly overriding CommonEmptyHeader
[ https://issues.apache.org/jira/browse/OFBIZ-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13276550#comment-13276550 ] Jacques Le Roux commented on OFBIZ-4652: Hi Adrian, Answered on de ML :) The Label Manager is wrongly overriding CommonEmptyHeader - Key: OFBIZ-4652 URL: https://issues.apache.org/jira/browse/OFBIZ-4652 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release 09.04, Release 10.04, Release Branch 11.04, SVN trunk Reporter: Jacques Le Roux Assignee: Jacques Le Roux Labels: labe, manager Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04 So xml:lang=en xml:space=preserve is replaced by value xml:lang=en xml:space=preserve/ We shoul also add /value!-- do not remove this! -- to docvument the feature (todo better, more a reminder) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4652) The Label Manager is wrongly overriding CommonEmptyHeader
[ https://issues.apache.org/jira/browse/OFBIZ-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13267277#comment-13267277 ] Jacques Le Roux commented on OFBIZ-4652: Why this label is needed is explained at http://markmail.org/message/42mp6djd546ici7g (part of the thread I referred about above). I think I have an idea to keep CommonEmptyHeader and address this issue. CommonEmptyHeader can be used in other cases and as proven be helpful in some projects already: we should keep it. The Label Manager is wrongly overriding CommonEmptyHeader - Key: OFBIZ-4652 URL: https://issues.apache.org/jira/browse/OFBIZ-4652 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release 09.04, Release 10.04, Release Branch 11.04, SVN trunk Reporter: Jacques Le Roux Labels: labe, manager So xml:lang=en xml:space=preserve is replaced by value xml:lang=en xml:space=preserve/ We shoul also add /value!-- do not remove this! -- to docvument the feature (todo better, more a reminder) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Commented] (OFBIZ-4652) The Label Manager is wrongly overriding CommonEmptyHeader
I use CommenEmptyHeader in overviews where I provide icons as buttons to actions. Regards, Pierre 2012/5/3 Jacques Le Roux (JIRA) j...@apache.org [ https://issues.apache.org/jira/browse/OFBIZ-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13267277#comment-13267277] Jacques Le Roux commented on OFBIZ-4652: Why this label is needed is explained at http://markmail.org/message/42mp6djd546ici7g (part of the thread I referred about above). I think I have an idea to keep CommonEmptyHeader and address this issue. CommonEmptyHeader can be used in other cases and as proven be helpful in some projects already: we should keep it. The Label Manager is wrongly overriding CommonEmptyHeader - Key: OFBIZ-4652 URL: https://issues.apache.org/jira/browse/OFBIZ-4652 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release 09.04, Release 10.04, Release Branch 11.04, SVN trunk Reporter: Jacques Le Roux Labels: labe, manager So xml:lang=en xml:space=preserve is replaced by value xml:lang=en xml:space=preserve/ We shoul also add /value!-- do not remove this! -- to docvument the feature (todo better, more a reminder) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4652) The Label Manager is wrongly overriding CommonEmptyHeader
[ https://issues.apache.org/jira/browse/OFBIZ-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13263675#comment-13263675 ] Jacques Le Roux commented on OFBIZ-4652: We still need a solution here. Else we have a problem when editing a label of CommonUiLabels.xml with the Labels Manager... The Label Manager is wrongly overriding CommonEmptyHeader - Key: OFBIZ-4652 URL: https://issues.apache.org/jira/browse/OFBIZ-4652 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release 09.04, Release 10.04, Release Branch 11.04, SVN trunk Reporter: Jacques Le Roux Labels: labe, manager So xml:lang=en xml:space=preserve is replaced by value xml:lang=en xml:space=preserve/ We shoul also add /value!-- do not remove this! -- to docvument the feature (todo better, more a reminder) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4652) The Label Manager is wrongly overriding CommonEmptyHeader
[ https://issues.apache.org/jira/browse/OFBIZ-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13263682#comment-13263682 ] Adrian Crum commented on OFBIZ-4652: I believe the ideal solution would be to find out why the label is needed, and fix the code that depends on it - so the label is not needed any more. The Label Manager is wrongly overriding CommonEmptyHeader - Key: OFBIZ-4652 URL: https://issues.apache.org/jira/browse/OFBIZ-4652 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release 09.04, Release 10.04, Release Branch 11.04, SVN trunk Reporter: Jacques Le Roux Labels: labe, manager So xml:lang=en xml:space=preserve is replaced by value xml:lang=en xml:space=preserve/ We shoul also add /value!-- do not remove this! -- to docvument the feature (todo better, more a reminder) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4652) The Label Manager is wrongly overriding CommonEmptyHeader
[ https://issues.apache.org/jira/browse/OFBIZ-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13263707#comment-13263707 ] Jacques Le Roux commented on OFBIZ-4652: Yes I tend to agree, I will try to check that... The Label Manager is wrongly overriding CommonEmptyHeader - Key: OFBIZ-4652 URL: https://issues.apache.org/jira/browse/OFBIZ-4652 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release 09.04, Release 10.04, Release Branch 11.04, SVN trunk Reporter: Jacques Le Roux Labels: labe, manager So xml:lang=en xml:space=preserve is replaced by value xml:lang=en xml:space=preserve/ We shoul also add /value!-- do not remove this! -- to docvument the feature (todo better, more a reminder) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4652) The Label Manager is wrongly overriding CommonEmptyHeader
[ https://issues.apache.org/jira/browse/OFBIZ-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13183966#comment-13183966 ] Jacques Le Roux commented on OFBIZ-4652: Yes you are right, it's my own wrong interpretation of http://www.w3.org/TR/REC-xml/#sec-white-space. I thought it would solve the problem at hand, when it actually does anything. This should be specifically handled in Label Manager code. I think it's interesting to keep history here: http://markmail.org/message/nrovxy6zxejjoqfk https://issues.apache.org/jira/browse/OFBIZ-2349 http://svn.apache.org/viewvc?view=revisionrevision=768123 https://issues.apache.org/jira/browse/OFBIZ-2171?focusedCommentId=12671931page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12671931 http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/config/CommonUiLabels.xml?view=diffr1=768194r2=768195pathrev=768195 http://svn.apache.org/viewvc?view=revisionrevision=767845 http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/config/CommonUiLabels.xml?r1=768195r2=768194pathrev=768195 The Label Manager is wrongly overriding CommonEmptyHeader - Key: OFBIZ-4652 URL: https://issues.apache.org/jira/browse/OFBIZ-4652 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release 09.04, Release 10.04, Release Branch 11.04, SVN trunk Reporter: Jacques Le Roux Labels: labe, manager So xml:lang=en xml:space=preserve is replaced by value xml:lang=en xml:space=preserve/ We shoul also add /value!-- do not remove this! -- to docvument the feature (todo better, more a reminder) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4652) The Label Manager is wrongly overriding CommonEmptyHeader
[ https://issues.apache.org/jira/browse/OFBIZ-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13183407#comment-13183407 ] Adrian Crum commented on OFBIZ-4652: I never understood the point of the CommonEmptyHeader property. If the only value it will ever contain is a single space, then why not use a single space instead of a UI label property? The Label Manager is wrongly overriding CommonEmptyHeader - Key: OFBIZ-4652 URL: https://issues.apache.org/jira/browse/OFBIZ-4652 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release 09.04, Release 10.04, Release Branch 11.04, SVN trunk Reporter: Jacques Le Roux Labels: labe, manager So xml:lang=en xml:space=preserve is replaced by value xml:lang=en xml:space=preserve/ We shoul also add /value!-- do not remove this! -- to docvument the feature (todo better, more a reminder) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
