[jira] [Commented] (OFBIZ-5364) Incorrect quantityNotAvailable for OrderItemShipGrpInvRes when issuing items to shipments

2015-01-31 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14299776#comment-14299776
 ] 

Jacques Le Roux commented on OFBIZ-5364:


I received Youseef's answer by mail, in French. Here is the translation.
{quote]
Good evening Jacques;
I do not know when I will have access to JIRA, I live answers you and apologize!

The answer is yes, this patch fixes the problem from a functional point of view 
and consequently the JUnit test in question.

In fact, functionally speaking, I think the previous patch is not good in 
measure or it does not take into account that an OrderItem might use several 
lines of stock InventoryItem.
orderId orderItemSeqId  orderItemShipGrpSeqId   InvetoryItemId
1   01  1   01
1   01  10001   01

So by making a stock exit (ItemIssuance) we can afford to cancel the 
reservation lines for the line of stock in question but not all the lines of 
stock.
That's why I added the lines in the inventoryItemId research question and then 
cancel a reservation!

I think I'm clear.

Thank you and sorry again for my email.
{quote]

 Incorrect quantityNotAvailable for OrderItemShipGrpInvRes when issuing items 
 to shipments
 -

 Key: OFBIZ-5364
 URL: https://issues.apache.org/jira/browse/OFBIZ-5364
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: Release Branch 12.04
Reporter: Christian Carlow
Assignee: Ashish Vijaywargiya
 Attachments: OFBIZ-5364-1.patch, OFBIZ-5364.patch


 The quantityNotAvailable field of OrderItemShipGrpRes seems to reflect 
 incorrect numbers after shipment issuances occur.
 To reproduct:
 1.  Create an order for DemoCustCompany for a quantity of 100 of a product 
 having no inventory quantity 
 2.  Create a second ship group on the Shipping page
 3.  Assign half of the order item quantity (50) to the second ship group 
 created and then finish creating the order
 4.  Click the New Shipment for Ship Group button for the first ship group 
 and navigate to the Order Items page
 5.  On the Order Items page, notice the issue quantity field is blank 
 because no inventory exist yet to be issued to the shipment.  
 6.  Navigate to the WebstoreWarehouse Receive Inventory page and receive a 
 quantity of 1 for the order item product to increase the inventory by 1
 7.  Refresh the Shipment Order Items page and you'll see the issue quantity 
 change to 1 because the inventoryItemId created in the last step was assigned 
 to the orderItemShipGrpInvRes for this item.
 8.  Now change from ship group 1 to ship group 2 and notice the issue 
 quantity is blank
 9.  Assign a quantity of 1 to the second ship group and click the Issue All 
 button
 10.  Change the ship group back to 1 and notice the quantity in the issue 
 text box is still 1
 It seems like the issue text box in step 10 should be 0 instead of 1 since 
 the inventory item quantity was used for ship group 2.  
 Does anyone disagree?  Could I be misinterpreting the way the 
 OrderItemShipGrpInvRes is supposed to work?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-5364) Incorrect quantityNotAvailable for OrderItemShipGrpInvRes when issuing items to shipments

2015-01-28 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295870#comment-14295870
 ] 

Jacques Le Roux commented on OFBIZ-5364:


Hi Youssef,

Did your patch fixes the testMultipleInventoryItemIssuance test failure?

 Incorrect quantityNotAvailable for OrderItemShipGrpInvRes when issuing items 
 to shipments
 -

 Key: OFBIZ-5364
 URL: https://issues.apache.org/jira/browse/OFBIZ-5364
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: Release Branch 12.04
Reporter: Christian Carlow
Assignee: Ashish Vijaywargiya
 Attachments: OFBIZ-5364-1.patch, OFBIZ-5364.patch


 The quantityNotAvailable field of OrderItemShipGrpRes seems to reflect 
 incorrect numbers after shipment issuances occur.
 To reproduct:
 1.  Create an order for DemoCustCompany for a quantity of 100 of a product 
 having no inventory quantity 
 2.  Create a second ship group on the Shipping page
 3.  Assign half of the order item quantity (50) to the second ship group 
 created and then finish creating the order
 4.  Click the New Shipment for Ship Group button for the first ship group 
 and navigate to the Order Items page
 5.  On the Order Items page, notice the issue quantity field is blank 
 because no inventory exist yet to be issued to the shipment.  
 6.  Navigate to the WebstoreWarehouse Receive Inventory page and receive a 
 quantity of 1 for the order item product to increase the inventory by 1
 7.  Refresh the Shipment Order Items page and you'll see the issue quantity 
 change to 1 because the inventoryItemId created in the last step was assigned 
 to the orderItemShipGrpInvRes for this item.
 8.  Now change from ship group 1 to ship group 2 and notice the issue 
 quantity is blank
 9.  Assign a quantity of 1 to the second ship group and click the Issue All 
 button
 10.  Change the ship group back to 1 and notice the quantity in the issue 
 text box is still 1
 It seems like the issue text box in step 10 should be 0 instead of 1 since 
 the inventory item quantity was used for ship group 2.  
 Does anyone disagree?  Could I be misinterpreting the way the 
 OrderItemShipGrpInvRes is supposed to work?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-5364) Incorrect quantityNotAvailable for OrderItemShipGrpInvRes when issuing items to shipments

2015-01-21 Thread youssef khaye (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14285823#comment-14285823
 ] 

youssef khaye commented on OFBIZ-5364:
--

I'am trying to fix the testMultipleInventoryItemIssuance test failure and i 
came across current Issue.

I'am not so good at business rule, But I don't think we have the good solution 
for this Issue ( cancel OISGIR and recreate theme).

This issue occurs when we issue an inventory item from one ship group to 
another ship group

To fix this I suggest to add the ineventoryItemId when selecting OISGIRs to 
cancel  reserve
 
look to attached patch OFBIZ-5364-1.patch


 Incorrect quantityNotAvailable for OrderItemShipGrpInvRes when issuing items 
 to shipments
 -

 Key: OFBIZ-5364
 URL: https://issues.apache.org/jira/browse/OFBIZ-5364
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: Release Branch 12.04
Reporter: Christian Carlow
Assignee: Ashish Vijaywargiya
 Attachments: OFBIZ-5364-1.patch, OFBIZ-5364.patch


 The quantityNotAvailable field of OrderItemShipGrpRes seems to reflect 
 incorrect numbers after shipment issuances occur.
 To reproduct:
 1.  Create an order for DemoCustCompany for a quantity of 100 of a product 
 having no inventory quantity 
 2.  Create a second ship group on the Shipping page
 3.  Assign half of the order item quantity (50) to the second ship group 
 created and then finish creating the order
 4.  Click the New Shipment for Ship Group button for the first ship group 
 and navigate to the Order Items page
 5.  On the Order Items page, notice the issue quantity field is blank 
 because no inventory exist yet to be issued to the shipment.  
 6.  Navigate to the WebstoreWarehouse Receive Inventory page and receive a 
 quantity of 1 for the order item product to increase the inventory by 1
 7.  Refresh the Shipment Order Items page and you'll see the issue quantity 
 change to 1 because the inventoryItemId created in the last step was assigned 
 to the orderItemShipGrpInvRes for this item.
 8.  Now change from ship group 1 to ship group 2 and notice the issue 
 quantity is blank
 9.  Assign a quantity of 1 to the second ship group and click the Issue All 
 button
 10.  Change the ship group back to 1 and notice the quantity in the issue 
 text box is still 1
 It seems like the issue text box in step 10 should be 0 instead of 1 since 
 the inventory item quantity was used for ship group 2.  
 Does anyone disagree?  Could I be misinterpreting the way the 
 OrderItemShipGrpInvRes is supposed to work?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-5364) Incorrect quantityNotAvailable for OrderItemShipGrpInvRes when issuing items to shipments

2015-01-19 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282722#comment-14282722
 ] 

Jacques Le Roux commented on OFBIZ-5364:


I have temporary removed (commented out) the testMultipleInventoryItemIssuance 
test after r1649408 and r1650455 in trunk at r1653056

 Incorrect quantityNotAvailable for OrderItemShipGrpInvRes when issuing items 
 to shipments
 -

 Key: OFBIZ-5364
 URL: https://issues.apache.org/jira/browse/OFBIZ-5364
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: Release Branch 12.04
Reporter: Christian Carlow
Assignee: Ashish Vijaywargiya
 Attachments: OFBIZ-5364.patch


 The quantityNotAvailable field of OrderItemShipGrpRes seems to reflect 
 incorrect numbers after shipment issuances occur.
 To reproduct:
 1.  Create an order for DemoCustCompany for a quantity of 100 of a product 
 having no inventory quantity 
 2.  Create a second ship group on the Shipping page
 3.  Assign half of the order item quantity (50) to the second ship group 
 created and then finish creating the order
 4.  Click the New Shipment for Ship Group button for the first ship group 
 and navigate to the Order Items page
 5.  On the Order Items page, notice the issue quantity field is blank 
 because no inventory exist yet to be issued to the shipment.  
 6.  Navigate to the WebstoreWarehouse Receive Inventory page and receive a 
 quantity of 1 for the order item product to increase the inventory by 1
 7.  Refresh the Shipment Order Items page and you'll see the issue quantity 
 change to 1 because the inventoryItemId created in the last step was assigned 
 to the orderItemShipGrpInvRes for this item.
 8.  Now change from ship group 1 to ship group 2 and notice the issue 
 quantity is blank
 9.  Assign a quantity of 1 to the second ship group and click the Issue All 
 button
 10.  Change the ship group back to 1 and notice the quantity in the issue 
 text box is still 1
 It seems like the issue text box in step 10 should be 0 instead of 1 since 
 the inventory item quantity was used for ship group 2.  
 Does anyone disagree?  Could I be misinterpreting the way the 
 OrderItemShipGrpInvRes is supposed to work?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-5364) Incorrect quantityNotAvailable for OrderItemShipGrpInvRes when issuing items to shipments

2015-01-05 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14264635#comment-14264635
 ] 

Jacques Le Roux commented on OFBIZ-5364:


This does not pass tests, http://ci.apache.org/projects/ofbiz/logs/trunk/html/ 
I take over...

 Incorrect quantityNotAvailable for OrderItemShipGrpInvRes when issuing items 
 to shipments
 -

 Key: OFBIZ-5364
 URL: https://issues.apache.org/jira/browse/OFBIZ-5364
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: Release Branch 12.04
Reporter: Christian Carlow
Assignee: Jacques Le Roux
 Attachments: OFBIZ-5364.patch


 The quantityNotAvailable field of OrderItemShipGrpRes seems to reflect 
 incorrect numbers after shipment issuances occur.
 To reproduct:
 1.  Create an order for DemoCustCompany for a quantity of 100 of a product 
 having no inventory quantity 
 2.  Create a second ship group on the Shipping page
 3.  Assign half of the order item quantity (50) to the second ship group 
 created and then finish creating the order
 4.  Click the New Shipment for Ship Group button for the first ship group 
 and navigate to the Order Items page
 5.  On the Order Items page, notice the issue quantity field is blank 
 because no inventory exist yet to be issued to the shipment.  
 6.  Navigate to the WebstoreWarehouse Receive Inventory page and receive a 
 quantity of 1 for the order item product to increase the inventory by 1
 7.  Refresh the Shipment Order Items page and you'll see the issue quantity 
 change to 1 because the inventoryItemId created in the last step was assigned 
 to the orderItemShipGrpInvRes for this item.
 8.  Now change from ship group 1 to ship group 2 and notice the issue 
 quantity is blank
 9.  Assign a quantity of 1 to the second ship group and click the Issue All 
 button
 10.  Change the ship group back to 1 and notice the quantity in the issue 
 text box is still 1
 It seems like the issue text box in step 10 should be 0 instead of 1 since 
 the inventory item quantity was used for ship group 2.  
 Does anyone disagree?  Could I be misinterpreting the way the 
 OrderItemShipGrpInvRes is supposed to work?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-5364) Incorrect quantityNotAvailable for OrderItemShipGrpInvRes when issuing items to shipments

2015-01-05 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14264637#comment-14264637
 ] 

Jacques Le Roux commented on OFBIZ-5364:


orderHeader.originFacilityId might be empty

 Incorrect quantityNotAvailable for OrderItemShipGrpInvRes when issuing items 
 to shipments
 -

 Key: OFBIZ-5364
 URL: https://issues.apache.org/jira/browse/OFBIZ-5364
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: Release Branch 12.04
Reporter: Christian Carlow
Assignee: Jacques Le Roux
 Attachments: OFBIZ-5364.patch


 The quantityNotAvailable field of OrderItemShipGrpRes seems to reflect 
 incorrect numbers after shipment issuances occur.
 To reproduct:
 1.  Create an order for DemoCustCompany for a quantity of 100 of a product 
 having no inventory quantity 
 2.  Create a second ship group on the Shipping page
 3.  Assign half of the order item quantity (50) to the second ship group 
 created and then finish creating the order
 4.  Click the New Shipment for Ship Group button for the first ship group 
 and navigate to the Order Items page
 5.  On the Order Items page, notice the issue quantity field is blank 
 because no inventory exist yet to be issued to the shipment.  
 6.  Navigate to the WebstoreWarehouse Receive Inventory page and receive a 
 quantity of 1 for the order item product to increase the inventory by 1
 7.  Refresh the Shipment Order Items page and you'll see the issue quantity 
 change to 1 because the inventoryItemId created in the last step was assigned 
 to the orderItemShipGrpInvRes for this item.
 8.  Now change from ship group 1 to ship group 2 and notice the issue 
 quantity is blank
 9.  Assign a quantity of 1 to the second ship group and click the Issue All 
 button
 10.  Change the ship group back to 1 and notice the quantity in the issue 
 text box is still 1
 It seems like the issue text box in step 10 should be 0 instead of 1 since 
 the inventory item quantity was used for ship group 2.  
 Does anyone disagree?  Could I be misinterpreting the way the 
 OrderItemShipGrpInvRes is supposed to work?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-5364) Incorrect quantityNotAvailable for OrderItemShipGrpInvRes when issuing items to shipments

2015-01-05 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14264675#comment-14264675
 ] 

Jacques Le Roux commented on OFBIZ-5364:


I will revert from R14.12 only for now...

 Incorrect quantityNotAvailable for OrderItemShipGrpInvRes when issuing items 
 to shipments
 -

 Key: OFBIZ-5364
 URL: https://issues.apache.org/jira/browse/OFBIZ-5364
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: Release Branch 12.04
Reporter: Christian Carlow
Assignee: Ashish Vijaywargiya
 Attachments: OFBIZ-5364.patch


 The quantityNotAvailable field of OrderItemShipGrpRes seems to reflect 
 incorrect numbers after shipment issuances occur.
 To reproduct:
 1.  Create an order for DemoCustCompany for a quantity of 100 of a product 
 having no inventory quantity 
 2.  Create a second ship group on the Shipping page
 3.  Assign half of the order item quantity (50) to the second ship group 
 created and then finish creating the order
 4.  Click the New Shipment for Ship Group button for the first ship group 
 and navigate to the Order Items page
 5.  On the Order Items page, notice the issue quantity field is blank 
 because no inventory exist yet to be issued to the shipment.  
 6.  Navigate to the WebstoreWarehouse Receive Inventory page and receive a 
 quantity of 1 for the order item product to increase the inventory by 1
 7.  Refresh the Shipment Order Items page and you'll see the issue quantity 
 change to 1 because the inventoryItemId created in the last step was assigned 
 to the orderItemShipGrpInvRes for this item.
 8.  Now change from ship group 1 to ship group 2 and notice the issue 
 quantity is blank
 9.  Assign a quantity of 1 to the second ship group and click the Issue All 
 button
 10.  Change the ship group back to 1 and notice the quantity in the issue 
 text box is still 1
 It seems like the issue text box in step 10 should be 0 instead of 1 since 
 the inventory item quantity was used for ship group 2.  
 Does anyone disagree?  Could I be misinterpreting the way the 
 OrderItemShipGrpInvRes is supposed to work?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-5364) Incorrect quantityNotAvailable for OrderItemShipGrpInvRes when issuing items to shipments

2015-01-05 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14264687#comment-14264687
 ] 

Jacques Le Roux commented on OFBIZ-5364:


I reverted r1649408 at r1649549. I will soon add the test for R14.12 on 
Buildbot...

 Incorrect quantityNotAvailable for OrderItemShipGrpInvRes when issuing items 
 to shipments
 -

 Key: OFBIZ-5364
 URL: https://issues.apache.org/jira/browse/OFBIZ-5364
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: Release Branch 12.04
Reporter: Christian Carlow
Assignee: Ashish Vijaywargiya
 Attachments: OFBIZ-5364.patch


 The quantityNotAvailable field of OrderItemShipGrpRes seems to reflect 
 incorrect numbers after shipment issuances occur.
 To reproduct:
 1.  Create an order for DemoCustCompany for a quantity of 100 of a product 
 having no inventory quantity 
 2.  Create a second ship group on the Shipping page
 3.  Assign half of the order item quantity (50) to the second ship group 
 created and then finish creating the order
 4.  Click the New Shipment for Ship Group button for the first ship group 
 and navigate to the Order Items page
 5.  On the Order Items page, notice the issue quantity field is blank 
 because no inventory exist yet to be issued to the shipment.  
 6.  Navigate to the WebstoreWarehouse Receive Inventory page and receive a 
 quantity of 1 for the order item product to increase the inventory by 1
 7.  Refresh the Shipment Order Items page and you'll see the issue quantity 
 change to 1 because the inventoryItemId created in the last step was assigned 
 to the orderItemShipGrpInvRes for this item.
 8.  Now change from ship group 1 to ship group 2 and notice the issue 
 quantity is blank
 9.  Assign a quantity of 1 to the second ship group and click the Issue All 
 button
 10.  Change the ship group back to 1 and notice the quantity in the issue 
 text box is still 1
 It seems like the issue text box in step 10 should be 0 instead of 1 since 
 the inventory item quantity was used for ship group 2.  
 Does anyone disagree?  Could I be misinterpreting the way the 
 OrderItemShipGrpInvRes is supposed to work?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-5364) Incorrect quantityNotAvailable for OrderItemShipGrpInvRes when issuing items to shipments

2015-01-04 Thread Ashish Vijaywargiya (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14263989#comment-14263989
 ] 

Ashish Vijaywargiya commented on OFBIZ-5364:


Thanks Christian for creating the jira issue. Thanks Swapnil for providing the 
additional details, Thanks Divesh for the patch. For now I have committed 
changes in trunk(r1649405) and in Branch14.12(r1649408). For now I am keeping 
this issue open, will cross check this issue in R13.07 and if it does exists 
there then I will back port the changes over there as well. 

 Incorrect quantityNotAvailable for OrderItemShipGrpInvRes when issuing items 
 to shipments
 -

 Key: OFBIZ-5364
 URL: https://issues.apache.org/jira/browse/OFBIZ-5364
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: Release Branch 12.04
Reporter: Christian Carlow
Assignee: Ashish Vijaywargiya
 Attachments: OFBIZ-5364.patch


 The quantityNotAvailable field of OrderItemShipGrpRes seems to reflect 
 incorrect numbers after shipment issuances occur.
 To reproduct:
 1.  Create an order for DemoCustCompany for a quantity of 100 of a product 
 having no inventory quantity 
 2.  Create a second ship group on the Shipping page
 3.  Assign half of the order item quantity (50) to the second ship group 
 created and then finish creating the order
 4.  Click the New Shipment for Ship Group button for the first ship group 
 and navigate to the Order Items page
 5.  On the Order Items page, notice the issue quantity field is blank 
 because no inventory exist yet to be issued to the shipment.  
 6.  Navigate to the WebstoreWarehouse Receive Inventory page and receive a 
 quantity of 1 for the order item product to increase the inventory by 1
 7.  Refresh the Shipment Order Items page and you'll see the issue quantity 
 change to 1 because the inventoryItemId created in the last step was assigned 
 to the orderItemShipGrpInvRes for this item.
 8.  Now change from ship group 1 to ship group 2 and notice the issue 
 quantity is blank
 9.  Assign a quantity of 1 to the second ship group and click the Issue All 
 button
 10.  Change the ship group back to 1 and notice the quantity in the issue 
 text box is still 1
 It seems like the issue text box in step 10 should be 0 instead of 1 since 
 the inventory item quantity was used for ship group 2.  
 Does anyone disagree?  Could I be misinterpreting the way the 
 OrderItemShipGrpInvRes is supposed to work?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-5364) Incorrect quantityNotAvailable for OrderItemShipGrpInvRes when issuing items to shipments

2015-01-04 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14264273#comment-14264273
 ] 

Divesh Dutta commented on OFBIZ-5364:
-

This fix should be pushed to R13.07 as well. Thanks Ashish for committing the 
patch in in trunk and in Branch14.12

 Incorrect quantityNotAvailable for OrderItemShipGrpInvRes when issuing items 
 to shipments
 -

 Key: OFBIZ-5364
 URL: https://issues.apache.org/jira/browse/OFBIZ-5364
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: Release Branch 12.04
Reporter: Christian Carlow
Assignee: Ashish Vijaywargiya
 Attachments: OFBIZ-5364.patch


 The quantityNotAvailable field of OrderItemShipGrpRes seems to reflect 
 incorrect numbers after shipment issuances occur.
 To reproduct:
 1.  Create an order for DemoCustCompany for a quantity of 100 of a product 
 having no inventory quantity 
 2.  Create a second ship group on the Shipping page
 3.  Assign half of the order item quantity (50) to the second ship group 
 created and then finish creating the order
 4.  Click the New Shipment for Ship Group button for the first ship group 
 and navigate to the Order Items page
 5.  On the Order Items page, notice the issue quantity field is blank 
 because no inventory exist yet to be issued to the shipment.  
 6.  Navigate to the WebstoreWarehouse Receive Inventory page and receive a 
 quantity of 1 for the order item product to increase the inventory by 1
 7.  Refresh the Shipment Order Items page and you'll see the issue quantity 
 change to 1 because the inventoryItemId created in the last step was assigned 
 to the orderItemShipGrpInvRes for this item.
 8.  Now change from ship group 1 to ship group 2 and notice the issue 
 quantity is blank
 9.  Assign a quantity of 1 to the second ship group and click the Issue All 
 button
 10.  Change the ship group back to 1 and notice the quantity in the issue 
 text box is still 1
 It seems like the issue text box in step 10 should be 0 instead of 1 since 
 the inventory item quantity was used for ship group 2.  
 Does anyone disagree?  Could I be misinterpreting the way the 
 OrderItemShipGrpInvRes is supposed to work?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-5364) Incorrect quantityNotAvailable for OrderItemShipGrpInvRes when issuing items to shipments

2014-12-29 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14260088#comment-14260088
 ] 

Divesh Dutta commented on OFBIZ-5364:
-

Here is the attached patch which will fix this issue. So once the items are 
issued from one ship group to another, item issuance are created, 
OrderItemShipGrpInvRes is updated with new quantity and inventoryItemDetail 
records are updated. After all this we have cancelled reservations of 
respective OrderItemShipGrpInvRes and re-reserved it. Doing this will balance 
reservations in respective OrderItemShipGrpInvRes .



 Incorrect quantityNotAvailable for OrderItemShipGrpInvRes when issuing items 
 to shipments
 -

 Key: OFBIZ-5364
 URL: https://issues.apache.org/jira/browse/OFBIZ-5364
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: Release Branch 12.04
Reporter: Christian Carlow
 Attachments: OFBIZ-5364.patch


 The quantityNotAvailable field of OrderItemShipGrpRes seems to reflect 
 incorrect numbers after shipment issuances occur.
 To reproduct:
 1.  Create an order for DemoCustCompany for a quantity of 100 of a product 
 having no inventory quantity 
 2.  Create a second ship group on the Shipping page
 3.  Assign half of the order item quantity (50) to the second ship group 
 created and then finish creating the order
 4.  Click the New Shipment for Ship Group button for the first ship group 
 and navigate to the Order Items page
 5.  On the Order Items page, notice the issue quantity field is blank 
 because no inventory exist yet to be issued to the shipment.  
 6.  Navigate to the WebstoreWarehouse Receive Inventory page and receive a 
 quantity of 1 for the order item product to increase the inventory by 1
 7.  Refresh the Shipment Order Items page and you'll see the issue quantity 
 change to 1 because the inventoryItemId created in the last step was assigned 
 to the orderItemShipGrpInvRes for this item.
 8.  Now change from ship group 1 to ship group 2 and notice the issue 
 quantity is blank
 9.  Assign a quantity of 1 to the second ship group and click the Issue All 
 button
 10.  Change the ship group back to 1 and notice the quantity in the issue 
 text box is still 1
 It seems like the issue text box in step 10 should be 0 instead of 1 since 
 the inventory item quantity was used for ship group 2.  
 Does anyone disagree?  Could I be misinterpreting the way the 
 OrderItemShipGrpInvRes is supposed to work?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-5364) Incorrect quantityNotAvailable for OrderItemShipGrpInvRes when issuing items to shipments

2014-12-24 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14258278#comment-14258278
 ] 

Divesh Dutta commented on OFBIZ-5364:
-

Christian ,

The issue you reported is right and it exists . Also thanks to Swapnil for 
giving the detailed analysis on where things are going wrong. Just so every one 
know, I am working on fix of this issue. 

 Incorrect quantityNotAvailable for OrderItemShipGrpInvRes when issuing items 
 to shipments
 -

 Key: OFBIZ-5364
 URL: https://issues.apache.org/jira/browse/OFBIZ-5364
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: Release Branch 12.04
Reporter: Christian Carlow

 The quantityNotAvailable field of OrderItemShipGrpRes seems to reflect 
 incorrect numbers after shipment issuances occur.
 To reproduct:
 1.  Create an order for DemoCustCompany for a quantity of 100 of a product 
 having no inventory quantity 
 2.  Create a second ship group on the Shipping page
 3.  Assign half of the order item quantity (50) to the second ship group 
 created and then finish creating the order
 4.  Click the New Shipment for Ship Group button for the first ship group 
 and navigate to the Order Items page
 5.  On the Order Items page, notice the issue quantity field is blank 
 because no inventory exist yet to be issued to the shipment.  
 6.  Navigate to the WebstoreWarehouse Receive Inventory page and receive a 
 quantity of 1 for the order item product to increase the inventory by 1
 7.  Refresh the Shipment Order Items page and you'll see the issue quantity 
 change to 1 because the inventoryItemId created in the last step was assigned 
 to the orderItemShipGrpInvRes for this item.
 8.  Now change from ship group 1 to ship group 2 and notice the issue 
 quantity is blank
 9.  Assign a quantity of 1 to the second ship group and click the Issue All 
 button
 10.  Change the ship group back to 1 and notice the quantity in the issue 
 text box is still 1
 It seems like the issue text box in step 10 should be 0 instead of 1 since 
 the inventory item quantity was used for ship group 2.  
 Does anyone disagree?  Could I be misinterpreting the way the 
 OrderItemShipGrpInvRes is supposed to work?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-5364) Incorrect quantityNotAvailable for OrderItemShipGrpInvRes when issuing items to shipments

2014-11-28 Thread Swapnil Shah (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14228203#comment-14228203
 ] 

Swapnil Shah commented on OFBIZ-5364:
-

[~ofbizzer] The issue seems to me in step#9. If at all we are allowing the user 
to directly ship/issue the material reserved from any given ship group to any 
different ship group then corresponding OISGIR per each ship group should be 
updated accordingly. In other words if we extend your given use case then 
following happened:
# In step#7 when 1 unit is received then following was the OISGIR state (say 
your order Id is 1):
|| ORDER_ID ||  SHIP_GROUP_SEQ_ID ||ORDER_ITEM_SEQ_ID || QUANTITY || 
QUANTITY_NOT_AVAILABLE ||
| 1 | 1 | 1| 50 | 49 |
| 1 | 2 | 1| 50 | 50 |
# In step#9 when 1 unit was issued from second ship group (which is still 
reserved against first ship group) then OISGIR changed as follows:
|| ORDER_ID ||  SHIP_GROUP_SEQ_ID ||ORDER_ITEM_SEQ_ID || QUANTITY || 
QUANTITY_NOT_AVAILABLE ||
| 1 | 1 | 1| 50 | 49 |
| 1 | 2 | 1| 49 | 50 |
# And possibly due to this in step#10 you are still seeing issue qty text box 
showing 1 because i think it shows issue=OISGIR.QUANTITY  - OISGIR. 
QUANTITY_NOT_AVAILABLE. But in reality its all messed up because now 
reservations against both ship group are corrupted.

The expected result after step#9 should be as follows in OISGIR as we 
transferred the reservations from first ship group to second in the process and 
eventually ended up with issuance from second ship group.
|| ORDER_ID ||  SHIP_GROUP_SEQ_ID ||ORDER_ITEM_SEQ_ID || QUANTITY || 
QUANTITY_NOT_AVAILABLE ||
| 1 | 1 | 1| 50 | 50 |
| 1 | 2 | 1| 49 | 49 |

I hope it should resolve the issue. Lemme know if i missed anything.  

 Incorrect quantityNotAvailable for OrderItemShipGrpInvRes when issuing items 
 to shipments
 -

 Key: OFBIZ-5364
 URL: https://issues.apache.org/jira/browse/OFBIZ-5364
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: Release Branch 12.04
Reporter: Christian Carlow

 The quantityNotAvailable field of OrderItemShipGrpRes seems to reflect 
 incorrect numbers after shipment issuances occur.
 To reproduct:
 1.  Create an order for DemoCustCompany for a quantity of 100 of a product 
 having no inventory quantity 
 2.  Create a second ship group on the Shipping page
 3.  Assign half of the order item quantity (50) to the second ship group 
 created and then finish creating the order
 4.  Click the New Shipment for Ship Group button for the first ship group 
 and navigate to the Order Items page
 5.  On the Order Items page, notice the issue quantity field is blank 
 because no inventory exist yet to be issued to the shipment.  
 6.  Navigate to the WebstoreWarehouse Receive Inventory page and receive a 
 quantity of 1 for the order item product to increase the inventory by 1
 7.  Refresh the Shipment Order Items page and you'll see the issue quantity 
 change to 1 because the inventoryItemId created in the last step was assigned 
 to the orderItemShipGrpInvRes for this item.
 8.  Now change from ship group 1 to ship group 2 and notice the issue 
 quantity is blank
 9.  Assign a quantity of 1 to the second ship group and click the Issue All 
 button
 10.  Change the ship group back to 1 and notice the quantity in the issue 
 text box is still 1
 It seems like the issue text box in step 10 should be 0 instead of 1 since 
 the inventory item quantity was used for ship group 2.  
 Does anyone disagree?  Could I be misinterpreting the way the 
 OrderItemShipGrpInvRes is supposed to work?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)