[jira] [Commented] (OFBIZ-5552) Problems in single form when use-when and position are used together
[ https://issues.apache.org/jira/browse/OFBIZ-5552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13919232#comment-13919232 ] Jacques Le Roux commented on OFBIZ-5552: Leila, Your 2nd patch is in trunk r1574019 R13.07 r1574020 R12.04 r1574021 R11.04 r1574022 Trivial comment for future: when replacing a patch, don't change the name. Jira will handle it by graying the older one with the same name, far easier to follow for committers (here was not an issue but somtimes can be confusing), thanks. Problems in single form when use-when and position are used together Key: OFBIZ-5552 URL: https://issues.apache.org/jira/browse/OFBIZ-5552 Project: OFBiz Issue Type: Bug Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Leila Mekika Assignee: Jacques Le Roux Priority: Minor Fix For: Release Branch 11.04, SVN trunk, Release Branch 12.04, Release Branch 13.07 Attachments: OFBIZ-5552 v2.patch, OFBIZ-5552.patch The service renderSingleFormString check the previous field position to see if the current field must be displayed after the previous field or on a new line. When the previous field has a use-when condition that is not valid, it remains as the currentFormField and the next field is compared with this not rendered field. If the position of this previous field is the same as the current field, the current is displayed on the next line. To reproduce, add in a single form the three fields below : field position=1 name=firstdisplay description=first//field field position=2 name=second use-when=truedisplay description=second//field field position=2 name=second use-when=falsedisplay description=second//field The field second is rendered on a new line -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (OFBIZ-5552) Problems in single form when use-when and position are used together
[ https://issues.apache.org/jira/browse/OFBIZ-5552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13918300#comment-13918300 ] Leila Mekika commented on OFBIZ-5552: - ok, sorry Jacques. I ran tests through several screens but i didn't see this side effect. It seems to cause wrong display in product edit screen because the lastFormField is null so here is a new patch with a control of lastFormField before assignment. I hope this time it doesn't impact anything else... Problems in single form when use-when and position are used together Key: OFBIZ-5552 URL: https://issues.apache.org/jira/browse/OFBIZ-5552 Project: OFBiz Issue Type: Bug Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Leila Mekika Assignee: Jacques Le Roux Priority: Minor Fix For: Release Branch 11.04, SVN trunk, Release Branch 12.04, Release Branch 13.07 Attachments: OFBIZ-5552 v2.patch, OFBIZ-5552.patch The service renderSingleFormString check the previous field position to see if the current field must be displayed after the previous field or on a new line. When the previous field has a use-when condition that is not valid, it remains as the currentFormField and the next field is compared with this not rendered field. If the position of this previous field is the same as the current field, the current is displayed on the next line. To reproduce, add in a single form the three fields below : field position=1 name=firstdisplay description=first//field field position=2 name=second use-when=truedisplay description=second//field field position=2 name=second use-when=falsedisplay description=second//field The field second is rendered on a new line -- This message was sent by Atlassian JIRA (v6.2#6252)
