[jira] [Commented] (OFBIZ-6208) rename AccountingConfig.properties to accounting.properties
[ https://issues.apache.org/jira/browse/OFBIZ-6208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379045#comment-14379045 ] Pierre Smits commented on OFBIZ-6208: - Dependencies on AccountingConfig.properties exist in: * order * product > rename AccountingConfig.properties to accounting.properties > --- > > Key: OFBIZ-6208 > URL: https://issues.apache.org/jira/browse/OFBIZ-6208 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Reporter: Pierre Smits >Assignee: Pierre Smits > Labels: configuration, multi-tenant > Attachments: OFBIZ-6208-AccountingConfigChange.patch > > > Currently many properties files in various components are named after the > component, i.e. the bi component has bi.properties. > In order to have consistency from component to component the > AccountingConfig.properties file must be renamed to accounting.properties and > all references in other components should reflect the change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6208) rename AccountingConfig.properties to accounting.properties
[ https://issues.apache.org/jira/browse/OFBIZ-6208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379440#comment-14379440 ] Jacques Le Roux commented on OFBIZ-6208: Dependencies between applications component are fine > rename AccountingConfig.properties to accounting.properties > --- > > Key: OFBIZ-6208 > URL: https://issues.apache.org/jira/browse/OFBIZ-6208 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Reporter: Pierre Smits >Assignee: Pierre Smits > Labels: configuration, multi-tenant > Attachments: OFBIZ-6208-ACCInvoicePerShipmentTests.patch, > OFBIZ-6208-ACCInvoiceServices.java.patch, > OFBIZ-6208-ACCInvoiceServices.xml.patch, > OFBIZ-6208-ACCPaymentServices.xml.patch, > OFBIZ-6208-AccountingConfigChange.patch, OFBIZ-6208-ORDROrderServices.patch, > OFBIZ-6208-PRODRentalServices.xml.patch > > > Currently many properties files in various components are named after the > component, i.e. the bi component has bi.properties. > In order to have consistency from component to component the > AccountingConfig.properties file must be renamed to accounting.properties and > all references in other components should reflect the change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6208) rename AccountingConfig.properties to accounting.properties
[ https://issues.apache.org/jira/browse/OFBIZ-6208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379442#comment-14379442 ] Jacques Le Roux commented on OFBIZ-6208: Pierre, these patches are small, could you please provide rather only 1 patch with *all* related changes > rename AccountingConfig.properties to accounting.properties > --- > > Key: OFBIZ-6208 > URL: https://issues.apache.org/jira/browse/OFBIZ-6208 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Reporter: Pierre Smits >Assignee: Pierre Smits > Labels: configuration, multi-tenant > Attachments: OFBIZ-6208-ACCInvoicePerShipmentTests.patch, > OFBIZ-6208-ACCInvoiceServices.java.patch, > OFBIZ-6208-ACCInvoiceServices.xml.patch, > OFBIZ-6208-ACCPaymentServices.xml.patch, > OFBIZ-6208-AccountingConfigChange.patch, OFBIZ-6208-ORDROrderServices.patch, > OFBIZ-6208-PRODRentalServices.xml.patch > > > Currently many properties files in various components are named after the > component, i.e. the bi component has bi.properties. > In order to have consistency from component to component the > AccountingConfig.properties file must be renamed to accounting.properties and > all references in other components should reflect the change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6208) rename AccountingConfig.properties to accounting.properties
[ https://issues.apache.org/jira/browse/OFBIZ-6208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379457#comment-14379457 ] Pierre Smits commented on OFBIZ-6208: - Jacques, I will as soon as it has gone through testing. Best regards, Pierre > rename AccountingConfig.properties to accounting.properties > --- > > Key: OFBIZ-6208 > URL: https://issues.apache.org/jira/browse/OFBIZ-6208 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Reporter: Pierre Smits >Assignee: Pierre Smits > Labels: configuration, multi-tenant > Attachments: OFBIZ-6208-ACCInvoicePerShipmentTests.patch, > OFBIZ-6208-ACCInvoiceServices.java.patch, > OFBIZ-6208-ACCInvoiceServices.xml.patch, > OFBIZ-6208-ACCPaymentServices.xml.patch, > OFBIZ-6208-AccountingConfigChange.patch, OFBIZ-6208-ORDROrderServices.patch, > OFBIZ-6208-PRODRentalServices.xml.patch > > > Currently many properties files in various components are named after the > component, i.e. the bi component has bi.properties. > In order to have consistency from component to component the > AccountingConfig.properties file must be renamed to accounting.properties and > all references in other components should reflect the change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6208) rename AccountingConfig.properties to accounting.properties
[ https://issues.apache.org/jira/browse/OFBIZ-6208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379475#comment-14379475 ] Jacques Le Roux commented on OFBIZ-6208: Testing: you mean on our side or your? I guess it's ours, you should have done testing on your side before submittint patches. Then look, several files mean several downloads and several applies, see my point? It's not specifically for this case but by and large... Thanks for your work! > rename AccountingConfig.properties to accounting.properties > --- > > Key: OFBIZ-6208 > URL: https://issues.apache.org/jira/browse/OFBIZ-6208 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Reporter: Pierre Smits >Assignee: Pierre Smits > Labels: configuration, multi-tenant > Attachments: OFBIZ-6208-ACCInvoicePerShipmentTests.patch, > OFBIZ-6208-ACCInvoiceServices.java.patch, > OFBIZ-6208-ACCInvoiceServices.xml.patch, > OFBIZ-6208-ACCPaymentServices.xml.patch, > OFBIZ-6208-AccountingConfigChange.patch, OFBIZ-6208-ORDROrderServices.patch, > OFBIZ-6208-PRODRentalServices.xml.patch > > > Currently many properties files in various components are named after the > component, i.e. the bi component has bi.properties. > In order to have consistency from component to component the > AccountingConfig.properties file must be renamed to accounting.properties and > all references in other components should reflect the change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6208) rename AccountingConfig.properties to accounting.properties
[ https://issues.apache.org/jira/browse/OFBIZ-6208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379476#comment-14379476 ] Pierre Smits commented on OFBIZ-6208: - It is work in progress. ;-) > rename AccountingConfig.properties to accounting.properties > --- > > Key: OFBIZ-6208 > URL: https://issues.apache.org/jira/browse/OFBIZ-6208 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Reporter: Pierre Smits >Assignee: Pierre Smits > Labels: configuration, multi-tenant > Attachments: OFBIZ-6208-ACCInvoicePerShipmentTests.patch, > OFBIZ-6208-ACCInvoiceServices.java.patch, > OFBIZ-6208-ACCInvoiceServices.xml.patch, > OFBIZ-6208-ACCPaymentServices.xml.patch, > OFBIZ-6208-AccountingConfigChange.patch, OFBIZ-6208-ORDROrderServices.patch, > OFBIZ-6208-PRODRentalServices.xml.patch > > > Currently many properties files in various components are named after the > component, i.e. the bi component has bi.properties. > In order to have consistency from component to component the > AccountingConfig.properties file must be renamed to accounting.properties and > all references in other components should reflect the change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6208) rename AccountingConfig.properties to accounting.properties
[ https://issues.apache.org/jira/browse/OFBIZ-6208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379501#comment-14379501 ] Jacques Le Roux commented on OFBIZ-6208: Better to not submit patches then, or say it ;) > rename AccountingConfig.properties to accounting.properties > --- > > Key: OFBIZ-6208 > URL: https://issues.apache.org/jira/browse/OFBIZ-6208 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Reporter: Pierre Smits >Assignee: Pierre Smits > Labels: configuration, multi-tenant > Attachments: OFBIZ-6208-ACCInvoicePerShipmentTests.patch, > OFBIZ-6208-ACCInvoiceServices.java.patch, > OFBIZ-6208-ACCInvoiceServices.xml.patch, > OFBIZ-6208-ACCPaymentServices.xml.patch, > OFBIZ-6208-AccountingConfigChange.patch, OFBIZ-6208-ORDROrderServices.patch, > OFBIZ-6208-PRODRentalServices.xml.patch > > > Currently many properties files in various components are named after the > component, i.e. the bi component has bi.properties. > In order to have consistency from component to component the > AccountingConfig.properties file must be renamed to accounting.properties and > all references in other components should reflect the change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6208) rename AccountingConfig.properties to accounting.properties
[ https://issues.apache.org/jira/browse/OFBIZ-6208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14492090#comment-14492090 ] Pierre Smits commented on OFBIZ-6208: - It is stated. > rename AccountingConfig.properties to accounting.properties > --- > > Key: OFBIZ-6208 > URL: https://issues.apache.org/jira/browse/OFBIZ-6208 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Reporter: Pierre Smits >Assignee: Pierre Smits > Labels: configuration, multi-tenant > Attachments: OFBIZ-6208-ACCInvoicePerShipmentTests.patch, > OFBIZ-6208-ACCInvoiceServices.java.patch, > OFBIZ-6208-ACCInvoiceServices.xml.patch, > OFBIZ-6208-ACCPaymentServices.xml.patch, > OFBIZ-6208-AccountingConfigChange.patch, OFBIZ-6208-ORDROrderServices.patch, > OFBIZ-6208-PRODRentalServices.xml.patch > > > Currently many properties files in various components are named after the > component, i.e. the bi component has bi.properties. > In order to have consistency from component to component the > AccountingConfig.properties file must be renamed to accounting.properties and > all references in other components should reflect the change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6208) rename AccountingConfig.properties to accounting.properties
[ https://issues.apache.org/jira/browse/OFBIZ-6208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14562406#comment-14562406 ] Jacques Le Roux commented on OFBIZ-6208: Hi Pierre, did you get a chance? > rename AccountingConfig.properties to accounting.properties > --- > > Key: OFBIZ-6208 > URL: https://issues.apache.org/jira/browse/OFBIZ-6208 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Reporter: Pierre Smits >Assignee: Pierre Smits > Labels: configuration, multi-tenant > Attachments: OFBIZ-6208-ACCInvoicePerShipmentTests.patch, > OFBIZ-6208-ACCInvoiceServices.java.patch, > OFBIZ-6208-ACCInvoiceServices.xml.patch, > OFBIZ-6208-ACCPaymentServices.xml.patch, > OFBIZ-6208-AccountingConfigChange.patch, OFBIZ-6208-ORDROrderServices.patch, > OFBIZ-6208-PRODRentalServices.xml.patch > > > Currently many properties files in various components are named after the > component, i.e. the bi component has bi.properties. > In order to have consistency from component to component the > AccountingConfig.properties file must be renamed to accounting.properties and > all references in other components should reflect the change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6208) rename AccountingConfig.properties to accounting.properties
[ https://issues.apache.org/jira/browse/OFBIZ-6208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14583000#comment-14583000 ] Jacques Le Roux commented on OFBIZ-6208: Still a WIP or should we review and hopefully commit? > rename AccountingConfig.properties to accounting.properties > --- > > Key: OFBIZ-6208 > URL: https://issues.apache.org/jira/browse/OFBIZ-6208 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Reporter: Pierre Smits >Assignee: Pierre Smits > Labels: configuration, multi-tenant > Attachments: OFBIZ-6208-ACCInvoicePerShipmentTests.patch, > OFBIZ-6208-ACCInvoiceServices.java.patch, > OFBIZ-6208-ACCInvoiceServices.xml.patch, > OFBIZ-6208-ACCPaymentServices.xml.patch, > OFBIZ-6208-AccountingConfigChange.patch, OFBIZ-6208-ORDROrderServices.patch, > OFBIZ-6208-PRODRentalServices.xml.patch > > > Currently many properties files in various components are named after the > component, i.e. the bi component has bi.properties. > In order to have consistency from component to component the > AccountingConfig.properties file must be renamed to accounting.properties and > all references in other components should reflect the change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6208) rename AccountingConfig.properties to accounting.properties
[ https://issues.apache.org/jira/browse/OFBIZ-6208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14583027#comment-14583027 ] Pierre Smits commented on OFBIZ-6208: - Thanks for the reminder, Jacques. Yes, the status of the issue hasn't changed. So it is safe to assume that it still is. Of course, you can always review it yourself and share your findings. If you then, based on that, want to change the status of the issue, you are free to do so. I don't determine what is committable or not. Best regards, Pierre > rename AccountingConfig.properties to accounting.properties > --- > > Key: OFBIZ-6208 > URL: https://issues.apache.org/jira/browse/OFBIZ-6208 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Reporter: Pierre Smits >Assignee: Pierre Smits > Labels: configuration, multi-tenant > Attachments: OFBIZ-6208-ACCInvoicePerShipmentTests.patch, > OFBIZ-6208-ACCInvoiceServices.java.patch, > OFBIZ-6208-ACCInvoiceServices.xml.patch, > OFBIZ-6208-ACCPaymentServices.xml.patch, > OFBIZ-6208-AccountingConfigChange.patch, OFBIZ-6208-ORDROrderServices.patch, > OFBIZ-6208-PRODRentalServices.xml.patch > > > Currently many properties files in various components are named after the > component, i.e. the bi component has bi.properties. > In order to have consistency from component to component the > AccountingConfig.properties file must be renamed to accounting.properties and > all references in other components should reflect the change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
