[jira] [Commented] (OFBIZ-6310) createConditionList doesn't handle widget dropdown multi-submitted values when called by performFind
[ https://issues.apache.org/jira/browse/OFBIZ-6310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563584#comment-14563584 ] Christian Carlow commented on OFBIZ-6310: - Thanks for the review Jacques, I'll pay better attention to those details for future patches. createConditionList doesn't handle widget dropdown multi-submitted values when called by performFind Key: OFBIZ-6310 URL: https://issues.apache.org/jira/browse/OFBIZ-6310 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk Reporter: Christian Carlow Assignee: Michael Brohl Fix For: Release Branch 13.07, Release Branch 14.12, Upcoming Branch Attachments: OFBIZ-6310.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6310) createConditionList doesn't handle widget dropdown multi-submitted values when called by performFind
[
https://issues.apache.org/jira/browse/OFBIZ-6310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563655#comment-14563655
]
Christian Carlow commented on OFBIZ-6310:
-
Good to know Michael.
I thought Jacques may have been referring to the missing space before the
opening curly bracket consistent with the others:
{code}
if(UtilValidate.isNotEmpty(UtilGenerics.toList(fieldValue))){
{code}
createConditionList doesn't handle widget dropdown multi-submitted values
when called by performFind
Key: OFBIZ-6310
URL: https://issues.apache.org/jira/browse/OFBIZ-6310
Project: OFBiz
Issue Type: Bug
Components: framework
Affects Versions: Trunk
Reporter: Christian Carlow
Assignee: Michael Brohl
Fix For: Release Branch 13.07, Release Branch 14.12, Upcoming
Branch
Attachments: OFBIZ-6310.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6310) createConditionList doesn't handle widget dropdown multi-submitted values when called by performFind
[
https://issues.apache.org/jira/browse/OFBIZ-6310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563653#comment-14563653
]
Christian Carlow commented on OFBIZ-6310:
-
Good to know Michael.
I thought Jacques may have been referring to the missing space before the
opening curly bracket consistent with the others:
{code}
if(UtilValidate.isNotEmpty(UtilGenerics.toList(fieldValue))){
{code}
createConditionList doesn't handle widget dropdown multi-submitted values
when called by performFind
Key: OFBIZ-6310
URL: https://issues.apache.org/jira/browse/OFBIZ-6310
Project: OFBiz
Issue Type: Bug
Components: framework
Affects Versions: Trunk
Reporter: Christian Carlow
Assignee: Michael Brohl
Fix For: Release Branch 13.07, Release Branch 14.12, Upcoming
Branch
Attachments: OFBIZ-6310.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6310) createConditionList doesn't handle widget dropdown multi-submitted values when called by performFind
[ https://issues.apache.org/jira/browse/OFBIZ-6310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563589#comment-14563589 ] Michael Brohl commented on OFBIZ-6310: -- Christian, your patch file was ok, it was my fault. No big deal anyway. createConditionList doesn't handle widget dropdown multi-submitted values when called by performFind Key: OFBIZ-6310 URL: https://issues.apache.org/jira/browse/OFBIZ-6310 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk Reporter: Christian Carlow Assignee: Michael Brohl Fix For: Release Branch 13.07, Release Branch 14.12, Upcoming Branch Attachments: OFBIZ-6310.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6310) createConditionList doesn't handle widget dropdown multi-submitted values when called by performFind
[ https://issues.apache.org/jira/browse/OFBIZ-6310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563760#comment-14563760 ] Jacques Le Roux commented on OFBIZ-6310: Actually was that and only that, anyway trivial ;) createConditionList doesn't handle widget dropdown multi-submitted values when called by performFind Key: OFBIZ-6310 URL: https://issues.apache.org/jira/browse/OFBIZ-6310 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk Reporter: Christian Carlow Assignee: Michael Brohl Fix For: Release Branch 13.07, Release Branch 14.12, Upcoming Branch Attachments: OFBIZ-6310.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6310) createConditionList doesn't handle widget dropdown multi-submitted values when called by performFind
[ https://issues.apache.org/jira/browse/OFBIZ-6310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563271#comment-14563271 ] Michael Brohl commented on OFBIZ-6310: -- Jacques, I had problems using the formatting in Eclipse in one of the latest developments, maybe it was just this issue, can't remember. Using the official OFBiz Eclipse formatting template there were way too much changes so I reverted and did it by hand. I fear formatting is not strictly followed in all our sources... Anyway, thanks for the correction. createConditionList doesn't handle widget dropdown multi-submitted values when called by performFind Key: OFBIZ-6310 URL: https://issues.apache.org/jira/browse/OFBIZ-6310 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk Reporter: Christian Carlow Assignee: Michael Brohl Fix For: Release Branch 13.07, Release Branch 14.12, Upcoming Branch Attachments: OFBIZ-6310.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6310) createConditionList doesn't handle widget dropdown multi-submitted values when called by performFind
[ https://issues.apache.org/jira/browse/OFBIZ-6310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563262#comment-14563262 ] Jacques Le Roux commented on OFBIZ-6310: Hi Michael, Christian, Please take care of the formatting, I know it's not so easy to spot during reviews ;) Done for trunk at r1682282, no needs to backport, thanks for your work! createConditionList doesn't handle widget dropdown multi-submitted values when called by performFind Key: OFBIZ-6310 URL: https://issues.apache.org/jira/browse/OFBIZ-6310 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk Reporter: Christian Carlow Assignee: Michael Brohl Fix For: Release Branch 13.07, Release Branch 14.12, Upcoming Branch Attachments: OFBIZ-6310.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6310) createConditionList doesn't handle widget dropdown multi-submitted values when called by performFind
[ https://issues.apache.org/jira/browse/OFBIZ-6310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563161#comment-14563161 ] Christian Carlow commented on OFBIZ-6310: - Thanks for the review Michael, Feel free to commit any of my patches for me. I've been holding off since it isn't convenient while I'm still using git and working on other functionality. Also feel free to backport if you like but for now I'm only focusing on the trunk. createConditionList doesn't handle widget dropdown multi-submitted values when called by performFind Key: OFBIZ-6310 URL: https://issues.apache.org/jira/browse/OFBIZ-6310 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk Reporter: Christian Carlow Attachments: OFBIZ-6310.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6310) createConditionList doesn't handle widget dropdown multi-submitted values when called by performFind
[ https://issues.apache.org/jira/browse/OFBIZ-6310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563135#comment-14563135 ] Michael Brohl commented on OFBIZ-6310: -- Christian, your patch looks good to me, do you want to commit it yourself? Should we backport to the 13.07 and 14.12 branches? createConditionList doesn't handle widget dropdown multi-submitted values when called by performFind Key: OFBIZ-6310 URL: https://issues.apache.org/jira/browse/OFBIZ-6310 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk Reporter: Christian Carlow Attachments: OFBIZ-6310.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
