[jira] [Commented] (OFBIZ-6328) createProductionRunsForOrder service doesn't handle cancelled production runs
[
https://issues.apache.org/jira/browse/OFBIZ-6328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15315404#comment-15315404
]
Pranay Pandey commented on OFBIZ-6328:
--
Okay, checked it again, test suite productionruntests running fine, all tests
passed.
Here is the result:
{code}
Results for test suite: productionruntests
Pass: true | # Tests: 35 | # Failed: 0 # Errors: 0
{code}
Going to commit the fix.
> createProductionRunsForOrder service doesn't handle cancelled production runs
> -
>
> Key: OFBIZ-6328
> URL: https://issues.apache.org/jira/browse/OFBIZ-6328
> Project: OFBiz
> Issue Type: Improvement
> Components: manufacturing
>Affects Versions: Trunk
>Reporter: Christian Carlow
>Assignee: Pranay Pandey
> Attachments: OFBIZ-6328.patch
>
>
> createProductionRunsForOrder doesn't create production runs whenever a
> WorkOrderItemFulfillment record exists even if workEffort.currentStatusId ==
> "PRUN_CANCELLED". The service should be enhanced to recognized canceled
> production runs and create replacements when no active ones are found.
> Extra logic may need to be added later to handle changing production run
> statuses from canceled back to an active state when another active production
> run took its place but as of right now such a status change is not possible.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6328) createProductionRunsForOrder service doesn't handle cancelled production runs
[ https://issues.apache.org/jira/browse/OFBIZ-6328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15247407#comment-15247407 ] Pranay Pandey commented on OFBIZ-6328: -- Hi [~ofbizzer], I reviewed this patch and found it good. Could you please also check unit test - testCreateProductionRunForOrder for the same. It's failing as now and it's a good chance to correct it. > createProductionRunsForOrder service doesn't handle cancelled production runs > - > > Key: OFBIZ-6328 > URL: https://issues.apache.org/jira/browse/OFBIZ-6328 > Project: OFBiz > Issue Type: Improvement > Components: manufacturing >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Pranay Pandey > Attachments: OFBIZ-6328.patch > > > createProductionRunsForOrder doesn't create production runs whenever a > WorkOrderItemFulfillment record exists even if workEffort.currentStatusId == > "PRUN_CANCELLED". The service should be enhanced to recognized canceled > production runs and create replacements when no active ones are found. > Extra logic may need to be added later to handle changing production run > statuses from canceled back to an active state when another active production > run took its place but as of right now such a status change is not possible. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6328) createProductionRunsForOrder service doesn't handle cancelled production runs
[ https://issues.apache.org/jira/browse/OFBIZ-6328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14526905#comment-14526905 ] Christian Carlow commented on OFBIZ-6328: - This patch was extracted from OFBIZ-6085 to handle this issue separately. > createProductionRunsForOrder service doesn't handle cancelled production runs > - > > Key: OFBIZ-6328 > URL: https://issues.apache.org/jira/browse/OFBIZ-6328 > Project: OFBiz > Issue Type: Improvement > Components: manufacturing >Affects Versions: Trunk >Reporter: Christian Carlow > Attachments: OFBIZ-6328.patch > > > createProductionRunsForOrder doesn't create production runs whenever a > WorkOrderItemFulfillment record exists even if workEffort.currentStatusId == > "PRUN_CANCELLED". The service should be enhanced to recognized canceled > production runs and create replacements when no active ones are found. > Extra logic may need to be added later to handle changing production run > statuses from canceled back to an active state when another active production > run took its place but as of right now such a status change is not possible. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
