[jira] [Commented] (OFBIZ-6362) Move js & css references from CommonDecorator(s) to themes
[ https://issues.apache.org/jira/browse/OFBIZ-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723159#comment-14723159 ] Jacques Le Roux commented on OFBIZ-6362: Good luck with solving OFBIZ-6589 w/o reverting all changes done here :/ At least we need to better deal with And why is the related code still present in :-o ? > Move js & css references from CommonDecorator(s) to themes > -- > > Key: OFBIZ-6362 > URL: https://issues.apache.org/jira/browse/OFBIZ-6362 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk, Upcoming Branch >Reporter: Pierre Smits >Assignee: Deepak Dixit >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-6263-BlueLight-header.ftl.patch, > OFBIZ-6362-BizznessTime-header.ftl.patch, > OFBIZ-6362-BizznessTimeThemeData.xml.patch, > OFBIZ-6362-BlueLightThemeData.xml.patch, OFBIZ-6362-CommonScreens.xml.patch, > OFBIZ-6362-DroppingCrumbs-header.ftl.patch, > OFBIZ-6362-DroppingCrumbsThemeData.xml.patch, > OFBIZ-6362-FlatGrey-header.ftl.patch, OFBIZ-6362-FlatGreyThemeData.xml.patch, > OFBIZ-6362-Tomahawk-header.ftl.patch, OFBIZ-6362-TomahawkThemeData.xml.patch, > OFBIZ-6362-bbasic-theme.patch, OFBIZ-6362-sunrise-theme.patch, bbasic.zip, > sunrise.zip > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6362) Move js & css references from CommonDecorator(s) to themes
[ https://issues.apache.org/jira/browse/OFBIZ-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723139#comment-14723139 ] Jacques Le Roux commented on OFBIZ-6362: I noticed this comment but then forgot to comment myself. I agree with Wei, also see OFBIZ-6589 for last commit below > Move js & css references from CommonDecorator(s) to themes > -- > > Key: OFBIZ-6362 > URL: https://issues.apache.org/jira/browse/OFBIZ-6362 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk, Upcoming Branch >Reporter: Pierre Smits >Assignee: Deepak Dixit >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-6263-BlueLight-header.ftl.patch, > OFBIZ-6362-BizznessTime-header.ftl.patch, > OFBIZ-6362-BizznessTimeThemeData.xml.patch, > OFBIZ-6362-BlueLightThemeData.xml.patch, OFBIZ-6362-CommonScreens.xml.patch, > OFBIZ-6362-DroppingCrumbs-header.ftl.patch, > OFBIZ-6362-DroppingCrumbsThemeData.xml.patch, > OFBIZ-6362-FlatGrey-header.ftl.patch, OFBIZ-6362-FlatGreyThemeData.xml.patch, > OFBIZ-6362-Tomahawk-header.ftl.patch, OFBIZ-6362-TomahawkThemeData.xml.patch, > OFBIZ-6362-bbasic-theme.patch, OFBIZ-6362-sunrise-theme.patch, bbasic.zip, > sunrise.zip > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6362) Move js & css references from CommonDecorator(s) to themes
[ https://issues.apache.org/jira/browse/OFBIZ-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14710700#comment-14710700 ] Deepak Dixit commented on OFBIZ-6362: - Added missing code at r#1697574 to include the component specific js file in header.ftl. > Move js & css references from CommonDecorator(s) to themes > -- > > Key: OFBIZ-6362 > URL: https://issues.apache.org/jira/browse/OFBIZ-6362 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk, Upcoming Branch >Reporter: Pierre Smits >Assignee: Adrian Crum >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-6263-BlueLight-header.ftl.patch, > OFBIZ-6362-BizznessTime-header.ftl.patch, > OFBIZ-6362-BizznessTimeThemeData.xml.patch, > OFBIZ-6362-BlueLightThemeData.xml.patch, OFBIZ-6362-CommonScreens.xml.patch, > OFBIZ-6362-DroppingCrumbs-header.ftl.patch, > OFBIZ-6362-DroppingCrumbsThemeData.xml.patch, > OFBIZ-6362-FlatGrey-header.ftl.patch, OFBIZ-6362-FlatGreyThemeData.xml.patch, > OFBIZ-6362-Tomahawk-header.ftl.patch, OFBIZ-6362-TomahawkThemeData.xml.patch, > OFBIZ-6362-bbasic-theme.patch, OFBIZ-6362-sunrise-theme.patch, bbasic.zip, > sunrise.zip > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6362) Move js & css references from CommonDecorator(s) to themes
[
https://issues.apache.org/jira/browse/OFBIZ-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14598918#comment-14598918
]
Wei Zhang commented on OFBIZ-6362:
--
I don't think we should add localization js files below to seed data
{code:borderStyle=solid}
{code}
And there is no way to output the localization js files defined GlobalActions
in framework\common\widget\CommonScreens.xml
{code:borderStyle=solid}
{code}
> Move js & css references from CommonDecorator(s) to themes
> --
>
> Key: OFBIZ-6362
> URL: https://issues.apache.org/jira/browse/OFBIZ-6362
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Adrian Crum
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-6263-BlueLight-header.ftl.patch,
> OFBIZ-6362-BizznessTime-header.ftl.patch,
> OFBIZ-6362-BizznessTimeThemeData.xml.patch,
> OFBIZ-6362-BlueLightThemeData.xml.patch, OFBIZ-6362-CommonScreens.xml.patch,
> OFBIZ-6362-DroppingCrumbs-header.ftl.patch,
> OFBIZ-6362-DroppingCrumbsThemeData.xml.patch,
> OFBIZ-6362-FlatGrey-header.ftl.patch, OFBIZ-6362-FlatGreyThemeData.xml.patch,
> OFBIZ-6362-Tomahawk-header.ftl.patch, OFBIZ-6362-TomahawkThemeData.xml.patch,
> OFBIZ-6362-bbasic-theme.patch, OFBIZ-6362-sunrise-theme.patch, bbasic.zip,
> sunrise.zip
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6362) Move js & css references from CommonDecorator(s) to themes
[ https://issues.apache.org/jira/browse/OFBIZ-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14544316#comment-14544316 ] Pierre Smits commented on OFBIZ-6362: - The issue OFBIZ-6367 has been created to address this. > Move js & css references from CommonDecorator(s) to themes > -- > > Key: OFBIZ-6362 > URL: https://issues.apache.org/jira/browse/OFBIZ-6362 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk, Upcoming Branch >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Minor > Attachments: OFBIZ-6263-BlueLight-header.ftl.patch, > OFBIZ-6362-BizznessTime-header.ftl.patch, > OFBIZ-6362-BizznessTimeThemeData.xml.patch, > OFBIZ-6362-BlueLightThemeData.xml.patch, OFBIZ-6362-CommonScreens.xml.patch, > OFBIZ-6362-DroppingCrumbs-header.ftl.patch, > OFBIZ-6362-DroppingCrumbsThemeData.xml.patch, > OFBIZ-6362-FlatGrey-header.ftl.patch, OFBIZ-6362-FlatGreyThemeData.xml.patch, > OFBIZ-6362-Tomahawk-header.ftl.patch, OFBIZ-6362-TomahawkThemeData.xml.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6362) Move js & css references from CommonDecorator(s) to themes
[ https://issues.apache.org/jira/browse/OFBIZ-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14544310#comment-14544310 ] Pierre Smits commented on OFBIZ-6362: - Those lines are not referencing jquery directly, but some java code in JsLanguageFilesMapping.java and JsLanguageFileMappingCreator.java, referencing template JsLanguageFilesMapping.ftl Cleaning up lines 147-151 and potentially (re)moving the code in JsLanguageFilesMapping.java, JsLanguageFileMappingCreator.java and JsLanguageFilesMapping.ftl will require more effort and should be assessed independently in a separate issue. > Move js & css references from CommonDecorator(s) to themes > -- > > Key: OFBIZ-6362 > URL: https://issues.apache.org/jira/browse/OFBIZ-6362 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk, Upcoming Branch >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Minor > Attachments: OFBIZ-6263-BlueLight-header.ftl.patch, > OFBIZ-6362-BizznessTime-header.ftl.patch, > OFBIZ-6362-BizznessTimeThemeData.xml.patch, > OFBIZ-6362-BlueLightThemeData.xml.patch, OFBIZ-6362-CommonScreens.xml.patch, > OFBIZ-6362-DroppingCrumbs-header.ftl.patch, > OFBIZ-6362-DroppingCrumbsThemeData.xml.patch, > OFBIZ-6362-FlatGrey-header.ftl.patch, OFBIZ-6362-FlatGreyThemeData.xml.patch, > OFBIZ-6362-Tomahawk-header.ftl.patch, OFBIZ-6362-TomahawkThemeData.xml.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6362) Move js & css references from CommonDecorator(s) to themes
[ https://issues.apache.org/jira/browse/OFBIZ-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14544299#comment-14544299 ] Pierre Smits commented on OFBIZ-6362: - Adjustment of the SimpleDecorator needs to be done in a separate issue, as it impacts more than just the screen in CommonScreens.xml. > Move js & css references from CommonDecorator(s) to themes > -- > > Key: OFBIZ-6362 > URL: https://issues.apache.org/jira/browse/OFBIZ-6362 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk, Upcoming Branch >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Minor > Attachments: OFBIZ-6263-BlueLight-header.ftl.patch, > OFBIZ-6362-BizznessTime-header.ftl.patch, > OFBIZ-6362-BizznessTimeThemeData.xml.patch, > OFBIZ-6362-BlueLightThemeData.xml.patch, OFBIZ-6362-CommonScreens.xml.patch, > OFBIZ-6362-DroppingCrumbs-header.ftl.patch, > OFBIZ-6362-DroppingCrumbsThemeData.xml.patch, > OFBIZ-6362-FlatGrey-header.ftl.patch, OFBIZ-6362-FlatGreyThemeData.xml.patch, > OFBIZ-6362-Tomahawk-header.ftl.patch, OFBIZ-6362-TomahawkThemeData.xml.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6362) Move js & css references from CommonDecorator(s) to themes
[ https://issues.apache.org/jira/browse/OFBIZ-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14544254#comment-14544254 ] Pierre Smits commented on OFBIZ-6362: - Those lines are not referencing jquery directly, but some java code in JsLanguageFilesMapping.java and JsLanguageFileMappingCreator.java, referencing template JsLanguageFilesMapping.ftl > Move js & css references from CommonDecorator(s) to themes > -- > > Key: OFBIZ-6362 > URL: https://issues.apache.org/jira/browse/OFBIZ-6362 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk, Upcoming Branch >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Minor > Attachments: OFBIZ-6263-BlueLight-header.ftl.patch, > OFBIZ-6362-BizznessTime-header.ftl.patch, > OFBIZ-6362-BizznessTimeThemeData.xml.patch, > OFBIZ-6362-BlueLightThemeData.xml.patch, OFBIZ-6362-CommonScreens.xml.patch, > OFBIZ-6362-DroppingCrumbs-header.ftl.patch, > OFBIZ-6362-DroppingCrumbsThemeData.xml.patch, > OFBIZ-6362-FlatGrey-header.ftl.patch, OFBIZ-6362-FlatGreyThemeData.xml.patch, > OFBIZ-6362-Tomahawk-header.ftl.patch, OFBIZ-6362-TomahawkThemeData.xml.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6362) Move js & css references from CommonDecorator(s) to themes
[ https://issues.apache.org/jira/browse/OFBIZ-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14544199#comment-14544199 ] Adrian Crum commented on OFBIZ-6362: JQuery is still referenced in the Global Decorator - lines 147-151. Those lines will need to be moved to the theme's header.ftl file. > Move js & css references from CommonDecorator(s) to themes > -- > > Key: OFBIZ-6362 > URL: https://issues.apache.org/jira/browse/OFBIZ-6362 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk, Upcoming Branch >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Minor > Attachments: OFBIZ-6263-BlueLight-header.ftl.patch, > OFBIZ-6362-BizznessTime-header.ftl.patch, > OFBIZ-6362-BizznessTimeThemeData.xml.patch, > OFBIZ-6362-BlueLightThemeData.xml.patch, OFBIZ-6362-CommonScreens.xml.patch, > OFBIZ-6362-DroppingCrumbs-header.ftl.patch, > OFBIZ-6362-DroppingCrumbsThemeData.xml.patch, > OFBIZ-6362-FlatGrey-header.ftl.patch, OFBIZ-6362-FlatGreyThemeData.xml.patch, > OFBIZ-6362-Tomahawk-header.ftl.patch, OFBIZ-6362-TomahawkThemeData.xml.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6362) Move js & css references from CommonDecorator(s) to themes
[ https://issues.apache.org/jira/browse/OFBIZ-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14543947#comment-14543947 ] Adrian Crum commented on OFBIZ-6362: The SimpleDecorator can be treated the same as GlobalDecorator. > Move js & css references from CommonDecorator(s) to themes > -- > > Key: OFBIZ-6362 > URL: https://issues.apache.org/jira/browse/OFBIZ-6362 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk, Upcoming Branch >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Minor > Attachments: OFBIZ-6263-BlueLight-header.ftl.patch, > OFBIZ-6362-BizznessTime-header.ftl.patch, > OFBIZ-6362-BizznessTimeThemeData.xml.patch, > OFBIZ-6362-BlueLightThemeData.xml.patch, OFBIZ-6362-CommonScreens.xml.patch, > OFBIZ-6362-DroppingCrumbs-header.ftl.patch, > OFBIZ-6362-DroppingCrumbsThemeData.xml.patch, > OFBIZ-6362-FlatGrey-header.ftl.patch, OFBIZ-6362-FlatGreyThemeData.xml.patch, > OFBIZ-6362-Tomahawk-header.ftl.patch, OFBIZ-6362-TomahawkThemeData.xml.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6362) Move js & css references from CommonDecorator(s) to themes
[ https://issues.apache.org/jira/browse/OFBIZ-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14543727#comment-14543727 ] Pierre Smits commented on OFBIZ-6362: - Question: How shall we deal with the ''? Have a simple theme for this? Or? > Move js & css references from CommonDecorator(s) to themes > -- > > Key: OFBIZ-6362 > URL: https://issues.apache.org/jira/browse/OFBIZ-6362 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk, Upcoming Branch >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Minor > Attachments: OFBIZ-6263-BlueLight-header.ftl.patch, > OFBIZ-6362-BizznessTime-header.ftl.patch, > OFBIZ-6362-BizznessTimeThemeData.xml.patch, > OFBIZ-6362-BlueLightThemeData.xml.patch, > OFBIZ-6362-DroppingCrumbs-header.ftl.patch, > OFBIZ-6362-DroppingCrumbsThemeData.xml.patch, > OFBIZ-6362-FlatGrey-header.ftl.patch, OFBIZ-6362-FlatGreyThemeData.xml.patch, > OFBIZ-6362-Tomahawk-header.ftl.patch, OFBIZ-6362-TomahawkThemeData.xml.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6362) Move js & css references from CommonDecorator(s) to themes
[ https://issues.apache.org/jira/browse/OFBIZ-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14543709#comment-14543709 ] Pierre Smits commented on OFBIZ-6362: - Thanks Adrian. Will do. > Move js & css references from CommonDecorator(s) to themes > -- > > Key: OFBIZ-6362 > URL: https://issues.apache.org/jira/browse/OFBIZ-6362 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk, Upcoming Branch >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Minor > Attachments: OFBIZ-6263-BlueLight-header.ftl.patch, > OFBIZ-6362-BizznessTime-header.ftl.patch, > OFBIZ-6362-BizznessTimeThemeData.xml.patch, > OFBIZ-6362-BlueLightThemeData.xml.patch, > OFBIZ-6362-DroppingCrumbs-header.ftl.patch, > OFBIZ-6362-DroppingCrumbsThemeData.xml.patch, > OFBIZ-6362-FlatGrey-header.ftl.patch, OFBIZ-6362-FlatGreyThemeData.xml.patch, > OFBIZ-6362-Tomahawk-header.ftl.patch, OFBIZ-6362-TomahawkThemeData.xml.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6362) Move js & css references from CommonDecorator(s) to themes
[ https://issues.apache.org/jira/browse/OFBIZ-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14543706#comment-14543706 ] Adrian Crum commented on OFBIZ-6362: Pierre, Thank you for working on this. When you are finished, please assign it to me. > Move js & css references from CommonDecorator(s) to themes > -- > > Key: OFBIZ-6362 > URL: https://issues.apache.org/jira/browse/OFBIZ-6362 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk, Upcoming Branch >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Minor > Attachments: OFBIZ-6263-BlueLight-header.ftl.patch, > OFBIZ-6362-BizznessTime-header.ftl.patch, > OFBIZ-6362-BizznessTimeThemeData.xml.patch, > OFBIZ-6362-BlueLightThemeData.xml.patch, > OFBIZ-6362-DroppingCrumbs-header.ftl.patch, > OFBIZ-6362-DroppingCrumbsThemeData.xml.patch, > OFBIZ-6362-FlatGrey-header.ftl.patch, OFBIZ-6362-FlatGreyThemeData.xml.patch, > OFBIZ-6362-Tomahawk-header.ftl.patch, OFBIZ-6362-TomahawkThemeData.xml.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
