[jira] [Commented] (OFBIZ-6662) PartyRelationship.securityGroupId not added when adding a PartyRelationship
[ https://issues.apache.org/jira/browse/OFBIZ-6662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15244078#comment-15244078 ] Jacques Le Roux commented on OFBIZ-6662: Thanks Michael! > PartyRelationship.securityGroupId not added when adding a PartyRelationship > --- > > Key: OFBIZ-6662 > URL: https://issues.apache.org/jira/browse/OFBIZ-6662 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Release Branch 11.04, Release Branch 12.04, Release > Branch 13.07, Release Branch 14.12, Upcoming Branch >Reporter: Forrest Rae >Assignee: Michael Brohl > Labels: patch > Fix For: 14.12.01, 13.07.04 > > Attachments: OFBIZ-6662-partymgr.patch > > > When adding a PartyRelationship the value selected for SecurityGroupId is > ignored as createPartyRelationship service expects the parameter to be named > securityGroupId. The AddOtherPartyRelationship form incorrectly names the > field groupId causing the value to be missed in the set-nonpk-fields call in > applications/party/script/org/ofbiz/party/party/PartyServices.xml at line 821. > This bug can be traced back 7 years and 1 month to when the code was > originally committed, showing that it never worked in the first place :( > https://fisheye6.atlassian.com/changelog/ofbiz?cs=688484 > Repo: > 1) While adding a relationship, select something in the Security Group ID > select menu. > 2) Submit > 3) Webtools -> Entity Engine -> PartyRelationship -> Find > 4) Search for the PartyRelationship > 5) Not that the securityGroupId field is empty even though you selected one > in step 1. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6662) PartyRelationship.securityGroupId not added when adding a PartyRelationship
[ https://issues.apache.org/jira/browse/OFBIZ-6662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15244077#comment-15244077 ] Jacques Le Roux commented on OFBIZ-6662: Ooops, my bad, it was then committed in R12.04.06 but we have not here is now so I can't put it back. Not a problem since it's already released, so the release note is OK :) Also, I wonder if in this case we should put Upcoming branch or 15.12.01. Because when it was committed the R15.12 branch did not exist and the fix was only put in trunk. Actually I believe we should not put either, sorry for the mess, I slowly get used to it :D > PartyRelationship.securityGroupId not added when adding a PartyRelationship > --- > > Key: OFBIZ-6662 > URL: https://issues.apache.org/jira/browse/OFBIZ-6662 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Release Branch 11.04, Release Branch 12.04, Release > Branch 13.07, Release Branch 14.12, Upcoming Branch >Reporter: Forrest Rae >Assignee: Michael Brohl > Labels: patch > Fix For: 14.12.01, 15.12.01, 13.07.04 > > Attachments: OFBIZ-6662-partymgr.patch > > > When adding a PartyRelationship the value selected for SecurityGroupId is > ignored as createPartyRelationship service expects the parameter to be named > securityGroupId. The AddOtherPartyRelationship form incorrectly names the > field groupId causing the value to be missed in the set-nonpk-fields call in > applications/party/script/org/ofbiz/party/party/PartyServices.xml at line 821. > This bug can be traced back 7 years and 1 month to when the code was > originally committed, showing that it never worked in the first place :( > https://fisheye6.atlassian.com/changelog/ofbiz?cs=688484 > Repo: > 1) While adding a relationship, select something in the Security Group ID > select menu. > 2) Submit > 3) Webtools -> Entity Engine -> PartyRelationship -> Find > 4) Search for the PartyRelationship > 5) Not that the securityGroupId field is empty even though you selected one > in step 1. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6662) PartyRelationship.securityGroupId not added when adding a PartyRelationship
[ https://issues.apache.org/jira/browse/OFBIZ-6662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15243514#comment-15243514 ] Michael Brohl commented on OFBIZ-6662: -- Hi Jacques, sorry, I have noticed but had not the time to check/fix this. I hope to have it fixed in the next days. Have a nice weekend, Michael > PartyRelationship.securityGroupId not added when adding a PartyRelationship > --- > > Key: OFBIZ-6662 > URL: https://issues.apache.org/jira/browse/OFBIZ-6662 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Release Branch 11.04, Release Branch 12.04, Release > Branch 13.07, Release Branch 14.12, Upcoming Branch >Reporter: Forrest Rae >Assignee: Michael Brohl > Labels: patch > Fix For: Release Branch 12.04, Release Branch 13.07, Release > Branch 14.12, Trunk > > Attachments: OFBIZ-6662-partymgr.patch > > > When adding a PartyRelationship the value selected for SecurityGroupId is > ignored as createPartyRelationship service expects the parameter to be named > securityGroupId. The AddOtherPartyRelationship form incorrectly names the > field groupId causing the value to be missed in the set-nonpk-fields call in > applications/party/script/org/ofbiz/party/party/PartyServices.xml at line 821. > This bug can be traced back 7 years and 1 month to when the code was > originally committed, showing that it never worked in the first place :( > https://fisheye6.atlassian.com/changelog/ofbiz?cs=688484 > Repo: > 1) While adding a relationship, select something in the Security Group ID > select menu. > 2) Submit > 3) Webtools -> Entity Engine -> PartyRelationship -> Find > 4) Search for the PartyRelationship > 5) Not that the securityGroupId field is empty even though you selected one > in step 1. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6662) PartyRelationship.securityGroupId not added when adding a PartyRelationship
[ https://issues.apache.org/jira/browse/OFBIZ-6662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15240773#comment-15240773 ] Jacques Le Roux commented on OFBIZ-6662: Hi Michael, You maybe not noticed but [we have changed the way we report the fixed versions in Jira|http://markmail.org/message/zl7zrk2lmm6dvj4v]. This to automatically provide better releases notes for our users. I have just updated [our documentation on this subject|https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Committers+Roles+and+Responsibilities#OFBizCommittersRolesandResponsibilities-ManageJIRA'sissues]. A last thing should be done, please replace all the occurences of "Release branch 14.12" by "14.12.01" in the [following instances|https://issues.apache.org/jira/browse/OFBIZ-6662?jql=project%20%3D%20OFBIZ%20AND%20fixVersion%20%3D%20%22Release%20Branch%2014.12%22%20ORDER%20BY%20updated%20DESC] Thanks! > PartyRelationship.securityGroupId not added when adding a PartyRelationship > --- > > Key: OFBIZ-6662 > URL: https://issues.apache.org/jira/browse/OFBIZ-6662 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Release Branch 11.04, Release Branch 12.04, Release > Branch 13.07, Release Branch 14.12, Upcoming Branch >Reporter: Forrest Rae >Assignee: Michael Brohl > Labels: patch > Fix For: Release Branch 12.04, Release Branch 13.07, Release > Branch 14.12, Trunk > > Attachments: OFBIZ-6662-partymgr.patch > > > When adding a PartyRelationship the value selected for SecurityGroupId is > ignored as createPartyRelationship service expects the parameter to be named > securityGroupId. The AddOtherPartyRelationship form incorrectly names the > field groupId causing the value to be missed in the set-nonpk-fields call in > applications/party/script/org/ofbiz/party/party/PartyServices.xml at line 821. > This bug can be traced back 7 years and 1 month to when the code was > originally committed, showing that it never worked in the first place :( > https://fisheye6.atlassian.com/changelog/ofbiz?cs=688484 > Repo: > 1) While adding a relationship, select something in the Security Group ID > select menu. > 2) Submit > 3) Webtools -> Entity Engine -> PartyRelationship -> Find > 4) Search for the PartyRelationship > 5) Not that the securityGroupId field is empty even though you selected one > in step 1. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6662) PartyRelationship.securityGroupId not added when adding a PartyRelationship
[ https://issues.apache.org/jira/browse/OFBIZ-6662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14941022#comment-14941022 ] Jacques Le Roux commented on OFBIZ-6662: Looks good to me > PartyRelationship.securityGroupId not added when adding a PartyRelationship > --- > > Key: OFBIZ-6662 > URL: https://issues.apache.org/jira/browse/OFBIZ-6662 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Release Branch 11.04, Release Branch 12.04, Release > Branch 13.07, Release Branch 14.12, Upcoming Branch >Reporter: Forrest Rae >Assignee: Michael Brohl > Labels: patch > Attachments: OFBIZ-6662-partymgr.patch > > > When adding a PartyRelationship the value selected for SecurityGroupId is > ignored as createPartyRelationship service expects the parameter to be named > securityGroupId. The AddOtherPartyRelationship form incorrectly names the > field groupId causing the value to be missed in the set-nonpk-fields call in > applications/party/script/org/ofbiz/party/party/PartyServices.xml at line 821. > This bug can be traced back 7 years and 1 month to when the code was > originally committed, showing that it never worked in the first place :( > https://fisheye6.atlassian.com/changelog/ofbiz?cs=688484 > Repo: > 1) While adding a relationship, select something in the Security Group ID > select menu. > 2) Submit > 3) Webtools -> Entity Engine -> PartyRelationship -> Find > 4) Search for the PartyRelationship > 5) Not that the securityGroupId field is empty even though you selected one > in step 1. -- This message was sent by Atlassian JIRA (v6.3.4#6332)