[jira] [Commented] (OFBIZ-7218) Refactor components regarding groovy file locations

2016-06-14 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329046#comment-15329046
 ] 

Deepak Dixit commented on OFBIZ-7218:
-

Thanks [~jacques.le.roux] :)

> Refactor components regarding groovy file locations
> ---
>
> Key: OFBIZ-7218
> URL: https://issues.apache.org/jira/browse/OFBIZ-7218
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
> Fix For: Upcoming Branch
>
>
> This is a placeholder issue to capture all tasks and related issues regarding 
> the refactoring of the directory structure of .groovy files.
> See related discussion: http://ofbiz.markmail.org/message/25dse4jke2fp64mx
> Nicolas Malin's comments from OFBIZ-6810
> {quote}
> http://markmail.org/thread/kyhgfykfiwhz#query:+page:1+mid:hemokyhcnpe4w5rn+state:results
> At the question :
> Regard to the issue, we have no problem for the java and minilang files 
> but the groovy need a community decision.
> A) All groovy script under the same path src/main/groovy/...
> B) Separate Groovy compiled and scripted like this src/main/groovy/... 
> (pre-compiled Groovy) src/main/scripts/... (parsed Groovy scripts)
> C) Separate Groovy compiled and scripted like this groovy/... 
> (pre-compiled Groovy) groovyScripts/... (parsed Groovy scripts, groovyScripts 
> rather that script because other script languages could be used in the future)
> D) other if you have an ingenious idea
> the result is :
> Total are :
> A) -5
> B) 0
> C) +7
> D) No other proposal
> Now we can move all groovy script present on 
> component://componentname/webapp/componentname/WEB-INF/actions/script.groovy 
> to component://componentname/groovyscript/script.groovy
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7218) Refactor components regarding groovy file locations

2016-06-14 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329045#comment-15329045
 ] 

Deepak Dixit commented on OFBIZ-7218:
-

Thanks [~jacques.le.roux]

> Refactor components regarding groovy file locations
> ---
>
> Key: OFBIZ-7218
> URL: https://issues.apache.org/jira/browse/OFBIZ-7218
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
> Fix For: Upcoming Branch
>
>
> This is a placeholder issue to capture all tasks and related issues regarding 
> the refactoring of the directory structure of .groovy files.
> See related discussion: http://ofbiz.markmail.org/message/25dse4jke2fp64mx
> Nicolas Malin's comments from OFBIZ-6810
> {quote}
> http://markmail.org/thread/kyhgfykfiwhz#query:+page:1+mid:hemokyhcnpe4w5rn+state:results
> At the question :
> Regard to the issue, we have no problem for the java and minilang files 
> but the groovy need a community decision.
> A) All groovy script under the same path src/main/groovy/...
> B) Separate Groovy compiled and scripted like this src/main/groovy/... 
> (pre-compiled Groovy) src/main/scripts/... (parsed Groovy scripts)
> C) Separate Groovy compiled and scripted like this groovy/... 
> (pre-compiled Groovy) groovyScripts/... (parsed Groovy scripts, groovyScripts 
> rather that script because other script languages could be used in the future)
> D) other if you have an ingenious idea
> the result is :
> Total are :
> A) -5
> B) 0
> C) +7
> D) No other proposal
> Now we can move all groovy script present on 
> component://componentname/webapp/componentname/WEB-INF/actions/script.groovy 
> to component://componentname/groovyscript/script.groovy
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7218) Refactor components regarding groovy file locations

2016-06-13 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327718#comment-15327718
 ] 

Jacques Le Roux commented on OFBIZ-7218:


It's ok as is, this is only to enhance Ant. BTW, kudos for the hard work Deepak!

> Refactor components regarding groovy file locations
> ---
>
> Key: OFBIZ-7218
> URL: https://issues.apache.org/jira/browse/OFBIZ-7218
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
> Fix For: Upcoming Branch
>
>
> This is a placeholder issue to capture all tasks and related issues regarding 
> the refactoring of the directory structure of .groovy files.
> See related discussion: http://ofbiz.markmail.org/message/25dse4jke2fp64mx
> Nicolas Malin's comments from OFBIZ-6810
> {quote}
> http://markmail.org/thread/kyhgfykfiwhz#query:+page:1+mid:hemokyhcnpe4w5rn+state:results
> At the question :
> Regard to the issue, we have no problem for the java and minilang files 
> but the groovy need a community decision.
> A) All groovy script under the same path src/main/groovy/...
> B) Separate Groovy compiled and scripted like this src/main/groovy/... 
> (pre-compiled Groovy) src/main/scripts/... (parsed Groovy scripts)
> C) Separate Groovy compiled and scripted like this groovy/... 
> (pre-compiled Groovy) groovyScripts/... (parsed Groovy scripts, groovyScripts 
> rather that script because other script languages could be used in the future)
> D) other if you have an ingenious idea
> the result is :
> Total are :
> A) -5
> B) 0
> C) +7
> D) No other proposal
> Now we can move all groovy script present on 
> component://componentname/webapp/componentname/WEB-INF/actions/script.groovy 
> to component://componentname/groovyscript/script.groovy
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7218) Refactor components regarding groovy file locations

2016-06-13 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327395#comment-15327395
 ] 

Deepak Dixit commented on OFBIZ-7218:
-

I did not change it if-script.groovy name, located at 
framework/base/ant-scripts/if-script.groovy. I don't know where its included 
and how to test it.

> Refactor components regarding groovy file locations
> ---
>
> Key: OFBIZ-7218
> URL: https://issues.apache.org/jira/browse/OFBIZ-7218
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
> Fix For: Upcoming Branch
>
>
> This is a placeholder issue to capture all tasks and related issues regarding 
> the refactoring of the directory structure of .groovy files.
> See related discussion: http://ofbiz.markmail.org/message/25dse4jke2fp64mx
> Nicolas Malin's comments from OFBIZ-6810
> {quote}
> http://markmail.org/thread/kyhgfykfiwhz#query:+page:1+mid:hemokyhcnpe4w5rn+state:results
> At the question :
> Regard to the issue, we have no problem for the java and minilang files 
> but the groovy need a community decision.
> A) All groovy script under the same path src/main/groovy/...
> B) Separate Groovy compiled and scripted like this src/main/groovy/... 
> (pre-compiled Groovy) src/main/scripts/... (parsed Groovy scripts)
> C) Separate Groovy compiled and scripted like this groovy/... 
> (pre-compiled Groovy) groovyScripts/... (parsed Groovy scripts, groovyScripts 
> rather that script because other script languages could be used in the future)
> D) other if you have an ingenious idea
> the result is :
> Total are :
> A) -5
> B) 0
> C) +7
> D) No other proposal
> Now we can move all groovy script present on 
> component://componentname/webapp/componentname/WEB-INF/actions/script.groovy 
> to component://componentname/groovyscript/script.groovy
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7218) Refactor components regarding groovy file locations

2016-06-10 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15325740#comment-15325740
 ] 

Deepak Dixit commented on OFBIZ-7218:
-

Relocate specialpurpose/projectmgr groovy file at r#1747848

> Refactor components regarding groovy file locations
> ---
>
> Key: OFBIZ-7218
> URL: https://issues.apache.org/jira/browse/OFBIZ-7218
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
>
> This is a placeholder issue to capture all tasks and related issues regarding 
> the refactoring of the directory structure of .groovy files.
> See related discussion: http://ofbiz.markmail.org/message/25dse4jke2fp64mx
> Nicolas Malin's comments from OFBIZ-6810
> {quote}
> http://markmail.org/thread/kyhgfykfiwhz#query:+page:1+mid:hemokyhcnpe4w5rn+state:results
> At the question :
> Regard to the issue, we have no problem for the java and minilang files 
> but the groovy need a community decision.
> A) All groovy script under the same path src/main/groovy/...
> B) Separate Groovy compiled and scripted like this src/main/groovy/... 
> (pre-compiled Groovy) src/main/scripts/... (parsed Groovy scripts)
> C) Separate Groovy compiled and scripted like this groovy/... 
> (pre-compiled Groovy) groovyScripts/... (parsed Groovy scripts, groovyScripts 
> rather that script because other script languages could be used in the future)
> D) other if you have an ingenious idea
> the result is :
> Total are :
> A) -5
> B) 0
> C) +7
> D) No other proposal
> Now we can move all groovy script present on 
> component://componentname/webapp/componentname/WEB-INF/actions/script.groovy 
> to component://componentname/groovyscript/script.groovy
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7218) Refactor components regarding groovy file locations

2016-06-10 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15325199#comment-15325199
 ] 

Deepak Dixit commented on OFBIZ-7218:
-

Here is the ticket id for minilang work OFBIZ-7267

> Refactor components regarding groovy file locations
> ---
>
> Key: OFBIZ-7218
> URL: https://issues.apache.org/jira/browse/OFBIZ-7218
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
>
> This is a placeholder issue to capture all tasks and related issues regarding 
> the refactoring of the directory structure of .groovy files.
> See related discussion: http://ofbiz.markmail.org/message/25dse4jke2fp64mx
> Nicolas Malin's comments from OFBIZ-6810
> {quote}
> http://markmail.org/thread/kyhgfykfiwhz#query:+page:1+mid:hemokyhcnpe4w5rn+state:results
> At the question :
> Regard to the issue, we have no problem for the java and minilang files 
> but the groovy need a community decision.
> A) All groovy script under the same path src/main/groovy/...
> B) Separate Groovy compiled and scripted like this src/main/groovy/... 
> (pre-compiled Groovy) src/main/scripts/... (parsed Groovy scripts)
> C) Separate Groovy compiled and scripted like this groovy/... 
> (pre-compiled Groovy) groovyScripts/... (parsed Groovy scripts, groovyScripts 
> rather that script because other script languages could be used in the future)
> D) other if you have an ingenious idea
> the result is :
> Total are :
> A) -5
> B) 0
> C) +7
> D) No other proposal
> Now we can move all groovy script present on 
> component://componentname/webapp/componentname/WEB-INF/actions/script.groovy 
> to component://componentname/groovyscript/script.groovy
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7218) Refactor components regarding groovy file locations

2016-06-08 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320242#comment-15320242
 ] 

Jacques Le Roux commented on OFBIZ-7218:


Following [Nicolas's 
comment|https://issues.apache.org/jira/browse/OFBIZ-6810?focusedCommentId=15201384]
 I also suggested to move minilang scripts from 
component://componentname/script/org/ofbiz 
to 
component://componentname/minilang
I'll create a Jira for that



> Refactor components regarding groovy file locations
> ---
>
> Key: OFBIZ-7218
> URL: https://issues.apache.org/jira/browse/OFBIZ-7218
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
>
> This is a placeholder issue to capture all tasks and related issues regarding 
> the refactoring of the directory structure of .groovy files.
> See related discussion: http://ofbiz.markmail.org/message/25dse4jke2fp64mx
> Nicolas Malin's comments from OFBIZ-6810
> {quote}
> http://markmail.org/thread/kyhgfykfiwhz#query:+page:1+mid:hemokyhcnpe4w5rn+state:results
> At the question :
> Regard to the issue, we have no problem for the java and minilang files 
> but the groovy need a community decision.
> A) All groovy script under the same path src/main/groovy/...
> B) Separate Groovy compiled and scripted like this src/main/groovy/... 
> (pre-compiled Groovy) src/main/scripts/... (parsed Groovy scripts)
> C) Separate Groovy compiled and scripted like this groovy/... 
> (pre-compiled Groovy) groovyScripts/... (parsed Groovy scripts, groovyScripts 
> rather that script because other script languages could be used in the future)
> D) other if you have an ingenious idea
> the result is :
> Total are :
> A) -5
> B) 0
> C) +7
> D) No other proposal
> Now we can move all groovy script present on 
> component://componentname/webapp/componentname/WEB-INF/actions/script.groovy 
> to component://componentname/groovyscript/script.groovy
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)