[jira] [Commented] (OFBIZ-7511) Add proper form validation across the application
[
https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344183#comment-15344183
]
Nicolas Malin commented on OFBIZ-7511:
--
Thanks Diversh for the explanation, I had some difficulty than Jacques to
understand exactly the problem.
When we extend a form we can surcharge a field with only the wanted attribute
to complete or change. Maybe override a field came from auto-field-* element
would be treated like that.
{code}
{code}
Or for not disturbing developer and xsd, we can change the field analyse like
service definition
{code}
{code}
I quite aware of going off on a tangent, but sometime an hight level idea can
resolve a specif case and some others ! :)
> Add proper form validation across the application
> --
>
> Key: OFBIZ-7511
> URL: https://issues.apache.org/jira/browse/OFBIZ-7511
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Deepak Dixit
>
> This is the place holder task for adding proper form validation across the
> application.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7511) Add proper form validation across the application
[
https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344102#comment-15344102
]
Jacques Le Roux commented on OFBIZ-7511:
OK, this was not quite clear to me. I was expecting we could replace
auto-field-service by automating it, like having
{code}
{code}
See no need for auto-field-service. If it's not there, we assume we should do
the same automatically when parsing
But now that I think about it, it maybe adds more confusion than anything else
:D Verbosity has its advantages!
So +1 for the consensus.
> Add proper form validation across the application
> --
>
> Key: OFBIZ-7511
> URL: https://issues.apache.org/jira/browse/OFBIZ-7511
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Deepak Dixit
>
> This is the place holder task for adding proper form validation across the
> application.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7511) Add proper form validation across the application
[
https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343992#comment-15343992
]
Divesh Dutta commented on OFBIZ-7511:
-
[~jacques.le.roux] this discussion has been concluded. There was confusion in
actual problem area. Actually the problem area is:
When you use auto-field-service in form say for eg:
{code}
{code}
Then exampleFeatureId is mandatory field in this form because exampleFeatureId
is mandatory attribute of service. Now if you create same form then where you
want to use tool tip in exampleFeatureId ,
{code}
{code}
In this case, you have overridden the exampleFeatureId field, but during
overriding required property is lost. And to solve this problem, Deepak is
recommending that when you override the field , then by default required
property should be inherited from auto-fields service, so that developer does
not have to explicitly define required-field=true . And we agreed on this
proposal of Deepak .
So we agreed on solution which maximally automates. Hope this helps to
understand the problem area and solution concluded.
> Add proper form validation across the application
> --
>
> Key: OFBIZ-7511
> URL: https://issues.apache.org/jira/browse/OFBIZ-7511
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Deepak Dixit
>
> This is the place holder task for adding proper form validation across the
> application.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7511) Add proper form validation across the application
[ https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343963#comment-15343963 ] Jacques Le Roux commented on OFBIZ-7511: When I have to choice I always prefer the solution which maximally automates (and I guess most of us do ;)). It seems Deepak proposition fits here. Let me resume to see if we are all on the same page. If a form uses a service, instead of using the manual auto-field-service element, we would have a widget coded mechanism able to automaticaly infer the field to be rendered as required, based on the service definition. So auto-field-service would be deprecated, we could remove it. But of course in case you would need to change the default behaviour (required true from service) and have a field not required a required-field attribute forced to false would be used. > Add proper form validation across the application > -- > > Key: OFBIZ-7511 > URL: https://issues.apache.org/jira/browse/OFBIZ-7511 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Deepak Dixit > > This is the place holder task for adding proper form validation across the > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7511) Add proper form validation across the application
[ https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343882#comment-15343882 ] Divesh Dutta commented on OFBIZ-7511: - Yea this solution makes sense Deepak. > Add proper form validation across the application > -- > > Key: OFBIZ-7511 > URL: https://issues.apache.org/jira/browse/OFBIZ-7511 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Deepak Dixit > > This is the place holder task for adding proper form validation across the > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7511) Add proper form validation across the application
[ https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343867#comment-15343867 ] Deepak Dixit commented on OFBIZ-7511: - Make sense Divesh, developer should use auto-service-field when ever possible. I had a discussion with [~diveshdut] regarding this, and we found that if we use auto-field-service and than override field in form than its override the required-filed behavior and set it to false. I think here we can fix/improve the auto-field-service behavior, If an field is set required true by auto-field-service than form field should not override this behavior until unless explicitly set required-fiedd in overridden attribute > Add proper form validation across the application > -- > > Key: OFBIZ-7511 > URL: https://issues.apache.org/jira/browse/OFBIZ-7511 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Deepak Dixit > > This is the place holder task for adding proper form validation across the > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7511) Add proper form validation across the application
[ https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343748#comment-15343748 ] Deepak Dixit commented on OFBIZ-7511: - If we can enhance form rendering then why go and add required filed on each form? If form uses auto-fields service then its done by default, and if form not using auto-fields service then we can enhance form widget. I am done with my part :) If still it make sense to go and add required-field on each form than its fine I don't have any concern. > Add proper form validation across the application > -- > > Key: OFBIZ-7511 > URL: https://issues.apache.org/jira/browse/OFBIZ-7511 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Deepak Dixit > > This is the place holder task for adding proper form validation across the > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7511) Add proper form validation across the application
[ https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343744#comment-15343744 ] Divesh Dutta commented on OFBIZ-7511: - why will we not use auto-fields-service ? :) Develper should use auto-field service when ever possible, and when developer will use auto-field-service then we don't have to work on solution you are proposing. > Add proper form validation across the application > -- > > Key: OFBIZ-7511 > URL: https://issues.apache.org/jira/browse/OFBIZ-7511 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Deepak Dixit > > This is the place holder task for adding proper form validation across the > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7511) Add proper form validation across the application
[ https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343738#comment-15343738 ] Divesh Dutta commented on OFBIZ-7511: - Also I agree with Mridul that when we already have auto-fields-feature which allows you to render all the fields of service in form and put required validation on fields in forms which are not optional in service, then why we are you proposing to identify request with an event of type service and then putting validations. auto-fields service already does the job. > Add proper form validation across the application > -- > > Key: OFBIZ-7511 > URL: https://issues.apache.org/jira/browse/OFBIZ-7511 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Deepak Dixit > > This is the place holder task for adding proper form validation across the > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7511) Add proper form validation across the application
[ https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342039#comment-15342039 ] Deepak Dixit commented on OFBIZ-7511: - I am not getting the point "override validation like auto-field-service provide?' I think currently we don't have any option in auto-field-service to override required field. I am not proposing to remove required-field attribute if user want to override it so he can use required-field to override behavior. > Add proper form validation across the application > -- > > Key: OFBIZ-7511 > URL: https://issues.apache.org/jira/browse/OFBIZ-7511 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Deepak Dixit > > This is the place holder task for adding proper form validation across the > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7511) Add proper form validation across the application
[ https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341937#comment-15341937 ] Divesh Dutta commented on OFBIZ-7511: - Ok, [~deepak.dixit] I am getting your point. Your solution will work when we call service. But in case of event this solution will not work and in that case we will have to explicitly define required field in form as done in this task. So I think the solution you are proposing is not generic. > Add proper form validation across the application > -- > > Key: OFBIZ-7511 > URL: https://issues.apache.org/jira/browse/OFBIZ-7511 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Deepak Dixit > > This is the place holder task for adding proper form validation across the > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7511) Add proper form validation across the application
[ https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341919#comment-15341919 ] Mridul Pathak commented on OFBIZ-7511: -- If we are rendering validations by default through form renderer using the auto-field-service validation, would there still be the flexibility to override validation like auto-field-service provide? > Add proper form validation across the application > -- > > Key: OFBIZ-7511 > URL: https://issues.apache.org/jira/browse/OFBIZ-7511 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Deepak Dixit > > This is the place holder task for adding proper form validation across the > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7511) Add proper form validation across the application
[ https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341879#comment-15341879 ] Deepak Dixit commented on OFBIZ-7511: - Hi [~mridul.pathak], How can we say its hardcoding? I am proposing same that used in auto-field-service, if we did not use auto-field-service in form, than we can use the target to analyze the required field. So this is not hard coding at rendering level. > Add proper form validation across the application > -- > > Key: OFBIZ-7511 > URL: https://issues.apache.org/jira/browse/OFBIZ-7511 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Deepak Dixit > > This is the place holder task for adding proper form validation across the > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7511) Add proper form validation across the application
[ https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341860#comment-15341860 ] Mridul Pathak commented on OFBIZ-7511: -- Hi [~deepak.dixit] auto-field-service tag does the job already and provides the required flexibility to override validations as well and when auto-field-service already provides this facility I do not see it as something that needs to be fixed at framework level. The problem I see here is that in many forms auto-field-service might have been used but when the fields are overridden validations are not applied properly and this is some thing that needs to be fixed. In fact, the approach you are suggesting seems to be hardcoding validations at the renderer level and would remove the flexibility we have at this moment, I might be mistaken though. > Add proper form validation across the application > -- > > Key: OFBIZ-7511 > URL: https://issues.apache.org/jira/browse/OFBIZ-7511 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Deepak Dixit > > This is the place holder task for adding proper form validation across the > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7511) Add proper form validation across the application
[ https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341833#comment-15341833 ] Deepak Dixit commented on OFBIZ-7511: - There is no bug in require-label attribute, I meant to we can fix or can say improve form render to handle the require-field based on target. > Add proper form validation across the application > -- > > Key: OFBIZ-7511 > URL: https://issues.apache.org/jira/browse/OFBIZ-7511 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Deepak Dixit > > This is the place holder task for adding proper form validation across the > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7511) Add proper form validation across the application
[ https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341829#comment-15341829 ] Deepak Dixit commented on OFBIZ-7511: - Thanks [~diveshdut] for your detailed input, My proposal to identify form request and if an event (type of service) is associated with request than we can use that to identify required fields and in OFBiz most of the forms are using request that call an service type of event. Currently we are using this pattern to render hyperlink whit link-type=auto. It check if request has an service type event then it create hidden form else it render the anchor tag. > Add proper form validation across the application > -- > > Key: OFBIZ-7511 > URL: https://issues.apache.org/jira/browse/OFBIZ-7511 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Deepak Dixit > > This is the place holder task for adding proper form validation across the > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7511) Add proper form validation across the application
[ https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341810#comment-15341810 ] Divesh Dutta commented on OFBIZ-7511: - auto-fields-service handles required option i.e if IN attribute is not optional then required is set to "true" in form widget. so where ever auto-fields-service is used fields will be automatically work as required field, but in forms where you want to make field mandatory but that field in not mandatory in service definition, there is no option available. Also forms which are directly not based on service, for those forms, there is no option available. So such cases, this is the only option available i.e you will have to define required explicitly in form. I don't see any thing to to be fixed at framework level here. Deepak what do you have in mind when you say we can fix this required-field at the time of form rendering. There is no bug in required-field. > Add proper form validation across the application > -- > > Key: OFBIZ-7511 > URL: https://issues.apache.org/jira/browse/OFBIZ-7511 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Deepak Dixit > > This is the place holder task for adding proper form validation across the > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7511) Add proper form validation across the application
[ https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339449#comment-15339449 ] Jacques Le Roux commented on OFBIZ-7511: Not sure about auto-filed-service tag in form, but +1 for the idea > Add proper form validation across the application > -- > > Key: OFBIZ-7511 > URL: https://issues.apache.org/jira/browse/OFBIZ-7511 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Deepak Dixit > > This is the place holder task for adding proper form validation across the > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7511) Add proper form validation across the application
[ https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339428#comment-15339428 ] Deepak Dixit commented on OFBIZ-7511: - I think we can fix this at framework level as well,instead of adding required-label field for all form, we can fix this required-field at the time of form rendering. I think this has been handled in auto-filed-service tag in form. > Add proper form validation across the application > -- > > Key: OFBIZ-7511 > URL: https://issues.apache.org/jira/browse/OFBIZ-7511 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Deepak Dixit > > This is the place holder task for adding proper form validation across the > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7511) Add proper form validation across the application
[ https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339315#comment-15339315 ] Deepak Dixit commented on OFBIZ-7511: - I'll create component level ticket as well :) > Add proper form validation across the application > -- > > Key: OFBIZ-7511 > URL: https://issues.apache.org/jira/browse/OFBIZ-7511 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Deepak Dixit > > This is the place holder task for adding proper form validation across the > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7511) Add proper form validation across the application
[ https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339312#comment-15339312 ] Amardeep Singh Jhajj commented on OFBIZ-7511: - +1. We have lot of screens where client side validation is missing, so component level effort seems to be correct approach instead of making tickets for each page. Thanks. > Add proper form validation across the application > -- > > Key: OFBIZ-7511 > URL: https://issues.apache.org/jira/browse/OFBIZ-7511 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Deepak Dixit > > This is the place holder task for adding proper form validation across the > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7511) Add proper form validation across the application
[ https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339310#comment-15339310 ] Jacques Le Roux commented on OFBIZ-7511: You miss something to do it? > Add proper form validation across the application > -- > > Key: OFBIZ-7511 > URL: https://issues.apache.org/jira/browse/OFBIZ-7511 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Deepak Dixit > > This is the place holder task for adding proper form validation across the > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7511) Add proper form validation across the application
[ https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339299#comment-15339299 ] Deepak Dixit commented on OFBIZ-7511: - I'd prefer component level ticket for this kind of effort :) > Add proper form validation across the application > -- > > Key: OFBIZ-7511 > URL: https://issues.apache.org/jira/browse/OFBIZ-7511 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Deepak Dixit > > This is the place holder task for adding proper form validation across the > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
