[jira] [Commented] (OFBIZ-7518) Unable to create Product Store Roles from Party manager
[ https://issues.apache.org/jira/browse/OFBIZ-7518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361654#comment-15361654 ] Divesh Dutta commented on OFBIZ-7518: - Thanks [~ankush.upadhyay] for your patch and thanks [~soledad] for your suggestion. Its committed in revision number 1751357 in trunk. release 14.12 - 1751359 release 15.12 - 1751360. > Unable to create Product Store Roles from Party manager > --- > > Key: OFBIZ-7518 > URL: https://issues.apache.org/jira/browse/OFBIZ-7518 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Upcoming Branch >Reporter: Ankush Upadhyay >Assignee: Divesh Dutta > Attachments: OFBIZ-7518.patch, ProductStoreRoleError.png > > > System throws error while adding new product store role. > Steps to reproduce: > 1. Login to party manager and go to Company party profile page. > 2. Navigate to Product Store Roles tab. > 3. Try to create new product store role for any product store and any > roleTypeId. > 4. System should show violation of foreign key constraint error. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7518) Unable to create Product Store Roles from Party manager
[ https://issues.apache.org/jira/browse/OFBIZ-7518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348195#comment-15348195 ] Ankush Upadhyay commented on OFBIZ-7518: Thanks [~soledad] for patch review, yes seca call is more adaptive and I missed the references so use service group concept. I have updated my patch and used seca call instead of service group. > Unable to create Product Store Roles from Party manager > --- > > Key: OFBIZ-7518 > URL: https://issues.apache.org/jira/browse/OFBIZ-7518 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Upcoming Branch >Reporter: Ankush Upadhyay >Assignee: Ankush Upadhyay > Attachments: OFBIZ-7518.patch, ProductStoreRoleError.png > > > System throws error while adding new product store role. > Steps to reproduce: > 1. Login to party manager and go to Company party profile page. > 2. Navigate to Product Store Roles tab. > 3. Try to create new product store role for any product store and any > roleTypeId. > 4. System should show violation of foreign key constraint error. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7518) Unable to create Product Store Roles from Party manager
[ https://issues.apache.org/jira/browse/OFBIZ-7518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343829#comment-15343829 ] Nicolas Malin commented on OFBIZ-7518: -- Hi Ankush, On the other case, ensurePartyRole is call by seca. What advantage to define this chain call on a service group ? It seems less adaptive than seca call > Unable to create Product Store Roles from Party manager > --- > > Key: OFBIZ-7518 > URL: https://issues.apache.org/jira/browse/OFBIZ-7518 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Upcoming Branch >Reporter: Ankush Upadhyay > Attachments: EnsureAndCreateProductStoreRole.patch, > ProductStoreRoleError.png, RenderPartyAssignedRolesInDropDown.patch > > > System throws error while adding new product store role. > Steps to reproduce: > 1. Login to party manager and go to Company party profile page. > 2. Navigate to Product Store Roles tab. > 3. Try to create new product store role for any product store and any > roleTypeId. > 4. System should show violation of foreign key constraint error. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7518) Unable to create Product Store Roles from Party manager
[ https://issues.apache.org/jira/browse/OFBIZ-7518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341107#comment-15341107 ] Ankush Upadhyay commented on OFBIZ-7518: Further researched on this and found that there are some more places from where createProductStoreRole calls but good thing is all wrapper methods creates role first and then call createProductStoreRole service so we don't need to worry about those places. Here are the wrapper methods: 1. createUser from UserEvents.xml 2. createEbayAccount from EbayServices.xml 3. createCustomer from CustomerEvents.xml 4. createCustomerProfile from CustomerEvents.xml > Unable to create Product Store Roles from Party manager > --- > > Key: OFBIZ-7518 > URL: https://issues.apache.org/jira/browse/OFBIZ-7518 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Upcoming Branch >Reporter: Ankush Upadhyay > Attachments: EnsureAndCreateProductStoreRole.patch, > ProductStoreRoleError.png, RenderPartyAssignedRolesInDropDown.patch > > > System throws error while adding new product store role. > Steps to reproduce: > 1. Login to party manager and go to Company party profile page. > 2. Navigate to Product Store Roles tab. > 3. Try to create new product store role for any product store and any > roleTypeId. > 4. System should show violation of foreign key constraint error. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7518) Unable to create Product Store Roles from Party manager
[ https://issues.apache.org/jira/browse/OFBIZ-7518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339863#comment-15339863 ] Ankush Upadhyay commented on OFBIZ-7518: I researched on this issue and found that this issue occurs only if PartyRole is not existed for the party with supplied roleTypeId. if the party is added to the role from Roles tab then functionality is working as expected. For the fix we have following two options: 1. Render only those roles assigned to party instead of render all available roles from RoleType entity. 2. We can call "ensurePartyRole" before ProductStoreRole creation service. I am attaching both the fix so that community can review and provide suggestion on the better fix of this issue. > Unable to create Product Store Roles from Party manager > --- > > Key: OFBIZ-7518 > URL: https://issues.apache.org/jira/browse/OFBIZ-7518 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Upcoming Branch >Reporter: Ankush Upadhyay > Attachments: ProductStoreRoleError.png > > > System throws error while adding new product store role. > Steps to reproduce: > 1. Login to party manager and go to Company party profile page. > 2. Navigate to Product Store Roles tab. > 3. Try to create new product store role for any product store and any > roleTypeId. > 4. System should show violation of foreign key constraint error. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
