[jira] [Commented] (OFBIZ-7611) Track userlogin for status change
[ https://issues.apache.org/jira/browse/OFBIZ-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15363629#comment-15363629 ] Nameet Jain commented on OFBIZ-7611: Thank you [~soledad], I will review all the subtask and update patches to use this concept. > Track userlogin for status change > - > > Key: OFBIZ-7611 > URL: https://issues.apache.org/jira/browse/OFBIZ-7611 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Nicolas Malin > Attachments: OFBIZ-7611.patch, OFBIZ-7611.patch > > > Currently in OFBiz, 'changedByUserLoginId' field is missing from status > entities (like: ShipmentStatus). Using this field we can maintain the history > for each status change made by user. > Update all respective service and events to ensure this field gets updated. > Here is the list of entities with missing this field. > 1. BudgetStatus > 2. ContactListCommStatus > 3. CustRequestStatus > 4. ExampleStatus > 5. FinAccountStatus > 6. InventoryItemStatus > 7. InvoiceStatus > 8. PartyStatus > 9. RequirementStatus > 10. ShipmentStatus -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7611) Track userlogin for status change
[ https://issues.apache.org/jira/browse/OFBIZ-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15363088#comment-15363088 ] Nicolas Malin commented on OFBIZ-7611: -- I commit the first version on trunk at revision 1751530. We can review the subtask to use this concept :) > Track userlogin for status change > - > > Key: OFBIZ-7611 > URL: https://issues.apache.org/jira/browse/OFBIZ-7611 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Nicolas Malin > Attachments: OFBIZ-7611.patch, OFBIZ-7611.patch > > > Currently in OFBiz, 'changedByUserLoginId' field is missing from status > entities (like: ShipmentStatus). Using this field we can maintain the history > for each status change made by user. > Update all respective service and events to ensure this field gets updated. > Here is the list of entities with missing this field. > 1. BudgetStatus > 2. ContactListCommStatus > 3. CustRequestStatus > 4. ExampleStatus > 5. FinAccountStatus > 6. InventoryItemStatus > 7. InvoiceStatus > 8. PartyStatus > 9. RequirementStatus > 10. ShipmentStatus -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7611) Track userlogin for status change
[ https://issues.apache.org/jira/browse/OFBIZ-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362013#comment-15362013 ] Nameet Jain commented on OFBIZ-7611: Sure make sense. > Track userlogin for status change > - > > Key: OFBIZ-7611 > URL: https://issues.apache.org/jira/browse/OFBIZ-7611 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Nicolas Malin > Attachments: OFBIZ-7611.patch, OFBIZ-7611.patch > > > Currently in OFBiz, 'changedByUserLoginId' field is missing from status > entities (like: ShipmentStatus). Using this field we can maintain the history > for each status change made by user. > Update all respective service and events to ensure this field gets updated. > Here is the list of entities with missing this field. > 1. BudgetStatus > 2. ContactListCommStatus > 3. CustRequestStatus > 4. ExampleStatus > 5. FinAccountStatus > 6. InventoryItemStatus > 7. InvoiceStatus > 8. PartyStatus > 9. RequirementStatus > 10. ShipmentStatus -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7611) Track userlogin for status change
[ https://issues.apache.org/jira/browse/OFBIZ-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360145#comment-15360145 ] Nicolas Malin commented on OFBIZ-7611: -- Yes you right, you start just to add changeByUserLoginId field and I continue the idea to define a EntityStatus concept manage by entity-auto and help developer to respect it. I think we can just change the issues name and get it all done in one fell swoop ? I can finish the entity improvement and we use subtask to add the missing field like you already done, add the create service by entity-auto and propagate his call > Track userlogin for status change > - > > Key: OFBIZ-7611 > URL: https://issues.apache.org/jira/browse/OFBIZ-7611 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Nicolas Malin > Attachments: OFBIZ-7611.patch, OFBIZ-7611.patch > > > Currently in OFBiz, 'changedByUserLoginId' field is missing from status > entities (like: ShipmentStatus). Using this field we can maintain the history > for each status change made by user. > Update all respective service and events to ensure this field gets updated. > Here is the list of entities with missing this field. > 1. BudgetStatus > 2. ContactListCommStatus > 3. CustRequestStatus > 4. ExampleStatus > 5. FinAccountStatus > 6. InventoryItemStatus > 7. InvoiceStatus > 8. PartyStatus > 9. RequirementStatus > 10. ShipmentStatus -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7611) Track userlogin for status change
[ https://issues.apache.org/jira/browse/OFBIZ-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360018#comment-15360018 ] Nameet Jain commented on OFBIZ-7611: On a second thought, should we enforce to have these two fields "changeByUserLoginId" and "statusDate" compulsory for the status entities? Also, we have multiple fields for the same purpose. Can we do something about it in the scope of another task? > Track userlogin for status change > - > > Key: OFBIZ-7611 > URL: https://issues.apache.org/jira/browse/OFBIZ-7611 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Nicolas Malin > Attachments: OFBIZ-7611.patch, OFBIZ-7611.patch > > > Currently in OFBiz, 'changedByUserLoginId' field is missing from status > entities (like: ShipmentStatus). Using this field we can maintain the history > for each status change made by user. > Update all respective service and events to ensure this field gets updated. > Here is the list of entities with missing this field. > 1. BudgetStatus > 2. ContactListCommStatus > 3. CustRequestStatus > 4. ExampleStatus > 5. FinAccountStatus > 6. InventoryItemStatus > 7. InvoiceStatus > 8. PartyStatus > 9. RequirementStatus > 10. ShipmentStatus -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7611) Track userlogin for status change
[ https://issues.apache.org/jira/browse/OFBIZ-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360014#comment-15360014 ] Nameet Jain commented on OFBIZ-7611: Hi [~soledad] I am perfectly ok with the patch. Only to confirm my understanding, with the patch we are enforcing here that if someone is using "entity-auto" and has "changeByUserLoginId" then he cannot update or delete the status entity record. With the previous patch also we cannot update the "changeByUserLoginId" field :-). Thanks > Track userlogin for status change > - > > Key: OFBIZ-7611 > URL: https://issues.apache.org/jira/browse/OFBIZ-7611 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Nicolas Malin > Attachments: OFBIZ-7611.patch, OFBIZ-7611.patch > > > Currently in OFBiz, 'changedByUserLoginId' field is missing from status > entities (like: ShipmentStatus). Using this field we can maintain the history > for each status change made by user. > Update all respective service and events to ensure this field gets updated. > Here is the list of entities with missing this field. > 1. BudgetStatus > 2. ContactListCommStatus > 3. CustRequestStatus > 4. ExampleStatus > 5. FinAccountStatus > 6. InventoryItemStatus > 7. InvoiceStatus > 8. PartyStatus > 9. RequirementStatus > 10. ShipmentStatus -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7611) Track userlogin for status change
[ https://issues.apache.org/jira/browse/OFBIZ-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358768#comment-15358768 ] Nameet Jain commented on OFBIZ-7611: Sure :) > Track userlogin for status change > - > > Key: OFBIZ-7611 > URL: https://issues.apache.org/jira/browse/OFBIZ-7611 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Nicolas Malin > Attachments: OFBIZ-7611.patch > > > Currently in OFBiz, 'changedByUserLoginId' field is missing from status > entities (like: ShipmentStatus). Using this field we can maintain the history > for each status change made by user. > Update all respective service and events to ensure this field gets updated. > Here is the list of entities with missing this field. > 1. BudgetStatus > 2. ContactListCommStatus > 3. CustRequestStatus > 4. ExampleStatus > 5. FinAccountStatus > 6. InventoryItemStatus > 7. InvoiceStatus > 8. PartyStatus > 9. RequirementStatus > 10. ShipmentStatus -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7611) Track userlogin for status change
[ https://issues.apache.org/jira/browse/OFBIZ-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358654#comment-15358654 ] Nicolas Malin commented on OFBIZ-7611: -- Oh nice Nameet, I will continue, I have some idea in my brain ;) > Track userlogin for status change > - > > Key: OFBIZ-7611 > URL: https://issues.apache.org/jira/browse/OFBIZ-7611 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Nicolas Malin > Attachments: OFBIZ-7611.patch > > > Currently in OFBiz, 'changedByUserLoginId' field is missing from status > entities (like: ShipmentStatus). Using this field we can maintain the history > for each status change made by user. > Update all respective service and events to ensure this field gets updated. > Here is the list of entities with missing this field. > 1. BudgetStatus > 2. ContactListCommStatus > 3. CustRequestStatus > 4. ExampleStatus > 5. FinAccountStatus > 6. InventoryItemStatus > 7. InvoiceStatus > 8. PartyStatus > 9. RequirementStatus > 10. ShipmentStatus -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7611) Track userlogin for status change
[ https://issues.apache.org/jira/browse/OFBIZ-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357735#comment-15357735 ] Nicolas Malin commented on OFBIZ-7611: -- Nameet, I am hesitant. I review your patch, no problem with you work. I just a doubt an the solution. I think we can realize a beautiful implementation of your initial proposition with improve the entity-auto and automatically manage this field and the statusDate by the engine. You won't mind if I will try to improve the entity-engine before commit your works ? > Track userlogin for status change > - > > Key: OFBIZ-7611 > URL: https://issues.apache.org/jira/browse/OFBIZ-7611 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Nicolas Malin > > Currently in OFBiz, 'changedByUserLoginId' field is missing from status > entities (like: ShipmentStatus). Using this field we can maintain the history > for each status change made by user. > Update all respective service and events to ensure this field gets updated. > Here is the list of entities with missing this field. > 1. BudgetStatus > 2. ContactListCommStatus > 3. CustRequestStatus > 4. ExampleStatus > 5. FinAccountStatus > 6. InventoryItemStatus > 7. InvoiceStatus > 8. PartyStatus > 9. RequirementStatus > 10. ShipmentStatus -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7611) Track userlogin for status change
[ https://issues.apache.org/jira/browse/OFBIZ-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15356286#comment-15356286 ] Nameet Jain commented on OFBIZ-7611: Hi [~utcb], You are right "enable-audit-log" is also a candidate used for tracking. If we set "enable-audit-log" on the field to true, it will create a record in entity "EntityAuditLog" from where we track which entity or field was changed, what was the previous value, what is the updated value, who changed it, when it was changed and so on. What I understand about using this setting majorly with entity fields whose data is very crucial and sensitive. Also, - Using "enable-audit-log" adds overhead and performance degradation. - When we want to show status history (same as Order history shown on orderview screen) on respective overview screen using "EntityAuditLog" is an additional work to do. - By the time when data will grow fetching details from this entity will also be a heavy job for the system. I think that's the reason why we have "changeByUserLogin", "lastModifiedByUserLogin" and such other field on multiple entities to show information to user. > Track userlogin for status change > - > > Key: OFBIZ-7611 > URL: https://issues.apache.org/jira/browse/OFBIZ-7611 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Nicolas Malin > > Currently in OFBiz, 'changedByUserLoginId' field is missing from status > entities (like: ShipmentStatus). Using this field we can maintain the history > for each status change made by user. > Update all respective service and events to ensure this field gets updated. > Here is the list of entities with missing this field. > 1. BudgetStatus > 2. ContactListCommStatus > 3. CustRequestStatus > 4. ExampleStatus > 5. FinAccountStatus > 6. InventoryItemStatus > 7. InvoiceStatus > 8. PartyStatus > 9. RequirementStatus > 10. ShipmentStatus -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7611) Track userlogin for status change
[ https://issues.apache.org/jira/browse/OFBIZ-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15355724#comment-15355724 ] Nicolas Malin commented on OFBIZ-7611: -- enable-audit-log is complex technical element to analyse what's going on. The advantage to add changeByUserLoginId on spotted entities is to present this information to end user (it's not easy with audit-log) > Track userlogin for status change > - > > Key: OFBIZ-7611 > URL: https://issues.apache.org/jira/browse/OFBIZ-7611 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Nicolas Malin > > Currently in OFBiz, 'changedByUserLoginId' field is missing from status > entities (like: ShipmentStatus). Using this field we can maintain the history > for each status change made by user. > Update all respective service and events to ensure this field gets updated. > Here is the list of entities with missing this field. > 1. BudgetStatus > 2. ContactListCommStatus > 3. CustRequestStatus > 4. ExampleStatus > 5. FinAccountStatus > 6. InventoryItemStatus > 7. InvoiceStatus > 8. PartyStatus > 9. RequirementStatus > 10. ShipmentStatus -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7611) Track userlogin for status change
[ https://issues.apache.org/jira/browse/OFBIZ-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15354667#comment-15354667 ] Leon commented on OFBIZ-7611: - why not use "enable-audit-log" instead? > Track userlogin for status change > - > > Key: OFBIZ-7611 > URL: https://issues.apache.org/jira/browse/OFBIZ-7611 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Nicolas Malin > > Currently in OFBiz, 'changedByUserLoginId' field is missing from status > entities (like: ShipmentStatus). Using this field we can maintain the history > for each status change made by user. > Update all respective service and events to ensure this field gets updated. > Here is the list of entities with missing this field. > 1. BudgetStatus > 2. ContactListCommStatus > 3. CustRequestStatus > 4. ExampleStatus > 5. FinAccountStatus > 6. InventoryItemStatus > 7. InvoiceStatus > 8. PartyStatus > 9. RequirementStatus > 10. ShipmentStatus -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7611) Track userlogin for status change
[ https://issues.apache.org/jira/browse/OFBIZ-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352981#comment-15352981 ] Nameet Jain commented on OFBIZ-7611: I have started on this task and will upload the patches soon in the child task. > Track userlogin for status change > - > > Key: OFBIZ-7611 > URL: https://issues.apache.org/jira/browse/OFBIZ-7611 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Nicolas Malin > > Currently in OFBiz, 'changedByUserLoginId' field is missing from status > entities (like: ShipmentStatus). Using this field we can maintain the history > for each status change made by user. > Update all respective service and events to ensure this field gets updated. > Here is the list of entities with missing this field. > 1. BudgetStatus > 2. ContactListCommStatus > 3. CustRequestStatus > 4. ExampleStatus > 5. FinAccountStatus > 6. InventoryItemStatus > 7. InvoiceStatus > 8. PartyStatus > 9. RequirementStatus > 10. ShipmentStatus -- This message was sent by Atlassian JIRA (v6.3.4#6332)
