[jira] [Commented] (OFBIZ-7622) Add "changeByUserLoginId" field for CustRequestStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15373081#comment-15373081 ] Pierre Smits commented on OFBIZ-7622: - This is a sub-tasks of OFBIZ-7611. Not a separate issue. The governing description is covered in the parent issue. > Add "changeByUserLoginId" field for CustRequestStatus > - > > Key: OFBIZ-7622 > URL: https://issues.apache.org/jira/browse/OFBIZ-7622 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Julien NICOLAS > Attachments: OFBIZ-7622.patch, OFBIZ-7622.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7622) Add "changeByUserLoginId" field for CustRequestStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15373083#comment-15373083 ] Pierre Smits commented on OFBIZ-7622: - See OFBIZ-7781 > Add "changeByUserLoginId" field for CustRequestStatus > - > > Key: OFBIZ-7622 > URL: https://issues.apache.org/jira/browse/OFBIZ-7622 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Julien NICOLAS > Attachments: OFBIZ-7622.patch, OFBIZ-7622.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7622) Add "changeByUserLoginId" field for CustRequestStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15373072#comment-15373072 ] Jacques Le Roux commented on OFBIZ-7622: BTW Pierre, you spoke about bq. something like 'STAMP_FIELD' and such There is a specific mechanism for those special fields, it could be used for that too (with not only on/off but also the proposed status ternary). But, like Nameet and Rishi, I doubt we need that automated on all entities... Let's discuss it... > Add "changeByUserLoginId" field for CustRequestStatus > - > > Key: OFBIZ-7622 > URL: https://issues.apache.org/jira/browse/OFBIZ-7622 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Julien NICOLAS > Attachments: OFBIZ-7622.patch, OFBIZ-7622.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7622) Add "changeByUserLoginId" field for CustRequestStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15373064#comment-15373064 ] Jacques Le Roux commented on OFBIZ-7622: BTW this issue misses a minimal description of the needs and reasons why. This would, at 1st glance, clarifies what it's all about. A simple sentence would be enough, thanks! > Add "changeByUserLoginId" field for CustRequestStatus > - > > Key: OFBIZ-7622 > URL: https://issues.apache.org/jira/browse/OFBIZ-7622 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Julien NICOLAS > Attachments: OFBIZ-7622.patch, OFBIZ-7622.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7622) Add "changeByUserLoginId" field for CustRequestStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372985#comment-15372985 ] Pierre Smits commented on OFBIZ-7622: - I believe we should continue the bigger improvement issue in a new JIRA issue. This sub-task served its particular purpose, and any new comment added to the follow up could potentially confuse our adopter when they go through the release notes of the release this sub-task or its parent issue will be included in. I will open a new JIRA issue. > Add "changeByUserLoginId" field for CustRequestStatus > - > > Key: OFBIZ-7622 > URL: https://issues.apache.org/jira/browse/OFBIZ-7622 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Julien NICOLAS > Attachments: OFBIZ-7622.patch, OFBIZ-7622.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7622) Add "changeByUserLoginId" field for CustRequestStatus
[
https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372940#comment-15372940
]
Michael Brohl commented on OFBIZ-7622:
--
The discussion about making this configurable comes from Pierre's suggestion:
{quote}
Isn't it much better to extend the ModelEntity in ModelEntity.java, with
something like 'STAMP_FIELD' and such? And have that applied in GenericDAO.java?
Now it seems we have something implemented for a set of specific cases. But
having a 'changeByUserLoginId on every entity makes sense.
{quote}
I then stated:
{quote}
That could be a problem at least in Germany, where it is a very sensitive
subject because you could track when employees changed data and could monitor
their working behaviour. I did not deeply think about it, just a short notice
to think about before we implement such a feature.
{quote}
Maybe we should first decide *if* we want the "changeByUserLoginId" in every
entity. If the answer is "yes", we may have to deal with configuration of some
sort to switch it off.
> Add "changeByUserLoginId" field for CustRequestStatus
> -
>
> Key: OFBIZ-7622
> URL: https://issues.apache.org/jira/browse/OFBIZ-7622
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Nameet Jain
>Assignee: Julien NICOLAS
> Attachments: OFBIZ-7622.patch, OFBIZ-7622.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7622) Add "changeByUserLoginId" field for CustRequestStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372913#comment-15372913 ] Rishi Solanki commented on OFBIZ-7622: -- [~julien.nicolas]: Sorry I still disagree on this, to manage fields creation and its relationship in this way. In case we found more entities which requires the same field then we will be altering the final static map probably (defined to manage the list of entities manage this extra field). I think its better to have the entities fields with them, instead of create them from any configuration. Also we are increasing responsibilities of EntityAutoEngine or GenericDAO or ModelEntity. It could be out of scope but we should consider this before assigning more responsibilities to same class. I'm good, if we found some good reason to make it configurable. As I see for few entities change by user login is must from business perspective and for few it may be optional. So enabling/disabling all from one configuration seems okay to me, and managing it at entity level seems better. Thanks! > Add "changeByUserLoginId" field for CustRequestStatus > - > > Key: OFBIZ-7622 > URL: https://issues.apache.org/jira/browse/OFBIZ-7622 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Julien NICOLAS > Attachments: OFBIZ-7622.patch, OFBIZ-7622.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7622) Add "changeByUserLoginId" field for CustRequestStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372775#comment-15372775 ] Julien NICOLAS commented on OFBIZ-7622: --- So we can just manage entity status listed by the parent Jira and add the property in general.properties. If you want to continue to discuss on this topic, I think it could be interesting to use the parent topic comments. Regards, Julien. > Add "changeByUserLoginId" field for CustRequestStatus > - > > Key: OFBIZ-7622 > URL: https://issues.apache.org/jira/browse/OFBIZ-7622 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Julien NICOLAS > Attachments: OFBIZ-7622.patch, OFBIZ-7622.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7622) Add "changeByUserLoginId" field for CustRequestStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372739#comment-15372739 ] Nameet Jain commented on OFBIZ-7622: Totally agree with Rishi > Add "changeByUserLoginId" field for CustRequestStatus > - > > Key: OFBIZ-7622 > URL: https://issues.apache.org/jira/browse/OFBIZ-7622 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Julien NICOLAS > Attachments: OFBIZ-7622.patch, OFBIZ-7622.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7622) Add "changeByUserLoginId" field for CustRequestStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372717#comment-15372717 ] Pierre Smits commented on OFBIZ-7622: - [~rishisolankii]: you raise very valid concerns, which need to be taking inconsideration and we need to thread carefully when working towards an acceptable solution for all. > Add "changeByUserLoginId" field for CustRequestStatus > - > > Key: OFBIZ-7622 > URL: https://issues.apache.org/jira/browse/OFBIZ-7622 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Julien NICOLAS > Attachments: OFBIZ-7622.patch, OFBIZ-7622.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7622) Add "changeByUserLoginId" field for CustRequestStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372707#comment-15372707 ] Rishi Solanki commented on OFBIZ-7622: -- Adding user login at each entity and logging an additional filed for all and maintaining the relationship by default with UserLogin entity. In first look it looks like good idea, but it will come with many challenges. IMO, we should check the business needs of each entity and decide weather to do this for that entity or not. For example, for all the type entities do we really need change by userLogin?. Type entities are in hundreds, why should they maintain the relationship. Also all the intersection entities like PartyContactMech, ProductCategoryMember, ProductAssoc, ProductCategoryRollup and many more, why these entities requires this extra field and relationship? I would say many entities may require user login field, but all requires some discussion, review, and closer look before proceeding. Maintaining this like DATE fields is not look a good idea to me, instead adding this field wherever required after discussion looks better to me. In that process (reviewing) if we found all the entities should maintain user login then we can proceed and think of adding user login for all. > Add "changeByUserLoginId" field for CustRequestStatus > - > > Key: OFBIZ-7622 > URL: https://issues.apache.org/jira/browse/OFBIZ-7622 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Julien NICOLAS > Attachments: OFBIZ-7622.patch, OFBIZ-7622.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7622) Add "changeByUserLoginId" field for CustRequestStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372691#comment-15372691 ] Nameet Jain commented on OFBIZ-7622: My main concern to add this task was, as most of the business process / workflow are triggered at status change. So tracking user for the status change makes sense. As it helps to know which business user made changes in related tables also. I don't find the reason to have tracking field on all the tables. Also, it will create additional data. > Add "changeByUserLoginId" field for CustRequestStatus > - > > Key: OFBIZ-7622 > URL: https://issues.apache.org/jira/browse/OFBIZ-7622 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Julien NICOLAS > Attachments: OFBIZ-7622.patch, OFBIZ-7622.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7622) Add "changeByUserLoginId" field for CustRequestStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372622#comment-15372622 ] Pierre Smits commented on OFBIZ-7622: - Thank you for sharing your viewpoint, [~gil portenseigne]. Unfortunately, the documentation regarding the 'audit log system' is far below par for me to be able to tell whether it suffices or not. > Add "changeByUserLoginId" field for CustRequestStatus > - > > Key: OFBIZ-7622 > URL: https://issues.apache.org/jira/browse/OFBIZ-7622 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Julien NICOLAS > Attachments: OFBIZ-7622.patch, OFBIZ-7622.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7622) Add "changeByUserLoginId" field for CustRequestStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372618#comment-15372618 ] Gil Portenseigne commented on OFBIZ-7622: - Adding an option to desactivate logging of status changes (like store.login.history.on.service.auth property) is good for your concern. Being active by default. But i don't see the point to track every change on every table, i think it's a bit to much. The audit log system will suffice to monitor sensible processes in my opinion. > Add "changeByUserLoginId" field for CustRequestStatus > - > > Key: OFBIZ-7622 > URL: https://issues.apache.org/jira/browse/OFBIZ-7622 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Julien NICOLAS > Attachments: OFBIZ-7622.patch, OFBIZ-7622.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7622) Add "changeByUserLoginId" field for CustRequestStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372616#comment-15372616 ] Pierre Smits commented on OFBIZ-7622: - Yes, let us do that. Does that mean that this now needs to be taken back to the dev ml as per suggestion by [~jacques.le.roux] posted in another issue? > Add "changeByUserLoginId" field for CustRequestStatus > - > > Key: OFBIZ-7622 > URL: https://issues.apache.org/jira/browse/OFBIZ-7622 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Julien NICOLAS > Attachments: OFBIZ-7622.patch, OFBIZ-7622.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7622) Add "changeByUserLoginId" field for CustRequestStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372607#comment-15372607 ] Michael Brohl commented on OFBIZ-7622: -- We should take care that this does not happen. It has to be very limited. My suggestion would cover the initial feature request and the general tracking as well of switching it off. Let's see what others think. > Add "changeByUserLoginId" field for CustRequestStatus > - > > Key: OFBIZ-7622 > URL: https://issues.apache.org/jira/browse/OFBIZ-7622 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Julien NICOLAS > Attachments: OFBIZ-7622.patch, OFBIZ-7622.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7622) Add "changeByUserLoginId" field for CustRequestStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372603#comment-15372603 ] Pierre Smits commented on OFBIZ-7622: - It seems to me, that the list of potential variables of that configuration element could and would grow to unmanageable proportions. > Add "changeByUserLoginId" field for CustRequestStatus > - > > Key: OFBIZ-7622 > URL: https://issues.apache.org/jira/browse/OFBIZ-7622 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Julien NICOLAS > Attachments: OFBIZ-7622.patch, OFBIZ-7622.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7622) Add "changeByUserLoginId" field for CustRequestStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372590#comment-15372590 ] Michael Brohl commented on OFBIZ-7622: -- I'd suggest track.user= off | always | status off = no tracking at all always = track for every entity status = only track status entities We may have to think about other cases like status changes and how to handle a change in this configuration, but that's for later (at least for me) > Add "changeByUserLoginId" field for CustRequestStatus > - > > Key: OFBIZ-7622 > URL: https://issues.apache.org/jira/browse/OFBIZ-7622 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Julien NICOLAS > Attachments: OFBIZ-7622.patch, OFBIZ-7622.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7622) Add "changeByUserLoginId" field for CustRequestStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372566#comment-15372566 ] Pierre Smits commented on OFBIZ-7622: - It is not only interesting, but even more to be regarded as acceptable (and unambiguous) ;). > Add "changeByUserLoginId" field for CustRequestStatus > - > > Key: OFBIZ-7622 > URL: https://issues.apache.org/jira/browse/OFBIZ-7622 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Julien NICOLAS > Attachments: OFBIZ-7622.patch, OFBIZ-7622.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7622) Add "changeByUserLoginId" field for CustRequestStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372561#comment-15372561 ] Julien NICOLAS commented on OFBIZ-7622: --- Hi Michael & Pierre, Tracking was already available for the order status. But maybe it could be interesting to define in general.properties a track.user.on.status.change=Y/N that can be manage in the auto-entity process. What do you think ? Julien. > Add "changeByUserLoginId" field for CustRequestStatus > - > > Key: OFBIZ-7622 > URL: https://issues.apache.org/jira/browse/OFBIZ-7622 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Julien NICOLAS > Attachments: OFBIZ-7622.patch, OFBIZ-7622.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7622) Add "changeByUserLoginId" field for CustRequestStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372541#comment-15372541 ] Pierre Smits commented on OFBIZ-7622: - Solving such through configuration is a fairly acceptable solution and works in my book. > Add "changeByUserLoginId" field for CustRequestStatus > - > > Key: OFBIZ-7622 > URL: https://issues.apache.org/jira/browse/OFBIZ-7622 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Julien NICOLAS > Attachments: OFBIZ-7622.patch, OFBIZ-7622.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7622) Add "changeByUserLoginId" field for CustRequestStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372542#comment-15372542 ] Pierre Smits commented on OFBIZ-7622: - Solving such through configuration is a fairly acceptable solution and works in my book. > Add "changeByUserLoginId" field for CustRequestStatus > - > > Key: OFBIZ-7622 > URL: https://issues.apache.org/jira/browse/OFBIZ-7622 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Julien NICOLAS > Attachments: OFBIZ-7622.patch, OFBIZ-7622.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7622) Add "changeByUserLoginId" field for CustRequestStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372538#comment-15372538 ] Michael Brohl commented on OFBIZ-7622: -- Maybe... I am no lawyer and not sure where to draw the line between particular status changes and the overall implementation of user change tracking. We could make in configurable. What do others think? > Add "changeByUserLoginId" field for CustRequestStatus > - > > Key: OFBIZ-7622 > URL: https://issues.apache.org/jira/browse/OFBIZ-7622 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Julien NICOLAS > Attachments: OFBIZ-7622.patch, OFBIZ-7622.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7622) Add "changeByUserLoginId" field for CustRequestStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372530#comment-15372530 ] Pierre Smits commented on OFBIZ-7622: - Is the implemented code change of this sub-task through r1752219 then not already creating the bigger issue (as you brought forward [~mbrohl])? And should we then not revert the changes implemented for this and the other sub-tasks of the parent issue just to be cautious? It might also apply to other countries. > Add "changeByUserLoginId" field for CustRequestStatus > - > > Key: OFBIZ-7622 > URL: https://issues.apache.org/jira/browse/OFBIZ-7622 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Julien NICOLAS > Attachments: OFBIZ-7622.patch, OFBIZ-7622.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7622) Add "changeByUserLoginId" field for CustRequestStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372518#comment-15372518 ] Michael Brohl commented on OFBIZ-7622: -- That could be a problem at least in Germany, where it is a very sensitive subject because you could track when employees changed data and could monitor their working behaviour. I did not deeply think about it, just a short notice to think about before we implement such a feature. > Add "changeByUserLoginId" field for CustRequestStatus > - > > Key: OFBIZ-7622 > URL: https://issues.apache.org/jira/browse/OFBIZ-7622 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Julien NICOLAS > Attachments: OFBIZ-7622.patch, OFBIZ-7622.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7622) Add "changeByUserLoginId" field for CustRequestStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372479#comment-15372479 ] Pierre Smits commented on OFBIZ-7622: - [~julien.nicolas] Isn't it much easier to extend the ModelEntity in ModelEntity.java, with something like 'STAMP_FIELD' and such? And have that applied in GenericDAO.java? Now it seems we have something implements for a set of specific cases. But having a 'changeByUserLoginId on every entity makes sense. Best regards, > Add "changeByUserLoginId" field for CustRequestStatus > - > > Key: OFBIZ-7622 > URL: https://issues.apache.org/jira/browse/OFBIZ-7622 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Julien NICOLAS > Attachments: OFBIZ-7622.patch, OFBIZ-7622.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7622) Add "changeByUserLoginId" field for CustRequestStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372392#comment-15372392 ] Julien NICOLAS commented on OFBIZ-7622: --- For more details, I don't need to use date, and user login because auto-entity manage it automatically. > Add "changeByUserLoginId" field for CustRequestStatus > - > > Key: OFBIZ-7622 > URL: https://issues.apache.org/jira/browse/OFBIZ-7622 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Julien NICOLAS > Attachments: OFBIZ-7622.patch, OFBIZ-7622.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7622) Add "changeByUserLoginId" field for CustRequestStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372388#comment-15372388 ] Julien NICOLAS commented on OFBIZ-7622: --- available on trunk r1752219 > Add "changeByUserLoginId" field for CustRequestStatus > - > > Key: OFBIZ-7622 > URL: https://issues.apache.org/jira/browse/OFBIZ-7622 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Julien NICOLAS > Attachments: OFBIZ-7622.patch, OFBIZ-7622.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7622) Add "changeByUserLoginId" field for CustRequestStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15371705#comment-15371705 ] Julien NICOLAS commented on OFBIZ-7622: --- I use the entity-auto and don't use the minilang anymore. > Add "changeByUserLoginId" field for CustRequestStatus > - > > Key: OFBIZ-7622 > URL: https://issues.apache.org/jira/browse/OFBIZ-7622 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Julien NICOLAS > Attachments: OFBIZ-7622.patch, OFBIZ-7622.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7622) Add "changeByUserLoginId" field for CustRequestStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15371498#comment-15371498 ] Julien NICOLAS commented on OFBIZ-7622: --- I start working on this one > Add "changeByUserLoginId" field for CustRequestStatus > - > > Key: OFBIZ-7622 > URL: https://issues.apache.org/jira/browse/OFBIZ-7622 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Julien NICOLAS > Attachments: OFBIZ-7622.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
