[jira] [Commented] (OFBIZ-7680) Attribute 'value-field' must appear on element 'entity-one'
[ https://issues.apache.org/jira/browse/OFBIZ-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364925#comment-15364925 ] Jacques Le Roux commented on OFBIZ-7680: Should we not rather fix (for those which are used) and get rid of useless parts? Who will misse CompDocTemplateTree.xml for instance? I curious about it! Other opinions? > Attribute 'value-field' must appear on element 'entity-one' > --- > > Key: OFBIZ-7680 > URL: https://issues.apache.org/jira/browse/OFBIZ-7680 > Project: OFBiz > Issue Type: Bug > Components: content, humanres >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Nicolas Malin > > I found these errors > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 25 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 57 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 93 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 125 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. ContentForms.xml > /ofbiz/applications/content/widget/content line 235 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. ContentSetupForms.xml > /ofbiz/applications/content/widget/contentsetup line 217 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. EmploymentAppForms.xml > /ofbiz/applications/humanres/widget/forms line 27 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. PayGradeForms.xml > /ofbiz/applications/humanres/widget/forms line 65 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7680) Attribute 'value-field' must appear on element 'entity-one'
[ https://issues.apache.org/jira/browse/OFBIZ-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364884#comment-15364884 ] Nicolas Malin commented on OFBIZ-7680: -- :) Yes at first time I was going for correct all instantiation error but after this discover I don't know well these form to be sure not introduce a regression. And on second time I found that indicate context on value-field is really explicit when you read the form code ;) > Attribute 'value-field' must appear on element 'entity-one' > --- > > Key: OFBIZ-7680 > URL: https://issues.apache.org/jira/browse/OFBIZ-7680 > Project: OFBiz > Issue Type: Bug > Components: content, humanres >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Nicolas Malin > > I found these errors > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 25 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 57 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 93 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 125 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. ContentForms.xml > /ofbiz/applications/content/widget/content line 235 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. ContentSetupForms.xml > /ofbiz/applications/content/widget/contentsetup line 217 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. EmploymentAppForms.xml > /ofbiz/applications/humanres/widget/forms line 27 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. PayGradeForms.xml > /ofbiz/applications/humanres/widget/forms line 65 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7680) Attribute 'value-field' must appear on element 'entity-one'
[ https://issues.apache.org/jira/browse/OFBIZ-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364499#comment-15364499 ] Jacques Le Roux commented on OFBIZ-7680: Hi Nicolas, This souds like a hack to me, maybe a smart hack but still a hack. This would *maybe* (did not check) fixes the issues locally but would introduce confusion elsewhere. I'd prefer to check the occurrences one and one and see what we should do with them. Surprisingly the issues in CompDocTemplateTree.xml are very old (pre Apache Era) and it seems nobody complained since. I just had a quick look at the CompDocTemplateTree case, I wonder if somebody is really using stuff like https://localhost:8443/content/control/ViewCompDocTemplateTree?rootContentId=CDT1201 I'll try to have a look at the other cases... > Attribute 'value-field' must appear on element 'entity-one' > --- > > Key: OFBIZ-7680 > URL: https://issues.apache.org/jira/browse/OFBIZ-7680 > Project: OFBiz > Issue Type: Bug > Components: content, humanres >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Nicolas Malin > > I found these errors > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 25 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 57 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 93 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 125 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. ContentForms.xml > /ofbiz/applications/content/widget/content line 235 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. ContentSetupForms.xml > /ofbiz/applications/content/widget/contentsetup line 217 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. EmploymentAppForms.xml > /ofbiz/applications/humanres/widget/forms line 27 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. PayGradeForms.xml > /ofbiz/applications/humanres/widget/forms line 65 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7680) Attribute 'value-field' must appear on element 'entity-one'
[ https://issues.apache.org/jira/browse/OFBIZ-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364245#comment-15364245 ] Jacques Le Roux commented on OFBIZ-7680: Totally agreed > Attribute 'value-field' must appear on element 'entity-one' > --- > > Key: OFBIZ-7680 > URL: https://issues.apache.org/jira/browse/OFBIZ-7680 > Project: OFBiz > Issue Type: Bug > Components: content, humanres >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Nicolas Malin > > I found these errors > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 25 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 57 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 93 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 125 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. ContentForms.xml > /ofbiz/applications/content/widget/content line 235 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. ContentSetupForms.xml > /ofbiz/applications/content/widget/contentsetup line 217 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. EmploymentAppForms.xml > /ofbiz/applications/humanres/widget/forms line 27 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. PayGradeForms.xml > /ofbiz/applications/humanres/widget/forms line 65 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7680) Attribute 'value-field' must appear on element 'entity-one'
[
https://issues.apache.org/jira/browse/OFBIZ-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364205#comment-15364205
]
Nicolas Malin commented on OFBIZ-7680:
--
On framework/entity/src/org/ofbiz/entity/finder/PrimaryKeyFinder:90 I found
this (use by AbstractModelAction)
{code}
if (!valueNameAcsr.isEmpty()) {
this.valueNameAcsr.put(context, valueOut);
} else {
if (valueOut != null) {
context.putAll(valueOut);
}
}
{code}
I think we can extend like that
{code}
String originalValueName = this.valueNameAcsr.getOriginalName();
if (originalValueName.isEmpty()) {
originalValueName = "context";
}
if ( !"context".equals(originalValueName)) {
this.valueNameAcsr.put(context, valueOut);
} else {
if (valueOut != null) {
context.putAll(valueOut);
}
}
{code}
And correct Forms file like that
{code}
{code}
To
{code}
{code}
Your remarks?
> Attribute 'value-field' must appear on element 'entity-one'
> ---
>
> Key: OFBIZ-7680
> URL: https://issues.apache.org/jira/browse/OFBIZ-7680
> Project: OFBiz
> Issue Type: Bug
> Components: content, humanres
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>
> I found these errors
> cvc-complex-type.4: Attribute 'value-field' must appear on element
> 'entity-one'. CompDocTemplateTree.xml
> /ofbiz/applications/content/widget/compdoc line 25
> cvc-complex-type.4: Attribute 'value-field' must appear on element
> 'entity-one'. CompDocTemplateTree.xml
> /ofbiz/applications/content/widget/compdoc line 57
> cvc-complex-type.4: Attribute 'value-field' must appear on element
> 'entity-one'. CompDocTemplateTree.xml
> /ofbiz/applications/content/widget/compdoc line 93
> cvc-complex-type.4: Attribute 'value-field' must appear on element
> 'entity-one'. CompDocTemplateTree.xml
> /ofbiz/applications/content/widget/compdoc line 125
> cvc-complex-type.4: Attribute 'value-field' must appear on element
> 'entity-one'. ContentForms.xml
> /ofbiz/applications/content/widget/content line 235
> cvc-complex-type.4: Attribute 'value-field' must appear on element
> 'entity-one'. ContentSetupForms.xml
> /ofbiz/applications/content/widget/contentsetup line 217
> cvc-complex-type.4: Attribute 'value-field' must appear on element
> 'entity-one'. EmploymentAppForms.xml
> /ofbiz/applications/humanres/widget/forms line 27
> cvc-complex-type.4: Attribute 'value-field' must appear on element
> 'entity-one'. PayGradeForms.xml
> /ofbiz/applications/humanres/widget/forms line 65
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7680) Attribute 'value-field' must appear on element 'entity-one'
[ https://issues.apache.org/jira/browse/OFBIZ-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364159#comment-15364159 ] Nicolas Malin commented on OFBIZ-7680: -- negative, value-field is required at any time, it's an error on theses form > Attribute 'value-field' must appear on element 'entity-one' > --- > > Key: OFBIZ-7680 > URL: https://issues.apache.org/jira/browse/OFBIZ-7680 > Project: OFBiz > Issue Type: Bug > Components: content, humanres >Affects Versions: Trunk >Reporter: Jacques Le Roux > > I found these errors > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 25 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 57 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 93 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 125 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. ContentForms.xml > /ofbiz/applications/content/widget/content line 235 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. ContentSetupForms.xml > /ofbiz/applications/content/widget/contentsetup line 217 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. EmploymentAppForms.xml > /ofbiz/applications/humanres/widget/forms line 27 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. PayGradeForms.xml > /ofbiz/applications/humanres/widget/forms line 65 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7680) Attribute 'value-field' must appear on element 'entity-one'
[ https://issues.apache.org/jira/browse/OFBIZ-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15356327#comment-15356327 ] james yong commented on OFBIZ-7680: --- >From the schema, value-field is a required attribute. Modify the schema? > Attribute 'value-field' must appear on element 'entity-one' > --- > > Key: OFBIZ-7680 > URL: https://issues.apache.org/jira/browse/OFBIZ-7680 > Project: OFBiz > Issue Type: Bug > Components: content, humanres >Affects Versions: Trunk >Reporter: Jacques Le Roux > > I found these errors > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 25 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 57 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 93 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 125 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. ContentForms.xml > /ofbiz/applications/content/widget/content line 235 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. ContentSetupForms.xml > /ofbiz/applications/content/widget/contentsetup line 217 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. EmploymentAppForms.xml > /ofbiz/applications/humanres/widget/forms line 27 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. PayGradeForms.xml > /ofbiz/applications/humanres/widget/forms line 65 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
