[jira] [Commented] (OFBIZ-7754) The big problem when load seed.
[ https://issues.apache.org/jira/browse/OFBIZ-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391227#comment-15391227 ] Hans Bakker commented on OFBIZ-7754: if you move these initial property settings to the database is fine with me, As long as you delete the general.properties file, because that file does not do anything anymore because overridden by the database settings... > The big problem when load seed. > --- > > Key: OFBIZ-7754 > URL: https://issues.apache.org/jira/browse/OFBIZ-7754 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Kongrath Suankaewmanee >Assignee: Pierre Smits > Attachments: OFBIZ-7754.patch > > > Hi All, > Regarding, [OFBIZ-7112|https://issues.apache.org/jira/browse/OFBIZ-7112] > That's good for who start on use the ofbiz with initial setup, but not for > the site that already online and has to update the OFBiz core. Because when > has update OFBiz core they will use command load-seed for update. > The problem is if we use load-seed mean the configuration data that's already > exists will be replaced by the data from this file, > *CommonSystemPropertyData.xml* > So, for my suggestion should change the reader from *seed* to *seed-initial* > or remove systemPropertyValue from the data file. > Thank you, > Kongrath -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7754) The big problem when load seed.
[ https://issues.apache.org/jira/browse/OFBIZ-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390583#comment-15390583 ] Pierre Smits commented on OFBIZ-7754: - Thank you for the reminder, [~jacques.le.roux], but I want to see whether [~h.bak...@antwebsystems.com] can find himself in this compromise. I have seen some other SystemPropertyData.xml files that are also loaded at load-seed moment. These should move too. > The big problem when load seed. > --- > > Key: OFBIZ-7754 > URL: https://issues.apache.org/jira/browse/OFBIZ-7754 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Kongrath Suankaewmanee >Assignee: Pierre Smits > Attachments: OFBIZ-7754.patch > > > Hi All, > Regarding, [OFBIZ-7112|https://issues.apache.org/jira/browse/OFBIZ-7112] > That's good for who start on use the ofbiz with initial setup, but not for > the site that already online and has to update the OFBiz core. Because when > has update OFBiz core they will use command load-seed for update. > The problem is if we use load-seed mean the configuration data that's already > exists will be replaced by the data from this file, > *CommonSystemPropertyData.xml* > So, for my suggestion should change the reader from *seed* to *seed-initial* > or remove systemPropertyValue from the data file. > Thank you, > Kongrath -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7754) The big problem when load seed.
[ https://issues.apache.org/jira/browse/OFBIZ-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390132#comment-15390132 ] Jacques Le Roux commented on OFBIZ-7754: Hi Pierre, we are waiting for you here, thanks! > The big problem when load seed. > --- > > Key: OFBIZ-7754 > URL: https://issues.apache.org/jira/browse/OFBIZ-7754 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Kongrath Suankaewmanee >Assignee: Jacques Le Roux > Attachments: OFBIZ-7754.patch > > > Hi All, > Regarding, [OFBIZ-7112|https://issues.apache.org/jira/browse/OFBIZ-7112] > That's good for who start on use the ofbiz with initial setup, but not for > the site that already online and has to update the OFBiz core. Because when > has update OFBiz core they will use command load-seed for update. > The problem is if we use load-seed mean the configuration data that's already > exists will be replaced by the data from this file, > *CommonSystemPropertyData.xml* > So, for my suggestion should change the reader from *seed* to *seed-initial* > or remove systemPropertyValue from the data file. > Thank you, > Kongrath -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7754) The big problem when load seed.
[ https://issues.apache.org/jira/browse/OFBIZ-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378849#comment-15378849 ] Jacques Le Roux commented on OFBIZ-7754: I agree Pierre, that sounds like the best solution, thanks! > The big problem when load seed. > --- > > Key: OFBIZ-7754 > URL: https://issues.apache.org/jira/browse/OFBIZ-7754 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Kongrath Suankaewmanee >Assignee: Jacques Le Roux > Attachments: OFBIZ-7754.patch > > > Hi All, > Regarding, [OFBIZ-7112|https://issues.apache.org/jira/browse/OFBIZ-7112] > That's good for who start on use the ofbiz with initial setup, but not for > the site that already online and has to update the OFBiz core. Because when > has update OFBiz core they will use command load-seed for update. > The problem is if we use load-seed mean the configuration data that's already > exists will be replaced by the data from this file, > *CommonSystemPropertyData.xml* > So, for my suggestion should change the reader from *seed* to *seed-initial* > or remove systemPropertyValue from the data file. > Thank you, > Kongrath -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7754) The big problem when load seed.
[ https://issues.apache.org/jira/browse/OFBIZ-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376540#comment-15376540 ] Pierre Smits commented on OFBIZ-7754: - I don't see problems in changing the reader-name from *seed* to *seed-initial*, but I don't believe we should treat that as an exception for only this scenario. I don't mind if it would be applied to *SystemPropertyData.xml files in all components. If that can achieve consensus, I will work on providing one or more patch files. > The big problem when load seed. > --- > > Key: OFBIZ-7754 > URL: https://issues.apache.org/jira/browse/OFBIZ-7754 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Kongrath Suankaewmanee >Assignee: Jacques Le Roux > Attachments: OFBIZ-7754.patch > > > Hi All, > Regarding, [OFBIZ-7112|https://issues.apache.org/jira/browse/OFBIZ-7112] > That's good for who start on use the ofbiz with initial setup, but not for > the site that already online and has to update the OFBiz core. Because when > has update OFBiz core they will use command load-seed for update. > The problem is if we use load-seed mean the configuration data that's already > exists will be replaced by the data from this file, > *CommonSystemPropertyData.xml* > So, for my suggestion should change the reader from *seed* to *seed-initial* > or remove systemPropertyValue from the data file. > Thank you, > Kongrath -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7754) The big problem when load seed.
[ https://issues.apache.org/jira/browse/OFBIZ-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376506#comment-15376506 ] Hans Bakker commented on OFBIZ-7754: Can only repeat: simply remove the framework/common/data/CommonSystemPropertyData.xml file from ofbiz-component is my suggestion. then the file general.properties is active again. > The big problem when load seed. > --- > > Key: OFBIZ-7754 > URL: https://issues.apache.org/jira/browse/OFBIZ-7754 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Kongrath Suankaewmanee >Assignee: Jacques Le Roux > Attachments: OFBIZ-7754.patch > > > Hi All, > Regarding, [OFBIZ-7112|https://issues.apache.org/jira/browse/OFBIZ-7112] > That's good for who start on use the ofbiz with initial setup, but not for > the site that already online and has to update the OFBiz core. Because when > has update OFBiz core they will use command load-seed for update. > The problem is if we use load-seed mean the configuration data that's already > exists will be replaced by the data from this file, > *CommonSystemPropertyData.xml* > So, for my suggestion should change the reader from *seed* to *seed-initial* > or remove systemPropertyValue from the data file. > Thank you, > Kongrath -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7754) The big problem when load seed.
[ https://issues.apache.org/jira/browse/OFBIZ-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376489#comment-15376489 ] Jacques Le Roux commented on OFBIZ-7754: That's my question to Hans, maybe it was not clear, thanks to repeat it. > The big problem when load seed. > --- > > Key: OFBIZ-7754 > URL: https://issues.apache.org/jira/browse/OFBIZ-7754 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Kongrath Suankaewmanee >Assignee: Jacques Le Roux > Attachments: OFBIZ-7754.patch > > > Hi All, > Regarding, [OFBIZ-7112|https://issues.apache.org/jira/browse/OFBIZ-7112] > That's good for who start on use the ofbiz with initial setup, but not for > the site that already online and has to update the OFBiz core. Because when > has update OFBiz core they will use command load-seed for update. > The problem is if we use load-seed mean the configuration data that's already > exists will be replaced by the data from this file, > *CommonSystemPropertyData.xml* > So, for my suggestion should change the reader from *seed* to *seed-initial* > or remove systemPropertyValue from the data file. > Thank you, > Kongrath -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7754) The big problem when load seed.
[
https://issues.apache.org/jira/browse/OFBIZ-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376461#comment-15376461
]
Pierre Smits commented on OFBIZ-7754:
-
Maybe it is an acceptable solution if Hans would to change the reader-name for
loading CommonSystemPropertyData.xml in the ofbiz-component.xml file within his
setup from: *seed* to *seed-initial*
See:
{code}
{code}
> The big problem when load seed.
> ---
>
> Key: OFBIZ-7754
> URL: https://issues.apache.org/jira/browse/OFBIZ-7754
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Kongrath Suankaewmanee
>Assignee: Jacques Le Roux
> Attachments: OFBIZ-7754.patch
>
>
> Hi All,
> Regarding, [OFBIZ-7112|https://issues.apache.org/jira/browse/OFBIZ-7112]
> That's good for who start on use the ofbiz with initial setup, but not for
> the site that already online and has to update the OFBiz core. Because when
> has update OFBiz core they will use command load-seed for update.
> The problem is if we use load-seed mean the configuration data that's already
> exists will be replaced by the data from this file,
> *CommonSystemPropertyData.xml*
> So, for my suggestion should change the reader from *seed* to *seed-initial*
> or remove systemPropertyValue from the data file.
> Thank you,
> Kongrath
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7754) The big problem when load seed.
[ https://issues.apache.org/jira/browse/OFBIZ-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376443#comment-15376443 ] Jacques Le Roux commented on OFBIZ-7754: Thanks for you feedback Hans. Why do you prefer to disable CommonSystemPropertyData.xml completely over using seed-initial. I ask this because you created CommonSystemPropertyData.xml so maybe I miss something? > The big problem when load seed. > --- > > Key: OFBIZ-7754 > URL: https://issues.apache.org/jira/browse/OFBIZ-7754 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Kongrath Suankaewmanee >Assignee: Jacques Le Roux > Attachments: OFBIZ-7754.patch > > > Hi All, > Regarding, [OFBIZ-7112|https://issues.apache.org/jira/browse/OFBIZ-7112] > That's good for who start on use the ofbiz with initial setup, but not for > the site that already online and has to update the OFBiz core. Because when > has update OFBiz core they will use command load-seed for update. > The problem is if we use load-seed mean the configuration data that's already > exists will be replaced by the data from this file, > *CommonSystemPropertyData.xml* > So, for my suggestion should change the reader from *seed* to *seed-initial* > or remove systemPropertyValue from the data file. > Thank you, > Kongrath -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7754) The big problem when load seed.
[ https://issues.apache.org/jira/browse/OFBIZ-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15370065#comment-15370065 ] Hans Bakker commented on OFBIZ-7754: Looks like my emails about this subject did not come through I am sorry Jacques, it still think this change solves a problem which does not exists. Referring to database settings we do not have in properties files is not justifying it. I was asking for actual examples. Anyway if you people think it is a good idea, i am fine but would like to propose to disable the file framework/common/data/CommonSystemPropertyData.xml completely and just use it as an example how to use systemproperties. So even not use it for initial seed. Then the general.properties gets active again and is not confusing for new users. Regards, Hans > The big problem when load seed. > --- > > Key: OFBIZ-7754 > URL: https://issues.apache.org/jira/browse/OFBIZ-7754 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Kongrath Suankaewmanee >Assignee: Jacques Le Roux > Attachments: OFBIZ-7754.patch > > > Hi All, > Regarding, [OFBIZ-7112|https://issues.apache.org/jira/browse/OFBIZ-7112] > That's good for who start on use the ofbiz with initial setup, but not for > the site that already online and has to update the OFBiz core. Because when > has update OFBiz core they will use command load-seed for update. > The problem is if we use load-seed mean the configuration data that's already > exists will be replaced by the data from this file, > *CommonSystemPropertyData.xml* > So, for my suggestion should change the reader from *seed* to *seed-initial* > or remove systemPropertyValue from the data file. > Thank you, > Kongrath -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7754) The big problem when load seed.
[ https://issues.apache.org/jira/browse/OFBIZ-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369643#comment-15369643 ] Jacques Le Roux commented on OFBIZ-7754: I think Wai has properly and thoroughly answered the business value concern. If nobody adds anything I'll do the change Kongrath suggested in this issue description in few days. This was not an easy thing to spot when I committed for OFBIZ-7112, because the seed aspect was already decided by http://svn.apache.org/viewvc?view=revisionrevision=1238993 and http://svn.apache.org/viewvc?view=revision=1238998 Thanks! > The big problem when load seed. > --- > > Key: OFBIZ-7754 > URL: https://issues.apache.org/jira/browse/OFBIZ-7754 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Kongrath Suankaewmanee >Assignee: Jacques Le Roux > Attachments: OFBIZ-7754.patch > > > Hi All, > Regarding, [OFBIZ-7112|https://issues.apache.org/jira/browse/OFBIZ-7112] > That's good for who start on use the ofbiz with initial setup, but not for > the site that already online and has to update the OFBiz core. Because when > has update OFBiz core they will use command load-seed for update. > The problem is if we use load-seed mean the configuration data that's already > exists will be replaced by the data from this file, > *CommonSystemPropertyData.xml* > So, for my suggestion should change the reader from *seed* to *seed-initial* > or remove systemPropertyValue from the data file. > Thank you, > Kongrath -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7754) The big problem when load seed.
[ https://issues.apache.org/jira/browse/OFBIZ-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15368271#comment-15368271 ] Wai commented on OFBIZ-7754: Seeing this solution from a customer's point of view may seem counter-intuitive. As previously suggested, I think using a separate readerName such as 'seed' and 'seed-initial' for such a file would be a good idea and have it loaded when it is actually required as a separate step. > The big problem when load seed. > --- > > Key: OFBIZ-7754 > URL: https://issues.apache.org/jira/browse/OFBIZ-7754 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Kongrath Suankaewmanee >Assignee: Jacques Le Roux > Attachments: OFBIZ-7754.patch > > > Hi All, > Regarding, [OFBIZ-7112|https://issues.apache.org/jira/browse/OFBIZ-7112] > That's good for who start on use the ofbiz with initial setup, but not for > the site that already online and has to update the OFBiz core. Because when > has update OFBiz core they will use command load-seed for update. > The problem is if we use load-seed mean the configuration data that's already > exists will be replaced by the data from this file, > *CommonSystemPropertyData.xml* > So, for my suggestion should change the reader from *seed* to *seed-initial* > or remove systemPropertyValue from the data file. > Thank you, > Kongrath -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7754) The big problem when load seed.
[ https://issues.apache.org/jira/browse/OFBIZ-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15368242#comment-15368242 ] Wai commented on OFBIZ-7754: A property value can be empty. It is the same as commenting out a property. In such a case, a default value in ofbiz code would be used. "...But is it required? Please give me a number of examples where this is needed. As far as I can see a properties value always has content either Y/N or False/True or a value" >>>A sample case in which an issue would result is if nothing is a valid value for a property. In such a scenario, if the user wants to set the database-based version of the property to nothing, the code would proceed to get a value from the file-based counterpart. Which is not what is desired. "...Further, anybody just starting with the system will try to change the most important properties file 'general.properties' and will see no result" >>>It should be noted that the database-based version of property is a special case. Generally, a user using ofbiz in single tenant mode would be using the file-based properties. In such a situation, the user should not have loaded the database-base version into the database. >>>And if seed data for database-based properties need to be loaded, it should be customized according to the user's requirements. In other words, those properties that are not required should be edited out before seeding. > The big problem when load seed. > --- > > Key: OFBIZ-7754 > URL: https://issues.apache.org/jira/browse/OFBIZ-7754 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Kongrath Suankaewmanee >Assignee: Jacques Le Roux > Attachments: OFBIZ-7754.patch > > > Hi All, > Regarding, [OFBIZ-7112|https://issues.apache.org/jira/browse/OFBIZ-7112] > That's good for who start on use the ofbiz with initial setup, but not for > the site that already online and has to update the OFBiz core. Because when > has update OFBiz core they will use command load-seed for update. > The problem is if we use load-seed mean the configuration data that's already > exists will be replaced by the data from this file, > *CommonSystemPropertyData.xml* > So, for my suggestion should change the reader from *seed* to *seed-initial* > or remove systemPropertyValue from the data file. > Thank you, > Kongrath -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7754) The big problem when load seed.
[
https://issues.apache.org/jira/browse/OFBIZ-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15368022#comment-15368022
]
Wai commented on OFBIZ-7754:
Regarding property values:
A property can have both a value or empty. 'empty' simply means that a property
is commented out or present but contain an empty value. If the value is empty,
then a default value would be that coded in the software.
Ofbiz modes:
I think we need to consider ofbiz in the 1)single tenant mode and 2)
multitenant mode.
In single tenant mode, ofbiz should only be using the properties files. Using
the database to store similar properties would be redundant. If the owner
wished to change the properties, one would just modify the relevant properties
file.
Methods of deployment:
I can think of a few methods of ofbiz deployment.
Deployment#1) owner of ofbiz(in single tenant mode) is also the user
In such a setup. The user would not require a database version of property
files. The owner can simply modify the appropriate files.
Deployment#2) owner of ofbiz(in single tenant mode) is a provider of ofbiz
service to paid users.
In such a setup, multiple instances of ofbiz is run on separate
ports(perhaps in separate virtual machines). Each ofbiz instance is assigned
to a paid user.
Hence, a database equivalent of changeable properties is placed in the
database associated with each paid user. This would allow the owner to simply
modify the property values tailored to each paid user. Based on the previous
comments, it seems the paid user is able to load seed data himself.
Note#1: I believe this is the original intent of why a database version of
properties was created. In such a scenario, if the database property is
missing or contains an empty value for a given paid user, ofbiz would fallback
on the value of the file-based property value.
Note#2: The peculiar interaction between the file-based property and the
database-based property as it was coded (ie. before my patch) is as follows.
The peculiar aspect is useCase#3. why have a database-based property if it is
not going to override the file-based version. Hence, if database-based property
has an empty value then it is meant to be empty (and thus use the hardcoded
default in ofbiz code). As mentioned in the section "Regarding property
values" above. it is possible to have a property that contains an empty value.
it is the same as commenting out the property in the file.
{{monospaced}}
database-based property file-based property result
--- --- --
useCase#1:property1=value1property1=value2use
property1=value1
useCase#2:nil property1=value2use
property1=value2
useCase#3:property1= property1=value2use
property1=value2 (this scenario is strange???)
{{monospaced}}
Deployment#3) owner of ofbiz(in multitenant mode) is a provider of ofbiz
service to paid users.
In such a setup, one instance of ofbiz is serving multiple paid users. Each
paid user accesses his assigned database via the one instance of ofbiz. Each
database would contain it's own property values and the paid user has access
and is responsible for configuring his own property values. The properties
that are available for the paid user to modify is determined by the ofbiz owner.
The interaction between database-based property and file-based property is
as follows. Notice that if a database-entry is present, its value(or lack
thereof) would always override that of the file-based version.
{{
database-based property file-based property result
--- --- --
useCase#1:property1=value1property1=value2use
property1=value1
useCase#2:nil property1=value2use
property1=value2
useCase#3:property1= property1=value2use
property1=
}}
> The big problem when load seed.
> ---
>
> Key: OFBIZ-7754
> URL: https://issues.apache.org/jira/browse/OFBIZ-7754
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Kongrath Suankaewmanee
>Assignee: Jacques Le Roux
> Attachments: OFBIZ-7754.patch
>
>
> Hi All,
> Regarding, [OFBIZ-7112|https://issues.apache.org/jira/browse/OFBIZ-7112]
> That's good for who start on use the ofbiz with initial setup, but not for
> the site that already online and has to update the OFBiz core. Because when
> has update OFBiz core they will use command load-seed for update.
> The problem is if we use load-seed mean the configuration data that's
[jira] [Commented] (OFBIZ-7754) The big problem when load seed.
[ https://issues.apache.org/jira/browse/OFBIZ-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367112#comment-15367112 ] Hans Bakker commented on OFBIZ-7754: here it shows that we always need a business reason for the change. This issue is a nice example that is trying to provide a solution for a technical problem for which i do not see a business reason. > The big problem when load seed. > --- > > Key: OFBIZ-7754 > URL: https://issues.apache.org/jira/browse/OFBIZ-7754 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Kongrath Suankaewmanee >Assignee: Jacques Le Roux > Attachments: OFBIZ-7754.patch > > > Hi All, > Regarding, [OFBIZ-7112|https://issues.apache.org/jira/browse/OFBIZ-7112] > That's good for who start on use the ofbiz with initial setup, but not for > the site that already online and has to update the OFBiz core. Because when > has update OFBiz core they will use command load-seed for update. > The problem is if we use load-seed mean the configuration data that's already > exists will be replaced by the data from this file, > *CommonSystemPropertyData.xml* > So, for my suggestion should change the reader from *seed* to *seed-initial* > or remove systemPropertyValue from the data file. > Thank you, > Kongrath -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7754) The big problem when load seed.
[ https://issues.apache.org/jira/browse/OFBIZ-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15366011#comment-15366011 ] Jacques Le Roux commented on OFBIZ-7754: I have no actual ideas why Wai suggested this patch, but it could be related with tenants. I'll ask him and other interested about that because your smart "NULL-FIELD" solution Arun does not cope with this problematic, nor Hans's alike proposition to "properties file set to blank". > The big problem when load seed. > --- > > Key: OFBIZ-7754 > URL: https://issues.apache.org/jira/browse/OFBIZ-7754 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Kongrath Suankaewmanee >Assignee: Jacques Le Roux > Attachments: OFBIZ-7754.patch > > > Hi All, > Regarding, [OFBIZ-7112|https://issues.apache.org/jira/browse/OFBIZ-7112] > That's good for who start on use the ofbiz with initial setup, but not for > the site that already online and has to update the OFBiz core. Because when > has update OFBiz core they will use command load-seed for update. > The problem is if we use load-seed mean the configuration data that's already > exists will be replaced by the data from this file, > *CommonSystemPropertyData.xml* > So, for my suggestion should change the reader from *seed* to *seed-initial* > or remove systemPropertyValue from the data file. > Thank you, > Kongrath -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7754) The big problem when load seed.
[
https://issues.apache.org/jira/browse/OFBIZ-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15365679#comment-15365679
]
Arun Patidar commented on OFBIZ-7754:
-
Hello [~hansbak]
I agree with you. We can put values in SystemProperty with empty value to keep
a reference of available properties and can override it in future whenever
required from DB directly. Also, if there is empty value in DB, then system
should check in properties file for getting its default value if any.
If user forcefully wants to override value with empty then we can add support
of *'NULL-FIELD'* as we use in xml. For example:
{code}
{code}
> The big problem when load seed.
> ---
>
> Key: OFBIZ-7754
> URL: https://issues.apache.org/jira/browse/OFBIZ-7754
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Kongrath Suankaewmanee
>Assignee: Jacques Le Roux
> Attachments: OFBIZ-7754.patch
>
>
> Hi All,
> Regarding, [OFBIZ-7112|https://issues.apache.org/jira/browse/OFBIZ-7112]
> That's good for who start on use the ofbiz with initial setup, but not for
> the site that already online and has to update the OFBiz core. Because when
> has update OFBiz core they will use command load-seed for update.
> The problem is if we use load-seed mean the configuration data that's already
> exists will be replaced by the data from this file,
> *CommonSystemPropertyData.xml*
> So, for my suggestion should change the reader from *seed* to *seed-initial*
> or remove systemPropertyValue from the data file.
> Thank you,
> Kongrath
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7754) The big problem when load seed.
[ https://issues.apache.org/jira/browse/OFBIZ-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15363576#comment-15363576 ] Hans Bakker commented on OFBIZ-7754: After more thought I would like to question the whole implementation of OFBIZ-7112. As far as i understood it, it was initiated because it was not possible to set a properties value to 'blank' or Empty, sure, accepted that is true. (although set in the properties file set to blank would be a solution?) But is it required? Please give me a number of examples where this is needed. As far as I can see a properties value always has content either Y/N or False/True or a value. Further, anybody just starting with the system will try to change the most important properties file 'general.properties' and will see no result. then as Kongrath (we call him Joe) mentioned an upgrade will be much more difficult if you set your parameters in general.properties or even worse set them in the DB and they get overwritten and sure should not be seed. So my proposal: please revert this change in OFBIZ-7112 it causes far more problems than it solves. > The big problem when load seed. > --- > > Key: OFBIZ-7754 > URL: https://issues.apache.org/jira/browse/OFBIZ-7754 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Kongrath Suankaewmanee >Assignee: Jacques Le Roux > Attachments: OFBIZ-7754.patch > > > Hi All, > Regarding, [OFBIZ-7112|https://issues.apache.org/jira/browse/OFBIZ-7112] > That's good for who start on use the ofbiz with initial setup, but not for > the site that already online and has to update the OFBiz core. Because when > has update OFBiz core they will use command load-seed for update. > The problem is if we use load-seed mean the configuration data that's already > exists will be replaced by the data from this file, > *CommonSystemPropertyData.xml* > So, for my suggestion should change the reader from *seed* to *seed-initial* > or remove systemPropertyValue from the data file. > Thank you, > Kongrath -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7754) The big problem when load seed.
[ https://issues.apache.org/jira/browse/OFBIZ-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15363409#comment-15363409 ] Jacques Le Roux commented on OFBIZ-7754: I agree Kongrath, seed-initial seems the best option > The big problem when load seed. > --- > > Key: OFBIZ-7754 > URL: https://issues.apache.org/jira/browse/OFBIZ-7754 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Kongrath Suankaewmanee >Assignee: Jacques Le Roux > Attachments: OFBIZ-7754.patch > > > Hi All, > Regarding, [OFBIZ-7112|https://issues.apache.org/jira/browse/OFBIZ-7112] > That's good for who start on use the ofbiz with initial setup, but not for > the site that already online and has to update the OFBiz core. Because when > has update OFBiz core they will use command load-seed for update. > The problem is if we use load-seed mean the configuration data that's already > exists will be replaced by the data from this file, > *CommonSystemPropertyData.xml* > So, for my suggestion should change the reader from *seed* to *seed-initial* > or remove systemPropertyValue from the data file. > Thank you, > Kongrath -- This message was sent by Atlassian JIRA (v6.3.4#6332)
