[jira] [Commented] (OFBIZ-7758) jquery.jgrowl.min.css is linked twice in html page
[
https://issues.apache.org/jira/browse/OFBIZ-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385512#comment-15385512
]
Jacques Le Roux commented on OFBIZ-7758:
Hi Rohit, I saw you assigned yourself, something changed?
> jquery.jgrowl.min.css is linked twice in html page
> --
>
> Key: OFBIZ-7758
> URL: https://issues.apache.org/jira/browse/OFBIZ-7758
> Project: OFBiz
> Issue Type: Bug
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: james yong
>Assignee: Rohit Koushal
>Priority: Minor
> Attachments: OFBIZ-7758.patch
>
>
> I am running on trunk rev 1751489 on tomahawk theme.
> In the browser, right-click and view the page source. There is duplicate
> linking of jquery.jgrowl.min.css i.e.
> {code}
> href="/images/jquery/plugins/jquery-jgrowl/1.4.1/jquery.jgrowl.min.css"
> type="text/css"/>
> href="/images/jquery/plugins/jquery-jgrowl/1.4.1/jquery.jgrowl.min.css"
> type="text/css"/>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7758) jquery.jgrowl.min.css is linked twice in html page
[
https://issues.apache.org/jira/browse/OFBIZ-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369645#comment-15369645
]
Jacques Le Roux commented on OFBIZ-7758:
Thanks Rohit, JPublish is already in the Attic
https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Attic#OFBizAttic-JPublish
So yes please go with your solution since it was only a hack for JPublish. I
saw it's also in ModelMenuAction.java
And thanks Amardeep for the link about jrequire.js and .css files. Good to
know, I still did not get a chance to seriously look at jrequire.js :/
> jquery.jgrowl.min.css is linked twice in html page
> --
>
> Key: OFBIZ-7758
> URL: https://issues.apache.org/jira/browse/OFBIZ-7758
> Project: OFBiz
> Issue Type: Bug
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: james yong
>Priority: Minor
> Attachments: OFBIZ-7758.patch
>
>
> I am running on trunk rev 1751489 on tomahawk theme.
> In the browser, right-click and view the page source. There is duplicate
> linking of jquery.jgrowl.min.css i.e.
> {code}
> href="/images/jquery/plugins/jquery-jgrowl/1.4.1/jquery.jgrowl.min.css"
> type="text/css"/>
> href="/images/jquery/plugins/jquery-jgrowl/1.4.1/jquery.jgrowl.min.css"
> type="text/css"/>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7758) jquery.jgrowl.min.css is linked twice in html page
[
https://issues.apache.org/jira/browse/OFBIZ-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367229#comment-15367229
]
Amardeep Singh Jhajj commented on OFBIZ-7758:
-
One more thing I want to add here that, require.js works well for js module
loading. Please refer:
http://requirejs.org/docs/faq-advanced.html#css
and here we are talking about css file. Thanks.
> jquery.jgrowl.min.css is linked twice in html page
> --
>
> Key: OFBIZ-7758
> URL: https://issues.apache.org/jira/browse/OFBIZ-7758
> Project: OFBiz
> Issue Type: Bug
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: james yong
>Priority: Minor
> Attachments: OFBIZ-7758.patch
>
>
> I am running on trunk rev 1751489 on tomahawk theme.
> In the browser, right-click and view the page source. There is duplicate
> linking of jquery.jgrowl.min.css i.e.
> {code}
> href="/images/jquery/plugins/jquery-jgrowl/1.4.1/jquery.jgrowl.min.css"
> type="text/css"/>
> href="/images/jquery/plugins/jquery-jgrowl/1.4.1/jquery.jgrowl.min.css"
> type="text/css"/>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7758) jquery.jgrowl.min.css is linked twice in html page
[
https://issues.apache.org/jira/browse/OFBIZ-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15366210#comment-15366210
]
Jacques Le Roux commented on OFBIZ-7758:
Thanks Rohit, this will certainly help. I did not get a chance yet to seriously
look at what using jrequire.js in OFBiz would mean...
> jquery.jgrowl.min.css is linked twice in html page
> --
>
> Key: OFBIZ-7758
> URL: https://issues.apache.org/jira/browse/OFBIZ-7758
> Project: OFBiz
> Issue Type: Bug
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: james yong
>Priority: Minor
> Attachments: OFBIZ-7758.patch
>
>
> I am running on trunk rev 1751489 on tomahawk theme.
> In the browser, right-click and view the page source. There is duplicate
> linking of jquery.jgrowl.min.css i.e.
> {code}
> href="/images/jquery/plugins/jquery-jgrowl/1.4.1/jquery.jgrowl.min.css"
> type="text/css"/>
> href="/images/jquery/plugins/jquery-jgrowl/1.4.1/jquery.jgrowl.min.css"
> type="text/css"/>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7758) jquery.jgrowl.min.css is linked twice in html page
[
https://issues.apache.org/jira/browse/OFBIZ-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364074#comment-15364074
]
Jacques Le Roux commented on OFBIZ-7758:
I'd take care of it, but I rather want to put require.js in place to handle all
these sorts of things...
> jquery.jgrowl.min.css is linked twice in html page
> --
>
> Key: OFBIZ-7758
> URL: https://issues.apache.org/jira/browse/OFBIZ-7758
> Project: OFBiz
> Issue Type: Bug
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: james yong
>Priority: Minor
>
> I am running on trunk rev 1751489 on tomahawk theme.
> In the browser, right-click and view the page source. There is duplicate
> linking of jquery.jgrowl.min.css i.e.
> {code}
> href="/images/jquery/plugins/jquery-jgrowl/1.4.1/jquery.jgrowl.min.css"
> type="text/css"/>
> href="/images/jquery/plugins/jquery-jgrowl/1.4.1/jquery.jgrowl.min.css"
> type="text/css"/>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
