[jira] [Commented] (OFBIZ-7768) remove gradle-wrapper external library
[ https://issues.apache.org/jira/browse/OFBIZ-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15371298#comment-15371298 ] Jacques Le Roux commented on OFBIZ-7768: To be clear here. We can use gradlew (aka the wrapper) on BuilBot, but since we start anew for each build this means to uselessly download 45 MB each time, so we use a gradle version (currently 2.13) rather. The idea is we will only upgrade it (what the wrapper does automatically) when we will cross issues. Done with INFRA-12235. On the other hand the deamon should not be used on CI servers like BuildBot. See the documentation for details about these 2 important parts of Gradle. > remove gradle-wrapper external library > -- > > Key: OFBIZ-7768 > URL: https://issues.apache.org/jira/browse/OFBIZ-7768 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Jacques Le Roux > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7768) remove gradle-wrapper external library
[ https://issues.apache.org/jira/browse/OFBIZ-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369886#comment-15369886 ] Jacques Le Roux commented on OFBIZ-7768: There is no problems having an external jar (and even more) in the repo. The pb is only when we release. SO I don't see your point, and will close later w/o better arguments or code from you > remove gradle-wrapper external library > -- > > Key: OFBIZ-7768 > URL: https://issues.apache.org/jira/browse/OFBIZ-7768 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Jacques Le Roux > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7768) remove gradle-wrapper external library
[ https://issues.apache.org/jira/browse/OFBIZ-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369579#comment-15369579 ] Jacques Le Roux commented on OFBIZ-7768: Please provide an actionnable plan... > remove gradle-wrapper external library > -- > > Key: OFBIZ-7768 > URL: https://issues.apache.org/jira/browse/OFBIZ-7768 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Jacques Le Roux > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7768) remove gradle-wrapper external library
[ https://issues.apache.org/jira/browse/OFBIZ-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369543#comment-15369543 ] Pierre Smits commented on OFBIZ-7768: - Then I suggest to have scripts included in the code base that download the required external libraries required for the gradle processes. > remove gradle-wrapper external library > -- > > Key: OFBIZ-7768 > URL: https://issues.apache.org/jira/browse/OFBIZ-7768 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Jacques Le Roux > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7768) remove gradle-wrapper external library
[ https://issues.apache.org/jira/browse/OFBIZ-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369539#comment-15369539 ] Jacques Le Roux commented on OFBIZ-7768: If you mean that there should be no external jars at all, the Gradle Wrapper will not be in release, people will have to download it to start from only source files. I guess we will also provide binaries releases... > remove gradle-wrapper external library > -- > > Key: OFBIZ-7768 > URL: https://issues.apache.org/jira/browse/OFBIZ-7768 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Jacques Le Roux > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7768) remove gradle-wrapper external library
[ https://issues.apache.org/jira/browse/OFBIZ-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369534#comment-15369534 ] Jacques Le Roux commented on OFBIZ-7768: Will you want to remove the OS :D? No seriously, we need a bootstrap and what the Gradle project recommends in this case is to use the Gradle Wrapper https://docs.gradle.org/current/userguide/gradle_wrapper.html BTW, about the daemon and why you can't use it on CI servers https://docs.gradle.org/current/userguide/gradle_daemon.html But don't expect me to do all your homework for you ;) > remove gradle-wrapper external library > -- > > Key: OFBIZ-7768 > URL: https://issues.apache.org/jira/browse/OFBIZ-7768 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7768) remove gradle-wrapper external library
[ https://issues.apache.org/jira/browse/OFBIZ-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369531#comment-15369531 ] Pierre Smits commented on OFBIZ-7768: - My plan? I didn't come up with this edict that there may be no external libraries in the code base? The gradle-wrapper jar is also an external library, like the rest the project is removing from the code base. Thus is should be treated the same way regarding loading, etc... > remove gradle-wrapper external library > -- > > Key: OFBIZ-7768 > URL: https://issues.apache.org/jira/browse/OFBIZ-7768 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7768) remove gradle-wrapper external library
[ https://issues.apache.org/jira/browse/OFBIZ-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369528#comment-15369528 ] Jacques Le Roux commented on OFBIZ-7768: Can you explain why and what is your plan? DId you read about it? What it does and why we use it? Else we will close this issue, we need the Gradle wrapper as it's the preferred way to keep in sync with Gradle. On dev machines the deamon is suggested. I can't be used on place like BuildBot, where all start anew, and there indeed we need to manually update Gradle :/ > remove gradle-wrapper external library > -- > > Key: OFBIZ-7768 > URL: https://issues.apache.org/jira/browse/OFBIZ-7768 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
