[jira] [Updated] (OFBIZ-5416) Sales order cart items already assigned to ship groups are incorrectly able to be modified to quantities/prices that break the ProductStoreShipmentMeth rules
[ https://issues.apache.org/jira/browse/OFBIZ-5416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-5416: --- Fix Version/s: 13.07.02 12.04.06 Upcoming Branch R13.07 r1639917 R12.04 r1639918 Sales order cart items already assigned to ship groups are incorrectly able to be modified to quantities/prices that break the ProductStoreShipmentMeth rules - Key: OFBIZ-5416 URL: https://issues.apache.org/jira/browse/OFBIZ-5416 Project: OFBiz Issue Type: Bug Components: order Affects Versions: Trunk Reporter: Christian Carlow Assignee: Ashish Vijaywargiya Fix For: Upcoming Branch, 12.04.06, 13.07.02 Attachments: OFBIZ-5416.patch When modifying sales order cart items that already have been assigned to ship groups, no logic exists to check that the modifications follow the ProductStoreShipmentMeth quantity/price rules of the shipment method. To reproduce: 1. Add a maxTot of 16 to productStoreShipmentMethId=9016 (FEDEX/Ground Home Delivery) on the Catalog-Store-Shipping page 2. Create a sales order for DemoCustCompany 3. Add 1 GZ-1000 to the cart and notice the total is under 16 4. Finalize the cart until reaching the shipping options page 5. Choose the FedEx Home Delivery option and click Continue 6. Click Cart Items to return to the cart page 7. Change the quantity of GZ-1000 to 2 and click Recalculate Order 8. Notice the total price of the cart has exceeded the 16 but the shipment method is still associated with the ship group Logic needs to be added to do something such as remove the shipment methods from ship groups when modifications of associated order items violate their rules. This would cause the shipping options page to reappear for entry of required missing ship group shipment methods when the Finalize button is clicked. Another option would be to keep the shipment method and throw an error when modifications violate ship group rules. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-5416) Sales order cart items already assigned to ship groups are incorrectly able to be modified to quantities/prices that break the ProductStoreShipmentMeth rules
[ https://issues.apache.org/jira/browse/OFBIZ-5416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar updated OFBIZ-5416: Attachment: OFBIZ-5416.patch I was able to regenerate the issue, thanks for the steps. Please find attached patch, I set shipmentMethodTypeId to null whenever cart get recalculate and update so that user have shipping options to select on finalize order. Sales order cart items already assigned to ship groups are incorrectly able to be modified to quantities/prices that break the ProductStoreShipmentMeth rules - Key: OFBIZ-5416 URL: https://issues.apache.org/jira/browse/OFBIZ-5416 Project: OFBiz Issue Type: Bug Components: order Affects Versions: Trunk Reporter: Christian Carlow Attachments: OFBIZ-5416.patch When modifying sales order cart items that already have been assigned to ship groups, no logic exists to check that the modifications follow the ProductStoreShipmentMeth quantity/price rules of the shipment method. To reproduce: 1. Add a maxTot of 16 to productStoreShipmentMethId=9016 (FEDEX/Ground Home Delivery) on the Catalog-Store-Shipping page 2. Create a sales order for DemoCustCompany 3. Add 1 GZ-1000 to the cart and notice the total is under 16 4. Finalize the cart until reaching the shipping options page 5. Choose the FedEx Home Delivery option and click Continue 6. Click Cart Items to return to the cart page 7. Change the quantity of GZ-1000 to 2 and click Recalculate Order 8. Notice the total price of the cart has exceeded the 16 but the shipment method is still associated with the ship group Logic needs to be added to do something such as remove the shipment methods from ship groups when modifications of associated order items violate their rules. This would cause the shipping options page to reappear for entry of required missing ship group shipment methods when the Finalize button is clicked. Another option would be to keep the shipment method and throw an error when modifications violate ship group rules. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-5416) Sales order cart items already assigned to ship groups are incorrectly able to be modified to quantities/prices that break the ProductStoreShipmentMeth rules
[ https://issues.apache.org/jira/browse/OFBIZ-5416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato updated OFBIZ-5416: - Component/s: order Sales order cart items already assigned to ship groups are incorrectly able to be modified to quantities/prices that break the ProductStoreShipmentMeth rules - Key: OFBIZ-5416 URL: https://issues.apache.org/jira/browse/OFBIZ-5416 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Christian Carlow When modifying sales order cart items that already have been assigned to ship groups, no logic exists to check that the modifications follow the ProductStoreShipmentMeth quantity/price rules of the shipment method. To reproduce: 1. Add a maxTot of 16 to productStoreShipmentMethId=9016 (FEDEX/Ground Home Delivery) on the Catalog-Store-Shipping page 2. Create a sales order for DemoCustCompany 3. Add 1 GZ-1000 to the cart and notice the total is under 16 4. Finalize the cart until reaching the shipping options page 5. Choose the FedEx Home Delivery option and click Continue 6. Click Cart Items to return to the cart page 7. Change the quantity of GZ-1000 to 2 and click Recalculate Order 8. Notice the total price of the cart has exceeded the 16 but the shipment method is still associated with the ship group Logic needs to be added to do something such as remove the shipment methods from ship groups when modifications of associated order items violate their rules. This would cause the shipping options page to reappear for entry of required missing ship group shipment methods when the Finalize button is clicked. Another option would be to keep the shipment method and throw an error when modifications violate ship group rules. -- This message was sent by Atlassian JIRA (v6.2#6252)
